Lines Matching +full:lint +full:- +full:cpp
9 * [Setting up your local environment](#setting-up-your-local-environment)
10 * [Step 1: Fork](#step-1-fork)
11 * [Step 2: Branch](#step-2-branch)
12 * [The Process of Making Changes](#the-process-of-making-changes)
13 * [Step 3: Code](#step-3-code)
14 * [Step 4: Commit](#step-4-commit)
15 * [Commit message guidelines](#commit-message-guidelines)
16 * [Step 5: Rebase](#step-5-rebase)
17 * [Step 6: Test](#step-6-test)
18 * [Step 7: Push](#step-7-push)
19 * [Step 8: Opening the Pull Request](#step-8-opening-the-pull-request)
20 * [Step 9: Discuss and Update](#step-9-discuss-and-update)
21 * [Approval and Request Changes Workflow](#approval-and-request-changes-workflow)
22 * [Step 10: Landing](#step-10-landing)
23 * [Reviewing Pull Requests](#reviewing-pull-requests)
24 * [Review a bit at a time](#review-a-bit-at-a-time)
25 * [Be aware of the person behind the code](#be-aware-of-the-person-behind-the-code)
26 * [Respect the minimum wait time for comments](#respect-the-minimum-wait-time-for-comments)
27 * [Abandoned or Stalled Pull Requests](#abandoned-or-stalled-pull-requests)
28 * [Approving a change](#approving-a-change)
29 … opinions about what belongs in Node.js](#accept-that-there-are-different-opinions-about-what-belo…
30 * [Performance is not everything](#performance-is-not-everything)
31 * [Continuous Integration Testing](#continuous-integration-testing)
33 * [Commit Squashing](#commit-squashing)
34 * [Getting Approvals for your Pull Request](#getting-approvals-for-your-pull-request)
35 * [CI Testing](#ci-testing)
36 * [Waiting Until the Pull Request Gets Landed](#waiting-until-the-pull-request-gets-landed)
37 * [Check Out the Collaborator Guide](#check-out-the-collaborator-guide)
48 [project Collaborators](https://github.com/nodejs/node/#current-project-team-members).
51 [OpenJS Foundation Slack](https://slack-invite.openjsf.org/). Interesting
53 [#nodejs](https://openjs-foundation.slack.com/archives/CK9Q4MB53) for general
55 [#nodejs-dev](https://openjs-foundation.slack.com/archives/C019Y2T6STH) for
61 [#node-dev](https://webchat.freenode.net/?channels=node-dev) for development of
71 [IDE configs](https://github.com/nodejs/node-code-ide-configs).
111 $ git checkout -b my-branch -t upstream/master
126 If you are modifying code, please be sure to run `make lint` from time to
130 should follow the [Style Guide](../doc-style-guide.md). Code samples
131 included in the API docs will also be checked when running `make lint` (or
132 `vcbuild.bat lint` on Windows). If you are adding to or deprecating an API,
136 [C++ Style Guide](../cpp-style-guide.md), as well as the
153 notes about [commit squashing](#commit-squashing).
165 imperative verb. Check the output of `git log --oneline files/you/changed` to
181 * `Refs: https://eslint.org/docs/rules/space-in-parens.html`
184 5. If your commit introduces a breaking change (`semver-major`), it should
194 things in more detail. Please word-wrap to keep columns to 72 characters or
198 Refs: https://eslint.org/docs/rules/space-in-parens.html
237 $ ./configure && make -j4 test
255 $ git push origin my-branch
264 <!--
271 -->
274 <!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
276 - [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes
277 - [ ] tests and/or benchmarks are included
278 - [ ] documentation is changed or added
279 - [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/gui…
302 $ git push origin my-branch
309 $ git fetch --all
311 $ git push --force-with-lease origin my-branch
314 **Important:** The `git push --force-with-lease` command is one of the few ways
317 [IRC in the #node-dev channel][].
324 $ git commit --amend
325 $ git push --force-with-lease origin my-branch
349 short amount of time to review and are not ill-intended. Such issues can often
362 [notes about the waiting time](#waiting-until-the-pull-request-gets-landed).
395 It is tempting to micro-optimize and make everything about relative performance,
421 commits or if they proved to be mistaken, please, [hide them][hiding-a-comment]
434 There is a minimum waiting time which we try to respect for non-trivial
438 For non-trivial changes, Pull Requests must be left open for at least 48 hours.
454 address in the commit log, or by using an `Author:` meta-data tag in the
538 specific platforms or for so-called "flaky" tests to fail ("be red"). It is
566 or [the official documentation](https://help.github.com/articles/reviewing-changes-in-pull-requests…
597 [CI (Continuous Integration) test run]: #ci-testing
599 [Collaborator Guide]: ../collaborator-guide.md
600 [IRC in the #node-dev channel]: https://webchat.freenode.net?channels=node-dev&uio=d4
602 [approved]: #getting-approvals-for-your-pull-request
603 [benchmark results]: ../writing-and-running-benchmarks.md
604 [guide for writing tests in Node.js]: ../writing-tests.md
605 [hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment
607 [running tests]: ../../../BUILDING.md#running-tests