1/** 2 * @fileoverview Rule to disallow Math.pow in favor of the ** operator 3 * @author Milos Djermanovic 4 */ 5 6"use strict"; 7 8//------------------------------------------------------------------------------ 9// Requirements 10//------------------------------------------------------------------------------ 11 12const astUtils = require("./utils/ast-utils"); 13const { CALL, ReferenceTracker } = require("eslint-utils"); 14 15//------------------------------------------------------------------------------ 16// Helpers 17//------------------------------------------------------------------------------ 18 19const PRECEDENCE_OF_EXPONENTIATION_EXPR = astUtils.getPrecedence({ type: "BinaryExpression", operator: "**" }); 20 21/** 22 * Determines whether the given node needs parens if used as the base in an exponentiation binary expression. 23 * @param {ASTNode} base The node to check. 24 * @returns {boolean} `true` if the node needs to be parenthesised. 25 */ 26function doesBaseNeedParens(base) { 27 return ( 28 29 // '**' is right-associative, parens are needed when Math.pow(a ** b, c) is converted to (a ** b) ** c 30 astUtils.getPrecedence(base) <= PRECEDENCE_OF_EXPONENTIATION_EXPR || 31 32 // An unary operator cannot be used immediately before an exponentiation expression 33 base.type === "UnaryExpression" 34 ); 35} 36 37/** 38 * Determines whether the given node needs parens if used as the exponent in an exponentiation binary expression. 39 * @param {ASTNode} exponent The node to check. 40 * @returns {boolean} `true` if the node needs to be parenthesised. 41 */ 42function doesExponentNeedParens(exponent) { 43 44 // '**' is right-associative, there is no need for parens when Math.pow(a, b ** c) is converted to a ** b ** c 45 return astUtils.getPrecedence(exponent) < PRECEDENCE_OF_EXPONENTIATION_EXPR; 46} 47 48/** 49 * Determines whether an exponentiation binary expression at the place of the given node would need parens. 50 * @param {ASTNode} node A node that would be replaced by an exponentiation binary expression. 51 * @param {SourceCode} sourceCode A SourceCode object. 52 * @returns {boolean} `true` if the expression needs to be parenthesised. 53 */ 54function doesExponentiationExpressionNeedParens(node, sourceCode) { 55 const parent = node.parent.type === "ChainExpression" ? node.parent.parent : node.parent; 56 57 const needsParens = ( 58 parent.type === "ClassDeclaration" || 59 ( 60 parent.type.endsWith("Expression") && 61 astUtils.getPrecedence(parent) >= PRECEDENCE_OF_EXPONENTIATION_EXPR && 62 !(parent.type === "BinaryExpression" && parent.operator === "**" && parent.right === node) && 63 !((parent.type === "CallExpression" || parent.type === "NewExpression") && parent.arguments.includes(node)) && 64 !(parent.type === "MemberExpression" && parent.computed && parent.property === node) && 65 !(parent.type === "ArrayExpression") 66 ) 67 ); 68 69 return needsParens && !astUtils.isParenthesised(sourceCode, node); 70} 71 72/** 73 * Optionally parenthesizes given text. 74 * @param {string} text The text to parenthesize. 75 * @param {boolean} shouldParenthesize If `true`, the text will be parenthesised. 76 * @returns {string} parenthesised or unchanged text. 77 */ 78function parenthesizeIfShould(text, shouldParenthesize) { 79 return shouldParenthesize ? `(${text})` : text; 80} 81 82//------------------------------------------------------------------------------ 83// Rule Definition 84//------------------------------------------------------------------------------ 85 86module.exports = { 87 meta: { 88 type: "suggestion", 89 90 docs: { 91 description: "disallow the use of `Math.pow` in favor of the `**` operator", 92 category: "Stylistic Issues", 93 recommended: false, 94 url: "https://eslint.org/docs/rules/prefer-exponentiation-operator" 95 }, 96 97 schema: [], 98 fixable: "code", 99 100 messages: { 101 useExponentiation: "Use the '**' operator instead of 'Math.pow'." 102 } 103 }, 104 105 create(context) { 106 const sourceCode = context.getSourceCode(); 107 108 /** 109 * Reports the given node. 110 * @param {ASTNode} node 'Math.pow()' node to report. 111 * @returns {void} 112 */ 113 function report(node) { 114 context.report({ 115 node, 116 messageId: "useExponentiation", 117 fix(fixer) { 118 if ( 119 node.arguments.length !== 2 || 120 node.arguments.some(arg => arg.type === "SpreadElement") || 121 sourceCode.getCommentsInside(node).length > 0 122 ) { 123 return null; 124 } 125 126 const base = node.arguments[0], 127 exponent = node.arguments[1], 128 baseText = sourceCode.getText(base), 129 exponentText = sourceCode.getText(exponent), 130 shouldParenthesizeBase = doesBaseNeedParens(base), 131 shouldParenthesizeExponent = doesExponentNeedParens(exponent), 132 shouldParenthesizeAll = doesExponentiationExpressionNeedParens(node, sourceCode); 133 134 let prefix = "", 135 suffix = ""; 136 137 if (!shouldParenthesizeAll) { 138 if (!shouldParenthesizeBase) { 139 const firstReplacementToken = sourceCode.getFirstToken(base), 140 tokenBefore = sourceCode.getTokenBefore(node); 141 142 if ( 143 tokenBefore && 144 tokenBefore.range[1] === node.range[0] && 145 !astUtils.canTokensBeAdjacent(tokenBefore, firstReplacementToken) 146 ) { 147 prefix = " "; // a+Math.pow(++b, c) -> a+ ++b**c 148 } 149 } 150 if (!shouldParenthesizeExponent) { 151 const lastReplacementToken = sourceCode.getLastToken(exponent), 152 tokenAfter = sourceCode.getTokenAfter(node); 153 154 if ( 155 tokenAfter && 156 node.range[1] === tokenAfter.range[0] && 157 !astUtils.canTokensBeAdjacent(lastReplacementToken, tokenAfter) 158 ) { 159 suffix = " "; // Math.pow(a, b)in c -> a**b in c 160 } 161 } 162 } 163 164 const baseReplacement = parenthesizeIfShould(baseText, shouldParenthesizeBase), 165 exponentReplacement = parenthesizeIfShould(exponentText, shouldParenthesizeExponent), 166 replacement = parenthesizeIfShould(`${baseReplacement}**${exponentReplacement}`, shouldParenthesizeAll); 167 168 return fixer.replaceText(node, `${prefix}${replacement}${suffix}`); 169 } 170 }); 171 } 172 173 return { 174 Program() { 175 const scope = context.getScope(); 176 const tracker = new ReferenceTracker(scope); 177 const trackMap = { 178 Math: { 179 pow: { [CALL]: true } 180 } 181 }; 182 183 for (const { node } of tracker.iterateGlobalReferences(trackMap)) { 184 report(node); 185 } 186 } 187 }; 188 } 189}; 190