1 /*
2 * Copyright 2019 Google Inc.
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8 #include "src/gpu/ops/OpsTask.h"
9
10 #include "include/gpu/GrRecordingContext.h"
11 #include "src/core/SkRectPriv.h"
12 #include "src/core/SkScopeExit.h"
13 #include "src/core/SkTraceEvent.h"
14 #include "src/gpu/GrAttachment.h"
15 #include "src/gpu/GrAuditTrail.h"
16 #include "src/gpu/GrCaps.h"
17 #include "src/gpu/GrGpu.h"
18 #include "src/gpu/GrMemoryPool.h"
19 #include "src/gpu/GrOpFlushState.h"
20 #include "src/gpu/GrOpsRenderPass.h"
21 #include "src/gpu/GrRecordingContextPriv.h"
22 #include "src/gpu/GrRenderTarget.h"
23 #include "src/gpu/GrResourceAllocator.h"
24 #include "src/gpu/GrResourceProvider.h"
25 #include "src/gpu/GrTexture.h"
26 #include "src/gpu/geometry/GrRect.h"
27
28 ////////////////////////////////////////////////////////////////////////////////
29
30 namespace {
31
32 // Experimentally we have found that most combining occurs within the first 10 comparisons.
33 static const int kMaxOpMergeDistance = 10;
34 static const int kMaxOpChainDistance = 10;
35
36 ////////////////////////////////////////////////////////////////////////////////
37
can_reorder(const SkRect & a,const SkRect & b)38 inline bool can_reorder(const SkRect& a, const SkRect& b) { return !GrRectsOverlap(a, b); }
39
create_render_pass(GrGpu * gpu,GrRenderTarget * rt,bool useMSAASurface,GrAttachment * stencil,GrSurfaceOrigin origin,const SkIRect & bounds,GrLoadOp colorLoadOp,const std::array<float,4> & loadClearColor,GrLoadOp stencilLoadOp,GrStoreOp stencilStoreOp,const SkTArray<GrSurfaceProxy *,true> & sampledProxies,GrXferBarrierFlags renderPassXferBarriers)40 GrOpsRenderPass* create_render_pass(GrGpu* gpu,
41 GrRenderTarget* rt,
42 bool useMSAASurface,
43 GrAttachment* stencil,
44 GrSurfaceOrigin origin,
45 const SkIRect& bounds,
46 GrLoadOp colorLoadOp,
47 const std::array<float, 4>& loadClearColor,
48 GrLoadOp stencilLoadOp,
49 GrStoreOp stencilStoreOp,
50 const SkTArray<GrSurfaceProxy*, true>& sampledProxies,
51 GrXferBarrierFlags renderPassXferBarriers) {
52 const GrOpsRenderPass::LoadAndStoreInfo kColorLoadStoreInfo {
53 colorLoadOp,
54 GrStoreOp::kStore,
55 loadClearColor
56 };
57
58 // TODO:
59 // We would like to (at this level) only ever clear & discard. We would need
60 // to stop splitting up higher level OpsTasks for copyOps to achieve that.
61 // Note: we would still need SB loads and stores but they would happen at a
62 // lower level (inside the VK command buffer).
63 const GrOpsRenderPass::StencilLoadAndStoreInfo stencilLoadAndStoreInfo {
64 stencilLoadOp,
65 stencilStoreOp,
66 };
67
68 return gpu->getOpsRenderPass(rt, useMSAASurface, stencil, origin, bounds, kColorLoadStoreInfo,
69 stencilLoadAndStoreInfo, sampledProxies, renderPassXferBarriers);
70 }
71
72 } // anonymous namespace
73
74 ////////////////////////////////////////////////////////////////////////////////
75
76 namespace skgpu::v1 {
77
List(GrOp::Owner op)78 inline OpsTask::OpChain::List::List(GrOp::Owner op)
79 : fHead(std::move(op)), fTail(fHead.get()) {
80 this->validate();
81 }
82
List(List && that)83 inline OpsTask::OpChain::List::List(List&& that) { *this = std::move(that); }
84
operator =(List && that)85 inline OpsTask::OpChain::List& OpsTask::OpChain::List::operator=(List&& that) {
86 fHead = std::move(that.fHead);
87 fTail = that.fTail;
88 that.fTail = nullptr;
89 this->validate();
90 return *this;
91 }
92
popHead()93 inline GrOp::Owner OpsTask::OpChain::List::popHead() {
94 SkASSERT(fHead);
95 auto temp = fHead->cutChain();
96 std::swap(temp, fHead);
97 if (!fHead) {
98 SkASSERT(fTail == temp.get());
99 fTail = nullptr;
100 }
101 return temp;
102 }
103
removeOp(GrOp * op)104 inline GrOp::Owner OpsTask::OpChain::List::removeOp(GrOp* op) {
105 #ifdef SK_DEBUG
106 auto head = op;
107 while (head->prevInChain()) { head = head->prevInChain(); }
108 SkASSERT(head == fHead.get());
109 #endif
110 auto prev = op->prevInChain();
111 if (!prev) {
112 SkASSERT(op == fHead.get());
113 return this->popHead();
114 }
115 auto temp = prev->cutChain();
116 if (auto next = temp->cutChain()) {
117 prev->chainConcat(std::move(next));
118 } else {
119 SkASSERT(fTail == op);
120 fTail = prev;
121 }
122 this->validate();
123 return temp;
124 }
125
pushHead(GrOp::Owner op)126 inline void OpsTask::OpChain::List::pushHead(GrOp::Owner op) {
127 SkASSERT(op);
128 SkASSERT(op->isChainHead());
129 SkASSERT(op->isChainTail());
130 if (fHead) {
131 op->chainConcat(std::move(fHead));
132 fHead = std::move(op);
133 } else {
134 fHead = std::move(op);
135 fTail = fHead.get();
136 }
137 }
138
pushTail(GrOp::Owner op)139 inline void OpsTask::OpChain::List::pushTail(GrOp::Owner op) {
140 SkASSERT(op->isChainTail());
141 fTail->chainConcat(std::move(op));
142 fTail = fTail->nextInChain();
143 }
144
validate() const145 inline void OpsTask::OpChain::List::validate() const {
146 #ifdef SK_DEBUG
147 if (fHead) {
148 SkASSERT(fTail);
149 fHead->validateChain(fTail);
150 }
151 #endif
152 }
153
154 ////////////////////////////////////////////////////////////////////////////////
155
OpChain(GrOp::Owner op,GrProcessorSet::Analysis processorAnalysis,GrAppliedClip * appliedClip,const GrDstProxyView * dstProxyView)156 OpsTask::OpChain::OpChain(GrOp::Owner op, GrProcessorSet::Analysis processorAnalysis,
157 GrAppliedClip* appliedClip, const GrDstProxyView* dstProxyView)
158 : fList{std::move(op)}
159 , fProcessorAnalysis(processorAnalysis)
160 , fAppliedClip(appliedClip) {
161 if (fProcessorAnalysis.requiresDstTexture()) {
162 SkASSERT(dstProxyView && dstProxyView->proxy());
163 fDstProxyView = *dstProxyView;
164 }
165 fBounds = fList.head()->bounds();
166 }
167
visitProxies(const GrVisitProxyFunc & func) const168 void OpsTask::OpChain::visitProxies(const GrVisitProxyFunc& func) const {
169 if (fList.empty()) {
170 return;
171 }
172 for (const auto& op : GrOp::ChainRange<>(fList.head())) {
173 op.visitProxies(func);
174 }
175 if (fDstProxyView.proxy()) {
176 func(fDstProxyView.proxy(), GrMipmapped::kNo);
177 }
178 if (fAppliedClip) {
179 fAppliedClip->visitProxies(func);
180 }
181 }
182
deleteOps()183 void OpsTask::OpChain::deleteOps() {
184 while (!fList.empty()) {
185 // Since the value goes out of scope immediately, the GrOp::Owner deletes the op.
186 fList.popHead();
187 }
188 }
189
190 // Concatenates two op chains and attempts to merge ops across the chains. Assumes that we know that
191 // the two chains are chainable. Returns the new chain.
DoConcat(List chainA,List chainB,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)192 OpsTask::OpChain::List OpsTask::OpChain::DoConcat(List chainA, List chainB, const GrCaps& caps,
193 SkArenaAlloc* opsTaskArena,
194 GrAuditTrail* auditTrail) {
195 // We process ops in chain b from head to tail. We attempt to merge with nodes in a, starting
196 // at chain a's tail and working toward the head. We produce one of the following outcomes:
197 // 1) b's head is merged into an op in a.
198 // 2) An op from chain a is merged into b's head. (In this case b's head gets processed again.)
199 // 3) b's head is popped from chain a and added at the tail of a.
200 // After result 3 we don't want to attempt to merge the next head of b with the new tail of a,
201 // as we assume merges were already attempted when chain b was created. So we keep track of the
202 // original tail of a and start our iteration of a there. We also track the bounds of the nodes
203 // appended to chain a that will be skipped for bounds testing. If the original tail of a is
204 // merged into an op in b (case 2) then we advance the "original tail" towards the head of a.
205 GrOp* origATail = chainA.tail();
206 SkRect skipBounds = SkRectPriv::MakeLargestInverted();
207 do {
208 int numMergeChecks = 0;
209 bool merged = false;
210 bool noSkip = (origATail == chainA.tail());
211 SkASSERT(noSkip == (skipBounds == SkRectPriv::MakeLargestInverted()));
212 bool canBackwardMerge = noSkip || can_reorder(chainB.head()->bounds(), skipBounds);
213 SkRect forwardMergeBounds = skipBounds;
214 GrOp* a = origATail;
215 while (a) {
216 bool canForwardMerge =
217 (a == chainA.tail()) || can_reorder(a->bounds(), forwardMergeBounds);
218 if (canForwardMerge || canBackwardMerge) {
219 auto result = a->combineIfPossible(chainB.head(), opsTaskArena, caps);
220 SkASSERT(result != GrOp::CombineResult::kCannotCombine);
221 merged = (result == GrOp::CombineResult::kMerged);
222 GrOP_INFO("\t\t: (%s opID: %u) -> Combining with (%s, opID: %u)\n",
223 chainB.head()->name(), chainB.head()->uniqueID(), a->name(),
224 a->uniqueID());
225 }
226 if (merged) {
227 GR_AUDIT_TRAIL_OPS_RESULT_COMBINED(auditTrail, a, chainB.head());
228 if (canBackwardMerge) {
229 // The GrOp::Owner releases the op.
230 chainB.popHead();
231 } else {
232 // We merged the contents of b's head into a. We will replace b's head with a in
233 // chain b.
234 SkASSERT(canForwardMerge);
235 if (a == origATail) {
236 origATail = a->prevInChain();
237 }
238 GrOp::Owner detachedA = chainA.removeOp(a);
239 // The GrOp::Owner releases the op.
240 chainB.popHead();
241 chainB.pushHead(std::move(detachedA));
242 if (chainA.empty()) {
243 // We merged all the nodes in chain a to chain b.
244 return chainB;
245 }
246 }
247 break;
248 } else {
249 if (++numMergeChecks == kMaxOpMergeDistance) {
250 break;
251 }
252 forwardMergeBounds.joinNonEmptyArg(a->bounds());
253 canBackwardMerge =
254 canBackwardMerge && can_reorder(chainB.head()->bounds(), a->bounds());
255 a = a->prevInChain();
256 }
257 }
258 // If we weren't able to merge b's head then pop b's head from chain b and make it the new
259 // tail of a.
260 if (!merged) {
261 chainA.pushTail(chainB.popHead());
262 skipBounds.joinNonEmptyArg(chainA.tail()->bounds());
263 }
264 } while (!chainB.empty());
265 return chainA;
266 }
267
268 // Attempts to concatenate the given chain onto our own and merge ops across the chains. Returns
269 // whether the operation succeeded. On success, the provided list will be returned empty.
tryConcat(List * list,GrProcessorSet::Analysis processorAnalysis,const GrDstProxyView & dstProxyView,const GrAppliedClip * appliedClip,const SkRect & bounds,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)270 bool OpsTask::OpChain::tryConcat(
271 List* list, GrProcessorSet::Analysis processorAnalysis, const GrDstProxyView& dstProxyView,
272 const GrAppliedClip* appliedClip, const SkRect& bounds, const GrCaps& caps,
273 SkArenaAlloc* opsTaskArena, GrAuditTrail* auditTrail) {
274 SkASSERT(!fList.empty());
275 SkASSERT(!list->empty());
276 SkASSERT(fProcessorAnalysis.requiresDstTexture() == SkToBool(fDstProxyView.proxy()));
277 SkASSERT(processorAnalysis.requiresDstTexture() == SkToBool(dstProxyView.proxy()));
278 // All returns use explicit tuple constructor rather than {a, b} to work around old GCC bug.
279 if (fList.head()->classID() != list->head()->classID() ||
280 SkToBool(fAppliedClip) != SkToBool(appliedClip) ||
281 (fAppliedClip && *fAppliedClip != *appliedClip) ||
282 (fProcessorAnalysis.requiresNonOverlappingDraws() !=
283 processorAnalysis.requiresNonOverlappingDraws()) ||
284 (fProcessorAnalysis.requiresNonOverlappingDraws() &&
285 // Non-overlaping draws are only required when Ganesh will either insert a barrier,
286 // or read back a new dst texture between draws. In either case, we can neither
287 // chain nor combine overlapping Ops.
288 GrRectsTouchOrOverlap(fBounds, bounds)) ||
289 (fProcessorAnalysis.requiresDstTexture() != processorAnalysis.requiresDstTexture()) ||
290 (fProcessorAnalysis.requiresDstTexture() && fDstProxyView != dstProxyView)) {
291 return false;
292 }
293
294 SkDEBUGCODE(bool first = true;)
295 do {
296 switch (fList.tail()->combineIfPossible(list->head(), opsTaskArena, caps))
297 {
298 case GrOp::CombineResult::kCannotCombine:
299 // If an op supports chaining then it is required that chaining is transitive and
300 // that if any two ops in two different chains can merge then the two chains
301 // may also be chained together. Thus, we should only hit this on the first
302 // iteration.
303 SkASSERT(first);
304 return false;
305 case GrOp::CombineResult::kMayChain:
306 fList = DoConcat(std::move(fList), std::exchange(*list, List()), caps, opsTaskArena,
307 auditTrail);
308 // The above exchange cleared out 'list'. The list needs to be empty now for the
309 // loop to terminate.
310 SkASSERT(list->empty());
311 break;
312 case GrOp::CombineResult::kMerged: {
313 GrOP_INFO("\t\t: (%s opID: %u) -> Combining with (%s, opID: %u)\n",
314 list->tail()->name(), list->tail()->uniqueID(), list->head()->name(),
315 list->head()->uniqueID());
316 GR_AUDIT_TRAIL_OPS_RESULT_COMBINED(auditTrail, fList.tail(), list->head());
317 // The GrOp::Owner releases the op.
318 list->popHead();
319 break;
320 }
321 }
322 SkDEBUGCODE(first = false);
323 } while (!list->empty());
324
325 // The new ops were successfully merged and/or chained onto our own.
326 fBounds.joinPossiblyEmptyRect(bounds);
327 return true;
328 }
329
prependChain(OpChain * that,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)330 bool OpsTask::OpChain::prependChain(OpChain* that, const GrCaps& caps, SkArenaAlloc* opsTaskArena,
331 GrAuditTrail* auditTrail) {
332 if (!that->tryConcat(&fList, fProcessorAnalysis, fDstProxyView, fAppliedClip, fBounds, caps,
333 opsTaskArena, auditTrail)) {
334 this->validate();
335 // append failed
336 return false;
337 }
338
339 // 'that' owns the combined chain. Move it into 'this'.
340 SkASSERT(fList.empty());
341 fList = std::move(that->fList);
342 fBounds = that->fBounds;
343
344 that->fDstProxyView.setProxyView({});
345 if (that->fAppliedClip && that->fAppliedClip->hasCoverageFragmentProcessor()) {
346 // Obliterates the processor.
347 that->fAppliedClip->detachCoverageFragmentProcessor();
348 }
349 this->validate();
350 return true;
351 }
352
appendOp(GrOp::Owner op,GrProcessorSet::Analysis processorAnalysis,const GrDstProxyView * dstProxyView,const GrAppliedClip * appliedClip,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)353 GrOp::Owner OpsTask::OpChain::appendOp(
354 GrOp::Owner op, GrProcessorSet::Analysis processorAnalysis,
355 const GrDstProxyView* dstProxyView, const GrAppliedClip* appliedClip, const GrCaps& caps,
356 SkArenaAlloc* opsTaskArena, GrAuditTrail* auditTrail) {
357 const GrDstProxyView noDstProxyView;
358 if (!dstProxyView) {
359 dstProxyView = &noDstProxyView;
360 }
361 SkASSERT(op->isChainHead() && op->isChainTail());
362 SkRect opBounds = op->bounds();
363 List chain(std::move(op));
364 if (!this->tryConcat(&chain, processorAnalysis, *dstProxyView, appliedClip, opBounds, caps,
365 opsTaskArena, auditTrail)) {
366 // append failed, give the op back to the caller.
367 this->validate();
368 return chain.popHead();
369 }
370
371 SkASSERT(chain.empty());
372 this->validate();
373 return nullptr;
374 }
375
validate() const376 inline void OpsTask::OpChain::validate() const {
377 #ifdef SK_DEBUG
378 fList.validate();
379 for (const auto& op : GrOp::ChainRange<>(fList.head())) {
380 // Not using SkRect::contains because we allow empty rects.
381 SkASSERT(fBounds.fLeft <= op.bounds().fLeft && fBounds.fTop <= op.bounds().fTop &&
382 fBounds.fRight >= op.bounds().fRight && fBounds.fBottom >= op.bounds().fBottom);
383 }
384 #endif
385 }
386
387 ////////////////////////////////////////////////////////////////////////////////
388
OpsTask(GrDrawingManager * drawingMgr,GrSurfaceProxyView view,GrAuditTrail * auditTrail,sk_sp<GrArenas> arenas)389 OpsTask::OpsTask(GrDrawingManager* drawingMgr,
390 GrSurfaceProxyView view,
391 GrAuditTrail* auditTrail,
392 sk_sp<GrArenas> arenas)
393 : GrRenderTask()
394 , fAuditTrail(auditTrail)
395 , fUsesMSAASurface(view.asRenderTargetProxy()->numSamples() > 1)
396 , fTargetSwizzle(view.swizzle())
397 , fTargetOrigin(view.origin())
398 , fArenas{std::move(arenas)}
399 SkDEBUGCODE(, fNumClips(0)) {
400 this->addTarget(drawingMgr, view.detachProxy());
401 }
402
deleteOps()403 void OpsTask::deleteOps() {
404 for (auto& chain : fOpChains) {
405 chain.deleteOps();
406 }
407 fOpChains.reset();
408 }
409
~OpsTask()410 OpsTask::~OpsTask() {
411 this->deleteOps();
412 }
413
addOp(GrDrawingManager * drawingMgr,GrOp::Owner op,GrTextureResolveManager textureResolveManager,const GrCaps & caps)414 void OpsTask::addOp(GrDrawingManager* drawingMgr, GrOp::Owner op,
415 GrTextureResolveManager textureResolveManager, const GrCaps& caps) {
416 auto addDependency = [&](GrSurfaceProxy* p, GrMipmapped mipmapped) {
417 this->addDependency(drawingMgr, p, mipmapped, textureResolveManager, caps);
418 };
419
420 op->visitProxies(addDependency);
421
422 this->recordOp(std::move(op), false/*usesMSAA*/, GrProcessorSet::EmptySetAnalysis(), nullptr,
423 nullptr, caps);
424 }
425
addDrawOp(GrDrawingManager * drawingMgr,GrOp::Owner op,bool usesMSAA,const GrProcessorSet::Analysis & processorAnalysis,GrAppliedClip && clip,const GrDstProxyView & dstProxyView,GrTextureResolveManager textureResolveManager,const GrCaps & caps)426 void OpsTask::addDrawOp(GrDrawingManager* drawingMgr, GrOp::Owner op, bool usesMSAA,
427 const GrProcessorSet::Analysis& processorAnalysis, GrAppliedClip&& clip,
428 const GrDstProxyView& dstProxyView,
429 GrTextureResolveManager textureResolveManager, const GrCaps& caps) {
430 auto addDependency = [&](GrSurfaceProxy* p, GrMipmapped mipmapped) {
431 this->addSampledTexture(p);
432 this->addDependency(drawingMgr, p, mipmapped, textureResolveManager, caps);
433 };
434
435 op->visitProxies(addDependency);
436 clip.visitProxies(addDependency);
437 if (dstProxyView.proxy()) {
438 if (!(dstProxyView.dstSampleFlags() & GrDstSampleFlags::kAsInputAttachment)) {
439 this->addSampledTexture(dstProxyView.proxy());
440 }
441 if (dstProxyView.dstSampleFlags() & GrDstSampleFlags::kRequiresTextureBarrier) {
442 fRenderPassXferBarriers |= GrXferBarrierFlags::kTexture;
443 }
444 addDependency(dstProxyView.proxy(), GrMipmapped::kNo);
445 SkASSERT(!(dstProxyView.dstSampleFlags() & GrDstSampleFlags::kAsInputAttachment) ||
446 dstProxyView.offset().isZero());
447 }
448
449 if (processorAnalysis.usesNonCoherentHWBlending()) {
450 fRenderPassXferBarriers |= GrXferBarrierFlags::kBlend;
451 }
452
453 this->recordOp(std::move(op), usesMSAA, processorAnalysis, clip.doesClip() ? &clip : nullptr,
454 &dstProxyView, caps);
455 }
456
endFlush(GrDrawingManager * drawingMgr)457 void OpsTask::endFlush(GrDrawingManager* drawingMgr) {
458 fLastClipStackGenID = SK_InvalidUniqueID;
459 this->deleteOps();
460
461 fDeferredProxies.reset();
462 fSampledProxies.reset();
463 fAuditTrail = nullptr;
464
465 GrRenderTask::endFlush(drawingMgr);
466 }
467
onPrePrepare(GrRecordingContext * context)468 void OpsTask::onPrePrepare(GrRecordingContext* context) {
469 SkASSERT(this->isClosed());
470 // TODO: remove the check for discard here once reduced op splitting is turned on. Currently we
471 // can end up with OpsTasks that only have a discard load op and no ops. For vulkan validation
472 // we need to keep that discard and not drop it. Once we have reduce op list splitting enabled
473 // we shouldn't end up with OpsTasks with only discard.
474 if (this->isColorNoOp() ||
475 (fClippedContentBounds.isEmpty() && fColorLoadOp != GrLoadOp::kDiscard)) {
476 return;
477 }
478 TRACE_EVENT0("skia.gpu", TRACE_FUNC);
479
480 GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
481 for (const auto& chain : fOpChains) {
482 if (chain.shouldExecute()) {
483 chain.head()->prePrepare(context,
484 dstView,
485 chain.appliedClip(),
486 chain.dstProxyView(),
487 fRenderPassXferBarriers,
488 fColorLoadOp);
489 }
490 }
491 }
492
onPrepare(GrOpFlushState * flushState)493 void OpsTask::onPrepare(GrOpFlushState* flushState) {
494 SkASSERT(this->target(0)->peekRenderTarget());
495 SkASSERT(this->isClosed());
496 // TODO: remove the check for discard here once reduced op splitting is turned on. Currently we
497 // can end up with OpsTasks that only have a discard load op and no ops. For vulkan validation
498 // we need to keep that discard and not drop it. Once we have reduce op list splitting enabled
499 // we shouldn't end up with OpsTasks with only discard.
500 if (this->isColorNoOp() ||
501 (fClippedContentBounds.isEmpty() && fColorLoadOp != GrLoadOp::kDiscard)) {
502 return;
503 }
504 TRACE_EVENT0("skia.gpu", TRACE_FUNC);
505
506 flushState->setSampledProxyArray(&fSampledProxies);
507 GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
508 // Loop over the ops that haven't yet been prepared.
509 for (const auto& chain : fOpChains) {
510 if (chain.shouldExecute()) {
511 #ifdef SK_BUILD_FOR_ANDROID_FRAMEWORK
512 TRACE_EVENT0("skia.gpu", chain.head()->name());
513 #endif
514 GrOpFlushState::OpArgs opArgs(chain.head(),
515 dstView,
516 fUsesMSAASurface,
517 chain.appliedClip(),
518 chain.dstProxyView(),
519 fRenderPassXferBarriers,
520 fColorLoadOp);
521
522 flushState->setOpArgs(&opArgs);
523
524 // Temporary debugging helper: for debugging prePrepare w/o going through DDLs
525 // Delete once most of the GrOps have an onPrePrepare.
526 // chain.head()->prePrepare(flushState->gpu()->getContext(), &this->target(0),
527 // chain.appliedClip());
528
529 // GrOp::prePrepare may or may not have been called at this point
530 chain.head()->prepare(flushState);
531 flushState->setOpArgs(nullptr);
532 }
533 }
534 flushState->setSampledProxyArray(nullptr);
535 }
536
537 // TODO: this is where GrOp::renderTarget is used (which is fine since it
538 // is at flush time). However, we need to store the RenderTargetProxy in the
539 // Ops and instantiate them here.
onExecute(GrOpFlushState * flushState)540 bool OpsTask::onExecute(GrOpFlushState* flushState) {
541 SkASSERT(this->numTargets() == 1);
542 GrRenderTargetProxy* proxy = this->target(0)->asRenderTargetProxy();
543 SkASSERT(proxy);
544 SK_AT_SCOPE_EXIT(proxy->clearArenas());
545
546 // TODO: remove the check for discard here once reduced op splitting is turned on. Currently we
547 // can end up with OpsTasks that only have a discard load op and no ops. For vulkan validation
548 // we need to keep that discard and not drop it. Once we have reduce op list splitting enabled
549 // we shouldn't end up with OpsTasks with only discard.
550 if (this->isColorNoOp() ||
551 (fClippedContentBounds.isEmpty() && fColorLoadOp != GrLoadOp::kDiscard)) {
552 return false;
553 }
554
555 TRACE_EVENT0("skia.gpu", TRACE_FUNC);
556
557 // Make sure load ops are not kClear if the GPU needs to use draws for clears
558 SkASSERT(fColorLoadOp != GrLoadOp::kClear ||
559 !flushState->gpu()->caps()->performColorClearsAsDraws());
560
561 const GrCaps& caps = *flushState->gpu()->caps();
562 GrRenderTarget* renderTarget = proxy->peekRenderTarget();
563 SkASSERT(renderTarget);
564
565 GrAttachment* stencil = nullptr;
566 if (proxy->needsStencil()) {
567 SkASSERT(proxy->canUseStencil(caps));
568 if (!flushState->resourceProvider()->attachStencilAttachment(renderTarget,
569 fUsesMSAASurface)) {
570 SkDebugf("WARNING: failed to attach a stencil buffer. Rendering will be skipped.\n");
571 return false;
572 }
573 stencil = renderTarget->getStencilAttachment(fUsesMSAASurface);
574 }
575
576 GrLoadOp stencilLoadOp;
577 switch (fInitialStencilContent) {
578 case StencilContent::kDontCare:
579 stencilLoadOp = GrLoadOp::kDiscard;
580 break;
581 case StencilContent::kUserBitsCleared:
582 SkASSERT(!caps.performStencilClearsAsDraws());
583 SkASSERT(stencil);
584 if (caps.discardStencilValuesAfterRenderPass()) {
585 // Always clear the stencil if it is being discarded after render passes. This is
586 // also an optimization because we are on a tiler and it avoids loading the values
587 // from memory.
588 stencilLoadOp = GrLoadOp::kClear;
589 break;
590 }
591 if (!stencil->hasPerformedInitialClear()) {
592 stencilLoadOp = GrLoadOp::kClear;
593 stencil->markHasPerformedInitialClear();
594 break;
595 }
596 // SurfaceDrawContexts are required to leave the user stencil bits in a cleared state
597 // once finished, meaning the stencil values will always remain cleared after the
598 // initial clear. Just fall through to reloading the existing (cleared) stencil values
599 // from memory.
600 [[fallthrough]];
601 case StencilContent::kPreserved:
602 SkASSERT(stencil);
603 stencilLoadOp = GrLoadOp::kLoad;
604 break;
605 }
606
607 // NOTE: If fMustPreserveStencil is set, then we are executing a surfaceDrawContext that split
608 // its opsTask.
609 //
610 // FIXME: We don't currently flag render passes that don't use stencil at all. In that case
611 // their store op might be "discard", and we currently make the assumption that a discard will
612 // not invalidate what's already in main memory. This is probably ok for now, but certainly
613 // something we want to address soon.
614 GrStoreOp stencilStoreOp = (caps.discardStencilValuesAfterRenderPass() && !fMustPreserveStencil)
615 ? GrStoreOp::kDiscard
616 : GrStoreOp::kStore;
617
618 GrOpsRenderPass* renderPass = create_render_pass(flushState->gpu(),
619 proxy->peekRenderTarget(),
620 fUsesMSAASurface,
621 stencil,
622 fTargetOrigin,
623 fClippedContentBounds,
624 fColorLoadOp,
625 fLoadClearColor,
626 stencilLoadOp,
627 stencilStoreOp,
628 fSampledProxies,
629 fRenderPassXferBarriers);
630
631 if (!renderPass) {
632 return false;
633 }
634 flushState->setOpsRenderPass(renderPass);
635 renderPass->begin();
636
637 GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
638
639 // Draw all the generated geometry.
640 for (const auto& chain : fOpChains) {
641 if (!chain.shouldExecute()) {
642 continue;
643 }
644 #ifdef SK_BUILD_FOR_ANDROID_FRAMEWORK
645 TRACE_EVENT0("skia.gpu", chain.head()->name());
646 #endif
647
648 GrOpFlushState::OpArgs opArgs(chain.head(),
649 dstView,
650 fUsesMSAASurface,
651 chain.appliedClip(),
652 chain.dstProxyView(),
653 fRenderPassXferBarriers,
654 fColorLoadOp);
655
656 flushState->setOpArgs(&opArgs);
657 chain.head()->execute(flushState, chain.bounds());
658 flushState->setOpArgs(nullptr);
659 }
660
661 renderPass->end();
662 flushState->gpu()->submit(renderPass);
663 flushState->setOpsRenderPass(nullptr);
664
665 return true;
666 }
667
setColorLoadOp(GrLoadOp op,std::array<float,4> color)668 void OpsTask::setColorLoadOp(GrLoadOp op, std::array<float, 4> color) {
669 fColorLoadOp = op;
670 fLoadClearColor = color;
671 if (GrLoadOp::kClear == fColorLoadOp) {
672 GrSurfaceProxy* proxy = this->target(0);
673 SkASSERT(proxy);
674 fTotalBounds = proxy->backingStoreBoundsRect();
675 }
676 }
677
reset()678 void OpsTask::reset() {
679 fDeferredProxies.reset();
680 fSampledProxies.reset();
681 fClippedContentBounds = SkIRect::MakeEmpty();
682 fTotalBounds = SkRect::MakeEmpty();
683 this->deleteOps();
684 fRenderPassXferBarriers = GrXferBarrierFlags::kNone;
685 }
686
canMerge(const OpsTask * opsTask) const687 bool OpsTask::canMerge(const OpsTask* opsTask) const {
688 return this->target(0) == opsTask->target(0) &&
689 fArenas == opsTask->fArenas &&
690 !opsTask->fCannotMergeBackward;
691 }
692
mergeFrom(SkSpan<const sk_sp<GrRenderTask>> tasks)693 int OpsTask::mergeFrom(SkSpan<const sk_sp<GrRenderTask>> tasks) {
694 int mergedCount = 0;
695 for (const sk_sp<GrRenderTask>& task : tasks) {
696 auto opsTask = task->asOpsTask();
697 if (!opsTask || !this->canMerge(opsTask)) {
698 break;
699 }
700 SkASSERT(fTargetSwizzle == opsTask->fTargetSwizzle);
701 SkASSERT(fTargetOrigin == opsTask->fTargetOrigin);
702 if (GrLoadOp::kClear == opsTask->fColorLoadOp) {
703 // TODO(11903): Go back to actually dropping ops tasks when we are merged with
704 // color clear.
705 return 0;
706 }
707 mergedCount += 1;
708 }
709 if (0 == mergedCount) {
710 return 0;
711 }
712
713 SkSpan<const sk_sp<OpsTask>> mergingNodes(
714 reinterpret_cast<const sk_sp<OpsTask>*>(tasks.data()), SkToSizeT(mergedCount));
715 int addlDeferredProxyCount = 0;
716 int addlProxyCount = 0;
717 int addlOpChainCount = 0;
718 for (const auto& toMerge : mergingNodes) {
719 addlDeferredProxyCount += toMerge->fDeferredProxies.count();
720 addlProxyCount += toMerge->fSampledProxies.count();
721 addlOpChainCount += toMerge->fOpChains.count();
722 fClippedContentBounds.join(toMerge->fClippedContentBounds);
723 fTotalBounds.join(toMerge->fTotalBounds);
724 fRenderPassXferBarriers |= toMerge->fRenderPassXferBarriers;
725 if (fInitialStencilContent == StencilContent::kDontCare) {
726 // Propogate the first stencil content that isn't kDontCare.
727 //
728 // Once the stencil has any kind of initial content that isn't kDontCare, then the
729 // inital contents of subsequent opsTasks that get merged in don't matter.
730 //
731 // (This works because the opsTask all target the same render target and are in
732 // painter's order. kPreserved obviously happens automatically with a merge, and kClear
733 // is also automatic because the contract is for ops to leave the stencil buffer in a
734 // cleared state when finished.)
735 fInitialStencilContent = toMerge->fInitialStencilContent;
736 }
737 fUsesMSAASurface |= toMerge->fUsesMSAASurface;
738 SkDEBUGCODE(fNumClips += toMerge->fNumClips);
739 }
740
741 fLastClipStackGenID = SK_InvalidUniqueID;
742 fDeferredProxies.reserve_back(addlDeferredProxyCount);
743 fSampledProxies.reserve_back(addlProxyCount);
744 fOpChains.reserve_back(addlOpChainCount);
745 for (const auto& toMerge : mergingNodes) {
746 for (GrRenderTask* renderTask : toMerge->dependents()) {
747 renderTask->replaceDependency(toMerge.get(), this);
748 }
749 for (GrRenderTask* renderTask : toMerge->dependencies()) {
750 renderTask->replaceDependent(toMerge.get(), this);
751 }
752 fDeferredProxies.move_back_n(toMerge->fDeferredProxies.count(),
753 toMerge->fDeferredProxies.data());
754 fSampledProxies.move_back_n(toMerge->fSampledProxies.count(),
755 toMerge->fSampledProxies.data());
756 fOpChains.move_back_n(toMerge->fOpChains.count(),
757 toMerge->fOpChains.data());
758 toMerge->fDeferredProxies.reset();
759 toMerge->fSampledProxies.reset();
760 toMerge->fOpChains.reset();
761 }
762 fMustPreserveStencil = mergingNodes.back()->fMustPreserveStencil;
763 return mergedCount;
764 }
765
resetForFullscreenClear(CanDiscardPreviousOps canDiscardPreviousOps)766 bool OpsTask::resetForFullscreenClear(CanDiscardPreviousOps canDiscardPreviousOps) {
767 if (CanDiscardPreviousOps::kYes == canDiscardPreviousOps || this->isEmpty()) {
768 this->deleteOps();
769 fDeferredProxies.reset();
770 fSampledProxies.reset();
771
772 // If the opsTask is using a render target which wraps a vulkan command buffer, we can't do
773 // a clear load since we cannot change the render pass that we are using. Thus we fall back
774 // to making a clear op in this case.
775 return !this->target(0)->asRenderTargetProxy()->wrapsVkSecondaryCB();
776 }
777
778 // Could not empty the task, so an op must be added to handle the clear
779 return false;
780 }
781
discard()782 void OpsTask::discard() {
783 // Discard calls to in-progress opsTasks are ignored. Calls at the start update the
784 // opsTasks' color & stencil load ops.
785 if (this->isEmpty()) {
786 fColorLoadOp = GrLoadOp::kDiscard;
787 fInitialStencilContent = StencilContent::kDontCare;
788 fTotalBounds.setEmpty();
789 }
790 }
791
792 ////////////////////////////////////////////////////////////////////////////////
793
794 #if GR_TEST_UTILS
dump(const SkString & label,SkString indent,bool printDependencies,bool close) const795 void OpsTask::dump(const SkString& label,
796 SkString indent,
797 bool printDependencies,
798 bool close) const {
799 GrRenderTask::dump(label, indent, printDependencies, false);
800
801 SkDebugf("%sfColorLoadOp: ", indent.c_str());
802 switch (fColorLoadOp) {
803 case GrLoadOp::kLoad:
804 SkDebugf("kLoad\n");
805 break;
806 case GrLoadOp::kClear:
807 SkDebugf("kClear {%g, %g, %g, %g}\n",
808 fLoadClearColor[0],
809 fLoadClearColor[1],
810 fLoadClearColor[2],
811 fLoadClearColor[3]);
812 break;
813 case GrLoadOp::kDiscard:
814 SkDebugf("kDiscard\n");
815 break;
816 }
817
818 SkDebugf("%sfInitialStencilContent: ", indent.c_str());
819 switch (fInitialStencilContent) {
820 case StencilContent::kDontCare:
821 SkDebugf("kDontCare\n");
822 break;
823 case StencilContent::kUserBitsCleared:
824 SkDebugf("kUserBitsCleared\n");
825 break;
826 case StencilContent::kPreserved:
827 SkDebugf("kPreserved\n");
828 break;
829 }
830
831 SkDebugf("%s%d ops:\n", indent.c_str(), fOpChains.count());
832 for (int i = 0; i < fOpChains.count(); ++i) {
833 SkDebugf("%s*******************************\n", indent.c_str());
834 if (!fOpChains[i].head()) {
835 SkDebugf("%s%d: <combined forward or failed instantiation>\n", indent.c_str(), i);
836 } else {
837 SkDebugf("%s%d: %s\n", indent.c_str(), i, fOpChains[i].head()->name());
838 SkRect bounds = fOpChains[i].bounds();
839 SkDebugf("%sClippedBounds: [L: %.2f, T: %.2f, R: %.2f, B: %.2f]\n",
840 indent.c_str(),
841 bounds.fLeft, bounds.fTop, bounds.fRight, bounds.fBottom);
842 for (const auto& op : GrOp::ChainRange<>(fOpChains[i].head())) {
843 SkString info = SkTabString(op.dumpInfo(), 1);
844 SkDebugf("%s%s\n", indent.c_str(), info.c_str());
845 bounds = op.bounds();
846 SkDebugf("%s\tClippedBounds: [L: %.2f, T: %.2f, R: %.2f, B: %.2f]\n",
847 indent.c_str(),
848 bounds.fLeft, bounds.fTop, bounds.fRight, bounds.fBottom);
849 }
850 }
851 }
852
853 if (close) {
854 SkDebugf("%s--------------------------------------------------------------\n\n",
855 indent.c_str());
856 }
857 }
858 #endif
859
860 #ifdef SK_DEBUG
visitProxies_debugOnly(const GrVisitProxyFunc & func) const861 void OpsTask::visitProxies_debugOnly(const GrVisitProxyFunc& func) const {
862 auto textureFunc = [ func ] (GrSurfaceProxy* tex, GrMipmapped mipmapped) {
863 func(tex, mipmapped);
864 };
865
866 for (const OpChain& chain : fOpChains) {
867 chain.visitProxies(textureFunc);
868 }
869 }
870
871 #endif
872
873 ////////////////////////////////////////////////////////////////////////////////
874
onMakeSkippable()875 void OpsTask::onMakeSkippable() {
876 this->deleteOps();
877 fDeferredProxies.reset();
878 fColorLoadOp = GrLoadOp::kLoad;
879 SkASSERT(this->isColorNoOp());
880 }
881
onIsUsed(GrSurfaceProxy * proxyToCheck) const882 bool OpsTask::onIsUsed(GrSurfaceProxy* proxyToCheck) const {
883 bool used = false;
884 for (GrSurfaceProxy* proxy : fSampledProxies) {
885 if (proxy == proxyToCheck) {
886 used = true;
887 break;
888 }
889 }
890 #ifdef SK_DEBUG
891 bool usedSlow = false;
892 auto visit = [ proxyToCheck, &usedSlow ] (GrSurfaceProxy* p, GrMipmapped) {
893 if (p == proxyToCheck) {
894 usedSlow = true;
895 }
896 };
897 this->visitProxies_debugOnly(visit);
898 SkASSERT(used == usedSlow);
899 #endif
900
901 return used;
902 }
903
gatherProxyIntervals(GrResourceAllocator * alloc) const904 void OpsTask::gatherProxyIntervals(GrResourceAllocator* alloc) const {
905 SkASSERT(this->isClosed());
906 if (this->isColorNoOp()) {
907 return;
908 }
909
910 for (int i = 0; i < fDeferredProxies.count(); ++i) {
911 SkASSERT(!fDeferredProxies[i]->isInstantiated());
912 // We give all the deferred proxies a write usage at the very start of flushing. This
913 // locks them out of being reused for the entire flush until they are read - and then
914 // they can be recycled. This is a bit unfortunate because a flush can proceed in waves
915 // with sub-flushes. The deferred proxies only need to be pinned from the start of
916 // the sub-flush in which they appear.
917 alloc->addInterval(fDeferredProxies[i], 0, 0, GrResourceAllocator::ActualUse::kNo);
918 }
919
920 GrSurfaceProxy* targetProxy = this->target(0);
921
922 // Add the interval for all the writes to this OpsTasks's target
923 if (fOpChains.count()) {
924 unsigned int cur = alloc->curOp();
925
926 alloc->addInterval(targetProxy, cur, cur + fOpChains.count() - 1,
927 GrResourceAllocator::ActualUse::kYes);
928 } else {
929 // This can happen if there is a loadOp (e.g., a clear) but no other draws. In this case we
930 // still need to add an interval for the destination so we create a fake op# for
931 // the missing clear op.
932 alloc->addInterval(targetProxy, alloc->curOp(), alloc->curOp(),
933 GrResourceAllocator::ActualUse::kYes);
934 alloc->incOps();
935 }
936
937 auto gather = [ alloc SkDEBUGCODE(, this) ] (GrSurfaceProxy* p, GrMipmapped) {
938 alloc->addInterval(p,
939 alloc->curOp(),
940 alloc->curOp(),
941 GrResourceAllocator::ActualUse::kYes
942 SkDEBUGCODE(, this->target(0) == p));
943 };
944 // TODO: visitProxies is expensive. Can we do this with fSampledProxies instead?
945 for (const OpChain& recordedOp : fOpChains) {
946 recordedOp.visitProxies(gather);
947
948 // Even though the op may have been (re)moved we still need to increment the op count to
949 // keep all the math consistent.
950 alloc->incOps();
951 }
952 }
953
recordOp(GrOp::Owner op,bool usesMSAA,GrProcessorSet::Analysis processorAnalysis,GrAppliedClip * clip,const GrDstProxyView * dstProxyView,const GrCaps & caps)954 void OpsTask::recordOp(
955 GrOp::Owner op, bool usesMSAA, GrProcessorSet::Analysis processorAnalysis,
956 GrAppliedClip* clip, const GrDstProxyView* dstProxyView, const GrCaps& caps) {
957 GrSurfaceProxy* proxy = this->target(0);
958 #ifdef SK_DEBUG
959 op->validate();
960 SkASSERT(processorAnalysis.requiresDstTexture() == (dstProxyView && dstProxyView->proxy()));
961 SkASSERT(proxy);
962 // A closed OpsTask should never receive new/more ops
963 SkASSERT(!this->isClosed());
964 // Ensure we can support dynamic msaa if the caller is trying to trigger it.
965 if (proxy->asRenderTargetProxy()->numSamples() == 1 && usesMSAA) {
966 SkASSERT(caps.supportsDynamicMSAA(proxy->asRenderTargetProxy()));
967 }
968 #endif
969
970 if (!op->bounds().isFinite()) {
971 return;
972 }
973
974 fUsesMSAASurface |= usesMSAA;
975
976 // Account for this op's bounds before we attempt to combine.
977 // NOTE: The caller should have already called "op->setClippedBounds()" by now, if applicable.
978 fTotalBounds.join(op->bounds());
979
980 // Check if there is an op we can combine with by linearly searching back until we either
981 // 1) check every op
982 // 2) intersect with something
983 // 3) find a 'blocker'
984 GR_AUDIT_TRAIL_ADD_OP(fAuditTrail, op.get(), proxy->uniqueID());
985 GrOP_INFO("opsTask: %d Recording (%s, opID: %u)\n"
986 "\tBounds [L: %.2f, T: %.2f R: %.2f B: %.2f]\n",
987 this->uniqueID(),
988 op->name(),
989 op->uniqueID(),
990 op->bounds().fLeft, op->bounds().fTop,
991 op->bounds().fRight, op->bounds().fBottom);
992 GrOP_INFO(SkTabString(op->dumpInfo(), 1).c_str());
993 GrOP_INFO("\tOutcome:\n");
994 int maxCandidates = std::min(kMaxOpChainDistance, fOpChains.count());
995 if (maxCandidates) {
996 int i = 0;
997 while (true) {
998 OpChain& candidate = fOpChains.fromBack(i);
999 op = candidate.appendOp(std::move(op), processorAnalysis, dstProxyView, clip, caps,
1000 fArenas->arenaAlloc(), fAuditTrail);
1001 if (!op) {
1002 return;
1003 }
1004 // Stop going backwards if we would cause a painter's order violation.
1005 if (!can_reorder(candidate.bounds(), op->bounds())) {
1006 GrOP_INFO("\t\tBackward: Intersects with chain (%s, head opID: %u)\n",
1007 candidate.head()->name(), candidate.head()->uniqueID());
1008 break;
1009 }
1010 if (++i == maxCandidates) {
1011 GrOP_INFO("\t\tBackward: Reached max lookback or beginning of op array %d\n", i);
1012 break;
1013 }
1014 }
1015 } else {
1016 GrOP_INFO("\t\tBackward: FirstOp\n");
1017 }
1018 if (clip) {
1019 clip = fArenas->arenaAlloc()->make<GrAppliedClip>(std::move(*clip));
1020 SkDEBUGCODE(fNumClips++;)
1021 }
1022 fOpChains.emplace_back(std::move(op), processorAnalysis, clip, dstProxyView);
1023 }
1024
forwardCombine(const GrCaps & caps)1025 void OpsTask::forwardCombine(const GrCaps& caps) {
1026 SkASSERT(!this->isClosed());
1027 GrOP_INFO("opsTask: %d ForwardCombine %d ops:\n", this->uniqueID(), fOpChains.count());
1028
1029 for (int i = 0; i < fOpChains.count() - 1; ++i) {
1030 OpChain& chain = fOpChains[i];
1031 int maxCandidateIdx = std::min(i + kMaxOpChainDistance, fOpChains.count() - 1);
1032 int j = i + 1;
1033 while (true) {
1034 OpChain& candidate = fOpChains[j];
1035 if (candidate.prependChain(&chain, caps, fArenas->arenaAlloc(), fAuditTrail)) {
1036 break;
1037 }
1038 // Stop traversing if we would cause a painter's order violation.
1039 if (!can_reorder(chain.bounds(), candidate.bounds())) {
1040 GrOP_INFO(
1041 "\t\t%d: chain (%s head opID: %u) -> "
1042 "Intersects with chain (%s, head opID: %u)\n",
1043 i, chain.head()->name(), chain.head()->uniqueID(), candidate.head()->name(),
1044 candidate.head()->uniqueID());
1045 break;
1046 }
1047 if (++j > maxCandidateIdx) {
1048 GrOP_INFO("\t\t%d: chain (%s opID: %u) -> Reached max lookahead or end of array\n",
1049 i, chain.head()->name(), chain.head()->uniqueID());
1050 break;
1051 }
1052 }
1053 }
1054 }
1055
onMakeClosed(GrRecordingContext * rContext,SkIRect * targetUpdateBounds)1056 GrRenderTask::ExpectedOutcome OpsTask::onMakeClosed(GrRecordingContext* rContext,
1057 SkIRect* targetUpdateBounds) {
1058 this->forwardCombine(*rContext->priv().caps());
1059 if (!this->isColorNoOp()) {
1060 GrSurfaceProxy* proxy = this->target(0);
1061 // Use the entire backing store bounds since the GPU doesn't clip automatically to the
1062 // logical dimensions.
1063 SkRect clippedContentBounds = proxy->backingStoreBoundsRect();
1064 // TODO: If we can fix up GLPrograms test to always intersect the target proxy bounds
1065 // then we can simply assert here that the bounds intersect.
1066 if (clippedContentBounds.intersect(fTotalBounds)) {
1067 clippedContentBounds.roundOut(&fClippedContentBounds);
1068 *targetUpdateBounds = GrNativeRect::MakeIRectRelativeTo(
1069 fTargetOrigin,
1070 this->target(0)->backingStoreDimensions().height(),
1071 fClippedContentBounds);
1072 return ExpectedOutcome::kTargetDirty;
1073 }
1074 }
1075 return ExpectedOutcome::kTargetUnchanged;
1076 }
1077
1078 } // namespace skgpu::v1
1079