Lines Matching full:pull

31   * [reviewing pull requests](#reviewing-pull-requests)
32   * [landing pull requests](#landing-pull-requests)
39   * Always create a branch in your own GitHub fork for pull requests
47   * Make a new branch for each pull request you submit.
81   * Be nice about closing issues! Let people know why, and that issues and pull
87     so that we know what parts of the code base the pull request modifies. It is
89     irrelevant labels from pull requests and issues.
95   * Please add the [`author-ready`][] label for pull requests, if applicable.
113 ## Reviewing pull requests
117   pull request from a new contributor is an opportunity to grow the community.
124   avoid stalling the pull request.
126   * If they are stalling the pull request, fix them yourself on merge.
134   * For non-trivial changes, leave the pull request open for at least 48 hours.
135   * If a pull request is abandoned, check if they'd mind if you took it over
139     a pull request using GitHub’s approval interface
142   * You cannot approve your own pull requests.
150       comments to block the pull request from landing.
165   * You will be using `node-test-pull-request` most of the time. Go there now!
166     * Consider bookmarking it: <https://ci.nodejs.org/job/node-test-pull-request/>
176     * The `PR_ID` box should be filled in with the number identifying the pull
178       the pull request is `https://github.com/nodejs/node/issues/7006`, then put
185 ## Landing pull requests
187 See the Collaborator Guide: [Landing pull requests][].
189 Commits in one pull request that belong to one logical change should
195 ## Exercise: Make a pull request adding yourself to the README
206 * Label your pull request with the `doc`, `notable-change`, and `fast-track`
208   comment in the pull request asking collaborators to approve the pull request
210 * Run CI on the pull request. Use the `node-test-pull-request` CI task.
214   single approval of the onboarding TSC member sufficient, and land the pull
245 [Landing pull requests]: doc/guides/collaborator-guide.md#landing-pull-requests
247 [`author-ready`]: doc/guides/collaborator-guide.md#author-ready-pull-requests