| /third_party/FreeBSD/ |
| D | MAINTAINERS | 4 No locks listed here are valid. The only strict review requirements
38 ath(4) adrian Pre-commit review requested, send to freebsd-wireless@freebsd.org
39 contrib/atf ngie,#test Pre-commit review requested.
40 contrib/capsicum-test ngie,#capsicum,#test Pre-commit review requested.
41 contrib/googletest ngie,#test Pre-commit review requested.
42 contrib/ipfilter cy Pre-commit review requested.
43 contrib/libcxxrt dim,emaste Pre-commit review preferred.
44 contrib/llvm-project/compiler-rt dim Pre-commit review preferred.
45 contrib/llvm-project/libcxx dim Pre-commit review preferred.
46 contrib/llvm-project/libunwind dim,emaste,jhb Pre-commit review preferred.
[all …]
|
| /third_party/skia/site/docs/user/release/ |
| D | release_notes.md | 16 https://review.skia.org/419336
19 https://review.skia.org/419796
22 https://review.skia.org/419836
32 https://review.skia.org/406140
35 https://review.skia.org/402957
38 https://review.skia.org/401816
42 https://review.skia.org/398222
51 https://review.skia.org/402156
59 https://review.skia.org/378496
68 https://review.skia.org/391856
[all …]
|
| /third_party/skia/ |
| D | RELEASE_NOTES.txt | 39 http://review.skia.org/452558
55 https://review.skia.org/432878
59 https://review.skia.org/430897
62 https://review.skia.org/436565
77 https://review.skia.org/444735
84 https://review.skia.org/419336
87 https://review.skia.org/419796
90 https://review.skia.org/419836
100 https://review.skia.org/406140
103 https://review.skia.org/402957
[all …]
|
| /third_party/skia/third_party/externals/angle2/doc/ |
| D | CodeReviewProcess.md | 3 This page describes the review process for ANGLE reviewers and committers. For
4 instructions on submitting your change list for review, please see
12 1. To review a change, you can either navigate directly to the URL for the CL,
14 your dashboard at https://chromium-review.googlesource.com/
27 3. Once your review is complete, click the "Review" button
29 review (Code-Review +1 or +2).
31 comments and a neutral review. (Code-Review 0)
33 review. (Code-Review -1 or -2)
34 * A +2 code review is required before landing. Only ANGLE committers may
35 provide a +2 code review.
[all …]
|
| D | ContributingCode.md | 25 3. Should be a reasonable size to review. Giant patches are unlikely to get reviewed quickly.
61 * Wait for the bots to report the result on the code review page. The bot results should be
122 1. Go to [https://chromium-review.googlesource.com/new-password][CR-passwd]
126 * Visit [https://chromium-review.googlesource.com/#/settings][CR-settings] and check the "Full
131 CL with a particular review, and track dependencies between commits.
133 [https://chromium-review.googlesource.com/tools/hooks/commit-msg][commit-msg-hook] and copy
137 not currently be used with changes intended for review.
139 [CR-passwd]: https://chromium-review.googlesource.com/new-password
140 [CR-settings]: https://chromium-review.googlesource.com/#/settings
141 [commit-msg-hook]: https://chromium-review.googlesource.com/tools/hooks/commit-msg
[all …]
|
| D | Update20131120.md | 6 The review process for contributed code has moved from [Rietveld](https://codereview.appspot.com/)
7 to [Gerrit](https://chromium-review.googlesource.com). This migration allows us to more
|
| /third_party/flutter/skia/third_party/externals/angle2/doc/ |
| D | CodeReviewProcess.md | 3 This page describes the review process for ANGLE reviewers and committers. For
4 instructions on submitting your change list for review, please see
12 1. To review a change, you can either navigate directly to the URL for the CL,
14 your dashboard at https://chromium-review.googlesource.com/
27 3. Once your review is complete, click the "Review" button
29 review (Code-Review +1 or +2).
31 comments and a neutral review. (Code-Review 0)
33 review. (Code-Review -1 or -2)
34 * A +2 code review is required before landing. Only ANGLE committers may
35 provide a +2 code review.
[all …]
|
| D | ContributingCode.md | 14 3. Should be a reasonable size to review. Giant patches are unlikely to get reviewed quickly.
30 …* Wait for the bots to report the result on the code review page. The bot results should be visibl…
56 …1. Go to [https://chromium-review.googlesource.com/new-password](https://chromium-review.googlesou…
60 …* Visit [https://chromium-review.googlesource.com/#/settings](https://chromium-review.googlesource…
63 …D tag to each commit, so that it can associate your CL with a particular review, and track depende…
64 …Download the hook from [https://chromium-review.googlesource.com/tools/hooks/commit-msg](https://c…
65 …it, currently bypass git hooks. They should not currently be used with changes intended for review.
83 [ANGLE Gerrit](https://chromium-review.googlesource.com/q/project:angle/angle).
85 …* Take a moment to perform a self-review of your code. Gerrit's viewer makes it easy to see whites…
86 …#selecting-reviewers). If you don't do this, reviewers may not realize you're requesting a review!
[all …]
|
| D | Update20131120.md | 6 The review process for contributed code has moved from [Rietveld](https://codereview.appspot.com/)
7 to [Gerrit](https://chromium-review.googlesource.com). This migration allows us to more
|
| /third_party/skia/third_party/externals/dawn/docs/ |
| D | contributing.md | 25 Dawn's contributions are submitted and reviewed on [Dawn's Gerrit](https://dawn-review.googlesource…
42 …e remote. To get the `.gitcookies`, log-in to [Dawn's Gerrit](https://dawn-review.googlesource.com)
56 …`/hooks/commit-msg ; mkdir -p $(dirname $f) ; curl -Lo $f https://gerrit-review.googlesource.com/t…
62 ## The code review process
64 All submissions, including submissions by project members, require review.
73 ### Pushing changes to code review
75 Before pushing changes to code review, it is better to run `git cl presubmit`
82 In the terminal you will see a URL where code review for this CL will happen.
83 CLs start in the "Work In Progress" state. To start the code review proper,
84 click on "Start Review", add reviewers and click "Send and start review". If
[all …]
|
| /third_party/flutter/skia/site/dev/contrib/ |
| D | submit.md | 65 review! Submit a patch and getting it reviewed is fairly easy with depot tools.
77 ### Uploading changes for review
79 Skia uses the Gerrit code review tool. Skia's instance is [skia-review](http://skia-review.googleso…
92 (https://skia-review.googlesource.com/c/4559/), indicating where your changelist
99 ask a committer. After uploading your CL to [Gerrit](https://skia-review.googlesource.com/),
116 ### Request review
118 Go to the supplied URL or go to the code review page and select the **Your**
120 review and click **Reply**. Enter at least one reviewer's email address. Now
121 add any optional notes, and send your change off for review by clicking on
125 _Note_: If you don't see editing commands on the review page, click **Sign in**
[all …]
|
| D | index.md | 30 base, you will need a committer to review and approve the change.
31 There are some steps that can speed up the review process:
33 When possible, have a fellow contributor review your change in advance of
|
| /third_party/skia/site/docs/dev/contrib/ |
| D | submit.md | 62 review! Submit a patch and getting it reviewed is fairly easy with depot tools.
80 ### Uploading changes for review
82 Skia uses the Gerrit code review tool. Skia's instance is
83 [skia-review](http://skia-review.googlesource.com). Use `git cl` to upload your
96 (https://skia-review.googlesource.com/c/4559/), indicating where your changelist
104 [Gerrit](https://skia-review.googlesource.com/), you may trigger a try job for
121 ### Request review
123 Go to the supplied URL or go to the code review page and select the **Your**
125 review and click **Reply**. Enter at least one reviewer's email address. Now add
126 any optional notes, and send your change off for review by clicking on **Send**.
[all …]
|
| D | _index.md | 32 base, you will need a committer to review and approve the change. There are some
33 steps that can speed up the review process:
36 - When possible, have a fellow contributor review your change in advance of
|
| /third_party/skia/third_party/externals/dawn/src/dawn_node/ |
| D | README.md | 112 …review.googlesource.com/c/dawn/+/64907/5/src/dawn_node/binding/Converter.cpp#167), [2](https://daw…
113 … aid in debugging. This can be extremely slow. [discussion](https://dawn-review.googlesource.com/c…
114 …d result in a TypeError "Illegal constructor". [discussion](https://dawn-review.googlesource.com/c…
115 …romises". This should return the same promise. [discussion](https://dawn-review.googlesource.com/c…
120 … `src/` for `dawn_node`, but outside for Dawn. [discussion](https://dawn-review.googlesource.com/c…
122 …awn implements the device / adapter creation path properly](https://dawn-review.googlesource.com/c…
|
| /third_party/node/deps/npm/node_modules/npm-audit-report/reporters/ |
| D | detail.js | 55 resolves.forEach(({id, path}) => acc.review.add(`${id}::${path}`))
58 }, {advisories: new Set(), major: new Set(), review: new Set()}) property
66 if (counts.review.size) {
67 const rev = counts.review.size
|
| /third_party/skia/third_party/externals/dawn/ |
| D | codereview.settings | 3 CODE_REVIEW_SERVER: https://dawn-review.googlesource.com
5 TRYSERVER_GERRIT_URL: https://dawn-review.googlesource.com
|
| /third_party/flutter/skia/third_party/externals/angle2/ |
| D | codereview.settings | 2 CODE_REVIEW_SERVER: https://chromium-review.googlesource.com
4 TRYSERVER_GERRIT_URL: https://chromium-review.googlesource.com
|
| /third_party/skia/third_party/externals/angle2/ |
| D | codereview.settings | 2 CODE_REVIEW_SERVER: https://chromium-review.googlesource.com
4 TRYSERVER_GERRIT_URL: https://chromium-review.googlesource.com
|
| /third_party/node/deps/npm/lib/ |
| D | audit.js | 237 action.resolves.forEach(({id, path}) => acc.review.add(`${id}::${path}`))
247 review: new Set() property
276 if (actions.review.size) {
277 …output(` ${actions.review.size} vulnerabilit${actions.review.size === 1 ? 'y' : 'ies'} required m…
|
| /third_party/jerryscript/ |
| D | CONTRIBUTING.md | 6 When development is complete, a patch set should be submitted via GitHub pull requests. A review of…
56 …to preserve the quality of the code and maintain the focus of the Project through intensive review.
61 ### 6. Code review
63 Code review can be performed by all the members of the Project (not just Maintainers and Committers…
69 …uld approve or reject the pull request (note that only Maintainers can give binding review scores).
70 …usiness day) so others can offer feedback. Review times increase with the complexity of the review.
|
| /third_party/skia/third_party/externals/swiftshader/ |
| D | CONTRIBUTING.txt | 12 the CLA until after you've submitted your code for review and a member has
20 All submissions, including submissions by project members, require review.
22 Information on how to sumbit changes for review is provided in README.md.
|
| D | README.md | 53 All changes must be reviewed and approved in the [Gerrit](https://www.gerritcodereview.com/) review…
54 https://swiftshader-review.googlesource.com.
57 https://swiftshader-review.googlesource.com/new-password (use the same e-mail address as the one co…
59 All changes require a [Change-ID](https://gerrit-review.googlesource.com/Documentation/user-changei…
60 https://gerrit-review.googlesource.com/tools/hooks/commit-msg. You can execute `git clone https://s…
70 When ready, [add](https://gerrit-review.googlesource.com/Documentation/intro-user.html#adding-revie…
|
| /third_party/node/ |
| D | glossary.md | 3 * LGTM: "Looks good to me", commonly used to approve a code review.
6 a full code review.
|
| /third_party/flutter/skia/third_party/externals/dawn/ |
| D | CONTRIBUTING.md | 20 All submissions, including submissions by project members, require review. We
21 use [Dawn's Gerrit](https://dawn-review.googlesource.com) for this purpose.
|