• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 
5 #include "gn/builder.h"
6 
7 #include <stddef.h>
8 #include <algorithm>
9 #include <utility>
10 
11 #include "gn/action_values.h"
12 #include "gn/config.h"
13 #include "gn/deps_iterator.h"
14 #include "gn/err.h"
15 #include "gn/loader.h"
16 #include "gn/pool.h"
17 #include "gn/scheduler.h"
18 #include "gn/settings.h"
19 #include "gn/target.h"
20 #include "gn/trace.h"
21 
22 namespace {
23 
24 using BuilderRecordSet = BuilderRecord::BuilderRecordSet;
25 
26 // Recursively looks in the tree for a given node, returning true if it
27 // was found in the dependency graph. This is used to see if a given node
28 // participates in a cycle.
29 //
30 // If this returns true, the cycle will be in *path. This should point to an
31 // empty vector for the first call. During computation, the path will contain
32 // the full dependency path to the current node.
33 //
34 // Return false means no cycle was found.
RecursiveFindCycle(const BuilderRecord * search_in,std::vector<const BuilderRecord * > * path)35 bool RecursiveFindCycle(const BuilderRecord* search_in,
36                         std::vector<const BuilderRecord*>* path) {
37   path->push_back(search_in);
38   for (const auto& cur : search_in->GetSortedUnresolvedDeps()) {
39     std::vector<const BuilderRecord*>::iterator found =
40         std::find(path->begin(), path->end(), cur);
41     if (found != path->end()) {
42       // This item is already in the set, we found the cycle. Everything before
43       // the first definition of cur is irrelevant to the cycle.
44       path->erase(path->begin(), found);
45       path->push_back(cur);
46       return true;
47     }
48 
49     if (RecursiveFindCycle(cur, path))
50       return true;  // Found cycle.
51   }
52   path->pop_back();
53   return false;
54 }
55 
56 }  // namespace
57 
Builder(Loader * loader)58 Builder::Builder(Loader* loader) : loader_(loader) {}
59 
60 Builder::~Builder() = default;
61 
ItemDefined(std::unique_ptr<Item> item)62 void Builder::ItemDefined(std::unique_ptr<Item> item) {
63   ScopedTrace trace(TraceItem::TRACE_DEFINE_TARGET, item->label());
64   trace.SetToolchain(item->settings()->toolchain_label());
65 
66   BuilderRecord::ItemType type = BuilderRecord::TypeOfItem(item.get());
67 
68   Err err;
69   BuilderRecord* record =
70       GetOrCreateRecordOfType(item->label(), item->defined_from(), type, &err);
71   if (!record) {
72     g_scheduler->FailWithError(err);
73     return;
74   }
75 
76   // Check that it's not been already defined.
77   if (record->item()) {
78     bool with_toolchain =
79         item->settings()->ShouldShowToolchain({&item->label()});
80     err =
81         Err(item->defined_from(), "Duplicate definition.",
82             "The item\n  " + item->label().GetUserVisibleName(with_toolchain) +
83                 "\nwas already defined.");
84     err.AppendSubErr(
85         Err(record->item()->defined_from(), "Previous definition:"));
86     g_scheduler->FailWithError(err);
87     return;
88   }
89 
90   record->set_item(std::move(item));
91 
92   // Do target-specific dependency setup. This will also schedule dependency
93   // loads for targets that are required.
94   switch (type) {
95     case BuilderRecord::ITEM_TARGET:
96       TargetDefined(record, &err);
97       break;
98     case BuilderRecord::ITEM_CONFIG:
99       ConfigDefined(record, &err);
100       break;
101     case BuilderRecord::ITEM_TOOLCHAIN:
102       ToolchainDefined(record, &err);
103       break;
104     default:
105       break;
106   }
107   if (err.has_error()) {
108     g_scheduler->FailWithError(err);
109     return;
110   }
111 
112   if (record->can_resolve()) {
113     if (!ResolveItem(record, &err)) {
114       g_scheduler->FailWithError(err);
115       return;
116     }
117   }
118 }
119 
GetItem(const Label & label) const120 const Item* Builder::GetItem(const Label& label) const {
121   const BuilderRecord* record = GetRecord(label);
122   if (!record)
123     return nullptr;
124   return record->item();
125 }
126 
GetToolchain(const Label & label) const127 const Toolchain* Builder::GetToolchain(const Label& label) const {
128   const BuilderRecord* record = GetRecord(label);
129   if (!record)
130     return nullptr;
131   if (!record->item())
132     return nullptr;
133   return record->item()->AsToolchain();
134 }
135 
GetAllRecords() const136 std::vector<const BuilderRecord*> Builder::GetAllRecords() const {
137   std::vector<const BuilderRecord*> result;
138   result.reserve(records_.size());
139   for (const auto& record : records_)
140     result.push_back(&record);
141   // Ensure deterministic outputs.
142   std::sort(result.begin(), result.end(), BuilderRecord::LabelCompare);
143   return result;
144 }
145 
GetAllResolvedItems() const146 std::vector<const Item*> Builder::GetAllResolvedItems() const {
147   std::vector<const Item*> result;
148   result.reserve(records_.size());
149   for (const auto& record : records_) {
150     if (record.type() != BuilderRecord::ITEM_UNKNOWN &&
151         record.should_generate() && record.item()) {
152       result.push_back(record.item());
153     }
154   }
155   // Ensure deterministic outputs.
156   std::sort(result.begin(), result.end(), [](const Item* a, const Item* b) {
157     return a->label() < b->label();
158   });
159   return result;
160 }
161 
GetAllResolvedTargets() const162 std::vector<const Target*> Builder::GetAllResolvedTargets() const {
163   std::vector<const Target*> result;
164   result.reserve(records_.size());
165   for (const auto& record : records_) {
166     if (record.type() == BuilderRecord::ITEM_TARGET &&
167         record.should_generate() && record.item())
168       result.push_back(record.item()->AsTarget());
169   }
170   // Ensure deterministic outputs.
171   std::sort(result.begin(), result.end(), [](const Target* a, const Target* b) {
172     return a->label() < b->label();
173   });
174   return result;
175 }
176 
GetRecord(const Label & label) const177 const BuilderRecord* Builder::GetRecord(const Label& label) const {
178   // Forward to the non-const version.
179   return const_cast<Builder*>(this)->GetRecord(label);
180 }
181 
GetRecord(const Label & label)182 BuilderRecord* Builder::GetRecord(const Label& label) {
183   return records_.find(label);
184 }
185 
CheckForBadItems(Err * err) const186 bool Builder::CheckForBadItems(Err* err) const {
187   // Look for errors where we find a defined node with an item that refers to
188   // an undefined one with no item. There may be other nodes in turn depending
189   // on our defined one, but listing those isn't helpful: we want to find the
190   // broken link.
191   //
192   // This finds normal "missing dependency" errors but does not find circular
193   // dependencies because in this case all items in the cycle will be GENERATED
194   // but none will be resolved. If this happens, we'll check explicitly for
195   // that below.
196   std::vector<const BuilderRecord*> bad_records;
197   for (const auto& src : records_) {
198     if (!src.should_generate())
199       continue;  // Skip ungenerated nodes.
200 
201     if (!src.resolved())
202       bad_records.push_back(&src);
203   }
204   if (bad_records.empty())
205     return true;
206 
207   // Sort by label to ensure deterministic outputs.
208   std::sort(bad_records.begin(), bad_records.end(),
209             BuilderRecord::LabelCompare);
210 
211   std::string depstring;
212   for (const auto& src : bad_records) {
213     // Check dependencies.
214     for (const auto* dest : src->GetSortedUnresolvedDeps()) {
215       if (!dest->item()) {
216         depstring += src->label().GetUserVisibleName(true) + "\n  needs " +
217                      dest->label().GetUserVisibleName(true) + "\n";
218       }
219     }
220   }
221 
222   if (!depstring.empty()) {
223     *err = Err(Location(), "Unresolved dependencies.", depstring);
224     return false;
225   }
226 
227   if (!bad_records.empty()) {
228     // Our logic above found a bad node but didn't identify the problem. This
229     // normally means a circular dependency.
230     depstring = CheckForCircularDependencies(bad_records);
231     if (depstring.empty()) {
232       // Something's very wrong, just dump out the bad nodes.
233       depstring =
234           "I have no idea what went wrong, but these are unresolved, "
235           "possibly due to an\ninternal error:";
236       for (auto* bad_record : bad_records) {
237         depstring +=
238             "\n\"" + bad_record->label().GetUserVisibleName(true) + "\"";
239       }
240       *err = Err(Location(), "", depstring);
241     } else {
242       *err = Err(Location(), "Dependency cycle:", depstring);
243     }
244     return false;
245   }
246 
247   return true;
248 }
249 
TargetDefined(BuilderRecord * record,Err * err)250 bool Builder::TargetDefined(BuilderRecord* record, Err* err) {
251   Target* target = record->item()->AsTarget();
252 
253   if (!AddDeps(record, target->public_deps(), err) ||
254       !AddDeps(record, target->private_deps(), err) ||
255       !AddDeps(record, target->data_deps(), err) ||
256       !AddDeps(record, target->configs().vector(), err) ||
257       !AddDeps(record, target->all_dependent_configs(), err) ||
258       !AddDeps(record, target->public_configs(), err) ||
259       !AddDeps(record, target->own_configs().vector(), err) ||
260       !AddDeps(record, target->own_all_dependent_configs(), err) ||
261       !AddDeps(record, target->own_public_configs(), err) ||
262       !AddGenDeps(record, target->gen_deps(), err) ||
263       !AddPoolDep(record, target, err) || !AddToolchainDep(record, target, err))
264     return false;
265 
266   // All targets in the default toolchain get generated by default. We also
267   // check if this target was previously marked as "required" and force setting
268   // the bit again so the target's dependencies (which we now know) get the
269   // required bit pushed to them.
270   if (record->should_generate() || target->ShouldGenerate())
271     RecursiveSetShouldGenerate(record, true);
272 
273   return true;
274 }
275 
ConfigDefined(BuilderRecord * record,Err * err)276 bool Builder::ConfigDefined(BuilderRecord* record, Err* err) {
277   Config* config = record->item()->AsConfig();
278   if (!AddDeps(record, config->configs(), err))
279     return false;
280 
281   // Make sure all deps of this config are scheduled to be loaded. For other
282   // item types like targets, the "should generate" flag is propagated around
283   // to mark whether this should happen. We could call
284   // RecursiveSetShouldGenerate to do this step here, but since configs nor
285   // anything they depend on is actually written, the "generate" flag isn't
286   // relevant and means extra book keeping. Just force load any deps of this
287   // config.
288   for (auto it = record->all_deps().begin(); it.valid(); ++it) {
289     ScheduleItemLoadIfNecessary(*it);
290   }
291 
292   return true;
293 }
294 
ToolchainDefined(BuilderRecord * record,Err * err)295 bool Builder::ToolchainDefined(BuilderRecord* record, Err* err) {
296   Toolchain* toolchain = record->item()->AsToolchain();
297 
298   if (!AddDeps(record, toolchain->deps(), err))
299     return false;
300 
301   for (const auto& tool : toolchain->tools()) {
302     if (tool.second->pool().label.is_null())
303       continue;
304 
305     BuilderRecord* dep_record = GetOrCreateRecordOfType(
306         tool.second->pool().label, tool.second->pool().origin,
307         BuilderRecord::ITEM_POOL, err);
308     if (!dep_record)
309       return false;
310     record->AddDep(dep_record);
311   }
312 
313   // The default toolchain gets generated by default. Also propagate the
314   // generate flag if it depends on items in a non-default toolchain.
315   if (record->should_generate() ||
316       toolchain->settings()->default_toolchain_label() == toolchain->label())
317     RecursiveSetShouldGenerate(record, true);
318 
319   loader_->ToolchainLoaded(toolchain);
320   return true;
321 }
322 
GetOrCreateRecordForTesting(const Label & label)323 BuilderRecord* Builder::GetOrCreateRecordForTesting(const Label& label) {
324   Err err;
325   return GetOrCreateRecordOfType(label, nullptr, BuilderRecord::ITEM_UNKNOWN,
326                                  &err);
327 }
328 
GetOrCreateRecordOfType(const Label & label,const ParseNode * request_from,BuilderRecord::ItemType type,Err * err)329 BuilderRecord* Builder::GetOrCreateRecordOfType(const Label& label,
330                                                 const ParseNode* request_from,
331                                                 BuilderRecord::ItemType type,
332                                                 Err* err) {
333   auto pair = records_.try_emplace(label, request_from, type);
334   BuilderRecord* record = pair.second;
335 
336   // Check types, if the record was not just created.
337   if (!pair.first && record->type() != type) {
338     std::string msg =
339         "The type of " + label.GetUserVisibleName(true) + "\nhere is a " +
340         BuilderRecord::GetNameForType(type) + " but was previously seen as a " +
341         BuilderRecord::GetNameForType(record->type()) +
342         ".\n\n"
343         "The most common cause is that the label of a config was put in the\n"
344         "in the deps section of a target (or vice-versa).";
345     *err = Err(request_from, "Item type does not match.", msg);
346     if (record->originally_referenced_from()) {
347       err->AppendSubErr(
348           Err(record->originally_referenced_from(), std::string()));
349     }
350     return nullptr;
351   }
352 
353   return record;
354 }
355 
GetResolvedRecordOfType(const Label & label,const ParseNode * origin,BuilderRecord::ItemType type,Err * err)356 BuilderRecord* Builder::GetResolvedRecordOfType(const Label& label,
357                                                 const ParseNode* origin,
358                                                 BuilderRecord::ItemType type,
359                                                 Err* err) {
360   BuilderRecord* record = GetRecord(label);
361   if (!record) {
362     *err = Err(origin, "Item not found",
363                "\"" + label.GetUserVisibleName(true) +
364                    "\" doesn't\n"
365                    "refer to an existent thing.");
366     return nullptr;
367   }
368 
369   const Item* item = record->item();
370   if (!item) {
371     *err = Err(
372         origin, "Item not resolved.",
373         "\"" + label.GetUserVisibleName(true) + "\" hasn't been resolved.\n");
374     return nullptr;
375   }
376 
377   if (!BuilderRecord::IsItemOfType(item, type)) {
378     *err =
379         Err(origin,
380             std::string("This is not a ") + BuilderRecord::GetNameForType(type),
381             "\"" + label.GetUserVisibleName(true) + "\" refers to a " +
382                 item->GetItemTypeName() + " instead of a " +
383                 BuilderRecord::GetNameForType(type) + ".");
384     return nullptr;
385   }
386   return record;
387 }
388 
AddDeps(BuilderRecord * record,const LabelConfigVector & configs,Err * err)389 bool Builder::AddDeps(BuilderRecord* record,
390                       const LabelConfigVector& configs,
391                       Err* err) {
392   for (const auto& config : configs) {
393     BuilderRecord* dep_record = GetOrCreateRecordOfType(
394         config.label, config.origin, BuilderRecord::ITEM_CONFIG, err);
395     if (!dep_record)
396       return false;
397     record->AddDep(dep_record);
398   }
399   return true;
400 }
401 
AddDeps(BuilderRecord * record,const UniqueVector<LabelConfigPair> & configs,Err * err)402 bool Builder::AddDeps(BuilderRecord* record,
403                       const UniqueVector<LabelConfigPair>& configs,
404                       Err* err) {
405   for (const auto& config : configs) {
406     BuilderRecord* dep_record = GetOrCreateRecordOfType(
407         config.label, config.origin, BuilderRecord::ITEM_CONFIG, err);
408     if (!dep_record)
409       return false;
410     record->AddDep(dep_record);
411   }
412   return true;
413 }
414 
AddDeps(BuilderRecord * record,const LabelTargetVector & targets,Err * err)415 bool Builder::AddDeps(BuilderRecord* record,
416                       const LabelTargetVector& targets,
417                       Err* err) {
418   for (const auto& target : targets) {
419     BuilderRecord* dep_record = GetOrCreateRecordOfType(
420         target.label, target.origin, BuilderRecord::ITEM_TARGET, err);
421     if (!dep_record)
422       return false;
423     record->AddDep(dep_record);
424   }
425   return true;
426 }
427 
AddGenDeps(BuilderRecord * record,const LabelTargetVector & targets,Err * err)428 bool Builder::AddGenDeps(BuilderRecord* record,
429                          const LabelTargetVector& targets,
430                          Err* err) {
431   for (const auto& target : targets) {
432     BuilderRecord* dep_record = GetOrCreateRecordOfType(
433         target.label, target.origin, BuilderRecord::ITEM_TARGET, err);
434     if (!dep_record)
435       return false;
436     record->AddGenDep(dep_record);
437   }
438   return true;
439 }
440 
AddPoolDep(BuilderRecord * record,const Target * target,Err * err)441 bool Builder::AddPoolDep(BuilderRecord* record,
442                          const Target* target,
443                          Err* err) {
444   if (target->pool().label.is_null())
445     return true;
446 
447   BuilderRecord* pool_record =
448       GetOrCreateRecordOfType(target->pool().label, target->pool().origin,
449                               BuilderRecord::ITEM_POOL, err);
450   if (!pool_record)
451     return false;
452   record->AddDep(pool_record);
453 
454   return true;
455 }
456 
AddToolchainDep(BuilderRecord * record,const Target * target,Err * err)457 bool Builder::AddToolchainDep(BuilderRecord* record,
458                               const Target* target,
459                               Err* err) {
460   BuilderRecord* toolchain_record = GetOrCreateRecordOfType(
461       target->settings()->toolchain_label(), target->defined_from(),
462       BuilderRecord::ITEM_TOOLCHAIN, err);
463   if (!toolchain_record)
464     return false;
465   record->AddDep(toolchain_record);
466 
467   return true;
468 }
469 
RecursiveSetShouldGenerate(BuilderRecord * record,bool force)470 void Builder::RecursiveSetShouldGenerate(BuilderRecord* record, bool force) {
471   if (!record->should_generate()) {
472     // This function can encounter cycles because gen_deps aren't a DAG. Setting
473     // the should_generate flag before iterating avoids infinite recursion in
474     // that case.
475     record->set_should_generate(true);
476 
477     // This may have caused the item to go into "resolved and generated" state.
478     if (record->resolved() && resolved_and_generated_callback_)
479       resolved_and_generated_callback_(record);
480   } else if (!force) {
481     return;  // Already set and we're not required to iterate dependencies.
482   }
483 
484   for (auto it = record->all_deps().begin(); it.valid(); ++it) {
485     BuilderRecord* cur = *it;
486     if (!cur->should_generate()) {
487       ScheduleItemLoadIfNecessary(cur);
488       RecursiveSetShouldGenerate(cur, false);
489     }
490   }
491 }
492 
ScheduleItemLoadIfNecessary(BuilderRecord * record)493 void Builder::ScheduleItemLoadIfNecessary(BuilderRecord* record) {
494   const ParseNode* origin = record->originally_referenced_from();
495   loader_->Load(record->label(), origin ? origin->GetRange() : LocationRange());
496 }
497 
ResolveItem(BuilderRecord * record,Err * err)498 bool Builder::ResolveItem(BuilderRecord* record, Err* err) {
499   DCHECK(record->can_resolve() && !record->resolved());
500 
501   if (record->type() == BuilderRecord::ITEM_TARGET) {
502     Target* target = record->item()->AsTarget();
503     if (!ResolveDeps(&target->public_deps(), err) ||
504         !ResolveDeps(&target->private_deps(), err) ||
505         !ResolveDeps(&target->data_deps(), err) ||
506         !ResolveConfigs(&target->configs(), err) ||
507         !ResolveConfigs(&target->all_dependent_configs(), err) ||
508         !ResolveConfigs(&target->public_configs(), err) ||
509         !ResolveConfigs(&target->own_configs(), err) ||
510         !ResolveConfigs(&target->own_all_dependent_configs(), err) ||
511         !ResolveConfigs(&target->own_public_configs(), err) ||
512         !ResolvePool(target, err) || !ResolveToolchain(target, err))
513       return false;
514   } else if (record->type() == BuilderRecord::ITEM_CONFIG) {
515     Config* config = record->item()->AsConfig();
516     if (!ResolveConfigs(&config->configs(), err))
517       return false;
518   } else if (record->type() == BuilderRecord::ITEM_TOOLCHAIN) {
519     Toolchain* toolchain = record->item()->AsToolchain();
520     if (!ResolveDeps(&toolchain->deps(), err))
521       return false;
522     if (!ResolvePools(toolchain, err))
523       return false;
524   }
525 
526   record->set_resolved(true);
527 
528   if (!record->item()->OnResolved(err))
529     return false;
530   if (record->should_generate() && resolved_and_generated_callback_)
531     resolved_and_generated_callback_(record);
532 
533   // Recursively update everybody waiting on this item to be resolved.
534   const BuilderRecordSet waiting_deps = record->waiting_on_resolution();
535   for (auto it = waiting_deps.begin(); it.valid(); ++it) {
536     BuilderRecord* waiting = *it;
537     if (waiting->OnResolvedDep(record)) {
538       if (!ResolveItem(waiting, err))
539         return false;
540     }
541   }
542   record->waiting_on_resolution().clear();
543   return true;
544 }
545 
ResolveDeps(LabelTargetVector * deps,Err * err)546 bool Builder::ResolveDeps(LabelTargetVector* deps, Err* err) {
547   for (LabelTargetPair& cur : *deps) {
548     DCHECK(!cur.ptr);
549 
550     BuilderRecord* record = GetResolvedRecordOfType(
551         cur.label, cur.origin, BuilderRecord::ITEM_TARGET, err);
552     if (!record)
553       return false;
554     cur.ptr = record->item()->AsTarget();
555   }
556   return true;
557 }
558 
ResolveConfigs(UniqueVector<LabelConfigPair> * configs,Err * err)559 bool Builder::ResolveConfigs(UniqueVector<LabelConfigPair>* configs, Err* err) {
560   for (const auto& cur : *configs) {
561     DCHECK(!cur.ptr);
562 
563     BuilderRecord* record = GetResolvedRecordOfType(
564         cur.label, cur.origin, BuilderRecord::ITEM_CONFIG, err);
565     if (!record)
566       return false;
567     const_cast<LabelConfigPair&>(cur).ptr = record->item()->AsConfig();
568   }
569   return true;
570 }
571 
ResolveToolchain(Target * target,Err * err)572 bool Builder::ResolveToolchain(Target* target, Err* err) {
573   BuilderRecord* record = GetResolvedRecordOfType(
574       target->settings()->toolchain_label(), target->defined_from(),
575       BuilderRecord::ITEM_TOOLCHAIN, err);
576   if (!record) {
577     *err = Err(
578         target->defined_from(), "Toolchain for target not defined.",
579         "I was hoping to find a toolchain " +
580             target->settings()->toolchain_label().GetUserVisibleName(false));
581     return false;
582   }
583 
584   if (!target->SetToolchain(record->item()->AsToolchain(), err))
585     return false;
586 
587   return true;
588 }
589 
ResolvePool(Target * target,Err * err)590 bool Builder::ResolvePool(Target* target, Err* err) {
591   if (target->pool().label.is_null())
592     return true;
593 
594   BuilderRecord* record =
595       GetResolvedRecordOfType(target->pool().label, target->pool().origin,
596                               BuilderRecord::ITEM_POOL, err);
597   if (!record)
598     return false;
599   target->set_pool(LabelPtrPair<Pool>(record->item()->AsPool()));
600 
601   return true;
602 }
603 
ResolvePools(Toolchain * toolchain,Err * err)604 bool Builder::ResolvePools(Toolchain* toolchain, Err* err) {
605   for (const auto& tool : toolchain->tools()) {
606     if (tool.second->pool().label.is_null())
607       continue;
608 
609     BuilderRecord* record = GetResolvedRecordOfType(
610         tool.second->pool().label, toolchain->defined_from(),
611         BuilderRecord::ITEM_POOL, err);
612     if (!record) {
613       *err = Err(tool.second->pool().origin, "Pool for tool not defined.",
614                  "I was hoping to find a pool " +
615                      tool.second->pool().label.GetUserVisibleName(false));
616       return false;
617     }
618 
619     tool.second->set_pool(LabelPtrPair<Pool>(record->item()->AsPool()));
620   }
621 
622   return true;
623 }
624 
CheckForCircularDependencies(const std::vector<const BuilderRecord * > & bad_records) const625 std::string Builder::CheckForCircularDependencies(
626     const std::vector<const BuilderRecord*>& bad_records) const {
627   std::vector<const BuilderRecord*> cycle;
628   if (!RecursiveFindCycle(bad_records[0], &cycle))
629     return std::string();  // Didn't find a cycle, something else is wrong.
630 
631   std::string ret;
632   for (size_t i = 0; i < cycle.size(); i++) {
633     ret += "  " +
634            cycle[i]->label().GetUserVisibleName(loader_->GetDefaultToolchain());
635     if (i != cycle.size() - 1)
636       ret += " ->";
637     ret += "\n";
638   }
639 
640   return ret;
641 }
642