1 #![feature(array_windows)]
2 #![feature(binary_heap_into_iter_sorted)]
3 #![feature(box_patterns)]
4 #![feature(if_let_guard)]
5 #![feature(iter_intersperse)]
6 #![feature(let_chains)]
7 #![feature(lint_reasons)]
8 #![feature(never_type)]
9 #![feature(rustc_private)]
10 #![feature(stmt_expr_attributes)]
11 #![recursion_limit = "512"]
12 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
13 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
14 #![warn(trivial_casts, trivial_numeric_casts)]
15 // warn on lints, that are included in `rust-lang/rust`s bootstrap
16 #![warn(rust_2018_idioms, unused_lifetimes)]
17 // warn on rustc internal lints
18 #![warn(rustc::internal)]
19 // Disable this rustc lint for now, as it was also done in rustc
20 #![allow(rustc::potential_query_instability)]
21
22 // FIXME: switch to something more ergonomic here, once available.
23 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
24 extern crate rustc_arena;
25 extern crate rustc_ast;
26 extern crate rustc_ast_pretty;
27 extern crate rustc_data_structures;
28 extern crate rustc_driver;
29 extern crate rustc_errors;
30 extern crate rustc_hir;
31 extern crate rustc_hir_analysis;
32 extern crate rustc_hir_pretty;
33 extern crate rustc_hir_typeck;
34 extern crate rustc_index;
35 extern crate rustc_infer;
36 extern crate rustc_lexer;
37 extern crate rustc_lint;
38 extern crate rustc_middle;
39 extern crate rustc_parse;
40 extern crate rustc_session;
41 extern crate rustc_span;
42 extern crate rustc_target;
43 extern crate rustc_trait_selection;
44 extern crate thin_vec;
45
46 #[macro_use]
47 extern crate clippy_utils;
48 #[macro_use]
49 extern crate declare_clippy_lint;
50
51 use std::io;
52 use std::path::PathBuf;
53
54 use clippy_utils::msrvs::Msrv;
55 use rustc_data_structures::fx::FxHashSet;
56 use rustc_lint::{Lint, LintId};
57 use rustc_session::Session;
58
59 #[cfg(feature = "internal")]
60 pub mod deprecated_lints;
61 #[cfg_attr(feature = "internal", allow(clippy::missing_clippy_version_attribute))]
62 mod utils;
63
64 mod declared_lints;
65 mod renamed_lints;
66
67 // begin lints modules, do not remove this comment, it’s used in `update_lints`
68 mod allow_attributes;
69 mod almost_complete_range;
70 mod approx_const;
71 mod arc_with_non_send_sync;
72 mod as_conversions;
73 mod asm_syntax;
74 mod assertions_on_constants;
75 mod assertions_on_result_states;
76 mod async_yields_async;
77 mod attrs;
78 mod await_holding_invalid;
79 mod blocks_in_if_conditions;
80 mod bool_assert_comparison;
81 mod bool_to_int_with_if;
82 mod booleans;
83 mod borrow_deref_ref;
84 mod box_default;
85 mod cargo;
86 mod casts;
87 mod checked_conversions;
88 mod cognitive_complexity;
89 mod collapsible_if;
90 mod collection_is_never_read;
91 mod comparison_chain;
92 mod copies;
93 mod copy_iterator;
94 mod crate_in_macro_def;
95 mod create_dir;
96 mod dbg_macro;
97 mod default;
98 mod default_constructed_unit_structs;
99 mod default_instead_of_iter_empty;
100 mod default_numeric_fallback;
101 mod default_union_representation;
102 mod dereference;
103 mod derivable_impls;
104 mod derive;
105 mod disallowed_macros;
106 mod disallowed_methods;
107 mod disallowed_names;
108 mod disallowed_script_idents;
109 mod disallowed_types;
110 mod doc;
111 mod double_parens;
112 mod drop_forget_ref;
113 mod duplicate_mod;
114 mod else_if_without_else;
115 mod empty_drop;
116 mod empty_enum;
117 mod empty_structs_with_brackets;
118 mod endian_bytes;
119 mod entry;
120 mod enum_clike;
121 mod enum_variants;
122 mod equatable_if_let;
123 mod escape;
124 mod eta_reduction;
125 mod excessive_bools;
126 mod excessive_nesting;
127 mod exhaustive_items;
128 mod exit;
129 mod explicit_write;
130 mod extra_unused_type_parameters;
131 mod fallible_impl_from;
132 mod float_literal;
133 mod floating_point_arithmetic;
134 mod fn_null_check;
135 mod format;
136 mod format_args;
137 mod format_impl;
138 mod format_push_string;
139 mod formatting;
140 mod from_over_into;
141 mod from_raw_with_void_ptr;
142 mod from_str_radix_10;
143 mod functions;
144 mod future_not_send;
145 mod if_let_mutex;
146 mod if_not_else;
147 mod if_then_some_else_none;
148 mod implicit_hasher;
149 mod implicit_return;
150 mod implicit_saturating_add;
151 mod implicit_saturating_sub;
152 mod inconsistent_struct_constructor;
153 mod incorrect_impls;
154 mod index_refutable_slice;
155 mod indexing_slicing;
156 mod infinite_iter;
157 mod inherent_impl;
158 mod inherent_to_string;
159 mod init_numbered_fields;
160 mod inline_fn_without_body;
161 mod instant_subtraction;
162 mod int_plus_one;
163 mod invalid_upcast_comparisons;
164 mod items_after_statements;
165 mod items_after_test_module;
166 mod iter_not_returning_iterator;
167 mod large_const_arrays;
168 mod large_enum_variant;
169 mod large_futures;
170 mod large_include_file;
171 mod large_stack_arrays;
172 mod large_stack_frames;
173 mod len_zero;
174 mod let_if_seq;
175 mod let_underscore;
176 mod let_with_type_underscore;
177 mod lifetimes;
178 mod lines_filter_map_ok;
179 mod literal_representation;
180 mod loops;
181 mod macro_use;
182 mod main_recursion;
183 mod manual_assert;
184 mod manual_async_fn;
185 mod manual_bits;
186 mod manual_clamp;
187 mod manual_is_ascii_check;
188 mod manual_let_else;
189 mod manual_main_separator_str;
190 mod manual_non_exhaustive;
191 mod manual_range_patterns;
192 mod manual_rem_euclid;
193 mod manual_retain;
194 mod manual_slice_size_calculation;
195 mod manual_string_new;
196 mod manual_strip;
197 mod map_unit_fn;
198 mod match_result_ok;
199 mod matches;
200 mod mem_replace;
201 mod methods;
202 mod min_ident_chars;
203 mod minmax;
204 mod misc;
205 mod misc_early;
206 mod mismatching_type_param_order;
207 mod missing_assert_message;
208 mod missing_const_for_fn;
209 mod missing_doc;
210 mod missing_enforced_import_rename;
211 mod missing_fields_in_debug;
212 mod missing_inline;
213 mod missing_trait_methods;
214 mod mixed_read_write_in_expression;
215 mod module_style;
216 mod multi_assignments;
217 mod multiple_unsafe_ops_per_block;
218 mod mut_key;
219 mod mut_mut;
220 mod mut_reference;
221 mod mutable_debug_assertion;
222 mod mutex_atomic;
223 mod needless_arbitrary_self_type;
224 mod needless_bool;
225 mod needless_borrowed_ref;
226 mod needless_continue;
227 mod needless_else;
228 mod needless_for_each;
229 mod needless_if;
230 mod needless_late_init;
231 mod needless_parens_on_range_literals;
232 mod needless_pass_by_value;
233 mod needless_question_mark;
234 mod needless_update;
235 mod neg_cmp_op_on_partial_ord;
236 mod neg_multiply;
237 mod new_without_default;
238 mod no_effect;
239 mod no_mangle_with_rust_abi;
240 mod non_copy_const;
241 mod non_expressive_names;
242 mod non_octal_unix_permissions;
243 mod non_send_fields_in_send_ty;
244 mod nonstandard_macro_braces;
245 mod octal_escapes;
246 mod only_used_in_recursion;
247 mod operators;
248 mod option_env_unwrap;
249 mod option_if_let_else;
250 mod overflow_check_conditional;
251 mod panic_in_result_fn;
252 mod panic_unimplemented;
253 mod partial_pub_fields;
254 mod partialeq_ne_impl;
255 mod partialeq_to_none;
256 mod pass_by_ref_or_value;
257 mod pattern_type_mismatch;
258 mod permissions_set_readonly_false;
259 mod precedence;
260 mod ptr;
261 mod ptr_offset_with_cast;
262 mod pub_use;
263 mod question_mark;
264 mod question_mark_used;
265 mod ranges;
266 mod raw_strings;
267 mod rc_clone_in_vec_init;
268 mod read_zero_byte_vec;
269 mod redundant_async_block;
270 mod redundant_clone;
271 mod redundant_closure_call;
272 mod redundant_else;
273 mod redundant_field_names;
274 mod redundant_pub_crate;
275 mod redundant_slicing;
276 mod redundant_static_lifetimes;
277 mod redundant_type_annotations;
278 mod ref_option_ref;
279 mod ref_patterns;
280 mod reference;
281 mod regex;
282 mod return_self_not_must_use;
283 mod returns;
284 mod same_name_method;
285 mod self_named_constructors;
286 mod semicolon_block;
287 mod semicolon_if_nothing_returned;
288 mod serde_api;
289 mod shadow;
290 mod significant_drop_tightening;
291 mod single_call_fn;
292 mod single_char_lifetime_names;
293 mod single_component_path_imports;
294 mod single_range_in_vec_init;
295 mod size_of_in_element_count;
296 mod size_of_ref;
297 mod slow_vector_initialization;
298 mod std_instead_of_core;
299 mod strings;
300 mod strlen_on_c_strings;
301 mod suspicious_doc_comments;
302 mod suspicious_operation_groupings;
303 mod suspicious_trait_impl;
304 mod suspicious_xor_used_as_pow;
305 mod swap;
306 mod swap_ptr_to_ref;
307 mod tabs_in_doc_comments;
308 mod temporary_assignment;
309 mod tests_outside_test_module;
310 mod to_digit_is_some;
311 mod trailing_empty_array;
312 mod trait_bounds;
313 mod transmute;
314 mod tuple_array_conversions;
315 mod types;
316 mod undocumented_unsafe_blocks;
317 mod unicode;
318 mod uninit_vec;
319 mod unit_return_expecting_ord;
320 mod unit_types;
321 mod unnamed_address;
322 mod unnecessary_box_returns;
323 mod unnecessary_owned_empty_strings;
324 mod unnecessary_self_imports;
325 mod unnecessary_struct_initialization;
326 mod unnecessary_wraps;
327 mod unnested_or_patterns;
328 mod unsafe_removed_from_name;
329 mod unused_async;
330 mod unused_io_amount;
331 mod unused_peekable;
332 mod unused_rounding;
333 mod unused_self;
334 mod unused_unit;
335 mod unwrap;
336 mod unwrap_in_result;
337 mod upper_case_acronyms;
338 mod use_self;
339 mod useless_conversion;
340 mod vec;
341 mod vec_init_then_push;
342 mod visibility;
343 mod wildcard_imports;
344 mod write;
345 mod zero_div_zero;
346 mod zero_sized_map_values;
347 // end lints modules, do not remove this comment, it’s used in `update_lints`
348
349 pub use crate::utils::conf::{lookup_conf_file, Conf};
350 use crate::utils::{
351 conf::{metadata::get_configuration_metadata, TryConf},
352 FindAll,
353 };
354
355 /// Register all pre expansion lints
356 ///
357 /// Pre-expansion lints run before any macro expansion has happened.
358 ///
359 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
360 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
361 ///
362 /// Used in `./src/driver.rs`.
register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf)363 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
364 // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
365 let msrv = Msrv::read(&conf.msrv, sess);
366 let msrv = move || msrv.clone();
367
368 store.register_pre_expansion_pass(move || Box::new(attrs::EarlyAttributes { msrv: msrv() }));
369 }
370
371 #[doc(hidden)]
read_conf(sess: &Session, path: &io::Result<(Option<PathBuf>, Vec<String>)>) -> Conf372 pub fn read_conf(sess: &Session, path: &io::Result<(Option<PathBuf>, Vec<String>)>) -> Conf {
373 if let Ok((_, warnings)) = path {
374 for warning in warnings {
375 sess.warn(warning.clone());
376 }
377 }
378 let file_name = match path {
379 Ok((Some(path), _)) => path,
380 Ok((None, _)) => return Conf::default(),
381 Err(error) => {
382 sess.err(format!("error finding Clippy's configuration file: {error}"));
383 return Conf::default();
384 },
385 };
386
387 let TryConf { conf, errors, warnings } = utils::conf::read(sess, file_name);
388 // all conf errors are non-fatal, we just use the default conf in case of error
389 for error in errors {
390 if let Some(span) = error.span {
391 sess.span_err(
392 span,
393 format!("error reading Clippy's configuration file: {}", error.message),
394 );
395 } else {
396 sess.err(format!(
397 "error reading Clippy's configuration file `{}`: {}",
398 file_name.display(),
399 error.message
400 ));
401 }
402 }
403
404 for warning in warnings {
405 if let Some(span) = warning.span {
406 sess.span_warn(
407 span,
408 format!("error reading Clippy's configuration file: {}", warning.message),
409 );
410 } else {
411 sess.warn(format!(
412 "error reading Clippy's configuration file `{}`: {}",
413 file_name.display(),
414 warning.message
415 ));
416 }
417 }
418
419 conf
420 }
421
422 #[derive(Default)]
423 struct RegistrationGroups {
424 all: Vec<LintId>,
425 cargo: Vec<LintId>,
426 complexity: Vec<LintId>,
427 correctness: Vec<LintId>,
428 nursery: Vec<LintId>,
429 pedantic: Vec<LintId>,
430 perf: Vec<LintId>,
431 restriction: Vec<LintId>,
432 style: Vec<LintId>,
433 suspicious: Vec<LintId>,
434 #[cfg(feature = "internal")]
435 internal: Vec<LintId>,
436 }
437
438 impl RegistrationGroups {
439 #[rustfmt::skip]
register(self, store: &mut rustc_lint::LintStore)440 fn register(self, store: &mut rustc_lint::LintStore) {
441 store.register_group(true, "clippy::all", Some("clippy_all"), self.all);
442 store.register_group(true, "clippy::cargo", Some("clippy_cargo"), self.cargo);
443 store.register_group(true, "clippy::complexity", Some("clippy_complexity"), self.complexity);
444 store.register_group(true, "clippy::correctness", Some("clippy_correctness"), self.correctness);
445 store.register_group(true, "clippy::nursery", Some("clippy_nursery"), self.nursery);
446 store.register_group(true, "clippy::pedantic", Some("clippy_pedantic"), self.pedantic);
447 store.register_group(true, "clippy::perf", Some("clippy_perf"), self.perf);
448 store.register_group(true, "clippy::restriction", Some("clippy_restriction"), self.restriction);
449 store.register_group(true, "clippy::style", Some("clippy_style"), self.style);
450 store.register_group(true, "clippy::suspicious", Some("clippy_suspicious"), self.suspicious);
451 #[cfg(feature = "internal")]
452 store.register_group(true, "clippy::internal", Some("clippy_internal"), self.internal);
453 }
454 }
455
456 #[derive(Copy, Clone)]
457 pub(crate) enum LintCategory {
458 Cargo,
459 Complexity,
460 Correctness,
461 Nursery,
462 Pedantic,
463 Perf,
464 Restriction,
465 Style,
466 Suspicious,
467 #[cfg(feature = "internal")]
468 Internal,
469 }
470 #[allow(clippy::enum_glob_use)]
471 use LintCategory::*;
472
473 impl LintCategory {
is_all(self) -> bool474 fn is_all(self) -> bool {
475 matches!(self, Correctness | Suspicious | Style | Complexity | Perf)
476 }
477
group(self, groups: &mut RegistrationGroups) -> &mut Vec<LintId>478 fn group(self, groups: &mut RegistrationGroups) -> &mut Vec<LintId> {
479 match self {
480 Cargo => &mut groups.cargo,
481 Complexity => &mut groups.complexity,
482 Correctness => &mut groups.correctness,
483 Nursery => &mut groups.nursery,
484 Pedantic => &mut groups.pedantic,
485 Perf => &mut groups.perf,
486 Restriction => &mut groups.restriction,
487 Style => &mut groups.style,
488 Suspicious => &mut groups.suspicious,
489 #[cfg(feature = "internal")]
490 Internal => &mut groups.internal,
491 }
492 }
493 }
494
495 pub(crate) struct LintInfo {
496 /// Double reference to maintain pointer equality
497 lint: &'static &'static Lint,
498 category: LintCategory,
499 explanation: &'static str,
500 }
501
explain(name: &str) -> i32502 pub fn explain(name: &str) -> i32 {
503 let target = format!("clippy::{}", name.to_ascii_uppercase());
504 if let Some(info) = declared_lints::LINTS.iter().find(|info| info.lint.name == target) {
505 println!("{}", info.explanation);
506 // Check if the lint has configuration
507 let mdconf = get_configuration_metadata();
508 if let Some(config_vec_positions) = mdconf
509 .iter()
510 .find_all(|cconf| cconf.lints.contains(&info.lint.name_lower()[8..].to_owned()))
511 {
512 // If it has, print it
513 println!("### Configuration for {}:\n", info.lint.name_lower());
514 for position in config_vec_positions {
515 let conf = &mdconf[position];
516 println!(" - {}: {} (default: {})", conf.name, conf.doc, conf.default);
517 }
518 }
519 0
520 } else {
521 println!("unknown lint: {name}");
522 1
523 }
524 }
525
register_categories(store: &mut rustc_lint::LintStore)526 fn register_categories(store: &mut rustc_lint::LintStore) {
527 let mut groups = RegistrationGroups::default();
528
529 for LintInfo { lint, category, .. } in declared_lints::LINTS {
530 if category.is_all() {
531 groups.all.push(LintId::of(lint));
532 }
533
534 category.group(&mut groups).push(LintId::of(lint));
535 }
536
537 let lints: Vec<&'static Lint> = declared_lints::LINTS.iter().map(|info| *info.lint).collect();
538
539 store.register_lints(&lints);
540 groups.register(store);
541 }
542
543 /// Register all lints and lint groups with the rustc plugin registry
544 ///
545 /// Used in `./src/driver.rs`.
546 #[expect(clippy::too_many_lines)]
register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf)547 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
548 register_removed_non_tool_lints(store);
549 register_categories(store);
550
551 include!("lib.deprecated.rs");
552
553 #[cfg(feature = "internal")]
554 {
555 if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
556 store.register_late_pass(|_| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
557 return;
558 }
559 }
560
561 // all the internal lints
562 #[cfg(feature = "internal")]
563 {
564 store.register_early_pass(|| Box::new(utils::internal_lints::clippy_lints_internal::ClippyLintsInternal));
565 store.register_early_pass(|| Box::new(utils::internal_lints::produce_ice::ProduceIce));
566 store.register_late_pass(|_| Box::new(utils::internal_lints::collapsible_calls::CollapsibleCalls));
567 store.register_late_pass(|_| {
568 Box::new(utils::internal_lints::compiler_lint_functions::CompilerLintFunctions::new())
569 });
570 store.register_late_pass(|_| Box::new(utils::internal_lints::if_chain_style::IfChainStyle));
571 store.register_late_pass(|_| Box::new(utils::internal_lints::invalid_paths::InvalidPaths));
572 store.register_late_pass(|_| {
573 Box::<utils::internal_lints::interning_defined_symbol::InterningDefinedSymbol>::default()
574 });
575 store.register_late_pass(|_| {
576 Box::<utils::internal_lints::lint_without_lint_pass::LintWithoutLintPass>::default()
577 });
578 store.register_late_pass(|_| Box::<utils::internal_lints::unnecessary_def_path::UnnecessaryDefPath>::default());
579 store.register_late_pass(|_| Box::new(utils::internal_lints::outer_expn_data_pass::OuterExpnDataPass));
580 store.register_late_pass(|_| Box::new(utils::internal_lints::msrv_attr_impl::MsrvAttrImpl));
581 store.register_late_pass(|_| {
582 Box::new(utils::internal_lints::almost_standard_lint_formulation::AlmostStandardFormulation::new())
583 });
584 }
585
586 let arithmetic_side_effects_allowed = conf.arithmetic_side_effects_allowed.clone();
587 let arithmetic_side_effects_allowed_binary = conf.arithmetic_side_effects_allowed_binary.clone();
588 let arithmetic_side_effects_allowed_unary = conf.arithmetic_side_effects_allowed_unary.clone();
589 store.register_late_pass(move |_| {
590 Box::new(operators::arithmetic_side_effects::ArithmeticSideEffects::new(
591 arithmetic_side_effects_allowed
592 .iter()
593 .flat_map(|el| [[el.clone(), "*".to_string()], ["*".to_string(), el.clone()]])
594 .chain(arithmetic_side_effects_allowed_binary.clone())
595 .collect(),
596 arithmetic_side_effects_allowed
597 .iter()
598 .chain(arithmetic_side_effects_allowed_unary.iter())
599 .cloned()
600 .collect(),
601 ))
602 });
603 store.register_early_pass(|| Box::new(utils::format_args_collector::FormatArgsCollector));
604 store.register_late_pass(|_| Box::new(utils::dump_hir::DumpHir));
605 store.register_late_pass(|_| Box::new(utils::author::Author));
606 let await_holding_invalid_types = conf.await_holding_invalid_types.clone();
607 store.register_late_pass(move |_| {
608 Box::new(await_holding_invalid::AwaitHolding::new(
609 await_holding_invalid_types.clone(),
610 ))
611 });
612 store.register_late_pass(|_| Box::new(serde_api::SerdeApi));
613 let vec_box_size_threshold = conf.vec_box_size_threshold;
614 let type_complexity_threshold = conf.type_complexity_threshold;
615 let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
616 store.register_late_pass(move |_| {
617 Box::new(types::Types::new(
618 vec_box_size_threshold,
619 type_complexity_threshold,
620 avoid_breaking_exported_api,
621 ))
622 });
623 store.register_late_pass(|_| Box::new(booleans::NonminimalBool));
624 store.register_late_pass(|_| Box::new(enum_clike::UnportableVariant));
625 store.register_late_pass(|_| Box::new(float_literal::FloatLiteral));
626 store.register_late_pass(|_| Box::new(ptr::Ptr));
627 store.register_late_pass(|_| Box::new(needless_bool::NeedlessBool));
628 store.register_late_pass(|_| Box::new(needless_bool::BoolComparison));
629 store.register_late_pass(|_| Box::new(needless_for_each::NeedlessForEach));
630 store.register_late_pass(|_| Box::<misc::LintPass>::default());
631 store.register_late_pass(|_| Box::new(eta_reduction::EtaReduction));
632 store.register_late_pass(|_| Box::new(mut_mut::MutMut));
633 store.register_late_pass(|_| Box::new(mut_reference::UnnecessaryMutPassed));
634 store.register_late_pass(|_| Box::<significant_drop_tightening::SignificantDropTightening<'_>>::default());
635 store.register_late_pass(|_| Box::new(len_zero::LenZero));
636 store.register_late_pass(|_| Box::new(attrs::Attributes));
637 store.register_late_pass(|_| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
638 store.register_late_pass(|_| Box::new(unicode::Unicode));
639 store.register_late_pass(|_| Box::new(uninit_vec::UninitVec));
640 store.register_late_pass(|_| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
641 store.register_late_pass(|_| Box::new(strings::StringAdd));
642 store.register_late_pass(|_| Box::new(implicit_return::ImplicitReturn));
643 store.register_late_pass(|_| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
644 store.register_late_pass(|_| Box::new(default_numeric_fallback::DefaultNumericFallback));
645 store.register_late_pass(|_| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
646 store.register_late_pass(|_| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
647 store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
648
649 let msrv = Msrv::read(&conf.msrv, sess);
650 let msrv = move || msrv.clone();
651 let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
652 let allow_expect_in_tests = conf.allow_expect_in_tests;
653 let allow_unwrap_in_tests = conf.allow_unwrap_in_tests;
654 let suppress_restriction_lint_in_const = conf.suppress_restriction_lint_in_const;
655 store.register_late_pass(move |_| Box::new(approx_const::ApproxConstant::new(msrv())));
656 store.register_late_pass(move |_| {
657 Box::new(methods::Methods::new(
658 avoid_breaking_exported_api,
659 msrv(),
660 allow_expect_in_tests,
661 allow_unwrap_in_tests,
662 ))
663 });
664 store.register_late_pass(move |_| Box::new(matches::Matches::new(msrv())));
665 let matches_for_let_else = conf.matches_for_let_else;
666 store.register_late_pass(move |_| Box::new(manual_let_else::ManualLetElse::new(msrv(), matches_for_let_else)));
667 store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustiveStruct::new(msrv())));
668 store.register_late_pass(move |_| Box::new(manual_non_exhaustive::ManualNonExhaustiveEnum::new(msrv())));
669 store.register_late_pass(move |_| Box::new(manual_strip::ManualStrip::new(msrv())));
670 store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv())));
671 store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv())));
672 store.register_late_pass(move |_| Box::new(checked_conversions::CheckedConversions::new(msrv())));
673 store.register_late_pass(move |_| Box::new(mem_replace::MemReplace::new(msrv())));
674 store.register_late_pass(move |_| Box::new(ranges::Ranges::new(msrv())));
675 store.register_late_pass(move |_| Box::new(from_over_into::FromOverInto::new(msrv())));
676 store.register_late_pass(move |_| Box::new(use_self::UseSelf::new(msrv())));
677 store.register_late_pass(move |_| Box::new(missing_const_for_fn::MissingConstForFn::new(msrv())));
678 store.register_late_pass(move |_| Box::new(needless_question_mark::NeedlessQuestionMark));
679 store.register_late_pass(move |_| Box::new(casts::Casts::new(msrv())));
680 store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv())));
681 store.register_late_pass(|_| Box::new(size_of_in_element_count::SizeOfInElementCount));
682 store.register_late_pass(|_| Box::new(same_name_method::SameNameMethod));
683 let max_suggested_slice_pattern_length = conf.max_suggested_slice_pattern_length;
684 store.register_late_pass(move |_| {
685 Box::new(index_refutable_slice::IndexRefutableSlice::new(
686 max_suggested_slice_pattern_length,
687 msrv(),
688 ))
689 });
690 store.register_late_pass(|_| Box::<shadow::Shadow>::default());
691 store.register_late_pass(|_| Box::new(unit_types::UnitTypes));
692 store.register_late_pass(move |_| Box::new(loops::Loops::new(msrv())));
693 store.register_late_pass(|_| Box::<main_recursion::MainRecursion>::default());
694 store.register_late_pass(|_| Box::new(lifetimes::Lifetimes));
695 store.register_late_pass(|_| Box::new(entry::HashMapPass));
696 store.register_late_pass(|_| Box::new(minmax::MinMaxPass));
697 store.register_late_pass(|_| Box::new(zero_div_zero::ZeroDiv));
698 store.register_late_pass(|_| Box::new(mutex_atomic::Mutex));
699 store.register_late_pass(|_| Box::new(needless_update::NeedlessUpdate));
700 store.register_late_pass(|_| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
701 store.register_late_pass(|_| Box::new(borrow_deref_ref::BorrowDerefRef));
702 store.register_late_pass(|_| Box::new(no_effect::NoEffect));
703 store.register_late_pass(|_| Box::new(temporary_assignment::TemporaryAssignment));
704 store.register_late_pass(move |_| Box::new(transmute::Transmute::new(msrv())));
705 let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
706 store.register_late_pass(move |_| {
707 Box::new(cognitive_complexity::CognitiveComplexity::new(
708 cognitive_complexity_threshold,
709 ))
710 });
711 let too_large_for_stack = conf.too_large_for_stack;
712 store.register_late_pass(move |_| Box::new(escape::BoxedLocal { too_large_for_stack }));
713 store.register_late_pass(move |_| {
714 Box::new(vec::UselessVec {
715 too_large_for_stack,
716 msrv: msrv(),
717 })
718 });
719 store.register_late_pass(|_| Box::new(panic_unimplemented::PanicUnimplemented));
720 store.register_late_pass(|_| Box::new(strings::StringLitAsBytes));
721 store.register_late_pass(|_| Box::new(derive::Derive));
722 store.register_late_pass(move |_| Box::new(derivable_impls::DerivableImpls::new(msrv())));
723 store.register_late_pass(|_| Box::new(drop_forget_ref::DropForgetRef));
724 store.register_late_pass(|_| Box::new(empty_enum::EmptyEnum));
725 store.register_late_pass(|_| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
726 store.register_late_pass(|_| Box::new(regex::Regex));
727 let ignore_interior_mutability = conf.ignore_interior_mutability.clone();
728 store.register_late_pass(move |_| Box::new(copies::CopyAndPaste::new(ignore_interior_mutability.clone())));
729 store.register_late_pass(|_| Box::new(copy_iterator::CopyIterator));
730 store.register_late_pass(|_| Box::new(format::UselessFormat));
731 store.register_late_pass(|_| Box::new(swap::Swap));
732 store.register_late_pass(|_| Box::new(overflow_check_conditional::OverflowCheckConditional));
733 store.register_late_pass(|_| Box::<new_without_default::NewWithoutDefault>::default());
734 let disallowed_names = conf.disallowed_names.iter().cloned().collect::<FxHashSet<_>>();
735 store.register_late_pass(move |_| Box::new(disallowed_names::DisallowedNames::new(disallowed_names.clone())));
736 let too_many_arguments_threshold = conf.too_many_arguments_threshold;
737 let too_many_lines_threshold = conf.too_many_lines_threshold;
738 let large_error_threshold = conf.large_error_threshold;
739 store.register_late_pass(move |_| {
740 Box::new(functions::Functions::new(
741 too_many_arguments_threshold,
742 too_many_lines_threshold,
743 large_error_threshold,
744 ))
745 });
746 let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
747 let missing_docs_in_crate_items = conf.missing_docs_in_crate_items;
748 store.register_late_pass(move |_| Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
749 store.register_late_pass(|_| Box::new(neg_multiply::NegMultiply));
750 store.register_late_pass(|_| Box::new(let_if_seq::LetIfSeq));
751 store.register_late_pass(|_| Box::new(mixed_read_write_in_expression::EvalOrderDependence));
752 store.register_late_pass(move |_| Box::new(missing_doc::MissingDoc::new(missing_docs_in_crate_items)));
753 store.register_late_pass(|_| Box::new(missing_inline::MissingInline));
754 store.register_late_pass(move |_| Box::new(exhaustive_items::ExhaustiveItems));
755 store.register_late_pass(|_| Box::new(match_result_ok::MatchResultOk));
756 store.register_late_pass(|_| Box::new(partialeq_ne_impl::PartialEqNeImpl));
757 store.register_late_pass(|_| Box::new(unused_io_amount::UnusedIoAmount));
758 let enum_variant_size_threshold = conf.enum_variant_size_threshold;
759 store.register_late_pass(move |_| Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
760 store.register_late_pass(|_| Box::new(explicit_write::ExplicitWrite));
761 store.register_late_pass(|_| Box::new(needless_pass_by_value::NeedlessPassByValue));
762 let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
763 conf.trivial_copy_size_limit,
764 conf.pass_by_value_size_limit,
765 conf.avoid_breaking_exported_api,
766 &sess.target,
767 );
768 store.register_late_pass(move |_| Box::new(pass_by_ref_or_value));
769 store.register_late_pass(|_| Box::new(ref_option_ref::RefOptionRef));
770 store.register_late_pass(|_| Box::new(infinite_iter::InfiniteIter));
771 store.register_late_pass(|_| Box::new(inline_fn_without_body::InlineFnWithoutBody));
772 store.register_late_pass(|_| Box::<useless_conversion::UselessConversion>::default());
773 store.register_late_pass(|_| Box::new(implicit_hasher::ImplicitHasher));
774 store.register_late_pass(|_| Box::new(fallible_impl_from::FallibleImplFrom));
775 store.register_late_pass(|_| Box::<question_mark::QuestionMark>::default());
776 store.register_late_pass(|_| Box::new(question_mark_used::QuestionMarkUsed));
777 store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
778 store.register_late_pass(|_| Box::new(suspicious_trait_impl::SuspiciousImpl));
779 store.register_late_pass(|_| Box::new(map_unit_fn::MapUnit));
780 store.register_late_pass(|_| Box::new(inherent_impl::MultipleInherentImpl));
781 store.register_late_pass(|_| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
782 store.register_late_pass(|_| Box::new(unwrap::Unwrap));
783 store.register_late_pass(move |_| {
784 Box::new(indexing_slicing::IndexingSlicing::new(
785 suppress_restriction_lint_in_const,
786 ))
787 });
788 store.register_late_pass(|_| Box::new(non_copy_const::NonCopyConst));
789 store.register_late_pass(|_| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
790 store.register_late_pass(|_| Box::new(redundant_clone::RedundantClone));
791 store.register_late_pass(|_| Box::new(slow_vector_initialization::SlowVectorInit));
792 store.register_late_pass(move |_| Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
793 store.register_late_pass(|_| Box::new(assertions_on_constants::AssertionsOnConstants));
794 store.register_late_pass(|_| Box::new(assertions_on_result_states::AssertionsOnResultStates));
795 store.register_late_pass(|_| Box::new(inherent_to_string::InherentToString));
796 let max_trait_bounds = conf.max_trait_bounds;
797 store.register_late_pass(move |_| Box::new(trait_bounds::TraitBounds::new(max_trait_bounds, msrv())));
798 store.register_late_pass(|_| Box::new(comparison_chain::ComparisonChain));
799 let ignore_interior_mutability = conf.ignore_interior_mutability.clone();
800 store.register_late_pass(move |_| Box::new(mut_key::MutableKeyType::new(ignore_interior_mutability.clone())));
801 store.register_early_pass(|| Box::new(reference::DerefAddrOf));
802 store.register_early_pass(|| Box::new(double_parens::DoubleParens));
803 store.register_late_pass(|_| Box::new(format_impl::FormatImpl::new()));
804 store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
805 store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
806 store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
807 store.register_early_pass(|| Box::new(formatting::Formatting));
808 store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
809 store.register_late_pass(|_| Box::new(redundant_closure_call::RedundantClosureCall));
810 store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
811 store.register_late_pass(|_| Box::new(returns::Return));
812 store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
813 store.register_late_pass(|_| Box::new(items_after_statements::ItemsAfterStatements));
814 store.register_early_pass(|| Box::new(precedence::Precedence));
815 store.register_late_pass(|_| Box::new(needless_parens_on_range_literals::NeedlessParensOnRangeLiterals));
816 store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
817 store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
818 store.register_late_pass(|_| Box::new(create_dir::CreateDir));
819 store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
820 let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
821 store.register_early_pass(move || {
822 Box::new(literal_representation::LiteralDigitGrouping::new(
823 literal_representation_lint_fraction_readability,
824 ))
825 });
826 let literal_representation_threshold = conf.literal_representation_threshold;
827 store.register_early_pass(move || {
828 Box::new(literal_representation::DecimalLiteralRepresentation::new(
829 literal_representation_threshold,
830 ))
831 });
832 let enum_variant_name_threshold = conf.enum_variant_name_threshold;
833 let allow_private_module_inception = conf.allow_private_module_inception;
834 store.register_late_pass(move |_| {
835 Box::new(enum_variants::EnumVariantNames::new(
836 enum_variant_name_threshold,
837 avoid_breaking_exported_api,
838 allow_private_module_inception,
839 ))
840 });
841 store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
842 let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
843 store.register_late_pass(move |_| {
844 Box::new(upper_case_acronyms::UpperCaseAcronyms::new(
845 avoid_breaking_exported_api,
846 upper_case_acronyms_aggressive,
847 ))
848 });
849 store.register_late_pass(|_| Box::<default::Default>::default());
850 store.register_late_pass(move |_| Box::new(unused_self::UnusedSelf::new(avoid_breaking_exported_api)));
851 store.register_late_pass(|_| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
852 store.register_late_pass(|_| Box::new(exit::Exit));
853 store.register_late_pass(|_| Box::new(to_digit_is_some::ToDigitIsSome));
854 let array_size_threshold = u128::from(conf.array_size_threshold);
855 store.register_late_pass(move |_| Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
856 store.register_late_pass(move |_| Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
857 store.register_late_pass(|_| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
858 store.register_late_pass(|_| Box::new(as_conversions::AsConversions));
859 store.register_late_pass(|_| Box::new(let_underscore::LetUnderscore));
860 store.register_early_pass(|| Box::<single_component_path_imports::SingleComponentPathImports>::default());
861 let max_fn_params_bools = conf.max_fn_params_bools;
862 let max_struct_bools = conf.max_struct_bools;
863 store.register_late_pass(move |_| {
864 Box::new(excessive_bools::ExcessiveBools::new(
865 max_struct_bools,
866 max_fn_params_bools,
867 ))
868 });
869 store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
870 let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
871 store.register_late_pass(move |_| Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
872 store.register_late_pass(|_| Box::<redundant_pub_crate::RedundantPubCrate>::default());
873 store.register_late_pass(|_| Box::new(unnamed_address::UnnamedAddress));
874 store.register_late_pass(move |_| Box::new(dereference::Dereferencing::new(msrv())));
875 store.register_late_pass(|_| Box::new(option_if_let_else::OptionIfLetElse));
876 store.register_late_pass(|_| Box::new(future_not_send::FutureNotSend));
877 let future_size_threshold = conf.future_size_threshold;
878 store.register_late_pass(move |_| Box::new(large_futures::LargeFuture::new(future_size_threshold)));
879 store.register_late_pass(|_| Box::new(if_let_mutex::IfLetMutex));
880 store.register_late_pass(|_| Box::new(if_not_else::IfNotElse));
881 store.register_late_pass(|_| Box::new(equatable_if_let::PatternEquality));
882 store.register_late_pass(|_| Box::new(manual_async_fn::ManualAsyncFn));
883 store.register_late_pass(|_| Box::new(panic_in_result_fn::PanicInResultFn));
884 let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
885 store.register_early_pass(move || {
886 Box::new(non_expressive_names::NonExpressiveNames {
887 single_char_binding_names_threshold,
888 })
889 });
890 let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
891 store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(¯o_matcher)));
892 store.register_late_pass(|_| Box::<macro_use::MacroUseImports>::default());
893 store.register_late_pass(|_| Box::new(pattern_type_mismatch::PatternTypeMismatch));
894 store.register_late_pass(|_| Box::new(unwrap_in_result::UnwrapInResult));
895 store.register_late_pass(|_| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
896 store.register_late_pass(|_| Box::new(async_yields_async::AsyncYieldsAsync));
897 let disallowed_macros = conf.disallowed_macros.clone();
898 store.register_late_pass(move |_| Box::new(disallowed_macros::DisallowedMacros::new(disallowed_macros.clone())));
899 let disallowed_methods = conf.disallowed_methods.clone();
900 store.register_late_pass(move |_| Box::new(disallowed_methods::DisallowedMethods::new(disallowed_methods.clone())));
901 store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
902 store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
903 store.register_late_pass(|_| Box::new(empty_drop::EmptyDrop));
904 store.register_late_pass(|_| Box::new(strings::StrToString));
905 store.register_late_pass(|_| Box::new(strings::StringToString));
906 store.register_late_pass(|_| Box::new(zero_sized_map_values::ZeroSizedMapValues));
907 store.register_late_pass(|_| Box::<vec_init_then_push::VecInitThenPush>::default());
908 store.register_late_pass(|_| Box::new(redundant_slicing::RedundantSlicing));
909 store.register_late_pass(|_| Box::new(from_str_radix_10::FromStrRadix10));
910 store.register_late_pass(move |_| Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv())));
911 store.register_late_pass(|_| Box::new(bool_assert_comparison::BoolAssertComparison));
912 store.register_early_pass(move || Box::new(module_style::ModStyle));
913 store.register_late_pass(|_| Box::new(unused_async::UnusedAsync));
914 let disallowed_types = conf.disallowed_types.clone();
915 store.register_late_pass(move |_| Box::new(disallowed_types::DisallowedTypes::new(disallowed_types.clone())));
916 let import_renames = conf.enforced_import_renames.clone();
917 store.register_late_pass(move |_| {
918 Box::new(missing_enforced_import_rename::ImportRename::new(
919 import_renames.clone(),
920 ))
921 });
922 let scripts = conf.allowed_scripts.clone();
923 store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
924 store.register_late_pass(|_| Box::new(strlen_on_c_strings::StrlenOnCStrings));
925 store.register_late_pass(move |_| Box::new(self_named_constructors::SelfNamedConstructors));
926 store.register_late_pass(move |_| Box::new(iter_not_returning_iterator::IterNotReturningIterator));
927 store.register_late_pass(move |_| Box::new(manual_assert::ManualAssert));
928 let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
929 store.register_late_pass(move |_| {
930 Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(
931 enable_raw_pointer_heuristic_for_send,
932 ))
933 });
934 let accept_comment_above_statement = conf.accept_comment_above_statement;
935 let accept_comment_above_attributes = conf.accept_comment_above_attributes;
936 store.register_late_pass(move |_| {
937 Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks::new(
938 accept_comment_above_statement,
939 accept_comment_above_attributes,
940 ))
941 });
942 let allow_mixed_uninlined = conf.allow_mixed_uninlined_format_args;
943 store.register_late_pass(move |_| Box::new(format_args::FormatArgs::new(msrv(), allow_mixed_uninlined)));
944 store.register_late_pass(|_| Box::new(trailing_empty_array::TrailingEmptyArray));
945 store.register_early_pass(|| Box::new(octal_escapes::OctalEscapes));
946 store.register_late_pass(|_| Box::new(needless_late_init::NeedlessLateInit));
947 store.register_late_pass(|_| Box::new(return_self_not_must_use::ReturnSelfNotMustUse));
948 store.register_late_pass(|_| Box::new(init_numbered_fields::NumberedFields));
949 store.register_early_pass(|| Box::new(single_char_lifetime_names::SingleCharLifetimeNames));
950 store.register_late_pass(move |_| Box::new(manual_bits::ManualBits::new(msrv())));
951 store.register_late_pass(|_| Box::new(default_union_representation::DefaultUnionRepresentation));
952 store.register_late_pass(|_| Box::<only_used_in_recursion::OnlyUsedInRecursion>::default());
953 let allow_dbg_in_tests = conf.allow_dbg_in_tests;
954 store.register_late_pass(move |_| Box::new(dbg_macro::DbgMacro::new(allow_dbg_in_tests)));
955 let allow_print_in_tests = conf.allow_print_in_tests;
956 store.register_late_pass(move |_| Box::new(write::Write::new(allow_print_in_tests)));
957 let cargo_ignore_publish = conf.cargo_ignore_publish;
958 store.register_late_pass(move |_| {
959 Box::new(cargo::Cargo {
960 ignore_publish: cargo_ignore_publish,
961 })
962 });
963 store.register_early_pass(|| Box::new(crate_in_macro_def::CrateInMacroDef));
964 store.register_early_pass(|| Box::new(empty_structs_with_brackets::EmptyStructsWithBrackets));
965 store.register_late_pass(|_| Box::new(unnecessary_owned_empty_strings::UnnecessaryOwnedEmptyStrings));
966 store.register_early_pass(|| Box::new(pub_use::PubUse));
967 store.register_late_pass(|_| Box::new(format_push_string::FormatPushString));
968 let max_include_file_size = conf.max_include_file_size;
969 store.register_late_pass(move |_| Box::new(large_include_file::LargeIncludeFile::new(max_include_file_size)));
970 store.register_late_pass(|_| Box::new(strings::TrimSplitWhitespace));
971 store.register_late_pass(|_| Box::new(rc_clone_in_vec_init::RcCloneInVecInit));
972 store.register_early_pass(|| Box::<duplicate_mod::DuplicateMod>::default());
973 store.register_early_pass(|| Box::new(unused_rounding::UnusedRounding));
974 store.register_early_pass(move || Box::new(almost_complete_range::AlmostCompleteRange::new(msrv())));
975 store.register_late_pass(|_| Box::new(swap_ptr_to_ref::SwapPtrToRef));
976 store.register_late_pass(|_| Box::new(mismatching_type_param_order::TypeParamMismatch));
977 store.register_late_pass(|_| Box::new(read_zero_byte_vec::ReadZeroByteVec));
978 store.register_late_pass(|_| Box::new(default_instead_of_iter_empty::DefaultIterEmpty));
979 store.register_late_pass(move |_| Box::new(manual_rem_euclid::ManualRemEuclid::new(msrv())));
980 store.register_late_pass(move |_| Box::new(manual_retain::ManualRetain::new(msrv())));
981 let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
982 store.register_late_pass(move |_| Box::new(operators::Operators::new(verbose_bit_mask_threshold)));
983 store.register_late_pass(|_| Box::<std_instead_of_core::StdReexports>::default());
984 store.register_late_pass(move |_| Box::new(instant_subtraction::InstantSubtraction::new(msrv())));
985 store.register_late_pass(|_| Box::new(partialeq_to_none::PartialeqToNone));
986 store.register_late_pass(move |_| Box::new(manual_clamp::ManualClamp::new(msrv())));
987 store.register_late_pass(|_| Box::new(manual_string_new::ManualStringNew));
988 store.register_late_pass(|_| Box::new(unused_peekable::UnusedPeekable));
989 store.register_early_pass(|| Box::new(multi_assignments::MultiAssignments));
990 store.register_late_pass(|_| Box::new(bool_to_int_with_if::BoolToIntWithIf));
991 store.register_late_pass(|_| Box::new(box_default::BoxDefault));
992 store.register_late_pass(|_| Box::new(implicit_saturating_add::ImplicitSaturatingAdd));
993 store.register_early_pass(|| Box::new(partial_pub_fields::PartialPubFields));
994 store.register_late_pass(|_| Box::new(missing_trait_methods::MissingTraitMethods));
995 store.register_late_pass(|_| Box::new(from_raw_with_void_ptr::FromRawWithVoidPtr));
996 store.register_late_pass(|_| Box::new(suspicious_xor_used_as_pow::ConfusingXorAndPow));
997 store.register_late_pass(move |_| Box::new(manual_is_ascii_check::ManualIsAsciiCheck::new(msrv())));
998 let semicolon_inside_block_ignore_singleline = conf.semicolon_inside_block_ignore_singleline;
999 let semicolon_outside_block_ignore_multiline = conf.semicolon_outside_block_ignore_multiline;
1000 store.register_late_pass(move |_| {
1001 Box::new(semicolon_block::SemicolonBlock::new(
1002 semicolon_inside_block_ignore_singleline,
1003 semicolon_outside_block_ignore_multiline,
1004 ))
1005 });
1006 store.register_late_pass(|_| Box::new(fn_null_check::FnNullCheck));
1007 store.register_late_pass(|_| Box::new(permissions_set_readonly_false::PermissionsSetReadonlyFalse));
1008 store.register_late_pass(|_| Box::new(size_of_ref::SizeOfRef));
1009 store.register_late_pass(|_| Box::new(multiple_unsafe_ops_per_block::MultipleUnsafeOpsPerBlock));
1010 store.register_late_pass(move |_| {
1011 Box::new(extra_unused_type_parameters::ExtraUnusedTypeParameters::new(
1012 avoid_breaking_exported_api,
1013 ))
1014 });
1015 store.register_late_pass(|_| Box::new(no_mangle_with_rust_abi::NoMangleWithRustAbi));
1016 store.register_late_pass(|_| Box::new(collection_is_never_read::CollectionIsNeverRead));
1017 store.register_late_pass(|_| Box::new(missing_assert_message::MissingAssertMessage));
1018 store.register_late_pass(|_| Box::new(redundant_async_block::RedundantAsyncBlock));
1019 store.register_late_pass(|_| Box::new(let_with_type_underscore::UnderscoreTyped));
1020 store.register_late_pass(|_| Box::new(allow_attributes::AllowAttribute));
1021 store.register_late_pass(move |_| Box::new(manual_main_separator_str::ManualMainSeparatorStr::new(msrv())));
1022 store.register_late_pass(|_| Box::new(unnecessary_struct_initialization::UnnecessaryStruct));
1023 let unnecessary_box_size = conf.unnecessary_box_size;
1024 store.register_late_pass(move |_| {
1025 Box::new(unnecessary_box_returns::UnnecessaryBoxReturns::new(
1026 avoid_breaking_exported_api,
1027 unnecessary_box_size,
1028 ))
1029 });
1030 store.register_late_pass(|_| Box::new(lines_filter_map_ok::LinesFilterMapOk));
1031 store.register_late_pass(|_| Box::new(tests_outside_test_module::TestsOutsideTestModule));
1032 store.register_late_pass(|_| Box::new(manual_slice_size_calculation::ManualSliceSizeCalculation));
1033 store.register_early_pass(|| Box::new(suspicious_doc_comments::SuspiciousDocComments));
1034 let excessive_nesting_threshold = conf.excessive_nesting_threshold;
1035 store.register_early_pass(move || {
1036 Box::new(excessive_nesting::ExcessiveNesting {
1037 excessive_nesting_threshold,
1038 nodes: rustc_ast::node_id::NodeSet::new(),
1039 })
1040 });
1041 store.register_late_pass(|_| Box::new(items_after_test_module::ItemsAfterTestModule));
1042 store.register_early_pass(|| Box::new(ref_patterns::RefPatterns));
1043 store.register_late_pass(|_| Box::new(default_constructed_unit_structs::DefaultConstructedUnitStructs));
1044 store.register_early_pass(|| Box::new(needless_else::NeedlessElse));
1045 store.register_late_pass(|_| Box::new(missing_fields_in_debug::MissingFieldsInDebug));
1046 store.register_late_pass(|_| Box::new(endian_bytes::EndianBytes));
1047 store.register_late_pass(|_| Box::new(redundant_type_annotations::RedundantTypeAnnotations));
1048 store.register_late_pass(|_| Box::new(arc_with_non_send_sync::ArcWithNonSendSync));
1049 store.register_late_pass(|_| Box::new(needless_if::NeedlessIf));
1050 let allowed_idents_below_min_chars = conf.allowed_idents_below_min_chars.clone();
1051 let min_ident_chars_threshold = conf.min_ident_chars_threshold;
1052 store.register_late_pass(move |_| {
1053 Box::new(min_ident_chars::MinIdentChars {
1054 allowed_idents_below_min_chars: allowed_idents_below_min_chars.clone(),
1055 min_ident_chars_threshold,
1056 })
1057 });
1058 let stack_size_threshold = conf.stack_size_threshold;
1059 store.register_late_pass(move |_| Box::new(large_stack_frames::LargeStackFrames::new(stack_size_threshold)));
1060 store.register_late_pass(|_| Box::new(single_range_in_vec_init::SingleRangeInVecInit));
1061 store.register_late_pass(|_| Box::new(incorrect_impls::IncorrectImpls));
1062 store.register_late_pass(move |_| {
1063 Box::new(single_call_fn::SingleCallFn {
1064 avoid_breaking_exported_api,
1065 def_id_to_usage: rustc_data_structures::fx::FxHashMap::default(),
1066 })
1067 });
1068 let needless_raw_string_hashes_allow_one = conf.allow_one_hash_in_raw_strings;
1069 store.register_early_pass(move || {
1070 Box::new(raw_strings::RawStrings {
1071 needless_raw_string_hashes_allow_one,
1072 })
1073 });
1074 store.register_late_pass(|_| Box::new(manual_range_patterns::ManualRangePatterns));
1075 store.register_early_pass(|| Box::new(visibility::Visibility));
1076 store.register_late_pass(move |_| Box::new(tuple_array_conversions::TupleArrayConversions { msrv: msrv() }));
1077 // add lints here, do not remove this comment, it's used in `new_lint`
1078 }
1079
1080 #[rustfmt::skip]
register_removed_non_tool_lints(store: &mut rustc_lint::LintStore)1081 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
1082 store.register_removed(
1083 "should_assert_eq",
1084 "`assert!()` will be more flexible with RFC 2011",
1085 );
1086 store.register_removed(
1087 "extend_from_slice",
1088 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
1089 );
1090 store.register_removed(
1091 "range_step_by_zero",
1092 "`iterator.step_by(0)` panics nowadays",
1093 );
1094 store.register_removed(
1095 "unstable_as_slice",
1096 "`Vec::as_slice` has been stabilized in 1.7",
1097 );
1098 store.register_removed(
1099 "unstable_as_mut_slice",
1100 "`Vec::as_mut_slice` has been stabilized in 1.7",
1101 );
1102 store.register_removed(
1103 "misaligned_transmute",
1104 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
1105 );
1106 store.register_removed(
1107 "assign_ops",
1108 "using compound assignment operators (e.g., `+=`) is harmless",
1109 );
1110 store.register_removed(
1111 "if_let_redundant_pattern_matching",
1112 "this lint has been changed to redundant_pattern_matching",
1113 );
1114 store.register_removed(
1115 "unsafe_vector_initialization",
1116 "the replacement suggested by this lint had substantially different behavior",
1117 );
1118 store.register_removed(
1119 "reverse_range_loop",
1120 "this lint is now included in reversed_empty_ranges",
1121 );
1122 }
1123
1124 /// Register renamed lints.
1125 ///
1126 /// Used in `./src/driver.rs`.
register_renamed(ls: &mut rustc_lint::LintStore)1127 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
1128 for (old_name, new_name) in renamed_lints::RENAMED_LINTS {
1129 ls.register_renamed(old_name, new_name);
1130 }
1131 }
1132
1133 // only exists to let the dogfood integration test works.
1134 // Don't run clippy as an executable directly
1135 #[allow(dead_code)]
main()1136 fn main() {
1137 panic!("Please use the cargo-clippy executable");
1138 }
1139