• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 /* Written by Nils Larsch for the OpenSSL project. */
2 /* ====================================================================
3  * Copyright (c) 2000-2003 The OpenSSL Project.  All rights reserved.
4  *
5  * Redistribution and use in source and binary forms, with or without
6  * modification, are permitted provided that the following conditions
7  * are met:
8  *
9  * 1. Redistributions of source code must retain the above copyright
10  *    notice, this list of conditions and the following disclaimer.
11  *
12  * 2. Redistributions in binary form must reproduce the above copyright
13  *    notice, this list of conditions and the following disclaimer in
14  *    the documentation and/or other materials provided with the
15  *    distribution.
16  *
17  * 3. All advertising materials mentioning features or use of this
18  *    software must display the following acknowledgment:
19  *    "This product includes software developed by the OpenSSL Project
20  *    for use in the OpenSSL Toolkit. (http://www.OpenSSL.org/)"
21  *
22  * 4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to
23  *    endorse or promote products derived from this software without
24  *    prior written permission. For written permission, please contact
25  *    licensing@OpenSSL.org.
26  *
27  * 5. Products derived from this software may not be called "OpenSSL"
28  *    nor may "OpenSSL" appear in their names without prior written
29  *    permission of the OpenSSL Project.
30  *
31  * 6. Redistributions of any form whatsoever must retain the following
32  *    acknowledgment:
33  *    "This product includes software developed by the OpenSSL Project
34  *    for use in the OpenSSL Toolkit (http://www.OpenSSL.org/)"
35  *
36  * THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY
37  * EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
38  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
39  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE OpenSSL PROJECT OR
40  * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
41  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
42  * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
43  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
44  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
45  * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
46  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
47  * OF THE POSSIBILITY OF SUCH DAMAGE.
48  * ====================================================================
49  *
50  * This product includes cryptographic software written by Eric Young
51  * (eay@cryptsoft.com).  This product includes software written by Tim
52  * Hudson (tjh@cryptsoft.com). */
53 
54 #include <openssl/ec.h>
55 
56 #include <limits.h>
57 #include <string.h>
58 
59 #include <openssl/bytestring.h>
60 #include <openssl/bn.h>
61 #include <openssl/err.h>
62 #include <openssl/mem.h>
63 #include <openssl/nid.h>
64 
65 #include "../fipsmodule/ec/internal.h"
66 #include "../bytestring/internal.h"
67 #include "../internal.h"
68 
69 
70 static const unsigned kParametersTag =
71     CBS_ASN1_CONSTRUCTED | CBS_ASN1_CONTEXT_SPECIFIC | 0;
72 static const unsigned kPublicKeyTag =
73     CBS_ASN1_CONSTRUCTED | CBS_ASN1_CONTEXT_SPECIFIC | 1;
74 
EC_KEY_parse_private_key(CBS * cbs,const EC_GROUP * group)75 EC_KEY *EC_KEY_parse_private_key(CBS *cbs, const EC_GROUP *group) {
76   CBS ec_private_key, private_key;
77   uint64_t version;
78   if (!CBS_get_asn1(cbs, &ec_private_key, CBS_ASN1_SEQUENCE) ||
79       !CBS_get_asn1_uint64(&ec_private_key, &version) ||
80       version != 1 ||
81       !CBS_get_asn1(&ec_private_key, &private_key, CBS_ASN1_OCTETSTRING)) {
82     OPENSSL_PUT_ERROR(EC, EC_R_DECODE_ERROR);
83     return NULL;
84   }
85 
86   // Parse the optional parameters field.
87   EC_GROUP *inner_group = NULL;
88   EC_KEY *ret = NULL;
89   BIGNUM *priv_key = NULL;
90   if (CBS_peek_asn1_tag(&ec_private_key, kParametersTag)) {
91     // Per SEC 1, as an alternative to omitting it, one is allowed to specify
92     // this field and put in a NULL to mean inheriting this value. This was
93     // omitted in a previous version of this logic without problems, so leave it
94     // unimplemented.
95     CBS child;
96     if (!CBS_get_asn1(&ec_private_key, &child, kParametersTag)) {
97       OPENSSL_PUT_ERROR(EC, EC_R_DECODE_ERROR);
98       goto err;
99     }
100     inner_group = EC_KEY_parse_parameters(&child);
101     if (inner_group == NULL) {
102       goto err;
103     }
104     if (group == NULL) {
105       group = inner_group;
106     } else if (EC_GROUP_cmp(group, inner_group, NULL) != 0) {
107       // If a group was supplied externally, it must match.
108       OPENSSL_PUT_ERROR(EC, EC_R_GROUP_MISMATCH);
109       goto err;
110     }
111     if (CBS_len(&child) != 0) {
112       OPENSSL_PUT_ERROR(EC, EC_R_DECODE_ERROR);
113       goto err;
114     }
115   }
116 
117   if (group == NULL) {
118     OPENSSL_PUT_ERROR(EC, EC_R_MISSING_PARAMETERS);
119     goto err;
120   }
121 
122   ret = EC_KEY_new();
123   if (ret == NULL || !EC_KEY_set_group(ret, group)) {
124     goto err;
125   }
126 
127   // Although RFC 5915 specifies the length of the key, OpenSSL historically
128   // got this wrong, so accept any length. See upstream's
129   // 30cd4ff294252c4b6a4b69cbef6a5b4117705d22.
130   priv_key = BN_bin2bn(CBS_data(&private_key), CBS_len(&private_key), NULL);
131   ret->pub_key = EC_POINT_new(group);
132   if (priv_key == NULL || ret->pub_key == NULL ||
133       !EC_KEY_set_private_key(ret, priv_key)) {
134     goto err;
135   }
136 
137   if (CBS_peek_asn1_tag(&ec_private_key, kPublicKeyTag)) {
138     CBS child, public_key;
139     uint8_t padding;
140     if (!CBS_get_asn1(&ec_private_key, &child, kPublicKeyTag) ||
141         !CBS_get_asn1(&child, &public_key, CBS_ASN1_BITSTRING) ||
142         // As in a SubjectPublicKeyInfo, the byte-encoded public key is then
143         // encoded as a BIT STRING with bits ordered as in the DER encoding.
144         !CBS_get_u8(&public_key, &padding) ||
145         padding != 0 ||
146         // Explicitly check |public_key| is non-empty to save the conversion
147         // form later.
148         CBS_len(&public_key) == 0 ||
149         !EC_POINT_oct2point(group, ret->pub_key, CBS_data(&public_key),
150                             CBS_len(&public_key), NULL) ||
151         CBS_len(&child) != 0) {
152       OPENSSL_PUT_ERROR(EC, EC_R_DECODE_ERROR);
153       goto err;
154     }
155 
156     // Save the point conversion form.
157     // TODO(davidben): Consider removing this.
158     ret->conv_form =
159         (point_conversion_form_t)(CBS_data(&public_key)[0] & ~0x01);
160   } else {
161     // Compute the public key instead.
162     if (!ec_point_mul_scalar_base(group, &ret->pub_key->raw,
163                                   &ret->priv_key->scalar)) {
164       goto err;
165     }
166     // Remember the original private-key-only encoding.
167     // TODO(davidben): Consider removing this.
168     ret->enc_flag |= EC_PKEY_NO_PUBKEY;
169   }
170 
171   if (CBS_len(&ec_private_key) != 0) {
172     OPENSSL_PUT_ERROR(EC, EC_R_DECODE_ERROR);
173     goto err;
174   }
175 
176   // Ensure the resulting key is valid.
177   if (!EC_KEY_check_key(ret)) {
178     goto err;
179   }
180 
181   BN_free(priv_key);
182   EC_GROUP_free(inner_group);
183   return ret;
184 
185 err:
186   EC_KEY_free(ret);
187   BN_free(priv_key);
188   EC_GROUP_free(inner_group);
189   return NULL;
190 }
191 
EC_KEY_marshal_private_key(CBB * cbb,const EC_KEY * key,unsigned enc_flags)192 int EC_KEY_marshal_private_key(CBB *cbb, const EC_KEY *key,
193                                unsigned enc_flags) {
194   if (key == NULL || key->group == NULL || key->priv_key == NULL) {
195     OPENSSL_PUT_ERROR(EC, ERR_R_PASSED_NULL_PARAMETER);
196     return 0;
197   }
198 
199   CBB ec_private_key, private_key;
200   if (!CBB_add_asn1(cbb, &ec_private_key, CBS_ASN1_SEQUENCE) ||
201       !CBB_add_asn1_uint64(&ec_private_key, 1 /* version */) ||
202       !CBB_add_asn1(&ec_private_key, &private_key, CBS_ASN1_OCTETSTRING) ||
203       !BN_bn2cbb_padded(&private_key,
204                         BN_num_bytes(EC_GROUP_get0_order(key->group)),
205                         EC_KEY_get0_private_key(key))) {
206     OPENSSL_PUT_ERROR(EC, EC_R_ENCODE_ERROR);
207     return 0;
208   }
209 
210   if (!(enc_flags & EC_PKEY_NO_PARAMETERS)) {
211     CBB child;
212     if (!CBB_add_asn1(&ec_private_key, &child, kParametersTag) ||
213         !EC_KEY_marshal_curve_name(&child, key->group) ||
214         !CBB_flush(&ec_private_key)) {
215       OPENSSL_PUT_ERROR(EC, EC_R_ENCODE_ERROR);
216       return 0;
217     }
218   }
219 
220   // TODO(fork): replace this flexibility with sensible default?
221   if (!(enc_flags & EC_PKEY_NO_PUBKEY) && key->pub_key != NULL) {
222     CBB child, public_key;
223     if (!CBB_add_asn1(&ec_private_key, &child, kPublicKeyTag) ||
224         !CBB_add_asn1(&child, &public_key, CBS_ASN1_BITSTRING) ||
225         // As in a SubjectPublicKeyInfo, the byte-encoded public key is then
226         // encoded as a BIT STRING with bits ordered as in the DER encoding.
227         !CBB_add_u8(&public_key, 0 /* padding */) ||
228         !EC_POINT_point2cbb(&public_key, key->group, key->pub_key,
229                             key->conv_form, NULL) ||
230         !CBB_flush(&ec_private_key)) {
231       OPENSSL_PUT_ERROR(EC, EC_R_ENCODE_ERROR);
232       return 0;
233     }
234   }
235 
236   if (!CBB_flush(cbb)) {
237     OPENSSL_PUT_ERROR(EC, EC_R_ENCODE_ERROR);
238     return 0;
239   }
240 
241   return 1;
242 }
243 
244 // is_unsigned_integer returns one if |cbs| is a valid unsigned DER INTEGER and
245 // zero otherwise.
is_unsigned_integer(const CBS * cbs)246 static int is_unsigned_integer(const CBS *cbs) {
247   if (CBS_len(cbs) == 0) {
248     return 0;
249   }
250   uint8_t byte = CBS_data(cbs)[0];
251   if ((byte & 0x80) ||
252       (byte == 0 && CBS_len(cbs) > 1 && (CBS_data(cbs)[1] & 0x80) == 0)) {
253     // Negative or not minimally-encoded.
254     return 0;
255   }
256   return 1;
257 }
258 
259 // kPrimeFieldOID is the encoding of 1.2.840.10045.1.1.
260 static const uint8_t kPrimeField[] = {0x2a, 0x86, 0x48, 0xce, 0x3d, 0x01, 0x01};
261 
parse_explicit_prime_curve(CBS * in,CBS * out_prime,CBS * out_a,CBS * out_b,CBS * out_base_x,CBS * out_base_y,CBS * out_order)262 static int parse_explicit_prime_curve(CBS *in, CBS *out_prime, CBS *out_a,
263                                       CBS *out_b, CBS *out_base_x,
264                                       CBS *out_base_y, CBS *out_order) {
265   // See RFC 3279, section 2.3.5. Note that RFC 3279 calls this structure an
266   // ECParameters while RFC 5480 calls it a SpecifiedECDomain.
267   CBS params, field_id, field_type, curve, base, cofactor;
268   int has_cofactor;
269   uint64_t version;
270   if (!CBS_get_asn1(in, &params, CBS_ASN1_SEQUENCE) ||
271       !CBS_get_asn1_uint64(&params, &version) ||
272       version != 1 ||
273       !CBS_get_asn1(&params, &field_id, CBS_ASN1_SEQUENCE) ||
274       !CBS_get_asn1(&field_id, &field_type, CBS_ASN1_OBJECT) ||
275       CBS_len(&field_type) != sizeof(kPrimeField) ||
276       OPENSSL_memcmp(CBS_data(&field_type), kPrimeField, sizeof(kPrimeField)) !=
277           0 ||
278       !CBS_get_asn1(&field_id, out_prime, CBS_ASN1_INTEGER) ||
279       !is_unsigned_integer(out_prime) ||
280       CBS_len(&field_id) != 0 ||
281       !CBS_get_asn1(&params, &curve, CBS_ASN1_SEQUENCE) ||
282       !CBS_get_asn1(&curve, out_a, CBS_ASN1_OCTETSTRING) ||
283       !CBS_get_asn1(&curve, out_b, CBS_ASN1_OCTETSTRING) ||
284       // |curve| has an optional BIT STRING seed which we ignore.
285       !CBS_get_optional_asn1(&curve, NULL, NULL, CBS_ASN1_BITSTRING) ||
286       CBS_len(&curve) != 0 ||
287       !CBS_get_asn1(&params, &base, CBS_ASN1_OCTETSTRING) ||
288       !CBS_get_asn1(&params, out_order, CBS_ASN1_INTEGER) ||
289       !is_unsigned_integer(out_order) ||
290       !CBS_get_optional_asn1(&params, &cofactor, &has_cofactor,
291                              CBS_ASN1_INTEGER) ||
292       CBS_len(&params) != 0) {
293     OPENSSL_PUT_ERROR(EC, EC_R_DECODE_ERROR);
294     return 0;
295   }
296 
297   if (has_cofactor) {
298     // We only support prime-order curves so the cofactor must be one.
299     if (CBS_len(&cofactor) != 1 ||
300         CBS_data(&cofactor)[0] != 1) {
301       OPENSSL_PUT_ERROR(EC, EC_R_UNKNOWN_GROUP);
302       return 0;
303     }
304   }
305 
306   // Require that the base point use uncompressed form.
307   uint8_t form;
308   if (!CBS_get_u8(&base, &form) || form != POINT_CONVERSION_UNCOMPRESSED) {
309     OPENSSL_PUT_ERROR(EC, EC_R_INVALID_FORM);
310     return 0;
311   }
312 
313   if (CBS_len(&base) % 2 != 0) {
314     OPENSSL_PUT_ERROR(EC, EC_R_DECODE_ERROR);
315     return 0;
316   }
317   size_t field_len = CBS_len(&base) / 2;
318   CBS_init(out_base_x, CBS_data(&base), field_len);
319   CBS_init(out_base_y, CBS_data(&base) + field_len, field_len);
320 
321   return 1;
322 }
323 
324 // integers_equal returns one if |a| and |b| are equal, up to leading zeros, and
325 // zero otherwise.
integers_equal(const CBS * a,const uint8_t * b,size_t b_len)326 static int integers_equal(const CBS *a, const uint8_t *b, size_t b_len) {
327   // Remove leading zeros from |a| and |b|.
328   CBS a_copy = *a;
329   while (CBS_len(&a_copy) > 0 && CBS_data(&a_copy)[0] == 0) {
330     CBS_skip(&a_copy, 1);
331   }
332   while (b_len > 0 && b[0] == 0) {
333     b++;
334     b_len--;
335   }
336   return CBS_mem_equal(&a_copy, b, b_len);
337 }
338 
EC_KEY_parse_curve_name(CBS * cbs)339 EC_GROUP *EC_KEY_parse_curve_name(CBS *cbs) {
340   CBS named_curve;
341   if (!CBS_get_asn1(cbs, &named_curve, CBS_ASN1_OBJECT)) {
342     OPENSSL_PUT_ERROR(EC, EC_R_DECODE_ERROR);
343     return NULL;
344   }
345 
346   // Look for a matching curve.
347   const struct built_in_curves *const curves = OPENSSL_built_in_curves();
348   for (size_t i = 0; i < OPENSSL_NUM_BUILT_IN_CURVES; i++) {
349     const struct built_in_curve *curve = &curves->curves[i];
350     if (CBS_len(&named_curve) == curve->oid_len &&
351         OPENSSL_memcmp(CBS_data(&named_curve), curve->oid, curve->oid_len) ==
352             0) {
353       return EC_GROUP_new_by_curve_name(curve->nid);
354     }
355   }
356 
357   OPENSSL_PUT_ERROR(EC, EC_R_UNKNOWN_GROUP);
358   return NULL;
359 }
360 
EC_KEY_marshal_curve_name(CBB * cbb,const EC_GROUP * group)361 int EC_KEY_marshal_curve_name(CBB *cbb, const EC_GROUP *group) {
362   int nid = EC_GROUP_get_curve_name(group);
363   if (nid == NID_undef) {
364     OPENSSL_PUT_ERROR(EC, EC_R_UNKNOWN_GROUP);
365     return 0;
366   }
367 
368   const struct built_in_curves *const curves = OPENSSL_built_in_curves();
369   for (size_t i = 0; i < OPENSSL_NUM_BUILT_IN_CURVES; i++) {
370     const struct built_in_curve *curve = &curves->curves[i];
371     if (curve->nid == nid) {
372       CBB child;
373       return CBB_add_asn1(cbb, &child, CBS_ASN1_OBJECT) &&
374              CBB_add_bytes(&child, curve->oid, curve->oid_len) &&
375              CBB_flush(cbb);
376     }
377   }
378 
379   OPENSSL_PUT_ERROR(EC, EC_R_UNKNOWN_GROUP);
380   return 0;
381 }
382 
EC_KEY_parse_parameters(CBS * cbs)383 EC_GROUP *EC_KEY_parse_parameters(CBS *cbs) {
384   if (!CBS_peek_asn1_tag(cbs, CBS_ASN1_SEQUENCE)) {
385     return EC_KEY_parse_curve_name(cbs);
386   }
387 
388   // OpenSSL sometimes produces ECPrivateKeys with explicitly-encoded versions
389   // of named curves.
390   //
391   // TODO(davidben): Remove support for this.
392   CBS prime, a, b, base_x, base_y, order;
393   if (!parse_explicit_prime_curve(cbs, &prime, &a, &b, &base_x, &base_y,
394                                   &order)) {
395     return NULL;
396   }
397 
398   // Look for a matching prime curve.
399   const struct built_in_curves *const curves = OPENSSL_built_in_curves();
400   for (size_t i = 0; i < OPENSSL_NUM_BUILT_IN_CURVES; i++) {
401     const struct built_in_curve *curve = &curves->curves[i];
402     const unsigned param_len = curve->param_len;
403     // |curve->params| is ordered p, a, b, x, y, order, each component
404     // zero-padded up to the field length. Although SEC 1 states that the
405     // Field-Element-to-Octet-String conversion also pads, OpenSSL mis-encodes
406     // |a| and |b|, so this comparison must allow omitting leading zeros. (This
407     // is relevant for P-521 whose |b| has a leading 0.)
408     if (integers_equal(&prime, curve->params, param_len) &&
409         integers_equal(&a, curve->params + param_len, param_len) &&
410         integers_equal(&b, curve->params + param_len * 2, param_len) &&
411         integers_equal(&base_x, curve->params + param_len * 3, param_len) &&
412         integers_equal(&base_y, curve->params + param_len * 4, param_len) &&
413         integers_equal(&order, curve->params + param_len * 5, param_len)) {
414       return EC_GROUP_new_by_curve_name(curve->nid);
415     }
416   }
417 
418   OPENSSL_PUT_ERROR(EC, EC_R_UNKNOWN_GROUP);
419   return NULL;
420 }
421 
EC_POINT_point2cbb(CBB * out,const EC_GROUP * group,const EC_POINT * point,point_conversion_form_t form,BN_CTX * ctx)422 int EC_POINT_point2cbb(CBB *out, const EC_GROUP *group, const EC_POINT *point,
423                        point_conversion_form_t form, BN_CTX *ctx) {
424   size_t len = EC_POINT_point2oct(group, point, form, NULL, 0, ctx);
425   if (len == 0) {
426     return 0;
427   }
428   uint8_t *p;
429   return CBB_add_space(out, &p, len) &&
430          EC_POINT_point2oct(group, point, form, p, len, ctx) == len;
431 }
432 
d2i_ECPrivateKey(EC_KEY ** out,const uint8_t ** inp,long len)433 EC_KEY *d2i_ECPrivateKey(EC_KEY **out, const uint8_t **inp, long len) {
434   // This function treats its |out| parameter differently from other |d2i|
435   // functions. If supplied, take the group from |*out|.
436   const EC_GROUP *group = NULL;
437   if (out != NULL && *out != NULL) {
438     group = EC_KEY_get0_group(*out);
439   }
440 
441   if (len < 0) {
442     OPENSSL_PUT_ERROR(EC, EC_R_DECODE_ERROR);
443     return NULL;
444   }
445   CBS cbs;
446   CBS_init(&cbs, *inp, (size_t)len);
447   EC_KEY *ret = EC_KEY_parse_private_key(&cbs, group);
448   if (ret == NULL) {
449     return NULL;
450   }
451   if (out != NULL) {
452     EC_KEY_free(*out);
453     *out = ret;
454   }
455   *inp = CBS_data(&cbs);
456   return ret;
457 }
458 
i2d_ECPrivateKey(const EC_KEY * key,uint8_t ** outp)459 int i2d_ECPrivateKey(const EC_KEY *key, uint8_t **outp) {
460   CBB cbb;
461   if (!CBB_init(&cbb, 0) ||
462       !EC_KEY_marshal_private_key(&cbb, key, EC_KEY_get_enc_flags(key))) {
463     CBB_cleanup(&cbb);
464     return -1;
465   }
466   return CBB_finish_i2d(&cbb, outp);
467 }
468 
d2i_ECParameters(EC_KEY ** out_key,const uint8_t ** inp,long len)469 EC_KEY *d2i_ECParameters(EC_KEY **out_key, const uint8_t **inp, long len) {
470   if (len < 0) {
471     return NULL;
472   }
473 
474   CBS cbs;
475   CBS_init(&cbs, *inp, (size_t)len);
476   EC_GROUP *group = EC_KEY_parse_parameters(&cbs);
477   if (group == NULL) {
478     return NULL;
479   }
480 
481   EC_KEY *ret = EC_KEY_new();
482   if (ret == NULL || !EC_KEY_set_group(ret, group)) {
483     EC_GROUP_free(group);
484     EC_KEY_free(ret);
485     return NULL;
486   }
487   EC_GROUP_free(group);
488 
489   if (out_key != NULL) {
490     EC_KEY_free(*out_key);
491     *out_key = ret;
492   }
493   *inp = CBS_data(&cbs);
494   return ret;
495 }
496 
i2d_ECParameters(const EC_KEY * key,uint8_t ** outp)497 int i2d_ECParameters(const EC_KEY *key, uint8_t **outp) {
498   if (key == NULL || key->group == NULL) {
499     OPENSSL_PUT_ERROR(EC, ERR_R_PASSED_NULL_PARAMETER);
500     return -1;
501   }
502 
503   CBB cbb;
504   if (!CBB_init(&cbb, 0) ||
505       !EC_KEY_marshal_curve_name(&cbb, key->group)) {
506     CBB_cleanup(&cbb);
507     return -1;
508   }
509   return CBB_finish_i2d(&cbb, outp);
510 }
511 
o2i_ECPublicKey(EC_KEY ** keyp,const uint8_t ** inp,long len)512 EC_KEY *o2i_ECPublicKey(EC_KEY **keyp, const uint8_t **inp, long len) {
513   EC_KEY *ret = NULL;
514 
515   if (keyp == NULL || *keyp == NULL || (*keyp)->group == NULL) {
516     OPENSSL_PUT_ERROR(EC, ERR_R_PASSED_NULL_PARAMETER);
517     return NULL;
518   }
519   ret = *keyp;
520   if (ret->pub_key == NULL &&
521       (ret->pub_key = EC_POINT_new(ret->group)) == NULL) {
522     OPENSSL_PUT_ERROR(EC, ERR_R_MALLOC_FAILURE);
523     return NULL;
524   }
525   if (!EC_POINT_oct2point(ret->group, ret->pub_key, *inp, len, NULL)) {
526     OPENSSL_PUT_ERROR(EC, ERR_R_EC_LIB);
527     return NULL;
528   }
529   // save the point conversion form
530   ret->conv_form = (point_conversion_form_t)(*inp[0] & ~0x01);
531   *inp += len;
532   return ret;
533 }
534 
i2o_ECPublicKey(const EC_KEY * key,uint8_t ** outp)535 int i2o_ECPublicKey(const EC_KEY *key, uint8_t **outp) {
536   size_t buf_len = 0;
537   int new_buffer = 0;
538 
539   if (key == NULL) {
540     OPENSSL_PUT_ERROR(EC, ERR_R_PASSED_NULL_PARAMETER);
541     return 0;
542   }
543 
544   buf_len = EC_POINT_point2oct(key->group, key->pub_key, key->conv_form, NULL,
545                                0, NULL);
546 
547   if (outp == NULL || buf_len == 0) {
548     // out == NULL => just return the length of the octet string
549     return buf_len;
550   }
551 
552   if (*outp == NULL) {
553     *outp = OPENSSL_malloc(buf_len);
554     if (*outp == NULL) {
555       OPENSSL_PUT_ERROR(EC, ERR_R_MALLOC_FAILURE);
556       return 0;
557     }
558     new_buffer = 1;
559   }
560   if (!EC_POINT_point2oct(key->group, key->pub_key, key->conv_form, *outp,
561                           buf_len, NULL)) {
562     OPENSSL_PUT_ERROR(EC, ERR_R_EC_LIB);
563     if (new_buffer) {
564       OPENSSL_free(*outp);
565       *outp = NULL;
566     }
567     return 0;
568   }
569 
570   if (!new_buffer) {
571     *outp += buf_len;
572   }
573   return buf_len;
574 }
575