• Home
  • Raw
  • Download

Lines Matching refs:your

16 First create a branch for your changes:
23 After making your changes, create a commit
30 If your branch gets out of date, you will need to update it:
47 Unit tests are best, but if your change touches rendering and you can't think of
48 an automated way to verify the results, consider writing a GM test. Also, if your
55 For your code to be accepted into the codebase, you must complete the
61 and send it to us as described on that page. Add your (or your organization's)
62 name and contact info to the AUTHORS file as a part of your CL.
80 Use `git cl` to upload your change:
92 (https://skia-review.googlesource.com/c/4559/), indicating where your changelist
99 ask a committer. After uploading your CL to [Gerrit](https://skia-review.googlesource.com/),
121 add any optional notes, and send your change off for review by clicking on
122 **Send**. Unless you send your change to reviewers, no one will know to look
138 take such suggestions personally or as a commentary on your abilities or ideas.
158 each of their comments). When the reviewer is happy with your patch, they will
159 approve your change by setting the Code-Review label to "+1".
161 _Note_: As you work through the review process, both you and your reviewers
164 Once your change has received an approval, you can click the "Submit to CQ"
165 button on the codereview page and it will be committed on your behalf.
167 Once your commit has gone in, you should delete the branch containing your change:
177 output can break Chromium. If your change alters rendering in any way, you are
187 your friendly Skia-Blink engineer to evaluate, rebaseline, and land your
198 Check in your changes
204 commit your change directly to Skia's repository.
207 first of all, thanks for submitting your patch! We really appreciate these
209 click the "Submit to CQ" button and submit your patch via the commit queue.
212 by uploading a new codereview containing your patch (perhaps with some small
213 adjustments at his/her discretion). If so, you can mark your change as
221 …`git-cl` will squash all your commits into a single one with the description you used when you upl…