• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 //===-- RenderScriptx86ABIFixups.cpp --------------------------------------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8 
9 #include <set>
10 
11 #include "llvm/ADT/StringRef.h"
12 #include "llvm/IR/BasicBlock.h"
13 #include "llvm/IR/Constants.h"
14 #include "llvm/IR/Function.h"
15 #include "llvm/IR/Instruction.h"
16 #include "llvm/IR/Instructions.h"
17 #include "llvm/IR/Module.h"
18 #include "llvm/IRReader/IRReader.h"
19 #include "llvm/Pass.h"
20 
21 #include "lldb/Target/Process.h"
22 #include "lldb/Utility/Log.h"
23 
24 using namespace lldb_private;
25 namespace {
26 
isRSAPICall(llvm::Module & module,llvm::CallInst * call_inst)27 bool isRSAPICall(llvm::Module &module, llvm::CallInst *call_inst) {
28   // TODO get the list of renderscript modules from lldb and check if
29   // this llvm::Module calls into any of them.
30   (void)module;
31   const auto func_name = call_inst->getCalledFunction()->getName();
32   if (func_name.startswith("llvm") || func_name.startswith("lldb"))
33     return false;
34 
35   if (call_inst->getCalledFunction()->isIntrinsic())
36     return false;
37 
38   return true;
39 }
40 
isRSLargeReturnCall(llvm::Module & module,llvm::CallInst * call_inst)41 bool isRSLargeReturnCall(llvm::Module &module, llvm::CallInst *call_inst) {
42   // i686 and x86_64 returns for large vectors in the RenderScript API are not
43   // handled as normal register pairs, but as a hidden sret type. This is not
44   // reflected in the debug info or mangled symbol name, and the android ABI
45   // for x86 and x86_64, (as well as the emulators) specifies there is no AVX,
46   // so bcc generates an sret function because we cannot natively return
47   // 256 bit vectors.
48   // This function simply checks whether a function has a > 128bit return type.
49   // It is perhaps an unreliable heuristic, and relies on bcc not generating
50   // AVX code, so if the android ABI one day provides for AVX, this function
51   // may go out of fashion.
52   (void)module;
53   if (!call_inst || !call_inst->getCalledFunction())
54     return false;
55 
56   return call_inst->getCalledFunction()
57              ->getReturnType()
58              ->getPrimitiveSizeInBits() > 128;
59 }
60 
isRSAllocationPtrTy(const llvm::Type * type)61 bool isRSAllocationPtrTy(const llvm::Type *type) {
62   if (!type->isPointerTy())
63     return false;
64   auto ptr_type = type->getPointerElementType();
65 
66   return ptr_type->isStructTy() &&
67          ptr_type->getStructName().startswith("struct.rs_allocation");
68 }
69 
isRSAllocationTyCallSite(llvm::Module & module,llvm::CallInst * call_inst)70 bool isRSAllocationTyCallSite(llvm::Module &module, llvm::CallInst *call_inst) {
71   (void)module;
72   if (!call_inst->hasByValArgument())
73     return false;
74   for (const auto *param : call_inst->operand_values())
75     if (isRSAllocationPtrTy(param->getType()))
76       return true;
77   return false;
78 }
79 
cloneToStructRetFnTy(llvm::CallInst * call_inst)80 llvm::FunctionType *cloneToStructRetFnTy(llvm::CallInst *call_inst) {
81   // on x86 StructReturn functions return a pointer to the return value, rather
82   // than the return value itself
83   // [ref](http://www.agner.org/optimize/calling_conventions.pdf section 6). We
84   // create a return type by getting the pointer type of the old return type,
85   // and inserting a new initial argument of pointer type of the original
86   // return type.
87   Log *log(
88       GetLogIfAnyCategoriesSet(LIBLLDB_LOG_LANGUAGE | LIBLLDB_LOG_EXPRESSIONS));
89 
90   assert(call_inst && "no CallInst");
91   llvm::Function *orig = call_inst->getCalledFunction();
92   assert(orig && "CallInst has no called function");
93   llvm::FunctionType *orig_type = orig->getFunctionType();
94   auto name = orig->getName();
95   LLDB_LOGF(log, "%s - cloning to StructRet function for '%s'", __FUNCTION__,
96             name.str().c_str());
97 
98   unsigned num_params = orig_type->getNumParams();
99   std::vector<llvm::Type *> new_params{num_params + 1, nullptr};
100   std::vector<llvm::Type *> params{orig_type->param_begin(),
101                                    orig_type->param_end()};
102 
103   // This may not work if the function is somehow declared void as llvm is
104   // strongly typed and represents void* with i8*
105   assert(!orig_type->getReturnType()->isVoidTy() &&
106          "Cannot add StructRet attribute to void function");
107   llvm::PointerType *return_type_ptr_type =
108       llvm::PointerType::getUnqual(orig->getReturnType());
109   assert(return_type_ptr_type &&
110          "failed to get function return type PointerType");
111   if (!return_type_ptr_type)
112     return nullptr;
113 
114   LLDB_LOGF(log,
115             "%s - return type pointer type for StructRet clone @ '0x%p':\n",
116             __FUNCTION__, (void *)return_type_ptr_type);
117   // put the sret pointer argument in place at the beginning of the
118   // argument list.
119   params.emplace(params.begin(), return_type_ptr_type);
120   assert(params.size() == num_params + 1);
121   return llvm::FunctionType::get(return_type_ptr_type, params,
122                                  orig->isVarArg());
123 }
124 
findRSCallSites(llvm::Module & module,std::set<llvm::CallInst * > & rs_callsites,bool (* predicate)(llvm::Module &,llvm::CallInst *))125 bool findRSCallSites(llvm::Module &module,
126                      std::set<llvm::CallInst *> &rs_callsites,
127                      bool (*predicate)(llvm::Module &, llvm::CallInst *)) {
128   bool found = false;
129 
130   for (auto &func : module.getFunctionList())
131     for (auto &block : func.getBasicBlockList())
132       for (auto &inst : block) {
133         llvm::CallInst *call_inst =
134             llvm::dyn_cast_or_null<llvm::CallInst>(&inst);
135         if (!call_inst || !call_inst->getCalledFunction())
136           // This is not the call-site you are looking for...
137           continue;
138         if (isRSAPICall(module, call_inst) && predicate(module, call_inst)) {
139           rs_callsites.insert(call_inst);
140           found = true;
141         }
142       }
143   return found;
144 }
145 
fixupX86StructRetCalls(llvm::Module & module)146 bool fixupX86StructRetCalls(llvm::Module &module) {
147   bool changed = false;
148   // changing a basic block while iterating over it seems to have some
149   // undefined behaviour going on so we find all RS callsites first, then fix
150   // them up after consuming the iterator.
151   std::set<llvm::CallInst *> rs_callsites;
152   if (!findRSCallSites(module, rs_callsites, isRSLargeReturnCall))
153     return false;
154 
155   for (auto call_inst : rs_callsites) {
156     llvm::FunctionType *new_func_type = cloneToStructRetFnTy(call_inst);
157     assert(new_func_type &&
158            "failed to clone functionType for Renderscript ABI fixup");
159 
160     llvm::Function *func = call_inst->getCalledFunction();
161     assert(func && "cannot resolve function in RenderScriptRuntime");
162     // Copy the original call arguments
163     std::vector<llvm::Value *> new_call_args(call_inst->arg_begin(),
164                                              call_inst->arg_end());
165 
166     // Allocate enough space to store the return value of the original function
167     // we pass a pointer to this allocation as the StructRet param, and then
168     // copy its value into the lldb return value
169     const llvm::DataLayout &DL = module.getDataLayout();
170     llvm::AllocaInst *return_value_alloc = new llvm::AllocaInst(
171       func->getReturnType(), DL.getAllocaAddrSpace(), "var_vector_return_alloc",
172       call_inst);
173     // use the new allocation as the new first argument
174     new_call_args.emplace(new_call_args.begin(),
175                           llvm::cast<llvm::Value>(return_value_alloc));
176     llvm::PointerType *new_func_ptr_type =
177         llvm::PointerType::get(new_func_type, 0);
178     // Create the type cast from the old function type to the new one
179     llvm::Constant *new_func_cast = llvm::ConstantExpr::getCast(
180         llvm::Instruction::BitCast, func, new_func_ptr_type);
181     // create an allocation for a new function pointer
182     llvm::AllocaInst *new_func_ptr =
183         new llvm::AllocaInst(new_func_ptr_type, DL.getAllocaAddrSpace(),
184                              "new_func_ptr", call_inst);
185     // store the new_func_cast to the newly allocated space
186     (new llvm::StoreInst(new_func_cast, new_func_ptr, call_inst))
187         ->setName("new_func_ptr_load_cast");
188     // load the new function address ready for a jump
189     llvm::LoadInst *new_func_addr_load =
190         new llvm::LoadInst(new_func_ptr->getType()->getPointerElementType(),
191                            new_func_ptr, "load_func_pointer", call_inst);
192     // and create a callinstruction from it
193     llvm::CallInst *new_call_inst =
194         llvm::CallInst::Create(new_func_type, new_func_addr_load, new_call_args,
195                                "new_func_call", call_inst);
196     new_call_inst->setCallingConv(call_inst->getCallingConv());
197     new_call_inst->setTailCall(call_inst->isTailCall());
198     llvm::LoadInst *lldb_save_result_address = new llvm::LoadInst(
199         return_value_alloc->getType()->getPointerElementType(),
200         return_value_alloc, "save_return_val", call_inst);
201 
202     // Now remove the old broken call
203     call_inst->replaceAllUsesWith(lldb_save_result_address);
204     call_inst->eraseFromParent();
205     changed = true;
206   }
207   return changed;
208 }
209 
fixupRSAllocationStructByValCalls(llvm::Module & module)210 bool fixupRSAllocationStructByValCalls(llvm::Module &module) {
211   // On x86_64, calls to functions in the RS runtime that take an
212   // `rs_allocation` type argument are actually handled as by-ref params by
213   // bcc, but appear to be passed by value by lldb (the callsite all use
214   // `struct byval`). On x86_64 Linux, struct arguments are transferred in
215   // registers if the struct size is no bigger than 128bits
216   // [ref](http://www.agner.org/optimize/calling_conventions.pdf) section 7.1
217   // "Passing and returning objects" otherwise passed on the stack. an object
218   // of type `rs_allocation` is actually 256bits, so should be passed on the
219   // stack. However, code generated by bcc actually treats formal params of
220   // type `rs_allocation` as `rs_allocation *` so we need to convert the
221   // calling convention to pass by reference, and remove any hint of byval from
222   // formal parameters.
223   bool changed = false;
224   std::set<llvm::CallInst *> rs_callsites;
225   if (!findRSCallSites(module, rs_callsites, isRSAllocationTyCallSite))
226     return false;
227 
228   std::set<llvm::Function *> rs_functions;
229 
230   // for all call instructions
231   for (auto call_inst : rs_callsites) {
232     // add the called function to a set so that we can strip its byval
233     // attributes in another pass
234     rs_functions.insert(call_inst->getCalledFunction());
235 
236     // get the function attributes
237     llvm::AttributeList call_attribs = call_inst->getAttributes();
238 
239     // iterate over the argument attributes
240     for (unsigned I = call_attribs.index_begin(); I != call_attribs.index_end();
241          I++) {
242       // if this argument is passed by val
243       if (call_attribs.hasAttribute(I, llvm::Attribute::ByVal)) {
244         // strip away the byval attribute
245         call_inst->removeAttribute(I, llvm::Attribute::ByVal);
246         changed = true;
247       }
248     }
249   }
250 
251   // for all called function decls
252   for (auto func : rs_functions) {
253     // inspect all of the arguments in the call
254     for (auto &arg : func->args()) {
255       if (arg.hasByValAttr()) {
256         arg.removeAttr(llvm::Attribute::ByVal);
257         changed = true;
258       }
259     }
260   }
261   return changed;
262 }
263 } // end anonymous namespace
264 
265 namespace lldb_private {
266 namespace lldb_renderscript {
267 
fixupX86FunctionCalls(llvm::Module & module)268 bool fixupX86FunctionCalls(llvm::Module &module) {
269   return fixupX86StructRetCalls(module);
270 }
271 
fixupX86_64FunctionCalls(llvm::Module & module)272 bool fixupX86_64FunctionCalls(llvm::Module &module) {
273   bool changed = false;
274   changed |= fixupX86StructRetCalls(module);
275   changed |= fixupRSAllocationStructByValCalls(module);
276   return changed;
277 }
278 
279 } // end namespace lldb_renderscript
280 } // end namespace lldb_private
281