Searched refs:review (Results 1 – 25 of 439) sorted by relevance
12345678910>>...18
| /external/skia/ |
| D | RELEASE_NOTES.txt | 11 https://review.skia.org/406140
14 https://review.skia.org/402957
17 https://review.skia.org/401816
21 https://review.skia.org/398222
30 https://review.skia.org/402156
38 https://review.skia.org/378496
47 https://review.skia.org/391856
51 https://review.skia.org/393081
58 https://review.skia.org/372556
61 https://review.skia.org/368621
[all …]
|
| /external/skia/site/docs/user/release/ |
| D | release_notes.md | 17 https://review.skia.org/378496
26 https://review.skia.org/391856
30 https://review.skia.org/393081
38 https://review.skia.org/399077
45 https://review.skia.org/372556
48 https://review.skia.org/368621
49 https://review.skia.org/369317
50 https://review.skia.org/371958
54 https://review.skia.org/366318
63 https://review.skia.org/361496
[all …]
|
| /external/llvm-project/llvm/docs/ |
| D | CodeReview.rst | 5 LLVM's code-review policy and practices help maintain high code quality across
6 the project. Specifically, our code review process aims to:
13 It is important for all contributors to understand our code-review
14 practices and participate in the code-review process.
32 be committed prior to an explicit review. In situations where there is any
36 responsible for making all necessary review-related changes, including
37 those requested during any post-commit review.
42 Post-commit review is encouraged, and can be accomplished using any of the
49 pre-commit review (including around the need for more design discussions),
52 developer asking for more review prevents any lingering disagreement over
[all …]
|
| D | Phabricator.rst | 14 is the system of record for all LLVM code review. The mailing list should be
33 Requesting a review via the command line
58 .. _phabricator-request-review-web:
60 Requesting a review via the web interface
63 The tool to create and review patches in Phabricator is called
73 will automatically send a diff with a smaller context in the review
93 later, when sending the review.)
108 * Select the review you want to from the *Attach To* dropdown and click
111 for the review request.)
136 responsibility for making sure the review happens.
[all …]
|
| D | Contributing.rst | 64 Before sending a patch for review, please also try to ensure it is
93 Please follow :ref:`Phabricator#requesting-a-review-via-the-web-interface <phabricator-request-rev…
94 to request a review using Phabricator.
97 and add them to your patch when requesting a review. Suitable reviewers are the
100 when creating a review and if you are using `llvm-commits`, add them to the CC of
103 A reviewer may request changes or ask questions during the review. If you are
105 for guidance during the review. Please address the feedback and re-post an
109 access, please let people know during the review and someone should commit it
113 review by 'ping'ing a patch by responding to the email thread containing the
114 patch, or the Phabricator review with "Ping." The common courtesy 'ping' rate
[all …]
|
| /external/angle/doc/ |
| D | CodeReviewProcess.md | 3 This page describes the review process for ANGLE reviewers and committers. For
4 instructions on submitting your change list for review, please see
12 1. To review a change, you can either navigate directly to the URL for the CL,
14 your dashboard at https://chromium-review.googlesource.com/
27 3. Once your review is complete, click the "Review" button
29 review (Code-Review +1 or +2).
31 comments and a neutral review. (Code-Review 0)
33 review. (Code-Review -1 or -2)
34 * A +2 code review is required before landing. Only ANGLE committers may
35 provide a +2 code review.
[all …]
|
| D | ContributingCode.md | 25 3. Should be a reasonable size to review. Giant patches are unlikely to get reviewed quickly.
61 * Wait for the bots to report the result on the code review page. The bot results should be
122 1. Go to [https://chromium-review.googlesource.com/new-password][CR-passwd]
126 * Visit [https://chromium-review.googlesource.com/#/settings][CR-settings] and check the "Full
131 CL with a particular review, and track dependencies between commits.
133 [https://chromium-review.googlesource.com/tools/hooks/commit-msg][commit-msg-hook] and copy
137 not currently be used with changes intended for review.
139 [CR-passwd]: https://chromium-review.googlesource.com/new-password
140 [CR-settings]: https://chromium-review.googlesource.com/#/settings
141 [commit-msg-hook]: https://chromium-review.googlesource.com/tools/hooks/commit-msg
[all …]
|
| D | Update20131120.md | 6 The review process for contributed code has moved from [Rietveld](https://codereview.appspot.com/)
7 to [Gerrit](https://chromium-review.googlesource.com). This migration allows us to more
|
| /external/llvm/docs/ |
| D | Phabricator.rst | 12 is the system of record for all LLVM code review. The mailing list should be
31 Requesting a review via the command line
41 Requesting a review via the web interface
44 The tool to create and review patches in Phabricator is called
50 will automatically send a diff with a smaller context in the review
70 lists that you want to be included in the review. If your patch is
81 * Select the review you want to from the *Attach To* dropdown and click
102 responsibility for making sure the review happens.
123 when a review changes state, for example by clicking "Accept Revision" in
138 where ``<URL>`` is the URL for the code review, starting with
[all …]
|
| /external/llvm-project/llvm/utils/Reviewing/ |
| D | find_interesting_reviews.py | 370 for review in newest_reviews:
371 if datetime.fromtimestamp(review.dateModified) < cut_off_date:
373 result.append(review)
414 for i, review in enumerate(newest_reviews):
415 matched_reviewers = find_reviewers_for_review(review)
421 i, review.id,
422 get_real_name_from_author(review.author), review.title,
423 datetime.fromtimestamp(review.dateModified)))
430 reviewer2reviews_and_scores[reviewer].append((review, scores))
438 for review, scores in reviews_and_scores:
[all …]
|
| /external/skia/site/docs/dev/contrib/ |
| D | submit.md | 62 review! Submit a patch and getting it reviewed is fairly easy with depot tools.
80 ### Uploading changes for review
82 Skia uses the Gerrit code review tool. Skia's instance is
83 [skia-review](http://skia-review.googlesource.com). Use `git cl` to upload your
96 (https://skia-review.googlesource.com/c/4559/), indicating where your changelist
104 [Gerrit](https://skia-review.googlesource.com/), you may trigger a try job for
121 ### Request review
123 Go to the supplied URL or go to the code review page and select the **Your**
125 review and click **Reply**. Enter at least one reviewer's email address. Now add
126 any optional notes, and send your change off for review by clicking on **Send**.
[all …]
|
| /external/skqp/site/dev/contrib/ |
| D | submit.md | 65 review! Submit a patch and getting it reviewed is fairly easy with depot tools.
77 ### Uploading changes for review
79 Skia uses the Gerrit code review tool. Skia's instance is [skia-review](http://skia-review.googleso…
92 (https://skia-review.googlesource.com/c/4559/), indicating where your changelist
99 ask a committer. After uploading your CL to [Gerrit](https://skia-review.googlesource.com/),
116 ### Request review
118 Go to the supplied URL or go to the code review page and select the **Your**
120 review and click **Reply**. Enter at least one reviewer's email address. Now
121 add any optional notes, and send your change off for review by clicking on
125 _Note_: If you don't see editing commands on the review page, click **Sign in**
[all …]
|
| /external/openscreen/docs/ |
| D | advanced_gerrit.md | 11 review system via `git` if you prefer as follows.
25 curl -Lo .git/hooks/commit-msg https://chromium-review.googlesource.com/tools/hooks/commit-msg
29 ### Uploading a new patch for review
32 review (which primarily checks formatting).
49 describes this. So if you want to upload a new patchset to an existing review,
55 pushed, unless it has a `Change-Id` corresponding to an existing review.
69 `chromium-review.googlesource.com` for the existing review.
80 existing commit that has been uploaded for review.
140 B changes, the review for B will only show the diff from A.
162 M and O are separate patchsets in one review (M containing A, B, C and O
[all …]
|
| /external/boringssl/src/ |
| D | CONTRIBUTING.md | 11 the CLA until after you've submitted your code for review and a member has
18 All submissions, including submissions by project members, require review. We
19 use [Gerrit](https://boringssl-review.googlesource.com) for this purpose.
26 [add Change-Ids](https://gerrit-review.googlesource.com/Documentation/cmd-hook-commit-msg.html)
29 curl -Lo .git/hooks/commit-msg https://boringssl-review.googlesource.com/tools/hooks/commit-msg
44 [Gerrit User Guide](https://gerrit-review.googlesource.com/Documentation/intro-user.html).
|
| /external/arm-trusted-firmware/docs/process/ |
| D | contributing.rst | 8 `developer.trustedfirmware.org`_ and `review.trustedfirmware.org`_.
36 review so this will speed up the review process.
127 - Submit your changes for review at https://review.trustedfirmware.org
143 send an email to the `TF-A mailing list`_ to broadcast your review request
151 - The changes will then undergo further review by the designated people. Any
152 review comments will be made directly on your patch. This may require you to
167 In addition to these various code review labels, the patch must also get a
176 in their review and the reviewer incorporates the review of the additional
220 .. _review.trustedfirmware.org: https://review.trustedfirmware.org
224 .. _Gerrit Uploading Changes documentation: https://review.trustedfirmware.org/Documentation/user-u…
[all …]
|
| D | code-review-guidelines.rst | 4 This document provides TF-A specific details about the project's code review
29 To ensure the code review gives the greatest possible benefit, participants in
39 code review helps everyone in the long run, as it creates a culture of
49 - Answer all comments from people who took the time to review your
56 In the event that a code review takes longer than you would hope for, you
80 There are no good or bad review comments. If you have any doubt about a patch or
82 issue slip. Examples of review comments could be:
135 - Once you are engaged in a review, make sure you stay involved until the patch
137 expected to monitor the patch author's answers to your review comments,
138 answer back if needed and review new revisions of their patch.
[all …]
|
| D | faq.rst | 24 they follow the coding guidelines, have already had some code review, and have
31 * How much opportunity for external review is required. For example, the TF
32 maintainers may not wait for external review comments to merge trivial
78 .. _Gerrit Upload Patch Set documentation: https://review.trustedfirmware.org/Documentation/intro-u…
79 .. _Gerrit Replace Changes documentation: https://review.trustedfirmware.org/Documentation/user-upl…
|
| /external/angle/ |
| D | codereview.settings | 2 CODE_REVIEW_SERVER: https://chromium-review.googlesource.com
4 TRYSERVER_GERRIT_URL: https://chromium-review.googlesource.com
|
| /external/volley/ |
| D | CONTRIBUTING.md | 21 All submissions, including submissions by project members, require review. We
27 ## Preparing a pull request for review
41 Please correct any failures before requesting a review.
|
| /external/bcc/ |
| D | CODEOWNERS | 3 # review code that touches the respective areas, and MUST review it if the
|
| /external/swiftshader/ |
| D | CONTRIBUTING.txt | 12 the CLA until after you've submitted your code for review and a member has
20 All submissions, including submissions by project members, require review.
22 Information on how to sumbit changes for review is provided in README.md.
|
| D | README.md | 53 All changes must be reviewed and approved in the [Gerrit](https://www.gerritcodereview.com/) review…
54 https://swiftshader-review.googlesource.com
57 https://swiftshader-review.googlesource.com/new-password
59 All changes require a [Change-ID](https://gerrit-review.googlesource.com/Documentation/user-changei…
60 https://gerrit-review.googlesource.com/tools/hooks/commit-msg. To clone the repository and install …
62 …er && curl -Lo `git rev-parse --git-dir`/hooks/commit-msg https://gerrit-review.googlesource.com/t…
68 When ready, [add](https://gerrit-review.googlesource.com/Documentation/intro-user.html#adding-revie…
|
| /external/minijail/ |
| D | HACKING.md | 40 We use [Android Review] for Minijail code review. The easiest way to submit
41 changes for review is using `repo upload` on a Chromium OS or Android checkout.
81 [Android Review]: https://android-review.googlesource.com/
82 [Android Review HTTP Credentials]: https://android-review.googlesource.com/settings/#HTTPCredentials
|
| /external/perfetto/docs/contributing/ |
| D | chrome-branches.md | 17 …[Gerrit's branch page](https://android-review.googlesource.com/admin/repos/platform/external/perfe…
30 …[Gerrit's branch page](https://android-review.googlesource.com/admin/repos/platform/external/perfe…
55 1. Send the patch for review and land it. Note the commit's revision hash.
59 1. Create, send for review, and land a Chromium patch that edits the top-level
|
| /external/openscreen/ |
| D | README.md | 232 openscreen uses [Chromium Gerrit](https://chromium-review.googlesource.com/) for
233 patch management and code review (for better or worse).
236 reviews, specifically when pushing patches for review, getting patches reviewed,
239 ## Uploading a patch for review
242 review tool) and is recommended for pushing patches for review. Once you have
252 newcode review will be posted on `chromium-review.googlesource.com`.
256 review as a new patchset.
259 separately. `git cl` keeps track of review status separately for each local
264 If conflicting commits have been landed in the repository for a patch in review,
274 review to avoid extra back-and-forth.
[all …]
|
12345678910>>...18