• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 /*
2  * Copyright 2019 Google Inc.
3  *
4  * Use of this source code is governed by a BSD-style license that can be
5  * found in the LICENSE file.
6  */
7 
8 #include "src/gpu/ops/OpsTask.h"
9 
10 #include "include/gpu/GrRecordingContext.h"
11 #include "src/core/SkRectPriv.h"
12 #include "src/core/SkScopeExit.h"
13 #include "src/core/SkTraceEvent.h"
14 #include "src/gpu/GrAttachment.h"
15 #include "src/gpu/GrAuditTrail.h"
16 #include "src/gpu/GrCaps.h"
17 #include "src/gpu/GrGpu.h"
18 #include "src/gpu/GrMemoryPool.h"
19 #include "src/gpu/GrOpFlushState.h"
20 #include "src/gpu/GrOpsRenderPass.h"
21 #include "src/gpu/GrRecordingContextPriv.h"
22 #include "src/gpu/GrRenderTarget.h"
23 #include "src/gpu/GrResourceAllocator.h"
24 #include "src/gpu/GrResourceProvider.h"
25 #include "src/gpu/GrTexture.h"
26 #include "src/gpu/geometry/GrRect.h"
27 
28 ////////////////////////////////////////////////////////////////////////////////
29 
30 namespace {
31 
32 // Experimentally we have found that most combining occurs within the first 10 comparisons.
33 static const int kMaxOpMergeDistance = 10;
34 static const int kMaxOpChainDistance = 10;
35 
36 ////////////////////////////////////////////////////////////////////////////////
37 
can_reorder(const SkRect & a,const SkRect & b)38 inline bool can_reorder(const SkRect& a, const SkRect& b) { return !GrRectsOverlap(a, b); }
39 
create_render_pass(GrGpu * gpu,GrRenderTarget * rt,bool useMSAASurface,GrAttachment * stencil,GrSurfaceOrigin origin,const SkIRect & bounds,GrLoadOp colorLoadOp,const std::array<float,4> & loadClearColor,GrLoadOp stencilLoadOp,GrStoreOp stencilStoreOp,const SkTArray<GrSurfaceProxy *,true> & sampledProxies,GrXferBarrierFlags renderPassXferBarriers)40 GrOpsRenderPass* create_render_pass(GrGpu* gpu,
41                                     GrRenderTarget* rt,
42                                     bool useMSAASurface,
43                                     GrAttachment* stencil,
44                                     GrSurfaceOrigin origin,
45                                     const SkIRect& bounds,
46                                     GrLoadOp colorLoadOp,
47                                     const std::array<float, 4>& loadClearColor,
48                                     GrLoadOp stencilLoadOp,
49                                     GrStoreOp stencilStoreOp,
50                                     const SkTArray<GrSurfaceProxy*, true>& sampledProxies,
51                                     GrXferBarrierFlags renderPassXferBarriers) {
52     const GrOpsRenderPass::LoadAndStoreInfo kColorLoadStoreInfo {
53         colorLoadOp,
54         GrStoreOp::kStore,
55         loadClearColor
56     };
57 
58     // TODO:
59     // We would like to (at this level) only ever clear & discard. We would need
60     // to stop splitting up higher level OpsTasks for copyOps to achieve that.
61     // Note: we would still need SB loads and stores but they would happen at a
62     // lower level (inside the VK command buffer).
63     const GrOpsRenderPass::StencilLoadAndStoreInfo stencilLoadAndStoreInfo {
64         stencilLoadOp,
65         stencilStoreOp,
66     };
67 
68     return gpu->getOpsRenderPass(rt, useMSAASurface, stencil, origin, bounds, kColorLoadStoreInfo,
69                                  stencilLoadAndStoreInfo, sampledProxies, renderPassXferBarriers);
70 }
71 
72 } // anonymous namespace
73 
74 ////////////////////////////////////////////////////////////////////////////////
75 
76 namespace skgpu::v1 {
77 
List(GrOp::Owner op)78 inline OpsTask::OpChain::List::List(GrOp::Owner op)
79         : fHead(std::move(op)), fTail(fHead.get()) {
80     this->validate();
81 }
82 
List(List && that)83 inline OpsTask::OpChain::List::List(List&& that) { *this = std::move(that); }
84 
operator =(List && that)85 inline OpsTask::OpChain::List& OpsTask::OpChain::List::operator=(List&& that) {
86     fHead = std::move(that.fHead);
87     fTail = that.fTail;
88     that.fTail = nullptr;
89     this->validate();
90     return *this;
91 }
92 
popHead()93 inline GrOp::Owner OpsTask::OpChain::List::popHead() {
94     SkASSERT(fHead);
95     auto temp = fHead->cutChain();
96     std::swap(temp, fHead);
97     if (!fHead) {
98         SkASSERT(fTail == temp.get());
99         fTail = nullptr;
100     }
101     return temp;
102 }
103 
removeOp(GrOp * op)104 inline GrOp::Owner OpsTask::OpChain::List::removeOp(GrOp* op) {
105 #ifdef SK_DEBUG
106     auto head = op;
107     while (head->prevInChain()) { head = head->prevInChain(); }
108     SkASSERT(head == fHead.get());
109 #endif
110     auto prev = op->prevInChain();
111     if (!prev) {
112         SkASSERT(op == fHead.get());
113         return this->popHead();
114     }
115     auto temp = prev->cutChain();
116     if (auto next = temp->cutChain()) {
117         prev->chainConcat(std::move(next));
118     } else {
119         SkASSERT(fTail == op);
120         fTail = prev;
121     }
122     this->validate();
123     return temp;
124 }
125 
pushHead(GrOp::Owner op)126 inline void OpsTask::OpChain::List::pushHead(GrOp::Owner op) {
127     SkASSERT(op);
128     SkASSERT(op->isChainHead());
129     SkASSERT(op->isChainTail());
130     if (fHead) {
131         op->chainConcat(std::move(fHead));
132         fHead = std::move(op);
133     } else {
134         fHead = std::move(op);
135         fTail = fHead.get();
136     }
137 }
138 
pushTail(GrOp::Owner op)139 inline void OpsTask::OpChain::List::pushTail(GrOp::Owner op) {
140     SkASSERT(op->isChainTail());
141     fTail->chainConcat(std::move(op));
142     fTail = fTail->nextInChain();
143 }
144 
validate() const145 inline void OpsTask::OpChain::List::validate() const {
146 #ifdef SK_DEBUG
147     if (fHead) {
148         SkASSERT(fTail);
149         fHead->validateChain(fTail);
150     }
151 #endif
152 }
153 
154 ////////////////////////////////////////////////////////////////////////////////
155 
OpChain(GrOp::Owner op,GrProcessorSet::Analysis processorAnalysis,GrAppliedClip * appliedClip,const GrDstProxyView * dstProxyView)156 OpsTask::OpChain::OpChain(GrOp::Owner op, GrProcessorSet::Analysis processorAnalysis,
157                           GrAppliedClip* appliedClip, const GrDstProxyView* dstProxyView)
158         : fList{std::move(op)}
159         , fProcessorAnalysis(processorAnalysis)
160         , fAppliedClip(appliedClip) {
161     if (fProcessorAnalysis.requiresDstTexture()) {
162         SkASSERT(dstProxyView && dstProxyView->proxy());
163         fDstProxyView = *dstProxyView;
164     }
165     fBounds = fList.head()->bounds();
166 }
167 
visitProxies(const GrVisitProxyFunc & func) const168 void OpsTask::OpChain::visitProxies(const GrVisitProxyFunc& func) const {
169     if (fList.empty()) {
170         return;
171     }
172     for (const auto& op : GrOp::ChainRange<>(fList.head())) {
173         op.visitProxies(func);
174     }
175     if (fDstProxyView.proxy()) {
176         func(fDstProxyView.proxy(), GrMipmapped::kNo);
177     }
178     if (fAppliedClip) {
179         fAppliedClip->visitProxies(func);
180     }
181 }
182 
deleteOps()183 void OpsTask::OpChain::deleteOps() {
184     while (!fList.empty()) {
185         // Since the value goes out of scope immediately, the GrOp::Owner deletes the op.
186         fList.popHead();
187     }
188 }
189 
190 // Concatenates two op chains and attempts to merge ops across the chains. Assumes that we know that
191 // the two chains are chainable. Returns the new chain.
DoConcat(List chainA,List chainB,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)192 OpsTask::OpChain::List OpsTask::OpChain::DoConcat(List chainA, List chainB, const GrCaps& caps,
193                                                   SkArenaAlloc* opsTaskArena,
194                                                   GrAuditTrail* auditTrail) {
195     // We process ops in chain b from head to tail. We attempt to merge with nodes in a, starting
196     // at chain a's tail and working toward the head. We produce one of the following outcomes:
197     // 1) b's head is merged into an op in a.
198     // 2) An op from chain a is merged into b's head. (In this case b's head gets processed again.)
199     // 3) b's head is popped from chain a and added at the tail of a.
200     // After result 3 we don't want to attempt to merge the next head of b with the new tail of a,
201     // as we assume merges were already attempted when chain b was created. So we keep track of the
202     // original tail of a and start our iteration of a there. We also track the bounds of the nodes
203     // appended to chain a that will be skipped for bounds testing. If the original tail of a is
204     // merged into an op in b (case 2) then we advance the "original tail" towards the head of a.
205     GrOp* origATail = chainA.tail();
206     SkRect skipBounds = SkRectPriv::MakeLargestInverted();
207     do {
208         int numMergeChecks = 0;
209         bool merged = false;
210         bool noSkip = (origATail == chainA.tail());
211         SkASSERT(noSkip == (skipBounds == SkRectPriv::MakeLargestInverted()));
212         bool canBackwardMerge = noSkip || can_reorder(chainB.head()->bounds(), skipBounds);
213         SkRect forwardMergeBounds = skipBounds;
214         GrOp* a = origATail;
215         while (a) {
216             bool canForwardMerge =
217                     (a == chainA.tail()) || can_reorder(a->bounds(), forwardMergeBounds);
218             if (canForwardMerge || canBackwardMerge) {
219                 auto result = a->combineIfPossible(chainB.head(), opsTaskArena, caps);
220                 SkASSERT(result != GrOp::CombineResult::kCannotCombine);
221                 merged = (result == GrOp::CombineResult::kMerged);
222                 GrOP_INFO("\t\t: (%s opID: %u) -> Combining with (%s, opID: %u)\n",
223                           chainB.head()->name(), chainB.head()->uniqueID(), a->name(),
224                           a->uniqueID());
225             }
226             if (merged) {
227                 GR_AUDIT_TRAIL_OPS_RESULT_COMBINED(auditTrail, a, chainB.head());
228                 if (canBackwardMerge) {
229                     // The GrOp::Owner releases the op.
230                     chainB.popHead();
231                 } else {
232                     // We merged the contents of b's head into a. We will replace b's head with a in
233                     // chain b.
234                     SkASSERT(canForwardMerge);
235                     if (a == origATail) {
236                         origATail = a->prevInChain();
237                     }
238                     GrOp::Owner detachedA = chainA.removeOp(a);
239                     // The GrOp::Owner releases the op.
240                     chainB.popHead();
241                     chainB.pushHead(std::move(detachedA));
242                     if (chainA.empty()) {
243                         // We merged all the nodes in chain a to chain b.
244                         return chainB;
245                     }
246                 }
247                 break;
248             } else {
249                 if (++numMergeChecks == kMaxOpMergeDistance) {
250                     break;
251                 }
252                 forwardMergeBounds.joinNonEmptyArg(a->bounds());
253                 canBackwardMerge =
254                         canBackwardMerge && can_reorder(chainB.head()->bounds(), a->bounds());
255                 a = a->prevInChain();
256             }
257         }
258         // If we weren't able to merge b's head then pop b's head from chain b and make it the new
259         // tail of a.
260         if (!merged) {
261             chainA.pushTail(chainB.popHead());
262             skipBounds.joinNonEmptyArg(chainA.tail()->bounds());
263         }
264     } while (!chainB.empty());
265     return chainA;
266 }
267 
268 // Attempts to concatenate the given chain onto our own and merge ops across the chains. Returns
269 // whether the operation succeeded. On success, the provided list will be returned empty.
tryConcat(List * list,GrProcessorSet::Analysis processorAnalysis,const GrDstProxyView & dstProxyView,const GrAppliedClip * appliedClip,const SkRect & bounds,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)270 bool OpsTask::OpChain::tryConcat(
271         List* list, GrProcessorSet::Analysis processorAnalysis, const GrDstProxyView& dstProxyView,
272         const GrAppliedClip* appliedClip, const SkRect& bounds, const GrCaps& caps,
273         SkArenaAlloc* opsTaskArena, GrAuditTrail* auditTrail) {
274     SkASSERT(!fList.empty());
275     SkASSERT(!list->empty());
276     SkASSERT(fProcessorAnalysis.requiresDstTexture() == SkToBool(fDstProxyView.proxy()));
277     SkASSERT(processorAnalysis.requiresDstTexture() == SkToBool(dstProxyView.proxy()));
278     // All returns use explicit tuple constructor rather than {a, b} to work around old GCC bug.
279     if (fList.head()->classID() != list->head()->classID() ||
280         SkToBool(fAppliedClip) != SkToBool(appliedClip) ||
281         (fAppliedClip && *fAppliedClip != *appliedClip) ||
282         (fProcessorAnalysis.requiresNonOverlappingDraws() !=
283                 processorAnalysis.requiresNonOverlappingDraws()) ||
284         (fProcessorAnalysis.requiresNonOverlappingDraws() &&
285                 // Non-overlaping draws are only required when Ganesh will either insert a barrier,
286                 // or read back a new dst texture between draws. In either case, we can neither
287                 // chain nor combine overlapping Ops.
288                 GrRectsTouchOrOverlap(fBounds, bounds)) ||
289         (fProcessorAnalysis.requiresDstTexture() != processorAnalysis.requiresDstTexture()) ||
290         (fProcessorAnalysis.requiresDstTexture() && fDstProxyView != dstProxyView)) {
291         return false;
292     }
293 
294     SkDEBUGCODE(bool first = true;)
295     do {
296         switch (fList.tail()->combineIfPossible(list->head(), opsTaskArena, caps))
297         {
298             case GrOp::CombineResult::kCannotCombine:
299                 // If an op supports chaining then it is required that chaining is transitive and
300                 // that if any two ops in two different chains can merge then the two chains
301                 // may also be chained together. Thus, we should only hit this on the first
302                 // iteration.
303                 SkASSERT(first);
304                 return false;
305             case GrOp::CombineResult::kMayChain:
306                 fList = DoConcat(std::move(fList), std::exchange(*list, List()), caps, opsTaskArena,
307                                  auditTrail);
308                 // The above exchange cleared out 'list'. The list needs to be empty now for the
309                 // loop to terminate.
310                 SkASSERT(list->empty());
311                 break;
312             case GrOp::CombineResult::kMerged: {
313                 GrOP_INFO("\t\t: (%s opID: %u) -> Combining with (%s, opID: %u)\n",
314                           list->tail()->name(), list->tail()->uniqueID(), list->head()->name(),
315                           list->head()->uniqueID());
316                 GR_AUDIT_TRAIL_OPS_RESULT_COMBINED(auditTrail, fList.tail(), list->head());
317                 // The GrOp::Owner releases the op.
318                 list->popHead();
319                 break;
320             }
321         }
322         SkDEBUGCODE(first = false);
323     } while (!list->empty());
324 
325     // The new ops were successfully merged and/or chained onto our own.
326     fBounds.joinPossiblyEmptyRect(bounds);
327     return true;
328 }
329 
prependChain(OpChain * that,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)330 bool OpsTask::OpChain::prependChain(OpChain* that, const GrCaps& caps, SkArenaAlloc* opsTaskArena,
331                                     GrAuditTrail* auditTrail) {
332     if (!that->tryConcat(&fList, fProcessorAnalysis, fDstProxyView, fAppliedClip, fBounds, caps,
333                          opsTaskArena, auditTrail)) {
334         this->validate();
335         // append failed
336         return false;
337     }
338 
339     // 'that' owns the combined chain. Move it into 'this'.
340     SkASSERT(fList.empty());
341     fList = std::move(that->fList);
342     fBounds = that->fBounds;
343 
344     that->fDstProxyView.setProxyView({});
345     if (that->fAppliedClip && that->fAppliedClip->hasCoverageFragmentProcessor()) {
346         // Obliterates the processor.
347         that->fAppliedClip->detachCoverageFragmentProcessor();
348     }
349     this->validate();
350     return true;
351 }
352 
appendOp(GrOp::Owner op,GrProcessorSet::Analysis processorAnalysis,const GrDstProxyView * dstProxyView,const GrAppliedClip * appliedClip,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)353 GrOp::Owner OpsTask::OpChain::appendOp(
354         GrOp::Owner op, GrProcessorSet::Analysis processorAnalysis,
355         const GrDstProxyView* dstProxyView, const GrAppliedClip* appliedClip, const GrCaps& caps,
356         SkArenaAlloc* opsTaskArena, GrAuditTrail* auditTrail) {
357     const GrDstProxyView noDstProxyView;
358     if (!dstProxyView) {
359         dstProxyView = &noDstProxyView;
360     }
361     SkASSERT(op->isChainHead() && op->isChainTail());
362     SkRect opBounds = op->bounds();
363     List chain(std::move(op));
364     if (!this->tryConcat(&chain, processorAnalysis, *dstProxyView, appliedClip, opBounds, caps,
365                          opsTaskArena, auditTrail)) {
366         // append failed, give the op back to the caller.
367         this->validate();
368         return chain.popHead();
369     }
370 
371     SkASSERT(chain.empty());
372     this->validate();
373     return nullptr;
374 }
375 
validate() const376 inline void OpsTask::OpChain::validate() const {
377 #ifdef SK_DEBUG
378     fList.validate();
379     for (const auto& op : GrOp::ChainRange<>(fList.head())) {
380         // Not using SkRect::contains because we allow empty rects.
381         SkASSERT(fBounds.fLeft <= op.bounds().fLeft && fBounds.fTop <= op.bounds().fTop &&
382                  fBounds.fRight >= op.bounds().fRight && fBounds.fBottom >= op.bounds().fBottom);
383     }
384 #endif
385 }
386 
387 ////////////////////////////////////////////////////////////////////////////////
388 
OpsTask(GrDrawingManager * drawingMgr,GrSurfaceProxyView view,GrAuditTrail * auditTrail,sk_sp<GrArenas> arenas)389 OpsTask::OpsTask(GrDrawingManager* drawingMgr,
390                  GrSurfaceProxyView view,
391                  GrAuditTrail* auditTrail,
392                  sk_sp<GrArenas> arenas)
393         : GrRenderTask()
394         , fAuditTrail(auditTrail)
395         , fUsesMSAASurface(view.asRenderTargetProxy()->numSamples() > 1)
396         , fTargetSwizzle(view.swizzle())
397         , fTargetOrigin(view.origin())
398         , fArenas{std::move(arenas)}
399           SkDEBUGCODE(, fNumClips(0)) {
400     this->addTarget(drawingMgr, view.detachProxy());
401 }
402 
deleteOps()403 void OpsTask::deleteOps() {
404     for (auto& chain : fOpChains) {
405         chain.deleteOps();
406     }
407     fOpChains.reset();
408 }
409 
~OpsTask()410 OpsTask::~OpsTask() {
411     this->deleteOps();
412 }
413 
addOp(GrDrawingManager * drawingMgr,GrOp::Owner op,GrTextureResolveManager textureResolveManager,const GrCaps & caps)414 void OpsTask::addOp(GrDrawingManager* drawingMgr, GrOp::Owner op,
415                     GrTextureResolveManager textureResolveManager, const GrCaps& caps) {
416     auto addDependency = [&](GrSurfaceProxy* p, GrMipmapped mipmapped) {
417         this->addDependency(drawingMgr, p, mipmapped, textureResolveManager, caps);
418     };
419 
420     op->visitProxies(addDependency);
421 
422     this->recordOp(std::move(op), false/*usesMSAA*/, GrProcessorSet::EmptySetAnalysis(), nullptr,
423                    nullptr, caps);
424 }
425 
addDrawOp(GrDrawingManager * drawingMgr,GrOp::Owner op,bool usesMSAA,const GrProcessorSet::Analysis & processorAnalysis,GrAppliedClip && clip,const GrDstProxyView & dstProxyView,GrTextureResolveManager textureResolveManager,const GrCaps & caps)426 void OpsTask::addDrawOp(GrDrawingManager* drawingMgr, GrOp::Owner op, bool usesMSAA,
427                         const GrProcessorSet::Analysis& processorAnalysis, GrAppliedClip&& clip,
428                         const GrDstProxyView& dstProxyView,
429                         GrTextureResolveManager textureResolveManager, const GrCaps& caps) {
430     auto addDependency = [&](GrSurfaceProxy* p, GrMipmapped mipmapped) {
431         this->addSampledTexture(p);
432         this->addDependency(drawingMgr, p, mipmapped, textureResolveManager, caps);
433     };
434 
435     op->visitProxies(addDependency);
436     clip.visitProxies(addDependency);
437     if (dstProxyView.proxy()) {
438         if (!(dstProxyView.dstSampleFlags() & GrDstSampleFlags::kAsInputAttachment)) {
439             this->addSampledTexture(dstProxyView.proxy());
440         }
441         if (dstProxyView.dstSampleFlags() & GrDstSampleFlags::kRequiresTextureBarrier) {
442             fRenderPassXferBarriers |= GrXferBarrierFlags::kTexture;
443         }
444         addDependency(dstProxyView.proxy(), GrMipmapped::kNo);
445         SkASSERT(!(dstProxyView.dstSampleFlags() & GrDstSampleFlags::kAsInputAttachment) ||
446                  dstProxyView.offset().isZero());
447     }
448 
449     if (processorAnalysis.usesNonCoherentHWBlending()) {
450         fRenderPassXferBarriers |= GrXferBarrierFlags::kBlend;
451     }
452 
453     this->recordOp(std::move(op), usesMSAA, processorAnalysis, clip.doesClip() ? &clip : nullptr,
454                    &dstProxyView, caps);
455 }
456 
endFlush(GrDrawingManager * drawingMgr)457 void OpsTask::endFlush(GrDrawingManager* drawingMgr) {
458     fLastClipStackGenID = SK_InvalidUniqueID;
459     this->deleteOps();
460 
461     fDeferredProxies.reset();
462     fSampledProxies.reset();
463     fAuditTrail = nullptr;
464 
465     GrRenderTask::endFlush(drawingMgr);
466 }
467 
onPrePrepare(GrRecordingContext * context)468 void OpsTask::onPrePrepare(GrRecordingContext* context) {
469     SkASSERT(this->isClosed());
470     // TODO: remove the check for discard here once reduced op splitting is turned on. Currently we
471     // can end up with OpsTasks that only have a discard load op and no ops. For vulkan validation
472     // we need to keep that discard and not drop it. Once we have reduce op list splitting enabled
473     // we shouldn't end up with OpsTasks with only discard.
474     if (this->isColorNoOp() ||
475         (fClippedContentBounds.isEmpty() && fColorLoadOp != GrLoadOp::kDiscard)) {
476         return;
477     }
478     TRACE_EVENT0("skia.gpu", TRACE_FUNC);
479 
480     GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
481     for (const auto& chain : fOpChains) {
482         if (chain.shouldExecute()) {
483             chain.head()->prePrepare(context,
484                                      dstView,
485                                      chain.appliedClip(),
486                                      chain.dstProxyView(),
487                                      fRenderPassXferBarriers,
488                                      fColorLoadOp);
489         }
490     }
491 }
492 
onPrepare(GrOpFlushState * flushState)493 void OpsTask::onPrepare(GrOpFlushState* flushState) {
494     SkASSERT(this->target(0)->peekRenderTarget());
495     SkASSERT(this->isClosed());
496     // TODO: remove the check for discard here once reduced op splitting is turned on. Currently we
497     // can end up with OpsTasks that only have a discard load op and no ops. For vulkan validation
498     // we need to keep that discard and not drop it. Once we have reduce op list splitting enabled
499     // we shouldn't end up with OpsTasks with only discard.
500     if (this->isColorNoOp() ||
501         (fClippedContentBounds.isEmpty() && fColorLoadOp != GrLoadOp::kDiscard)) {
502         return;
503     }
504     TRACE_EVENT0_ALWAYS("skia.gpu", TRACE_FUNC);
505 
506     flushState->setSampledProxyArray(&fSampledProxies);
507     GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
508     // Loop over the ops that haven't yet been prepared.
509     for (const auto& chain : fOpChains) {
510         if (chain.shouldExecute()) {
511             GrOpFlushState::OpArgs opArgs(chain.head(),
512                                           dstView,
513                                           fUsesMSAASurface,
514                                           chain.appliedClip(),
515                                           chain.dstProxyView(),
516                                           fRenderPassXferBarriers,
517                                           fColorLoadOp);
518 
519             flushState->setOpArgs(&opArgs);
520 
521             // Temporary debugging helper: for debugging prePrepare w/o going through DDLs
522             // Delete once most of the GrOps have an onPrePrepare.
523             // chain.head()->prePrepare(flushState->gpu()->getContext(), &this->target(0),
524             //                          chain.appliedClip());
525 
526             // GrOp::prePrepare may or may not have been called at this point
527             chain.head()->prepare(flushState);
528             flushState->setOpArgs(nullptr);
529         }
530     }
531     flushState->setSampledProxyArray(nullptr);
532 }
533 
534 // TODO: this is where GrOp::renderTarget is used (which is fine since it
535 // is at flush time). However, we need to store the RenderTargetProxy in the
536 // Ops and instantiate them here.
onExecute(GrOpFlushState * flushState)537 bool OpsTask::onExecute(GrOpFlushState* flushState) {
538     SkASSERT(this->numTargets() == 1);
539     GrRenderTargetProxy* proxy = this->target(0)->asRenderTargetProxy();
540     SkASSERT(proxy);
541     SK_AT_SCOPE_EXIT(proxy->clearArenas());
542 
543     if (this->isColorNoOp() || fClippedContentBounds.isEmpty()) {
544         return false;
545     }
546     TRACE_EVENT0_ALWAYS("skia.gpu", TRACE_FUNC);
547 
548     // Make sure load ops are not kClear if the GPU needs to use draws for clears
549     SkASSERT(fColorLoadOp != GrLoadOp::kClear ||
550              !flushState->gpu()->caps()->performColorClearsAsDraws());
551 
552     const GrCaps& caps = *flushState->gpu()->caps();
553     GrRenderTarget* renderTarget = proxy->peekRenderTarget();
554     SkASSERT(renderTarget);
555 
556     GrAttachment* stencil = nullptr;
557     if (proxy->needsStencil()) {
558         SkASSERT(proxy->canUseStencil(caps));
559         if (!flushState->resourceProvider()->attachStencilAttachment(renderTarget,
560                                                                      fUsesMSAASurface)) {
561             SkDebugf("WARNING: failed to attach a stencil buffer. Rendering will be skipped.\n");
562             return false;
563         }
564         stencil = renderTarget->getStencilAttachment(fUsesMSAASurface);
565     }
566 
567     GrLoadOp stencilLoadOp;
568     switch (fInitialStencilContent) {
569         case StencilContent::kDontCare:
570             stencilLoadOp = GrLoadOp::kDiscard;
571             break;
572         case StencilContent::kUserBitsCleared:
573             SkASSERT(!caps.performStencilClearsAsDraws());
574             SkASSERT(stencil);
575             if (caps.discardStencilValuesAfterRenderPass()) {
576                 // Always clear the stencil if it is being discarded after render passes. This is
577                 // also an optimization because we are on a tiler and it avoids loading the values
578                 // from memory.
579                 stencilLoadOp = GrLoadOp::kClear;
580                 break;
581             }
582             if (!stencil->hasPerformedInitialClear()) {
583                 stencilLoadOp = GrLoadOp::kClear;
584                 stencil->markHasPerformedInitialClear();
585                 break;
586             }
587             // SurfaceDrawContexts are required to leave the user stencil bits in a cleared state
588             // once finished, meaning the stencil values will always remain cleared after the
589             // initial clear. Just fall through to reloading the existing (cleared) stencil values
590             // from memory.
591             [[fallthrough]];
592         case StencilContent::kPreserved:
593             SkASSERT(stencil);
594             stencilLoadOp = GrLoadOp::kLoad;
595             break;
596     }
597 
598     // NOTE: If fMustPreserveStencil is set, then we are executing a surfaceDrawContext that split
599     // its opsTask.
600     //
601     // FIXME: We don't currently flag render passes that don't use stencil at all. In that case
602     // their store op might be "discard", and we currently make the assumption that a discard will
603     // not invalidate what's already in main memory. This is probably ok for now, but certainly
604     // something we want to address soon.
605     GrStoreOp stencilStoreOp = (caps.discardStencilValuesAfterRenderPass() && !fMustPreserveStencil)
606             ? GrStoreOp::kDiscard
607             : GrStoreOp::kStore;
608 
609     GrOpsRenderPass* renderPass = create_render_pass(flushState->gpu(),
610                                                      proxy->peekRenderTarget(),
611                                                      fUsesMSAASurface,
612                                                      stencil,
613                                                      fTargetOrigin,
614                                                      fClippedContentBounds,
615                                                      fColorLoadOp,
616                                                      fLoadClearColor,
617                                                      stencilLoadOp,
618                                                      stencilStoreOp,
619                                                      fSampledProxies,
620                                                      fRenderPassXferBarriers);
621 
622     if (!renderPass) {
623         return false;
624     }
625     flushState->setOpsRenderPass(renderPass);
626     renderPass->begin();
627 
628     GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
629 
630     // Draw all the generated geometry.
631     for (const auto& chain : fOpChains) {
632         if (!chain.shouldExecute()) {
633             continue;
634         }
635 
636         GrOpFlushState::OpArgs opArgs(chain.head(),
637                                       dstView,
638                                       fUsesMSAASurface,
639                                       chain.appliedClip(),
640                                       chain.dstProxyView(),
641                                       fRenderPassXferBarriers,
642                                       fColorLoadOp);
643 
644         flushState->setOpArgs(&opArgs);
645         chain.head()->execute(flushState, chain.bounds());
646         flushState->setOpArgs(nullptr);
647     }
648 
649     renderPass->end();
650     flushState->gpu()->submit(renderPass);
651     flushState->setOpsRenderPass(nullptr);
652 
653     return true;
654 }
655 
setColorLoadOp(GrLoadOp op,std::array<float,4> color)656 void OpsTask::setColorLoadOp(GrLoadOp op, std::array<float, 4> color) {
657     fColorLoadOp = op;
658     fLoadClearColor = color;
659     if (GrLoadOp::kClear == fColorLoadOp) {
660         GrSurfaceProxy* proxy = this->target(0);
661         SkASSERT(proxy);
662         fTotalBounds = proxy->backingStoreBoundsRect();
663     }
664 }
665 
reset()666 void OpsTask::reset() {
667     fDeferredProxies.reset();
668     fSampledProxies.reset();
669     fClippedContentBounds = SkIRect::MakeEmpty();
670     fTotalBounds = SkRect::MakeEmpty();
671     this->deleteOps();
672     fRenderPassXferBarriers = GrXferBarrierFlags::kNone;
673 }
674 
canMerge(const OpsTask * opsTask) const675 bool OpsTask::canMerge(const OpsTask* opsTask) const {
676     return this->target(0) == opsTask->target(0) &&
677            fArenas == opsTask->fArenas &&
678            !opsTask->fCannotMergeBackward;
679 }
680 
mergeFrom(SkSpan<const sk_sp<GrRenderTask>> tasks)681 int OpsTask::mergeFrom(SkSpan<const sk_sp<GrRenderTask>> tasks) {
682     int mergedCount = 0;
683     for (const sk_sp<GrRenderTask>& task : tasks) {
684         auto opsTask = task->asOpsTask();
685         if (!opsTask || !this->canMerge(opsTask)) {
686             break;
687         }
688         SkASSERT(fTargetSwizzle == opsTask->fTargetSwizzle);
689         SkASSERT(fTargetOrigin == opsTask->fTargetOrigin);
690         if (GrLoadOp::kClear == opsTask->fColorLoadOp) {
691             // TODO(11903): Go back to actually dropping ops tasks when we are merged with
692             // color clear.
693             return 0;
694         }
695         mergedCount += 1;
696     }
697     if (0 == mergedCount) {
698         return 0;
699     }
700 
701     SkSpan<const sk_sp<OpsTask>> mergingNodes(
702             reinterpret_cast<const sk_sp<OpsTask>*>(tasks.data()), SkToSizeT(mergedCount));
703     int addlDeferredProxyCount = 0;
704     int addlProxyCount = 0;
705     int addlOpChainCount = 0;
706     for (const auto& toMerge : mergingNodes) {
707         addlDeferredProxyCount += toMerge->fDeferredProxies.count();
708         addlProxyCount += toMerge->fSampledProxies.count();
709         addlOpChainCount += toMerge->fOpChains.count();
710         fClippedContentBounds.join(toMerge->fClippedContentBounds);
711         fTotalBounds.join(toMerge->fTotalBounds);
712         fRenderPassXferBarriers |= toMerge->fRenderPassXferBarriers;
713         if (fInitialStencilContent == StencilContent::kDontCare) {
714             // Propogate the first stencil content that isn't kDontCare.
715             //
716             // Once the stencil has any kind of initial content that isn't kDontCare, then the
717             // inital contents of subsequent opsTasks that get merged in don't matter.
718             //
719             // (This works because the opsTask all target the same render target and are in
720             // painter's order. kPreserved obviously happens automatically with a merge, and kClear
721             // is also automatic because the contract is for ops to leave the stencil buffer in a
722             // cleared state when finished.)
723             fInitialStencilContent = toMerge->fInitialStencilContent;
724         }
725         fUsesMSAASurface |= toMerge->fUsesMSAASurface;
726         SkDEBUGCODE(fNumClips += toMerge->fNumClips);
727     }
728 
729     fLastClipStackGenID = SK_InvalidUniqueID;
730     fDeferredProxies.reserve_back(addlDeferredProxyCount);
731     fSampledProxies.reserve_back(addlProxyCount);
732     fOpChains.reserve_back(addlOpChainCount);
733     for (const auto& toMerge : mergingNodes) {
734         for (GrRenderTask* renderTask : toMerge->dependents()) {
735             renderTask->replaceDependency(toMerge.get(), this);
736         }
737         for (GrRenderTask* renderTask : toMerge->dependencies()) {
738             renderTask->replaceDependent(toMerge.get(), this);
739         }
740         fDeferredProxies.move_back_n(toMerge->fDeferredProxies.count(),
741                                      toMerge->fDeferredProxies.data());
742         fSampledProxies.move_back_n(toMerge->fSampledProxies.count(),
743                                     toMerge->fSampledProxies.data());
744         fOpChains.move_back_n(toMerge->fOpChains.count(),
745                               toMerge->fOpChains.data());
746         toMerge->fDeferredProxies.reset();
747         toMerge->fSampledProxies.reset();
748         toMerge->fOpChains.reset();
749     }
750     fMustPreserveStencil = mergingNodes.back()->fMustPreserveStencil;
751     return mergedCount;
752 }
753 
resetForFullscreenClear(CanDiscardPreviousOps canDiscardPreviousOps)754 bool OpsTask::resetForFullscreenClear(CanDiscardPreviousOps canDiscardPreviousOps) {
755     if (CanDiscardPreviousOps::kYes == canDiscardPreviousOps || this->isEmpty()) {
756         this->deleteOps();
757         fDeferredProxies.reset();
758         fSampledProxies.reset();
759 
760         // If the opsTask is using a render target which wraps a vulkan command buffer, we can't do
761         // a clear load since we cannot change the render pass that we are using. Thus we fall back
762         // to making a clear op in this case.
763         return !this->target(0)->asRenderTargetProxy()->wrapsVkSecondaryCB();
764     }
765 
766     // Could not empty the task, so an op must be added to handle the clear
767     return false;
768 }
769 
discard()770 void OpsTask::discard() {
771     // Discard calls to in-progress opsTasks are ignored. Calls at the start update the
772     // opsTasks' color & stencil load ops.
773     if (this->isEmpty()) {
774         fColorLoadOp = GrLoadOp::kDiscard;
775         fInitialStencilContent = StencilContent::kDontCare;
776         fTotalBounds.setEmpty();
777     }
778 }
779 
780 ////////////////////////////////////////////////////////////////////////////////
781 
782 #if GR_TEST_UTILS
dump(const SkString & label,SkString indent,bool printDependencies,bool close) const783 void OpsTask::dump(const SkString& label,
784                    SkString indent,
785                    bool printDependencies,
786                    bool close) const {
787     GrRenderTask::dump(label, indent, printDependencies, false);
788 
789     SkDebugf("%sfColorLoadOp: ", indent.c_str());
790     switch (fColorLoadOp) {
791         case GrLoadOp::kLoad:
792             SkDebugf("kLoad\n");
793             break;
794         case GrLoadOp::kClear:
795             SkDebugf("kClear {%g, %g, %g, %g}\n",
796                      fLoadClearColor[0],
797                      fLoadClearColor[1],
798                      fLoadClearColor[2],
799                      fLoadClearColor[3]);
800             break;
801         case GrLoadOp::kDiscard:
802             SkDebugf("kDiscard\n");
803             break;
804     }
805 
806     SkDebugf("%sfInitialStencilContent: ", indent.c_str());
807     switch (fInitialStencilContent) {
808         case StencilContent::kDontCare:
809             SkDebugf("kDontCare\n");
810             break;
811         case StencilContent::kUserBitsCleared:
812             SkDebugf("kUserBitsCleared\n");
813             break;
814         case StencilContent::kPreserved:
815             SkDebugf("kPreserved\n");
816             break;
817     }
818 
819     SkDebugf("%s%d ops:\n", indent.c_str(), fOpChains.count());
820     for (int i = 0; i < fOpChains.count(); ++i) {
821         SkDebugf("%s*******************************\n", indent.c_str());
822         if (!fOpChains[i].head()) {
823             SkDebugf("%s%d: <combined forward or failed instantiation>\n", indent.c_str(), i);
824         } else {
825             SkDebugf("%s%d: %s\n", indent.c_str(), i, fOpChains[i].head()->name());
826             SkRect bounds = fOpChains[i].bounds();
827             SkDebugf("%sClippedBounds: [L: %.2f, T: %.2f, R: %.2f, B: %.2f]\n",
828                      indent.c_str(),
829                      bounds.fLeft, bounds.fTop, bounds.fRight, bounds.fBottom);
830             for (const auto& op : GrOp::ChainRange<>(fOpChains[i].head())) {
831                 SkString info = SkTabString(op.dumpInfo(), 1);
832                 SkDebugf("%s%s\n", indent.c_str(), info.c_str());
833                 bounds = op.bounds();
834                 SkDebugf("%s\tClippedBounds: [L: %.2f, T: %.2f, R: %.2f, B: %.2f]\n",
835                          indent.c_str(),
836                          bounds.fLeft, bounds.fTop, bounds.fRight, bounds.fBottom);
837             }
838         }
839     }
840 
841     if (close) {
842         SkDebugf("%s--------------------------------------------------------------\n\n",
843                  indent.c_str());
844     }
845 }
846 #endif
847 
848 #ifdef SK_DEBUG
visitProxies_debugOnly(const GrVisitProxyFunc & func) const849 void OpsTask::visitProxies_debugOnly(const GrVisitProxyFunc& func) const {
850     auto textureFunc = [ func ] (GrSurfaceProxy* tex, GrMipmapped mipmapped) {
851         func(tex, mipmapped);
852     };
853 
854     for (const OpChain& chain : fOpChains) {
855         chain.visitProxies(textureFunc);
856     }
857 }
858 
859 #endif
860 
861 ////////////////////////////////////////////////////////////////////////////////
862 
onMakeSkippable()863 void OpsTask::onMakeSkippable() {
864     this->deleteOps();
865     fDeferredProxies.reset();
866     fColorLoadOp = GrLoadOp::kLoad;
867     SkASSERT(this->isColorNoOp());
868 }
869 
onIsUsed(GrSurfaceProxy * proxyToCheck) const870 bool OpsTask::onIsUsed(GrSurfaceProxy* proxyToCheck) const {
871     bool used = false;
872     for (GrSurfaceProxy* proxy : fSampledProxies) {
873         if (proxy == proxyToCheck) {
874             used = true;
875             break;
876         }
877     }
878 #ifdef SK_DEBUG
879     bool usedSlow = false;
880     auto visit = [ proxyToCheck, &usedSlow ] (GrSurfaceProxy* p, GrMipmapped) {
881         if (p == proxyToCheck) {
882             usedSlow = true;
883         }
884     };
885     this->visitProxies_debugOnly(visit);
886     SkASSERT(used == usedSlow);
887 #endif
888 
889     return used;
890 }
891 
gatherProxyIntervals(GrResourceAllocator * alloc) const892 void OpsTask::gatherProxyIntervals(GrResourceAllocator* alloc) const {
893     SkASSERT(this->isClosed());
894     if (this->isColorNoOp()) {
895         return;
896     }
897 
898     for (int i = 0; i < fDeferredProxies.count(); ++i) {
899         SkASSERT(!fDeferredProxies[i]->isInstantiated());
900         // We give all the deferred proxies a write usage at the very start of flushing. This
901         // locks them out of being reused for the entire flush until they are read - and then
902         // they can be recycled. This is a bit unfortunate because a flush can proceed in waves
903         // with sub-flushes. The deferred proxies only need to be pinned from the start of
904         // the sub-flush in which they appear.
905         alloc->addInterval(fDeferredProxies[i], 0, 0, GrResourceAllocator::ActualUse::kNo);
906     }
907 
908     GrSurfaceProxy* targetProxy = this->target(0);
909 
910     // Add the interval for all the writes to this OpsTasks's target
911     if (fOpChains.count()) {
912         unsigned int cur = alloc->curOp();
913 
914         alloc->addInterval(targetProxy, cur, cur + fOpChains.count() - 1,
915                            GrResourceAllocator::ActualUse::kYes);
916     } else {
917         // This can happen if there is a loadOp (e.g., a clear) but no other draws. In this case we
918         // still need to add an interval for the destination so we create a fake op# for
919         // the missing clear op.
920         alloc->addInterval(targetProxy, alloc->curOp(), alloc->curOp(),
921                            GrResourceAllocator::ActualUse::kYes);
922         alloc->incOps();
923     }
924 
925     auto gather = [ alloc SkDEBUGCODE(, this) ] (GrSurfaceProxy* p, GrMipmapped) {
926         alloc->addInterval(p,
927                            alloc->curOp(),
928                            alloc->curOp(),
929                            GrResourceAllocator::ActualUse::kYes
930                            SkDEBUGCODE(, this->target(0) == p));
931     };
932     // TODO: visitProxies is expensive. Can we do this with fSampledProxies instead?
933     for (const OpChain& recordedOp : fOpChains) {
934         recordedOp.visitProxies(gather);
935 
936         // Even though the op may have been (re)moved we still need to increment the op count to
937         // keep all the math consistent.
938         alloc->incOps();
939     }
940 }
941 
recordOp(GrOp::Owner op,bool usesMSAA,GrProcessorSet::Analysis processorAnalysis,GrAppliedClip * clip,const GrDstProxyView * dstProxyView,const GrCaps & caps)942 void OpsTask::recordOp(
943         GrOp::Owner op, bool usesMSAA, GrProcessorSet::Analysis processorAnalysis,
944         GrAppliedClip* clip, const GrDstProxyView* dstProxyView, const GrCaps& caps) {
945     GrSurfaceProxy* proxy = this->target(0);
946 #ifdef SK_DEBUG
947     op->validate();
948     SkASSERT(processorAnalysis.requiresDstTexture() == (dstProxyView && dstProxyView->proxy()));
949     SkASSERT(proxy);
950     // A closed OpsTask should never receive new/more ops
951     SkASSERT(!this->isClosed());
952     // Ensure we can support dynamic msaa if the caller is trying to trigger it.
953     if (proxy->asRenderTargetProxy()->numSamples() == 1 && usesMSAA) {
954         SkASSERT(caps.supportsDynamicMSAA(proxy->asRenderTargetProxy()));
955     }
956 #endif
957 
958     if (!op->bounds().isFinite()) {
959         return;
960     }
961 
962     fUsesMSAASurface |= usesMSAA;
963 
964     // Account for this op's bounds before we attempt to combine.
965     // NOTE: The caller should have already called "op->setClippedBounds()" by now, if applicable.
966     fTotalBounds.join(op->bounds());
967 
968     // Check if there is an op we can combine with by linearly searching back until we either
969     // 1) check every op
970     // 2) intersect with something
971     // 3) find a 'blocker'
972     GR_AUDIT_TRAIL_ADD_OP(fAuditTrail, op.get(), proxy->uniqueID());
973     GrOP_INFO("opsTask: %d Recording (%s, opID: %u)\n"
974               "\tBounds [L: %.2f, T: %.2f R: %.2f B: %.2f]\n",
975                this->uniqueID(),
976                op->name(),
977                op->uniqueID(),
978                op->bounds().fLeft, op->bounds().fTop,
979                op->bounds().fRight, op->bounds().fBottom);
980     GrOP_INFO(SkTabString(op->dumpInfo(), 1).c_str());
981     GrOP_INFO("\tOutcome:\n");
982     int maxCandidates = std::min(kMaxOpChainDistance, fOpChains.count());
983     if (maxCandidates) {
984         int i = 0;
985         while (true) {
986             OpChain& candidate = fOpChains.fromBack(i);
987             op = candidate.appendOp(std::move(op), processorAnalysis, dstProxyView, clip, caps,
988                                     fArenas->arenaAlloc(), fAuditTrail);
989             if (!op) {
990                 return;
991             }
992             // Stop going backwards if we would cause a painter's order violation.
993             if (!can_reorder(candidate.bounds(), op->bounds())) {
994                 GrOP_INFO("\t\tBackward: Intersects with chain (%s, head opID: %u)\n",
995                           candidate.head()->name(), candidate.head()->uniqueID());
996                 break;
997             }
998             if (++i == maxCandidates) {
999                 GrOP_INFO("\t\tBackward: Reached max lookback or beginning of op array %d\n", i);
1000                 break;
1001             }
1002         }
1003     } else {
1004         GrOP_INFO("\t\tBackward: FirstOp\n");
1005     }
1006     if (clip) {
1007         clip = fArenas->arenaAlloc()->make<GrAppliedClip>(std::move(*clip));
1008         SkDEBUGCODE(fNumClips++;)
1009     }
1010     fOpChains.emplace_back(std::move(op), processorAnalysis, clip, dstProxyView);
1011 }
1012 
forwardCombine(const GrCaps & caps)1013 void OpsTask::forwardCombine(const GrCaps& caps) {
1014     SkASSERT(!this->isClosed());
1015     GrOP_INFO("opsTask: %d ForwardCombine %d ops:\n", this->uniqueID(), fOpChains.count());
1016 
1017     for (int i = 0; i < fOpChains.count() - 1; ++i) {
1018         OpChain& chain = fOpChains[i];
1019         int maxCandidateIdx = std::min(i + kMaxOpChainDistance, fOpChains.count() - 1);
1020         int j = i + 1;
1021         while (true) {
1022             OpChain& candidate = fOpChains[j];
1023             if (candidate.prependChain(&chain, caps, fArenas->arenaAlloc(), fAuditTrail)) {
1024                 break;
1025             }
1026             // Stop traversing if we would cause a painter's order violation.
1027             if (!can_reorder(chain.bounds(), candidate.bounds())) {
1028                 GrOP_INFO(
1029                         "\t\t%d: chain (%s head opID: %u) -> "
1030                         "Intersects with chain (%s, head opID: %u)\n",
1031                         i, chain.head()->name(), chain.head()->uniqueID(), candidate.head()->name(),
1032                         candidate.head()->uniqueID());
1033                 break;
1034             }
1035             if (++j > maxCandidateIdx) {
1036                 GrOP_INFO("\t\t%d: chain (%s opID: %u) -> Reached max lookahead or end of array\n",
1037                           i, chain.head()->name(), chain.head()->uniqueID());
1038                 break;
1039             }
1040         }
1041     }
1042 }
1043 
onMakeClosed(GrRecordingContext * rContext,SkIRect * targetUpdateBounds)1044 GrRenderTask::ExpectedOutcome OpsTask::onMakeClosed(GrRecordingContext* rContext,
1045                                                     SkIRect* targetUpdateBounds) {
1046     this->forwardCombine(*rContext->priv().caps());
1047     if (!this->isColorNoOp()) {
1048         GrSurfaceProxy* proxy = this->target(0);
1049         // Use the entire backing store bounds since the GPU doesn't clip automatically to the
1050         // logical dimensions.
1051         SkRect clippedContentBounds = proxy->backingStoreBoundsRect();
1052         // TODO: If we can fix up GLPrograms test to always intersect the target proxy bounds
1053         // then we can simply assert here that the bounds intersect.
1054         if (clippedContentBounds.intersect(fTotalBounds)) {
1055             clippedContentBounds.roundOut(&fClippedContentBounds);
1056             *targetUpdateBounds = GrNativeRect::MakeIRectRelativeTo(
1057                     fTargetOrigin,
1058                     this->target(0)->backingStoreDimensions().height(),
1059                     fClippedContentBounds);
1060             return ExpectedOutcome::kTargetDirty;
1061         }
1062     }
1063     return ExpectedOutcome::kTargetUnchanged;
1064 }
1065 
1066 } // namespace skgpu::v1
1067