1 /*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17 // Test is in compiler, as it uses compiler related code.
18 #include "verifier/verifier_deps.h"
19
20 #include "art_method-inl.h"
21 #include "base/indenter.h"
22 #include "class_linker.h"
23 #include "common_compiler_driver_test.h"
24 #include "compiler_callbacks.h"
25 #include "dex/class_accessor-inl.h"
26 #include "dex/class_iterator.h"
27 #include "dex/dex_file-inl.h"
28 #include "dex/dex_file_types.h"
29 #include "dex/verification_results.h"
30 #include "driver/compiler_driver-inl.h"
31 #include "driver/compiler_options.h"
32 #include "handle_scope-inl.h"
33 #include "mirror/class_loader.h"
34 #include "runtime.h"
35 #include "scoped_thread_state_change-inl.h"
36 #include "thread.h"
37 #include "utils/atomic_dex_ref_map-inl.h"
38 #include "verifier/method_verifier-inl.h"
39
40 namespace art {
41 namespace verifier {
42
43 class VerifierDepsCompilerCallbacks : public CompilerCallbacks {
44 public:
VerifierDepsCompilerCallbacks()45 VerifierDepsCompilerCallbacks()
46 : CompilerCallbacks(CompilerCallbacks::CallbackMode::kCompileApp),
47 deps_(nullptr) {}
48
AddUncompilableMethod(MethodReference ref ATTRIBUTE_UNUSED)49 void AddUncompilableMethod(MethodReference ref ATTRIBUTE_UNUSED) override {}
ClassRejected(ClassReference ref ATTRIBUTE_UNUSED)50 void ClassRejected(ClassReference ref ATTRIBUTE_UNUSED) override {}
51
GetVerifierDeps() const52 verifier::VerifierDeps* GetVerifierDeps() const override { return deps_; }
SetVerifierDeps(verifier::VerifierDeps * deps)53 void SetVerifierDeps(verifier::VerifierDeps* deps) override { deps_ = deps; }
54
55 private:
56 verifier::VerifierDeps* deps_;
57 };
58
59 class VerifierDepsTest : public CommonCompilerDriverTest {
60 public:
VerifierDepsTest()61 VerifierDepsTest() {
62 this->use_boot_image_ = true; // Make the Runtime creation cheaper.
63 }
64
SetUpRuntimeOptions(RuntimeOptions * options)65 void SetUpRuntimeOptions(RuntimeOptions* options) override {
66 CommonCompilerTest::SetUpRuntimeOptions(options);
67 callbacks_.reset(new VerifierDepsCompilerCallbacks());
68 }
69
FindClassByName(ScopedObjectAccess & soa,const std::string & name)70 ObjPtr<mirror::Class> FindClassByName(ScopedObjectAccess& soa, const std::string& name)
71 REQUIRES_SHARED(Locks::mutator_lock_) {
72 StackHandleScope<1> hs(soa.Self());
73 Handle<mirror::ClassLoader> class_loader_handle(
74 hs.NewHandle(soa.Decode<mirror::ClassLoader>(class_loader_)));
75 ObjPtr<mirror::Class> klass =
76 class_linker_->FindClass(soa.Self(), name.c_str(), class_loader_handle);
77 if (klass == nullptr) {
78 DCHECK(soa.Self()->IsExceptionPending());
79 soa.Self()->ClearException();
80 }
81 return klass;
82 }
83
SetupCompilerDriver()84 void SetupCompilerDriver() {
85 compiler_options_->image_type_ = CompilerOptions::ImageType::kNone;
86 compiler_driver_->InitializeThreadPools();
87 }
88
VerifyWithCompilerDriver(verifier::VerifierDeps * verifier_deps)89 void VerifyWithCompilerDriver(verifier::VerifierDeps* verifier_deps) {
90 TimingLogger timings("Verify", false, false);
91 // The compiler driver handles the verifier deps in the callbacks, so
92 // remove what this class did for unit testing.
93 if (verifier_deps == nullptr) {
94 // Create some verifier deps by default if they are not already specified.
95 verifier_deps = new verifier::VerifierDeps(dex_files_);
96 verifier_deps_.reset(verifier_deps);
97 }
98 callbacks_->SetVerifierDeps(verifier_deps);
99 compiler_driver_->Verify(class_loader_, dex_files_, &timings);
100 callbacks_->SetVerifierDeps(nullptr);
101 }
102
SetVerifierDeps(const std::vector<const DexFile * > & dex_files)103 void SetVerifierDeps(const std::vector<const DexFile*>& dex_files) {
104 verifier_deps_.reset(new verifier::VerifierDeps(dex_files));
105 VerifierDepsCompilerCallbacks* callbacks =
106 reinterpret_cast<VerifierDepsCompilerCallbacks*>(callbacks_.get());
107 callbacks->SetVerifierDeps(verifier_deps_.get());
108 }
109
LoadDexFile(ScopedObjectAccess & soa,const char * name1,const char * name2=nullptr)110 void LoadDexFile(ScopedObjectAccess& soa, const char* name1, const char* name2 = nullptr)
111 REQUIRES_SHARED(Locks::mutator_lock_) {
112 class_loader_ = (name2 == nullptr) ? LoadDex(name1) : LoadMultiDex(name1, name2);
113 dex_files_ = GetDexFiles(class_loader_);
114 primary_dex_file_ = dex_files_.front();
115
116 SetVerifierDeps(dex_files_);
117 StackHandleScope<1> hs(soa.Self());
118 Handle<mirror::ClassLoader> loader =
119 hs.NewHandle(soa.Decode<mirror::ClassLoader>(class_loader_));
120 for (const DexFile* dex_file : dex_files_) {
121 class_linker_->RegisterDexFile(*dex_file, loader.Get());
122 }
123 SetDexFilesForOatFile(dex_files_);
124 }
125
LoadDexFile(ScopedObjectAccess & soa)126 void LoadDexFile(ScopedObjectAccess& soa) REQUIRES_SHARED(Locks::mutator_lock_) {
127 LoadDexFile(soa, "VerifierDeps");
128 CHECK_EQ(dex_files_.size(), 1u);
129 klass_Main_ = FindClassByName(soa, "LMain;");
130 CHECK(klass_Main_ != nullptr);
131 }
132
VerifyMethod(const std::string & method_name)133 bool VerifyMethod(const std::string& method_name) {
134 ScopedObjectAccess soa(Thread::Current());
135 LoadDexFile(soa);
136
137 StackHandleScope<2> hs(soa.Self());
138 Handle<mirror::ClassLoader> class_loader_handle(
139 hs.NewHandle(soa.Decode<mirror::ClassLoader>(class_loader_)));
140 Handle<mirror::DexCache> dex_cache_handle(hs.NewHandle(klass_Main_->GetDexCache()));
141
142 const dex::ClassDef* class_def = klass_Main_->GetClassDef();
143 ClassAccessor accessor(*primary_dex_file_, *class_def);
144
145 bool has_failures = true;
146 bool found_method = false;
147
148 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
149 ArtMethod* resolved_method =
150 class_linker_->ResolveMethod<ClassLinker::ResolveMode::kNoChecks>(
151 method.GetIndex(),
152 dex_cache_handle,
153 class_loader_handle,
154 /* referrer= */ nullptr,
155 method.GetInvokeType(class_def->access_flags_));
156 CHECK(resolved_method != nullptr);
157 if (method_name == resolved_method->GetName()) {
158 std::unique_ptr<MethodVerifier> verifier(
159 MethodVerifier::CreateVerifier(soa.Self(),
160 callbacks_->GetVerifierDeps(),
161 primary_dex_file_,
162 dex_cache_handle,
163 class_loader_handle,
164 *class_def,
165 method.GetCodeItem(),
166 method.GetIndex(),
167 method.GetAccessFlags(),
168 /* can_load_classes= */ true,
169 /* verify to dump */ false,
170 /* allow_thread_suspension= */ true,
171 /* api_level= */ 0));
172 verifier->Verify();
173 soa.Self()->SetVerifierDeps(nullptr);
174 has_failures = verifier->HasFailures();
175 found_method = true;
176 }
177 }
178 CHECK(found_method) << "Expected to find method " << method_name;
179 return !has_failures;
180 }
181
VerifyDexFile(const char * multidex=nullptr)182 void VerifyDexFile(const char* multidex = nullptr) {
183 {
184 ScopedObjectAccess soa(Thread::Current());
185 LoadDexFile(soa, "VerifierDeps", multidex);
186 }
187 SetupCompilerDriver();
188 VerifyWithCompilerDriver(/* verifier_deps= */ nullptr);
189 }
190
TestAssignabilityRecording(const std::string & dst,const std::string & src)191 bool TestAssignabilityRecording(const std::string& dst, const std::string& src) {
192 ScopedObjectAccess soa(Thread::Current());
193 LoadDexFile(soa);
194 StackHandleScope<1> hs(soa.Self());
195 Handle<mirror::Class> klass_dst = hs.NewHandle(FindClassByName(soa, dst));
196 DCHECK(klass_dst != nullptr) << dst;
197 ObjPtr<mirror::Class> klass_src = FindClassByName(soa, src);
198 DCHECK(klass_src != nullptr) << src;
199 verifier_deps_->AddAssignability(*primary_dex_file_,
200 primary_dex_file_->GetClassDef(0),
201 klass_dst.Get(),
202 klass_src);
203 return true;
204 }
205
206 // Check that the status of classes in `class_loader_` match the
207 // expected status in `deps`.
VerifyClassStatus(const verifier::VerifierDeps & deps)208 void VerifyClassStatus(const verifier::VerifierDeps& deps) {
209 ScopedObjectAccess soa(Thread::Current());
210 StackHandleScope<2> hs(soa.Self());
211 Handle<mirror::ClassLoader> class_loader_handle(
212 hs.NewHandle(soa.Decode<mirror::ClassLoader>(class_loader_)));
213 MutableHandle<mirror::Class> cls(hs.NewHandle<mirror::Class>(nullptr));
214 for (const DexFile* dex_file : dex_files_) {
215 const std::vector<bool>& verified_classes = deps.GetVerifiedClasses(*dex_file);
216 ASSERT_EQ(verified_classes.size(), dex_file->NumClassDefs());
217 for (uint32_t i = 0; i < dex_file->NumClassDefs(); ++i) {
218 const dex::ClassDef& class_def = dex_file->GetClassDef(i);
219 const char* descriptor = dex_file->GetClassDescriptor(class_def);
220 cls.Assign(class_linker_->FindClass(soa.Self(), descriptor, class_loader_handle));
221 if (cls == nullptr) {
222 CHECK(soa.Self()->IsExceptionPending());
223 soa.Self()->ClearException();
224 } else if (&cls->GetDexFile() != dex_file) {
225 // Ignore classes from different dex files.
226 } else if (verified_classes[i]) {
227 ASSERT_EQ(cls->GetStatus(), ClassStatus::kVerifiedNeedsAccessChecks);
228 } else {
229 ASSERT_LT(cls->GetStatus(), ClassStatus::kVerified);
230 }
231 }
232 }
233 }
234
GetClassDefIndex(const std::string & cls,const DexFile & dex_file)235 uint16_t GetClassDefIndex(const std::string& cls, const DexFile& dex_file) {
236 const dex::TypeId* type_id = dex_file.FindTypeId(cls.c_str());
237 DCHECK(type_id != nullptr);
238 dex::TypeIndex type_idx = dex_file.GetIndexForTypeId(*type_id);
239 const dex::ClassDef* class_def = dex_file.FindClassDef(type_idx);
240 DCHECK(class_def != nullptr);
241 return dex_file.GetIndexForClassDef(*class_def);
242 }
243
HasVerifiedClass(const std::string & cls)244 bool HasVerifiedClass(const std::string& cls) {
245 return HasVerifiedClass(cls, *primary_dex_file_);
246 }
247
HasUnverifiedClass(const std::string & cls)248 bool HasUnverifiedClass(const std::string& cls) {
249 return !HasVerifiedClass(cls, *primary_dex_file_);
250 }
251
HasUnverifiedClass(const std::string & cls,const DexFile & dex_file)252 bool HasUnverifiedClass(const std::string& cls, const DexFile& dex_file) {
253 return !HasVerifiedClass(cls, dex_file);
254 }
255
HasVerifiedClass(const std::string & cls,const DexFile & dex_file)256 bool HasVerifiedClass(const std::string& cls, const DexFile& dex_file) {
257 uint16_t class_def_idx = GetClassDefIndex(cls, dex_file);
258 return verifier_deps_->GetVerifiedClasses(dex_file)[class_def_idx];
259 }
260
261 // Iterates over all assignability records and tries to find an entry which
262 // matches the expected destination/source pair.
HasAssignable(const std::string & expected_destination,const std::string & expected_source) const263 bool HasAssignable(const std::string& expected_destination,
264 const std::string& expected_source) const {
265 for (auto& dex_dep : verifier_deps_->dex_deps_) {
266 const DexFile& dex_file = *dex_dep.first;
267 auto& storage = dex_dep.second->assignable_types_;
268 for (auto& set : storage) {
269 for (auto& entry : set) {
270 std::string actual_destination =
271 verifier_deps_->GetStringFromId(dex_file, entry.GetDestination());
272 std::string actual_source = verifier_deps_->GetStringFromId(dex_file, entry.GetSource());
273 if ((expected_destination == actual_destination) && (expected_source == actual_source)) {
274 return true;
275 }
276 }
277 }
278 }
279 return false;
280 }
281
NumberOfCompiledDexFiles()282 size_t NumberOfCompiledDexFiles() {
283 return verifier_deps_->dex_deps_.size();
284 }
285
HasBoolValue(const std::vector<bool> & vec,bool value)286 bool HasBoolValue(const std::vector<bool>& vec, bool value) {
287 return std::count(vec.begin(), vec.end(), value) > 0;
288 }
289
HasEachKindOfRecord()290 bool HasEachKindOfRecord() {
291 bool has_strings = false;
292 bool has_assignability = false;
293 bool has_verified_classes = false;
294 bool has_unverified_classes = false;
295
296 for (auto& entry : verifier_deps_->dex_deps_) {
297 has_strings |= !entry.second->strings_.empty();
298 has_assignability |= !entry.second->assignable_types_.empty();
299 has_verified_classes |= HasBoolValue(entry.second->verified_classes_, true);
300 has_unverified_classes |= HasBoolValue(entry.second->verified_classes_, false);
301 }
302
303 return has_strings &&
304 has_assignability &&
305 has_verified_classes &&
306 has_unverified_classes;
307 }
308
309 // Load the dex file again with a new class loader, decode the VerifierDeps
310 // in `buffer`, allow the caller to modify the deps and then run validation.
311 template<typename Fn>
RunValidation(Fn fn,const std::vector<uint8_t> & buffer,std::string * error_msg)312 bool RunValidation(Fn fn, const std::vector<uint8_t>& buffer, std::string* error_msg) {
313 ScopedObjectAccess soa(Thread::Current());
314
315 jobject second_loader = LoadDex("VerifierDeps");
316 const auto& second_dex_files = GetDexFiles(second_loader);
317
318 VerifierDeps decoded_deps(second_dex_files, /*output_only=*/ false);
319 bool parsed = decoded_deps.ParseStoredData(second_dex_files, ArrayRef<const uint8_t>(buffer));
320 CHECK(parsed);
321 VerifierDeps::DexFileDeps* decoded_dex_deps =
322 decoded_deps.GetDexFileDeps(*second_dex_files.front());
323
324 // Let the test modify the dependencies.
325 fn(*decoded_dex_deps);
326
327 StackHandleScope<1> hs(soa.Self());
328 Handle<mirror::ClassLoader> new_class_loader =
329 hs.NewHandle<mirror::ClassLoader>(soa.Decode<mirror::ClassLoader>(second_loader));
330
331 return decoded_deps.ValidateDependencies(soa.Self(),
332 new_class_loader,
333 second_dex_files,
334 error_msg);
335 }
336
337 std::unique_ptr<verifier::VerifierDeps> verifier_deps_;
338 std::vector<const DexFile*> dex_files_;
339 const DexFile* primary_dex_file_;
340 jobject class_loader_;
341 ObjPtr<mirror::Class> klass_Main_;
342 };
343
TEST_F(VerifierDepsTest,StringToId)344 TEST_F(VerifierDepsTest, StringToId) {
345 ScopedObjectAccess soa(Thread::Current());
346 LoadDexFile(soa);
347
348 dex::StringIndex id_Main1 = verifier_deps_->GetIdFromString(*primary_dex_file_, "LMain;");
349 ASSERT_LT(id_Main1.index_, primary_dex_file_->NumStringIds());
350 ASSERT_EQ("LMain;", verifier_deps_->GetStringFromId(*primary_dex_file_, id_Main1));
351
352 dex::StringIndex id_Main2 = verifier_deps_->GetIdFromString(*primary_dex_file_, "LMain;");
353 ASSERT_LT(id_Main2.index_, primary_dex_file_->NumStringIds());
354 ASSERT_EQ("LMain;", verifier_deps_->GetStringFromId(*primary_dex_file_, id_Main2));
355
356 dex::StringIndex id_Lorem1 = verifier_deps_->GetIdFromString(*primary_dex_file_, "Lorem ipsum");
357 ASSERT_GE(id_Lorem1.index_, primary_dex_file_->NumStringIds());
358 ASSERT_EQ("Lorem ipsum", verifier_deps_->GetStringFromId(*primary_dex_file_, id_Lorem1));
359
360 dex::StringIndex id_Lorem2 = verifier_deps_->GetIdFromString(*primary_dex_file_, "Lorem ipsum");
361 ASSERT_GE(id_Lorem2.index_, primary_dex_file_->NumStringIds());
362 ASSERT_EQ("Lorem ipsum", verifier_deps_->GetStringFromId(*primary_dex_file_, id_Lorem2));
363
364 ASSERT_EQ(id_Main1, id_Main2);
365 ASSERT_EQ(id_Lorem1, id_Lorem2);
366 ASSERT_NE(id_Main1, id_Lorem1);
367 }
368
TEST_F(VerifierDepsTest,Assignable_BothInBoot)369 TEST_F(VerifierDepsTest, Assignable_BothInBoot) {
370 ASSERT_TRUE(TestAssignabilityRecording(/* dst= */ "Ljava/util/TimeZone;",
371 /* src= */ "Ljava/util/SimpleTimeZone;"));
372 ASSERT_TRUE(HasAssignable("Ljava/util/TimeZone;", "Ljava/util/SimpleTimeZone;"));
373 }
374
TEST_F(VerifierDepsTest,Assignable_BothArrays_Resolved)375 TEST_F(VerifierDepsTest, Assignable_BothArrays_Resolved) {
376 ASSERT_TRUE(TestAssignabilityRecording(/* dst= */ "[[Ljava/util/TimeZone;",
377 /* src= */ "[[Ljava/util/SimpleTimeZone;"));
378 // If the component types of both arrays are resolved, we optimize the list of
379 // dependencies by recording a dependency on the component types.
380 ASSERT_FALSE(HasAssignable("[[Ljava/util/TimeZone;", "[[Ljava/util/SimpleTimeZone;"));
381 ASSERT_FALSE(HasAssignable("[Ljava/util/TimeZone;", "[Ljava/util/SimpleTimeZone;"));
382 ASSERT_TRUE(HasAssignable("Ljava/util/TimeZone;", "Ljava/util/SimpleTimeZone;"));
383 }
384
TEST_F(VerifierDepsTest,ReturnType_Reference)385 TEST_F(VerifierDepsTest, ReturnType_Reference) {
386 ASSERT_TRUE(VerifyMethod("ReturnType_Reference"));
387 ASSERT_TRUE(HasAssignable("Ljava/lang/Throwable;", "Ljava/lang/IllegalStateException;"));
388 }
389
TEST_F(VerifierDepsTest,InvokeArgumentType)390 TEST_F(VerifierDepsTest, InvokeArgumentType) {
391 ASSERT_TRUE(VerifyMethod("InvokeArgumentType"));
392 ASSERT_TRUE(HasAssignable("Ljava/util/TimeZone;", "Ljava/util/SimpleTimeZone;"));
393 }
394
TEST_F(VerifierDepsTest,MergeTypes_RegisterLines)395 TEST_F(VerifierDepsTest, MergeTypes_RegisterLines) {
396 ASSERT_TRUE(VerifyMethod("MergeTypes_RegisterLines"));
397 ASSERT_TRUE(HasAssignable("Ljava/lang/Exception;", "LMySocketTimeoutException;"));
398 ASSERT_TRUE(HasAssignable(
399 "Ljava/lang/Exception;", "Ljava/util/concurrent/TimeoutException;"));
400 }
401
TEST_F(VerifierDepsTest,MergeTypes_IfInstanceOf)402 TEST_F(VerifierDepsTest, MergeTypes_IfInstanceOf) {
403 ASSERT_TRUE(VerifyMethod("MergeTypes_IfInstanceOf"));
404 ASSERT_TRUE(HasAssignable("Ljava/lang/Exception;", "Ljava/net/SocketTimeoutException;"));
405 ASSERT_TRUE(HasAssignable(
406 "Ljava/lang/Exception;", "Ljava/util/concurrent/TimeoutException;"));
407 }
408
TEST_F(VerifierDepsTest,MergeTypes_Unresolved)409 TEST_F(VerifierDepsTest, MergeTypes_Unresolved) {
410 ASSERT_TRUE(VerifyMethod("MergeTypes_Unresolved"));
411 ASSERT_TRUE(HasAssignable("Ljava/lang/Exception;", "Ljava/net/SocketTimeoutException;"));
412 ASSERT_TRUE(HasAssignable(
413 "Ljava/lang/Exception;", "Ljava/util/concurrent/TimeoutException;"));
414 }
415
TEST_F(VerifierDepsTest,Throw)416 TEST_F(VerifierDepsTest, Throw) {
417 ASSERT_TRUE(VerifyMethod("Throw"));
418 ASSERT_TRUE(HasAssignable("Ljava/lang/Throwable;", "Ljava/lang/IllegalStateException;"));
419 }
420
TEST_F(VerifierDepsTest,MoveException_Resolved)421 TEST_F(VerifierDepsTest, MoveException_Resolved) {
422 ASSERT_TRUE(VerifyMethod("MoveException_Resolved"));
423
424 // Testing that all exception types are assignable to Throwable.
425 ASSERT_TRUE(HasAssignable("Ljava/lang/Throwable;", "Ljava/io/InterruptedIOException;"));
426 ASSERT_TRUE(HasAssignable("Ljava/lang/Throwable;", "Ljava/net/SocketTimeoutException;"));
427 ASSERT_TRUE(HasAssignable("Ljava/lang/Throwable;", "Ljava/util/zip/ZipException;"));
428
429 // Testing that the merge type is assignable to Throwable.
430 ASSERT_TRUE(HasAssignable("Ljava/lang/Throwable;", "Ljava/io/IOException;"));
431
432 // Merging of exception types.
433 ASSERT_TRUE(HasAssignable("Ljava/io/IOException;", "Ljava/io/InterruptedIOException;"));
434 ASSERT_TRUE(HasAssignable("Ljava/io/IOException;", "Ljava/util/zip/ZipException;"));
435 ASSERT_TRUE(HasAssignable(
436 "Ljava/io/InterruptedIOException;", "Ljava/net/SocketTimeoutException;"));
437 }
438
TEST_F(VerifierDepsTest,InstanceField_Resolved_DeclaredInReferenced)439 TEST_F(VerifierDepsTest, InstanceField_Resolved_DeclaredInReferenced) {
440 ASSERT_TRUE(VerifyMethod("InstanceField_Resolved_DeclaredInReferenced"));
441 ASSERT_TRUE(HasAssignable(
442 "Ljava/io/InterruptedIOException;", "LMySocketTimeoutException;"));
443 }
444
TEST_F(VerifierDepsTest,InstanceField_Resolved_DeclaredInSuperclass1)445 TEST_F(VerifierDepsTest, InstanceField_Resolved_DeclaredInSuperclass1) {
446 ASSERT_TRUE(VerifyMethod("InstanceField_Resolved_DeclaredInSuperclass1"));
447 ASSERT_TRUE(HasAssignable(
448 "Ljava/io/InterruptedIOException;", "LMySocketTimeoutException;"));
449 }
450
TEST_F(VerifierDepsTest,InstanceField_Resolved_DeclaredInSuperclass2)451 TEST_F(VerifierDepsTest, InstanceField_Resolved_DeclaredInSuperclass2) {
452 ASSERT_TRUE(VerifyMethod("InstanceField_Resolved_DeclaredInSuperclass2"));
453 ASSERT_TRUE(HasAssignable(
454 "Ljava/io/InterruptedIOException;", "LMySocketTimeoutException;"));
455 }
456
TEST_F(VerifierDepsTest,InvokeVirtual_Resolved_DeclaredInReferenced)457 TEST_F(VerifierDepsTest, InvokeVirtual_Resolved_DeclaredInReferenced) {
458 ASSERT_TRUE(VerifyMethod("InvokeVirtual_Resolved_DeclaredInReferenced"));
459 // Type dependency on `this` argument.
460 ASSERT_TRUE(HasAssignable("Ljava/lang/Throwable;", "LMySocketTimeoutException;"));
461 }
462
TEST_F(VerifierDepsTest,InvokeVirtual_Resolved_DeclaredInSuperclass1)463 TEST_F(VerifierDepsTest, InvokeVirtual_Resolved_DeclaredInSuperclass1) {
464 ASSERT_TRUE(VerifyMethod("InvokeVirtual_Resolved_DeclaredInSuperclass1"));
465 // Type dependency on `this` argument.
466 ASSERT_TRUE(HasAssignable("Ljava/lang/Throwable;", "LMySocketTimeoutException;"));
467 }
468
TEST_F(VerifierDepsTest,InvokeSuper_ThisAssignable)469 TEST_F(VerifierDepsTest, InvokeSuper_ThisAssignable) {
470 ASSERT_TRUE(VerifyMethod("InvokeSuper_ThisAssignable"));
471 ASSERT_TRUE(HasAssignable("Ljava/lang/Runnable;", "LMain;"));
472 }
473
TEST_F(VerifierDepsTest,EncodeDecode)474 TEST_F(VerifierDepsTest, EncodeDecode) {
475 VerifyDexFile();
476
477 ASSERT_EQ(1u, NumberOfCompiledDexFiles());
478 ASSERT_TRUE(HasEachKindOfRecord());
479
480 std::vector<uint8_t> buffer;
481 verifier_deps_->Encode(dex_files_, &buffer);
482 ASSERT_FALSE(buffer.empty());
483
484 VerifierDeps decoded_deps(dex_files_, /*output_only=*/ false);
485 bool parsed = decoded_deps.ParseStoredData(dex_files_, ArrayRef<const uint8_t>(buffer));
486 ASSERT_TRUE(parsed);
487 ASSERT_TRUE(verifier_deps_->Equals(decoded_deps));
488 }
489
TEST_F(VerifierDepsTest,EncodeDecodeMulti)490 TEST_F(VerifierDepsTest, EncodeDecodeMulti) {
491 VerifyDexFile("MultiDex");
492
493 ASSERT_GT(NumberOfCompiledDexFiles(), 1u);
494 std::vector<uint8_t> buffer;
495 verifier_deps_->Encode(dex_files_, &buffer);
496 ASSERT_FALSE(buffer.empty());
497
498 // Create new DexFile, to mess with std::map order: the verifier deps used
499 // to iterate over the map, which doesn't guarantee insertion order. We fixed
500 // this by passing the expected order when encoding/decoding.
501 std::vector<std::unique_ptr<const DexFile>> first_dex_files = OpenTestDexFiles("VerifierDeps");
502 std::vector<std::unique_ptr<const DexFile>> second_dex_files = OpenTestDexFiles("MultiDex");
503 std::vector<const DexFile*> dex_files;
504 for (auto& dex_file : first_dex_files) {
505 dex_files.push_back(dex_file.get());
506 }
507 for (auto& dex_file : second_dex_files) {
508 dex_files.push_back(dex_file.get());
509 }
510
511 // Dump the new verifier deps to ensure it can properly read the data.
512 VerifierDeps decoded_deps(dex_files, /*output_only=*/ false);
513 bool parsed = decoded_deps.ParseStoredData(dex_files, ArrayRef<const uint8_t>(buffer));
514 ASSERT_TRUE(parsed);
515 std::ostringstream stream;
516 VariableIndentationOutputStream os(&stream);
517 decoded_deps.Dump(&os);
518 }
519
TEST_F(VerifierDepsTest,UnverifiedClasses)520 TEST_F(VerifierDepsTest, UnverifiedClasses) {
521 VerifyDexFile();
522 ASSERT_FALSE(HasUnverifiedClass("LMyThread;"));
523 // Test that a class with a soft failure is recorded.
524 ASSERT_TRUE(HasUnverifiedClass("LMain;"));
525 // Test that a class with hard failure is recorded.
526 ASSERT_TRUE(HasUnverifiedClass("LMyVerificationFailure;"));
527 // Test that a class with unresolved super and hard failure is recorded.
528 ASSERT_TRUE(HasUnverifiedClass("LMyClassWithNoSuperButFailures;"));
529 // Test that a class with unresolved super can be verified.
530 ASSERT_TRUE(HasVerifiedClass("LMyClassWithNoSuper;"));
531 }
532
TEST_F(VerifierDepsTest,UnverifiedOrder)533 TEST_F(VerifierDepsTest, UnverifiedOrder) {
534 ScopedObjectAccess soa(Thread::Current());
535 jobject loader = LoadDex("VerifierDeps");
536 std::vector<const DexFile*> dex_files = GetDexFiles(loader);
537 ASSERT_GT(dex_files.size(), 0u);
538 const DexFile* dex_file = dex_files[0];
539 VerifierDeps deps1(dex_files);
540 deps1.MaybeRecordVerificationStatus(&deps1,
541 *dex_file,
542 dex_file->GetClassDef(0u),
543 verifier::FailureKind::kHardFailure);
544 deps1.MaybeRecordVerificationStatus(&deps1,
545 *dex_file,
546 dex_file->GetClassDef(1u),
547 verifier::FailureKind::kHardFailure);
548 VerifierDeps deps2(dex_files);
549 deps2.MaybeRecordVerificationStatus(&deps2,
550 *dex_file,
551 dex_file->GetClassDef(1u),
552 verifier::FailureKind::kHardFailure);
553 deps2.MaybeRecordVerificationStatus(&deps2,
554 *dex_file,
555 dex_file->GetClassDef(0u),
556 verifier::FailureKind::kHardFailure);
557 std::vector<uint8_t> buffer1;
558 deps1.Encode(dex_files, &buffer1);
559 std::vector<uint8_t> buffer2;
560 deps2.Encode(dex_files, &buffer2);
561 EXPECT_EQ(buffer1, buffer2);
562 }
563
TEST_F(VerifierDepsTest,VerifyDeps)564 TEST_F(VerifierDepsTest, VerifyDeps) {
565 std::string error_msg;
566
567 VerifyDexFile();
568 ASSERT_EQ(1u, NumberOfCompiledDexFiles());
569 ASSERT_TRUE(HasEachKindOfRecord());
570
571 // When validating, we create a new class loader, as
572 // the existing `class_loader_` may contain erroneous classes,
573 // that ClassLinker::FindClass won't return.
574
575 std::vector<uint8_t> buffer;
576 verifier_deps_->Encode(dex_files_, &buffer);
577 ASSERT_FALSE(buffer.empty());
578
579 // Check that dependencies are satisfied after decoding `buffer`.
580 ASSERT_TRUE(RunValidation([](VerifierDeps::DexFileDeps&) {}, buffer, &error_msg))
581 << error_msg;
582 }
583
TEST_F(VerifierDepsTest,CompilerDriver)584 TEST_F(VerifierDepsTest, CompilerDriver) {
585 SetupCompilerDriver();
586
587 // Test both multi-dex and single-dex configuration.
588 for (const char* multi : { "MultiDex", static_cast<const char*>(nullptr) }) {
589 // Test that the compiler driver behaves as expected when the dependencies
590 // verify and when they don't verify.
591 for (bool verify_failure : { false, true }) {
592 {
593 ScopedObjectAccess soa(Thread::Current());
594 LoadDexFile(soa, "VerifierDeps", multi);
595 }
596 VerifyWithCompilerDriver(/* verifier_deps= */ nullptr);
597
598 std::vector<uint8_t> buffer;
599 verifier_deps_->Encode(dex_files_, &buffer);
600
601 {
602 ScopedObjectAccess soa(Thread::Current());
603 LoadDexFile(soa, "VerifierDeps", multi);
604 }
605 VerifierDeps decoded_deps(dex_files_, /*output_only=*/ false);
606 bool parsed = decoded_deps.ParseStoredData(dex_files_, ArrayRef<const uint8_t>(buffer));
607 ASSERT_TRUE(parsed);
608 VerifyWithCompilerDriver(&decoded_deps);
609
610 if (verify_failure) {
611 ASSERT_FALSE(verifier_deps_ == nullptr);
612 ASSERT_FALSE(verifier_deps_->Equals(decoded_deps));
613 } else {
614 VerifyClassStatus(decoded_deps);
615 }
616 }
617 }
618 }
619
TEST_F(VerifierDepsTest,MultiDexVerification)620 TEST_F(VerifierDepsTest, MultiDexVerification) {
621 VerifyDexFile("VerifierDepsMulti");
622 ASSERT_EQ(NumberOfCompiledDexFiles(), 2u);
623
624 ASSERT_TRUE(HasUnverifiedClass("LMySoftVerificationFailure;", *dex_files_[1]));
625 ASSERT_TRUE(HasUnverifiedClass("LMySub1SoftVerificationFailure;", *dex_files_[0]));
626 ASSERT_TRUE(HasUnverifiedClass("LMySub2SoftVerificationFailure;", *dex_files_[0]));
627
628 std::vector<uint8_t> buffer;
629 verifier_deps_->Encode(dex_files_, &buffer);
630 ASSERT_FALSE(buffer.empty());
631 }
632
TEST_F(VerifierDepsTest,Assignable_Arrays)633 TEST_F(VerifierDepsTest, Assignable_Arrays) {
634 ASSERT_TRUE(TestAssignabilityRecording(/* dst= */ "[LIface;",
635 /* src= */ "[LMyClassExtendingInterface;"));
636 ASSERT_FALSE(HasAssignable(
637 "LIface;", "LMyClassExtendingInterface;"));
638 }
639
640 } // namespace verifier
641 } // namespace art
642