Lines Matching +full:commit +full:- +full:message +full:- +full:check

7   ([angleproject][ANGLE-website]).
11   fixes) should generally be tracked in the bug system. Please [file a bug][anglebug-new] and
13 * If you would like bug-editing rights, simply ask a team member via email or the discussion group.
15 [ANGLE-website]: https://groups.google.com/forum/?fromgroups#!forum/angleproject
17 [anglebug-new]: http://anglebug.com/new
23 1. Must conform to the [ANGLE style][ANGLE-style] guidelines.
27 [ANGLE-style]: CodingStandard.md
35 2. ANGLE's BUILD.gn script is used by [Chromium's gn build][gn-build-config]. If you change build
37    ANGLE's commit queue (CQ) will detect such breakage. Ask a project member for help with Chromium
45 [gn-build-config]: https://www.chromium.org/developers/gn-build-configuration
54   and check the results before landing changes or requesting reviews.
55    * Upload your change (see [Making changes](#making-changes)).
56    * To kick off a try job, use the 'CQ Dry Run' button, or set the Commit-Queue +1 label to trigger
58    * If you are not part of the `angle-committers` group, you will need to either ask to be added or
62      visible in Gerrit as yellow (in-progress), green (passed), or red (failed). This can take up to
72    * The [Top-of-Tree WebGL Conformance tests][WebGL-CTS].
74        [Building ANGLE for Chromium Development][build-ANGLE-for-chromium] for instructions on
77        Chrome installation, in place of those distributed with Chrome, to check WebGL conformance.
78        [Chrome Canary][Chrome-Canary] is well-suited for this.
82    * Add new tests to `angle_end2end_tests` for OpenGL-based API tests, `angle_unittests` for
83      cross-platform internal tests, and `angle_white_box_tests` for rendering tests which also need
88   * The [Chromium GPU FYI bot waterfall][Chromium-waterfall] provides continuous integration for
93 [WebGL-CTS]: https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html
94 [build-ANGLE-for-Chromium]: BuildingAngleForChromiumDevelopment.md
95 [Chrome-Canary]: https://www.google.com/chrome/browser/canary.html
97 [Chromium-waterfall]: https://ci.chromium.org/p/chromium/g/chromium.gpu.fyi/console
101 1. You must complete the [Individual Contributor License Agreement][Individual-CLA]. You can do this
103    fill out the [Corporate Contributor License Agreement][Corporate-CLA] and send it to Google as
112 4. *NOTE TO REVIEWERS*: Follow the [External Contributor Checklist][Contributor-checklist].
114 [Individual-CLA]: https://cla.developers.google.com/about/google-individual
115 [Corporate-CLA]: https://cla.developers.google.com/about/google-corporate
116 [Contributor-checklist]: http://www.chromium.org/developers/contributing-code/external-contributor-…
120 ### <a name="getting-started-with-gerrit"></a>Getting started with Gerrit for ANGLE
122 1. Go to [https://chromium.googlesource.com/new-password][CR-passwd]
124 3. Follow the directions on the new-password page to set up authentication with your Google account.
126    * Visit [https://chromium-review.googlesource.com/#/settings][CR-settings] and check the "Full
128 5. Check out the repository (see [DevSetup](DevSetup.md)).
130    * Gerrit requires a hook to append a change ID tag to each commit, so that it can associate your
133      [https://chromium-review.googlesource.com/tools/hooks/commit-msg][commit-msg-hook] and copy
134      this file to `.git/hooks/commit-msg` within your local repository. On non-Windows platforms,
139 [CR-passwd]: https://chromium.googlesource.com/new-password
140 [CR-settings]: https://chromium-review.googlesource.com/#/settings
141 [commit-msg-hook]: https://chromium-review.googlesource.com/tools/hooks/commit-msg
145 1. Commit your changes locally:
147    * `git commit`
150      by adding the following line to the commit message: `Bug: angleproject:<issue number>`.
154    * Use `git commit --amend` to update your CL with new changes.
157    * `git pull --rebase`
161    * The change list and modified files will be uploaded to [ANGLE Gerrit][ANGLE-Gerrit].
163    * Take a moment to perform a self-review of your code. Gerrit's viewer makes it easy to see
165    * [Select reviewers](#selecting-reviewers).  If you don't do this, reviewers may not realize
171    * If you have correctly installed the commit hook from the section above, Gerrit will be able to
172      track your changes by Change-Id.
173    * You should need only to update your commit with `git commit --amend` and re-upload with
179    * `git pull --rebase`
181 [ANGLE-Gerrit]: https://chromium-review.googlesource.com/q/project:angle/angle
194  * At least two **Committers** must give approval for non-trival CLs.
197  * Committers may submit high-priority small CLs immediately using **TBR**.
201 [TBR]: https://chromium.googlesource.com/chromium/src/+/main/docs/code_reviews.md#tbr-to-be-reviewed
206 pre-submit testing.  In those cases, a CL may be reverted; often by a "[Wrangler][wrangler]", who is
212 upper-right corner of the original change.  Pressing this will pop up a dialog with a template
213 commit message, and an optional checkbox for automatically sending the revert CL to CQ.  Please edit
214 the commit message with the reason for the revert.  When satisfied, press the dialog's **REVERT**
220 command.  When doing so, the commit message should include a short description for why the original
221 commit needs to be reverted, and potentially a bug; similar to this example [revert CL][RevertCL].
223 [RevertCL]: https://chromium-review.googlesource.com/c/chromium/src/+/2453504
228 When you re-land a reverted CL, follow this process:
231  * Keep the commit message of the original CL and add a description of what changed in the re-land.
232  * Ensure the re-land CL has a unique Change-Id.
240 [RelandCL]: https://chromium-review.googlesource.com/c/angle/angle/+/2197735
241 [RelandCLDiff]: https://chromium-review.googlesource.com/c/angle/angle/+/2197735/1..3
243 If you do not need to make any changes to your CL to re-land, you can instead use Gerrit's **CREATE
248 Similar to [Chromium's committer status][Committer-status], long-term contributors to the ANGLE
249 project may request to join the `angle-committers` group.  This allows you to give `+2` on code
262 * [ANGLE Gerrit][ANGLE-Gerrit]
263 * [Chromium Projects: Contributing Code][Contributing-code]
264 * [depot_tools tutorial][depot-tools-tutorial]
265 * [angle_perftests README][Perftest-README]
268 [Committer-status]: https://dev.chromium.org/getting-involved/become-a-committer
269 [Contributing-code]: http://www.chromium.org/developers/contributing-code/
270 [depot-tools-tutorial]: http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/…
271 [Perftest-README]: ../src/tests/perf_tests/README.md
272 …: https://chromium.googlesource.com/chromium/src/+/main/docs/code_reviews.md#expectations-of-owners