Lines Matching full:review
1 Code Review Guidelines
4 This document provides TF-A specific details about the project's code review
29 To ensure the code review gives the greatest possible benefit, participants in
37 - Review other people's patches where possible. The more active reviewers there
39 code review helps everyone in the long run, as it creates a culture of
49 - Answer all comments from people who took the time to review your
56 In the event that a code review takes longer than you would hope for, you
80 There are no good or bad review comments. If you have any doubt about a patch or
82 issue slip. Examples of review comments could be:
128 through the ``Code-Owner-Review+1`` label in Gerrit. If instead, they have
130 ``Code-Owner-Review-1``.
135 - Once you are engaged in a review, make sure you stay involved until the patch
137 expected to monitor the patch author's answers to your review comments,
138 answer back if needed and review new revisions of their patch.
203 - Before merging a patch, verify that all review comments have been addressed.
208 through the ``Maintainer-Review+1`` label in Gerrit. If instead, they have
210 ``Maintainer-Review-1``.