• Home
  • Raw
  • Download

Lines Matching full:your

10     git config --global user.name "Your Name"
15 First create a branch for your changes:
22 After making your changes, create a commit
29 If your branch gets out of date, you will need to update it:
45 Unit tests are best, but if your change touches rendering and you can't think of
47 your change is in the GPU code, you may not be able to write it as part of the
59 If your feature will be conditionally enabled (e.g. like the GPU backends or image codecs), you
66 For your code to be accepted into the codebase, you must complete the
71 and send it to us as described on that page. Add your (or your organization's)
72 name and contact info to the AUTHORS file as a part of your CL.
90 appropriate reviewers for your change. The button is located here:
96 [skia-review](http://skia-review.googlesource.com). Use `git cl` to upload your
110 indicating where your changelist can be reviewed.
116 ask a committer. After uploading your CL to
136 Go to the supplied URL or go to the code review page and select the **Your**
139 any optional notes, and send your change off for review by clicking on **Send**.
140 Unless you send your change to reviewers, no one will know to look at it.
153 take such suggestions personally or as a commentary on your abilities or ideas.
173 each of their comments). When the reviewer is happy with your patch, they will
174 approve your change by setting the Code-Review label to "+1".
176 _Note_: As you work through the review process, both you and your reviewers
179 Once your change has received an approval, you can click the "Submit to CQ"
180 button on the codereview page and it will be committed on your behalf.
182 Once your commit has gone in, you should delete the branch containing your
191 output can break Chromium. If your change alters rendering in any way, you are
201 your friendly Skia-Blink engineer to evaluate, rebaseline, and land your
212 ## Check in your changes
217 commit your change directly to Skia's repository.
220 first of all, thanks for submitting your patch! We really appreciate these
222 click the "Submit to CQ" button and submit your patch via the commit queue.
225 uploading a new codereview containing your patch (perhaps with some small
226 adjustments at their discretion). If so, you can mark your change as
236 `git-cl` will squash all your commits into a single one with the description
237 you used when you uploaded your change.