• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 
5 #include "src/typing.h"
6 
7 #include "src/frames.h"
8 #include "src/frames-inl.h"
9 #include "src/parser.h"  // for CompileTimeValue; TODO(rossberg): should move
10 #include "src/scopes.h"
11 
12 namespace v8 {
13 namespace internal {
14 
15 
AstTyper(CompilationInfo * info)16 AstTyper::AstTyper(CompilationInfo* info)
17     : info_(info),
18       oracle_(
19           handle(info->closure()->shared()->code()),
20           handle(info->closure()->shared()->feedback_vector()),
21           handle(info->closure()->context()->native_context()),
22           info->zone()),
23       store_(info->zone()) {
24   InitializeAstVisitor(info->zone());
25 }
26 
27 
28 #define RECURSE(call)                         \
29   do {                                        \
30     ASSERT(!visitor->HasStackOverflow());     \
31     call;                                     \
32     if (visitor->HasStackOverflow()) return;  \
33   } while (false)
34 
Run(CompilationInfo * info)35 void AstTyper::Run(CompilationInfo* info) {
36   AstTyper* visitor = new(info->zone()) AstTyper(info);
37   Scope* scope = info->scope();
38 
39   // Handle implicit declaration of the function name in named function
40   // expressions before other declarations.
41   if (scope->is_function_scope() && scope->function() != NULL) {
42     RECURSE(visitor->VisitVariableDeclaration(scope->function()));
43   }
44   RECURSE(visitor->VisitDeclarations(scope->declarations()));
45   RECURSE(visitor->VisitStatements(info->function()->body()));
46 }
47 
48 #undef RECURSE
49 
50 
51 #ifdef OBJECT_PRINT
PrintObserved(Variable * var,Object * value,Type * type)52   static void PrintObserved(Variable* var, Object* value, Type* type) {
53     PrintF("  observed %s ", var->IsParameter() ? "param" : "local");
54     var->name()->Print();
55     PrintF(" : ");
56     value->ShortPrint();
57     PrintF(" -> ");
58     type->TypePrint();
59   }
60 #endif  // OBJECT_PRINT
61 
62 
ObservedOnStack(Object * value)63 Effect AstTyper::ObservedOnStack(Object* value) {
64   Type* lower = Type::NowOf(value, zone());
65   return Effect(Bounds(lower, Type::Any(zone())));
66 }
67 
68 
ObserveTypesAtOsrEntry(IterationStatement * stmt)69 void AstTyper::ObserveTypesAtOsrEntry(IterationStatement* stmt) {
70   if (stmt->OsrEntryId() != info_->osr_ast_id()) return;
71 
72   DisallowHeapAllocation no_gc;
73   JavaScriptFrameIterator it(isolate());
74   JavaScriptFrame* frame = it.frame();
75   Scope* scope = info_->scope();
76 
77   // Assert that the frame on the stack belongs to the function we want to OSR.
78   ASSERT_EQ(*info_->closure(), frame->function());
79 
80   int params = scope->num_parameters();
81   int locals = scope->StackLocalCount();
82 
83   // Use sequential composition to achieve desired narrowing.
84   // The receiver is a parameter with index -1.
85   store_.Seq(parameter_index(-1), ObservedOnStack(frame->receiver()));
86   for (int i = 0; i < params; i++) {
87     store_.Seq(parameter_index(i), ObservedOnStack(frame->GetParameter(i)));
88   }
89 
90   for (int i = 0; i < locals; i++) {
91     store_.Seq(stack_local_index(i), ObservedOnStack(frame->GetExpression(i)));
92   }
93 
94 #ifdef OBJECT_PRINT
95   if (FLAG_trace_osr && FLAG_print_scopes) {
96     PrintObserved(scope->receiver(),
97                   frame->receiver(),
98                   store_.LookupBounds(parameter_index(-1)).lower);
99 
100     for (int i = 0; i < params; i++) {
101       PrintObserved(scope->parameter(i),
102                     frame->GetParameter(i),
103                     store_.LookupBounds(parameter_index(i)).lower);
104     }
105 
106     ZoneList<Variable*> local_vars(locals, zone());
107     ZoneList<Variable*> context_vars(scope->ContextLocalCount(), zone());
108     scope->CollectStackAndContextLocals(&local_vars, &context_vars);
109     for (int i = 0; i < locals; i++) {
110       PrintObserved(local_vars.at(i),
111                     frame->GetExpression(i),
112                     store_.LookupBounds(stack_local_index(i)).lower);
113     }
114   }
115 #endif  // OBJECT_PRINT
116 }
117 
118 
119 #define RECURSE(call)                \
120   do {                               \
121     ASSERT(!HasStackOverflow());     \
122     call;                            \
123     if (HasStackOverflow()) return;  \
124   } while (false)
125 
126 
VisitStatements(ZoneList<Statement * > * stmts)127 void AstTyper::VisitStatements(ZoneList<Statement*>* stmts) {
128   for (int i = 0; i < stmts->length(); ++i) {
129     Statement* stmt = stmts->at(i);
130     RECURSE(Visit(stmt));
131     if (stmt->IsJump()) break;
132   }
133 }
134 
135 
VisitBlock(Block * stmt)136 void AstTyper::VisitBlock(Block* stmt) {
137   RECURSE(VisitStatements(stmt->statements()));
138   if (stmt->labels() != NULL) {
139     store_.Forget();  // Control may transfer here via 'break l'.
140   }
141 }
142 
143 
VisitExpressionStatement(ExpressionStatement * stmt)144 void AstTyper::VisitExpressionStatement(ExpressionStatement* stmt) {
145   RECURSE(Visit(stmt->expression()));
146 }
147 
148 
VisitEmptyStatement(EmptyStatement * stmt)149 void AstTyper::VisitEmptyStatement(EmptyStatement* stmt) {
150 }
151 
152 
VisitIfStatement(IfStatement * stmt)153 void AstTyper::VisitIfStatement(IfStatement* stmt) {
154   // Collect type feedback.
155   if (!stmt->condition()->ToBooleanIsTrue() &&
156       !stmt->condition()->ToBooleanIsFalse()) {
157     stmt->condition()->RecordToBooleanTypeFeedback(oracle());
158   }
159 
160   RECURSE(Visit(stmt->condition()));
161   Effects then_effects = EnterEffects();
162   RECURSE(Visit(stmt->then_statement()));
163   ExitEffects();
164   Effects else_effects = EnterEffects();
165   RECURSE(Visit(stmt->else_statement()));
166   ExitEffects();
167   then_effects.Alt(else_effects);
168   store_.Seq(then_effects);
169 }
170 
171 
VisitContinueStatement(ContinueStatement * stmt)172 void AstTyper::VisitContinueStatement(ContinueStatement* stmt) {
173   // TODO(rossberg): is it worth having a non-termination effect?
174 }
175 
176 
VisitBreakStatement(BreakStatement * stmt)177 void AstTyper::VisitBreakStatement(BreakStatement* stmt) {
178   // TODO(rossberg): is it worth having a non-termination effect?
179 }
180 
181 
VisitReturnStatement(ReturnStatement * stmt)182 void AstTyper::VisitReturnStatement(ReturnStatement* stmt) {
183   // Collect type feedback.
184   // TODO(rossberg): we only need this for inlining into test contexts...
185   stmt->expression()->RecordToBooleanTypeFeedback(oracle());
186 
187   RECURSE(Visit(stmt->expression()));
188   // TODO(rossberg): is it worth having a non-termination effect?
189 }
190 
191 
VisitWithStatement(WithStatement * stmt)192 void AstTyper::VisitWithStatement(WithStatement* stmt) {
193   RECURSE(stmt->expression());
194   RECURSE(stmt->statement());
195 }
196 
197 
VisitSwitchStatement(SwitchStatement * stmt)198 void AstTyper::VisitSwitchStatement(SwitchStatement* stmt) {
199   RECURSE(Visit(stmt->tag()));
200 
201   ZoneList<CaseClause*>* clauses = stmt->cases();
202   Effects local_effects(zone());
203   bool complex_effects = false;  // True for label effects or fall-through.
204 
205   for (int i = 0; i < clauses->length(); ++i) {
206     CaseClause* clause = clauses->at(i);
207 
208     Effects clause_effects = EnterEffects();
209 
210     if (!clause->is_default()) {
211       Expression* label = clause->label();
212       // Collect type feedback.
213       Type* tag_type;
214       Type* label_type;
215       Type* combined_type;
216       oracle()->CompareType(clause->CompareId(),
217                             &tag_type, &label_type, &combined_type);
218       NarrowLowerType(stmt->tag(), tag_type);
219       NarrowLowerType(label, label_type);
220       clause->set_compare_type(combined_type);
221 
222       RECURSE(Visit(label));
223       if (!clause_effects.IsEmpty()) complex_effects = true;
224     }
225 
226     ZoneList<Statement*>* stmts = clause->statements();
227     RECURSE(VisitStatements(stmts));
228     ExitEffects();
229     if (stmts->is_empty() || stmts->last()->IsJump()) {
230       local_effects.Alt(clause_effects);
231     } else {
232       complex_effects = true;
233     }
234   }
235 
236   if (complex_effects) {
237     store_.Forget();  // Reached this in unknown state.
238   } else {
239     store_.Seq(local_effects);
240   }
241 }
242 
243 
VisitCaseClause(CaseClause * clause)244 void AstTyper::VisitCaseClause(CaseClause* clause) {
245   UNREACHABLE();
246 }
247 
248 
VisitDoWhileStatement(DoWhileStatement * stmt)249 void AstTyper::VisitDoWhileStatement(DoWhileStatement* stmt) {
250   // Collect type feedback.
251   if (!stmt->cond()->ToBooleanIsTrue()) {
252     stmt->cond()->RecordToBooleanTypeFeedback(oracle());
253   }
254 
255   // TODO(rossberg): refine the unconditional Forget (here and elsewhere) by
256   // computing the set of variables assigned in only some of the origins of the
257   // control transfer (such as the loop body here).
258   store_.Forget();  // Control may transfer here via looping or 'continue'.
259   ObserveTypesAtOsrEntry(stmt);
260   RECURSE(Visit(stmt->body()));
261   RECURSE(Visit(stmt->cond()));
262   store_.Forget();  // Control may transfer here via 'break'.
263 }
264 
265 
VisitWhileStatement(WhileStatement * stmt)266 void AstTyper::VisitWhileStatement(WhileStatement* stmt) {
267   // Collect type feedback.
268   if (!stmt->cond()->ToBooleanIsTrue()) {
269     stmt->cond()->RecordToBooleanTypeFeedback(oracle());
270   }
271 
272   store_.Forget();  // Control may transfer here via looping or 'continue'.
273   RECURSE(Visit(stmt->cond()));
274   ObserveTypesAtOsrEntry(stmt);
275   RECURSE(Visit(stmt->body()));
276   store_.Forget();  // Control may transfer here via termination or 'break'.
277 }
278 
279 
VisitForStatement(ForStatement * stmt)280 void AstTyper::VisitForStatement(ForStatement* stmt) {
281   if (stmt->init() != NULL) {
282     RECURSE(Visit(stmt->init()));
283   }
284   store_.Forget();  // Control may transfer here via looping.
285   if (stmt->cond() != NULL) {
286     // Collect type feedback.
287     stmt->cond()->RecordToBooleanTypeFeedback(oracle());
288 
289     RECURSE(Visit(stmt->cond()));
290   }
291   ObserveTypesAtOsrEntry(stmt);
292   RECURSE(Visit(stmt->body()));
293   if (stmt->next() != NULL) {
294     store_.Forget();  // Control may transfer here via 'continue'.
295     RECURSE(Visit(stmt->next()));
296   }
297   store_.Forget();  // Control may transfer here via termination or 'break'.
298 }
299 
300 
VisitForInStatement(ForInStatement * stmt)301 void AstTyper::VisitForInStatement(ForInStatement* stmt) {
302   // Collect type feedback.
303   stmt->set_for_in_type(static_cast<ForInStatement::ForInType>(
304       oracle()->ForInType(stmt->ForInFeedbackSlot())));
305 
306   RECURSE(Visit(stmt->enumerable()));
307   store_.Forget();  // Control may transfer here via looping or 'continue'.
308   ObserveTypesAtOsrEntry(stmt);
309   RECURSE(Visit(stmt->body()));
310   store_.Forget();  // Control may transfer here via 'break'.
311 }
312 
313 
VisitForOfStatement(ForOfStatement * stmt)314 void AstTyper::VisitForOfStatement(ForOfStatement* stmt) {
315   RECURSE(Visit(stmt->iterable()));
316   store_.Forget();  // Control may transfer here via looping or 'continue'.
317   RECURSE(Visit(stmt->body()));
318   store_.Forget();  // Control may transfer here via 'break'.
319 }
320 
321 
VisitTryCatchStatement(TryCatchStatement * stmt)322 void AstTyper::VisitTryCatchStatement(TryCatchStatement* stmt) {
323   Effects try_effects = EnterEffects();
324   RECURSE(Visit(stmt->try_block()));
325   ExitEffects();
326   Effects catch_effects = EnterEffects();
327   store_.Forget();  // Control may transfer here via 'throw'.
328   RECURSE(Visit(stmt->catch_block()));
329   ExitEffects();
330   try_effects.Alt(catch_effects);
331   store_.Seq(try_effects);
332   // At this point, only variables that were reassigned in the catch block are
333   // still remembered.
334 }
335 
336 
VisitTryFinallyStatement(TryFinallyStatement * stmt)337 void AstTyper::VisitTryFinallyStatement(TryFinallyStatement* stmt) {
338   RECURSE(Visit(stmt->try_block()));
339   store_.Forget();  // Control may transfer here via 'throw'.
340   RECURSE(Visit(stmt->finally_block()));
341 }
342 
343 
VisitDebuggerStatement(DebuggerStatement * stmt)344 void AstTyper::VisitDebuggerStatement(DebuggerStatement* stmt) {
345   store_.Forget();  // May do whatever.
346 }
347 
348 
VisitFunctionLiteral(FunctionLiteral * expr)349 void AstTyper::VisitFunctionLiteral(FunctionLiteral* expr) {
350   expr->InitializeSharedInfo(Handle<Code>(info_->closure()->shared()->code()));
351 }
352 
353 
VisitNativeFunctionLiteral(NativeFunctionLiteral * expr)354 void AstTyper::VisitNativeFunctionLiteral(NativeFunctionLiteral* expr) {
355 }
356 
357 
VisitConditional(Conditional * expr)358 void AstTyper::VisitConditional(Conditional* expr) {
359   // Collect type feedback.
360   expr->condition()->RecordToBooleanTypeFeedback(oracle());
361 
362   RECURSE(Visit(expr->condition()));
363   Effects then_effects = EnterEffects();
364   RECURSE(Visit(expr->then_expression()));
365   ExitEffects();
366   Effects else_effects = EnterEffects();
367   RECURSE(Visit(expr->else_expression()));
368   ExitEffects();
369   then_effects.Alt(else_effects);
370   store_.Seq(then_effects);
371 
372   NarrowType(expr, Bounds::Either(
373       expr->then_expression()->bounds(),
374       expr->else_expression()->bounds(), zone()));
375 }
376 
377 
VisitVariableProxy(VariableProxy * expr)378 void AstTyper::VisitVariableProxy(VariableProxy* expr) {
379   Variable* var = expr->var();
380   if (var->IsStackAllocated()) {
381     NarrowType(expr, store_.LookupBounds(variable_index(var)));
382   }
383 }
384 
385 
VisitLiteral(Literal * expr)386 void AstTyper::VisitLiteral(Literal* expr) {
387   Type* type = Type::Constant(expr->value(), zone());
388   NarrowType(expr, Bounds(type));
389 }
390 
391 
VisitRegExpLiteral(RegExpLiteral * expr)392 void AstTyper::VisitRegExpLiteral(RegExpLiteral* expr) {
393   NarrowType(expr, Bounds(Type::RegExp(zone())));
394 }
395 
396 
VisitObjectLiteral(ObjectLiteral * expr)397 void AstTyper::VisitObjectLiteral(ObjectLiteral* expr) {
398   ZoneList<ObjectLiteral::Property*>* properties = expr->properties();
399   for (int i = 0; i < properties->length(); ++i) {
400     ObjectLiteral::Property* prop = properties->at(i);
401 
402     // Collect type feedback.
403     if ((prop->kind() == ObjectLiteral::Property::MATERIALIZED_LITERAL &&
404         !CompileTimeValue::IsCompileTimeValue(prop->value())) ||
405         prop->kind() == ObjectLiteral::Property::COMPUTED) {
406       if (prop->key()->value()->IsInternalizedString() && prop->emit_store()) {
407         prop->RecordTypeFeedback(oracle());
408       }
409     }
410 
411     RECURSE(Visit(prop->value()));
412   }
413 
414   NarrowType(expr, Bounds(Type::Object(zone())));
415 }
416 
417 
VisitArrayLiteral(ArrayLiteral * expr)418 void AstTyper::VisitArrayLiteral(ArrayLiteral* expr) {
419   ZoneList<Expression*>* values = expr->values();
420   for (int i = 0; i < values->length(); ++i) {
421     Expression* value = values->at(i);
422     RECURSE(Visit(value));
423   }
424 
425   NarrowType(expr, Bounds(Type::Array(zone())));
426 }
427 
428 
VisitAssignment(Assignment * expr)429 void AstTyper::VisitAssignment(Assignment* expr) {
430   // Collect type feedback.
431   Property* prop = expr->target()->AsProperty();
432   if (prop != NULL) {
433     TypeFeedbackId id = expr->AssignmentFeedbackId();
434     expr->set_is_uninitialized(oracle()->StoreIsUninitialized(id));
435     if (!expr->IsUninitialized()) {
436       if (prop->key()->IsPropertyName()) {
437         Literal* lit_key = prop->key()->AsLiteral();
438         ASSERT(lit_key != NULL && lit_key->value()->IsString());
439         Handle<String> name = Handle<String>::cast(lit_key->value());
440         oracle()->AssignmentReceiverTypes(id, name, expr->GetReceiverTypes());
441       } else {
442         KeyedAccessStoreMode store_mode;
443         oracle()->KeyedAssignmentReceiverTypes(
444             id, expr->GetReceiverTypes(), &store_mode);
445         expr->set_store_mode(store_mode);
446       }
447     }
448   }
449 
450   Expression* rhs =
451       expr->is_compound() ? expr->binary_operation() : expr->value();
452   RECURSE(Visit(expr->target()));
453   RECURSE(Visit(rhs));
454   NarrowType(expr, rhs->bounds());
455 
456   VariableProxy* proxy = expr->target()->AsVariableProxy();
457   if (proxy != NULL && proxy->var()->IsStackAllocated()) {
458     store_.Seq(variable_index(proxy->var()), Effect(expr->bounds()));
459   }
460 }
461 
462 
VisitYield(Yield * expr)463 void AstTyper::VisitYield(Yield* expr) {
464   RECURSE(Visit(expr->generator_object()));
465   RECURSE(Visit(expr->expression()));
466 
467   // We don't know anything about the result type.
468 }
469 
470 
VisitThrow(Throw * expr)471 void AstTyper::VisitThrow(Throw* expr) {
472   RECURSE(Visit(expr->exception()));
473   // TODO(rossberg): is it worth having a non-termination effect?
474 
475   NarrowType(expr, Bounds(Type::None(zone())));
476 }
477 
478 
VisitProperty(Property * expr)479 void AstTyper::VisitProperty(Property* expr) {
480   // Collect type feedback.
481   TypeFeedbackId id = expr->PropertyFeedbackId();
482   expr->set_is_uninitialized(oracle()->LoadIsUninitialized(id));
483   if (!expr->IsUninitialized()) {
484     if (expr->key()->IsPropertyName()) {
485       Literal* lit_key = expr->key()->AsLiteral();
486       ASSERT(lit_key != NULL && lit_key->value()->IsString());
487       Handle<String> name = Handle<String>::cast(lit_key->value());
488       bool is_prototype;
489       oracle()->PropertyReceiverTypes(
490           id, name, expr->GetReceiverTypes(), &is_prototype);
491       expr->set_is_function_prototype(is_prototype);
492     } else {
493       bool is_string;
494       oracle()->KeyedPropertyReceiverTypes(
495           id, expr->GetReceiverTypes(), &is_string);
496       expr->set_is_string_access(is_string);
497     }
498   }
499 
500   RECURSE(Visit(expr->obj()));
501   RECURSE(Visit(expr->key()));
502 
503   // We don't know anything about the result type.
504 }
505 
506 
VisitCall(Call * expr)507 void AstTyper::VisitCall(Call* expr) {
508   // Collect type feedback.
509   RECURSE(Visit(expr->expression()));
510   if (!expr->expression()->IsProperty() &&
511       expr->IsUsingCallFeedbackSlot(isolate()) &&
512       oracle()->CallIsMonomorphic(expr->CallFeedbackSlot())) {
513     expr->set_target(oracle()->GetCallTarget(expr->CallFeedbackSlot()));
514     Handle<AllocationSite> site =
515         oracle()->GetCallAllocationSite(expr->CallFeedbackSlot());
516     expr->set_allocation_site(site);
517   }
518 
519   ZoneList<Expression*>* args = expr->arguments();
520   for (int i = 0; i < args->length(); ++i) {
521     Expression* arg = args->at(i);
522     RECURSE(Visit(arg));
523   }
524 
525   VariableProxy* proxy = expr->expression()->AsVariableProxy();
526   if (proxy != NULL && proxy->var()->is_possibly_eval(isolate())) {
527     store_.Forget();  // Eval could do whatever to local variables.
528   }
529 
530   // We don't know anything about the result type.
531 }
532 
533 
VisitCallNew(CallNew * expr)534 void AstTyper::VisitCallNew(CallNew* expr) {
535   // Collect type feedback.
536   expr->RecordTypeFeedback(oracle());
537 
538   RECURSE(Visit(expr->expression()));
539   ZoneList<Expression*>* args = expr->arguments();
540   for (int i = 0; i < args->length(); ++i) {
541     Expression* arg = args->at(i);
542     RECURSE(Visit(arg));
543   }
544 
545   NarrowType(expr, Bounds(Type::None(zone()), Type::Receiver(zone())));
546 }
547 
548 
VisitCallRuntime(CallRuntime * expr)549 void AstTyper::VisitCallRuntime(CallRuntime* expr) {
550   ZoneList<Expression*>* args = expr->arguments();
551   for (int i = 0; i < args->length(); ++i) {
552     Expression* arg = args->at(i);
553     RECURSE(Visit(arg));
554   }
555 
556   // We don't know anything about the result type.
557 }
558 
559 
VisitUnaryOperation(UnaryOperation * expr)560 void AstTyper::VisitUnaryOperation(UnaryOperation* expr) {
561   // Collect type feedback.
562   if (expr->op() == Token::NOT) {
563     // TODO(rossberg): only do in test or value context.
564     expr->expression()->RecordToBooleanTypeFeedback(oracle());
565   }
566 
567   RECURSE(Visit(expr->expression()));
568 
569   switch (expr->op()) {
570     case Token::NOT:
571     case Token::DELETE:
572       NarrowType(expr, Bounds(Type::Boolean(zone())));
573       break;
574     case Token::VOID:
575       NarrowType(expr, Bounds(Type::Undefined(zone())));
576       break;
577     case Token::TYPEOF:
578       NarrowType(expr, Bounds(Type::InternalizedString(zone())));
579       break;
580     default:
581       UNREACHABLE();
582   }
583 }
584 
585 
VisitCountOperation(CountOperation * expr)586 void AstTyper::VisitCountOperation(CountOperation* expr) {
587   // Collect type feedback.
588   TypeFeedbackId store_id = expr->CountStoreFeedbackId();
589   expr->set_store_mode(oracle()->GetStoreMode(store_id));
590   oracle()->CountReceiverTypes(store_id, expr->GetReceiverTypes());
591   expr->set_type(oracle()->CountType(expr->CountBinOpFeedbackId()));
592   // TODO(rossberg): merge the count type with the generic expression type.
593 
594   RECURSE(Visit(expr->expression()));
595 
596   NarrowType(expr, Bounds(Type::SignedSmall(zone()), Type::Number(zone())));
597 
598   VariableProxy* proxy = expr->expression()->AsVariableProxy();
599   if (proxy != NULL && proxy->var()->IsStackAllocated()) {
600     store_.Seq(variable_index(proxy->var()), Effect(expr->bounds()));
601   }
602 }
603 
604 
VisitBinaryOperation(BinaryOperation * expr)605 void AstTyper::VisitBinaryOperation(BinaryOperation* expr) {
606   // Collect type feedback.
607   Type* type;
608   Type* left_type;
609   Type* right_type;
610   Maybe<int> fixed_right_arg;
611   Handle<AllocationSite> allocation_site;
612   oracle()->BinaryType(expr->BinaryOperationFeedbackId(),
613       &left_type, &right_type, &type, &fixed_right_arg,
614       &allocation_site, expr->op());
615   NarrowLowerType(expr, type);
616   NarrowLowerType(expr->left(), left_type);
617   NarrowLowerType(expr->right(), right_type);
618   expr->set_allocation_site(allocation_site);
619   expr->set_fixed_right_arg(fixed_right_arg);
620   if (expr->op() == Token::OR || expr->op() == Token::AND) {
621     expr->left()->RecordToBooleanTypeFeedback(oracle());
622   }
623 
624   switch (expr->op()) {
625     case Token::COMMA:
626       RECURSE(Visit(expr->left()));
627       RECURSE(Visit(expr->right()));
628       NarrowType(expr, expr->right()->bounds());
629       break;
630     case Token::OR:
631     case Token::AND: {
632       Effects left_effects = EnterEffects();
633       RECURSE(Visit(expr->left()));
634       ExitEffects();
635       Effects right_effects = EnterEffects();
636       RECURSE(Visit(expr->right()));
637       ExitEffects();
638       left_effects.Alt(right_effects);
639       store_.Seq(left_effects);
640 
641       NarrowType(expr, Bounds::Either(
642           expr->left()->bounds(), expr->right()->bounds(), zone()));
643       break;
644     }
645     case Token::BIT_OR:
646     case Token::BIT_AND: {
647       RECURSE(Visit(expr->left()));
648       RECURSE(Visit(expr->right()));
649       Type* upper = Type::Union(
650           expr->left()->bounds().upper, expr->right()->bounds().upper, zone());
651       if (!upper->Is(Type::Signed32())) upper = Type::Signed32(zone());
652       Type* lower = Type::Intersect(Type::SignedSmall(zone()), upper, zone());
653       NarrowType(expr, Bounds(lower, upper));
654       break;
655     }
656     case Token::BIT_XOR:
657     case Token::SHL:
658     case Token::SAR:
659       RECURSE(Visit(expr->left()));
660       RECURSE(Visit(expr->right()));
661       NarrowType(expr,
662           Bounds(Type::SignedSmall(zone()), Type::Signed32(zone())));
663       break;
664     case Token::SHR:
665       RECURSE(Visit(expr->left()));
666       RECURSE(Visit(expr->right()));
667       // TODO(rossberg): The upper bound would be Unsigned32, but since there
668       // is no 'positive Smi' type for the lower bound, we use the smallest
669       // union of Smi and Unsigned32 as upper bound instead.
670       NarrowType(expr, Bounds(Type::SignedSmall(zone()), Type::Number(zone())));
671       break;
672     case Token::ADD: {
673       RECURSE(Visit(expr->left()));
674       RECURSE(Visit(expr->right()));
675       Bounds l = expr->left()->bounds();
676       Bounds r = expr->right()->bounds();
677       Type* lower =
678           !l.lower->IsInhabited() || !r.lower->IsInhabited() ?
679               Type::None(zone()) :
680           l.lower->Is(Type::String()) || r.lower->Is(Type::String()) ?
681               Type::String(zone()) :
682           l.lower->Is(Type::Number()) && r.lower->Is(Type::Number()) ?
683               Type::SignedSmall(zone()) : Type::None(zone());
684       Type* upper =
685           l.upper->Is(Type::String()) || r.upper->Is(Type::String()) ?
686               Type::String(zone()) :
687           l.upper->Is(Type::Number()) && r.upper->Is(Type::Number()) ?
688               Type::Number(zone()) : Type::NumberOrString(zone());
689       NarrowType(expr, Bounds(lower, upper));
690       break;
691     }
692     case Token::SUB:
693     case Token::MUL:
694     case Token::DIV:
695     case Token::MOD:
696       RECURSE(Visit(expr->left()));
697       RECURSE(Visit(expr->right()));
698       NarrowType(expr, Bounds(Type::SignedSmall(zone()), Type::Number(zone())));
699       break;
700     default:
701       UNREACHABLE();
702   }
703 }
704 
705 
VisitCompareOperation(CompareOperation * expr)706 void AstTyper::VisitCompareOperation(CompareOperation* expr) {
707   // Collect type feedback.
708   Type* left_type;
709   Type* right_type;
710   Type* combined_type;
711   oracle()->CompareType(expr->CompareOperationFeedbackId(),
712       &left_type, &right_type, &combined_type);
713   NarrowLowerType(expr->left(), left_type);
714   NarrowLowerType(expr->right(), right_type);
715   expr->set_combined_type(combined_type);
716 
717   RECURSE(Visit(expr->left()));
718   RECURSE(Visit(expr->right()));
719 
720   NarrowType(expr, Bounds(Type::Boolean(zone())));
721 }
722 
723 
VisitThisFunction(ThisFunction * expr)724 void AstTyper::VisitThisFunction(ThisFunction* expr) {
725 }
726 
727 
VisitDeclarations(ZoneList<Declaration * > * decls)728 void AstTyper::VisitDeclarations(ZoneList<Declaration*>* decls) {
729   for (int i = 0; i < decls->length(); ++i) {
730     Declaration* decl = decls->at(i);
731     RECURSE(Visit(decl));
732   }
733 }
734 
735 
VisitVariableDeclaration(VariableDeclaration * declaration)736 void AstTyper::VisitVariableDeclaration(VariableDeclaration* declaration) {
737 }
738 
739 
VisitFunctionDeclaration(FunctionDeclaration * declaration)740 void AstTyper::VisitFunctionDeclaration(FunctionDeclaration* declaration) {
741   RECURSE(Visit(declaration->fun()));
742 }
743 
744 
VisitModuleDeclaration(ModuleDeclaration * declaration)745 void AstTyper::VisitModuleDeclaration(ModuleDeclaration* declaration) {
746   RECURSE(Visit(declaration->module()));
747 }
748 
749 
VisitImportDeclaration(ImportDeclaration * declaration)750 void AstTyper::VisitImportDeclaration(ImportDeclaration* declaration) {
751   RECURSE(Visit(declaration->module()));
752 }
753 
754 
VisitExportDeclaration(ExportDeclaration * declaration)755 void AstTyper::VisitExportDeclaration(ExportDeclaration* declaration) {
756 }
757 
758 
VisitModuleLiteral(ModuleLiteral * module)759 void AstTyper::VisitModuleLiteral(ModuleLiteral* module) {
760   RECURSE(Visit(module->body()));
761 }
762 
763 
VisitModuleVariable(ModuleVariable * module)764 void AstTyper::VisitModuleVariable(ModuleVariable* module) {
765 }
766 
767 
VisitModulePath(ModulePath * module)768 void AstTyper::VisitModulePath(ModulePath* module) {
769   RECURSE(Visit(module->module()));
770 }
771 
772 
VisitModuleUrl(ModuleUrl * module)773 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
774 }
775 
776 
VisitModuleStatement(ModuleStatement * stmt)777 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
778   RECURSE(Visit(stmt->body()));
779 }
780 
781 
782 } }  // namespace v8::internal
783