• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 // SPDX-License-Identifier: GPL-2.0
2 /*
3  * Copyright (c) 2000-2005 Silicon Graphics, Inc.
4  * All Rights Reserved.
5  */
6 #include "xfs.h"
7 #include "xfs_fs.h"
8 #include "xfs_shared.h"
9 #include "xfs_format.h"
10 #include "xfs_log_format.h"
11 #include "xfs_trans_resv.h"
12 #include "xfs_sb.h"
13 #include "xfs_mount.h"
14 #include "xfs_trans.h"
15 #include "xfs_error.h"
16 #include "xfs_alloc.h"
17 #include "xfs_fsops.h"
18 #include "xfs_trans_space.h"
19 #include "xfs_log.h"
20 #include "xfs_log_priv.h"
21 #include "xfs_ag.h"
22 #include "xfs_ag_resv.h"
23 #include "xfs_trace.h"
24 
25 /*
26  * Write new AG headers to disk. Non-transactional, but need to be
27  * written and completed prior to the growfs transaction being logged.
28  * To do this, we use a delayed write buffer list and wait for
29  * submission and IO completion of the list as a whole. This allows the
30  * IO subsystem to merge all the AG headers in a single AG into a single
31  * IO and hide most of the latency of the IO from us.
32  *
33  * This also means that if we get an error whilst building the buffer
34  * list to write, we can cancel the entire list without having written
35  * anything.
36  */
37 static int
xfs_resizefs_init_new_ags(struct xfs_trans * tp,struct aghdr_init_data * id,xfs_agnumber_t oagcount,xfs_agnumber_t nagcount,xfs_rfsblock_t delta,struct xfs_perag * last_pag,bool * lastag_extended)38 xfs_resizefs_init_new_ags(
39 	struct xfs_trans	*tp,
40 	struct aghdr_init_data	*id,
41 	xfs_agnumber_t		oagcount,
42 	xfs_agnumber_t		nagcount,
43 	xfs_rfsblock_t		delta,
44 	struct xfs_perag	*last_pag,
45 	bool			*lastag_extended)
46 {
47 	struct xfs_mount	*mp = tp->t_mountp;
48 	xfs_rfsblock_t		nb = mp->m_sb.sb_dblocks + delta;
49 	int			error;
50 
51 	*lastag_extended = false;
52 
53 	INIT_LIST_HEAD(&id->buffer_list);
54 	for (id->agno = nagcount - 1;
55 	     id->agno >= oagcount;
56 	     id->agno--, delta -= id->agsize) {
57 
58 		if (id->agno == nagcount - 1)
59 			id->agsize = nb - (id->agno *
60 					(xfs_rfsblock_t)mp->m_sb.sb_agblocks);
61 		else
62 			id->agsize = mp->m_sb.sb_agblocks;
63 
64 		error = xfs_ag_init_headers(mp, id);
65 		if (error) {
66 			xfs_buf_delwri_cancel(&id->buffer_list);
67 			return error;
68 		}
69 	}
70 
71 	error = xfs_buf_delwri_submit(&id->buffer_list);
72 	if (error)
73 		return error;
74 
75 	if (delta) {
76 		*lastag_extended = true;
77 		error = xfs_ag_extend_space(last_pag, tp, delta);
78 	}
79 	return error;
80 }
81 
82 /*
83  * growfs operations
84  */
85 static int
xfs_growfs_data_private(struct xfs_mount * mp,struct xfs_growfs_data * in)86 xfs_growfs_data_private(
87 	struct xfs_mount	*mp,		/* mount point for filesystem */
88 	struct xfs_growfs_data	*in)		/* growfs data input struct */
89 {
90 	struct xfs_buf		*bp;
91 	int			error;
92 	xfs_agnumber_t		nagcount;
93 	xfs_agnumber_t		nagimax = 0;
94 	xfs_rfsblock_t		nb, nb_div, nb_mod;
95 	int64_t			delta;
96 	bool			lastag_extended = false;
97 	xfs_agnumber_t		oagcount;
98 	struct xfs_trans	*tp;
99 	struct aghdr_init_data	id = {};
100 	struct xfs_perag	*last_pag;
101 
102 	nb = in->newblocks;
103 	error = xfs_sb_validate_fsb_count(&mp->m_sb, nb);
104 	if (error)
105 		return error;
106 
107 	if (nb > mp->m_sb.sb_dblocks) {
108 		error = xfs_buf_read_uncached(mp->m_ddev_targp,
109 				XFS_FSB_TO_BB(mp, nb) - XFS_FSS_TO_BB(mp, 1),
110 				XFS_FSS_TO_BB(mp, 1), 0, &bp, NULL);
111 		if (error)
112 			return error;
113 		xfs_buf_relse(bp);
114 	}
115 
116 	nb_div = nb;
117 	nb_mod = do_div(nb_div, mp->m_sb.sb_agblocks);
118 	if (nb_mod && nb_mod >= XFS_MIN_AG_BLOCKS)
119 		nb_div++;
120 	else if (nb_mod)
121 		nb = nb_div * mp->m_sb.sb_agblocks;
122 
123 	if (nb_div > XFS_MAX_AGNUMBER + 1) {
124 		nb_div = XFS_MAX_AGNUMBER + 1;
125 		nb = nb_div * mp->m_sb.sb_agblocks;
126 	}
127 	nagcount = nb_div;
128 	delta = nb - mp->m_sb.sb_dblocks;
129 	/*
130 	 * Reject filesystems with a single AG because they are not
131 	 * supported, and reject a shrink operation that would cause a
132 	 * filesystem to become unsupported.
133 	 */
134 	if (delta < 0 && nagcount < 2)
135 		return -EINVAL;
136 
137 	/* No work to do */
138 	if (delta == 0)
139 		return 0;
140 
141 	oagcount = mp->m_sb.sb_agcount;
142 	/* allocate the new per-ag structures */
143 	if (nagcount > oagcount) {
144 		error = xfs_initialize_perag(mp, nagcount, nb, &nagimax);
145 		if (error)
146 			return error;
147 	} else if (nagcount < oagcount) {
148 		/* TODO: shrinking the entire AGs hasn't yet completed */
149 		return -EINVAL;
150 	}
151 
152 	if (delta > 0)
153 		error = xfs_trans_alloc(mp, &M_RES(mp)->tr_growdata,
154 				XFS_GROWFS_SPACE_RES(mp), 0, XFS_TRANS_RESERVE,
155 				&tp);
156 	else
157 		error = xfs_trans_alloc(mp, &M_RES(mp)->tr_growdata, -delta, 0,
158 				0, &tp);
159 	if (error)
160 		goto out_free_unused_perag;
161 
162 	last_pag = xfs_perag_get(mp, oagcount - 1);
163 	if (delta > 0) {
164 		error = xfs_resizefs_init_new_ags(tp, &id, oagcount, nagcount,
165 				delta, last_pag, &lastag_extended);
166 	} else {
167 		xfs_warn_mount(mp, XFS_OPSTATE_WARNED_SHRINK,
168 	"EXPERIMENTAL online shrink feature in use. Use at your own risk!");
169 
170 		error = xfs_ag_shrink_space(last_pag, &tp, -delta);
171 	}
172 	xfs_perag_put(last_pag);
173 	if (error)
174 		goto out_trans_cancel;
175 
176 	/*
177 	 * Update changed superblock fields transactionally. These are not
178 	 * seen by the rest of the world until the transaction commit applies
179 	 * them atomically to the superblock.
180 	 */
181 	if (nagcount > oagcount)
182 		xfs_trans_mod_sb(tp, XFS_TRANS_SB_AGCOUNT, nagcount - oagcount);
183 	if (delta)
184 		xfs_trans_mod_sb(tp, XFS_TRANS_SB_DBLOCKS, delta);
185 	if (id.nfree)
186 		xfs_trans_mod_sb(tp, XFS_TRANS_SB_FDBLOCKS, id.nfree);
187 
188 	/*
189 	 * Sync sb counters now to reflect the updated values. This is
190 	 * particularly important for shrink because the write verifier
191 	 * will fail if sb_fdblocks is ever larger than sb_dblocks.
192 	 */
193 	if (xfs_has_lazysbcount(mp))
194 		xfs_log_sb(tp);
195 
196 	xfs_trans_set_sync(tp);
197 	error = xfs_trans_commit(tp);
198 	if (error)
199 		return error;
200 
201 	/* New allocation groups fully initialized, so update mount struct */
202 	if (nagimax)
203 		mp->m_maxagi = nagimax;
204 	xfs_set_low_space_thresholds(mp);
205 	mp->m_alloc_set_aside = xfs_alloc_set_aside(mp);
206 
207 	if (delta > 0) {
208 		/*
209 		 * If we expanded the last AG, free the per-AG reservation
210 		 * so we can reinitialize it with the new size.
211 		 */
212 		if (lastag_extended) {
213 			struct xfs_perag	*pag;
214 
215 			pag = xfs_perag_get(mp, id.agno);
216 			error = xfs_ag_resv_free(pag);
217 			xfs_perag_put(pag);
218 			if (error)
219 				return error;
220 		}
221 		/*
222 		 * Reserve AG metadata blocks. ENOSPC here does not mean there
223 		 * was a growfs failure, just that there still isn't space for
224 		 * new user data after the grow has been run.
225 		 */
226 		error = xfs_fs_reserve_ag_blocks(mp);
227 		if (error == -ENOSPC)
228 			error = 0;
229 	}
230 	return error;
231 
232 out_trans_cancel:
233 	xfs_trans_cancel(tp);
234 out_free_unused_perag:
235 	if (nagcount > oagcount)
236 		xfs_free_unused_perag_range(mp, oagcount, nagcount);
237 	return error;
238 }
239 
240 static int
xfs_growfs_log_private(struct xfs_mount * mp,struct xfs_growfs_log * in)241 xfs_growfs_log_private(
242 	struct xfs_mount	*mp,	/* mount point for filesystem */
243 	struct xfs_growfs_log	*in)	/* growfs log input struct */
244 {
245 	xfs_extlen_t		nb;
246 
247 	nb = in->newblocks;
248 	if (nb < XFS_MIN_LOG_BLOCKS || nb < XFS_B_TO_FSB(mp, XFS_MIN_LOG_BYTES))
249 		return -EINVAL;
250 	if (nb == mp->m_sb.sb_logblocks &&
251 	    in->isint == (mp->m_sb.sb_logstart != 0))
252 		return -EINVAL;
253 	/*
254 	 * Moving the log is hard, need new interfaces to sync
255 	 * the log first, hold off all activity while moving it.
256 	 * Can have shorter or longer log in the same space,
257 	 * or transform internal to external log or vice versa.
258 	 */
259 	return -ENOSYS;
260 }
261 
262 static int
xfs_growfs_imaxpct(struct xfs_mount * mp,__u32 imaxpct)263 xfs_growfs_imaxpct(
264 	struct xfs_mount	*mp,
265 	__u32			imaxpct)
266 {
267 	struct xfs_trans	*tp;
268 	int			dpct;
269 	int			error;
270 
271 	if (imaxpct > 100)
272 		return -EINVAL;
273 
274 	error = xfs_trans_alloc(mp, &M_RES(mp)->tr_growdata,
275 			XFS_GROWFS_SPACE_RES(mp), 0, XFS_TRANS_RESERVE, &tp);
276 	if (error)
277 		return error;
278 
279 	dpct = imaxpct - mp->m_sb.sb_imax_pct;
280 	xfs_trans_mod_sb(tp, XFS_TRANS_SB_IMAXPCT, dpct);
281 	xfs_trans_set_sync(tp);
282 	return xfs_trans_commit(tp);
283 }
284 
285 /*
286  * protected versions of growfs function acquire and release locks on the mount
287  * point - exported through ioctls: XFS_IOC_FSGROWFSDATA, XFS_IOC_FSGROWFSLOG,
288  * XFS_IOC_FSGROWFSRT
289  */
290 int
xfs_growfs_data(struct xfs_mount * mp,struct xfs_growfs_data * in)291 xfs_growfs_data(
292 	struct xfs_mount	*mp,
293 	struct xfs_growfs_data	*in)
294 {
295 	int			error = 0;
296 
297 	if (!capable(CAP_SYS_ADMIN))
298 		return -EPERM;
299 	if (!mutex_trylock(&mp->m_growlock))
300 		return -EWOULDBLOCK;
301 
302 	/* update imaxpct separately to the physical grow of the filesystem */
303 	if (in->imaxpct != mp->m_sb.sb_imax_pct) {
304 		error = xfs_growfs_imaxpct(mp, in->imaxpct);
305 		if (error)
306 			goto out_error;
307 	}
308 
309 	if (in->newblocks != mp->m_sb.sb_dblocks) {
310 		error = xfs_growfs_data_private(mp, in);
311 		if (error)
312 			goto out_error;
313 	}
314 
315 	/* Post growfs calculations needed to reflect new state in operations */
316 	if (mp->m_sb.sb_imax_pct) {
317 		uint64_t icount = mp->m_sb.sb_dblocks * mp->m_sb.sb_imax_pct;
318 		do_div(icount, 100);
319 		M_IGEO(mp)->maxicount = XFS_FSB_TO_INO(mp, icount);
320 	} else
321 		M_IGEO(mp)->maxicount = 0;
322 
323 	/* Update secondary superblocks now the physical grow has completed */
324 	error = xfs_update_secondary_sbs(mp);
325 
326 out_error:
327 	/*
328 	 * Increment the generation unconditionally, the error could be from
329 	 * updating the secondary superblocks, in which case the new size
330 	 * is live already.
331 	 */
332 	mp->m_generation++;
333 	mutex_unlock(&mp->m_growlock);
334 	return error;
335 }
336 
337 int
xfs_growfs_log(xfs_mount_t * mp,struct xfs_growfs_log * in)338 xfs_growfs_log(
339 	xfs_mount_t		*mp,
340 	struct xfs_growfs_log	*in)
341 {
342 	int error;
343 
344 	if (!capable(CAP_SYS_ADMIN))
345 		return -EPERM;
346 	if (!mutex_trylock(&mp->m_growlock))
347 		return -EWOULDBLOCK;
348 	error = xfs_growfs_log_private(mp, in);
349 	mutex_unlock(&mp->m_growlock);
350 	return error;
351 }
352 
353 /*
354  * exported through ioctl XFS_IOC_FSCOUNTS
355  */
356 
357 void
xfs_fs_counts(xfs_mount_t * mp,xfs_fsop_counts_t * cnt)358 xfs_fs_counts(
359 	xfs_mount_t		*mp,
360 	xfs_fsop_counts_t	*cnt)
361 {
362 	cnt->allocino = percpu_counter_read_positive(&mp->m_icount);
363 	cnt->freeino = percpu_counter_read_positive(&mp->m_ifree);
364 	cnt->freedata = percpu_counter_read_positive(&mp->m_fdblocks) -
365 						xfs_fdblocks_unavailable(mp);
366 	cnt->freertx = percpu_counter_read_positive(&mp->m_frextents);
367 }
368 
369 /*
370  * exported through ioctl XFS_IOC_SET_RESBLKS & XFS_IOC_GET_RESBLKS
371  *
372  * xfs_reserve_blocks is called to set m_resblks
373  * in the in-core mount table. The number of unused reserved blocks
374  * is kept in m_resblks_avail.
375  *
376  * Reserve the requested number of blocks if available. Otherwise return
377  * as many as possible to satisfy the request. The actual number
378  * reserved are returned in outval
379  *
380  * A null inval pointer indicates that only the current reserved blocks
381  * available  should  be returned no settings are changed.
382  */
383 
384 int
xfs_reserve_blocks(xfs_mount_t * mp,uint64_t * inval,xfs_fsop_resblks_t * outval)385 xfs_reserve_blocks(
386 	xfs_mount_t             *mp,
387 	uint64_t              *inval,
388 	xfs_fsop_resblks_t      *outval)
389 {
390 	int64_t			lcounter, delta;
391 	int64_t			fdblks_delta = 0;
392 	uint64_t		request;
393 	int64_t			free;
394 	int			error = 0;
395 
396 	/* If inval is null, report current values and return */
397 	if (inval == (uint64_t *)NULL) {
398 		if (!outval)
399 			return -EINVAL;
400 		outval->resblks = mp->m_resblks;
401 		outval->resblks_avail = mp->m_resblks_avail;
402 		return 0;
403 	}
404 
405 	request = *inval;
406 
407 	/*
408 	 * With per-cpu counters, this becomes an interesting problem. we need
409 	 * to work out if we are freeing or allocation blocks first, then we can
410 	 * do the modification as necessary.
411 	 *
412 	 * We do this under the m_sb_lock so that if we are near ENOSPC, we will
413 	 * hold out any changes while we work out what to do. This means that
414 	 * the amount of free space can change while we do this, so we need to
415 	 * retry if we end up trying to reserve more space than is available.
416 	 */
417 	spin_lock(&mp->m_sb_lock);
418 
419 	/*
420 	 * If our previous reservation was larger than the current value,
421 	 * then move any unused blocks back to the free pool. Modify the resblks
422 	 * counters directly since we shouldn't have any problems unreserving
423 	 * space.
424 	 */
425 	if (mp->m_resblks > request) {
426 		lcounter = mp->m_resblks_avail - request;
427 		if (lcounter  > 0) {		/* release unused blocks */
428 			fdblks_delta = lcounter;
429 			mp->m_resblks_avail -= lcounter;
430 		}
431 		mp->m_resblks = request;
432 		if (fdblks_delta) {
433 			spin_unlock(&mp->m_sb_lock);
434 			error = xfs_mod_fdblocks(mp, fdblks_delta, 0);
435 			spin_lock(&mp->m_sb_lock);
436 		}
437 
438 		goto out;
439 	}
440 
441 	/*
442 	 * If the request is larger than the current reservation, reserve the
443 	 * blocks before we update the reserve counters. Sample m_fdblocks and
444 	 * perform a partial reservation if the request exceeds free space.
445 	 *
446 	 * The code below estimates how many blocks it can request from
447 	 * fdblocks to stash in the reserve pool.  This is a classic TOCTOU
448 	 * race since fdblocks updates are not always coordinated via
449 	 * m_sb_lock.  Set the reserve size even if there's not enough free
450 	 * space to fill it because mod_fdblocks will refill an undersized
451 	 * reserve when it can.
452 	 */
453 	free = percpu_counter_sum(&mp->m_fdblocks) -
454 						xfs_fdblocks_unavailable(mp);
455 	delta = request - mp->m_resblks;
456 	mp->m_resblks = request;
457 	if (delta > 0 && free > 0) {
458 		/*
459 		 * We'll either succeed in getting space from the free block
460 		 * count or we'll get an ENOSPC.  Don't set the reserved flag
461 		 * here - we don't want to reserve the extra reserve blocks
462 		 * from the reserve.
463 		 *
464 		 * The desired reserve size can change after we drop the lock.
465 		 * Use mod_fdblocks to put the space into the reserve or into
466 		 * fdblocks as appropriate.
467 		 */
468 		fdblks_delta = min(free, delta);
469 		spin_unlock(&mp->m_sb_lock);
470 		error = xfs_mod_fdblocks(mp, -fdblks_delta, 0);
471 		if (!error)
472 			xfs_mod_fdblocks(mp, fdblks_delta, 0);
473 		spin_lock(&mp->m_sb_lock);
474 	}
475 out:
476 	if (outval) {
477 		outval->resblks = mp->m_resblks;
478 		outval->resblks_avail = mp->m_resblks_avail;
479 	}
480 
481 	spin_unlock(&mp->m_sb_lock);
482 	return error;
483 }
484 
485 int
xfs_fs_goingdown(xfs_mount_t * mp,uint32_t inflags)486 xfs_fs_goingdown(
487 	xfs_mount_t	*mp,
488 	uint32_t	inflags)
489 {
490 	switch (inflags) {
491 	case XFS_FSOP_GOING_FLAGS_DEFAULT: {
492 		if (!freeze_bdev(mp->m_super->s_bdev)) {
493 			xfs_force_shutdown(mp, SHUTDOWN_FORCE_UMOUNT);
494 			thaw_bdev(mp->m_super->s_bdev);
495 		}
496 		break;
497 	}
498 	case XFS_FSOP_GOING_FLAGS_LOGFLUSH:
499 		xfs_force_shutdown(mp, SHUTDOWN_FORCE_UMOUNT);
500 		break;
501 	case XFS_FSOP_GOING_FLAGS_NOLOGFLUSH:
502 		xfs_force_shutdown(mp,
503 				SHUTDOWN_FORCE_UMOUNT | SHUTDOWN_LOG_IO_ERROR);
504 		break;
505 	default:
506 		return -EINVAL;
507 	}
508 
509 	return 0;
510 }
511 
512 /*
513  * Force a shutdown of the filesystem instantly while keeping the filesystem
514  * consistent. We don't do an unmount here; just shutdown the shop, make sure
515  * that absolutely nothing persistent happens to this filesystem after this
516  * point.
517  *
518  * The shutdown state change is atomic, resulting in the first and only the
519  * first shutdown call processing the shutdown. This means we only shutdown the
520  * log once as it requires, and we don't spam the logs when multiple concurrent
521  * shutdowns race to set the shutdown flags.
522  */
523 void
xfs_do_force_shutdown(struct xfs_mount * mp,uint32_t flags,char * fname,int lnnum)524 xfs_do_force_shutdown(
525 	struct xfs_mount *mp,
526 	uint32_t	flags,
527 	char		*fname,
528 	int		lnnum)
529 {
530 	int		tag;
531 	const char	*why;
532 
533 
534 	if (test_and_set_bit(XFS_OPSTATE_SHUTDOWN, &mp->m_opstate)) {
535 		xlog_shutdown_wait(mp->m_log);
536 		return;
537 	}
538 	if (mp->m_sb_bp)
539 		mp->m_sb_bp->b_flags |= XBF_DONE;
540 
541 	if (flags & SHUTDOWN_FORCE_UMOUNT)
542 		xfs_alert(mp, "User initiated shutdown received.");
543 
544 	if (xlog_force_shutdown(mp->m_log, flags)) {
545 		tag = XFS_PTAG_SHUTDOWN_LOGERROR;
546 		why = "Log I/O Error";
547 	} else if (flags & SHUTDOWN_CORRUPT_INCORE) {
548 		tag = XFS_PTAG_SHUTDOWN_CORRUPT;
549 		why = "Corruption of in-memory data";
550 	} else if (flags & SHUTDOWN_CORRUPT_ONDISK) {
551 		tag = XFS_PTAG_SHUTDOWN_CORRUPT;
552 		why = "Corruption of on-disk metadata";
553 	} else if (flags & SHUTDOWN_DEVICE_REMOVED) {
554 		tag = XFS_PTAG_SHUTDOWN_IOERROR;
555 		why = "Block device removal";
556 	} else {
557 		tag = XFS_PTAG_SHUTDOWN_IOERROR;
558 		why = "Metadata I/O Error";
559 	}
560 
561 	trace_xfs_force_shutdown(mp, tag, flags, fname, lnnum);
562 
563 	xfs_alert_tag(mp, tag,
564 "%s (0x%x) detected at %pS (%s:%d).  Shutting down filesystem.",
565 			why, flags, __return_address, fname, lnnum);
566 	xfs_alert(mp,
567 		"Please unmount the filesystem and rectify the problem(s)");
568 	if (xfs_error_level >= XFS_ERRLEVEL_HIGH)
569 		xfs_stack_trace();
570 }
571 
572 /*
573  * Reserve free space for per-AG metadata.
574  */
575 int
xfs_fs_reserve_ag_blocks(struct xfs_mount * mp)576 xfs_fs_reserve_ag_blocks(
577 	struct xfs_mount	*mp)
578 {
579 	xfs_agnumber_t		agno;
580 	struct xfs_perag	*pag;
581 	int			error = 0;
582 	int			err2;
583 
584 	mp->m_finobt_nores = false;
585 	for_each_perag(mp, agno, pag) {
586 		err2 = xfs_ag_resv_init(pag, NULL);
587 		if (err2 && !error)
588 			error = err2;
589 	}
590 
591 	if (error && error != -ENOSPC) {
592 		xfs_warn(mp,
593 	"Error %d reserving per-AG metadata reserve pool.", error);
594 		xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
595 	}
596 
597 	return error;
598 }
599 
600 /*
601  * Free space reserved for per-AG metadata.
602  */
603 int
xfs_fs_unreserve_ag_blocks(struct xfs_mount * mp)604 xfs_fs_unreserve_ag_blocks(
605 	struct xfs_mount	*mp)
606 {
607 	xfs_agnumber_t		agno;
608 	struct xfs_perag	*pag;
609 	int			error = 0;
610 	int			err2;
611 
612 	for_each_perag(mp, agno, pag) {
613 		err2 = xfs_ag_resv_free(pag);
614 		if (err2 && !error)
615 			error = err2;
616 	}
617 
618 	if (error)
619 		xfs_warn(mp,
620 	"Error %d freeing per-AG metadata reserve pool.", error);
621 
622 	return error;
623 }
624