Lines Matching +full:pull +full:- +full:requests
9 confirm that they are using [two-factor authentication][]. It will not be
10 possible to add them to the organization if they are not using two-factor
15 * Suggest the new Collaborator install [`node-core-utils`][] and
23 [Who to CC in the issue tracker][who-to-cc].
28 * [local setup](#local-setup)
29 * [project goals and values](#project-goals-and-values)
30 * [managing the issue tracker](#managing-the-issue-tracker)
31 * [reviewing pull requests](#reviewing-pull-requests)
32 * [landing pull requests](#landing-pull-requests)
37 * Make sure you have whitespace=fix: `git config --global --add
39 * Always create a branch in your own GitHub fork for pull requests
45 * `git remote update -p` OR `git fetch --all`
46 * `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`)
47 * Make a new branch for each pull request you submit.
59 The project has two venues for real-time discussion:
60 * [`#nodejs-dev`](https://openjs-foundation.slack.com/archives/C019Y2T6STH) on
61 the [OpenJS Foundation](https://slack-invite.openjsf.org/)
68 * There are some higher-level goals and values
81 * Be nice about closing issues! Let people know why, and that issues and pull
82 requests can be reopened if necessary.
85 * There is [a bot](https://github.com/nodejs-github-bot/github-bot) that
87 so that we know what parts of the code base the pull request modifies. It is
89 irrelevant labels from pull requests and issues.
90 * `semver-{minor,major}`:
92 `semver-major` label
93 * When adding a `semver-*` label, add a comment explaining why you're adding
95 * Please add the [`author-ready`][] label for pull requests, if applicable.
97 * See [Who to CC in the issue tracker][who-to-cc].
111 [here](https://github.com/nodejs/admin/blob/HEAD/Moderation-Policy.md).
113 ## Reviewing pull requests
117 pull request from a new contributor is an opportunity to grow the community.
119 * It is tempting to micro-optimize. Don't succumb to that temptation. We
123 * Nits (requests for small changes that are not essential) are fine, but try to
124 avoid stalling the pull request.
126 * If they are stalling the pull request, fix them yourself on merge.
131 * There is a minimum waiting time which we try to respect for non-trivial
134 * For non-trivial changes, leave the pull request open for at least 48 hours.
135 * If a pull request is abandoned, check if they'd mind if you took it over
139 a pull request using GitHub’s approval interface
142 * You cannot approve your own pull requests.
150 comments to block the pull request from landing.
165 * You will be using `node-test-pull-request` most of the time. Go there now!
166 * Consider bookmarking it: <https://ci.nodejs.org/job/node-test-pull-request/>
176 * The `PR_ID` box should be filled in with the number identifying the pull
178 the pull request is `https://github.com/nodejs/node/issues/7006`, then put
181 * If you need help with something CI-related:
185 ## Landing pull requests
187 See the Collaborator Guide: [Landing pull requests][].
189 Commits in one pull request that belong to one logical change should
193 <!-- TODO(joyeechueng): provide examples about "one logical change" -->
195 ## Exercise: Make a pull request adding yourself to the README
200 `git show --format=%Bb58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8`
203 * Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message
206 * Label your pull request with the `doc`, `notable-change`, and `fast-track`
207 labels. The `fast-track` label should cause the Node.js GitHub bot to post a
208 comment in the pull request asking collaborators to approve the pull request
210 * Run CI on the pull request. Use the `node-test-pull-request` CI task.
212 for fast-tracking, land the PR.
214 single approval of the onboarding TSC member sufficient, and land the pull
216 * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
218 * [`node-core-utils`][] automates the generation of metadata and the landing
219 process. See the documentation of [`git-node`][].
220 * [`core-validate-commit`][] automates the validation of commit messages.
221 This will be run during `git node land --final` of the [`git-node`][]
234 * [https://github.com/nodejs/readable-stream](https://github.com/nodejs/readable-stream)
238 Node.js project, where we have face-to-face discussions about our work on the
244 [Labels]: doc/guides/collaborator-guide.md#labels
245 [Landing pull requests]: doc/guides/collaborator-guide.md#landing-pull-requests
246 …zation membership]: https://help.github.com/articles/publicizing-or-hiding-organization-membership/
247 [`author-ready`]: doc/guides/collaborator-guide.md#author-ready-pull-requests
248 [`core-validate-commit`]: https://github.com/nodejs/core-validate-commit
249 [`git-node`]: https://github.com/nodejs/node-core-utils/blob/HEAD/docs/git-node.md
250 [`node-core-utils`]: https://github.com/nodejs/node-core-utils
251 [set up the credentials]: https://github.com/nodejs/node-core-utils#setting-up-credentials
252 [two-factor authentication]: https://help.github.com/articles/securing-your-account-with-two-factor…
253 …ile app]: https://help.github.com/articles/configuring-two-factor-authentication-via-a-totp-mobile…
254 [who-to-cc]: doc/guides/collaborator-guide.md#who-to-cc-in-the-issue-tracker