Lines Matching +full:node +full:- +full:core
4 * [Setting up your local environment](#setting-up-your-local-environment)
5 * [Step 1: Fork](#step-1-fork)
6 * [Step 2: Branch](#step-2-branch)
7 * [The process of making changes](#the-process-of-making-changes)
8 * [Step 3: Code](#step-3-code)
9 * [Step 4: Commit](#step-4-commit)
10 * [Commit message guidelines](#commit-message-guidelines)
11 * [Step 5: Rebase](#step-5-rebase)
12 * [Step 6: Test](#step-6-test)
13 * [Step 7: Push](#step-7-push)
14 * [Step 8: Opening the pull request](#step-8-opening-the-pull-request)
15 * [Step 9: Discuss and update](#step-9-discuss-and-update)
16 * [Approval and request changes workflow](#approval-and-request-changes-workflow)
17 * [Step 10: Landing](#step-10-landing)
18 * [Reviewing pull requests](#reviewing-pull-requests)
19 * [Review a bit at a time](#review-a-bit-at-a-time)
20 * [Be aware of the person behind the code](#be-aware-of-the-person-behind-the-code)
21 * [Respect the minimum wait time for comments](#respect-the-minimum-wait-time-for-comments)
22 * [Abandoned or stalled pull requests](#abandoned-or-stalled-pull-requests)
23 * [Approving a change](#approving-a-change)
24 …ifferent opinions about what belongs in Node.js](#accept-that-there-are-different-opinions-about-w…
25 * [Performance is not everything](#performance-is-not-everything)
26 * [Continuous integration testing](#continuous-integration-testing)
28 * [Commit squashing](#commit-squashing)
29 * [Getting approvals for your pull request](#getting-approvals-for-your-pull-request)
30 * [Waiting until the pull request gets landed](#waiting-until-the-pull-request-gets-landed)
31 * [Check out the collaborator guide](#check-out-the-collaborator-guide)
32 * [Appendix: subsystems](#appendix-subsystems)
36 Node.js has several bundled dependencies in the _deps/_ and the _tools/_
39 Node.js. We cannot accept such patches.
42 [issue tracker](https://github.com/nodejs/node/issues/) or contact one of the
43 [project collaborators](https://github.com/nodejs/node/#current-project-team-members).
45 Node.js has many channels on the
46 [OpenJS Foundation Slack](https://slack-invite.openjsf.org/). Interesting
48 [#nodejs](https://openjs-foundation.slack.com/archives/CK9Q4MB53) for general
50 [#nodejs-core](https://openjs-foundation.slack.com/archives/C019Y2T6STH) for
51 development of Node.js core specifically.
53 Node.js also has an unofficial IRC channel:
54 [#Node.js](https://web.libera.chat/?channels=node.js).
63 [IDE configs](https://github.com/nodejs/node-code-ide-configs).
70 Fork the project [on GitHub](https://github.com/nodejs/node) and clone your fork
74 git clone git@github.com:username/node.git
75 cd node
76 git remote add upstream https://github.com/nodejs/node.git
103 git checkout -b my-branch -t upstream/HEAD
110 Pull requests in Node.js typically involve changes to
119 `vcbuild.bat lint` on Windows) to ensure that the changes follow the Node.js
131 <!-- YAML
133 -->
139 [C++ Style Guide](cpp-style-guide.md), as well as the
140 [README of `src/`](../../src/README.md) for an overview of Node.js
156 notes about [commit squashing](#commit-squashing).
168 * be prefixed with the name of the changed [subsystem](#appendix-subsystems)
169 and start with an imperative verb. Check the output of `git log --oneline
187 * `Fixes: https://github.com/nodejs/node/issues/1337`
188 * `Refs: https://eslint.org/docs/rules/space-in-parens.html`
189 * `Refs: https://github.com/nodejs/node/pull/3615`
191 5. If your commit introduces a breaking change (`semver-major`), it should
201 things in more detail. Please word-wrap to keep columns to 72 characters or
204 Fixes: https://github.com/nodejs/node/issues/1337
205 Refs: https://eslint.org/docs/rules/space-in-parens.html
208 If you are new to contributing to Node.js, please try to do your best at
225 This ensures that your working branch has the latest changes from `nodejs/node`.
230 [guide for writing tests in Node.js][] has been
234 The `test` directory within the `nodejs/node` repository is complex and it is
239 Before submitting your changes in a pull request, always run the full Node.js
243 ./configure && make -j4 test
246 We can speed up the builds by using [Ninja](https://ninja-build.org/). For more
248 [Building Node.js with Ninja](building-node-with-ninja.md).
267 git push origin my-branch
298 git push origin my-branch
307 git push --force-with-lease origin my-branch
310 **Important:** The `git push --force-with-lease` command is one of the few ways
322 [glossary](https://github.com/nodejs/node/blob/HEAD/glossary.md).
337 short amount of time to review and are not ill-intended. Such issues can often
345 at least two Node.js Collaborators (one collaborator approval is enough if the
350 [notes about the waiting time](#waiting-until-the-pull-request-gets-landed).
361 All Node.js contributors who choose to review and provide feedback on Pull
382 It is tempting to micro-optimize and make everything about relative performance,
387 1. Does this change make sense for Node.js?
388 2. Does this change make Node.js better, even if only incrementally?
401 Node.js collaborator landing the pull request but they can also be an
408 commits or if they proved to be mistaken, please, [hide them][hiding-a-comment]
415 a particular change that makes Node.js better, but the individual might just
416 not want to have anything to do with Node.js ever again. The goal is not just
421 There is a minimum waiting time which we try to respect for non-trivial
425 For non-trivial changes, pull requests must be left open for at least 48 hours.
427 from subject-matter experts. When in doubt, do not rush.
439 address) in the commit log, or by using an `Author:` meta-data tag in the
444 Any Node.js core collaborator (any GitHub user with commit rights in the
445 `nodejs/node` repository) is authorized to approve any other contributor's
471 ### Accept that there are different opinions about what belongs in Node.js
476 One general rule of thumb is that if Node.js itself needs it (due to historic
477 or functional reasons), then it belongs in Node.js. For instance, `url`
478 parsing is in Node.js because of HTTP protocol support.
480 Also, functionality that either cannot be implemented outside of core in any
484 make Node.js better. These may or may not make sense to add, but as with all
491 Node.js has always optimized for speed of execution. If a particular change
492 can be shown to make some part of Node.js faster, it's quite likely to be
497 That said, performance is not the only factor to consider. Node.js also
513 Only Node.js core collaborators and triagers can start a CI testing run. The
520 supported by Node.js. This means that all tests pass and there are no linting
522 to fail on specific platforms or for so-called "flaky" tests to fail ("be red").
538 [0b5191f](https://github.com/nodejs/node/commit/0b5191f15d0f311c804d542b67e2e922d98834f8)
541 when each individual commit lands on one of the `nodejs/node` branches.
550 or [the official documentation](https://help.github.com/articles/reviewing-changes-in-pull-requests…
562 longer to be merged in. All these precautions are important because Node.js is
580 [nodejs/core-validate-commit][] repository.
584 [CI (Continuous Integration) test run]: #continuous-integration-testing
587 [approved]: #getting-approvals-for-your-pull-request
588 [benchmark results]: writing-and-running-benchmarks.md
589 [collaborator guide]: collaborator-guide.md
590 [guide for writing tests in Node.js]: writing-tests.md
591 [hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment
593 [nodejs/core-validate-commit]: https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/s…
594 [pull request template]: https://raw.githubusercontent.com/nodejs/node/HEAD/.github/PULL_REQUEST_TE…
595 [running tests]: ../../BUILDING.md#running-tests