Lines Matching full:pull

1 # Pull requests
14   * [Step 8: Opening the pull request](#step-8-opening-the-pull-request)
18 * [Reviewing pull requests](#reviewing-pull-requests)
22   * [Abandoned or stalled pull requests](#abandoned-or-stalled-pull-requests)
29   * [Getting approvals for your pull request](#getting-approvals-for-your-pull-request)
30   * [Waiting until the pull request gets landed](#waiting-until-the-pull-request-gets-landed)
110 Pull requests in Node.js typically involve changes to
147 commits any single pull request may have, and many contributors find it easier
189    * `Refs: https://github.com/nodejs/node/pull/3615`
211 contributor landing the pull request will ensure that everything follows
239 Before submitting your changes in a pull request, always run the full Node.js
263 begin the process of opening a pull request by pushing your working branch to
270 ### Step 8: Opening the pull request
272 From within GitHub, opening a new pull request will present you with a
273 [pull request template][]. Please try to do your best at filling out the
276 Once opened, pull requests are usually reviewed within a few days.
285 You will probably get feedback or requests for changes to your pull request.
287 contributors may sign off on the pull request right away, others may have
291 To make changes to an existing pull request, make the changes to your local
293 GitHub will automatically update the pull request.
314 the pull request.
319 Feel free to post a comment in the pull request to ping reviewers if you are
326 All pull requests require "sign off" in order to land. Whenever a contributor
327 reviews a pull request they may find specific details that they would like to
344 In order to land, a pull request needs to be reviewed and [approved][] by
346 pull request has been open for more than 7 days) and pass a
348 objections from other contributors, the pull request can be merged. If you find
349 your pull request waiting longer than you expect, see the
350 [notes about the waiting time](#waiting-until-the-pull-request-gets-landed).
352 When a collaborator lands your pull request, they will post
353 a comment to the pull request page mentioning the commit(s) it
354 landed as. GitHub might show the pull request as `Closed` at this
356 pull request against, you should see a commit with your name on it.
359 ## Reviewing pull requests
361 All Node.js contributors who choose to review and provide feedback on Pull
365 expect to be able to block a pull request from advancing simply because you say
367 to working with the contributor to make the pull request better.
372 When reviewing a pull request, the primary goals are for the codebase to improve
373 and for the person submitting the request to succeed. Even if a pull request
375 their effort was not wasted or unappreciated. Every pull request from a new
400 avoid stalling the pull request. Most nits can typically be fixed by the
401 Node.js collaborator landing the pull request but they can also be an
414 have a significant impact on the success of the pull request. Yes, we may land
425 For non-trivial changes, pull requests must be left open for at least 48 hours.
432 ### Abandoned or stalled pull requests
434 If a pull request appears to be abandoned or stalled, it is polite to first
446 work. Collaborators are not permitted to approve their own pull requests.
449 a pull request either by using GitHub's Approval Workflow, which is preferred,
467 Use `Changes requested` to block a pull request from landing. When doing so,
468 explain why you believe the pull request should not land along with an
493 accepted. Claims that a particular pull request will make things faster will
501 If a particular pull request introduces a performance or functional
502 regression, rather than simply rejecting the pull request, take the time to
504 advice on what would make the pull request acceptable, and do not assume that
510 All pull requests that contain changes to code must be run through
516 test run for you as approvals for the pull request come in.
524 determine whether the failure was caused by the changes in the pull request.
530 In most cases, do not squash commits that you add to your pull request during
531 the review process. When the commits in your pull request land, they may be
533 commit message (including links to the pull request, links to relevant issues,
534 and the names of the reviewers). The commit history of your pull request,
535 however, will stay intact on the pull request page.
543 ### Getting approvals for your pull request
545 A pull request is approved either by saying LGTM, which stands for
547 GitHub's pull request review feature can be used during the process.
550 or [the official documentation](https://help.github.com/articles/reviewing-changes-in-pull-requests…
556 ### Waiting until the pull request gets landed
558 A pull request needs to stay open for at least 48 hours from when it is
561 collaborators may decide it doesn't need to wait. A pull request may well take
581 More than one subsystem may be valid for any particular issue or pull request.
587 [approved]: #getting-approvals-for-your-pull-request
594 [pull request template]: https://raw.githubusercontent.com/nodejs/node/HEAD/.github/PULL_REQUEST_TE…