• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3  * Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
4  *
5  * Test code for seccomp bpf.
6  */
7 
8 #define _GNU_SOURCE
9 #include <sys/types.h>
10 
11 /*
12  * glibc 2.26 and later have SIGSYS in siginfo_t. Before that,
13  * we need to use the kernel's siginfo.h file and trick glibc
14  * into accepting it.
15  */
16 #if !__GLIBC_PREREQ(2, 26)
17 # include <asm/siginfo.h>
18 # define __have_siginfo_t 1
19 # define __have_sigval_t 1
20 # define __have_sigevent_t 1
21 #endif
22 
23 #include <errno.h>
24 #include <linux/filter.h>
25 #include <sys/prctl.h>
26 #include <sys/ptrace.h>
27 #include <sys/user.h>
28 #include <linux/prctl.h>
29 #include <linux/ptrace.h>
30 #include <linux/seccomp.h>
31 #include <pthread.h>
32 #include <semaphore.h>
33 #include <signal.h>
34 #include <stddef.h>
35 #include <stdbool.h>
36 #include <string.h>
37 #include <time.h>
38 #include <limits.h>
39 #include <linux/elf.h>
40 #include <sys/uio.h>
41 #include <sys/utsname.h>
42 #include <sys/fcntl.h>
43 #include <sys/mman.h>
44 #include <sys/times.h>
45 #include <sys/socket.h>
46 #include <sys/ioctl.h>
47 #include <linux/kcmp.h>
48 #include <sys/resource.h>
49 #include <sys/capability.h>
50 
51 #include <unistd.h>
52 #include <sys/syscall.h>
53 #include <poll.h>
54 
55 #include "../kselftest_harness.h"
56 #include "../clone3/clone3_selftests.h"
57 
58 /* Attempt to de-conflict with the selftests tree. */
59 #ifndef SKIP
60 #define SKIP(s, ...)	XFAIL(s, ##__VA_ARGS__)
61 #endif
62 
63 #ifndef MIN
64 #define MIN(X, Y) ((X) < (Y) ? (X) : (Y))
65 #endif
66 
67 #ifndef PR_SET_PTRACER
68 # define PR_SET_PTRACER 0x59616d61
69 #endif
70 
71 #ifndef PR_SET_NO_NEW_PRIVS
72 #define PR_SET_NO_NEW_PRIVS 38
73 #define PR_GET_NO_NEW_PRIVS 39
74 #endif
75 
76 #ifndef PR_SECCOMP_EXT
77 #define PR_SECCOMP_EXT 43
78 #endif
79 
80 #ifndef SECCOMP_EXT_ACT
81 #define SECCOMP_EXT_ACT 1
82 #endif
83 
84 #ifndef SECCOMP_EXT_ACT_TSYNC
85 #define SECCOMP_EXT_ACT_TSYNC 1
86 #endif
87 
88 #ifndef SECCOMP_MODE_STRICT
89 #define SECCOMP_MODE_STRICT 1
90 #endif
91 
92 #ifndef SECCOMP_MODE_FILTER
93 #define SECCOMP_MODE_FILTER 2
94 #endif
95 
96 #ifndef SECCOMP_RET_ALLOW
97 struct seccomp_data {
98 	int nr;
99 	__u32 arch;
100 	__u64 instruction_pointer;
101 	__u64 args[6];
102 };
103 #endif
104 
105 #ifndef SECCOMP_RET_KILL_PROCESS
106 #define SECCOMP_RET_KILL_PROCESS 0x80000000U /* kill the process */
107 #define SECCOMP_RET_KILL_THREAD	 0x00000000U /* kill the thread */
108 #endif
109 #ifndef SECCOMP_RET_KILL
110 #define SECCOMP_RET_KILL	 SECCOMP_RET_KILL_THREAD
111 #define SECCOMP_RET_TRAP	 0x00030000U /* disallow and force a SIGSYS */
112 #define SECCOMP_RET_ERRNO	 0x00050000U /* returns an errno */
113 #define SECCOMP_RET_TRACE	 0x7ff00000U /* pass to a tracer or disallow */
114 #define SECCOMP_RET_ALLOW	 0x7fff0000U /* allow */
115 #endif
116 #ifndef SECCOMP_RET_LOG
117 #define SECCOMP_RET_LOG		 0x7ffc0000U /* allow after logging */
118 #endif
119 
120 #ifndef __NR_seccomp
121 # if defined(__i386__)
122 #  define __NR_seccomp 354
123 # elif defined(__x86_64__)
124 #  define __NR_seccomp 317
125 # elif defined(__arm__)
126 #  define __NR_seccomp 383
127 # elif defined(__aarch64__)
128 #  define __NR_seccomp 277
129 # elif defined(__riscv)
130 #  define __NR_seccomp 277
131 # elif defined(__csky__)
132 #  define __NR_seccomp 277
133 # elif defined(__loongarch__)
134 #  define __NR_seccomp 277
135 # elif defined(__hppa__)
136 #  define __NR_seccomp 338
137 # elif defined(__powerpc__)
138 #  define __NR_seccomp 358
139 # elif defined(__s390__)
140 #  define __NR_seccomp 348
141 # elif defined(__xtensa__)
142 #  define __NR_seccomp 337
143 # elif defined(__sh__)
144 #  define __NR_seccomp 372
145 # elif defined(__mc68000__)
146 #  define __NR_seccomp 380
147 # else
148 #  warning "seccomp syscall number unknown for this architecture"
149 #  define __NR_seccomp 0xffff
150 # endif
151 #endif
152 
153 #ifndef SECCOMP_SET_MODE_STRICT
154 #define SECCOMP_SET_MODE_STRICT 0
155 #endif
156 
157 #ifndef SECCOMP_SET_MODE_FILTER
158 #define SECCOMP_SET_MODE_FILTER 1
159 #endif
160 
161 #ifndef SECCOMP_GET_ACTION_AVAIL
162 #define SECCOMP_GET_ACTION_AVAIL 2
163 #endif
164 
165 #ifndef SECCOMP_GET_NOTIF_SIZES
166 #define SECCOMP_GET_NOTIF_SIZES 3
167 #endif
168 
169 #ifndef SECCOMP_FILTER_FLAG_TSYNC
170 #define SECCOMP_FILTER_FLAG_TSYNC (1UL << 0)
171 #endif
172 
173 #ifndef SECCOMP_FILTER_FLAG_LOG
174 #define SECCOMP_FILTER_FLAG_LOG (1UL << 1)
175 #endif
176 
177 #ifndef SECCOMP_FILTER_FLAG_SPEC_ALLOW
178 #define SECCOMP_FILTER_FLAG_SPEC_ALLOW (1UL << 2)
179 #endif
180 
181 #ifndef PTRACE_SECCOMP_GET_METADATA
182 #define PTRACE_SECCOMP_GET_METADATA	0x420d
183 
184 struct seccomp_metadata {
185 	__u64 filter_off;       /* Input: which filter */
186 	__u64 flags;             /* Output: filter's flags */
187 };
188 #endif
189 
190 #ifndef SECCOMP_FILTER_FLAG_NEW_LISTENER
191 #define SECCOMP_FILTER_FLAG_NEW_LISTENER	(1UL << 3)
192 #endif
193 
194 #ifndef SECCOMP_RET_USER_NOTIF
195 #define SECCOMP_RET_USER_NOTIF 0x7fc00000U
196 
197 #define SECCOMP_IOC_MAGIC		'!'
198 #define SECCOMP_IO(nr)			_IO(SECCOMP_IOC_MAGIC, nr)
199 #define SECCOMP_IOR(nr, type)		_IOR(SECCOMP_IOC_MAGIC, nr, type)
200 #define SECCOMP_IOW(nr, type)		_IOW(SECCOMP_IOC_MAGIC, nr, type)
201 #define SECCOMP_IOWR(nr, type)		_IOWR(SECCOMP_IOC_MAGIC, nr, type)
202 
203 /* Flags for seccomp notification fd ioctl. */
204 #define SECCOMP_IOCTL_NOTIF_RECV	SECCOMP_IOWR(0, struct seccomp_notif)
205 #define SECCOMP_IOCTL_NOTIF_SEND	SECCOMP_IOWR(1,	\
206 						struct seccomp_notif_resp)
207 #define SECCOMP_IOCTL_NOTIF_ID_VALID	SECCOMP_IOW(2, __u64)
208 
209 struct seccomp_notif {
210 	__u64 id;
211 	__u32 pid;
212 	__u32 flags;
213 	struct seccomp_data data;
214 };
215 
216 struct seccomp_notif_resp {
217 	__u64 id;
218 	__s64 val;
219 	__s32 error;
220 	__u32 flags;
221 };
222 
223 struct seccomp_notif_sizes {
224 	__u16 seccomp_notif;
225 	__u16 seccomp_notif_resp;
226 	__u16 seccomp_data;
227 };
228 #endif
229 
230 #ifndef SECCOMP_IOCTL_NOTIF_ADDFD
231 /* On success, the return value is the remote process's added fd number */
232 #define SECCOMP_IOCTL_NOTIF_ADDFD	SECCOMP_IOW(3,	\
233 						struct seccomp_notif_addfd)
234 
235 /* valid flags for seccomp_notif_addfd */
236 #define SECCOMP_ADDFD_FLAG_SETFD	(1UL << 0) /* Specify remote fd */
237 
238 struct seccomp_notif_addfd {
239 	__u64 id;
240 	__u32 flags;
241 	__u32 srcfd;
242 	__u32 newfd;
243 	__u32 newfd_flags;
244 };
245 #endif
246 
247 #ifndef SECCOMP_ADDFD_FLAG_SEND
248 #define SECCOMP_ADDFD_FLAG_SEND	(1UL << 1) /* Addfd and return it, atomically */
249 #endif
250 
251 struct seccomp_notif_addfd_small {
252 	__u64 id;
253 	char weird[4];
254 };
255 #define SECCOMP_IOCTL_NOTIF_ADDFD_SMALL	\
256 	SECCOMP_IOW(3, struct seccomp_notif_addfd_small)
257 
258 struct seccomp_notif_addfd_big {
259 	union {
260 		struct seccomp_notif_addfd addfd;
261 		char buf[sizeof(struct seccomp_notif_addfd) + 8];
262 	};
263 };
264 #define SECCOMP_IOCTL_NOTIF_ADDFD_BIG	\
265 	SECCOMP_IOWR(3, struct seccomp_notif_addfd_big)
266 
267 #ifndef PTRACE_EVENTMSG_SYSCALL_ENTRY
268 #define PTRACE_EVENTMSG_SYSCALL_ENTRY	1
269 #define PTRACE_EVENTMSG_SYSCALL_EXIT	2
270 #endif
271 
272 #ifndef SECCOMP_USER_NOTIF_FLAG_CONTINUE
273 #define SECCOMP_USER_NOTIF_FLAG_CONTINUE 0x00000001
274 #endif
275 
276 #ifndef SECCOMP_FILTER_FLAG_TSYNC_ESRCH
277 #define SECCOMP_FILTER_FLAG_TSYNC_ESRCH (1UL << 4)
278 #endif
279 
280 #ifndef SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV
281 #define SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV (1UL << 5)
282 #endif
283 
284 #ifndef seccomp
seccomp(unsigned int op,unsigned int flags,void * args)285 int seccomp(unsigned int op, unsigned int flags, void *args)
286 {
287 	errno = 0;
288 	return syscall(__NR_seccomp, op, flags, args);
289 }
290 #endif
291 
292 #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
293 #define syscall_arg(_n) (offsetof(struct seccomp_data, args[_n]))
294 #elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
295 #define syscall_arg(_n) (offsetof(struct seccomp_data, args[_n]) + sizeof(__u32))
296 #else
297 #error "wut? Unknown __BYTE_ORDER__?!"
298 #endif
299 
300 #define SIBLING_EXIT_UNKILLED	0xbadbeef
301 #define SIBLING_EXIT_FAILURE	0xbadface
302 #define SIBLING_EXIT_NEWPRIVS	0xbadfeed
303 
__filecmp(pid_t pid1,pid_t pid2,int fd1,int fd2)304 static int __filecmp(pid_t pid1, pid_t pid2, int fd1, int fd2)
305 {
306 #ifdef __NR_kcmp
307 	errno = 0;
308 	return syscall(__NR_kcmp, pid1, pid2, KCMP_FILE, fd1, fd2);
309 #else
310 	errno = ENOSYS;
311 	return -1;
312 #endif
313 }
314 
315 /* Have TH_LOG report actual location filecmp() is used. */
316 #define filecmp(pid1, pid2, fd1, fd2)	({		\
317 	int _ret;					\
318 							\
319 	_ret = __filecmp(pid1, pid2, fd1, fd2);		\
320 	if (_ret != 0) {				\
321 		if (_ret < 0 && errno == ENOSYS) {	\
322 			TH_LOG("kcmp() syscall missing (test is less accurate)");\
323 			_ret = 0;			\
324 		}					\
325 	}						\
326 	_ret; })
327 
TEST(kcmp)328 TEST(kcmp)
329 {
330 	int ret;
331 
332 	ret = __filecmp(getpid(), getpid(), 1, 1);
333 	EXPECT_EQ(ret, 0);
334 	if (ret != 0 && errno == ENOSYS)
335 		SKIP(return, "Kernel does not support kcmp() (missing CONFIG_KCMP?)");
336 }
337 
TEST(mode_strict_support)338 TEST(mode_strict_support)
339 {
340 	long ret;
341 
342 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_STRICT, NULL, NULL, NULL);
343 	ASSERT_EQ(0, ret) {
344 		TH_LOG("Kernel does not support CONFIG_SECCOMP");
345 	}
346 	syscall(__NR_exit, 0);
347 }
348 
TEST_SIGNAL(mode_strict_cannot_call_prctl,SIGKILL)349 TEST_SIGNAL(mode_strict_cannot_call_prctl, SIGKILL)
350 {
351 	long ret;
352 
353 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_STRICT, NULL, NULL, NULL);
354 	ASSERT_EQ(0, ret) {
355 		TH_LOG("Kernel does not support CONFIG_SECCOMP");
356 	}
357 	syscall(__NR_prctl, PR_SET_SECCOMP, SECCOMP_MODE_FILTER,
358 		NULL, NULL, NULL);
359 	EXPECT_FALSE(true) {
360 		TH_LOG("Unreachable!");
361 	}
362 }
363 
364 /* Note! This doesn't test no new privs behavior */
TEST(no_new_privs_support)365 TEST(no_new_privs_support)
366 {
367 	long ret;
368 
369 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
370 	EXPECT_EQ(0, ret) {
371 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
372 	}
373 }
374 
375 /* Tests kernel support by checking for a copy_from_user() fault on NULL. */
TEST(mode_filter_support)376 TEST(mode_filter_support)
377 {
378 	long ret;
379 
380 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, NULL, 0, 0);
381 	ASSERT_EQ(0, ret) {
382 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
383 	}
384 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, NULL, NULL, NULL);
385 	EXPECT_EQ(-1, ret);
386 	EXPECT_EQ(EFAULT, errno) {
387 		TH_LOG("Kernel does not support CONFIG_SECCOMP_FILTER!");
388 	}
389 }
390 
TEST(mode_filter_without_nnp)391 TEST(mode_filter_without_nnp)
392 {
393 	struct sock_filter filter[] = {
394 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
395 	};
396 	struct sock_fprog prog = {
397 		.len = (unsigned short)ARRAY_SIZE(filter),
398 		.filter = filter,
399 	};
400 	long ret;
401 	cap_t cap = cap_get_proc();
402 	cap_flag_value_t is_cap_sys_admin = 0;
403 
404 	ret = prctl(PR_GET_NO_NEW_PRIVS, 0, NULL, 0, 0);
405 	ASSERT_LE(0, ret) {
406 		TH_LOG("Expected 0 or unsupported for NO_NEW_PRIVS");
407 	}
408 	errno = 0;
409 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
410 	/* Succeeds with CAP_SYS_ADMIN, fails without */
411 	cap_get_flag(cap, CAP_SYS_ADMIN, CAP_EFFECTIVE, &is_cap_sys_admin);
412 	if (!is_cap_sys_admin) {
413 		EXPECT_EQ(-1, ret);
414 		EXPECT_EQ(EACCES, errno);
415 	} else {
416 		EXPECT_EQ(0, ret);
417 	}
418 }
419 
420 #define MAX_INSNS_PER_PATH 32768
421 
TEST(filter_size_limits)422 TEST(filter_size_limits)
423 {
424 	int i;
425 	int count = BPF_MAXINSNS + 1;
426 	struct sock_filter allow[] = {
427 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
428 	};
429 	struct sock_filter *filter;
430 	struct sock_fprog prog = { };
431 	long ret;
432 
433 	filter = calloc(count, sizeof(*filter));
434 	ASSERT_NE(NULL, filter);
435 
436 	for (i = 0; i < count; i++)
437 		filter[i] = allow[0];
438 
439 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
440 	ASSERT_EQ(0, ret);
441 
442 	prog.filter = filter;
443 	prog.len = count;
444 
445 	/* Too many filter instructions in a single filter. */
446 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
447 	ASSERT_NE(0, ret) {
448 		TH_LOG("Installing %d insn filter was allowed", prog.len);
449 	}
450 
451 	/* One less is okay, though. */
452 	prog.len -= 1;
453 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
454 	ASSERT_EQ(0, ret) {
455 		TH_LOG("Installing %d insn filter wasn't allowed", prog.len);
456 	}
457 }
458 
TEST(filter_chain_limits)459 TEST(filter_chain_limits)
460 {
461 	int i;
462 	int count = BPF_MAXINSNS;
463 	struct sock_filter allow[] = {
464 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
465 	};
466 	struct sock_filter *filter;
467 	struct sock_fprog prog = { };
468 	long ret;
469 
470 	filter = calloc(count, sizeof(*filter));
471 	ASSERT_NE(NULL, filter);
472 
473 	for (i = 0; i < count; i++)
474 		filter[i] = allow[0];
475 
476 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
477 	ASSERT_EQ(0, ret);
478 
479 	prog.filter = filter;
480 	prog.len = 1;
481 
482 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
483 	ASSERT_EQ(0, ret);
484 
485 	prog.len = count;
486 
487 	/* Too many total filter instructions. */
488 	for (i = 0; i < MAX_INSNS_PER_PATH; i++) {
489 		ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
490 		if (ret != 0)
491 			break;
492 	}
493 	ASSERT_NE(0, ret) {
494 		TH_LOG("Allowed %d %d-insn filters (total with penalties:%d)",
495 		       i, count, i * (count + 4));
496 	}
497 }
498 
TEST(mode_filter_cannot_move_to_strict)499 TEST(mode_filter_cannot_move_to_strict)
500 {
501 	struct sock_filter filter[] = {
502 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
503 	};
504 	struct sock_fprog prog = {
505 		.len = (unsigned short)ARRAY_SIZE(filter),
506 		.filter = filter,
507 	};
508 	long ret;
509 
510 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
511 	ASSERT_EQ(0, ret);
512 
513 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
514 	ASSERT_EQ(0, ret);
515 
516 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_STRICT, NULL, 0, 0);
517 	EXPECT_EQ(-1, ret);
518 	EXPECT_EQ(EINVAL, errno);
519 }
520 
521 
TEST(mode_filter_get_seccomp)522 TEST(mode_filter_get_seccomp)
523 {
524 	struct sock_filter filter[] = {
525 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
526 	};
527 	struct sock_fprog prog = {
528 		.len = (unsigned short)ARRAY_SIZE(filter),
529 		.filter = filter,
530 	};
531 	long ret;
532 
533 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
534 	ASSERT_EQ(0, ret);
535 
536 	ret = prctl(PR_GET_SECCOMP, 0, 0, 0, 0);
537 	EXPECT_EQ(0, ret);
538 
539 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
540 	ASSERT_EQ(0, ret);
541 
542 	ret = prctl(PR_GET_SECCOMP, 0, 0, 0, 0);
543 	EXPECT_EQ(2, ret);
544 }
545 
546 
TEST(ALLOW_all)547 TEST(ALLOW_all)
548 {
549 	struct sock_filter filter[] = {
550 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
551 	};
552 	struct sock_fprog prog = {
553 		.len = (unsigned short)ARRAY_SIZE(filter),
554 		.filter = filter,
555 	};
556 	long ret;
557 
558 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
559 	ASSERT_EQ(0, ret);
560 
561 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog);
562 	ASSERT_EQ(0, ret);
563 }
564 
TEST(empty_prog)565 TEST(empty_prog)
566 {
567 	struct sock_filter filter[] = {
568 	};
569 	struct sock_fprog prog = {
570 		.len = (unsigned short)ARRAY_SIZE(filter),
571 		.filter = filter,
572 	};
573 	long ret;
574 
575 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
576 	ASSERT_EQ(0, ret);
577 
578 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog);
579 	EXPECT_EQ(-1, ret);
580 	EXPECT_EQ(EINVAL, errno);
581 }
582 
TEST(log_all)583 TEST(log_all)
584 {
585 	struct sock_filter filter[] = {
586 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_LOG),
587 	};
588 	struct sock_fprog prog = {
589 		.len = (unsigned short)ARRAY_SIZE(filter),
590 		.filter = filter,
591 	};
592 	long ret;
593 	pid_t parent = getppid();
594 
595 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
596 	ASSERT_EQ(0, ret);
597 
598 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog);
599 	ASSERT_EQ(0, ret);
600 
601 	/* getppid() should succeed and be logged (no check for logging) */
602 	EXPECT_EQ(parent, syscall(__NR_getppid));
603 }
604 
TEST_SIGNAL(unknown_ret_is_kill_inside,SIGSYS)605 TEST_SIGNAL(unknown_ret_is_kill_inside, SIGSYS)
606 {
607 	struct sock_filter filter[] = {
608 		BPF_STMT(BPF_RET|BPF_K, 0x10000000U),
609 	};
610 	struct sock_fprog prog = {
611 		.len = (unsigned short)ARRAY_SIZE(filter),
612 		.filter = filter,
613 	};
614 	long ret;
615 
616 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
617 	ASSERT_EQ(0, ret);
618 
619 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog);
620 	ASSERT_EQ(0, ret);
621 	EXPECT_EQ(0, syscall(__NR_getpid)) {
622 		TH_LOG("getpid() shouldn't ever return");
623 	}
624 }
625 
626 /* return code >= 0x80000000 is unused. */
TEST_SIGNAL(unknown_ret_is_kill_above_allow,SIGSYS)627 TEST_SIGNAL(unknown_ret_is_kill_above_allow, SIGSYS)
628 {
629 	struct sock_filter filter[] = {
630 		BPF_STMT(BPF_RET|BPF_K, 0x90000000U),
631 	};
632 	struct sock_fprog prog = {
633 		.len = (unsigned short)ARRAY_SIZE(filter),
634 		.filter = filter,
635 	};
636 	long ret;
637 
638 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
639 	ASSERT_EQ(0, ret);
640 
641 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog);
642 	ASSERT_EQ(0, ret);
643 	EXPECT_EQ(0, syscall(__NR_getpid)) {
644 		TH_LOG("getpid() shouldn't ever return");
645 	}
646 }
647 
TEST_SIGNAL(KILL_all,SIGSYS)648 TEST_SIGNAL(KILL_all, SIGSYS)
649 {
650 	struct sock_filter filter[] = {
651 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_KILL),
652 	};
653 	struct sock_fprog prog = {
654 		.len = (unsigned short)ARRAY_SIZE(filter),
655 		.filter = filter,
656 	};
657 	long ret;
658 
659 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
660 	ASSERT_EQ(0, ret);
661 
662 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog);
663 	ASSERT_EQ(0, ret);
664 }
665 
TEST_SIGNAL(KILL_one,SIGSYS)666 TEST_SIGNAL(KILL_one, SIGSYS)
667 {
668 	struct sock_filter filter[] = {
669 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
670 			offsetof(struct seccomp_data, nr)),
671 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getpid, 0, 1),
672 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_KILL),
673 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
674 	};
675 	struct sock_fprog prog = {
676 		.len = (unsigned short)ARRAY_SIZE(filter),
677 		.filter = filter,
678 	};
679 	long ret;
680 	pid_t parent = getppid();
681 
682 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
683 	ASSERT_EQ(0, ret);
684 
685 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog);
686 	ASSERT_EQ(0, ret);
687 
688 	EXPECT_EQ(parent, syscall(__NR_getppid));
689 	/* getpid() should never return. */
690 	EXPECT_EQ(0, syscall(__NR_getpid));
691 }
692 
TEST_SIGNAL(KILL_one_arg_one,SIGSYS)693 TEST_SIGNAL(KILL_one_arg_one, SIGSYS)
694 {
695 	void *fatal_address;
696 	struct sock_filter filter[] = {
697 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
698 			offsetof(struct seccomp_data, nr)),
699 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_times, 1, 0),
700 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
701 		/* Only both with lower 32-bit for now. */
702 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS, syscall_arg(0)),
703 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K,
704 			(unsigned long)&fatal_address, 0, 1),
705 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_KILL),
706 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
707 	};
708 	struct sock_fprog prog = {
709 		.len = (unsigned short)ARRAY_SIZE(filter),
710 		.filter = filter,
711 	};
712 	long ret;
713 	pid_t parent = getppid();
714 	struct tms timebuf;
715 	clock_t clock = times(&timebuf);
716 
717 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
718 	ASSERT_EQ(0, ret);
719 
720 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog);
721 	ASSERT_EQ(0, ret);
722 
723 	EXPECT_EQ(parent, syscall(__NR_getppid));
724 	EXPECT_LE(clock, syscall(__NR_times, &timebuf));
725 	/* times() should never return. */
726 	EXPECT_EQ(0, syscall(__NR_times, &fatal_address));
727 }
728 
TEST_SIGNAL(KILL_one_arg_six,SIGSYS)729 TEST_SIGNAL(KILL_one_arg_six, SIGSYS)
730 {
731 #ifndef __NR_mmap2
732 	int sysno = __NR_mmap;
733 #else
734 	int sysno = __NR_mmap2;
735 #endif
736 	struct sock_filter filter[] = {
737 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
738 			offsetof(struct seccomp_data, nr)),
739 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, sysno, 1, 0),
740 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
741 		/* Only both with lower 32-bit for now. */
742 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS, syscall_arg(5)),
743 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, 0x0C0FFEE, 0, 1),
744 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_KILL),
745 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
746 	};
747 	struct sock_fprog prog = {
748 		.len = (unsigned short)ARRAY_SIZE(filter),
749 		.filter = filter,
750 	};
751 	long ret;
752 	pid_t parent = getppid();
753 	int fd;
754 	void *map1, *map2;
755 	int page_size = sysconf(_SC_PAGESIZE);
756 
757 	ASSERT_LT(0, page_size);
758 
759 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
760 	ASSERT_EQ(0, ret);
761 
762 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog);
763 	ASSERT_EQ(0, ret);
764 
765 	fd = open("/dev/zero", O_RDONLY);
766 	ASSERT_NE(-1, fd);
767 
768 	EXPECT_EQ(parent, syscall(__NR_getppid));
769 	map1 = (void *)syscall(sysno,
770 		NULL, page_size, PROT_READ, MAP_PRIVATE, fd, page_size);
771 	EXPECT_NE(MAP_FAILED, map1);
772 	/* mmap2() should never return. */
773 	map2 = (void *)syscall(sysno,
774 		 NULL, page_size, PROT_READ, MAP_PRIVATE, fd, 0x0C0FFEE);
775 	EXPECT_EQ(MAP_FAILED, map2);
776 
777 	/* The test failed, so clean up the resources. */
778 	munmap(map1, page_size);
779 	munmap(map2, page_size);
780 	close(fd);
781 }
782 
783 /* This is a thread task to die via seccomp filter violation. */
kill_thread(void * data)784 void *kill_thread(void *data)
785 {
786 	bool die = (bool)data;
787 
788 	if (die) {
789 		syscall(__NR_getpid);
790 		return (void *)SIBLING_EXIT_FAILURE;
791 	}
792 
793 	return (void *)SIBLING_EXIT_UNKILLED;
794 }
795 
796 enum kill_t {
797 	KILL_THREAD,
798 	KILL_PROCESS,
799 	RET_UNKNOWN
800 };
801 
802 /* Prepare a thread that will kill itself or both of us. */
kill_thread_or_group(struct __test_metadata * _metadata,enum kill_t kill_how)803 void kill_thread_or_group(struct __test_metadata *_metadata,
804 			  enum kill_t kill_how)
805 {
806 	pthread_t thread;
807 	void *status;
808 	/* Kill only when calling __NR_getpid. */
809 	struct sock_filter filter_thread[] = {
810 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
811 			offsetof(struct seccomp_data, nr)),
812 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getpid, 0, 1),
813 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_KILL_THREAD),
814 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
815 	};
816 	struct sock_fprog prog_thread = {
817 		.len = (unsigned short)ARRAY_SIZE(filter_thread),
818 		.filter = filter_thread,
819 	};
820 	int kill = kill_how == KILL_PROCESS ? SECCOMP_RET_KILL_PROCESS : 0xAAAAAAAA;
821 	struct sock_filter filter_process[] = {
822 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
823 			offsetof(struct seccomp_data, nr)),
824 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getpid, 0, 1),
825 		BPF_STMT(BPF_RET|BPF_K, kill),
826 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
827 	};
828 	struct sock_fprog prog_process = {
829 		.len = (unsigned short)ARRAY_SIZE(filter_process),
830 		.filter = filter_process,
831 	};
832 
833 	ASSERT_EQ(0, prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
834 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
835 	}
836 
837 	ASSERT_EQ(0, seccomp(SECCOMP_SET_MODE_FILTER, 0,
838 			     kill_how == KILL_THREAD ? &prog_thread
839 						     : &prog_process));
840 
841 	/*
842 	 * Add the KILL_THREAD rule again to make sure that the KILL_PROCESS
843 	 * flag cannot be downgraded by a new filter.
844 	 */
845 	if (kill_how == KILL_PROCESS)
846 		ASSERT_EQ(0, seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog_thread));
847 
848 	/* Start a thread that will exit immediately. */
849 	ASSERT_EQ(0, pthread_create(&thread, NULL, kill_thread, (void *)false));
850 	ASSERT_EQ(0, pthread_join(thread, &status));
851 	ASSERT_EQ(SIBLING_EXIT_UNKILLED, (unsigned long)status);
852 
853 	/* Start a thread that will die immediately. */
854 	ASSERT_EQ(0, pthread_create(&thread, NULL, kill_thread, (void *)true));
855 	ASSERT_EQ(0, pthread_join(thread, &status));
856 	ASSERT_NE(SIBLING_EXIT_FAILURE, (unsigned long)status);
857 
858 	/*
859 	 * If we get here, only the spawned thread died. Let the parent know
860 	 * the whole process didn't die (i.e. this thread, the spawner,
861 	 * stayed running).
862 	 */
863 	exit(42);
864 }
865 
TEST(KILL_thread)866 TEST(KILL_thread)
867 {
868 	int status;
869 	pid_t child_pid;
870 
871 	child_pid = fork();
872 	ASSERT_LE(0, child_pid);
873 	if (child_pid == 0) {
874 		kill_thread_or_group(_metadata, KILL_THREAD);
875 		_exit(38);
876 	}
877 
878 	ASSERT_EQ(child_pid, waitpid(child_pid, &status, 0));
879 
880 	/* If only the thread was killed, we'll see exit 42. */
881 	ASSERT_TRUE(WIFEXITED(status));
882 	ASSERT_EQ(42, WEXITSTATUS(status));
883 }
884 
TEST(KILL_process)885 TEST(KILL_process)
886 {
887 	int status;
888 	pid_t child_pid;
889 
890 	child_pid = fork();
891 	ASSERT_LE(0, child_pid);
892 	if (child_pid == 0) {
893 		kill_thread_or_group(_metadata, KILL_PROCESS);
894 		_exit(38);
895 	}
896 
897 	ASSERT_EQ(child_pid, waitpid(child_pid, &status, 0));
898 
899 	/* If the entire process was killed, we'll see SIGSYS. */
900 	ASSERT_TRUE(WIFSIGNALED(status));
901 	ASSERT_EQ(SIGSYS, WTERMSIG(status));
902 }
903 
TEST(KILL_unknown)904 TEST(KILL_unknown)
905 {
906 	int status;
907 	pid_t child_pid;
908 
909 	child_pid = fork();
910 	ASSERT_LE(0, child_pid);
911 	if (child_pid == 0) {
912 		kill_thread_or_group(_metadata, RET_UNKNOWN);
913 		_exit(38);
914 	}
915 
916 	ASSERT_EQ(child_pid, waitpid(child_pid, &status, 0));
917 
918 	/* If the entire process was killed, we'll see SIGSYS. */
919 	EXPECT_TRUE(WIFSIGNALED(status)) {
920 		TH_LOG("Unknown SECCOMP_RET is only killing the thread?");
921 	}
922 	ASSERT_EQ(SIGSYS, WTERMSIG(status));
923 }
924 
925 /* TODO(wad) add 64-bit versus 32-bit arg tests. */
TEST(arg_out_of_range)926 TEST(arg_out_of_range)
927 {
928 	struct sock_filter filter[] = {
929 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS, syscall_arg(6)),
930 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
931 	};
932 	struct sock_fprog prog = {
933 		.len = (unsigned short)ARRAY_SIZE(filter),
934 		.filter = filter,
935 	};
936 	long ret;
937 
938 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
939 	ASSERT_EQ(0, ret);
940 
941 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog);
942 	EXPECT_EQ(-1, ret);
943 	EXPECT_EQ(EINVAL, errno);
944 }
945 
946 #define ERRNO_FILTER(name, errno)					\
947 	struct sock_filter _read_filter_##name[] = {			\
948 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,				\
949 			offsetof(struct seccomp_data, nr)),		\
950 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_read, 0, 1),	\
951 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ERRNO | errno),	\
952 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),		\
953 	};								\
954 	struct sock_fprog prog_##name = {				\
955 		.len = (unsigned short)ARRAY_SIZE(_read_filter_##name),	\
956 		.filter = _read_filter_##name,				\
957 	}
958 
959 /* Make sure basic errno values are correctly passed through a filter. */
TEST(ERRNO_valid)960 TEST(ERRNO_valid)
961 {
962 	ERRNO_FILTER(valid, E2BIG);
963 	long ret;
964 	pid_t parent = getppid();
965 
966 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
967 	ASSERT_EQ(0, ret);
968 
969 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog_valid);
970 	ASSERT_EQ(0, ret);
971 
972 	EXPECT_EQ(parent, syscall(__NR_getppid));
973 	EXPECT_EQ(-1, read(-1, NULL, 0));
974 	EXPECT_EQ(E2BIG, errno);
975 }
976 
977 /* Make sure an errno of zero is correctly handled by the arch code. */
TEST(ERRNO_zero)978 TEST(ERRNO_zero)
979 {
980 	ERRNO_FILTER(zero, 0);
981 	long ret;
982 	pid_t parent = getppid();
983 
984 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
985 	ASSERT_EQ(0, ret);
986 
987 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog_zero);
988 	ASSERT_EQ(0, ret);
989 
990 	EXPECT_EQ(parent, syscall(__NR_getppid));
991 	/* "errno" of 0 is ok. */
992 	EXPECT_EQ(0, read(-1, NULL, 0));
993 }
994 
995 /*
996  * The SECCOMP_RET_DATA mask is 16 bits wide, but errno is smaller.
997  * This tests that the errno value gets capped correctly, fixed by
998  * 580c57f10768 ("seccomp: cap SECCOMP_RET_ERRNO data to MAX_ERRNO").
999  */
TEST(ERRNO_capped)1000 TEST(ERRNO_capped)
1001 {
1002 	ERRNO_FILTER(capped, 4096);
1003 	long ret;
1004 	pid_t parent = getppid();
1005 
1006 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1007 	ASSERT_EQ(0, ret);
1008 
1009 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog_capped);
1010 	ASSERT_EQ(0, ret);
1011 
1012 	EXPECT_EQ(parent, syscall(__NR_getppid));
1013 	EXPECT_EQ(-1, read(-1, NULL, 0));
1014 	EXPECT_EQ(4095, errno);
1015 }
1016 
1017 /*
1018  * Filters are processed in reverse order: last applied is executed first.
1019  * Since only the SECCOMP_RET_ACTION mask is tested for return values, the
1020  * SECCOMP_RET_DATA mask results will follow the most recently applied
1021  * matching filter return (and not the lowest or highest value).
1022  */
TEST(ERRNO_order)1023 TEST(ERRNO_order)
1024 {
1025 	ERRNO_FILTER(first,  11);
1026 	ERRNO_FILTER(second, 13);
1027 	ERRNO_FILTER(third,  12);
1028 	long ret;
1029 	pid_t parent = getppid();
1030 
1031 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1032 	ASSERT_EQ(0, ret);
1033 
1034 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog_first);
1035 	ASSERT_EQ(0, ret);
1036 
1037 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog_second);
1038 	ASSERT_EQ(0, ret);
1039 
1040 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog_third);
1041 	ASSERT_EQ(0, ret);
1042 
1043 	EXPECT_EQ(parent, syscall(__NR_getppid));
1044 	EXPECT_EQ(-1, read(-1, NULL, 0));
1045 	EXPECT_EQ(12, errno);
1046 }
1047 
FIXTURE(TRAP)1048 FIXTURE(TRAP) {
1049 	struct sock_fprog prog;
1050 };
1051 
FIXTURE_SETUP(TRAP)1052 FIXTURE_SETUP(TRAP)
1053 {
1054 	struct sock_filter filter[] = {
1055 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
1056 			offsetof(struct seccomp_data, nr)),
1057 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getpid, 0, 1),
1058 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_TRAP),
1059 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
1060 	};
1061 
1062 	memset(&self->prog, 0, sizeof(self->prog));
1063 	self->prog.filter = malloc(sizeof(filter));
1064 	ASSERT_NE(NULL, self->prog.filter);
1065 	memcpy(self->prog.filter, filter, sizeof(filter));
1066 	self->prog.len = (unsigned short)ARRAY_SIZE(filter);
1067 }
1068 
FIXTURE_TEARDOWN(TRAP)1069 FIXTURE_TEARDOWN(TRAP)
1070 {
1071 	if (self->prog.filter)
1072 		free(self->prog.filter);
1073 }
1074 
TEST_F_SIGNAL(TRAP,dfl,SIGSYS)1075 TEST_F_SIGNAL(TRAP, dfl, SIGSYS)
1076 {
1077 	long ret;
1078 
1079 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1080 	ASSERT_EQ(0, ret);
1081 
1082 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->prog);
1083 	ASSERT_EQ(0, ret);
1084 	syscall(__NR_getpid);
1085 }
1086 
1087 /* Ensure that SIGSYS overrides SIG_IGN */
TEST_F_SIGNAL(TRAP,ign,SIGSYS)1088 TEST_F_SIGNAL(TRAP, ign, SIGSYS)
1089 {
1090 	long ret;
1091 
1092 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1093 	ASSERT_EQ(0, ret);
1094 
1095 	signal(SIGSYS, SIG_IGN);
1096 
1097 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->prog);
1098 	ASSERT_EQ(0, ret);
1099 	syscall(__NR_getpid);
1100 }
1101 
1102 static siginfo_t TRAP_info;
1103 static volatile int TRAP_nr;
TRAP_action(int nr,siginfo_t * info,void * void_context)1104 static void TRAP_action(int nr, siginfo_t *info, void *void_context)
1105 {
1106 	memcpy(&TRAP_info, info, sizeof(TRAP_info));
1107 	TRAP_nr = nr;
1108 }
1109 
TEST_F(TRAP,handler)1110 TEST_F(TRAP, handler)
1111 {
1112 	int ret, test;
1113 	struct sigaction act;
1114 	sigset_t mask;
1115 
1116 	memset(&act, 0, sizeof(act));
1117 	sigemptyset(&mask);
1118 	sigaddset(&mask, SIGSYS);
1119 
1120 	act.sa_sigaction = &TRAP_action;
1121 	act.sa_flags = SA_SIGINFO;
1122 	ret = sigaction(SIGSYS, &act, NULL);
1123 	ASSERT_EQ(0, ret) {
1124 		TH_LOG("sigaction failed");
1125 	}
1126 	ret = sigprocmask(SIG_UNBLOCK, &mask, NULL);
1127 	ASSERT_EQ(0, ret) {
1128 		TH_LOG("sigprocmask failed");
1129 	}
1130 
1131 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1132 	ASSERT_EQ(0, ret);
1133 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->prog);
1134 	ASSERT_EQ(0, ret);
1135 	TRAP_nr = 0;
1136 	memset(&TRAP_info, 0, sizeof(TRAP_info));
1137 	/* Expect the registers to be rolled back. (nr = error) may vary
1138 	 * based on arch. */
1139 	ret = syscall(__NR_getpid);
1140 	/* Silence gcc warning about volatile. */
1141 	test = TRAP_nr;
1142 	EXPECT_EQ(SIGSYS, test);
1143 	struct local_sigsys {
1144 		void *_call_addr;	/* calling user insn */
1145 		int _syscall;		/* triggering system call number */
1146 		unsigned int _arch;	/* AUDIT_ARCH_* of syscall */
1147 	} *sigsys = (struct local_sigsys *)
1148 #ifdef si_syscall
1149 		&(TRAP_info.si_call_addr);
1150 #else
1151 		&TRAP_info.si_pid;
1152 #endif
1153 	EXPECT_EQ(__NR_getpid, sigsys->_syscall);
1154 	/* Make sure arch is non-zero. */
1155 	EXPECT_NE(0, sigsys->_arch);
1156 	EXPECT_NE(0, (unsigned long)sigsys->_call_addr);
1157 }
1158 
FIXTURE(precedence)1159 FIXTURE(precedence) {
1160 	struct sock_fprog allow;
1161 	struct sock_fprog log;
1162 	struct sock_fprog trace;
1163 	struct sock_fprog error;
1164 	struct sock_fprog trap;
1165 	struct sock_fprog kill;
1166 };
1167 
FIXTURE_SETUP(precedence)1168 FIXTURE_SETUP(precedence)
1169 {
1170 	struct sock_filter allow_insns[] = {
1171 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
1172 	};
1173 	struct sock_filter log_insns[] = {
1174 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
1175 			offsetof(struct seccomp_data, nr)),
1176 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getpid, 1, 0),
1177 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
1178 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_LOG),
1179 	};
1180 	struct sock_filter trace_insns[] = {
1181 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
1182 			offsetof(struct seccomp_data, nr)),
1183 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getpid, 1, 0),
1184 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
1185 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_TRACE),
1186 	};
1187 	struct sock_filter error_insns[] = {
1188 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
1189 			offsetof(struct seccomp_data, nr)),
1190 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getpid, 1, 0),
1191 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
1192 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ERRNO),
1193 	};
1194 	struct sock_filter trap_insns[] = {
1195 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
1196 			offsetof(struct seccomp_data, nr)),
1197 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getpid, 1, 0),
1198 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
1199 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_TRAP),
1200 	};
1201 	struct sock_filter kill_insns[] = {
1202 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
1203 			offsetof(struct seccomp_data, nr)),
1204 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getpid, 1, 0),
1205 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
1206 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_KILL),
1207 	};
1208 
1209 	memset(self, 0, sizeof(*self));
1210 #define FILTER_ALLOC(_x) \
1211 	self->_x.filter = malloc(sizeof(_x##_insns)); \
1212 	ASSERT_NE(NULL, self->_x.filter); \
1213 	memcpy(self->_x.filter, &_x##_insns, sizeof(_x##_insns)); \
1214 	self->_x.len = (unsigned short)ARRAY_SIZE(_x##_insns)
1215 	FILTER_ALLOC(allow);
1216 	FILTER_ALLOC(log);
1217 	FILTER_ALLOC(trace);
1218 	FILTER_ALLOC(error);
1219 	FILTER_ALLOC(trap);
1220 	FILTER_ALLOC(kill);
1221 }
1222 
FIXTURE_TEARDOWN(precedence)1223 FIXTURE_TEARDOWN(precedence)
1224 {
1225 #define FILTER_FREE(_x) if (self->_x.filter) free(self->_x.filter)
1226 	FILTER_FREE(allow);
1227 	FILTER_FREE(log);
1228 	FILTER_FREE(trace);
1229 	FILTER_FREE(error);
1230 	FILTER_FREE(trap);
1231 	FILTER_FREE(kill);
1232 }
1233 
TEST_F(precedence,allow_ok)1234 TEST_F(precedence, allow_ok)
1235 {
1236 	pid_t parent, res = 0;
1237 	long ret;
1238 
1239 	parent = getppid();
1240 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1241 	ASSERT_EQ(0, ret);
1242 
1243 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->allow);
1244 	ASSERT_EQ(0, ret);
1245 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->log);
1246 	ASSERT_EQ(0, ret);
1247 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trace);
1248 	ASSERT_EQ(0, ret);
1249 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->error);
1250 	ASSERT_EQ(0, ret);
1251 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trap);
1252 	ASSERT_EQ(0, ret);
1253 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->kill);
1254 	ASSERT_EQ(0, ret);
1255 	/* Should work just fine. */
1256 	res = syscall(__NR_getppid);
1257 	EXPECT_EQ(parent, res);
1258 }
1259 
TEST_F_SIGNAL(precedence,kill_is_highest,SIGSYS)1260 TEST_F_SIGNAL(precedence, kill_is_highest, SIGSYS)
1261 {
1262 	pid_t parent, res = 0;
1263 	long ret;
1264 
1265 	parent = getppid();
1266 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1267 	ASSERT_EQ(0, ret);
1268 
1269 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->allow);
1270 	ASSERT_EQ(0, ret);
1271 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->log);
1272 	ASSERT_EQ(0, ret);
1273 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trace);
1274 	ASSERT_EQ(0, ret);
1275 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->error);
1276 	ASSERT_EQ(0, ret);
1277 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trap);
1278 	ASSERT_EQ(0, ret);
1279 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->kill);
1280 	ASSERT_EQ(0, ret);
1281 	/* Should work just fine. */
1282 	res = syscall(__NR_getppid);
1283 	EXPECT_EQ(parent, res);
1284 	/* getpid() should never return. */
1285 	res = syscall(__NR_getpid);
1286 	EXPECT_EQ(0, res);
1287 }
1288 
TEST_F_SIGNAL(precedence,kill_is_highest_in_any_order,SIGSYS)1289 TEST_F_SIGNAL(precedence, kill_is_highest_in_any_order, SIGSYS)
1290 {
1291 	pid_t parent;
1292 	long ret;
1293 
1294 	parent = getppid();
1295 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1296 	ASSERT_EQ(0, ret);
1297 
1298 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->allow);
1299 	ASSERT_EQ(0, ret);
1300 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->kill);
1301 	ASSERT_EQ(0, ret);
1302 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->error);
1303 	ASSERT_EQ(0, ret);
1304 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->log);
1305 	ASSERT_EQ(0, ret);
1306 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trace);
1307 	ASSERT_EQ(0, ret);
1308 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trap);
1309 	ASSERT_EQ(0, ret);
1310 	/* Should work just fine. */
1311 	EXPECT_EQ(parent, syscall(__NR_getppid));
1312 	/* getpid() should never return. */
1313 	EXPECT_EQ(0, syscall(__NR_getpid));
1314 }
1315 
TEST_F_SIGNAL(precedence,trap_is_second,SIGSYS)1316 TEST_F_SIGNAL(precedence, trap_is_second, SIGSYS)
1317 {
1318 	pid_t parent;
1319 	long ret;
1320 
1321 	parent = getppid();
1322 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1323 	ASSERT_EQ(0, ret);
1324 
1325 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->allow);
1326 	ASSERT_EQ(0, ret);
1327 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->log);
1328 	ASSERT_EQ(0, ret);
1329 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trace);
1330 	ASSERT_EQ(0, ret);
1331 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->error);
1332 	ASSERT_EQ(0, ret);
1333 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trap);
1334 	ASSERT_EQ(0, ret);
1335 	/* Should work just fine. */
1336 	EXPECT_EQ(parent, syscall(__NR_getppid));
1337 	/* getpid() should never return. */
1338 	EXPECT_EQ(0, syscall(__NR_getpid));
1339 }
1340 
TEST_F_SIGNAL(precedence,trap_is_second_in_any_order,SIGSYS)1341 TEST_F_SIGNAL(precedence, trap_is_second_in_any_order, SIGSYS)
1342 {
1343 	pid_t parent;
1344 	long ret;
1345 
1346 	parent = getppid();
1347 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1348 	ASSERT_EQ(0, ret);
1349 
1350 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->allow);
1351 	ASSERT_EQ(0, ret);
1352 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trap);
1353 	ASSERT_EQ(0, ret);
1354 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->log);
1355 	ASSERT_EQ(0, ret);
1356 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trace);
1357 	ASSERT_EQ(0, ret);
1358 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->error);
1359 	ASSERT_EQ(0, ret);
1360 	/* Should work just fine. */
1361 	EXPECT_EQ(parent, syscall(__NR_getppid));
1362 	/* getpid() should never return. */
1363 	EXPECT_EQ(0, syscall(__NR_getpid));
1364 }
1365 
TEST_F(precedence,errno_is_third)1366 TEST_F(precedence, errno_is_third)
1367 {
1368 	pid_t parent;
1369 	long ret;
1370 
1371 	parent = getppid();
1372 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1373 	ASSERT_EQ(0, ret);
1374 
1375 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->allow);
1376 	ASSERT_EQ(0, ret);
1377 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->log);
1378 	ASSERT_EQ(0, ret);
1379 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trace);
1380 	ASSERT_EQ(0, ret);
1381 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->error);
1382 	ASSERT_EQ(0, ret);
1383 	/* Should work just fine. */
1384 	EXPECT_EQ(parent, syscall(__NR_getppid));
1385 	EXPECT_EQ(0, syscall(__NR_getpid));
1386 }
1387 
TEST_F(precedence,errno_is_third_in_any_order)1388 TEST_F(precedence, errno_is_third_in_any_order)
1389 {
1390 	pid_t parent;
1391 	long ret;
1392 
1393 	parent = getppid();
1394 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1395 	ASSERT_EQ(0, ret);
1396 
1397 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->log);
1398 	ASSERT_EQ(0, ret);
1399 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->error);
1400 	ASSERT_EQ(0, ret);
1401 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trace);
1402 	ASSERT_EQ(0, ret);
1403 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->allow);
1404 	ASSERT_EQ(0, ret);
1405 	/* Should work just fine. */
1406 	EXPECT_EQ(parent, syscall(__NR_getppid));
1407 	EXPECT_EQ(0, syscall(__NR_getpid));
1408 }
1409 
TEST_F(precedence,trace_is_fourth)1410 TEST_F(precedence, trace_is_fourth)
1411 {
1412 	pid_t parent;
1413 	long ret;
1414 
1415 	parent = getppid();
1416 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1417 	ASSERT_EQ(0, ret);
1418 
1419 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->allow);
1420 	ASSERT_EQ(0, ret);
1421 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->log);
1422 	ASSERT_EQ(0, ret);
1423 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trace);
1424 	ASSERT_EQ(0, ret);
1425 	/* Should work just fine. */
1426 	EXPECT_EQ(parent, syscall(__NR_getppid));
1427 	/* No ptracer */
1428 	EXPECT_EQ(-1, syscall(__NR_getpid));
1429 }
1430 
TEST_F(precedence,trace_is_fourth_in_any_order)1431 TEST_F(precedence, trace_is_fourth_in_any_order)
1432 {
1433 	pid_t parent;
1434 	long ret;
1435 
1436 	parent = getppid();
1437 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1438 	ASSERT_EQ(0, ret);
1439 
1440 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->trace);
1441 	ASSERT_EQ(0, ret);
1442 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->allow);
1443 	ASSERT_EQ(0, ret);
1444 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->log);
1445 	ASSERT_EQ(0, ret);
1446 	/* Should work just fine. */
1447 	EXPECT_EQ(parent, syscall(__NR_getppid));
1448 	/* No ptracer */
1449 	EXPECT_EQ(-1, syscall(__NR_getpid));
1450 }
1451 
TEST_F(precedence,log_is_fifth)1452 TEST_F(precedence, log_is_fifth)
1453 {
1454 	pid_t mypid, parent;
1455 	long ret;
1456 
1457 	mypid = getpid();
1458 	parent = getppid();
1459 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1460 	ASSERT_EQ(0, ret);
1461 
1462 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->allow);
1463 	ASSERT_EQ(0, ret);
1464 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->log);
1465 	ASSERT_EQ(0, ret);
1466 	/* Should work just fine. */
1467 	EXPECT_EQ(parent, syscall(__NR_getppid));
1468 	/* Should also work just fine */
1469 	EXPECT_EQ(mypid, syscall(__NR_getpid));
1470 }
1471 
TEST_F(precedence,log_is_fifth_in_any_order)1472 TEST_F(precedence, log_is_fifth_in_any_order)
1473 {
1474 	pid_t mypid, parent;
1475 	long ret;
1476 
1477 	mypid = getpid();
1478 	parent = getppid();
1479 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1480 	ASSERT_EQ(0, ret);
1481 
1482 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->log);
1483 	ASSERT_EQ(0, ret);
1484 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->allow);
1485 	ASSERT_EQ(0, ret);
1486 	/* Should work just fine. */
1487 	EXPECT_EQ(parent, syscall(__NR_getppid));
1488 	/* Should also work just fine */
1489 	EXPECT_EQ(mypid, syscall(__NR_getpid));
1490 }
1491 
1492 #ifndef PTRACE_O_TRACESECCOMP
1493 #define PTRACE_O_TRACESECCOMP	0x00000080
1494 #endif
1495 
1496 /* Catch the Ubuntu 12.04 value error. */
1497 #if PTRACE_EVENT_SECCOMP != 7
1498 #undef PTRACE_EVENT_SECCOMP
1499 #endif
1500 
1501 #ifndef PTRACE_EVENT_SECCOMP
1502 #define PTRACE_EVENT_SECCOMP 7
1503 #endif
1504 
1505 #define PTRACE_EVENT_MASK(status) ((status) >> 16)
1506 bool tracer_running;
tracer_stop(int sig)1507 void tracer_stop(int sig)
1508 {
1509 	tracer_running = false;
1510 }
1511 
1512 typedef void tracer_func_t(struct __test_metadata *_metadata,
1513 			   pid_t tracee, int status, void *args);
1514 
start_tracer(struct __test_metadata * _metadata,int fd,pid_t tracee,tracer_func_t tracer_func,void * args,bool ptrace_syscall)1515 void start_tracer(struct __test_metadata *_metadata, int fd, pid_t tracee,
1516 	    tracer_func_t tracer_func, void *args, bool ptrace_syscall)
1517 {
1518 	int ret = -1;
1519 	struct sigaction action = {
1520 		.sa_handler = tracer_stop,
1521 	};
1522 
1523 	/* Allow external shutdown. */
1524 	tracer_running = true;
1525 	ASSERT_EQ(0, sigaction(SIGUSR1, &action, NULL));
1526 
1527 	errno = 0;
1528 	while (ret == -1 && errno != EINVAL)
1529 		ret = ptrace(PTRACE_ATTACH, tracee, NULL, 0);
1530 	ASSERT_EQ(0, ret) {
1531 		kill(tracee, SIGKILL);
1532 	}
1533 	/* Wait for attach stop */
1534 	wait(NULL);
1535 
1536 	ret = ptrace(PTRACE_SETOPTIONS, tracee, NULL, ptrace_syscall ?
1537 						      PTRACE_O_TRACESYSGOOD :
1538 						      PTRACE_O_TRACESECCOMP);
1539 	ASSERT_EQ(0, ret) {
1540 		TH_LOG("Failed to set PTRACE_O_TRACESECCOMP");
1541 		kill(tracee, SIGKILL);
1542 	}
1543 	ret = ptrace(ptrace_syscall ? PTRACE_SYSCALL : PTRACE_CONT,
1544 		     tracee, NULL, 0);
1545 	ASSERT_EQ(0, ret);
1546 
1547 	/* Unblock the tracee */
1548 	ASSERT_EQ(1, write(fd, "A", 1));
1549 	ASSERT_EQ(0, close(fd));
1550 
1551 	/* Run until we're shut down. Must assert to stop execution. */
1552 	while (tracer_running) {
1553 		int status;
1554 
1555 		if (wait(&status) != tracee)
1556 			continue;
1557 
1558 		if (WIFSIGNALED(status)) {
1559 			/* Child caught a fatal signal. */
1560 			return;
1561 		}
1562 		if (WIFEXITED(status)) {
1563 			/* Child exited with code. */
1564 			return;
1565 		}
1566 
1567 		/* Check if we got an expected event. */
1568 		ASSERT_EQ(WIFCONTINUED(status), false);
1569 		ASSERT_EQ(WIFSTOPPED(status), true);
1570 		ASSERT_EQ(WSTOPSIG(status) & SIGTRAP, SIGTRAP) {
1571 			TH_LOG("Unexpected WSTOPSIG: %d", WSTOPSIG(status));
1572 		}
1573 
1574 		tracer_func(_metadata, tracee, status, args);
1575 
1576 		ret = ptrace(ptrace_syscall ? PTRACE_SYSCALL : PTRACE_CONT,
1577 			     tracee, NULL, 0);
1578 		ASSERT_EQ(0, ret);
1579 	}
1580 	/* Directly report the status of our test harness results. */
1581 	syscall(__NR_exit, _metadata->exit_code);
1582 }
1583 
1584 /* Common tracer setup/teardown functions. */
cont_handler(int num)1585 void cont_handler(int num)
1586 { }
setup_trace_fixture(struct __test_metadata * _metadata,tracer_func_t func,void * args,bool ptrace_syscall)1587 pid_t setup_trace_fixture(struct __test_metadata *_metadata,
1588 			  tracer_func_t func, void *args, bool ptrace_syscall)
1589 {
1590 	char sync;
1591 	int pipefd[2];
1592 	pid_t tracer_pid;
1593 	pid_t tracee = getpid();
1594 
1595 	/* Setup a pipe for clean synchronization. */
1596 	ASSERT_EQ(0, pipe(pipefd));
1597 
1598 	/* Fork a child which we'll promote to tracer */
1599 	tracer_pid = fork();
1600 	ASSERT_LE(0, tracer_pid);
1601 	signal(SIGALRM, cont_handler);
1602 	if (tracer_pid == 0) {
1603 		close(pipefd[0]);
1604 		start_tracer(_metadata, pipefd[1], tracee, func, args,
1605 			     ptrace_syscall);
1606 		syscall(__NR_exit, 0);
1607 	}
1608 	close(pipefd[1]);
1609 	prctl(PR_SET_PTRACER, tracer_pid, 0, 0, 0);
1610 	read(pipefd[0], &sync, 1);
1611 	close(pipefd[0]);
1612 
1613 	return tracer_pid;
1614 }
1615 
teardown_trace_fixture(struct __test_metadata * _metadata,pid_t tracer)1616 void teardown_trace_fixture(struct __test_metadata *_metadata,
1617 			    pid_t tracer)
1618 {
1619 	if (tracer) {
1620 		int status;
1621 		ASSERT_EQ(0, kill(tracer, SIGUSR1));
1622 		ASSERT_EQ(tracer, waitpid(tracer, &status, 0));
1623 	}
1624 }
1625 
1626 /* "poke" tracer arguments and function. */
1627 struct tracer_args_poke_t {
1628 	unsigned long poke_addr;
1629 };
1630 
tracer_poke(struct __test_metadata * _metadata,pid_t tracee,int status,void * args)1631 void tracer_poke(struct __test_metadata *_metadata, pid_t tracee, int status,
1632 		 void *args)
1633 {
1634 	int ret;
1635 	unsigned long msg;
1636 	struct tracer_args_poke_t *info = (struct tracer_args_poke_t *)args;
1637 
1638 	ret = ptrace(PTRACE_GETEVENTMSG, tracee, NULL, &msg);
1639 	EXPECT_EQ(0, ret);
1640 	/* If this fails, don't try to recover. */
1641 	ASSERT_EQ(0x1001, msg) {
1642 		kill(tracee, SIGKILL);
1643 	}
1644 	/*
1645 	 * Poke in the message.
1646 	 * Registers are not touched to try to keep this relatively arch
1647 	 * agnostic.
1648 	 */
1649 	ret = ptrace(PTRACE_POKEDATA, tracee, info->poke_addr, 0x1001);
1650 	EXPECT_EQ(0, ret);
1651 }
1652 
FIXTURE(TRACE_poke)1653 FIXTURE(TRACE_poke) {
1654 	struct sock_fprog prog;
1655 	pid_t tracer;
1656 	long poked;
1657 	struct tracer_args_poke_t tracer_args;
1658 };
1659 
FIXTURE_SETUP(TRACE_poke)1660 FIXTURE_SETUP(TRACE_poke)
1661 {
1662 	struct sock_filter filter[] = {
1663 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
1664 			offsetof(struct seccomp_data, nr)),
1665 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_read, 0, 1),
1666 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_TRACE | 0x1001),
1667 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
1668 	};
1669 
1670 	self->poked = 0;
1671 	memset(&self->prog, 0, sizeof(self->prog));
1672 	self->prog.filter = malloc(sizeof(filter));
1673 	ASSERT_NE(NULL, self->prog.filter);
1674 	memcpy(self->prog.filter, filter, sizeof(filter));
1675 	self->prog.len = (unsigned short)ARRAY_SIZE(filter);
1676 
1677 	/* Set up tracer args. */
1678 	self->tracer_args.poke_addr = (unsigned long)&self->poked;
1679 
1680 	/* Launch tracer. */
1681 	self->tracer = setup_trace_fixture(_metadata, tracer_poke,
1682 					   &self->tracer_args, false);
1683 }
1684 
FIXTURE_TEARDOWN(TRACE_poke)1685 FIXTURE_TEARDOWN(TRACE_poke)
1686 {
1687 	teardown_trace_fixture(_metadata, self->tracer);
1688 	if (self->prog.filter)
1689 		free(self->prog.filter);
1690 }
1691 
TEST_F(TRACE_poke,read_has_side_effects)1692 TEST_F(TRACE_poke, read_has_side_effects)
1693 {
1694 	ssize_t ret;
1695 
1696 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1697 	ASSERT_EQ(0, ret);
1698 
1699 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->prog, 0, 0);
1700 	ASSERT_EQ(0, ret);
1701 
1702 	EXPECT_EQ(0, self->poked);
1703 	ret = read(-1, NULL, 0);
1704 	EXPECT_EQ(-1, ret);
1705 	EXPECT_EQ(0x1001, self->poked);
1706 }
1707 
TEST_F(TRACE_poke,getpid_runs_normally)1708 TEST_F(TRACE_poke, getpid_runs_normally)
1709 {
1710 	long ret;
1711 
1712 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
1713 	ASSERT_EQ(0, ret);
1714 
1715 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &self->prog, 0, 0);
1716 	ASSERT_EQ(0, ret);
1717 
1718 	EXPECT_EQ(0, self->poked);
1719 	EXPECT_NE(0, syscall(__NR_getpid));
1720 	EXPECT_EQ(0, self->poked);
1721 }
1722 
1723 #if defined(__x86_64__)
1724 # define ARCH_REGS		struct user_regs_struct
1725 # define SYSCALL_NUM(_regs)	(_regs).orig_rax
1726 # define SYSCALL_RET(_regs)	(_regs).rax
1727 #elif defined(__i386__)
1728 # define ARCH_REGS		struct user_regs_struct
1729 # define SYSCALL_NUM(_regs)	(_regs).orig_eax
1730 # define SYSCALL_RET(_regs)	(_regs).eax
1731 #elif defined(__arm__)
1732 # define ARCH_REGS		struct pt_regs
1733 # define SYSCALL_NUM(_regs)	(_regs).ARM_r7
1734 # ifndef PTRACE_SET_SYSCALL
1735 #  define PTRACE_SET_SYSCALL   23
1736 # endif
1737 # define SYSCALL_NUM_SET(_regs, _nr)	\
1738 		EXPECT_EQ(0, ptrace(PTRACE_SET_SYSCALL, tracee, NULL, _nr))
1739 # define SYSCALL_RET(_regs)	(_regs).ARM_r0
1740 #elif defined(__aarch64__)
1741 # define ARCH_REGS		struct user_pt_regs
1742 # define SYSCALL_NUM(_regs)	(_regs).regs[8]
1743 # ifndef NT_ARM_SYSTEM_CALL
1744 #  define NT_ARM_SYSTEM_CALL 0x404
1745 # endif
1746 # define SYSCALL_NUM_SET(_regs, _nr)				\
1747 	do {							\
1748 		struct iovec __v;				\
1749 		typeof(_nr) __nr = (_nr);			\
1750 		__v.iov_base = &__nr;				\
1751 		__v.iov_len = sizeof(__nr);			\
1752 		EXPECT_EQ(0, ptrace(PTRACE_SETREGSET, tracee,	\
1753 				    NT_ARM_SYSTEM_CALL, &__v));	\
1754 	} while (0)
1755 # define SYSCALL_RET(_regs)	(_regs).regs[0]
1756 #elif defined(__loongarch__)
1757 # define ARCH_REGS		struct user_pt_regs
1758 # define SYSCALL_NUM(_regs)	(_regs).regs[11]
1759 # define SYSCALL_RET(_regs)	(_regs).regs[4]
1760 #elif defined(__riscv) && __riscv_xlen == 64
1761 # define ARCH_REGS		struct user_regs_struct
1762 # define SYSCALL_NUM(_regs)	(_regs).a7
1763 # define SYSCALL_RET(_regs)	(_regs).a0
1764 #elif defined(__csky__)
1765 # define ARCH_REGS		struct pt_regs
1766 #  if defined(__CSKYABIV2__)
1767 #   define SYSCALL_NUM(_regs)	(_regs).regs[3]
1768 #  else
1769 #   define SYSCALL_NUM(_regs)	(_regs).regs[9]
1770 #  endif
1771 # define SYSCALL_RET(_regs)	(_regs).a0
1772 #elif defined(__hppa__)
1773 # define ARCH_REGS		struct user_regs_struct
1774 # define SYSCALL_NUM(_regs)	(_regs).gr[20]
1775 # define SYSCALL_RET(_regs)	(_regs).gr[28]
1776 #elif defined(__powerpc__)
1777 # define ARCH_REGS		struct pt_regs
1778 # define SYSCALL_NUM(_regs)	(_regs).gpr[0]
1779 # define SYSCALL_RET(_regs)	(_regs).gpr[3]
1780 # define SYSCALL_RET_SET(_regs, _val)				\
1781 	do {							\
1782 		typeof(_val) _result = (_val);			\
1783 		if ((_regs.trap & 0xfff0) == 0x3000) {		\
1784 			/*					\
1785 			 * scv 0 system call uses -ve result	\
1786 			 * for error, so no need to adjust.	\
1787 			 */					\
1788 			SYSCALL_RET(_regs) = _result;		\
1789 		} else {					\
1790 			/*					\
1791 			 * A syscall error is signaled by the	\
1792 			 * CR0 SO bit and the code is stored as	\
1793 			 * a positive value.			\
1794 			 */					\
1795 			if (_result < 0) {			\
1796 				SYSCALL_RET(_regs) = -_result;	\
1797 				(_regs).ccr |= 0x10000000;	\
1798 			} else {				\
1799 				SYSCALL_RET(_regs) = _result;	\
1800 				(_regs).ccr &= ~0x10000000;	\
1801 			}					\
1802 		}						\
1803 	} while (0)
1804 # define SYSCALL_RET_SET_ON_PTRACE_EXIT
1805 #elif defined(__s390__)
1806 # define ARCH_REGS		s390_regs
1807 # define SYSCALL_NUM(_regs)	(_regs).gprs[2]
1808 # define SYSCALL_RET_SET(_regs, _val)			\
1809 		TH_LOG("Can't modify syscall return on this architecture")
1810 #elif defined(__mips__)
1811 # include <asm/unistd_nr_n32.h>
1812 # include <asm/unistd_nr_n64.h>
1813 # include <asm/unistd_nr_o32.h>
1814 # define ARCH_REGS		struct pt_regs
1815 # define SYSCALL_NUM(_regs)				\
1816 	({						\
1817 		typeof((_regs).regs[2]) _nr;		\
1818 		if ((_regs).regs[2] == __NR_O32_Linux)	\
1819 			_nr = (_regs).regs[4];		\
1820 		else					\
1821 			_nr = (_regs).regs[2];		\
1822 		_nr;					\
1823 	})
1824 # define SYSCALL_NUM_SET(_regs, _nr)			\
1825 	do {						\
1826 		if ((_regs).regs[2] == __NR_O32_Linux)	\
1827 			(_regs).regs[4] = _nr;		\
1828 		else					\
1829 			(_regs).regs[2] = _nr;		\
1830 	} while (0)
1831 # define SYSCALL_RET_SET(_regs, _val)			\
1832 		TH_LOG("Can't modify syscall return on this architecture")
1833 #elif defined(__xtensa__)
1834 # define ARCH_REGS		struct user_pt_regs
1835 # define SYSCALL_NUM(_regs)	(_regs).syscall
1836 /*
1837  * On xtensa syscall return value is in the register
1838  * a2 of the current window which is not fixed.
1839  */
1840 #define SYSCALL_RET(_regs)	(_regs).a[(_regs).windowbase * 4 + 2]
1841 #elif defined(__sh__)
1842 # define ARCH_REGS		struct pt_regs
1843 # define SYSCALL_NUM(_regs)	(_regs).regs[3]
1844 # define SYSCALL_RET(_regs)	(_regs).regs[0]
1845 #elif defined(__mc68000__)
1846 # define ARCH_REGS		struct user_regs_struct
1847 # define SYSCALL_NUM(_regs)	(_regs).orig_d0
1848 # define SYSCALL_RET(_regs)	(_regs).d0
1849 #else
1850 # error "Do not know how to find your architecture's registers and syscalls"
1851 #endif
1852 
1853 /*
1854  * Most architectures can change the syscall by just updating the
1855  * associated register. This is the default if not defined above.
1856  */
1857 #ifndef SYSCALL_NUM_SET
1858 # define SYSCALL_NUM_SET(_regs, _nr)		\
1859 	do {					\
1860 		SYSCALL_NUM(_regs) = (_nr);	\
1861 	} while (0)
1862 #endif
1863 /*
1864  * Most architectures can change the syscall return value by just
1865  * writing to the SYSCALL_RET register. This is the default if not
1866  * defined above. If an architecture cannot set the return value
1867  * (for example when the syscall and return value register is
1868  * shared), report it with TH_LOG() in an arch-specific definition
1869  * of SYSCALL_RET_SET() above, and leave SYSCALL_RET undefined.
1870  */
1871 #if !defined(SYSCALL_RET) && !defined(SYSCALL_RET_SET)
1872 # error "One of SYSCALL_RET or SYSCALL_RET_SET is needed for this arch"
1873 #endif
1874 #ifndef SYSCALL_RET_SET
1875 # define SYSCALL_RET_SET(_regs, _val)		\
1876 	do {					\
1877 		SYSCALL_RET(_regs) = (_val);	\
1878 	} while (0)
1879 #endif
1880 
1881 /* When the syscall return can't be changed, stub out the tests for it. */
1882 #ifndef SYSCALL_RET
1883 # define EXPECT_SYSCALL_RETURN(val, action)	EXPECT_EQ(-1, action)
1884 #else
1885 # define EXPECT_SYSCALL_RETURN(val, action)		\
1886 	do {						\
1887 		errno = 0;				\
1888 		if (val < 0) {				\
1889 			EXPECT_EQ(-1, action);		\
1890 			EXPECT_EQ(-(val), errno);	\
1891 		} else {				\
1892 			EXPECT_EQ(val, action);		\
1893 		}					\
1894 	} while (0)
1895 #endif
1896 
1897 /*
1898  * Some architectures (e.g. powerpc) can only set syscall
1899  * return values on syscall exit during ptrace.
1900  */
1901 const bool ptrace_entry_set_syscall_nr = true;
1902 const bool ptrace_entry_set_syscall_ret =
1903 #ifndef SYSCALL_RET_SET_ON_PTRACE_EXIT
1904 	true;
1905 #else
1906 	false;
1907 #endif
1908 
1909 /*
1910  * Use PTRACE_GETREGS and PTRACE_SETREGS when available. This is useful for
1911  * architectures without HAVE_ARCH_TRACEHOOK (e.g. User-mode Linux).
1912  */
1913 #if defined(__x86_64__) || defined(__i386__) || defined(__mips__) || defined(__mc68000__)
1914 # define ARCH_GETREGS(_regs)	ptrace(PTRACE_GETREGS, tracee, 0, &(_regs))
1915 # define ARCH_SETREGS(_regs)	ptrace(PTRACE_SETREGS, tracee, 0, &(_regs))
1916 #else
1917 # define ARCH_GETREGS(_regs)	({					\
1918 		struct iovec __v;					\
1919 		__v.iov_base = &(_regs);				\
1920 		__v.iov_len = sizeof(_regs);				\
1921 		ptrace(PTRACE_GETREGSET, tracee, NT_PRSTATUS, &__v);	\
1922 	})
1923 # define ARCH_SETREGS(_regs)	({					\
1924 		struct iovec __v;					\
1925 		__v.iov_base = &(_regs);				\
1926 		__v.iov_len = sizeof(_regs);				\
1927 		ptrace(PTRACE_SETREGSET, tracee, NT_PRSTATUS, &__v);	\
1928 	})
1929 #endif
1930 
1931 /* Architecture-specific syscall fetching routine. */
get_syscall(struct __test_metadata * _metadata,pid_t tracee)1932 int get_syscall(struct __test_metadata *_metadata, pid_t tracee)
1933 {
1934 	ARCH_REGS regs;
1935 
1936 	EXPECT_EQ(0, ARCH_GETREGS(regs)) {
1937 		return -1;
1938 	}
1939 
1940 	return SYSCALL_NUM(regs);
1941 }
1942 
1943 /* Architecture-specific syscall changing routine. */
__change_syscall(struct __test_metadata * _metadata,pid_t tracee,long * syscall,long * ret)1944 void __change_syscall(struct __test_metadata *_metadata,
1945 		    pid_t tracee, long *syscall, long *ret)
1946 {
1947 	ARCH_REGS orig, regs;
1948 
1949 	/* Do not get/set registers if we have nothing to do. */
1950 	if (!syscall && !ret)
1951 		return;
1952 
1953 	EXPECT_EQ(0, ARCH_GETREGS(regs)) {
1954 		return;
1955 	}
1956 	orig = regs;
1957 
1958 	if (syscall)
1959 		SYSCALL_NUM_SET(regs, *syscall);
1960 
1961 	if (ret)
1962 		SYSCALL_RET_SET(regs, *ret);
1963 
1964 	/* Flush any register changes made. */
1965 	if (memcmp(&orig, &regs, sizeof(orig)) != 0)
1966 		EXPECT_EQ(0, ARCH_SETREGS(regs));
1967 }
1968 
1969 /* Change only syscall number. */
change_syscall_nr(struct __test_metadata * _metadata,pid_t tracee,long syscall)1970 void change_syscall_nr(struct __test_metadata *_metadata,
1971 		       pid_t tracee, long syscall)
1972 {
1973 	__change_syscall(_metadata, tracee, &syscall, NULL);
1974 }
1975 
1976 /* Change syscall return value (and set syscall number to -1). */
change_syscall_ret(struct __test_metadata * _metadata,pid_t tracee,long ret)1977 void change_syscall_ret(struct __test_metadata *_metadata,
1978 			pid_t tracee, long ret)
1979 {
1980 	long syscall = -1;
1981 
1982 	__change_syscall(_metadata, tracee, &syscall, &ret);
1983 }
1984 
tracer_seccomp(struct __test_metadata * _metadata,pid_t tracee,int status,void * args)1985 void tracer_seccomp(struct __test_metadata *_metadata, pid_t tracee,
1986 		    int status, void *args)
1987 {
1988 	int ret;
1989 	unsigned long msg;
1990 
1991 	EXPECT_EQ(PTRACE_EVENT_MASK(status), PTRACE_EVENT_SECCOMP) {
1992 		TH_LOG("Unexpected ptrace event: %d", PTRACE_EVENT_MASK(status));
1993 		return;
1994 	}
1995 
1996 	/* Make sure we got the right message. */
1997 	ret = ptrace(PTRACE_GETEVENTMSG, tracee, NULL, &msg);
1998 	EXPECT_EQ(0, ret);
1999 
2000 	/* Validate and take action on expected syscalls. */
2001 	switch (msg) {
2002 	case 0x1002:
2003 		/* change getpid to getppid. */
2004 		EXPECT_EQ(__NR_getpid, get_syscall(_metadata, tracee));
2005 		change_syscall_nr(_metadata, tracee, __NR_getppid);
2006 		break;
2007 	case 0x1003:
2008 		/* skip gettid with valid return code. */
2009 		EXPECT_EQ(__NR_gettid, get_syscall(_metadata, tracee));
2010 		change_syscall_ret(_metadata, tracee, 45000);
2011 		break;
2012 	case 0x1004:
2013 		/* skip openat with error. */
2014 		EXPECT_EQ(__NR_openat, get_syscall(_metadata, tracee));
2015 		change_syscall_ret(_metadata, tracee, -ESRCH);
2016 		break;
2017 	case 0x1005:
2018 		/* do nothing (allow getppid) */
2019 		EXPECT_EQ(__NR_getppid, get_syscall(_metadata, tracee));
2020 		break;
2021 	default:
2022 		EXPECT_EQ(0, msg) {
2023 			TH_LOG("Unknown PTRACE_GETEVENTMSG: 0x%lx", msg);
2024 			kill(tracee, SIGKILL);
2025 		}
2026 	}
2027 
2028 }
2029 
FIXTURE(TRACE_syscall)2030 FIXTURE(TRACE_syscall) {
2031 	struct sock_fprog prog;
2032 	pid_t tracer, mytid, mypid, parent;
2033 	long syscall_nr;
2034 };
2035 
tracer_ptrace(struct __test_metadata * _metadata,pid_t tracee,int status,void * args)2036 void tracer_ptrace(struct __test_metadata *_metadata, pid_t tracee,
2037 		   int status, void *args)
2038 {
2039 	int ret;
2040 	unsigned long msg;
2041 	static bool entry;
2042 	long syscall_nr_val, syscall_ret_val;
2043 	long *syscall_nr = NULL, *syscall_ret = NULL;
2044 	FIXTURE_DATA(TRACE_syscall) *self = args;
2045 
2046 	EXPECT_EQ(WSTOPSIG(status) & 0x80, 0x80) {
2047 		TH_LOG("Unexpected WSTOPSIG: %d", WSTOPSIG(status));
2048 		return;
2049 	}
2050 
2051 	/*
2052 	 * The traditional way to tell PTRACE_SYSCALL entry/exit
2053 	 * is by counting.
2054 	 */
2055 	entry = !entry;
2056 
2057 	/* Make sure we got an appropriate message. */
2058 	ret = ptrace(PTRACE_GETEVENTMSG, tracee, NULL, &msg);
2059 	EXPECT_EQ(0, ret);
2060 	EXPECT_EQ(entry ? PTRACE_EVENTMSG_SYSCALL_ENTRY
2061 			: PTRACE_EVENTMSG_SYSCALL_EXIT, msg);
2062 
2063 	/*
2064 	 * Some architectures only support setting return values during
2065 	 * syscall exit under ptrace, and on exit the syscall number may
2066 	 * no longer be available. Therefore, save the initial sycall
2067 	 * number here, so it can be examined during both entry and exit
2068 	 * phases.
2069 	 */
2070 	if (entry)
2071 		self->syscall_nr = get_syscall(_metadata, tracee);
2072 
2073 	/*
2074 	 * Depending on the architecture's syscall setting abilities, we
2075 	 * pick which things to set during this phase (entry or exit).
2076 	 */
2077 	if (entry == ptrace_entry_set_syscall_nr)
2078 		syscall_nr = &syscall_nr_val;
2079 	if (entry == ptrace_entry_set_syscall_ret)
2080 		syscall_ret = &syscall_ret_val;
2081 
2082 	/* Now handle the actual rewriting cases. */
2083 	switch (self->syscall_nr) {
2084 	case __NR_getpid:
2085 		syscall_nr_val = __NR_getppid;
2086 		/* Never change syscall return for this case. */
2087 		syscall_ret = NULL;
2088 		break;
2089 	case __NR_gettid:
2090 		syscall_nr_val = -1;
2091 		syscall_ret_val = 45000;
2092 		break;
2093 	case __NR_openat:
2094 		syscall_nr_val = -1;
2095 		syscall_ret_val = -ESRCH;
2096 		break;
2097 	default:
2098 		/* Unhandled, do nothing. */
2099 		return;
2100 	}
2101 
2102 	__change_syscall(_metadata, tracee, syscall_nr, syscall_ret);
2103 }
2104 
FIXTURE_VARIANT(TRACE_syscall)2105 FIXTURE_VARIANT(TRACE_syscall) {
2106 	/*
2107 	 * All of the SECCOMP_RET_TRACE behaviors can be tested with either
2108 	 * SECCOMP_RET_TRACE+PTRACE_CONT or plain ptrace()+PTRACE_SYSCALL.
2109 	 * This indicates if we should use SECCOMP_RET_TRACE (false), or
2110 	 * ptrace (true).
2111 	 */
2112 	bool use_ptrace;
2113 };
2114 
FIXTURE_VARIANT_ADD(TRACE_syscall,ptrace)2115 FIXTURE_VARIANT_ADD(TRACE_syscall, ptrace) {
2116 	.use_ptrace = true,
2117 };
2118 
FIXTURE_VARIANT_ADD(TRACE_syscall,seccomp)2119 FIXTURE_VARIANT_ADD(TRACE_syscall, seccomp) {
2120 	.use_ptrace = false,
2121 };
2122 
FIXTURE_SETUP(TRACE_syscall)2123 FIXTURE_SETUP(TRACE_syscall)
2124 {
2125 	struct sock_filter filter[] = {
2126 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
2127 			offsetof(struct seccomp_data, nr)),
2128 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getpid, 0, 1),
2129 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_TRACE | 0x1002),
2130 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_gettid, 0, 1),
2131 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_TRACE | 0x1003),
2132 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_openat, 0, 1),
2133 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_TRACE | 0x1004),
2134 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getppid, 0, 1),
2135 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_TRACE | 0x1005),
2136 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
2137 	};
2138 	struct sock_fprog prog = {
2139 		.len = (unsigned short)ARRAY_SIZE(filter),
2140 		.filter = filter,
2141 	};
2142 	long ret;
2143 
2144 	/* Prepare some testable syscall results. */
2145 	self->mytid = syscall(__NR_gettid);
2146 	ASSERT_GT(self->mytid, 0);
2147 	ASSERT_NE(self->mytid, 1) {
2148 		TH_LOG("Running this test as init is not supported. :)");
2149 	}
2150 
2151 	self->mypid = getpid();
2152 	ASSERT_GT(self->mypid, 0);
2153 	ASSERT_EQ(self->mytid, self->mypid);
2154 
2155 	self->parent = getppid();
2156 	ASSERT_GT(self->parent, 0);
2157 	ASSERT_NE(self->parent, self->mypid);
2158 
2159 	/* Launch tracer. */
2160 	self->tracer = setup_trace_fixture(_metadata,
2161 					   variant->use_ptrace ? tracer_ptrace
2162 							       : tracer_seccomp,
2163 					   self, variant->use_ptrace);
2164 
2165 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
2166 	ASSERT_EQ(0, ret);
2167 
2168 	/* Do not install seccomp rewrite filters, as we'll use ptrace instead. */
2169 	if (variant->use_ptrace)
2170 		return;
2171 
2172 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
2173 	ASSERT_EQ(0, ret);
2174 }
2175 
FIXTURE_TEARDOWN(TRACE_syscall)2176 FIXTURE_TEARDOWN(TRACE_syscall)
2177 {
2178 	teardown_trace_fixture(_metadata, self->tracer);
2179 }
2180 
TEST(negative_ENOSYS)2181 TEST(negative_ENOSYS)
2182 {
2183 #if defined(__arm__)
2184 	SKIP(return, "arm32 does not support calling syscall -1");
2185 #endif
2186 	/*
2187 	 * There should be no difference between an "internal" skip
2188 	 * and userspace asking for syscall "-1".
2189 	 */
2190 	errno = 0;
2191 	EXPECT_EQ(-1, syscall(-1));
2192 	EXPECT_EQ(errno, ENOSYS);
2193 	/* And no difference for "still not valid but not -1". */
2194 	errno = 0;
2195 	EXPECT_EQ(-1, syscall(-101));
2196 	EXPECT_EQ(errno, ENOSYS);
2197 }
2198 
TEST_F(TRACE_syscall,negative_ENOSYS)2199 TEST_F(TRACE_syscall, negative_ENOSYS)
2200 {
2201 	negative_ENOSYS(_metadata);
2202 }
2203 
TEST_F(TRACE_syscall,syscall_allowed)2204 TEST_F(TRACE_syscall, syscall_allowed)
2205 {
2206 	/* getppid works as expected (no changes). */
2207 	EXPECT_EQ(self->parent, syscall(__NR_getppid));
2208 	EXPECT_NE(self->mypid, syscall(__NR_getppid));
2209 }
2210 
TEST_F(TRACE_syscall,syscall_redirected)2211 TEST_F(TRACE_syscall, syscall_redirected)
2212 {
2213 	/* getpid has been redirected to getppid as expected. */
2214 	EXPECT_EQ(self->parent, syscall(__NR_getpid));
2215 	EXPECT_NE(self->mypid, syscall(__NR_getpid));
2216 }
2217 
TEST_F(TRACE_syscall,syscall_errno)2218 TEST_F(TRACE_syscall, syscall_errno)
2219 {
2220 	/* Tracer should skip the open syscall, resulting in ESRCH. */
2221 	EXPECT_SYSCALL_RETURN(-ESRCH, syscall(__NR_openat));
2222 }
2223 
TEST_F(TRACE_syscall,syscall_faked)2224 TEST_F(TRACE_syscall, syscall_faked)
2225 {
2226 	/* Tracer skips the gettid syscall and store altered return value. */
2227 	EXPECT_SYSCALL_RETURN(45000, syscall(__NR_gettid));
2228 }
2229 
TEST_F_SIGNAL(TRACE_syscall,kill_immediate,SIGSYS)2230 TEST_F_SIGNAL(TRACE_syscall, kill_immediate, SIGSYS)
2231 {
2232 	struct sock_filter filter[] = {
2233 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
2234 			offsetof(struct seccomp_data, nr)),
2235 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_mknodat, 0, 1),
2236 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_KILL_THREAD),
2237 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
2238 	};
2239 	struct sock_fprog prog = {
2240 		.len = (unsigned short)ARRAY_SIZE(filter),
2241 		.filter = filter,
2242 	};
2243 	long ret;
2244 
2245 	/* Install "kill on mknodat" filter. */
2246 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
2247 	ASSERT_EQ(0, ret);
2248 
2249 	/* This should immediately die with SIGSYS, regardless of tracer. */
2250 	EXPECT_EQ(-1, syscall(__NR_mknodat, -1, NULL, 0, 0));
2251 }
2252 
TEST_F(TRACE_syscall,skip_after)2253 TEST_F(TRACE_syscall, skip_after)
2254 {
2255 	struct sock_filter filter[] = {
2256 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
2257 			offsetof(struct seccomp_data, nr)),
2258 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getppid, 0, 1),
2259 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ERRNO | EPERM),
2260 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
2261 	};
2262 	struct sock_fprog prog = {
2263 		.len = (unsigned short)ARRAY_SIZE(filter),
2264 		.filter = filter,
2265 	};
2266 	long ret;
2267 
2268 	/* Install additional "errno on getppid" filter. */
2269 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
2270 	ASSERT_EQ(0, ret);
2271 
2272 	/* Tracer will redirect getpid to getppid, and we should see EPERM. */
2273 	errno = 0;
2274 	EXPECT_EQ(-1, syscall(__NR_getpid));
2275 	EXPECT_EQ(EPERM, errno);
2276 }
2277 
TEST_F_SIGNAL(TRACE_syscall,kill_after,SIGSYS)2278 TEST_F_SIGNAL(TRACE_syscall, kill_after, SIGSYS)
2279 {
2280 	struct sock_filter filter[] = {
2281 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
2282 			offsetof(struct seccomp_data, nr)),
2283 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getppid, 0, 1),
2284 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_KILL),
2285 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
2286 	};
2287 	struct sock_fprog prog = {
2288 		.len = (unsigned short)ARRAY_SIZE(filter),
2289 		.filter = filter,
2290 	};
2291 	long ret;
2292 
2293 	/* Install additional "death on getppid" filter. */
2294 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
2295 	ASSERT_EQ(0, ret);
2296 
2297 	/* Tracer will redirect getpid to getppid, and we should die. */
2298 	EXPECT_NE(self->mypid, syscall(__NR_getpid));
2299 }
2300 
TEST(seccomp_syscall)2301 TEST(seccomp_syscall)
2302 {
2303 	struct sock_filter filter[] = {
2304 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
2305 	};
2306 	struct sock_fprog prog = {
2307 		.len = (unsigned short)ARRAY_SIZE(filter),
2308 		.filter = filter,
2309 	};
2310 	long ret;
2311 
2312 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
2313 	ASSERT_EQ(0, ret) {
2314 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
2315 	}
2316 
2317 	/* Reject insane operation. */
2318 	ret = seccomp(-1, 0, &prog);
2319 	ASSERT_NE(ENOSYS, errno) {
2320 		TH_LOG("Kernel does not support seccomp syscall!");
2321 	}
2322 	EXPECT_EQ(EINVAL, errno) {
2323 		TH_LOG("Did not reject crazy op value!");
2324 	}
2325 
2326 	/* Reject strict with flags or pointer. */
2327 	ret = seccomp(SECCOMP_SET_MODE_STRICT, -1, NULL);
2328 	EXPECT_EQ(EINVAL, errno) {
2329 		TH_LOG("Did not reject mode strict with flags!");
2330 	}
2331 	ret = seccomp(SECCOMP_SET_MODE_STRICT, 0, &prog);
2332 	EXPECT_EQ(EINVAL, errno) {
2333 		TH_LOG("Did not reject mode strict with uargs!");
2334 	}
2335 
2336 	/* Reject insane args for filter. */
2337 	ret = seccomp(SECCOMP_SET_MODE_FILTER, -1, &prog);
2338 	EXPECT_EQ(EINVAL, errno) {
2339 		TH_LOG("Did not reject crazy filter flags!");
2340 	}
2341 	ret = seccomp(SECCOMP_SET_MODE_FILTER, 0, NULL);
2342 	EXPECT_EQ(EFAULT, errno) {
2343 		TH_LOG("Did not reject NULL filter!");
2344 	}
2345 
2346 	ret = seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog);
2347 	EXPECT_EQ(0, errno) {
2348 		TH_LOG("Kernel does not support SECCOMP_SET_MODE_FILTER: %s",
2349 			strerror(errno));
2350 	}
2351 }
2352 
TEST(seccomp_syscall_mode_lock)2353 TEST(seccomp_syscall_mode_lock)
2354 {
2355 	struct sock_filter filter[] = {
2356 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
2357 	};
2358 	struct sock_fprog prog = {
2359 		.len = (unsigned short)ARRAY_SIZE(filter),
2360 		.filter = filter,
2361 	};
2362 	long ret;
2363 
2364 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, NULL, 0, 0);
2365 	ASSERT_EQ(0, ret) {
2366 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
2367 	}
2368 
2369 	ret = seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog);
2370 	ASSERT_NE(ENOSYS, errno) {
2371 		TH_LOG("Kernel does not support seccomp syscall!");
2372 	}
2373 	EXPECT_EQ(0, ret) {
2374 		TH_LOG("Could not install filter!");
2375 	}
2376 
2377 	/* Make sure neither entry point will switch to strict. */
2378 	ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_STRICT, 0, 0, 0);
2379 	EXPECT_EQ(EINVAL, errno) {
2380 		TH_LOG("Switched to mode strict!");
2381 	}
2382 
2383 	ret = seccomp(SECCOMP_SET_MODE_STRICT, 0, NULL);
2384 	EXPECT_EQ(EINVAL, errno) {
2385 		TH_LOG("Switched to mode strict!");
2386 	}
2387 }
2388 
2389 /*
2390  * Test detection of known and unknown filter flags. Userspace needs to be able
2391  * to check if a filter flag is supported by the current kernel and a good way
2392  * of doing that is by attempting to enter filter mode, with the flag bit in
2393  * question set, and a NULL pointer for the _args_ parameter. EFAULT indicates
2394  * that the flag is valid and EINVAL indicates that the flag is invalid.
2395  */
TEST(detect_seccomp_filter_flags)2396 TEST(detect_seccomp_filter_flags)
2397 {
2398 	unsigned int flags[] = { SECCOMP_FILTER_FLAG_TSYNC,
2399 				 SECCOMP_FILTER_FLAG_LOG,
2400 				 SECCOMP_FILTER_FLAG_SPEC_ALLOW,
2401 				 SECCOMP_FILTER_FLAG_NEW_LISTENER,
2402 				 SECCOMP_FILTER_FLAG_TSYNC_ESRCH };
2403 	unsigned int exclusive[] = {
2404 				SECCOMP_FILTER_FLAG_TSYNC,
2405 				SECCOMP_FILTER_FLAG_NEW_LISTENER };
2406 	unsigned int flag, all_flags, exclusive_mask;
2407 	int i;
2408 	long ret;
2409 
2410 	/* Test detection of individual known-good filter flags */
2411 	for (i = 0, all_flags = 0; i < ARRAY_SIZE(flags); i++) {
2412 		int bits = 0;
2413 
2414 		flag = flags[i];
2415 		/* Make sure the flag is a single bit! */
2416 		while (flag) {
2417 			if (flag & 0x1)
2418 				bits ++;
2419 			flag >>= 1;
2420 		}
2421 		ASSERT_EQ(1, bits);
2422 		flag = flags[i];
2423 
2424 		ret = seccomp(SECCOMP_SET_MODE_FILTER, flag, NULL);
2425 		ASSERT_NE(ENOSYS, errno) {
2426 			TH_LOG("Kernel does not support seccomp syscall!");
2427 		}
2428 		EXPECT_EQ(-1, ret);
2429 		EXPECT_EQ(EFAULT, errno) {
2430 			TH_LOG("Failed to detect that a known-good filter flag (0x%X) is supported!",
2431 			       flag);
2432 		}
2433 
2434 		all_flags |= flag;
2435 	}
2436 
2437 	/*
2438 	 * Test detection of all known-good filter flags combined. But
2439 	 * for the exclusive flags we need to mask them out and try them
2440 	 * individually for the "all flags" testing.
2441 	 */
2442 	exclusive_mask = 0;
2443 	for (i = 0; i < ARRAY_SIZE(exclusive); i++)
2444 		exclusive_mask |= exclusive[i];
2445 	for (i = 0; i < ARRAY_SIZE(exclusive); i++) {
2446 		flag = all_flags & ~exclusive_mask;
2447 		flag |= exclusive[i];
2448 
2449 		ret = seccomp(SECCOMP_SET_MODE_FILTER, flag, NULL);
2450 		EXPECT_EQ(-1, ret);
2451 		EXPECT_EQ(EFAULT, errno) {
2452 			TH_LOG("Failed to detect that all known-good filter flags (0x%X) are supported!",
2453 			       flag);
2454 		}
2455 	}
2456 
2457 	/* Test detection of an unknown filter flags, without exclusives. */
2458 	flag = -1;
2459 	flag &= ~exclusive_mask;
2460 	ret = seccomp(SECCOMP_SET_MODE_FILTER, flag, NULL);
2461 	EXPECT_EQ(-1, ret);
2462 	EXPECT_EQ(EINVAL, errno) {
2463 		TH_LOG("Failed to detect that an unknown filter flag (0x%X) is unsupported!",
2464 		       flag);
2465 	}
2466 
2467 	/*
2468 	 * Test detection of an unknown filter flag that may simply need to be
2469 	 * added to this test
2470 	 */
2471 	flag = flags[ARRAY_SIZE(flags) - 1] << 1;
2472 	ret = seccomp(SECCOMP_SET_MODE_FILTER, flag, NULL);
2473 	EXPECT_EQ(-1, ret);
2474 	EXPECT_EQ(EINVAL, errno) {
2475 		TH_LOG("Failed to detect that an unknown filter flag (0x%X) is unsupported! Does a new flag need to be added to this test?",
2476 		       flag);
2477 	}
2478 }
2479 
TEST(TSYNC_first)2480 TEST(TSYNC_first)
2481 {
2482 	struct sock_filter filter[] = {
2483 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
2484 	};
2485 	struct sock_fprog prog = {
2486 		.len = (unsigned short)ARRAY_SIZE(filter),
2487 		.filter = filter,
2488 	};
2489 	long ret;
2490 
2491 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, NULL, 0, 0);
2492 	ASSERT_EQ(0, ret) {
2493 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
2494 	}
2495 
2496 	ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
2497 		      &prog);
2498 	ASSERT_NE(ENOSYS, errno) {
2499 		TH_LOG("Kernel does not support seccomp syscall!");
2500 	}
2501 	EXPECT_EQ(0, ret) {
2502 		TH_LOG("Could not install initial filter with TSYNC!");
2503 	}
2504 }
2505 
2506 #define TSYNC_SIBLINGS 2
2507 struct tsync_sibling {
2508 	pthread_t tid;
2509 	pid_t system_tid;
2510 	sem_t *started;
2511 	pthread_cond_t *cond;
2512 	pthread_mutex_t *mutex;
2513 	int diverge;
2514 	int num_waits;
2515 	struct sock_fprog *prog;
2516 	struct __test_metadata *metadata;
2517 };
2518 
2519 /*
2520  * To avoid joining joined threads (which is not allowed by Bionic),
2521  * make sure we both successfully join and clear the tid to skip a
2522  * later join attempt during fixture teardown. Any remaining threads
2523  * will be directly killed during teardown.
2524  */
2525 #define PTHREAD_JOIN(tid, status)					\
2526 	do {								\
2527 		int _rc = pthread_join(tid, status);			\
2528 		if (_rc) {						\
2529 			TH_LOG("pthread_join of tid %u failed: %d\n",	\
2530 				(unsigned int)tid, _rc);		\
2531 		} else {						\
2532 			tid = 0;					\
2533 		}							\
2534 	} while (0)
2535 
FIXTURE(TSYNC)2536 FIXTURE(TSYNC) {
2537 	struct sock_fprog root_prog, apply_prog;
2538 	struct tsync_sibling sibling[TSYNC_SIBLINGS];
2539 	sem_t started;
2540 	pthread_cond_t cond;
2541 	pthread_mutex_t mutex;
2542 	int sibling_count;
2543 };
2544 
FIXTURE_SETUP(TSYNC)2545 FIXTURE_SETUP(TSYNC)
2546 {
2547 	struct sock_filter root_filter[] = {
2548 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
2549 	};
2550 	struct sock_filter apply_filter[] = {
2551 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
2552 			offsetof(struct seccomp_data, nr)),
2553 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_read, 0, 1),
2554 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_KILL),
2555 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
2556 	};
2557 
2558 	memset(&self->root_prog, 0, sizeof(self->root_prog));
2559 	memset(&self->apply_prog, 0, sizeof(self->apply_prog));
2560 	memset(&self->sibling, 0, sizeof(self->sibling));
2561 	self->root_prog.filter = malloc(sizeof(root_filter));
2562 	ASSERT_NE(NULL, self->root_prog.filter);
2563 	memcpy(self->root_prog.filter, &root_filter, sizeof(root_filter));
2564 	self->root_prog.len = (unsigned short)ARRAY_SIZE(root_filter);
2565 
2566 	self->apply_prog.filter = malloc(sizeof(apply_filter));
2567 	ASSERT_NE(NULL, self->apply_prog.filter);
2568 	memcpy(self->apply_prog.filter, &apply_filter, sizeof(apply_filter));
2569 	self->apply_prog.len = (unsigned short)ARRAY_SIZE(apply_filter);
2570 
2571 	self->sibling_count = 0;
2572 	pthread_mutex_init(&self->mutex, NULL);
2573 	pthread_cond_init(&self->cond, NULL);
2574 	sem_init(&self->started, 0, 0);
2575 	self->sibling[0].tid = 0;
2576 	self->sibling[0].cond = &self->cond;
2577 	self->sibling[0].started = &self->started;
2578 	self->sibling[0].mutex = &self->mutex;
2579 	self->sibling[0].diverge = 0;
2580 	self->sibling[0].num_waits = 1;
2581 	self->sibling[0].prog = &self->root_prog;
2582 	self->sibling[0].metadata = _metadata;
2583 	self->sibling[1].tid = 0;
2584 	self->sibling[1].cond = &self->cond;
2585 	self->sibling[1].started = &self->started;
2586 	self->sibling[1].mutex = &self->mutex;
2587 	self->sibling[1].diverge = 0;
2588 	self->sibling[1].prog = &self->root_prog;
2589 	self->sibling[1].num_waits = 1;
2590 	self->sibling[1].metadata = _metadata;
2591 }
2592 
FIXTURE_TEARDOWN(TSYNC)2593 FIXTURE_TEARDOWN(TSYNC)
2594 {
2595 	int sib = 0;
2596 
2597 	if (self->root_prog.filter)
2598 		free(self->root_prog.filter);
2599 	if (self->apply_prog.filter)
2600 		free(self->apply_prog.filter);
2601 
2602 	for ( ; sib < self->sibling_count; ++sib) {
2603 		struct tsync_sibling *s = &self->sibling[sib];
2604 
2605 		if (!s->tid)
2606 			continue;
2607 		/*
2608 		 * If a thread is still running, it may be stuck, so hit
2609 		 * it over the head really hard.
2610 		 */
2611 		pthread_kill(s->tid, 9);
2612 	}
2613 	pthread_mutex_destroy(&self->mutex);
2614 	pthread_cond_destroy(&self->cond);
2615 	sem_destroy(&self->started);
2616 }
2617 
tsync_sibling(void * data)2618 void *tsync_sibling(void *data)
2619 {
2620 	long ret = 0;
2621 	struct tsync_sibling *me = data;
2622 
2623 	me->system_tid = syscall(__NR_gettid);
2624 
2625 	pthread_mutex_lock(me->mutex);
2626 	if (me->diverge) {
2627 		/* Just re-apply the root prog to fork the tree */
2628 		ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER,
2629 				me->prog, 0, 0);
2630 	}
2631 	sem_post(me->started);
2632 	/* Return outside of started so parent notices failures. */
2633 	if (ret) {
2634 		pthread_mutex_unlock(me->mutex);
2635 		return (void *)SIBLING_EXIT_FAILURE;
2636 	}
2637 	do {
2638 		pthread_cond_wait(me->cond, me->mutex);
2639 		me->num_waits = me->num_waits - 1;
2640 	} while (me->num_waits);
2641 	pthread_mutex_unlock(me->mutex);
2642 
2643 	ret = prctl(PR_GET_NO_NEW_PRIVS, 0, 0, 0, 0);
2644 	if (!ret)
2645 		return (void *)SIBLING_EXIT_NEWPRIVS;
2646 	read(-1, NULL, 0);
2647 	return (void *)SIBLING_EXIT_UNKILLED;
2648 }
2649 
tsync_start_sibling(struct tsync_sibling * sibling)2650 void tsync_start_sibling(struct tsync_sibling *sibling)
2651 {
2652 	pthread_create(&sibling->tid, NULL, tsync_sibling, (void *)sibling);
2653 }
2654 
TEST_F(TSYNC,siblings_fail_prctl)2655 TEST_F(TSYNC, siblings_fail_prctl)
2656 {
2657 	long ret;
2658 	void *status;
2659 	struct sock_filter filter[] = {
2660 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
2661 			offsetof(struct seccomp_data, nr)),
2662 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_prctl, 0, 1),
2663 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ERRNO | EINVAL),
2664 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
2665 	};
2666 	struct sock_fprog prog = {
2667 		.len = (unsigned short)ARRAY_SIZE(filter),
2668 		.filter = filter,
2669 	};
2670 
2671 	ASSERT_EQ(0, prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
2672 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
2673 	}
2674 
2675 	/* Check prctl failure detection by requesting sib 0 diverge. */
2676 	ret = seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog);
2677 	ASSERT_NE(ENOSYS, errno) {
2678 		TH_LOG("Kernel does not support seccomp syscall!");
2679 	}
2680 	ASSERT_EQ(0, ret) {
2681 		TH_LOG("setting filter failed");
2682 	}
2683 
2684 	self->sibling[0].diverge = 1;
2685 	tsync_start_sibling(&self->sibling[0]);
2686 	tsync_start_sibling(&self->sibling[1]);
2687 
2688 	while (self->sibling_count < TSYNC_SIBLINGS) {
2689 		sem_wait(&self->started);
2690 		self->sibling_count++;
2691 	}
2692 
2693 	/* Signal the threads to clean up*/
2694 	pthread_mutex_lock(&self->mutex);
2695 	ASSERT_EQ(0, pthread_cond_broadcast(&self->cond)) {
2696 		TH_LOG("cond broadcast non-zero");
2697 	}
2698 	pthread_mutex_unlock(&self->mutex);
2699 
2700 	/* Ensure diverging sibling failed to call prctl. */
2701 	PTHREAD_JOIN(self->sibling[0].tid, &status);
2702 	EXPECT_EQ(SIBLING_EXIT_FAILURE, (long)status);
2703 	PTHREAD_JOIN(self->sibling[1].tid, &status);
2704 	EXPECT_EQ(SIBLING_EXIT_UNKILLED, (long)status);
2705 }
2706 
TEST_F(TSYNC,two_siblings_with_ancestor)2707 TEST_F(TSYNC, two_siblings_with_ancestor)
2708 {
2709 	long ret;
2710 	void *status;
2711 
2712 	ASSERT_EQ(0, prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
2713 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
2714 	}
2715 
2716 	ret = seccomp(SECCOMP_SET_MODE_FILTER, 0, &self->root_prog);
2717 	ASSERT_NE(ENOSYS, errno) {
2718 		TH_LOG("Kernel does not support seccomp syscall!");
2719 	}
2720 	ASSERT_EQ(0, ret) {
2721 		TH_LOG("Kernel does not support SECCOMP_SET_MODE_FILTER!");
2722 	}
2723 	tsync_start_sibling(&self->sibling[0]);
2724 	tsync_start_sibling(&self->sibling[1]);
2725 
2726 	while (self->sibling_count < TSYNC_SIBLINGS) {
2727 		sem_wait(&self->started);
2728 		self->sibling_count++;
2729 	}
2730 
2731 	ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
2732 		      &self->apply_prog);
2733 	ASSERT_EQ(0, ret) {
2734 		TH_LOG("Could install filter on all threads!");
2735 	}
2736 	/* Tell the siblings to test the policy */
2737 	pthread_mutex_lock(&self->mutex);
2738 	ASSERT_EQ(0, pthread_cond_broadcast(&self->cond)) {
2739 		TH_LOG("cond broadcast non-zero");
2740 	}
2741 	pthread_mutex_unlock(&self->mutex);
2742 	/* Ensure they are both killed and don't exit cleanly. */
2743 	PTHREAD_JOIN(self->sibling[0].tid, &status);
2744 	EXPECT_EQ(0x0, (long)status);
2745 	PTHREAD_JOIN(self->sibling[1].tid, &status);
2746 	EXPECT_EQ(0x0, (long)status);
2747 }
2748 
TEST_F(TSYNC,two_sibling_want_nnp)2749 TEST_F(TSYNC, two_sibling_want_nnp)
2750 {
2751 	void *status;
2752 
2753 	/* start siblings before any prctl() operations */
2754 	tsync_start_sibling(&self->sibling[0]);
2755 	tsync_start_sibling(&self->sibling[1]);
2756 	while (self->sibling_count < TSYNC_SIBLINGS) {
2757 		sem_wait(&self->started);
2758 		self->sibling_count++;
2759 	}
2760 
2761 	/* Tell the siblings to test no policy */
2762 	pthread_mutex_lock(&self->mutex);
2763 	ASSERT_EQ(0, pthread_cond_broadcast(&self->cond)) {
2764 		TH_LOG("cond broadcast non-zero");
2765 	}
2766 	pthread_mutex_unlock(&self->mutex);
2767 
2768 	/* Ensure they are both upset about lacking nnp. */
2769 	PTHREAD_JOIN(self->sibling[0].tid, &status);
2770 	EXPECT_EQ(SIBLING_EXIT_NEWPRIVS, (long)status);
2771 	PTHREAD_JOIN(self->sibling[1].tid, &status);
2772 	EXPECT_EQ(SIBLING_EXIT_NEWPRIVS, (long)status);
2773 }
2774 
TEST_F(TSYNC,two_siblings_with_no_filter)2775 TEST_F(TSYNC, two_siblings_with_no_filter)
2776 {
2777 	long ret;
2778 	void *status;
2779 
2780 	/* start siblings before any prctl() operations */
2781 	tsync_start_sibling(&self->sibling[0]);
2782 	tsync_start_sibling(&self->sibling[1]);
2783 	while (self->sibling_count < TSYNC_SIBLINGS) {
2784 		sem_wait(&self->started);
2785 		self->sibling_count++;
2786 	}
2787 
2788 	ASSERT_EQ(0, prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
2789 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
2790 	}
2791 
2792 	ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
2793 		      &self->apply_prog);
2794 	ASSERT_NE(ENOSYS, errno) {
2795 		TH_LOG("Kernel does not support seccomp syscall!");
2796 	}
2797 	ASSERT_EQ(0, ret) {
2798 		TH_LOG("Could install filter on all threads!");
2799 	}
2800 
2801 	/* Tell the siblings to test the policy */
2802 	pthread_mutex_lock(&self->mutex);
2803 	ASSERT_EQ(0, pthread_cond_broadcast(&self->cond)) {
2804 		TH_LOG("cond broadcast non-zero");
2805 	}
2806 	pthread_mutex_unlock(&self->mutex);
2807 
2808 	/* Ensure they are both killed and don't exit cleanly. */
2809 	PTHREAD_JOIN(self->sibling[0].tid, &status);
2810 	EXPECT_EQ(0x0, (long)status);
2811 	PTHREAD_JOIN(self->sibling[1].tid, &status);
2812 	EXPECT_EQ(0x0, (long)status);
2813 }
2814 
TEST_F(TSYNC,two_siblings_with_one_divergence)2815 TEST_F(TSYNC, two_siblings_with_one_divergence)
2816 {
2817 	long ret;
2818 	void *status;
2819 
2820 	ASSERT_EQ(0, prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
2821 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
2822 	}
2823 
2824 	ret = seccomp(SECCOMP_SET_MODE_FILTER, 0, &self->root_prog);
2825 	ASSERT_NE(ENOSYS, errno) {
2826 		TH_LOG("Kernel does not support seccomp syscall!");
2827 	}
2828 	ASSERT_EQ(0, ret) {
2829 		TH_LOG("Kernel does not support SECCOMP_SET_MODE_FILTER!");
2830 	}
2831 	self->sibling[0].diverge = 1;
2832 	tsync_start_sibling(&self->sibling[0]);
2833 	tsync_start_sibling(&self->sibling[1]);
2834 
2835 	while (self->sibling_count < TSYNC_SIBLINGS) {
2836 		sem_wait(&self->started);
2837 		self->sibling_count++;
2838 	}
2839 
2840 	ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
2841 		      &self->apply_prog);
2842 	ASSERT_EQ(self->sibling[0].system_tid, ret) {
2843 		TH_LOG("Did not fail on diverged sibling.");
2844 	}
2845 
2846 	/* Wake the threads */
2847 	pthread_mutex_lock(&self->mutex);
2848 	ASSERT_EQ(0, pthread_cond_broadcast(&self->cond)) {
2849 		TH_LOG("cond broadcast non-zero");
2850 	}
2851 	pthread_mutex_unlock(&self->mutex);
2852 
2853 	/* Ensure they are both unkilled. */
2854 	PTHREAD_JOIN(self->sibling[0].tid, &status);
2855 	EXPECT_EQ(SIBLING_EXIT_UNKILLED, (long)status);
2856 	PTHREAD_JOIN(self->sibling[1].tid, &status);
2857 	EXPECT_EQ(SIBLING_EXIT_UNKILLED, (long)status);
2858 }
2859 
TEST_F(TSYNC,two_siblings_with_one_divergence_no_tid_in_err)2860 TEST_F(TSYNC, two_siblings_with_one_divergence_no_tid_in_err)
2861 {
2862 	long ret, flags;
2863 	void *status;
2864 
2865 	ASSERT_EQ(0, prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
2866 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
2867 	}
2868 
2869 	ret = seccomp(SECCOMP_SET_MODE_FILTER, 0, &self->root_prog);
2870 	ASSERT_NE(ENOSYS, errno) {
2871 		TH_LOG("Kernel does not support seccomp syscall!");
2872 	}
2873 	ASSERT_EQ(0, ret) {
2874 		TH_LOG("Kernel does not support SECCOMP_SET_MODE_FILTER!");
2875 	}
2876 	self->sibling[0].diverge = 1;
2877 	tsync_start_sibling(&self->sibling[0]);
2878 	tsync_start_sibling(&self->sibling[1]);
2879 
2880 	while (self->sibling_count < TSYNC_SIBLINGS) {
2881 		sem_wait(&self->started);
2882 		self->sibling_count++;
2883 	}
2884 
2885 	flags = SECCOMP_FILTER_FLAG_TSYNC | \
2886 		SECCOMP_FILTER_FLAG_TSYNC_ESRCH;
2887 	ret = seccomp(SECCOMP_SET_MODE_FILTER, flags, &self->apply_prog);
2888 	ASSERT_EQ(ESRCH, errno) {
2889 		TH_LOG("Did not return ESRCH for diverged sibling.");
2890 	}
2891 	ASSERT_EQ(-1, ret) {
2892 		TH_LOG("Did not fail on diverged sibling.");
2893 	}
2894 
2895 	/* Wake the threads */
2896 	pthread_mutex_lock(&self->mutex);
2897 	ASSERT_EQ(0, pthread_cond_broadcast(&self->cond)) {
2898 		TH_LOG("cond broadcast non-zero");
2899 	}
2900 	pthread_mutex_unlock(&self->mutex);
2901 
2902 	/* Ensure they are both unkilled. */
2903 	PTHREAD_JOIN(self->sibling[0].tid, &status);
2904 	EXPECT_EQ(SIBLING_EXIT_UNKILLED, (long)status);
2905 	PTHREAD_JOIN(self->sibling[1].tid, &status);
2906 	EXPECT_EQ(SIBLING_EXIT_UNKILLED, (long)status);
2907 }
2908 
TEST_F(TSYNC,two_siblings_not_under_filter)2909 TEST_F(TSYNC, two_siblings_not_under_filter)
2910 {
2911 	long ret, sib;
2912 	void *status;
2913 	struct timespec delay = { .tv_nsec = 100000000 };
2914 
2915 	ASSERT_EQ(0, prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
2916 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
2917 	}
2918 
2919 	/*
2920 	 * Sibling 0 will have its own seccomp policy
2921 	 * and Sibling 1 will not be under seccomp at
2922 	 * all. Sibling 1 will enter seccomp and 0
2923 	 * will cause failure.
2924 	 */
2925 	self->sibling[0].diverge = 1;
2926 	tsync_start_sibling(&self->sibling[0]);
2927 	tsync_start_sibling(&self->sibling[1]);
2928 
2929 	while (self->sibling_count < TSYNC_SIBLINGS) {
2930 		sem_wait(&self->started);
2931 		self->sibling_count++;
2932 	}
2933 
2934 	ret = seccomp(SECCOMP_SET_MODE_FILTER, 0, &self->root_prog);
2935 	ASSERT_NE(ENOSYS, errno) {
2936 		TH_LOG("Kernel does not support seccomp syscall!");
2937 	}
2938 	ASSERT_EQ(0, ret) {
2939 		TH_LOG("Kernel does not support SECCOMP_SET_MODE_FILTER!");
2940 	}
2941 
2942 	ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
2943 		      &self->apply_prog);
2944 	ASSERT_EQ(ret, self->sibling[0].system_tid) {
2945 		TH_LOG("Did not fail on diverged sibling.");
2946 	}
2947 	sib = 1;
2948 	if (ret == self->sibling[0].system_tid)
2949 		sib = 0;
2950 
2951 	pthread_mutex_lock(&self->mutex);
2952 
2953 	/* Increment the other siblings num_waits so we can clean up
2954 	 * the one we just saw.
2955 	 */
2956 	self->sibling[!sib].num_waits += 1;
2957 
2958 	/* Signal the thread to clean up*/
2959 	ASSERT_EQ(0, pthread_cond_broadcast(&self->cond)) {
2960 		TH_LOG("cond broadcast non-zero");
2961 	}
2962 	pthread_mutex_unlock(&self->mutex);
2963 	PTHREAD_JOIN(self->sibling[sib].tid, &status);
2964 	EXPECT_EQ(SIBLING_EXIT_UNKILLED, (long)status);
2965 	/* Poll for actual task death. pthread_join doesn't guarantee it. */
2966 	while (!kill(self->sibling[sib].system_tid, 0))
2967 		nanosleep(&delay, NULL);
2968 	/* Switch to the remaining sibling */
2969 	sib = !sib;
2970 
2971 	ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
2972 		      &self->apply_prog);
2973 	ASSERT_EQ(0, ret) {
2974 		TH_LOG("Expected the remaining sibling to sync");
2975 	};
2976 
2977 	pthread_mutex_lock(&self->mutex);
2978 
2979 	/* If remaining sibling didn't have a chance to wake up during
2980 	 * the first broadcast, manually reduce the num_waits now.
2981 	 */
2982 	if (self->sibling[sib].num_waits > 1)
2983 		self->sibling[sib].num_waits = 1;
2984 	ASSERT_EQ(0, pthread_cond_broadcast(&self->cond)) {
2985 		TH_LOG("cond broadcast non-zero");
2986 	}
2987 	pthread_mutex_unlock(&self->mutex);
2988 	PTHREAD_JOIN(self->sibling[sib].tid, &status);
2989 	EXPECT_EQ(0, (long)status);
2990 	/* Poll for actual task death. pthread_join doesn't guarantee it. */
2991 	while (!kill(self->sibling[sib].system_tid, 0))
2992 		nanosleep(&delay, NULL);
2993 
2994 	ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC,
2995 		      &self->apply_prog);
2996 	ASSERT_EQ(0, ret);  /* just us chickens */
2997 }
2998 
2999 /* Make sure restarted syscalls are seen directly as "restart_syscall". */
TEST(syscall_restart)3000 TEST(syscall_restart)
3001 {
3002 	long ret;
3003 	unsigned long msg;
3004 	pid_t child_pid;
3005 	int pipefd[2];
3006 	int status;
3007 	siginfo_t info = { };
3008 	struct sock_filter filter[] = {
3009 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
3010 			 offsetof(struct seccomp_data, nr)),
3011 
3012 #ifdef __NR_sigreturn
3013 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_sigreturn, 7, 0),
3014 #endif
3015 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_read, 6, 0),
3016 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_exit, 5, 0),
3017 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_rt_sigreturn, 4, 0),
3018 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_nanosleep, 5, 0),
3019 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_clock_nanosleep, 4, 0),
3020 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_restart_syscall, 4, 0),
3021 
3022 		/* Allow __NR_write for easy logging. */
3023 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_write, 0, 1),
3024 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
3025 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_KILL),
3026 		/* The nanosleep jump target. */
3027 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_TRACE|0x100),
3028 		/* The restart_syscall jump target. */
3029 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_TRACE|0x200),
3030 	};
3031 	struct sock_fprog prog = {
3032 		.len = (unsigned short)ARRAY_SIZE(filter),
3033 		.filter = filter,
3034 	};
3035 #if defined(__arm__)
3036 	struct utsname utsbuf;
3037 #endif
3038 
3039 	ASSERT_EQ(0, pipe(pipefd));
3040 
3041 	child_pid = fork();
3042 	ASSERT_LE(0, child_pid);
3043 	if (child_pid == 0) {
3044 		/* Child uses EXPECT not ASSERT to deliver status correctly. */
3045 		char buf = ' ';
3046 		struct timespec timeout = { };
3047 
3048 		/* Attach parent as tracer and stop. */
3049 		EXPECT_EQ(0, ptrace(PTRACE_TRACEME));
3050 		EXPECT_EQ(0, raise(SIGSTOP));
3051 
3052 		EXPECT_EQ(0, close(pipefd[1]));
3053 
3054 		EXPECT_EQ(0, prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0)) {
3055 			TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
3056 		}
3057 
3058 		ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog, 0, 0);
3059 		EXPECT_EQ(0, ret) {
3060 			TH_LOG("Failed to install filter!");
3061 		}
3062 
3063 		EXPECT_EQ(1, read(pipefd[0], &buf, 1)) {
3064 			TH_LOG("Failed to read() sync from parent");
3065 		}
3066 		EXPECT_EQ('.', buf) {
3067 			TH_LOG("Failed to get sync data from read()");
3068 		}
3069 
3070 		/* Start nanosleep to be interrupted. */
3071 		timeout.tv_sec = 1;
3072 		errno = 0;
3073 		EXPECT_EQ(0, nanosleep(&timeout, NULL)) {
3074 			TH_LOG("Call to nanosleep() failed (errno %d: %s)",
3075 				errno, strerror(errno));
3076 		}
3077 
3078 		/* Read final sync from parent. */
3079 		EXPECT_EQ(1, read(pipefd[0], &buf, 1)) {
3080 			TH_LOG("Failed final read() from parent");
3081 		}
3082 		EXPECT_EQ('!', buf) {
3083 			TH_LOG("Failed to get final data from read()");
3084 		}
3085 
3086 		/* Directly report the status of our test harness results. */
3087 		syscall(__NR_exit, _metadata->exit_code);
3088 	}
3089 	EXPECT_EQ(0, close(pipefd[0]));
3090 
3091 	/* Attach to child, setup options, and release. */
3092 	ASSERT_EQ(child_pid, waitpid(child_pid, &status, 0));
3093 	ASSERT_EQ(true, WIFSTOPPED(status));
3094 	ASSERT_EQ(0, ptrace(PTRACE_SETOPTIONS, child_pid, NULL,
3095 			    PTRACE_O_TRACESECCOMP));
3096 	ASSERT_EQ(0, ptrace(PTRACE_CONT, child_pid, NULL, 0));
3097 	ASSERT_EQ(1, write(pipefd[1], ".", 1));
3098 
3099 	/* Wait for nanosleep() to start. */
3100 	ASSERT_EQ(child_pid, waitpid(child_pid, &status, 0));
3101 	ASSERT_EQ(true, WIFSTOPPED(status));
3102 	ASSERT_EQ(SIGTRAP, WSTOPSIG(status));
3103 	ASSERT_EQ(PTRACE_EVENT_SECCOMP, (status >> 16));
3104 	ASSERT_EQ(0, ptrace(PTRACE_GETEVENTMSG, child_pid, NULL, &msg));
3105 	ASSERT_EQ(0x100, msg);
3106 	ret = get_syscall(_metadata, child_pid);
3107 	EXPECT_TRUE(ret == __NR_nanosleep || ret == __NR_clock_nanosleep);
3108 
3109 	/* Might as well check siginfo for sanity while we're here. */
3110 	ASSERT_EQ(0, ptrace(PTRACE_GETSIGINFO, child_pid, NULL, &info));
3111 	ASSERT_EQ(SIGTRAP, info.si_signo);
3112 	ASSERT_EQ(SIGTRAP | (PTRACE_EVENT_SECCOMP << 8), info.si_code);
3113 	EXPECT_EQ(0, info.si_errno);
3114 	EXPECT_EQ(getuid(), info.si_uid);
3115 	/* Verify signal delivery came from child (seccomp-triggered). */
3116 	EXPECT_EQ(child_pid, info.si_pid);
3117 
3118 	/* Interrupt nanosleep with SIGSTOP (which we'll need to handle). */
3119 	ASSERT_EQ(0, kill(child_pid, SIGSTOP));
3120 	ASSERT_EQ(0, ptrace(PTRACE_CONT, child_pid, NULL, 0));
3121 	ASSERT_EQ(child_pid, waitpid(child_pid, &status, 0));
3122 	ASSERT_EQ(true, WIFSTOPPED(status));
3123 	ASSERT_EQ(SIGSTOP, WSTOPSIG(status));
3124 	ASSERT_EQ(0, ptrace(PTRACE_GETSIGINFO, child_pid, NULL, &info));
3125 	/*
3126 	 * There is no siginfo on SIGSTOP any more, so we can't verify
3127 	 * signal delivery came from parent now (getpid() == info.si_pid).
3128 	 * https://lkml.kernel.org/r/CAGXu5jJaZAOzP1qFz66tYrtbuywqb+UN2SOA1VLHpCCOiYvYeg@mail.gmail.com
3129 	 * At least verify the SIGSTOP via PTRACE_GETSIGINFO.
3130 	 */
3131 	EXPECT_EQ(SIGSTOP, info.si_signo);
3132 
3133 	/* Restart nanosleep with SIGCONT, which triggers restart_syscall. */
3134 	ASSERT_EQ(0, kill(child_pid, SIGCONT));
3135 	ASSERT_EQ(0, ptrace(PTRACE_CONT, child_pid, NULL, 0));
3136 	ASSERT_EQ(child_pid, waitpid(child_pid, &status, 0));
3137 	ASSERT_EQ(true, WIFSTOPPED(status));
3138 	ASSERT_EQ(SIGCONT, WSTOPSIG(status));
3139 	ASSERT_EQ(0, ptrace(PTRACE_CONT, child_pid, NULL, 0));
3140 
3141 	/* Wait for restart_syscall() to start. */
3142 	ASSERT_EQ(child_pid, waitpid(child_pid, &status, 0));
3143 	ASSERT_EQ(true, WIFSTOPPED(status));
3144 	ASSERT_EQ(SIGTRAP, WSTOPSIG(status));
3145 	ASSERT_EQ(PTRACE_EVENT_SECCOMP, (status >> 16));
3146 	ASSERT_EQ(0, ptrace(PTRACE_GETEVENTMSG, child_pid, NULL, &msg));
3147 
3148 	ASSERT_EQ(0x200, msg);
3149 	ret = get_syscall(_metadata, child_pid);
3150 #if defined(__arm__)
3151 	/*
3152 	 * - native ARM registers do NOT expose true syscall.
3153 	 * - compat ARM registers on ARM64 DO expose true syscall.
3154 	 * - values of utsbuf.machine include 'armv8l' or 'armb8b'
3155 	 *   for ARM64 running in compat mode.
3156 	 */
3157 	ASSERT_EQ(0, uname(&utsbuf));
3158 	if ((strncmp(utsbuf.machine, "arm", 3) == 0) &&
3159 	    (strncmp(utsbuf.machine, "armv8l", 6) != 0) &&
3160 	    (strncmp(utsbuf.machine, "armv8b", 6) != 0)) {
3161 		EXPECT_EQ(__NR_nanosleep, ret);
3162 	} else
3163 #endif
3164 	{
3165 		EXPECT_EQ(__NR_restart_syscall, ret);
3166 	}
3167 
3168 	/* Write again to end test. */
3169 	ASSERT_EQ(0, ptrace(PTRACE_CONT, child_pid, NULL, 0));
3170 	ASSERT_EQ(1, write(pipefd[1], "!", 1));
3171 	EXPECT_EQ(0, close(pipefd[1]));
3172 
3173 	ASSERT_EQ(child_pid, waitpid(child_pid, &status, 0));
3174 	if (WIFSIGNALED(status) || WEXITSTATUS(status))
3175 		_metadata->exit_code = KSFT_FAIL;
3176 }
3177 
TEST_SIGNAL(filter_flag_log,SIGSYS)3178 TEST_SIGNAL(filter_flag_log, SIGSYS)
3179 {
3180 	struct sock_filter allow_filter[] = {
3181 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
3182 	};
3183 	struct sock_filter kill_filter[] = {
3184 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
3185 			offsetof(struct seccomp_data, nr)),
3186 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, __NR_getpid, 0, 1),
3187 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_KILL),
3188 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
3189 	};
3190 	struct sock_fprog allow_prog = {
3191 		.len = (unsigned short)ARRAY_SIZE(allow_filter),
3192 		.filter = allow_filter,
3193 	};
3194 	struct sock_fprog kill_prog = {
3195 		.len = (unsigned short)ARRAY_SIZE(kill_filter),
3196 		.filter = kill_filter,
3197 	};
3198 	long ret;
3199 	pid_t parent = getppid();
3200 
3201 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
3202 	ASSERT_EQ(0, ret);
3203 
3204 	/* Verify that the FILTER_FLAG_LOG flag isn't accepted in strict mode */
3205 	ret = seccomp(SECCOMP_SET_MODE_STRICT, SECCOMP_FILTER_FLAG_LOG,
3206 		      &allow_prog);
3207 	ASSERT_NE(ENOSYS, errno) {
3208 		TH_LOG("Kernel does not support seccomp syscall!");
3209 	}
3210 	EXPECT_NE(0, ret) {
3211 		TH_LOG("Kernel accepted FILTER_FLAG_LOG flag in strict mode!");
3212 	}
3213 	EXPECT_EQ(EINVAL, errno) {
3214 		TH_LOG("Kernel returned unexpected errno for FILTER_FLAG_LOG flag in strict mode!");
3215 	}
3216 
3217 	/* Verify that a simple, permissive filter can be added with no flags */
3218 	ret = seccomp(SECCOMP_SET_MODE_FILTER, 0, &allow_prog);
3219 	EXPECT_EQ(0, ret);
3220 
3221 	/* See if the same filter can be added with the FILTER_FLAG_LOG flag */
3222 	ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_LOG,
3223 		      &allow_prog);
3224 	ASSERT_NE(EINVAL, errno) {
3225 		TH_LOG("Kernel does not support the FILTER_FLAG_LOG flag!");
3226 	}
3227 	EXPECT_EQ(0, ret);
3228 
3229 	/* Ensure that the kill filter works with the FILTER_FLAG_LOG flag */
3230 	ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_LOG,
3231 		      &kill_prog);
3232 	EXPECT_EQ(0, ret);
3233 
3234 	EXPECT_EQ(parent, syscall(__NR_getppid));
3235 	/* getpid() should never return. */
3236 	EXPECT_EQ(0, syscall(__NR_getpid));
3237 }
3238 
TEST(get_action_avail)3239 TEST(get_action_avail)
3240 {
3241 	__u32 actions[] = { SECCOMP_RET_KILL_THREAD, SECCOMP_RET_TRAP,
3242 			    SECCOMP_RET_ERRNO, SECCOMP_RET_TRACE,
3243 			    SECCOMP_RET_LOG,   SECCOMP_RET_ALLOW };
3244 	__u32 unknown_action = 0x10000000U;
3245 	int i;
3246 	long ret;
3247 
3248 	ret = seccomp(SECCOMP_GET_ACTION_AVAIL, 0, &actions[0]);
3249 	ASSERT_NE(ENOSYS, errno) {
3250 		TH_LOG("Kernel does not support seccomp syscall!");
3251 	}
3252 	ASSERT_NE(EINVAL, errno) {
3253 		TH_LOG("Kernel does not support SECCOMP_GET_ACTION_AVAIL operation!");
3254 	}
3255 	EXPECT_EQ(ret, 0);
3256 
3257 	for (i = 0; i < ARRAY_SIZE(actions); i++) {
3258 		ret = seccomp(SECCOMP_GET_ACTION_AVAIL, 0, &actions[i]);
3259 		EXPECT_EQ(ret, 0) {
3260 			TH_LOG("Expected action (0x%X) not available!",
3261 			       actions[i]);
3262 		}
3263 	}
3264 
3265 	/* Check that an unknown action is handled properly (EOPNOTSUPP) */
3266 	ret = seccomp(SECCOMP_GET_ACTION_AVAIL, 0, &unknown_action);
3267 	EXPECT_EQ(ret, -1);
3268 	EXPECT_EQ(errno, EOPNOTSUPP);
3269 }
3270 
TEST(get_metadata)3271 TEST(get_metadata)
3272 {
3273 	pid_t pid;
3274 	int pipefd[2];
3275 	char buf;
3276 	struct seccomp_metadata md;
3277 	long ret;
3278 
3279 	/* Only real root can get metadata. */
3280 	if (geteuid()) {
3281 		SKIP(return, "get_metadata requires real root");
3282 		return;
3283 	}
3284 
3285 	ASSERT_EQ(0, pipe(pipefd));
3286 
3287 	pid = fork();
3288 	ASSERT_GE(pid, 0);
3289 	if (pid == 0) {
3290 		struct sock_filter filter[] = {
3291 			BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
3292 		};
3293 		struct sock_fprog prog = {
3294 			.len = (unsigned short)ARRAY_SIZE(filter),
3295 			.filter = filter,
3296 		};
3297 
3298 		/* one with log, one without */
3299 		EXPECT_EQ(0, seccomp(SECCOMP_SET_MODE_FILTER,
3300 				     SECCOMP_FILTER_FLAG_LOG, &prog));
3301 		EXPECT_EQ(0, seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog));
3302 
3303 		EXPECT_EQ(0, close(pipefd[0]));
3304 		ASSERT_EQ(1, write(pipefd[1], "1", 1));
3305 		ASSERT_EQ(0, close(pipefd[1]));
3306 
3307 		while (1)
3308 			sleep(100);
3309 	}
3310 
3311 	ASSERT_EQ(0, close(pipefd[1]));
3312 	ASSERT_EQ(1, read(pipefd[0], &buf, 1));
3313 
3314 	ASSERT_EQ(0, ptrace(PTRACE_ATTACH, pid));
3315 	ASSERT_EQ(pid, waitpid(pid, NULL, 0));
3316 
3317 	/* Past here must not use ASSERT or child process is never killed. */
3318 
3319 	md.filter_off = 0;
3320 	errno = 0;
3321 	ret = ptrace(PTRACE_SECCOMP_GET_METADATA, pid, sizeof(md), &md);
3322 	EXPECT_EQ(sizeof(md), ret) {
3323 		if (errno == EINVAL)
3324 			SKIP(goto skip, "Kernel does not support PTRACE_SECCOMP_GET_METADATA (missing CONFIG_CHECKPOINT_RESTORE?)");
3325 	}
3326 
3327 	EXPECT_EQ(md.flags, SECCOMP_FILTER_FLAG_LOG);
3328 	EXPECT_EQ(md.filter_off, 0);
3329 
3330 	md.filter_off = 1;
3331 	ret = ptrace(PTRACE_SECCOMP_GET_METADATA, pid, sizeof(md), &md);
3332 	EXPECT_EQ(sizeof(md), ret);
3333 	EXPECT_EQ(md.flags, 0);
3334 	EXPECT_EQ(md.filter_off, 1);
3335 
3336 skip:
3337 	ASSERT_EQ(0, kill(pid, SIGKILL));
3338 }
3339 
user_notif_syscall(int nr,unsigned int flags)3340 static int user_notif_syscall(int nr, unsigned int flags)
3341 {
3342 	struct sock_filter filter[] = {
3343 		BPF_STMT(BPF_LD|BPF_W|BPF_ABS,
3344 			offsetof(struct seccomp_data, nr)),
3345 		BPF_JUMP(BPF_JMP|BPF_JEQ|BPF_K, nr, 0, 1),
3346 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_USER_NOTIF),
3347 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
3348 	};
3349 
3350 	struct sock_fprog prog = {
3351 		.len = (unsigned short)ARRAY_SIZE(filter),
3352 		.filter = filter,
3353 	};
3354 
3355 	return seccomp(SECCOMP_SET_MODE_FILTER, flags, &prog);
3356 }
3357 
3358 #define USER_NOTIF_MAGIC INT_MAX
TEST(user_notification_basic)3359 TEST(user_notification_basic)
3360 {
3361 	pid_t pid;
3362 	long ret;
3363 	int status, listener;
3364 	struct seccomp_notif req = {};
3365 	struct seccomp_notif_resp resp = {};
3366 	struct pollfd pollfd;
3367 
3368 	struct sock_filter filter[] = {
3369 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
3370 	};
3371 	struct sock_fprog prog = {
3372 		.len = (unsigned short)ARRAY_SIZE(filter),
3373 		.filter = filter,
3374 	};
3375 
3376 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
3377 	ASSERT_EQ(0, ret) {
3378 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
3379 	}
3380 
3381 	pid = fork();
3382 	ASSERT_GE(pid, 0);
3383 
3384 	/* Check that we get -ENOSYS with no listener attached */
3385 	if (pid == 0) {
3386 		if (user_notif_syscall(__NR_getppid, 0) < 0)
3387 			exit(1);
3388 		ret = syscall(__NR_getppid);
3389 		exit(ret >= 0 || errno != ENOSYS);
3390 	}
3391 
3392 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
3393 	EXPECT_EQ(true, WIFEXITED(status));
3394 	EXPECT_EQ(0, WEXITSTATUS(status));
3395 
3396 	/* Add some no-op filters for grins. */
3397 	EXPECT_EQ(seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog), 0);
3398 	EXPECT_EQ(seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog), 0);
3399 	EXPECT_EQ(seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog), 0);
3400 	EXPECT_EQ(seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog), 0);
3401 
3402 	/* Check that the basic notification machinery works */
3403 	listener = user_notif_syscall(__NR_getppid,
3404 				      SECCOMP_FILTER_FLAG_NEW_LISTENER);
3405 	ASSERT_GE(listener, 0);
3406 
3407 	/* Installing a second listener in the chain should EBUSY */
3408 	EXPECT_EQ(user_notif_syscall(__NR_getppid,
3409 				     SECCOMP_FILTER_FLAG_NEW_LISTENER),
3410 		  -1);
3411 	EXPECT_EQ(errno, EBUSY);
3412 
3413 	pid = fork();
3414 	ASSERT_GE(pid, 0);
3415 
3416 	if (pid == 0) {
3417 		ret = syscall(__NR_getppid);
3418 		exit(ret != USER_NOTIF_MAGIC);
3419 	}
3420 
3421 	pollfd.fd = listener;
3422 	pollfd.events = POLLIN | POLLOUT;
3423 
3424 	EXPECT_GT(poll(&pollfd, 1, -1), 0);
3425 	EXPECT_EQ(pollfd.revents, POLLIN);
3426 
3427 	/* Test that we can't pass garbage to the kernel. */
3428 	memset(&req, 0, sizeof(req));
3429 	req.pid = -1;
3430 	errno = 0;
3431 	ret = ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req);
3432 	EXPECT_EQ(-1, ret);
3433 	EXPECT_EQ(EINVAL, errno);
3434 
3435 	if (ret) {
3436 		req.pid = 0;
3437 		EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
3438 	}
3439 
3440 	pollfd.fd = listener;
3441 	pollfd.events = POLLIN | POLLOUT;
3442 
3443 	EXPECT_GT(poll(&pollfd, 1, -1), 0);
3444 	EXPECT_EQ(pollfd.revents, POLLOUT);
3445 
3446 	EXPECT_EQ(req.data.nr,  __NR_getppid);
3447 
3448 	resp.id = req.id;
3449 	resp.error = 0;
3450 	resp.val = USER_NOTIF_MAGIC;
3451 
3452 	/* check that we make sure flags == 0 */
3453 	resp.flags = 1;
3454 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), -1);
3455 	EXPECT_EQ(errno, EINVAL);
3456 
3457 	resp.flags = 0;
3458 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
3459 
3460 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
3461 	EXPECT_EQ(true, WIFEXITED(status));
3462 	EXPECT_EQ(0, WEXITSTATUS(status));
3463 }
3464 
TEST(user_notification_with_tsync)3465 TEST(user_notification_with_tsync)
3466 {
3467 	int ret;
3468 	unsigned int flags;
3469 
3470 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
3471 	ASSERT_EQ(0, ret) {
3472 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
3473 	}
3474 
3475 	/* these were exclusive */
3476 	flags = SECCOMP_FILTER_FLAG_NEW_LISTENER |
3477 		SECCOMP_FILTER_FLAG_TSYNC;
3478 	ASSERT_EQ(-1, user_notif_syscall(__NR_getppid, flags));
3479 	ASSERT_EQ(EINVAL, errno);
3480 
3481 	/* but now they're not */
3482 	flags |= SECCOMP_FILTER_FLAG_TSYNC_ESRCH;
3483 	ret = user_notif_syscall(__NR_getppid, flags);
3484 	close(ret);
3485 	ASSERT_LE(0, ret);
3486 }
3487 
TEST(user_notification_kill_in_middle)3488 TEST(user_notification_kill_in_middle)
3489 {
3490 	pid_t pid;
3491 	long ret;
3492 	int listener;
3493 	struct seccomp_notif req = {};
3494 	struct seccomp_notif_resp resp = {};
3495 
3496 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
3497 	ASSERT_EQ(0, ret) {
3498 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
3499 	}
3500 
3501 	listener = user_notif_syscall(__NR_getppid,
3502 				      SECCOMP_FILTER_FLAG_NEW_LISTENER);
3503 	ASSERT_GE(listener, 0);
3504 
3505 	/*
3506 	 * Check that nothing bad happens when we kill the task in the middle
3507 	 * of a syscall.
3508 	 */
3509 	pid = fork();
3510 	ASSERT_GE(pid, 0);
3511 
3512 	if (pid == 0) {
3513 		ret = syscall(__NR_getppid);
3514 		exit(ret != USER_NOTIF_MAGIC);
3515 	}
3516 
3517 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
3518 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_ID_VALID, &req.id), 0);
3519 
3520 	EXPECT_EQ(kill(pid, SIGKILL), 0);
3521 	EXPECT_EQ(waitpid(pid, NULL, 0), pid);
3522 
3523 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_ID_VALID, &req.id), -1);
3524 
3525 	resp.id = req.id;
3526 	ret = ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp);
3527 	EXPECT_EQ(ret, -1);
3528 	EXPECT_EQ(errno, ENOENT);
3529 }
3530 
3531 static int handled = -1;
3532 
signal_handler(int signal)3533 static void signal_handler(int signal)
3534 {
3535 	if (write(handled, "c", 1) != 1)
3536 		perror("write from signal");
3537 }
3538 
TEST(user_notification_signal)3539 TEST(user_notification_signal)
3540 {
3541 	pid_t pid;
3542 	long ret;
3543 	int status, listener, sk_pair[2];
3544 	struct seccomp_notif req = {};
3545 	struct seccomp_notif_resp resp = {};
3546 	char c;
3547 
3548 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
3549 	ASSERT_EQ(0, ret) {
3550 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
3551 	}
3552 
3553 	ASSERT_EQ(socketpair(PF_LOCAL, SOCK_SEQPACKET, 0, sk_pair), 0);
3554 
3555 	listener = user_notif_syscall(__NR_gettid,
3556 				      SECCOMP_FILTER_FLAG_NEW_LISTENER);
3557 	ASSERT_GE(listener, 0);
3558 
3559 	pid = fork();
3560 	ASSERT_GE(pid, 0);
3561 
3562 	if (pid == 0) {
3563 		close(sk_pair[0]);
3564 		handled = sk_pair[1];
3565 		if (signal(SIGUSR1, signal_handler) == SIG_ERR) {
3566 			perror("signal");
3567 			exit(1);
3568 		}
3569 		/*
3570 		 * ERESTARTSYS behavior is a bit hard to test, because we need
3571 		 * to rely on a signal that has not yet been handled. Let's at
3572 		 * least check that the error code gets propagated through, and
3573 		 * hope that it doesn't break when there is actually a signal :)
3574 		 */
3575 		ret = syscall(__NR_gettid);
3576 		exit(!(ret == -1 && errno == 512));
3577 	}
3578 
3579 	close(sk_pair[1]);
3580 
3581 	memset(&req, 0, sizeof(req));
3582 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
3583 
3584 	EXPECT_EQ(kill(pid, SIGUSR1), 0);
3585 
3586 	/*
3587 	 * Make sure the signal really is delivered, which means we're not
3588 	 * stuck in the user notification code any more and the notification
3589 	 * should be dead.
3590 	 */
3591 	EXPECT_EQ(read(sk_pair[0], &c, 1), 1);
3592 
3593 	resp.id = req.id;
3594 	resp.error = -EPERM;
3595 	resp.val = 0;
3596 
3597 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), -1);
3598 	EXPECT_EQ(errno, ENOENT);
3599 
3600 	memset(&req, 0, sizeof(req));
3601 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
3602 
3603 	resp.id = req.id;
3604 	resp.error = -512; /* -ERESTARTSYS */
3605 	resp.val = 0;
3606 
3607 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
3608 
3609 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
3610 	EXPECT_EQ(true, WIFEXITED(status));
3611 	EXPECT_EQ(0, WEXITSTATUS(status));
3612 }
3613 
TEST(user_notification_closed_listener)3614 TEST(user_notification_closed_listener)
3615 {
3616 	pid_t pid;
3617 	long ret;
3618 	int status, listener;
3619 
3620 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
3621 	ASSERT_EQ(0, ret) {
3622 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
3623 	}
3624 
3625 	listener = user_notif_syscall(__NR_getppid,
3626 				      SECCOMP_FILTER_FLAG_NEW_LISTENER);
3627 	ASSERT_GE(listener, 0);
3628 
3629 	/*
3630 	 * Check that we get an ENOSYS when the listener is closed.
3631 	 */
3632 	pid = fork();
3633 	ASSERT_GE(pid, 0);
3634 	if (pid == 0) {
3635 		close(listener);
3636 		ret = syscall(__NR_getppid);
3637 		exit(ret != -1 && errno != ENOSYS);
3638 	}
3639 
3640 	close(listener);
3641 
3642 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
3643 	EXPECT_EQ(true, WIFEXITED(status));
3644 	EXPECT_EQ(0, WEXITSTATUS(status));
3645 }
3646 
3647 /*
3648  * Check that a pid in a child namespace still shows up as valid in ours.
3649  */
TEST(user_notification_child_pid_ns)3650 TEST(user_notification_child_pid_ns)
3651 {
3652 	pid_t pid;
3653 	int status, listener;
3654 	struct seccomp_notif req = {};
3655 	struct seccomp_notif_resp resp = {};
3656 
3657 	ASSERT_EQ(unshare(CLONE_NEWUSER | CLONE_NEWPID), 0) {
3658 		if (errno == EINVAL)
3659 			SKIP(return, "kernel missing CLONE_NEWUSER support");
3660 	};
3661 
3662 	listener = user_notif_syscall(__NR_getppid,
3663 				      SECCOMP_FILTER_FLAG_NEW_LISTENER);
3664 	ASSERT_GE(listener, 0);
3665 
3666 	pid = fork();
3667 	ASSERT_GE(pid, 0);
3668 
3669 	if (pid == 0)
3670 		exit(syscall(__NR_getppid) != USER_NOTIF_MAGIC);
3671 
3672 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
3673 	EXPECT_EQ(req.pid, pid);
3674 
3675 	resp.id = req.id;
3676 	resp.error = 0;
3677 	resp.val = USER_NOTIF_MAGIC;
3678 
3679 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
3680 
3681 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
3682 	EXPECT_EQ(true, WIFEXITED(status));
3683 	EXPECT_EQ(0, WEXITSTATUS(status));
3684 	close(listener);
3685 }
3686 
3687 /*
3688  * Check that a pid in a sibling (i.e. unrelated) namespace shows up as 0, i.e.
3689  * invalid.
3690  */
TEST(user_notification_sibling_pid_ns)3691 TEST(user_notification_sibling_pid_ns)
3692 {
3693 	pid_t pid, pid2;
3694 	int status, listener;
3695 	struct seccomp_notif req = {};
3696 	struct seccomp_notif_resp resp = {};
3697 
3698 	ASSERT_EQ(prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0), 0) {
3699 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
3700 	}
3701 
3702 	listener = user_notif_syscall(__NR_getppid,
3703 				      SECCOMP_FILTER_FLAG_NEW_LISTENER);
3704 	ASSERT_GE(listener, 0);
3705 
3706 	pid = fork();
3707 	ASSERT_GE(pid, 0);
3708 
3709 	if (pid == 0) {
3710 		ASSERT_EQ(unshare(CLONE_NEWPID), 0) {
3711 			if (errno == EPERM)
3712 				SKIP(return, "CLONE_NEWPID requires CAP_SYS_ADMIN");
3713 			else if (errno == EINVAL)
3714 				SKIP(return, "CLONE_NEWPID is invalid (missing CONFIG_PID_NS?)");
3715 		}
3716 
3717 		pid2 = fork();
3718 		ASSERT_GE(pid2, 0);
3719 
3720 		if (pid2 == 0)
3721 			exit(syscall(__NR_getppid) != USER_NOTIF_MAGIC);
3722 
3723 		EXPECT_EQ(waitpid(pid2, &status, 0), pid2);
3724 		EXPECT_EQ(true, WIFEXITED(status));
3725 		EXPECT_EQ(0, WEXITSTATUS(status));
3726 		exit(WEXITSTATUS(status));
3727 	}
3728 
3729 	/* Create the sibling ns, and sibling in it. */
3730 	ASSERT_EQ(unshare(CLONE_NEWPID), 0) {
3731 		if (errno == EPERM)
3732 			SKIP(return, "CLONE_NEWPID requires CAP_SYS_ADMIN");
3733 		else if (errno == EINVAL)
3734 			SKIP(return, "CLONE_NEWPID is invalid (missing CONFIG_PID_NS?)");
3735 	}
3736 	ASSERT_EQ(errno, 0);
3737 
3738 	pid2 = fork();
3739 	ASSERT_GE(pid2, 0);
3740 
3741 	if (pid2 == 0) {
3742 		ASSERT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
3743 		/*
3744 		 * The pid should be 0, i.e. the task is in some namespace that
3745 		 * we can't "see".
3746 		 */
3747 		EXPECT_EQ(req.pid, 0);
3748 
3749 		resp.id = req.id;
3750 		resp.error = 0;
3751 		resp.val = USER_NOTIF_MAGIC;
3752 
3753 		ASSERT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
3754 		exit(0);
3755 	}
3756 
3757 	close(listener);
3758 
3759 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
3760 	EXPECT_EQ(true, WIFEXITED(status));
3761 	EXPECT_EQ(0, WEXITSTATUS(status));
3762 
3763 	EXPECT_EQ(waitpid(pid2, &status, 0), pid2);
3764 	EXPECT_EQ(true, WIFEXITED(status));
3765 	EXPECT_EQ(0, WEXITSTATUS(status));
3766 }
3767 
TEST(user_notification_fault_recv)3768 TEST(user_notification_fault_recv)
3769 {
3770 	pid_t pid;
3771 	int status, listener;
3772 	struct seccomp_notif req = {};
3773 	struct seccomp_notif_resp resp = {};
3774 
3775 	ASSERT_EQ(unshare(CLONE_NEWUSER), 0) {
3776 		if (errno == EINVAL)
3777 			SKIP(return, "kernel missing CLONE_NEWUSER support");
3778 	}
3779 
3780 	listener = user_notif_syscall(__NR_getppid,
3781 				      SECCOMP_FILTER_FLAG_NEW_LISTENER);
3782 	ASSERT_GE(listener, 0);
3783 
3784 	pid = fork();
3785 	ASSERT_GE(pid, 0);
3786 
3787 	if (pid == 0)
3788 		exit(syscall(__NR_getppid) != USER_NOTIF_MAGIC);
3789 
3790 	/* Do a bad recv() */
3791 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, NULL), -1);
3792 	EXPECT_EQ(errno, EFAULT);
3793 
3794 	/* We should still be able to receive this notification, though. */
3795 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
3796 	EXPECT_EQ(req.pid, pid);
3797 
3798 	resp.id = req.id;
3799 	resp.error = 0;
3800 	resp.val = USER_NOTIF_MAGIC;
3801 
3802 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
3803 
3804 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
3805 	EXPECT_EQ(true, WIFEXITED(status));
3806 	EXPECT_EQ(0, WEXITSTATUS(status));
3807 }
3808 
TEST(seccomp_get_notif_sizes)3809 TEST(seccomp_get_notif_sizes)
3810 {
3811 	struct seccomp_notif_sizes sizes;
3812 
3813 	ASSERT_EQ(seccomp(SECCOMP_GET_NOTIF_SIZES, 0, &sizes), 0);
3814 	EXPECT_EQ(sizes.seccomp_notif, sizeof(struct seccomp_notif));
3815 	EXPECT_EQ(sizes.seccomp_notif_resp, sizeof(struct seccomp_notif_resp));
3816 }
3817 
TEST(user_notification_continue)3818 TEST(user_notification_continue)
3819 {
3820 	pid_t pid;
3821 	long ret;
3822 	int status, listener;
3823 	struct seccomp_notif req = {};
3824 	struct seccomp_notif_resp resp = {};
3825 	struct pollfd pollfd;
3826 
3827 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
3828 	ASSERT_EQ(0, ret) {
3829 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
3830 	}
3831 
3832 	listener = user_notif_syscall(__NR_dup, SECCOMP_FILTER_FLAG_NEW_LISTENER);
3833 	ASSERT_GE(listener, 0);
3834 
3835 	pid = fork();
3836 	ASSERT_GE(pid, 0);
3837 
3838 	if (pid == 0) {
3839 		int dup_fd, pipe_fds[2];
3840 		pid_t self;
3841 
3842 		ASSERT_GE(pipe(pipe_fds), 0);
3843 
3844 		dup_fd = dup(pipe_fds[0]);
3845 		ASSERT_GE(dup_fd, 0);
3846 		EXPECT_NE(pipe_fds[0], dup_fd);
3847 
3848 		self = getpid();
3849 		ASSERT_EQ(filecmp(self, self, pipe_fds[0], dup_fd), 0);
3850 		exit(0);
3851 	}
3852 
3853 	pollfd.fd = listener;
3854 	pollfd.events = POLLIN | POLLOUT;
3855 
3856 	EXPECT_GT(poll(&pollfd, 1, -1), 0);
3857 	EXPECT_EQ(pollfd.revents, POLLIN);
3858 
3859 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
3860 
3861 	pollfd.fd = listener;
3862 	pollfd.events = POLLIN | POLLOUT;
3863 
3864 	EXPECT_GT(poll(&pollfd, 1, -1), 0);
3865 	EXPECT_EQ(pollfd.revents, POLLOUT);
3866 
3867 	EXPECT_EQ(req.data.nr, __NR_dup);
3868 
3869 	resp.id = req.id;
3870 	resp.flags = SECCOMP_USER_NOTIF_FLAG_CONTINUE;
3871 
3872 	/*
3873 	 * Verify that setting SECCOMP_USER_NOTIF_FLAG_CONTINUE enforces other
3874 	 * args be set to 0.
3875 	 */
3876 	resp.error = 0;
3877 	resp.val = USER_NOTIF_MAGIC;
3878 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), -1);
3879 	EXPECT_EQ(errno, EINVAL);
3880 
3881 	resp.error = USER_NOTIF_MAGIC;
3882 	resp.val = 0;
3883 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), -1);
3884 	EXPECT_EQ(errno, EINVAL);
3885 
3886 	resp.error = 0;
3887 	resp.val = 0;
3888 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0) {
3889 		if (errno == EINVAL)
3890 			SKIP(goto skip, "Kernel does not support SECCOMP_USER_NOTIF_FLAG_CONTINUE");
3891 	}
3892 
3893 skip:
3894 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
3895 	EXPECT_EQ(true, WIFEXITED(status));
3896 	EXPECT_EQ(0, WEXITSTATUS(status)) {
3897 		if (WEXITSTATUS(status) == 2) {
3898 			SKIP(return, "Kernel does not support kcmp() syscall");
3899 			return;
3900 		}
3901 	}
3902 }
3903 
TEST(user_notification_filter_empty)3904 TEST(user_notification_filter_empty)
3905 {
3906 	pid_t pid;
3907 	long ret;
3908 	int status;
3909 	struct pollfd pollfd;
3910 	struct __clone_args args = {
3911 		.flags = CLONE_FILES,
3912 		.exit_signal = SIGCHLD,
3913 	};
3914 
3915 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
3916 	ASSERT_EQ(0, ret) {
3917 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
3918 	}
3919 
3920 	if (__NR_clone3 < 0)
3921 		SKIP(return, "Test not built with clone3 support");
3922 
3923 	pid = sys_clone3(&args, sizeof(args));
3924 	ASSERT_GE(pid, 0);
3925 
3926 	if (pid == 0) {
3927 		int listener;
3928 
3929 		listener = user_notif_syscall(__NR_mknodat, SECCOMP_FILTER_FLAG_NEW_LISTENER);
3930 		if (listener < 0)
3931 			_exit(EXIT_FAILURE);
3932 
3933 		if (dup2(listener, 200) != 200)
3934 			_exit(EXIT_FAILURE);
3935 
3936 		close(listener);
3937 
3938 		_exit(EXIT_SUCCESS);
3939 	}
3940 
3941 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
3942 	EXPECT_EQ(true, WIFEXITED(status));
3943 	EXPECT_EQ(0, WEXITSTATUS(status));
3944 
3945 	/*
3946 	 * The seccomp filter has become unused so we should be notified once
3947 	 * the kernel gets around to cleaning up task struct.
3948 	 */
3949 	pollfd.fd = 200;
3950 	pollfd.events = POLLHUP;
3951 
3952 	EXPECT_GT(poll(&pollfd, 1, 2000), 0);
3953 	EXPECT_GT((pollfd.revents & POLLHUP) ?: 0, 0);
3954 }
3955 
TEST(user_ioctl_notification_filter_empty)3956 TEST(user_ioctl_notification_filter_empty)
3957 {
3958 	pid_t pid;
3959 	long ret;
3960 	int status, p[2];
3961 	struct __clone_args args = {
3962 		.flags = CLONE_FILES,
3963 		.exit_signal = SIGCHLD,
3964 	};
3965 	struct seccomp_notif req = {};
3966 
3967 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
3968 	ASSERT_EQ(0, ret) {
3969 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
3970 	}
3971 
3972 	if (__NR_clone3 < 0)
3973 		SKIP(return, "Test not built with clone3 support");
3974 
3975 	ASSERT_EQ(0, pipe(p));
3976 
3977 	pid = sys_clone3(&args, sizeof(args));
3978 	ASSERT_GE(pid, 0);
3979 
3980 	if (pid == 0) {
3981 		int listener;
3982 
3983 		listener = user_notif_syscall(__NR_mknodat, SECCOMP_FILTER_FLAG_NEW_LISTENER);
3984 		if (listener < 0)
3985 			_exit(EXIT_FAILURE);
3986 
3987 		if (dup2(listener, 200) != 200)
3988 			_exit(EXIT_FAILURE);
3989 		close(p[1]);
3990 		close(listener);
3991 		sleep(1);
3992 
3993 		_exit(EXIT_SUCCESS);
3994 	}
3995 	if (read(p[0], &status, 1) != 0)
3996 		_exit(EXIT_SUCCESS);
3997 	close(p[0]);
3998 	/*
3999 	 * The seccomp filter has become unused so we should be notified once
4000 	 * the kernel gets around to cleaning up task struct.
4001 	 */
4002 	EXPECT_EQ(ioctl(200, SECCOMP_IOCTL_NOTIF_RECV, &req), -1);
4003 	EXPECT_EQ(errno, ENOENT);
4004 
4005 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
4006 	EXPECT_EQ(true, WIFEXITED(status));
4007 	EXPECT_EQ(0, WEXITSTATUS(status));
4008 }
4009 
do_thread(void * data)4010 static void *do_thread(void *data)
4011 {
4012 	return NULL;
4013 }
4014 
TEST(user_notification_filter_empty_threaded)4015 TEST(user_notification_filter_empty_threaded)
4016 {
4017 	pid_t pid;
4018 	long ret;
4019 	int status;
4020 	struct pollfd pollfd;
4021 	struct __clone_args args = {
4022 		.flags = CLONE_FILES,
4023 		.exit_signal = SIGCHLD,
4024 	};
4025 
4026 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
4027 	ASSERT_EQ(0, ret) {
4028 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
4029 	}
4030 
4031 	if (__NR_clone3 < 0)
4032 		SKIP(return, "Test not built with clone3 support");
4033 
4034 	pid = sys_clone3(&args, sizeof(args));
4035 	ASSERT_GE(pid, 0);
4036 
4037 	if (pid == 0) {
4038 		pid_t pid1, pid2;
4039 		int listener, status;
4040 		pthread_t thread;
4041 
4042 		listener = user_notif_syscall(__NR_dup, SECCOMP_FILTER_FLAG_NEW_LISTENER);
4043 		if (listener < 0)
4044 			_exit(EXIT_FAILURE);
4045 
4046 		if (dup2(listener, 200) != 200)
4047 			_exit(EXIT_FAILURE);
4048 
4049 		close(listener);
4050 
4051 		pid1 = fork();
4052 		if (pid1 < 0)
4053 			_exit(EXIT_FAILURE);
4054 
4055 		if (pid1 == 0)
4056 			_exit(EXIT_SUCCESS);
4057 
4058 		pid2 = fork();
4059 		if (pid2 < 0)
4060 			_exit(EXIT_FAILURE);
4061 
4062 		if (pid2 == 0)
4063 			_exit(EXIT_SUCCESS);
4064 
4065 		if (pthread_create(&thread, NULL, do_thread, NULL) ||
4066 		    pthread_join(thread, NULL))
4067 			_exit(EXIT_FAILURE);
4068 
4069 		if (pthread_create(&thread, NULL, do_thread, NULL) ||
4070 		    pthread_join(thread, NULL))
4071 			_exit(EXIT_FAILURE);
4072 
4073 		if (waitpid(pid1, &status, 0) != pid1 || !WIFEXITED(status) ||
4074 		    WEXITSTATUS(status))
4075 			_exit(EXIT_FAILURE);
4076 
4077 		if (waitpid(pid2, &status, 0) != pid2 || !WIFEXITED(status) ||
4078 		    WEXITSTATUS(status))
4079 			_exit(EXIT_FAILURE);
4080 
4081 		exit(EXIT_SUCCESS);
4082 	}
4083 
4084 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
4085 	EXPECT_EQ(true, WIFEXITED(status));
4086 	EXPECT_EQ(0, WEXITSTATUS(status));
4087 
4088 	/*
4089 	 * The seccomp filter has become unused so we should be notified once
4090 	 * the kernel gets around to cleaning up task struct.
4091 	 */
4092 	pollfd.fd = 200;
4093 	pollfd.events = POLLHUP;
4094 
4095 	EXPECT_GT(poll(&pollfd, 1, 2000), 0);
4096 	EXPECT_GT((pollfd.revents & POLLHUP) ?: 0, 0);
4097 }
4098 
4099 
get_next_fd(int prev_fd)4100 int get_next_fd(int prev_fd)
4101 {
4102 	for (int i = prev_fd + 1; i < FD_SETSIZE; ++i) {
4103 		if (fcntl(i, F_GETFD) == -1)
4104 			return i;
4105 	}
4106 	_exit(EXIT_FAILURE);
4107 }
4108 
TEST(user_notification_addfd)4109 TEST(user_notification_addfd)
4110 {
4111 	pid_t pid;
4112 	long ret;
4113 	int status, listener, memfd, fd, nextfd;
4114 	struct seccomp_notif_addfd addfd = {};
4115 	struct seccomp_notif_addfd_small small = {};
4116 	struct seccomp_notif_addfd_big big = {};
4117 	struct seccomp_notif req = {};
4118 	struct seccomp_notif_resp resp = {};
4119 	/* 100 ms */
4120 	struct timespec delay = { .tv_nsec = 100000000 };
4121 
4122 	/* There may be arbitrary already-open fds at test start. */
4123 	memfd = memfd_create("test", 0);
4124 	ASSERT_GE(memfd, 0);
4125 	nextfd = get_next_fd(memfd);
4126 
4127 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
4128 	ASSERT_EQ(0, ret) {
4129 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
4130 	}
4131 
4132 	/* fd: 4 */
4133 	/* Check that the basic notification machinery works */
4134 	listener = user_notif_syscall(__NR_getppid,
4135 				      SECCOMP_FILTER_FLAG_NEW_LISTENER);
4136 	ASSERT_EQ(listener, nextfd);
4137 	nextfd = get_next_fd(nextfd);
4138 
4139 	pid = fork();
4140 	ASSERT_GE(pid, 0);
4141 
4142 	if (pid == 0) {
4143 		/* fds will be added and this value is expected */
4144 		if (syscall(__NR_getppid) != USER_NOTIF_MAGIC)
4145 			exit(1);
4146 
4147 		/* Atomic addfd+send is received here. Check it is a valid fd */
4148 		if (fcntl(syscall(__NR_getppid), F_GETFD) == -1)
4149 			exit(1);
4150 
4151 		exit(syscall(__NR_getppid) != USER_NOTIF_MAGIC);
4152 	}
4153 
4154 	ASSERT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
4155 
4156 	addfd.srcfd = memfd;
4157 	addfd.newfd = 0;
4158 	addfd.id = req.id;
4159 	addfd.flags = 0x0;
4160 
4161 	/* Verify bad newfd_flags cannot be set */
4162 	addfd.newfd_flags = ~O_CLOEXEC;
4163 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd), -1);
4164 	EXPECT_EQ(errno, EINVAL);
4165 	addfd.newfd_flags = O_CLOEXEC;
4166 
4167 	/* Verify bad flags cannot be set */
4168 	addfd.flags = 0xff;
4169 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd), -1);
4170 	EXPECT_EQ(errno, EINVAL);
4171 	addfd.flags = 0;
4172 
4173 	/* Verify that remote_fd cannot be set without setting flags */
4174 	addfd.newfd = 1;
4175 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd), -1);
4176 	EXPECT_EQ(errno, EINVAL);
4177 	addfd.newfd = 0;
4178 
4179 	/* Verify small size cannot be set */
4180 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD_SMALL, &small), -1);
4181 	EXPECT_EQ(errno, EINVAL);
4182 
4183 	/* Verify we can't send bits filled in unknown buffer area */
4184 	memset(&big, 0xAA, sizeof(big));
4185 	big.addfd = addfd;
4186 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD_BIG, &big), -1);
4187 	EXPECT_EQ(errno, E2BIG);
4188 
4189 
4190 	/* Verify we can set an arbitrary remote fd */
4191 	fd = ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd);
4192 	EXPECT_EQ(fd, nextfd);
4193 	nextfd = get_next_fd(nextfd);
4194 	EXPECT_EQ(filecmp(getpid(), pid, memfd, fd), 0);
4195 
4196 	/* Verify we can set an arbitrary remote fd with large size */
4197 	memset(&big, 0x0, sizeof(big));
4198 	big.addfd = addfd;
4199 	fd = ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD_BIG, &big);
4200 	EXPECT_EQ(fd, nextfd);
4201 	nextfd = get_next_fd(nextfd);
4202 
4203 	/* Verify we can set a specific remote fd */
4204 	addfd.newfd = 42;
4205 	addfd.flags = SECCOMP_ADDFD_FLAG_SETFD;
4206 	fd = ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd);
4207 	EXPECT_EQ(fd, 42);
4208 	EXPECT_EQ(filecmp(getpid(), pid, memfd, fd), 0);
4209 
4210 	/* Resume syscall */
4211 	resp.id = req.id;
4212 	resp.error = 0;
4213 	resp.val = USER_NOTIF_MAGIC;
4214 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
4215 
4216 	/*
4217 	 * This sets the ID of the ADD FD to the last request plus 1. The
4218 	 * notification ID increments 1 per notification.
4219 	 */
4220 	addfd.id = req.id + 1;
4221 
4222 	/* This spins until the underlying notification is generated */
4223 	while (ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd) != -1 &&
4224 	       errno != -EINPROGRESS)
4225 		nanosleep(&delay, NULL);
4226 
4227 	memset(&req, 0, sizeof(req));
4228 	ASSERT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
4229 	ASSERT_EQ(addfd.id, req.id);
4230 
4231 	/* Verify we can do an atomic addfd and send */
4232 	addfd.newfd = 0;
4233 	addfd.flags = SECCOMP_ADDFD_FLAG_SEND;
4234 	fd = ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd);
4235 	/*
4236 	 * Child has earlier "low" fds and now 42, so we expect the next
4237 	 * lowest available fd to be assigned here.
4238 	 */
4239 	EXPECT_EQ(fd, nextfd);
4240 	nextfd = get_next_fd(nextfd);
4241 	ASSERT_EQ(filecmp(getpid(), pid, memfd, fd), 0);
4242 
4243 	/*
4244 	 * This sets the ID of the ADD FD to the last request plus 1. The
4245 	 * notification ID increments 1 per notification.
4246 	 */
4247 	addfd.id = req.id + 1;
4248 
4249 	/* This spins until the underlying notification is generated */
4250 	while (ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd) != -1 &&
4251 	       errno != -EINPROGRESS)
4252 		nanosleep(&delay, NULL);
4253 
4254 	memset(&req, 0, sizeof(req));
4255 	ASSERT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
4256 	ASSERT_EQ(addfd.id, req.id);
4257 
4258 	resp.id = req.id;
4259 	resp.error = 0;
4260 	resp.val = USER_NOTIF_MAGIC;
4261 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
4262 
4263 	/* Wait for child to finish. */
4264 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
4265 	EXPECT_EQ(true, WIFEXITED(status));
4266 	EXPECT_EQ(0, WEXITSTATUS(status));
4267 
4268 	close(memfd);
4269 }
4270 
TEST(user_notification_addfd_rlimit)4271 TEST(user_notification_addfd_rlimit)
4272 {
4273 	pid_t pid;
4274 	long ret;
4275 	int status, listener, memfd;
4276 	struct seccomp_notif_addfd addfd = {};
4277 	struct seccomp_notif req = {};
4278 	struct seccomp_notif_resp resp = {};
4279 	const struct rlimit lim = {
4280 		.rlim_cur	= 0,
4281 		.rlim_max	= 0,
4282 	};
4283 
4284 	memfd = memfd_create("test", 0);
4285 	ASSERT_GE(memfd, 0);
4286 
4287 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
4288 	ASSERT_EQ(0, ret) {
4289 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
4290 	}
4291 
4292 	/* Check that the basic notification machinery works */
4293 	listener = user_notif_syscall(__NR_getppid,
4294 				      SECCOMP_FILTER_FLAG_NEW_LISTENER);
4295 	ASSERT_GE(listener, 0);
4296 
4297 	pid = fork();
4298 	ASSERT_GE(pid, 0);
4299 
4300 	if (pid == 0)
4301 		exit(syscall(__NR_getppid) != USER_NOTIF_MAGIC);
4302 
4303 
4304 	ASSERT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
4305 
4306 	ASSERT_EQ(prlimit(pid, RLIMIT_NOFILE, &lim, NULL), 0);
4307 
4308 	addfd.srcfd = memfd;
4309 	addfd.newfd_flags = O_CLOEXEC;
4310 	addfd.newfd = 0;
4311 	addfd.id = req.id;
4312 	addfd.flags = 0;
4313 
4314 	/* Should probably spot check /proc/sys/fs/file-nr */
4315 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd), -1);
4316 	EXPECT_EQ(errno, EMFILE);
4317 
4318 	addfd.flags = SECCOMP_ADDFD_FLAG_SEND;
4319 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd), -1);
4320 	EXPECT_EQ(errno, EMFILE);
4321 
4322 	addfd.newfd = 100;
4323 	addfd.flags = SECCOMP_ADDFD_FLAG_SETFD;
4324 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd), -1);
4325 	EXPECT_EQ(errno, EBADF);
4326 
4327 	resp.id = req.id;
4328 	resp.error = 0;
4329 	resp.val = USER_NOTIF_MAGIC;
4330 
4331 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
4332 
4333 	/* Wait for child to finish. */
4334 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
4335 	EXPECT_EQ(true, WIFEXITED(status));
4336 	EXPECT_EQ(0, WEXITSTATUS(status));
4337 
4338 	close(memfd);
4339 }
4340 
4341 #ifndef SECCOMP_USER_NOTIF_FD_SYNC_WAKE_UP
4342 #define SECCOMP_USER_NOTIF_FD_SYNC_WAKE_UP (1UL << 0)
4343 #define SECCOMP_IOCTL_NOTIF_SET_FLAGS  SECCOMP_IOW(4, __u64)
4344 #endif
4345 
TEST(user_notification_sync)4346 TEST(user_notification_sync)
4347 {
4348 	struct seccomp_notif req = {};
4349 	struct seccomp_notif_resp resp = {};
4350 	int status, listener;
4351 	pid_t pid;
4352 	long ret;
4353 
4354 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
4355 	ASSERT_EQ(0, ret) {
4356 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
4357 	}
4358 
4359 	listener = user_notif_syscall(__NR_getppid,
4360 				      SECCOMP_FILTER_FLAG_NEW_LISTENER);
4361 	ASSERT_GE(listener, 0);
4362 
4363 	/* Try to set invalid flags. */
4364 	EXPECT_SYSCALL_RETURN(-EINVAL,
4365 		ioctl(listener, SECCOMP_IOCTL_NOTIF_SET_FLAGS, 0xffffffff, 0));
4366 
4367 	ASSERT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SET_FLAGS,
4368 			SECCOMP_USER_NOTIF_FD_SYNC_WAKE_UP, 0), 0);
4369 
4370 	pid = fork();
4371 	ASSERT_GE(pid, 0);
4372 	if (pid == 0) {
4373 		ret = syscall(__NR_getppid);
4374 		ASSERT_EQ(ret, USER_NOTIF_MAGIC) {
4375 			_exit(1);
4376 		}
4377 		_exit(0);
4378 	}
4379 
4380 	req.pid = 0;
4381 	ASSERT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
4382 
4383 	ASSERT_EQ(req.data.nr,  __NR_getppid);
4384 
4385 	resp.id = req.id;
4386 	resp.error = 0;
4387 	resp.val = USER_NOTIF_MAGIC;
4388 	resp.flags = 0;
4389 	ASSERT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
4390 
4391 	ASSERT_EQ(waitpid(pid, &status, 0), pid);
4392 	ASSERT_EQ(status, 0);
4393 }
4394 
4395 
4396 /* Make sure PTRACE_O_SUSPEND_SECCOMP requires CAP_SYS_ADMIN. */
FIXTURE(O_SUSPEND_SECCOMP)4397 FIXTURE(O_SUSPEND_SECCOMP) {
4398 	pid_t pid;
4399 };
4400 
FIXTURE_SETUP(O_SUSPEND_SECCOMP)4401 FIXTURE_SETUP(O_SUSPEND_SECCOMP)
4402 {
4403 	ERRNO_FILTER(block_read, E2BIG);
4404 	cap_value_t cap_list[] = { CAP_SYS_ADMIN };
4405 	cap_t caps;
4406 
4407 	self->pid = 0;
4408 
4409 	/* make sure we don't have CAP_SYS_ADMIN */
4410 	caps = cap_get_proc();
4411 	ASSERT_NE(NULL, caps);
4412 	ASSERT_EQ(0, cap_set_flag(caps, CAP_EFFECTIVE, 1, cap_list, CAP_CLEAR));
4413 	ASSERT_EQ(0, cap_set_proc(caps));
4414 	cap_free(caps);
4415 
4416 	ASSERT_EQ(0, prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0));
4417 	ASSERT_EQ(0, prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog_block_read));
4418 
4419 	self->pid = fork();
4420 	ASSERT_GE(self->pid, 0);
4421 
4422 	if (self->pid == 0) {
4423 		while (1)
4424 			pause();
4425 		_exit(127);
4426 	}
4427 }
4428 
FIXTURE_TEARDOWN(O_SUSPEND_SECCOMP)4429 FIXTURE_TEARDOWN(O_SUSPEND_SECCOMP)
4430 {
4431 	if (self->pid)
4432 		kill(self->pid, SIGKILL);
4433 }
4434 
TEST_F(O_SUSPEND_SECCOMP,setoptions)4435 TEST_F(O_SUSPEND_SECCOMP, setoptions)
4436 {
4437 	int wstatus;
4438 
4439 	ASSERT_EQ(0, ptrace(PTRACE_ATTACH, self->pid, NULL, 0));
4440 	ASSERT_EQ(self->pid, wait(&wstatus));
4441 	ASSERT_EQ(-1, ptrace(PTRACE_SETOPTIONS, self->pid, NULL, PTRACE_O_SUSPEND_SECCOMP));
4442 	if (errno == EINVAL)
4443 		SKIP(return, "Kernel does not support PTRACE_O_SUSPEND_SECCOMP (missing CONFIG_CHECKPOINT_RESTORE?)");
4444 	ASSERT_EQ(EPERM, errno);
4445 }
4446 
TEST_F(O_SUSPEND_SECCOMP,seize)4447 TEST_F(O_SUSPEND_SECCOMP, seize)
4448 {
4449 	int ret;
4450 
4451 	ret = ptrace(PTRACE_SEIZE, self->pid, NULL, PTRACE_O_SUSPEND_SECCOMP);
4452 	ASSERT_EQ(-1, ret);
4453 	if (errno == EINVAL)
4454 		SKIP(return, "Kernel does not support PTRACE_O_SUSPEND_SECCOMP (missing CONFIG_CHECKPOINT_RESTORE?)");
4455 	ASSERT_EQ(EPERM, errno);
4456 }
4457 
4458 /*
4459  * get_nth - Get the nth, space separated entry in a file.
4460  *
4461  * Returns the length of the read field.
4462  * Throws error if field is zero-lengthed.
4463  */
get_nth(struct __test_metadata * _metadata,const char * path,const unsigned int position,char ** entry)4464 static ssize_t get_nth(struct __test_metadata *_metadata, const char *path,
4465 		     const unsigned int position, char **entry)
4466 {
4467 	char *line = NULL;
4468 	unsigned int i;
4469 	ssize_t nread;
4470 	size_t len = 0;
4471 	FILE *f;
4472 
4473 	f = fopen(path, "r");
4474 	ASSERT_NE(f, NULL) {
4475 		TH_LOG("Could not open %s: %s", path, strerror(errno));
4476 	}
4477 
4478 	for (i = 0; i < position; i++) {
4479 		nread = getdelim(&line, &len, ' ', f);
4480 		ASSERT_GE(nread, 0) {
4481 			TH_LOG("Failed to read %d entry in file %s", i, path);
4482 		}
4483 	}
4484 	fclose(f);
4485 
4486 	ASSERT_GT(nread, 0) {
4487 		TH_LOG("Entry in file %s had zero length", path);
4488 	}
4489 
4490 	*entry = line;
4491 	return nread - 1;
4492 }
4493 
4494 /* For a given PID, get the task state (D, R, etc...) */
get_proc_stat(struct __test_metadata * _metadata,pid_t pid)4495 static char get_proc_stat(struct __test_metadata *_metadata, pid_t pid)
4496 {
4497 	char proc_path[100] = {0};
4498 	char status;
4499 	char *line;
4500 
4501 	snprintf(proc_path, sizeof(proc_path), "/proc/%d/stat", pid);
4502 	ASSERT_EQ(get_nth(_metadata, proc_path, 3, &line), 1);
4503 
4504 	status = *line;
4505 	free(line);
4506 
4507 	return status;
4508 }
4509 
TEST(user_notification_fifo)4510 TEST(user_notification_fifo)
4511 {
4512 	struct seccomp_notif_resp resp = {};
4513 	struct seccomp_notif req = {};
4514 	int i, status, listener;
4515 	pid_t pid, pids[3];
4516 	__u64 baseid;
4517 	long ret;
4518 	/* 100 ms */
4519 	struct timespec delay = { .tv_nsec = 100000000 };
4520 
4521 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
4522 	ASSERT_EQ(0, ret) {
4523 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
4524 	}
4525 
4526 	/* Setup a listener */
4527 	listener = user_notif_syscall(__NR_getppid,
4528 				      SECCOMP_FILTER_FLAG_NEW_LISTENER);
4529 	ASSERT_GE(listener, 0);
4530 
4531 	pid = fork();
4532 	ASSERT_GE(pid, 0);
4533 
4534 	if (pid == 0) {
4535 		ret = syscall(__NR_getppid);
4536 		exit(ret != USER_NOTIF_MAGIC);
4537 	}
4538 
4539 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
4540 	baseid = req.id + 1;
4541 
4542 	resp.id = req.id;
4543 	resp.error = 0;
4544 	resp.val = USER_NOTIF_MAGIC;
4545 
4546 	/* check that we make sure flags == 0 */
4547 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
4548 
4549 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
4550 	EXPECT_EQ(true, WIFEXITED(status));
4551 	EXPECT_EQ(0, WEXITSTATUS(status));
4552 
4553 	/* Start children, and generate notifications */
4554 	for (i = 0; i < ARRAY_SIZE(pids); i++) {
4555 		pid = fork();
4556 		if (pid == 0) {
4557 			ret = syscall(__NR_getppid);
4558 			exit(ret != USER_NOTIF_MAGIC);
4559 		}
4560 		pids[i] = pid;
4561 	}
4562 
4563 	/* This spins until all of the children are sleeping */
4564 restart_wait:
4565 	for (i = 0; i < ARRAY_SIZE(pids); i++) {
4566 		if (get_proc_stat(_metadata, pids[i]) != 'S') {
4567 			nanosleep(&delay, NULL);
4568 			goto restart_wait;
4569 		}
4570 	}
4571 
4572 	/* Read the notifications in order (and respond) */
4573 	for (i = 0; i < ARRAY_SIZE(pids); i++) {
4574 		memset(&req, 0, sizeof(req));
4575 		EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
4576 		EXPECT_EQ(req.id, baseid + i);
4577 		resp.id = req.id;
4578 		EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
4579 	}
4580 
4581 	/* Make sure notifications were received */
4582 	for (i = 0; i < ARRAY_SIZE(pids); i++) {
4583 		EXPECT_EQ(waitpid(pids[i], &status, 0), pids[i]);
4584 		EXPECT_EQ(true, WIFEXITED(status));
4585 		EXPECT_EQ(0, WEXITSTATUS(status));
4586 	}
4587 }
4588 
4589 /* get_proc_syscall - Get the syscall in progress for a given pid
4590  *
4591  * Returns the current syscall number for a given process
4592  * Returns -1 if not in syscall (running or blocked)
4593  */
get_proc_syscall(struct __test_metadata * _metadata,int pid)4594 static long get_proc_syscall(struct __test_metadata *_metadata, int pid)
4595 {
4596 	char proc_path[100] = {0};
4597 	long ret = -1;
4598 	ssize_t nread;
4599 	char *line;
4600 
4601 	snprintf(proc_path, sizeof(proc_path), "/proc/%d/syscall", pid);
4602 	nread = get_nth(_metadata, proc_path, 1, &line);
4603 	ASSERT_GT(nread, 0);
4604 
4605 	if (!strncmp("running", line, MIN(7, nread)))
4606 		ret = strtol(line, NULL, 16);
4607 
4608 	free(line);
4609 	return ret;
4610 }
4611 
4612 /* Ensure non-fatal signals prior to receive are unmodified */
TEST(user_notification_wait_killable_pre_notification)4613 TEST(user_notification_wait_killable_pre_notification)
4614 {
4615 	struct sigaction new_action = {
4616 		.sa_handler = signal_handler,
4617 	};
4618 	int listener, status, sk_pair[2];
4619 	pid_t pid;
4620 	long ret;
4621 	char c;
4622 	/* 100 ms */
4623 	struct timespec delay = { .tv_nsec = 100000000 };
4624 
4625 	ASSERT_EQ(sigemptyset(&new_action.sa_mask), 0);
4626 
4627 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
4628 	ASSERT_EQ(0, ret)
4629 	{
4630 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
4631 	}
4632 
4633 	ASSERT_EQ(socketpair(PF_LOCAL, SOCK_SEQPACKET, 0, sk_pair), 0);
4634 
4635 	listener = user_notif_syscall(
4636 		__NR_getppid, SECCOMP_FILTER_FLAG_NEW_LISTENER |
4637 				      SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV);
4638 	ASSERT_GE(listener, 0);
4639 
4640 	/*
4641 	 * Check that we can kill the process with SIGUSR1 prior to receiving
4642 	 * the notification. SIGUSR1 is wired up to a custom signal handler,
4643 	 * and make sure it gets called.
4644 	 */
4645 	pid = fork();
4646 	ASSERT_GE(pid, 0);
4647 
4648 	if (pid == 0) {
4649 		close(sk_pair[0]);
4650 		handled = sk_pair[1];
4651 
4652 		/* Setup the non-fatal sigaction without SA_RESTART */
4653 		if (sigaction(SIGUSR1, &new_action, NULL)) {
4654 			perror("sigaction");
4655 			exit(1);
4656 		}
4657 
4658 		ret = syscall(__NR_getppid);
4659 		/* Make sure we got a return from a signal interruption */
4660 		exit(ret != -1 || errno != EINTR);
4661 	}
4662 
4663 	/*
4664 	 * Make sure we've gotten to the seccomp user notification wait
4665 	 * from getppid prior to sending any signals
4666 	 */
4667 	while (get_proc_syscall(_metadata, pid) != __NR_getppid &&
4668 	       get_proc_stat(_metadata, pid) != 'S')
4669 		nanosleep(&delay, NULL);
4670 
4671 	/* Send non-fatal kill signal */
4672 	EXPECT_EQ(kill(pid, SIGUSR1), 0);
4673 
4674 	/* wait for process to exit (exit checks for EINTR) */
4675 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
4676 	EXPECT_EQ(true, WIFEXITED(status));
4677 	EXPECT_EQ(0, WEXITSTATUS(status));
4678 
4679 	EXPECT_EQ(read(sk_pair[0], &c, 1), 1);
4680 }
4681 
4682 /* Ensure non-fatal signals after receive are blocked */
TEST(user_notification_wait_killable)4683 TEST(user_notification_wait_killable)
4684 {
4685 	struct sigaction new_action = {
4686 		.sa_handler = signal_handler,
4687 	};
4688 	struct seccomp_notif_resp resp = {};
4689 	struct seccomp_notif req = {};
4690 	int listener, status, sk_pair[2];
4691 	pid_t pid;
4692 	long ret;
4693 	char c;
4694 	/* 100 ms */
4695 	struct timespec delay = { .tv_nsec = 100000000 };
4696 
4697 	ASSERT_EQ(sigemptyset(&new_action.sa_mask), 0);
4698 
4699 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
4700 	ASSERT_EQ(0, ret)
4701 	{
4702 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
4703 	}
4704 
4705 	ASSERT_EQ(socketpair(PF_LOCAL, SOCK_SEQPACKET, 0, sk_pair), 0);
4706 
4707 	listener = user_notif_syscall(
4708 		__NR_getppid, SECCOMP_FILTER_FLAG_NEW_LISTENER |
4709 				      SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV);
4710 	ASSERT_GE(listener, 0);
4711 
4712 	pid = fork();
4713 	ASSERT_GE(pid, 0);
4714 
4715 	if (pid == 0) {
4716 		close(sk_pair[0]);
4717 		handled = sk_pair[1];
4718 
4719 		/* Setup the sigaction without SA_RESTART */
4720 		if (sigaction(SIGUSR1, &new_action, NULL)) {
4721 			perror("sigaction");
4722 			exit(1);
4723 		}
4724 
4725 		/* Make sure that the syscall is completed (no EINTR) */
4726 		ret = syscall(__NR_getppid);
4727 		exit(ret != USER_NOTIF_MAGIC);
4728 	}
4729 
4730 	/*
4731 	 * Get the notification, to make move the notifying process into a
4732 	 * non-preemptible (TASK_KILLABLE) state.
4733 	 */
4734 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
4735 	/* Send non-fatal kill signal */
4736 	EXPECT_EQ(kill(pid, SIGUSR1), 0);
4737 
4738 	/*
4739 	 * Make sure the task enters moves to TASK_KILLABLE by waiting for
4740 	 * D (Disk Sleep) state after receiving non-fatal signal.
4741 	 */
4742 	while (get_proc_stat(_metadata, pid) != 'D')
4743 		nanosleep(&delay, NULL);
4744 
4745 	resp.id = req.id;
4746 	resp.val = USER_NOTIF_MAGIC;
4747 	/* Make sure the notification is found and able to be replied to */
4748 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
4749 
4750 	/*
4751 	 * Make sure that the signal handler does get called once we're back in
4752 	 * userspace.
4753 	 */
4754 	EXPECT_EQ(read(sk_pair[0], &c, 1), 1);
4755 	/* wait for process to exit (exit checks for USER_NOTIF_MAGIC) */
4756 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
4757 	EXPECT_EQ(true, WIFEXITED(status));
4758 	EXPECT_EQ(0, WEXITSTATUS(status));
4759 }
4760 
4761 /* Ensure fatal signals after receive are not blocked */
TEST(user_notification_wait_killable_fatal)4762 TEST(user_notification_wait_killable_fatal)
4763 {
4764 	struct seccomp_notif req = {};
4765 	int listener, status;
4766 	pid_t pid;
4767 	long ret;
4768 	/* 100 ms */
4769 	struct timespec delay = { .tv_nsec = 100000000 };
4770 
4771 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
4772 	ASSERT_EQ(0, ret)
4773 	{
4774 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
4775 	}
4776 
4777 	listener = user_notif_syscall(
4778 		__NR_getppid, SECCOMP_FILTER_FLAG_NEW_LISTENER |
4779 				      SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV);
4780 	ASSERT_GE(listener, 0);
4781 
4782 	pid = fork();
4783 	ASSERT_GE(pid, 0);
4784 
4785 	if (pid == 0) {
4786 		/* This should never complete as it should get a SIGTERM */
4787 		syscall(__NR_getppid);
4788 		exit(1);
4789 	}
4790 
4791 	while (get_proc_stat(_metadata, pid) != 'S')
4792 		nanosleep(&delay, NULL);
4793 
4794 	/*
4795 	 * Get the notification, to make move the notifying process into a
4796 	 * non-preemptible (TASK_KILLABLE) state.
4797 	 */
4798 	EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
4799 	/* Kill the process with a fatal signal */
4800 	EXPECT_EQ(kill(pid, SIGTERM), 0);
4801 
4802 	/*
4803 	 * Wait for the process to exit, and make sure the process terminated
4804 	 * due to the SIGTERM signal.
4805 	 */
4806 	EXPECT_EQ(waitpid(pid, &status, 0), pid);
4807 	EXPECT_EQ(true, WIFSIGNALED(status));
4808 	EXPECT_EQ(SIGTERM, WTERMSIG(status));
4809 }
4810 
4811 struct tsync_vs_thread_leader_args {
4812 	pthread_t leader;
4813 };
4814 
tsync_vs_dead_thread_leader_sibling(void * _args)4815 static void *tsync_vs_dead_thread_leader_sibling(void *_args)
4816 {
4817 	struct sock_filter allow_filter[] = {
4818 		BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
4819 	};
4820 	struct sock_fprog allow_prog = {
4821 		.len = (unsigned short)ARRAY_SIZE(allow_filter),
4822 		.filter = allow_filter,
4823 	};
4824 	struct tsync_vs_thread_leader_args *args = _args;
4825 	void *retval;
4826 	long ret;
4827 
4828 	ret = pthread_join(args->leader, &retval);
4829 	if (ret)
4830 		exit(1);
4831 	if (retval != _args)
4832 		exit(2);
4833 	ret = seccomp(SECCOMP_SET_MODE_FILTER, SECCOMP_FILTER_FLAG_TSYNC, &allow_prog);
4834 	if (ret)
4835 		exit(3);
4836 
4837 	exit(0);
4838 }
4839 
4840 /*
4841  * Ensure that a dead thread leader doesn't prevent installing new filters with
4842  * SECCOMP_FILTER_FLAG_TSYNC from other threads.
4843  */
TEST(tsync_vs_dead_thread_leader)4844 TEST(tsync_vs_dead_thread_leader)
4845 {
4846 	int status;
4847 	pid_t pid;
4848 	long ret;
4849 
4850 	ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0);
4851 	ASSERT_EQ(0, ret) {
4852 		TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!");
4853 	}
4854 
4855 	pid = fork();
4856 	ASSERT_GE(pid, 0);
4857 
4858 	if (pid == 0) {
4859 		struct sock_filter allow_filter[] = {
4860 			BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW),
4861 		};
4862 		struct sock_fprog allow_prog = {
4863 			.len = (unsigned short)ARRAY_SIZE(allow_filter),
4864 			.filter = allow_filter,
4865 		};
4866 		struct  tsync_vs_thread_leader_args *args;
4867 		pthread_t sibling;
4868 
4869 		args = malloc(sizeof(*args));
4870 		ASSERT_NE(NULL, args);
4871 		args->leader = pthread_self();
4872 
4873 		ret = pthread_create(&sibling, NULL,
4874 				     tsync_vs_dead_thread_leader_sibling, args);
4875 		ASSERT_EQ(0, ret);
4876 
4877 		/* Install a new filter just to the leader thread. */
4878 		ret = seccomp(SECCOMP_SET_MODE_FILTER, 0, &allow_prog);
4879 		ASSERT_EQ(0, ret);
4880 		pthread_exit(args);
4881 		exit(1);
4882 	}
4883 
4884 	EXPECT_EQ(pid, waitpid(pid, &status, 0));
4885 	EXPECT_EQ(0, status);
4886 }
4887 
4888 /*
4889  * TODO:
4890  * - expand NNP testing
4891  * - better arch-specific TRACE and TRAP handlers.
4892  * - endianness checking when appropriate
4893  * - 64-bit arg prodding
4894  * - arch value testing (x86 modes especially)
4895  * - verify that FILTER_FLAG_LOG filters generate log messages
4896  * - verify that RET_LOG generates log messages
4897  */
4898 
4899 TEST_HARNESS_MAIN
4900