• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 // SPDX-License-Identifier: GPL-2.0
2 /* Copyright 2018 Marty E. Plummer <hanetzer@startmail.com> */
3 /* Copyright 2019 Linaro, Ltd., Rob Herring <robh@kernel.org> */
4 /* Copyright 2019 Collabora ltd. */
5 
6 #include <linux/module.h>
7 #include <linux/of_platform.h>
8 #include <linux/pagemap.h>
9 #include <linux/pm_runtime.h>
10 #include <drm/panfrost_drm.h>
11 #include <drm/drm_drv.h>
12 #include <drm/drm_ioctl.h>
13 #include <drm/drm_syncobj.h>
14 #include <drm/drm_utils.h>
15 
16 #include "panfrost_device.h"
17 #include "panfrost_gem.h"
18 #include "panfrost_mmu.h"
19 #include "panfrost_job.h"
20 #include "panfrost_gpu.h"
21 #include "panfrost_perfcnt.h"
22 
23 static bool unstable_ioctls;
24 module_param_unsafe(unstable_ioctls, bool, 0600);
25 
panfrost_ioctl_get_param(struct drm_device * ddev,void * data,struct drm_file * file)26 static int panfrost_ioctl_get_param(struct drm_device *ddev, void *data, struct drm_file *file)
27 {
28 	struct drm_panfrost_get_param *param = data;
29 	struct panfrost_device *pfdev = ddev->dev_private;
30 
31 	if (param->pad != 0)
32 		return -EINVAL;
33 
34 #define PANFROST_FEATURE(name, member)			\
35 	case DRM_PANFROST_PARAM_ ## name:		\
36 		param->value = pfdev->features.member;	\
37 		break
38 #define PANFROST_FEATURE_ARRAY(name, member, max)			\
39 	case DRM_PANFROST_PARAM_ ## name ## 0 ...			\
40 		DRM_PANFROST_PARAM_ ## name ## max:			\
41 		param->value = pfdev->features.member[param->param -	\
42 			DRM_PANFROST_PARAM_ ## name ## 0];		\
43 		break
44 
45 	switch (param->param) {
46 		PANFROST_FEATURE(GPU_PROD_ID, id);
47 		PANFROST_FEATURE(GPU_REVISION, revision);
48 		PANFROST_FEATURE(SHADER_PRESENT, shader_present);
49 		PANFROST_FEATURE(TILER_PRESENT, tiler_present);
50 		PANFROST_FEATURE(L2_PRESENT, l2_present);
51 		PANFROST_FEATURE(STACK_PRESENT, stack_present);
52 		PANFROST_FEATURE(AS_PRESENT, as_present);
53 		PANFROST_FEATURE(JS_PRESENT, js_present);
54 		PANFROST_FEATURE(L2_FEATURES, l2_features);
55 		PANFROST_FEATURE(CORE_FEATURES, core_features);
56 		PANFROST_FEATURE(TILER_FEATURES, tiler_features);
57 		PANFROST_FEATURE(MEM_FEATURES, mem_features);
58 		PANFROST_FEATURE(MMU_FEATURES, mmu_features);
59 		PANFROST_FEATURE(THREAD_FEATURES, thread_features);
60 		PANFROST_FEATURE(MAX_THREADS, max_threads);
61 		PANFROST_FEATURE(THREAD_MAX_WORKGROUP_SZ,
62 				thread_max_workgroup_sz);
63 		PANFROST_FEATURE(THREAD_MAX_BARRIER_SZ,
64 				thread_max_barrier_sz);
65 		PANFROST_FEATURE(COHERENCY_FEATURES, coherency_features);
66 		PANFROST_FEATURE_ARRAY(TEXTURE_FEATURES, texture_features, 3);
67 		PANFROST_FEATURE_ARRAY(JS_FEATURES, js_features, 15);
68 		PANFROST_FEATURE(NR_CORE_GROUPS, nr_core_groups);
69 		PANFROST_FEATURE(THREAD_TLS_ALLOC, thread_tls_alloc);
70 	default:
71 		return -EINVAL;
72 	}
73 
74 	return 0;
75 }
76 
panfrost_ioctl_create_bo(struct drm_device * dev,void * data,struct drm_file * file)77 static int panfrost_ioctl_create_bo(struct drm_device *dev, void *data,
78 		struct drm_file *file)
79 {
80 	struct panfrost_file_priv *priv = file->driver_priv;
81 	struct panfrost_gem_object *bo;
82 	struct drm_panfrost_create_bo *args = data;
83 	struct panfrost_gem_mapping *mapping;
84 
85 	if (!args->size || args->pad ||
86 	    (args->flags & ~(PANFROST_BO_NOEXEC | PANFROST_BO_HEAP)))
87 		return -EINVAL;
88 
89 	/* Heaps should never be executable */
90 	if ((args->flags & PANFROST_BO_HEAP) &&
91 	    !(args->flags & PANFROST_BO_NOEXEC))
92 		return -EINVAL;
93 
94 	bo = panfrost_gem_create_with_handle(file, dev, args->size, args->flags,
95 					     &args->handle);
96 	if (IS_ERR(bo))
97 		return PTR_ERR(bo);
98 
99 	mapping = panfrost_gem_mapping_get(bo, priv);
100 	if (!mapping) {
101 		drm_gem_object_put(&bo->base.base);
102 		return -EINVAL;
103 	}
104 
105 	args->offset = mapping->mmnode.start << PAGE_SHIFT;
106 	panfrost_gem_mapping_put(mapping);
107 
108 	return 0;
109 }
110 
111 /**
112  * panfrost_lookup_bos() - Sets up job->bo[] with the GEM objects
113  * referenced by the job.
114  * @dev: DRM device
115  * @file_priv: DRM file for this fd
116  * @args: IOCTL args
117  * @job: job being set up
118  *
119  * Resolve handles from userspace to BOs and attach them to job.
120  *
121  * Note that this function doesn't need to unreference the BOs on
122  * failure, because that will happen at panfrost_job_cleanup() time.
123  */
124 static int
panfrost_lookup_bos(struct drm_device * dev,struct drm_file * file_priv,struct drm_panfrost_submit * args,struct panfrost_job * job)125 panfrost_lookup_bos(struct drm_device *dev,
126 		  struct drm_file *file_priv,
127 		  struct drm_panfrost_submit *args,
128 		  struct panfrost_job *job)
129 {
130 	struct panfrost_file_priv *priv = file_priv->driver_priv;
131 	struct panfrost_gem_object *bo;
132 	unsigned int i;
133 	int ret;
134 
135 	job->bo_count = args->bo_handle_count;
136 
137 	if (!job->bo_count)
138 		return 0;
139 
140 	job->implicit_fences = kvmalloc_array(job->bo_count,
141 				  sizeof(struct dma_fence *),
142 				  GFP_KERNEL | __GFP_ZERO);
143 	if (!job->implicit_fences)
144 		return -ENOMEM;
145 
146 	ret = drm_gem_objects_lookup(file_priv,
147 				     (void __user *)(uintptr_t)args->bo_handles,
148 				     job->bo_count, &job->bos);
149 	if (ret)
150 		return ret;
151 
152 	job->mappings = kvmalloc_array(job->bo_count,
153 				       sizeof(struct panfrost_gem_mapping *),
154 				       GFP_KERNEL | __GFP_ZERO);
155 	if (!job->mappings)
156 		return -ENOMEM;
157 
158 	for (i = 0; i < job->bo_count; i++) {
159 		struct panfrost_gem_mapping *mapping;
160 
161 		bo = to_panfrost_bo(job->bos[i]);
162 		mapping = panfrost_gem_mapping_get(bo, priv);
163 		if (!mapping) {
164 			ret = -EINVAL;
165 			break;
166 		}
167 
168 		atomic_inc(&bo->gpu_usecount);
169 		job->mappings[i] = mapping;
170 	}
171 
172 	return ret;
173 }
174 
175 /**
176  * panfrost_copy_in_sync() - Sets up job->in_fences[] with the sync objects
177  * referenced by the job.
178  * @dev: DRM device
179  * @file_priv: DRM file for this fd
180  * @args: IOCTL args
181  * @job: job being set up
182  *
183  * Resolve syncobjs from userspace to fences and attach them to job.
184  *
185  * Note that this function doesn't need to unreference the fences on
186  * failure, because that will happen at panfrost_job_cleanup() time.
187  */
188 static int
panfrost_copy_in_sync(struct drm_device * dev,struct drm_file * file_priv,struct drm_panfrost_submit * args,struct panfrost_job * job)189 panfrost_copy_in_sync(struct drm_device *dev,
190 		  struct drm_file *file_priv,
191 		  struct drm_panfrost_submit *args,
192 		  struct panfrost_job *job)
193 {
194 	u32 *handles;
195 	int ret = 0;
196 	int i;
197 
198 	job->in_fence_count = args->in_sync_count;
199 
200 	if (!job->in_fence_count)
201 		return 0;
202 
203 	job->in_fences = kvmalloc_array(job->in_fence_count,
204 					sizeof(struct dma_fence *),
205 					GFP_KERNEL | __GFP_ZERO);
206 	if (!job->in_fences) {
207 		DRM_DEBUG("Failed to allocate job in fences\n");
208 		return -ENOMEM;
209 	}
210 
211 	handles = kvmalloc_array(job->in_fence_count, sizeof(u32), GFP_KERNEL);
212 	if (!handles) {
213 		ret = -ENOMEM;
214 		DRM_DEBUG("Failed to allocate incoming syncobj handles\n");
215 		goto fail;
216 	}
217 
218 	if (copy_from_user(handles,
219 			   (void __user *)(uintptr_t)args->in_syncs,
220 			   job->in_fence_count * sizeof(u32))) {
221 		ret = -EFAULT;
222 		DRM_DEBUG("Failed to copy in syncobj handles\n");
223 		goto fail;
224 	}
225 
226 	for (i = 0; i < job->in_fence_count; i++) {
227 		ret = drm_syncobj_find_fence(file_priv, handles[i], 0, 0,
228 					     &job->in_fences[i]);
229 		if (ret == -EINVAL)
230 			goto fail;
231 	}
232 
233 fail:
234 	kvfree(handles);
235 	return ret;
236 }
237 
panfrost_ioctl_submit(struct drm_device * dev,void * data,struct drm_file * file)238 static int panfrost_ioctl_submit(struct drm_device *dev, void *data,
239 		struct drm_file *file)
240 {
241 	struct panfrost_device *pfdev = dev->dev_private;
242 	struct drm_panfrost_submit *args = data;
243 	struct drm_syncobj *sync_out = NULL;
244 	struct panfrost_job *job;
245 	int ret = 0;
246 
247 	if (!args->jc)
248 		return -EINVAL;
249 
250 	if (args->requirements && args->requirements != PANFROST_JD_REQ_FS)
251 		return -EINVAL;
252 
253 	if (args->out_sync > 0) {
254 		sync_out = drm_syncobj_find(file, args->out_sync);
255 		if (!sync_out)
256 			return -ENODEV;
257 	}
258 
259 	job = kzalloc(sizeof(*job), GFP_KERNEL);
260 	if (!job) {
261 		ret = -ENOMEM;
262 		goto fail_out_sync;
263 	}
264 
265 	kref_init(&job->refcount);
266 
267 	job->pfdev = pfdev;
268 	job->jc = args->jc;
269 	job->requirements = args->requirements;
270 	job->flush_id = panfrost_gpu_get_latest_flush_id(pfdev);
271 	job->file_priv = file->driver_priv;
272 
273 	ret = panfrost_copy_in_sync(dev, file, args, job);
274 	if (ret)
275 		goto fail_job;
276 
277 	ret = panfrost_lookup_bos(dev, file, args, job);
278 	if (ret)
279 		goto fail_job;
280 
281 	ret = panfrost_job_push(job);
282 	if (ret)
283 		goto fail_job;
284 
285 	/* Update the return sync object for the job */
286 	if (sync_out)
287 		drm_syncobj_replace_fence(sync_out, job->render_done_fence);
288 
289 fail_job:
290 	panfrost_job_put(job);
291 fail_out_sync:
292 	if (sync_out)
293 		drm_syncobj_put(sync_out);
294 
295 	return ret;
296 }
297 
298 static int
panfrost_ioctl_wait_bo(struct drm_device * dev,void * data,struct drm_file * file_priv)299 panfrost_ioctl_wait_bo(struct drm_device *dev, void *data,
300 		       struct drm_file *file_priv)
301 {
302 	long ret;
303 	struct drm_panfrost_wait_bo *args = data;
304 	struct drm_gem_object *gem_obj;
305 	unsigned long timeout = drm_timeout_abs_to_jiffies(args->timeout_ns);
306 
307 	if (args->pad)
308 		return -EINVAL;
309 
310 	gem_obj = drm_gem_object_lookup(file_priv, args->handle);
311 	if (!gem_obj)
312 		return -ENOENT;
313 
314 	ret = dma_resv_wait_timeout_rcu(gem_obj->resv, true,
315 						  true, timeout);
316 	if (!ret)
317 		ret = timeout ? -ETIMEDOUT : -EBUSY;
318 
319 	drm_gem_object_put(gem_obj);
320 
321 	return ret;
322 }
323 
panfrost_ioctl_mmap_bo(struct drm_device * dev,void * data,struct drm_file * file_priv)324 static int panfrost_ioctl_mmap_bo(struct drm_device *dev, void *data,
325 		      struct drm_file *file_priv)
326 {
327 	struct drm_panfrost_mmap_bo *args = data;
328 	struct drm_gem_object *gem_obj;
329 	int ret;
330 
331 	if (args->flags != 0) {
332 		DRM_INFO("unknown mmap_bo flags: %d\n", args->flags);
333 		return -EINVAL;
334 	}
335 
336 	gem_obj = drm_gem_object_lookup(file_priv, args->handle);
337 	if (!gem_obj) {
338 		DRM_DEBUG("Failed to look up GEM BO %d\n", args->handle);
339 		return -ENOENT;
340 	}
341 
342 	/* Don't allow mmapping of heap objects as pages are not pinned. */
343 	if (to_panfrost_bo(gem_obj)->is_heap) {
344 		ret = -EINVAL;
345 		goto out;
346 	}
347 
348 	ret = drm_gem_create_mmap_offset(gem_obj);
349 	if (ret == 0)
350 		args->offset = drm_vma_node_offset_addr(&gem_obj->vma_node);
351 
352 out:
353 	drm_gem_object_put(gem_obj);
354 	return ret;
355 }
356 
panfrost_ioctl_get_bo_offset(struct drm_device * dev,void * data,struct drm_file * file_priv)357 static int panfrost_ioctl_get_bo_offset(struct drm_device *dev, void *data,
358 			    struct drm_file *file_priv)
359 {
360 	struct panfrost_file_priv *priv = file_priv->driver_priv;
361 	struct drm_panfrost_get_bo_offset *args = data;
362 	struct panfrost_gem_mapping *mapping;
363 	struct drm_gem_object *gem_obj;
364 	struct panfrost_gem_object *bo;
365 
366 	gem_obj = drm_gem_object_lookup(file_priv, args->handle);
367 	if (!gem_obj) {
368 		DRM_DEBUG("Failed to look up GEM BO %d\n", args->handle);
369 		return -ENOENT;
370 	}
371 	bo = to_panfrost_bo(gem_obj);
372 
373 	mapping = panfrost_gem_mapping_get(bo, priv);
374 	drm_gem_object_put(gem_obj);
375 
376 	if (!mapping)
377 		return -EINVAL;
378 
379 	args->offset = mapping->mmnode.start << PAGE_SHIFT;
380 	panfrost_gem_mapping_put(mapping);
381 	return 0;
382 }
383 
panfrost_ioctl_madvise(struct drm_device * dev,void * data,struct drm_file * file_priv)384 static int panfrost_ioctl_madvise(struct drm_device *dev, void *data,
385 				  struct drm_file *file_priv)
386 {
387 	struct panfrost_file_priv *priv = file_priv->driver_priv;
388 	struct drm_panfrost_madvise *args = data;
389 	struct panfrost_device *pfdev = dev->dev_private;
390 	struct drm_gem_object *gem_obj;
391 	struct panfrost_gem_object *bo;
392 	int ret = 0;
393 
394 	gem_obj = drm_gem_object_lookup(file_priv, args->handle);
395 	if (!gem_obj) {
396 		DRM_DEBUG("Failed to look up GEM BO %d\n", args->handle);
397 		return -ENOENT;
398 	}
399 
400 	bo = to_panfrost_bo(gem_obj);
401 
402 	mutex_lock(&pfdev->shrinker_lock);
403 	mutex_lock(&bo->mappings.lock);
404 	if (args->madv == PANFROST_MADV_DONTNEED) {
405 		struct panfrost_gem_mapping *first;
406 
407 		first = list_first_entry(&bo->mappings.list,
408 					 struct panfrost_gem_mapping,
409 					 node);
410 
411 		/*
412 		 * If we want to mark the BO purgeable, there must be only one
413 		 * user: the caller FD.
414 		 * We could do something smarter and mark the BO purgeable only
415 		 * when all its users have marked it purgeable, but globally
416 		 * visible/shared BOs are likely to never be marked purgeable
417 		 * anyway, so let's not bother.
418 		 */
419 		if (!list_is_singular(&bo->mappings.list) ||
420 		    WARN_ON_ONCE(first->mmu != priv->mmu)) {
421 			ret = -EINVAL;
422 			goto out_unlock_mappings;
423 		}
424 	}
425 
426 	args->retained = drm_gem_shmem_madvise(gem_obj, args->madv);
427 
428 	if (args->retained) {
429 		if (args->madv == PANFROST_MADV_DONTNEED)
430 			list_add_tail(&bo->base.madv_list,
431 				      &pfdev->shrinker_list);
432 		else if (args->madv == PANFROST_MADV_WILLNEED)
433 			list_del_init(&bo->base.madv_list);
434 	}
435 
436 out_unlock_mappings:
437 	mutex_unlock(&bo->mappings.lock);
438 	mutex_unlock(&pfdev->shrinker_lock);
439 
440 	drm_gem_object_put(gem_obj);
441 	return ret;
442 }
443 
panfrost_unstable_ioctl_check(void)444 int panfrost_unstable_ioctl_check(void)
445 {
446 	if (!unstable_ioctls)
447 		return -ENOSYS;
448 
449 	return 0;
450 }
451 
452 static int
panfrost_open(struct drm_device * dev,struct drm_file * file)453 panfrost_open(struct drm_device *dev, struct drm_file *file)
454 {
455 	int ret;
456 	struct panfrost_device *pfdev = dev->dev_private;
457 	struct panfrost_file_priv *panfrost_priv;
458 
459 	panfrost_priv = kzalloc(sizeof(*panfrost_priv), GFP_KERNEL);
460 	if (!panfrost_priv)
461 		return -ENOMEM;
462 
463 	panfrost_priv->pfdev = pfdev;
464 	file->driver_priv = panfrost_priv;
465 
466 	panfrost_priv->mmu = panfrost_mmu_ctx_create(pfdev);
467 	if (IS_ERR(panfrost_priv->mmu)) {
468 		ret = PTR_ERR(panfrost_priv->mmu);
469 		goto err_free;
470 	}
471 
472 	ret = panfrost_job_open(panfrost_priv);
473 	if (ret)
474 		goto err_job;
475 
476 	return 0;
477 
478 err_job:
479 	panfrost_mmu_ctx_put(panfrost_priv->mmu);
480 err_free:
481 	kfree(panfrost_priv);
482 	return ret;
483 }
484 
485 static void
panfrost_postclose(struct drm_device * dev,struct drm_file * file)486 panfrost_postclose(struct drm_device *dev, struct drm_file *file)
487 {
488 	struct panfrost_file_priv *panfrost_priv = file->driver_priv;
489 
490 	panfrost_perfcnt_close(file);
491 	panfrost_job_close(panfrost_priv);
492 
493 	panfrost_mmu_ctx_put(panfrost_priv->mmu);
494 	kfree(panfrost_priv);
495 }
496 
497 static const struct drm_ioctl_desc panfrost_drm_driver_ioctls[] = {
498 #define PANFROST_IOCTL(n, func, flags) \
499 	DRM_IOCTL_DEF_DRV(PANFROST_##n, panfrost_ioctl_##func, flags)
500 
501 	PANFROST_IOCTL(SUBMIT,		submit,		DRM_RENDER_ALLOW),
502 	PANFROST_IOCTL(WAIT_BO,		wait_bo,	DRM_RENDER_ALLOW),
503 	PANFROST_IOCTL(CREATE_BO,	create_bo,	DRM_RENDER_ALLOW),
504 	PANFROST_IOCTL(MMAP_BO,		mmap_bo,	DRM_RENDER_ALLOW),
505 	PANFROST_IOCTL(GET_PARAM,	get_param,	DRM_RENDER_ALLOW),
506 	PANFROST_IOCTL(GET_BO_OFFSET,	get_bo_offset,	DRM_RENDER_ALLOW),
507 	PANFROST_IOCTL(PERFCNT_ENABLE,	perfcnt_enable,	DRM_RENDER_ALLOW),
508 	PANFROST_IOCTL(PERFCNT_DUMP,	perfcnt_dump,	DRM_RENDER_ALLOW),
509 	PANFROST_IOCTL(MADVISE,		madvise,	DRM_RENDER_ALLOW),
510 };
511 
512 DEFINE_DRM_GEM_FOPS(panfrost_drm_driver_fops);
513 
514 /*
515  * Panfrost driver version:
516  * - 1.0 - initial interface
517  * - 1.1 - adds HEAP and NOEXEC flags for CREATE_BO
518  */
519 static struct drm_driver panfrost_drm_driver = {
520 	.driver_features	= DRIVER_RENDER | DRIVER_GEM | DRIVER_SYNCOBJ,
521 	.open			= panfrost_open,
522 	.postclose		= panfrost_postclose,
523 	.ioctls			= panfrost_drm_driver_ioctls,
524 	.num_ioctls		= ARRAY_SIZE(panfrost_drm_driver_ioctls),
525 	.fops			= &panfrost_drm_driver_fops,
526 	.name			= "panfrost",
527 	.desc			= "panfrost DRM",
528 	.date			= "20180908",
529 	.major			= 1,
530 	.minor			= 1,
531 
532 	.gem_create_object	= panfrost_gem_create_object,
533 	.prime_handle_to_fd	= drm_gem_prime_handle_to_fd,
534 	.prime_fd_to_handle	= drm_gem_prime_fd_to_handle,
535 	.gem_prime_import_sg_table = panfrost_gem_prime_import_sg_table,
536 	.gem_prime_mmap		= drm_gem_prime_mmap,
537 };
538 
panfrost_probe(struct platform_device * pdev)539 static int panfrost_probe(struct platform_device *pdev)
540 {
541 	struct panfrost_device *pfdev;
542 	struct drm_device *ddev;
543 	int err;
544 
545 	pfdev = devm_kzalloc(&pdev->dev, sizeof(*pfdev), GFP_KERNEL);
546 	if (!pfdev)
547 		return -ENOMEM;
548 
549 	pfdev->pdev = pdev;
550 	pfdev->dev = &pdev->dev;
551 
552 	platform_set_drvdata(pdev, pfdev);
553 
554 	pfdev->comp = of_device_get_match_data(&pdev->dev);
555 	if (!pfdev->comp)
556 		return -ENODEV;
557 
558 	pfdev->coherent = device_get_dma_attr(&pdev->dev) == DEV_DMA_COHERENT;
559 
560 	/* Allocate and initialze the DRM device. */
561 	ddev = drm_dev_alloc(&panfrost_drm_driver, &pdev->dev);
562 	if (IS_ERR(ddev))
563 		return PTR_ERR(ddev);
564 
565 	ddev->dev_private = pfdev;
566 	pfdev->ddev = ddev;
567 
568 	mutex_init(&pfdev->shrinker_lock);
569 	INIT_LIST_HEAD(&pfdev->shrinker_list);
570 
571 	err = panfrost_device_init(pfdev);
572 	if (err) {
573 		if (err != -EPROBE_DEFER)
574 			dev_err(&pdev->dev, "Fatal error during GPU init\n");
575 		goto err_out0;
576 	}
577 
578 	pm_runtime_set_active(pfdev->dev);
579 	pm_runtime_mark_last_busy(pfdev->dev);
580 	pm_runtime_enable(pfdev->dev);
581 	pm_runtime_set_autosuspend_delay(pfdev->dev, 50); /* ~3 frames */
582 	pm_runtime_use_autosuspend(pfdev->dev);
583 
584 	/*
585 	 * Register the DRM device with the core and the connectors with
586 	 * sysfs
587 	 */
588 	err = drm_dev_register(ddev, 0);
589 	if (err < 0)
590 		goto err_out1;
591 
592 	panfrost_gem_shrinker_init(ddev);
593 
594 	return 0;
595 
596 err_out1:
597 	pm_runtime_disable(pfdev->dev);
598 	panfrost_device_fini(pfdev);
599 	pm_runtime_set_suspended(pfdev->dev);
600 err_out0:
601 	drm_dev_put(ddev);
602 	return err;
603 }
604 
panfrost_remove(struct platform_device * pdev)605 static int panfrost_remove(struct platform_device *pdev)
606 {
607 	struct panfrost_device *pfdev = platform_get_drvdata(pdev);
608 	struct drm_device *ddev = pfdev->ddev;
609 
610 	drm_dev_unregister(ddev);
611 	panfrost_gem_shrinker_cleanup(ddev);
612 
613 	pm_runtime_get_sync(pfdev->dev);
614 	pm_runtime_disable(pfdev->dev);
615 	panfrost_device_fini(pfdev);
616 	pm_runtime_set_suspended(pfdev->dev);
617 
618 	drm_dev_put(ddev);
619 	return 0;
620 }
621 
622 static const char * const default_supplies[] = { "mali" };
623 static const struct panfrost_compatible default_data = {
624 	.num_supplies = ARRAY_SIZE(default_supplies),
625 	.supply_names = default_supplies,
626 	.num_pm_domains = 1, /* optional */
627 	.pm_domain_names = NULL,
628 };
629 
630 static const struct panfrost_compatible amlogic_data = {
631 	.num_supplies = ARRAY_SIZE(default_supplies),
632 	.supply_names = default_supplies,
633 	.vendor_quirk = panfrost_gpu_amlogic_quirk,
634 };
635 
636 static const struct of_device_id dt_match[] = {
637 	/* Set first to probe before the generic compatibles */
638 	{ .compatible = "amlogic,meson-gxm-mali",
639 	  .data = &amlogic_data, },
640 	{ .compatible = "amlogic,meson-g12a-mali",
641 	  .data = &amlogic_data, },
642 	{ .compatible = "arm,mali-t604", .data = &default_data, },
643 	{ .compatible = "arm,mali-t624", .data = &default_data, },
644 	{ .compatible = "arm,mali-t628", .data = &default_data, },
645 	{ .compatible = "arm,mali-t720", .data = &default_data, },
646 	{ .compatible = "arm,mali-t760", .data = &default_data, },
647 	{ .compatible = "arm,mali-t820", .data = &default_data, },
648 	{ .compatible = "arm,mali-t830", .data = &default_data, },
649 	{ .compatible = "arm,mali-t860", .data = &default_data, },
650 	{ .compatible = "arm,mali-t880", .data = &default_data, },
651 	{ .compatible = "arm,mali-bifrost", .data = &default_data, },
652 	{}
653 };
654 MODULE_DEVICE_TABLE(of, dt_match);
655 
656 static const struct dev_pm_ops panfrost_pm_ops = {
657 	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
658 	SET_RUNTIME_PM_OPS(panfrost_device_suspend, panfrost_device_resume, NULL)
659 };
660 
661 static struct platform_driver panfrost_driver = {
662 	.probe		= panfrost_probe,
663 	.remove		= panfrost_remove,
664 	.driver		= {
665 		.name	= "panfrost",
666 		.pm	= &panfrost_pm_ops,
667 		.of_match_table = dt_match,
668 	},
669 };
670 module_platform_driver(panfrost_driver);
671 
672 MODULE_AUTHOR("Panfrost Project Developers");
673 MODULE_DESCRIPTION("Panfrost DRM Driver");
674 MODULE_LICENSE("GPL v2");
675