• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 /*
2  * Copyright 2015 Google Inc.
3  *
4  * Use of this source code is governed by a BSD-style license that can be
5  * found in the LICENSE file.
6  */
7 
8 #include "include/codec/SkAndroidCodec.h"
9 #include "include/codec/SkCodec.h"
10 #include "include/core/SkBitmap.h"
11 #include "include/core/SkCanvas.h"
12 #include "include/core/SkColor.h"
13 #include "include/core/SkColorSpace.h"
14 #include "include/core/SkData.h"
15 #include "include/core/SkEncodedImageFormat.h"
16 #include "include/core/SkImage.h"
17 #include "include/core/SkImageEncoder.h"
18 #include "include/core/SkImageGenerator.h"
19 #include "include/core/SkImageInfo.h"
20 #include "include/core/SkPixmap.h"
21 #include "include/core/SkPngChunkReader.h"
22 #include "include/core/SkRect.h"
23 #include "include/core/SkRefCnt.h"
24 #include "include/core/SkSize.h"
25 #include "include/core/SkStream.h"
26 #include "include/core/SkString.h"
27 #include "include/core/SkTypes.h"
28 #include "include/core/SkUnPreMultiply.h"
29 #include "include/encode/SkJpegEncoder.h"
30 #include "include/encode/SkPngEncoder.h"
31 #include "include/encode/SkWebpEncoder.h"
32 #include "include/private/SkMalloc.h"
33 #include "include/private/SkTemplates.h"
34 #include "include/third_party/skcms/skcms.h"
35 #include "include/utils/SkFrontBufferedStream.h"
36 #include "include/utils/SkRandom.h"
37 #include "src/codec/SkCodecImageGenerator.h"
38 #include "src/core/SkAutoMalloc.h"
39 #include "src/core/SkColorSpacePriv.h"
40 #include "src/core/SkMD5.h"
41 #include "src/core/SkMakeUnique.h"
42 #include "src/core/SkStreamPriv.h"
43 #include "tests/FakeStreams.h"
44 #include "tests/Test.h"
45 #include "tools/Resources.h"
46 #include "tools/ToolUtils.h"
47 
48 #include "png.h"
49 
50 #include <setjmp.h>
51 #include <cstring>
52 #include <initializer_list>
53 #include <memory>
54 #include <utility>
55 #include <vector>
56 
57 #if PNG_LIBPNG_VER_MAJOR == 1 && PNG_LIBPNG_VER_MINOR < 5
58     // FIXME (scroggo): Google3 needs to be updated to use a newer version of libpng. In
59     // the meantime, we had to break some pieces of SkPngCodec in order to support Google3.
60     // The parts that are broken are likely not used by Google3.
61     #define SK_PNG_DISABLE_TESTS
62 #endif
63 
md5(const SkBitmap & bm)64 static SkMD5::Digest md5(const SkBitmap& bm) {
65     SkASSERT(bm.getPixels());
66     SkMD5 md5;
67     size_t rowLen = bm.info().bytesPerPixel() * bm.width();
68     for (int y = 0; y < bm.height(); ++y) {
69         md5.write(bm.getAddr(0, y), rowLen);
70     }
71     return md5.finish();
72 }
73 
74 /**
75  *  Compute the digest for bm and compare it to a known good digest.
76  *  @param r Reporter to assert that bm's digest matches goodDigest.
77  *  @param goodDigest The known good digest to compare to.
78  *  @param bm The bitmap to test.
79  */
compare_to_good_digest(skiatest::Reporter * r,const SkMD5::Digest & goodDigest,const SkBitmap & bm)80 static void compare_to_good_digest(skiatest::Reporter* r, const SkMD5::Digest& goodDigest,
81                            const SkBitmap& bm) {
82     SkMD5::Digest digest = md5(bm);
83     REPORTER_ASSERT(r, digest == goodDigest);
84 }
85 
86 /**
87  *  Test decoding an SkCodec to a particular SkImageInfo.
88  *
89  *  Calling getPixels(info) should return expectedResult, and if goodDigest is non nullptr,
90  *  the resulting decode should match.
91  */
92 template<typename Codec>
test_info(skiatest::Reporter * r,Codec * codec,const SkImageInfo & info,SkCodec::Result expectedResult,const SkMD5::Digest * goodDigest)93 static void test_info(skiatest::Reporter* r, Codec* codec, const SkImageInfo& info,
94                       SkCodec::Result expectedResult, const SkMD5::Digest* goodDigest) {
95     SkBitmap bm;
96     bm.allocPixels(info);
97 
98     SkCodec::Result result = codec->getPixels(info, bm.getPixels(), bm.rowBytes());
99     REPORTER_ASSERT(r, result == expectedResult);
100 
101     if (goodDigest) {
102         compare_to_good_digest(r, *goodDigest, bm);
103     }
104 }
105 
generate_random_subset(SkRandom * rand,int w,int h)106 SkIRect generate_random_subset(SkRandom* rand, int w, int h) {
107     SkIRect rect;
108     do {
109         rect.fLeft = rand->nextRangeU(0, w);
110         rect.fTop = rand->nextRangeU(0, h);
111         rect.fRight = rand->nextRangeU(0, w);
112         rect.fBottom = rand->nextRangeU(0, h);
113         rect.sort();
114     } while (rect.isEmpty());
115     return rect;
116 }
117 
test_incremental_decode(skiatest::Reporter * r,SkCodec * codec,const SkImageInfo & info,const SkMD5::Digest & goodDigest)118 static void test_incremental_decode(skiatest::Reporter* r, SkCodec* codec, const SkImageInfo& info,
119         const SkMD5::Digest& goodDigest) {
120     SkBitmap bm;
121     bm.allocPixels(info);
122 
123     REPORTER_ASSERT(r, SkCodec::kSuccess == codec->startIncrementalDecode(info, bm.getPixels(),
124                                                                           bm.rowBytes()));
125 
126     REPORTER_ASSERT(r, SkCodec::kSuccess == codec->incrementalDecode());
127 
128     compare_to_good_digest(r, goodDigest, bm);
129 }
130 
131 // Test in stripes, similar to DM's kStripe_Mode
test_in_stripes(skiatest::Reporter * r,SkCodec * codec,const SkImageInfo & info,const SkMD5::Digest & goodDigest)132 static void test_in_stripes(skiatest::Reporter* r, SkCodec* codec, const SkImageInfo& info,
133                             const SkMD5::Digest& goodDigest) {
134     SkBitmap bm;
135     bm.allocPixels(info);
136     bm.eraseColor(SK_ColorYELLOW);
137 
138     const int height = info.height();
139     // Note that if numStripes does not evenly divide height there will be an extra
140     // stripe.
141     const int numStripes = 4;
142 
143     if (numStripes > height) {
144         // Image is too small.
145         return;
146     }
147 
148     const int stripeHeight = height / numStripes;
149 
150     // Iterate through the image twice. Once to decode odd stripes, and once for even.
151     for (int oddEven = 1; oddEven >= 0; oddEven--) {
152         for (int y = oddEven * stripeHeight; y < height; y += 2 * stripeHeight) {
153             SkIRect subset = SkIRect::MakeLTRB(0, y, info.width(),
154                                                SkTMin(y + stripeHeight, height));
155             SkCodec::Options options;
156             options.fSubset = &subset;
157             if (SkCodec::kSuccess != codec->startIncrementalDecode(info, bm.getAddr(0, y),
158                         bm.rowBytes(), &options)) {
159                 ERRORF(r, "failed to start incremental decode!\ttop: %i\tbottom%i\n",
160                        subset.top(), subset.bottom());
161                 return;
162             }
163             if (SkCodec::kSuccess != codec->incrementalDecode()) {
164                 ERRORF(r, "failed incremental decode starting from line %i\n", y);
165                 return;
166             }
167         }
168     }
169 
170     compare_to_good_digest(r, goodDigest, bm);
171 }
172 
173 template<typename Codec>
test_codec(skiatest::Reporter * r,const char * path,Codec * codec,SkBitmap & bm,const SkImageInfo & info,const SkISize & size,SkCodec::Result expectedResult,SkMD5::Digest * digest,const SkMD5::Digest * goodDigest)174 static void test_codec(skiatest::Reporter* r, const char* path, Codec* codec, SkBitmap& bm,
175         const SkImageInfo& info, const SkISize& size, SkCodec::Result expectedResult,
176         SkMD5::Digest* digest, const SkMD5::Digest* goodDigest) {
177 
178     REPORTER_ASSERT(r, info.dimensions() == size);
179     bm.allocPixels(info);
180 
181     SkCodec::Result result = codec->getPixels(info, bm.getPixels(), bm.rowBytes());
182     REPORTER_ASSERT(r, result == expectedResult);
183 
184     *digest = md5(bm);
185     if (goodDigest) {
186         REPORTER_ASSERT(r, *digest == *goodDigest);
187     }
188 
189     {
190         // Test decoding to 565
191         SkImageInfo info565 = info.makeColorType(kRGB_565_SkColorType);
192         if (info.alphaType() == kOpaque_SkAlphaType) {
193             // Decoding to 565 should succeed.
194             SkBitmap bm565;
195             bm565.allocPixels(info565);
196 
197             // This will allow comparison even if the image is incomplete.
198             bm565.eraseColor(SK_ColorBLACK);
199 
200             auto actualResult = codec->getPixels(info565, bm565.getPixels(), bm565.rowBytes());
201             if (actualResult == expectedResult) {
202                 SkMD5::Digest digest565 = md5(bm565);
203 
204                 // A request for non-opaque should also succeed.
205                 for (auto alpha : { kPremul_SkAlphaType, kUnpremul_SkAlphaType }) {
206                     info565 = info565.makeAlphaType(alpha);
207                     test_info(r, codec, info565, expectedResult, &digest565);
208                 }
209             } else {
210                 ERRORF(r, "Decoding %s to 565 failed with result \"%s\"\n\t\t\t\texpected:\"%s\"",
211                           path,
212                           SkCodec::ResultToString(actualResult),
213                           SkCodec::ResultToString(expectedResult));
214             }
215         } else {
216             test_info(r, codec, info565, SkCodec::kInvalidConversion, nullptr);
217         }
218     }
219 
220     if (codec->getInfo().colorType() == kGray_8_SkColorType) {
221         SkImageInfo grayInfo = codec->getInfo();
222         SkBitmap grayBm;
223         grayBm.allocPixels(grayInfo);
224 
225         grayBm.eraseColor(SK_ColorBLACK);
226 
227         REPORTER_ASSERT(r, expectedResult == codec->getPixels(grayInfo,
228                 grayBm.getPixels(), grayBm.rowBytes()));
229 
230         SkMD5::Digest grayDigest = md5(grayBm);
231 
232         for (auto alpha : { kPremul_SkAlphaType, kUnpremul_SkAlphaType }) {
233             grayInfo = grayInfo.makeAlphaType(alpha);
234             test_info(r, codec, grayInfo, expectedResult, &grayDigest);
235         }
236     }
237 
238     // Verify that re-decoding gives the same result.  It is interesting to check this after
239     // a decode to 565, since choosing to decode to 565 may result in some of the decode
240     // options being modified.  These options should return to their defaults on another
241     // decode to kN32, so the new digest should match the old digest.
242     test_info(r, codec, info, expectedResult, digest);
243 
244     {
245         // Check alpha type conversions
246         if (info.alphaType() == kOpaque_SkAlphaType) {
247             test_info(r, codec, info.makeAlphaType(kUnpremul_SkAlphaType),
248                       expectedResult, digest);
249             test_info(r, codec, info.makeAlphaType(kPremul_SkAlphaType),
250                       expectedResult, digest);
251         } else {
252             // Decoding to opaque should fail
253             test_info(r, codec, info.makeAlphaType(kOpaque_SkAlphaType),
254                       SkCodec::kInvalidConversion, nullptr);
255             SkAlphaType otherAt = info.alphaType();
256             if (kPremul_SkAlphaType == otherAt) {
257                 otherAt = kUnpremul_SkAlphaType;
258             } else {
259                 otherAt = kPremul_SkAlphaType;
260             }
261             // The other non-opaque alpha type should always succeed, but not match.
262             test_info(r, codec, info.makeAlphaType(otherAt), expectedResult, nullptr);
263         }
264     }
265 }
266 
supports_partial_scanlines(const char path[])267 static bool supports_partial_scanlines(const char path[]) {
268     static const char* const exts[] = {
269         "jpg", "jpeg", "png", "webp"
270         "JPG", "JPEG", "PNG", "WEBP"
271     };
272 
273     for (uint32_t i = 0; i < SK_ARRAY_COUNT(exts); i++) {
274         if (SkStrEndsWith(path, exts[i])) {
275             return true;
276         }
277     }
278     return false;
279 }
280 
281 // FIXME: Break up this giant function
check(skiatest::Reporter * r,const char path[],SkISize size,bool supportsScanlineDecoding,bool supportsSubsetDecoding,bool supportsIncomplete,bool supportsNewScanlineDecoding=false)282 static void check(skiatest::Reporter* r,
283                   const char path[],
284                   SkISize size,
285                   bool supportsScanlineDecoding,
286                   bool supportsSubsetDecoding,
287                   bool supportsIncomplete,
288                   bool supportsNewScanlineDecoding = false) {
289     // If we're testing incomplete decodes, let's run the same test on full decodes.
290     if (supportsIncomplete) {
291         check(r, path, size, supportsScanlineDecoding, supportsSubsetDecoding, false,
292               supportsNewScanlineDecoding);
293     }
294 
295     std::unique_ptr<SkStream> stream(GetResourceAsStream(path));
296     if (!stream) {
297         return;
298     }
299 
300     std::unique_ptr<SkCodec> codec(nullptr);
301     if (supportsIncomplete) {
302         size_t size = stream->getLength();
303         codec = SkCodec::MakeFromData(SkData::MakeFromStream(stream.get(), 2 * size / 3));
304     } else {
305         codec = SkCodec::MakeFromStream(std::move(stream));
306     }
307     if (!codec) {
308         ERRORF(r, "Unable to decode '%s'", path);
309         return;
310     }
311 
312     // Test full image decodes with SkCodec
313     SkMD5::Digest codecDigest;
314     const SkImageInfo info = codec->getInfo().makeColorType(kN32_SkColorType);
315     SkBitmap bm;
316     SkCodec::Result expectedResult =
317         supportsIncomplete ? SkCodec::kIncompleteInput : SkCodec::kSuccess;
318     test_codec(r, path, codec.get(), bm, info, size, expectedResult, &codecDigest, nullptr);
319 
320     // Scanline decoding follows.
321 
322     if (supportsNewScanlineDecoding && !supportsIncomplete) {
323         test_incremental_decode(r, codec.get(), info, codecDigest);
324         // This is only supported by codecs that use incremental decoding to
325         // support subset decodes - png and jpeg (once SkJpegCodec is
326         // converted).
327         if (SkStrEndsWith(path, "png") || SkStrEndsWith(path, "PNG")) {
328             test_in_stripes(r, codec.get(), info, codecDigest);
329         }
330     }
331 
332     // Need to call startScanlineDecode() first.
333     REPORTER_ASSERT(r, codec->getScanlines(bm.getAddr(0, 0), 1, 0) == 0);
334     REPORTER_ASSERT(r, !codec->skipScanlines(1));
335     const SkCodec::Result startResult = codec->startScanlineDecode(info);
336     if (supportsScanlineDecoding) {
337         bm.eraseColor(SK_ColorYELLOW);
338 
339         REPORTER_ASSERT(r, startResult == SkCodec::kSuccess);
340 
341         for (int y = 0; y < info.height(); y++) {
342             const int lines = codec->getScanlines(bm.getAddr(0, y), 1, 0);
343             if (!supportsIncomplete) {
344                 REPORTER_ASSERT(r, 1 == lines);
345             }
346         }
347         // verify that scanline decoding gives the same result.
348         if (SkCodec::kTopDown_SkScanlineOrder == codec->getScanlineOrder()) {
349             compare_to_good_digest(r, codecDigest, bm);
350         }
351 
352         // Cannot continue to decode scanlines beyond the end
353         REPORTER_ASSERT(r, codec->getScanlines(bm.getAddr(0, 0), 1, 0)
354                 == 0);
355 
356         // Interrupting a scanline decode with a full decode starts from
357         // scratch
358         REPORTER_ASSERT(r, codec->startScanlineDecode(info) == SkCodec::kSuccess);
359         const int lines = codec->getScanlines(bm.getAddr(0, 0), 1, 0);
360         if (!supportsIncomplete) {
361             REPORTER_ASSERT(r, lines == 1);
362         }
363         REPORTER_ASSERT(r, codec->getPixels(bm.info(), bm.getPixels(), bm.rowBytes())
364                 == expectedResult);
365         REPORTER_ASSERT(r, codec->getScanlines(bm.getAddr(0, 0), 1, 0)
366                 == 0);
367         REPORTER_ASSERT(r, codec->skipScanlines(1)
368                 == 0);
369 
370         // Test partial scanline decodes
371         if (supports_partial_scanlines(path) && info.width() >= 3) {
372             SkCodec::Options options;
373             int width = info.width();
374             int height = info.height();
375             SkIRect subset = SkIRect::MakeXYWH(2 * (width / 3), 0, width / 3, height);
376             options.fSubset = &subset;
377 
378             const auto partialStartResult = codec->startScanlineDecode(info, &options);
379             REPORTER_ASSERT(r, partialStartResult == SkCodec::kSuccess);
380 
381             for (int y = 0; y < height; y++) {
382                 const int lines = codec->getScanlines(bm.getAddr(0, y), 1, 0);
383                 if (!supportsIncomplete) {
384                     REPORTER_ASSERT(r, 1 == lines);
385                 }
386             }
387         }
388     } else {
389         REPORTER_ASSERT(r, startResult == SkCodec::kUnimplemented);
390     }
391 
392     // The rest of this function tests decoding subsets, and will decode an arbitrary number of
393     // random subsets.
394     // Do not attempt to decode subsets of an image of only once pixel, since there is no
395     // meaningful subset.
396     if (size.width() * size.height() == 1) {
397         return;
398     }
399 
400     SkRandom rand;
401     SkIRect subset;
402     SkCodec::Options opts;
403     opts.fSubset = &subset;
404     for (int i = 0; i < 5; i++) {
405         subset = generate_random_subset(&rand, size.width(), size.height());
406         SkASSERT(!subset.isEmpty());
407         const bool supported = codec->getValidSubset(&subset);
408         REPORTER_ASSERT(r, supported == supportsSubsetDecoding);
409 
410         SkImageInfo subsetInfo = info.makeWH(subset.width(), subset.height());
411         SkBitmap bm;
412         bm.allocPixels(subsetInfo);
413         const auto result = codec->getPixels(bm.info(), bm.getPixels(), bm.rowBytes(), &opts);
414 
415         if (supportsSubsetDecoding) {
416             if (expectedResult == SkCodec::kSuccess) {
417                 REPORTER_ASSERT(r, result == expectedResult);
418             }
419             // Webp is the only codec that supports subsets, and it will have modified the subset
420             // to have even left/top.
421             REPORTER_ASSERT(r, SkIsAlign2(subset.fLeft) && SkIsAlign2(subset.fTop));
422         } else {
423             // No subsets will work.
424             REPORTER_ASSERT(r, result == SkCodec::kUnimplemented);
425         }
426     }
427 
428     // SkAndroidCodec tests
429     if (supportsScanlineDecoding || supportsSubsetDecoding || supportsNewScanlineDecoding) {
430 
431         std::unique_ptr<SkStream> stream(GetResourceAsStream(path));
432         if (!stream) {
433             return;
434         }
435 
436         auto androidCodec = SkAndroidCodec::MakeFromCodec(std::move(codec));
437         if (!androidCodec) {
438             ERRORF(r, "Unable to decode '%s'", path);
439             return;
440         }
441 
442         SkBitmap bm;
443         SkMD5::Digest androidCodecDigest;
444         test_codec(r, path, androidCodec.get(), bm, info, size, expectedResult, &androidCodecDigest,
445                    &codecDigest);
446     }
447 
448     if (!supportsIncomplete) {
449         // Test SkCodecImageGenerator
450         std::unique_ptr<SkStream> stream(GetResourceAsStream(path));
451         sk_sp<SkData> fullData(SkData::MakeFromStream(stream.get(), stream->getLength()));
452         std::unique_ptr<SkImageGenerator> gen(
453                 SkCodecImageGenerator::MakeFromEncodedCodec(fullData));
454         SkBitmap bm;
455         bm.allocPixels(info);
456         REPORTER_ASSERT(r, gen->getPixels(info, bm.getPixels(), bm.rowBytes()));
457         compare_to_good_digest(r, codecDigest, bm);
458 
459 #ifndef SK_PNG_DISABLE_TESTS
460         // Test using SkFrontBufferedStream, as Android does
461         auto bufferedStream = SkFrontBufferedStream::Make(
462                       SkMemoryStream::Make(std::move(fullData)), SkCodec::MinBufferedBytesNeeded());
463         REPORTER_ASSERT(r, bufferedStream);
464         codec = SkCodec::MakeFromStream(std::move(bufferedStream));
465         REPORTER_ASSERT(r, codec);
466         if (codec) {
467             test_info(r, codec.get(), info, SkCodec::kSuccess, &codecDigest);
468         }
469 #endif
470     }
471 }
472 
DEF_TEST(Codec_wbmp,r)473 DEF_TEST(Codec_wbmp, r) {
474     check(r, "images/mandrill.wbmp", SkISize::Make(512, 512), true, false, true);
475 }
476 
DEF_TEST(Codec_webp,r)477 DEF_TEST(Codec_webp, r) {
478     check(r, "images/baby_tux.webp", SkISize::Make(386, 395), false, true, true);
479     check(r, "images/color_wheel.webp", SkISize::Make(128, 128), false, true, true);
480     check(r, "images/yellow_rose.webp", SkISize::Make(400, 301), false, true, true);
481 }
482 
DEF_TEST(Codec_bmp,r)483 DEF_TEST(Codec_bmp, r) {
484     check(r, "images/randPixels.bmp", SkISize::Make(8, 8), true, false, true);
485     check(r, "images/rle.bmp", SkISize::Make(320, 240), true, false, true);
486 }
487 
DEF_TEST(Codec_ico,r)488 DEF_TEST(Codec_ico, r) {
489     // FIXME: We are not ready to test incomplete ICOs
490     // These two tests examine interestingly different behavior:
491     // Decodes an embedded BMP image
492     check(r, "images/color_wheel.ico", SkISize::Make(128, 128), true, false, false);
493     // Decodes an embedded PNG image
494     check(r, "images/google_chrome.ico", SkISize::Make(256, 256), false, false, false, true);
495 }
496 
DEF_TEST(Codec_gif,r)497 DEF_TEST(Codec_gif, r) {
498     check(r, "images/box.gif", SkISize::Make(200, 55), false, false, true, true);
499     check(r, "images/color_wheel.gif", SkISize::Make(128, 128), false, false, true, true);
500     // randPixels.gif is too small to test incomplete
501     check(r, "images/randPixels.gif", SkISize::Make(8, 8), false, false, false, true);
502 }
503 
DEF_TEST(Codec_jpg,r)504 DEF_TEST(Codec_jpg, r) {
505     check(r, "images/CMYK.jpg", SkISize::Make(642, 516), true, false, true);
506     check(r, "images/color_wheel.jpg", SkISize::Make(128, 128), true, false, true);
507     // grayscale.jpg is too small to test incomplete
508     check(r, "images/grayscale.jpg", SkISize::Make(128, 128), true, false, false);
509     check(r, "images/mandrill_512_q075.jpg", SkISize::Make(512, 512), true, false, true);
510     // randPixels.jpg is too small to test incomplete
511     check(r, "images/randPixels.jpg", SkISize::Make(8, 8), true, false, false);
512 }
513 
DEF_TEST(Codec_png,r)514 DEF_TEST(Codec_png, r) {
515     check(r, "images/arrow.png", SkISize::Make(187, 312), false, false, true, true);
516     check(r, "images/baby_tux.png", SkISize::Make(240, 246), false, false, true, true);
517     check(r, "images/color_wheel.png", SkISize::Make(128, 128), false, false, true, true);
518     // half-transparent-white-pixel.png is too small to test incomplete
519     check(r, "images/half-transparent-white-pixel.png", SkISize::Make(1, 1), false, false, false, true);
520     check(r, "images/mandrill_128.png", SkISize::Make(128, 128), false, false, true, true);
521     // mandrill_16.png is too small (relative to embedded sRGB profile) to test incomplete
522     check(r, "images/mandrill_16.png", SkISize::Make(16, 16), false, false, false, true);
523     check(r, "images/mandrill_256.png", SkISize::Make(256, 256), false, false, true, true);
524     check(r, "images/mandrill_32.png", SkISize::Make(32, 32), false, false, true, true);
525     check(r, "images/mandrill_512.png", SkISize::Make(512, 512), false, false, true, true);
526     check(r, "images/mandrill_64.png", SkISize::Make(64, 64), false, false, true, true);
527     check(r, "images/plane.png", SkISize::Make(250, 126), false, false, true, true);
528     check(r, "images/plane_interlaced.png", SkISize::Make(250, 126), false, false, true, true);
529     check(r, "images/randPixels.png", SkISize::Make(8, 8), false, false, true, true);
530     check(r, "images/yellow_rose.png", SkISize::Make(400, 301), false, false, true, true);
531 }
532 
533 // Disable RAW tests for Win32.
534 #if defined(SK_CODEC_DECODES_RAW) && (!defined(_WIN32))
DEF_TEST(Codec_raw,r)535 DEF_TEST(Codec_raw, r) {
536     check(r, "images/sample_1mp.dng", SkISize::Make(600, 338), false, false, false);
537     check(r, "images/sample_1mp_rotated.dng", SkISize::Make(600, 338), false, false, false);
538     check(r, "images/dng_with_preview.dng", SkISize::Make(600, 338), true, false, false);
539 }
540 #endif
541 
test_invalid_stream(skiatest::Reporter * r,const void * stream,size_t len)542 static void test_invalid_stream(skiatest::Reporter* r, const void* stream, size_t len) {
543     // Neither of these calls should return a codec. Bots should catch us if we leaked anything.
544     REPORTER_ASSERT(r, !SkCodec::MakeFromStream(
545                                         skstd::make_unique<SkMemoryStream>(stream, len, false)));
546     REPORTER_ASSERT(r, !SkAndroidCodec::MakeFromStream(
547                                         skstd::make_unique<SkMemoryStream>(stream, len, false)));
548 }
549 
550 // Ensure that SkCodec::NewFromStream handles freeing the passed in SkStream,
551 // even on failure. Test some bad streams.
DEF_TEST(Codec_leaks,r)552 DEF_TEST(Codec_leaks, r) {
553     // No codec should claim this as their format, so this tests SkCodec::NewFromStream.
554     const char nonSupportedStream[] = "hello world";
555     // The other strings should look like the beginning of a file type, so we'll call some
556     // internal version of NewFromStream, which must also delete the stream on failure.
557     const unsigned char emptyPng[] = { 0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a };
558     const unsigned char emptyJpeg[] = { 0xFF, 0xD8, 0xFF };
559     const char emptyWebp[] = "RIFF1234WEBPVP";
560     const char emptyBmp[] = { 'B', 'M' };
561     const char emptyIco[] = { '\x00', '\x00', '\x01', '\x00' };
562     const char emptyGif[] = "GIFVER";
563 
564     test_invalid_stream(r, nonSupportedStream, sizeof(nonSupportedStream));
565     test_invalid_stream(r, emptyPng, sizeof(emptyPng));
566     test_invalid_stream(r, emptyJpeg, sizeof(emptyJpeg));
567     test_invalid_stream(r, emptyWebp, sizeof(emptyWebp));
568     test_invalid_stream(r, emptyBmp, sizeof(emptyBmp));
569     test_invalid_stream(r, emptyIco, sizeof(emptyIco));
570     test_invalid_stream(r, emptyGif, sizeof(emptyGif));
571 }
572 
DEF_TEST(Codec_null,r)573 DEF_TEST(Codec_null, r) {
574     // Attempting to create an SkCodec or an SkAndroidCodec with null should not
575     // crash.
576     REPORTER_ASSERT(r, !SkCodec::MakeFromStream(nullptr));
577     REPORTER_ASSERT(r, !SkAndroidCodec::MakeFromStream(nullptr));
578 }
579 
test_dimensions(skiatest::Reporter * r,const char path[])580 static void test_dimensions(skiatest::Reporter* r, const char path[]) {
581     // Create the codec from the resource file
582     std::unique_ptr<SkStream> stream(GetResourceAsStream(path));
583     if (!stream) {
584         return;
585     }
586     std::unique_ptr<SkAndroidCodec> codec(SkAndroidCodec::MakeFromStream(std::move(stream)));
587     if (!codec) {
588         ERRORF(r, "Unable to create codec '%s'", path);
589         return;
590     }
591 
592     // Check that the decode is successful for a variety of scales
593     for (int sampleSize = 1; sampleSize < 32; sampleSize++) {
594         // Scale the output dimensions
595         SkISize scaledDims = codec->getSampledDimensions(sampleSize);
596         SkImageInfo scaledInfo = codec->getInfo()
597                 .makeWH(scaledDims.width(), scaledDims.height())
598                 .makeColorType(kN32_SkColorType);
599 
600         // Set up for the decode
601         size_t rowBytes = scaledDims.width() * sizeof(SkPMColor);
602         size_t totalBytes = scaledInfo.computeByteSize(rowBytes);
603         SkAutoTMalloc<SkPMColor> pixels(totalBytes);
604 
605         SkAndroidCodec::AndroidOptions options;
606         options.fSampleSize = sampleSize;
607         SkCodec::Result result =
608                 codec->getAndroidPixels(scaledInfo, pixels.get(), rowBytes, &options);
609         REPORTER_ASSERT(r, SkCodec::kSuccess == result);
610     }
611 }
612 
613 // Ensure that onGetScaledDimensions returns valid image dimensions to use for decodes
DEF_TEST(Codec_Dimensions,r)614 DEF_TEST(Codec_Dimensions, r) {
615     // JPG
616     test_dimensions(r, "images/CMYK.jpg");
617     test_dimensions(r, "images/color_wheel.jpg");
618     test_dimensions(r, "images/grayscale.jpg");
619     test_dimensions(r, "images/mandrill_512_q075.jpg");
620     test_dimensions(r, "images/randPixels.jpg");
621 
622     // Decoding small images with very large scaling factors is a potential
623     // source of bugs and crashes.  We disable these tests in Gold because
624     // tiny images are not very useful to look at.
625     // Here we make sure that we do not crash or access illegal memory when
626     // performing scaled decodes on small images.
627     test_dimensions(r, "images/1x1.png");
628     test_dimensions(r, "images/2x2.png");
629     test_dimensions(r, "images/3x3.png");
630     test_dimensions(r, "images/3x1.png");
631     test_dimensions(r, "images/1x1.png");
632     test_dimensions(r, "images/16x1.png");
633     test_dimensions(r, "images/1x16.png");
634     test_dimensions(r, "images/mandrill_16.png");
635 
636     // RAW
637 // Disable RAW tests for Win32.
638 #if defined(SK_CODEC_DECODES_RAW) && (!defined(_WIN32))
639     test_dimensions(r, "images/sample_1mp.dng");
640     test_dimensions(r, "images/sample_1mp_rotated.dng");
641     test_dimensions(r, "images/dng_with_preview.dng");
642 #endif
643 }
644 
test_invalid(skiatest::Reporter * r,const char path[])645 static void test_invalid(skiatest::Reporter* r, const char path[]) {
646     auto data = GetResourceAsData(path);
647     if (!data) {
648         ERRORF(r, "Failed to get resource %s", path);
649         return;
650     }
651 
652     REPORTER_ASSERT(r, !SkCodec::MakeFromData(data));
653 }
654 
DEF_TEST(Codec_Empty,r)655 DEF_TEST(Codec_Empty, r) {
656     if (GetResourcePath().isEmpty()) {
657         return;
658     }
659 
660     // Test images that should not be able to create a codec
661     test_invalid(r, "empty_images/zero-dims.gif");
662     test_invalid(r, "empty_images/zero-embedded.ico");
663     test_invalid(r, "empty_images/zero-width.bmp");
664     test_invalid(r, "empty_images/zero-height.bmp");
665     test_invalid(r, "empty_images/zero-width.jpg");
666     test_invalid(r, "empty_images/zero-height.jpg");
667     test_invalid(r, "empty_images/zero-width.png");
668     test_invalid(r, "empty_images/zero-height.png");
669     test_invalid(r, "empty_images/zero-width.wbmp");
670     test_invalid(r, "empty_images/zero-height.wbmp");
671     // This image is an ico with an embedded mask-bmp.  This is illegal.
672     test_invalid(r, "invalid_images/mask-bmp-ico.ico");
673     // It is illegal for a webp frame to not be fully contained by the canvas.
674     test_invalid(r, "invalid_images/invalid-offset.webp");
675 #if defined(SK_CODEC_DECODES_RAW) && (!defined(_WIN32))
676     test_invalid(r, "empty_images/zero_height.tiff");
677 #endif
678     test_invalid(r, "invalid_images/b37623797.ico");
679     test_invalid(r, "invalid_images/osfuzz6295.webp");
680     test_invalid(r, "invalid_images/osfuzz6288.bmp");
681     test_invalid(r, "invalid_images/ossfuzz6347");
682 }
683 
684 #ifdef PNG_READ_UNKNOWN_CHUNKS_SUPPORTED
685 
686 #ifndef SK_PNG_DISABLE_TESTS   // reading chunks does not work properly with older versions.
687                                // It does not appear that anyone in Google3 is reading chunks.
688 
codex_test_write_fn(png_structp png_ptr,png_bytep data,png_size_t len)689 static void codex_test_write_fn(png_structp png_ptr, png_bytep data, png_size_t len) {
690     SkWStream* sk_stream = (SkWStream*)png_get_io_ptr(png_ptr);
691     if (!sk_stream->write(data, len)) {
692         png_error(png_ptr, "sk_write_fn Error!");
693     }
694 }
695 
DEF_TEST(Codec_pngChunkReader,r)696 DEF_TEST(Codec_pngChunkReader, r) {
697     // Create a dummy bitmap. Use unpremul RGBA for libpng.
698     SkBitmap bm;
699     const int w = 1;
700     const int h = 1;
701     const SkImageInfo bmInfo = SkImageInfo::Make(w, h, kRGBA_8888_SkColorType,
702                                                  kUnpremul_SkAlphaType);
703     bm.setInfo(bmInfo);
704     bm.allocPixels();
705     bm.eraseColor(SK_ColorBLUE);
706     SkMD5::Digest goodDigest = md5(bm);
707 
708     // Write to a png file.
709     png_structp png = png_create_write_struct(PNG_LIBPNG_VER_STRING, nullptr, nullptr, nullptr);
710     REPORTER_ASSERT(r, png);
711     if (!png) {
712         return;
713     }
714 
715     png_infop info = png_create_info_struct(png);
716     REPORTER_ASSERT(r, info);
717     if (!info) {
718         png_destroy_write_struct(&png, nullptr);
719         return;
720     }
721 
722     if (setjmp(png_jmpbuf(png))) {
723         ERRORF(r, "failed writing png");
724         png_destroy_write_struct(&png, &info);
725         return;
726     }
727 
728     SkDynamicMemoryWStream wStream;
729     png_set_write_fn(png, (void*) (&wStream), codex_test_write_fn, nullptr);
730 
731     png_set_IHDR(png, info, (png_uint_32)w, (png_uint_32)h, 8,
732                  PNG_COLOR_TYPE_RGB_ALPHA, PNG_INTERLACE_NONE,
733                  PNG_COMPRESSION_TYPE_DEFAULT, PNG_FILTER_TYPE_DEFAULT);
734 
735     // Create some chunks that match the Android framework's use.
736     static png_unknown_chunk gUnknowns[] = {
737         { "npOl", (png_byte*)"outline", sizeof("outline"), PNG_HAVE_IHDR },
738         { "npLb", (png_byte*)"layoutBounds", sizeof("layoutBounds"), PNG_HAVE_IHDR },
739         { "npTc", (png_byte*)"ninePatchData", sizeof("ninePatchData"), PNG_HAVE_IHDR },
740     };
741 
742     png_set_keep_unknown_chunks(png, PNG_HANDLE_CHUNK_ALWAYS, (png_byte*)"npOl\0npLb\0npTc\0", 3);
743     png_set_unknown_chunks(png, info, gUnknowns, SK_ARRAY_COUNT(gUnknowns));
744 #if PNG_LIBPNG_VER < 10600
745     /* Deal with unknown chunk location bug in 1.5.x and earlier */
746     png_set_unknown_chunk_location(png, info, 0, PNG_HAVE_IHDR);
747     png_set_unknown_chunk_location(png, info, 1, PNG_HAVE_IHDR);
748 #endif
749 
750     png_write_info(png, info);
751 
752     for (int j = 0; j < h; j++) {
753         png_bytep row = (png_bytep)(bm.getAddr(0, j));
754         png_write_rows(png, &row, 1);
755     }
756     png_write_end(png, info);
757     png_destroy_write_struct(&png, &info);
758 
759     class ChunkReader : public SkPngChunkReader {
760     public:
761         ChunkReader(skiatest::Reporter* r)
762             : fReporter(r)
763         {
764             this->reset();
765         }
766 
767         bool readChunk(const char tag[], const void* data, size_t length) override {
768             for (size_t i = 0; i < SK_ARRAY_COUNT(gUnknowns); ++i) {
769                 if (!strcmp(tag, (const char*) gUnknowns[i].name)) {
770                     // Tag matches. This should have been the first time we see it.
771                     REPORTER_ASSERT(fReporter, !fSeen[i]);
772                     fSeen[i] = true;
773 
774                     // Data and length should match
775                     REPORTER_ASSERT(fReporter, length == gUnknowns[i].size);
776                     REPORTER_ASSERT(fReporter, !strcmp((const char*) data,
777                                                        (const char*) gUnknowns[i].data));
778                     return true;
779                 }
780             }
781             ERRORF(fReporter, "Saw an unexpected unknown chunk.");
782             return true;
783         }
784 
785         bool allHaveBeenSeen() {
786             bool ret = true;
787             for (auto seen : fSeen) {
788                 ret &= seen;
789             }
790             return ret;
791         }
792 
793         void reset() {
794             sk_bzero(fSeen, sizeof(fSeen));
795         }
796 
797     private:
798         skiatest::Reporter* fReporter;  // Unowned
799         bool fSeen[3];
800     };
801 
802     ChunkReader chunkReader(r);
803 
804     // Now read the file with SkCodec.
805     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromData(wStream.detachAsData(), &chunkReader));
806     REPORTER_ASSERT(r, codec);
807     if (!codec) {
808         return;
809     }
810 
811     // Now compare to the original.
812     SkBitmap decodedBm;
813     decodedBm.setInfo(codec->getInfo());
814     decodedBm.allocPixels();
815     SkCodec::Result result = codec->getPixels(codec->getInfo(), decodedBm.getPixels(),
816                                               decodedBm.rowBytes());
817     REPORTER_ASSERT(r, SkCodec::kSuccess == result);
818 
819     if (decodedBm.colorType() != bm.colorType()) {
820         SkBitmap tmp;
821         bool     success = ToolUtils::copy_to(&tmp, bm.colorType(), decodedBm);
822         REPORTER_ASSERT(r, success);
823         if (!success) {
824             return;
825         }
826 
827         tmp.swap(decodedBm);
828     }
829 
830     compare_to_good_digest(r, goodDigest, decodedBm);
831     REPORTER_ASSERT(r, chunkReader.allHaveBeenSeen());
832 
833     // Decoding again will read the chunks again.
834     chunkReader.reset();
835     REPORTER_ASSERT(r, !chunkReader.allHaveBeenSeen());
836     result = codec->getPixels(codec->getInfo(), decodedBm.getPixels(), decodedBm.rowBytes());
837     REPORTER_ASSERT(r, SkCodec::kSuccess == result);
838     REPORTER_ASSERT(r, chunkReader.allHaveBeenSeen());
839 }
840 #endif // SK_PNG_DISABLE_TESTS
841 #endif // PNG_READ_UNKNOWN_CHUNKS_SUPPORTED
842 
843 // Stream that can only peek up to a limit
844 class LimitedPeekingMemStream : public SkStream {
845 public:
LimitedPeekingMemStream(sk_sp<SkData> data,size_t limit)846     LimitedPeekingMemStream(sk_sp<SkData> data, size_t limit)
847         : fStream(std::move(data))
848         , fLimit(limit) {}
849 
peek(void * buf,size_t bytes) const850     size_t peek(void* buf, size_t bytes) const override {
851         return fStream.peek(buf, SkTMin(bytes, fLimit));
852     }
read(void * buf,size_t bytes)853     size_t read(void* buf, size_t bytes) override {
854         return fStream.read(buf, bytes);
855     }
rewind()856     bool rewind() override {
857         return fStream.rewind();
858     }
isAtEnd() const859     bool isAtEnd() const override {
860         return fStream.isAtEnd();
861     }
862 private:
863     SkMemoryStream fStream;
864     const size_t   fLimit;
865 };
866 
867 // Disable RAW tests for Win32.
868 #if defined(SK_CODEC_DECODES_RAW) && (!defined(_WIN32))
869 // Test that the RawCodec works also for not asset stream. This will test the code path using
870 // SkRawBufferedStream instead of SkRawAssetStream.
DEF_TEST(Codec_raw_notseekable,r)871 DEF_TEST(Codec_raw_notseekable, r) {
872     constexpr char path[] = "images/dng_with_preview.dng";
873     sk_sp<SkData> data(GetResourceAsData(path));
874     if (!data) {
875         SkDebugf("Missing resource '%s'\n", path);
876         return;
877     }
878 
879     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(
880                                            skstd::make_unique<NotAssetMemStream>(std::move(data))));
881     REPORTER_ASSERT(r, codec);
882 
883     test_info(r, codec.get(), codec->getInfo(), SkCodec::kSuccess, nullptr);
884 }
885 #endif
886 
887 // Test that even if webp_parse_header fails to peek enough, it will fall back to read()
888 // + rewind() and succeed.
DEF_TEST(Codec_webp_peek,r)889 DEF_TEST(Codec_webp_peek, r) {
890     constexpr char path[] = "images/baby_tux.webp";
891     auto data = GetResourceAsData(path);
892     if (!data) {
893         SkDebugf("Missing resource '%s'\n", path);
894         return;
895     }
896 
897     // The limit is less than webp needs to peek or read.
898     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(
899                                            skstd::make_unique<LimitedPeekingMemStream>(data, 25)));
900     REPORTER_ASSERT(r, codec);
901 
902     test_info(r, codec.get(), codec->getInfo(), SkCodec::kSuccess, nullptr);
903 
904     // Similarly, a stream which does not peek should still succeed.
905     codec = SkCodec::MakeFromStream(skstd::make_unique<LimitedPeekingMemStream>(data, 0));
906     REPORTER_ASSERT(r, codec);
907 
908     test_info(r, codec.get(), codec->getInfo(), SkCodec::kSuccess, nullptr);
909 }
910 
911 // SkCodec's wbmp decoder was initially unnecessarily restrictive.
912 // It required the second byte to be zero. The wbmp specification allows
913 // a couple of bits to be 1 (so long as they do not overlap with 0x9F).
914 // Test that SkCodec now supports an image with these bits set.
DEF_TEST(Codec_wbmp_restrictive,r)915 DEF_TEST(Codec_wbmp_restrictive, r) {
916     const char* path = "images/mandrill.wbmp";
917     std::unique_ptr<SkStream> stream(GetResourceAsStream(path));
918     if (!stream) {
919         return;
920     }
921 
922     // Modify the stream to contain a second byte with some bits set.
923     auto data = SkCopyStreamToData(stream.get());
924     uint8_t* writeableData = static_cast<uint8_t*>(data->writable_data());
925     writeableData[1] = static_cast<uint8_t>(~0x9F);
926 
927     // SkCodec should support this.
928     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromData(data));
929     REPORTER_ASSERT(r, codec);
930     if (!codec) {
931         return;
932     }
933     test_info(r, codec.get(), codec->getInfo(), SkCodec::kSuccess, nullptr);
934 }
935 
936 // wbmp images have a header that can be arbitrarily large, depending on the
937 // size of the image. We cap the size at 65535, meaning we only need to look at
938 // 8 bytes to determine whether we can read the image. This is important
939 // because SkCodec only passes a limited number of bytes to SkWbmpCodec to
940 // determine whether the image is a wbmp.
DEF_TEST(Codec_wbmp_max_size,r)941 DEF_TEST(Codec_wbmp_max_size, r) {
942     const unsigned char maxSizeWbmp[] = { 0x00, 0x00,           // Header
943                                           0x83, 0xFF, 0x7F,     // W: 65535
944                                           0x83, 0xFF, 0x7F };   // H: 65535
945     std::unique_ptr<SkStream> stream(new SkMemoryStream(maxSizeWbmp, sizeof(maxSizeWbmp), false));
946     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream)));
947 
948     REPORTER_ASSERT(r, codec);
949     if (!codec) return;
950 
951     REPORTER_ASSERT(r, codec->getInfo().width() == 65535);
952     REPORTER_ASSERT(r, codec->getInfo().height() == 65535);
953 
954     // Now test an image which is too big. Any image with a larger header (i.e.
955     // has bigger width/height) is also too big.
956     const unsigned char tooBigWbmp[] = { 0x00, 0x00,           // Header
957                                          0x84, 0x80, 0x00,     // W: 65536
958                                          0x84, 0x80, 0x00 };   // H: 65536
959     stream.reset(new SkMemoryStream(tooBigWbmp, sizeof(tooBigWbmp), false));
960     codec = SkCodec::MakeFromStream(std::move(stream));
961 
962     REPORTER_ASSERT(r, !codec);
963 }
964 
DEF_TEST(Codec_jpeg_rewind,r)965 DEF_TEST(Codec_jpeg_rewind, r) {
966     const char* path = "images/mandrill_512_q075.jpg";
967     sk_sp<SkData> data(GetResourceAsData(path));
968     if (!data) {
969         return;
970     }
971 
972     data = SkData::MakeSubset(data.get(), 0, data->size() / 2);
973     std::unique_ptr<SkAndroidCodec> codec(SkAndroidCodec::MakeFromData(data));
974     if (!codec) {
975         ERRORF(r, "Unable to create codec '%s'.", path);
976         return;
977     }
978 
979     const int width = codec->getInfo().width();
980     const int height = codec->getInfo().height();
981     size_t rowBytes = sizeof(SkPMColor) * width;
982     SkAutoMalloc pixelStorage(height * rowBytes);
983 
984     // Perform a sampled decode.
985     SkAndroidCodec::AndroidOptions opts;
986     opts.fSampleSize = 12;
987     auto sampledInfo = codec->getInfo().makeWH(width / 12, height / 12);
988     auto result = codec->getAndroidPixels(sampledInfo, pixelStorage.get(), rowBytes, &opts);
989     REPORTER_ASSERT(r, SkCodec::kIncompleteInput == result);
990 
991     // Rewind the codec and perform a full image decode.
992     result = codec->getPixels(codec->getInfo(), pixelStorage.get(), rowBytes);
993     REPORTER_ASSERT(r, SkCodec::kIncompleteInput == result);
994 
995     // Now perform a subset decode.
996     {
997         opts.fSampleSize = 1;
998         SkIRect subset = SkIRect::MakeWH(100, 100);
999         opts.fSubset = &subset;
1000         result = codec->getAndroidPixels(codec->getInfo().makeWH(100, 100), pixelStorage.get(),
1001                                          rowBytes, &opts);
1002         // Though we only have half the data, it is enough to decode this subset.
1003         REPORTER_ASSERT(r, SkCodec::kSuccess == result);
1004     }
1005 
1006     // Perform another full image decode.  ASAN will detect if we look at the subset when it is
1007     // out of scope.  This would happen if we depend on the old state in the codec.
1008     // This tests two layers of bugs: both SkJpegCodec::readRows and SkCodec::fillIncompleteImage
1009     // used to look at the old subset.
1010     opts.fSubset = nullptr;
1011     result = codec->getAndroidPixels(codec->getInfo(), pixelStorage.get(), rowBytes, &opts);
1012     REPORTER_ASSERT(r, SkCodec::kIncompleteInput == result);
1013 }
1014 
check_color_xform(skiatest::Reporter * r,const char * path)1015 static void check_color_xform(skiatest::Reporter* r, const char* path) {
1016     std::unique_ptr<SkAndroidCodec> codec(SkAndroidCodec::MakeFromStream(GetResourceAsStream(path)));
1017 
1018     SkAndroidCodec::AndroidOptions opts;
1019     opts.fSampleSize = 3;
1020     const int subsetWidth = codec->getInfo().width() / 2;
1021     const int subsetHeight = codec->getInfo().height() / 2;
1022     SkIRect subset = SkIRect::MakeWH(subsetWidth, subsetHeight);
1023     opts.fSubset = &subset;
1024 
1025     const int dstWidth = subsetWidth / opts.fSampleSize;
1026     const int dstHeight = subsetHeight / opts.fSampleSize;
1027     auto colorSpace = SkColorSpace::MakeRGB(SkNamedTransferFn::k2Dot2, SkNamedGamut::kAdobeRGB);
1028     SkImageInfo dstInfo = codec->getInfo().makeWH(dstWidth, dstHeight)
1029                                           .makeColorType(kN32_SkColorType)
1030                                           .makeColorSpace(colorSpace);
1031 
1032     size_t rowBytes = dstInfo.minRowBytes();
1033     SkAutoMalloc pixelStorage(dstInfo.computeByteSize(rowBytes));
1034     SkCodec::Result result = codec->getAndroidPixels(dstInfo, pixelStorage.get(), rowBytes, &opts);
1035     REPORTER_ASSERT(r, SkCodec::kSuccess == result);
1036 }
1037 
DEF_TEST(Codec_ColorXform,r)1038 DEF_TEST(Codec_ColorXform, r) {
1039     check_color_xform(r, "images/mandrill_512_q075.jpg");
1040     check_color_xform(r, "images/mandrill_512.png");
1041 }
1042 
color_type_match(SkColorType origColorType,SkColorType codecColorType)1043 static bool color_type_match(SkColorType origColorType, SkColorType codecColorType) {
1044     switch (origColorType) {
1045         case kRGBA_8888_SkColorType:
1046         case kBGRA_8888_SkColorType:
1047             return kRGBA_8888_SkColorType == codecColorType ||
1048                    kBGRA_8888_SkColorType == codecColorType;
1049         default:
1050             return origColorType == codecColorType;
1051     }
1052 }
1053 
alpha_type_match(SkAlphaType origAlphaType,SkAlphaType codecAlphaType)1054 static bool alpha_type_match(SkAlphaType origAlphaType, SkAlphaType codecAlphaType) {
1055     switch (origAlphaType) {
1056         case kUnpremul_SkAlphaType:
1057         case kPremul_SkAlphaType:
1058             return kUnpremul_SkAlphaType == codecAlphaType ||
1059                     kPremul_SkAlphaType == codecAlphaType;
1060         default:
1061             return origAlphaType == codecAlphaType;
1062     }
1063 }
1064 
check_round_trip(skiatest::Reporter * r,SkCodec * origCodec,const SkImageInfo & info)1065 static void check_round_trip(skiatest::Reporter* r, SkCodec* origCodec, const SkImageInfo& info) {
1066     SkBitmap bm1;
1067     bm1.allocPixels(info);
1068     SkCodec::Result result = origCodec->getPixels(info, bm1.getPixels(), bm1.rowBytes());
1069     REPORTER_ASSERT(r, SkCodec::kSuccess == result);
1070 
1071     // Encode the image to png.
1072     auto data = SkEncodeBitmap(bm1, SkEncodedImageFormat::kPNG, 100);
1073 
1074     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromData(data));
1075     REPORTER_ASSERT(r, color_type_match(info.colorType(), codec->getInfo().colorType()));
1076     REPORTER_ASSERT(r, alpha_type_match(info.alphaType(), codec->getInfo().alphaType()));
1077 
1078     SkBitmap bm2;
1079     bm2.allocPixels(info);
1080     result = codec->getPixels(info, bm2.getPixels(), bm2.rowBytes());
1081     REPORTER_ASSERT(r, SkCodec::kSuccess == result);
1082 
1083     REPORTER_ASSERT(r, md5(bm1) == md5(bm2));
1084 }
1085 
DEF_TEST(Codec_PngRoundTrip,r)1086 DEF_TEST(Codec_PngRoundTrip, r) {
1087     auto codec = SkCodec::MakeFromStream(GetResourceAsStream("images/mandrill_512_q075.jpg"));
1088 
1089     SkColorType colorTypesOpaque[] = {
1090             kRGB_565_SkColorType, kRGBA_8888_SkColorType, kBGRA_8888_SkColorType
1091     };
1092     for (SkColorType colorType : colorTypesOpaque) {
1093         SkImageInfo newInfo = codec->getInfo().makeColorType(colorType);
1094         check_round_trip(r, codec.get(), newInfo);
1095     }
1096 
1097     codec = SkCodec::MakeFromStream(GetResourceAsStream("images/grayscale.jpg"));
1098     check_round_trip(r, codec.get(), codec->getInfo());
1099 
1100     codec = SkCodec::MakeFromStream(GetResourceAsStream("images/yellow_rose.png"));
1101 
1102     SkColorType colorTypesWithAlpha[] = {
1103             kRGBA_8888_SkColorType, kBGRA_8888_SkColorType
1104     };
1105     SkAlphaType alphaTypes[] = {
1106             kUnpremul_SkAlphaType, kPremul_SkAlphaType
1107     };
1108     for (SkColorType colorType : colorTypesWithAlpha) {
1109         for (SkAlphaType alphaType : alphaTypes) {
1110             // Set color space to nullptr because color correct premultiplies do not round trip.
1111             SkImageInfo newInfo = codec->getInfo().makeColorType(colorType)
1112                                                   .makeAlphaType(alphaType)
1113                                                   .makeColorSpace(nullptr);
1114             check_round_trip(r, codec.get(), newInfo);
1115         }
1116     }
1117 
1118     codec = SkCodec::MakeFromStream(GetResourceAsStream("images/index8.png"));
1119 
1120     for (SkAlphaType alphaType : alphaTypes) {
1121         SkImageInfo newInfo = codec->getInfo().makeAlphaType(alphaType)
1122                                               .makeColorSpace(nullptr);
1123         check_round_trip(r, codec.get(), newInfo);
1124     }
1125 }
1126 
test_conversion_possible(skiatest::Reporter * r,const char * path,bool supportsScanlineDecoder,bool supportsIncrementalDecoder)1127 static void test_conversion_possible(skiatest::Reporter* r, const char* path,
1128                                      bool supportsScanlineDecoder,
1129                                      bool supportsIncrementalDecoder) {
1130     std::unique_ptr<SkStream> stream(GetResourceAsStream(path));
1131     if (!stream) {
1132         return;
1133     }
1134 
1135     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream)));
1136     if (!codec) {
1137         ERRORF(r, "failed to create a codec for %s", path);
1138         return;
1139     }
1140 
1141     SkImageInfo infoF16 = codec->getInfo().makeColorType(kRGBA_F16_SkColorType);
1142 
1143     SkBitmap bm;
1144     bm.allocPixels(infoF16);
1145     SkCodec::Result result = codec->getPixels(infoF16, bm.getPixels(), bm.rowBytes());
1146     REPORTER_ASSERT(r, SkCodec::kSuccess == result);
1147 
1148     result = codec->startScanlineDecode(infoF16);
1149     if (supportsScanlineDecoder) {
1150         REPORTER_ASSERT(r, SkCodec::kSuccess == result);
1151     } else {
1152         REPORTER_ASSERT(r, SkCodec::kUnimplemented == result
1153                         || SkCodec::kSuccess == result);
1154     }
1155 
1156     result = codec->startIncrementalDecode(infoF16, bm.getPixels(), bm.rowBytes());
1157     if (supportsIncrementalDecoder) {
1158         REPORTER_ASSERT(r, SkCodec::kSuccess == result);
1159     } else {
1160         REPORTER_ASSERT(r, SkCodec::kUnimplemented == result
1161                         || SkCodec::kSuccess == result);
1162     }
1163 
1164     infoF16 = infoF16.makeColorSpace(infoF16.colorSpace()->makeLinearGamma());
1165     result = codec->getPixels(infoF16, bm.getPixels(), bm.rowBytes());
1166     REPORTER_ASSERT(r, SkCodec::kSuccess == result);
1167     result = codec->startScanlineDecode(infoF16);
1168     if (supportsScanlineDecoder) {
1169         REPORTER_ASSERT(r, SkCodec::kSuccess == result);
1170     } else {
1171         REPORTER_ASSERT(r, SkCodec::kUnimplemented == result);
1172     }
1173 
1174     result = codec->startIncrementalDecode(infoF16, bm.getPixels(), bm.rowBytes());
1175     if (supportsIncrementalDecoder) {
1176         REPORTER_ASSERT(r, SkCodec::kSuccess == result);
1177     } else {
1178         REPORTER_ASSERT(r, SkCodec::kUnimplemented == result);
1179     }
1180 }
1181 
DEF_TEST(Codec_F16ConversionPossible,r)1182 DEF_TEST(Codec_F16ConversionPossible, r) {
1183     test_conversion_possible(r, "images/color_wheel.webp", false, false);
1184     test_conversion_possible(r, "images/mandrill_512_q075.jpg", true, false);
1185     test_conversion_possible(r, "images/yellow_rose.png", false, true);
1186 }
1187 
decode_frame(skiatest::Reporter * r,SkCodec * codec,size_t frame)1188 static void decode_frame(skiatest::Reporter* r, SkCodec* codec, size_t frame) {
1189     SkBitmap bm;
1190     auto info = codec->getInfo().makeColorType(kN32_SkColorType);
1191     bm.allocPixels(info);
1192 
1193     SkCodec::Options opts;
1194     opts.fFrameIndex = frame;
1195     REPORTER_ASSERT(r, SkCodec::kSuccess == codec->getPixels(info,
1196             bm.getPixels(), bm.rowBytes(), &opts));
1197 }
1198 
1199 // For an animated GIF, we should only read enough to decode frame 0 if the
1200 // client never calls getFrameInfo and only decodes frame 0.
DEF_TEST(Codec_skipFullParse,r)1201 DEF_TEST(Codec_skipFullParse, r) {
1202     auto path = "images/test640x479.gif";
1203     auto streamObj = GetResourceAsStream(path);
1204     if (!streamObj) {
1205         return;
1206     }
1207     SkStream* stream = streamObj.get();
1208 
1209     // Note that we cheat and hold on to the stream pointer, but SkCodec will
1210     // take ownership. We will not refer to the stream after the SkCodec
1211     // deletes it.
1212     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(streamObj)));
1213     if (!codec) {
1214         ERRORF(r, "Failed to create codec for %s", path);
1215         return;
1216     }
1217 
1218     REPORTER_ASSERT(r, stream->hasPosition());
1219     const size_t sizePosition = stream->getPosition();
1220     REPORTER_ASSERT(r, stream->hasLength() && sizePosition < stream->getLength());
1221 
1222     // This should read more of the stream, but not the whole stream.
1223     decode_frame(r, codec.get(), 0);
1224     const size_t positionAfterFirstFrame = stream->getPosition();
1225     REPORTER_ASSERT(r, positionAfterFirstFrame > sizePosition
1226                        && positionAfterFirstFrame < stream->getLength());
1227 
1228     // There is more data in the stream.
1229     auto frameInfo = codec->getFrameInfo();
1230     REPORTER_ASSERT(r, frameInfo.size() == 4);
1231     REPORTER_ASSERT(r, stream->getPosition() > positionAfterFirstFrame);
1232 }
1233 
1234 // Only rewinds up to a limit.
1235 class LimitedRewindingStream : public SkStream {
1236 public:
Make(const char path[],size_t limit)1237     static std::unique_ptr<SkStream> Make(const char path[], size_t limit) {
1238         auto stream = GetResourceAsStream(path);
1239         if (!stream) {
1240             return nullptr;
1241         }
1242         return std::unique_ptr<SkStream>(new LimitedRewindingStream(std::move(stream), limit));
1243     }
1244 
read(void * buffer,size_t size)1245     size_t read(void* buffer, size_t size) override {
1246         const size_t bytes = fStream->read(buffer, size);
1247         fPosition += bytes;
1248         return bytes;
1249     }
1250 
isAtEnd() const1251     bool isAtEnd() const override {
1252         return fStream->isAtEnd();
1253     }
1254 
rewind()1255     bool rewind() override {
1256         if (fPosition <= fLimit && fStream->rewind()) {
1257             fPosition = 0;
1258             return true;
1259         }
1260 
1261         return false;
1262     }
1263 
1264 private:
1265     std::unique_ptr<SkStream> fStream;
1266     const size_t              fLimit;
1267     size_t                    fPosition;
1268 
LimitedRewindingStream(std::unique_ptr<SkStream> stream,size_t limit)1269     LimitedRewindingStream(std::unique_ptr<SkStream> stream, size_t limit)
1270         : fStream(std::move(stream))
1271         , fLimit(limit)
1272         , fPosition(0)
1273     {
1274         SkASSERT(fStream);
1275     }
1276 };
1277 
DEF_TEST(Codec_fallBack,r)1278 DEF_TEST(Codec_fallBack, r) {
1279     // SkAndroidCodec needs to be able to fall back to scanline decoding
1280     // if incremental decoding does not work. Make sure this does not
1281     // require a rewind.
1282 
1283     // Formats that currently do not support incremental decoding
1284     auto files = {
1285             "images/CMYK.jpg",
1286             "images/color_wheel.ico",
1287             "images/mandrill.wbmp",
1288             "images/randPixels.bmp",
1289             };
1290     for (auto file : files) {
1291         auto stream = LimitedRewindingStream::Make(file, SkCodec::MinBufferedBytesNeeded());
1292         if (!stream) {
1293             SkDebugf("Missing resources (%s). Set --resourcePath.\n", file);
1294             return;
1295         }
1296 
1297         std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream)));
1298         if (!codec) {
1299             ERRORF(r, "Failed to create codec for %s,", file);
1300             continue;
1301         }
1302 
1303         SkImageInfo info = codec->getInfo().makeColorType(kN32_SkColorType);
1304         SkBitmap bm;
1305         bm.allocPixels(info);
1306 
1307         if (SkCodec::kUnimplemented != codec->startIncrementalDecode(info, bm.getPixels(),
1308                 bm.rowBytes())) {
1309             ERRORF(r, "Is scanline decoding now implemented for %s?", file);
1310             continue;
1311         }
1312 
1313         // Scanline decoding should not require a rewind.
1314         SkCodec::Result result = codec->startScanlineDecode(info);
1315         if (SkCodec::kSuccess != result) {
1316             ERRORF(r, "Scanline decoding failed for %s with %i", file, result);
1317         }
1318     }
1319 }
1320 
1321 // This test verifies that we fixed an assert statement that fired when reusing a png codec
1322 // after scaling.
DEF_TEST(Codec_reusePng,r)1323 DEF_TEST(Codec_reusePng, r) {
1324     std::unique_ptr<SkStream> stream(GetResourceAsStream("images/plane.png"));
1325     if (!stream) {
1326         return;
1327     }
1328 
1329     std::unique_ptr<SkAndroidCodec> codec(SkAndroidCodec::MakeFromStream(std::move(stream)));
1330     if (!codec) {
1331         ERRORF(r, "Failed to create codec\n");
1332         return;
1333     }
1334 
1335     SkAndroidCodec::AndroidOptions opts;
1336     opts.fSampleSize = 5;
1337     auto size = codec->getSampledDimensions(opts.fSampleSize);
1338     auto info = codec->getInfo().makeWH(size.fWidth, size.fHeight).makeColorType(kN32_SkColorType);
1339     SkBitmap bm;
1340     bm.allocPixels(info);
1341     auto result = codec->getAndroidPixels(info, bm.getPixels(), bm.rowBytes(), &opts);
1342     REPORTER_ASSERT(r, result == SkCodec::kSuccess);
1343 
1344     info = codec->getInfo().makeColorType(kN32_SkColorType);
1345     bm.allocPixels(info);
1346     opts.fSampleSize = 1;
1347     result = codec->getAndroidPixels(info, bm.getPixels(), bm.rowBytes(), &opts);
1348     REPORTER_ASSERT(r, result == SkCodec::kSuccess);
1349 }
1350 
DEF_TEST(Codec_rowsDecoded,r)1351 DEF_TEST(Codec_rowsDecoded, r) {
1352     auto file = "images/plane_interlaced.png";
1353     std::unique_ptr<SkStream> stream(GetResourceAsStream(file));
1354     if (!stream) {
1355         return;
1356     }
1357 
1358     // This is enough to read the header etc, but no rows.
1359     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromData(SkData::MakeFromStream(stream.get(), 99)));
1360     if (!codec) {
1361         ERRORF(r, "Failed to create codec\n");
1362         return;
1363     }
1364 
1365     auto info = codec->getInfo().makeColorType(kN32_SkColorType);
1366     SkBitmap bm;
1367     bm.allocPixels(info);
1368     auto result = codec->startIncrementalDecode(info, bm.getPixels(), bm.rowBytes());
1369     REPORTER_ASSERT(r, result == SkCodec::kSuccess);
1370 
1371     // This is an arbitrary value. The important fact is that it is not zero, and rowsDecoded
1372     // should get set to zero by incrementalDecode.
1373     int rowsDecoded = 77;
1374     result = codec->incrementalDecode(&rowsDecoded);
1375     REPORTER_ASSERT(r, result == SkCodec::kIncompleteInput);
1376     REPORTER_ASSERT(r, rowsDecoded == 0);
1377 }
1378 
test_invalid_images(skiatest::Reporter * r,const char * path,SkCodec::Result expectedResult)1379 static void test_invalid_images(skiatest::Reporter* r, const char* path,
1380                                 SkCodec::Result expectedResult) {
1381     auto stream = GetResourceAsStream(path);
1382     if (!stream) {
1383         return;
1384     }
1385 
1386     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream)));
1387     REPORTER_ASSERT(r, codec);
1388 
1389     test_info(r, codec.get(), codec->getInfo().makeColorType(kN32_SkColorType), expectedResult,
1390               nullptr);
1391 }
1392 
DEF_TEST(Codec_InvalidImages,r)1393 DEF_TEST(Codec_InvalidImages, r) {
1394     // ASAN will complain if there is an issue.
1395     test_invalid_images(r, "invalid_images/skbug5887.gif", SkCodec::kErrorInInput);
1396     test_invalid_images(r, "invalid_images/many-progressive-scans.jpg", SkCodec::kInvalidInput);
1397     test_invalid_images(r, "invalid_images/b33251605.bmp", SkCodec::kIncompleteInput);
1398     test_invalid_images(r, "invalid_images/bad_palette.png", SkCodec::kInvalidInput);
1399 }
1400 
test_invalid_header(skiatest::Reporter * r,const char * path)1401 static void test_invalid_header(skiatest::Reporter* r, const char* path) {
1402     auto data = GetResourceAsData(path);
1403     if (!data) {
1404         return;
1405     }
1406     std::unique_ptr<SkStreamAsset> stream(new SkMemoryStream(std::move(data)));
1407     if (!stream) {
1408         return;
1409     }
1410     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream)));
1411     REPORTER_ASSERT(r, !codec);
1412 }
1413 
DEF_TEST(Codec_InvalidHeader,r)1414 DEF_TEST(Codec_InvalidHeader, r) {
1415     test_invalid_header(r, "invalid_images/int_overflow.ico");
1416 
1417     // These files report values that have caused problems with SkFILEStreams.
1418     // They are invalid, and should not create SkCodecs.
1419     test_invalid_header(r, "invalid_images/b33651913.bmp");
1420     test_invalid_header(r, "invalid_images/b34778578.bmp");
1421 }
1422 
1423 /*
1424 For the Codec_InvalidAnimated test, immediately below,
1425 resources/invalid_images/skbug6046.gif is:
1426 
1427 00000000: 4749 4638 3961 2000 0000 0000 002c ff00  GIF89a ......,..
1428 00000010: 7400 0600 0000 4001 0021 f904 0a00 0000  t.....@..!......
1429 00000020: 002c ff00 0000 ff00 7400 0606 0606 0601  .,......t.......
1430 00000030: 0021 f904 0000 0000 002c ff00 0000 ffcc  .!.......,......
1431 00000040: 1b36 5266 deba 543d                      .6Rf..T=
1432 
1433 It nominally contains 3 frames, but only the first one is valid. It came from a
1434 fuzzer doing random mutations and copies. The breakdown:
1435 
1436 @000  6 bytes magic "GIF89a"
1437 @006  7 bytes Logical Screen Descriptor: 0x20 0x00 ... 0x00
1438    - width     =    32
1439    - height    =     0
1440    - flags     =  0x00
1441    - background color index, pixel aspect ratio bytes ignored
1442 @00D 10 bytes Image Descriptor header: 0x2C 0xFF ... 0x40
1443    - origin_x  =   255
1444    - origin_y  =   116
1445    - width     =     6
1446    - height    =     0
1447    - flags     =  0x40, interlaced
1448 @017  2 bytes Image Descriptor body (pixel data): 0x01 0x00
1449    - lit_width =     1
1450    - 0x00 byte means "end of data" for this frame
1451 @019  8 bytes Graphic Control Extension: 0x21 0xF9 ... 0x00
1452    - valid, but irrelevant here.
1453 @021 10 bytes Image Descriptor header: 0x2C 0xFF ... 0x06
1454    - origin_x  =   255
1455    - origin_y  =     0
1456    - width     =   255
1457    - height    =   116
1458    - flags     =  0x06, INVALID, 0x80 BIT ZERO IMPLIES 0x07 BITS SHOULD BE ZERO
1459 @02B 14 bytes Image Descriptor body (pixel data): 0x06 0x06 ... 0x00
1460    - lit_width =     6
1461    - 0x06 precedes a 6 byte block of data
1462    - 0x04 precedes a 4 byte block of data
1463    - 0x00 byte means "end of data" for this frame
1464 @039 10 bytes Image Descriptor header: 0x2C 0xFF ... 0x06
1465    - origin_x  =   255
1466    - origin_y  =     0
1467    - width     = 52479
1468    - height    = 13851
1469    - flags     =  0x52, INVALID, 0x80 BIT ZERO IMPLIES 0x07 BITS SHOULD BE ZERO
1470 @043  5 bytes Image Descriptor body (pixel data): 0x66 0xDE ... unexpected-EOF
1471    - lit_width =   102, INVALID, GREATER THAN 8
1472    - 0xDE precedes a 222 byte block of data, INVALIDLY TRUNCATED
1473 
1474 On Image Descriptor flags INVALIDITY,
1475 https://www.w3.org/Graphics/GIF/spec-gif89a.txt section 20.c says that "Size of
1476 Local Color Table [the low 3 bits]... should be 0 if there is no Local Color
1477 Table specified [the high bit]."
1478 
1479 On LZW literal width (also known as Minimum Code Size) INVALIDITY,
1480 https://www.w3.org/Graphics/GIF/spec-gif89a.txt Appendix F says that "Normally
1481 this will be the same as the number of [palette index] bits. Because of some
1482 algorithmic constraints however, black & white images which have one color bit
1483 must be indicated as having a code size of 2." In practice, some GIF decoders,
1484 including both the old third_party/gif code and the Wuffs GIF decoder, don't
1485 enforce this "at least 2" constraint. Nonetheless, any width greater than 8 is
1486 invalid, as there are only 8 bits in a byte.
1487 */
1488 
DEF_TEST(Codec_InvalidAnimated,r)1489 DEF_TEST(Codec_InvalidAnimated, r) {
1490     // ASAN will complain if there is an issue.
1491     auto path = "invalid_images/skbug6046.gif";
1492     auto stream = GetResourceAsStream(path);
1493     if (!stream) {
1494         return;
1495     }
1496 
1497     std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream)));
1498     REPORTER_ASSERT(r, codec);
1499     if (!codec) {
1500         return;
1501     }
1502 
1503     const auto info = codec->getInfo().makeColorType(kN32_SkColorType);
1504     SkBitmap bm;
1505     bm.allocPixels(info);
1506 
1507     auto frameInfos = codec->getFrameInfo();
1508     SkCodec::Options opts;
1509     for (int i = 0; static_cast<size_t>(i) < frameInfos.size(); i++) {
1510         opts.fFrameIndex = i;
1511         const auto reqFrame = frameInfos[i].fRequiredFrame;
1512         opts.fPriorFrame = reqFrame == i - 1 ? reqFrame : SkCodec::kNoFrame;
1513         auto result = codec->startIncrementalDecode(info, bm.getPixels(), bm.rowBytes(), &opts);
1514 
1515         if (result != SkCodec::kSuccess) {
1516             ERRORF(r, "Failed to start decoding frame %i (out of %i) with error %i\n", i,
1517                    frameInfos.size(), result);
1518             continue;
1519         }
1520 
1521         codec->incrementalDecode();
1522     }
1523 }
1524 
encode_format(SkDynamicMemoryWStream * stream,const SkPixmap & pixmap,SkEncodedImageFormat format)1525 static void encode_format(SkDynamicMemoryWStream* stream, const SkPixmap& pixmap,
1526                           SkEncodedImageFormat format) {
1527     switch (format) {
1528         case SkEncodedImageFormat::kPNG:
1529             SkPngEncoder::Encode(stream, pixmap, SkPngEncoder::Options());
1530             break;
1531         case SkEncodedImageFormat::kJPEG:
1532             SkJpegEncoder::Encode(stream, pixmap, SkJpegEncoder::Options());
1533             break;
1534         case SkEncodedImageFormat::kWEBP:
1535             SkWebpEncoder::Encode(stream, pixmap, SkWebpEncoder::Options());
1536             break;
1537         default:
1538             SkASSERT(false);
1539             break;
1540     }
1541 }
1542 
test_encode_icc(skiatest::Reporter * r,SkEncodedImageFormat format)1543 static void test_encode_icc(skiatest::Reporter* r, SkEncodedImageFormat format) {
1544     // Test with sRGB color space.
1545     SkBitmap srgbBitmap;
1546     SkImageInfo srgbInfo = SkImageInfo::MakeS32(1, 1, kOpaque_SkAlphaType);
1547     srgbBitmap.allocPixels(srgbInfo);
1548     *srgbBitmap.getAddr32(0, 0) = 0;
1549     SkPixmap pixmap;
1550     srgbBitmap.peekPixels(&pixmap);
1551     SkDynamicMemoryWStream srgbBuf;
1552     encode_format(&srgbBuf, pixmap, format);
1553     sk_sp<SkData> srgbData = srgbBuf.detachAsData();
1554     std::unique_ptr<SkCodec> srgbCodec(SkCodec::MakeFromData(srgbData));
1555     REPORTER_ASSERT(r, srgbCodec->getInfo().colorSpace() == sk_srgb_singleton());
1556 
1557     // Test with P3 color space.
1558     SkDynamicMemoryWStream p3Buf;
1559     sk_sp<SkColorSpace> p3 = SkColorSpace::MakeRGB(SkNamedTransferFn::kSRGB, SkNamedGamut::kDCIP3);
1560     pixmap.setColorSpace(p3);
1561     encode_format(&p3Buf, pixmap, format);
1562     sk_sp<SkData> p3Data = p3Buf.detachAsData();
1563     std::unique_ptr<SkCodec> p3Codec(SkCodec::MakeFromData(p3Data));
1564     REPORTER_ASSERT(r, p3Codec->getInfo().colorSpace()->gammaCloseToSRGB());
1565     skcms_Matrix3x3 mat0, mat1;
1566     bool success = p3->toXYZD50(&mat0);
1567     REPORTER_ASSERT(r, success);
1568     success = p3Codec->getInfo().colorSpace()->toXYZD50(&mat1);
1569     REPORTER_ASSERT(r, success);
1570 
1571     for (int i = 0; i < 3; i++) {
1572         for (int j = 0; j < 3; j++) {
1573             REPORTER_ASSERT(r, color_space_almost_equal(mat0.vals[i][j], mat1.vals[i][j]));
1574         }
1575     }
1576 }
1577 
DEF_TEST(Codec_EncodeICC,r)1578 DEF_TEST(Codec_EncodeICC, r) {
1579     test_encode_icc(r, SkEncodedImageFormat::kPNG);
1580     test_encode_icc(r, SkEncodedImageFormat::kJPEG);
1581     test_encode_icc(r, SkEncodedImageFormat::kWEBP);
1582 }
1583 
DEF_TEST(Codec_webp_rowsDecoded,r)1584 DEF_TEST(Codec_webp_rowsDecoded, r) {
1585     const char* path = "images/baby_tux.webp";
1586     sk_sp<SkData> data(GetResourceAsData(path));
1587     if (!data) {
1588         return;
1589     }
1590 
1591     // Truncate this file so that the header is available but no rows can be
1592     // decoded. This should create a codec but fail to decode.
1593     size_t truncatedSize = 5000;
1594     sk_sp<SkData> subset = SkData::MakeSubset(data.get(), 0, truncatedSize);
1595     std::unique_ptr<SkCodec> codec = SkCodec::MakeFromData(std::move(subset));
1596     if (!codec) {
1597         ERRORF(r, "Failed to create a codec for %s truncated to only %lu bytes",
1598                path, truncatedSize);
1599         return;
1600     }
1601 
1602     test_info(r, codec.get(), codec->getInfo(), SkCodec::kInvalidInput, nullptr);
1603 }
1604 
1605 /*
1606 For the Codec_ossfuzz6274 test, immediately below,
1607 resources/invalid_images/ossfuzz6274.gif is:
1608 
1609 00000000: 4749 4638 3961 2000 2000 f120 2020 2020  GIF89a . ..
1610 00000010: 2020 2020 2020 2020 2021 f903 ff20 2020           !...
1611 00000020: 002c 0000 0000 2000 2000 2000 00         .,.... . . ..
1612 
1613 @000  6 bytes magic "GIF89a"
1614 @006  7 bytes Logical Screen Descriptor: 0x20 0x00 ... 0x00
1615    - width     =    32
1616    - height    =    32
1617    - flags     =  0xF1, global color table, 4 RGB entries
1618    - background color index, pixel aspect ratio bytes ignored
1619 @00D 12 bytes Color Table: 0x20 0x20 ... 0x20
1620 @019 20 bytes Graphic Control Extension: 0x21 0xF9 ... unexpected-EOF
1621    - 0x03 precedes a 3 byte block of data, INVALID, MUST BE 4
1622    - 0x20 precedes a 32 byte block of data, INVALIDly truncated
1623 
1624 https://www.w3.org/Graphics/GIF/spec-gif89a.txt section 23.c says that the
1625 block size (for an 0x21 0xF9 Graphic Control Extension) must be "the fixed
1626 value 4".
1627 */
1628 
DEF_TEST(Codec_ossfuzz6274,r)1629 DEF_TEST(Codec_ossfuzz6274, r) {
1630     if (GetResourcePath().isEmpty()) {
1631         return;
1632     }
1633 
1634     const char* file = "invalid_images/ossfuzz6274.gif";
1635     auto image = GetResourceAsImage(file);
1636 
1637 #ifdef SK_HAS_WUFFS_LIBRARY
1638     // We are transitioning from an old GIF implementation to a new (Wuffs) GIF
1639     // implementation.
1640     //
1641     // This test (without SK_HAS_WUFFS_LIBRARY) is overly specific to the old
1642     // implementation. In the new implementation, the MakeFromStream factory
1643     // method returns a nullptr SkImage*, instead of returning a non-null but
1644     // otherwise all-transparent SkImage*.
1645     //
1646     // Either way, the end-to-end result is the same - the source input is
1647     // rejected as an invalid GIF image - but the two implementations differ in
1648     // how that's represented.
1649     //
1650     // Once the transition is complete, we can remove the #ifdef and delete the
1651     // rest of the test function.
1652     //
1653     // See Codec_GifTruncated3 for the equivalent of the rest of the test
1654     // function, on different (but still truncated) source data.
1655     if (image) {
1656         ERRORF(r, "Invalid data gave non-nullptr image");
1657     }
1658     return;
1659 #endif
1660 
1661     if (!image) {
1662         ERRORF(r, "Missing %s", file);
1663         return;
1664     }
1665 
1666     REPORTER_ASSERT(r, image->width()  == 32);
1667     REPORTER_ASSERT(r, image->height() == 32);
1668 
1669     SkBitmap bm;
1670     if (!bm.tryAllocPixels(SkImageInfo::MakeN32Premul(32, 32))) {
1671         ERRORF(r, "Failed to allocate pixels");
1672         return;
1673     }
1674 
1675     bm.eraseColor(SK_ColorTRANSPARENT);
1676 
1677     SkCanvas canvas(bm);
1678     canvas.drawImage(image, 0, 0, nullptr);
1679 
1680     for (int i = 0; i < image->width();  ++i)
1681     for (int j = 0; j < image->height(); ++j) {
1682         SkColor actual = SkUnPreMultiply::PMColorToColor(*bm.getAddr32(i, j));
1683         if (actual != SK_ColorTRANSPARENT) {
1684             ERRORF(r, "did not initialize pixels! %i, %i is %x", i, j, actual);
1685         }
1686     }
1687 }
1688 
DEF_TEST(Codec_78329453,r)1689 DEF_TEST(Codec_78329453, r) {
1690     if (GetResourcePath().isEmpty()) {
1691         return;
1692     }
1693 
1694     const char* file = "images/b78329453.jpeg";
1695     auto data = GetResourceAsData(file);
1696     if (!data) {
1697         ERRORF(r, "Missing %s", file);
1698         return;
1699     }
1700 
1701     auto codec = SkAndroidCodec::MakeFromCodec(SkCodec::MakeFromData(data));
1702     if (!codec) {
1703         ERRORF(r, "failed to create codec from %s", file);
1704         return;
1705     }
1706 
1707     // A bug in jpeg_skip_scanlines resulted in an infinite loop for this specific
1708     // sample size on this image. Other sample sizes could have had the same result,
1709     // but the ones tested by DM happen to not.
1710     constexpr int kSampleSize = 19;
1711     const auto size = codec->getSampledDimensions(kSampleSize);
1712     auto info = codec->getInfo().makeWH(size.width(), size.height());
1713     SkBitmap bm;
1714     bm.allocPixels(info);
1715     bm.eraseColor(SK_ColorTRANSPARENT);
1716 
1717     SkAndroidCodec::AndroidOptions options;
1718     options.fSampleSize = kSampleSize;
1719     auto result = codec->getAndroidPixels(info, bm.getPixels(), bm.rowBytes(), &options);
1720     if (result != SkCodec::kSuccess) {
1721         ERRORF(r, "failed to decode with error %s", SkCodec::ResultToString(result));
1722     }
1723 }
1724 
DEF_TEST(Codec_A8,r)1725 DEF_TEST(Codec_A8, r) {
1726     if (GetResourcePath().isEmpty()) {
1727         return;
1728     }
1729 
1730     const char* file = "images/mandrill_cmyk.jpg";
1731     auto data = GetResourceAsData(file);
1732     if (!data) {
1733         ERRORF(r, "missing %s", file);
1734         return;
1735     }
1736 
1737     auto codec = SkCodec::MakeFromData(std::move(data));
1738     auto info = codec->getInfo().makeColorType(kAlpha_8_SkColorType);
1739     SkBitmap bm;
1740     bm.allocPixels(info);
1741     REPORTER_ASSERT(r, codec->getPixels(bm.pixmap()) == SkCodec::kInvalidConversion);
1742 }
1743 
DEF_TEST(Codec_crbug807324,r)1744 DEF_TEST(Codec_crbug807324, r) {
1745     if (GetResourcePath().isEmpty()) {
1746         return;
1747     }
1748 
1749     const char* file = "images/crbug807324.png";
1750     auto image = GetResourceAsImage(file);
1751     if (!image) {
1752         ERRORF(r, "Missing %s", file);
1753         return;
1754     }
1755 
1756     const int kWidth = image->width();
1757     const int kHeight = image->height();
1758 
1759     SkBitmap bm;
1760     if (!bm.tryAllocPixels(SkImageInfo::MakeN32Premul(kWidth, kHeight))) {
1761         ERRORF(r, "Could not allocate pixels (%i x %i)", kWidth, kHeight);
1762         return;
1763     }
1764 
1765     bm.eraseColor(SK_ColorTRANSPARENT);
1766 
1767     SkCanvas canvas(bm);
1768     canvas.drawImage(image, 0, 0, nullptr);
1769 
1770     for (int i = 0; i < kWidth;  ++i)
1771     for (int j = 0; j < kHeight; ++j) {
1772         if (*bm.getAddr32(i, j) == SK_ColorTRANSPARENT) {
1773             ERRORF(r, "image should not be transparent! %i, %i is 0", i, j);
1774             return;
1775         }
1776     }
1777 }
1778