1 /*
2 * Copyright 2019 Google Inc.
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8 #include "src/gpu/ops/OpsTask.h"
9
10 #include "include/gpu/GrRecordingContext.h"
11 #include "src/core/SkRectPriv.h"
12 #include "src/core/SkScopeExit.h"
13 #include "src/core/SkTraceEvent.h"
14 #include "src/gpu/GrAttachment.h"
15 #include "src/gpu/GrAuditTrail.h"
16 #include "src/gpu/GrCaps.h"
17 #include "src/gpu/GrGpu.h"
18 #include "src/gpu/GrMemoryPool.h"
19 #include "src/gpu/GrOpFlushState.h"
20 #include "src/gpu/GrOpsRenderPass.h"
21 #include "src/gpu/GrRecordingContextPriv.h"
22 #include "src/gpu/GrRenderTarget.h"
23 #include "src/gpu/GrResourceAllocator.h"
24 #include "src/gpu/GrResourceProvider.h"
25 #include "src/gpu/GrTexture.h"
26 #include "src/gpu/geometry/GrRect.h"
27
28 ////////////////////////////////////////////////////////////////////////////////
29
30 namespace {
31
32 // Experimentally we have found that most combining occurs within the first 10 comparisons.
33 static const int kMaxOpMergeDistance = 10;
34 static const int kMaxOpChainDistance = 10;
35
36 ////////////////////////////////////////////////////////////////////////////////
37
can_reorder(const SkRect & a,const SkRect & b)38 inline bool can_reorder(const SkRect& a, const SkRect& b) { return !GrRectsOverlap(a, b); }
39
create_render_pass(GrGpu * gpu,GrRenderTarget * rt,bool useMSAASurface,GrAttachment * stencil,GrSurfaceOrigin origin,const SkIRect & bounds,GrLoadOp colorLoadOp,const std::array<float,4> & loadClearColor,GrLoadOp stencilLoadOp,GrStoreOp stencilStoreOp,const SkTArray<GrSurfaceProxy *,true> & sampledProxies,GrXferBarrierFlags renderPassXferBarriers)40 GrOpsRenderPass* create_render_pass(GrGpu* gpu,
41 GrRenderTarget* rt,
42 bool useMSAASurface,
43 GrAttachment* stencil,
44 GrSurfaceOrigin origin,
45 const SkIRect& bounds,
46 GrLoadOp colorLoadOp,
47 const std::array<float, 4>& loadClearColor,
48 GrLoadOp stencilLoadOp,
49 GrStoreOp stencilStoreOp,
50 const SkTArray<GrSurfaceProxy*, true>& sampledProxies,
51 GrXferBarrierFlags renderPassXferBarriers) {
52 const GrOpsRenderPass::LoadAndStoreInfo kColorLoadStoreInfo {
53 colorLoadOp,
54 GrStoreOp::kStore,
55 loadClearColor
56 };
57
58 // TODO:
59 // We would like to (at this level) only ever clear & discard. We would need
60 // to stop splitting up higher level OpsTasks for copyOps to achieve that.
61 // Note: we would still need SB loads and stores but they would happen at a
62 // lower level (inside the VK command buffer).
63 const GrOpsRenderPass::StencilLoadAndStoreInfo stencilLoadAndStoreInfo {
64 stencilLoadOp,
65 stencilStoreOp,
66 };
67
68 return gpu->getOpsRenderPass(rt, useMSAASurface, stencil, origin, bounds, kColorLoadStoreInfo,
69 stencilLoadAndStoreInfo, sampledProxies, renderPassXferBarriers);
70 }
71
72 } // anonymous namespace
73
74 ////////////////////////////////////////////////////////////////////////////////
75
76 namespace skgpu::v1 {
77
List(GrOp::Owner op)78 inline OpsTask::OpChain::List::List(GrOp::Owner op)
79 : fHead(std::move(op)), fTail(fHead.get()) {
80 this->validate();
81 }
82
List(List && that)83 inline OpsTask::OpChain::List::List(List&& that) { *this = std::move(that); }
84
operator =(List && that)85 inline OpsTask::OpChain::List& OpsTask::OpChain::List::operator=(List&& that) {
86 fHead = std::move(that.fHead);
87 fTail = that.fTail;
88 that.fTail = nullptr;
89 this->validate();
90 return *this;
91 }
92
popHead()93 inline GrOp::Owner OpsTask::OpChain::List::popHead() {
94 SkASSERT(fHead);
95 auto temp = fHead->cutChain();
96 std::swap(temp, fHead);
97 if (!fHead) {
98 SkASSERT(fTail == temp.get());
99 fTail = nullptr;
100 }
101 return temp;
102 }
103
removeOp(GrOp * op)104 inline GrOp::Owner OpsTask::OpChain::List::removeOp(GrOp* op) {
105 #ifdef SK_DEBUG
106 auto head = op;
107 while (head->prevInChain()) { head = head->prevInChain(); }
108 SkASSERT(head == fHead.get());
109 #endif
110 auto prev = op->prevInChain();
111 if (!prev) {
112 SkASSERT(op == fHead.get());
113 return this->popHead();
114 }
115 auto temp = prev->cutChain();
116 if (auto next = temp->cutChain()) {
117 prev->chainConcat(std::move(next));
118 } else {
119 SkASSERT(fTail == op);
120 fTail = prev;
121 }
122 this->validate();
123 return temp;
124 }
125
pushHead(GrOp::Owner op)126 inline void OpsTask::OpChain::List::pushHead(GrOp::Owner op) {
127 SkASSERT(op);
128 SkASSERT(op->isChainHead());
129 SkASSERT(op->isChainTail());
130 if (fHead) {
131 op->chainConcat(std::move(fHead));
132 fHead = std::move(op);
133 } else {
134 fHead = std::move(op);
135 fTail = fHead.get();
136 }
137 }
138
pushTail(GrOp::Owner op)139 inline void OpsTask::OpChain::List::pushTail(GrOp::Owner op) {
140 SkASSERT(op->isChainTail());
141 fTail->chainConcat(std::move(op));
142 fTail = fTail->nextInChain();
143 }
144
validate() const145 inline void OpsTask::OpChain::List::validate() const {
146 #ifdef SK_DEBUG
147 if (fHead) {
148 SkASSERT(fTail);
149 fHead->validateChain(fTail);
150 }
151 #endif
152 }
153
154 ////////////////////////////////////////////////////////////////////////////////
155
OpChain(GrOp::Owner op,GrProcessorSet::Analysis processorAnalysis,GrAppliedClip * appliedClip,const GrDstProxyView * dstProxyView)156 OpsTask::OpChain::OpChain(GrOp::Owner op, GrProcessorSet::Analysis processorAnalysis,
157 GrAppliedClip* appliedClip, const GrDstProxyView* dstProxyView)
158 : fList{std::move(op)}
159 , fProcessorAnalysis(processorAnalysis)
160 , fAppliedClip(appliedClip) {
161 if (fProcessorAnalysis.requiresDstTexture()) {
162 SkASSERT(dstProxyView && dstProxyView->proxy());
163 fDstProxyView = *dstProxyView;
164 }
165 fBounds = fList.head()->bounds();
166 }
167
visitProxies(const GrVisitProxyFunc & func) const168 void OpsTask::OpChain::visitProxies(const GrVisitProxyFunc& func) const {
169 if (fList.empty()) {
170 return;
171 }
172 for (const auto& op : GrOp::ChainRange<>(fList.head())) {
173 op.visitProxies(func);
174 }
175 if (fDstProxyView.proxy()) {
176 func(fDstProxyView.proxy(), GrMipmapped::kNo);
177 }
178 if (fAppliedClip) {
179 fAppliedClip->visitProxies(func);
180 }
181 }
182
deleteOps()183 void OpsTask::OpChain::deleteOps() {
184 while (!fList.empty()) {
185 // Since the value goes out of scope immediately, the GrOp::Owner deletes the op.
186 fList.popHead();
187 }
188 }
189
190 // Concatenates two op chains and attempts to merge ops across the chains. Assumes that we know that
191 // the two chains are chainable. Returns the new chain.
DoConcat(List chainA,List chainB,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)192 OpsTask::OpChain::List OpsTask::OpChain::DoConcat(List chainA, List chainB, const GrCaps& caps,
193 SkArenaAlloc* opsTaskArena,
194 GrAuditTrail* auditTrail) {
195 // We process ops in chain b from head to tail. We attempt to merge with nodes in a, starting
196 // at chain a's tail and working toward the head. We produce one of the following outcomes:
197 // 1) b's head is merged into an op in a.
198 // 2) An op from chain a is merged into b's head. (In this case b's head gets processed again.)
199 // 3) b's head is popped from chain a and added at the tail of a.
200 // After result 3 we don't want to attempt to merge the next head of b with the new tail of a,
201 // as we assume merges were already attempted when chain b was created. So we keep track of the
202 // original tail of a and start our iteration of a there. We also track the bounds of the nodes
203 // appended to chain a that will be skipped for bounds testing. If the original tail of a is
204 // merged into an op in b (case 2) then we advance the "original tail" towards the head of a.
205 GrOp* origATail = chainA.tail();
206 SkRect skipBounds = SkRectPriv::MakeLargestInverted();
207 do {
208 int numMergeChecks = 0;
209 bool merged = false;
210 bool noSkip = (origATail == chainA.tail());
211 SkASSERT(noSkip == (skipBounds == SkRectPriv::MakeLargestInverted()));
212 bool canBackwardMerge = noSkip || can_reorder(chainB.head()->bounds(), skipBounds);
213 SkRect forwardMergeBounds = skipBounds;
214 GrOp* a = origATail;
215 while (a) {
216 bool canForwardMerge =
217 (a == chainA.tail()) || can_reorder(a->bounds(), forwardMergeBounds);
218 if (canForwardMerge || canBackwardMerge) {
219 auto result = a->combineIfPossible(chainB.head(), opsTaskArena, caps);
220 SkASSERT(result != GrOp::CombineResult::kCannotCombine);
221 merged = (result == GrOp::CombineResult::kMerged);
222 GrOP_INFO("\t\t: (%s opID: %u) -> Combining with (%s, opID: %u)\n",
223 chainB.head()->name(), chainB.head()->uniqueID(), a->name(),
224 a->uniqueID());
225 }
226 if (merged) {
227 GR_AUDIT_TRAIL_OPS_RESULT_COMBINED(auditTrail, a, chainB.head());
228 if (canBackwardMerge) {
229 // The GrOp::Owner releases the op.
230 chainB.popHead();
231 } else {
232 // We merged the contents of b's head into a. We will replace b's head with a in
233 // chain b.
234 SkASSERT(canForwardMerge);
235 if (a == origATail) {
236 origATail = a->prevInChain();
237 }
238 GrOp::Owner detachedA = chainA.removeOp(a);
239 // The GrOp::Owner releases the op.
240 chainB.popHead();
241 chainB.pushHead(std::move(detachedA));
242 if (chainA.empty()) {
243 // We merged all the nodes in chain a to chain b.
244 return chainB;
245 }
246 }
247 break;
248 } else {
249 if (++numMergeChecks == kMaxOpMergeDistance) {
250 break;
251 }
252 forwardMergeBounds.joinNonEmptyArg(a->bounds());
253 canBackwardMerge =
254 canBackwardMerge && can_reorder(chainB.head()->bounds(), a->bounds());
255 a = a->prevInChain();
256 }
257 }
258 // If we weren't able to merge b's head then pop b's head from chain b and make it the new
259 // tail of a.
260 if (!merged) {
261 chainA.pushTail(chainB.popHead());
262 skipBounds.joinNonEmptyArg(chainA.tail()->bounds());
263 }
264 } while (!chainB.empty());
265 return chainA;
266 }
267
268 // Attempts to concatenate the given chain onto our own and merge ops across the chains. Returns
269 // whether the operation succeeded. On success, the provided list will be returned empty.
tryConcat(List * list,GrProcessorSet::Analysis processorAnalysis,const GrDstProxyView & dstProxyView,const GrAppliedClip * appliedClip,const SkRect & bounds,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)270 bool OpsTask::OpChain::tryConcat(
271 List* list, GrProcessorSet::Analysis processorAnalysis, const GrDstProxyView& dstProxyView,
272 const GrAppliedClip* appliedClip, const SkRect& bounds, const GrCaps& caps,
273 SkArenaAlloc* opsTaskArena, GrAuditTrail* auditTrail) {
274 SkASSERT(!fList.empty());
275 SkASSERT(!list->empty());
276 SkASSERT(fProcessorAnalysis.requiresDstTexture() == SkToBool(fDstProxyView.proxy()));
277 SkASSERT(processorAnalysis.requiresDstTexture() == SkToBool(dstProxyView.proxy()));
278 // All returns use explicit tuple constructor rather than {a, b} to work around old GCC bug.
279 if (fList.head()->classID() != list->head()->classID() ||
280 SkToBool(fAppliedClip) != SkToBool(appliedClip) ||
281 (fAppliedClip && *fAppliedClip != *appliedClip) ||
282 (fProcessorAnalysis.requiresNonOverlappingDraws() !=
283 processorAnalysis.requiresNonOverlappingDraws()) ||
284 (fProcessorAnalysis.requiresNonOverlappingDraws() &&
285 // Non-overlaping draws are only required when Ganesh will either insert a barrier,
286 // or read back a new dst texture between draws. In either case, we can neither
287 // chain nor combine overlapping Ops.
288 GrRectsTouchOrOverlap(fBounds, bounds)) ||
289 (fProcessorAnalysis.requiresDstTexture() != processorAnalysis.requiresDstTexture()) ||
290 (fProcessorAnalysis.requiresDstTexture() && fDstProxyView != dstProxyView)) {
291 return false;
292 }
293
294 SkDEBUGCODE(bool first = true;)
295 do {
296 switch (fList.tail()->combineIfPossible(list->head(), opsTaskArena, caps))
297 {
298 case GrOp::CombineResult::kCannotCombine:
299 // If an op supports chaining then it is required that chaining is transitive and
300 // that if any two ops in two different chains can merge then the two chains
301 // may also be chained together. Thus, we should only hit this on the first
302 // iteration.
303 SkASSERT(first);
304 return false;
305 case GrOp::CombineResult::kMayChain:
306 fList = DoConcat(std::move(fList), std::exchange(*list, List()), caps, opsTaskArena,
307 auditTrail);
308 // The above exchange cleared out 'list'. The list needs to be empty now for the
309 // loop to terminate.
310 SkASSERT(list->empty());
311 break;
312 case GrOp::CombineResult::kMerged: {
313 GrOP_INFO("\t\t: (%s opID: %u) -> Combining with (%s, opID: %u)\n",
314 list->tail()->name(), list->tail()->uniqueID(), list->head()->name(),
315 list->head()->uniqueID());
316 GR_AUDIT_TRAIL_OPS_RESULT_COMBINED(auditTrail, fList.tail(), list->head());
317 // The GrOp::Owner releases the op.
318 list->popHead();
319 break;
320 }
321 }
322 SkDEBUGCODE(first = false);
323 } while (!list->empty());
324
325 // The new ops were successfully merged and/or chained onto our own.
326 fBounds.joinPossiblyEmptyRect(bounds);
327 return true;
328 }
329
prependChain(OpChain * that,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)330 bool OpsTask::OpChain::prependChain(OpChain* that, const GrCaps& caps, SkArenaAlloc* opsTaskArena,
331 GrAuditTrail* auditTrail) {
332 if (!that->tryConcat(&fList, fProcessorAnalysis, fDstProxyView, fAppliedClip, fBounds, caps,
333 opsTaskArena, auditTrail)) {
334 this->validate();
335 // append failed
336 return false;
337 }
338
339 // 'that' owns the combined chain. Move it into 'this'.
340 SkASSERT(fList.empty());
341 fList = std::move(that->fList);
342 fBounds = that->fBounds;
343
344 that->fDstProxyView.setProxyView({});
345 if (that->fAppliedClip && that->fAppliedClip->hasCoverageFragmentProcessor()) {
346 // Obliterates the processor.
347 that->fAppliedClip->detachCoverageFragmentProcessor();
348 }
349 this->validate();
350 return true;
351 }
352
appendOp(GrOp::Owner op,GrProcessorSet::Analysis processorAnalysis,const GrDstProxyView * dstProxyView,const GrAppliedClip * appliedClip,const GrCaps & caps,SkArenaAlloc * opsTaskArena,GrAuditTrail * auditTrail)353 GrOp::Owner OpsTask::OpChain::appendOp(
354 GrOp::Owner op, GrProcessorSet::Analysis processorAnalysis,
355 const GrDstProxyView* dstProxyView, const GrAppliedClip* appliedClip, const GrCaps& caps,
356 SkArenaAlloc* opsTaskArena, GrAuditTrail* auditTrail) {
357 const GrDstProxyView noDstProxyView;
358 if (!dstProxyView) {
359 dstProxyView = &noDstProxyView;
360 }
361 SkASSERT(op->isChainHead() && op->isChainTail());
362 SkRect opBounds = op->bounds();
363 List chain(std::move(op));
364 if (!this->tryConcat(&chain, processorAnalysis, *dstProxyView, appliedClip, opBounds, caps,
365 opsTaskArena, auditTrail)) {
366 // append failed, give the op back to the caller.
367 this->validate();
368 return chain.popHead();
369 }
370
371 SkASSERT(chain.empty());
372 this->validate();
373 return nullptr;
374 }
375
validate() const376 inline void OpsTask::OpChain::validate() const {
377 #ifdef SK_DEBUG
378 fList.validate();
379 for (const auto& op : GrOp::ChainRange<>(fList.head())) {
380 // Not using SkRect::contains because we allow empty rects.
381 SkASSERT(fBounds.fLeft <= op.bounds().fLeft && fBounds.fTop <= op.bounds().fTop &&
382 fBounds.fRight >= op.bounds().fRight && fBounds.fBottom >= op.bounds().fBottom);
383 }
384 #endif
385 }
386
387 ////////////////////////////////////////////////////////////////////////////////
388
OpsTask(GrDrawingManager * drawingMgr,GrSurfaceProxyView view,GrAuditTrail * auditTrail,sk_sp<GrArenas> arenas)389 OpsTask::OpsTask(GrDrawingManager* drawingMgr,
390 GrSurfaceProxyView view,
391 GrAuditTrail* auditTrail,
392 sk_sp<GrArenas> arenas)
393 : GrRenderTask()
394 , fAuditTrail(auditTrail)
395 , fUsesMSAASurface(view.asRenderTargetProxy()->numSamples() > 1)
396 , fTargetSwizzle(view.swizzle())
397 , fTargetOrigin(view.origin())
398 , fArenas{std::move(arenas)}
399 SkDEBUGCODE(, fNumClips(0)) {
400 this->addTarget(drawingMgr, view.detachProxy());
401 }
402
deleteOps()403 void OpsTask::deleteOps() {
404 for (auto& chain : fOpChains) {
405 chain.deleteOps();
406 }
407 fOpChains.reset();
408 }
409
~OpsTask()410 OpsTask::~OpsTask() {
411 this->deleteOps();
412 }
413
addOp(GrDrawingManager * drawingMgr,GrOp::Owner op,GrTextureResolveManager textureResolveManager,const GrCaps & caps)414 void OpsTask::addOp(GrDrawingManager* drawingMgr, GrOp::Owner op,
415 GrTextureResolveManager textureResolveManager, const GrCaps& caps) {
416 auto addDependency = [&](GrSurfaceProxy* p, GrMipmapped mipmapped) {
417 this->addDependency(drawingMgr, p, mipmapped, textureResolveManager, caps);
418 };
419
420 op->visitProxies(addDependency);
421
422 this->recordOp(std::move(op), false/*usesMSAA*/, GrProcessorSet::EmptySetAnalysis(), nullptr,
423 nullptr, caps);
424 }
425
addDrawOp(GrDrawingManager * drawingMgr,GrOp::Owner op,bool usesMSAA,const GrProcessorSet::Analysis & processorAnalysis,GrAppliedClip && clip,const GrDstProxyView & dstProxyView,GrTextureResolveManager textureResolveManager,const GrCaps & caps)426 void OpsTask::addDrawOp(GrDrawingManager* drawingMgr, GrOp::Owner op, bool usesMSAA,
427 const GrProcessorSet::Analysis& processorAnalysis, GrAppliedClip&& clip,
428 const GrDstProxyView& dstProxyView,
429 GrTextureResolveManager textureResolveManager, const GrCaps& caps) {
430 auto addDependency = [&](GrSurfaceProxy* p, GrMipmapped mipmapped) {
431 this->addSampledTexture(p);
432 this->addDependency(drawingMgr, p, mipmapped, textureResolveManager, caps);
433 };
434
435 op->visitProxies(addDependency);
436 clip.visitProxies(addDependency);
437 if (dstProxyView.proxy()) {
438 if (!(dstProxyView.dstSampleFlags() & GrDstSampleFlags::kAsInputAttachment)) {
439 this->addSampledTexture(dstProxyView.proxy());
440 }
441 if (dstProxyView.dstSampleFlags() & GrDstSampleFlags::kRequiresTextureBarrier) {
442 fRenderPassXferBarriers |= GrXferBarrierFlags::kTexture;
443 }
444 addDependency(dstProxyView.proxy(), GrMipmapped::kNo);
445 SkASSERT(!(dstProxyView.dstSampleFlags() & GrDstSampleFlags::kAsInputAttachment) ||
446 dstProxyView.offset().isZero());
447 }
448
449 if (processorAnalysis.usesNonCoherentHWBlending()) {
450 fRenderPassXferBarriers |= GrXferBarrierFlags::kBlend;
451 }
452
453 this->recordOp(std::move(op), usesMSAA, processorAnalysis, clip.doesClip() ? &clip : nullptr,
454 &dstProxyView, caps);
455 }
456
endFlush(GrDrawingManager * drawingMgr)457 void OpsTask::endFlush(GrDrawingManager* drawingMgr) {
458 fLastClipStackGenID = SK_InvalidUniqueID;
459 this->deleteOps();
460
461 fDeferredProxies.reset();
462 fSampledProxies.reset();
463 fAuditTrail = nullptr;
464
465 GrRenderTask::endFlush(drawingMgr);
466 }
467
onPrePrepare(GrRecordingContext * context)468 void OpsTask::onPrePrepare(GrRecordingContext* context) {
469 SkASSERT(this->isClosed());
470 // TODO: remove the check for discard here once reduced op splitting is turned on. Currently we
471 // can end up with OpsTasks that only have a discard load op and no ops. For vulkan validation
472 // we need to keep that discard and not drop it. Once we have reduce op list splitting enabled
473 // we shouldn't end up with OpsTasks with only discard.
474 if (this->isColorNoOp() ||
475 (fClippedContentBounds.isEmpty() && fColorLoadOp != GrLoadOp::kDiscard)) {
476 return;
477 }
478 TRACE_EVENT0("skia.gpu", TRACE_FUNC);
479
480 GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
481 for (const auto& chain : fOpChains) {
482 if (chain.shouldExecute()) {
483 chain.head()->prePrepare(context,
484 dstView,
485 chain.appliedClip(),
486 chain.dstProxyView(),
487 fRenderPassXferBarriers,
488 fColorLoadOp);
489 }
490 }
491 }
492
onPrepare(GrOpFlushState * flushState)493 void OpsTask::onPrepare(GrOpFlushState* flushState) {
494 SkASSERT(this->target(0)->peekRenderTarget());
495 SkASSERT(this->isClosed());
496 // TODO: remove the check for discard here once reduced op splitting is turned on. Currently we
497 // can end up with OpsTasks that only have a discard load op and no ops. For vulkan validation
498 // we need to keep that discard and not drop it. Once we have reduce op list splitting enabled
499 // we shouldn't end up with OpsTasks with only discard.
500 if (this->isColorNoOp() ||
501 (fClippedContentBounds.isEmpty() && fColorLoadOp != GrLoadOp::kDiscard)) {
502 return;
503 }
504 TRACE_EVENT0("skia.gpu", TRACE_FUNC);
505
506 flushState->setSampledProxyArray(&fSampledProxies);
507 GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
508 auto grGpu = flushState->gpu();
509 // Loop over the ops that haven't yet been prepared.
510 for (const auto& chain : fOpChains) {
511 if (chain.shouldExecute()) {
512 #ifdef SK_BUILD_FOR_ANDROID_FRAMEWORK
513 TRACE_EVENT0("skia.gpu", chain.head()->name());
514 #endif
515 auto tag = chain.head()->getGrOpTag();
516 if (grGpu && tag.isGrTagValid()) {
517 grGpu->setCurrentGrResourceTag(tag);
518 }
519 GrOpFlushState::OpArgs opArgs(chain.head(),
520 dstView,
521 fUsesMSAASurface,
522 chain.appliedClip(),
523 chain.dstProxyView(),
524 fRenderPassXferBarriers,
525 fColorLoadOp);
526
527 flushState->setOpArgs(&opArgs);
528
529 // Temporary debugging helper: for debugging prePrepare w/o going through DDLs
530 // Delete once most of the GrOps have an onPrePrepare.
531 // chain.head()->prePrepare(flushState->gpu()->getContext(), &this->target(0),
532 // chain.appliedClip());
533
534 // GrOp::prePrepare may or may not have been called at this point
535 chain.head()->prepare(flushState);
536 flushState->setOpArgs(nullptr);
537 if (grGpu && tag.isGrTagValid()) {
538 GrGpuResourceTag grGpuResourceTag;
539 grGpu->setCurrentGrResourceTag(grGpuResourceTag);
540 }
541 }
542 }
543 flushState->setSampledProxyArray(nullptr);
544 }
545
546 // TODO: this is where GrOp::renderTarget is used (which is fine since it
547 // is at flush time). However, we need to store the RenderTargetProxy in the
548 // Ops and instantiate them here.
onExecute(GrOpFlushState * flushState)549 bool OpsTask::onExecute(GrOpFlushState* flushState) {
550 SkASSERT(this->numTargets() == 1);
551 GrRenderTargetProxy* proxy = this->target(0)->asRenderTargetProxy();
552 SkASSERT(proxy);
553 SK_AT_SCOPE_EXIT(proxy->clearArenas());
554
555 // TODO: remove the check for discard here once reduced op splitting is turned on. Currently we
556 // can end up with OpsTasks that only have a discard load op and no ops. For vulkan validation
557 // we need to keep that discard and not drop it. Once we have reduce op list splitting enabled
558 // we shouldn't end up with OpsTasks with only discard.
559 if (this->isColorNoOp() ||
560 (fClippedContentBounds.isEmpty() && fColorLoadOp != GrLoadOp::kDiscard)) {
561 return false;
562 }
563
564 TRACE_EVENT0("skia.gpu", TRACE_FUNC);
565
566 // Make sure load ops are not kClear if the GPU needs to use draws for clears
567 SkASSERT(fColorLoadOp != GrLoadOp::kClear ||
568 !flushState->gpu()->caps()->performColorClearsAsDraws());
569
570 const GrCaps& caps = *flushState->gpu()->caps();
571 GrRenderTarget* renderTarget = proxy->peekRenderTarget();
572 SkASSERT(renderTarget);
573
574 GrAttachment* stencil = nullptr;
575 if (proxy->needsStencil()) {
576 SkASSERT(proxy->canUseStencil(caps));
577 if (!flushState->resourceProvider()->attachStencilAttachment(renderTarget,
578 fUsesMSAASurface)) {
579 SkDebugf("WARNING: failed to attach a stencil buffer. Rendering will be skipped.\n");
580 return false;
581 }
582 stencil = renderTarget->getStencilAttachment(fUsesMSAASurface);
583 }
584
585 GrLoadOp stencilLoadOp;
586 switch (fInitialStencilContent) {
587 case StencilContent::kDontCare:
588 stencilLoadOp = GrLoadOp::kDiscard;
589 break;
590 case StencilContent::kUserBitsCleared:
591 SkASSERT(!caps.performStencilClearsAsDraws());
592 SkASSERT(stencil);
593 if (caps.discardStencilValuesAfterRenderPass()) {
594 // Always clear the stencil if it is being discarded after render passes. This is
595 // also an optimization because we are on a tiler and it avoids loading the values
596 // from memory.
597 stencilLoadOp = GrLoadOp::kClear;
598 break;
599 }
600 if (!stencil->hasPerformedInitialClear()) {
601 stencilLoadOp = GrLoadOp::kClear;
602 stencil->markHasPerformedInitialClear();
603 break;
604 }
605 // SurfaceDrawContexts are required to leave the user stencil bits in a cleared state
606 // once finished, meaning the stencil values will always remain cleared after the
607 // initial clear. Just fall through to reloading the existing (cleared) stencil values
608 // from memory.
609 [[fallthrough]];
610 case StencilContent::kPreserved:
611 SkASSERT(stencil);
612 stencilLoadOp = GrLoadOp::kLoad;
613 break;
614 }
615
616 // NOTE: If fMustPreserveStencil is set, then we are executing a surfaceDrawContext that split
617 // its opsTask.
618 //
619 // FIXME: We don't currently flag render passes that don't use stencil at all. In that case
620 // their store op might be "discard", and we currently make the assumption that a discard will
621 // not invalidate what's already in main memory. This is probably ok for now, but certainly
622 // something we want to address soon.
623 GrStoreOp stencilStoreOp = (caps.discardStencilValuesAfterRenderPass() && !fMustPreserveStencil)
624 ? GrStoreOp::kDiscard
625 : GrStoreOp::kStore;
626
627 GrOpsRenderPass* renderPass = create_render_pass(flushState->gpu(),
628 proxy->peekRenderTarget(),
629 fUsesMSAASurface,
630 stencil,
631 fTargetOrigin,
632 fClippedContentBounds,
633 fColorLoadOp,
634 fLoadClearColor,
635 stencilLoadOp,
636 stencilStoreOp,
637 fSampledProxies,
638 fRenderPassXferBarriers);
639
640 if (!renderPass) {
641 return false;
642 }
643 flushState->setOpsRenderPass(renderPass);
644 renderPass->begin();
645
646 GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
647
648 auto grGpu = flushState->gpu();
649 // Draw all the generated geometry.
650 for (const auto& chain : fOpChains) {
651 if (!chain.shouldExecute()) {
652 continue;
653 }
654 #ifdef SK_BUILD_FOR_ANDROID_FRAMEWORK
655 TRACE_EVENT0("skia.gpu", chain.head()->name());
656 #endif
657 auto tag = chain.head()->getGrOpTag();
658 if (grGpu && tag.isGrTagValid()) {
659 grGpu->setCurrentGrResourceTag(tag);
660 }
661
662 GrOpFlushState::OpArgs opArgs(chain.head(),
663 dstView,
664 fUsesMSAASurface,
665 chain.appliedClip(),
666 chain.dstProxyView(),
667 fRenderPassXferBarriers,
668 fColorLoadOp);
669
670 flushState->setOpArgs(&opArgs);
671 chain.head()->execute(flushState, chain.bounds());
672 flushState->setOpArgs(nullptr);
673 if (grGpu && tag.isGrTagValid()) {
674 GrGpuResourceTag grGpuResourceTag;
675 grGpu->setCurrentGrResourceTag(grGpuResourceTag);
676 }
677 }
678
679 renderPass->end();
680 flushState->gpu()->submit(renderPass);
681 flushState->setOpsRenderPass(nullptr);
682
683 return true;
684 }
685
setColorLoadOp(GrLoadOp op,std::array<float,4> color)686 void OpsTask::setColorLoadOp(GrLoadOp op, std::array<float, 4> color) {
687 fColorLoadOp = op;
688 fLoadClearColor = color;
689 if (GrLoadOp::kClear == fColorLoadOp) {
690 GrSurfaceProxy* proxy = this->target(0);
691 SkASSERT(proxy);
692 fTotalBounds = proxy->backingStoreBoundsRect();
693 }
694 }
695
reset()696 void OpsTask::reset() {
697 fDeferredProxies.reset();
698 fSampledProxies.reset();
699 fClippedContentBounds = SkIRect::MakeEmpty();
700 fTotalBounds = SkRect::MakeEmpty();
701 this->deleteOps();
702 fRenderPassXferBarriers = GrXferBarrierFlags::kNone;
703 }
704
canMerge(const OpsTask * opsTask) const705 bool OpsTask::canMerge(const OpsTask* opsTask) const {
706 return this->target(0) == opsTask->target(0) &&
707 fArenas == opsTask->fArenas &&
708 !opsTask->fCannotMergeBackward;
709 }
710
mergeFrom(SkSpan<const sk_sp<GrRenderTask>> tasks)711 int OpsTask::mergeFrom(SkSpan<const sk_sp<GrRenderTask>> tasks) {
712 int mergedCount = 0;
713 for (const sk_sp<GrRenderTask>& task : tasks) {
714 auto opsTask = task->asOpsTask();
715 if (!opsTask || !this->canMerge(opsTask)) {
716 break;
717 }
718 SkASSERT(fTargetSwizzle == opsTask->fTargetSwizzle);
719 SkASSERT(fTargetOrigin == opsTask->fTargetOrigin);
720 if (GrLoadOp::kClear == opsTask->fColorLoadOp) {
721 // TODO(11903): Go back to actually dropping ops tasks when we are merged with
722 // color clear.
723 return 0;
724 }
725 mergedCount += 1;
726 }
727 if (0 == mergedCount) {
728 return 0;
729 }
730
731 SkSpan<const sk_sp<OpsTask>> mergingNodes(
732 reinterpret_cast<const sk_sp<OpsTask>*>(tasks.data()), SkToSizeT(mergedCount));
733 int addlDeferredProxyCount = 0;
734 int addlProxyCount = 0;
735 int addlOpChainCount = 0;
736 for (const auto& toMerge : mergingNodes) {
737 addlDeferredProxyCount += toMerge->fDeferredProxies.count();
738 addlProxyCount += toMerge->fSampledProxies.count();
739 addlOpChainCount += toMerge->fOpChains.count();
740 fClippedContentBounds.join(toMerge->fClippedContentBounds);
741 fTotalBounds.join(toMerge->fTotalBounds);
742 fRenderPassXferBarriers |= toMerge->fRenderPassXferBarriers;
743 if (fInitialStencilContent == StencilContent::kDontCare) {
744 // Propogate the first stencil content that isn't kDontCare.
745 //
746 // Once the stencil has any kind of initial content that isn't kDontCare, then the
747 // inital contents of subsequent opsTasks that get merged in don't matter.
748 //
749 // (This works because the opsTask all target the same render target and are in
750 // painter's order. kPreserved obviously happens automatically with a merge, and kClear
751 // is also automatic because the contract is for ops to leave the stencil buffer in a
752 // cleared state when finished.)
753 fInitialStencilContent = toMerge->fInitialStencilContent;
754 }
755 fUsesMSAASurface |= toMerge->fUsesMSAASurface;
756 SkDEBUGCODE(fNumClips += toMerge->fNumClips);
757 }
758
759 fLastClipStackGenID = SK_InvalidUniqueID;
760 fDeferredProxies.reserve_back(addlDeferredProxyCount);
761 fSampledProxies.reserve_back(addlProxyCount);
762 fOpChains.reserve_back(addlOpChainCount);
763 for (const auto& toMerge : mergingNodes) {
764 for (GrRenderTask* renderTask : toMerge->dependents()) {
765 renderTask->replaceDependency(toMerge.get(), this);
766 }
767 for (GrRenderTask* renderTask : toMerge->dependencies()) {
768 renderTask->replaceDependent(toMerge.get(), this);
769 }
770 fDeferredProxies.move_back_n(toMerge->fDeferredProxies.count(),
771 toMerge->fDeferredProxies.data());
772 fSampledProxies.move_back_n(toMerge->fSampledProxies.count(),
773 toMerge->fSampledProxies.data());
774 fOpChains.move_back_n(toMerge->fOpChains.count(),
775 toMerge->fOpChains.data());
776 toMerge->fDeferredProxies.reset();
777 toMerge->fSampledProxies.reset();
778 toMerge->fOpChains.reset();
779 }
780 fMustPreserveStencil = mergingNodes.back()->fMustPreserveStencil;
781 return mergedCount;
782 }
783
resetForFullscreenClear(CanDiscardPreviousOps canDiscardPreviousOps)784 bool OpsTask::resetForFullscreenClear(CanDiscardPreviousOps canDiscardPreviousOps) {
785 if (CanDiscardPreviousOps::kYes == canDiscardPreviousOps || this->isEmpty()) {
786 this->deleteOps();
787 fDeferredProxies.reset();
788 fSampledProxies.reset();
789
790 // If the opsTask is using a render target which wraps a vulkan command buffer, we can't do
791 // a clear load since we cannot change the render pass that we are using. Thus we fall back
792 // to making a clear op in this case.
793 return !this->target(0)->asRenderTargetProxy()->wrapsVkSecondaryCB();
794 }
795
796 // Could not empty the task, so an op must be added to handle the clear
797 return false;
798 }
799
discard()800 void OpsTask::discard() {
801 // Discard calls to in-progress opsTasks are ignored. Calls at the start update the
802 // opsTasks' color & stencil load ops.
803 if (this->isEmpty()) {
804 fColorLoadOp = GrLoadOp::kDiscard;
805 fInitialStencilContent = StencilContent::kDontCare;
806 fTotalBounds.setEmpty();
807 }
808 }
809
810 ////////////////////////////////////////////////////////////////////////////////
811
812 #if GR_TEST_UTILS
dump(const SkString & label,SkString indent,bool printDependencies,bool close) const813 void OpsTask::dump(const SkString& label,
814 SkString indent,
815 bool printDependencies,
816 bool close) const {
817 GrRenderTask::dump(label, indent, printDependencies, false);
818
819 SkDebugf("%sfColorLoadOp: ", indent.c_str());
820 switch (fColorLoadOp) {
821 case GrLoadOp::kLoad:
822 SkDebugf("kLoad\n");
823 break;
824 case GrLoadOp::kClear:
825 SkDebugf("kClear {%g, %g, %g, %g}\n",
826 fLoadClearColor[0],
827 fLoadClearColor[1],
828 fLoadClearColor[2],
829 fLoadClearColor[3]);
830 break;
831 case GrLoadOp::kDiscard:
832 SkDebugf("kDiscard\n");
833 break;
834 }
835
836 SkDebugf("%sfInitialStencilContent: ", indent.c_str());
837 switch (fInitialStencilContent) {
838 case StencilContent::kDontCare:
839 SkDebugf("kDontCare\n");
840 break;
841 case StencilContent::kUserBitsCleared:
842 SkDebugf("kUserBitsCleared\n");
843 break;
844 case StencilContent::kPreserved:
845 SkDebugf("kPreserved\n");
846 break;
847 }
848
849 SkDebugf("%s%d ops:\n", indent.c_str(), fOpChains.count());
850 for (int i = 0; i < fOpChains.count(); ++i) {
851 SkDebugf("%s*******************************\n", indent.c_str());
852 if (!fOpChains[i].head()) {
853 SkDebugf("%s%d: <combined forward or failed instantiation>\n", indent.c_str(), i);
854 } else {
855 SkDebugf("%s%d: %s\n", indent.c_str(), i, fOpChains[i].head()->name());
856 SkRect bounds = fOpChains[i].bounds();
857 SkDebugf("%sClippedBounds: [L: %.2f, T: %.2f, R: %.2f, B: %.2f]\n",
858 indent.c_str(),
859 bounds.fLeft, bounds.fTop, bounds.fRight, bounds.fBottom);
860 for (const auto& op : GrOp::ChainRange<>(fOpChains[i].head())) {
861 SkString info = SkTabString(op.dumpInfo(), 1);
862 SkDebugf("%s%s\n", indent.c_str(), info.c_str());
863 bounds = op.bounds();
864 SkDebugf("%s\tClippedBounds: [L: %.2f, T: %.2f, R: %.2f, B: %.2f]\n",
865 indent.c_str(),
866 bounds.fLeft, bounds.fTop, bounds.fRight, bounds.fBottom);
867 }
868 }
869 }
870
871 if (close) {
872 SkDebugf("%s--------------------------------------------------------------\n\n",
873 indent.c_str());
874 }
875 }
876 #endif
877
878 #ifdef SK_DEBUG
visitProxies_debugOnly(const GrVisitProxyFunc & func) const879 void OpsTask::visitProxies_debugOnly(const GrVisitProxyFunc& func) const {
880 auto textureFunc = [ func ] (GrSurfaceProxy* tex, GrMipmapped mipmapped) {
881 func(tex, mipmapped);
882 };
883
884 for (const OpChain& chain : fOpChains) {
885 chain.visitProxies(textureFunc);
886 }
887 }
888
889 #endif
890
891 ////////////////////////////////////////////////////////////////////////////////
892
onMakeSkippable()893 void OpsTask::onMakeSkippable() {
894 this->deleteOps();
895 fDeferredProxies.reset();
896 fColorLoadOp = GrLoadOp::kLoad;
897 SkASSERT(this->isColorNoOp());
898 }
899
onIsUsed(GrSurfaceProxy * proxyToCheck) const900 bool OpsTask::onIsUsed(GrSurfaceProxy* proxyToCheck) const {
901 bool used = false;
902 for (GrSurfaceProxy* proxy : fSampledProxies) {
903 if (proxy == proxyToCheck) {
904 used = true;
905 break;
906 }
907 }
908 #ifdef SK_DEBUG
909 bool usedSlow = false;
910 auto visit = [ proxyToCheck, &usedSlow ] (GrSurfaceProxy* p, GrMipmapped) {
911 if (p == proxyToCheck) {
912 usedSlow = true;
913 }
914 };
915 this->visitProxies_debugOnly(visit);
916 SkASSERT(used == usedSlow);
917 #endif
918
919 return used;
920 }
921
gatherProxyIntervals(GrResourceAllocator * alloc) const922 void OpsTask::gatherProxyIntervals(GrResourceAllocator* alloc) const {
923 SkASSERT(this->isClosed());
924 if (this->isColorNoOp()) {
925 return;
926 }
927
928 for (int i = 0; i < fDeferredProxies.count(); ++i) {
929 SkASSERT(!fDeferredProxies[i]->isInstantiated());
930 // We give all the deferred proxies a write usage at the very start of flushing. This
931 // locks them out of being reused for the entire flush until they are read - and then
932 // they can be recycled. This is a bit unfortunate because a flush can proceed in waves
933 // with sub-flushes. The deferred proxies only need to be pinned from the start of
934 // the sub-flush in which they appear.
935 alloc->addInterval(fDeferredProxies[i], 0, 0, GrResourceAllocator::ActualUse::kNo);
936 }
937
938 GrSurfaceProxy* targetProxy = this->target(0);
939
940 // Add the interval for all the writes to this OpsTasks's target
941 if (fOpChains.count()) {
942 unsigned int cur = alloc->curOp();
943
944 alloc->addInterval(targetProxy, cur, cur + fOpChains.count() - 1,
945 GrResourceAllocator::ActualUse::kYes);
946 } else {
947 // This can happen if there is a loadOp (e.g., a clear) but no other draws. In this case we
948 // still need to add an interval for the destination so we create a fake op# for
949 // the missing clear op.
950 alloc->addInterval(targetProxy, alloc->curOp(), alloc->curOp(),
951 GrResourceAllocator::ActualUse::kYes);
952 alloc->incOps();
953 }
954
955 auto gather = [ alloc SkDEBUGCODE(, this) ] (GrSurfaceProxy* p, GrMipmapped) {
956 alloc->addInterval(p,
957 alloc->curOp(),
958 alloc->curOp(),
959 GrResourceAllocator::ActualUse::kYes
960 SkDEBUGCODE(, this->target(0) == p));
961 };
962 // TODO: visitProxies is expensive. Can we do this with fSampledProxies instead?
963 for (const OpChain& recordedOp : fOpChains) {
964 recordedOp.visitProxies(gather);
965
966 // Even though the op may have been (re)moved we still need to increment the op count to
967 // keep all the math consistent.
968 alloc->incOps();
969 }
970 }
971
recordOp(GrOp::Owner op,bool usesMSAA,GrProcessorSet::Analysis processorAnalysis,GrAppliedClip * clip,const GrDstProxyView * dstProxyView,const GrCaps & caps)972 void OpsTask::recordOp(
973 GrOp::Owner op, bool usesMSAA, GrProcessorSet::Analysis processorAnalysis,
974 GrAppliedClip* clip, const GrDstProxyView* dstProxyView, const GrCaps& caps) {
975 GrSurfaceProxy* proxy = this->target(0);
976 #ifdef SK_DEBUG
977 op->validate();
978 SkASSERT(processorAnalysis.requiresDstTexture() == (dstProxyView && dstProxyView->proxy()));
979 SkASSERT(proxy);
980 // A closed OpsTask should never receive new/more ops
981 SkASSERT(!this->isClosed());
982 // Ensure we can support dynamic msaa if the caller is trying to trigger it.
983 if (proxy->asRenderTargetProxy()->numSamples() == 1 && usesMSAA) {
984 SkASSERT(caps.supportsDynamicMSAA(proxy->asRenderTargetProxy()));
985 }
986 #endif
987
988 if (!op->bounds().isFinite()) {
989 return;
990 }
991
992 fUsesMSAASurface |= usesMSAA;
993
994 // Account for this op's bounds before we attempt to combine.
995 // NOTE: The caller should have already called "op->setClippedBounds()" by now, if applicable.
996 fTotalBounds.join(op->bounds());
997
998 // Check if there is an op we can combine with by linearly searching back until we either
999 // 1) check every op
1000 // 2) intersect with something
1001 // 3) find a 'blocker'
1002 GR_AUDIT_TRAIL_ADD_OP(fAuditTrail, op.get(), proxy->uniqueID());
1003 GrOP_INFO("opsTask: %d Recording (%s, opID: %u)\n"
1004 "\tBounds [L: %.2f, T: %.2f R: %.2f B: %.2f]\n",
1005 this->uniqueID(),
1006 op->name(),
1007 op->uniqueID(),
1008 op->bounds().fLeft, op->bounds().fTop,
1009 op->bounds().fRight, op->bounds().fBottom);
1010 GrOP_INFO(SkTabString(op->dumpInfo(), 1).c_str());
1011 GrOP_INFO("\tOutcome:\n");
1012 int maxCandidates = std::min(kMaxOpChainDistance, fOpChains.count());
1013 if (maxCandidates) {
1014 int i = 0;
1015 while (true) {
1016 OpChain& candidate = fOpChains.fromBack(i);
1017 op = candidate.appendOp(std::move(op), processorAnalysis, dstProxyView, clip, caps,
1018 fArenas->arenaAlloc(), fAuditTrail);
1019 if (!op) {
1020 return;
1021 }
1022 // Stop going backwards if we would cause a painter's order violation.
1023 if (!can_reorder(candidate.bounds(), op->bounds())) {
1024 GrOP_INFO("\t\tBackward: Intersects with chain (%s, head opID: %u)\n",
1025 candidate.head()->name(), candidate.head()->uniqueID());
1026 break;
1027 }
1028 if (++i == maxCandidates) {
1029 GrOP_INFO("\t\tBackward: Reached max lookback or beginning of op array %d\n", i);
1030 break;
1031 }
1032 }
1033 } else {
1034 GrOP_INFO("\t\tBackward: FirstOp\n");
1035 }
1036 if (clip) {
1037 clip = fArenas->arenaAlloc()->make<GrAppliedClip>(std::move(*clip));
1038 SkDEBUGCODE(fNumClips++;)
1039 }
1040 fOpChains.emplace_back(std::move(op), processorAnalysis, clip, dstProxyView);
1041 }
1042
forwardCombine(const GrCaps & caps)1043 void OpsTask::forwardCombine(const GrCaps& caps) {
1044 SkASSERT(!this->isClosed());
1045 GrOP_INFO("opsTask: %d ForwardCombine %d ops:\n", this->uniqueID(), fOpChains.count());
1046
1047 for (int i = 0; i < fOpChains.count() - 1; ++i) {
1048 OpChain& chain = fOpChains[i];
1049 int maxCandidateIdx = std::min(i + kMaxOpChainDistance, fOpChains.count() - 1);
1050 int j = i + 1;
1051 while (true) {
1052 OpChain& candidate = fOpChains[j];
1053 if (candidate.prependChain(&chain, caps, fArenas->arenaAlloc(), fAuditTrail)) {
1054 break;
1055 }
1056 // Stop traversing if we would cause a painter's order violation.
1057 if (!can_reorder(chain.bounds(), candidate.bounds())) {
1058 GrOP_INFO(
1059 "\t\t%d: chain (%s head opID: %u) -> "
1060 "Intersects with chain (%s, head opID: %u)\n",
1061 i, chain.head()->name(), chain.head()->uniqueID(), candidate.head()->name(),
1062 candidate.head()->uniqueID());
1063 break;
1064 }
1065 if (++j > maxCandidateIdx) {
1066 GrOP_INFO("\t\t%d: chain (%s opID: %u) -> Reached max lookahead or end of array\n",
1067 i, chain.head()->name(), chain.head()->uniqueID());
1068 break;
1069 }
1070 }
1071 }
1072 }
1073
onMakeClosed(GrRecordingContext * rContext,SkIRect * targetUpdateBounds)1074 GrRenderTask::ExpectedOutcome OpsTask::onMakeClosed(GrRecordingContext* rContext,
1075 SkIRect* targetUpdateBounds) {
1076 this->forwardCombine(*rContext->priv().caps());
1077 if (!this->isColorNoOp()) {
1078 GrSurfaceProxy* proxy = this->target(0);
1079 // Use the entire backing store bounds since the GPU doesn't clip automatically to the
1080 // logical dimensions.
1081 SkRect clippedContentBounds = proxy->backingStoreBoundsRect();
1082 // TODO: If we can fix up GLPrograms test to always intersect the target proxy bounds
1083 // then we can simply assert here that the bounds intersect.
1084 if (clippedContentBounds.intersect(fTotalBounds)) {
1085 clippedContentBounds.roundOut(&fClippedContentBounds);
1086 *targetUpdateBounds = GrNativeRect::MakeIRectRelativeTo(
1087 fTargetOrigin,
1088 this->target(0)->backingStoreDimensions().height(),
1089 fClippedContentBounds);
1090 return ExpectedOutcome::kTargetDirty;
1091 }
1092 }
1093 return ExpectedOutcome::kTargetUnchanged;
1094 }
1095
1096 } // namespace skgpu::v1
1097