1 /*
2 * Copyright 2012 Google Inc.
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8 #include "include/core/SkBitmap.h"
9 #include "include/core/SkCanvas.h"
10 #include "include/core/SkColor.h"
11 #include "include/core/SkImageInfo.h"
12 #include "include/core/SkMatrix.h"
13 #include "include/core/SkPaint.h"
14 #include "include/core/SkPath.h"
15 #include "include/core/SkPathEffect.h"
16 #include "include/core/SkPoint.h"
17 #include "include/core/SkRRect.h"
18 #include "include/core/SkRect.h"
19 #include "include/core/SkRefCnt.h"
20 #include "include/core/SkScalar.h"
21 #include "include/core/SkStrokeRec.h"
22 #include "include/core/SkSurface.h"
23 #include "include/core/SkTypes.h"
24 #include "include/effects/SkDashPathEffect.h"
25 #include "tests/Test.h"
26
27 // test that we can draw an aa-rect at coordinates > 32K (bigger than fixedpoint)
test_big_aa_rect(skiatest::Reporter * reporter)28 static void test_big_aa_rect(skiatest::Reporter* reporter) {
29 SkBitmap output;
30 SkPMColor pixel[1];
31 output.installPixels(SkImageInfo::MakeN32Premul(1, 1), pixel, 4);
32
33 auto surf = SkSurface::MakeRasterN32Premul(300, 33300);
34 SkCanvas* canvas = surf->getCanvas();
35
36 SkRect r = { 0, 33000, 300, 33300 };
37 int x = SkScalarRoundToInt(r.left());
38 int y = SkScalarRoundToInt(r.top());
39
40 // check that the pixel in question starts as transparent (by the surface)
41 if (surf->readPixels(output, x, y)) {
42 REPORTER_ASSERT(reporter, 0 == pixel[0]);
43 } else {
44 REPORTER_ASSERT(reporter, false, "readPixels failed");
45 }
46
47 SkPaint paint;
48 paint.setAntiAlias(true);
49 paint.setColor(SK_ColorWHITE);
50
51 canvas->drawRect(r, paint);
52
53 // Now check that it is BLACK
54 if (surf->readPixels(output, x, y)) {
55 // don't know what swizzling PMColor did, but white should always
56 // appear the same.
57 REPORTER_ASSERT(reporter, 0xFFFFFFFF == pixel[0]);
58 } else {
59 REPORTER_ASSERT(reporter, false, "readPixels failed");
60 }
61 }
62
63 ///////////////////////////////////////////////////////////////////////////////
64
moveToH(SkPath * path,const uint32_t raw[])65 static void moveToH(SkPath* path, const uint32_t raw[]) {
66 const float* fptr = (const float*)raw;
67 path->moveTo(fptr[0], fptr[1]);
68 }
69
cubicToH(SkPath * path,const uint32_t raw[])70 static void cubicToH(SkPath* path, const uint32_t raw[]) {
71 const float* fptr = (const float*)raw;
72 path->cubicTo(fptr[0], fptr[1], fptr[2], fptr[3], fptr[4], fptr[5]);
73 }
74
75 // This used to assert, because we performed a cast (int)(pt[0].fX * scale) to
76 // arrive at an int (SkFDot6) rather than calling sk_float_round2int. The assert
77 // was that the initial line-segment produced by the cubic was not monotonically
78 // going down (i.e. the initial DY was negative). By rounding the floats, we get
79 // the more proper result.
80 //
81 // http://code.google.com/p/chromium/issues/detail?id=131181
82 //
83
84 // we're not calling this test anymore; is that for a reason?
85
test_crbug131181()86 static void test_crbug131181() {
87 /*
88 fX = 18.8943768,
89 fY = 129.121277
90 }, {
91 fX = 18.8937435,
92 fY = 129.121689
93 }, {
94 fX = 18.8950119,
95 fY = 129.120422
96 }, {
97 fX = 18.5030727,
98 fY = 129.13121
99 */
100 uint32_t data[] = {
101 0x419727af, 0x43011f0c, 0x41972663, 0x43011f27,
102 0x419728fc, 0x43011ed4, 0x4194064b, 0x43012197
103 };
104
105 SkPath path;
106 moveToH(&path, &data[0]);
107 cubicToH(&path, &data[2]);
108
109 auto surface(SkSurface::MakeRasterN32Premul(640, 480));
110
111 SkPaint paint;
112 paint.setAntiAlias(true);
113 surface->getCanvas()->drawPath(path, paint);
114 }
115
116 // This used to assert in debug builds (and crash writing bad memory in release)
117 // because we overflowed an intermediate value (B coefficient) setting up our
118 // stepper for the quadratic. Now we bias that value by 1/2 so we don't overflow
test_crbug_140803()119 static void test_crbug_140803() {
120 SkBitmap bm;
121 bm.allocN32Pixels(2700, 30*1024);
122 SkCanvas canvas(bm);
123
124 SkPaint paint;
125 paint.setAntiAlias(true);
126 canvas.drawPath(SkPath().moveTo(2762, 20).quadTo(11, 21702, 10, 21706), paint);
127 }
128
test_crbug_1239558(skiatest::Reporter * reporter)129 static void test_crbug_1239558(skiatest::Reporter* reporter) {
130 SkBitmap bm;
131 bm.allocN32Pixels(256, 256);
132
133 SkCanvas canvas(bm);
134 canvas.clear(SK_ColorWHITE);
135
136 // This creates a single cubic where the control points form an extremely skinny, vertical
137 // triangle contained within the x=0 column of pixels. Since it is convex (ignoring the leading
138 // moveTo's) it uses the convex aaa optimized edge walking algorithm after clipping the path to
139 // the device bounds. However, due to fixed-point math while walking these edges, the edge
140 // walking evaluates to coords that are very slightly less than 0 (i.e. 0.0012). Both the left
141 // and right edges would be out of bounds, but the edge walking is optimized to only clamp the
142 // left edge to the left bounds, and the right edge to the right bounds. After this clamping,
143 // the left and right edges are no longer sorted. This then led to incorrect behavior in various
144 // forms (described below).
145 SkPath path;
146 path.setFillType(SkPathFillType::kWinding);
147 path.moveTo(7.00649e-45f, 2.f);
148 path.moveTo(0.0160219f, 7.45063e-09f);
149 path.moveTo(192.263f, 8.40779e-44f);
150 path.moveTo(7.34684e-40f, 194.25f);
151 path.moveTo(2.3449e-38f, 6.01858e-36f);
152 path.moveTo(7.34684e-40f, 194.25f);
153 path.cubicTo(5.07266e-39f, 56.0488f,
154 0.0119172f, 0.f,
155 7.34684e-40f, 194.25f);
156
157 SkPaint paint;
158 paint.setColor(SK_ColorRED);
159 paint.setAntiAlias(true);
160 // On debug builds, the inverted left/right edges led to a negative coverage that triggered an
161 // assert while converting to a uint8 alpha value. On release builds with UBSAN, it would
162 // detect a negative left shift when computing the pixel address and crash. On regular release
163 // builds it would write a saturate coverage value to pixels that wrapped around to the far edge
164 canvas.drawPath(path, paint);
165
166 // UBSAN and debug builds would fail inside the drawPath() call above, but detect the incorrect
167 // memory access on release builds so that the test would fail. Given the path, it should only
168 // touch pixels with x=0 but the incorrect addressing would wrap to the right edge.
169 for (int y = 0; y < 256; ++y) {
170 if (bm.getColor(255, y) != SK_ColorWHITE) {
171 REPORTER_ASSERT(reporter, false, "drawPath modified incorrect pixels");
172 break;
173 }
174 }
175 }
176
177 // Need to exercise drawing an inverse-path whose bounds intersect the clip,
178 // but whose edges do not (since its a quad which draws only in the bottom half
179 // of its bounds).
180 // In the debug build, we used to assert in this case, until it was fixed.
181 //
test_inversepathwithclip()182 static void test_inversepathwithclip() {
183 SkPath path;
184
185 path.moveTo(0, 20);
186 path.quadTo(10, 10, 20, 20);
187 path.toggleInverseFillType();
188
189 SkPaint paint;
190
191 auto surface(SkSurface::MakeRasterN32Premul(640, 480));
192 SkCanvas* canvas = surface->getCanvas();
193 canvas->save();
194 canvas->clipRect(SkRect::MakeWH(19, 11));
195
196 paint.setAntiAlias(false);
197 canvas->drawPath(path, paint);
198 paint.setAntiAlias(true);
199 canvas->drawPath(path, paint);
200
201 canvas->restore();
202
203 // Now do the test again, with the path flipped, so we only draw in the
204 // top half of our bounds, and have the clip intersect our bounds at the
205 // bottom.
206 path.reset(); // preserves our filltype
207 path.moveTo(0, 10);
208 path.quadTo(10, 20, 20, 10);
209 canvas->clipRect(SkRect::MakeXYWH(0, 19, 19, 11));
210
211 paint.setAntiAlias(false);
212 canvas->drawPath(path, paint);
213 paint.setAntiAlias(true);
214 canvas->drawPath(path, paint);
215 }
216
test_bug533()217 static void test_bug533() {
218 /*
219 http://code.google.com/p/skia/issues/detail?id=533
220 This particular test/bug only applies to the float case, where the
221 coordinates are very large.
222 */
223 SkPath path;
224 path.moveTo(64, 3);
225 path.quadTo(-329936, -100000000, 1153, 330003);
226
227 SkPaint paint;
228 paint.setAntiAlias(true);
229
230 auto surface(SkSurface::MakeRasterN32Premul(640, 480));
231 surface->getCanvas()->drawPath(path, paint);
232 }
233
test_crbug_140642()234 static void test_crbug_140642() {
235 /*
236 * We used to see this construct, and due to rounding as we accumulated
237 * our length, the loop where we apply the phase would run off the end of
238 * the array, since it relied on just -= each interval value, which did not
239 * behave as "expected". Now the code explicitly checks for walking off the
240 * end of that array.
241
242 * A different (better) fix might be to rewrite dashing to do all of its
243 * length/phase/measure math using double, but this may need to be
244 * coordinated with SkPathMeasure, to be consistent between the two.
245
246 <path stroke="mintcream" stroke-dasharray="27734 35660 2157846850 247"
247 stroke-dashoffset="-248.135982067">
248 */
249
250 const SkScalar vals[] = { 27734, 35660, 2157846850.0f, 247 };
251 auto dontAssert = SkDashPathEffect::Make(vals, 4, -248.135982067f);
252 }
253
test_crbug_124652()254 static void test_crbug_124652() {
255 /*
256 http://code.google.com/p/chromium/issues/detail?id=124652
257 This particular test/bug only applies to the float case, where
258 large values can "swamp" small ones.
259 */
260 SkScalar intervals[2] = {837099584, 33450};
261 auto dontAssert = SkDashPathEffect::Make(intervals, 2, -10);
262 }
263
test_bigcubic()264 static void test_bigcubic() {
265 SkPath path;
266 path.moveTo(64, 3);
267 path.cubicTo(-329936, -100000000, -329936, 100000000, 1153, 330003);
268
269 SkPaint paint;
270 paint.setAntiAlias(true);
271
272 auto surface(SkSurface::MakeRasterN32Premul(640, 480));
273 surface->getCanvas()->drawPath(path, paint);
274 }
275
276 // asserts if halfway case is not handled
test_halfway()277 static void test_halfway() {
278 SkPaint paint;
279 SkPath path;
280 path.moveTo(16365.5f, 1394);
281 path.lineTo(16365.5f, 1387.5f);
282 path.quadTo(16365.5f, 1385.43f, 16367, 1383.96f);
283 path.quadTo(16368.4f, 1382.5f, 16370.5f, 1382.5f);
284 path.lineTo(16465.5f, 1382.5f);
285 path.quadTo(16467.6f, 1382.5f, 16469, 1383.96f);
286 path.quadTo(16470.5f, 1385.43f, 16470.5f, 1387.5f);
287 path.lineTo(16470.5f, 1394);
288 path.quadTo(16470.5f, 1396.07f, 16469, 1397.54f);
289 path.quadTo(16467.6f, 1399, 16465.5f, 1399);
290 path.lineTo(16370.5f, 1399);
291 path.quadTo(16368.4f, 1399, 16367, 1397.54f);
292 path.quadTo(16365.5f, 1396.07f, 16365.5f, 1394);
293 path.close();
294 SkPath p2;
295 SkMatrix m;
296 m.reset();
297 m.postTranslate(0.001f, 0.001f);
298 path.transform(m, &p2);
299
300 auto surface(SkSurface::MakeRasterN32Premul(640, 480));
301 SkCanvas* canvas = surface->getCanvas();
302 canvas->translate(-16366, -1383);
303 canvas->drawPath(p2, paint);
304
305 m.reset();
306 m.postTranslate(-0.001f, -0.001f);
307 path.transform(m, &p2);
308 canvas->drawPath(p2, paint);
309
310 m.reset();
311 path.transform(m, &p2);
312 canvas->drawPath(p2, paint);
313 }
314
315 // we used to assert if the bounds of the device (clip) was larger than 32K
316 // even when the path itself was smaller. We just draw and hope in the debug
317 // version to not assert.
test_giantaa()318 static void test_giantaa() {
319 const int W = 400;
320 const int H = 400;
321 auto surface(SkSurface::MakeRasterN32Premul(33000, 10));
322
323 SkPaint paint;
324 paint.setAntiAlias(true);
325 SkPath path;
326 path.addOval(SkRect::MakeXYWH(-10, -10, 20 + W, 20 + H));
327 surface->getCanvas()->drawPath(path, paint);
328 }
329
330 // Extremely large path_length/dash_length ratios may cause infinite looping
331 // in SkDashPathEffect::filterPath() due to single precision rounding.
332 // The test is quite expensive, but it should get much faster after the fix
333 // for http://crbug.com/165432 goes in.
test_infinite_dash(skiatest::Reporter * reporter)334 static void test_infinite_dash(skiatest::Reporter* reporter) {
335 SkPath path;
336 path.moveTo(0, 0);
337 path.lineTo(5000000, 0);
338
339 SkScalar intervals[] = { 0.2f, 0.2f };
340 sk_sp<SkPathEffect> dash(SkDashPathEffect::Make(intervals, 2, 0));
341
342 SkPath filteredPath;
343 SkPaint paint;
344 paint.setStyle(SkPaint::kStroke_Style);
345 paint.setPathEffect(dash);
346
347 paint.getFillPath(path, &filteredPath);
348 // If we reach this, we passed.
349 REPORTER_ASSERT(reporter, true);
350 }
351
352 // http://crbug.com/165432
353 // Limit extreme dash path effects to avoid exhausting the system memory.
test_crbug_165432(skiatest::Reporter * reporter)354 static void test_crbug_165432(skiatest::Reporter* reporter) {
355 SkPath path;
356 path.moveTo(0, 0);
357 path.lineTo(10000000, 0);
358
359 SkScalar intervals[] = { 0.5f, 0.5f };
360 sk_sp<SkPathEffect> dash(SkDashPathEffect::Make(intervals, 2, 0));
361
362 SkPaint paint;
363 paint.setStyle(SkPaint::kStroke_Style);
364 paint.setPathEffect(dash);
365
366 SkPath filteredPath;
367 SkStrokeRec rec(paint);
368 REPORTER_ASSERT(reporter, !dash->filterPath(&filteredPath, path, &rec, nullptr));
369 REPORTER_ASSERT(reporter, filteredPath.isEmpty());
370 }
371
372 // http://crbug.com/472147
373 // This is a simplified version from the bug. RRect radii not properly scaled.
test_crbug_472147_simple(skiatest::Reporter * reporter)374 static void test_crbug_472147_simple(skiatest::Reporter* reporter) {
375 auto surface(SkSurface::MakeRasterN32Premul(1000, 1000));
376 SkCanvas* canvas = surface->getCanvas();
377 SkPaint p;
378 SkRect r = SkRect::MakeLTRB(-246.0f, 33.0f, 848.0f, 33554464.0f);
379 SkVector radii[4] = {
380 { 13.0f, 8.0f }, { 170.0f, 2.0 }, { 256.0f, 33554430.0f }, { 120.0f, 5.0f }
381 };
382 SkRRect rr;
383 rr.setRectRadii(r, radii);
384 canvas->drawRRect(rr, p);
385 }
386
387 // http://crbug.com/472147
388 // RRect radii not properly scaled.
test_crbug_472147_actual(skiatest::Reporter * reporter)389 static void test_crbug_472147_actual(skiatest::Reporter* reporter) {
390 auto surface(SkSurface::MakeRasterN32Premul(1000, 1000));
391 SkCanvas* canvas = surface->getCanvas();
392 SkPaint p;
393 SkRect r = SkRect::MakeLTRB(-246.0f, 33.0f, 848.0f, 33554464.0f);
394 SkVector radii[4] = {
395 { 13.0f, 8.0f }, { 170.0f, 2.0 }, { 256.0f, 33554430.0f }, { 120.0f, 5.0f }
396 };
397 SkRRect rr;
398 rr.setRectRadii(r, radii);
399 canvas->clipRRect(rr);
400
401 SkRect r2 = SkRect::MakeLTRB(0, 33, 1102, 33554464);
402 canvas->drawRect(r2, p);
403 }
404
DEF_TEST(DrawPath,reporter)405 DEF_TEST(DrawPath, reporter) {
406 test_giantaa();
407 test_bug533();
408 test_bigcubic();
409 test_crbug_124652();
410 test_crbug_140642();
411 test_crbug_140803();
412 test_inversepathwithclip();
413 // why?
414 if (false) test_crbug131181();
415 test_infinite_dash(reporter);
416 test_crbug_165432(reporter);
417 test_crbug_472147_simple(reporter);
418 test_crbug_472147_actual(reporter);
419 test_crbug_1239558(reporter);
420 test_big_aa_rect(reporter);
421 test_halfway();
422 }
423