1 // Copyright (c) 2017 The Khronos Group Inc.
2 // Copyright (c) 2017 Valve Corporation
3 // Copyright (c) 2017 LunarG Inc.
4 //
5 // Licensed under the Apache License, Version 2.0 (the "License");
6 // you may not use this file except in compliance with the License.
7 // You may obtain a copy of the License at
8 //
9 // http://www.apache.org/licenses/LICENSE-2.0
10 //
11 // Unless required by applicable law or agreed to in writing, software
12 // distributed under the License is distributed on an "AS IS" BASIS,
13 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14 // See the License for the specific language governing permissions and
15 // limitations under the License.
16
17 #include "source/opt/inline_pass.h"
18
19 #include <unordered_set>
20 #include <utility>
21
22 #include "source/cfa.h"
23 #include "source/opt/reflect.h"
24 #include "source/util/make_unique.h"
25
26 namespace spvtools {
27 namespace opt {
28 namespace {
29 // Indices of operands in SPIR-V instructions
30 constexpr int kSpvFunctionCallFunctionId = 2;
31 constexpr int kSpvFunctionCallArgumentId = 3;
32 constexpr int kSpvReturnValueId = 0;
33 } // namespace
34
AddPointerToType(uint32_t type_id,spv::StorageClass storage_class)35 uint32_t InlinePass::AddPointerToType(uint32_t type_id,
36 spv::StorageClass storage_class) {
37 uint32_t resultId = context()->TakeNextId();
38 if (resultId == 0) {
39 return resultId;
40 }
41
42 std::unique_ptr<Instruction> type_inst(
43 new Instruction(context(), spv::Op::OpTypePointer, 0, resultId,
44 {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS,
45 {uint32_t(storage_class)}},
46 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {type_id}}}));
47 context()->AddType(std::move(type_inst));
48 analysis::Type* pointeeTy;
49 std::unique_ptr<analysis::Pointer> pointerTy;
50 std::tie(pointeeTy, pointerTy) =
51 context()->get_type_mgr()->GetTypeAndPointerType(
52 type_id, spv::StorageClass::Function);
53 context()->get_type_mgr()->RegisterType(resultId, *pointerTy);
54 return resultId;
55 }
56
AddBranch(uint32_t label_id,std::unique_ptr<BasicBlock> * block_ptr)57 void InlinePass::AddBranch(uint32_t label_id,
58 std::unique_ptr<BasicBlock>* block_ptr) {
59 std::unique_ptr<Instruction> newBranch(
60 new Instruction(context(), spv::Op::OpBranch, 0, 0,
61 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {label_id}}}));
62 (*block_ptr)->AddInstruction(std::move(newBranch));
63 }
64
AddBranchCond(uint32_t cond_id,uint32_t true_id,uint32_t false_id,std::unique_ptr<BasicBlock> * block_ptr)65 void InlinePass::AddBranchCond(uint32_t cond_id, uint32_t true_id,
66 uint32_t false_id,
67 std::unique_ptr<BasicBlock>* block_ptr) {
68 std::unique_ptr<Instruction> newBranch(
69 new Instruction(context(), spv::Op::OpBranchConditional, 0, 0,
70 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {cond_id}},
71 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {true_id}},
72 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {false_id}}}));
73 (*block_ptr)->AddInstruction(std::move(newBranch));
74 }
75
AddLoopMerge(uint32_t merge_id,uint32_t continue_id,std::unique_ptr<BasicBlock> * block_ptr)76 void InlinePass::AddLoopMerge(uint32_t merge_id, uint32_t continue_id,
77 std::unique_ptr<BasicBlock>* block_ptr) {
78 std::unique_ptr<Instruction> newLoopMerge(new Instruction(
79 context(), spv::Op::OpLoopMerge, 0, 0,
80 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {merge_id}},
81 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {continue_id}},
82 {spv_operand_type_t::SPV_OPERAND_TYPE_LOOP_CONTROL, {0}}}));
83 (*block_ptr)->AddInstruction(std::move(newLoopMerge));
84 }
85
AddStore(uint32_t ptr_id,uint32_t val_id,std::unique_ptr<BasicBlock> * block_ptr,const Instruction * line_inst,const DebugScope & dbg_scope)86 void InlinePass::AddStore(uint32_t ptr_id, uint32_t val_id,
87 std::unique_ptr<BasicBlock>* block_ptr,
88 const Instruction* line_inst,
89 const DebugScope& dbg_scope) {
90 std::unique_ptr<Instruction> newStore(
91 new Instruction(context(), spv::Op::OpStore, 0, 0,
92 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}},
93 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {val_id}}}));
94 if (line_inst != nullptr) {
95 newStore->AddDebugLine(line_inst);
96 }
97 newStore->SetDebugScope(dbg_scope);
98 (*block_ptr)->AddInstruction(std::move(newStore));
99 }
100
AddLoad(uint32_t type_id,uint32_t resultId,uint32_t ptr_id,std::unique_ptr<BasicBlock> * block_ptr,const Instruction * line_inst,const DebugScope & dbg_scope)101 void InlinePass::AddLoad(uint32_t type_id, uint32_t resultId, uint32_t ptr_id,
102 std::unique_ptr<BasicBlock>* block_ptr,
103 const Instruction* line_inst,
104 const DebugScope& dbg_scope) {
105 std::unique_ptr<Instruction> newLoad(
106 new Instruction(context(), spv::Op::OpLoad, type_id, resultId,
107 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}}}));
108 if (line_inst != nullptr) {
109 newLoad->AddDebugLine(line_inst);
110 }
111 newLoad->SetDebugScope(dbg_scope);
112 (*block_ptr)->AddInstruction(std::move(newLoad));
113 }
114
NewLabel(uint32_t label_id)115 std::unique_ptr<Instruction> InlinePass::NewLabel(uint32_t label_id) {
116 std::unique_ptr<Instruction> newLabel(
117 new Instruction(context(), spv::Op::OpLabel, 0, label_id, {}));
118 return newLabel;
119 }
120
GetFalseId()121 uint32_t InlinePass::GetFalseId() {
122 if (false_id_ != 0) return false_id_;
123 false_id_ = get_module()->GetGlobalValue(spv::Op::OpConstantFalse);
124 if (false_id_ != 0) return false_id_;
125 uint32_t boolId = get_module()->GetGlobalValue(spv::Op::OpTypeBool);
126 if (boolId == 0) {
127 boolId = context()->TakeNextId();
128 if (boolId == 0) {
129 return 0;
130 }
131 get_module()->AddGlobalValue(spv::Op::OpTypeBool, boolId, 0);
132 }
133 false_id_ = context()->TakeNextId();
134 if (false_id_ == 0) {
135 return 0;
136 }
137 get_module()->AddGlobalValue(spv::Op::OpConstantFalse, false_id_, boolId);
138 return false_id_;
139 }
140
MapParams(Function * calleeFn,BasicBlock::iterator call_inst_itr,std::unordered_map<uint32_t,uint32_t> * callee2caller)141 void InlinePass::MapParams(
142 Function* calleeFn, BasicBlock::iterator call_inst_itr,
143 std::unordered_map<uint32_t, uint32_t>* callee2caller) {
144 int param_idx = 0;
145 calleeFn->ForEachParam(
146 [&call_inst_itr, ¶m_idx, &callee2caller](const Instruction* cpi) {
147 const uint32_t pid = cpi->result_id();
148 (*callee2caller)[pid] = call_inst_itr->GetSingleWordOperand(
149 kSpvFunctionCallArgumentId + param_idx);
150 ++param_idx;
151 });
152 }
153
CloneAndMapLocals(Function * calleeFn,std::vector<std::unique_ptr<Instruction>> * new_vars,std::unordered_map<uint32_t,uint32_t> * callee2caller,analysis::DebugInlinedAtContext * inlined_at_ctx)154 bool InlinePass::CloneAndMapLocals(
155 Function* calleeFn, std::vector<std::unique_ptr<Instruction>>* new_vars,
156 std::unordered_map<uint32_t, uint32_t>* callee2caller,
157 analysis::DebugInlinedAtContext* inlined_at_ctx) {
158 auto callee_block_itr = calleeFn->begin();
159 auto callee_var_itr = callee_block_itr->begin();
160 while (callee_var_itr->opcode() == spv::Op::OpVariable ||
161 callee_var_itr->GetCommonDebugOpcode() ==
162 CommonDebugInfoDebugDeclare) {
163 if (callee_var_itr->opcode() != spv::Op::OpVariable) {
164 ++callee_var_itr;
165 continue;
166 }
167
168 std::unique_ptr<Instruction> var_inst(callee_var_itr->Clone(context()));
169 uint32_t newId = context()->TakeNextId();
170 if (newId == 0) {
171 return false;
172 }
173 get_decoration_mgr()->CloneDecorations(callee_var_itr->result_id(), newId);
174 var_inst->SetResultId(newId);
175 var_inst->UpdateDebugInlinedAt(
176 context()->get_debug_info_mgr()->BuildDebugInlinedAtChain(
177 callee_var_itr->GetDebugInlinedAt(), inlined_at_ctx));
178 (*callee2caller)[callee_var_itr->result_id()] = newId;
179 new_vars->push_back(std::move(var_inst));
180 ++callee_var_itr;
181 }
182 return true;
183 }
184
CreateReturnVar(Function * calleeFn,std::vector<std::unique_ptr<Instruction>> * new_vars)185 uint32_t InlinePass::CreateReturnVar(
186 Function* calleeFn, std::vector<std::unique_ptr<Instruction>>* new_vars) {
187 uint32_t returnVarId = 0;
188 const uint32_t calleeTypeId = calleeFn->type_id();
189 analysis::TypeManager* type_mgr = context()->get_type_mgr();
190 assert(type_mgr->GetType(calleeTypeId)->AsVoid() == nullptr &&
191 "Cannot create a return variable of type void.");
192 // Find or create ptr to callee return type.
193 uint32_t returnVarTypeId =
194 type_mgr->FindPointerToType(calleeTypeId, spv::StorageClass::Function);
195
196 if (returnVarTypeId == 0) {
197 returnVarTypeId =
198 AddPointerToType(calleeTypeId, spv::StorageClass::Function);
199 if (returnVarTypeId == 0) {
200 return 0;
201 }
202 }
203
204 // Add return var to new function scope variables.
205 returnVarId = context()->TakeNextId();
206 if (returnVarId == 0) {
207 return 0;
208 }
209
210 std::unique_ptr<Instruction> var_inst(new Instruction(
211 context(), spv::Op::OpVariable, returnVarTypeId, returnVarId,
212 {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS,
213 {(uint32_t)spv::StorageClass::Function}}}));
214 new_vars->push_back(std::move(var_inst));
215 get_decoration_mgr()->CloneDecorations(calleeFn->result_id(), returnVarId);
216 return returnVarId;
217 }
218
IsSameBlockOp(const Instruction * inst) const219 bool InlinePass::IsSameBlockOp(const Instruction* inst) const {
220 return inst->opcode() == spv::Op::OpSampledImage ||
221 inst->opcode() == spv::Op::OpImage;
222 }
223
CloneSameBlockOps(std::unique_ptr<Instruction> * inst,std::unordered_map<uint32_t,uint32_t> * postCallSB,std::unordered_map<uint32_t,Instruction * > * preCallSB,std::unique_ptr<BasicBlock> * block_ptr)224 bool InlinePass::CloneSameBlockOps(
225 std::unique_ptr<Instruction>* inst,
226 std::unordered_map<uint32_t, uint32_t>* postCallSB,
227 std::unordered_map<uint32_t, Instruction*>* preCallSB,
228 std::unique_ptr<BasicBlock>* block_ptr) {
229 return (*inst)->WhileEachInId([&postCallSB, &preCallSB, &block_ptr,
230 this](uint32_t* iid) {
231 const auto mapItr = (*postCallSB).find(*iid);
232 if (mapItr == (*postCallSB).end()) {
233 const auto mapItr2 = (*preCallSB).find(*iid);
234 if (mapItr2 != (*preCallSB).end()) {
235 // Clone pre-call same-block ops, map result id.
236 const Instruction* inInst = mapItr2->second;
237 std::unique_ptr<Instruction> sb_inst(inInst->Clone(context()));
238 if (!CloneSameBlockOps(&sb_inst, postCallSB, preCallSB, block_ptr)) {
239 return false;
240 }
241
242 const uint32_t rid = sb_inst->result_id();
243 const uint32_t nid = context()->TakeNextId();
244 if (nid == 0) {
245 return false;
246 }
247 get_decoration_mgr()->CloneDecorations(rid, nid);
248 sb_inst->SetResultId(nid);
249 (*postCallSB)[rid] = nid;
250 *iid = nid;
251 (*block_ptr)->AddInstruction(std::move(sb_inst));
252 }
253 } else {
254 // Reset same-block op operand.
255 *iid = mapItr->second;
256 }
257 return true;
258 });
259 }
260
MoveInstsBeforeEntryBlock(std::unordered_map<uint32_t,Instruction * > * preCallSB,BasicBlock * new_blk_ptr,BasicBlock::iterator call_inst_itr,UptrVectorIterator<BasicBlock> call_block_itr)261 void InlinePass::MoveInstsBeforeEntryBlock(
262 std::unordered_map<uint32_t, Instruction*>* preCallSB,
263 BasicBlock* new_blk_ptr, BasicBlock::iterator call_inst_itr,
264 UptrVectorIterator<BasicBlock> call_block_itr) {
265 for (auto cii = call_block_itr->begin(); cii != call_inst_itr;
266 cii = call_block_itr->begin()) {
267 Instruction* inst = &*cii;
268 inst->RemoveFromList();
269 std::unique_ptr<Instruction> cp_inst(inst);
270 // Remember same-block ops for possible regeneration.
271 if (IsSameBlockOp(&*cp_inst)) {
272 auto* sb_inst_ptr = cp_inst.get();
273 (*preCallSB)[cp_inst->result_id()] = sb_inst_ptr;
274 }
275 new_blk_ptr->AddInstruction(std::move(cp_inst));
276 }
277 }
278
AddGuardBlock(std::vector<std::unique_ptr<BasicBlock>> * new_blocks,std::unordered_map<uint32_t,uint32_t> * callee2caller,std::unique_ptr<BasicBlock> new_blk_ptr,uint32_t entry_blk_label_id)279 std::unique_ptr<BasicBlock> InlinePass::AddGuardBlock(
280 std::vector<std::unique_ptr<BasicBlock>>* new_blocks,
281 std::unordered_map<uint32_t, uint32_t>* callee2caller,
282 std::unique_ptr<BasicBlock> new_blk_ptr, uint32_t entry_blk_label_id) {
283 const auto guard_block_id = context()->TakeNextId();
284 if (guard_block_id == 0) {
285 return nullptr;
286 }
287 AddBranch(guard_block_id, &new_blk_ptr);
288 new_blocks->push_back(std::move(new_blk_ptr));
289 // Start the next block.
290 new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(guard_block_id));
291 // Reset the mapping of the callee's entry block to point to
292 // the guard block. Do this so we can fix up phis later on to
293 // satisfy dominance.
294 (*callee2caller)[entry_blk_label_id] = guard_block_id;
295 return new_blk_ptr;
296 }
297
AddStoresForVariableInitializers(const std::unordered_map<uint32_t,uint32_t> & callee2caller,analysis::DebugInlinedAtContext * inlined_at_ctx,std::unique_ptr<BasicBlock> * new_blk_ptr,UptrVectorIterator<BasicBlock> callee_first_block_itr)298 InstructionList::iterator InlinePass::AddStoresForVariableInitializers(
299 const std::unordered_map<uint32_t, uint32_t>& callee2caller,
300 analysis::DebugInlinedAtContext* inlined_at_ctx,
301 std::unique_ptr<BasicBlock>* new_blk_ptr,
302 UptrVectorIterator<BasicBlock> callee_first_block_itr) {
303 auto callee_itr = callee_first_block_itr->begin();
304 while (callee_itr->opcode() == spv::Op::OpVariable ||
305 callee_itr->GetCommonDebugOpcode() == CommonDebugInfoDebugDeclare) {
306 if (callee_itr->opcode() == spv::Op::OpVariable &&
307 callee_itr->NumInOperands() == 2) {
308 assert(callee2caller.count(callee_itr->result_id()) &&
309 "Expected the variable to have already been mapped.");
310 uint32_t new_var_id = callee2caller.at(callee_itr->result_id());
311
312 // The initializer must be a constant or global value. No mapped
313 // should be used.
314 uint32_t val_id = callee_itr->GetSingleWordInOperand(1);
315 AddStore(new_var_id, val_id, new_blk_ptr, callee_itr->dbg_line_inst(),
316 context()->get_debug_info_mgr()->BuildDebugScope(
317 callee_itr->GetDebugScope(), inlined_at_ctx));
318 }
319 if (callee_itr->GetCommonDebugOpcode() == CommonDebugInfoDebugDeclare) {
320 InlineSingleInstruction(
321 callee2caller, new_blk_ptr->get(), &*callee_itr,
322 context()->get_debug_info_mgr()->BuildDebugInlinedAtChain(
323 callee_itr->GetDebugScope().GetInlinedAt(), inlined_at_ctx));
324 }
325 ++callee_itr;
326 }
327 return callee_itr;
328 }
329
InlineSingleInstruction(const std::unordered_map<uint32_t,uint32_t> & callee2caller,BasicBlock * new_blk_ptr,const Instruction * inst,uint32_t dbg_inlined_at)330 bool InlinePass::InlineSingleInstruction(
331 const std::unordered_map<uint32_t, uint32_t>& callee2caller,
332 BasicBlock* new_blk_ptr, const Instruction* inst, uint32_t dbg_inlined_at) {
333 // If we have return, it must be at the end of the callee. We will handle
334 // it at the end.
335 if (inst->opcode() == spv::Op::OpReturnValue ||
336 inst->opcode() == spv::Op::OpReturn)
337 return true;
338
339 // Copy callee instruction and remap all input Ids.
340 std::unique_ptr<Instruction> cp_inst(inst->Clone(context()));
341 cp_inst->ForEachInId([&callee2caller](uint32_t* iid) {
342 const auto mapItr = callee2caller.find(*iid);
343 if (mapItr != callee2caller.end()) {
344 *iid = mapItr->second;
345 }
346 });
347
348 // If result id is non-zero, remap it.
349 const uint32_t rid = cp_inst->result_id();
350 if (rid != 0) {
351 const auto mapItr = callee2caller.find(rid);
352 if (mapItr == callee2caller.end()) {
353 return false;
354 }
355 uint32_t nid = mapItr->second;
356 cp_inst->SetResultId(nid);
357 get_decoration_mgr()->CloneDecorations(rid, nid);
358 }
359
360 cp_inst->UpdateDebugInlinedAt(dbg_inlined_at);
361 new_blk_ptr->AddInstruction(std::move(cp_inst));
362 return true;
363 }
364
InlineReturn(const std::unordered_map<uint32_t,uint32_t> & callee2caller,std::vector<std::unique_ptr<BasicBlock>> * new_blocks,std::unique_ptr<BasicBlock> new_blk_ptr,analysis::DebugInlinedAtContext * inlined_at_ctx,Function * calleeFn,const Instruction * inst,uint32_t returnVarId)365 std::unique_ptr<BasicBlock> InlinePass::InlineReturn(
366 const std::unordered_map<uint32_t, uint32_t>& callee2caller,
367 std::vector<std::unique_ptr<BasicBlock>>* new_blocks,
368 std::unique_ptr<BasicBlock> new_blk_ptr,
369 analysis::DebugInlinedAtContext* inlined_at_ctx, Function* calleeFn,
370 const Instruction* inst, uint32_t returnVarId) {
371 // Store return value to return variable.
372 if (inst->opcode() == spv::Op::OpReturnValue) {
373 assert(returnVarId != 0);
374 uint32_t valId = inst->GetInOperand(kSpvReturnValueId).words[0];
375 const auto mapItr = callee2caller.find(valId);
376 if (mapItr != callee2caller.end()) {
377 valId = mapItr->second;
378 }
379 AddStore(returnVarId, valId, &new_blk_ptr, inst->dbg_line_inst(),
380 context()->get_debug_info_mgr()->BuildDebugScope(
381 inst->GetDebugScope(), inlined_at_ctx));
382 }
383
384 uint32_t returnLabelId = 0;
385 for (auto callee_block_itr = calleeFn->begin();
386 callee_block_itr != calleeFn->end(); ++callee_block_itr) {
387 if (spvOpcodeIsAbort(callee_block_itr->tail()->opcode())) {
388 returnLabelId = context()->TakeNextId();
389 break;
390 }
391 }
392 if (returnLabelId == 0) return new_blk_ptr;
393
394 if (inst->opcode() == spv::Op::OpReturn ||
395 inst->opcode() == spv::Op::OpReturnValue)
396 AddBranch(returnLabelId, &new_blk_ptr);
397 new_blocks->push_back(std::move(new_blk_ptr));
398 return MakeUnique<BasicBlock>(NewLabel(returnLabelId));
399 }
400
InlineEntryBlock(const std::unordered_map<uint32_t,uint32_t> & callee2caller,std::unique_ptr<BasicBlock> * new_blk_ptr,UptrVectorIterator<BasicBlock> callee_first_block,analysis::DebugInlinedAtContext * inlined_at_ctx)401 bool InlinePass::InlineEntryBlock(
402 const std::unordered_map<uint32_t, uint32_t>& callee2caller,
403 std::unique_ptr<BasicBlock>* new_blk_ptr,
404 UptrVectorIterator<BasicBlock> callee_first_block,
405 analysis::DebugInlinedAtContext* inlined_at_ctx) {
406 auto callee_inst_itr = AddStoresForVariableInitializers(
407 callee2caller, inlined_at_ctx, new_blk_ptr, callee_first_block);
408
409 while (callee_inst_itr != callee_first_block->end()) {
410 // Don't inline function definition links, the calling function is not a
411 // definition.
412 if (callee_inst_itr->GetShader100DebugOpcode() ==
413 NonSemanticShaderDebugInfo100DebugFunctionDefinition) {
414 ++callee_inst_itr;
415 continue;
416 }
417
418 if (!InlineSingleInstruction(
419 callee2caller, new_blk_ptr->get(), &*callee_inst_itr,
420 context()->get_debug_info_mgr()->BuildDebugInlinedAtChain(
421 callee_inst_itr->GetDebugScope().GetInlinedAt(),
422 inlined_at_ctx))) {
423 return false;
424 }
425 ++callee_inst_itr;
426 }
427 return true;
428 }
429
InlineBasicBlocks(std::vector<std::unique_ptr<BasicBlock>> * new_blocks,const std::unordered_map<uint32_t,uint32_t> & callee2caller,std::unique_ptr<BasicBlock> new_blk_ptr,analysis::DebugInlinedAtContext * inlined_at_ctx,Function * calleeFn)430 std::unique_ptr<BasicBlock> InlinePass::InlineBasicBlocks(
431 std::vector<std::unique_ptr<BasicBlock>>* new_blocks,
432 const std::unordered_map<uint32_t, uint32_t>& callee2caller,
433 std::unique_ptr<BasicBlock> new_blk_ptr,
434 analysis::DebugInlinedAtContext* inlined_at_ctx, Function* calleeFn) {
435 auto callee_block_itr = calleeFn->begin();
436 ++callee_block_itr;
437
438 while (callee_block_itr != calleeFn->end()) {
439 new_blocks->push_back(std::move(new_blk_ptr));
440 const auto mapItr =
441 callee2caller.find(callee_block_itr->GetLabelInst()->result_id());
442 if (mapItr == callee2caller.end()) return nullptr;
443 new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(mapItr->second));
444
445 auto tail_inst_itr = callee_block_itr->end();
446 for (auto inst_itr = callee_block_itr->begin(); inst_itr != tail_inst_itr;
447 ++inst_itr) {
448 // Don't inline function definition links, the calling function is not a
449 // definition
450 if (inst_itr->GetShader100DebugOpcode() ==
451 NonSemanticShaderDebugInfo100DebugFunctionDefinition)
452 continue;
453 if (!InlineSingleInstruction(
454 callee2caller, new_blk_ptr.get(), &*inst_itr,
455 context()->get_debug_info_mgr()->BuildDebugInlinedAtChain(
456 inst_itr->GetDebugScope().GetInlinedAt(), inlined_at_ctx))) {
457 return nullptr;
458 }
459 }
460
461 ++callee_block_itr;
462 }
463 return new_blk_ptr;
464 }
465
MoveCallerInstsAfterFunctionCall(std::unordered_map<uint32_t,Instruction * > * preCallSB,std::unordered_map<uint32_t,uint32_t> * postCallSB,std::unique_ptr<BasicBlock> * new_blk_ptr,BasicBlock::iterator call_inst_itr,bool multiBlocks)466 bool InlinePass::MoveCallerInstsAfterFunctionCall(
467 std::unordered_map<uint32_t, Instruction*>* preCallSB,
468 std::unordered_map<uint32_t, uint32_t>* postCallSB,
469 std::unique_ptr<BasicBlock>* new_blk_ptr,
470 BasicBlock::iterator call_inst_itr, bool multiBlocks) {
471 // Copy remaining instructions from caller block.
472 for (Instruction* inst = call_inst_itr->NextNode(); inst;
473 inst = call_inst_itr->NextNode()) {
474 inst->RemoveFromList();
475 std::unique_ptr<Instruction> cp_inst(inst);
476 // If multiple blocks generated, regenerate any same-block
477 // instruction that has not been seen in this last block.
478 if (multiBlocks) {
479 if (!CloneSameBlockOps(&cp_inst, postCallSB, preCallSB, new_blk_ptr)) {
480 return false;
481 }
482
483 // Remember same-block ops in this block.
484 if (IsSameBlockOp(&*cp_inst)) {
485 const uint32_t rid = cp_inst->result_id();
486 (*postCallSB)[rid] = rid;
487 }
488 }
489 new_blk_ptr->get()->AddInstruction(std::move(cp_inst));
490 }
491
492 return true;
493 }
494
MoveLoopMergeInstToFirstBlock(std::vector<std::unique_ptr<BasicBlock>> * new_blocks)495 void InlinePass::MoveLoopMergeInstToFirstBlock(
496 std::vector<std::unique_ptr<BasicBlock>>* new_blocks) {
497 // Move the OpLoopMerge from the last block back to the first, where
498 // it belongs.
499 auto& first = new_blocks->front();
500 auto& last = new_blocks->back();
501 assert(first != last);
502
503 // Insert a modified copy of the loop merge into the first block.
504 auto loop_merge_itr = last->tail();
505 --loop_merge_itr;
506 assert(loop_merge_itr->opcode() == spv::Op::OpLoopMerge);
507 std::unique_ptr<Instruction> cp_inst(loop_merge_itr->Clone(context()));
508 first->tail().InsertBefore(std::move(cp_inst));
509
510 // Remove the loop merge from the last block.
511 loop_merge_itr->RemoveFromList();
512 delete &*loop_merge_itr;
513 }
514
UpdateSingleBlockLoopContinueTarget(uint32_t new_id,std::vector<std::unique_ptr<BasicBlock>> * new_blocks)515 void InlinePass::UpdateSingleBlockLoopContinueTarget(
516 uint32_t new_id, std::vector<std::unique_ptr<BasicBlock>>* new_blocks) {
517 auto& header = new_blocks->front();
518 auto* merge_inst = header->GetLoopMergeInst();
519
520 // The back-edge block is split at the branch to create a new back-edge
521 // block. The old block is modified to branch to the new block. The loop
522 // merge instruction is updated to declare the new block as the continue
523 // target. This has the effect of changing the loop from being a large
524 // continue construct and an empty loop construct to being a loop with a loop
525 // construct and a trivial continue construct. This change is made to satisfy
526 // structural dominance.
527
528 // Add the new basic block.
529 std::unique_ptr<BasicBlock> new_block =
530 MakeUnique<BasicBlock>(NewLabel(new_id));
531 auto& old_backedge = new_blocks->back();
532 auto old_branch = old_backedge->tail();
533
534 // Move the old back edge into the new block.
535 std::unique_ptr<Instruction> br(&*old_branch);
536 new_block->AddInstruction(std::move(br));
537
538 // Add a branch to the new block from the old back-edge block.
539 AddBranch(new_id, &old_backedge);
540 new_blocks->push_back(std::move(new_block));
541
542 // Update the loop's continue target to the new block.
543 merge_inst->SetInOperand(1u, {new_id});
544 }
545
GenInlineCode(std::vector<std::unique_ptr<BasicBlock>> * new_blocks,std::vector<std::unique_ptr<Instruction>> * new_vars,BasicBlock::iterator call_inst_itr,UptrVectorIterator<BasicBlock> call_block_itr)546 bool InlinePass::GenInlineCode(
547 std::vector<std::unique_ptr<BasicBlock>>* new_blocks,
548 std::vector<std::unique_ptr<Instruction>>* new_vars,
549 BasicBlock::iterator call_inst_itr,
550 UptrVectorIterator<BasicBlock> call_block_itr) {
551 // Map from all ids in the callee to their equivalent id in the caller
552 // as callee instructions are copied into caller.
553 std::unordered_map<uint32_t, uint32_t> callee2caller;
554 // Pre-call same-block insts
555 std::unordered_map<uint32_t, Instruction*> preCallSB;
556 // Post-call same-block op ids
557 std::unordered_map<uint32_t, uint32_t> postCallSB;
558
559 analysis::DebugInlinedAtContext inlined_at_ctx(&*call_inst_itr);
560
561 // Invalidate the def-use chains. They are not kept up to date while
562 // inlining. However, certain calls try to keep them up-to-date if they are
563 // valid. These operations can fail.
564 context()->InvalidateAnalyses(IRContext::kAnalysisDefUse);
565
566 // If the caller is a loop header and the callee has multiple blocks, then the
567 // normal inlining logic will place the OpLoopMerge in the last of several
568 // blocks in the loop. Instead, it should be placed at the end of the first
569 // block. We'll wait to move the OpLoopMerge until the end of the regular
570 // inlining logic, and only if necessary.
571 bool caller_is_loop_header = call_block_itr->GetLoopMergeInst() != nullptr;
572
573 // Single-trip loop continue block
574 std::unique_ptr<BasicBlock> single_trip_loop_cont_blk;
575
576 Function* calleeFn = id2function_[call_inst_itr->GetSingleWordOperand(
577 kSpvFunctionCallFunctionId)];
578
579 // Map parameters to actual arguments.
580 MapParams(calleeFn, call_inst_itr, &callee2caller);
581
582 // Define caller local variables for all callee variables and create map to
583 // them.
584 if (!CloneAndMapLocals(calleeFn, new_vars, &callee2caller, &inlined_at_ctx)) {
585 return false;
586 }
587
588 // First block needs to use label of original block
589 // but map callee label in case of phi reference.
590 uint32_t entry_blk_label_id = calleeFn->begin()->GetLabelInst()->result_id();
591 callee2caller[entry_blk_label_id] = call_block_itr->id();
592 std::unique_ptr<BasicBlock> new_blk_ptr =
593 MakeUnique<BasicBlock>(NewLabel(call_block_itr->id()));
594
595 // Move instructions of original caller block up to call instruction.
596 MoveInstsBeforeEntryBlock(&preCallSB, new_blk_ptr.get(), call_inst_itr,
597 call_block_itr);
598
599 if (caller_is_loop_header &&
600 (*(calleeFn->begin())).GetMergeInst() != nullptr) {
601 // We can't place both the caller's merge instruction and
602 // another merge instruction in the same block. So split the
603 // calling block. Insert an unconditional branch to a new guard
604 // block. Later, once we know the ID of the last block, we
605 // will move the caller's OpLoopMerge from the last generated
606 // block into the first block. We also wait to avoid
607 // invalidating various iterators.
608 new_blk_ptr = AddGuardBlock(new_blocks, &callee2caller,
609 std::move(new_blk_ptr), entry_blk_label_id);
610 if (new_blk_ptr == nullptr) return false;
611 }
612
613 // Create return var if needed.
614 const uint32_t calleeTypeId = calleeFn->type_id();
615 uint32_t returnVarId = 0;
616 analysis::Type* calleeType = context()->get_type_mgr()->GetType(calleeTypeId);
617 if (calleeType->AsVoid() == nullptr) {
618 returnVarId = CreateReturnVar(calleeFn, new_vars);
619 if (returnVarId == 0) {
620 return false;
621 }
622 }
623
624 calleeFn->WhileEachInst([&callee2caller, this](const Instruction* cpi) {
625 // Create set of callee result ids. Used to detect forward references
626 const uint32_t rid = cpi->result_id();
627 if (rid != 0 && callee2caller.find(rid) == callee2caller.end()) {
628 const uint32_t nid = context()->TakeNextId();
629 if (nid == 0) return false;
630 callee2caller[rid] = nid;
631 }
632 return true;
633 });
634
635 // Inline DebugClare instructions in the callee's header.
636 calleeFn->ForEachDebugInstructionsInHeader(
637 [&new_blk_ptr, &callee2caller, &inlined_at_ctx, this](Instruction* inst) {
638 InlineSingleInstruction(
639 callee2caller, new_blk_ptr.get(), inst,
640 context()->get_debug_info_mgr()->BuildDebugInlinedAtChain(
641 inst->GetDebugScope().GetInlinedAt(), &inlined_at_ctx));
642 });
643
644 // Inline the entry block of the callee function.
645 if (!InlineEntryBlock(callee2caller, &new_blk_ptr, calleeFn->begin(),
646 &inlined_at_ctx)) {
647 return false;
648 }
649
650 // Inline blocks of the callee function other than the entry block.
651 new_blk_ptr =
652 InlineBasicBlocks(new_blocks, callee2caller, std::move(new_blk_ptr),
653 &inlined_at_ctx, calleeFn);
654 if (new_blk_ptr == nullptr) return false;
655
656 new_blk_ptr = InlineReturn(callee2caller, new_blocks, std::move(new_blk_ptr),
657 &inlined_at_ctx, calleeFn,
658 &*(calleeFn->tail()->tail()), returnVarId);
659
660 // Load return value into result id of call, if it exists.
661 if (returnVarId != 0) {
662 const uint32_t resId = call_inst_itr->result_id();
663 assert(resId != 0);
664 AddLoad(calleeTypeId, resId, returnVarId, &new_blk_ptr,
665 call_inst_itr->dbg_line_inst(), call_inst_itr->GetDebugScope());
666 }
667
668 // Move instructions of original caller block after call instruction.
669 if (!MoveCallerInstsAfterFunctionCall(&preCallSB, &postCallSB, &new_blk_ptr,
670 call_inst_itr,
671 calleeFn->begin() != calleeFn->end()))
672 return false;
673
674 // Finalize inline code.
675 new_blocks->push_back(std::move(new_blk_ptr));
676
677 if (caller_is_loop_header && (new_blocks->size() > 1)) {
678 MoveLoopMergeInstToFirstBlock(new_blocks);
679
680 // If the loop was a single basic block previously, update it's structure.
681 auto& header = new_blocks->front();
682 auto* merge_inst = header->GetLoopMergeInst();
683 if (merge_inst->GetSingleWordInOperand(1u) == header->id()) {
684 auto new_id = context()->TakeNextId();
685 if (new_id == 0) return false;
686 UpdateSingleBlockLoopContinueTarget(new_id, new_blocks);
687 }
688 }
689
690 // Update block map given replacement blocks.
691 for (auto& blk : *new_blocks) {
692 id2block_[blk->id()] = &*blk;
693 }
694
695 // We need to kill the name and decorations for the call, which will be
696 // deleted.
697 context()->KillNamesAndDecorates(&*call_inst_itr);
698
699 return true;
700 }
701
IsInlinableFunctionCall(const Instruction * inst)702 bool InlinePass::IsInlinableFunctionCall(const Instruction* inst) {
703 if (inst->opcode() != spv::Op::OpFunctionCall) return false;
704 const uint32_t calleeFnId =
705 inst->GetSingleWordOperand(kSpvFunctionCallFunctionId);
706 const auto ci = inlinable_.find(calleeFnId);
707 if (ci == inlinable_.cend()) return false;
708
709 if (early_return_funcs_.find(calleeFnId) != early_return_funcs_.end()) {
710 // We rely on the merge-return pass to handle the early return case
711 // in advance.
712 std::string message =
713 "The function '" + id2function_[calleeFnId]->DefInst().PrettyPrint() +
714 "' could not be inlined because the return instruction "
715 "is not at the end of the function. This could be fixed by "
716 "running merge-return before inlining.";
717 consumer()(SPV_MSG_WARNING, "", {0, 0, 0}, message.c_str());
718 return false;
719 }
720
721 return true;
722 }
723
UpdateSucceedingPhis(std::vector<std::unique_ptr<BasicBlock>> & new_blocks)724 void InlinePass::UpdateSucceedingPhis(
725 std::vector<std::unique_ptr<BasicBlock>>& new_blocks) {
726 const auto firstBlk = new_blocks.begin();
727 const auto lastBlk = new_blocks.end() - 1;
728 const uint32_t firstId = (*firstBlk)->id();
729 const uint32_t lastId = (*lastBlk)->id();
730 const BasicBlock& const_last_block = *lastBlk->get();
731 const_last_block.ForEachSuccessorLabel(
732 [&firstId, &lastId, this](const uint32_t succ) {
733 BasicBlock* sbp = this->id2block_[succ];
734 sbp->ForEachPhiInst([&firstId, &lastId](Instruction* phi) {
735 phi->ForEachInId([&firstId, &lastId](uint32_t* id) {
736 if (*id == firstId) *id = lastId;
737 });
738 });
739 });
740 }
741
HasNoReturnInLoop(Function * func)742 bool InlinePass::HasNoReturnInLoop(Function* func) {
743 // If control not structured, do not do loop/return analysis
744 // TODO: Analyze returns in non-structured control flow
745 if (!context()->get_feature_mgr()->HasCapability(spv::Capability::Shader))
746 return false;
747 const auto structured_analysis = context()->GetStructuredCFGAnalysis();
748 // Search for returns in structured construct.
749 bool return_in_loop = false;
750 for (auto& blk : *func) {
751 auto terminal_ii = blk.cend();
752 --terminal_ii;
753 if (spvOpcodeIsReturn(terminal_ii->opcode()) &&
754 structured_analysis->ContainingLoop(blk.id()) != 0) {
755 return_in_loop = true;
756 break;
757 }
758 }
759 return !return_in_loop;
760 }
761
AnalyzeReturns(Function * func)762 void InlinePass::AnalyzeReturns(Function* func) {
763 // Analyze functions without a return in loop.
764 if (HasNoReturnInLoop(func)) {
765 no_return_in_loop_.insert(func->result_id());
766 }
767 // Analyze functions with a return before its tail basic block.
768 for (auto& blk : *func) {
769 auto terminal_ii = blk.cend();
770 --terminal_ii;
771 if (spvOpcodeIsReturn(terminal_ii->opcode()) && &blk != func->tail()) {
772 early_return_funcs_.insert(func->result_id());
773 break;
774 }
775 }
776 }
777
IsInlinableFunction(Function * func)778 bool InlinePass::IsInlinableFunction(Function* func) {
779 // We can only inline a function if it has blocks.
780 if (func->cbegin() == func->cend()) return false;
781
782 // Do not inline functions with DontInline flag.
783 if (func->control_mask() & uint32_t(spv::FunctionControlMask::DontInline)) {
784 return false;
785 }
786
787 // Do not inline functions with returns in loops. Currently early return
788 // functions are inlined by wrapping them in a one trip loop and implementing
789 // the returns as a branch to the loop's merge block. However, this can only
790 // done validly if the return was not in a loop in the original function.
791 // Also remember functions with multiple (early) returns.
792 AnalyzeReturns(func);
793 if (no_return_in_loop_.find(func->result_id()) == no_return_in_loop_.cend()) {
794 return false;
795 }
796
797 if (func->IsRecursive()) {
798 return false;
799 }
800
801 // Do not inline functions with an abort instruction if they are called from a
802 // continue construct. If it is inlined into a continue construct the backedge
803 // will no longer post-dominate the continue target, which is invalid. An
804 // `OpUnreachable` is acceptable because it will not change post-dominance if
805 // it is statically unreachable.
806 bool func_is_called_from_continue =
807 funcs_called_from_continue_.count(func->result_id()) != 0;
808
809 if (func_is_called_from_continue && ContainsAbortOtherThanUnreachable(func)) {
810 return false;
811 }
812
813 return true;
814 }
815
ContainsAbortOtherThanUnreachable(Function * func) const816 bool InlinePass::ContainsAbortOtherThanUnreachable(Function* func) const {
817 return !func->WhileEachInst([](Instruction* inst) {
818 return inst->opcode() == spv::Op::OpUnreachable ||
819 !spvOpcodeIsAbort(inst->opcode());
820 });
821 }
822
InitializeInline()823 void InlinePass::InitializeInline() {
824 false_id_ = 0;
825
826 // clear collections
827 id2function_.clear();
828 id2block_.clear();
829 inlinable_.clear();
830 no_return_in_loop_.clear();
831 early_return_funcs_.clear();
832 funcs_called_from_continue_ =
833 context()->GetStructuredCFGAnalysis()->FindFuncsCalledFromContinue();
834
835 for (auto& fn : *get_module()) {
836 // Initialize function and block maps.
837 id2function_[fn.result_id()] = &fn;
838 for (auto& blk : fn) {
839 id2block_[blk.id()] = &blk;
840 }
841 // Compute inlinability
842 if (IsInlinableFunction(&fn)) inlinable_.insert(fn.result_id());
843 }
844 }
845
InlinePass()846 InlinePass::InlinePass() {}
847
848 } // namespace opt
849 } // namespace spvtools
850