1 /*------------------------------------------------------------------------
2 * Vulkan Conformance Tests
3 * ------------------------
4 *
5 * Copyright (c) 2016 The Khronos Group Inc.
6 * Copyright (c) 2016 The Android Open Source Project
7 *
8 * Licensed under the Apache License, Version 2.0 (the "License");
9 * you may not use this file except in compliance with the License.
10 * You may obtain a copy of the License at
11 *
12 * http://www.apache.org/licenses/LICENSE-2.0
13 *
14 * Unless required by applicable law or agreed to in writing, software
15 * distributed under the License is distributed on an "AS IS" BASIS,
16 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
17 * See the License for the specific language governing permissions and
18 * limitations under the License.
19 *
20 *//*!
21 * \file
22 * \brief Memory qualifiers tests
23 *//*--------------------------------------------------------------------*/
24
25 #include "vktImageQualifiersTests.hpp"
26 #include "vktImageLoadStoreTests.hpp"
27 #include "vktImageTestsUtil.hpp"
28
29 #include "vkDefs.hpp"
30 #include "vkImageUtil.hpp"
31 #include "vkRef.hpp"
32 #include "vkRefUtil.hpp"
33 #include "vktTestCase.hpp"
34 #include "vktTestCaseUtil.hpp"
35 #include "vkBarrierUtil.hpp"
36 #include "vkPlatform.hpp"
37 #include "vkPrograms.hpp"
38 #include "vkMemUtil.hpp"
39 #include "vkBuilderUtil.hpp"
40 #include "vkQueryUtil.hpp"
41 #include "vkTypeUtil.hpp"
42 #include "vkCmdUtil.hpp"
43 #include "vkObjUtil.hpp"
44 #include "vkBufferWithMemory.hpp"
45
46 #include "deDefs.hpp"
47 #include "deStringUtil.hpp"
48 #include "deUniquePtr.hpp"
49
50 #include "tcuImageCompare.hpp"
51 #include "tcuTexture.hpp"
52 #include "tcuTextureUtil.hpp"
53 #include "tcuVectorType.hpp"
54
55 using namespace vk;
56
57 namespace vkt
58 {
59 namespace image
60 {
61 namespace
62 {
63
64 static const tcu::UVec3 g_localWorkGroupSizeBase = tcu::UVec3(8, 8, 2);
65 static const deInt32 g_ShaderReadOffsetsX[4] = { 1, 4, 7, 10 };
66 static const deInt32 g_ShaderReadOffsetsY[4] = { 2, 5, 8, 11 };
67 static const deInt32 g_ShaderReadOffsetsZ[4] = { 3, 6, 9, 12 };
68 static const char* const g_ShaderReadOffsetsXStr = "int[]( 1, 4, 7, 10 )";
69 static const char* const g_ShaderReadOffsetsYStr = "int[]( 2, 5, 8, 11 )";
70 static const char* const g_ShaderReadOffsetsZStr = "int[]( 3, 6, 9, 12 )";
71
getLocalWorkGroupSize(const ImageType imageType,const tcu::UVec3 & imageSize)72 const tcu::UVec3 getLocalWorkGroupSize (const ImageType imageType, const tcu::UVec3& imageSize)
73 {
74 const tcu::UVec3 computeGridSize = getShaderGridSize(imageType, imageSize);
75
76 const tcu::UVec3 localWorkGroupSize = tcu::UVec3(de::min(g_localWorkGroupSizeBase.x(), computeGridSize.x()),
77 de::min(g_localWorkGroupSizeBase.y(), computeGridSize.y()),
78 de::min(g_localWorkGroupSizeBase.z(), computeGridSize.z()));
79 return localWorkGroupSize;
80 }
81
getNumWorkGroups(const ImageType imageType,const tcu::UVec3 & imageSize)82 const tcu::UVec3 getNumWorkGroups (const ImageType imageType, const tcu::UVec3& imageSize)
83 {
84 const tcu::UVec3 computeGridSize = getShaderGridSize(imageType, imageSize);
85 const tcu::UVec3 localWorkGroupSize = getLocalWorkGroupSize(imageType, imageSize);
86
87 return computeGridSize / localWorkGroupSize;
88 }
89
getLayerOrSlice(const ImageType imageType,const tcu::ConstPixelBufferAccess & access,const deUint32 layer)90 tcu::ConstPixelBufferAccess getLayerOrSlice (const ImageType imageType,
91 const tcu::ConstPixelBufferAccess& access,
92 const deUint32 layer)
93 {
94 switch (imageType)
95 {
96 case IMAGE_TYPE_1D:
97 case IMAGE_TYPE_2D:
98 case IMAGE_TYPE_BUFFER:
99 DE_ASSERT(layer == 0);
100 return access;
101
102 case IMAGE_TYPE_1D_ARRAY:
103 return tcu::getSubregion(access, 0, layer, access.getWidth(), 1);
104
105 case IMAGE_TYPE_2D_ARRAY:
106 case IMAGE_TYPE_3D:
107 case IMAGE_TYPE_CUBE:
108 case IMAGE_TYPE_CUBE_ARRAY:
109 return tcu::getSubregion(access, 0, 0, layer, access.getWidth(), access.getHeight(), 1);
110
111 default:
112 DE_FATAL("Unknown image type");
113 return tcu::ConstPixelBufferAccess();
114 }
115 }
116
comparePixelBuffers(tcu::TestContext & testCtx,const ImageType imageType,const tcu::UVec3 & imageSize,const tcu::TextureFormat & format,const tcu::ConstPixelBufferAccess & reference,const tcu::ConstPixelBufferAccess & result)117 bool comparePixelBuffers (tcu::TestContext& testCtx,
118 const ImageType imageType,
119 const tcu::UVec3& imageSize,
120 const tcu::TextureFormat& format,
121 const tcu::ConstPixelBufferAccess& reference,
122 const tcu::ConstPixelBufferAccess& result)
123 {
124 DE_ASSERT(reference.getFormat() == result.getFormat());
125 DE_ASSERT(reference.getSize() == result.getSize());
126
127 const bool intFormat = isIntFormat(mapTextureFormat(format)) || isUintFormat(mapTextureFormat(format));
128 deUint32 passedLayers = 0;
129
130 for (deUint32 layerNdx = 0; layerNdx < getNumLayers(imageType, imageSize); ++layerNdx)
131 {
132 const std::string comparisonName = "Comparison" + de::toString(layerNdx);
133
134 std::string comparisonDesc = "Image Comparison, ";
135 switch (imageType)
136 {
137 case IMAGE_TYPE_3D:
138 comparisonDesc = comparisonDesc + "slice " + de::toString(layerNdx);
139 break;
140
141 case IMAGE_TYPE_CUBE:
142 case IMAGE_TYPE_CUBE_ARRAY:
143 comparisonDesc = comparisonDesc + "face " + de::toString(layerNdx % 6) + ", cube " + de::toString(layerNdx / 6);
144 break;
145
146 default:
147 comparisonDesc = comparisonDesc + "layer " + de::toString(layerNdx);
148 break;
149 }
150
151 const tcu::ConstPixelBufferAccess refLayer = getLayerOrSlice(imageType, reference, layerNdx);
152 const tcu::ConstPixelBufferAccess resultLayer = getLayerOrSlice(imageType, result, layerNdx);
153
154 bool ok = false;
155 if (intFormat)
156 ok = tcu::intThresholdCompare(testCtx.getLog(), comparisonName.c_str(), comparisonDesc.c_str(), refLayer, resultLayer, tcu::UVec4(0), tcu::COMPARE_LOG_RESULT);
157 else
158 ok = tcu::floatThresholdCompare(testCtx.getLog(), comparisonName.c_str(), comparisonDesc.c_str(), refLayer, resultLayer, tcu::Vec4(0.01f), tcu::COMPARE_LOG_RESULT);
159
160 if (ok)
161 ++passedLayers;
162 }
163
164 return passedLayers == getNumLayers(imageType, imageSize);
165 }
166
getCoordStr(const ImageType imageType,const std::string & x,const std::string & y,const std::string & z)167 const std::string getCoordStr (const ImageType imageType,
168 const std::string& x,
169 const std::string& y,
170 const std::string& z)
171 {
172 switch (imageType)
173 {
174 case IMAGE_TYPE_1D:
175 case IMAGE_TYPE_BUFFER:
176 return x;
177
178 case IMAGE_TYPE_1D_ARRAY:
179 case IMAGE_TYPE_2D:
180 return "ivec2(" + x + "," + y + ")";
181
182 case IMAGE_TYPE_2D_ARRAY:
183 case IMAGE_TYPE_3D:
184 case IMAGE_TYPE_CUBE:
185 case IMAGE_TYPE_CUBE_ARRAY:
186 return "ivec3(" + x + "," + y + "," + z + ")";
187
188 default:
189 DE_ASSERT(false);
190 return "";
191 }
192 }
193
194 class MemoryQualifierTestCase : public vkt::TestCase
195 {
196 public:
197
198 enum Qualifier
199 {
200 QUALIFIER_COHERENT = 0,
201 QUALIFIER_VOLATILE,
202 QUALIFIER_RESTRICT,
203 QUALIFIER_LAST
204 };
205
206 MemoryQualifierTestCase (tcu::TestContext& testCtx,
207 const std::string& name,
208 const Qualifier qualifier,
209 const ImageType imageType,
210 const tcu::UVec3& imageSize,
211 const tcu::TextureFormat& format,
212 const glu::GLSLVersion glslVersion);
213
~MemoryQualifierTestCase(void)214 virtual ~MemoryQualifierTestCase (void) {}
215
216 virtual void initPrograms (SourceCollections& programCollection) const;
217 virtual TestInstance* createInstance (Context& context) const;
218 virtual void checkSupport (Context& context) const;
219
220 protected:
221
222 const Qualifier m_qualifier;
223 const ImageType m_imageType;
224 const tcu::UVec3 m_imageSize;
225 const tcu::TextureFormat m_format;
226 const glu::GLSLVersion m_glslVersion;
227 };
228
MemoryQualifierTestCase(tcu::TestContext & testCtx,const std::string & name,const Qualifier qualifier,const ImageType imageType,const tcu::UVec3 & imageSize,const tcu::TextureFormat & format,const glu::GLSLVersion glslVersion)229 MemoryQualifierTestCase::MemoryQualifierTestCase (tcu::TestContext& testCtx,
230 const std::string& name,
231 const Qualifier qualifier,
232 const ImageType imageType,
233 const tcu::UVec3& imageSize,
234 const tcu::TextureFormat& format,
235 const glu::GLSLVersion glslVersion)
236 : vkt::TestCase(testCtx, name)
237 , m_qualifier(qualifier)
238 , m_imageType(imageType)
239 , m_imageSize(imageSize)
240 , m_format(format)
241 , m_glslVersion(glslVersion)
242 {
243 }
244
checkSupport(Context & context) const245 void MemoryQualifierTestCase::checkSupport (Context& context) const
246 {
247 if (m_imageType == IMAGE_TYPE_CUBE_ARRAY)
248 context.requireDeviceCoreFeature(DEVICE_CORE_FEATURE_IMAGE_CUBE_ARRAY);
249 }
250
initPrograms(SourceCollections & programCollection) const251 void MemoryQualifierTestCase::initPrograms (SourceCollections& programCollection) const
252 {
253 const char* const versionDecl = glu::getGLSLVersionDeclaration(m_glslVersion);
254
255 const char* const qualifierName = m_qualifier == QUALIFIER_COHERENT ? "coherent"
256 : m_qualifier == QUALIFIER_VOLATILE ? "volatile"
257 : DE_NULL;
258
259 const bool uintFormat = isUintFormat(mapTextureFormat(m_format));
260 const bool intFormat = isIntFormat(mapTextureFormat(m_format));
261 const std::string colorVecTypeName = std::string(uintFormat ? "u" : intFormat ? "i" : "") + "vec4";
262 const std::string colorScalarTypeName = std::string(uintFormat ? "uint" : intFormat ? "int" : "float");
263 const std::string invocationCoord = getCoordStr(m_imageType, "gx", "gy", "gz");
264 const std::string shaderImageFormat = getShaderImageFormatQualifier(m_format);
265 const std::string shaderImageType = getShaderImageType(m_format, m_imageType);
266
267 const tcu::UVec3 localWorkGroupSize = getLocalWorkGroupSize(m_imageType, m_imageSize);
268 const std::string localSizeX = de::toString(localWorkGroupSize.x());
269 const std::string localSizeY = de::toString(localWorkGroupSize.y());
270 const std::string localSizeZ = de::toString(localWorkGroupSize.z());
271
272 std::ostringstream programBuffer;
273
274 programBuffer
275 << versionDecl << "\n"
276 << "\n"
277 << "precision highp " << shaderImageType << ";\n"
278 << "\n"
279 << "layout (local_size_x = " << localSizeX << ", local_size_y = " << localSizeY << ", local_size_z = " + localSizeZ << ") in;\n"
280 << "layout (" << shaderImageFormat << ", binding=0) " << qualifierName << " uniform " << shaderImageType << " u_image;\n"
281 << "void main (void)\n"
282 << "{\n"
283 << " int gx = int(gl_GlobalInvocationID.x);\n"
284 << " int gy = int(gl_GlobalInvocationID.y);\n"
285 << " int gz = int(gl_GlobalInvocationID.z);\n"
286 << " imageStore(u_image, " << invocationCoord << ", " << colorVecTypeName << "(gx^gy^gz));\n"
287 << "\n"
288 << " memoryBarrier();\n"
289 << " barrier();\n"
290 << "\n"
291 << " " << colorScalarTypeName << " sum = " << colorScalarTypeName << "(0);\n"
292 << " int groupBaseX = gx/" << localSizeX << "*" << localSizeX << ";\n"
293 << " int groupBaseY = gy/" << localSizeY << "*" << localSizeY << ";\n"
294 << " int groupBaseZ = gz/" << localSizeZ << "*" << localSizeZ << ";\n"
295 << " int xOffsets[] = " << g_ShaderReadOffsetsXStr << ";\n"
296 << " int yOffsets[] = " << g_ShaderReadOffsetsYStr << ";\n"
297 << " int zOffsets[] = " << g_ShaderReadOffsetsZStr << ";\n"
298 << " for (int i = 0; i < " << de::toString(DE_LENGTH_OF_ARRAY(g_ShaderReadOffsetsX)) << "; i++)\n"
299 << " {\n"
300 << " int readX = groupBaseX + (gx + xOffsets[i]) % " + localSizeX + ";\n"
301 << " int readY = groupBaseY + (gy + yOffsets[i]) % " + localSizeY + ";\n"
302 << " int readZ = groupBaseZ + (gz + zOffsets[i]) % " + localSizeZ + ";\n"
303 << " sum += imageLoad(u_image, " << getCoordStr(m_imageType, "readX", "readY", "readZ") << ").x;\n"
304 << " }\n"
305 << "\n"
306 << " memoryBarrier();\n"
307 << " barrier();\n"
308 << "\n"
309 << " imageStore(u_image, " + invocationCoord + ", " + colorVecTypeName + "(sum));\n"
310 << "}\n";
311
312 programCollection.glslSources.add(m_name) << glu::ComputeSource(programBuffer.str());
313 }
314
315 class MemoryQualifierInstanceBase : public vkt::TestInstance
316 {
317 public:
318 MemoryQualifierInstanceBase (Context& context,
319 const std::string& name,
320 const ImageType imageType,
321 const tcu::UVec3& imageSize,
322 const tcu::TextureFormat& format);
323
~MemoryQualifierInstanceBase(void)324 virtual ~MemoryQualifierInstanceBase (void) {}
325
326 virtual tcu::TestStatus iterate (void);
327
328 virtual void prepareResources (const VkDeviceSize bufferSizeInBytes) = 0;
329
330 virtual void prepareDescriptors (void) = 0;
331
332 virtual void commandsBeforeCompute (const VkCommandBuffer cmdBuffer,
333 const VkDeviceSize bufferSizeInBytes) const = 0;
334
335 virtual void commandsAfterCompute (const VkCommandBuffer cmdBuffer,
336 const VkDeviceSize bufferSizeInBytes) const = 0;
337
338 protected:
339
340 tcu::TextureLevel generateReferenceImage (void) const;
341
342 const std::string m_name;
343 const ImageType m_imageType;
344 const tcu::UVec3 m_imageSize;
345 const tcu::TextureFormat m_format;
346
347 de::MovePtr<BufferWithMemory> m_buffer;
348 Move<VkDescriptorPool> m_descriptorPool;
349 Move<VkDescriptorSetLayout> m_descriptorSetLayout;
350 Move<VkDescriptorSet> m_descriptorSet;
351 };
352
MemoryQualifierInstanceBase(Context & context,const std::string & name,const ImageType imageType,const tcu::UVec3 & imageSize,const tcu::TextureFormat & format)353 MemoryQualifierInstanceBase::MemoryQualifierInstanceBase (Context& context,
354 const std::string& name,
355 const ImageType imageType,
356 const tcu::UVec3& imageSize,
357 const tcu::TextureFormat& format)
358 : vkt::TestInstance(context)
359 , m_name(name)
360 , m_imageType(imageType)
361 , m_imageSize(imageSize)
362 , m_format(format)
363 {
364 }
365
iterate(void)366 tcu::TestStatus MemoryQualifierInstanceBase::iterate (void)
367 {
368 const VkDevice device = m_context.getDevice();
369 const DeviceInterface& deviceInterface = m_context.getDeviceInterface();
370 const VkQueue queue = m_context.getUniversalQueue();
371 const deUint32 queueFamilyIndex = m_context.getUniversalQueueFamilyIndex();
372
373 const VkDeviceSize bufferSizeInBytes = getNumPixels(m_imageType, m_imageSize) * tcu::getPixelSize(m_format);
374
375 // Prepare resources for the test
376 prepareResources(bufferSizeInBytes);
377
378 // Prepare descriptor sets
379 prepareDescriptors();
380
381 // Create compute shader
382 const vk::Unique<VkShaderModule> shaderModule(createShaderModule(deviceInterface, device, m_context.getBinaryCollection().get(m_name), 0u));
383
384 // Create compute pipeline
385 const vk::Unique<VkPipelineLayout> pipelineLayout(makePipelineLayout(deviceInterface, device, *m_descriptorSetLayout));
386 const vk::Unique<VkPipeline> pipeline(makeComputePipeline(deviceInterface, device, *pipelineLayout, *shaderModule));
387
388 // Create command buffer
389 const Unique<VkCommandPool> cmdPool(createCommandPool(deviceInterface, device, VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT, queueFamilyIndex));
390 const Unique<VkCommandBuffer> cmdBuffer(allocateCommandBuffer(deviceInterface, device, *cmdPool, VK_COMMAND_BUFFER_LEVEL_PRIMARY));
391
392 // Start recording commands
393 beginCommandBuffer(deviceInterface, *cmdBuffer);
394
395 deviceInterface.cmdBindPipeline(*cmdBuffer, VK_PIPELINE_BIND_POINT_COMPUTE, *pipeline);
396 deviceInterface.cmdBindDescriptorSets(*cmdBuffer, VK_PIPELINE_BIND_POINT_COMPUTE, *pipelineLayout, 0u, 1u, &m_descriptorSet.get(), 0u, DE_NULL);
397
398 commandsBeforeCompute(*cmdBuffer, bufferSizeInBytes);
399
400 const tcu::UVec3 numGroups = getNumWorkGroups(m_imageType, m_imageSize);
401 deviceInterface.cmdDispatch(*cmdBuffer, numGroups.x(), numGroups.y(), numGroups.z());
402
403 commandsAfterCompute(*cmdBuffer, bufferSizeInBytes);
404
405 endCommandBuffer(deviceInterface, *cmdBuffer);
406
407 // Submit and wait for completion
408 submitCommandsAndWait(deviceInterface, device, queue, *cmdBuffer);
409
410 // Retrieve data from buffer to host memory
411 const Allocation& allocation = m_buffer->getAllocation();
412 invalidateAlloc(deviceInterface, device, allocation);
413
414 const tcu::UVec3 computeGridSize = getShaderGridSize(m_imageType, m_imageSize);
415 tcu::ConstPixelBufferAccess resultPixelBuffer(m_format, computeGridSize.x(), computeGridSize.y(), computeGridSize.z(), allocation.getHostPtr());
416
417 // Create a reference image
418 tcu::TextureLevel referenceImage = generateReferenceImage();
419 tcu::ConstPixelBufferAccess referencePixelBuffer = referenceImage.getAccess();
420
421 // Validate the result
422 if (comparePixelBuffers(m_context.getTestContext(), m_imageType, m_imageSize, m_format, referencePixelBuffer, resultPixelBuffer))
423 return tcu::TestStatus::pass("Passed");
424 else
425 return tcu::TestStatus::fail("Image comparison failed");
426 }
427
generateReferenceImage(void) const428 tcu::TextureLevel MemoryQualifierInstanceBase::generateReferenceImage (void) const
429 {
430 // Generate a reference image data using the storage format
431 const tcu::UVec3 computeGridSize = getShaderGridSize(m_imageType, m_imageSize);
432
433 tcu::TextureLevel base(m_format, computeGridSize.x(), computeGridSize.y(), computeGridSize.z());
434 tcu::PixelBufferAccess baseAccess = base.getAccess();
435
436 tcu::TextureLevel reference(m_format, computeGridSize.x(), computeGridSize.y(), computeGridSize.z());
437 tcu::PixelBufferAccess referenceAccess = reference.getAccess();
438
439 for (deInt32 z = 0; z < baseAccess.getDepth(); ++z)
440 for (deInt32 y = 0; y < baseAccess.getHeight(); ++y)
441 for (deInt32 x = 0; x < baseAccess.getWidth(); ++x)
442 {
443 baseAccess.setPixel(tcu::IVec4(x^y^z), x, y, z);
444 }
445
446 const tcu::UVec3 localWorkGroupSize = getLocalWorkGroupSize(m_imageType, m_imageSize);
447
448 for (deInt32 z = 0; z < referenceAccess.getDepth(); ++z)
449 for (deInt32 y = 0; y < referenceAccess.getHeight(); ++y)
450 for (deInt32 x = 0; x < referenceAccess.getWidth(); ++x)
451 {
452 const deInt32 groupBaseX = x / localWorkGroupSize.x() * localWorkGroupSize.x();
453 const deInt32 groupBaseY = y / localWorkGroupSize.y() * localWorkGroupSize.y();
454 const deInt32 groupBaseZ = z / localWorkGroupSize.z() * localWorkGroupSize.z();
455 deInt32 sum = 0;
456
457 for (deInt32 i = 0; i < DE_LENGTH_OF_ARRAY(g_ShaderReadOffsetsX); i++)
458 {
459 sum += baseAccess.getPixelInt(
460 groupBaseX + (x + g_ShaderReadOffsetsX[i]) % localWorkGroupSize.x(),
461 groupBaseY + (y + g_ShaderReadOffsetsY[i]) % localWorkGroupSize.y(),
462 groupBaseZ + (z + g_ShaderReadOffsetsZ[i]) % localWorkGroupSize.z()).x();
463 }
464
465 referenceAccess.setPixel(tcu::IVec4(sum), x, y, z);
466 }
467
468 return reference;
469 }
470
471 class MemoryQualifierInstanceImage : public MemoryQualifierInstanceBase
472 {
473 public:
MemoryQualifierInstanceImage(Context & context,const std::string & name,const ImageType imageType,const tcu::UVec3 & imageSize,const tcu::TextureFormat & format)474 MemoryQualifierInstanceImage (Context& context,
475 const std::string& name,
476 const ImageType imageType,
477 const tcu::UVec3& imageSize,
478 const tcu::TextureFormat& format)
479 : MemoryQualifierInstanceBase(context, name, imageType, imageSize, format) {}
480
~MemoryQualifierInstanceImage(void)481 virtual ~MemoryQualifierInstanceImage (void) {}
482
483 virtual void prepareResources (const VkDeviceSize bufferSizeInBytes);
484
485 virtual void prepareDescriptors (void);
486
487 virtual void commandsBeforeCompute (const VkCommandBuffer cmdBuffer,
488 const VkDeviceSize bufferSizeInBytes) const;
489
490 virtual void commandsAfterCompute (const VkCommandBuffer cmdBuffer,
491 const VkDeviceSize bufferSizeInBytes) const;
492 protected:
493
494 de::MovePtr<Image> m_image;
495 Move<VkImageView> m_imageView;
496 };
497
prepareResources(const VkDeviceSize bufferSizeInBytes)498 void MemoryQualifierInstanceImage::prepareResources (const VkDeviceSize bufferSizeInBytes)
499 {
500 const VkDevice device = m_context.getDevice();
501 const DeviceInterface& deviceInterface = m_context.getDeviceInterface();
502 Allocator& allocator = m_context.getDefaultAllocator();
503
504 // Create image
505 const VkImageCreateInfo imageCreateInfo =
506 {
507 VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO, // VkStructureType sType;
508 DE_NULL, // const void* pNext;
509 m_imageType == IMAGE_TYPE_CUBE ||
510 m_imageType == IMAGE_TYPE_CUBE_ARRAY
511 ? (VkImageCreateFlags)VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT : 0u, // VkImageCreateFlags flags;
512 mapImageType(m_imageType), // VkImageType imageType;
513 mapTextureFormat(m_format), // VkFormat format;
514 makeExtent3D(getLayerSize(m_imageType, m_imageSize)), // VkExtent3D extent;
515 1u, // deUint32 mipLevels;
516 getNumLayers(m_imageType, m_imageSize), // deUint32 arrayLayers;
517 VK_SAMPLE_COUNT_1_BIT, // VkSampleCountFlagBits samples;
518 VK_IMAGE_TILING_OPTIMAL, // VkImageTiling tiling;
519 VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_STORAGE_BIT, // VkImageUsageFlags usage;
520 VK_SHARING_MODE_EXCLUSIVE, // VkSharingMode sharingMode;
521 0u, // deUint32 queueFamilyIndexCount;
522 DE_NULL, // const deUint32* pQueueFamilyIndices;
523 VK_IMAGE_LAYOUT_UNDEFINED, // VkImageLayout initialLayout;
524 };
525
526 m_image = de::MovePtr<Image>(new Image(deviceInterface, device, allocator, imageCreateInfo, MemoryRequirement::Any));
527
528 // Create imageView
529 const VkImageSubresourceRange subresourceRange = makeImageSubresourceRange(VK_IMAGE_ASPECT_COLOR_BIT, 0u, 1u, 0u, getNumLayers(m_imageType, m_imageSize));
530 m_imageView = makeImageView(deviceInterface, device, m_image->get(), mapImageViewType(m_imageType), mapTextureFormat(m_format), subresourceRange);
531
532 // Create a buffer to store shader output (copied from image data)
533 const VkBufferCreateInfo bufferCreateInfo = makeBufferCreateInfo(bufferSizeInBytes, VK_BUFFER_USAGE_TRANSFER_DST_BIT);
534 m_buffer = de::MovePtr<BufferWithMemory>(new BufferWithMemory(deviceInterface, device, allocator, bufferCreateInfo, MemoryRequirement::HostVisible));
535 }
536
prepareDescriptors(void)537 void MemoryQualifierInstanceImage::prepareDescriptors (void)
538 {
539 const VkDevice device = m_context.getDevice();
540 const DeviceInterface& deviceInterface = m_context.getDeviceInterface();
541
542 // Create descriptor pool
543 m_descriptorPool =
544 DescriptorPoolBuilder()
545 .addType(VK_DESCRIPTOR_TYPE_STORAGE_IMAGE)
546 .build(deviceInterface, device, VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT, 1u);
547
548 // Create descriptor set layout
549 m_descriptorSetLayout =
550 DescriptorSetLayoutBuilder()
551 .addSingleBinding(VK_DESCRIPTOR_TYPE_STORAGE_IMAGE, VK_SHADER_STAGE_COMPUTE_BIT)
552 .build(deviceInterface, device);
553
554 // Allocate descriptor set
555 m_descriptorSet = makeDescriptorSet(deviceInterface, device, *m_descriptorPool, *m_descriptorSetLayout);
556
557 // Set the bindings
558 const VkDescriptorImageInfo descriptorImageInfo = makeDescriptorImageInfo(DE_NULL, *m_imageView, VK_IMAGE_LAYOUT_GENERAL);
559
560 DescriptorSetUpdateBuilder()
561 .writeSingle(*m_descriptorSet, DescriptorSetUpdateBuilder::Location::binding(0u), VK_DESCRIPTOR_TYPE_STORAGE_IMAGE, &descriptorImageInfo)
562 .update(deviceInterface, device);
563 }
564
commandsBeforeCompute(const VkCommandBuffer cmdBuffer,const VkDeviceSize bufferSizeInBytes) const565 void MemoryQualifierInstanceImage::commandsBeforeCompute (const VkCommandBuffer cmdBuffer, const VkDeviceSize bufferSizeInBytes) const
566 {
567 DE_UNREF(bufferSizeInBytes);
568
569 const DeviceInterface& deviceInterface = m_context.getDeviceInterface();
570 const VkImageSubresourceRange subresourceRange = makeImageSubresourceRange(VK_IMAGE_ASPECT_COLOR_BIT, 0u, 1u, 0u, getNumLayers(m_imageType, m_imageSize));
571
572 const VkImageMemoryBarrier imageLayoutBarrier
573 = makeImageMemoryBarrier(0u,
574 VK_ACCESS_SHADER_WRITE_BIT,
575 VK_IMAGE_LAYOUT_UNDEFINED,
576 VK_IMAGE_LAYOUT_GENERAL,
577 m_image->get(),
578 subresourceRange);
579
580 deviceInterface.cmdPipelineBarrier(cmdBuffer, VK_PIPELINE_STAGE_HOST_BIT, VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, 0u, 0u, DE_NULL, 0u, DE_NULL, 1u, &imageLayoutBarrier);
581 }
582
commandsAfterCompute(const VkCommandBuffer cmdBuffer,const VkDeviceSize bufferSizeInBytes) const583 void MemoryQualifierInstanceImage::commandsAfterCompute (const VkCommandBuffer cmdBuffer, const VkDeviceSize bufferSizeInBytes) const
584 {
585 const DeviceInterface& deviceInterface = m_context.getDeviceInterface();
586 const VkImageSubresourceRange subresourceRange = makeImageSubresourceRange(VK_IMAGE_ASPECT_COLOR_BIT, 0u, 1u, 0u, getNumLayers(m_imageType, m_imageSize));
587
588 const VkImageMemoryBarrier imagePreCopyBarrier
589 = makeImageMemoryBarrier(VK_ACCESS_SHADER_WRITE_BIT,
590 VK_ACCESS_TRANSFER_READ_BIT,
591 VK_IMAGE_LAYOUT_GENERAL,
592 VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL,
593 m_image->get(),
594 subresourceRange);
595
596 deviceInterface.cmdPipelineBarrier(cmdBuffer, VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, VK_PIPELINE_STAGE_TRANSFER_BIT, 0u, 0u, DE_NULL, 0u, DE_NULL, 1u, &imagePreCopyBarrier);
597
598 const VkBufferImageCopy copyParams = makeBufferImageCopy(makeExtent3D(getLayerSize(m_imageType, m_imageSize)), getNumLayers(m_imageType, m_imageSize));
599 deviceInterface.cmdCopyImageToBuffer(cmdBuffer, m_image->get(), VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, m_buffer->get(), 1u, ©Params);
600
601 const VkBufferMemoryBarrier bufferPostCopyBarrier
602 = makeBufferMemoryBarrier(VK_ACCESS_TRANSFER_WRITE_BIT,
603 VK_ACCESS_HOST_READ_BIT,
604 m_buffer->get(),
605 0ull,
606 bufferSizeInBytes);
607
608 deviceInterface.cmdPipelineBarrier(cmdBuffer, VK_PIPELINE_STAGE_TRANSFER_BIT, VK_PIPELINE_STAGE_HOST_BIT, 0u, 0u, DE_NULL, 1u, &bufferPostCopyBarrier, 0u, DE_NULL);
609 }
610
611 class MemoryQualifierInstanceBuffer : public MemoryQualifierInstanceBase
612 {
613 public:
MemoryQualifierInstanceBuffer(Context & context,const std::string & name,const ImageType imageType,const tcu::UVec3 & imageSize,const tcu::TextureFormat & format)614 MemoryQualifierInstanceBuffer (Context& context,
615 const std::string& name,
616 const ImageType imageType,
617 const tcu::UVec3& imageSize,
618 const tcu::TextureFormat& format)
619 : MemoryQualifierInstanceBase(context, name, imageType, imageSize, format) {}
620
~MemoryQualifierInstanceBuffer(void)621 virtual ~MemoryQualifierInstanceBuffer (void) {}
622
623 virtual void prepareResources (const VkDeviceSize bufferSizeInBytes);
624
625 virtual void prepareDescriptors (void);
626
commandsBeforeCompute(const VkCommandBuffer,const VkDeviceSize) const627 virtual void commandsBeforeCompute (const VkCommandBuffer,
628 const VkDeviceSize) const {}
629
630 virtual void commandsAfterCompute (const VkCommandBuffer cmdBuffer,
631 const VkDeviceSize bufferSizeInBytes) const;
632 protected:
633
634 Move<VkBufferView> m_bufferView;
635 };
636
prepareResources(const VkDeviceSize bufferSizeInBytes)637 void MemoryQualifierInstanceBuffer::prepareResources (const VkDeviceSize bufferSizeInBytes)
638 {
639 const VkDevice device = m_context.getDevice();
640 const DeviceInterface& deviceInterface = m_context.getDeviceInterface();
641 Allocator& allocator = m_context.getDefaultAllocator();
642
643 // Create a buffer to store shader output
644 const VkBufferCreateInfo bufferCreateInfo = makeBufferCreateInfo(bufferSizeInBytes, VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT);
645 m_buffer = de::MovePtr<BufferWithMemory>(new BufferWithMemory(deviceInterface, device, allocator, bufferCreateInfo, MemoryRequirement::HostVisible));
646
647 m_bufferView = makeBufferView(deviceInterface, device, m_buffer->get(), mapTextureFormat(m_format), 0ull, bufferSizeInBytes);
648 }
649
prepareDescriptors(void)650 void MemoryQualifierInstanceBuffer::prepareDescriptors (void)
651 {
652 const VkDevice device = m_context.getDevice();
653 const DeviceInterface& deviceInterface = m_context.getDeviceInterface();
654
655 // Create descriptor pool
656 m_descriptorPool =
657 DescriptorPoolBuilder()
658 .addType(VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER)
659 .build(deviceInterface, device, VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT, 1u);
660
661 // Create descriptor set layout
662 m_descriptorSetLayout =
663 DescriptorSetLayoutBuilder()
664 .addSingleBinding(VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, VK_SHADER_STAGE_COMPUTE_BIT)
665 .build(deviceInterface, device);
666
667 // Allocate descriptor set
668 m_descriptorSet = makeDescriptorSet(deviceInterface, device, *m_descriptorPool, *m_descriptorSetLayout);
669
670 // Set the bindings
671 DescriptorSetUpdateBuilder()
672 .writeSingle(*m_descriptorSet, DescriptorSetUpdateBuilder::Location::binding(0u), VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, &m_bufferView.get())
673 .update(deviceInterface, device);
674 }
675
commandsAfterCompute(const VkCommandBuffer cmdBuffer,const VkDeviceSize bufferSizeInBytes) const676 void MemoryQualifierInstanceBuffer::commandsAfterCompute (const VkCommandBuffer cmdBuffer, const VkDeviceSize bufferSizeInBytes) const
677 {
678 const DeviceInterface& deviceInterface = m_context.getDeviceInterface();
679
680 const VkBufferMemoryBarrier shaderWriteBarrier
681 = makeBufferMemoryBarrier(VK_ACCESS_SHADER_WRITE_BIT,
682 VK_ACCESS_HOST_READ_BIT,
683 m_buffer->get(),
684 0ull,
685 bufferSizeInBytes);
686
687 deviceInterface.cmdPipelineBarrier(cmdBuffer, VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, VK_PIPELINE_STAGE_HOST_BIT, 0u, 0u, DE_NULL, 1u, &shaderWriteBarrier, 0u, DE_NULL);
688 }
689
createInstance(Context & context) const690 TestInstance* MemoryQualifierTestCase::createInstance (Context& context) const
691 {
692 if ( m_imageType == IMAGE_TYPE_BUFFER )
693 return new MemoryQualifierInstanceBuffer(context, m_name, m_imageType, m_imageSize, m_format);
694 else
695 return new MemoryQualifierInstanceImage(context, m_name, m_imageType, m_imageSize, m_format);
696 }
697
698 } // anonymous ns
699
createImageQualifiersTests(tcu::TestContext & testCtx)700 tcu::TestCaseGroup* createImageQualifiersTests (tcu::TestContext& testCtx)
701 {
702 // Coherent, volatile and restrict
703 de::MovePtr<tcu::TestCaseGroup> imageQualifiersTests(new tcu::TestCaseGroup(testCtx, "qualifiers"));
704
705 struct ImageParams
706 {
707 ImageParams(const ImageType imageType, const tcu::UVec3& imageSize)
708 : m_imageType (imageType)
709 , m_imageSize (imageSize)
710 {
711 }
712 ImageType m_imageType;
713 tcu::UVec3 m_imageSize;
714 };
715
716 static const ImageParams imageParamsArray[] =
717 {
718 ImageParams(IMAGE_TYPE_1D, tcu::UVec3(64u, 1u, 1u)),
719 ImageParams(IMAGE_TYPE_1D_ARRAY, tcu::UVec3(64u, 1u, 8u)),
720 ImageParams(IMAGE_TYPE_2D, tcu::UVec3(64u, 64u, 1u)),
721 ImageParams(IMAGE_TYPE_2D_ARRAY, tcu::UVec3(64u, 64u, 8u)),
722 ImageParams(IMAGE_TYPE_3D, tcu::UVec3(64u, 64u, 8u)),
723 ImageParams(IMAGE_TYPE_CUBE, tcu::UVec3(64u, 64u, 1u)),
724 ImageParams(IMAGE_TYPE_CUBE_ARRAY, tcu::UVec3(64u, 64u, 2u)),
725 ImageParams(IMAGE_TYPE_BUFFER, tcu::UVec3(64u, 1u, 1u))
726 };
727
728 static const tcu::TextureFormat formats[] =
729 {
730 tcu::TextureFormat(tcu::TextureFormat::R, tcu::TextureFormat::FLOAT),
731 tcu::TextureFormat(tcu::TextureFormat::R, tcu::TextureFormat::UNSIGNED_INT32),
732 tcu::TextureFormat(tcu::TextureFormat::R, tcu::TextureFormat::SIGNED_INT32),
733 };
734
735 for (deUint32 qualifierI = 0; qualifierI < MemoryQualifierTestCase::QUALIFIER_LAST; ++qualifierI)
736 {
737 const MemoryQualifierTestCase::Qualifier memoryQualifier = (MemoryQualifierTestCase::Qualifier)qualifierI;
738 const char* const memoryQualifierName =
739 memoryQualifier == MemoryQualifierTestCase::QUALIFIER_COHERENT ? "coherent" :
740 memoryQualifier == MemoryQualifierTestCase::QUALIFIER_VOLATILE ? "volatile" :
741 memoryQualifier == MemoryQualifierTestCase::QUALIFIER_RESTRICT ? "restrict" :
742 DE_NULL;
743
744 de::MovePtr<tcu::TestCaseGroup> qualifierGroup(new tcu::TestCaseGroup(testCtx, memoryQualifierName));
745
746 for (deInt32 imageTypeNdx = 0; imageTypeNdx < DE_LENGTH_OF_ARRAY(imageParamsArray); imageTypeNdx++)
747 {
748 const ImageType imageType = imageParamsArray[imageTypeNdx].m_imageType;
749 const tcu::UVec3 imageSize = imageParamsArray[imageTypeNdx].m_imageSize;
750
751 if (memoryQualifier == MemoryQualifierTestCase::QUALIFIER_RESTRICT)
752 {
753 de::MovePtr<TestCase> restrictCase = createImageQualifierRestrictCase(testCtx, imageType, getImageTypeName(imageType));
754 qualifierGroup->addChild(restrictCase.release());
755 }
756 else
757 {
758 de::MovePtr<tcu::TestCaseGroup> imageTypeGroup(new tcu::TestCaseGroup(testCtx, getImageTypeName(imageType).c_str()));
759
760 for (deInt32 formatNdx = 0; formatNdx < DE_LENGTH_OF_ARRAY(formats); formatNdx++)
761 {
762 const tcu::TextureFormat& format = formats[formatNdx];
763 const std::string formatName = getShaderImageFormatQualifier(formats[formatNdx]);
764
765 imageTypeGroup->addChild(
766 new MemoryQualifierTestCase(testCtx, formatName, memoryQualifier, imageType, imageSize, format, glu::GLSL_VERSION_440));
767 }
768
769 qualifierGroup->addChild(imageTypeGroup.release());
770 }
771 }
772
773 imageQualifiersTests->addChild(qualifierGroup.release());
774 }
775
776 return imageQualifiersTests.release();
777 }
778
779 } // image
780 } // vkt
781