Searched refs:review (Results 1 – 25 of 273) sorted by relevance
1234567891011
| /external/swiftshader/third_party/llvm-7.0/llvm/docs/ |
| D | Phabricator.rst | 12 is the system of record for all LLVM code review. The mailing list should be
31 Requesting a review via the command line
41 .. _phabricator-request-review-web:
43 Requesting a review via the web interface
46 The tool to create and review patches in Phabricator is called
52 will automatically send a diff with a smaller context in the review
69 later, when sending the review.)
77 etc.) to which the review should be sent.
85 * Select the review you want to from the *Attach To* dropdown and click
88 for the review request.)
[all …]
|
| D | Contributing.rst | 60 Please follow :ref:`Phabricator#requesting-a-review-via-the-web-interface <phabricator-request-rev…
61 to request a review using Phabricator.
64 and add them to your patch when requesting a review. Suitable reviewers are the
67 when creating a review and if you are using `llvm-commits`, add them to the CC of
70 A reviewer may request changes or ask questions during the review. If you are
72 for guidance during the review. Please address the feedback and re-post an
76 access, please let people know during the review and someone should commit it
80 review by 'ping'ing a patch by responding to the email thread containing the
81 patch, or the Phabricator review with "Ping." The common courtesy 'ping' rate
|
| D | DeveloperPolicy.rst | 80 When making a patch for review, the goal is to make it as easy for the reviewer
123 .. _code review:
128 LLVM has a code review policy. Code review is one way to increase the quality of
142 all necessary review-related changes.
144 #. Code review can be an iterative process, which continues until the patch is
145 ready to be committed. Specifically, once a patch is sent out for review, it
150 larger features. Accepted ways to speed up review times for your patches are:
165 reviewees. If someone is kind enough to review your code, you should return the
166 favor for someone else. Note that anyone is welcome to review and give feedback
169 There is a web based code review tool that can optionally be used
[all …]
|
| /external/llvm/docs/ |
| D | Phabricator.rst | 12 is the system of record for all LLVM code review. The mailing list should be
31 Requesting a review via the command line
41 Requesting a review via the web interface
44 The tool to create and review patches in Phabricator is called
50 will automatically send a diff with a smaller context in the review
70 lists that you want to be included in the review. If your patch is
81 * Select the review you want to from the *Attach To* dropdown and click
102 responsibility for making sure the review happens.
123 when a review changes state, for example by clicking "Accept Revision" in
138 where ``<URL>`` is the URL for the code review, starting with
[all …]
|
| D | DeveloperPolicy.rst | 80 When making a patch for review, the goal is to make it as easy for the reviewer
123 .. _code review:
128 LLVM has a code review policy. Code review is one way to increase the quality of
142 all necessary review-related changes.
144 #. Code review can be an iterative process, which continues until the patch is
145 ready to be committed. Specifically, once a patch is sent out for review, it
150 larger features. Accepted ways to speed up review times for your patches are:
165 reviewees. If someone is kind enough to review your code, you should return the
166 favor for someone else. Note that anyone is welcome to review and give feedback
169 There is a web based code review tool that can optionally be used
[all …]
|
| /external/swiftshader/third_party/llvm-7.0/llvm/utils/Reviewing/ |
| D | find_interesting_reviews.py | 367 for review in newest_reviews:
368 if datetime.fromtimestamp(review.dateModified) < cut_off_date:
370 result.append(review)
411 for i, review in enumerate(newest_reviews):
412 matched_reviewers = find_reviewers_for_review(review)
418 i, review.id,
419 get_real_name_from_author(review.author), review.title,
420 datetime.fromtimestamp(review.dateModified)))
427 reviewer2reviews_and_scores[reviewer].append((review, scores))
435 for review, scores in reviews_and_scores:
[all …]
|
| /external/skia/site/dev/contrib/ |
| D | submit.md | 65 review! Submit a patch and getting it reviewed is fairly easy with depot tools.
77 ### Uploading changes for review
79 Skia uses the Gerrit code review tool. Skia's instance is [skia-review](http://skia-review.googleso…
92 (https://skia-review.googlesource.com/c/4559/), indicating where your changelist
99 ask a committer. After uploading your CL to [Gerrit](https://skia-review.googlesource.com/),
116 ### Request review
118 Go to the supplied URL or go to the code review page and select the **Your**
120 review and click **Reply**. Enter at least one reviewer's email address. Now
121 add any optional notes, and send your change off for review by clicking on
125 _Note_: If you don't see editing commands on the review page, click **Sign in**
[all …]
|
| D | index.md | 26 you will need a committer to review and approve the change. There are some steps that
27 can speed up the review process:
29 When possible, have a fellow contributor review your change in advance of submission.
|
| /external/skqp/site/dev/contrib/ |
| D | submit.md | 65 review! Submit a patch and getting it reviewed is fairly easy with depot tools.
77 ### Uploading changes for review
79 Skia uses the Gerrit code review tool. Skia's instance is [skia-review](http://skia-review.googleso…
92 (https://skia-review.googlesource.com/c/4559/), indicating where your changelist
99 ask a committer. After uploading your CL to [Gerrit](https://skia-review.googlesource.com/),
116 ### Request review
118 Go to the supplied URL or go to the code review page and select the **Your**
120 review and click **Reply**. Enter at least one reviewer's email address. Now
121 add any optional notes, and send your change off for review by clicking on
125 _Note_: If you don't see editing commands on the review page, click **Sign in**
[all …]
|
| D | index.md | 26 you will need a committer to review and approve the change. There are some steps that
27 can speed up the review process:
29 When possible, have a fellow contributor review your change in advance of submission.
|
| /external/boringssl/src/ |
| D | CONTRIBUTING.md | 11 the CLA until after you've submitted your code for review and a member has
18 All submissions, including submissions by project members, require review. We
19 use [Gerrit](https://boringssl-review.googlesource.com) for this purpose.
26 [add Change-Ids](https://gerrit-review.googlesource.com/Documentation/cmd-hook-commit-msg.html)
29 curl -Lo .git/hooks/commit-msg https://boringssl-review.googlesource.com/tools/hooks/commit-msg
44 [Gerrit User Guide](https://gerrit-review.googlesource.com/Documentation/intro-user.html).
|
| /external/swiftshader/ |
| D | README.md | 46 All changes must be reviewed and approved in the [Gerrit](https://www.gerritcodereview.com/) review…
47 https://swiftshader-review.googlesource.com
50 https://swiftshader-review.googlesource.com/new-password
52 All changes require a [Change-ID](https://gerrit-review.googlesource.com/Documentation/user-changei…
53 https://gerrit-review.googlesource.com/tools/hooks/commit-msg. To clone the repository and install …
55 …er && curl -Lo `git rev-parse --git-dir`/hooks/commit-msg https://gerrit-review.googlesource.com/t…
75 …ME.rst) instructions, reviewed at [https://chromium-review.googlesource.com](https://chromium-revi…
|
| D | CONTRIBUTING.txt | 12 the CLA until after you've submitted your code for review and a member has
20 All submissions, including submissions by project members, require review.
22 Information on how to sumbit changes for review is provided in README.md.
|
| /external/volley/ |
| D | CONTRIBUTING.md | 21 All submissions, including submissions by project members, require review. We
27 ## Preparing a pull request for review
41 Please correct any failures before requesting a review.
|
| /external/bcc/ |
| D | CODEOWNERS | 3 # review code that touches the respective areas, and MUST review it if the
|
| /external/syzkaller/vendor/google.golang.org/grpc/ |
| D | CONTRIBUTING.md | 15 …ne fix is considered acceptable, nothing gets merged and both author's & review's time is wasted. …
25 …review and won't be merged. Use `rebase -i upstream/master` to curate your commit history and/or t…
|
| /external/perf_data_converter/ |
| D | CONTRIBUTING | 12 the CLA until after you've submitted your code for review and a member has
20 All submissions, including submissions by project members, require review. We
|
| /external/drrickorang/LoopbackApp/ |
| D | CONTRIBUTING | 12 the CLA until after you've submitted your code for review and a member has
20 All submissions, including submissions by project members, require review. We
|
| /external/google-breakpad/ |
| D | README | 16 To request change review:
39 6. When applying code review feedback, specify the '-i' option when running
|
| /external/honggfuzz/ |
| D | CONTRIBUTING | 11 the CLA until after you've submitted your code for review and a member has
19 All submissions, including submissions by project members, require review. We
|
| /external/syzkaller/vendor/github.com/googleapis/gax-go/ |
| D | CONTRIBUTING.md | 12 the CLA until after you've submitted your code for review and a member has
20 All submissions, including submissions by project members, require review. We
|
| /external/libprotobuf-mutator/ |
| D | CONTRIBUTING | 12 the CLA until after you've submitted your code for review and a member has
20 All submissions, including submissions by project members, require review. We
|
| /external/brotli/ |
| D | CONTRIBUTING.md | 13 the CLA until after you've submitted your code for review and a member has
21 All submissions, including submissions by project members, require review. We
|
| /external/walt/ |
| D | CONTRIBUTING.md | 12 the CLA until after you've submitted your code for review and a member has
20 All submissions, including submissions by project members, require review. We
|
| /external/perfetto/docs/ |
| D | security-model.md | 37 … [Proof of concept](https://android-review.googlesource.com/c/platform/external/perfetto/+/576563)
70 * [Android security review doc](http://go/perfetto-asec)
71 * [Chromium security review doc](http://go/perfetto-csec)
|
1234567891011