• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 // Copyright (c) 2017 Valve Corporation
2 // Copyright (c) 2017 LunarG Inc.
3 //
4 // Licensed under the Apache License, Version 2.0 (the "License");
5 // you may not use this file except in compliance with the License.
6 // You may obtain a copy of the License at
7 //
8 //     http://www.apache.org/licenses/LICENSE-2.0
9 //
10 // Unless required by applicable law or agreed to in writing, software
11 // distributed under the License is distributed on an "AS IS" BASIS,
12 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 // See the License for the specific language governing permissions and
14 // limitations under the License.
15 
16 #include <memory>
17 #include <string>
18 
19 #include "test/opt/pass_fixture.h"
20 #include "test/opt/pass_utils.h"
21 
22 namespace spvtools {
23 namespace opt {
24 namespace {
25 
26 using LocalSSAElimTest = PassTest<::testing::Test>;
27 
TEST_F(LocalSSAElimTest,ForLoop)28 TEST_F(LocalSSAElimTest, ForLoop) {
29   // #version 140
30   //
31   // in vec4 BC;
32   // out float fo;
33   //
34   // void main()
35   // {
36   //     float f = 0.0;
37   //     for (int i=0; i<4; i++) {
38   //       f = f + BC[i];
39   //     }
40   //     fo = f;
41   // }
42 
43   const std::string predefs =
44       R"(OpCapability Shader
45 %1 = OpExtInstImport "GLSL.std.450"
46 OpMemoryModel Logical GLSL450
47 OpEntryPoint Fragment %main "main" %BC %fo
48 OpExecutionMode %main OriginUpperLeft
49 OpSource GLSL 140
50 OpName %main "main"
51 OpName %f "f"
52 OpName %i "i"
53 OpName %BC "BC"
54 OpName %fo "fo"
55 %void = OpTypeVoid
56 %8 = OpTypeFunction %void
57 %float = OpTypeFloat 32
58 %_ptr_Function_float = OpTypePointer Function %float
59 %float_0 = OpConstant %float 0
60 %int = OpTypeInt 32 1
61 %_ptr_Function_int = OpTypePointer Function %int
62 %int_0 = OpConstant %int 0
63 %int_4 = OpConstant %int 4
64 %bool = OpTypeBool
65 %v4float = OpTypeVector %float 4
66 %_ptr_Input_v4float = OpTypePointer Input %v4float
67 %BC = OpVariable %_ptr_Input_v4float Input
68 %_ptr_Input_float = OpTypePointer Input %float
69 %int_1 = OpConstant %int 1
70 %_ptr_Output_float = OpTypePointer Output %float
71 %fo = OpVariable %_ptr_Output_float Output
72 )";
73 
74   const std::string before =
75       R"(%main = OpFunction %void None %8
76 %22 = OpLabel
77 %f = OpVariable %_ptr_Function_float Function
78 %i = OpVariable %_ptr_Function_int Function
79 OpStore %f %float_0
80 OpStore %i %int_0
81 OpBranch %23
82 %23 = OpLabel
83 OpLoopMerge %24 %25 None
84 OpBranch %26
85 %26 = OpLabel
86 %27 = OpLoad %int %i
87 %28 = OpSLessThan %bool %27 %int_4
88 OpBranchConditional %28 %29 %24
89 %29 = OpLabel
90 %30 = OpLoad %float %f
91 %31 = OpLoad %int %i
92 %32 = OpAccessChain %_ptr_Input_float %BC %31
93 %33 = OpLoad %float %32
94 %34 = OpFAdd %float %30 %33
95 OpStore %f %34
96 OpBranch %25
97 %25 = OpLabel
98 %35 = OpLoad %int %i
99 %36 = OpIAdd %int %35 %int_1
100 OpStore %i %36
101 OpBranch %23
102 %24 = OpLabel
103 %37 = OpLoad %float %f
104 OpStore %fo %37
105 OpReturn
106 OpFunctionEnd
107 )";
108 
109   const std::string after =
110       R"(%main = OpFunction %void None %8
111 %22 = OpLabel
112 %f = OpVariable %_ptr_Function_float Function
113 %i = OpVariable %_ptr_Function_int Function
114 OpStore %f %float_0
115 OpStore %i %int_0
116 OpBranch %23
117 %23 = OpLabel
118 %39 = OpPhi %float %float_0 %22 %34 %25
119 %38 = OpPhi %int %int_0 %22 %36 %25
120 OpLoopMerge %24 %25 None
121 OpBranch %26
122 %26 = OpLabel
123 %28 = OpSLessThan %bool %38 %int_4
124 OpBranchConditional %28 %29 %24
125 %29 = OpLabel
126 %32 = OpAccessChain %_ptr_Input_float %BC %38
127 %33 = OpLoad %float %32
128 %34 = OpFAdd %float %39 %33
129 OpStore %f %34
130 OpBranch %25
131 %25 = OpLabel
132 %36 = OpIAdd %int %38 %int_1
133 OpStore %i %36
134 OpBranch %23
135 %24 = OpLabel
136 OpStore %fo %39
137 OpReturn
138 OpFunctionEnd
139 )";
140 
141   SinglePassRunAndCheck<SSARewritePass>(predefs + before, predefs + after, true,
142                                         true);
143 }
144 
TEST_F(LocalSSAElimTest,NestedForLoop)145 TEST_F(LocalSSAElimTest, NestedForLoop) {
146   // #version 450
147   //
148   // layout (location=0) in mat4 BC;
149   // layout (location=0) out float fo;
150   //
151   // void main()
152   // {
153   //     float f = 0.0;
154   //     for (int i=0; i<4; i++)
155   //       for (int j=0; j<4; j++)
156   //         f = f + BC[i][j];
157   //     fo = f;
158   // }
159 
160   const std::string predefs =
161       R"(OpCapability Shader
162 %1 = OpExtInstImport "GLSL.std.450"
163 OpMemoryModel Logical GLSL450
164 OpEntryPoint Fragment %main "main" %BC %fo
165 OpExecutionMode %main OriginUpperLeft
166 OpSource GLSL 450
167 OpName %main "main"
168 OpName %f "f"
169 OpName %i "i"
170 OpName %j "j"
171 OpName %BC "BC"
172 OpName %fo "fo"
173 OpDecorate %BC Location 0
174 OpDecorate %fo Location 0
175 %void = OpTypeVoid
176 %9 = OpTypeFunction %void
177 %float = OpTypeFloat 32
178 %_ptr_Function_float = OpTypePointer Function %float
179 %float_0 = OpConstant %float 0
180 %int = OpTypeInt 32 1
181 %_ptr_Function_int = OpTypePointer Function %int
182 %int_0 = OpConstant %int 0
183 %int_4 = OpConstant %int 4
184 %bool = OpTypeBool
185 %v4float = OpTypeVector %float 4
186 %mat4v4float = OpTypeMatrix %v4float 4
187 %_ptr_Input_mat4v4float = OpTypePointer Input %mat4v4float
188 %BC = OpVariable %_ptr_Input_mat4v4float Input
189 %_ptr_Input_float = OpTypePointer Input %float
190 %int_1 = OpConstant %int 1
191 %_ptr_Output_float = OpTypePointer Output %float
192 %fo = OpVariable %_ptr_Output_float Output
193 )";
194 
195   const std::string before =
196       R"(
197 ; CHECK: = OpFunction
198 ; CHECK-NEXT: [[entry:%\w+]] = OpLabel
199 ; CHECK: [[outer_header:%\w+]] = OpLabel
200 ; CHECK-NEXT: [[outer_f:%\w+]] = OpPhi %float %float_0 [[entry]] [[inner_f:%\w+]] [[outer_be:%\w+]]
201 ; CHECK-NEXT: [[i:%\w+]] = OpPhi %int %int_0 [[entry]] [[i_next:%\w+]] [[outer_be]]
202 ; CHECK-NEXT: OpSLessThan {{%\w+}} [[i]]
203 ; CHECK: [[inner_pre_header:%\w+]] = OpLabel
204 ; CHECK: [[inner_header:%\w+]] = OpLabel
205 ; CHECK-NEXT: [[inner_f]] = OpPhi %float [[outer_f]] [[inner_pre_header]] [[f_next:%\w+]] [[inner_be:%\w+]]
206 ; CHECK-NEXT: [[j:%\w+]] = OpPhi %int %int_0 [[inner_pre_header]] [[j_next:%\w+]] [[inner_be]]
207 ; CHECK: [[inner_be]] = OpLabel
208 ; CHECK: [[f_next]] = OpFAdd %float [[inner_f]]
209 ; CHECK: [[j_next]] = OpIAdd %int [[j]] %int_1
210 ; CHECK: [[outer_be]] = OpLabel
211 ; CHECK: [[i_next]] = OpIAdd
212 ; CHECK: OpStore %fo [[outer_f]]
213 %main = OpFunction %void None %9
214 %24 = OpLabel
215 %f = OpVariable %_ptr_Function_float Function
216 %i = OpVariable %_ptr_Function_int Function
217 %j = OpVariable %_ptr_Function_int Function
218 OpStore %f %float_0
219 OpStore %i %int_0
220 OpBranch %25
221 %25 = OpLabel
222 %26 = OpLoad %int %i
223 %27 = OpSLessThan %bool %26 %int_4
224 OpLoopMerge %28 %29 None
225 OpBranchConditional %27 %30 %28
226 %30 = OpLabel
227 OpStore %j %int_0
228 OpBranch %31
229 %31 = OpLabel
230 %32 = OpLoad %int %j
231 %33 = OpSLessThan %bool %32 %int_4
232 OpLoopMerge %50 %34 None
233 OpBranchConditional %33 %34 %50
234 %34 = OpLabel
235 %35 = OpLoad %float %f
236 %36 = OpLoad %int %i
237 %37 = OpLoad %int %j
238 %38 = OpAccessChain %_ptr_Input_float %BC %36 %37
239 %39 = OpLoad %float %38
240 %40 = OpFAdd %float %35 %39
241 OpStore %f %40
242 %41 = OpLoad %int %j
243 %42 = OpIAdd %int %41 %int_1
244 OpStore %j %42
245 OpBranch %31
246 %50 = OpLabel
247 OpBranch %29
248 %29 = OpLabel
249 %43 = OpLoad %int %i
250 %44 = OpIAdd %int %43 %int_1
251 OpStore %i %44
252 OpBranch %25
253 %28 = OpLabel
254 %45 = OpLoad %float %f
255 OpStore %fo %45
256 OpReturn
257 OpFunctionEnd
258 )";
259 
260   SinglePassRunAndMatch<SSARewritePass>(predefs + before, true);
261 }
262 
TEST_F(LocalSSAElimTest,ForLoopWithContinue)263 TEST_F(LocalSSAElimTest, ForLoopWithContinue) {
264   // #version 140
265   //
266   // in vec4 BC;
267   // out float fo;
268   //
269   // void main()
270   // {
271   //     float f = 0.0;
272   //     for (int i=0; i<4; i++) {
273   //       float t = BC[i];
274   //       if (t < 0.0)
275   //         continue;
276   //       f = f + t;
277   //     }
278   //     fo = f;
279   // }
280 
281   const std::string predefs =
282       R"(OpCapability Shader
283 %1 = OpExtInstImport "GLSL.std.450"
284 OpMemoryModel Logical GLSL450
285 OpEntryPoint Fragment %main "main" %BC %fo
286 OpExecutionMode %main OriginUpperLeft
287 OpSource GLSL 140
288 )";
289 
290   const std::string names =
291       R"(OpName %main "main"
292 OpName %f "f"
293 OpName %i "i"
294 OpName %t "t"
295 OpName %BC "BC"
296 OpName %fo "fo"
297 )";
298 
299   const std::string predefs2 =
300       R"(%void = OpTypeVoid
301 %9 = OpTypeFunction %void
302 %float = OpTypeFloat 32
303 %_ptr_Function_float = OpTypePointer Function %float
304 %float_0 = OpConstant %float 0
305 %int = OpTypeInt 32 1
306 %_ptr_Function_int = OpTypePointer Function %int
307 %int_0 = OpConstant %int 0
308 %int_4 = OpConstant %int 4
309 %bool = OpTypeBool
310 %v4float = OpTypeVector %float 4
311 %_ptr_Input_v4float = OpTypePointer Input %v4float
312 %BC = OpVariable %_ptr_Input_v4float Input
313 %_ptr_Input_float = OpTypePointer Input %float
314 %int_1 = OpConstant %int 1
315 %_ptr_Output_float = OpTypePointer Output %float
316 %fo = OpVariable %_ptr_Output_float Output
317 )";
318 
319   const std::string before =
320       R"(%main = OpFunction %void None %9
321 %23 = OpLabel
322 %f = OpVariable %_ptr_Function_float Function
323 %i = OpVariable %_ptr_Function_int Function
324 %t = OpVariable %_ptr_Function_float Function
325 OpStore %f %float_0
326 OpStore %i %int_0
327 OpBranch %24
328 %24 = OpLabel
329 OpLoopMerge %25 %26 None
330 OpBranch %27
331 %27 = OpLabel
332 %28 = OpLoad %int %i
333 %29 = OpSLessThan %bool %28 %int_4
334 OpBranchConditional %29 %30 %25
335 %30 = OpLabel
336 %31 = OpLoad %int %i
337 %32 = OpAccessChain %_ptr_Input_float %BC %31
338 %33 = OpLoad %float %32
339 OpStore %t %33
340 %34 = OpLoad %float %t
341 %35 = OpFOrdLessThan %bool %34 %float_0
342 OpSelectionMerge %36 None
343 OpBranchConditional %35 %37 %36
344 %37 = OpLabel
345 OpBranch %26
346 %36 = OpLabel
347 %38 = OpLoad %float %f
348 %39 = OpLoad %float %t
349 %40 = OpFAdd %float %38 %39
350 OpStore %f %40
351 OpBranch %26
352 %26 = OpLabel
353 %41 = OpLoad %int %i
354 %42 = OpIAdd %int %41 %int_1
355 OpStore %i %42
356 OpBranch %24
357 %25 = OpLabel
358 %43 = OpLoad %float %f
359 OpStore %fo %43
360 OpReturn
361 OpFunctionEnd
362 )";
363 
364   const std::string after =
365       R"(%main = OpFunction %void None %9
366 %23 = OpLabel
367 %f = OpVariable %_ptr_Function_float Function
368 %i = OpVariable %_ptr_Function_int Function
369 %t = OpVariable %_ptr_Function_float Function
370 OpStore %f %float_0
371 OpStore %i %int_0
372 OpBranch %24
373 %24 = OpLabel
374 %45 = OpPhi %float %float_0 %23 %47 %26
375 %44 = OpPhi %int %int_0 %23 %42 %26
376 OpLoopMerge %25 %26 None
377 OpBranch %27
378 %27 = OpLabel
379 %29 = OpSLessThan %bool %44 %int_4
380 OpBranchConditional %29 %30 %25
381 %30 = OpLabel
382 %32 = OpAccessChain %_ptr_Input_float %BC %44
383 %33 = OpLoad %float %32
384 OpStore %t %33
385 %35 = OpFOrdLessThan %bool %33 %float_0
386 OpSelectionMerge %36 None
387 OpBranchConditional %35 %37 %36
388 %37 = OpLabel
389 OpBranch %26
390 %36 = OpLabel
391 %40 = OpFAdd %float %45 %33
392 OpStore %f %40
393 OpBranch %26
394 %26 = OpLabel
395 %47 = OpPhi %float %45 %37 %40 %36
396 %42 = OpIAdd %int %44 %int_1
397 OpStore %i %42
398 OpBranch %24
399 %25 = OpLabel
400 OpStore %fo %45
401 OpReturn
402 OpFunctionEnd
403 )";
404 
405   SinglePassRunAndCheck<SSARewritePass>(predefs + names + predefs2 + before,
406                                         predefs + names + predefs2 + after,
407                                         true, true);
408 }
409 
TEST_F(LocalSSAElimTest,ForLoopWithBreak)410 TEST_F(LocalSSAElimTest, ForLoopWithBreak) {
411   // #version 140
412   //
413   // in vec4 BC;
414   // out float fo;
415   //
416   // void main()
417   // {
418   //     float f = 0.0;
419   //     for (int i=0; i<4; i++) {
420   //       float t = f + BC[i];
421   //       if (t > 1.0)
422   //         break;
423   //       f = t;
424   //     }
425   //     fo = f;
426   // }
427 
428   const std::string predefs =
429       R"(OpCapability Shader
430 %1 = OpExtInstImport "GLSL.std.450"
431 OpMemoryModel Logical GLSL450
432 OpEntryPoint Fragment %main "main" %BC %fo
433 OpExecutionMode %main OriginUpperLeft
434 OpSource GLSL 140
435 OpName %main "main"
436 OpName %f "f"
437 OpName %i "i"
438 OpName %t "t"
439 OpName %BC "BC"
440 OpName %fo "fo"
441 %void = OpTypeVoid
442 %9 = OpTypeFunction %void
443 %float = OpTypeFloat 32
444 %_ptr_Function_float = OpTypePointer Function %float
445 %float_0 = OpConstant %float 0
446 %int = OpTypeInt 32 1
447 %_ptr_Function_int = OpTypePointer Function %int
448 %int_0 = OpConstant %int 0
449 %int_4 = OpConstant %int 4
450 %bool = OpTypeBool
451 %v4float = OpTypeVector %float 4
452 %_ptr_Input_v4float = OpTypePointer Input %v4float
453 %BC = OpVariable %_ptr_Input_v4float Input
454 %_ptr_Input_float = OpTypePointer Input %float
455 %float_1 = OpConstant %float 1
456 %int_1 = OpConstant %int 1
457 %_ptr_Output_float = OpTypePointer Output %float
458 %fo = OpVariable %_ptr_Output_float Output
459 )";
460 
461   const std::string before =
462       R"(%main = OpFunction %void None %9
463 %24 = OpLabel
464 %f = OpVariable %_ptr_Function_float Function
465 %i = OpVariable %_ptr_Function_int Function
466 %t = OpVariable %_ptr_Function_float Function
467 OpStore %f %float_0
468 OpStore %i %int_0
469 OpBranch %25
470 %25 = OpLabel
471 OpLoopMerge %26 %27 None
472 OpBranch %28
473 %28 = OpLabel
474 %29 = OpLoad %int %i
475 %30 = OpSLessThan %bool %29 %int_4
476 OpBranchConditional %30 %31 %26
477 %31 = OpLabel
478 %32 = OpLoad %float %f
479 %33 = OpLoad %int %i
480 %34 = OpAccessChain %_ptr_Input_float %BC %33
481 %35 = OpLoad %float %34
482 %36 = OpFAdd %float %32 %35
483 OpStore %t %36
484 %37 = OpLoad %float %t
485 %38 = OpFOrdGreaterThan %bool %37 %float_1
486 OpSelectionMerge %39 None
487 OpBranchConditional %38 %40 %39
488 %40 = OpLabel
489 OpBranch %26
490 %39 = OpLabel
491 %41 = OpLoad %float %t
492 OpStore %f %41
493 OpBranch %27
494 %27 = OpLabel
495 %42 = OpLoad %int %i
496 %43 = OpIAdd %int %42 %int_1
497 OpStore %i %43
498 OpBranch %25
499 %26 = OpLabel
500 %44 = OpLoad %float %f
501 OpStore %fo %44
502 OpReturn
503 OpFunctionEnd
504 )";
505 
506   const std::string after =
507       R"(%main = OpFunction %void None %9
508 %24 = OpLabel
509 %f = OpVariable %_ptr_Function_float Function
510 %i = OpVariable %_ptr_Function_int Function
511 %t = OpVariable %_ptr_Function_float Function
512 OpStore %f %float_0
513 OpStore %i %int_0
514 OpBranch %25
515 %25 = OpLabel
516 %46 = OpPhi %float %float_0 %24 %36 %27
517 %45 = OpPhi %int %int_0 %24 %43 %27
518 OpLoopMerge %26 %27 None
519 OpBranch %28
520 %28 = OpLabel
521 %30 = OpSLessThan %bool %45 %int_4
522 OpBranchConditional %30 %31 %26
523 %31 = OpLabel
524 %34 = OpAccessChain %_ptr_Input_float %BC %45
525 %35 = OpLoad %float %34
526 %36 = OpFAdd %float %46 %35
527 OpStore %t %36
528 %38 = OpFOrdGreaterThan %bool %36 %float_1
529 OpSelectionMerge %39 None
530 OpBranchConditional %38 %40 %39
531 %40 = OpLabel
532 OpBranch %26
533 %39 = OpLabel
534 OpStore %f %36
535 OpBranch %27
536 %27 = OpLabel
537 %43 = OpIAdd %int %45 %int_1
538 OpStore %i %43
539 OpBranch %25
540 %26 = OpLabel
541 OpStore %fo %46
542 OpReturn
543 OpFunctionEnd
544 )";
545 
546   SinglePassRunAndCheck<SSARewritePass>(predefs + before, predefs + after, true,
547                                         true);
548 }
549 
TEST_F(LocalSSAElimTest,SwapProblem)550 TEST_F(LocalSSAElimTest, SwapProblem) {
551   // #version 140
552   //
553   // in float fe;
554   // out float fo;
555   //
556   // void main()
557   // {
558   //     float f1 = 0.0;
559   //     float f2 = 1.0;
560   //     int ie = int(fe);
561   //     for (int i=0; i<ie; i++) {
562   //       float t = f1;
563   //       f1 = f2;
564   //       f2 = t;
565   //     }
566   //     fo = f1;
567   // }
568 
569   const std::string predefs =
570       R"(OpCapability Shader
571 %1 = OpExtInstImport "GLSL.std.450"
572 OpMemoryModel Logical GLSL450
573 OpEntryPoint Fragment %main "main" %fe %fo
574 OpExecutionMode %main OriginUpperLeft
575 OpSource GLSL 140
576 OpName %main "main"
577 OpName %f1 "f1"
578 OpName %f2 "f2"
579 OpName %ie "ie"
580 OpName %fe "fe"
581 OpName %i "i"
582 OpName %t "t"
583 OpName %fo "fo"
584 %void = OpTypeVoid
585 %11 = OpTypeFunction %void
586 %float = OpTypeFloat 32
587 %_ptr_Function_float = OpTypePointer Function %float
588 %float_0 = OpConstant %float 0
589 %float_1 = OpConstant %float 1
590 %int = OpTypeInt 32 1
591 %_ptr_Function_int = OpTypePointer Function %int
592 %_ptr_Input_float = OpTypePointer Input %float
593 %fe = OpVariable %_ptr_Input_float Input
594 %int_0 = OpConstant %int 0
595 %bool = OpTypeBool
596 %int_1 = OpConstant %int 1
597 %_ptr_Output_float = OpTypePointer Output %float
598 %fo = OpVariable %_ptr_Output_float Output
599 )";
600 
601   const std::string before =
602       R"(%main = OpFunction %void None %11
603 %23 = OpLabel
604 %f1 = OpVariable %_ptr_Function_float Function
605 %f2 = OpVariable %_ptr_Function_float Function
606 %ie = OpVariable %_ptr_Function_int Function
607 %i = OpVariable %_ptr_Function_int Function
608 %t = OpVariable %_ptr_Function_float Function
609 OpStore %f1 %float_0
610 OpStore %f2 %float_1
611 %24 = OpLoad %float %fe
612 %25 = OpConvertFToS %int %24
613 OpStore %ie %25
614 OpStore %i %int_0
615 OpBranch %26
616 %26 = OpLabel
617 OpLoopMerge %27 %28 None
618 OpBranch %29
619 %29 = OpLabel
620 %30 = OpLoad %int %i
621 %31 = OpLoad %int %ie
622 %32 = OpSLessThan %bool %30 %31
623 OpBranchConditional %32 %33 %27
624 %33 = OpLabel
625 %34 = OpLoad %float %f1
626 OpStore %t %34
627 %35 = OpLoad %float %f2
628 OpStore %f1 %35
629 %36 = OpLoad %float %t
630 OpStore %f2 %36
631 OpBranch %28
632 %28 = OpLabel
633 %37 = OpLoad %int %i
634 %38 = OpIAdd %int %37 %int_1
635 OpStore %i %38
636 OpBranch %26
637 %27 = OpLabel
638 %39 = OpLoad %float %f1
639 OpStore %fo %39
640 OpReturn
641 OpFunctionEnd
642 )";
643 
644   const std::string after =
645       R"(%main = OpFunction %void None %11
646 %23 = OpLabel
647 %f1 = OpVariable %_ptr_Function_float Function
648 %f2 = OpVariable %_ptr_Function_float Function
649 %ie = OpVariable %_ptr_Function_int Function
650 %i = OpVariable %_ptr_Function_int Function
651 %t = OpVariable %_ptr_Function_float Function
652 OpStore %f1 %float_0
653 OpStore %f2 %float_1
654 %24 = OpLoad %float %fe
655 %25 = OpConvertFToS %int %24
656 OpStore %ie %25
657 OpStore %i %int_0
658 OpBranch %26
659 %26 = OpLabel
660 %43 = OpPhi %float %float_1 %23 %42 %28
661 %42 = OpPhi %float %float_0 %23 %43 %28
662 %40 = OpPhi %int %int_0 %23 %38 %28
663 OpLoopMerge %27 %28 None
664 OpBranch %29
665 %29 = OpLabel
666 %32 = OpSLessThan %bool %40 %25
667 OpBranchConditional %32 %33 %27
668 %33 = OpLabel
669 OpStore %t %42
670 OpStore %f1 %43
671 OpStore %f2 %42
672 OpBranch %28
673 %28 = OpLabel
674 %38 = OpIAdd %int %40 %int_1
675 OpStore %i %38
676 OpBranch %26
677 %27 = OpLabel
678 OpStore %fo %42
679 OpReturn
680 OpFunctionEnd
681 )";
682 
683   SinglePassRunAndCheck<SSARewritePass>(predefs + before, predefs + after, true,
684                                         true);
685 }
686 
TEST_F(LocalSSAElimTest,LostCopyProblem)687 TEST_F(LocalSSAElimTest, LostCopyProblem) {
688   // #version 140
689   //
690   // in vec4 BC;
691   // out float fo;
692   //
693   // void main()
694   // {
695   //     float f = 0.0;
696   //     float t;
697   //     for (int i=0; i<4; i++) {
698   //       t = f;
699   //       f = f + BC[i];
700   //       if (f > 1.0)
701   //         break;
702   //     }
703   //     fo = t;
704   // }
705 
706   const std::string predefs =
707       R"(OpCapability Shader
708 %1 = OpExtInstImport "GLSL.std.450"
709 OpMemoryModel Logical GLSL450
710 OpEntryPoint Fragment %main "main" %BC %fo
711 OpExecutionMode %main OriginUpperLeft
712 OpSource GLSL 140
713 OpName %main "main"
714 OpName %f "f"
715 OpName %i "i"
716 OpName %t "t"
717 OpName %BC "BC"
718 OpName %fo "fo"
719 %void = OpTypeVoid
720 %9 = OpTypeFunction %void
721 %float = OpTypeFloat 32
722 %_ptr_Function_float = OpTypePointer Function %float
723 %float_0 = OpConstant %float 0
724 %int = OpTypeInt 32 1
725 %_ptr_Function_int = OpTypePointer Function %int
726 %int_0 = OpConstant %int 0
727 %int_4 = OpConstant %int 4
728 %bool = OpTypeBool
729 %v4float = OpTypeVector %float 4
730 %_ptr_Input_v4float = OpTypePointer Input %v4float
731 %BC = OpVariable %_ptr_Input_v4float Input
732 %_ptr_Input_float = OpTypePointer Input %float
733 %float_1 = OpConstant %float 1
734 %int_1 = OpConstant %int 1
735 %_ptr_Output_float = OpTypePointer Output %float
736 %fo = OpVariable %_ptr_Output_float Output
737 )";
738 
739   const std::string before =
740       R"(%main = OpFunction %void None %9
741 %24 = OpLabel
742 %f = OpVariable %_ptr_Function_float Function
743 %i = OpVariable %_ptr_Function_int Function
744 %t = OpVariable %_ptr_Function_float Function
745 OpStore %f %float_0
746 OpStore %i %int_0
747 OpBranch %25
748 %25 = OpLabel
749 OpLoopMerge %26 %27 None
750 OpBranch %28
751 %28 = OpLabel
752 %29 = OpLoad %int %i
753 %30 = OpSLessThan %bool %29 %int_4
754 OpBranchConditional %30 %31 %26
755 %31 = OpLabel
756 %32 = OpLoad %float %f
757 OpStore %t %32
758 %33 = OpLoad %float %f
759 %34 = OpLoad %int %i
760 %35 = OpAccessChain %_ptr_Input_float %BC %34
761 %36 = OpLoad %float %35
762 %37 = OpFAdd %float %33 %36
763 OpStore %f %37
764 %38 = OpLoad %float %f
765 %39 = OpFOrdGreaterThan %bool %38 %float_1
766 OpSelectionMerge %40 None
767 OpBranchConditional %39 %41 %40
768 %41 = OpLabel
769 OpBranch %26
770 %40 = OpLabel
771 OpBranch %27
772 %27 = OpLabel
773 %42 = OpLoad %int %i
774 %43 = OpIAdd %int %42 %int_1
775 OpStore %i %43
776 OpBranch %25
777 %26 = OpLabel
778 %44 = OpLoad %float %t
779 OpStore %fo %44
780 OpReturn
781 OpFunctionEnd
782 )";
783 
784   const std::string after =
785       R"(%49 = OpUndef %float
786 %main = OpFunction %void None %9
787 %24 = OpLabel
788 %f = OpVariable %_ptr_Function_float Function
789 %i = OpVariable %_ptr_Function_int Function
790 %t = OpVariable %_ptr_Function_float Function
791 OpStore %f %float_0
792 OpStore %i %int_0
793 OpBranch %25
794 %25 = OpLabel
795 %46 = OpPhi %float %float_0 %24 %37 %27
796 %45 = OpPhi %int %int_0 %24 %43 %27
797 %48 = OpPhi %float %49 %24 %46 %27
798 OpLoopMerge %26 %27 None
799 OpBranch %28
800 %28 = OpLabel
801 %30 = OpSLessThan %bool %45 %int_4
802 OpBranchConditional %30 %31 %26
803 %31 = OpLabel
804 OpStore %t %46
805 %35 = OpAccessChain %_ptr_Input_float %BC %45
806 %36 = OpLoad %float %35
807 %37 = OpFAdd %float %46 %36
808 OpStore %f %37
809 %39 = OpFOrdGreaterThan %bool %37 %float_1
810 OpSelectionMerge %40 None
811 OpBranchConditional %39 %41 %40
812 %41 = OpLabel
813 OpBranch %26
814 %40 = OpLabel
815 OpBranch %27
816 %27 = OpLabel
817 %43 = OpIAdd %int %45 %int_1
818 OpStore %i %43
819 OpBranch %25
820 %26 = OpLabel
821 %47 = OpPhi %float %48 %28 %46 %41
822 OpStore %fo %47
823 OpReturn
824 OpFunctionEnd
825 )";
826 
827   SinglePassRunAndCheck<SSARewritePass>(predefs + before, predefs + after, true,
828                                         true);
829 }
830 
TEST_F(LocalSSAElimTest,IfThenElse)831 TEST_F(LocalSSAElimTest, IfThenElse) {
832   // #version 140
833   //
834   // in vec4 BaseColor;
835   // in float f;
836   //
837   // void main()
838   // {
839   //     vec4 v;
840   //     if (f >= 0)
841   //       v = BaseColor * 0.5;
842   //     else
843   //       v = BaseColor + vec4(1.0,1.0,1.0,1.0);
844   //     gl_FragColor = v;
845   // }
846 
847   const std::string predefs =
848       R"(OpCapability Shader
849 %1 = OpExtInstImport "GLSL.std.450"
850 OpMemoryModel Logical GLSL450
851 OpEntryPoint Fragment %main "main" %f %BaseColor %gl_FragColor
852 OpExecutionMode %main OriginUpperLeft
853 OpSource GLSL 140
854 OpName %main "main"
855 OpName %f "f"
856 OpName %v "v"
857 OpName %BaseColor "BaseColor"
858 OpName %gl_FragColor "gl_FragColor"
859 %void = OpTypeVoid
860 %8 = OpTypeFunction %void
861 %float = OpTypeFloat 32
862 %_ptr_Input_float = OpTypePointer Input %float
863 %f = OpVariable %_ptr_Input_float Input
864 %float_0 = OpConstant %float 0
865 %bool = OpTypeBool
866 %v4float = OpTypeVector %float 4
867 %_ptr_Function_v4float = OpTypePointer Function %v4float
868 %_ptr_Input_v4float = OpTypePointer Input %v4float
869 %BaseColor = OpVariable %_ptr_Input_v4float Input
870 %float_0_5 = OpConstant %float 0.5
871 %float_1 = OpConstant %float 1
872 %18 = OpConstantComposite %v4float %float_1 %float_1 %float_1 %float_1
873 %_ptr_Output_v4float = OpTypePointer Output %v4float
874 %gl_FragColor = OpVariable %_ptr_Output_v4float Output
875 )";
876 
877   const std::string before =
878       R"(%main = OpFunction %void None %8
879 %20 = OpLabel
880 %v = OpVariable %_ptr_Function_v4float Function
881 %21 = OpLoad %float %f
882 %22 = OpFOrdGreaterThanEqual %bool %21 %float_0
883 OpSelectionMerge %23 None
884 OpBranchConditional %22 %24 %25
885 %24 = OpLabel
886 %26 = OpLoad %v4float %BaseColor
887 %27 = OpVectorTimesScalar %v4float %26 %float_0_5
888 OpStore %v %27
889 OpBranch %23
890 %25 = OpLabel
891 %28 = OpLoad %v4float %BaseColor
892 %29 = OpFAdd %v4float %28 %18
893 OpStore %v %29
894 OpBranch %23
895 %23 = OpLabel
896 %30 = OpLoad %v4float %v
897 OpStore %gl_FragColor %30
898 OpReturn
899 OpFunctionEnd
900 )";
901 
902   const std::string after =
903       R"(%main = OpFunction %void None %8
904 %20 = OpLabel
905 %v = OpVariable %_ptr_Function_v4float Function
906 %21 = OpLoad %float %f
907 %22 = OpFOrdGreaterThanEqual %bool %21 %float_0
908 OpSelectionMerge %23 None
909 OpBranchConditional %22 %24 %25
910 %24 = OpLabel
911 %26 = OpLoad %v4float %BaseColor
912 %27 = OpVectorTimesScalar %v4float %26 %float_0_5
913 OpStore %v %27
914 OpBranch %23
915 %25 = OpLabel
916 %28 = OpLoad %v4float %BaseColor
917 %29 = OpFAdd %v4float %28 %18
918 OpStore %v %29
919 OpBranch %23
920 %23 = OpLabel
921 %31 = OpPhi %v4float %27 %24 %29 %25
922 OpStore %gl_FragColor %31
923 OpReturn
924 OpFunctionEnd
925 )";
926 
927   SinglePassRunAndCheck<SSARewritePass>(predefs + before, predefs + after, true,
928                                         true);
929 }
930 
TEST_F(LocalSSAElimTest,IfThen)931 TEST_F(LocalSSAElimTest, IfThen) {
932   // #version 140
933   //
934   // in vec4 BaseColor;
935   // in float f;
936   //
937   // void main()
938   // {
939   //     vec4 v = BaseColor;
940   //     if (f <= 0)
941   //       v = v * 0.5;
942   //     gl_FragColor = v;
943   // }
944 
945   const std::string predefs =
946       R"(OpCapability Shader
947 %1 = OpExtInstImport "GLSL.std.450"
948 OpMemoryModel Logical GLSL450
949 OpEntryPoint Fragment %main "main" %BaseColor %f %gl_FragColor
950 OpExecutionMode %main OriginUpperLeft
951 OpSource GLSL 140
952 OpName %main "main"
953 OpName %v "v"
954 OpName %BaseColor "BaseColor"
955 OpName %f "f"
956 OpName %gl_FragColor "gl_FragColor"
957 %void = OpTypeVoid
958 %8 = OpTypeFunction %void
959 %float = OpTypeFloat 32
960 %v4float = OpTypeVector %float 4
961 %_ptr_Function_v4float = OpTypePointer Function %v4float
962 %_ptr_Input_v4float = OpTypePointer Input %v4float
963 %BaseColor = OpVariable %_ptr_Input_v4float Input
964 %_ptr_Input_float = OpTypePointer Input %float
965 %f = OpVariable %_ptr_Input_float Input
966 %float_0 = OpConstant %float 0
967 %bool = OpTypeBool
968 %float_0_5 = OpConstant %float 0.5
969 %_ptr_Output_v4float = OpTypePointer Output %v4float
970 %gl_FragColor = OpVariable %_ptr_Output_v4float Output
971 )";
972 
973   const std::string before =
974       R"(%main = OpFunction %void None %8
975 %18 = OpLabel
976 %v = OpVariable %_ptr_Function_v4float Function
977 %19 = OpLoad %v4float %BaseColor
978 OpStore %v %19
979 %20 = OpLoad %float %f
980 %21 = OpFOrdLessThanEqual %bool %20 %float_0
981 OpSelectionMerge %22 None
982 OpBranchConditional %21 %23 %22
983 %23 = OpLabel
984 %24 = OpLoad %v4float %v
985 %25 = OpVectorTimesScalar %v4float %24 %float_0_5
986 OpStore %v %25
987 OpBranch %22
988 %22 = OpLabel
989 %26 = OpLoad %v4float %v
990 OpStore %gl_FragColor %26
991 OpReturn
992 OpFunctionEnd
993 )";
994 
995   const std::string after =
996       R"(%main = OpFunction %void None %8
997 %18 = OpLabel
998 %v = OpVariable %_ptr_Function_v4float Function
999 %19 = OpLoad %v4float %BaseColor
1000 OpStore %v %19
1001 %20 = OpLoad %float %f
1002 %21 = OpFOrdLessThanEqual %bool %20 %float_0
1003 OpSelectionMerge %22 None
1004 OpBranchConditional %21 %23 %22
1005 %23 = OpLabel
1006 %25 = OpVectorTimesScalar %v4float %19 %float_0_5
1007 OpStore %v %25
1008 OpBranch %22
1009 %22 = OpLabel
1010 %27 = OpPhi %v4float %19 %18 %25 %23
1011 OpStore %gl_FragColor %27
1012 OpReturn
1013 OpFunctionEnd
1014 )";
1015 
1016   SinglePassRunAndCheck<SSARewritePass>(predefs + before, predefs + after, true,
1017                                         true);
1018 }
1019 
TEST_F(LocalSSAElimTest,Switch)1020 TEST_F(LocalSSAElimTest, Switch) {
1021   // #version 140
1022   //
1023   // in vec4 BaseColor;
1024   // in float f;
1025   //
1026   // void main()
1027   // {
1028   //     vec4 v = BaseColor;
1029   //     int i = int(f);
1030   //     switch (i) {
1031   //       case 0:
1032   //         v = v * 0.25;
1033   //         break;
1034   //       case 1:
1035   //         v = v * 0.625;
1036   //         break;
1037   //       case 2:
1038   //         v = v * 0.75;
1039   //         break;
1040   //       default:
1041   //         break;
1042   //     }
1043   //     gl_FragColor = v;
1044   // }
1045 
1046   const std::string predefs =
1047       R"(OpCapability Shader
1048 %1 = OpExtInstImport "GLSL.std.450"
1049 OpMemoryModel Logical GLSL450
1050 OpEntryPoint Fragment %main "main" %BaseColor %f %gl_FragColor
1051 OpExecutionMode %main OriginUpperLeft
1052 OpSource GLSL 140
1053 OpName %main "main"
1054 OpName %v "v"
1055 OpName %BaseColor "BaseColor"
1056 OpName %i "i"
1057 OpName %f "f"
1058 OpName %gl_FragColor "gl_FragColor"
1059 %void = OpTypeVoid
1060 %9 = OpTypeFunction %void
1061 %float = OpTypeFloat 32
1062 %v4float = OpTypeVector %float 4
1063 %_ptr_Function_v4float = OpTypePointer Function %v4float
1064 %_ptr_Input_v4float = OpTypePointer Input %v4float
1065 %BaseColor = OpVariable %_ptr_Input_v4float Input
1066 %int = OpTypeInt 32 1
1067 %_ptr_Function_int = OpTypePointer Function %int
1068 %_ptr_Input_float = OpTypePointer Input %float
1069 %f = OpVariable %_ptr_Input_float Input
1070 %float_0_25 = OpConstant %float 0.25
1071 %float_0_625 = OpConstant %float 0.625
1072 %float_0_75 = OpConstant %float 0.75
1073 %_ptr_Output_v4float = OpTypePointer Output %v4float
1074 %gl_FragColor = OpVariable %_ptr_Output_v4float Output
1075 )";
1076 
1077   const std::string before =
1078       R"(%main = OpFunction %void None %9
1079 %21 = OpLabel
1080 %v = OpVariable %_ptr_Function_v4float Function
1081 %i = OpVariable %_ptr_Function_int Function
1082 %22 = OpLoad %v4float %BaseColor
1083 OpStore %v %22
1084 %23 = OpLoad %float %f
1085 %24 = OpConvertFToS %int %23
1086 OpStore %i %24
1087 %25 = OpLoad %int %i
1088 OpSelectionMerge %26 None
1089 OpSwitch %25 %27 0 %28 1 %29 2 %30
1090 %27 = OpLabel
1091 OpBranch %26
1092 %28 = OpLabel
1093 %31 = OpLoad %v4float %v
1094 %32 = OpVectorTimesScalar %v4float %31 %float_0_25
1095 OpStore %v %32
1096 OpBranch %26
1097 %29 = OpLabel
1098 %33 = OpLoad %v4float %v
1099 %34 = OpVectorTimesScalar %v4float %33 %float_0_625
1100 OpStore %v %34
1101 OpBranch %26
1102 %30 = OpLabel
1103 %35 = OpLoad %v4float %v
1104 %36 = OpVectorTimesScalar %v4float %35 %float_0_75
1105 OpStore %v %36
1106 OpBranch %26
1107 %26 = OpLabel
1108 %37 = OpLoad %v4float %v
1109 OpStore %gl_FragColor %37
1110 OpReturn
1111 OpFunctionEnd
1112 )";
1113 
1114   const std::string after =
1115       R"(%main = OpFunction %void None %9
1116 %21 = OpLabel
1117 %v = OpVariable %_ptr_Function_v4float Function
1118 %i = OpVariable %_ptr_Function_int Function
1119 %22 = OpLoad %v4float %BaseColor
1120 OpStore %v %22
1121 %23 = OpLoad %float %f
1122 %24 = OpConvertFToS %int %23
1123 OpStore %i %24
1124 OpSelectionMerge %26 None
1125 OpSwitch %24 %27 0 %28 1 %29 2 %30
1126 %27 = OpLabel
1127 OpBranch %26
1128 %28 = OpLabel
1129 %32 = OpVectorTimesScalar %v4float %22 %float_0_25
1130 OpStore %v %32
1131 OpBranch %26
1132 %29 = OpLabel
1133 %34 = OpVectorTimesScalar %v4float %22 %float_0_625
1134 OpStore %v %34
1135 OpBranch %26
1136 %30 = OpLabel
1137 %36 = OpVectorTimesScalar %v4float %22 %float_0_75
1138 OpStore %v %36
1139 OpBranch %26
1140 %26 = OpLabel
1141 %38 = OpPhi %v4float %22 %27 %32 %28 %34 %29 %36 %30
1142 OpStore %gl_FragColor %38
1143 OpReturn
1144 OpFunctionEnd
1145 )";
1146 
1147   SinglePassRunAndCheck<SSARewritePass>(predefs + before, predefs + after, true,
1148                                         true);
1149 }
1150 
TEST_F(LocalSSAElimTest,SwitchWithFallThrough)1151 TEST_F(LocalSSAElimTest, SwitchWithFallThrough) {
1152   // #version 140
1153   //
1154   // in vec4 BaseColor;
1155   // in float f;
1156   //
1157   // void main()
1158   // {
1159   //     vec4 v = BaseColor;
1160   //     int i = int(f);
1161   //     switch (i) {
1162   //       case 0:
1163   //         v = v * 0.25;
1164   //         break;
1165   //       case 1:
1166   //         v = v + 0.25;
1167   //       case 2:
1168   //         v = v * 0.75;
1169   //         break;
1170   //       default:
1171   //         break;
1172   //     }
1173   //     gl_FragColor = v;
1174   // }
1175 
1176   const std::string predefs =
1177       R"(OpCapability Shader
1178 %1 = OpExtInstImport "GLSL.std.450"
1179 OpMemoryModel Logical GLSL450
1180 OpEntryPoint Fragment %main "main" %BaseColor %f %gl_FragColor
1181 OpExecutionMode %main OriginUpperLeft
1182 OpSource GLSL 140
1183 OpName %main "main"
1184 OpName %v "v"
1185 OpName %BaseColor "BaseColor"
1186 OpName %i "i"
1187 OpName %f "f"
1188 OpName %gl_FragColor "gl_FragColor"
1189 %void = OpTypeVoid
1190 %9 = OpTypeFunction %void
1191 %float = OpTypeFloat 32
1192 %v4float = OpTypeVector %float 4
1193 %_ptr_Function_v4float = OpTypePointer Function %v4float
1194 %_ptr_Input_v4float = OpTypePointer Input %v4float
1195 %BaseColor = OpVariable %_ptr_Input_v4float Input
1196 %int = OpTypeInt 32 1
1197 %_ptr_Function_int = OpTypePointer Function %int
1198 %_ptr_Input_float = OpTypePointer Input %float
1199 %f = OpVariable %_ptr_Input_float Input
1200 %float_0_25 = OpConstant %float 0.25
1201 %float_0_75 = OpConstant %float 0.75
1202 %_ptr_Output_v4float = OpTypePointer Output %v4float
1203 %gl_FragColor = OpVariable %_ptr_Output_v4float Output
1204 )";
1205 
1206   const std::string before =
1207       R"(%main = OpFunction %void None %9
1208 %20 = OpLabel
1209 %v = OpVariable %_ptr_Function_v4float Function
1210 %i = OpVariable %_ptr_Function_int Function
1211 %21 = OpLoad %v4float %BaseColor
1212 OpStore %v %21
1213 %22 = OpLoad %float %f
1214 %23 = OpConvertFToS %int %22
1215 OpStore %i %23
1216 %24 = OpLoad %int %i
1217 OpSelectionMerge %25 None
1218 OpSwitch %24 %26 0 %27 1 %28 2 %29
1219 %26 = OpLabel
1220 OpBranch %25
1221 %27 = OpLabel
1222 %30 = OpLoad %v4float %v
1223 %31 = OpVectorTimesScalar %v4float %30 %float_0_25
1224 OpStore %v %31
1225 OpBranch %25
1226 %28 = OpLabel
1227 %32 = OpLoad %v4float %v
1228 %33 = OpCompositeConstruct %v4float %float_0_25 %float_0_25 %float_0_25 %float_0_25
1229 %34 = OpFAdd %v4float %32 %33
1230 OpStore %v %34
1231 OpBranch %29
1232 %29 = OpLabel
1233 %35 = OpLoad %v4float %v
1234 %36 = OpVectorTimesScalar %v4float %35 %float_0_75
1235 OpStore %v %36
1236 OpBranch %25
1237 %25 = OpLabel
1238 %37 = OpLoad %v4float %v
1239 OpStore %gl_FragColor %37
1240 OpReturn
1241 OpFunctionEnd
1242 )";
1243 
1244   const std::string after =
1245       R"(%main = OpFunction %void None %9
1246 %20 = OpLabel
1247 %v = OpVariable %_ptr_Function_v4float Function
1248 %i = OpVariable %_ptr_Function_int Function
1249 %21 = OpLoad %v4float %BaseColor
1250 OpStore %v %21
1251 %22 = OpLoad %float %f
1252 %23 = OpConvertFToS %int %22
1253 OpStore %i %23
1254 OpSelectionMerge %25 None
1255 OpSwitch %23 %26 0 %27 1 %28 2 %29
1256 %26 = OpLabel
1257 OpBranch %25
1258 %27 = OpLabel
1259 %31 = OpVectorTimesScalar %v4float %21 %float_0_25
1260 OpStore %v %31
1261 OpBranch %25
1262 %28 = OpLabel
1263 %33 = OpCompositeConstruct %v4float %float_0_25 %float_0_25 %float_0_25 %float_0_25
1264 %34 = OpFAdd %v4float %21 %33
1265 OpStore %v %34
1266 OpBranch %29
1267 %29 = OpLabel
1268 %38 = OpPhi %v4float %21 %20 %34 %28
1269 %36 = OpVectorTimesScalar %v4float %38 %float_0_75
1270 OpStore %v %36
1271 OpBranch %25
1272 %25 = OpLabel
1273 %39 = OpPhi %v4float %21 %26 %31 %27 %36 %29
1274 OpStore %gl_FragColor %39
1275 OpReturn
1276 OpFunctionEnd
1277 )";
1278 
1279   SinglePassRunAndCheck<SSARewritePass>(predefs + before, predefs + after, true,
1280                                         true);
1281 }
1282 
TEST_F(LocalSSAElimTest,DontPatchPhiInLoopHeaderThatIsNotAVar)1283 TEST_F(LocalSSAElimTest, DontPatchPhiInLoopHeaderThatIsNotAVar) {
1284   // From https://github.com/KhronosGroup/SPIRV-Tools/issues/826
1285   // Don't try patching the (%16 %7) value/predecessor pair in the OpPhi.
1286   // That OpPhi is unrelated to this optimization: we did not set that up
1287   // in the SSA initialization for the loop header block.
1288   // The pass should be a no-op on this module.
1289 
1290   const std::string before = R"(OpCapability Shader
1291 OpMemoryModel Logical GLSL450
1292 OpEntryPoint GLCompute %1 "main"
1293 %void = OpTypeVoid
1294 %3 = OpTypeFunction %void
1295 %float = OpTypeFloat 32
1296 %float_1 = OpConstant %float 1
1297 %1 = OpFunction %void None %3
1298 %6 = OpLabel
1299 OpBranch %7
1300 %7 = OpLabel
1301 %8 = OpPhi %float %float_1 %6 %9 %7
1302 %9 = OpFAdd %float %8 %float_1
1303 OpLoopMerge %10 %7 None
1304 OpBranch %7
1305 %10 = OpLabel
1306 OpReturn
1307 OpFunctionEnd
1308 )";
1309 
1310   SinglePassRunAndCheck<SSARewritePass>(before, before, true, true);
1311 }
1312 
TEST_F(LocalSSAElimTest,OptInitializedVariableLikeStore)1313 TEST_F(LocalSSAElimTest, OptInitializedVariableLikeStore) {
1314   // Note: SPIR-V edited to change store to v into variable initialization
1315   //
1316   // #version 450
1317   //
1318   // layout (location=0) in vec4 iColor;
1319   // layout (location=1) in float fi;
1320   // layout (location=0) out vec4 oColor;
1321   //
1322   // void main()
1323   // {
1324   //     vec4 v = vec4(0.0);
1325   //     if (fi < 0.0)
1326   //       v.x = iColor.x;
1327   //     oColor = v;
1328   // }
1329 
1330   const std::string predefs =
1331       R"(OpCapability Shader
1332 %1 = OpExtInstImport "GLSL.std.450"
1333 OpMemoryModel Logical GLSL450
1334 OpEntryPoint Fragment %main "main" %fi %iColor %oColor
1335 OpExecutionMode %main OriginUpperLeft
1336 OpSource GLSL 450
1337 OpName %main "main"
1338 OpName %v "v"
1339 OpName %fi "fi"
1340 OpName %iColor "iColor"
1341 OpName %oColor "oColor"
1342 OpDecorate %fi Location 1
1343 OpDecorate %iColor Location 0
1344 OpDecorate %oColor Location 0
1345 %void = OpTypeVoid
1346 %8 = OpTypeFunction %void
1347 %float = OpTypeFloat 32
1348 %v4float = OpTypeVector %float 4
1349 %_ptr_Function_v4float = OpTypePointer Function %v4float
1350 %float_0 = OpConstant %float 0
1351 %13 = OpConstantComposite %v4float %float_0 %float_0 %float_0 %float_0
1352 %_ptr_Input_float = OpTypePointer Input %float
1353 %fi = OpVariable %_ptr_Input_float Input
1354 %bool = OpTypeBool
1355 %_ptr_Input_v4float = OpTypePointer Input %v4float
1356 %iColor = OpVariable %_ptr_Input_v4float Input
1357 %uint = OpTypeInt 32 0
1358 %uint_0 = OpConstant %uint 0
1359 %_ptr_Function_float = OpTypePointer Function %float
1360 %_ptr_Output_v4float = OpTypePointer Output %v4float
1361 %oColor = OpVariable %_ptr_Output_v4float Output
1362 )";
1363 
1364   const std::string func_before =
1365       R"(%main = OpFunction %void None %8
1366 %21 = OpLabel
1367 %v = OpVariable %_ptr_Function_v4float Function %13
1368 %22 = OpLoad %float %fi
1369 %23 = OpFOrdLessThan %bool %22 %float_0
1370 OpSelectionMerge %24 None
1371 OpBranchConditional %23 %25 %24
1372 %25 = OpLabel
1373 %26 = OpAccessChain %_ptr_Input_float %iColor %uint_0
1374 %27 = OpLoad %float %26
1375 %28 = OpLoad %v4float %v
1376 %29 = OpCompositeInsert %v4float %27 %28 0
1377 OpStore %v %29
1378 OpBranch %24
1379 %24 = OpLabel
1380 %30 = OpLoad %v4float %v
1381 OpStore %oColor %30
1382 OpReturn
1383 OpFunctionEnd
1384 )";
1385 
1386   const std::string func_after =
1387       R"(%main = OpFunction %void None %8
1388 %21 = OpLabel
1389 %v = OpVariable %_ptr_Function_v4float Function %13
1390 %22 = OpLoad %float %fi
1391 %23 = OpFOrdLessThan %bool %22 %float_0
1392 OpSelectionMerge %24 None
1393 OpBranchConditional %23 %25 %24
1394 %25 = OpLabel
1395 %26 = OpAccessChain %_ptr_Input_float %iColor %uint_0
1396 %27 = OpLoad %float %26
1397 %29 = OpCompositeInsert %v4float %27 %13 0
1398 OpStore %v %29
1399 OpBranch %24
1400 %24 = OpLabel
1401 %31 = OpPhi %v4float %13 %21 %29 %25
1402 OpStore %oColor %31
1403 OpReturn
1404 OpFunctionEnd
1405 )";
1406 
1407   SinglePassRunAndCheck<SSARewritePass>(predefs + func_before,
1408                                         predefs + func_after, true, true);
1409 }
1410 
TEST_F(LocalSSAElimTest,PointerVariable)1411 TEST_F(LocalSSAElimTest, PointerVariable) {
1412   // Test that checks if a pointer variable is removed.
1413 
1414   const std::string before =
1415       R"(OpCapability Shader
1416 OpMemoryModel Logical GLSL450
1417 OpEntryPoint Fragment %1 "main" %2
1418 OpExecutionMode %1 OriginUpperLeft
1419 OpMemberDecorate %_struct_3 0 Offset 0
1420 OpDecorate %_runtimearr__struct_3 ArrayStride 16
1421 OpMemberDecorate %_struct_5 0 Offset 0
1422 OpDecorate %_struct_5 BufferBlock
1423 OpMemberDecorate %_struct_6 0 Offset 0
1424 OpDecorate %_struct_6 BufferBlock
1425 OpDecorate %2 Location 0
1426 OpDecorate %7 DescriptorSet 0
1427 OpDecorate %7 Binding 0
1428 %void = OpTypeVoid
1429 %10 = OpTypeFunction %void
1430 %int = OpTypeInt 32 1
1431 %uint = OpTypeInt 32 0
1432 %float = OpTypeFloat 32
1433 %v4float = OpTypeVector %float 4
1434 %_ptr_Output_v4float = OpTypePointer Output %v4float
1435 %_ptr_Uniform_v4float = OpTypePointer Uniform %v4float
1436 %_struct_3 = OpTypeStruct %v4float
1437 %_runtimearr__struct_3 = OpTypeRuntimeArray %_struct_3
1438 %_struct_5 = OpTypeStruct %_runtimearr__struct_3
1439 %_ptr_Uniform__struct_5 = OpTypePointer Uniform %_struct_5
1440 %_struct_6 = OpTypeStruct %int
1441 %_ptr_Uniform__struct_6 = OpTypePointer Uniform %_struct_6
1442 %_ptr_Function__ptr_Uniform__struct_5 = OpTypePointer Function %_ptr_Uniform__struct_5
1443 %_ptr_Function__ptr_Uniform__struct_6 = OpTypePointer Function %_ptr_Uniform__struct_6
1444 %int_0 = OpConstant %int 0
1445 %uint_0 = OpConstant %uint 0
1446 %2 = OpVariable %_ptr_Output_v4float Output
1447 %7 = OpVariable %_ptr_Uniform__struct_5 Uniform
1448 %1 = OpFunction %void None %10
1449 %23 = OpLabel
1450 %24 = OpVariable %_ptr_Function__ptr_Uniform__struct_5 Function
1451 OpStore %24 %7
1452 %26 = OpLoad %_ptr_Uniform__struct_5 %24
1453 %27 = OpAccessChain %_ptr_Uniform_v4float %26 %int_0 %uint_0 %int_0
1454 %28 = OpLoad %v4float %27
1455 %29 = OpCopyObject %v4float %28
1456 OpStore %2 %28
1457 OpReturn
1458 OpFunctionEnd
1459 )";
1460 
1461   const std::string after =
1462       R"(OpCapability Shader
1463 OpMemoryModel Logical GLSL450
1464 OpEntryPoint Fragment %1 "main" %2
1465 OpExecutionMode %1 OriginUpperLeft
1466 OpMemberDecorate %_struct_3 0 Offset 0
1467 OpDecorate %_runtimearr__struct_3 ArrayStride 16
1468 OpMemberDecorate %_struct_5 0 Offset 0
1469 OpDecorate %_struct_5 BufferBlock
1470 OpMemberDecorate %_struct_6 0 Offset 0
1471 OpDecorate %_struct_6 BufferBlock
1472 OpDecorate %2 Location 0
1473 OpDecorate %7 DescriptorSet 0
1474 OpDecorate %7 Binding 0
1475 %void = OpTypeVoid
1476 %10 = OpTypeFunction %void
1477 %int = OpTypeInt 32 1
1478 %uint = OpTypeInt 32 0
1479 %float = OpTypeFloat 32
1480 %v4float = OpTypeVector %float 4
1481 %_ptr_Output_v4float = OpTypePointer Output %v4float
1482 %_ptr_Uniform_v4float = OpTypePointer Uniform %v4float
1483 %_struct_3 = OpTypeStruct %v4float
1484 %_runtimearr__struct_3 = OpTypeRuntimeArray %_struct_3
1485 %_struct_5 = OpTypeStruct %_runtimearr__struct_3
1486 %_ptr_Uniform__struct_5 = OpTypePointer Uniform %_struct_5
1487 %_struct_6 = OpTypeStruct %int
1488 %_ptr_Uniform__struct_6 = OpTypePointer Uniform %_struct_6
1489 %_ptr_Function__ptr_Uniform__struct_5 = OpTypePointer Function %_ptr_Uniform__struct_5
1490 %_ptr_Function__ptr_Uniform__struct_6 = OpTypePointer Function %_ptr_Uniform__struct_6
1491 %int_0 = OpConstant %int 0
1492 %uint_0 = OpConstant %uint 0
1493 %2 = OpVariable %_ptr_Output_v4float Output
1494 %7 = OpVariable %_ptr_Uniform__struct_5 Uniform
1495 %1 = OpFunction %void None %10
1496 %23 = OpLabel
1497 %24 = OpVariable %_ptr_Function__ptr_Uniform__struct_5 Function
1498 OpStore %24 %7
1499 %27 = OpAccessChain %_ptr_Uniform_v4float %7 %int_0 %uint_0 %int_0
1500 %28 = OpLoad %v4float %27
1501 %29 = OpCopyObject %v4float %28
1502 OpStore %2 %28
1503 OpReturn
1504 OpFunctionEnd
1505 )";
1506 
1507   // Relax logical pointers to allow pointer allocations.
1508   SetAssembleOptions(SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
1509   ValidatorOptions()->relax_logical_pointer = true;
1510   SinglePassRunAndCheck<SSARewritePass>(before, after, true, true);
1511 }
1512 
TEST_F(LocalSSAElimTest,VerifyInstToBlockMap)1513 TEST_F(LocalSSAElimTest, VerifyInstToBlockMap) {
1514   // #version 140
1515   //
1516   // in vec4 BC;
1517   // out float fo;
1518   //
1519   // void main()
1520   // {
1521   //     float f = 0.0;
1522   //     for (int i=0; i<4; i++) {
1523   //       f = f + BC[i];
1524   //     }
1525   //     fo = f;
1526   // }
1527 
1528   const std::string text = R"(
1529 OpCapability Shader
1530 %1 = OpExtInstImport "GLSL.std.450"
1531 OpMemoryModel Logical GLSL450
1532 OpEntryPoint Fragment %main "main" %BC %fo
1533 OpExecutionMode %main OriginUpperLeft
1534 OpSource GLSL 140
1535 OpName %main "main"
1536 OpName %f "f"
1537 OpName %i "i"
1538 OpName %BC "BC"
1539 OpName %fo "fo"
1540 %void = OpTypeVoid
1541 %8 = OpTypeFunction %void
1542 %float = OpTypeFloat 32
1543 %_ptr_Function_float = OpTypePointer Function %float
1544 %float_0 = OpConstant %float 0
1545 %int = OpTypeInt 32 1
1546 %_ptr_Function_int = OpTypePointer Function %int
1547 %int_0 = OpConstant %int 0
1548 %int_4 = OpConstant %int 4
1549 %bool = OpTypeBool
1550 %v4float = OpTypeVector %float 4
1551 %_ptr_Input_v4float = OpTypePointer Input %v4float
1552 %BC = OpVariable %_ptr_Input_v4float Input
1553 %_ptr_Input_float = OpTypePointer Input %float
1554 %int_1 = OpConstant %int 1
1555 %_ptr_Output_float = OpTypePointer Output %float
1556 %fo = OpVariable %_ptr_Output_float Output
1557 %main = OpFunction %void None %8
1558 %22 = OpLabel
1559 %f = OpVariable %_ptr_Function_float Function
1560 %i = OpVariable %_ptr_Function_int Function
1561 OpStore %f %float_0
1562 OpStore %i %int_0
1563 OpBranch %23
1564 %23 = OpLabel
1565 OpLoopMerge %24 %25 None
1566 OpBranch %26
1567 %26 = OpLabel
1568 %27 = OpLoad %int %i
1569 %28 = OpSLessThan %bool %27 %int_4
1570 OpBranchConditional %28 %29 %24
1571 %29 = OpLabel
1572 %30 = OpLoad %float %f
1573 %31 = OpLoad %int %i
1574 %32 = OpAccessChain %_ptr_Input_float %BC %31
1575 %33 = OpLoad %float %32
1576 %34 = OpFAdd %float %30 %33
1577 OpStore %f %34
1578 OpBranch %25
1579 %25 = OpLabel
1580 %35 = OpLoad %int %i
1581 %36 = OpIAdd %int %35 %int_1
1582 OpStore %i %36
1583 OpBranch %23
1584 %24 = OpLabel
1585 %37 = OpLoad %float %f
1586 OpStore %fo %37
1587 OpReturn
1588 OpFunctionEnd
1589 )";
1590 
1591   std::unique_ptr<IRContext> context =
1592       BuildModule(SPV_ENV_UNIVERSAL_1_1, nullptr, text,
1593                   SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
1594   EXPECT_NE(nullptr, context);
1595 
1596   // Force the instruction to block mapping to get built.
1597   context->get_instr_block(27u);
1598 
1599   auto pass = MakeUnique<SSARewritePass>();
1600   pass->SetMessageConsumer(nullptr);
1601   const auto status = pass->Run(context.get());
1602   EXPECT_TRUE(status == Pass::Status::SuccessWithChange);
1603 }
1604 
TEST_F(LocalSSAElimTest,CompositeExtractProblem)1605 TEST_F(LocalSSAElimTest, CompositeExtractProblem) {
1606   const std::string spv_asm = R"(
1607                OpCapability Tessellation
1608           %1 = OpExtInstImport "GLSL.std.450"
1609                OpMemoryModel Logical GLSL450
1610                OpEntryPoint TessellationControl %2 "main" %16 %17 %18 %20 %22 %26 %27 %30 %31
1611        %void = OpTypeVoid
1612           %4 = OpTypeFunction %void
1613       %float = OpTypeFloat 32
1614     %v4float = OpTypeVector %float 4
1615        %uint = OpTypeInt 32 0
1616      %uint_3 = OpConstant %uint 3
1617     %v3float = OpTypeVector %float 3
1618     %v2float = OpTypeVector %float 2
1619  %_struct_11 = OpTypeStruct %v4float %v4float %v4float %v3float %v3float %v2float %v2float
1620 %_arr__struct_11_uint_3 = OpTypeArray %_struct_11 %uint_3
1621 %_ptr_Function__arr__struct_11_uint_3 = OpTypePointer Function %_arr__struct_11_uint_3
1622 %_arr_v4float_uint_3 = OpTypeArray %v4float %uint_3
1623 %_ptr_Input__arr_v4float_uint_3 = OpTypePointer Input %_arr_v4float_uint_3
1624          %16 = OpVariable %_ptr_Input__arr_v4float_uint_3 Input
1625          %17 = OpVariable %_ptr_Input__arr_v4float_uint_3 Input
1626          %18 = OpVariable %_ptr_Input__arr_v4float_uint_3 Input
1627 %_ptr_Input_uint = OpTypePointer Input %uint
1628          %20 = OpVariable %_ptr_Input_uint Input
1629 %_ptr_Output__arr_v4float_uint_3 = OpTypePointer Output %_arr_v4float_uint_3
1630          %22 = OpVariable %_ptr_Output__arr_v4float_uint_3 Output
1631 %_ptr_Output_v4float = OpTypePointer Output %v4float
1632 %_arr_v3float_uint_3 = OpTypeArray %v3float %uint_3
1633 %_ptr_Input__arr_v3float_uint_3 = OpTypePointer Input %_arr_v3float_uint_3
1634          %26 = OpVariable %_ptr_Input__arr_v3float_uint_3 Input
1635          %27 = OpVariable %_ptr_Input__arr_v3float_uint_3 Input
1636 %_arr_v2float_uint_3 = OpTypeArray %v2float %uint_3
1637 %_ptr_Input__arr_v2float_uint_3 = OpTypePointer Input %_arr_v2float_uint_3
1638          %30 = OpVariable %_ptr_Input__arr_v2float_uint_3 Input
1639          %31 = OpVariable %_ptr_Input__arr_v2float_uint_3 Input
1640 %_ptr_Function__struct_11 = OpTypePointer Function %_struct_11
1641           %2 = OpFunction %void None %4
1642          %33 = OpLabel
1643          %66 = OpVariable %_ptr_Function__arr__struct_11_uint_3 Function
1644          %34 = OpLoad %_arr_v4float_uint_3 %16
1645          %35 = OpLoad %_arr_v4float_uint_3 %17
1646          %36 = OpLoad %_arr_v4float_uint_3 %18
1647          %37 = OpLoad %_arr_v3float_uint_3 %26
1648          %38 = OpLoad %_arr_v3float_uint_3 %27
1649          %39 = OpLoad %_arr_v2float_uint_3 %30
1650          %40 = OpLoad %_arr_v2float_uint_3 %31
1651          %41 = OpCompositeExtract %v4float %34 0
1652          %42 = OpCompositeExtract %v4float %35 0
1653          %43 = OpCompositeExtract %v4float %36 0
1654          %44 = OpCompositeExtract %v3float %37 0
1655          %45 = OpCompositeExtract %v3float %38 0
1656          %46 = OpCompositeExtract %v2float %39 0
1657          %47 = OpCompositeExtract %v2float %40 0
1658          %48 = OpCompositeConstruct %_struct_11 %41 %42 %43 %44 %45 %46 %47
1659          %49 = OpCompositeExtract %v4float %34 1
1660          %50 = OpCompositeExtract %v4float %35 1
1661          %51 = OpCompositeExtract %v4float %36 1
1662          %52 = OpCompositeExtract %v3float %37 1
1663          %53 = OpCompositeExtract %v3float %38 1
1664          %54 = OpCompositeExtract %v2float %39 1
1665          %55 = OpCompositeExtract %v2float %40 1
1666          %56 = OpCompositeConstruct %_struct_11 %49 %50 %51 %52 %53 %54 %55
1667          %57 = OpCompositeExtract %v4float %34 2
1668          %58 = OpCompositeExtract %v4float %35 2
1669          %59 = OpCompositeExtract %v4float %36 2
1670          %60 = OpCompositeExtract %v3float %37 2
1671          %61 = OpCompositeExtract %v3float %38 2
1672          %62 = OpCompositeExtract %v2float %39 2
1673          %63 = OpCompositeExtract %v2float %40 2
1674          %64 = OpCompositeConstruct %_struct_11 %57 %58 %59 %60 %61 %62 %63
1675          %65 = OpCompositeConstruct %_arr__struct_11_uint_3 %48 %56 %64
1676          %67 = OpLoad %uint %20
1677 
1678 ; CHECK OpStore {{%\d+}} [[store_source:%\d+]]
1679                OpStore %66 %65
1680          %68 = OpAccessChain %_ptr_Function__struct_11 %66 %67
1681 
1682 ; This load was being removed, because %_ptr_Function__struct_11 was being
1683 ; wrongfully considered an SSA target.
1684 ; CHECK OpLoad %_struct_11 %68
1685          %69 = OpLoad %_struct_11 %68
1686 
1687 ; Similarly, %69 cannot be replaced with %65.
1688 ; CHECK-NOT: OpCompositeExtract %v4float [[store_source]] 0
1689          %70 = OpCompositeExtract %v4float %69 0
1690 
1691          %71 = OpAccessChain %_ptr_Output_v4float %22 %67
1692                OpStore %71 %70
1693                OpReturn
1694                OpFunctionEnd)";
1695 
1696   SinglePassRunAndMatch<SSARewritePass>(spv_asm, true);
1697 }
1698 
1699 // Test that the RelaxedPrecision decoration on the variable to added to the
1700 // result of the OpPhi instruction.
TEST_F(LocalSSAElimTest,DecoratedVariable)1701 TEST_F(LocalSSAElimTest, DecoratedVariable) {
1702   const std::string spv_asm = R"(
1703 ; CHECK: OpDecorate [[var:%\w+]] RelaxedPrecision
1704 ; CHECK: OpDecorate [[phi_id:%\w+]] RelaxedPrecision
1705 ; CHECK: [[phi_id]] = OpPhi
1706                OpCapability Shader
1707           %1 = OpExtInstImport "GLSL.std.450"
1708                OpMemoryModel Logical GLSL450
1709                OpEntryPoint GLCompute %2 "main"
1710                OpDecorate %v RelaxedPrecision
1711        %void = OpTypeVoid
1712      %func_t = OpTypeFunction %void
1713        %bool = OpTypeBool
1714        %true = OpConstantTrue %bool
1715        %int  = OpTypeInt 32 0
1716       %int_p = OpTypePointer Function %int
1717       %int_1 = OpConstant %int 1
1718       %int_0 = OpConstant %int 0
1719           %2 = OpFunction %void None %func_t
1720          %33 = OpLabel
1721          %v  = OpVariable %int_p Function
1722                OpSelectionMerge %merge None
1723                OpBranchConditional %true %l1 %l2
1724          %l1 = OpLabel
1725                OpStore %v %int_1
1726                OpBranch %merge
1727          %l2 = OpLabel
1728                OpStore %v %int_0
1729                OpBranch %merge
1730       %merge = OpLabel
1731          %ld = OpLoad %int %v
1732                OpReturn
1733                OpFunctionEnd)";
1734 
1735   SinglePassRunAndMatch<SSARewritePass>(spv_asm, true);
1736 }
1737 
1738 // Test that the RelaxedPrecision decoration on the variable to added to the
1739 // result of the OpPhi instruction.
TEST_F(LocalSSAElimTest,MultipleEdges)1740 TEST_F(LocalSSAElimTest, MultipleEdges) {
1741   const std::string spv_asm = R"(
1742   ; CHECK: OpSelectionMerge
1743   ; CHECK: [[header_bb:%\w+]] = OpLabel
1744   ; CHECK-NOT: OpLabel
1745   ; CHECK: OpSwitch {{%\w+}} {{%\w+}} 76 [[bb1:%\w+]] 17 [[bb2:%\w+]]
1746   ; CHECK-SAME: 4 [[bb2]]
1747   ; CHECK: [[bb2]] = OpLabel
1748   ; CHECK-NEXT: OpPhi [[type:%\w+]] [[val:%\w+]] [[header_bb]] %int_0 [[bb1]]
1749           OpCapability Shader
1750      %1 = OpExtInstImport "GLSL.std.450"
1751           OpMemoryModel Logical GLSL450
1752           OpEntryPoint Fragment %4 "main"
1753           OpExecutionMode %4 OriginUpperLeft
1754           OpSource ESSL 310
1755   %void = OpTypeVoid
1756      %3 = OpTypeFunction %void
1757    %int = OpTypeInt 32 1
1758   %_ptr_Function_int = OpTypePointer Function %int
1759   %int_0 = OpConstant %int 0
1760   %bool = OpTypeBool
1761   %true = OpConstantTrue %bool
1762   %false = OpConstantFalse %bool
1763   %int_1 = OpConstant %int 1
1764      %4 = OpFunction %void None %3
1765      %5 = OpLabel
1766      %8 = OpVariable %_ptr_Function_int Function
1767           OpBranch %10
1768     %10 = OpLabel
1769           OpLoopMerge %12 %13 None
1770           OpBranch %14
1771     %14 = OpLabel
1772           OpBranchConditional %true %11 %12
1773     %11 = OpLabel
1774           OpSelectionMerge %19 None
1775           OpBranchConditional %false %18 %19
1776     %18 = OpLabel
1777           OpSelectionMerge %22 None
1778           OpSwitch %int_0 %22 76 %20 17 %21 4 %21
1779     %20 = OpLabel
1780     %23 = OpLoad %int %8
1781           OpStore %8 %int_0
1782           OpBranch %21
1783     %21 = OpLabel
1784           OpBranch %22
1785     %22 = OpLabel
1786           OpBranch %19
1787     %19 = OpLabel
1788           OpBranch %13
1789     %13 = OpLabel
1790           OpBranch %10
1791     %12 = OpLabel
1792           OpReturn
1793           OpFunctionEnd
1794   )";
1795 
1796   SinglePassRunAndMatch<SSARewritePass>(spv_asm, true);
1797 }
1798 
TEST_F(LocalSSAElimTest,VariablePointerTest1)1799 TEST_F(LocalSSAElimTest, VariablePointerTest1) {
1800   // Check that the load of the first variable is still used and that the load
1801   // of the third variable is propagated.  The first load has to remain because
1802   // of the store to the variable pointer.
1803   const std::string text = R"(
1804 ; CHECK: [[v1:%\w+]] = OpVariable
1805 ; CHECK: [[v2:%\w+]] = OpVariable
1806 ; CHECK: [[v3:%\w+]] = OpVariable
1807 ; CHECK: [[ld1:%\w+]] = OpLoad %int [[v1]]
1808 ; CHECK: OpIAdd %int [[ld1]] %int_0
1809                OpCapability Shader
1810                OpCapability VariablePointers
1811           %1 = OpExtInstImport "GLSL.std.450"
1812                OpMemoryModel Logical GLSL450
1813                OpEntryPoint GLCompute %2 "main"
1814                OpExecutionMode %2 LocalSize 1 1 1
1815                OpSource GLSL 450
1816                OpMemberDecorate %_struct_3 0 Offset 0
1817                OpMemberDecorate %_struct_3 1 Offset 4
1818        %void = OpTypeVoid
1819           %5 = OpTypeFunction %void
1820         %int = OpTypeInt 32 1
1821        %bool = OpTypeBool
1822   %_struct_3 = OpTypeStruct %int %int
1823 %_ptr_Function__struct_3 = OpTypePointer Function %_struct_3
1824 %_ptr_Function_int = OpTypePointer Function %int
1825        %true = OpConstantTrue %bool
1826       %int_0 = OpConstant %int 0
1827       %int_1 = OpConstant %int 1
1828          %13 = OpConstantNull %_struct_3
1829           %2 = OpFunction %void None %5
1830          %14 = OpLabel
1831          %15 = OpVariable %_ptr_Function_int Function
1832          %16 = OpVariable %_ptr_Function_int Function
1833          %17 = OpVariable %_ptr_Function_int Function
1834                OpStore %15 %int_1
1835                OpStore %17 %int_0
1836                OpSelectionMerge %18 None
1837                OpBranchConditional %true %19 %20
1838          %19 = OpLabel
1839                OpBranch %18
1840          %20 = OpLabel
1841                OpBranch %18
1842          %18 = OpLabel
1843          %21 = OpPhi %_ptr_Function_int %15 %19 %16 %20
1844                OpStore %21 %int_0
1845          %22 = OpLoad %int %15
1846          %23 = OpLoad %int %17
1847          %24 = OpIAdd %int %22 %23
1848                OpReturn
1849                OpFunctionEnd
1850   )";
1851   SinglePassRunAndMatch<SSARewritePass>(text, false);
1852 }
1853 
TEST_F(LocalSSAElimTest,VariablePointerTest2)1854 TEST_F(LocalSSAElimTest, VariablePointerTest2) {
1855   // Check that the load of the first variable is still used and that the load
1856   // of the third variable is propagated.  The first load has to remain because
1857   // of the store to the variable pointer.
1858   const std::string text = R"(
1859 ; CHECK: [[v1:%\w+]] = OpVariable
1860 ; CHECK: [[v2:%\w+]] = OpVariable
1861 ; CHECK: [[v3:%\w+]] = OpVariable
1862 ; CHECK: [[ld1:%\w+]] = OpLoad %int [[v1]]
1863 ; CHECK: OpIAdd %int [[ld1]] %int_0
1864                OpCapability Shader
1865                OpCapability VariablePointers
1866           %1 = OpExtInstImport "GLSL.std.450"
1867                OpMemoryModel Logical GLSL450
1868                OpEntryPoint GLCompute %2 "main"
1869                OpExecutionMode %2 LocalSize 1 1 1
1870                OpSource GLSL 450
1871                OpMemberDecorate %_struct_3 0 Offset 0
1872                OpMemberDecorate %_struct_3 1 Offset 4
1873        %void = OpTypeVoid
1874           %5 = OpTypeFunction %void
1875         %int = OpTypeInt 32 1
1876        %bool = OpTypeBool
1877   %_struct_3 = OpTypeStruct %int %int
1878 %_ptr_Function__struct_3 = OpTypePointer Function %_struct_3
1879 %_ptr_Function_int = OpTypePointer Function %int
1880        %true = OpConstantTrue %bool
1881       %int_0 = OpConstant %int 0
1882       %int_1 = OpConstant %int 1
1883          %13 = OpConstantNull %_struct_3
1884           %2 = OpFunction %void None %5
1885          %14 = OpLabel
1886          %15 = OpVariable %_ptr_Function_int Function
1887          %16 = OpVariable %_ptr_Function_int Function
1888          %17 = OpVariable %_ptr_Function_int Function
1889                OpStore %15 %int_1
1890                OpStore %17 %int_0
1891                OpSelectionMerge %18 None
1892                OpBranchConditional %true %19 %20
1893          %19 = OpLabel
1894                OpBranch %18
1895          %20 = OpLabel
1896                OpBranch %18
1897          %18 = OpLabel
1898          %21 = OpPhi %_ptr_Function_int %15 %19 %16 %20
1899                OpStore %21 %int_0
1900          %22 = OpLoad %int %15
1901          %23 = OpLoad %int %17
1902          %24 = OpIAdd %int %22 %23
1903                OpReturn
1904                OpFunctionEnd
1905   )";
1906   SinglePassRunAndMatch<SSARewritePass>(text, false);
1907 }
1908 
TEST_F(LocalSSAElimTest,ChainedTrivialPhis)1909 TEST_F(LocalSSAElimTest, ChainedTrivialPhis) {
1910   // Check that the copy object get the undef value implicitly assigned in the
1911   // entry block.
1912   const std::string text = R"(
1913 ; CHECK: [[undef:%\w+]] = OpUndef %v4float
1914 ; CHECK: OpCopyObject %v4float [[undef]]
1915                OpCapability Shader
1916           %1 = OpExtInstImport "GLSL.std.450"
1917                OpMemoryModel Logical GLSL450
1918                OpEntryPoint GLCompute %2 "main"
1919                OpExecutionMode %2 LocalSize 1 18 6
1920                OpSource ESSL 310
1921        %void = OpTypeVoid
1922           %4 = OpTypeFunction %void
1923        %bool = OpTypeBool
1924       %float = OpTypeFloat 32
1925     %v4float = OpTypeVector %float 4
1926 %_ptr_Function_v4float = OpTypePointer Function %v4float
1927           %2 = OpFunction %void None %4
1928           %9 = OpLabel
1929          %10 = OpVariable %_ptr_Function_v4float Function
1930                OpBranch %11
1931          %11 = OpLabel
1932                OpLoopMerge %12 %13 None
1933                OpBranch %14
1934          %14 = OpLabel
1935          %15 = OpUndef %bool
1936                OpBranchConditional %15 %16 %12
1937          %16 = OpLabel
1938          %17 = OpUndef %bool
1939                OpSelectionMerge %18 None
1940                OpBranchConditional %17 %19 %18
1941          %19 = OpLabel
1942          %20 = OpUndef %bool
1943                OpLoopMerge %21 %22 None
1944                OpBranchConditional %20 %23 %21
1945          %23 = OpLabel
1946          %24 = OpLoad %v4float %10
1947          %25 = OpCopyObject %v4float %24
1948          %26 = OpUndef %bool
1949                OpBranch %22
1950          %22 = OpLabel
1951                OpBranch %19
1952          %21 = OpLabel
1953                OpBranch %12
1954          %18 = OpLabel
1955                OpBranch %13
1956          %13 = OpLabel
1957                OpBranch %11
1958          %12 = OpLabel
1959          %27 = OpLoad %v4float %10
1960                OpReturn
1961                OpFunctionEnd
1962   )";
1963   SinglePassRunAndMatch<SSARewritePass>(text, false);
1964 }
1965 
TEST_F(LocalSSAElimTest,Overflowtest1)1966 TEST_F(LocalSSAElimTest, Overflowtest1) {
1967   // Check that the copy object get the undef value implicitly assigned in the
1968   // entry block.
1969   const std::string text = R"(
1970 OpCapability Geometry
1971 OpMemoryModel Logical GLSL450
1972 OpEntryPoint Fragment %4 "P2Mai" %12 %17
1973 OpExecutionMode %4 OriginUpperLeft
1974 %2 = OpTypeVoid
1975 %3 = OpTypeFunction %2
1976 %6 = OpTypeFloat 32
1977 %7 = OpTypeVector %6 4
1978 %11 = OpTypePointer Input %7
1979 %16 = OpTypePointer Output %7
1980 %23 = OpTypePointer Function %7
1981 %12 = OpVariable %11 Input
1982 %17 = OpVariable %16 Output
1983 %4 = OpFunction %2 None %3
1984 %2177 = OpLabel
1985 %4194302 = OpVariable %23 Function
1986 %4194301 = OpLoad %7 %4194302
1987 OpStore %17 %4194301
1988 OpReturn
1989 OpFunctionEnd
1990   )";
1991 
1992   SetAssembleOptions(SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
1993 
1994   std::vector<Message> messages = {
1995       {SPV_MSG_ERROR, "", 0, 0, "ID overflow. Try running compact-ids."}};
1996   SetMessageConsumer(GetTestMessageConsumer(messages));
1997   auto result = SinglePassRunToBinary<SSARewritePass>(text, true);
1998   EXPECT_EQ(Pass::Status::Failure, std::get<1>(result));
1999 }
2000 
2001 // TODO(greg-lunarg): Add tests to verify handling of these cases:
2002 //
2003 //    No optimization in the presence of
2004 //      access chains
2005 //      function calls
2006 //      OpCopyMemory?
2007 //      unsupported extensions
2008 //    Others?
2009 
2010 }  // namespace
2011 }  // namespace opt
2012 }  // namespace spvtools
2013