• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 /*
2  * Copyright 2017 The Android Open Source Project
3  *
4  * Licensed under the Apache License, Version 2.0 (the "License");
5  * you may not use this file except in compliance with the License.
6  * You may obtain a copy of the License at
7  *
8  * http://www.apache.org/licenses/LICENSE-2.0
9  *
10  * Unless required by applicable law or agreed to in writing, software
11  * distributed under the License is distributed on an "AS IS" BASIS,
12  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13  * See the License for the specific language governing permissions and
14  * limitations under the License.
15  *
16  * xfrm_ctrl_test.cpp - unit tests for xfrm controllers.
17  */
18 
19 #include <cerrno>
20 #include <cinttypes>
21 #include <cstdint>
22 #include <cstdlib>
23 #include <set>
24 #include <vector>
25 
26 #include <arpa/inet.h>
27 #include <fcntl.h>
28 #include <gmock/gmock.h>
29 #include <ifaddrs.h>
30 #include <linux/if.h>
31 #include <linux/if_tun.h>
32 #include <linux/netfilter/nfnetlink.h>
33 #include <linux/netlink.h>
34 #include <netdb.h>
35 #include <netinet/in.h>
36 #include <sys/socket.h>
37 #include <sys/types.h>
38 
39 #include <android-base/macros.h>
40 #include <android-base/stringprintf.h>
41 #include <android-base/strings.h>
42 #include <android-base/unique_fd.h>
43 #include <gtest/gtest.h>
44 
45 #include "Fwmark.h"
46 #include "NetdConstants.h"
47 #include "NetlinkCommands.h"
48 #include "Permission.h"
49 #include "XfrmController.h"
50 #include "android/net/INetd.h"
51 #include "binder/IServiceManager.h"
52 #include "netdutils/MockSyscalls.h"
53 #include "netdutils/Netlink.h"
54 #include "tun_interface.h"
55 
56 using android::base::unique_fd;
57 using android::netdutils::Fd;
58 using android::netdutils::MockSyscalls;
59 using android::netdutils::Slice;
60 using android::netdutils::Status;
61 
62 using ::testing::_;
63 using ::testing::DoAll;
64 using ::testing::Invoke;
65 using ::testing::Return;
66 using ::testing::SaveArg;
67 using ::testing::SetArgPointee;
68 using ::testing::Values;
69 using ::testing::WithArg;
70 
71 /**
72  * This gMock action works like SetArgPointee, but for netdutils::Slice.
73  * It sets the memory which is pointed to by the N-th argument with the supplied value.
74  */
ACTION_TEMPLATE(SetArgSlice,HAS_1_TEMPLATE_PARAMS (int,N),AND_1_VALUE_PARAMS (value))75 ACTION_TEMPLATE(SetArgSlice, HAS_1_TEMPLATE_PARAMS(int, N), AND_1_VALUE_PARAMS(value)) {
76     Slice orig = ::testing::get<N>(args);
77     android::netdutils::copy(orig, value);
78 }
79 
80 /**
81  * This gMock action works like SaveArg, but is specialized for vector<iovec>.
82  * It copies the memory pointed to by each of the iovecs into a single vector<uint8_t>.
83  *
84  * Flattening the iovec objects cannot be done later, since there is no guarantee that the memory
85  * they point to will still be valid after the mock method returns.
86  */
ACTION_TEMPLATE(SaveFlattenedIovecs,HAS_1_TEMPLATE_PARAMS (int,N),AND_1_VALUE_PARAMS (resVec))87 ACTION_TEMPLATE(SaveFlattenedIovecs, HAS_1_TEMPLATE_PARAMS(int, N), AND_1_VALUE_PARAMS(resVec)) {
88     const std::vector<iovec>& iovs = ::testing::get<N>(args);
89 
90     for (const iovec& iov : iovs) {
91         resVec->insert(resVec->end(), reinterpret_cast<uint8_t*>(iov.iov_base),
92                        reinterpret_cast<uint8_t*>(iov.iov_base) + iov.iov_len);
93     }
94 }
95 
96 namespace android {
97 namespace net {
98 
99 static constexpr int DROID_SPI = 0xD1201D;
100 static constexpr size_t KEY_LENGTH = 32;
101 static constexpr int NLMSG_DEFAULTSIZE = 8192;
102 static constexpr uint32_t TEST_XFRM_UNDERLYING_NET = 0x512;
103 static constexpr uint32_t TEST_XFRM_IF_ID = 0x1234;
104 static constexpr uint32_t TEST_XFRM_MARK = 0x123;
105 static constexpr uint32_t TEST_XFRM_MASK = 0xFFFFFFFF;
106 
107 static constexpr char LOCALHOST_V4[] = "127.0.0.1";
108 static constexpr char LOCALHOST_V6[] = "::1";
109 static constexpr char TEST_ADDR_V4[] = "8.8.8.8";
110 static constexpr char TEST_ADDR_V6[] = "2001:4860:4860::8888";
111 
112 struct Policy {
113     xfrm_userpolicy_info info;
114     xfrm_user_tmpl tmpl;
115 };
116 
117 struct NetlinkResponse {
118     nlmsghdr hdr;
119     char buf[NLMSG_DEFAULTSIZE];
120 };
121 
expectAddressEquals(int family,const std::string & expected,const xfrm_address_t & actual)122 void expectAddressEquals(int family, const std::string& expected, const xfrm_address_t& actual) {
123     char actualStr[INET6_ADDRSTRLEN];
124     const char* ret =
125         inet_ntop(family, reinterpret_cast<const void*>(&actual), actualStr, INET6_ADDRSTRLEN);
126     EXPECT_NE(nullptr, ret) << "Unable to convert xfrm_address_t to string";
127     EXPECT_EQ(expected, actualStr);
128 }
129 
130 class XfrmControllerTest : public ::testing::Test {
131   public:
132     testing::StrictMock<netdutils::ScopedMockSyscalls> mockSyscalls;
133 };
134 
135 /* Generate function to set value refered to by 3rd argument.
136  *
137  * This allows us to mock functions that pass in a pointer, expecting the result to be put into
138  * that location.
139  */
ACTION_P(SetArg3IntValue,value)140 ACTION_P(SetArg3IntValue, value) { *static_cast<int*>(arg3) = value; }
141 
TEST_F(XfrmControllerTest,TestFchown)142 TEST_F(XfrmControllerTest, TestFchown) {
143     XfrmController ctrl;
144     unique_fd sockFd(socket(AF_INET, SOCK_DGRAM | SOCK_CLOEXEC, 0));
145 
146     EXPECT_CALL(mockSyscalls, getsockopt(Fd(sockFd), IPPROTO_UDP, UDP_ENCAP, _, _))
147         .WillOnce(DoAll(SetArg3IntValue(UDP_ENCAP_ESPINUDP), Return(netdutils::status::ok)));
148 
149     netdutils::Status res = ctrl.ipSecSetEncapSocketOwner(sockFd, 1001, getuid());
150     EXPECT_EQ(netdutils::status::ok, res);
151 
152     struct stat info;
153     EXPECT_EQ(0, fstat(sockFd.get(), &info));
154     EXPECT_EQ(1001, (int)info.st_uid);
155 }
156 
TEST_F(XfrmControllerTest,TestFchownInvalidFd)157 TEST_F(XfrmControllerTest, TestFchownInvalidFd) {
158     XfrmController ctrl;
159 
160     netdutils::Status res = ctrl.ipSecSetEncapSocketOwner(unique_fd(), 1001, getuid());
161     EXPECT_EQ(netdutils::statusFromErrno(errno, "Failed to stat socket file descriptor"), res);
162 }
163 
TEST_F(XfrmControllerTest,TestFchownIncorrectCallerUid)164 TEST_F(XfrmControllerTest, TestFchownIncorrectCallerUid) {
165     XfrmController ctrl;
166     unique_fd sockFd(socket(AF_INET, SOCK_DGRAM | SOCK_CLOEXEC, 0));
167 
168     netdutils::Status res = ctrl.ipSecSetEncapSocketOwner(sockFd, 1001, 1001);
169     EXPECT_EQ(netdutils::statusFromErrno(EPERM, "fchown disabled for non-owner calls"), res);
170 }
171 
TEST_F(XfrmControllerTest,TestFchownNonSocketFd)172 TEST_F(XfrmControllerTest, TestFchownNonSocketFd) {
173     XfrmController ctrl;
174     unique_fd fd(open("/dev/null", O_CLOEXEC));
175 
176     netdutils::Status res = ctrl.ipSecSetEncapSocketOwner(fd, 1001, getuid());
177     EXPECT_EQ(netdutils::statusFromErrno(EINVAL, "File descriptor was not a socket"), res);
178 }
179 
TEST_F(XfrmControllerTest,TestFchownNonUdp)180 TEST_F(XfrmControllerTest, TestFchownNonUdp) {
181     XfrmController ctrl;
182     unique_fd sockFd(socket(AF_INET, SOCK_STREAM | SOCK_CLOEXEC, 0));
183 
184     EXPECT_CALL(mockSyscalls, getsockopt(Fd(sockFd), IPPROTO_UDP, UDP_ENCAP, _, _))
185         .WillOnce(DoAll(SetArg3IntValue(0), Return(netdutils::status::ok)));
186 
187     netdutils::Status res = ctrl.ipSecSetEncapSocketOwner(sockFd, 1001, getuid());
188     EXPECT_EQ(netdutils::statusFromErrno(EINVAL, "Socket was not a UDP socket"), res);
189 }
190 
TEST_F(XfrmControllerTest,TestFchownNonUdpEncap)191 TEST_F(XfrmControllerTest, TestFchownNonUdpEncap) {
192     XfrmController ctrl;
193     unique_fd sockFd(socket(AF_INET, SOCK_DGRAM | SOCK_CLOEXEC, 0));
194 
195     EXPECT_CALL(mockSyscalls, getsockopt(Fd(sockFd), IPPROTO_UDP, UDP_ENCAP, _, _))
196         .WillOnce(DoAll(SetArg3IntValue(0), Return(netdutils::status::ok)));
197 
198     netdutils::Status res = ctrl.ipSecSetEncapSocketOwner(sockFd, 1001, getuid());
199     EXPECT_EQ(netdutils::statusFromErrno(EINVAL, "Socket did not have UDP-encap sockopt set"), res);
200 }
201 
202 struct testCaseParams {
203     const int version;
204     const bool xfrmInterfacesEnabled;
205 
getTunnelInterfaceNlAttrsLenandroid::net::testCaseParams206     int getTunnelInterfaceNlAttrsLen() {
207         if (xfrmInterfacesEnabled) {
208             return NLMSG_ALIGN(sizeof(XfrmController::nlattr_xfrm_interface_id));
209         } else {
210             return NLMSG_ALIGN(sizeof(XfrmController::nlattr_xfrm_mark));
211         }
212     }
213 };
214 
215 // Test class allowing IPv4/IPv6 parameterized tests.
216 class XfrmControllerParameterizedTest : public XfrmControllerTest,
217                                         public ::testing::WithParamInterface<testCaseParams> {};
218 
219 // Helper to make generated test names readable.
TestNameGenerator(::testing::TestParamInfo<testCaseParams> info)220 std::string TestNameGenerator(::testing::TestParamInfo<testCaseParams> info) {
221     std::string name = "";
222     switch (info.param.version) {
223         case 4:
224             name += "IPv4";
225             break;
226         case 5:
227             name += "IPv64DualStack";
228             break;
229         case 6:
230             name += "IPv6";
231             break;
232         default:
233             name += android::base::StringPrintf("UNKNOWN family type: %d", info.param.version);
234             break;
235     }
236 
237     name += "_";
238 
239     if (info.param.xfrmInterfacesEnabled) {
240         name += "XFRMI";
241     } else {
242         name += "VTI";
243     }
244 
245     return name;
246 }
247 
248 // The TEST_P cases below will run with each of the following value parameters.
249 INSTANTIATE_TEST_CASE_P(ByFamily, XfrmControllerParameterizedTest,
250                         Values(testCaseParams{4, false}, testCaseParams{4, true},
251                                testCaseParams{5, false}, testCaseParams{5, true},
252                                testCaseParams{6, false}, testCaseParams{6, true}),
253                         TestNameGenerator);
254 
TEST_P(XfrmControllerParameterizedTest,TestIpSecAllocateSpi)255 TEST_P(XfrmControllerParameterizedTest, TestIpSecAllocateSpi) {
256     testCaseParams params = GetParam();
257     const int version = params.version;
258     const int family = (version == 6) ? AF_INET6 : AF_INET;
259     const std::string localAddr = (version == 6) ? LOCALHOST_V6 : LOCALHOST_V4;
260     const std::string remoteAddr = (version == 6) ? TEST_ADDR_V6 : TEST_ADDR_V4;
261 
262     NetlinkResponse response{};
263     response.hdr.nlmsg_type = XFRM_MSG_ALLOCSPI;
264     Slice responseSlice = netdutils::makeSlice(response);
265 
266     // No IF_ID expected for allocSPI.
267     size_t expectedMsgLength = NLMSG_HDRLEN + NLMSG_ALIGN(sizeof(xfrm_userspi_info));
268 
269     // A vector to hold the flattened netlink message for nlMsgSlice
270     std::vector<uint8_t> nlMsgBuf;
271     EXPECT_CALL(mockSyscalls, writev(_, _))
272         .WillOnce(DoAll(SaveFlattenedIovecs<1>(&nlMsgBuf), Return(expectedMsgLength)));
273     EXPECT_CALL(mockSyscalls, read(_, _))
274         .WillOnce(DoAll(SetArgSlice<1>(responseSlice), Return(responseSlice)));
275 
276     XfrmController ctrl(params.xfrmInterfacesEnabled);
277     int outSpi = 0;
278     Status res = ctrl.ipSecAllocateSpi(1 /* resourceId */, localAddr,
279                                        remoteAddr, DROID_SPI, &outSpi);
280 
281     EXPECT_TRUE(isOk(res)) << res;
282     EXPECT_EQ(DROID_SPI, outSpi);
283     EXPECT_EQ(expectedMsgLength, nlMsgBuf.size());
284 
285     Slice nlMsgSlice = netdutils::makeSlice(nlMsgBuf);
286     nlMsgSlice = drop(nlMsgSlice, NLMSG_HDRLEN);
287 
288     xfrm_userspi_info userspi{};
289     netdutils::extract(nlMsgSlice, userspi);
290 
291     EXPECT_EQ(AF_UNSPEC, userspi.info.sel.family);
292     expectAddressEquals(family, localAddr, userspi.info.saddr);
293     expectAddressEquals(family, remoteAddr, userspi.info.id.daddr);
294 
295     EXPECT_EQ(DROID_SPI, static_cast<int>(userspi.min));
296     EXPECT_EQ(DROID_SPI, static_cast<int>(userspi.max));
297 }
298 
verifyXfrmiArguments(uint32_t mark,uint32_t mask,uint32_t ifId)299 void verifyXfrmiArguments(uint32_t mark, uint32_t mask, uint32_t ifId) {
300     // Check that correct arguments (and only those) are non-zero, and correct.
301     EXPECT_EQ(0U, mark);
302     EXPECT_EQ(0U, mask);
303     EXPECT_EQ(TEST_XFRM_IF_ID, ifId);
304 }
305 
verifyVtiArguments(uint32_t mark,uint32_t mask,uint32_t ifId)306 void verifyVtiArguments(uint32_t mark, uint32_t mask, uint32_t ifId) {
307     // Check that correct arguments (and only those) are non-zero, and correct.
308     EXPECT_EQ(TEST_XFRM_MARK, mark);
309     EXPECT_EQ(TEST_XFRM_MASK, mask);
310     EXPECT_EQ(0U, ifId);
311 }
312 
testIpSecAddSecurityAssociation(testCaseParams params,const MockSyscalls & mockSyscalls,const XfrmMode & mode)313 void testIpSecAddSecurityAssociation(testCaseParams params, const MockSyscalls& mockSyscalls,
314                                      const XfrmMode& mode) {
315     const int version = params.version;
316     const int family = (version == 6) ? AF_INET6 : AF_INET;
317     const std::string localAddr = (version == 6) ? LOCALHOST_V6 : LOCALHOST_V4;
318     const std::string remoteAddr = (version == 6) ? TEST_ADDR_V6 : TEST_ADDR_V4;
319 
320     NetlinkResponse response{};
321     response.hdr.nlmsg_type = XFRM_MSG_ALLOCSPI;
322     Slice responseSlice = netdutils::makeSlice(response);
323 
324     std::vector<uint8_t> authKey(KEY_LENGTH, 0);
325     std::vector<uint8_t> cryptKey(KEY_LENGTH, 1);
326 
327     // Calculate the length of the expected netlink message.
328     size_t expectedMsgLength =
329             NLMSG_HDRLEN + NLMSG_ALIGN(sizeof(xfrm_usersa_info)) +
330             NLA_ALIGN(offsetof(XfrmController::nlattr_algo_crypt, key) + KEY_LENGTH) +
331             NLA_ALIGN(offsetof(XfrmController::nlattr_algo_auth, key) + KEY_LENGTH);
332 
333     uint32_t testIfId = 0;
334     uint32_t testMark = 0;
335     uint32_t testMarkMask = 0;
336     uint32_t testOutputNetid = 0;
337     if (mode == XfrmMode::TUNNEL) {
338         expectedMsgLength += params.getTunnelInterfaceNlAttrsLen();
339         expectedMsgLength += NLA_ALIGN(sizeof(XfrmController::nlattr_xfrm_output_mark));
340 
341         testIfId = TEST_XFRM_IF_ID;
342         testMark = TEST_XFRM_MARK;
343         testMarkMask = TEST_XFRM_MASK;
344         testOutputNetid = TEST_XFRM_UNDERLYING_NET;
345     }
346 
347     std::vector<uint8_t> nlMsgBuf;
348     EXPECT_CALL(mockSyscalls, writev(_, _))
349         .WillOnce(DoAll(SaveFlattenedIovecs<1>(&nlMsgBuf), Return(expectedMsgLength)));
350     EXPECT_CALL(mockSyscalls, read(_, _))
351         .WillOnce(DoAll(SetArgSlice<1>(responseSlice), Return(responseSlice)));
352 
353     XfrmController ctrl(params.xfrmInterfacesEnabled);
354     Status res = ctrl.ipSecAddSecurityAssociation(
355             1 /* resourceId */, static_cast<int>(mode), localAddr, remoteAddr,
356             testOutputNetid /* underlying netid */, DROID_SPI, testMark /* mark */,
357             testMarkMask /* mask */, "hmac(sha256)" /* auth algo */, authKey,
358             128 /* auth trunc length */, "cbc(aes)" /* encryption algo */, cryptKey,
359             0 /* crypt trunc length? */, "" /* AEAD algo */, {}, 0,
360             static_cast<int>(XfrmEncapType::NONE), 0 /* local port */, 0 /* remote port */,
361             testIfId /* xfrm_if_id */);
362 
363     EXPECT_TRUE(isOk(res)) << res;
364     EXPECT_EQ(expectedMsgLength, nlMsgBuf.size());
365 
366     Slice nlMsgSlice = netdutils::makeSlice(nlMsgBuf);
367     nlMsgSlice = drop(nlMsgSlice, NLMSG_HDRLEN);
368 
369     xfrm_usersa_info usersa{};
370     netdutils::extract(nlMsgSlice, usersa);
371 
372     EXPECT_EQ(family, usersa.family);
373     EXPECT_EQ(1 /* Transform Id*/, static_cast<int>(usersa.reqid));
374     EXPECT_EQ(static_cast<int>(mode), usersa.mode);
375 
376     if (mode == XfrmMode::TUNNEL) {
377         EXPECT_EQ(XFRM_STATE_AF_UNSPEC, usersa.flags);
378     } else {
379         EXPECT_EQ(0, usersa.flags);
380     }
381 
382     EXPECT_EQ(htonl(DROID_SPI), usersa.id.spi);
383     EXPECT_EQ(IPPROTO_ESP, usersa.id.proto);
384 
385     expectAddressEquals(family, localAddr, usersa.saddr);
386     expectAddressEquals(family, remoteAddr, usersa.id.daddr);
387 
388     // Extract and check the encryption/authentication algorithms.
389     Slice attr_buf = drop(nlMsgSlice, NLA_ALIGN(sizeof(xfrm_usersa_info)));
390 
391     // Extract and check the encryption/authentication algorithm
392     XfrmController::nlattr_algo_crypt encryptAlgo{};
393     XfrmController::nlattr_algo_auth authAlgo{};
394     XfrmController::nlattr_xfrm_mark mark{};
395     XfrmController::nlattr_xfrm_output_mark outputmark{};
396     XfrmController::nlattr_xfrm_interface_id xfrm_if_id{};
397     auto attrHandler = [&encryptAlgo, &authAlgo, &mark, &outputmark, &xfrm_if_id](
398                                const nlattr& attr, const Slice& attr_payload) {
399         Slice buf = attr_payload;
400         if (attr.nla_type == XFRMA_ALG_CRYPT) {
401             encryptAlgo.hdr = attr;
402             netdutils::extract(buf, encryptAlgo.crypt);
403             buf = drop(buf, sizeof(xfrm_algo));
404             netdutils::extract(buf, encryptAlgo.key);
405         } else if (attr.nla_type == XFRMA_ALG_AUTH_TRUNC) {
406             authAlgo.hdr = attr;
407             netdutils::extract(buf, authAlgo.auth);
408             buf = drop(buf, sizeof(xfrm_algo_auth));
409             netdutils::extract(buf, authAlgo.key);
410         } else if (attr.nla_type == XFRMA_MARK) {
411             mark.hdr = attr;
412             netdutils::extract(buf, mark.mark);
413         } else if (attr.nla_type == XFRMA_OUTPUT_MARK) {
414             mark.hdr = attr;
415             netdutils::extract(buf, outputmark.outputMark);
416         } else if (attr.nla_type == XFRMA_IF_ID) {
417             xfrm_if_id.hdr = attr;
418             netdutils::extract(buf, xfrm_if_id.if_id);
419         } else {
420             FAIL() << "Unexpected nlattr type: " << attr.nla_type;
421         }
422     };
423     forEachNetlinkAttribute(attr_buf, attrHandler);
424 
425     // TODO: Use ContainerEq or ElementsAreArray to get better test failure messages.
426     EXPECT_EQ(0, memcmp(reinterpret_cast<void*>(cryptKey.data()),
427                         reinterpret_cast<void*>(&encryptAlgo.key), KEY_LENGTH));
428     EXPECT_EQ(0, memcmp(reinterpret_cast<void*>(authKey.data()),
429                         reinterpret_cast<void*>(&authAlgo.key), KEY_LENGTH));
430 
431     if (mode == XfrmMode::TUNNEL) {
432         if (params.xfrmInterfacesEnabled) {
433             verifyXfrmiArguments(mark.mark.v, mark.mark.m, xfrm_if_id.if_id);
434         } else {
435             verifyVtiArguments(mark.mark.v, mark.mark.m, xfrm_if_id.if_id);
436         }
437 
438         Fwmark fwmark;
439         fwmark.intValue = outputmark.outputMark;
440         EXPECT_EQ(testOutputNetid, fwmark.netId);
441         EXPECT_EQ(PERMISSION_SYSTEM, fwmark.permission);
442         EXPECT_TRUE(fwmark.explicitlySelected);
443         EXPECT_TRUE(fwmark.protectedFromVpn);
444     } else {
445         EXPECT_EQ(0U, outputmark.outputMark);
446         EXPECT_EQ(0U, mark.mark.v);
447         EXPECT_EQ(0U, mark.mark.m);
448         EXPECT_EQ(0U, xfrm_if_id.if_id);
449     }
450 }
451 
TEST_P(XfrmControllerParameterizedTest,TestTransportModeIpSecAddSecurityAssociation)452 TEST_P(XfrmControllerParameterizedTest, TestTransportModeIpSecAddSecurityAssociation) {
453     testCaseParams params = GetParam();
454     testIpSecAddSecurityAssociation(params, mockSyscalls, XfrmMode::TRANSPORT);
455 }
456 
TEST_P(XfrmControllerParameterizedTest,TestTunnelModeIpSecAddSecurityAssociation)457 TEST_P(XfrmControllerParameterizedTest, TestTunnelModeIpSecAddSecurityAssociation) {
458     testCaseParams params = GetParam();
459     testIpSecAddSecurityAssociation(params, mockSyscalls, XfrmMode::TUNNEL);
460 }
461 
TEST_F(XfrmControllerTest,TestIpSecAddSecurityAssociationIPv4Encap)462 TEST_F(XfrmControllerTest, TestIpSecAddSecurityAssociationIPv4Encap) {
463     // TODO: Implement this test, which is nearly identical to
464     // TestIpSecAddSecurityAssociation.
465 }
466 
467 // Test that input validation rejects IPv6 UDP encap.
TEST_F(XfrmControllerTest,TestIpSecAddSecurityAssociationIPv6Encap)468 TEST_F(XfrmControllerTest, TestIpSecAddSecurityAssociationIPv6Encap) {
469     EXPECT_CALL(mockSyscalls, writev(_, _)).Times(0);
470 
471     XfrmController ctrl;
472     Status res = ctrl.ipSecAddSecurityAssociation(
473             1, static_cast<int>(XfrmMode::TRANSPORT), LOCALHOST_V6, TEST_ADDR_V6, 0, DROID_SPI, 0,
474             0, "hmac(sha256)", {}, 128, "cbc(aes)", {}, 0, "", {}, 0,
475             static_cast<int>(XfrmEncapType::ESPINUDP_NON_IKE), 0, 0, 0);
476 
477     EXPECT_FALSE(isOk(res)) << "IPv6 UDP encap not rejected";
478 }
479 
TEST_F(XfrmControllerTest,TestIpSecApplyTransportModeTransformChecksFamily)480 TEST_F(XfrmControllerTest, TestIpSecApplyTransportModeTransformChecksFamily) {
481     struct sockaddr socketaddr;
482     socketaddr.sa_family = AF_INET;
483 
484     unique_fd sock(socket(AF_INET, SOCK_STREAM | SOCK_CLOEXEC, 0));
485 
486     EXPECT_CALL(mockSyscalls, getsockname(Fd(sock), _, _))
487         .WillOnce(DoAll(SetArgPointee<1>(socketaddr), Return(netdutils::status::ok)));
488 
489     XfrmController ctrl;
490     Status res = ctrl.ipSecApplyTransportModeTransform(sock, 1 /* resourceId */,
491                                                        static_cast<int>(XfrmDirection::OUT),
492                                                        LOCALHOST_V6, TEST_ADDR_V6, DROID_SPI);
493 
494     EXPECT_EQ(res.code(), EINVAL);
495 }
496 
TEST_P(XfrmControllerParameterizedTest,TestIpSecApplyTransportModeTransform)497 TEST_P(XfrmControllerParameterizedTest, TestIpSecApplyTransportModeTransform) {
498     testCaseParams params = GetParam();
499     const int version = params.version;
500     const int sockFamily = (version == 4) ? AF_INET : AF_INET6;
501     const int xfrmFamily = (version == 6) ? AF_INET6: AF_INET;
502     const std::string localAddr = (version == 6) ? LOCALHOST_V6 : LOCALHOST_V4;
503     const std::string remoteAddr = (version == 6) ? TEST_ADDR_V6 : TEST_ADDR_V4;
504 
505     size_t optlen = 0;
506     Policy policy{};
507     // Need to cast from void* in order to "SaveArg" policy. Easier to invoke a
508     // lambda than to write a gMock action.
509     auto SavePolicy = [&policy](const void* value) {
510         policy = *reinterpret_cast<const Policy*>(value);
511     };
512 
513     struct sockaddr socketaddr;
514     socketaddr.sa_family = sockFamily;
515 
516     unique_fd sock(socket(sockFamily, SOCK_STREAM | SOCK_CLOEXEC, 0));
517 
518     EXPECT_CALL(mockSyscalls, getsockname(_, _, _))
519         .WillOnce(DoAll(SetArgPointee<1>(socketaddr), Return(netdutils::status::ok)));
520 
521     EXPECT_CALL(mockSyscalls, setsockopt(_, _, _, _, _))
522         .WillOnce(DoAll(WithArg<3>(Invoke(SavePolicy)), SaveArg<4>(&optlen),
523                         Return(netdutils::status::ok)));
524 
525     XfrmController ctrl(params.xfrmInterfacesEnabled);
526     Status res = ctrl.ipSecApplyTransportModeTransform(sock, 1 /* resourceId */,
527                                                        static_cast<int>(XfrmDirection::OUT),
528                                                        localAddr, remoteAddr, DROID_SPI);
529 
530     EXPECT_TRUE(isOk(res)) << res;
531     EXPECT_EQ(sizeof(Policy), optlen);
532 
533     EXPECT_EQ(1 /* resourceId */, static_cast<int>(policy.tmpl.reqid));
534     EXPECT_EQ(htonl(DROID_SPI), policy.tmpl.id.spi);
535 
536     expectAddressEquals(xfrmFamily, localAddr, policy.tmpl.saddr);
537     expectAddressEquals(xfrmFamily, remoteAddr, policy.tmpl.id.daddr);
538 }
539 
TEST_P(XfrmControllerParameterizedTest,TestIpSecRemoveTransportModeTransform)540 TEST_P(XfrmControllerParameterizedTest, TestIpSecRemoveTransportModeTransform) {
541     testCaseParams params = GetParam();
542     const int version = params.version;
543     const int family = (version == 6) ? AF_INET6 : AF_INET;
544     const std::string localAddr = (version == 6) ? LOCALHOST_V6 : LOCALHOST_V4;
545     const std::string remoteAddr = (version == 6) ? TEST_ADDR_V6 : TEST_ADDR_V4;
546 
547     socklen_t optlen;
548     const void* optval;
549 
550     struct sockaddr socketaddr;
551     socketaddr.sa_family = family;
552 
553     unique_fd sock(socket(family, SOCK_STREAM | SOCK_CLOEXEC, 0));
554 
555     EXPECT_CALL(mockSyscalls, getsockname(_, _, _))
556         .WillOnce(DoAll(SetArgPointee<1>(socketaddr), Return(netdutils::status::ok)));
557 
558     EXPECT_CALL(mockSyscalls, setsockopt(_, _, _, _, _))
559         .WillOnce(DoAll(SaveArg<3>(&optval), SaveArg<4>(&optlen),
560                         Return(netdutils::status::ok)));
561     XfrmController ctrl(params.xfrmInterfacesEnabled);
562     Status res = ctrl.ipSecRemoveTransportModeTransform(sock);
563 
564     EXPECT_TRUE(isOk(res)) << res;
565     EXPECT_EQ(nullptr, optval);
566     EXPECT_EQ(static_cast<socklen_t>(0), optlen);
567 }
568 
parseTunnelNetlinkAttrs(XfrmController::nlattr_xfrm_mark * mark,XfrmController::nlattr_xfrm_interface_id * xfrm_if_id,Slice attr_buf)569 void parseTunnelNetlinkAttrs(XfrmController::nlattr_xfrm_mark* mark,
570                              XfrmController::nlattr_xfrm_interface_id* xfrm_if_id, Slice attr_buf) {
571     auto attrHandler = [mark, xfrm_if_id](const nlattr& attr, const Slice& attr_payload) {
572         Slice buf = attr_payload;
573         if (attr.nla_type == XFRMA_MARK) {
574             mark->hdr = attr;
575             netdutils::extract(buf, mark->mark);
576         } else if (attr.nla_type == XFRMA_IF_ID) {
577             xfrm_if_id->hdr = attr;
578             netdutils::extract(buf, xfrm_if_id->if_id);
579         } else {
580             FAIL() << "Unexpected nlattr type: " << attr.nla_type;
581         }
582     };
583     forEachNetlinkAttribute(attr_buf, attrHandler);
584 }
585 
TEST_P(XfrmControllerParameterizedTest,TestIpSecDeleteSecurityAssociation)586 TEST_P(XfrmControllerParameterizedTest, TestIpSecDeleteSecurityAssociation) {
587     testCaseParams params = GetParam();
588     const int version = params.version;
589     const int family = (version == 6) ? AF_INET6 : AF_INET;
590     const std::string localAddr = (version == 6) ? LOCALHOST_V6 : LOCALHOST_V4;
591     const std::string remoteAddr = (version == 6) ? TEST_ADDR_V6 : TEST_ADDR_V4;
592 
593     NetlinkResponse response{};
594     response.hdr.nlmsg_type = XFRM_MSG_DELSA;
595     Slice responseSlice = netdutils::makeSlice(response);
596 
597     size_t expectedMsgLength = NLMSG_HDRLEN + NLMSG_ALIGN(sizeof(xfrm_usersa_id)) +
598                                params.getTunnelInterfaceNlAttrsLen();
599 
600     std::vector<uint8_t> nlMsgBuf;
601     EXPECT_CALL(mockSyscalls, writev(_, _))
602         .WillOnce(DoAll(SaveFlattenedIovecs<1>(&nlMsgBuf), Return(expectedMsgLength)));
603     EXPECT_CALL(mockSyscalls, read(_, _))
604         .WillOnce(DoAll(SetArgSlice<1>(responseSlice), Return(responseSlice)));
605 
606     XfrmController ctrl(params.xfrmInterfacesEnabled);
607     Status res = ctrl.ipSecDeleteSecurityAssociation(1 /* resourceId */, localAddr, remoteAddr,
608                                                      DROID_SPI, TEST_XFRM_MARK, TEST_XFRM_MASK,
609                                                      TEST_XFRM_IF_ID);
610 
611     EXPECT_TRUE(isOk(res)) << res;
612     EXPECT_EQ(expectedMsgLength, nlMsgBuf.size());
613 
614     Slice nlMsgSlice = netdutils::makeSlice(nlMsgBuf);
615     nlMsgSlice = netdutils::drop(nlMsgSlice, NLMSG_HDRLEN);
616 
617     // Extract and check the usersa_id
618     xfrm_usersa_id said{};
619     netdutils::extract(nlMsgSlice, said);
620     nlMsgSlice = drop(nlMsgSlice, sizeof(xfrm_usersa_id));
621     EXPECT_EQ(htonl(DROID_SPI), said.spi);
622     expectAddressEquals(family, remoteAddr, said.daddr);
623 
624     // Extract and check the marks and xfrm_if_id
625     XfrmController::nlattr_xfrm_mark mark{};
626     XfrmController::nlattr_xfrm_interface_id xfrm_if_id{};
627     parseTunnelNetlinkAttrs(&mark, &xfrm_if_id, nlMsgSlice);
628 
629     if (params.xfrmInterfacesEnabled) {
630         verifyXfrmiArguments(mark.mark.v, mark.mark.m, xfrm_if_id.if_id);
631     } else {
632         verifyVtiArguments(mark.mark.v, mark.mark.m, xfrm_if_id.if_id);
633     }
634 }
635 
TEST_P(XfrmControllerParameterizedTest,TestIpSecAddSecurityPolicy)636 TEST_P(XfrmControllerParameterizedTest, TestIpSecAddSecurityPolicy) {
637     testCaseParams params = GetParam();
638     const int version = params.version;
639     const int family = (version == 6) ? AF_INET6 : AF_INET;
640     const std::string localAddr = (version == 6) ? LOCALHOST_V6 : LOCALHOST_V4;
641     const std::string remoteAddr = (version == 6) ? TEST_ADDR_V6 : TEST_ADDR_V4;
642 
643     NetlinkResponse response{};
644     response.hdr.nlmsg_type = XFRM_MSG_NEWPOLICY;
645     Slice responseSlice = netdutils::makeSlice(response);
646 
647     size_t expectedMsgLength = NLMSG_HDRLEN + NLMSG_ALIGN(sizeof(xfrm_userpolicy_info)) +
648                                NLMSG_ALIGN(sizeof(XfrmController::nlattr_user_tmpl)) +
649                                params.getTunnelInterfaceNlAttrsLen();
650 
651     std::vector<uint8_t> nlMsgBuf;
652     EXPECT_CALL(mockSyscalls, writev(_, _))
653         .WillOnce(DoAll(SaveFlattenedIovecs<1>(&nlMsgBuf), Return(expectedMsgLength)));
654     EXPECT_CALL(mockSyscalls, read(_, _))
655         .WillOnce(DoAll(SetArgSlice<1>(responseSlice), Return(responseSlice)));
656 
657     XfrmController ctrl(params.xfrmInterfacesEnabled);
658     Status res = ctrl.ipSecAddSecurityPolicy(
659             1 /* resourceId */, family, static_cast<int>(XfrmDirection::OUT), localAddr, remoteAddr,
660             0 /* SPI */, TEST_XFRM_MARK, TEST_XFRM_MASK, TEST_XFRM_IF_ID);
661 
662     EXPECT_TRUE(isOk(res)) << res;
663     EXPECT_EQ(expectedMsgLength, nlMsgBuf.size());
664 
665     Slice nlMsgSlice = netdutils::makeSlice(nlMsgBuf);
666     nlmsghdr hdr;
667     netdutils::extract(nlMsgSlice, hdr);
668     EXPECT_EQ(XFRM_MSG_NEWPOLICY, hdr.nlmsg_type);
669 
670     nlMsgSlice = netdutils::drop(nlMsgSlice, NLMSG_HDRLEN);
671     xfrm_userpolicy_info userpolicy{};
672     netdutils::extract(nlMsgSlice, userpolicy);
673 
674     EXPECT_EQ(static_cast<uint8_t>(XfrmDirection::OUT), userpolicy.dir);
675 
676     // Drop the user policy info.
677     Slice attr_buf = drop(nlMsgSlice, NLA_ALIGN(sizeof(xfrm_userpolicy_info)));
678 
679     // Extract and check the user tmpl and mark.
680     XfrmController::nlattr_user_tmpl usertmpl{};
681     XfrmController::nlattr_xfrm_mark mark{};
682     XfrmController::nlattr_xfrm_interface_id xfrm_if_id{};
683     auto attrHandler = [&usertmpl, &mark, &xfrm_if_id](const nlattr& attr,
684                                                        const Slice& attr_payload) {
685         Slice buf = attr_payload;
686         if (attr.nla_type == XFRMA_TMPL) {
687             usertmpl.hdr = attr;
688             netdutils::extract(buf, usertmpl.tmpl);
689         } else if (attr.nla_type == XFRMA_MARK) {
690             mark.hdr = attr;
691             netdutils::extract(buf, mark.mark);
692         } else if (attr.nla_type == XFRMA_IF_ID) {
693             mark.hdr = attr;
694             netdutils::extract(buf, xfrm_if_id.if_id);
695         } else {
696             FAIL() << "Unexpected nlattr type: " << attr.nla_type;
697         }
698     };
699     forEachNetlinkAttribute(attr_buf, attrHandler);
700 
701     expectAddressEquals(family, remoteAddr, usertmpl.tmpl.id.daddr);
702 
703     if (params.xfrmInterfacesEnabled) {
704         verifyXfrmiArguments(mark.mark.v, mark.mark.m, xfrm_if_id.if_id);
705     } else {
706         verifyVtiArguments(mark.mark.v, mark.mark.m, xfrm_if_id.if_id);
707     }
708 }
709 
TEST_P(XfrmControllerParameterizedTest,TestIpSecUpdateSecurityPolicy)710 TEST_P(XfrmControllerParameterizedTest, TestIpSecUpdateSecurityPolicy) {
711     testCaseParams params = GetParam();
712     const int version = params.version;
713     const int family = (version == 6) ? AF_INET6 : AF_INET;
714     const std::string localAddr = (version == 6) ? LOCALHOST_V6 : LOCALHOST_V4;
715     const std::string remoteAddr = (version == 6) ? TEST_ADDR_V6 : TEST_ADDR_V4;
716 
717     NetlinkResponse response{};
718     response.hdr.nlmsg_type = XFRM_MSG_UPDPOLICY;
719     Slice responseSlice = netdutils::makeSlice(response);
720 
721     size_t expectedMsgLength = NLMSG_HDRLEN + NLMSG_ALIGN(sizeof(xfrm_userpolicy_info)) +
722                                NLMSG_ALIGN(sizeof(XfrmController::nlattr_user_tmpl)) +
723                                params.getTunnelInterfaceNlAttrsLen();
724 
725     std::vector<uint8_t> nlMsgBuf;
726     EXPECT_CALL(mockSyscalls, writev(_, _))
727         .WillOnce(DoAll(SaveFlattenedIovecs<1>(&nlMsgBuf), Return(expectedMsgLength)));
728     EXPECT_CALL(mockSyscalls, read(_, _))
729         .WillOnce(DoAll(SetArgSlice<1>(responseSlice), Return(responseSlice)));
730 
731     XfrmController ctrl(params.xfrmInterfacesEnabled);
732     Status res = ctrl.ipSecUpdateSecurityPolicy(
733             1 /* resourceId */, family, static_cast<int>(XfrmDirection::OUT), localAddr, remoteAddr,
734             0 /* SPI */, TEST_XFRM_MARK /* Mark */, TEST_XFRM_MARK /* Mask */,
735             TEST_XFRM_IF_ID /* xfrm_if_id */);
736 
737     EXPECT_TRUE(isOk(res)) << res;
738     EXPECT_EQ(expectedMsgLength, nlMsgBuf.size());
739 
740     Slice nlMsgSlice = netdutils::makeSlice(nlMsgBuf);
741     nlmsghdr hdr;
742     netdutils::extract(nlMsgSlice, hdr);
743     EXPECT_EQ(XFRM_MSG_UPDPOLICY, hdr.nlmsg_type);
744 }
745 
TEST_P(XfrmControllerParameterizedTest,TestIpSecDeleteSecurityPolicy)746 TEST_P(XfrmControllerParameterizedTest, TestIpSecDeleteSecurityPolicy) {
747     testCaseParams params = GetParam();
748     const int version = params.version;
749     const int family = (version == 6) ? AF_INET6 : AF_INET;
750     const std::string localAddr = (version == 6) ? LOCALHOST_V6 : LOCALHOST_V4;
751     const std::string remoteAddr = (version == 6) ? TEST_ADDR_V6 : TEST_ADDR_V4;
752 
753     NetlinkResponse response{};
754     response.hdr.nlmsg_type = XFRM_MSG_DELPOLICY;
755     Slice responseSlice = netdutils::makeSlice(response);
756 
757     size_t expectedMsgLength = NLMSG_HDRLEN + NLMSG_ALIGN(sizeof(xfrm_userpolicy_id)) +
758                                params.getTunnelInterfaceNlAttrsLen();
759 
760     std::vector<uint8_t> nlMsgBuf;
761     EXPECT_CALL(mockSyscalls, writev(_, _))
762         .WillOnce(DoAll(SaveFlattenedIovecs<1>(&nlMsgBuf), Return(expectedMsgLength)));
763     EXPECT_CALL(mockSyscalls, read(_, _))
764         .WillOnce(DoAll(SetArgSlice<1>(responseSlice), Return(responseSlice)));
765 
766     XfrmController ctrl(params.xfrmInterfacesEnabled);
767     Status res = ctrl.ipSecDeleteSecurityPolicy(1 /* resourceId */, family,
768                                                 static_cast<int>(XfrmDirection::OUT),
769                                                 TEST_XFRM_MARK, TEST_XFRM_MASK, TEST_XFRM_IF_ID);
770 
771     EXPECT_TRUE(isOk(res)) << res;
772     EXPECT_EQ(expectedMsgLength, nlMsgBuf.size());
773 
774     Slice nlMsgSlice = netdutils::makeSlice(nlMsgBuf);
775     nlMsgSlice = netdutils::drop(nlMsgSlice, NLMSG_HDRLEN);
776 
777     xfrm_userpolicy_id policyid{};
778     netdutils::extract(nlMsgSlice, policyid);
779 
780     EXPECT_EQ(static_cast<uint8_t>(XfrmDirection::OUT), policyid.dir);
781 
782     // Drop the user policy id.
783     nlMsgSlice = drop(nlMsgSlice, NLA_ALIGN(sizeof(xfrm_userpolicy_id)));
784 
785     // Extract and check the marks and xfrm_if_id
786     XfrmController::nlattr_xfrm_mark mark{};
787     XfrmController::nlattr_xfrm_interface_id xfrm_if_id{};
788     parseTunnelNetlinkAttrs(&mark, &xfrm_if_id, nlMsgSlice);
789 
790     if (params.xfrmInterfacesEnabled) {
791         verifyXfrmiArguments(mark.mark.v, mark.mark.m, xfrm_if_id.if_id);
792     } else {
793         verifyVtiArguments(mark.mark.v, mark.mark.m, xfrm_if_id.if_id);
794     }
795 }
796 
797 // TODO: Add tests for VTIs, ensuring that we are sending the correct data over netlink.
798 
799 } // namespace net
800 } // namespace android
801