1 // Copyright (c) 2017 The Khronos Group Inc.
2 // Copyright (c) 2017 Valve Corporation
3 // Copyright (c) 2017 LunarG Inc.
4 //
5 // Licensed under the Apache License, Version 2.0 (the "License");
6 // you may not use this file except in compliance with the License.
7 // You may obtain a copy of the License at
8 //
9 // http://www.apache.org/licenses/LICENSE-2.0
10 //
11 // Unless required by applicable law or agreed to in writing, software
12 // distributed under the License is distributed on an "AS IS" BASIS,
13 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14 // See the License for the specific language governing permissions and
15 // limitations under the License.
16
17 #include "source/opt/inline_pass.h"
18
19 #include <unordered_set>
20 #include <utility>
21
22 #include "source/cfa.h"
23 #include "source/opt/reflect.h"
24 #include "source/util/make_unique.h"
25
26 // Indices of operands in SPIR-V instructions
27
28 static const int kSpvFunctionCallFunctionId = 2;
29 static const int kSpvFunctionCallArgumentId = 3;
30 static const int kSpvReturnValueId = 0;
31
32 namespace spvtools {
33 namespace opt {
34
AddPointerToType(uint32_t type_id,SpvStorageClass storage_class)35 uint32_t InlinePass::AddPointerToType(uint32_t type_id,
36 SpvStorageClass storage_class) {
37 uint32_t resultId = context()->TakeNextId();
38 if (resultId == 0) {
39 return resultId;
40 }
41
42 std::unique_ptr<Instruction> type_inst(
43 new Instruction(context(), SpvOpTypePointer, 0, resultId,
44 {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS,
45 {uint32_t(storage_class)}},
46 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {type_id}}}));
47 context()->AddType(std::move(type_inst));
48 analysis::Type* pointeeTy;
49 std::unique_ptr<analysis::Pointer> pointerTy;
50 std::tie(pointeeTy, pointerTy) =
51 context()->get_type_mgr()->GetTypeAndPointerType(type_id,
52 SpvStorageClassFunction);
53 context()->get_type_mgr()->RegisterType(resultId, *pointerTy);
54 return resultId;
55 }
56
AddBranch(uint32_t label_id,std::unique_ptr<BasicBlock> * block_ptr)57 void InlinePass::AddBranch(uint32_t label_id,
58 std::unique_ptr<BasicBlock>* block_ptr) {
59 std::unique_ptr<Instruction> newBranch(
60 new Instruction(context(), SpvOpBranch, 0, 0,
61 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {label_id}}}));
62 (*block_ptr)->AddInstruction(std::move(newBranch));
63 }
64
AddBranchCond(uint32_t cond_id,uint32_t true_id,uint32_t false_id,std::unique_ptr<BasicBlock> * block_ptr)65 void InlinePass::AddBranchCond(uint32_t cond_id, uint32_t true_id,
66 uint32_t false_id,
67 std::unique_ptr<BasicBlock>* block_ptr) {
68 std::unique_ptr<Instruction> newBranch(
69 new Instruction(context(), SpvOpBranchConditional, 0, 0,
70 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {cond_id}},
71 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {true_id}},
72 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {false_id}}}));
73 (*block_ptr)->AddInstruction(std::move(newBranch));
74 }
75
AddLoopMerge(uint32_t merge_id,uint32_t continue_id,std::unique_ptr<BasicBlock> * block_ptr)76 void InlinePass::AddLoopMerge(uint32_t merge_id, uint32_t continue_id,
77 std::unique_ptr<BasicBlock>* block_ptr) {
78 std::unique_ptr<Instruction> newLoopMerge(new Instruction(
79 context(), SpvOpLoopMerge, 0, 0,
80 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {merge_id}},
81 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {continue_id}},
82 {spv_operand_type_t::SPV_OPERAND_TYPE_LOOP_CONTROL, {0}}}));
83 (*block_ptr)->AddInstruction(std::move(newLoopMerge));
84 }
85
AddStore(uint32_t ptr_id,uint32_t val_id,std::unique_ptr<BasicBlock> * block_ptr,const Instruction * line_inst,const DebugScope & dbg_scope)86 void InlinePass::AddStore(uint32_t ptr_id, uint32_t val_id,
87 std::unique_ptr<BasicBlock>* block_ptr,
88 const Instruction* line_inst,
89 const DebugScope& dbg_scope) {
90 std::unique_ptr<Instruction> newStore(
91 new Instruction(context(), SpvOpStore, 0, 0,
92 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}},
93 {spv_operand_type_t::SPV_OPERAND_TYPE_ID, {val_id}}}));
94 if (line_inst != nullptr) {
95 newStore->dbg_line_insts().push_back(*line_inst);
96 }
97 newStore->SetDebugScope(dbg_scope);
98 (*block_ptr)->AddInstruction(std::move(newStore));
99 }
100
AddLoad(uint32_t type_id,uint32_t resultId,uint32_t ptr_id,std::unique_ptr<BasicBlock> * block_ptr,const Instruction * line_inst,const DebugScope & dbg_scope)101 void InlinePass::AddLoad(uint32_t type_id, uint32_t resultId, uint32_t ptr_id,
102 std::unique_ptr<BasicBlock>* block_ptr,
103 const Instruction* line_inst,
104 const DebugScope& dbg_scope) {
105 std::unique_ptr<Instruction> newLoad(
106 new Instruction(context(), SpvOpLoad, type_id, resultId,
107 {{spv_operand_type_t::SPV_OPERAND_TYPE_ID, {ptr_id}}}));
108 if (line_inst != nullptr) {
109 newLoad->dbg_line_insts().push_back(*line_inst);
110 }
111 newLoad->SetDebugScope(dbg_scope);
112 (*block_ptr)->AddInstruction(std::move(newLoad));
113 }
114
NewLabel(uint32_t label_id)115 std::unique_ptr<Instruction> InlinePass::NewLabel(uint32_t label_id) {
116 std::unique_ptr<Instruction> newLabel(
117 new Instruction(context(), SpvOpLabel, 0, label_id, {}));
118 return newLabel;
119 }
120
GetFalseId()121 uint32_t InlinePass::GetFalseId() {
122 if (false_id_ != 0) return false_id_;
123 false_id_ = get_module()->GetGlobalValue(SpvOpConstantFalse);
124 if (false_id_ != 0) return false_id_;
125 uint32_t boolId = get_module()->GetGlobalValue(SpvOpTypeBool);
126 if (boolId == 0) {
127 boolId = context()->TakeNextId();
128 if (boolId == 0) {
129 return 0;
130 }
131 get_module()->AddGlobalValue(SpvOpTypeBool, boolId, 0);
132 }
133 false_id_ = context()->TakeNextId();
134 if (false_id_ == 0) {
135 return 0;
136 }
137 get_module()->AddGlobalValue(SpvOpConstantFalse, false_id_, boolId);
138 return false_id_;
139 }
140
MapParams(Function * calleeFn,BasicBlock::iterator call_inst_itr,std::unordered_map<uint32_t,uint32_t> * callee2caller)141 void InlinePass::MapParams(
142 Function* calleeFn, BasicBlock::iterator call_inst_itr,
143 std::unordered_map<uint32_t, uint32_t>* callee2caller) {
144 int param_idx = 0;
145 calleeFn->ForEachParam(
146 [&call_inst_itr, ¶m_idx, &callee2caller](const Instruction* cpi) {
147 const uint32_t pid = cpi->result_id();
148 (*callee2caller)[pid] = call_inst_itr->GetSingleWordOperand(
149 kSpvFunctionCallArgumentId + param_idx);
150 ++param_idx;
151 });
152 }
153
CloneAndMapLocals(Function * calleeFn,std::vector<std::unique_ptr<Instruction>> * new_vars,std::unordered_map<uint32_t,uint32_t> * callee2caller,analysis::DebugInlinedAtContext * inlined_at_ctx)154 bool InlinePass::CloneAndMapLocals(
155 Function* calleeFn, std::vector<std::unique_ptr<Instruction>>* new_vars,
156 std::unordered_map<uint32_t, uint32_t>* callee2caller,
157 analysis::DebugInlinedAtContext* inlined_at_ctx) {
158 auto callee_block_itr = calleeFn->begin();
159 auto callee_var_itr = callee_block_itr->begin();
160 while (callee_var_itr->opcode() == SpvOp::SpvOpVariable ||
161 callee_var_itr->GetOpenCL100DebugOpcode() ==
162 OpenCLDebugInfo100DebugDeclare) {
163 if (callee_var_itr->opcode() != SpvOp::SpvOpVariable) {
164 ++callee_var_itr;
165 continue;
166 }
167
168 std::unique_ptr<Instruction> var_inst(callee_var_itr->Clone(context()));
169 uint32_t newId = context()->TakeNextId();
170 if (newId == 0) {
171 return false;
172 }
173 get_decoration_mgr()->CloneDecorations(callee_var_itr->result_id(), newId);
174 var_inst->SetResultId(newId);
175 var_inst->UpdateDebugInlinedAt(
176 context()->get_debug_info_mgr()->BuildDebugInlinedAtChain(
177 callee_var_itr->GetDebugInlinedAt(), inlined_at_ctx));
178 (*callee2caller)[callee_var_itr->result_id()] = newId;
179 new_vars->push_back(std::move(var_inst));
180 ++callee_var_itr;
181 }
182 return true;
183 }
184
CreateReturnVar(Function * calleeFn,std::vector<std::unique_ptr<Instruction>> * new_vars)185 uint32_t InlinePass::CreateReturnVar(
186 Function* calleeFn, std::vector<std::unique_ptr<Instruction>>* new_vars) {
187 uint32_t returnVarId = 0;
188 const uint32_t calleeTypeId = calleeFn->type_id();
189 analysis::TypeManager* type_mgr = context()->get_type_mgr();
190 assert(type_mgr->GetType(calleeTypeId)->AsVoid() == nullptr &&
191 "Cannot create a return variable of type void.");
192 // Find or create ptr to callee return type.
193 uint32_t returnVarTypeId =
194 type_mgr->FindPointerToType(calleeTypeId, SpvStorageClassFunction);
195
196 if (returnVarTypeId == 0) {
197 returnVarTypeId = AddPointerToType(calleeTypeId, SpvStorageClassFunction);
198 if (returnVarTypeId == 0) {
199 return 0;
200 }
201 }
202
203 // Add return var to new function scope variables.
204 returnVarId = context()->TakeNextId();
205 if (returnVarId == 0) {
206 return 0;
207 }
208
209 std::unique_ptr<Instruction> var_inst(
210 new Instruction(context(), SpvOpVariable, returnVarTypeId, returnVarId,
211 {{spv_operand_type_t::SPV_OPERAND_TYPE_STORAGE_CLASS,
212 {SpvStorageClassFunction}}}));
213 new_vars->push_back(std::move(var_inst));
214 get_decoration_mgr()->CloneDecorations(calleeFn->result_id(), returnVarId);
215 return returnVarId;
216 }
217
IsSameBlockOp(const Instruction * inst) const218 bool InlinePass::IsSameBlockOp(const Instruction* inst) const {
219 return inst->opcode() == SpvOpSampledImage || inst->opcode() == SpvOpImage;
220 }
221
CloneSameBlockOps(std::unique_ptr<Instruction> * inst,std::unordered_map<uint32_t,uint32_t> * postCallSB,std::unordered_map<uint32_t,Instruction * > * preCallSB,std::unique_ptr<BasicBlock> * block_ptr)222 bool InlinePass::CloneSameBlockOps(
223 std::unique_ptr<Instruction>* inst,
224 std::unordered_map<uint32_t, uint32_t>* postCallSB,
225 std::unordered_map<uint32_t, Instruction*>* preCallSB,
226 std::unique_ptr<BasicBlock>* block_ptr) {
227 return (*inst)->WhileEachInId([&postCallSB, &preCallSB, &block_ptr,
228 this](uint32_t* iid) {
229 const auto mapItr = (*postCallSB).find(*iid);
230 if (mapItr == (*postCallSB).end()) {
231 const auto mapItr2 = (*preCallSB).find(*iid);
232 if (mapItr2 != (*preCallSB).end()) {
233 // Clone pre-call same-block ops, map result id.
234 const Instruction* inInst = mapItr2->second;
235 std::unique_ptr<Instruction> sb_inst(inInst->Clone(context()));
236 if (!CloneSameBlockOps(&sb_inst, postCallSB, preCallSB, block_ptr)) {
237 return false;
238 }
239
240 const uint32_t rid = sb_inst->result_id();
241 const uint32_t nid = context()->TakeNextId();
242 if (nid == 0) {
243 return false;
244 }
245 get_decoration_mgr()->CloneDecorations(rid, nid);
246 sb_inst->SetResultId(nid);
247 (*postCallSB)[rid] = nid;
248 *iid = nid;
249 (*block_ptr)->AddInstruction(std::move(sb_inst));
250 }
251 } else {
252 // Reset same-block op operand.
253 *iid = mapItr->second;
254 }
255 return true;
256 });
257 }
258
MoveInstsBeforeEntryBlock(std::unordered_map<uint32_t,Instruction * > * preCallSB,BasicBlock * new_blk_ptr,BasicBlock::iterator call_inst_itr,UptrVectorIterator<BasicBlock> call_block_itr)259 void InlinePass::MoveInstsBeforeEntryBlock(
260 std::unordered_map<uint32_t, Instruction*>* preCallSB,
261 BasicBlock* new_blk_ptr, BasicBlock::iterator call_inst_itr,
262 UptrVectorIterator<BasicBlock> call_block_itr) {
263 for (auto cii = call_block_itr->begin(); cii != call_inst_itr;
264 cii = call_block_itr->begin()) {
265 Instruction* inst = &*cii;
266 inst->RemoveFromList();
267 std::unique_ptr<Instruction> cp_inst(inst);
268 // Remember same-block ops for possible regeneration.
269 if (IsSameBlockOp(&*cp_inst)) {
270 auto* sb_inst_ptr = cp_inst.get();
271 (*preCallSB)[cp_inst->result_id()] = sb_inst_ptr;
272 }
273 new_blk_ptr->AddInstruction(std::move(cp_inst));
274 }
275 }
276
AddGuardBlock(std::vector<std::unique_ptr<BasicBlock>> * new_blocks,std::unordered_map<uint32_t,uint32_t> * callee2caller,std::unique_ptr<BasicBlock> new_blk_ptr,uint32_t entry_blk_label_id)277 std::unique_ptr<BasicBlock> InlinePass::AddGuardBlock(
278 std::vector<std::unique_ptr<BasicBlock>>* new_blocks,
279 std::unordered_map<uint32_t, uint32_t>* callee2caller,
280 std::unique_ptr<BasicBlock> new_blk_ptr, uint32_t entry_blk_label_id) {
281 const auto guard_block_id = context()->TakeNextId();
282 if (guard_block_id == 0) {
283 return nullptr;
284 }
285 AddBranch(guard_block_id, &new_blk_ptr);
286 new_blocks->push_back(std::move(new_blk_ptr));
287 // Start the next block.
288 new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(guard_block_id));
289 // Reset the mapping of the callee's entry block to point to
290 // the guard block. Do this so we can fix up phis later on to
291 // satisfy dominance.
292 (*callee2caller)[entry_blk_label_id] = guard_block_id;
293 return new_blk_ptr;
294 }
295
AddStoresForVariableInitializers(const std::unordered_map<uint32_t,uint32_t> & callee2caller,analysis::DebugInlinedAtContext * inlined_at_ctx,std::unique_ptr<BasicBlock> * new_blk_ptr,UptrVectorIterator<BasicBlock> callee_first_block_itr)296 InstructionList::iterator InlinePass::AddStoresForVariableInitializers(
297 const std::unordered_map<uint32_t, uint32_t>& callee2caller,
298 analysis::DebugInlinedAtContext* inlined_at_ctx,
299 std::unique_ptr<BasicBlock>* new_blk_ptr,
300 UptrVectorIterator<BasicBlock> callee_first_block_itr) {
301 auto callee_itr = callee_first_block_itr->begin();
302 while (callee_itr->opcode() == SpvOp::SpvOpVariable ||
303 callee_itr->GetOpenCL100DebugOpcode() ==
304 OpenCLDebugInfo100DebugDeclare) {
305 if (callee_itr->opcode() == SpvOp::SpvOpVariable &&
306 callee_itr->NumInOperands() == 2) {
307 assert(callee2caller.count(callee_itr->result_id()) &&
308 "Expected the variable to have already been mapped.");
309 uint32_t new_var_id = callee2caller.at(callee_itr->result_id());
310
311 // The initializer must be a constant or global value. No mapped
312 // should be used.
313 uint32_t val_id = callee_itr->GetSingleWordInOperand(1);
314 AddStore(new_var_id, val_id, new_blk_ptr, callee_itr->dbg_line_inst(),
315 context()->get_debug_info_mgr()->BuildDebugScope(
316 callee_itr->GetDebugScope(), inlined_at_ctx));
317 }
318 if (callee_itr->GetOpenCL100DebugOpcode() ==
319 OpenCLDebugInfo100DebugDeclare) {
320 InlineSingleInstruction(
321 callee2caller, new_blk_ptr->get(), &*callee_itr,
322 context()->get_debug_info_mgr()->BuildDebugInlinedAtChain(
323 callee_itr->GetDebugScope().GetInlinedAt(), inlined_at_ctx));
324 }
325 ++callee_itr;
326 }
327 return callee_itr;
328 }
329
InlineSingleInstruction(const std::unordered_map<uint32_t,uint32_t> & callee2caller,BasicBlock * new_blk_ptr,const Instruction * inst,uint32_t dbg_inlined_at)330 bool InlinePass::InlineSingleInstruction(
331 const std::unordered_map<uint32_t, uint32_t>& callee2caller,
332 BasicBlock* new_blk_ptr, const Instruction* inst, uint32_t dbg_inlined_at) {
333 // If we have return, it must be at the end of the callee. We will handle
334 // it at the end.
335 if (inst->opcode() == SpvOpReturnValue || inst->opcode() == SpvOpReturn)
336 return true;
337
338 // Copy callee instruction and remap all input Ids.
339 std::unique_ptr<Instruction> cp_inst(inst->Clone(context()));
340 cp_inst->ForEachInId([&callee2caller](uint32_t* iid) {
341 const auto mapItr = callee2caller.find(*iid);
342 if (mapItr != callee2caller.end()) {
343 *iid = mapItr->second;
344 }
345 });
346
347 // If result id is non-zero, remap it.
348 const uint32_t rid = cp_inst->result_id();
349 if (rid != 0) {
350 const auto mapItr = callee2caller.find(rid);
351 if (mapItr == callee2caller.end()) {
352 return false;
353 }
354 uint32_t nid = mapItr->second;
355 cp_inst->SetResultId(nid);
356 get_decoration_mgr()->CloneDecorations(rid, nid);
357 }
358
359 cp_inst->UpdateDebugInlinedAt(dbg_inlined_at);
360 new_blk_ptr->AddInstruction(std::move(cp_inst));
361 return true;
362 }
363
InlineReturn(const std::unordered_map<uint32_t,uint32_t> & callee2caller,std::vector<std::unique_ptr<BasicBlock>> * new_blocks,std::unique_ptr<BasicBlock> new_blk_ptr,analysis::DebugInlinedAtContext * inlined_at_ctx,Function * calleeFn,const Instruction * inst,uint32_t returnVarId)364 std::unique_ptr<BasicBlock> InlinePass::InlineReturn(
365 const std::unordered_map<uint32_t, uint32_t>& callee2caller,
366 std::vector<std::unique_ptr<BasicBlock>>* new_blocks,
367 std::unique_ptr<BasicBlock> new_blk_ptr,
368 analysis::DebugInlinedAtContext* inlined_at_ctx, Function* calleeFn,
369 const Instruction* inst, uint32_t returnVarId) {
370 // Store return value to return variable.
371 if (inst->opcode() == SpvOpReturnValue) {
372 assert(returnVarId != 0);
373 uint32_t valId = inst->GetInOperand(kSpvReturnValueId).words[0];
374 const auto mapItr = callee2caller.find(valId);
375 if (mapItr != callee2caller.end()) {
376 valId = mapItr->second;
377 }
378 AddStore(returnVarId, valId, &new_blk_ptr, inst->dbg_line_inst(),
379 context()->get_debug_info_mgr()->BuildDebugScope(
380 inst->GetDebugScope(), inlined_at_ctx));
381 }
382
383 uint32_t returnLabelId = 0;
384 for (auto callee_block_itr = calleeFn->begin();
385 callee_block_itr != calleeFn->end(); ++callee_block_itr) {
386 if (spvOpcodeIsAbort(callee_block_itr->tail()->opcode())) {
387 returnLabelId = context()->TakeNextId();
388 break;
389 }
390 }
391 if (returnLabelId == 0) return new_blk_ptr;
392
393 if (inst->opcode() == SpvOpReturn || inst->opcode() == SpvOpReturnValue)
394 AddBranch(returnLabelId, &new_blk_ptr);
395 new_blocks->push_back(std::move(new_blk_ptr));
396 return MakeUnique<BasicBlock>(NewLabel(returnLabelId));
397 }
398
InlineEntryBlock(const std::unordered_map<uint32_t,uint32_t> & callee2caller,std::unique_ptr<BasicBlock> * new_blk_ptr,UptrVectorIterator<BasicBlock> callee_first_block,analysis::DebugInlinedAtContext * inlined_at_ctx)399 bool InlinePass::InlineEntryBlock(
400 const std::unordered_map<uint32_t, uint32_t>& callee2caller,
401 std::unique_ptr<BasicBlock>* new_blk_ptr,
402 UptrVectorIterator<BasicBlock> callee_first_block,
403 analysis::DebugInlinedAtContext* inlined_at_ctx) {
404 auto callee_inst_itr = AddStoresForVariableInitializers(
405 callee2caller, inlined_at_ctx, new_blk_ptr, callee_first_block);
406
407 while (callee_inst_itr != callee_first_block->end()) {
408 if (!InlineSingleInstruction(
409 callee2caller, new_blk_ptr->get(), &*callee_inst_itr,
410 context()->get_debug_info_mgr()->BuildDebugInlinedAtChain(
411 callee_inst_itr->GetDebugScope().GetInlinedAt(),
412 inlined_at_ctx))) {
413 return false;
414 }
415 ++callee_inst_itr;
416 }
417 return true;
418 }
419
InlineBasicBlocks(std::vector<std::unique_ptr<BasicBlock>> * new_blocks,const std::unordered_map<uint32_t,uint32_t> & callee2caller,std::unique_ptr<BasicBlock> new_blk_ptr,analysis::DebugInlinedAtContext * inlined_at_ctx,Function * calleeFn)420 std::unique_ptr<BasicBlock> InlinePass::InlineBasicBlocks(
421 std::vector<std::unique_ptr<BasicBlock>>* new_blocks,
422 const std::unordered_map<uint32_t, uint32_t>& callee2caller,
423 std::unique_ptr<BasicBlock> new_blk_ptr,
424 analysis::DebugInlinedAtContext* inlined_at_ctx, Function* calleeFn) {
425 auto callee_block_itr = calleeFn->begin();
426 ++callee_block_itr;
427
428 while (callee_block_itr != calleeFn->end()) {
429 new_blocks->push_back(std::move(new_blk_ptr));
430 const auto mapItr =
431 callee2caller.find(callee_block_itr->GetLabelInst()->result_id());
432 if (mapItr == callee2caller.end()) return nullptr;
433 new_blk_ptr = MakeUnique<BasicBlock>(NewLabel(mapItr->second));
434
435 auto tail_inst_itr = callee_block_itr->end();
436 for (auto inst_itr = callee_block_itr->begin(); inst_itr != tail_inst_itr;
437 ++inst_itr) {
438 if (!InlineSingleInstruction(
439 callee2caller, new_blk_ptr.get(), &*inst_itr,
440 context()->get_debug_info_mgr()->BuildDebugInlinedAtChain(
441 inst_itr->GetDebugScope().GetInlinedAt(), inlined_at_ctx))) {
442 return nullptr;
443 }
444 }
445
446 ++callee_block_itr;
447 }
448 return new_blk_ptr;
449 }
450
MoveCallerInstsAfterFunctionCall(std::unordered_map<uint32_t,Instruction * > * preCallSB,std::unordered_map<uint32_t,uint32_t> * postCallSB,std::unique_ptr<BasicBlock> * new_blk_ptr,BasicBlock::iterator call_inst_itr,bool multiBlocks)451 bool InlinePass::MoveCallerInstsAfterFunctionCall(
452 std::unordered_map<uint32_t, Instruction*>* preCallSB,
453 std::unordered_map<uint32_t, uint32_t>* postCallSB,
454 std::unique_ptr<BasicBlock>* new_blk_ptr,
455 BasicBlock::iterator call_inst_itr, bool multiBlocks) {
456 // Copy remaining instructions from caller block.
457 for (Instruction* inst = call_inst_itr->NextNode(); inst;
458 inst = call_inst_itr->NextNode()) {
459 inst->RemoveFromList();
460 std::unique_ptr<Instruction> cp_inst(inst);
461 // If multiple blocks generated, regenerate any same-block
462 // instruction that has not been seen in this last block.
463 if (multiBlocks) {
464 if (!CloneSameBlockOps(&cp_inst, postCallSB, preCallSB, new_blk_ptr)) {
465 return false;
466 }
467
468 // Remember same-block ops in this block.
469 if (IsSameBlockOp(&*cp_inst)) {
470 const uint32_t rid = cp_inst->result_id();
471 (*postCallSB)[rid] = rid;
472 }
473 }
474 new_blk_ptr->get()->AddInstruction(std::move(cp_inst));
475 }
476
477 return true;
478 }
479
MoveLoopMergeInstToFirstBlock(std::vector<std::unique_ptr<BasicBlock>> * new_blocks)480 void InlinePass::MoveLoopMergeInstToFirstBlock(
481 std::vector<std::unique_ptr<BasicBlock>>* new_blocks) {
482 // Move the OpLoopMerge from the last block back to the first, where
483 // it belongs.
484 auto& first = new_blocks->front();
485 auto& last = new_blocks->back();
486 assert(first != last);
487
488 // Insert a modified copy of the loop merge into the first block.
489 auto loop_merge_itr = last->tail();
490 --loop_merge_itr;
491 assert(loop_merge_itr->opcode() == SpvOpLoopMerge);
492 std::unique_ptr<Instruction> cp_inst(loop_merge_itr->Clone(context()));
493 first->tail().InsertBefore(std::move(cp_inst));
494
495 // Remove the loop merge from the last block.
496 loop_merge_itr->RemoveFromList();
497 delete &*loop_merge_itr;
498 }
499
GenInlineCode(std::vector<std::unique_ptr<BasicBlock>> * new_blocks,std::vector<std::unique_ptr<Instruction>> * new_vars,BasicBlock::iterator call_inst_itr,UptrVectorIterator<BasicBlock> call_block_itr)500 bool InlinePass::GenInlineCode(
501 std::vector<std::unique_ptr<BasicBlock>>* new_blocks,
502 std::vector<std::unique_ptr<Instruction>>* new_vars,
503 BasicBlock::iterator call_inst_itr,
504 UptrVectorIterator<BasicBlock> call_block_itr) {
505 // Map from all ids in the callee to their equivalent id in the caller
506 // as callee instructions are copied into caller.
507 std::unordered_map<uint32_t, uint32_t> callee2caller;
508 // Pre-call same-block insts
509 std::unordered_map<uint32_t, Instruction*> preCallSB;
510 // Post-call same-block op ids
511 std::unordered_map<uint32_t, uint32_t> postCallSB;
512
513 analysis::DebugInlinedAtContext inlined_at_ctx(&*call_inst_itr);
514
515 // Invalidate the def-use chains. They are not kept up to date while
516 // inlining. However, certain calls try to keep them up-to-date if they are
517 // valid. These operations can fail.
518 context()->InvalidateAnalyses(IRContext::kAnalysisDefUse);
519
520 // If the caller is a loop header and the callee has multiple blocks, then the
521 // normal inlining logic will place the OpLoopMerge in the last of several
522 // blocks in the loop. Instead, it should be placed at the end of the first
523 // block. We'll wait to move the OpLoopMerge until the end of the regular
524 // inlining logic, and only if necessary.
525 bool caller_is_loop_header = call_block_itr->GetLoopMergeInst() != nullptr;
526
527 // Single-trip loop continue block
528 std::unique_ptr<BasicBlock> single_trip_loop_cont_blk;
529
530 Function* calleeFn = id2function_[call_inst_itr->GetSingleWordOperand(
531 kSpvFunctionCallFunctionId)];
532
533 // Map parameters to actual arguments.
534 MapParams(calleeFn, call_inst_itr, &callee2caller);
535
536 // Define caller local variables for all callee variables and create map to
537 // them.
538 if (!CloneAndMapLocals(calleeFn, new_vars, &callee2caller, &inlined_at_ctx)) {
539 return false;
540 }
541
542 // First block needs to use label of original block
543 // but map callee label in case of phi reference.
544 uint32_t entry_blk_label_id = calleeFn->begin()->GetLabelInst()->result_id();
545 callee2caller[entry_blk_label_id] = call_block_itr->id();
546 std::unique_ptr<BasicBlock> new_blk_ptr =
547 MakeUnique<BasicBlock>(NewLabel(call_block_itr->id()));
548
549 // Move instructions of original caller block up to call instruction.
550 MoveInstsBeforeEntryBlock(&preCallSB, new_blk_ptr.get(), call_inst_itr,
551 call_block_itr);
552
553 if (caller_is_loop_header &&
554 (*(calleeFn->begin())).GetMergeInst() != nullptr) {
555 // We can't place both the caller's merge instruction and
556 // another merge instruction in the same block. So split the
557 // calling block. Insert an unconditional branch to a new guard
558 // block. Later, once we know the ID of the last block, we
559 // will move the caller's OpLoopMerge from the last generated
560 // block into the first block. We also wait to avoid
561 // invalidating various iterators.
562 new_blk_ptr = AddGuardBlock(new_blocks, &callee2caller,
563 std::move(new_blk_ptr), entry_blk_label_id);
564 if (new_blk_ptr == nullptr) return false;
565 }
566
567 // Create return var if needed.
568 const uint32_t calleeTypeId = calleeFn->type_id();
569 uint32_t returnVarId = 0;
570 analysis::Type* calleeType = context()->get_type_mgr()->GetType(calleeTypeId);
571 if (calleeType->AsVoid() == nullptr) {
572 returnVarId = CreateReturnVar(calleeFn, new_vars);
573 if (returnVarId == 0) {
574 return false;
575 }
576 }
577
578 calleeFn->WhileEachInst([&callee2caller, this](const Instruction* cpi) {
579 // Create set of callee result ids. Used to detect forward references
580 const uint32_t rid = cpi->result_id();
581 if (rid != 0 && callee2caller.find(rid) == callee2caller.end()) {
582 const uint32_t nid = context()->TakeNextId();
583 if (nid == 0) return false;
584 callee2caller[rid] = nid;
585 }
586 return true;
587 });
588
589 // Inline DebugClare instructions in the callee's header.
590 calleeFn->ForEachDebugInstructionsInHeader(
591 [&new_blk_ptr, &callee2caller, &inlined_at_ctx, this](Instruction* inst) {
592 InlineSingleInstruction(
593 callee2caller, new_blk_ptr.get(), inst,
594 context()->get_debug_info_mgr()->BuildDebugInlinedAtChain(
595 inst->GetDebugScope().GetInlinedAt(), &inlined_at_ctx));
596 });
597
598 // Inline the entry block of the callee function.
599 if (!InlineEntryBlock(callee2caller, &new_blk_ptr, calleeFn->begin(),
600 &inlined_at_ctx)) {
601 return false;
602 }
603
604 // Inline blocks of the callee function other than the entry block.
605 new_blk_ptr =
606 InlineBasicBlocks(new_blocks, callee2caller, std::move(new_blk_ptr),
607 &inlined_at_ctx, calleeFn);
608 if (new_blk_ptr == nullptr) return false;
609
610 new_blk_ptr = InlineReturn(callee2caller, new_blocks, std::move(new_blk_ptr),
611 &inlined_at_ctx, calleeFn,
612 &*(calleeFn->tail()->tail()), returnVarId);
613
614 // Load return value into result id of call, if it exists.
615 if (returnVarId != 0) {
616 const uint32_t resId = call_inst_itr->result_id();
617 assert(resId != 0);
618 AddLoad(calleeTypeId, resId, returnVarId, &new_blk_ptr,
619 call_inst_itr->dbg_line_inst(), call_inst_itr->GetDebugScope());
620 }
621
622 // Move instructions of original caller block after call instruction.
623 if (!MoveCallerInstsAfterFunctionCall(&preCallSB, &postCallSB, &new_blk_ptr,
624 call_inst_itr,
625 calleeFn->begin() != calleeFn->end()))
626 return false;
627
628 // Finalize inline code.
629 new_blocks->push_back(std::move(new_blk_ptr));
630
631 if (caller_is_loop_header && (new_blocks->size() > 1))
632 MoveLoopMergeInstToFirstBlock(new_blocks);
633
634 // Update block map given replacement blocks.
635 for (auto& blk : *new_blocks) {
636 id2block_[blk->id()] = &*blk;
637 }
638
639 // We need to kill the name and decorations for the call, which will be
640 // deleted.
641 context()->KillNamesAndDecorates(&*call_inst_itr);
642
643 return true;
644 }
645
IsInlinableFunctionCall(const Instruction * inst)646 bool InlinePass::IsInlinableFunctionCall(const Instruction* inst) {
647 if (inst->opcode() != SpvOp::SpvOpFunctionCall) return false;
648 const uint32_t calleeFnId =
649 inst->GetSingleWordOperand(kSpvFunctionCallFunctionId);
650 const auto ci = inlinable_.find(calleeFnId);
651 if (ci == inlinable_.cend()) return false;
652
653 if (early_return_funcs_.find(calleeFnId) != early_return_funcs_.end()) {
654 // We rely on the merge-return pass to handle the early return case
655 // in advance.
656 std::string message =
657 "The function '" + id2function_[calleeFnId]->DefInst().PrettyPrint() +
658 "' could not be inlined because the return instruction "
659 "is not at the end of the function. This could be fixed by "
660 "running merge-return before inlining.";
661 consumer()(SPV_MSG_WARNING, "", {0, 0, 0}, message.c_str());
662 return false;
663 }
664
665 return true;
666 }
667
UpdateSucceedingPhis(std::vector<std::unique_ptr<BasicBlock>> & new_blocks)668 void InlinePass::UpdateSucceedingPhis(
669 std::vector<std::unique_ptr<BasicBlock>>& new_blocks) {
670 const auto firstBlk = new_blocks.begin();
671 const auto lastBlk = new_blocks.end() - 1;
672 const uint32_t firstId = (*firstBlk)->id();
673 const uint32_t lastId = (*lastBlk)->id();
674 const BasicBlock& const_last_block = *lastBlk->get();
675 const_last_block.ForEachSuccessorLabel(
676 [&firstId, &lastId, this](const uint32_t succ) {
677 BasicBlock* sbp = this->id2block_[succ];
678 sbp->ForEachPhiInst([&firstId, &lastId](Instruction* phi) {
679 phi->ForEachInId([&firstId, &lastId](uint32_t* id) {
680 if (*id == firstId) *id = lastId;
681 });
682 });
683 });
684 }
685
HasNoReturnInLoop(Function * func)686 bool InlinePass::HasNoReturnInLoop(Function* func) {
687 // If control not structured, do not do loop/return analysis
688 // TODO: Analyze returns in non-structured control flow
689 if (!context()->get_feature_mgr()->HasCapability(SpvCapabilityShader))
690 return false;
691 const auto structured_analysis = context()->GetStructuredCFGAnalysis();
692 // Search for returns in structured construct.
693 bool return_in_loop = false;
694 for (auto& blk : *func) {
695 auto terminal_ii = blk.cend();
696 --terminal_ii;
697 if (spvOpcodeIsReturn(terminal_ii->opcode()) &&
698 structured_analysis->ContainingLoop(blk.id()) != 0) {
699 return_in_loop = true;
700 break;
701 }
702 }
703 return !return_in_loop;
704 }
705
AnalyzeReturns(Function * func)706 void InlinePass::AnalyzeReturns(Function* func) {
707 // Analyze functions without a return in loop.
708 if (HasNoReturnInLoop(func)) {
709 no_return_in_loop_.insert(func->result_id());
710 }
711 // Analyze functions with a return before its tail basic block.
712 for (auto& blk : *func) {
713 auto terminal_ii = blk.cend();
714 --terminal_ii;
715 if (spvOpcodeIsReturn(terminal_ii->opcode()) && &blk != func->tail()) {
716 early_return_funcs_.insert(func->result_id());
717 break;
718 }
719 }
720 }
721
IsInlinableFunction(Function * func)722 bool InlinePass::IsInlinableFunction(Function* func) {
723 // We can only inline a function if it has blocks.
724 if (func->cbegin() == func->cend()) return false;
725
726 // Do not inline functions with DontInline flag.
727 if (func->control_mask() & SpvFunctionControlDontInlineMask) {
728 return false;
729 }
730
731 // Do not inline functions with returns in loops. Currently early return
732 // functions are inlined by wrapping them in a one trip loop and implementing
733 // the returns as a branch to the loop's merge block. However, this can only
734 // done validly if the return was not in a loop in the original function.
735 // Also remember functions with multiple (early) returns.
736 AnalyzeReturns(func);
737 if (no_return_in_loop_.find(func->result_id()) == no_return_in_loop_.cend()) {
738 return false;
739 }
740
741 if (func->IsRecursive()) {
742 return false;
743 }
744
745 // Do not inline functions with an OpKill if they are called from a continue
746 // construct. If it is inlined into a continue construct it will generate
747 // invalid code.
748 bool func_is_called_from_continue =
749 funcs_called_from_continue_.count(func->result_id()) != 0;
750
751 if (func_is_called_from_continue && ContainsKillOrTerminateInvocation(func)) {
752 return false;
753 }
754
755 return true;
756 }
757
ContainsKillOrTerminateInvocation(Function * func) const758 bool InlinePass::ContainsKillOrTerminateInvocation(Function* func) const {
759 return !func->WhileEachInst([](Instruction* inst) {
760 return !spvOpcodeTerminatesExecution(inst->opcode());
761 });
762 }
763
InitializeInline()764 void InlinePass::InitializeInline() {
765 false_id_ = 0;
766
767 // clear collections
768 id2function_.clear();
769 id2block_.clear();
770 inlinable_.clear();
771 no_return_in_loop_.clear();
772 early_return_funcs_.clear();
773 funcs_called_from_continue_ =
774 context()->GetStructuredCFGAnalysis()->FindFuncsCalledFromContinue();
775
776 for (auto& fn : *get_module()) {
777 // Initialize function and block maps.
778 id2function_[fn.result_id()] = &fn;
779 for (auto& blk : fn) {
780 id2block_[blk.id()] = &blk;
781 }
782 // Compute inlinability
783 if (IsInlinableFunction(&fn)) inlinable_.insert(fn.result_id());
784 }
785 }
786
InlinePass()787 InlinePass::InlinePass() {}
788
789 } // namespace opt
790 } // namespace spvtools
791