| /external/trusty/arm-trusted-firmware/docs/ |
| D | change-log.md | 6 ## [2.12.0](https://review.trustedfirmware.org/plugins/gitiles/TF-A/trusted-firmware-a/+/refs/tags/…
17 …**See:** remove unused plat_try_next_boot_source ([2c303e3](https://review.trustedfirmware.org/plu…
25 …- allow RME builds with BRBE ([9890eab](https://review.trustedfirmware.org/plugins/gitiles/TF-A/tr…
29 …- improve ENABLE_FEAT_MTE deprecation warning ([ba65e2d](https://review.trustedfirmware.org/plugin…
30 …- remove deprecated CTX_INCLUDE_MTE_REGS/FEAT_MTE ([6f2b881](https://review.trustedfirmware.org/pl…
36 …- dtb: check for correct error condition ([7300a4d](https://review.trustedfirmware.org/plugins/git…
37 …- enable dtb modifications for CPU idle states to the rich OS ([188a988](https://review.trustedfir…
38 …- remove unneeded header inclusion ([8bb8f02](https://review.trustedfirmware.org/plugins/gitiles/T…
44 …- avoid stripping kernel trampoline ([8292f24](https://review.trustedfirmware.org/plugins/gitiles/…
48 …- add DRAM memory regions that linux kernel can share ([18ec9bd](https://review.trustedfirmware.or…
[all …]
|
| /external/pigweed/docs/ |
| D | changelog.rst | 5670 <https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/217219>`__
5672 <https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/217212>`__
5674 <https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/216274>`__
5677 <https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/216436>`__
5680 <https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/216271>`__
5683 <https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/216181>`__
5685 <https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/218411>`__
5687 <https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/218271>`__
5701 <https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/216893>`__
5703 <https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/216672>`__
[all …]
|
| D | code_reviews.rst | 4 Code review guidelines
14 have Gerrit automatically choose an appropriate person to review your change.
25 <https://google.github.io/eng-practices/review/developer/small-cls.html>`_.
42 Review speed
45 <https://google.github.io/eng-practices/review/reviewer/speed.html>`_. Most
48 * If you are not in the middle of a focused task, **you should do a code review
51 review request (i.e., first thing the next morning).
52 * If you will not be able to review the change within a business day, comment
58 <https://gerrit-review.googlesource.com/Documentation/user-attention-set.html>`_
60 you can continue to review. You are encouraged, but not required, to leave a
[all …]
|
| /external/angle/doc/ |
| D | CodeReviewProcess.md | 1 # ANGLE's Code Review Process
3 This page describes the review process for ANGLE reviewers and committers. For
4 instructions on submitting your change list for review, please see
12 1. To review a change, you can either navigate directly to the URL for the CL,
14 your dashboard at https://chromium-review.googlesource.com/
15 2. Review the change listed by looking over the diffs listed in the most recent
27 3. Once your review is complete, click the "Review" button
29 review (Code-Review +1 or +2).
31 comments and a neutral review. (Code-Review 0)
33 review. (Code-Review -1 or -2)
[all …]
|
| /external/coreboot/ |
| D | .gitmodules | 3 url = https://review.coreboot.org/blobs.git
8 url = https://review.coreboot.org/nvidia-cbootimage.git
11 url = https://review.coreboot.org/vboot.git
15 url = https://review.coreboot.org/arm-trusted-firmware.git
18 url = https://review.coreboot.org/chrome-ec.git
21 url = https://review.coreboot.org/libhwbase.git
24 url = https://review.coreboot.org/libgfxinit.git
27 url = https://review.coreboot.org/fsp.git
32 url = https://review.coreboot.org/opensbi.git
35 url = https://review.coreboot.org/intel-microcode.git
[all …]
|
| /external/spdx-tools/rdfloader/parser2v3/ |
| D | parse_review_test.go | 12 <spdx:Review>
17 </spdx:Review>
27 <spdx:Review>
31 </spdx:Review>
41 <spdx:Review>
45 </spdx:Review>
54 t.Errorf("expected doc to have 1 review, found %d", n)
56 review := parser.doc.Reviews[0]
58 if review.ReviewComment != expectedComment {
59 t.Errorf("expected: %v, found: %s", expectedComment, review.ReviewComment)
[all …]
|
| D | parse_review.go | 13 review := v2_3.Review{}
21 review.ReviewComment = triple.Object.ID
24 review.ReviewDate = triple.Object.ID
28 review.ReviewerType, review.Reviewer, err = ExtractSubs(triple.Object.ID, ":")
33 return fmt.Errorf("unknown predicate %v for review triples", triple.Predicate)
36 parser.doc.Reviews = append(parser.doc.Reviews, &review)
|
| /external/spdx-tools/rdfloader/parser2v2/ |
| D | parse_review_test.go | 12 <spdx:Review>
17 </spdx:Review>
27 <spdx:Review>
31 </spdx:Review>
41 <spdx:Review>
45 </spdx:Review>
54 t.Errorf("expected doc to have 1 review, found %d", n)
56 review := parser.doc.Reviews[0]
58 if review.ReviewComment != expectedComment {
59 t.Errorf("expected: %v, found: %s", expectedComment, review.ReviewComment)
[all …]
|
| D | parse_review.go | 13 review := v2_2.Review{}
21 review.ReviewComment = triple.Object.ID
24 review.ReviewDate = triple.Object.ID
28 review.ReviewerType, review.Reviewer, err = ExtractSubs(triple.Object.ID, ":")
33 return fmt.Errorf("unknown predicate %v for review triples", triple.Predicate)
36 parser.doc.Reviews = append(parser.doc.Reviews, &review)
|
| /external/coreboot/Documentation/infrastructure/ |
| D | services.md | 7 ## Gerrit code review
8 We exchange and review patches to the code using our [Gerrit code review
9 system](https://review.coreboot.org).
14 On the [settings screen](https://review.coreboot.org/settings) you can register
21 [review.coreboot.org]:29418 ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAvNDn8qGHlWM/5ndFltStlg3QTc8xvGOgyjx…
23 [review.coreboot.org]:29418 ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAAB…
25 [review.coreboot.org]:29418 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOC3Z32gc+1rJXhKX+SW0vESlXR/h/mhcxd…
29 2048 SHA256:WW5prF7YE3MTnkRIxLklr9Gxddj9s5BZKUqWJF5dnTg review.coreboot.org:29418 (RSA)
30 256 SHA256:IuLv/DgrBtVn36eMP1zFD0ISAl3IxIoCeiRms6UDhZc review.coreboot.org:29418 (ECDSA)
31 256 SHA256:QFZieVHy8dCRl9tDib6qiwELnfa7SVU4ZWJ5VrXoC8k review.coreboot.org:29418 (ED25519)
[all …]
|
| /external/googleapis/google/maps/places/v1/ |
| D | review.proto | 33 // Information about a review of a place.
34 message Review { message
36 type: "places.googleapis.com/Review"
37 pattern: "places/{place}/reviews/{review}"
39 singular: "review"
42 // A reference representing this place review which may be used to look up
43 // this place review again (also called the API "resource" name:
44 // `places/{place_id}/reviews/{review}`).
47 // A string of formatted recent time, expressing the review time relative
51 // The localized text of the review.
[all …]
|
| D | attribution.proto | 30 // [Review][google.maps.places.v1.Review].
33 // [Review][google.maps.places.v1.Review].
37 // [Review][google.maps.places.v1.Review].
42 // [Review][google.maps.places.v1.Review].
|
| /external/python/google-api-python-client/docs/dyn/ |
| D | androidpublisher_v3.reviews.html | 82 <p class="firstline">Gets a single review.</p>
88 <p class="firstline">Replies to a single review, or updates an existing reply.</p>
97 <pre>Gets a single review.
101 reviewId: string, Unique identifier for a review. (required)
111 { # An Android app review.
112 "authorName": "A String", # The name of the user who wrote the review.
113 "comments": [ # A repeated field containing comments for the review.
123 … # Integer Android SDK version of the user's device at the time the review was written, e.g. …
124 …uot;: 42, # Integer version code of the app as installed at the time the review was written. May b…
125 …ing", # String version name of the app as installed at the time the review was written. May b…
[all …]
|
| /external/skia/ |
| D | RELEASE_NOTES.md | 1014 https://review.skia.org/506462
1030 https://review.skia.org/481416
1032 https://review.skia.org/489536
1091 http://review.skia.org/452558
1107 https://review.skia.org/432878
1111 https://review.skia.org/430897
1114 https://review.skia.org/436565
1129 https://review.skia.org/444735
1136 https://review.skia.org/419336
1139 https://review.skia.org/419796
[all …]
|
| /external/arm-trusted-firmware/docs/ |
| D | change-log.md | 17 …**See:** privatize unused AMU APIs ([b4b726e](https://review.trustedfirmware.org/plugins/gitiles/T…
23 …**See:** remove `PLAT_AMU_GROUP1_COUNTERS_MASK` ([6c8dda1](https://review.trustedfirmware.org/plug…
34 …**See:** clean up source collection ([e04da4c](https://review.trustedfirmware.org/plugins/gitiles/…
44 …**See:** multi-device support ([1c65989](https://review.trustedfirmware.org/plugins/gitiles/TF-A/t…
52 …- enable per-core AMU auxiliary counters ([742ca23](https://review.trustedfirmware.org/plugins/git…
56 …- add build option to enable FEAT_HCX ([cb4ec47](https://review.trustedfirmware.org/plugins/gitile…
60 …- enable SME functionality ([dc78e62](https://review.trustedfirmware.org/plugins/gitiles/TF-A/trus…
64 …- enable SVE for the secure world ([0c5e7d1](https://review.trustedfirmware.org/plugins/gitiles/TF…
68 …- enable access to trace buffer control registers from lower NS EL ([813524e](https://review.trust…
69 …- initialize trap settings of trace buffer control registers access ([40ff907](https://review.trus…
[all …]
|
| /external/trusty/arm-trusted-firmware/docs/process/ |
| D | code-review-guidelines.rst | 1 Code Review Guidelines
21 Overview of the code review process
34 - At least one ``Code-Owner-Review+1`` up-vote, and no ``Code-Owner-Review-1``
37 - At least one ``Maintainer-Review+1`` up-vote, and no ``Maintainer-Review-1``
50 To ensure the code review gives the greatest possible benefit, participants in
58 - Review other people's patches where possible. The more active reviewers there
60 code review helps everyone in the long run, as it creates a culture of
70 - Answer all comments from people who took the time to review your
77 In the event that a code review takes longer than you would hope for, you
97 - It is the patch-author's responsibility to respond to review comments within
[all …]
|
| /external/llvm/docs/ |
| D | Phabricator.rst | 12 is the system of record for all LLVM code review. The mailing list should be
31 Requesting a review via the command line
41 Requesting a review via the web interface
44 The tool to create and review patches in Phabricator is called
50 will automatically send a diff with a smaller context in the review
70 lists that you want to be included in the review. If your patch is
81 * Select the review you want to from the *Attach To* dropdown and click
102 responsibility for making sure the review happens.
123 when a review changes state, for example by clicking "Accept Revision" in
138 where ``<URL>`` is the URL for the code review, starting with
[all …]
|
| /external/cldr/docs/site/translation/getting-started/ |
| D | review-formats.md | 2 title: Review Reports
5 # Review Reports
11 You should review the reports:
30 
49 …(https://cldr.unicode.org/translation/miscellaneous-person-name-formats) under "**Review Report**".
52 ### Date & Time Review Tips
55 2. Lower down on the page are charts of weekdays, months, and quarters for review. When a language …
57 
59 ### Number formats Review tips
62 2. Review the cells within each row for consistency.
[all …]
|
| /external/skia/site/docs/dev/contrib/ |
| D | submit.md | 75 review! Submit a patch and getting it reviewed is fairly easy with depot tools.
93 ### Uploading changes for review
95 Skia uses the Gerrit code review tool. Skia's instance is
96 [skia-review](http://skia-review.googlesource.com). Use `git cl` to upload your
109 ([https://skia-review.googlesource.com/c/4559/](https://skia-review.googlesource.com/c/4559/)),
117 [Gerrit](https://skia-review.googlesource.com/), you may trigger a try job for
134 ### Request review
136 Go to the supplied URL or go to the code review page and select the **Your**
138 review and click **Reply**. Enter at least one reviewer's email address. Now add
139 any optional notes, and send your change off for review by clicking on **Send**.
[all …]
|
| /external/arm-trusted-firmware/docs/process/ |
| D | contributing.rst | 8 `developer.trustedfirmware.org`_ and `review.trustedfirmware.org`_.
38 review so this will speed up the review process.
96 - Submit your changes for review at https://review.trustedfirmware.org
112 send an email to the `TF-A mailing list`_ to broadcast your review request
120 - The changes will then undergo further review by the designated people. Any
121 review comments will be made directly on your patch. This may require you to
130 - One ``Code-Owner-Review+1`` for each of the modules modified by the patch.
131 - A ``Maintainer-Review+1``.
134 ``Code-Owner-Review+1`` is substituted by ``Code-Review+1``.
136 In addition to these various code review labels, the patch must also get a
[all …]
|
| D | code-review-guidelines.rst | 1 Code Review Guidelines
4 This document provides TF-A specific details about the project's code review
29 To ensure the code review gives the greatest possible benefit, participants in
37 - Review other people's patches where possible. The more active reviewers there
39 code review helps everyone in the long run, as it creates a culture of
49 - Answer all comments from people who took the time to review your
56 In the event that a code review takes longer than you would hope for, you
80 There are no good or bad review comments. If you have any doubt about a patch or
82 issue slip. Examples of review comments could be:
128 through the ``Code-Owner-Review+1`` label in Gerrit. If instead, they have
[all …]
|
| /external/openscreen/ |
| D | README.md | 197 This library uses [Chromium Gerrit](https://chromium-review.googlesource.com/) for
198 patch management and code review (for better or worse). You will need to register
199 for an account at `chromium-review.googlesource.com` to upload patches for review.
202 reviews, specifically when pushing patches for review, getting patches reviewed,
205 # Uploading a patch for review
208 review tool) and is recommended for pushing patches for review. Once you have
218 newcode review will be posted on `chromium-review.googlesource.com`.
222 review as a new patchset.
225 separately. `git cl` keeps track of review status separately for each local
230 If conflicting commits have been landed in the repository for a patch in review,
[all …]
|
| /external/spdx-tools/tvloader/parser2v2/ |
| D | parse_review_test.go | 10 // ===== Parser review section state change tests =====
12 // create the first review
23 rev: &v2_2.Review{
36 t.Errorf("Expected only one review, got %d", len(parser.doc.Reviews))
39 t.Errorf("Expected review %v in Reviews[0], got %v", r1, parser.doc.Reviews[0])
42 t.Errorf("expected review name %s in Reviews[0], got %s", rev1, parser.doc.Reviews[0].Reviewer)
45 // now add a new review
56 // and a review should be created
58 t.Fatalf("parser didn't create new review")
69 t.Errorf("Expected review %v in Reviews[0], got %v", r1, parser.doc.Reviews[0])
[all …]
|
| /external/spdx-tools/tvloader/parser2v1/ |
| D | parse_review_test.go | 10 // ===== Parser review section state change tests =====
12 // create the first review
23 rev: &v2_1.Review{
36 t.Errorf("Expected only one review, got %d", len(parser.doc.Reviews))
39 t.Errorf("Expected review %v in Reviews[0], got %v", r1, parser.doc.Reviews[0])
42 t.Errorf("expected review name %s in Reviews[0], got %s", rev1, parser.doc.Reviews[0].Reviewer)
45 // now add a new review
56 // and a review should be created
58 t.Fatalf("parser didn't create new review")
69 t.Errorf("Expected review %v in Reviews[0], got %v", r1, parser.doc.Reviews[0])
[all …]
|
| /external/spdx-tools/tvloader/parser2v3/ |
| D | parse_review_test.go | 10 // ===== Parser review section state change tests =====
12 // create the first review
23 rev: &v2_3.Review{
36 t.Errorf("Expected only one review, got %d", len(parser.doc.Reviews))
39 t.Errorf("Expected review %v in Reviews[0], got %v", r1, parser.doc.Reviews[0])
42 t.Errorf("expected review name %s in Reviews[0], got %s", rev1, parser.doc.Reviews[0].Reviewer)
45 // now add a new review
56 // and a review should be created
58 t.Fatalf("parser didn't create new review")
69 t.Errorf("Expected review %v in Reviews[0], got %v", r1, parser.doc.Reviews[0])
[all …]
|