1# Guidelines for submitting bugs: 2All non security bugs should be filed on the Issues tracker: 3https://github.com/tpm2-software/tpm2-tss/issues 4 5Security sensitive bugs should be emailed to a maintainer directly, or to Intel 6via the guidelines here: 7https://security-center.intel.com/VulnerabilityHandlingGuidelines.aspx 8 9# Guideline for submitting changes: 10All changes to the source code must follow the coding standard used in the 11surrounding source and documented [here](doc/coding_standard_c.md). 12 13All changes should be introduced via github pull requests. This allows anyone to 14comment and provide feedback in lieu of having a mailing list. For pull requests 15opened by non-maintainers, any maintainer may review and merge that pull 16request. For maintainers, they either must have their pull request reviewed by 17another maintainer if possible, or leave the PR open for at least 24 hours, we 18consider this the window for comments. 19 20## Patch requirements 21* All tests must pass on Travis CI for the merge to occur. 22* All changes must not introduce superfluous changes or whitespace errors. 23* All commits should adhere to the git commit message guidelines described 24here: https://chris.beams.io/posts/git-commit/ with the following exceptions. 25 * We allow commit subject lines up to 80 characters. 26 * Commit subject lines should be prefixed with a string identifying the 27effected subsystem. If the change is spread over a number of 28subsystems then the prefix may be omitted. Recommended prefix for changes to 29files in src/tss2-sys is "sys: ", and for changes to files in src/tss2-esys 30is "esys: ". 31* All contributions must adhere to the Developers Certificate of Origin. The 32full text of the DCO is here: https://developercertificate.org/. Contributors 33must add a 'Signed-off-by' line to their commits. This indicates the 34submitters acceptance of the DCO. 35 36## Guideline for merging changes 37Changes must be merged with the "rebase" option on github to avoid merge commits. 38This provides for a clear linear history. 39