1 /*
2 * Copyright (C) 2018 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17 #include "Command.h"
18
19 #include "test/Test.h"
20
21 using ::testing::Eq;
22 using namespace std::literals;
23
24 namespace aapt {
25
26 class TestCommand : public Command {
27 public:
TestCommand()28 explicit TestCommand() : Command("command") {}
Action(const std::vector<std::string> & args)29 int Action(const std::vector<std::string>& args) override {
30 args_ = args;
31 return 0;
32 }
33
34 std::vector<std::string> args_;
35 };
36
37 #ifdef _WIN32
TEST(CommandTest,LongFullyQualifiedPathWindows)38 TEST(CommandTest, LongFullyQualifiedPathWindows) {
39 TestCommand command;
40 std::string required_flag;
41 command.AddRequiredFlag("--rflag", "", &required_flag, Command::kPath);
42 std::optional<std::string> optional_flag;
43 command.AddOptionalFlag("--oflag", "", &optional_flag, Command::kPath);
44 std::vector<std::string> required_flag_list;
45 command.AddRequiredFlagList("--rlflag", "", &required_flag_list, Command::kPath);
46 std::vector<std::string> optional_flag_list;
47 command.AddOptionalFlagList("--olflag", "", &optional_flag_list, Command::kPath);
48 std::string non_path_flag;
49 command.AddRequiredFlag("--nflag", "", &non_path_flag);
50
51 const std::string kLongPath =
52 "C:\\Users\\jedo\\_bazel_jedo\\vcmdctjv\\execroot\\__main__\\_tmp"
53 "\\6767b4778f8798efc0f784ee74fa70ee\\tests\\testApksAr8c7560a9a65"
54 "\\1346ee7c014a089fb55d8c46cf3d9\\project\\baseModule\\build"
55 "\\intermediates\\processed_res\\minified\\processMinifiedResources"
56 "\\1346ee7c014a089fb55d8c46cf3d9\\project\\baseModule\\build"
57 "\\intermediates\\processed_res\\minified\\processMinifiedResources"
58 "\\out\\resources-minified.ap_";
59
60 const std::string kExpected =
61 "\\\\?\\C:\\Users\\jedo\\_bazel_jedo\\vcmdctjv\\execroot\\__main__\\_tmp"
62 "\\6767b4778f8798efc0f784ee74fa70ee\\tests\\testApksAr8c7560a9a65"
63 "\\1346ee7c014a089fb55d8c46cf3d9\\project\\baseModule\\build"
64 "\\intermediates\\processed_res\\minified\\processMinifiedResources"
65 "\\1346ee7c014a089fb55d8c46cf3d9\\project\\baseModule\\build"
66 "\\intermediates\\processed_res\\minified\\processMinifiedResources"
67 "\\out\\resources-minified.ap_";
68
69
70 ASSERT_THAT(command.Execute({"--rflag", kLongPath,
71 "--oflag", kLongPath,
72 "--rlflag", kLongPath,
73 "--rlflag", kLongPath,
74 "--olflag", kLongPath,
75 "--olflag", kLongPath,
76 "--nflag", kLongPath,
77 kLongPath, kLongPath}, &std::cerr), Eq(0));
78
79 ASSERT_THAT(required_flag, Eq(kExpected));
80 ASSERT_THAT(optional_flag, Eq(kExpected));
81 ASSERT_THAT(required_flag_list.size(), Eq(2));
82 ASSERT_THAT(required_flag_list[0], Eq(kExpected));
83 ASSERT_THAT(required_flag_list[1], Eq(kExpected));
84 ASSERT_THAT(optional_flag_list.size(), Eq(2));
85 ASSERT_THAT(optional_flag_list[0], Eq(kExpected));
86 ASSERT_THAT(optional_flag_list[1], Eq(kExpected));
87
88 // File arguments should also be converted to use the long path prefix
89 ASSERT_THAT(command.args_.size(), Eq(2));
90 ASSERT_THAT(command.args_[0], Eq(kExpected));
91 ASSERT_THAT(command.args_[1], Eq(kExpected));
92
93 // Do not convert flags that are not marged as paths
94 ASSERT_THAT(non_path_flag, Eq(kLongPath));
95 }
96 #endif
97
TEST(CommandTest,OptionsWithValues)98 TEST(CommandTest, OptionsWithValues) {
99 TestCommand command;
100 std::string flag;
101 command.AddRequiredFlag("--flag", "", &flag);
102
103 ASSERT_EQ(0, command.Execute({"--flag"s, "1"s}, &std::cerr));
104 EXPECT_STREQ("1", flag.c_str());
105
106 ASSERT_EQ(0, command.Execute({"--flag=1"s}, &std::cerr));
107 EXPECT_STREQ("1", flag.c_str());
108
109 ASSERT_EQ(0, command.Execute({"--flag"s, "=2"s}, &std::cerr));
110 EXPECT_STREQ("=2", flag.c_str());
111
112 ASSERT_EQ(0, command.Execute({"--flag"s, "--flag"s}, &std::cerr));
113 EXPECT_STREQ("--flag", flag.c_str());
114
115 EXPECT_NE(0, command.Execute({"--flag"s}, &std::cerr));
116 EXPECT_NE(0, command.Execute({"--flag="s}, &std::cerr));
117 EXPECT_NE(0, command.Execute({"--flag1=2"s}, &std::cerr));
118 EXPECT_NE(0, command.Execute({"--flag1"s, "2"s}, &std::cerr));
119 }
120
TEST(CommandTest,ShortOptions)121 TEST(CommandTest, ShortOptions) {
122 TestCommand command;
123 bool flag = false;
124 command.AddOptionalSwitch("--flag", "", &flag);
125
126 ASSERT_EQ(0, command.Execute({"--flag"s}, &std::cerr));
127 EXPECT_TRUE(flag);
128
129 // Short version of a switch should work.
130 flag = false;
131 ASSERT_EQ(0, command.Execute({"-f"s}, &std::cerr));
132 EXPECT_TRUE(flag);
133
134 // Ambiguous names shouldn't parse via short options.
135 command.AddOptionalSwitch("--flag-2", "", &flag);
136 ASSERT_NE(0, command.Execute({"-f"s}, &std::cerr));
137
138 // But when we have a proper flag like that it should still work.
139 flag = false;
140 command.AddOptionalSwitch("-f", "", &flag);
141 ASSERT_EQ(0, command.Execute({"-f"s}, &std::cerr));
142 EXPECT_TRUE(flag);
143
144 // A regular short flag works fine as well.
145 flag = false;
146 command.AddOptionalSwitch("-d", "", &flag);
147 ASSERT_EQ(0, command.Execute({"-d"s}, &std::cerr));
148 EXPECT_TRUE(flag);
149
150 // A flag with a value only works via its long name syntax.
151 std::optional<std::string> val;
152 command.AddOptionalFlag("--with-val", "", &val);
153 ASSERT_EQ(0, command.Execute({"--with-val"s, "1"s}, &std::cerr));
154 EXPECT_TRUE(val);
155 EXPECT_STREQ("1", val->c_str());
156
157 // Make sure the flags that require a value can't be parsed via short syntax, -w=blah
158 // looks weird.
159 ASSERT_NE(0, command.Execute({"-w"s, "2"s}, &std::cerr));
160 }
161
162 } // namespace aapt