1 /*
2 * Copyright (C) 2022 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17 #include <limits.h>
18
19 #define LOG_TAG "VtsHalBassBoostTest"
20 #include <aidl/Vintf.h>
21 #include <android-base/logging.h>
22 #include "EffectHelper.h"
23 #include "pffft.hpp"
24
25 using namespace android;
26
27 using aidl::android::hardware::audio::common::getChannelCount;
28 using aidl::android::hardware::audio::effect::BassBoost;
29 using aidl::android::hardware::audio::effect::Capability;
30 using aidl::android::hardware::audio::effect::Descriptor;
31 using aidl::android::hardware::audio::effect::getEffectTypeUuidBassBoost;
32 using aidl::android::hardware::audio::effect::IEffect;
33 using aidl::android::hardware::audio::effect::IFactory;
34 using aidl::android::hardware::audio::effect::Parameter;
35 using aidl::android::hardware::audio::effect::Range;
36 using android::hardware::audio::common::testing::detail::TestExecutionTracer;
37
38 // minimal HAL interface version to run bassboost data path test
39 constexpr int32_t kMinDataTestHalVersion = 2;
40 static const std::vector<int32_t> kLayouts = {AudioChannelLayout::LAYOUT_STEREO,
41 AudioChannelLayout::LAYOUT_MONO};
42 /*
43 * Testing parameter range, assuming the parameter supported by effect is in this range.
44 * Parameter should be within the valid range defined in the documentation,
45 * for any supported value test expects EX_NONE from IEffect.setParameter(),
46 * otherwise expect EX_ILLEGAL_ARGUMENT.
47 */
48
49 class BassBoostEffectHelper : public EffectHelper {
50 public:
SetUpBassBoost(int32_t layout=kDefaultChannelLayout)51 void SetUpBassBoost(int32_t layout = kDefaultChannelLayout) {
52 ASSERT_NE(nullptr, mFactory);
53 ASSERT_NO_FATAL_FAILURE(create(mFactory, mEffect, mDescriptor));
54 setFrameCounts(layout);
55
56 AudioChannelLayout channelLayout =
57 AudioChannelLayout::make<AudioChannelLayout::layoutMask>(layout);
58
59 Parameter::Specific specific = getDefaultParamSpecific();
60 Parameter::Common common = createParamCommon(
61 0 /* session */, 1 /* ioHandle */, kSamplingFrequency /* iSampleRate */,
62 kSamplingFrequency /* oSampleRate */, mInputFrameCount /* iFrameCount */,
63 mOutputFrameCount /* oFrameCount */, channelLayout, channelLayout);
64 ASSERT_NO_FATAL_FAILURE(open(mEffect, common, specific, &mOpenEffectReturn, EX_NONE));
65 ASSERT_NE(nullptr, mEffect);
66 }
67
TearDownBassBoost()68 void TearDownBassBoost() {
69 ASSERT_NO_FATAL_FAILURE(close(mEffect));
70 ASSERT_NO_FATAL_FAILURE(destroy(mFactory, mEffect));
71 mOpenEffectReturn = IEffect::OpenEffectReturn{};
72 }
73
getDefaultParamSpecific()74 Parameter::Specific getDefaultParamSpecific() {
75 BassBoost bb = BassBoost::make<BassBoost::strengthPm>(0);
76 Parameter::Specific specific =
77 Parameter::Specific::make<Parameter::Specific::bassBoost>(bb);
78 return specific;
79 }
80
setFrameCounts(int32_t inputBufferLayout)81 void setFrameCounts(int32_t inputBufferLayout) {
82 int channelCount = getChannelCount(
83 AudioChannelLayout::make<AudioChannelLayout::layoutMask>(inputBufferLayout));
84 mInputFrameCount = kInputSize / channelCount;
85 mOutputFrameCount = kInputSize / channelCount;
86 }
87
createBassBoostParam(int strength)88 Parameter createBassBoostParam(int strength) {
89 return Parameter::make<Parameter::specific>(
90 Parameter::Specific::make<Parameter::Specific::bassBoost>(
91 BassBoost::make<BassBoost::strengthPm>(strength)));
92 }
93
isStrengthValid(int strength)94 bool isStrengthValid(int strength) {
95 auto bb = BassBoost::make<BassBoost::strengthPm>(strength);
96 return isParameterValid<BassBoost, Range::bassBoost>(bb, mDescriptor);
97 }
98
setAndVerifyParameters(int strength,binder_exception_t expected)99 void setAndVerifyParameters(int strength, binder_exception_t expected) {
100 auto expectedParam = createBassBoostParam(strength);
101 EXPECT_STATUS(expected, mEffect->setParameter(expectedParam)) << expectedParam.toString();
102
103 if (expected == EX_NONE) {
104 auto bbId = BassBoost::Id::make<BassBoost::Id::commonTag>(
105 BassBoost::Tag(BassBoost::strengthPm));
106 auto id = Parameter::Id::make<Parameter::Id::bassBoostTag>(bbId);
107 // get parameter
108 Parameter getParam;
109 // if set success, then get should match
110 EXPECT_STATUS(expected, mEffect->getParameter(id, &getParam));
111 EXPECT_EQ(expectedParam, getParam) << "\nexpectedParam:" << expectedParam.toString()
112 << "\ngetParam:" << getParam.toString();
113 }
114 }
115
116 static constexpr int kDurationMilliSec = 1440;
117 static constexpr int kInputSize = kSamplingFrequency * kDurationMilliSec / 1000;
118 long mInputFrameCount, mOutputFrameCount;
119 std::shared_ptr<IFactory> mFactory;
120 Descriptor mDescriptor;
121 std::shared_ptr<IEffect> mEffect;
122 IEffect::OpenEffectReturn mOpenEffectReturn;
123 };
124
125 /**
126 * Here we focus on specific parameter checking, general IEffect interfaces testing performed in
127 * VtsAudioEffectTargetTest.
128 */
129 enum ParamName { PARAM_INSTANCE_NAME, PARAM_STRENGTH };
130 using BassBoostParamTestParam = std::tuple<std::pair<std::shared_ptr<IFactory>, Descriptor>, int>;
131
132 class BassBoostParamTest : public ::testing::TestWithParam<BassBoostParamTestParam>,
133 public BassBoostEffectHelper {
134 public:
BassBoostParamTest()135 BassBoostParamTest() : mParamStrength(std::get<PARAM_STRENGTH>(GetParam())) {
136 std::tie(mFactory, mDescriptor) = std::get<PARAM_INSTANCE_NAME>(GetParam());
137 }
138
SetUp()139 void SetUp() override { ASSERT_NO_FATAL_FAILURE(SetUpBassBoost()); }
TearDown()140 void TearDown() override { TearDownBassBoost(); }
141
142 int mParamStrength = 0;
143 };
144
TEST_P(BassBoostParamTest,SetAndGetStrength)145 TEST_P(BassBoostParamTest, SetAndGetStrength) {
146 if (isStrengthValid(mParamStrength)) {
147 ASSERT_NO_FATAL_FAILURE(setAndVerifyParameters(mParamStrength, EX_NONE));
148 } else {
149 ASSERT_NO_FATAL_FAILURE(setAndVerifyParameters(mParamStrength, EX_ILLEGAL_ARGUMENT));
150 }
151 }
152
153 enum DataParamName { DATA_INSTANCE_NAME, DATA_LAYOUT };
154
155 using BassBoostDataTestParam =
156 std::tuple<std::pair<std::shared_ptr<IFactory>, Descriptor>, int32_t>;
157
158 class BassBoostDataTest : public ::testing::TestWithParam<BassBoostDataTestParam>,
159 public BassBoostEffectHelper {
160 public:
BassBoostDataTest()161 BassBoostDataTest() : mChannelLayout(std::get<DATA_LAYOUT>(GetParam())) {
162 std::tie(mFactory, mDescriptor) = std::get<DATA_INSTANCE_NAME>(GetParam());
163 mStrengthValues = getTestValueSet<BassBoost, int, Range::bassBoost, BassBoost::strengthPm>(
164 {std::get<DATA_INSTANCE_NAME>(GetParam())}, expandTestValueBasic<int>);
165 }
166
SetUp()167 void SetUp() override {
168 SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags);
169 ASSERT_NO_FATAL_FAILURE(SetUpBassBoost(mChannelLayout));
170 SKIP_TEST_IF_VERSION_UNSUPPORTED(mEffect, kMinDataTestHalVersion);
171 }
172
TearDown()173 void TearDown() override {
174 SKIP_TEST_IF_DATA_UNSUPPORTED(mDescriptor.common.flags);
175 TearDownBassBoost();
176 }
177
178 // Find FFT bin indices for testFrequencies and get bin center frequencies
roundToFreqCenteredToFftBin(std::vector<int> & testFrequencies,std::vector<int> & binOffsets)179 void roundToFreqCenteredToFftBin(std::vector<int>& testFrequencies,
180 std::vector<int>& binOffsets) {
181 for (size_t i = 0; i < testFrequencies.size(); i++) {
182 binOffsets[i] = std::round(testFrequencies[i] / kBinWidth);
183 testFrequencies[i] = std::round(binOffsets[i] * kBinWidth);
184 }
185 }
186
187 // Calculate gain difference between low frequency and high frequency magnitude
calculateGainDiff(const std::vector<float> & inputMag,const std::vector<float> & outputMag)188 float calculateGainDiff(const std::vector<float>& inputMag,
189 const std::vector<float>& outputMag) {
190 std::vector<float> gains(inputMag.size());
191
192 for (size_t i = 0; i < inputMag.size(); i++) {
193 gains[i] = 20 * log10(outputMag[i] / inputMag[i]);
194 }
195
196 return gains[0] - gains[1];
197 }
198
199 static constexpr float kBinWidth = (float)kSamplingFrequency / kNPointFFT;
200 std::set<int> mStrengthValues;
201 int32_t mChannelLayout;
202 };
203
TEST_P(BassBoostDataTest,IncreasingStrength)204 TEST_P(BassBoostDataTest, IncreasingStrength) {
205 // Frequencies to generate multitone input
206 std::vector<int> testFrequencies = {100, 1000};
207
208 // FFT bin indices for testFrequencies
209 std::vector<int> binOffsets(testFrequencies.size());
210
211 std::vector<float> input(kInputSize);
212 std::vector<float> baseOutput(kInputSize);
213
214 std::vector<float> inputMag(testFrequencies.size());
215 float prevGain = -100;
216
217 roundToFreqCenteredToFftBin(testFrequencies, binOffsets);
218
219 // Generate multitone input
220 ASSERT_NO_FATAL_FAILURE(
221 generateSineWave(testFrequencies, input, 1.0, kSamplingFrequency, mChannelLayout));
222
223 ASSERT_NO_FATAL_FAILURE(
224 calculateAndVerifyMagnitude(inputMag, mChannelLayout, input, binOffsets));
225
226 if (isStrengthValid(0)) {
227 ASSERT_NO_FATAL_FAILURE(setAndVerifyParameters(0, EX_NONE));
228 } else {
229 GTEST_SKIP() << "Strength not supported, skipping the test\n";
230 }
231
232 ASSERT_NO_FATAL_FAILURE(
233 processAndWriteToOutput(input, baseOutput, mEffect, &mOpenEffectReturn));
234
235 std::vector<float> baseMag(testFrequencies.size());
236
237 ASSERT_NO_FATAL_FAILURE(
238 calculateAndVerifyMagnitude(baseMag, mChannelLayout, baseOutput, binOffsets));
239
240 float baseDiff = calculateGainDiff(inputMag, baseMag);
241
242 for (int strength : mStrengthValues) {
243 // Skipping the further steps for invalid strength values
244 if (!isStrengthValid(strength)) {
245 continue;
246 }
247
248 ASSERT_NO_FATAL_FAILURE(setAndVerifyParameters(strength, EX_NONE));
249
250 std::vector<float> output(kInputSize);
251 std::vector<float> outputMag(testFrequencies.size());
252
253 ASSERT_NO_FATAL_FAILURE(
254 processAndWriteToOutput(input, output, mEffect, &mOpenEffectReturn));
255
256 ASSERT_NO_FATAL_FAILURE(
257 calculateAndVerifyMagnitude(outputMag, mChannelLayout, output, binOffsets));
258
259 float diff = calculateGainDiff(inputMag, outputMag);
260
261 ASSERT_GT(diff, prevGain);
262 ASSERT_GT(diff, baseDiff);
263 prevGain = diff;
264 }
265 }
266
267 std::vector<std::pair<std::shared_ptr<IFactory>, Descriptor>> kDescPair;
268 INSTANTIATE_TEST_SUITE_P(
269 BassBoostTest, BassBoostParamTest,
270 ::testing::Combine(
271 testing::ValuesIn(kDescPair = EffectFactoryHelper::getAllEffectDescriptors(
272 IFactory::descriptor, getEffectTypeUuidBassBoost())),
273 testing::ValuesIn(EffectHelper::getTestValueSet<BassBoost, int, Range::bassBoost,
274 BassBoost::strengthPm>(
275 kDescPair, EffectHelper::expandTestValueBasic<int>))),
__anon779723350102(const testing::TestParamInfo<BassBoostParamTest::ParamType>& info) 276 [](const testing::TestParamInfo<BassBoostParamTest::ParamType>& info) {
277 auto descriptor = std::get<PARAM_INSTANCE_NAME>(info.param).second;
278 std::string strength = std::to_string(std::get<PARAM_STRENGTH>(info.param));
279 std::string name = getPrefix(descriptor) + "_strength_" + strength;
280 std::replace_if(
281 name.begin(), name.end(), [](const char c) { return !std::isalnum(c); }, '_');
282 return name;
283 });
284
285 GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(BassBoostParamTest);
286
287 INSTANTIATE_TEST_SUITE_P(
288 BassBoostTest, BassBoostDataTest,
289 ::testing::Combine(testing::ValuesIn(EffectFactoryHelper::getAllEffectDescriptors(
290 IFactory::descriptor, getEffectTypeUuidBassBoost())),
291 testing::ValuesIn(kLayouts)),
__anon779723350302(const testing::TestParamInfo<BassBoostDataTest::ParamType>& info) 292 [](const testing::TestParamInfo<BassBoostDataTest::ParamType>& info) {
293 auto descriptor = std::get<DATA_INSTANCE_NAME>(info.param).second;
294 std::string layout = std::to_string(std::get<DATA_LAYOUT>(info.param));
295 std::string name = getPrefix(descriptor) + "_layout_" + layout;
296 std::replace_if(
297 name.begin(), name.end(), [](const char c) { return !std::isalnum(c); }, '_');
298 return name;
299 });
300
301 GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(BassBoostDataTest);
302
main(int argc,char ** argv)303 int main(int argc, char** argv) {
304 ::testing::InitGoogleTest(&argc, argv);
305 ::testing::UnitTest::GetInstance()->listeners().Append(new TestExecutionTracer());
306 ABinderProcess_setThreadPoolMaxThreadCount(1);
307 ABinderProcess_startThreadPool();
308 return RUN_ALL_TESTS();
309 }
310