12009-08-11 Dmitry Titov <dimich@chromium.org> 2 3 Reviewed by NOBODY (build fix). 4 5 Attempt to fix the Windows test bot. Reverted r47015 caused one of the Windows 6 bots that runs Layout Tests to save "JS disabled" and "default font 24pt" 7 preferences permanently. Since these preferences are not initialized explicitly in DRT, 8 almost all Layout tests are failing. Attempt to fix by explicit 9 initialization of these into defaults (enabled, 16pt) at the beginning of the DRT. 10 11 * DumpRenderTree/win/DumpRenderTree.cpp: 12 (main): see above. 13 142009-08-10 Steve Falkenburg <sfalken@apple.com> 15 16 Windows nightly fix. 17 18 Reviewed by Ada Chan. 19 20 * FindSafari/FindSafari.cpp: 21 (_tmain): Copy Safari.dll if it exists. 22 232009-08-10 David Levin <levin@chromium.org> 24 25 Reviewed by David Kilzer. 26 27 check-webkit-style doesn't catch braces around single line statements when followed by else. 28 https://bugs.webkit.org/show_bug.cgi?id=28164 29 30 * Scripts/modules/cpp_style.py: Added else to the regex that finds ending }'s when 31 checking the no braces for "single lines" rule. 32 * Scripts/modules/cpp_style_unittest.py: Added test case. 33 342009-08-10 David Kilzer <ddkilzer@apple.com> 35 36 <http://webkit.org/b/28163> bugzilla-tool: scm module should not import bugzilla module 37 38 Reviewed by David Levin. 39 40 * Scripts/bugzilla-tool: 41 (parse_bug_id): Added. Moved from CommitMessage.parse_bug_id() 42 in scm module. 43 * Scripts/modules/scm.py: Removed import of bugzilla module. 44 (CommitMessage.parse_bug_id): Deleted. 45 462009-08-10 Peter Kasting <pkasting@google.com> 47 48 Reviewed by David Kilzer. 49 50 https://bugs.webkit.org/show_bug.cgi?id=18599 51 Work around apparent bug in abs2rel() with symlinked directories. 52 53 * Scripts/resolve-ChangeLogs: 54 552009-08-10 Dan Bernstein <mitz@apple.com> 56 57 Build fix 58 59 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 60 (NPP_New): 61 622009-08-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 63 64 Reviewed by Adam Roben. 65 66 Allow TestNetscapePlugIn to fall back to the Carbon event model 67 68 Previously the plugin would fail, even though the Carbon event 69 model was available. The only way to get the Carbon event model 70 was to pass the "forcecarbon" argument in the test markup, but no 71 tests were using this. 72 73 Now the plugin uses carbon either if it's forced, or if the Cocoa 74 event model is not supported. 75 76 This helps us run most of the plugin tests on Qt/Mac, which still 77 does not support the Cocoa event model. 78 79 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 80 (NPP_New): 81 822009-08-08 Adam Barth <abarth@webkit.org> 83 84 Reviewed by Eric Seidel. 85 86 bugzilla-tool needs a --quiet option 87 https://bugs.webkit.org/show_bug.cgi?id=28060 88 89 A first pass at a --quiet option. This doesn't do all the excting 90 things we might want, but it addresses 80% of the use case. 91 92 * Scripts/bugzilla-tool: 93 942009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org> 95 96 Reviewed by Xan Lopez. 97 98 [Gtk] Enable accessibility in Gtk DRT 99 https://bugs.webkit.org/show_bug.cgi?id=25989 100 101 Add Accessibility support to the GTK DRT. 102 103 * DumpRenderTree/AccessibilityUIElement.h: 104 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Added. 105 (AccessibilityController::AccessibilityController): 106 (AccessibilityController::~AccessibilityController): 107 (AccessibilityController::focusedElement): 108 (AccessibilityController::rootElement): 109 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Added. 110 (AccessibilityUIElement::AccessibilityUIElement): 111 (AccessibilityUIElement::~AccessibilityUIElement): 112 (AccessibilityUIElement::getLinkedUIElements): 113 (AccessibilityUIElement::getDocumentLinks): 114 (AccessibilityUIElement::getChildren): 115 (AccessibilityUIElement::getChildrenWithRange): 116 (AccessibilityUIElement::childrenCount): 117 (AccessibilityUIElement::elementAtPoint): 118 (AccessibilityUIElement::getChildAtIndex): 119 (AccessibilityUIElement::allAttributes): 120 (AccessibilityUIElement::attributesOfLinkedUIElements): 121 (AccessibilityUIElement::attributesOfDocumentLinks): 122 (AccessibilityUIElement::titleUIElement): 123 (AccessibilityUIElement::parentElement): 124 (AccessibilityUIElement::attributesOfChildren): 125 (AccessibilityUIElement::parameterizedAttributeNames): 126 (AccessibilityUIElement::role): 127 (AccessibilityUIElement::title): 128 (AccessibilityUIElement::description): 129 (AccessibilityUIElement::language): 130 (AccessibilityUIElement::x): 131 (AccessibilityUIElement::y): 132 (AccessibilityUIElement::width): 133 (AccessibilityUIElement::height): 134 (AccessibilityUIElement::clickPointX): 135 (AccessibilityUIElement::clickPointY): 136 (AccessibilityUIElement::intValue): 137 (AccessibilityUIElement::minValue): 138 (AccessibilityUIElement::maxValue): 139 (AccessibilityUIElement::valueDescription): 140 (AccessibilityUIElement::isEnabled): 141 (AccessibilityUIElement::insertionPointLineNumber): 142 (AccessibilityUIElement::isActionSupported): 143 (AccessibilityUIElement::isRequired): 144 (AccessibilityUIElement::attributesOfColumnHeaders): 145 (AccessibilityUIElement::attributesOfRowHeaders): 146 (AccessibilityUIElement::attributesOfColumns): 147 (AccessibilityUIElement::attributesOfRows): 148 (AccessibilityUIElement::attributesOfVisibleCells): 149 (AccessibilityUIElement::attributesOfHeader): 150 (AccessibilityUIElement::indexInTable): 151 (AccessibilityUIElement::rowIndexRange): 152 (AccessibilityUIElement::columnIndexRange): 153 (AccessibilityUIElement::lineForIndex): 154 (AccessibilityUIElement::boundsForRange): 155 (AccessibilityUIElement::cellForColumnAndRow): 156 (AccessibilityUIElement::selectedTextRange): 157 (AccessibilityUIElement::setSelectedTextRange): 158 (AccessibilityUIElement::attributeValue): 159 (AccessibilityUIElement::isAttributeSettable): 160 (AccessibilityUIElement::increment): 161 (AccessibilityUIElement::decrement): 162 * DumpRenderTree/gtk/DumpRenderTree.cpp: 163 (webViewWindowObjectCleared): 164 (main): 165 * GNUmakefile.am: 166 1672009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org> 168 169 Unreviewed Gtk build fix. 170 171 DRT needs internal WTF symbols so we link to libJavaScriptCore.la 172 too. Also don't force Gtk to use USE_SYSTEM_MALLOC. 173 174 * GNUmakefile.am: 175 1762009-08-07 Darin Adler <darin@apple.com> 177 178 * Scripts/commit-log-editor: Fix unchecked access to environment 179 variable that may not be there. 180 1812009-08-07 Mark Rowe <mrowe@apple.com> 182 183 Handle the case where only a single test is missing results. 184 185 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 186 1872009-08-07 George Wright <george.wright@torchmobile.com> 188 189 Reviewed by Adam Treat 190 191 Fix DumpRenderTree for the Qt port to always dump the PNG data unless 192 the expected and actual hashes match. 193 194 https://bugs.webkit.org/show_bug.cgi?id=28077 195 196 * DumpRenderTree/qt/DumpRenderTree.cpp: 197 (WebCore::DumpRenderTree::dump): 198 1992009-08-07 Pierre d'Herbemont <pdherbemont@apple.com> 200 201 Reviewed by Eric Seidel. 202 203 commit-log-editor does not produce a git commit log that is git friendly. 204 https://bugs.webkit.org/show_bug.cgi?id=27754 205 206 We make sure we end up with: 207 - A first paragraph describing the bug. It is eventually prefixed by 208 "WebKit: <line>" or "WebCore: <line>". This used to be 209 "WebCore:\n\n<line>". 210 - The Reviewed By line. 211 - An eventual Patch By line if author and committer doesn't match. 212 - The rest of the commit. 213 214 * Scripts/commit-log-editor: 215 2162009-08-07 Adam Barth <abarth@webkit.org> 217 218 Unreviewed. (Darin Adler indicated he'd prefer if we landed these 219 kinds of changes unreviewed, like editing the WebKit Team wiki page.) 220 221 Added Pierre d'Herbemont to list of committers. 222 223 * Scripts/modules/committers.py: 224 2252009-08-07 Shinichiro Hamaji <hamaji@chromium.org> 226 227 Reviewed by Adele Peterson. 228 229 Cannot scroll for box-reflect:right 230 https://bugs.webkit.org/show_bug.cgi?id=27979 231 232 Update m_overflowLeft an m_overflowWidth for reflection just like 233 m_overflowTop and m_overflowHeight. 234 235 * Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflo 236w-scroll.js 237 2382009-08-06 Shinichiro Hamaji <hamaji@chromium.org> 239 240 Reviewed by Adam Barth. 241 242 box-shadow's spread is ignored with <table> 243 https://bugs.webkit.org/show_bug.cgi?id=28017 244 245 Use RenderStyle::getBoxShadowExtent just like RenderBlock. 246 247 * Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflow-scroll.js 248 2492009-08-06 Eric Seidel <eric@webkit.org> 250 251 No review, only changing make-js-test-wrappers. 252 253 Fix make-js-test-wrappers to ignore a few more js tests 254 with custom templates. 255 256 * Scripts/make-js-test-wrappers: 257 2582009-08-06 Chris Marrin <cmarrin@apple.com> 259 260 Reviewed by David Hyatt. 261 262 Added ENABLE_3D_CANVAS flag to build, default to off 263 264 * Scripts/build-webkit: 265 2662009-08-05 Brady Eidson <beidson@apple.com> 267 268 Reviewed by Darin Adler. 269 270 Win DRT's resource load delegate is missing didReceiveResponse 271 https://bugs.webkit.org/show_bug.cgi?id=28033 272 273 * DumpRenderTree/win/FrameLoadDelegate.cpp: 274 Added: 275 (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): 276 (FrameLoadDelegate::willPerformClientRedirectToURL): 277 (FrameLoadDelegate::didCancelClientRedirectForFrame): 278 279 Minor style cleanup: 280 (FrameLoadDelegate::didStartProvisionalLoadForFrame): 281 (FrameLoadDelegate::didReceiveTitle): 282 (FrameLoadDelegate::didFinishLoadForFrame): 283 (FrameLoadDelegate::willCloseFrame): 284 (FrameLoadDelegate::didClearWindowObject): 285 * DumpRenderTree/win/FrameLoadDelegate.h: 286 2872009-08-05 Brady Eidson <beidson@apple.com> 288 289 Reviewed by Darin Adler. 290 291 Win DRT's resource load delegate is missing didReceiveResponse 292 https://bugs.webkit.org/show_bug.cgi?id=28033 293 294 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 295 (ResourceLoadDelegate::didReceiveResponse): 296 * DumpRenderTree/win/ResourceLoadDelegate.h: 297 2982009-08-05 Darin Fisher <darin@chromium.org> 299 300 Reviewed by Darin Adler. 301 302 Add layoutTestController.dumpWillCacheResponse 303 https://bugs.webkit.org/show_bug.cgi?id=28010 304 305 willCacheResponse is only interesting for embedders of mainline WebKit on Mac. 306 Splitting off a new dumpWillCacheResponse allows a number of existings tests 307 to run across platforms. 308 309 The test that was specifically verifying willCacheResponse now calls 310 dumpWillCacheResponse. 311 312 * DumpRenderTree/LayoutTestController.cpp: Add dumpWillCacheResponse 313 (LayoutTestController::LayoutTestController): 314 (dumpWillCacheResponseCallback): 315 (LayoutTestController::staticFunctions): 316 * DumpRenderTree/LayoutTestController.h: 317 (LayoutTestController::dumpWillCacheResponse): 318 (LayoutTestController::setDumpWillCacheResponse): 319 * DumpRenderTree/mac/ResourceLoadDelegate.mm: Inspect dumpWillCacheResponse 320 instead of dumpResourceLoadCallbacks. 321 (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]): 322 3232009-08-05 Jeremy Orlow <jorlow@chromium.org> 324 325 Reviewed by Adam Barth. 326 327 Add my name to committers.py 328 https://bugs.webkit.org/show_bug.cgi?id=28013 329 330 Add my name to committers.py. 331 332 * Scripts/modules/committers.py: 333 3342009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org> 335 336 Reviewed by Simon Hausmann. 337 338 A minor refactoring of the Qt DRT to be a bit more similar to 339 the other DRTs, as well as more understandable. 340 341 Splitting up resetJSObjects into a LayoutTestController->reset() 342 plus a new closeRemainingWindows() method. 343 344 Added a resetToConsistentStateBeforeTesting() method to keep 345 the code in one place, making it easier to verify that we are 346 doing things properly. 347 348 * DumpRenderTree/qt/DumpRenderTree.cpp: 349 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 350 (WebCore::DumpRenderTree::open): 351 (WebCore::DumpRenderTree::closeRemainingWindows): 352 * DumpRenderTree/qt/DumpRenderTree.h: 353 3542009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org> 355 356 Reviewed by Simon Hausmann. 357 358 Make the Qt DRT WorkQueue work similarily to the cross platform 359 one. This means that all items return true if they started 360 loading. 361 362 This change paves the way for unforking the WorkQueue, if we [Qt] 363 would like that. 364 365 * DumpRenderTree/qt/WorkQueue.cpp: 366 (WorkQueue::processWork): 367 * DumpRenderTree/qt/WorkQueue.h: 368 * DumpRenderTree/qt/WorkQueueItem.h: 369 * DumpRenderTree/qt/jsobjects.cpp: 370 (LoadItem::invoke): 371 (ReloadItem::invoke): 372 (ScriptItem::invoke): 373 (BackForwardItem::invoke): 374 (LayoutTestController::processWork): 375 (LayoutTestController::maybeDump): 376 3772009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 378 379 Reviewed by Simon Hausmann. 380 381 If load of a test fails, don't dump as it will be dumped 382 in the preceding test, resulting in a invalid incorrect layout. 383 384 * DumpRenderTree/qt/jsobjects.cpp: 385 (LayoutTestController::maybeDump): 386 3872009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 388 389 Reviewed by Simon Hausmann. 390 391 Make the Qt DumpRenderTree more similar to the mac one. 392 393 Changes include: 394 1) Reset zoom factor before each test 395 2) Only dump the backforward list when we got other dump result 396 3) When we dump the render tree, and got zero result print out: 397 [mainFrame renderTreeAsExternalRepresentation] 398 and not: 399 [frame renderTreeAsExternalRepresentation] 400 401 * DumpRenderTree/qt/DumpRenderTree.cpp: 402 (WebCore::DumpRenderTree::open): 403 (WebCore::methodNameStringForFailedTest): 404 (WebCore::DumpRenderTree::dump): 405 4062009-08-05 chris fleizach <cfleizach@apple.com> 407 408 Fix Tiger build breakage. 409 410 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 411 4122009-08-04 Chris Fleizach <cfleizach@apple.com> 413 414 Reviewed by Darin Adler. 415 416 Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented 417 https://bugs.webkit.org/show_bug.cgi?id=27994 418 419 Expose valueDescription for accessibility. 420 421 * DumpRenderTree/AccessibilityUIElement.cpp: 422 (getValueDescriptionCallback): 423 (AccessibilityUIElement::getJSClass): 424 * DumpRenderTree/AccessibilityUIElement.h: 425 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 426 (AccessibilityUIElement::valueDescription): 427 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 428 (AccessibilityUIElement::valueDescription): 429 4302009-08-04 Eric Seidel <eric@webkit.org> 431 432 Reviewed by Mark Rowe. 433 434 REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH 435 https://bugs.webkit.org/show_bug.cgi?id=28006 436 437 Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig 438 439 * DumpRenderTree/mac/PerlSupport/Makefile: 440 4412009-08-04 Adam Barth <abarth@webkit.org> 442 443 Reviewed by Darin Adler. 444 445 Add pkasting to bugzilla-tool as a committer 446 https://bugs.webkit.org/show_bug.cgi?id=28002 447 448 * Scripts/modules/committers.py: 449 4502009-08-04 Chris Fleizach <cfleizach@apple.com> 451 452 Reviewed by Darin Adler. 453 454 Bug 27993 - AXSliders are missing required attributes and actions 455 https://bugs.webkit.org/show_bug.cgi?id=27993 456 457 Add ability to check if any arbitrary action is supported. 458 459 * DumpRenderTree/AccessibilityUIElement.cpp: 460 (isActionSupportedCallback): 461 (AccessibilityUIElement::getJSClass): 462 * DumpRenderTree/AccessibilityUIElement.h: 463 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 464 (AccessibilityUIElement::isActionSupported): 465 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 466 (AccessibilityUIElement::isActionSupported): 467 4682009-08-04 Adam Barth <abarth@webkit.org> 469 470 Reviewed by Eric Seidel. 471 472 bugzilla-tool unit tests need a test harness 473 https://bugs.webkit.org/show_bug.cgi?id=27977 474 475 * Scripts/run-webkit-unittests: Added. 476 4772009-08-04 Mark Rowe <mrowe@apple.com> 478 479 Rubber-stamped by Gavin "Gavvy" Barraclough. 480 481 Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions 482 by listing the DumpRenderTree binary as a dependency. Xcode has the smarts to rebuild 483 DumpRenderTree itself when switching OS versions so this dependency removes the need 484 for any smarts in the Makefile. 485 486 * DumpRenderTree/mac/PerlSupport/Makefile: 487 4882009-08-04 Eric Seidel <eric@webkit.org> 489 490 Reviewed by Adam Barth. 491 492 bugzilla-tool needs unit tests 493 https://bugs.webkit.org/show_bug.cgi?id=26916 494 495 Add some basic unit testing for scm.py. 496 497 * Scripts/modules/scm.py: 498 * Scripts/modules/scm_unittest.py: Added. 499 5002009-08-04 Mike Fenton <mike.fenton@torchmobile.com> 501 502 Reviewed by Adam Treat. 503 504 Fix --skipped=only mode to honor flags such as --no-http and platform ignored directories by checking 505 to make sure the Skipped entries are not in the $ignoredDirectories array. Directories commonly included 506 are (http, media, compositing, wml, wcss). 507 508 https://bugs.webkit.org/show_bug.cgi?id=27893 509 510 * Scripts/run-webkit-tests: 511 5122009-08-03 Chris Fleizach <cfleizach@apple.com> 513 514 Reviewed by Jon Honeycutt. 515 516 Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute. 517 https://bugs.webkit.org/show_bug.cgi?id=27958 518 519 Exposed isRequired to DumpRenderTree for accessibility. 520 521 * DumpRenderTree/AccessibilityUIElement.cpp: 522 (getIsRequiredCallback): 523 (AccessibilityUIElement::getJSClass): 524 * DumpRenderTree/AccessibilityUIElement.h: 525 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 526 (AccessibilityUIElement::isRequired): 527 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 528 (AccessibilityUIElement::isRequired): 529 5302009-08-04 Adam Barth <abarth@webkit.org> 531 532 Reviewed by Eric Seidel. 533 534 bugzilla-tool --commit-queue should validate commit-queue setter is a committer 535 https://bugs.webkit.org/show_bug.cgi?id=27974 536 537 With a test! 538 539 * Scripts/modules/bugzilla.py: 540 * Scripts/modules/bugzilla_unittest.py: 541 5422009-08-04 Eric Seidel <eric@webkit.org> 543 544 Reviewed by Adam Barth. 545 546 REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs 547 https://bugs.webkit.org/show_bug.cgi?id=27973 548 549 The trailing comma (suppresses newlines) was lost in r46700. 550 551 * Scripts/bugzilla-tool: 552 5532009-08-04 Adam Barth <abarth@webkit.org> 554 555 Reviewed by Eric Seidel. 556 557 bugzilla-tool has too many fatal errors 558 https://bugs.webkit.org/show_bug.cgi?id=27969 559 560 Replace several fatal errors with ScriptError exceptions. 561 562 * Scripts/bugzilla-tool: 563 * Scripts/modules/bugzilla.py: 564 * Scripts/modules/scm.py: 565 5662009-08-04 Eric Seidel <eric@webkit.org> 567 568 No review, ChangeLog fix only. 569 570 Fix a ChangeLog line-spacing disaster caused by: 571 https://bugs.webkit.org/show_bug.cgi?id=27973 572 573 Still unsure what the fix for bugzilla-tool will be. 574 5752009-08-04 Adam Barth <abarth@webkit.org> 576 577 Reviewed by Eric Seidel. 578 579 bugzilla-tool --commit-queue should only land commit-queue+ patches 580 https://bugs.webkit.org/show_bug.cgi?id=27970 581 582 commit-queue mode for bugzilla-tool 583 https://bugs.webkit.org/show_bug.cgi?id=27918 584 585 Make bugzilla tool smart enough to find the commit-queue+ flags and 586 land those patches. 587 When we call land-patches with --commit-queue, we should filter the 588 patches we land to only those that have the commit-queue+ flag set. 589 That way, when we call bugzilla-tool from a main commit queue process, 590 we won't land the wrong patches. 591 592 * Scripts/bugzilla-tool: 593 5942009-08-04 Eric Seidel <eric@webkit.org> 595 596 Reviewed by Adam Barth. 597 598 committer logic should be split out of bugzilla.py into its own module 599 600 https://bugs.webkit.org/show_bug.cgi?id=27972 601 602 I also added unit tests for the functionality I added. 603 604 * Scripts/modules/bugzilla.py: 605 * Scripts/modules/bugzilla_unittest.py: Added. 606 * Scripts/modules/commiters_unittest.py: Added. 607 * Scripts/modules/committers.py: Added. 608 6092009-08-03 Peter Kasting <pkasting@google.com> 610 611 Reviewed by David Kilzer. 612 613 https://bugs.webkit.org/show_bug.cgi?id=27323 614 Handle any kind of line endings in svn-apply and svn-unapply, instead 615 of assuming LF. 616 617 * Scripts/svn-apply: 618 * Scripts/svn-unapply: 619 6202009-08-03 Adam Barth <abarth@webkit.org> 621 622 Reviewed by Eric Seidel. 623 624 bugzilla-tool land-patches needs --queue mode 625 https://bugs.webkit.org/show_bug.cgi?id=27961 626 627 Add a --commit-queue command line option to suppress user interaction. 628 629 * Scripts/bugzilla-tool: 630 * Scripts/modules/scm.py: 631 6322009-08-03 Mark Rowe <mrowe@apple.com> 633 634 Build fix. Add installsrc, installhdrs and install targets. 635 636 * DumpRenderTree/mac/PerlSupport/Makefile: 637 6382009-08-03 Eric Carlson <eric.carlson@apple.com> 639 640 Reviewed by Eric Seidel. 641 642 HTMLInputElement is not controllable by assistive technologies 643 https://bugs.webkit.org/show_bug.cgi?id=27941 644 645 Accessibility control of a slider required adding increment() and decrement() 646 methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement. 647 648 * DumpRenderTree/AccessibilityUIElement.cpp: 649 (incrementCallback): New, call UI element increment method. 650 (decrementCallback): New, call UI element decrement method. 651 (AccessibilityUIElement::getJSClass): Expose increment and decrement methods. 652 653 * DumpRenderTree/AccessibilityUIElement.h: 654 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 655 (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper. 656 (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper. 657 658 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 659 (AccessibilityUIElement::increment): New, do nothing. 660 (AccessibilityUIElement::decrement): New, do nothing. 661 6622009-08-02 David D. Kilzer <ddkilzer@webkit.org> 663 664 <http://webkit.org/b/27930> bugzilla-tool hates Tor Arne Vestbø 665 666 Reviewed by Tor Arne Vestbø. 667 668 * Scripts/bugzilla-tool: 669 (set_reviewer_in_changelog): Made sure reviewer is properly 670 encoded when calling replace(). 671 6722009-08-02 Kevin Ollivier <kevino@theolliviers.com> 673 674 Reviewed by David Levin. 675 676 Script for building the wxBrowser sample app for wx. 677 https://bugs.webkit.org/show_bug.cgi?id=27619 678 679 * wx/browser/wscript: Added. 680 6812009-08-02 Kevin Ollivier <kevino@theolliviers.com> 682 683 Reviewed by Jan Alonzo. 684 685 Scripts needed for the waf build. 686 https://bugs.webkit.org/show_bug.cgi?id=27619 687 688 * wx/build: Added. 689 * wx/build/build_utils.py: Added. 690 * wx/build/settings.py: Added. 691 * wx/build/waf_extensions.py: Added. 692 * wx/build/wxpresets.py: Added. 693 6942009-08-01 Dan Bernstein <mitz@apple.com> 695 696 Reviewed by Darin Adler. 697 698 Make pixel test results more consistent across Mac OS X versions 699 700 * DumpRenderTree/cg/ImageDiffCG.cpp: 701 (createDifferenceImage): Avoid color correction when rendering the 702 images into graphics contexts, so that the actual color values are 703 compared, regardless of how the images are tagged. 704 * DumpRenderTree/mac/DumpRenderTree.mm: 705 (createWebViewAndOffscreenWindow): Set the window’s color space to the 706 main screen’s color space, even though the window is off-screen. 707 7082009-08-01 Mark Rowe <mrowe@apple.com> 709 710 Try again to make the Qt build bot happy. 711 712 * BuildSlaveSupport/test-result-archive: Create a placeholder file inside the newly-created 713 directory to prevent 'zip' from failing due to the directory containing no files. 714 7152009-08-01 Mark Rowe <mrowe@apple.com> 716 717 Try and make the Qt build bot happy. 718 719 * BuildSlaveSupport/test-result-archive: Handle the case where run-webkit-tests generates 720 no output files at all and thus does not create the layout-test-results directory. 721 7222009-08-01 Mark Rowe <mrowe@apple.com> 723 724 Move the include of DumpRenderTreeSupport to after DumpRenderTree has been built. 725 726 * Scripts/run-webkit-tests: 727 7282009-08-01 Mark Rowe <mrowe@apple.com> 729 730 Reviewed by Sam Weinig and David D. Kilzer. 731 732 Fix <https://bugs.webkit.org/show_bug.cgi?id=27923>. 733 Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X 734 735 run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is 736 in the process of crashing. We can do the same test more efficiently with a simple call to sysctl. 737 I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module 738 instead. This speeds up run-webkit-tests by around 8%. 739 740 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 741 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added. 742 (processIsCrashing): 743 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: Added. Tiger does not have the SWIG tool 744 that is used to generate the Perl binding to the C code, so we fall back to the old implementation on Tiger. 745 * DumpRenderTree/mac/PerlSupport/Makefile: Added. 746 * Scripts/run-webkit-tests: 747 7482009-08-01 Mark Rowe <mrowe@apple.com> 749 750 Reviewed by David D. Kilzer. 751 752 Display the reminder once rather than once per ChangeLog. 753 754 * Scripts/prepare-ChangeLog: 755 7562009-08-01 David Kilzer <ddkilzer@apple.com> 757 758 resolve-ChangeLogs: add error checking to git ls-files command on close() 759 760 Reviewed by Eric Seidel. 761 762 Item 2 of <https://bugs.webkit.org/show_bug.cgi?id=18599#c0>. 763 764 * Scripts/resolve-ChangeLogs: Added error checking to close() 765 after running git ls-files. Added error checking to all 766 system() calls by checking for a non-zero WEXITSTATUS($?). 767 Changed "|| die;" expressions to "or die $!;". 768 7692009-08-01 David Kilzer <ddkilzer@apple.com> 770 771 <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths 772 773 Reviewed by Eric Seidel. 774 775 * Scripts/resolve-ChangeLogs: Used chdirReturningRelativePath() 776 and determineVCSRoot() to change directories to the root of the 777 project before running the command and to provide a path for 778 removeChangeLogArguments() to make sure any ChangeLog arguments 779 on the command line are still found. 780 (canonicalRelativePath): Added. Returns a canonical path (e.g., 781 stripping 'dir/../' from the path) relative to the current 782 directory. 783 (removeChangeLogArguments): Added argument which contains a 784 relative path that must be prepended to any ChangeLog arguments. 785 Used canonicalRelativePath() and File::Spec->catfile() to 786 construct a normalized, relative path to each file. 787 7882009-08-01 David Kilzer <ddkilzer@apple.com> 789 790 Implement VCSUtils::chdirReturningRelativePath() 791 792 Reviewed by Eric Seidel. 793 794 Step 2 to fix: 795 <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths 796 797 * Scripts/VCSUtils.pm: 798 (VCSUtils::chdirReturningRelativePath): Moved here from 799 chdirAndGetDifference() in svn-create-patch. 800 * Scripts/svn-create-patch: Switched to use 801 chdirReturningRelativePath() instead of chdirAndGetDifference(). 802 (chdirAndGetDifference): Removed. 803 8042009-08-01 David Kilzer <ddkilzer@apple.com> 805 806 Implement VCSUtils::determineVCSRoot() 807 808 Reviewed by Eric Seidel. 809 810 Step 1 to fix: 811 <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths 812 813 * Scripts/VCSUtils.pm: Removed reference to webkitdirs module. 814 (VCSUtils::EXPORT): Added &determineVCSRoot. Realphabetized. 815 (VCSUtils::determineGitRoot): Added. Based on code in 816 commit-log-editor. 817 (VCSUtils::determineVCSRoot): Implemented using 818 determineGitRoot() and determineSVNRoot(). 819 * Scripts/commit-log-editor: Replaced use of 820 topLevelSourceDirectory() with determineVCSRoot(). Resorted 821 use statements. 822 (topLevelSourceDirectory): Removed. 823 8242009-07-31 Daniel Bates <dbates@intudata.com> 825 826 Reviewed by Eric Seidel. 827 828 https://bugs.webkit.org/show_bug.cgi?id=27757 829 830 Resolves Perl redefinition warnings about functions tmpfile and tmpnam which are 831 defined in both File::Temp and POSIX. 832 833 This stops the warnings by preventing the "import" method of File::Temp from being called, 834 which would otherwise add these functions into the primary namespace. Note, "use POSIX" 835 will import these functions into the primary namespace anyway. We only need one instance 836 of these functions in our namespace (or we get redefinition warnings), so lets use the 837 one's in the POSIX package. 838 839 * Scripts/update-webkit-auxiliary-libs: Changed "use File::Temp" to "use File::Temp ()". 840 * Scripts/update-webkit-support-libs: ditto 841 8422009-07-31 Laszlo Gombos <laszlo.1.gombos@nokia.com> 843 844 Reviewed by Eric Seidel. 845 846 Add a top level build option to control datagrid support 847 https://bugs.webkit.org/show_bug.cgi?id=27915 848 849 * Scripts/build-webkit: 850 8512009-07-31 David Levin <levin@chromium.org> 852 853 Reviewed by Adam Treat. 854 855 check-webkit-style --git-commit has bugs if you select a commit in the past 856 https://bugs.webkit.org/show_bug.cgi?id=27908 857 858 * Scripts/check-webkit-style: 859 (main): Made the git-commit command only select the first commit 860 if a range is given (and print a warning). 861 * Scripts/modules/scm.py: 862 (SCM::create_patch_from_local_commit): 863 (SCM::create_patch_since_local_commit): 864 (SCM::commit_locally_with_message): 865 (SCM::discard_local_commits): 866 Added an error messages in case these aren't overriden. 867 868 (Git::create_patch_since_local_commit): 869 Added this command to allow doing a diff of everything after a given commit. 870 8712009-07-31 Jan Michael Alonzo <jmalonzo@webkit.org> 872 873 Speculative Qt build fix. Not reviewed. 874 875 Add LayoutTestController::disableImageLoading() in jsobjects.h. 876 877 * DumpRenderTree/qt/jsobjects.h: 878 8792009-07-31 Brady Eidson <beidson@apple.com> 880 881 Reviewed by John Sullivan. 882 883 <rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896 884 Favicons are still loaded when automatic image loading is disabled. 885 886 * DumpRenderTree/LayoutTestController.cpp: 887 (disableImageLoadingCallback): 888 (LayoutTestController::staticFunctions): 889 * DumpRenderTree/LayoutTestController.h: 890 891 * DumpRenderTree/mac/DumpRenderTree.mm: 892 (resetWebViewToConsistentStateBeforeTesting): 893 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 894 (LayoutTestController::disableImageLoading): 895 896 * DumpRenderTree/win/DumpRenderTree.cpp: 897 (resetWebViewToConsistentStateBeforeTesting): 898 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 899 (LayoutTestController::disableImageLoading): 900 901 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 902 (LayoutTestController::disableImageLoading): Stubbed for now. 903 * DumpRenderTree/qt/jsobjects.cpp: 904 (LayoutTestController::disableImageLoading): Ditto. 905 9062009-07-30 Eric Seidel <eric@webkit.org> 907 908 Reviewed by David Kilzer. 909 910 bugzilla-tool post-commits trunk..head errors out 911 https://bugs.webkit.org/show_bug.cgi?id=27847 912 913 Rename commit_ids_from_range_arguments to commit_ids_from_commitish_arguments 914 and make it handle the new arguments format proposed in the bug. 915 916 * Scripts/bugzilla-tool: 917 * Scripts/modules/scm.py: 918 9192009-07-30 Eric Seidel <eric@webkit.org> 920 921 Reviewed by David Levin. 922 923 clean up build-webkit to use less copy/paste code and remove unneeded SVG warning 924 https://bugs.webkit.org/show_bug.cgi?id=27857 925 926 * Scripts/build-webkit: 927 9282009-07-31 David Kilzer <ddkilzer@apple.com> 929 930 <http://webkit.org/b/27894> bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5 931 932 Reviewed by Eric Seidel. 933 934 * Scripts/modules/bugzilla.py: 935 (Bugzilla.clear_attachment_review_flag): Specify which 'comment' 936 form field to use when setting its value. 937 9382009-07-31 Eric Seidel <eric@webkit.org> 939 940 Reviewed by David Kilzer. 941 942 bugzilla-tool post-commits obsoletes its own work :( 943 https://bugs.webkit.org/show_bug.cgi?id=27849 944 945 Simple fix. Use .add() instead of .update() 946 947 * Scripts/bugzilla-tool: 948 9492009-07-31 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 950 951 Reviewed by Anders Carlsson. 952 953 Improve platform-detection in run-webkit-tests 954 955 This prevents miss-detection of mac-* over Qt/Mac. 956 957 * Scripts/run-webkit-tests: 958 9592009-07-30 Mark Rowe <mrowe@apple.com> 960 961 Reviewed by Cameron Zwarich. 962 963 Teach buildbot to detect test cases that are missing results. 964 965 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 966 9672009-07-30 Mark Rowe <mrowe@apple.com> 968 969 Things work better when you create the correct directories. 970 971 * Scripts/run-webkit-tests: 972 9732009-07-30 Mark Rowe <mrowe@apple.com> 974 975 Include some information about the error when we die. 976 977 * Scripts/run-webkit-tests: 978 9792009-07-30 Mark Rowe <mrowe@apple.com> 980 981 Ensure that the path exists before writing results to it. 982 Hopefully this will make the Windows build bot happy. 983 984 * Scripts/run-webkit-tests: 985 9862009-07-30 Mark Rowe <mrowe@apple.com> 987 988 Reviewed by Adam Treat and Jon Honeycutt. 989 990 Teach run-webkit-tests to always store the actual results in the results directory for new tests. 991 This allows us to give a working link to the results from the result summary page, even if we're 992 not generating new results in to the tree. 993 994 * Scripts/run-webkit-tests: 995 9962009-07-30 Mark Rowe <mrowe@apple.com> 997 998 Add a Qt Linux build bot. 999 1000 * BuildSlaveSupport/build.webkit.org-config/config.json: 1001 10022009-07-30 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1003 1004 Reviewed by Adam Roben. 1005 1006 Add --minimal option to webkit-build. 1007 https://bugs.webkit.org/show_bug.cgi?id=27852 1008 1009 This option disables all optional build features unless 1010 they are explicitly enabled. 1011 1012 * Scripts/build-webkit: 1013 10142009-07-30 Jakub Wieczorek <faw217@gmail.com> 1015 1016 [Qt] Fix build with GCC 4.4. 1017 1018 * DumpRenderTree/qt/ImageDiff.cpp: 1019 10202009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com> 1021 1022 Reviewed by Simon Hausmann. 1023 1024 https://bugs.webkit.org/show_bug.cgi?id=27813 1025 1026 [Qt] Support pixel tests in DumpRenderTree for the Qt port. 1027 1028 * DumpRenderTree/qt/DumpRenderTree.cpp: 1029 (WebCore::DumpRenderTree::DumpRenderTree): 1030 (WebCore::DumpRenderTree::open): 1031 (WebCore::DumpRenderTree::setDumpPixels): 1032 (WebCore::DumpRenderTree::dump): 1033 * DumpRenderTree/qt/DumpRenderTree.h: 1034 * DumpRenderTree/qt/main.cpp: 1035 (main): 1036 10372009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com> 1038 1039 Reviewed by Simon Hausmann. 1040 1041 https://bugs.webkit.org/show_bug.cgi?id=27813 1042 1043 [Qt] Implement ImageDiff. 1044 1045 * DumpRenderTree/qt/ImageDiff.cpp: Added. 1046 * DumpRenderTree/qt/ImageDiff.pro: Added. 1047 10482009-07-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 1049 1050 Reviewed by Eric Seidel. 1051 1052 build-webkit: Reorder logic for determining the baseProductDir 1053 1054 https://bugs.webkit.org/show_bug.cgi?id=27699 1055 1056 We now do port-spesific probing for the product dir first, and then 1057 fall back to either the generic WEBKITOUTPUTDIR (which now also works 1058 on Mac), or WebKitBuild. 1059 1060 Then we add the git branch if the git branch build option is enabled. 1061 1062 Finally we massage the product dir based on the port. For example the 1063 Mac port will now always set the SYMROOT and OBJROOT configuration for 1064 XCode. 1065 1066 Note that isAppleWinWebkit() and isCygwin() is not mutually exclusive, 1067 hence the normal if and not elsif in the last two blocks. 1068 1069 * Scripts/webkitdirs.pm: 1070 10712009-07-29 David Kilzer <ddkilzer@apple.com> 1072 1073 <http://webkit.org/b/27082> bugzilla-tool: Add --no-close switch to land-patches 1074 1075 Reviewed by David Levin. 1076 1077 * Scripts/bugzilla-tool: 1078 (LandPatchesFromBugs.__init__): Added --no-close switch. 1079 (LandPatchesFromBugs.land_patches): Don't close the bug if the 1080 --no-close switch was used. Always clear the review+ flag on 1081 every landed patch using the commit_text message when cleared. 1082 This prevents patches from showing up in the commit queue if 1083 reopened and provides consistency with all landed patches. 1084 * Scripts/modules/bugzilla.py: 1085 (Bugzilla.clear_attachment_review_flag): Added. 1086 10872009-07-29 David Kilzer <ddkilzer@apple.com> 1088 1089 <http://webkit.org/b/27815> bugzilla-tool: add -m/--description to post-commits command 1090 1091 Reviewed by Eric Seidel. 1092 1093 * Scripts/bugzilla-tool: 1094 (PostDiffAsPatchToBug.execute): Changed default patch name from 1095 "patch" to "Patch v1". 1096 (PostCommitsAsPatchesToBug.__init__): Added -m/--description 1097 switch. 1098 (PostCommitsAsPatchesToBug.execute): Use description provided by 1099 -m/--description switch first, else fall back to the commit 1100 message. 1101 11022009-07-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 1103 1104 Reviewed by Dave Levin. 1105 1106 Make check-webkit-style support files as arguments. 1107 https://bugs.webkit.org/show_bug.cgi?id=27549 1108 1109 * Scripts/check-webkit-style: 1110 Support files as argument. Change documentation and use basename 1111 on the binary name when used in the documentation. Also do not 1112 die when printing something containing non-ASCII characters. 1113 11142009-08-06 Mike Fenton <mike.fenton@torchmobile.com> 1115 1116 Reviewed by David Levin. 1117 1118 Add validation for pointer and reference declaration as defined by webkit style guidelines to cpp_style.py. 1119 Add unit tests for validation and update existing c style cast test to be run explicitly as c validation. 1120 1121 https://bugs.webkit.org/show_bug.cgi?id=27984 1122 1123 * Scripts/modules/cpp_style.py: 1124 * Scripts/modules/cpp_style_unittest.py: 1125 11262009-07-29 David Kilzer <ddkilzer@apple.com> 1127 1128 <http://webkit.org/b/27119> bugzilla-tool: Add create-bug command 1129 1130 Reviewed by David Levin. 1131 1132 Implement "create-bug" command for bugzilla-tool. 1133 1134 * Scripts/bugzilla-tool: Added CreateBug class. 1135 (CreateBug.__init__): Added. 1136 (CreateBug.create_bug_from_commit): Added. 1137 (CreateBug.create_bug_from_patch): Added. 1138 (CreateBug.prompt_for_bug_title_and_comment): Added. 1139 (CreateBug.execute): Added. 1140 (BugzillaTool.__init__): Added create-bug command. 1141 * Scripts/modules/bugzilla.py: 1142 (Bugzilla.prompt_for_component): Added. 1143 (Bugzilla.check_create_bug_response_returning_bug_id_on_success): Added. 1144 (Bugzilla.create_bug_with_patch): Added. 1145 11462009-07-29 Jan Michael Alonzo <jmalonzo@webkit.org> 1147 1148 Reviewed by Eric Seidel and Xan Lopez. 1149 1150 [Gtk] Enable http/tests/appcache tests 1151 https://bugs.webkit.org/show_bug.cgi?id=27674 1152 1153 Add support for testing http/tests/appcache tests. 1154 1155 * DumpRenderTree/gtk/DumpRenderTree.cpp: 1156 (resetWebViewToConsistentStateBeforeTesting): 1157 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 1158 (LayoutTestController::setAppCacheMaximumSize): 1159 11602009-07-28 Mark Rowe <mrowe@apple.com> 1161 1162 Reviewed by Oliver Hunt. 1163 1164 Prevent nightly builds of WebKit from launching against old Safari versions that we no longer work with. 1165 1166 * WebKitLauncher/main.m: 1167 (checkSafariVersion): Add a minimum required Safari version of 4.0. This matches the requirement on Windows. 1168 (main): If the minimum version requirement is not met, display an alert and bail out. 1169 11702009-07-28 David Levin <levin@chromium.org> 1171 1172 Reviewed by Adam Treat. 1173 1174 cpplint* should be named cpp_style* 1175 https://bugs.webkit.org/show_bug.cgi?id=27752 1176 1177 The files were renamed. A few renames were done: 1178 CppLint -> CppStyle 1179 cpplint -> cpp_style 1180 1181 * Scripts/check-webkit-style: 1182 * Scripts/modules/cpp_style.py: Copied from cpplint.py and 1183 did name fix ups. 1184 * Scripts/modules/cpp_style_unittest.py: Copied from cpplint_unittest.py and 1185 did name fix ups. 1186 * Scripts/modules/cpplint.py: Removed. 1187 * Scripts/modules/cpplint_unittest.py: Removed. 1188 11892009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 1190 1191 Rubber-stamped by Holger Freyther. 1192 1193 Add Steve Falkenburg to bugzilla-tools' reviewers list 1194 1195 * Scripts/modules/bugzilla.py: 1196 11972009-07-28 Zoltan Horvath <hzoltan@inf.u-szeged.hu> 1198 1199 Reviewed by Simon Hausmann. 1200 1201 Implement test result archive support for the Qt port. 1202 1203 * BuildSlaveSupport/test-result-archive: 1204 12052009-07-27 Brady Eidson <beidson@apple.com> 1206 1207 Reviewed by Sam Weinig. 1208 1209 https://bugs.webkit.org/show_bug.cgi?id=27755 1210 Layout tests that dump resource load delegate calls should dump the request method and the response status code. 1211 1212 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 1213 (-[NSURLResponse _drt_descriptionSuitableForTestResult]): 1214 (-[NSURLRequest _drt_descriptionSuitableForTestResult]): 1215 1216 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 1217 (descriptionSuitableForTestResult): 1218 12192009-07-27 Pierre d'Herbemont <pdherbemont@apple.com> 1220 1221 Reviewed by David Levin. 1222 1223 "bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load. 1224 https://bugs.webkit.org/show_bug.cgi?id=27747 1225 1226 modules.bugzilla is not found because not included. 1227 1228 * Scripts/modules/scm.py: Properly import modules.bugzilla. 1229 12302009-07-24 Pierre d'Herbemont <pdherbemont@apple.com> 1231 1232 Reviewed by David Kilzer. 1233 1234 commit-log-editor should allow git commit --amend to regenerate the commit log based on the modifed ChangeLog 1235 https://bugs.webkit.org/show_bug.cgi?id=27664 1236 1237 * Scripts/commit-log-editor: Add --regenerate-log option. 1238 The user is asked if he wants to suppress previous ChangeLog and regenerate it, 1239 if this option is enabled. 1240 12412009-07-27 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu> 1242 1243 Reviewed by Simon Hausmann. 1244 1245 Generating remote links causes a lot of unnecessary spew on Qt build bot too 1246 1247 * Scripts/run-webkit-tests: 1248 12492009-07-25 Kwang Yul Seo <skyul@company100.net> 1250 1251 Reviewed by Darin Adler. 1252 1253 Windows build break due to warning C4819 1254 https://bugs.webkit.org/show_bug.cgi?id=27416 1255 1256 Disable C4819 warning to fix build. 1257 1258 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 1259 12602009-07-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com> 1261 1262 Not reviewed. Add Kevin McCullough as reviewer in bugzilla.py 1263 1264 * Scripts/modules/bugzilla.py: 1265 12662009-07-24 Eli Fidler <eli.fidler@torchmobile.com> 1267 1268 Reviewed by Adam Treat. 1269 1270 Improve git workflow by populating commit messages with ChangeLog entries. 1271 https://bugs.webkit.org/show_bug.cgi?id=27605 1272 1273 If the user doesn't manually modify the ChangeLog files, use 1274 prepare-ChangeLog to populate the git commit message. This behaviour 1275 can be disabled by the 'webkitGenerateCommitMessage' git configuration option. 1276 1277 * Scripts/commit-log-editor: 1278 12792009-07-24 David Levin <levin@chromium.org> 1280 1281 Reviewed by Adam Treat. 1282 1283 cpplint crash when there is a duplicate header followed by another header. 1284 https://bugs.webkit.org/show_bug.cgi?id=27625 1285 1286 * Scripts/modules/cpplint.py: Ensure that include_state.header_types is updated even 1287 there is a duplicate header, which resulted in some code rearrangement. Also, 1288 changed some if's in this function to return early. This avoids having nearly the 1289 whole function content being indented. 1290 * Scripts/modules/cpplint_unittest.py: Added a test which would have exposed the crash. 1291 12922009-07-24 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1293 1294 Reviewed by Adam Treat. 1295 1296 Filetype support changes for cpplint and check_webkit_style 1297 https://bugs.webkit.org/show_bug.cgi?id=27653 1298 1299 Introduce .c support for check_webkit_style, and remove support for 1300 .cc files in favor of .cpp. 1301 1302 * Scripts/check-webkit-style: 1303 * Scripts/modules/cpplint.py: 1304 * Scripts/modules/cpplint_unittest.py: 1305 13062009-07-24 Eli Fidler <eli.fidler@torchmobile.com> 1307 1308 Reviewed by David Levin. 1309 1310 Improve git workflow by populating commit messages with ChangeLog entries. 1311 https://bugs.webkit.org/show_bug.cgi?id=27605 1312 1313 add --[no-]write prepare-ChangeLog options to bash completion 1314 1315 * Scripts/webkit-tools-completion.sh: 1316 13172009-07-24 Andrei Popescu <andreip@google.com> 1318 1319 Reviewed by Anders Carlsson. 1320 1321 ApplicationCache should have size limit 1322 https://bugs.webkit.org/show_bug.cgi?id=22700 1323 1324 Adds a new method on the LayoutTestController that 1325 allows a JS unit test to configure the maximum size 1326 of the Application Cache. 1327 1328 * DumpRenderTree/LayoutTestController.cpp: 1329 (setAppCacheMaximumSizeCallback): 1330 (LayoutTestController::staticFunctions): 1331 * DumpRenderTree/LayoutTestController.h: 1332 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 1333 (LayoutTestController::setAppCacheMaximumSize): 1334 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 1335 (LayoutTestController::setAppCacheMaximumSize): 1336 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 1337 (LayoutTestController::setAppCacheMaximumSize): 1338 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 1339 (LayoutTestController::setAppCacheMaximumSize): 1340 13412009-07-24 Adam Barth <abarth@webkit.org> 1342 1343 Rubber stamped by Eric Seidel. 1344 1345 Added andersca to list of reviewers. 1346 1347 * Scripts/modules/bugzilla.py: 1348 13492009-07-24 Mark Rowe <mrowe@apple.com> 1350 1351 Reviewed by Xan Lopez. 1352 1353 Fix dozens of "Deallocation of a pointer not malloced" messages seen while running 1354 layout tests on the build bot. 1355 1356 Memory allocated via FastMalloc was being deleted via the system memory allocator 1357 due to an inconsistent including of FastMalloc.h. We address this by including it 1358 from config.h and including config.h from every implementation file, as in our other 1359 projects. 1360 1361 * DumpRenderTree/ForwardingHeaders/wtf/FastMalloc.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h. 1362 * DumpRenderTree/config.h: 1363 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 1364 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 1365 * DumpRenderTree/mac/AppleScriptController.m: 1366 * DumpRenderTree/mac/CheckedMalloc.cpp: 1367 * DumpRenderTree/mac/DumpRenderTree.mm: 1368 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: 1369 * DumpRenderTree/mac/DumpRenderTreePasteboard.m: 1370 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: 1371 * DumpRenderTree/mac/EditingDelegate.mm: 1372 * DumpRenderTree/mac/EventSendingController.mm: 1373 * DumpRenderTree/mac/FrameLoadDelegate.mm: 1374 * DumpRenderTree/mac/GCControllerMac.mm: 1375 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 1376 * DumpRenderTree/mac/NavigationController.m: 1377 * DumpRenderTree/mac/ObjCController.m: 1378 * DumpRenderTree/mac/ObjCPlugin.m: 1379 * DumpRenderTree/mac/ObjCPluginFunction.m: 1380 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 1381 * DumpRenderTree/mac/PlainTextController.mm: 1382 * DumpRenderTree/mac/PolicyDelegate.mm: 1383 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 1384 * DumpRenderTree/mac/TextInputController.m: 1385 * DumpRenderTree/mac/UIDelegate.mm: 1386 * DumpRenderTree/mac/WorkQueueItemMac.mm: 1387 13882009-07-24 Mark Rowe <mrowe@apple.com> 1389 1390 Reviewed by Simon Hausmann. 1391 1392 Add a command line option to run-javascriptcore-tests to explicitly opt out of attempting to rebuild JavaScriptCore. 1393 This is primarily useful to speed up the build bots where one machine builds JavaScriptCore and a second runs the tests, 1394 leading to situations where the build system unnecessarily feels that the need to recompile. 1395 1396 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 1397 * Scripts/run-javascriptcore-tests: 1398 13992009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org> 1400 1401 Reviewed by Eric Seidel. 1402 1403 [Gtk] Add implementation of GCController for DRT 1404 https://bugs.webkit.org/show_bug.cgi?id=27636 1405 1406 * DumpRenderTree/gtk/DumpRenderTree.cpp: 1407 (webViewWindowObjectCleared): 1408 (main): 1409 * DumpRenderTree/gtk/GCControllerGtk.cpp: 1410 (GCController::collect): 1411 (GCController::collectOnAlternateThread): 1412 (GCController::getJSObjectCount): 1413 14142009-07-23 Mark Rowe <mrowe@apple.com> 1415 1416 Update build.webkit.org config for new machine. 1417 1418 * BuildSlaveSupport/build.webkit.org-config/config.json: 1419 14202009-07-23 Brady Eidson <beidson@apple.com> 1421 1422 Remove accidentally checked in code. 1423 1424 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 1425 (waitUntilDoneWatchdogFired): 1426 (LayoutTestController::setWaitToDump): 1427 14282009-07-23 Brady Eidson <beidson@apple.com> 1429 1430 Reviewed by Geoff Garen. 1431 1432 WebCore has a few places that don't gracefully handle a null request returned from willSendRequest. 1433 https://bugs.webkit.org/show_bug.cgi?id=27595 1434 1435 Add the ability to tell the LayoutTestController to return a null request for willSendRequest 1436 redirect callbacks. 1437 1438 * DumpRenderTree/LayoutTestController.cpp: 1439 (LayoutTestController::LayoutTestController): 1440 (setWillSendRequestReturnsNullOnRedirectCallback): 1441 (LayoutTestController::staticFunctions): 1442 * DumpRenderTree/LayoutTestController.h: 1443 (LayoutTestController::willSendRequestReturnsNullOnRedirect): 1444 (LayoutTestController::setWillSendRequestReturnsNullOnRedirect): 1445 1446 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 1447 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): 1448 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 1449 (ResourceLoadDelegate::willSendRequest): 1450 14512009-07-23 Mark Rowe <mrowe@apple.com> 1452 1453 Reviewed Oliver Hunt. 1454 1455 Fix DumpRenderTree to not fail an assertion on launch on a new machine. 1456 1457 * DumpRenderTree/mac/DumpRenderTree.mm: 1458 (setDefaultsToConsistentValuesForTesting): Disable the XSS auditor. It being enabled 1459 breaks all of the JavaScript tests within testStringByEvaluatingJavaScriptFromString, 1460 which causes us to exit due to an assertion failure. It's not clear why the XSS auditor 1461 decides to interfere with these tests. 1462 14632009-07-23 Mark Rowe <mrowe@apple.com> 1464 1465 Reviewed by Oliver Hunt. 1466 1467 Update default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows 1468 in hopes of fixing some layout test failures seen on the build bot. 1469 1470 * DumpRenderTree/gtk/DumpRenderTree.cpp: 1471 (resetWebViewToConsistentStateBeforeTesting): 1472 14732009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1474 1475 Reviewed by Adam Treat. 1476 1477 Fix false positives for switch statement indentation check in cpplint. 1478 https://bugs.webkit.org/show_bug.cgi?id=27615 1479 1480 Makes one-line case statements (e.g. "case foo: bar();") work. 1481 Also a few general improvements to the robustness and readability of 1482 the check, and more test cases. 1483 1484 * Scripts/modules/cpplint.py: 1485 * Scripts/modules/cpplint_unittest.py: 1486 14872009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1488 1489 Reviewed by Adam Treat. 1490 1491 Add check for line-breaking rule #3 to cpplint. 1492 https://bugs.webkit.org/show_bug.cgi?id=27610 1493 1494 "An else if statement should be written as an if statement when 1495 the prior if concludes with a return statement." 1496 1497 Implemented by a multi-line (kind of back-tracking) algorithm. 1498 Comes with loads of unit tests. Fixes the check for label indentation 1499 to be not so overzealous, as it didn't allow for completely unindented 1500 goto labels (at the very start of a line). 1501 1502 * Scripts/modules/cpplint.py: 1503 * Scripts/modules/cpplint_unittest.py: 1504 15052009-07-23 Eli Fidler <eli.fidler@torchmobile.com> 1506 1507 Reviewed by Adam Treat. 1508 1509 Improve git workflow by populating commit messages with ChangeLog entries. 1510 https://bugs.webkit.org/show_bug.cgi?id=27605 1511 1512 add --[no-]write option to optionally output new ChangeLog entries to 1513 stdout instead of modifying ChangeLog files 1514 1515 fix Torch Mobile copyright 1516 1517 * Scripts/prepare-ChangeLog: 1518 15192009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1520 1521 Reviewed by Adam Treat. 1522 1523 Enable cpplint for .c files. 1524 https://bugs.webkit.org/show_bug.cgi?id=27604 1525 1526 Also make sure that the check for NULL does not apply to .c files. 1527 1528 * Scripts/modules/cpplint.py: 1529 * Scripts/modules/cpplint_unittest.py: 1530 15312009-07-22 Steve Falkenburg <sfalken@apple.com> 1532 1533 Checkpoint new Windows nightly launcher. 1534 1535 Reviewed by Mark Rowe. 1536 1537 * WebKitLauncherWin: Added. 1538 * WebKitLauncherWin/Resource.h: Added. 1539 * WebKitLauncherWin/WebKitLauncherWin.cpp: Added. 1540 (getStringValue): Retrieve a string registry value. 1541 (applePathFromRegistry): Get an Apple-related path out of the registry. 1542 (copyEnvironmentVariable): Copy an environment variable. 1543 (safariInstallDir): Helper function to get the install directory for Safari. 1544 (safariBrowserExe): Helper function to get the full path of the Safari executable. 1545 (_tWinMain): Locate Safari and launch it after setting up an environment variable. 1546 * WebKitLauncherWin/WebKitLauncherWin.h: Added. 1547 * WebKitLauncherWin/WebKitLauncherWin.rc: Added. 1548 * WebKitLauncherWin/WebKitLauncherWin.vcproj: Added. 1549 * WebKitLauncherWin/webkit.ico: Added. 1550 15512009-07-22 David Levin <levin@chromium.org> 1552 1553 Reviewed by Adam Treat. 1554 1555 run-webkit-lint should be named check-webkit-style 1556 https://bugs.webkit.org/show_bug.cgi?id=27568 1557 1558 This name better reflects the fact that it is about checking the style of files. 1559 1560 * Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint. 1561 15622009-07-22 Takeshi Yoshino <tyoshino@google.com> 1563 1564 Reviewed by Darin Adler. 1565 1566 VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp 1567 https://bugs.webkit.org/show_bug.cgi?id=26375 1568 1569 Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now, 1570 the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals 1571 in the macros before writing out them into the file to update. 1572 1573 By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian 1574 strings in the Localizable.strings file. 1575 1576 Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide 1577 users to update-webkit-localizable-strings. 1578 1579 * Scripts/extract-localizable-strings: 1580 15812009-07-22 Shinichiro Hamaji <hamaji@google.com> 1582 1583 Reviewed by David Levin. 1584 1585 Tiny typo fixes for cpplint.py 1586 https://bugs.webkit.org/show_bug.cgi?id=27530 1587 1588 * Scripts/modules/cpplint.py: 1589 15902009-07-22 Shinichiro Hamaji <hamaji@chromium.org> 1591 1592 Reviewed by David Levin. 1593 1594 run-webkit-lint checks code which are not changed 1595 https://bugs.webkit.org/show_bug.cgi?id=27529 1596 1597 Add check if the line is newly added. 1598 1599 * Scripts/run-webkit-lint: 1600 16012009-07-22 Shinichiro Hamaji <hamaji@chromium.org> 1602 1603 Reviewed by David Levin. 1604 1605 run-webkit-lint should have --git-commit option 1606 https://bugs.webkit.org/show_bug.cgi?id=27528 1607 1608 * Scripts/modules/cpplint.py: 1609 * Scripts/run-webkit-lint: 1610 16112009-07-22 Peter Kasting <pkasting@google.com> 1612 1613 Reviewed by David Kilzer. 1614 1615 https://bugs.webkit.org/show_bug.cgi?id=27323 1616 Factor svn-create-patch's "determineSvnRoot()" into a function in 1617 VCSUtils.pm so commit-log-editor can use it too. 1618 1619 * Scripts/VCSUtils.pm: Add determineSVNRoot(). 1620 * Scripts/commit-log-editor: Use determineSVNRoot() instead of old 1621 code (which didn't work as well). 1622 * Scripts/svn-create-patch: Remove determineSvnRoot() (moved). 1623 16242009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1625 1626 Reviewed by Adam Treat. 1627 1628 Fix false positives in namespace indentation checks. 1629 https://bugs.webkit.org/show_bug.cgi?id=27567 1630 1631 The regular expression detecting goto labels (in order 1632 to skip those) was too permissive, which caused other 1633 code like "Foo::Bar()" to be treated as a label too, 1634 thereby not stopping the processing loop as expected. 1635 1636 Now comes with a stricter regexp, and more demanding 1637 test cases to check for these issues. 1638 1639 * Scripts/modules/cpplint.py: 1640 * Scripts/modules/cpplint_unittest.py: 1641 16422009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1643 1644 Reviewed by Adam Treat. 1645 1646 Fix cpplint generating false positives for 1647 "primary" includes in headers. 1648 https://bugs.webkit.org/show_bug.cgi?id=27553 1649 1650 Doing so by only flagging includes in header files 1651 as primary when the include filename exactly matches 1652 the header filename. 1653 1654 * Scripts/modules/cpplint.py: 1655 * Scripts/modules/cpplint_unittest.py: 1656 16572009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1658 1659 Reviewed by Adam Treat. 1660 1661 cpplint generates false positives for primary includes 1662 https://bugs.webkit.org/show_bug.cgi?id=27544 1663 1664 Fix false positives for instances when cpplint would 1665 normally classify multiple includes as primary: After 1666 the first primary include, classify subsequent ones as 1667 "other" includes even if they look like primary ones. 1668 1669 * Scripts/modules/cpplint.py: 1670 * Scripts/modules/cpplint_unittest.py: 1671 16722009-07-22 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu> 1673 1674 Reviewed by Simon Hausmann. 1675 1676 Pass XAUTHORITY environment variable to $dumpTool as well. 1677 1678 * Scripts/run-webkit-tests: 1679 16802009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1681 1682 Reviewed by Adam Treat. 1683 1684 Add check for correct wtf includes to cpplint. 1685 https://bugs.webkit.org/show_bug.cgi?id=27524 1686 1687 * Scripts/modules/cpplint.py: 1688 * Scripts/modules/cpplint_unittest.py: 1689 16902009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1691 1692 Reviewed by David Levin. 1693 1694 Add checks for multi-line boolean operator placement. 1695 https://bugs.webkit.org/show_bug.cgi?id=27496 1696 1697 * Scripts/modules/cpplint.py: 1698 * Scripts/modules/cpplint_unittest.py: 1699 17002009-07-21 Adam Treat <adam.treat@torchmobile.com> 1701 1702 Reviewed by David Levin. 1703 1704 We can't match implementation file and primary header exactly 1705 since we have so many files in WebKit where the port suffix 1706 is appended to the filename. 1707 1708 Example: FooQt.cpp and the primary header is Foo.h. 1709 1710 * Scripts/modules/cpplint.py: 1711 17122009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1713 1714 Reviewed by David Levin. 1715 1716 Add checks for switch statement indentation to cpplint. 1717 https://bugs.webkit.org/show_bug.cgi?id=27508 1718 1719 * Scripts/modules/cpplint.py: 1720 * Scripts/modules/cpplint_unittest.py: 1721 17222009-07-21 Kenneth Rohde Christiansen <kenneth@webkit.org> 1723 1724 Reviewed by Adam Treat. 1725 1726 Feature request: cpplint should check for braces - rule 2 1727 https://bugs.webkit.org/show_bug.cgi?id=27497 1728 1729 Add the requested feature: Make sure { is on the same line 1730 as the foreach "keyword". 1731 1732 * Scripts/modules/cpplint.py: 1733 * Scripts/modules/cpplint_unittest.py: 1734 17352009-07-20 Jakob Petsovits <jakob.petsovits@torchmobile.com> 1736 1737 Reviewed by David Levin. 1738 1739 Add checks for namespace indentation to cpplint. 1740 https://bugs.webkit.org/show_bug.cgi?id=27461 1741 1742 * Scripts/modules/cpplint.py: 1743 * Scripts/modules/cpplint_unittest.py: 1744 17452009-07-20 Adam Treat <adam.treat@torchmobile.com> 1746 1747 Reviewed by David Levin. 1748 1749 Add cpplint check for proper include order 1750 https://bugs.webkit.org/show_bug.cgi?id=27462 1751 1752 Add a new check to cpplint to flag cases where the include section of a file 1753 does not match the mandated include order and style of the Webkit coding style 1754 guidelines. 1755 1756 Add associated tests. 1757 1758 * Scripts/modules/cpplint.py: 1759 * Scripts/modules/cpplint_unittest.py: 1760 17612009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 1762 1763 Reviewed by David Levin. 1764 1765 Support lint for patches 1766 https://bugs.webkit.org/show_bug.cgi?id=27291 1767 1768 Add run-webkit-lint script, which lints recent changes in local 1769 repository. Also, modified cpplint.py so that we don't need to 1770 specify verbose level for process_file(). 1771 1772 * Scripts/modules/cpplint.py: 1773 * Scripts/run-webkit-lint: Added. 1774 17752009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 1776 1777 Reviewed by David Levin. 1778 1779 diff_parser should accept lines without trailing \n 1780 https://bugs.webkit.org/show_bug.cgi?id=27483 1781 1782 Normalize the input lines by removing a trailing newline. 1783 Also, add a case for unittest for newly added files. 1784 1785 * Scripts/modules/diff_parser.py: 1786 * Scripts/modules/diff_parser_unittest.py: 1787 17882009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 1789 1790 Reviewed by David Levin. 1791 1792 cpplint.py's process_file() should accept customized error function 1793 https://bugs.webkit.org/show_bug.cgi?id=27487 1794 1795 * Scripts/modules/cpplint.py: 1796 17972009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 1798 1799 Reviewed by David Levin. 1800 1801 cpplint.py should have an interface to get global error count 1802 https://bugs.webkit.org/show_bug.cgi?id=27486 1803 1804 * Scripts/modules/cpplint.py: 1805 * Scripts/modules/cpplint_unittest.py: 1806 18072009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 1808 1809 Reviewed by David Levin. 1810 1811 cpplint's parse_argument should not exit even if no files are specified 1812 https://bugs.webkit.org/show_bug.cgi?id=27489 1813 1814 * Scripts/modules/cpplint.py: 1815 * Scripts/modules/cpplint_unittest.py: 1816 18172009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 1818 1819 Reviewed by David Levin. 1820 1821 diff_parser: s/add_deleted_line/add_old_line/g 1822 https://bugs.webkit.org/show_bug.cgi?id=27484 1823 1824 * Scripts/modules/diff_parser.py: 1825 18262009-07-21 Roland Steiner <rolandsteiner@google.com> 1827 1828 Reviewed by David Levin. 1829 1830 Add ENABLE_RUBY to list of build options 1831 https://bugs.webkit.org/show_bug.cgi?id=27324 1832 1833 * Scripts/build-webkit: Added flag ENABLE_RUBY. 1834 18352009-07-20 Mark Rowe <mrowe@apple.com> 1836 1837 Reviewed by David D. Kilzer. 1838 1839 Fix <https://bugs.webkit.org/show_bug.cgi?id=27482>. 1840 Bug 27482: svn-apply cannot apply patch generated by Windows SVN 1841 1842 A regexp in svn-apply was treating everything prior to a \n as part of the 1843 file name. The native Windows SVN client uses \r\n for line endings which 1844 meant that the \r was being included in the file name. This defeated the 1845 special-case logic for ChangeLogs to apply them with an increased fuzz factor, 1846 meaning that the ChangeLog portions of such patches would fail to apply. 1847 1848 Also updated two other regexps that look like they would hit similar problems 1849 with line-endings so that they will correctly handle patches from Windows SVN. 1850 1851 * Scripts/svn-apply: 1852 18532009-07-20 Peter Kasting <pkasting@google.com> 1854 1855 Reviewed by Mark Rowe. 1856 1857 https://bugs.webkit.org/show_bug.cgi?id=27468 1858 Back out r46060, which caused problems for some Apple developers. 1859 1860 * DumpRenderTree/win/DumpRenderTree.vcproj: 1861 * DumpRenderTree/win/ImageDiff.vcproj: 1862 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 1863 18642009-07-20 Peter Kasting <pkasting@google.com> 1865 1866 Reviewed by Darin Adler. 1867 1868 https://bugs.webkit.org/show_bug.cgi?id=27323 1869 Use shorter, more correct code for determining the current directory, 1870 which works better with symbolic links on some systems. Also switch 1871 from checking repository root to checking UUID, to match scm.py. 1872 1873 * Scripts/svn-create-patch: 1874 18752009-07-20 Mark Rowe <mrowe@apple.com> 1876 1877 Rubber-stamped by Dan Bernstein. 1878 1879 Work around <rdar://problem/7075373> by ensuring that the URL is absolute before handing it off to CoreText. 1880 1881 * DumpRenderTree/mac/DumpRenderTree.mm: 1882 (activateFonts): 1883 18842009-07-20 David Levin <levin@chromium.org> 1885 1886 Reviewed by Adam Treat. 1887 1888 Enable filename completion for run-webkit-test (added "-o default"). 1889 1890 * Scripts/webkit-tools-completion.sh: 1891 18922009-07-20 Simon Hausmann <simon.hausmann@nokia.com> 1893 1894 No review, just adding Gavin Barraclough as reviewer. 1895 1896 * Scripts/modules/bugzilla.py: 1897 18982009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org> 1899 1900 Reviewed by David Levin. 1901 1902 Add support for Qt's foreach to cpplint 1903 https://bugs.webkit.org/show_bug.cgi?id=27386 1904 1905 * Scripts/modules/cpplint.py: 1906 * Scripts/modules/cpplint_unittest.py: 1907 19082009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org> 1909 1910 https://bugs.webkit.org/show_bug.cgi?id=27145 1911 [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615 1912 1913 Reviewed by Gustavo Noronha. 1914 1915 Normalize file URLs. 1916 1917 * DumpRenderTree/gtk/DumpRenderTree.cpp: 1918 (dumpHistoryItem): 1919 19202009-07-17 Peter Kasting <pkasting@google.com> 1921 1922 Reviewed by David Kilzer. 1923 1924 https://bugs.webkit.org/show_bug.cgi?id=27323 1925 Further improve non-Cygwin SVN support. 1926 1927 * Scripts/prepare-ChangeLog: Harmless change to be consistent with other 1928 places that consume whitespace at the end of svn output. 1929 * Scripts/resolve-ChangeLogs: Add support for SVN 1.6. Slightly 1930 optimize svn info parsing based on technique in svn-create-patch. 1931 Normalize paths and consume whitespace in the same way as 1932 prepare-ChangeLog, for Windows systems with a non-Cygwin SVN. Force 1933 diff and patch to run in binary mode so that they won't 1934 "intelligently" screw up line endings. 1935 19362009-07-18 Simon Fraser <simon.fraser@apple.com> 1937 1938 Fix Tiger DRT build. 1939 1940 * DumpRenderTree/mac/DumpRenderTree.mm: 1941 (createWebViewAndOffscreenWindow): 1942 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 1943 19442009-07-17 Simon Fraser <simon.fraser@apple.com> 1945 1946 Reviewed by Dan Bernstein. 1947 1948 DRT doesn't reliably snapshot composited layers 1949 https://bugs.webkit.org/show_bug.cgi?id=27399 1950 1951 If we're doing an "onscreen" pixel capture, it means that we're snapshotting a view 1952 with composited content. In that case we need to force the view to display so that 1953 the composited layers are rendered to the screen. 1954 1955 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 1956 (createBitmapContextFromWebView): 1957 19582009-07-17 Adam Barth <abarth@webkit.org> 1959 1960 Reviewed by David Levin. 1961 1962 bugzilla-tool does not understand nested SVN repos 1963 https://bugs.webkit.org/show_bug.cgi?id=27404 1964 1965 Determine the root of the working copy by looking at SVN's UUIDs. 1966 1967 * Scripts/modules/scm.py: 1968 19692009-07-17 David Levin <levin@chromium.org> 1970 1971 Reviewed by Mark Rowe. 1972 1973 webkit-tools-completion.sh has two typos and sorting issues. 1974 https://bugs.webkit.org/show_bug.cgi?id=27401 1975 1976 * Scripts/webkit-tools-completion.sh: Fix two typos "--dif" and "-clean". 1977 Also, sort all lists including items in the case statement and flags for 1978 the commands. 1979 19802009-07-17 Peter Kasting <pkasting@google.com> 1981 1982 Reviewed by David Kilzer. 1983 1984 https://bugs.webkit.org/show_bug.cgi?id=27323 1985 Tweak some regexes for correctness. 1986 1987 * Scripts/prepare-ChangeLog: Allow 1-character filenames (my previous 1988 change here didn't quite get things right). 1989 * Scripts/update-webkit: Detect conflicting ChangeLogs correctly by not 1990 including any trailing whitespace in the name "ChangeLog", and by 1991 normalizing paths before calling basename() to avoid confusing it. 1992 (normalizePath() copied from prepare-ChangeLog.) 1993 19942009-07-17 Peter Kasting <pkasting@google.com> 1995 1996 Reviewed by Steve Falkenburg. 1997 1998 https://bugs.webkit.org/show_bug.cgi?id=27323 1999 Only add Cygwin to the path when it isn't already there. This avoids 2000 causing problems for people who purposefully have non-Cygwin versions of 2001 executables like svn in front of the Cygwin ones in their paths. 2002 2003 * DumpRenderTree/win/DumpRenderTree.vcproj: 2004 * DumpRenderTree/win/ImageDiff.vcproj: 2005 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 2006 20072009-07-17 David Levin <levin@chromium.org> 2008 2009 Reviewed by Adam Treat. 2010 2011 WebKit should have a bash completion script to aid with common commands. 2012 https://bugs.webkit.org/show_bug.cgi?id=27374 2013 2014 * Scripts/webkit-tools-completion.sh: The script which enables option completion 2015 for several WebKit command line scripts. 2016 20172009-07-17 Peter Kasting <pkasting@google.com> 2018 2019 Reviewed by David Kilzer. 2020 2021 https://bugs.webkit.org/show_bug.cgi?id=27323 2022 Avoid error spew on Macs, and fix a few other tiny details. 2023 2024 * Scripts/svn-create-patch: 2025 20262009-07-17 Adam Treat <adam.treat@torchmobile.com> 2027 2028 Reviewed by Dave Levin. 2029 2030 https://bugs.webkit.org/show_bug.cgi?id=27377 2031 This makes cpplint complain about this for instance: 2032 2033 if (true) 2034 { 2035 int foo; 2036 } 2037 2038 Add the appropriate unit tests. 2039 2040 * Scripts/modules/cpplint.py: 2041 * Scripts/modules/cpplint_unittest.py: 2042 20432009-07-17 Adam Treat <adam.treat@torchmobile.com> 2044 2045 Reviewed by Dave Levin. 2046 2047 https://bugs.webkit.org/show_bug.cgi?id=27377 2048 Don't filter whitespace at the end of the line. This is not 2049 explicitly a rule of webkit coding style, but there is no reason 2050 not to warn of this common style problem. 2051 2052 Don't filter whitespace newline. Now, cpplint will complain 2053 about the following situation: 2054 2055 if (true) { 2056 doSomething(); 2057 doSomethingAgain(); 2058 } 2059 else 2060 doSomething(); 2061 2062 Which is a webkit coding style rule violation. 2063 2064 * Scripts/modules/cpplint.py: 2065 20662009-07-17 Adam Treat <adam.treat@torchmobile.com> 2067 2068 Reviewed by Dave Levin. 2069 2070 https://bugs.webkit.org/show_bug.cgi?id=27377 2071 Move this comment to where it belongs. 2072 2073 * Scripts/modules/cpplint_unittest.py: 2074 20752009-07-17 Brent Fulgham <bfulgham@webkit.org> 2076 2077 Reviewed by Adam Roben. 2078 2079 Correct crash in WinLauncher due to improper mixing of BSTR 2080 and TCHAR types. 2081 https://bugs.webkit.org/show_bug.cgi?id=27381 2082 2083 * WinLauncher/WinLauncher.cpp: 2084 (loadURL): Perform SysReAllocString to update the BSTR with 2085 the contents of the TCHAR string. 2086 20872009-07-17 David Levin <levin@chromium.org> 2088 2089 Reviewed by Adam Treat. 2090 2091 cpplint should flag usages of NULL. 2092 https://bugs.webkit.org/show_bug.cgi?id=27341 2093 2094 * Scripts/modules/cpplint.py: Add the check for NULL test and call it. 2095 Make the collapse_strings method public. 2096 * Scripts/modules/cpplint_unittest.py: Add several tests to verify 2097 the check for NULL behavior. Adjust existing tests due to the 2098 new NULL check: 2099 1. Several had NULL removed (or were just removed completely). 2100 2. Two tests now do an assert that allows the caller to check 2101 that a particular error is one of several that was returned. 2102 21032009-07-17 Shinichiro Hamaji <hamaji@chromium.org> 2104 2105 Reviewed by David Levin. 2106 2107 Add a parser of patches for linter. 2108 https://bugs.webkit.org/show_bug.cgi?id=27363 2109 2110 Adds a simple parser for unified diff format. 2111 2112 * Scripts/modules/diff_parser.py: Added. 2113 * Scripts/modules/diff_parser_unittest.py: Added. 2114 21152009-06-30 Holger Hans Peter Freyther <zecke@selfish.org> 2116 2117 Reviewed by Simon Hausmann. 2118 2119 [GTK+] Remove check to be loadable in firefox 2120 https://bugs.webkit.org/show_bug.cgi?id=27345 2121 2122 if (aMozillaVTable->size < sizeof (NPNetscapeFuncs)) 2123 fails in firefox but no other example in the mozilla tree is 2124 doing that check. Remove and be happy. 2125 2126 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 2127 (NP_Initialize): 2128 21292009-07-17 Adam Treat <adam.treat@torchmobile.com> 2130 2131 Reviewed by Simon Hausmann. 2132 2133 Something about having a single TAB in a style checking tool like this 2134 is equivalent to nails on a chalk board to me... 2135 2136 * Scripts/modules/cpplint.py: 2137 21382009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org> 2139 2140 Reviewed by Simon Hausmann. 2141 2142 Overwrite the plugin directories for the DRT. 2143 Part of https://bugs.webkit.org/show_bug.cgi?id=27215 2144 2145 * DumpRenderTree/qt/DumpRenderTree.cpp: 2146 (WebCore::DumpRenderTree::DumpRenderTree): 2147 21482009-07-16 Fumitoshi Ukai <ukai@chromium.org> 2149 2150 Reviewed by David Levin. 2151 2152 Add --web-sockets flag and ENABLE_WEB_SOCKETS define. 2153 https://bugs.webkit.org/show_bug.cgi?id=27206 2154 2155 Add --web-sockets flag. 2156 2157 * Scripts/build-webkit: add --web-sockets flag. 2158 21592009-07-16 Adam Treat <adam.treat@torchmobile.com> 2160 2161 Reviewed by Dave Levin. 2162 2163 cpplint should check for one line control clauses that are surrounded 2164 by braces 2165 https://bugs.webkit.org/show_bug.cgi?id=27354 2166 2167 * Scripts/modules/cpplint.py: Added the new lint check. 2168 * Scripts/modules/cpplint_unittest.py: Add tests for the new lint check 2169 and fix the other tests as they were not passing this new lint check. 2170 21712009-07-16 Peter Kasting <pkasting@google.com> 2172 2173 Reviewed by David Kilzer. 2174 2175 https://bugs.webkit.org/show_bug.cgi?id=27323 2176 Improve support for WebKit checkouts hosted inside other checkouts 2177 (possible for some ports, e.g. Chromium). 2178 2179 * Scripts/svn-create-patch: Determine SVN root by looking for Repository 2180 Root string and aborting when it's missing or different than what 2181 we've already seen. 2182 21832009-07-16 Peter Kasting <pkasting@google.com> 2184 2185 Reviewed by Adam Roben. 2186 2187 https://bugs.webkit.org/show_bug.cgi?id=27323 2188 Improve support for non-Cygwin SVNs on Windows. 2189 2190 * Scripts/commit-log-editor: Modify regex so that trailing whitespace 2191 (e.g. \r) isn't included in filenames. 2192 * Scripts/prepare-ChangeLog: Fix a case of adding "\n" to the ChangeLog 2193 without normalizing. Normalize file paths early instead of late so 2194 all stages of the script work. Modify regexes so that trailing 2195 whitespace (e.g. \r) isn't included in filenames. 2196 * Scripts/svn-create-patch: Use a regex instead of chomp so we cut off 2197 line endings even if they don't match Perl's. 2198 21992009-07-16 Joseph Pecoraro <joepeck02@gmail.com> 2200 2201 Reviewed by Darin Adler. 2202 2203 WebKitTools/Scripts/svn-create-patch is broken 2204 https://bugs.webkit.org/show_bug.cgi?id=27328 2205 2206 * Scripts/svn-create-patch: one line fix for unusual perl behavior 2207 22082009-07-16 David Levin <levin@chromium.org> 2209 2210 Reviewed by David Kilzer. 2211 2212 cpplint should check for equality comparisons to 0/true/false 2213 https://bugs.webkit.org/show_bug.cgi?id=27333 2214 2215 * Scripts/modules/cpplint.py: Added the new lint check. 2216 * Scripts/modules/cpplint_unittest.py: Add tests for the new lint check 2217 and fix a regex that in another unit test that caused it to fail when 2218 you have a directory with a number in it (like WebKit-2) 2219 22202009-07-16 David D. Kilzer <ddkilzer@webkit.org> 2221 2222 <http://webkit.org/b/27241> bugzilla-tool post-commits silently fails with bad args 2223 2224 Reviewed by Eric Seidel. 2225 2226 * Scripts/bugzilla-tool: 2227 (PostCommitsAsPatchesToBug.execute): Added more error checking 2228 when consuming arguments. 2229 22302009-07-16 David D. Kilzer <ddkilzer@webkit.org> 2231 2232 TOOL FIX: scm.py: CommitMessage.message is ambiguous 2233 2234 Fixes this error when running bugzilla-tool apply-patches 2235 --local-commit: 2236 2237 File "bugzilla-tool", line 188, in apply_patches 2238 scm.commit_locally_with_message(commit_message.message() or patch['name']) 2239 TypeError: 'list' object is not callable 2240 2241 * Scripts/modules/scm.py: After r45940 (and r45971), rename 2242 CommitMessage.message attribute to CommitMessage.message_lines. 2243 (CommitMessage.__init__): 2244 (CommitMessage.body): 2245 (CommitMessage.description): 2246 (CommitMessage.message): 2247 (CommitMessage.parse_bug_id): 2248 22492009-07-16 David D. Kilzer <ddkilzer@webkit.org> 2250 2251 TOOL FIX: bugzilla-tool: import CommitMessage class 2252 2253 * Scripts/bugzilla-tool: After r45940, the CommitMessage class 2254 needs to be imported for commit_message_for_this_commit(). 2255 22562009-07-16 David Levin <levin@chromium.org> 2257 2258 Reviewed by Maciej Stachowiak. 2259 2260 prepare-ChangeLog should display the --bug option in its help text. 2261 https://bugs.webkit.org/show_bug.cgi?id=27334 2262 2263 * Scripts/prepare-ChangeLog: Added the help text. 2264 22652009-07-15 Darin Adler <darin@apple.com> 2266 2267 * Scripts/do-webcore-rename: Check in the version used to 2268 rename parseURL to deprecatedParseURL. 2269 22702009-07-10 David Kilzer <ddkilzer@apple.com> 2271 2272 bugzilla-tool: create CommitMessage class 2273 2274 Reviewed by Eric Seidel. 2275 2276 Create a CommitMessage class to encapsulate related code. 2277 2278 * Scripts/bugzilla-tool: 2279 (bug_id_from_commit_message): Moved to 2280 CommitMessage.parse_bug_id(). 2281 (commit_message_for_this_commit): Return a CommitMessage. 2282 (ApplyPatchesFromBug.apply_patches): Use CommitMessage.message(). 2283 (LandPatchesFromBugs.build_and_commit): Ditto. 2284 (CommitMessageForCurrentDiff.execute): Ditto. 2285 (PostCommitsAsPatchesToBug.execute): Switched from 2286 Git.commit_message_for_commit() to 2287 Git.commit_message_for_local_commit(). Switched from 2288 bug_id_from_commit_message() to CommitMessage.parse_bug_id(). 2289 2290 * Scripts/modules/scm.py: 2291 (first_non_empty_line_after_index): Added. 2292 (CommitMessage.__init__): Added. 2293 (CommitMessage.body): Added. 2294 (CommitMessage.description): Added. 2295 (CommitMessage.message): Added. 2296 (CommitMessage.parse_bug_id): Added. Moved from 2297 bug_id_from_commit_message() in bugzilla-tool. 2298 (Git.commit_message_for_local_commit): Renamed from 2299 commit_message_for_commit(). Return a CommitMessage. 2300 23012009-07-15 Joseph Pecoraro <joepeck02@gmail.com> 2302 2303 Reviewed by David Kilzer. 2304 2305 bugzilla-tool/svn-apply can't handle patches made from a non-root directory 2306 https://bugs.webkit.org/show_bug.cgi?id=26999 2307 2308 * Scripts/svn-create-patch: 2309 23102009-07-15 Shinichiro Hamaji <hamaji@chromium.org> 2311 2312 Reviewed by David Levin. 2313 2314 Move cpplint.py to module directory 2315 https://bugs.webkit.org/show_bug.cgi?id=27302 2316 2317 * Scripts/modules/cpplint.py: Renamed from WebKitTools/Scripts/cpplint.py. 2318 * Scripts/modules/cpplint_unittest.py: Renamed from WebKitTools/Scripts/cpplint_unittest.py. 2319 23202009-07-15 Simon Hausmann <simon.hausmann@nokia.com> 2321 2322 Reviewed by Adam Treat. 2323 2324 https://bugs.webkit.org/show_bug.cgi?id=27295 2325 2326 Re-implement QWebPage::shouldInterruptJavaScript to disable 2327 js interruption and avoid showing a messagebox during Qt DRT 2328 runs when script execution takes a bit longer. 2329 2330 * DumpRenderTree/qt/DumpRenderTree.cpp: 2331 (WebCore::WebPage::shouldInterruptJavaScript): Return false 2332 in re-implemented slot. 2333 23342009-07-15 Zoltan Horvath <hzoltan@inf.u-szeged.hu> 2335 2336 Reviewed by Jan Alonzo. 2337 2338 Fix the DumpRenderTree GTK+ build 2339 https://bugs.webkit.org/show_bug.cgi?id=27290 2340 2341 Set USE_SYSTEM_MALLOC macro for the DumpRenderTree build to 2342 disable using TCmalloc in DumpRenderTree. 2343 2344 * GNUmakefile.am: 2345 23462009-07-14 Steve Falkenburg <sfalken@apple.com> 2347 2348 Reorganize JavaScriptCore headers into: 2349 API: include/JavaScriptCore/ 2350 Private: include/private/JavaScriptCore/ 2351 2352 Reviewed by Darin Adler. 2353 2354 * DumpRenderTree/win/DumpRenderTree.vcproj: 2355 * DumpRenderTree/win/ImageDiff.vcproj: 2356 23572009-07-14 Shinichiro Hamaji <hamaji@chromium.org> 2358 2359 Reviewed by David Levin. 2360 2361 WebKit needs a style linting tool 2362 https://bugs.webkit.org/show_bug.cgi?id=25884 2363 2364 Modifies cpplint (http://google-styleguide.googlecode.com/svn/trunk/cpplint/) 2365 based on WebKit's style guide. 2366 2367 * Scripts/cpplint.py: Added. 2368 * Scripts/cpplint_unittest.py: Added. 2369 23702009-07-14 Laszlo Gombos <laszlo.1.gombos@nokia.com> 2371 2372 Reviewed by Simon Hausmann. 2373 2374 [Qt] DumpRenderTree no longer builds with Qt4.4 2375 https://bugs.webkit.org/show_bug.cgi?id=27257 2376 2377 Flag Qt 4.5 dependency to allow building with Qt 4.4. 2378 2379 * DumpRenderTree/qt/main.cpp: 2380 (main): 2381 23822009-07-13 Brent Fulgham <bfulgham@webkit.org> 2383 2384 Reviewed by Adam Roben. 2385 2386 Add new configuration flag for redistributable Windows build. 2387 https://bugs.webkit.org/show_bug.cgi=27087 2388 2389 * DumpRenderTree/config.h: Check for presence of WIN_CAIRO and 2390 select appropriate configuration. Defaults to standard Apple build. 2391 * DumpRenderTree/win/DumpRenderTree.vcproj: Add new WinCairo.vsprops 2392 to Debug_Cairo and Release_Cairo targets. 2393 23942009-07-13 Simon Hausmann <simon.hausmann@nokia.com> 2395 2396 Reviewed by Ariya Hidayat. 2397 2398 Always run the Qt DRT with the raster graphicssystem on X11, for 2399 increased stability in the image based tests, in particular canvas. 2400 2401 * DumpRenderTree/qt/main.cpp: 2402 (main): 2403 24042009-07-13 Simon Hausmann <simon.hausmann@nokia.com> 2405 2406 Reviewed by Ariya Hidayat. 2407 2408 Fix test netscape plugin usage with the Qt DRT. 2409 2410 * DumpRenderTree/qt/DumpRenderTree.cpp: 2411 (WebCore::WebPage::WebPage): Enable plugins in the settings. 2412 * Scripts/run-webkit-tests: Set the QT_WEBKIT_PLUGIN path to the correct build 2413 directory to make Qt DRT find the test netscape plugin. 2414 24152009-07-13 Simon Hausmann <hausmann@webkit.org> 2416 2417 Reviewed by Ariya Hidayat. 2418 2419 Make sure to disable the fixed contents size when resetting the page/view 2420 state between test runs, to avoid side-effects. 2421 2422 * DumpRenderTree/qt/DumpRenderTree.cpp: 2423 (WebCore::DumpRenderTree::open): Call setFixedContentsSize() with an invalid 2424 QSize to disable the fixed layout. 2425 24262009-07-13 Simon Hausmann <hausmann@webkit.org> 2427 2428 Reviewed by Ariya Hidayat. 2429 2430 When creating new windows, don't forget to connect the new 2431 page's main frame. This ensures that for example the layoutTestController 2432 is also available there. 2433 2434 * DumpRenderTree/qt/DumpRenderTree.cpp: 2435 (WebCore::DumpRenderTree::createWindow): 2436 24372009-07-13 Simon Hausmann <hausmann@webkit.org> 2438 2439 Reviewed by Ariya Hidayat. 2440 2441 Added support for LayoutTestController.setPrivateBrowsingEnabled. 2442 2443 * DumpRenderTree/qt/jsobjects.cpp: 2444 (LayoutTestController::reset): 2445 (LayoutTestController::setPrivateBrowsingEnabled): 2446 * DumpRenderTree/qt/jsobjects.h: 2447 24482009-07-13 Simon Hausmann <hausmann@webkit.org> 2449 2450 Reviewed by Ariya Hidayat. 2451 2452 Added support for database callbacks, storage quota setting, 2453 and clearing of all databases. 2454 2455 * DumpRenderTree/qt/DumpRenderTree.cpp: 2456 (WebCore::DumpRenderTree::DumpRenderTree): 2457 (WebCore::DumpRenderTree::dumpDatabaseQuota): 2458 * DumpRenderTree/qt/DumpRenderTree.h: 2459 * DumpRenderTree/qt/jsobjects.cpp: 2460 (LayoutTestController::reset): 2461 (LayoutTestController::setDatabaseQuota): 2462 (LayoutTestController::clearAllDatabases): 2463 * DumpRenderTree/qt/jsobjects.h: 2464 (LayoutTestController::shouldDumpDatabaseCallbacks): 2465 (LayoutTestController::dumpDatabaseCallbacks): 2466 * DumpRenderTree/qt/main.cpp: 2467 (main): 2468 24692009-07-13 Simon Hausmann <hausmann@webkit.org> 2470 2471 Reviewed by Ariya Hidayat. 2472 2473 Setup the path in the Qt DRT for HTML 5 Databases, to enable some of 2474 the storage layout tests. 2475 2476 * DumpRenderTree/qt/main.cpp: 2477 (main): 2478 24792009-07-13 Simon Hausmann <hausmann@webkit.org> 2480 2481 Reviewed by Ariya Hidayat. 2482 2483 Make the test output more robust by dumping only when the main 2484 frame finishes loading, instead of when _any_ frame finishes. 2485 2486 * DumpRenderTree/qt/DumpRenderTree.cpp: 2487 (WebCore::DumpRenderTree::DumpRenderTree): Connect to the 2488 main frame's loadFinished() signal instead of the page's one. 2489 24902009-07-13 Simon Hausmann <hausmann@webkit.org> 2491 2492 Reviewed by Ariya Hidayat. 2493 2494 Implement the GCController DRT interface. 2495 2496 * DumpRenderTree/qt/DumpRenderTree.cpp: 2497 (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController. 2498 (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine. 2499 * DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController. 2500 * DumpRenderTree/qt/jsobjects.cpp: Implement GCController. 2501 (GCController::GCController): 2502 (GCController::collect): 2503 (GCController::collectOnAlternateThread): 2504 (GCController::getJSObjectCount): 2505 * DumpRenderTree/qt/jsobjects.h: Declare GCController. 2506 25072009-07-13 Simon Hausmann <hausmann@webkit.org> 2508 2509 Reviewed by Ariya Hidayat. 2510 2511 Implement the GCController DRT interface in the Qt DRT. 2512 2513 * DumpRenderTree/qt/DumpRenderTree.cpp: 2514 (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController. 2515 (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine. 2516 * DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController. 2517 * DumpRenderTree/qt/jsobjects.cpp: Implement GCController. 2518 (GCController::GCController): 2519 (GCController::collect): 2520 (GCController::collectOnAlternateThread): 2521 (GCController::getJSObjectCount): 2522 * DumpRenderTree/qt/jsobjects.h: Declare GCController. 2523 25242009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org> 2525 2526 https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT 2527 2528 Reviewed by Gustavo Noronha and Xan Lopez. 2529 2530 Support running of tests that open and close JS windows automatically. 2531 2532 * DumpRenderTree/gtk/DumpRenderTree.cpp: 2533 (dumpFramesAsText): 2534 (dumpBackForwardListForAllWebViews): 2535 (resetWebViewToConsistentStateBeforeTesting): 2536 (dump): 2537 (runTest): 2538 (webViewClose): 2539 (createWebView): 2540 (webViewCreate): 2541 (main): 2542 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: 2543 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 2544 (LayoutTestController::windowCount): 2545 (LayoutTestController::setPopupBlockingEnabled): 2546 25472009-07-13 Shinichiro Hamaji <hamaji@chromium.org> 2548 2549 Reviewed by Maciej Stachowiak. 2550 2551 prepare-ChangeLog should decode HTML entities in short description 2552 https://bugs.webkit.org/show_bug.cgi?id=27122 2553 2554 Decode the short description by adding a function which decodes HTML 2555 entities. It can decode &, <, >, ", and ' . They may be sufficient 2556 as the description seems to be encoded by xml_quote in 2557 http://mxr.mozilla.org/bugzilla/source/Bugzilla/Util.pm 2558 2559 * Scripts/prepare-ChangeLog: 2560 25612009-07-13 Drew Wilson <atwilson@google.com> 2562 2563 Reviewed by David Levin. 2564 2565 Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs 2566 https://bugs.webkit.org/show_bug.cgi?id=26932 2567 2568 Added support for --shared-workers (turned off by default) 2569 2570 * Scripts/build-webkit: 2571 25722009-07-12 Dan Bernstein <mitz@apple.com> 2573 2574 Reviewed by Maciej Stachowiak. 2575 2576 https://bugs.webkit.org/show_bug.cgi?id=27196 2577 Update check-for-global-initializers for the renaming for bidi.cpp to 2578 RenderBlockLineLayout.cpp 2579 2580 * Scripts/check-for-global-initializers: 2581 25822009-07-11 Simon Fraser <simon.fraser@apple.com> 2583 2584 Enable support for accelerated compositing and 3d transforms on Leopard. 2585 <https://bugs.webkit.org/show_bug.cgi?id=20166> 2586 <rdar://problem/6120614> 2587 2588 Reviewed by Oliver Hunt. 2589 2590 * Configurations/FeatureDefines.xcconfig: 2591 * wtf/Platform.h: 2592 25932009-07-10 David Kilzer <ddkilzer@apple.com> 2594 2595 <http://webkit.org/b/27173> svn-apply: Fix typo in git command used to find deleted files 2596 2597 Reviewed by Eric Seidel. 2598 2599 * Scripts/svn-apply: 2600 (scmWillDeleteFile): Changed 'head' to 'HEAD'. 2601 26022009-07-10 David Kilzer <ddkilzer@apple.com> 2603 2604 <http://webkit.org/b/27167> bugzilla-tool: hide help for unsupported commands 2605 2606 Reviewed by Eric Seidel. 2607 2608 When bugzilla-tool -h|--help is invoked in an svn working 2609 directory, don't print help for commands that are only supported 2610 on git working directories. 2611 2612 * Scripts/bugzilla-tool: 2613 (Command.__init__): Added requires_local_commits argument with a 2614 default of False. Set self.requires_local_commits attribute. 2615 (PostCommitsAsPatchesToBug.execute): Removed 2616 SCM.supports_local_commits() check since this is now handled by 2617 BugzillaTool.main(). 2618 (PostCommitsAsPatchesToBug.__init__): Added 2619 requires_local_commits=True argument to Command.__init__(). 2620 (BugzillaTool.commands_usage): Don't print help for commands if 2621 they require local commits and the current SCM doesn't support 2622 them. 2623 (BugzillaTool.main): If command_object requires local commits 2624 and the current SCM doesn't, exit with an error message. 2625 26262009-07-10 David Kilzer <ddkilzer@apple.com> 2627 2628 <http://webkit.org/b/27117> bugzilla-tool: use Mac OS X keychain for authentication 2629 2630 Reviewed by Eric Seidel. 2631 2632 Try reading credentials from git config first, then keychain if 2633 running on Mac OS X, else prompt at the command-line. 2634 2635 * Scripts/modules/bugzilla.py: Added "import platform". 2636 (credentials_from_git): Added. 2637 (credentials_from_keychain): Added. 2638 (is_mac_os_x): Added. 2639 (read_credentials): Added. 2640 (Bugzilla.__init__): Moved instance attribute bug_server to a 2641 static attribute named bug-server_url. 2642 (Bugzilla.bug_server_host): Added. Extracted host name from 2643 bug_server_url. 2644 (Bugzilla.bug_server_regex): Updated to be created using 2645 bug_server_host. 2646 (Bugzilla.bug_server_url): Renamed from bug_server. 2647 (Bugzilla.bug_url_for_bug_id): Updated for renaming of 2648 bug_server to bug_server_url. 2649 (Bugzilla.attachment_url_for_id): Ditto. 2650 (Bugzilla.fetch_bug_ids_from_commit_queue): Ditto. 2651 (Bugzilla.authenticate): Ditto. Updated to use 2652 read_credentials(). 2653 (Bugzilla.add_patch_to_bug): Ditto. 2654 26552009-07-10 David Kilzer <ddkilzer@apple.com> 2656 2657 <http://webkit.org/b/27115> bugzilla-tool: extract duplicate logging methods into a module 2658 2659 Reviewed by Adam Roben. 2660 2661 * Scripts/bugzilla-tool: Removed error() and log() methods and 2662 added import of new logging module. 2663 * Scripts/modules/bugzilla.py: Ditto. Removed "import sys". 2664 * Scripts/modules/scm.py: Ditto. 2665 2666 * Scripts/modules/logging.py: Added. 2667 (log): Added. 2668 (error): Added. Prefix error messages with "ERROR: ". 2669 26702009-07-10 Adam Roben <aroben@apple.com> 2671 2672 Sort all our Xcode projects 2673 2674 Accomplished using sort-Xcode-project-file. 2675 2676 Requested by Dave Kilzer. 2677 2678 * DrawTest/DrawTest.xcodeproj/project.pbxproj: 2679 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 2680 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: 2681 26822009-07-10 Adam Roben <aroben@apple.com> 2683 2684 Print prepare-ChangeLog's reminders to STDERR so they don't end up in 2685 the diff output 2686 2687 Fixes REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines 2688 into the diff 2689 <https://bugs.webkit.org/show_bug.cgi?id=27150> 2690 2691 Reviewed by Maciej Stachowiak. 2692 2693 * Scripts/prepare-ChangeLog: 2694 26952009-07-08 Adam Roben <aroben@apple.com> 2696 2697 Use case-insensitive comparisons when sorting Xcode project files 2698 2699 This matches the sorting used in Xcode's files list. 2700 2701 Fixes Bug 27079: sort-Xcode-project-file should sort 2702 case-insensitively, to match Xcode's files list 2703 <https://bugs.webkit.org/show_bug.cgi?id=27079> 2704 2705 Reviewed by Dave Kilzer. 2706 2707 * Scripts/sort-Xcode-project-file: 2708 (sortChildrenByFileName): 2709 (sortFilesByFileName): 2710 Lowercase the strings before comparing them so that the comparison 2711 will be case-insensitive. 2712 27132009-07-08 Simon Hausmann <hausmann@webkit.org> 2714 2715 Reviewed by Holger Freyther. 2716 2717 https://bugs.webkit.org/show_bug.cgi?id=27109 2718 2719 Fix side-effects in the Qt DRT with tests using application fonts. 2720 2721 Detect if a test used application fonts and re-initialize the fontconfig 2722 application fontset accordingly. 2723 2724 * DumpRenderTree/qt/DumpRenderTree.cpp: 2725 (WebCore::DumpRenderTree::open): call initializeFonts and remove all application fonts 2726 after running a testcase. 2727 (WebCore::DumpRenderTree::initializeFonts): Moved fontconfig initialization code 2728 here from main. 2729 * DumpRenderTree/qt/DumpRenderTree.h: Declare initializeFonts. 2730 * DumpRenderTree/qt/main.cpp: 2731 (main): Moved fontconfig initialization code to DRT::initializeFonts. 2732 27332009-07-10 Antonio Gomes <antonio.gomes@openbossa.org> 2734 2735 Reviewed by Simon Hausmann. 2736 2737 [QT] [ARM] Add pkg-config entry for FontConfig on DRT.pro 2738 https://bugs.webkit.org/show_bug.cgi?id=26990 2739 2740 Missing pkg-config entry for FontConfig in DRT.pro causes some compilers to 2741 not link fine against FontConfig bits. 2742 2743 * DumpRenderTree/qt/DumpRenderTree.pro: 2744 27452009-07-09 Drew Wilson <atwilson@google.com> 2746 2747 Reviewed by Alexey Proskuryakov. 2748 2749 https://bugs.webkit.org/show_bug.cgi?id=26903 2750 2751 Turned on CHANNEL_MESSAGING by default because the MessageChannel API 2752 can now be implemented for Web Workers and is reasonably stable. 2753 2754 * Scripts/build-webkit: 2755 27562009-07-09 David Kilzer <ddkilzer@apple.com> 2757 2758 <http://webkit.org/b/27114> bugzilla-tool: Parse short bug URL from commit log messages 2759 2760 Reviewed by Adam Roben. 2761 2762 * Scripts/bugzilla-tool: 2763 (bug_id_from_commit_message): Check for the short bug URL before 2764 checking for the longer bugs.webkit.org URL. 2765 27662009-07-08 David Kilzer <ddkilzer@apple.com> 2767 2768 Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and actually work 2769 2770 <https://bugs.webkit.org/show_bug.cgi?id=27062> 2771 2772 Reviewed by Eric Seidel. 2773 2774 Removed the required BUGID argument from the "post-commits" 2775 command and replaced it with a -b|--bug-id switch or parsing the 2776 commit log message for the bug URL. Fixed a bug in the 2777 "post-commits" that would ignore the COMMITISH used and post a 2778 patch of local changes against HEAD. Added --no-commit switch 2779 to disable using the bulk of the ChangeLog entry as the comment 2780 for the new patch. 2781 2782 * Scripts/bugzilla-tool: 2783 (bug_id_from_commit_message): Added. Returns a bug id from the 2784 commit log message, thus enforcing the need for a bug URL in the 2785 message. 2786 (PostCommitsAsPatchesToBug.__init__): Updated help description 2787 to match new behavior of pulling bug ids from commit log 2788 messages instead of from the command line. Added -b|--bug-id 2789 switch and --no-comment switch. 2790 (PostCommitsAsPatchesToBug.execute): Updated to use 2791 bug_id_from_commit_message() to pull bug ids from commit log 2792 messages. Also switched from SCM.create_patch() to use 2793 SCM.create_patch_from_local_commit() to fix a bug where local 2794 repository changes were posted as a patch instead of the 2795 specific COMMITISH. Fall back to -b|--bug-id if no URL is found 2796 in the commit log message. Don't specify a comment for the 2797 patch if --no-comment is used. Set cherry_pick argument to True 2798 for Git.commit_ids_from_range_arguments() since we don't want 2799 implicit commit range behavior for this command. 2800 2801 * Scripts/modules/bugzilla.py: Import datetime module. 2802 (timestamp): Added. Returns a timestamp in the form of 2803 "YYYYMMDDhhmmss". 2804 (Bugzilla.bug_server_regex): Added static attribute. 2805 (Bugzilla.add_patch_to_bug): Construct a more meaningful patch 2806 file name using the bug_id and timestamp(). 2807 2808 * Scripts/modules/scm.py: 2809 (SCM.create_patch_from_local_commit): Added. 2810 (Git.create_patch_from_local_commit): Added. Runs "git diff" to 2811 return a patch for the given commit_id. 2812 28132009-07-08 Maciej Stachowiak <mjs@apple.com> 2814 2815 Reviewed by Mark Rowe. 2816 2817 Make prepare-ChangeLog less shouty 2818 https://bugs.webkit.org/show_bug.cgi?id=27098 2819 2820 * Scripts/prepare-ChangeLog: 2821 28222009-07-08 David Kilzer <ddkilzer@apple.com> 2823 2824 Bug 27083: bugzilla.py: Clean up bug_server use 2825 2826 <https://bugs.webkit.org/show_bug.cgi?id=27083> 2827 2828 Reviewed by Darin Adler. 2829 2830 * Scripts/modules/bugzilla.py: 2831 (Bugzilla.fetch_bug_ids_from_commit_queue): Use bug_server 2832 instead of hard-coding the URL. 2833 (Bugzilla.authenticate): Remove extra '/' before URL path. 2834 (Bugzilla.add_patch_to_bug): Ditto. 2835 28362009-07-08 Brent Fulgham <bfulgham@webkit.org> 2837 2838 Build fix for Windows Cairo. 2839 2840 Cairo build was incorrectly #including the PixelDumpSupportCG.h 2841 instead of PixelDumpSupportCairo.h 2842 2843 * DumpRenderTree/win/PixelDumpSupportWin.cpp: Correct #include 2844 28452009-07-08 David Faure <faure@kde.org> 2846 2847 Reviewed by Ariya Hidayat. 2848 2849 Small documentation improvement for build-webkit --help 2850 2851 * Scripts/build-webkit: mention --debug option 2852 28532009-07-07 Brady Eidson <beidson@apple.com> 2854 2855 Tiger build fix, work around missing NSString API. 2856 2857 * DumpRenderTree/mac/DumpRenderTree.mm: 2858 (dumpHistoryItem): 2859 28602009-07-07 Brady Eidson <beidson@apple.com> 2861 2862 Reviewed by Mark Rowe. 2863 2864 https://bugs.webkit.org/show_bug.cgi?id=27049 - In dumpBackForwardList() mode, DRT should normalize file urls. 2865 2866 Make the dump of a history item agnostic to the layout of filesystem on the testing machine. 2867 2868 * DumpRenderTree/mac/DumpRenderTree.mm: 2869 (dumpHistoryItem): 2870 * DumpRenderTree/win/DumpRenderTree.cpp: 2871 (dumpHistoryItem): 2872 28732009-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 2874 2875 Rubber-stamped by Simon Hausmann. 2876 2877 Correct git url of the Qt test-fonts. 2878 2879 * DumpRenderTree/qt/main.cpp: 2880 (main): 2881 28822009-07-07 Simon Hausmann <hausmann@webkit.org> 2883 2884 Reviewed by Holger Freyther. 2885 2886 Clear the main frame's name between loading pages, like in r36652. This 2887 reduces the side-effects between test cases. 2888 2889 * DumpRenderTree/qt/DumpRenderTree.cpp: 2890 (WebCore::DumpRenderTree::open): 2891 28922009-07-06 Simon Hausmann <hausmann@webkit.org> 2893 2894 Reviewed by Holger Freyther. 2895 2896 Fix various layout tests with Qt's DRT. 2897 2898 Remember to set the focus on the web page before 2899 loading. 2900 2901 * DumpRenderTree/qt/DumpRenderTree.cpp: 2902 (WebCore::DumpRenderTree::open): 2903 29042009-07-07 Simon Hausmann <hausmann@webkit.org> 2905 2906 Reviewed by Tor Arne Vestbø and Holger Freyther. 2907 2908 Fix timeout timer handling in Qt DRT. 2909 2910 Use QBasicTimer instead of startTimer/killTimer, to fix the 2911 problem that starting the timeout timer did not stop a 2912 previously started timer, causing multiple emissions of timeout. 2913 The timerEvent() implementation now also checks the timer id, to 2914 protect against double timeouts. 2915 2916 * DumpRenderTree/qt/jsobjects.cpp: 2917 (LayoutTestController::LayoutTestController): 2918 (LayoutTestController::reset): 2919 (LayoutTestController::waitUntilDone): 2920 (LayoutTestController::notifyDone): 2921 (LayoutTestController::timerEvent): 2922 * DumpRenderTree/qt/jsobjects.h: 2923 29242009-07-06 Eric Seidel <eric@webkit.org> 2925 2926 Reviewed by Maciej Stachowiak. 2927 2928 bugzilla-tool fails to close bugs with bugzilla 3.0 2929 https://bugs.webkit.org/show_bug.cgi?id=27008 2930 2931 Update bugzilla.py to match changes in the bug page "changeform" 2932 Update scm.py to add bug_ids to attachments to make error reporting nicer. 2933 2934 * Scripts/modules/bugzilla.py: 2935 * Scripts/modules/scm.py: 2936 29372009-07-03 Maciej Stachowiak <mjs@apple.com> 2938 2939 Reviewed by Eric Seidel. 2940 2941 bugzilla-tool forgot how to obsolete patches 2942 https://bugs.webkit.org/show_bug.cgi?id=26951 2943 2944 * Scripts/modules/bugzilla.py: 2945 29462009-07-02 Brent Fulgham <bfulgham@webkit.org> 2947 2948 Unreviewed build fix (Cairo this time) for DumpRenderTree. 2949 Put Cairo code back in, but use original include order 2950 for the CG stuff to avoid compile issues. 2951 2952 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 2953 (createBitmapContextFromWebView): 2954 29552009-07-02 Eric Seidel <eric@webkit.org> 2956 2957 Correct blatant typo (missing []), no review. 2958 2959 * Scripts/modules/scm.py: 2960 29612009-07-02 Brent Fulgham <bfulgham@webkit.org> 2962 2963 Windows build fix, no review. 2964 2965 2966 Reverting PixelDumpSupportWin.cpp change to avoid strange 2967 error on the build-bot. 2968 2969 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 2970 (createBitmapContextFromWebView): 2971 29722009-07-02 Brent Fulgham <bfulgham@webkit.org> 2973 2974 Build fix, no review. 2975 2976 * DumpRenderTree/config.h: 2977 29782009-07-02 Eric Seidel <eric@webkit.org> 2979 2980 Reviewed by David Levin. 2981 2982 bugzilla-tool needs to handle login failure 2983 https://bugs.webkit.org/show_bug.cgi?id=26913 2984 2985 We now exit(1) on login failure. 2986 2987 * Scripts/modules/bugzilla.py: 2988 29892009-06-30 Brent Fulgham <bfulgham@webkit.org> 2990 2991 Reviewed by Adam Roben. 2992 2993 Add build support for a Windows Cairo version of 2994 DumpRenderTree. Share as much logic between the 2995 CG and Cairo builds as possible. 2996 https://bugs.webkit.org/show_bug.cgi?id=26457 2997 2998 * DumpRenderTree/PixelDumpSupport.cpp: Added. 2999 (dumpWebViewAsPixelsAndCompareWithExpected): Moved common logic 3000 from CG-specific file. 3001 (printPNG): Moved common logic from CG-specific file. 3002 * DumpRenderTree/PixelDumpSupport.h: Add declaration for new 3003 common printPNG function. 3004 * DumpRenderTree/cairo: Added. 3005 * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Added. 3006 Implement cairo-specific logic for dealing with Cairo surfaces. 3007 (writeFunction): 3008 (printPNG): Cairo-specific PNG handling logic. 3009 (computeMD5HashStringForBitmapContext): New Cairo routine using 3010 the generic BitmapContext signature. 3011 (dumpBitmap): New function containing Cairo-specific portions of 3012 the dumping routine. 3013 * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Added. 3014 Provide Cairo version of the BitmapContext structure so that 3015 dumping routines can work on an abstract type. 3016 (BitmapContext::createByAdoptingBitmapAndContext): 3017 (BitmapContext::~BitmapContext): 3018 (BitmapContext::cairoContext): 3019 (BitmapContext::BitmapContext): 3020 * DumpRenderTree/cg/PixelDumpSupportCG.cpp: 3021 (printPNG): CG-specific PNG handling logic. 3022 (computeMD5HashStringForBitmapContext): Revised to use generic 3023 BitmapContext signature. 3024 (dumpBitmap): New function containing CG-specific portions of 3025 the dumping routine. 3026 * DumpRenderTree/cg/PixelDumpSupportCG.h: Add new signatures. 3027 * DumpRenderTree/win/DumpRenderTree.cpp: Disable CFNetwork logic 3028 when building the non-CFNetwork version. 3029 (main): 3030 * DumpRenderTree/win/DumpRenderTree.vcproj: 3031 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 3032 (createBitmapContextFromWebView): Provide parallel Cairo implementation 3033 of CG bitmap/context setup. 3034 30352009-07-02 Eric Seidel <eric@webkit.org> 3036 3037 No review, just adding Antti as a reviewer. 3038 3039 * Scripts/modules/bugzilla.py: 3040 30412009-07-02 Antonio Gomes <antonio.gomes@openbossa.org> 3042 3043 Reviewed by Simon Hausmann. 3044 3045 https://bugs.webkit.org/show_bug.cgi?id=26896 3046 3047 [Qt] Set DRT's default fontsize to 13. 3048 3049 * DumpRenderTree/qt/DumpRenderTree.cpp: 3050 (WebCore::WebPage::WebPage): 3051 30522009-07-01 Eric Seidel <eric@webkit.org> 3053 3054 Reviewed by Adam Barth. 3055 3056 bugzilla-tool fails for SVN users 3057 https://bugs.webkit.org/show_bug.cgi?id=26914 3058 3059 To fix this I moved svn from -F - to using -m 3060 In order for -m to work I had to move us off of shell=True 3061 To move off of shell=True all call sites for run_command 3062 which take args, need to pass their args as an list instead of a string. 3063 3064 In order for the final bug update to work correctly, I had to 3065 abstract the way that we parse out revision numbers from the commit text. 3066 3067 * Scripts/bugzilla-tool: 3068 * Scripts/modules/scm.py: 3069 30702009-07-01 Eric Seidel <eric@webkit.org> 3071 3072 Reviewed by Maciej Stachowiak. 3073 3074 prepare-ChangeLog should have a --bug= argument and use it for url autofill 3075 https://bugs.webkit.org/show_bug.cgi?id=26383 3076 3077 prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org 3078 I also added a bit more template text in an effort to get better ChangeLogs 3079 from casual contributers. 3080 3081 * Scripts/prepare-ChangeLog: 3082 30832009-07-01 Eric Seidel <eric@webkit.org> 3084 3085 Reviewed by Adam Roben. 3086 3087 prepare-ChangeLog should fail when EMAIL_ADDRESS or REAL_NAME are missing: 3088 https://bugs.webkit.org/show_bug.cgi?id=26692 3089 3090 I also made prepare-ChangeLog sanity-check names and email addresses a little. 3091 Names must contain a space, and email addresses must contain '@' 3092 3093 Also "fixed" $email_address to $emailAddress. This script uses mixed variable name styles. 3094 3095 * Scripts/prepare-ChangeLog: 3096 30972009-07-01 Chris Fleizach <cfleizach@apple.com> 3098 3099 Reviewed by Beth Dakin. 3100 3101 Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions 3102 https://bugs.webkit.org/show_bug.cgi?id=26900 3103 3104 Expose the ability to get the click point of an element through accessibility. 3105 3106 * DumpRenderTree/AccessibilityUIElement.cpp: 3107 (getClickPointXCallback): 3108 (getClickPointYCallback): 3109 (AccessibilityUIElement::getJSClass): 3110 * DumpRenderTree/AccessibilityUIElement.h: 3111 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 3112 (AccessibilityUIElement::clickPointX): 3113 (AccessibilityUIElement::clickPointY): 3114 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 3115 (AccessibilityUIElement::clickPointX): 3116 (AccessibilityUIElement::clickPointY): 3117 31182009-07-01 Mark Rowe <mrowe@apple.com> 3119 3120 Reviewed by Simon Fraser. 3121 3122 Change how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices. 3123 This makes WebKit.app behave as expected when set as the default web browser on a wider 3124 range of OS versions. 3125 3126 * WebKitLauncher/WebKitNightlyEnabler.m: 3127 (poseAsWebKitApp): 3128 (enableWebKitNightlyBehaviour): 3129 31302009-07-01 Mark Rowe <mrowe@apple.com> 3131 3132 Reviewed by Simon Fraser. 3133 3134 Shuffle some code around in preparation for a change to how poseAsWebKitApp works. 3135 3136 * WebKitLauncher/WebKitNightlyEnabler.m: 3137 (systemVersion): 3138 (webKitLauncherBundle): 3139 (insideSafari4OnTigerTrampoline): 3140 31412009-06-30 Xan Lopez <xlopez@igalia.com> 3142 3143 Reviewed by Jan Alonzo. 3144 3145 https://bugs.webkit.org/show_bug.cgi?id=26877 3146 [GTK] DRT fixes to pass new plugin test 3147 3148 Silence compiler warnings. 3149 3150 Newer GCC don't like using or returning a static string where a 3151 'char*' is expected. Ideally we'd change the function signatures 3152 to return or take 'const char*' I suppose, but since we can't do 3153 that just cast the strings to 'char*'. 3154 3155 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 3156 (webkit_test_plugin_get_value): 3157 31582009-06-30 Xan Lopez <xlopez@igalia.com> 3159 3160 Reviewed by Jan Alonzo. 3161 3162 https://bugs.webkit.org/show_bug.cgi?id=26877 3163 [GTK] DRT fixes to pass new plugin test 3164 3165 Use the common pluginLog function instead of a local copy. 3166 3167 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 3168 (webkit_test_plugin_new_instance): 3169 (webkit_test_plugin_destroy_instance): 3170 (webkit_test_plugin_set_window): 3171 (webkit_test_plugin_handle_event): 3172 31732009-06-30 Xan Lopez <xlopez@igalia.com> 3174 3175 Reviewed by Jan Alonzo. 3176 3177 https://bugs.webkit.org/show_bug.cgi?id=26877 3178 [GTK] DRT fixes to pass new plugin test 3179 3180 Modify our DRT as done in bug #15457 to log logSrc as src in order 3181 to pass test plugins/netscape-plugin-map-data-to-src.html. 3182 3183 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 3184 (webkit_test_plugin_new_instance): 3185 31862009-06-30 Adrien Nader <camaradetux@gmail.com> 3187 3188 Reviewed by Jan Alonzo. 3189 3190 [GTK] GtkLauncher depends on gtk+2-2.15 because of gtk_orientable_set_orientation() 3191 https://bugs.webkit.org/show_bug.cgi?id=26835 3192 3193 * GtkLauncher/main.c: 3194 (create_toolbar): 3195 31962009-06-30 Eric Seidel <eric@webkit.org> 3197 3198 Typo fix only, no review. 3199 3200 Fix typo causing failure during land-diff 3201 3202 * Scripts/bugzilla-tool: 3203 32042009-06-30 Simon Fraser <simon.fraser@apple.com> 3205 3206 Reviewed by Dan Bernstein. 3207 3208 Fix drawing of view background in pixel snapshots when using compositing. 3209 We still need to call -displayIfNeeded to ensure that the NSView drawing 3210 has happened. 3211 3212 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 3213 (createBitmapContextFromWebView): 3214 32152009-06-30 Simon Fraser <simon.fraser@apple.com> 3216 3217 Reviewed by Mark Rowe. 3218 3219 createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD, 3220 and thus failed on SnowLeopard. 3221 3222 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 3223 (createBitmapContextFromWebView): 3224 32252009-06-30 Eric Seidel <eric@webkit.org> 3226 3227 Reviewed by Nikolas Zimmermann. 3228 3229 Make bugzilla tool print a message explaining how to get help on failure: 3230 https://bugs.webkit.org/show_bug.cgi?id=26861 3231 3232 % bugzilla-tool 3233 Usage: bugzilla-tool [options] command [command-options] [command-arguments] 3234 3235 bugzilla-tool: error: No command specified 3236 3237 Type 'bugzilla-tool --help' to see usage. 3238 3239 * Scripts/bugzilla-tool: 3240 32412009-06-30 Eric Seidel <eric@webkit.org> 3242 3243 Reviewed by Maciej Stachowiak. 3244 3245 Include a built copy of BeautifulSoup 3.1.0.1 so that 3246 bugzilla-tool users do not need to install it manually. 3247 https://bugs.webkit.org/show_bug.cgi?id=26833 3248 3249 BeautifulSoup is BSD-licensed (thus WebKit compatible) and available from: 3250 http://www.crummy.com/software/BeautifulSoup 3251 3252 * Scripts/bugzilla-tool: fixed a typo in a log message. 3253 * Scripts/modules/BeautifulSoup.py: Added. 3254 * Scripts/modules/bugzilla.py: 3255 32562009-06-30 Eric Seidel <eric@webkit.org> 3257 3258 Reviewed by Simon Hausmann. 3259 3260 Fix our create_patch handling to not 3261 hang when creating large patches. 3262 https://bugs.webkit.org/show_bug.cgi?id=26834 3263 3264 We're now using StringIO to make an in-memory buffer for the patch 3265 instead of piping from the patch command directly to the upload. 3266 The previous hang was caused by calling wait() when the process had already 3267 filed the stdout buffer. 3268 3269 * Scripts/modules/scm.py: 3270 32712009-06-29 Sam Weinig <sam@webkit.org> 3272 3273 Reviewed by Mark Rowe. 3274 3275 Remove more unused scons support. 3276 3277 * Scripts/build-jsc: 3278 * Scripts/build-webkit: 3279 * Scripts/webkitdirs.pm: 3280 32812009-06-26 Eric Seidel <eric@webkit.org> 3282 3283 Reviewed by David Levin. 3284 3285 Rename land-and-update to land-diff and make it awesome. 3286 https://bugs.webkit.org/show_bug.cgi?id=26734 3287 3288 Renamed land-and-update to land-diff 3289 Made the BUGID argument optional. 3290 Added optional support for building and testing before landing. 3291 3292 land-diff [options] [BUGID] Lands the current working directory diff and updates the bug if provided. 3293 Options: 3294 -r REVIEWER, --reviewer=REVIEWER 3295 Update ChangeLogs to say Reviewed by REVIEWER. 3296 --no-close Leave bug open after landing. 3297 --no-build Commit without building first, implies --no-test. 3298 --no-test Commit without running run-webkit-tests. 3299 3300 * Scripts/bugzilla-tool: 3301 33022009-06-28 Jan Michael Alonzo <jmalonzo@webkit.org> 3303 3304 Gtk build fix - include stdarg.h for va_start/va_end. 3305 3306 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 3307 33082009-06-28 John Abd-El-Malek <jam@chromium.org> 3309 3310 https://bugs.webkit.org/show_bug.cgi?id=15457 3311 3312 Modify NPAPI test plugin to verify that "src" paramater is added when 3313 it's missing but "data" is present. 3314 3315 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 3316 (pluginLog): 3317 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 3318 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 3319 (NPP_New): 3320 (NPP_Destroy): 3321 (NPP_SetWindow): 3322 (handleEventCarbon): 3323 (handleEventCocoa): 3324 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 3325 (NPP_New): 3326 33272009-06-27 Emilio Pozuelo Monfort <pochu27@gmail.com> 3328 3329 Reviewed by Jan Alonzo. 3330 3331 [GTK] Don't use deprecated GTK+ symbols. 3332 https://bugs.webkit.org/show_bug.cgi?id=26583 3333 3334 * GtkLauncher/main.c: 3335 (create_toolbar): 3336 33372009-06-26 Adam Barth <abarth@webkit.org> 3338 3339 Reviewed by Eric Seidel. 3340 3341 Make SVN work (again?). 3342 3343 * Scripts/modules/scm.py: 3344 33452009-06-26 Chris Fleizach <cfleizach@apple.com> 3346 3347 Reviewed by Oliver Hunt. 3348 3349 Add ability to query isEnabled 3350 3351 * DumpRenderTree/AccessibilityUIElement.cpp: 3352 (getIsEnabledCallback): 3353 (AccessibilityUIElement::getJSClass): 3354 * DumpRenderTree/AccessibilityUIElement.h: 3355 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 3356 (AccessibilityUIElement::isEnabled): 3357 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 3358 (AccessibilityUIElement::isEnabled): 3359 33602009-06-26 Brady Eidson <beidson@apple.com> 3361 3362 Reviewed by Sam Weinig 3363 3364 <rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails 3365 3366 Add a dumpResourceResponseMIMETypes() mode so the ResourceLoadDelegate will dump the mime type from 3367 the NSURLResponse. Needed for the test for this bug fix. 3368 3369 * DumpRenderTree/LayoutTestController.cpp: 3370 (LayoutTestController::LayoutTestController): 3371 (dumpResourceResponseMIMETypesCallback): 3372 (LayoutTestController::staticFunctions): 3373 * DumpRenderTree/LayoutTestController.h: 3374 (LayoutTestController::dumpResourceResponseMIMETypes): 3375 (LayoutTestController::setDumpResourceResponseMIMETypes): 3376 3377 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 3378 (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): 3379 33802009-06-26 David Kilzer <ddkilzer@apple.com> 3381 3382 Update build-dumprendertree to use buildXCodeProject() 3383 3384 Reviewed by Adam Roben. 3385 3386 * Scripts/build-dumprendertree: Updated to use 3387 buildXCodeProject() when building for isAppleMacWebKit(). This 3388 provides additional command-line switch parsing for free. Also 3389 added --clean and --help switches. Updated copyright. 3390 33912009-06-26 Eric Seidel <eric@webkit.org> 3392 3393 Reviewed by Tor Arne Vestbø. 3394 3395 Remove non-sense --update option to land-patches 3396 and make land-patches update before every patch application. 3397 This makes it slightly less likely that multi-patch landings will fail. 3398 3399 Also updated git diff command to include staged modifications. 3400 3401 * Scripts/bugzilla-tool: 3402 * Scripts/modules/scm.py: 3403 34042009-06-25 Eric Seidel <eric@webkit.org> 3405 3406 Reviewed by Jan Alonzo. 3407 3408 Fix obsolete_attachment to work when passed a comment. 3409 https://bugs.webkit.org/show_bug.cgi?id=26745 3410 3411 * Scripts/modules/bugzilla.py: 3412 34132009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org> 3414 3415 Reviewed by Mark Rowe. 3416 3417 bugzilla-tool apply-patch throws exception in Linux 3418 https://bugs.webkit.org/show_bug.cgi?id=26738 3419 3420 HEAD is case-sensitive in Linux. Convert uses of head to HEAD in 3421 the scm module. 3422 3423 * Scripts/modules/scm.py: 3424 34252009-06-25 Eric Seidel <eric@webkit.org> 3426 3427 Reviewed by Jan Alonzo. 3428 3429 bugzilla-tool post-diff needs to obsolete old patches before posting 3430 https://bugs.webkit.org/show_bug.cgi?id=26740 3431 3432 I've also added a --no-obsolete to disable this behavior. 3433 3434 I also finally updated the bug page parsing to use XML. So much less code! 3435 3436 * Scripts/bugzilla-tool: 3437 * Scripts/modules/bugzilla.py: 3438 34392009-06-25 Eric Seidel <eric@webkit.org> 3440 3441 Reviewed by Mark Rowe. 3442 3443 Call WebKitTools/Scripts scripts by their absolute paths 3444 https://bugs.webkit.org/show_bug.cgi?id=26704 3445 3446 bugzilla-tool used to use whatever build-webkit was in your path. 3447 That could end up building the wrong copy of WebKit. 3448 3449 * Scripts/bugzilla-tool: 3450 * Scripts/modules/scm.py: 3451 34522009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 3453 3454 Reviewed by Dave Levin. 3455 3456 Use unicode() instead of str when reading from bugzilla. 3457 Also add Simon Fraser as a reviewer. 3458 https://bugs.webkit.org/show_bug.cgi?id=26719 3459 3460 * Scripts/modules/bugzilla.py: 3461 34622009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 3463 3464 Reviewed by Simon Hausmann. 3465 3466 Use Q_ASSERT in Qt's DumpRenderTree instead of JSC's ASSERT 3467 3468 The WTFReportAssertionFailure function in JSC is not exported when 3469 building QtWebKit in both debug and release on Mac, so DRT fails to 3470 link. 3471 3472 We can revert this patch once the Qt port builds JSC as a separate 3473 library, and we add the proper export macros to Assertions.cpp 3474 3475 * DumpRenderTree/qt/WorkQueue.cpp: 3476 (WorkQueue::queue): 3477 (WorkQueue::dequeue): 3478 34792009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 3480 3481 Reviewed by Jan Alonzo. 3482 3483 bugzilla-tool: Add Simon Hausmann as reviewer 3484 3485 * Scripts/modules/bugzilla.py: 3486 34872009-06-24 Eric Seidel <eric@webkit.org> 3488 3489 Reviewed by Dave Levin. 3490 3491 Support local commits during apply-patches 3492 and let land-patches take multiple bug ids. 3493 https://bugs.webkit.org/show_bug.cgi?id=26703 3494 3495 I also restructured parts of land-patches into 3496 class methods and static methods in preparation 3497 for future code sharing with other commands. 3498 3499 * Scripts/bugzilla-tool: 3500 * Scripts/modules/bugzilla.py: 3501 * Scripts/modules/scm.py: 3502 35032009-06-25 Eric Seidel <eric@webkit.org> 3504 3505 Reviewed by Tor Arne Vestbø. 3506 3507 Make svn-apply work with Git too 3508 https://bugs.webkit.org/show_bug.cgi?id=26299 3509 3510 Add an --force option to svn-apply and otherwise make svn-apply 3511 exit non-zero when patch application fails. 3512 https://bugs.webkit.org/show_bug.cgi?id=26300 3513 3514 I did not update svn-unapply, because it makes no sense in a Git world. 3515 You don't roll in and out patch files. You make commits and deal with those. 3516 Git users can just git reset --hard to get the same functionality. 3517 3518 * Scripts/svn-apply: 3519 35202009-06-25 Eric Seidel <eric@webkit.org> 3521 3522 Reviewed by Tor Arne Vestbø. 3523 3524 Remove use of os.system to fix reviewers with unicode chars in their names 3525 https://bugs.webkit.org/show_bug.cgi?id=26713 3526 3527 Also change to latin1 encoding of ø to make python happy. 3528 3529 * Scripts/modules/bugzilla.py: 3530 * Scripts/modules/scm.py: 3531 35322009-06-25 Eric Seidel <eric@webkit.org> 3533 3534 Reviewed by Tor Arne Vestbø. 3535 3536 Add Adam Roben and Tor Arne Vestbø to the reviewers list. 3537 3538 * Scripts/modules/bugzilla.py: 3539 35402009-06-24 Chris Fleizach <cfleizach@apple.com> 3541 3542 Windows build fix. 3543 3544 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 3545 (AccessibilityUIElement::language): 3546 35472009-06-24 Chris Fleizach <cfleizach@apple.com> 3548 3549 Reviewed by Oliver Hunt. 3550 3551 Bug 26668: AX: need a way to retrieve the language for an element 3552 Support ability to retrieve AXLanguage for testing 3553 3554 * DumpRenderTree/AccessibilityUIElement.cpp: 3555 (getLanguageCallback): 3556 (AccessibilityUIElement::getJSClass): 3557 * DumpRenderTree/AccessibilityUIElement.h: 3558 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 3559 (AccessibilityUIElement::language): 3560 35612009-06-24 Eric Seidel <eric@webkit.org> 3562 3563 Reviewed by Maciej Stachowiak. 3564 3565 Spell Maciej's name right and add Brady Eidson. 3566 3567 * Scripts/modules/bugzilla.py: 3568 35692009-06-23 Eric Seidel <eric@webkit.org> 3570 3571 Reviewed by Dave Levin. 3572 3573 Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run 3574 https://bugs.webkit.org/show_bug.cgi?id=26669 3575 3576 * Scripts/bugzilla-tool: 3577 * Scripts/modules/scm.py: 3578 35792009-06-23 Takeshi Yoshino <tyoshino@google.com> 3580 3581 Reviewed by Mark Rowe. 3582 3583 Bug 26537: Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists 3584 https://bugs.webkit.org/show_bug.cgi?id=26537 3585 3586 Let determineBaseProductDir subroutine remove 3587 ~/Library/Preferences/xcodebuild.plist. It can prevent xcodebuild from 3588 respecting global settings such as a custom build products directory 3589 (<rdar://problem/5585899>). 3590 3591 * Scripts/webkitdirs.pm: 3592 35932009-06-23 Eric Seidel <eric@webkit.org> 3594 3595 Reviewed by Dave Levin. 3596 3597 Make SCM.run_command smarter, and make all previous 3598 os.system and subprocess.popen use SCM.run_command instead. 3599 https://bugs.webkit.org/show_bug.cgi?id=26666 3600 3601 This makes it easier to handle errors in a standard way throughout all the code. 3602 Since this new code raises by default when the exit_code != 0, 3603 we should prevent future problems of bugzilla-tool continuing after 3604 a git or svn command failed. 3605 3606 * Scripts/modules/scm.py: 3607 36082009-06-23 Joe Mason <joe.mason@torchmobile.com> 3609 3610 Reviewed by Adam Treat. 3611 3612 https://bugs.webkit.org/show_bug.cgi?id=26664 3613 * Scripts/prepare-ChangeLog: Added --git-index mode to list only the 3614 changes which are already staged in the index. Useful to create an 3615 entry for what you're about to commit while ignoring unstaged changes. 3616 36172009-06-23 Anders Carlsson <andersca@apple.com> 3618 3619 Reviewed by Darin Adler. 3620 3621 Update for WebKit changes. 3622 3623 * DumpRenderTree/win/UIDelegate.h: 3624 (UIDelegate::willPerformDragSourceAction): 3625 36262009-06-23 Eric Seidel <eric@webkit.org> 3627 3628 Reviewed by Mark Rowe. 3629 3630 * Scripts/modules/scm.py: Fix commit_with_message to return the commit output. 3631 36322009-06-23 Eric Seidel <eric@webkit.org> 3633 3634 Reviewed by Mark Rowe. 3635 3636 * Scripts/modules/scm.py: Fix error seen when commiting r44979. 3637 36382009-06-18 Eric Seidel <eric@webkit.org> 3639 3640 Reviewed by Dave Levin. 3641 3642 WebKit needs a script to interact with bugzilla and automate 3643 parts of the patch posting and commit processes. 3644 https://bugs.webkit.org/show_bug.cgi?id=26283 3645 3646 This is really a first-draft tool. 3647 It's to the point where it's useful to more people than just me now though. 3648 Git support works. SVN support is written, but mostly untested. 3649 3650 This tool requires BeautifulSoup and mechanize python modules to run: 3651 sudo easy_install BeautifulSoup 3652 sudo easy_install mechanize 3653 3654 More important than the tool itself are the Bugzilla, Git and SVN class abstractions 3655 which I hope will allow easy writing of future tools. 3656 3657 The tool currently implements 10 commands, described below. 3658 3659 Helpers for scripting dealing with the commit queue: 3660 bugs-to-commit Bugs in the commit queue 3661 patches-to-commit Patches attached to bugs in the commit queue 3662 3663 Dealing with bugzilla: 3664 reviewed-patches BUGID r+'d patches on a bug 3665 apply-patches BUGID Applies all patches on a bug to the local working directory without committing. 3666 land-and-update BUGID Lands the current working directory diff and updates the bug. 3667 land-patches [options] BUGID Lands all patches on a bug optionally testing them first 3668 obsolete-attachments BUGID Marks all attachments on a bug as obsolete. 3669 commit-message Prints a commit message suitable for the uncommitted changes. 3670 3671 These effectively replace git-send-bugzilla: 3672 post-diff BUGID Attaches the current working directory diff to a bug as a patch file. 3673 post-commits BUGID COMMITISH Attaches a range of local commits to a bug as patch files. 3674 3675 post-diff works for SVN and Git, post-commits only works for SCMs with local-commit support (like Git) 3676 3677 land-* commands in a Git environment only work with simple patches due to svn-apply bugs: 3678 https://bugs.webkit.org/show_bug.cgi?id=26299 3679 https://bugs.webkit.org/show_bug.cgi?id=26300 3680 3681 This script follows python style (similar to how for Obj-C we follow AppKit style) 3682 http://www.python.org/doc/essays/styleguide.html 3683 The Python community has a strong style culture and the WebKit style guide is silent re: Python. 3684 3685 I've filed a bug to update the WebKit style guide to mention python: 3686 https://bugs.webkit.org/show_bug.cgi?id=26524 3687 3688 * Scripts/bugzilla-tool: Added. 3689 36902009-06-22 Steve Falkenburg <sfalken@apple.com> 3691 3692 Remove errant line of code mistakenly checked in. 3693 3694 * DumpRenderTree/win/DumpRenderTree.cpp: 3695 (main): 3696 36972009-06-22 Steve Falkenburg <sfalken@apple.com> 3698 3699 Pass correct value to setShouldPaintNativeControls. 3700 3701 Rubber stamped by Mark Rowe. 3702 3703 * DumpRenderTree/win/DumpRenderTree.cpp: 3704 (main): 3705 37062009-06-22 Steve Falkenburg <sfalken@apple.com> 3707 3708 Fix last DumpRenderTree change to correctly set preferences flag without crashing. 3709 3710 Reviewed by Mark Rowe. 3711 3712 * DumpRenderTree/win/DumpRenderTree.cpp: 3713 (main): 3714 37152009-06-21 Steve Falkenburg <sfalken@apple.com> 3716 3717 Set up global native controls flag before creating the first WebView. 3718 3719 Reviewed by Darin Adler. 3720 3721 * DumpRenderTree/win/DumpRenderTree.cpp: 3722 (main): 3723 37242009-06-21 Mark Rowe <mrowe@apple.com> 3725 3726 Reviewed by Sam Weinig. 3727 3728 Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates). 3729 3730 * WebKitLauncher/WebKitNightlyEnablerSparkle.m: 3731 (userAgentStringForSparkle): 3732 (initializeSparkle): 3733 37342009-06-21 Mark Rowe <mrowe@apple.com> 3735 3736 Reviewed by Sam Weinig. 3737 3738 Add a hook to the WebKit launcher application to allow a link on the nightly build start page to 3739 trigger an update via the built-in software update mechanism. 3740 3741 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: 3742 * WebKitLauncher/WebKitLauncherURLProtocol.h: Added. 3743 * WebKitLauncher/WebKitLauncherURLProtocol.m: Added. 3744 (+[WebKitLauncherURLProtocol load]): 3745 (+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains. 3746 (+[WebKitLauncherURLProtocol canonicalRequestForRequest:]): 3747 (-[WebKitLauncherURLProtocol startLoading]): 3748 (-[WebKitLauncherURLProtocol stopLoading]): 3749 (-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically 3750 determine whether the x-webkit-launcher is available and working. 3751 (-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread. 3752 (-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error. 3753 37542009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org> 3755 3756 Reviewed by Gustavo Noronha and Xan Lopez. 3757 3758 [Gtk] Implement DRT XSS auditor support 3759 https://bugs.webkit.org/show_bug.cgi?id=26571 3760 3761 * DumpRenderTree/gtk/DumpRenderTree.cpp: 3762 (resetWebViewToConsistentStateBeforeTesting): 3763 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 3764 (LayoutTestController::setXSSAuditorEnabled): 3765 37662009-06-19 Darin Adler <darin@apple.com> 3767 3768 * Scripts/do-webcore-rename: More renaming ideas. 3769 37702009-06-15 Andre Pedralho <andre.pedralho@openbossa.org> 3771 3772 Reviewed by Tor Arne Vestbø. 3773 3774 Only pass --makeargs along if an argument is given. 3775 3776 * Scripts/build-webkit: 3777 37782009-06-19 Adam Barth <abarth@webkit.org> 3779 3780 Unreviewed attempt to fix Windows build. 3781 3782 * DumpRenderTree/win/DumpRenderTree.cpp: 3783 (resetWebViewToConsistentStateBeforeTesting): 3784 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 3785 (LayoutTestController::setXSSAuditorEnabled): 3786 37872009-06-18 Adam Barth <abarth@webkit.org> 3788 3789 Reviewed by Sam Weinig. 3790 3791 https://bugs.webkit.org/show_bug.cgi?id=26199 3792 3793 Add support for testing the XSSAuditor. 3794 3795 * DumpRenderTree/LayoutTestController.cpp: 3796 (setXSSAuditorEnabledCallback): 3797 (LayoutTestController::staticFunctions): 3798 * DumpRenderTree/LayoutTestController.h: 3799 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 3800 (LayoutTestController::setXSSAuditorEnabled): 3801 * DumpRenderTree/mac/DumpRenderTree.mm: 3802 (resetWebViewToConsistentStateBeforeTesting): 3803 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 3804 (LayoutTestController::setXSSAuditorEnabled): 3805 * DumpRenderTree/win/DumpRenderTree.cpp: 3806 (resetWebViewToConsistentStateBeforeTesting): 3807 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 3808 (LayoutTestController::setXSSAuditorEnabled): 3809 (LayoutTestController::setPopupBlockingEnabled): 3810 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 3811 (LayoutTestController::setXSSAuditorEnabled): 3812 38132009-06-18 Darin Adler <darin@apple.com> 3814 3815 Rubber stamped by Mark Rowe. 3816 3817 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: 3818 (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression 3819 tests. The close method can be called on a window that's already closed 3820 so we can't assert here. 3821 38222009-06-17 Steve Falkenburg <sfalken@apple.com> 3823 3824 Updated for consolidated WebKit COM interfaces. 3825 3826 Reviewed by Adam Roben. 3827 3828 * DumpRenderTree/win/FrameLoadDelegate.cpp: 3829 * DumpRenderTree/win/FrameLoadDelegate.h: 3830 * DumpRenderTree/win/UIDelegate.cpp: 3831 * DumpRenderTree/win/UIDelegate.h: 3832 * WinLauncher/WinLauncher.h: 3833 38342009-06-16 Adam Barth <abarth@webkit.org> 3835 3836 Reviewed by Darin Adler. 3837 3838 https://bugs.webkit.org/show_bug.cgi?id=26437 3839 3840 Make the commit-log-editor match the ambient line endings in commit 3841 messages. 3842 3843 * Scripts/commit-log-editor: 3844 38452009-06-16 Xan Lopez <xlopez@igalia.com> 3846 3847 Reviewed by Gustavo Noronha. 3848 3849 Update GtkLauncher to recent API changes in the progress property, 3850 which now goes from 0.0 to 1.0. 3851 3852 * GtkLauncher/main.c: 3853 38542009-06-16 Adam Barth <abarth@webkit.org> 3855 3856 Reviewed by Darin Adler. 3857 3858 https://bugs.webkit.org/show_bug.cgi?id=26000 3859 3860 Teach prepare-ChangeLog to match the line ends that are already present 3861 in ChangeLog files. This helps folks whose use cygwin perl with CR LF 3862 line endings on Windows. 3863 3864 Also, teach prepare-ChangeLog to normalize backslashes in paths. This 3865 helps folks who use Windows SVN prepare correct ChangeLogs. 3866 3867 * Scripts/prepare-ChangeLog: 3868 3869== Rolled over to ChangeLog-2009-06-16 == 3870