12010-02-12 Diego Gonzalez <diego.gonzalez@openbossa.org> 2 3 Reviewed by Kenneth Rohde Christiansen. 4 5 Qt DRT now dump the frame loader callbacks when LayoutTestController() 6 method is called. 7 8 LayoutTests: 9 http/tests/security/mixedContent/data-url-script-in-iframe.html 10 http/tests/security/mixedContent/empty-url-plugin-in-frame.html 11 http/tests/security/mixedContent/insecure-css-in-iframe.html 12 http/tests/security/mixedContent/insecure-iframe-in-iframe.html 13 http/tests/security/mixedContent/insecure-image-in-iframe.html 14 http/tests/security/mixedContent/insecure-plugin-in-iframe.html 15 http/tests/security/mixedContent/insecure-script-in-iframe.html 16 http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html 17 http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html 18 19 [Qt] Make possible Qt DRT dump frame load callbacks 20 https://bugs.webkit.org/show_bug.cgi?id=34702 21 22 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 23 (LayoutTestController::reset): 24 (LayoutTestController::dumpFrameLoadCallbacks): 25 * DumpRenderTree/qt/LayoutTestControllerQt.h: 26 272010-02-12 Simon Hausmann <simon.hausmann@nokia.com> 28 29 Reviewed by Antti Koivisto. 30 31 Make QtLauncher somewhat useable on S60. 32 33 Show the window fullscreen to make scrollbars appear, resize 34 the toolbar buttons to 16x16 to give more screen space to 35 web content and moved the location lineedit into a separate 36 line. 37 38 * QtLauncher/main.cpp: 39 (LauncherWindow::LauncherWindow): 40 * QtLauncher/mainwindow.cpp: 41 (MainWindow::buildUI): 42 432010-02-12 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 44 45 Reviewed by Kenneth Rohde Christiansen. 46 47 Support frameset flattening 48 https://bugs.webkit.org/show_bug.cgi?id=32717 49 50 Add FrameSet Flattening support to Mac DRT. 51 52 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 53 (LayoutTestController::setFrameSetFlatteningEnabled): 54 * DumpRenderTree/win/DumpRenderTree.cpp: 55 (resetDefaultsToConsistentValues): 56 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 57 (LayoutTestController::setXSSAuditorEnabled): 58 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 59 (LayoutTestController::setFrameSetFlatteningEnabled): 60 * DumpRenderTree/LayoutTestController.cpp: 61 (setFrameSetFlatteningEnabledCallback): 62 (LayoutTestController::staticFunctions): 63 * DumpRenderTree/LayoutTestController.h: 64 * DumpRenderTree/mac/DumpRenderTree.mm: 65 (resetDefaultsToConsistentValues): 66 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 67 (LayoutTestController::setFrameSetFlatteningEnabled): 68 692010-02-12 Dirk Pranke <dpranke@chromium.org> 70 71 Reviewed by Eric Seidel. 72 73 Fix typos in driver_test.py 74 75 https://bugs.webkit.org/show_bug.cgi?id=34810 76 77 * Scripts/webkitpy/layout_tests/driver_test.py: 78 792010-02-12 Simon Hausmann <simon.hausmann@nokia.com> 80 81 Reviewed by Kenneth Rohde Christiansen. 82 83 [Qt] Make it possible to toggle the use of QGraphicsView in QtLauncher at run-time 84 https://bugs.webkit.org/show_bug.cgi?id=34844 85 86 * QtLauncher/main.cpp: 87 (LauncherWindow::LauncherWindow): 88 (LauncherWindow::initializeView): 89 (LauncherWindow::setupUI): 90 * QtLauncher/webview.cpp: 91 (WebViewGraphicsBased::WebViewGraphicsBased): 92 932010-02-11 Fumitoshi Ukai <ukai@chromium.org> 94 95 Reviewed by Alexey Proskuryakov. 96 97 WebSocket ignores HttpOnly cookies, but should use in Handshake. 98 https://bugs.webkit.org/show_bug.cgi?id=34289 99 100 Update pywebsocket to 0.4.8, which supports cgi directories. 101 run-webkit-tests and run-webkit-websocketserver will run 102 pywebsocket, specifying /websocket/test/cookies as cgi directory. 103 104 * Scripts/run-webkit-tests: 105 * Scripts/run-webkit-websocketserver: 106 * pywebsocket/mod_pywebsocket/standalone.py: 107 * pywebsocket/setup.py: 108 1092010-02-11 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 110 111 Reviewed by Dan Bernstein. 112 113 [Mac] Duplicated setXSSAuditorEnabled preference at Mac DRT 114 https://bugs.webkit.org/show_bug.cgi?id=34798 115 116 Remove duplicated setXSSAuditorEnabled preference at Mac DRT 117 118 * DumpRenderTree/mac/DumpRenderTree.mm: 119 (resetDefaultsToConsistentValues): 120 1212010-02-11 Eric Seidel <eric@webkit.org> 122 123 No review, build fix only. 124 125 webkitdirs.pm has a crazy amount of duplicated feature detection code 126 https://bugs.webkit.org/show_bug.cgi?id=34869 127 128 * Scripts/build-webkit: Fix typo which broke bots. 129 1302010-02-11 Eric Seidel <eric@webkit.org> 131 132 Reviewed by Adam Barth. 133 134 webkitdirs.pm has a crazy amount of duplicated feature detection code 135 https://bugs.webkit.org/show_bug.cgi?id=34869 136 137 * Scripts/build-webkit: Use the new hotness. 138 * Scripts/run-webkit-tests: ditto 139 * Scripts/webkitdirs.pm: Remove a bunch of bad duplicate code. 140 * Scripts/webkitperl/features.pm: Added. 141 - Simplified the 10 methods in webkitdirs.pm into 2 exported methods in this new file. 142 1432010-02-11 Daniel Bates <dbates@rim.com> 144 145 Reviewed by Adam Barth. 146 147 https://bugs.webkit.org/show_bug.cgi?id=34830 148 149 Makes method User.prompt static and adds the parameter repeat 150 to prompt the user up to repeat times. 151 152 * Scripts/test-webkitpy: 153 * Scripts/webkitpy/bugzilla.py: Substituted method User.prompt for method raw_input. 154 * Scripts/webkitpy/commands/upload.py: Ditto 155 * Scripts/webkitpy/credentials.py: Ditto 156 * Scripts/mock_bugzillatool.py: Updated prototype of MockUser.prompt to match User.prompt. 157 * Scripts/webkitpy/user.py: Made method prompt static and added parameter repeat. 158 * Scripts/webkitpy/user_unittest.py: Added. 159 1602010-02-10 Yuzo Fujishima <yuzo@google.com> 161 162 Reviewed by Darin Adler. 163 164 Allow underscored identifiers in CSSParser.cpp 165 166 Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*. 167 WebCore/css/CSSParser.cpp needs to handle some such identifiers. 168 We should relax the style rule for the file to allow underscored identifiers. 169 170 https://bugs.webkit.org/show_bug.cgi?id=34787 171 172 * Scripts/webkitpy/style/checker.py: 173 1742010-02-11 Eric Seidel <eric@webkit.org> 175 176 Rubber-stamped by Adam Barth. 177 178 Remove DrawTest, the application I used when bringing up SVG support on the Mac. 179 The code hasn't been touched (or used) in years. No sense in keeping it in trunk. 180 181 * Scripts/build-drawtest: Removed. 182 * Scripts/run-drawtest: Removed. 183 * DrawTest: Removed. 184 1852010-02-11 Eric Seidel <eric@webkit.org> 186 187 Reviewed by Adam Barth. 188 189 Need a command to clear r+ on obsolete patches in the pending-commit queue. 190 https://bugs.webkit.org/show_bug.cgi?id=34863 191 192 Unfortunately our http://webkit.org/pending-commit bugzilla query is not 193 smart enough to ignore obsolete patches, so bugs show up there which are 194 still open, but do not have patches ready for landing on them. 195 This new command "clean-pending-commit" will remove r+ from obsolete patches 196 in the pending-commit list. 197 198 * Scripts/test-webkitpy: Add grammar_unittest 199 * Scripts/webkitpy/commands/upload.py: Add clean-pending-commit and make assign-to-committer ignore cq+'d patches. 200 * Scripts/webkitpy/grammar.py: Add join_with_separators 201 * Scripts/webkitpy/grammar_unittest.py: Added. 202 2032010-02-11 Eric Seidel <eric@webkit.org> 204 205 Reviewed by Adam Barth. 206 207 run-chromium-webkit-tests fails random pixel tests on Mac 208 https://bugs.webkit.org/show_bug.cgi?id=34862 209 210 This is due to the fact that the Mac port has an 211 invalid path to the image diff tool. Currently it points 212 to image_diff even though ImageDiff would be correct. We 213 can't change it to the right path yet without causing the 214 script to hang. ImageDiff expects to be long-running and 215 be passed image data over stdin. image_diff (chromium's fork) 216 expects to be passed command line arguments. 217 This fix works around the random failures by disabling pixel 218 tests on mac and logging if the user was trying to run with pixel 219 tests enabled. 220 221 * Scripts/webkitpy/layout_tests/port/mac.py: 222 2232010-02-11 Nikolas Zimmermann <nzimmermann@rim.com> 224 225 Reviewed by Adam Roben. 226 Try to fix build breakage from r54665. 227 228 * Scripts/check-for-global-initializers: 229 2302010-02-11 Simon Hausmann <simon.hausmann@nokia.com> 231 232 Reviewed by Tor Arne Vestbø. 233 234 Make it possible to toggle accelerated compositing from the menu 235 at run-time. 236 237 * QtLauncher/main.cpp: 238 (LauncherWindow::toggleAcceleratedCompositing): 239 (LauncherWindow::setupUI): 240 2412010-02-08 Maciej Stachowiak <mjs@apple.com> 242 243 Reviewed by Cameron Zwarich. 244 245 Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose. 246 https://bugs.webkit.org/show_bug.cgi?id=34698 247 248 * Scripts/build-webkit: 249 2502010-02-10 Dirk Pranke <dpranke@chromium.org> 251 252 Reviewed by Eric Seidel. 253 254 Fix various minor bugs keeping run-chromium-webkit-tests from actually 255 working on the linux and win ports of Chromium. 256 257 https://bugs.webkit.org/show_bug.cgi?id=34739 258 259 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 260 * Scripts/webkitpy/layout_tests/port/__init__.py: 261 * Scripts/webkitpy/layout_tests/port/base.py: 262 * Scripts/webkitpy/layout_tests/port/chromium.py: 263 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 264 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 265 * Scripts/webkitpy/layout_tests/port/http_server.py: 266 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 267 2682010-02-10 Eric Seidel <eric@webkit.org> 269 270 Reviewed by David Levin. 271 272 run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory 273 https://bugs.webkit.org/show_bug.cgi?id=34817 274 275 This doesn't fix the root cause of us not 276 correctly failing when support binaries are missing. 277 This only causes the DumpRenderTree binary not to be 278 missing in the custom build directory case. 279 Later patches will make us correctly fail fast when 280 support binaries (like DumpRenderTree or ImageDiff) are missing. 281 282 * Scripts/webkit-build-directory: Added. 283 - Need a way to re-use the perl logic for finding build directories in non-perl scripts. 284 * Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME. 285 * Scripts/webkitpy/layout_tests/port/mac.py: 286 - Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild" 287 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs. 288 2892010-02-10 Kevin Watters <kevinwatters@gmail.com> 290 291 Reviewed by Kevin Ollivier. 292 293 [wx] Add Windows complex text support. 294 295 https://bugs.webkit.org/show_bug.cgi?id=34759 296 297 * wx/build/settings.py: 298 2992010-02-10 Kevin Ollivier <kevino@theolliviers.com> 300 301 [wx] Build fix. Add stub for new LayoutTestController method. 302 303 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 304 (LayoutTestController::numberOfPages): 305 3062010-02-10 Csaba Osztrogonác <ossy@webkit.org> 307 308 Unreviewed. Roll out r54626, because it broke GTK and Win build. 309 https://bugs.webkit.org/show_bug.cgi?id=32717 310 311 * DumpRenderTree/LayoutTestController.cpp: 312 (LayoutTestController::staticFunctions): 313 * DumpRenderTree/LayoutTestController.h: 314 * DumpRenderTree/mac/DumpRenderTree.mm: 315 (resetDefaultsToConsistentValues): 316 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 317 3182010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 319 320 Reviewed by Kenneth Rohde Christiansen. 321 322 Support frameset flattening 323 https://bugs.webkit.org/show_bug.cgi?id=32717 324 325 Add FrameSet Flattening support to Mac DRT. 326 327 * DumpRenderTree/LayoutTestController.cpp: 328 (setFrameSetFlatteningEnabledCallback): 329 (LayoutTestController::staticFunctions): 330 * DumpRenderTree/LayoutTestController.h: 331 * DumpRenderTree/mac/DumpRenderTree.mm: 332 (resetDefaultsToConsistentValues): 333 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 334 (LayoutTestController::setFrameSetFlatteningEnabled): 335 3362010-02-08 Jon Honeycutt <jhoneycutt@apple.com> 337 338 <rdar://problem/7436875> Crash in Flash when visiting 339 http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260] 340 341 Reviewed by Darin Adler. 342 343 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 344 (executeScript): 345 Moved to an earlier point in the file. 346 (NPP_New): 347 If the plug-in has an onDestroy attribute, store its value. 348 (NPP_Destroy): 349 If the plug-in has code to run on destruction, run it and free it. 350 3512010-02-10 Diego Gonzalez <diego.gonzalez@openbossa.org> 352 353 Reviewed by Kenneth Rohde Christiansen. 354 355 Implement pageNumberForElementById() method in Qt DRT LayoutTestController, 356 to make Qt DRT able to get page number. 357 358 LayoutTests: 359 printing/page-break-always.html 360 printing/pageNumerForElementById.html 361 printing/css2.1/page-break-before-000.html 362 printing/css2.1/page-break-after-000.html 363 printing/css2.1/page-break-after-004.html 364 printing/css2.1/page-break-before-001.html 365 printing/css2.1/page-break-after-001.html 366 printing/css2.1/page-break-after-002.html 367 printing/css2.1/page-break-before-002.html 368 printing/css2.1/page-break-inside-000.html 369 370 [Qt] Make possible Qt DRT get a page number for element by ID 371 https://bugs.webkit.org/show_bug.cgi?id=34777 372 373 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 374 (LayoutTestController::pageNumberForElementById): 375 * DumpRenderTree/qt/LayoutTestControllerQt.h: 376 3772010-02-10 Andras Becsi <abecsi@webkit.org> 378 379 Reviewed by Adam Barth. 380 381 Make run-iexploder-tests work on Linux. 382 https://bugs.webkit.org/show_bug.cgi?id=34748 383 384 Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function 385 called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux. 386 387 * Scripts/run-iexploder-tests: 388 * Scripts/webkitperl/httpd.pm: 389 3902010-02-09 Csaba Osztrogonác <ossy@webkit.org> 391 392 [Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode. 393 https://bugs.webkit.org/show_bug.cgi?id=34713 394 395 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 396 (WebCore::WebPage::WebPage): 397 * DumpRenderTree/qt/main.cpp: 398 (main): 399 4002010-02-09 Alejandro G. Castro <alex@igalia.com> 401 402 Unreviewed; added myself to committers 403 404 * Scripts/webkitpy/committers.py: 405 4062010-02-09 Yael Aharon <yael.aharon@nokia.com> 407 408 Reviewed by Kenneth Rohde Christiansen. 409 410 [Qt] Webkit in Qt does not have window.showModalDialog 411 https://bugs.webkit.org/show_bug.cgi?id=25585 412 413 Set the modality flag when createWindow is called with window type WebWindowDialog. 414 415 * QtLauncher/main.cpp: 416 (WebPage::createWindow): 417 4182010-02-09 Andras Becsi <abecsi@webkit.org> 419 420 Unreviewed trivial warning fix. 421 422 * Scripts/build-webkit: 423 4242010-02-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> 425 426 Reviewed by Tor Arne Vestbø. 427 428 Add possibility of passing parameters to build-webkit by environment variable, 429 because the buildbot slaves can't control the arguments. 430 431 * Scripts/build-webkit: 432 4332010-02-09 Chang Shu <Chang.Shu@nokia.com> 434 435 Reviewed by Laszlo Gombos. 436 437 [Qt] Enable appcache feature. 438 https://bugs.webkit.org/show_bug.cgi?id=34713 439 440 441 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 442 (WebCore::WebPage::WebPage): 443 * DumpRenderTree/qt/main.cpp: 444 (main): 445 4462010-02-09 Shinichiro Hamaji <hamaji@chromium.org> 447 448 Reviewed by Darin Adler. 449 450 Provide a way to get total number of pages to be printed 451 https://bugs.webkit.org/show_bug.cgi?id=34699 452 453 * DumpRenderTree/LayoutTestController.cpp: 454 (parsePageParameters): 455 (pageNumberForElementByIdCallback): 456 (numberOfPagesCallback): 457 (LayoutTestController::staticFunctions): 458 * DumpRenderTree/LayoutTestController.h: 459 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 460 (LayoutTestController::numberOfPages): 461 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 462 (LayoutTestController::numberOfPages): 463 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 464 (LayoutTestController::numberOfPages): 465 4662010-02-08 Alexey Proskuryakov <ap@apple.com> 467 468 Reviewed by Darin Adler. 469 470 https://bugs.webkit.org/show_bug.cgi?id=34727 471 Assertion crashes and freezes when plug-in property access results in an exception 472 473 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 474 (pluginGetProperty): Raise an exception when accessing a particular property. 475 (pluginSetProperty): Ditto. 476 (pluginInvoke): Added methods to get and set host object properties. 477 4782010-02-08 Kenneth Rohde Christiansen <kenneth@webkit.org> 479 480 Reviewed by Ariya Hidayat. 481 482 [Qt] Backport No'am Rosenthal's frame rate measurement 483 484 * QtLauncher/main.cpp: 485 (LauncherWindow::LauncherWindow): 486 (LauncherApplication::handleUserOptions): 487 * QtLauncher/webview.cpp: 488 (WebViewGraphicsBased::WebViewGraphicsBased): 489 (WebViewGraphicsBased::enableFrameRateMeasurement): 490 (WebViewGraphicsBased::updateFrameRate): 491 (WebViewGraphicsBased::paintEvent): 492 * QtLauncher/webview.h: 493 4942010-02-08 Kenneth Rohde Christiansen <kenneth@webkit.org> 495 496 Reviewed by Tor Arne Vestbø. 497 498 [Qt] Make overridePreference complain when it does not 499 support the preference given. 500 501 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 502 (LayoutTestController::overridePreference): 503 5042010-02-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 505 506 Reviewed by Kenneth Rohde Christiansen. 507 508 [Qt] Set stdout/stderr to binary mode for DRT on Windows 509 510 This makes sure we don't end up with lots of CRLFs in the 511 DRT output, which breaks tons of results. Matches what 512 the Windows DRT does. 513 514 * DumpRenderTree/qt/main.cpp: 515 5162010-02-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 517 518 Reviewed by Kenneth Rohde Christiansen. 519 520 Build fix for Qt on Windows. 521 522 Don't use noreturn directly since it's a gcc attribute. 523 Instead use the NO_RETURN macro from AlwaysInline.h 524 525 * QtLauncher/QtLauncher.pro: 526 * QtLauncher/utils.h: 527 5282010-02-05 Chris Jerdonek <cjerdonek@webkit.org> 529 530 Reviewed by Shinichiro Hamaji. 531 532 Suppressed check-webkit-style's underscore check in Qt's autotests. 533 Also made the path-specific filter check case-insensitive. 534 535 https://bugs.webkit.org/show_bug.cgi?id=34574 536 537 * Scripts/webkitpy/style/checker.py: 538 - Added a list element to _PATH_RULES_SPECIFIER for 539 directories that should be excluded from the 540 "readability/naming" category (the category that relates to 541 underscores in identifiers, for example). 542 543 * Scripts/webkitpy/style/checker_unittest.py: 544 - Added an "end-to-end" test for "WebKit/qt/tests/". 545 546 * Scripts/webkitpy/style/filter.py: 547 - Altered FilterConfiguration's should_check() method to 548 check for path substring matches case-insensitively. 549 550 * Scripts/webkitpy/style/filter_unittest.py: 551 - Added a test to check case-insensitive path substring matching. 552 553 * Scripts/webkitpy/style/processors/cpp.py: 554 - Removed the hard-coded "WebKit/gtk/webkit/" path reference 555 since this is now taken care of by the _PATH_RULES_SPECIFIER 556 configuration variable. 557 558 * Scripts/webkitpy/style/processors/cpp_unittest.py: 559 - Removed the unit test for the GTK directory since this 560 is now taken care of by the checker._PATH_RULES_SPECIFIER 561 end-to-end tests. 562 5632010-02-08 Leith Bade <leith@leithalweapon.geek.nz> 564 565 Reviewed by Darin Adler. 566 567 Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637 568 Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows 569 environemnt variables when there is a space in the user's /home path. 570 571 * Scripts/webkitdirs.pm: 572 - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir(). 573 5742010-02-05 Alexey Proskuryakov <ap@apple.com> 575 576 Reviewed by Oliver Hunt. 577 578 https://bugs.webkit.org/show_bug.cgi?id=34670 579 TestNetscapePlugin should work with Firefox 580 581 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if 582 browser doesn't tell what it supports. 583 5842010-02-05 Shinichiro Hamaji <hamaji@chromium.org> 585 586 Reviewed by Gustavo Noronha Silva. 587 588 [Gtk] Implement layoutTestController.pageNumberForElementById 589 https://bugs.webkit.org/show_bug.cgi?id=34572 590 591 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 592 (LayoutTestController::pageNumberForElementById): 593 5942010-02-03 Dirk Pranke <dpranke@chromium.org> 595 596 Reviewed by Eric Seidel. 597 598 Add a simple test implementation and the WebKit Mac implementation 599 for the layout_tests/port package. Also add a simple test driver of 600 that interface. 601 602 https://bugs.webkit.org/show_bug.cgi?id=34511 603 604 * Scripts/webkitpy/layout_tests/driver_test.py: Added. 605 * Scripts/webkitpy/layout_tests/port/__init__.py: 606 * Scripts/webkitpy/layout_tests/port/mac.py: Added. 607 * Scripts/webkitpy/layout_tests/port/test.py: Added. 608 6092010-02-03 Dirk Pranke <dpranke@chromium.org> 610 611 Reviewed by Eric Siedel. 612 613 Refactor the port package into an object-oriented style and merge 614 path_utils into it. We add a 'base' and a 'chromium' object to the 615 port package; this will allow us to easily add new ports (like 616 WebKit Mac). 617 618 https://bugs.webkit.org/show_bug.cgi?id=34511 619 620 * Scripts/rebaseline-chromium-webkit-tests: 621 * Scripts/run-chromium-webkit-tests: 622 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 623 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 624 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 625 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: 626 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 627 * Scripts/webkitpy/layout_tests/port/__init__.py: 628 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 629 * Scripts/webkitpy/layout_tests/port/base.py: Added. 630 * Scripts/webkitpy/layout_tests/port/chromium.py: Added. 631 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 632 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 633 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 634 * Scripts/webkitpy/layout_tests/port/http_server.py: 635 * Scripts/webkitpy/layout_tests/port/http_server_base.py: 636 * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed. 637 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 638 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 639 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: 640 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: 641 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 642 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 643 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 644 6452010-01-19 Kenneth Rohde Christiansen <kenneth@webkit.org> 646 647 Reviewed by Dave Hyatt. 648 649 Implement flattening of framesets 650 https://bugs.webkit.org/show_bug.cgi?id=32717 651 652 Add support for testing frame flattening with the Qt DRT 653 654 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 655 (LayoutTestController::setFrameSetFlatteningEnabled): 656 * DumpRenderTree/qt/LayoutTestControllerQt.h: 657 6582010-02-03 Chris Jerdonek <cjerdonek@webkit.org> 659 660 Reviewed by Shinichiro Hamaji. 661 662 Provided a way in check-webkit-style to specify filter rules 663 on a per file or folder basis, via a configuration variable. 664 665 https://bugs.webkit.org/show_bug.cgi?id=33684 666 667 * Scripts/webkitpy/style/checker.py: 668 - Added _PATH_RULES_SPECIFIER configuration variable. 669 - In ProcessorOptions class-- 670 - Changed the CategoryFilter attribute to FilterConfiguration. 671 - Added path parameter to is_reportable(). 672 - Renamed ArgumentDefaults filter_rules attribute to 673 base_filter_rules. 674 - Updated ArgumentPrinter class. 675 - Added filter rule validation to ArgumentParser (instead of 676 in CategoryFilter constructor). 677 678 * Scripts/webkitpy/style/checker_unittest.py: 679 - Updated unit tests as necessary. 680 - Added unit tests for PATH_RULES_SPECIFIER. 681 682 * Scripts/webkitpy/style/error_handlers.py: 683 - Updated DefaultStyleErrorHandler to use file path when 684 calling is_reportable(). 685 686 * Scripts/webkitpy/style/error_handlers_unittest.py: 687 - Updated unit tests as necessary. 688 689 * Scripts/webkitpy/style/filter.py: 690 - Marked CategoryFilter internal with an underscore. 691 - Removed argument validation from CategoryFilter. 692 - Added FilterConfiguration class. 693 694 * Scripts/webkitpy/style/filter_unittest.py: 695 - Updated CategoryFilterTest class. 696 - Added FilterConfigurationTest unit tests. 697 698 * Scripts/webkitpy/style/processors/cpp.py: 699 - Removed _is_test_filename() code. 700 - Removed hard-coded path checks from check_include_line(). 701 702 * Scripts/webkitpy/style/processors/cpp_unittest.py: 703 - Removed three unit tests related to exempted files. 704 7052010-02-05 Kenneth Rohde Christiansen <kenneth@webkit.org> 706 707 Reviewed by Ariya Hidayat. 708 709 [Qt] Apply the command line options as settings to the 710 graphics system. 711 712 * QtLauncher/main.cpp: 713 (LauncherWindow::LauncherWindow): 714 (requiresGraphicsView): 715 (LauncherApplication::handleUserOptions): 716 * QtLauncher/webview.h: 717 (WebViewGraphicsBased::setItemCacheMode): 718 7192010-02-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 720 721 Reviewed by Simon Hausmann. 722 723 Notify user that run-webkit-tests has to be run under Cygwin 724 725 The script will bail out if run under Windows shell or Msys. 726 727 * Scripts/run-webkit-tests: 728 * Scripts/webkitdirs.pm: 729 7302010-02-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 731 732 Reviewed by Simon Hausmann. 733 734 [Qt] Generate convenience headers (QWebView, etc) using qmake 735 736 In Qt this is done using syncqt, but we use a pro-file instead 737 that generates makefile-rules for each of the extra headers. 738 739 These extra headers are installed alongside the normal headers. 740 741 * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources 742 7432010-02-05 Andras Becsi <abecsi@webkit.org> 744 745 Unreviewed typo fix. 746 747 Fix wrong whitespace alignment introduced in r54342. 748 749 * Scripts/run-webkit-tests: 750 7512010-02-04 Mark Rowe <mrowe@apple.com> 752 753 Reviewed by Timothy Hatcher. 754 755 Build fix. Remove a symbol corresponding to an inline function from the linker export 756 file to prevent a weak external failure. 757 758 * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables. 759 Teach the script how to detect weak external symbols so that these errors can be caught immediately 760 in the future. 761 7622010-02-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 763 764 Rubberstamped by Oliver Hunt. 765 766 [Qt] Make it possible to choose whether the launcher should 767 use the traditional QWidget based QWebView or the newer 768 QGraphics based QGraphicsWebView on a QGraphicsView. 769 770 * QtLauncher/main.cpp: 771 (LauncherWindow::LauncherWindow): 772 (LauncherWindow::eventFilter): 773 (LauncherWindow::loadStarted): 774 (LauncherWindow::print): 775 (LauncherWindow::screenshot): 776 (LauncherWindow::setEditable): 777 (LauncherWindow::setupUI): 778 (main): 779 * QtLauncher/webview.cpp: 780 (WebViewGraphicsBased::WebViewGraphicsBased): 781 (WebViewGraphicsBased::resizeEvent): 782 (GraphicsWebView::mousePressEvent): 783 (GraphicsWebView::contextMenuEvent): 784 * QtLauncher/webview.h: 785 (WebViewTraditional::WebViewTraditional): 786 (GraphicsWebView::GraphicsWebView): 787 (WebViewGraphicsBased::setPage): 788 7892010-02-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 790 791 Rubberstamped by Oliver Hunt. 792 793 [Qt] QtLauncher cleanup. 794 795 Refactor option handling out in utility functions and make the 796 arguments more Qt compatible. 797 798 * QtLauncher/main.cpp: 799 (requiresGraphicsView): 800 (LauncherApplication::handleUserOptions): 801 * QtLauncher/utils.cpp: 802 (takeOptionValue): 803 (formatKeys): 804 (enumToKeys): 805 (appQuit): 806 * QtLauncher/utils.h: 807 8082010-02-04 Andras Becsi <abecsi@inf.u-szeged.hu> 809 810 Reviewed by Tor Arne Vestbø. 811 812 Implement a locking and scheduling mechanism for http testing sessions to be able 813 to run multiple instances of run-webkit-tests parallel on the same machine. 814 If a test session wants to run http tests and this feature is enabled, the pending 815 sessions create lockfiles with sequential lock numbers. These locks are used to schedule 816 the running test sessions in first come first served order. An exclusive lock ensures 817 that the lock numbers are sequential to avoid deadlocks and starvation. 818 Because the buildbot master specifies the flags used by slaves we need an environment 819 variable too to be able to use the feature per-slave. 820 Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd 821 flag enables this feature, otherwise this patch has no effect on the testing whatsoever. 822 823 https://bugs.webkit.org/show_bug.cgi?id=33153 824 825 * Scripts/run-webkit-tests: 826 * Scripts/webkitperl/httpd.pm: 827 8282010-01-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 829 830 Reviewed by Simon Hausmann. 831 832 Make run-webkit-tests work under Cygwin for the Qt port 833 834 setPathForRunningWebKitApp() is implemented for the Qt port 835 by using qmake to query for the location of the Qt libraries. 836 837 This requires the original environment (%ENV) to be untouched, 838 so launchWithCurrentEnv() was refactored to launchWithEnv(), 839 and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV 840 instead. This has the added benefit of getting rid of the temp 841 variables used for storing the current env. 842 843 openDumpTool() is also refactored a bit into platform-spesific, 844 port-spesific, and generic environment variables. 845 846 Checks for undef was added a few places to fix Perl concat 847 warnings when run-webkit-tests is aborted. 848 849 https://bugs.webkit.org/show_bug.cgi?id=33895 850 851 * Scripts/run-webkit-tests: 852 * Scripts/webkitdirs.pm: 853 8542010-02-04 Yuzo Fujishima <yuzo@google.com> 855 856 Unreviewed. 857 858 Add Yuzo to the committers list. 859 860 * Scripts/webkitpy/committers.py: 861 8622010-02-03 Dirk Pranke <dpranke@chromium.org> 863 864 Rubber-stamped by Eric Seidel. 865 866 Change "the Chromium name" to "the name of Google Inc." in the licenses 867 868 https://bugs.webkit.org/show_bug.cgi?id=34511 869 870 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 871 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 872 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: 873 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 874 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 875 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: 876 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 877 * Scripts/webkitpy/layout_tests/port/__init__.py: 878 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 879 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 880 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 881 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 882 * Scripts/webkitpy/layout_tests/port/http_server.py: 883 * Scripts/webkitpy/layout_tests/port/http_server_base.py: 884 * Scripts/webkitpy/layout_tests/port/path_utils.py: 885 * Scripts/webkitpy/layout_tests/port/websocket_server.py: 886 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 887 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: 888 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: 889 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 890 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 891 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 892 8932010-02-03 Dirk Pranke <dpranke@chromium.org> 894 895 Rubber-stamped by Eric Siedel. 896 897 Rename files as part of refactoring the layout_tests package. All 898 the platform_utils* module, the path_utils.py module, and 899 the http server and web socket server modules are moved into a new 900 port/ package. 901 902 https://bugs.webkit.org/show_bug.cgi?id=34511 903 904 * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed. 905 * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed. 906 * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed. 907 * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed. 908 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 909 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 910 * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed. 911 * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed. 912 * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed. 913 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed. 914 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed. 915 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed. 916 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 917 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: 918 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 919 * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed. 920 * Scripts/webkitpy/layout_tests/port: Added. 921 * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py. 922 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py. 923 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py. 924 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py. 925 * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py. 926 * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py. 927 * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py. 928 * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem. 929 * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf. 930 * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py. 931 * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py. 932 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 933 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: 934 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: 935 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 936 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 937 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 938 939 9402010-02-03 Csaba Osztrogonác <ossy@webkit.org> 941 942 Rubber-stamped by Eric Seidel. 943 944 Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots 945 https://bugs.webkit.org/show_bug.cgi?id=34399 946 947 * Scripts/run-iexploder-tests: 948 * Scripts/run-webkit-httpd: 949 * Scripts/run-webkit-tests: 950 * Scripts/webkitperl/httpd.pm: Added. 951 9522010-02-03 Csaba Osztrogonác <ossy@webkit.org> 953 954 Rubber-stamped by Eric Seidel. 955 956 Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots 957 958 * Scripts/run-iexploder-tests: 959 * Scripts/run-webkit-httpd: 960 * Scripts/run-webkit-tests: 961 * Scripts/webkitperl/httpd.pm: Removed. 962 9632010-02-03 Csaba Osztrogonác <ossy@webkit.org> 964 965 Rubber-stamped by Ariya Hidayat. 966 967 Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots 968 https://bugs.webkit.org/show_bug.cgi?id=34399 969 970 * DumpRenderTree/win/EventSender.cpp: 971 (buildModifierFlags): 972 (mouseDownCallback): 973 (mouseUpCallback): 974 (keyDownCallback): 975 9762010-02-03 Eric Seidel <eric@webkit.org> 977 978 No review, just fixing copyrights. 979 980 Concerns were expressed about "The Chromium Authors" being 981 a valid legal entity for copyright assignment in the WebKit repository, 982 so this change removes all "The Chromium Authors". 983 984 I looked at the svn logs in src.chromium.org and failed to find any 985 non-google contributions to these files, so they are all now 986 marked as copyright "Google Inc" as all Google contributers assign 987 copyright to "Google Inc" as part of their employment agreement. 988 989 * Scripts/rebaseline-chromium-webkit-tests: 990 * Scripts/run-chromium-webkit-tests: 991 * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: 992 * Scripts/webkitpy/layout_tests/layout_package/http_server.py: 993 * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: 994 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 995 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 996 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: 997 * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: 998 * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: 999 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: 1000 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: 1001 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: 1002 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 1003 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 1004 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: 1005 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: 1006 * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: 1007 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 1008 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: 1009 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: 1010 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 1011 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 1012 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 1013 10142010-02-03 Kenneth Rohde Christiansen <kenneth@webkit.org> 1015 1016 Reviewed by Ariya Hidayat. 1017 1018 [Qt] QtLauncher, refactor argument handling in preparation of merge 1019 with QGVLauncher 1020 1021 * QtLauncher/main.cpp: 1022 (LauncherApplication::urls): 1023 (LauncherApplication::isRobotized): 1024 (LauncherApplication::applyDefaultSettings): 1025 (LauncherApplication::LauncherApplication): 1026 (LauncherApplication::formatKeys): 1027 (LauncherApplication::enumToKeys): 1028 (fail): 1029 (LauncherApplication::handleUserOptions): 1030 (main): 1031 10322010-02-03 Csaba Osztrogonác <ossy@webkit.org> 1033 1034 Rubber-stamped by Ariya Hidayat. 1035 1036 Rolling out r53889, because it might caused flakeyness on the Windows Test bots 1037 https://bugs.webkit.org/show_bug.cgi?id=34399 1038 1039 * DumpRenderTree/win/EventSender.cpp: 1040 (mouseDownCallback): 1041 (mouseUpCallback): 1042 (keyDownCallback): 1043 10442010-02-03 Csaba Osztrogonác <ossy@webkit.org> 1045 1046 Reviewed by Ariya Hidayat. 1047 1048 [Qt] Fix pixel tests support. 1049 https://bugs.webkit.org/show_bug.cgi?id=27813 1050 1051 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 1052 (WebCore::DumpRenderTree::open): 1053 (WebCore::DumpRenderTree::processLine): 1054 - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine. 1055 (WebCore::DumpRenderTree::dump): Fixed and renamed variables. 1056 10572010-02-03 Kevin Watters <kevinwatters@gmail.com> 1058 1059 Reviewed by Kevin Ollivier. 1060 1061 [wx] Enable JIT compilation for wx. 1062 1063 https://bugs.webkit.org/show_bug.cgi?id=34536 1064 1065 * wx/build/settings.py: 1066 10672010-02-02 Kevin Ollivier <kevino@theolliviers.com> 1068 1069 [wx] Build fix after introduction of pageNumberForElementById. 1070 1071 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 1072 (LayoutTestController::pageNumberForElementById): 1073 10742010-02-02 Shu Chang <Chang.Shu@nokia.com> 1075 1076 Unreviewed. 1077 1078 Add myself to list of committers. 1079 1080 * Scripts/webkitpy/committers.py: 1081 10822010-02-02 Chris Jerdonek <cjerdonek@webkit.org> 1083 1084 Reviewed by Shinichiro Hamaji. 1085 1086 Moved filter-related check-webkit-style code into a separate 1087 filter module. 1088 1089 https://bugs.webkit.org/show_bug.cgi?id=34408 1090 1091 This is preparatory refactoring for Bug 33684, which will allow 1092 file and folder-specific filter rules. 1093 1094 * Scripts/webkitpy/style/checker.py: 1095 - Removed CategoryFilter class (moved to filter.py). 1096 1097 * Scripts/webkitpy/style/checker_unittest.py: 1098 - Removed CategoryFilter unit tests (moved to filter_unittest.py). 1099 1100 * Scripts/webkitpy/style/filter.py: Added. 1101 - Added CategoryFilter class (moved from checker.py). 1102 1103 * Scripts/webkitpy/style/filter_unittest.py: Added. 1104 - Added CategoryFilter unit tests (moved from checker_unittest.py). 1105 1106 * Scripts/webkitpy/style/unittests.py: 1107 - Added reference to filter_unittest.py. 1108 11092010-02-01 Chris Jerdonek <cjerdonek@webkit.org> 1110 1111 Reviewed by Shinichiro Hamaji. 1112 1113 Addressed FIXME in check-webkit-style so that the carriage-return 1114 check will work for patches. 1115 1116 https://bugs.webkit.org/show_bug.cgi?id=34260 1117 1118 Also added support for limiting the number of errors reported 1119 per category, per file. 1120 1121 * Scripts/webkitpy/style/checker.py: 1122 - Added new "whitespace/carriage_return" category from common.py. 1123 - Added MAX_REPORTS_PER_CATEGORY dictionary. 1124 - Added max_reports_per_category attribute to ProcessorOptions class. 1125 - Refactored StyleChecker._process_file(). 1126 1127 * Scripts/webkitpy/style/checker_unittest.py: 1128 - Updated ProcessorOptionsTest tests. 1129 - Added test to check MAX_REPORTS_PER_CATEGORY. 1130 1131 * Scripts/webkitpy/style/error_handlers.py: 1132 - Added support for suppressing the display of errors after 1133 reaching a per-category maximum (from max_reports_per_category). 1134 1135 * Scripts/webkitpy/style/error_handlers_unittest.py: 1136 - Added test for suppressing error display. 1137 1138 * Scripts/webkitpy/style/processors/common.py: Added. 1139 - Moved carriage-return check to new file. 1140 1141 * Scripts/webkitpy/style/processors/common_unittest.py: Added. 1142 - Added unit tests for carriage-return check. 1143 1144 * Scripts/webkitpy/style/unittests.py: 1145 - Added reference to common_unittest.py. 1146 11472010-02-01 Shinichiro Hamaji <hamaji@chromium.org> 1148 1149 Reviewed by Eric Seidel. 1150 1151 Provide a way to get page number with layoutTestController 1152 https://bugs.webkit.org/show_bug.cgi?id=33840 1153 1154 * DumpRenderTree/LayoutTestController.cpp: 1155 (pageNumberForElementByIdCallback): 1156 (LayoutTestController::staticFunctions): 1157 * DumpRenderTree/LayoutTestController.h: 1158 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 1159 (LayoutTestController::pageNumberForElementById): 1160 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 1161 (LayoutTestController::pageNumberForElementById): 1162 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 1163 (LayoutTestController::pageNumberForElementById): 1164 11652010-02-01 Shinichiro Hamaji <hamaji@chromium.org> 1166 1167 Unreviewed fix for an invalid function call. 1168 1169 check-webkit-style: Remove filename parameter from all functions where no longer used 1170 https://bugs.webkit.org/show_bug.cgi?id=34249 1171 1172 * Scripts/webkitpy/style/checker.py: 1173 11742010-02-01 Diego Gonzalez <diego.gonzalez@openbossa.org> 1175 1176 Reviewed by Kenneth Rohde Christiansen. 1177 1178 [Qt] DRT Provide global flag ability 1179 https://bugs.webkit.org/show_bug.cgi?id=34418 1180 1181 Add the globalFlag property to the Qt LayoutTestController to allow 1182 cross-domain indications. 1183 1184 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 1185 (LayoutTestController::reset): 1186 * DumpRenderTree/qt/LayoutTestControllerQt.h: 1187 (LayoutTestController::globalFlag): 1188 (LayoutTestController::setGlobalFlag): 1189 11902010-02-01 Brady Eidson <beidson@apple.com> 1191 1192 Reviewed by Adele Peterson. 1193 1194 Crash in Safari opening new tabs to "same page" 1195 <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444 1196 1197 Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView: 1198 1199 * DumpRenderTree/LayoutTestController.cpp: 1200 (LayoutTestController::LayoutTestController): 1201 (setNewWindowsCopyBackForwardListCallback): 1202 (LayoutTestController::staticFunctions): 1203 1204 * DumpRenderTree/LayoutTestController.h: 1205 (LayoutTestController::newWindowsCopyBackForwardList): 1206 (LayoutTestController::setNewWindowsCopyBackForwardList): 1207 1208 * DumpRenderTree/mac/UIDelegate.mm: 1209 (-[UIDelegate webView:createWebViewWithRequest:]): 1210 12112010-02-01 Carol Szabo <carol.szabo@nokia.com> 1212 1213 Unreviewed. 1214 1215 Add myself to list of committers. 1216 1217 * Scripts/webkitpy/committers.py: 1218 12192010-02-01 Nate Chapin <japhet@chromium.org> 1220 1221 Rubber-stamped by David Levin. 1222 1223 Add myself to reviewer list. 1224 1225 * Scripts/webkitpy/committers.py: 1226 12272010-01-31 Chris Jerdonek <cjerdonek@webkit.org> 1228 1229 Reviewed by Shinichiro Hamaji. 1230 1231 Moved style error handler code to their own classes, and 1232 related refactoring. Increased unit test code coverage of 1233 style error handling. 1234 1235 https://bugs.webkit.org/show_bug.cgi?id=34379 1236 1237 * Scripts/check-webkit-style: 1238 - Minor change: added error_count variable. 1239 1240 * Scripts/webkitpy/style/checker.py: 1241 - Renamed ProcessorOptions.should_report_error() to is_reportable(). 1242 - In the StyleChecker class-- 1243 - Removed _default_style_error_handler(). 1244 - Added _increment_error_count(). 1245 - Refactored to use DefaultStyleErrorHandler and 1246 PatchStyleErrorHandler constructors. 1247 1248 * Scripts/webkitpy/style/checker_unittest.py: 1249 - In the StyleStyleCheckerTest class-- 1250 - Removed write_sample_error(). 1251 - Removed test_default_style_error_handler(). 1252 1253 * Scripts/webkitpy/style/error_handlers.py: Added. 1254 - Added DefaultStyleErrorHandler class. 1255 - Added PatchStyleErrorHandler class. 1256 1257 * Scripts/webkitpy/style/error_handlers_unittest.py: Added. 1258 - Added unit tests for DefaultStyleErrorHandler and 1259 PatchStyleErrorHandler. 1260 1261 * Scripts/webkitpy/style/unittests.py: 1262 - Added error_handlers unit tests. 1263 12642010-01-29 Mark Rowe <mrowe@apple.com> 1265 1266 Rubber-stamped by Stephanie Lewis. 1267 1268 Fix run-leaks with newer versions of the leaks tool. 1269 1270 * Scripts/run-leaks: 1271 12722010-01-29 Dirk Pranke <dpranke@chromium.org> 1273 1274 Reviewed by Eric Siedel. 1275 1276 Top-level test drivers for running the Chromium port of run-webkit-tests 1277 and being able to rebaseline test results from the test bots. The 1278 files in the Scripts directory are simply wrappers around the files 1279 in webkitpy/layout_tests for convenience. 1280 1281 https://bugs.webkit.org/show_bug.cgi?id=31498 1282 1283 * Scripts/rebaseline-chromium-webkit-tests: Added. 1284 * Scripts/run-chromium-webkit-tests: Added. 1285 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added. 1286 * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added. 1287 12882010-01-29 Dirk Pranke <dpranke@chromium.org> 1289 1290 Reviewed by Eric Siedel. 1291 1292 Add in the second block of python code for the Chromium port 1293 of run-webkit-tests. These files execute different diffs to classify 1294 the various types of failures from a test. 1295 1296 * Scripts/webkitpy/layout_tests/test_types: Added. 1297 * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added. 1298 * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added. 1299 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added. 1300 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added. 1301 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added. 1302 13032010-01-29 Dirk Pranke <dpranke@chromium.org> 1304 1305 Reviewed by Eric Siedel. 1306 1307 Check in the first part of the Chromium Python port of the 1308 run-webkit-tests test driver. The files under 1309 layout_tests/layout_layout constitute most of the implementation; 1310 they can be roughly divided into code that parses the 1311 "test_expectations.txt" file that describes how we expect tests to 1312 pass or fail, platform-specific hooks for the different Chromium 1313 ports (in platform_utils*), code for parsing the output of the 1314 tests and generating results files and HTML and JSON for the 1315 dashboards, auxiliary scripts for starting and stopping HTTP and 1316 Web Socket servers, and then one of the actual driver files 1317 (test_shell_thread). Code for actually parsing test output for 1318 failures and the top-level driver scripts will follow shortly. 1319 1320 https://bugs.webkit.org/show_bug.cgi?id=31498 1321 1322 * Scripts/webkitpy/layout_tests: Added. 1323 * Scripts/webkitpy/layout_tests/layout_package: Added. 1324 * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added. 1325 * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added. 1326 * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added. 1327 * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added. 1328 * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added. 1329 - scripts to start and stop apache. Note that the apache file 1330 generates a conf file dynamically, and we should switch to 1331 using the same static conf file that the regular run-webkit-tests 1332 uses, and we can also use the same httpd2.pem file. 1333 1334 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added. 1335 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added. 1336 - scripts to generate the JSON layout test dashboard and the 1337 flakiness dashboard 1338 * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added. 1339 - default configuration for LigHTTPd (used on Windows) 1340 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added. 1341 - utility class that implements progress bars on the console to 1342 be displayed while the tests are running 1343 * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added. 1344 - various routines for manipulating paths and URIs 1345 * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added. 1346 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added. 1347 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added. 1348 * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added. 1349 - platform-specific aspects of the drivers (binary names, paths, 1350 process control, etc.) 1351 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added. 1352 - code for parsing the 'test_expectations.txt' file to determine 1353 which tests are expected to fail (and how) on which platforms 1354 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added. 1355 - code for handling different kinds of failures (generating output 1356 in the results, etc.) 1357 * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added. 1358 - code to gather the lists of tests 1359 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added. 1360 - code to actually execute tests via TestShell and process 1361 the output 1362 * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added. 1363 - scripts to start and stop the pywebsocket server 1364 13652010-01-29 Dirk Pranke <dpranke@chromium.org> 1366 1367 Reviewed by Eric Seidel. 1368 1369 Check in a copy of the simplejson library; it will be used by 1370 the Chromium port of run-webkit-tests. 1371 1372 https://bugs.webkit.org/show_bug.cgi?id=31498 1373 1374 * simplejson: Added. 1375 * simplejson/LICENSE.txt: Added. 1376 * simplejson/README.txt: Added. 1377 * simplejson/__init__.py: Added. 1378 * simplejson/_speedups.c: Added. 1379 (ascii_escape_char): 1380 (ascii_escape_unicode): 1381 (ascii_escape_str): 1382 (py_encode_basestring_ascii): 1383 (init_speedups): 1384 * simplejson/decoder.py: Added. 1385 * simplejson/encoder.py: Added. 1386 * simplejson/jsonfilter.py: Added. 1387 * simplejson/scanner.py: Added. 1388 13892010-01-29 Dirk Pranke <dpranke@chromium.org> 1390 1391 No review 1392 1393 Add myself to the committers list 1394 1395 * Scripts/webkitpy/committers.py: 1396 13972010-01-29 Jeremy Orlow <jorlow@chromium.org> 1398 1399 Reviewed by Dimitri Glazkov. 1400 1401 A first step towards the Indexed Database API 1402 https://bugs.webkit.org/show_bug.cgi?id=34342 1403 1404 Add indexed database API. 1405 1406 * Scripts/build-webkit: 1407 14082010-01-29 Andras Becsi <abecsi@webkit.org> 1409 1410 Reviewed by Alexey Proskuryakov. 1411 1412 Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used. 1413 This fixes a regression introduced in r53559. 1414 1415 https://bugs.webkit.org/show_bug.cgi?id=34336 1416 1417 * Scripts/webkitperl/httpd.pm: 1418 14192010-01-28 Jon Honeycutt <jhoneycutt@apple.com> 1420 1421 MSAA: Crash when posting a notification for a detached object 1422 1423 https://bugs.webkit.org/show_bug.cgi?id=34309 1424 <rdar://problem/7409759> 1425 1426 Reviewed by Darin Adler. 1427 1428 * DumpRenderTree/AccessibilityController.h: 1429 Declare new functions. Add new members to store the event hook and the 1430 mapping of accessibility elements to their JS callbacks. 1431 1432 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 1433 (AccessibilityController::notificationReceived): 1434 Stubbed. 1435 (AccessibilityController::addNotificationListener): 1436 Stubbed. 1437 1438 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 1439 (AccessibilityController::notificationReceived): 1440 Stubbed. 1441 (AccessibilityController::addNotificationListener): 1442 Stubbed. 1443 1444 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 1445 (AccessibilityController::AccessibilityController): 1446 Initialize the event hook. 1447 (AccessibilityController::~AccessibilityController): 1448 Remove the event hook. Unprotect all of the JS functions that are stored 1449 in the map. 1450 (logEventProc): 1451 Clean-up a variable. 1452 (stringEvent): 1453 Return a string description of the MSAA event code. 1454 (notificationListenerProc): 1455 Get the accessible object from the event, and query it for IAccessible. 1456 Call the AccessibilityController's notificationReceived(). 1457 (comparableObject): 1458 Use QueryService to obtain the IAccessibleComparable for the 1459 IServiceProvider. 1460 (AccessibilityController::notificationReceived): 1461 Iterate the map of objects that have registered for notification 1462 callbacks. Query each for IServiceProvider, then use comparableObject() 1463 to get an IAccessibleComparable. If we find an object matching the 1464 notified object, call its callback, passing the event that was received. 1465 (AccessibilityController::addNotificationListener): 1466 If we have not created the event hook, create it. Protect the JS 1467 callback function object, and add the object and its callback to our 1468 map. 1469 1470 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 1471 (AccessibilityUIElement::addNotificationListener): 1472 Call through to the AccessibilityController's addNotificationListener(). 1473 1474 * DumpRenderTree/win/DumpRenderTreeWin.h: 1475 Add an extern declaration for the shared FrameLoadDelegate extern, so we 1476 can access it from AccessibilityController. 1477 1478 * DumpRenderTree/win/FrameLoadDelegate.h: 1479 (FrameLoadDelegate::accessibilityController): 1480 Return the AccessibilityController. 1481 14822010-01-29 Shinichiro Hamaji <hamaji@chromium.org> 1483 1484 Reviewed by Darin Adler. 1485 1486 prepare-ChangeLog outputs useless messages for a nonexistent bug ID 1487 https://bugs.webkit.org/show_bug.cgi?id=34313 1488 1489 * Scripts/prepare-ChangeLog: 1490 14912010-01-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 1492 1493 Rubberstamped by Simon Hausmann. 1494 1495 [Qt] Separate implementation from class definition. 1496 1497 * QtLauncher/main.cpp: 1498 (LauncherWindow::webView): 1499 (LauncherWindow::LauncherWindow): 1500 (LauncherWindow::~LauncherWindow): 1501 (LauncherWindow::keyPressEvent): 1502 (LauncherWindow::grabZoomKeys): 1503 (LauncherWindow::sendTouchEvent): 1504 (LauncherWindow::eventFilter): 1505 (LauncherWindow::loadStarted): 1506 (LauncherWindow::loadFinished): 1507 (LauncherWindow::showLinkHover): 1508 (LauncherWindow::zoomIn): 1509 (LauncherWindow::zoomOut): 1510 (LauncherWindow::resetZoom): 1511 (LauncherWindow::toggleZoomTextOnly): 1512 (LauncherWindow::print): 1513 (LauncherWindow::screenshot): 1514 (LauncherWindow::setEditable): 1515 (LauncherWindow::dumpHtml): 1516 (LauncherWindow::selectElements): 1517 (LauncherWindow::setTouchMocking): 1518 (LauncherWindow::newWindow): 1519 (LauncherWindow::setupUI): 1520 15212010-01-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 1522 1523 Reviewed by Ariya Hidayat. 1524 1525 [Qt] On Maemo5, a click/touch in the location bar (when unfocused) 1526 should result in all text selected. 1527 1528 * QtLauncher/locationedit.cpp: 1529 (LocationEdit::focusInEvent): 1530 * QtLauncher/locationedit.h: 1531 15322010-01-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 1533 1534 Reviewed by Ariya Hidayat. 1535 1536 [Qt] Show progress reaching 100% for loads. 1537 1538 * QtLauncher/locationedit.cpp: 1539 (LocationEdit::LocationEdit): 1540 (LocationEdit::setProgress): 1541 (LocationEdit::reset): 1542 (LocationEdit::paintEvent): 1543 * QtLauncher/locationedit.h: 1544 15452010-01-29 Andreas Kling <andreas.kling@nokia.com> 1546 1547 Reviewed by Kenneth Rohde Christiansen. 1548 1549 [Qt] Disable the QtLauncher statusbar on Maemo 1550 1551 https://bugs.webkit.org/show_bug.cgi?id=34330 1552 1553 * QtLauncher/main.cpp: 1554 (LauncherWindow::showLinkHover): 1555 (LauncherWindow::selectElements): 1556 15572010-01-29 Andreas Kling <andreas.kling@nokia.com> 1558 1559 Reviewed by Kenneth Rohde Christiansen. 1560 1561 [Qt] Display page loading progress inside the QtLauncher location bar 1562 1563 https://bugs.webkit.org/show_bug.cgi?id=34210 1564 1565 * QtLauncher/QtLauncher.pro: 1566 * QtLauncher/locationedit.cpp: Added. 1567 (LocationEdit::LocationEdit): 1568 (LocationEdit::setProgress): 1569 (LocationEdit::paintEvent): 1570 * QtLauncher/locationedit.h: Added. 1571 * QtLauncher/mainwindow.cpp: 1572 (MainWindow::buildUI): 1573 * QtLauncher/mainwindow.h: 1574 15752010-01-29 Andreas Kling <andreas.kling@nokia.com> 1576 1577 Reviewed by Kenneth Rohde Christiansen. 1578 1579 [Qt] Add support for Maemo zoom keys in QtLauncher 1580 1581 https://bugs.webkit.org/show_bug.cgi?id=34160 1582 1583 * QtLauncher/main.cpp: 1584 (LauncherWindow::LauncherWindow): 1585 (LauncherWindow::~LauncherWindow): 1586 (LauncherWindow::keyPressEvent): 1587 (LauncherWindow::grabZoomKeys): 1588 15892010-01-29 Benjamin Poulain <benjamin.poulain@nokia.com> 1590 1591 Reviewed by Kenneth Rohde Christiansen. 1592 1593 [Qt] Implement the display() method of the layout test controller 1594 https://bugs.webkit.org/show_bug.cgi?id=34258 1595 1596 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 1597 (WebCore::DumpRenderTree::DumpRenderTree): 1598 (WebCore::DumpRenderTree::showPage): 1599 (WebCore::DumpRenderTree::hidePage): 1600 * DumpRenderTree/qt/DumpRenderTreeQt.h: 1601 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 1602 (LayoutTestController::reset): 1603 (LayoutTestController::display): 1604 * DumpRenderTree/qt/LayoutTestControllerQt.h: 1605 16062010-01-28 Kevin Ollivier <kevino@theolliviers.com> 1607 1608 [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation 1609 implements pthread_t in a way that makes it impossible to check its validity, 1610 which is needed by ThreadingPthreads.cpp. 1611 1612 * DumpRenderTree/wscript: 1613 * wx/build/settings.py: 1614 16152010-01-28 Andras Becsi <abecsi@webkit.org> 1616 1617 Adding myself to the committer list. No review needed. 1618 1619 * Scripts/webkitpy/committers.py: 1620 16212010-01-28 Hayato Ito <hayato@chromium.org> 1622 1623 Reviewed by David Levin. 1624 1625 Remove NULL char from input JS file because 'grep' fails if the file contains NULL char. 1626 1627 https://bugs.webkit.org/show_bug.cgi?id=34252 1628 1629 * Scripts/make-script-test-wrappers: 1630 16312010-01-28 Kevin Ollivier <kevino@theolliviers.com> 1632 1633 [wx] Build fix after removal of the zlib image decoder. 1634 1635 * wx/build/settings.py: 1636 16372010-01-28 Csaba Osztrogonác <ossy@webkit.org> 1638 1639 [Qt] Unreviewed, roll out r54000. 1640 1641 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 1642 (WebCore::DumpRenderTree::DumpRenderTree): 1643 * DumpRenderTree/qt/DumpRenderTreeQt.h: 1644 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 1645 (LayoutTestController::reset): 1646 * DumpRenderTree/qt/LayoutTestControllerQt.h: 1647 (LayoutTestController::display): 1648 16492010-01-28 Benjamin Poulain <benjamin.poulain@nokia.com> 1650 1651 Reviewed by Kenneth Rohde Christiansen. 1652 1653 [Qt] Implement the display() method of the layout test controller 1654 https://bugs.webkit.org/show_bug.cgi?id=34258 1655 1656 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 1657 (WebCore::DumpRenderTree::DumpRenderTree): 1658 (WebCore::DumpRenderTree::showPage): 1659 (WebCore::DumpRenderTree::hidePage): 1660 * DumpRenderTree/qt/DumpRenderTreeQt.h: 1661 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 1662 (LayoutTestController::reset): 1663 (LayoutTestController::display): 1664 * DumpRenderTree/qt/LayoutTestControllerQt.h: 1665 16662010-01-28 Chris Jerdonek <cjerdonek@webkit.org> 1667 1668 Reviewed by Shinichiro Hamaji. 1669 1670 Eliminated the filename parameter from functions in 1671 check-webkit-style's cpp.py where it is no longer used. 1672 1673 https://bugs.webkit.org/show_bug.cgi?id=34249 1674 1675 * Scripts/webkitpy/style/processors/cpp.py: 1676 - Reduced number of occurrences of "filename" variable from 1677 approximately 200 to 120. 1678 1679 * Scripts/webkitpy/style/processors/cpp_unittest.py: 1680 - Refactored unit tests as necessary to accommodate changes to cpp.py. 1681 - Fixed bug in CppStyleTestBase.perform_include_what_you_use() 1682 where the incorrect file extension was getting passed to 1683 cpp_style.check_language(). 1684 16852010-01-28 Chris Jerdonek <cjerdonek@webkit.org> 1686 1687 Reviewed by Shinichiro Hamaji. 1688 1689 In check-webkit-style, eliminated the dependency of 1690 processors/cpp_unittest.py on checker.py. 1691 1692 https://bugs.webkit.org/show_bug.cgi?id=34205 1693 1694 * Scripts/webkitpy/style/checker.py: 1695 - Addressed FIXME by removing STYLE_CATEGORIES data. 1696 - Added style_categories(). 1697 1698 * Scripts/webkitpy/style/checker_unittest.py: 1699 - Minor changes. 1700 1701 * Scripts/webkitpy/style/processors/cpp.py: 1702 - Added categories attribute to CppProcessor class (data 1703 was originally checker.STYLE_CATEGORIES). 1704 1705 * Scripts/webkitpy/style/processors/cpp_unittest.py: 1706 - Addressed FIXME by eliminating "import" from checker.py. 1707 17082010-01-28 Anton Muhin <antonm@chromium.org> 1709 1710 Reviewed by Shinichiro Hamaji. 1711 1712 Improve treatment of conditions and rest of the line for if, else, switch and alikes 1713 https://bugs.webkit.org/show_bug.cgi?id=34173 1714 1715 * Scripts/webkitpy/style/cpp_style.py: 1716 * Scripts/webkitpy/style/cpp_style_unittest.py: 1717 17182010-01-28 Joe Mason <jmason@rim.com> 1719 1720 Reviewed by Adam Barth. 1721 1722 Limit login retries to 5 1723 https://bugs.webkit.org/show_bug.cgi?id=34193 1724 1725 * Scripts/webkitpy/bugzilla.py: 1726 17272010-01-27 Martin Robinson <mrobinson@webkit.org> 1728 1729 Adding myself to the committer list. No review necessary. 1730 1731 * Scripts/webkitpy/committers.py: 1732 17332010-01-27 George Wright <gwright@rim.com> 1734 1735 Reviewed by Adam Treat. 1736 1737 https://bugs.webkit.org/show_bug.cgi?id=34216 1738 1739 Add missing include for wtf/Platform.h 1740 1741 * DumpRenderTree/AccessibilityController.h: 1742 17432010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org> 1744 1745 Reviewed by Kenneth Rohde Christiansen. 1746 1747 [Qt] DRT Provide worker thread ability to track counters 1748 https://bugs.webkit.org/show_bug.cgi?id=34221 1749 1750 Implement workerThreadCount() in LayoutTestController of Qt DRT 1751 1752 Tests: 1753 fast/workers/dedicated-worker-lifecycle.html 1754 fast/workers/shared-worker-frame-lifecycle.html 1755 fast/workers/shared-worker-lifecycle.html 1756 fast/workers/worker-lifecycle.html 1757 1758 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 1759 (LayoutTestController::workerThreadCount): 1760 * DumpRenderTree/qt/LayoutTestControllerQt.h: 1761 17622010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 1763 1764 Rubberstamped by Simon Hausmann. 1765 1766 [Qt] QtLauncher refactoring: 1767 1768 Make the LauncherWindow depend less on the view, so that more 1769 code can be shared in near future. 1770 1771 * QtLauncher/main.cpp: 1772 (LauncherWindow::sendTouchEvent): 1773 (LauncherWindow::loadFinished): 1774 (LauncherWindow::zoomIn): 1775 (LauncherWindow::zoomOut): 1776 (LauncherWindow::resetZoom): 1777 (LauncherWindow::toggleZoomTextOnly): 1778 (LauncherWindow::dumpHtml): 1779 (LauncherWindow::selectElements): 1780 (LauncherWindow::setupUI): 1781 17822010-01-27 Kinuko Yasuda <kinuko@chromium.org> 1783 1784 Reviewed by Eric Seidel. 1785 1786 Correctly handle the KeyLocation argument that has been introduced 1787 recently to test location-dependent key events in EventSender.keyDown. 1788 http://bugs.webkit.org/show_bug.cgi?id=28247 1789 1790 Test: fast/events/keydown-numpad-keys.html 1791 1792 * DumpRenderTree/gtk/EventSender.cpp: 1793 (keyDownCallback): 1794 17952010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 1796 1797 Rubberstamped by Simon Hausmann. 1798 1799 [Qt] QtLauncher refactoring: 1800 1801 Move out code from the MainWindow (renamed to LauncherWindow) 1802 that is not depending on the view, and add it to a new class 1803 called MainWindow. 1804 1805 * QtLauncher/QtLauncher.pro: 1806 * QtLauncher/main.cpp: 1807 (LauncherWindow::LauncherWindow): 1808 (LauncherWindow::eventFilter): 1809 (LauncherWindow::loadStarted): 1810 (LauncherWindow::loadFinished): 1811 (LauncherWindow::newWindow): 1812 (LauncherWindow::setupUI): 1813 (WebPage::createWindow): 1814 (main): 1815 * QtLauncher/mainwindow.cpp: Added. 1816 (MainWindow::MainWindow): 1817 (MainWindow::buildUI): 1818 (MainWindow::page): 1819 (MainWindow::setAddressUrl): 1820 (MainWindow::addCompleterEntry): 1821 (MainWindow::load): 1822 (MainWindow::changeLocation): 1823 (MainWindow::openFile): 1824 * QtLauncher/mainwindow.h: Added. 1825 18262010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 1827 1828 Rubberstamped by Simon Hausmann. 1829 1830 [Qt] QtLauncher, coding style fixes. 1831 1832 * QtLauncher/main.cpp: 1833 (MainWindow::MainWindow): 1834 (MainWindow::sendTouchEvent): 1835 (MainWindow::eventFilter): 1836 (MainWindow::loadURL): 1837 (MainWindow::setupUI): 1838 (WebPage::createPlugin): 1839 18402010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 1841 1842 Rubberstamped by Simon Hausmann. 1843 1844 [Qt] QtLauncher refactoring, separating the webview and 1845 adding a QGraphicsWebView based version. 1846 1847 * QtLauncher/QtLauncher.pro: 1848 * QtLauncher/main.cpp: 1849 (MainWindow::MainWindow): 1850 * QtLauncher/webpage.h: 1851 * QtLauncher/webview.cpp: Added. 1852 (createContextMenu): 1853 (WebViewGraphicsBased::mousePressEvent): 1854 (WebViewTraditional::mousePressEvent): 1855 (WebViewGraphicsBased::contextMenuEvent): 1856 (WebViewTraditional::contextMenuEvent): 1857 * QtLauncher/webview.h: Added. 1858 (WebViewGraphicsBased::WebViewGraphicsBased): 1859 (WebViewTraditional::WebViewTraditional): 1860 18612010-01-27 Alexander Pavlov <apavlov@chromium.org> 1862 1863 Adding myself as committer. No review necessary. 1864 1865 * Scripts/webkitpy/committers.py: 1866 18672010-01-27 Eric Seidel <eric@webkit.org> 1868 1869 Reviewed by Darin Adler. 1870 1871 webkit-patch needs an open-bugs command 1872 https://bugs.webkit.org/show_bug.cgi?id=30793 1873 1874 * Scripts/test-webkitpy: import OpenBugsTest 1875 * Scripts/webkit-patch: import OpenBugs 1876 * Scripts/webkitpy/commands/download_unittest.py: don't import unittest 1877 * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto 1878 * Scripts/webkitpy/commands/queries_unittest.py: ditto 1879 * Scripts/webkitpy/commands/queues_unittest.py: ditto 1880 * Scripts/webkitpy/commands/upload_unittest.py: ditto 1881 * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called. 1882 18832010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 1884 1885 Rubberstamped by Simon Hausmann 1886 1887 [Qt] QtLauncher refactoring, separating utility methods. 1888 1889 * QtLauncher/QtLauncher.pro: 1890 * QtLauncher/main.cpp: 1891 * QtLauncher/utils.cpp: Added. 1892 (urlFromUserInput): 1893 * QtLauncher/utils.h: Added. 1894 18952010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 1896 1897 Rubberstamped by Simon Hausmann 1898 1899 [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy. 1900 1901 * QtLauncher/main.cpp: 1902 (MainWindow::MainWindow): 1903 * QtLauncher/webpage.cpp: 1904 (WebPage::WebPage): 1905 (WebPage::applyProxy): 1906 * QtLauncher/webpage.h: 1907 19082010-01-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 1909 1910 Reviewed by Tor Arne Vestbø. 1911 1912 [Qt] Corrects debug build of DumpRenderTree on Windows. 1913 1914 * DumpRenderTree/qt/DumpRenderTree.pro: 1915 19162010-01-26 Daniel Bates <dbates@webkit.org> 1917 1918 Reviewed by Adam Barth. 1919 1920 https://bugs.webkit.org/show_bug.cgi?id=34070 1921 1922 Moves the try/catch for OSError exceptions in Executive.run_command 1923 to Credentials.read_credentials() so that the unit test 1924 webkitpy.scm_unittest.SCMClassTests.test_error_handlers can 1925 assert that Executive.run_command throws an OSError exception. 1926 1927 * Scripts/webkitpy/credentials.py: 1928 * Scripts/webkitpy/executive.py: Moved try/catch for OSError to 1929 method Credentials.read_credentials(). 1930 * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer 1931 apply: test_run_command_with_bad_command_check_return_code and 1932 test_run_command_with_bad_command_check_calls_error_handler. Added new 1933 test to assert that run_command throws OSError exceptions. 1934 19352010-01-26 Diego Gonzalez <diego.gonzalez@openbossa.org> 1936 1937 Reviewed by Kenneth Rohde Christiansen. 1938 1939 [Qt] DRT WebHistory support 1940 https://bugs.webkit.org/show_bug.cgi?id=34167 1941 1942 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 1943 (LayoutTestController::reset): 1944 (LayoutTestController::webHistoryItemCount): 1945 (LayoutTestController::keepWebHistory): 1946 * DumpRenderTree/qt/LayoutTestControllerQt.h: 1947 19482010-01-26 Kent Tamura <tkent@chromium.org> 1949 1950 Reviewed by Eric Seidel. 1951 1952 [Win] Add modifiers parameter support to Windows DumpRenderTree 1953 https://bugs.webkit.org/show_bug.cgi?id=34068 1954 1955 Add support for functional name modifiers; "addSelectionKey" and 1956 "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown() 1957 and eventSender.mouseUp(). 1958 This change is similar to r53498 for Mac. 1959 1960 * DumpRenderTree/win/EventSender.cpp: 1961 (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM. 1962 (mouseDownCallback): Call buidlModifiersFlags(). 1963 (mouseUpCallback): ditto. 1964 (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey". 1965 19662010-01-26 Chris Jerdonek <cjerdonek@webkit.org> 1967 1968 Reviewed by Eric Seidel. 1969 1970 The Python autoinstall cache directory now only gets created 1971 in the directory containing autoinstall.py. 1972 1973 https://bugs.webkit.org/show_bug.cgi?id=33365 1974 1975 * Scripts/webkitpy/autoinstall.py: 1976 - Also added a README file to the cache directory saying 1977 where it came from. 1978 19792010-01-26 Chris Jerdonek <cjerdonek@webkit.org> 1980 1981 Reviewed by Eric Seidel. 1982 1983 Moved the check-webkit-style processors into a new 1984 webkitpy/style/processors directory. 1985 1986 https://bugs.webkit.org/show_bug.cgi?id=34060 1987 1988 * Scripts/webkitpy/style/checker.py: 1989 * Scripts/webkitpy/style/checker_unittest.py: 1990 * Scripts/webkitpy/style/cpp_style.py: Removed. 1991 * Scripts/webkitpy/style/cpp_style_unittest.py: Removed. 1992 * Scripts/webkitpy/style/processors: Added. 1993 * Scripts/webkitpy/style/processors/__init__.py: Added. 1994 * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py. 1995 * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py. 1996 * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py. 1997 * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py. 1998 * Scripts/webkitpy/style/text_style.py: Removed. 1999 * Scripts/webkitpy/style/text_style_unittest.py: Removed. 2000 * Scripts/webkitpy/style/unittests.py: 2001 20022010-01-26 Kevin Ollivier <kevino@theolliviers.com> 2003 2004 [wx] Build fix, make sure stub function returns a value. 2005 2006 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 2007 (LayoutTestController::counterValueForElementById): 2008 20092010-01-26 Steve Falkenburg <sfalken@apple.com> 2010 2011 Reviewed by Oliver Hunt. 2012 2013 Windows build references non-existent include paths 2014 https://bugs.webkit.org/show_bug.cgi?id=34175 2015 2016 * DumpRenderTree/win/DumpRenderTree.vcproj: 2017 * DumpRenderTree/win/ImageDiff.vcproj: 2018 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 2019 20202010-01-26 Kenneth Rohde Christiansen <kenneth@webkit.org> 2021 2022 Reviewed by Ariya Hidayat. 2023 2024 [Qt] Separating out the UrlLoader from the QtLauncher in it's 2025 own implementation and header file. 2026 2027 * QtLauncher/main.cpp: 2028 (main): 2029 * QtLauncher/urlloader.cpp: Added. 2030 (UrlLoader::UrlLoader): 2031 (UrlLoader::loadNext): 2032 (UrlLoader::init): 2033 (UrlLoader::getUrl): 2034 * QtLauncher/urlloader.h: Added. 2035 20362010-01-25 Chris Jerdonek <cjerdonek@webkit.org> 2037 2038 Reviewed by Shinichiro Hamaji. 2039 2040 Refactored check-webkit-style by removing the file path 2041 parameter from the style error handler functions. 2042 2043 https://bugs.webkit.org/show_bug.cgi?id=34031 2044 2045 * Scripts/webkitpy/style/checker.py: 2046 - Added _default_style_error_handler() to StyleChecker class. 2047 - Moved handle_style_error() to inside _default_style_error_handler(). 2048 2049 * Scripts/webkitpy/style/checker_unittest.py: 2050 - Removed file path from calls to error handler. 2051 2052 * Scripts/webkitpy/style/cpp_style.py: 2053 - Removed file path from calls to error handler. 2054 2055 * Scripts/webkitpy/style/cpp_style_unittest.py: 2056 - Removed file path from calls to error handler. 2057 2058 * Scripts/webkitpy/style/text_style.py: 2059 - Removed file path from calls to error handler. 2060 2061 * Scripts/webkitpy/style/text_style_unittest.py: 2062 - Removed file path from calls to error handler. 2063 20642010-01-25 Jeremy Orlow <jorlow@chromium.org> 2065 2066 Adding myself as reviewer. No review necessary. 2067 2068 * Scripts/webkitpy/committers.py: 2069 20702010-01-25 Chris Jerdonek <cjerdonek@webkit.org> 2071 2072 Reviewed by Adam Barth. 2073 2074 Improved prepare-ChangeLog so that it preserves the relative 2075 indentation of a git commit message. 2076 2077 https://bugs.webkit.org/show_bug.cgi?id=34058 2078 2079 * Scripts/prepare-ChangeLog: 2080 - Also adjusted the script so that it does not add white 2081 space characters to empty lines. 2082 20832010-01-24 Eric Seidel <eric@webkit.org> 2084 2085 No review, rolling out r53763. 2086 http://trac.webkit.org/changeset/53763 2087 https://bugs.webkit.org/show_bug.cgi?id=33895 2088 2089 Broke 20+ tests on Windows. 2090 2091 * Scripts/run-webkit-tests: 2092 * Scripts/webkitdirs.pm: 2093 20942010-01-24 Adam Barth <abarth@webkit.org> 2095 2096 Rubber stamped by Eric Seidel. 2097 2098 More pep8 compliance. 2099 2100 * Scripts/webkitpy/mock_bugzillatool.py: 2101 21022010-01-24 Adam Barth <abarth@webkit.org> 2103 2104 Rubber stamped by Eric Seidel. 2105 2106 More pep8 compliance. 2107 2108 * Scripts/webkitpy/executive.py: 2109 * Scripts/webkitpy/grammar.py: 2110 21112010-01-24 Adam Barth <abarth@webkit.org> 2112 2113 Rubber stamped by Eric Seidel. 2114 2115 More pep8 compliance. 2116 2117 * Scripts/webkitpy/comments.py: 2118 * Scripts/webkitpy/committers.py: 2119 * Scripts/webkitpy/credentials.py: 2120 21212010-01-24 Adam Barth <abarth@webkit.org> 2122 2123 Rubber stamped by Eric Seidel. 2124 2125 Make changelogs.py pass pep8. 2126 2127 * Scripts/webkitpy/changelogs.py: 2128 21292010-01-23 Kenneth Rohde Christiansen <kenneth@webkit.org> 2130 2131 [Qt] Unreviewed build fix 2132 2133 * QtLauncher/QtLauncher.pro: 2134 * QtLauncher/webinspector.h: 2135 21362010-01-23 Kenneth Rohde Christiansen <kenneth@webkit.org> 2137 2138 Rubberstamped by Simon Hausmann. 2139 2140 [Qt] Move the WebInspector class to it's own header file. 2141 2142 * QtLauncher/main.cpp: 2143 * QtLauncher/webinspector.h: Added. 2144 (WebInspector::WebInspector): 2145 (WebInspector::showEvent): 2146 (WebInspector::hideEvent): 2147 21482010-01-23 Robert Hogan <robert@roberthogan.net> 2149 2150 Reviewed by Kenneth Rohde Christiansen. 2151 2152 Qt DRT: respect window.close() and window.closed() 2153 2154 Qt DRT needs to maintain a correct count of open windows 2155 for windowCount(). It also needs to delete windows that 2156 have been closed by window.close(). 2157 2158 This fixes the following tests: 2159 2160 plugins/destroy-during-npp-new.html 2161 fast/dom/Document/early-document-access.html 2162 fast/dom/Window/window-early-properties.html 2163 fast/events/open-window-from-another-frame.html 2164 fast/events/popup-blocking-click-in-iframe.html 2165 2166 https://bugs.webkit.org/show_bug.cgi?id=32953 2167 2168 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 2169 (WebCore::DumpRenderTree::DumpRenderTree): 2170 (WebCore::DumpRenderTree::createWindow): 2171 (WebCore::DumpRenderTree::windowCloseRequested): 2172 * DumpRenderTree/qt/DumpRenderTreeQt.h: 2173 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 2174 (LayoutTestController::maybeDump): 2175 21762010-01-23 Dan Bernstein <mitz@apple.com> 2177 2178 Reviewed by Mark Rowe. 2179 2180 Added a user default for specifying a fallback frameworks path in case 2181 the bundle does not contain frameworks for the current Mac OS X version. 2182 2183 * WebKitLauncher/main.m: 2184 (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary 2185 keyed by the FallbackSystemVersions user default and returns it. 2186 (main): If a frameworks directory for the current system version is not found, 2187 try the fallback. 2188 21892010-01-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 2190 2191 Reviewed by Simon Hausmann. 2192 2193 Make run-webkit-tests work under Cygwin for the Qt port 2194 2195 setPathForRunningWebKitApp() is implemented for the Qt port 2196 by using qmake to query for the location of the Qt libraries. 2197 2198 This requires the original environment (%ENV) to be untouched, 2199 so launchWithCurrentEnv() was refactored to launchWithEnv(), 2200 and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV 2201 instead. This has the added benefit of getting rid of the temp 2202 variables used for storing the current env. 2203 2204 openDumpTool() is also refactored a bit into platform-spesific, 2205 port-spesific, and generic environment variables. 2206 2207 Checks for undef was added a few places to fix Perl concat 2208 warnings when run-webkit-tests is aborted. 2209 2210 https://bugs.webkit.org/show_bug.cgi?id=33895 2211 2212 * Scripts/run-webkit-tests: 2213 * Scripts/webkitdirs.pm: 2214 22152010-01-22 Kevin Watters <kevinwatters@gmail.com> 2216 2217 Reviewed by Kevin Ollivier. 2218 2219 [wx] Remove the Bakefile build system, which is no longer being used. 2220 2221 https://bugs.webkit.org/show_bug.cgi?id=34022 2222 2223 * DumpRenderTree/wx/DumpRenderTree.bkl: Removed. 2224 * wx/browser/browser.bkl: Removed. 2225 * wx/build-wxwebkit: Removed. 2226 22272010-01-22 Gustavo Noronha Silva <gns@gnome.org> 2228 2229 Reviewed by Simon Fraser. 2230 2231 Reset zoom level to 1.0 when resetting view state. This is causing 2232 many tests to fail after svg/custom/text-zoom.xhtml changes the 2233 zoom level. 2234 2235 * DumpRenderTree/gtk/DumpRenderTree.cpp: 2236 (resetDefaultsToConsistentValues): 2237 22382010-01-22 Steve Falkenburg <sfalken@apple.com> 2239 2240 Reviewed by Darin Adler. 2241 2242 https://bugs.webkit.org/show_bug.cgi?id=34025 2243 Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets. 2244 2245 * Scripts/build-webkit: 2246 22472010-01-22 Adam Barth <abarth@webkit.org> 2248 2249 Unreviewed. Arg. Someone renamed limit to output_limit on me. 2250 2251 * Scripts/webkitpy/commands/queues.py: 2252 22532010-01-22 Adam Barth <abarth@webkit.org> 2254 2255 Rubber stamped by Eric Seidel. 2256 2257 Make __init__.py and buildbot.py pass pep8 style checker. 2258 2259 * Scripts/webkitpy/__init__.py: 2260 * Scripts/webkitpy/buildbot.py: 2261 22622010-01-21 Joe Mason <jmason@rim.com> 2263 2264 Reviewed by Adam Barth. 2265 2266 webkit-patch should retry on invalid password 2267 https://bugs.webkit.org/show_bug.cgi?id=33955 2268 2269 Ask for bugs.webkit.org authentication in a loop. 2270 2271 * Scripts/webkitpy/bugzilla.py: 2272 22732010-01-22 Adam Barth <abarth@webkit.org> 2274 2275 Unreviewed. Don't call seek on a NoneType. 2276 2277 * Scripts/webkitpy/statusserver.py: 2278 22792010-01-22 Petri Latvala <petri.latvala@nomovok.com> 2280 2281 Reviewed by David Levin. 2282 2283 check-webkit-style breaks on files with unknown types 2284 https://bugs.webkit.org/show_bug.cgi?id=34001 2285 2286 For files with type FileType.NONE, dispatch_processor returns None. 2287 2288 * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None. 2289 22902010-01-22 Adam Barth <abarth@webkit.org> 2291 2292 Reviewed by Eric Seidel. 2293 2294 Make bugzilla.py and webkitport.py conform to pep8 2295 https://bugs.webkit.org/show_bug.cgi?id=34015 2296 2297 This patch makes webkitport.py and bugzilla.py mostly conform to PEP8 2298 style as enforced by pep8.py. I wasn't able to get rid of all the 2299 errors because I'm not sure how to wrap some lines properly. Also, 2300 there are a few deprication errors that I couldn't resolve easily. 2301 However, this is a massive improvement in compliance. 2302 2303 * Scripts/webkitpy/bugzilla.py: 2304 * Scripts/webkitpy/webkitport.py: 2305 23062010-01-22 Adam Barth <abarth@webkit.org> 2307 2308 Reviewed by Darin Adler. 2309 2310 Limit length of EWS results to 5MB 2311 https://bugs.webkit.org/show_bug.cgi?id=34016 2312 2313 Hopefully this will fix the bug where the results link doesn't appear. 2314 Our current theory is that the results blob is too big and the server 2315 is rejecting the request with a 500 error. That causes us to re-try 2316 the post, but when we re-try the StringIO buffer has its seek pointer 2317 at the end. 2318 2319 * Scripts/webkitpy/commands/queues.py: 2320 * Scripts/webkitpy/statusserver.py: 2321 23222010-01-22 Chris Jerdonek <cjerdonek@webkit.org> 2323 2324 Reviewed by Adam Barth. 2325 2326 Made check-webkit-style able to check patches when script not 2327 run from source root. Also consolidated external references 2328 to a single file. 2329 2330 https://bugs.webkit.org/show_bug.cgi?id=33791 2331 2332 * Scripts/check-webkit-style: 2333 - Changed to import style_references.py. 2334 2335 * Scripts/webkitpy/style/__init__.py: 2336 - Removed __path__ hack that allowed searching Scripts/ directory. 2337 2338 * Scripts/webkitpy/style/checker.py: 2339 - Changed to import style_references.py. 2340 2341 * Scripts/webkitpy/style_references.py: Added. 2342 23432010-01-22 Dmitry Titov <dimich@chromium.org> 2344 2345 Reviewed by Maciej Stachowiak. 2346 2347 Fix the leak of ThreadIdentifiers in threadMap across threads. 2348 https://bugs.webkit.org/show_bug.cgi?id=32689 2349 2350 Add a new test to verify the ThreadIdentifiers are not reused across threads. 2351 The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially, 2352 waiting for the previous thread to terminate before starting the next. 2353 The treads use WTF::currentThread() in their thread function. Without a fix, this 2354 causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function. 2355 It also starts another thread using WTF. Without the fix, this finds pthread handle from previous 2356 threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle(). 2357 The test practically does not affect the DRT run time because the threads end immediately. 2358 2359 * DumpRenderTree/mac/DumpRenderTree.mm: 2360 (runThread): Test thread function. 2361 (testThreadIdentifierMap): 2362 (dumpRenderTree): 2363 23642010-01-22 Kent Tamura <tkent@chromium.org> 2365 2366 Reviewed by Maciej Stachowiak. 2367 2368 Fix a bug that mouseDown:withModifiers: is never called. 2369 https://bugs.webkit.org/show_bug.cgi?id=33989 2370 2371 * DumpRenderTree/mac/EventSendingController.mm: 2372 (+[EventSendingController isSelectorExcludedFromWebScript:]): 2373 (+[EventSendingController webScriptNameForSelector:]): 2374 23752010-01-22 Kenneth Rohde Christiansen <kenneth@webkit.org> 2376 2377 Rubberstamped by Antti Koivisto. 2378 2379 [Qt] Separate out the WebPage class into it's own 2380 cpp/header files. Also, removed the assumption that 2381 the view is a QWebView, in preparation of a merger 2382 of the two Qt WebKit launchers. 2383 2384 * QtLauncher/QtLauncher.pro: 2385 * QtLauncher/main.cpp: 2386 (WebView::mousePressEvent): 2387 * QtLauncher/webpage.cpp: Added. 2388 (WebPage::supportsExtension): 2389 (WebPage::extension): 2390 (WebPage::acceptNavigationRequest): 2391 (WebPage::openUrlInDefaultBrowser): 2392 * QtLauncher/webpage.h: Added. 2393 (WebPage::WebPage): 2394 23952010-01-21 Chris Jerdonek <cjerdonek@webkit.org> 2396 2397 Reviewed by Shinichiro Hamaji. 2398 2399 Refactored to move file name and file-reading related code 2400 from cpp_style.py and text_style.py to checker.py. 2401 2402 https://bugs.webkit.org/show_bug.cgi?id=33775 2403 2404 * Scripts/check-webkit-style: 2405 - Updates caused by changes to checker.py. 2406 2407 * Scripts/webkitpy/style/checker.py: 2408 - Added SKIPPED_FILES_WITH_WARNING list. 2409 - Added SKIPPED_FILES_WITHOUT_WARNING list. 2410 - Added FileType class. 2411 - Added ProcessorDispatcher class. 2412 - In StyleChecker class: 2413 - Renamed process_patch() to check_patch(). 2414 - Renamed process_file() to check_file(). 2415 - Added _process_file(). 2416 - Related refactoring. 2417 - Addressed check_patch() FIXME to share code with process_file(). 2418 2419 * Scripts/webkitpy/style/checker_unittest.py: 2420 - Added ProcessorDispatcherSkipTest class. 2421 - Added ProcessorDispatcherDispatchTest class. 2422 - Added StyleCheckerCheckFileTest class. 2423 2424 * Scripts/webkitpy/style/cpp_style.py: 2425 - Renamed process_file_data() to _process_lines. 2426 - Removed process_file() (moved logic to checker.py). 2427 - Removed can_handle() (moved logic to checker.py). 2428 - Added CppProcessor class. 2429 - Removed is_exempt() (moved logic to checker.py). 2430 - Added process_file_data() back as a wrapper function. 2431 2432 * Scripts/webkitpy/style/cpp_style_unittest.py: 2433 - Removed test_can_handle(). 2434 - Removed test_is_exempt(). 2435 - Added CppProcessorTest class. 2436 2437 * Scripts/webkitpy/style/text_style.py: 2438 - Added TextProcessor class. 2439 - Removed process_file(). 2440 - Removed can_handle(). 2441 2442 * Scripts/webkitpy/style/text_style_unittest.py: 2443 - Removed test_can_handle(). 2444 - Added TextProcessorTest class. 2445 24462010-01-21 Chris Jerdonek <cjerdonek@webkit.org> 2447 2448 Reviewed by David Kilzer. 2449 2450 Create a unit-tested subroutine to parse patch files created 2451 by svn-create-patch. 2452 2453 https://bugs.webkit.org/show_bug.cgi?id=33475 2454 2455 * Scripts/VCSUtils.pm: 2456 - Added parseDiff(). 2457 - Added parsePatch(). 2458 2459 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added. 2460 - Added unit tests for parseDiff(). 2461 2462 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: 2463 - Total number of tests now computed dynamically. 2464 2465 * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added. 2466 - Added unit tests for parsePatch(). 2467 24682010-01-21 Kevin Ollivier <kevino@theolliviers.com> 2469 2470 [wx] Build fix, add new directory to dir list. 2471 2472 * wx/build/settings.py: 2473 24742010-01-21 Adam Barth <abarth@webkit.org> 2475 2476 Reviewed by Eric Seidel. 2477 2478 Make the EWS transactional 2479 https://bugs.webkit.org/show_bug.cgi?id=33978 2480 2481 Now if the EWS gets interrupted in the middle of processing a patch, 2482 the bots will re-process the patch. 2483 2484 * Scripts/test-webkitpy: 2485 * Scripts/webkitpy/commands/queues.py: 2486 * Scripts/webkitpy/commands/queues_unittest.py: 2487 * Scripts/webkitpy/patchcollection.py: 2488 * Scripts/webkitpy/patchcollection_unittest.py: Added. 2489 24902010-01-21 Adam Barth <abarth@webkit.org> 2491 2492 Unreviewed. Add missing "ago" for style in the status bubble. 2493 2494 * QueueStatusServer/templates/statusbubble.html: 2495 24962010-01-21 Adam Barth <abarth@webkit.org> 2497 2498 Reviewed by David Levin. 2499 2500 [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/ 2501 https://bugs.webkit.org/show_bug.cgi?id=33356 2502 2503 White list unix_hacker_style names in WebKit/gtk/webkit because these 2504 are used in the GTK+ API. 2505 2506 * Scripts/webkitpy/style/cpp_style.py: 2507 * Scripts/webkitpy/style/cpp_style_unittest.py: 2508 25092010-01-21 Diego Gonzalez <diego.gonzalez@openbossa.org> 2510 2511 Reviewed by Kenneth Rohde Christiansen. 2512 2513 [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT 2514 https://bugs.webkit.org/show_bug.cgi?id=33945 2515 2516 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 2517 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 2518 * DumpRenderTree/qt/LayoutTestControllerQt.h: 2519 25202010-01-21 Simon Hausmann <simon.hausmann@nokia.com> 2521 2522 No review, rolling out 53615 as it causes two 2523 crashes on the bot. 2524 2525 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 2526 (WebCore::DumpRenderTree::DumpRenderTree): 2527 (WebCore::DumpRenderTree::createWindow): 2528 * DumpRenderTree/qt/DumpRenderTreeQt.h: 2529 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 2530 (LayoutTestController::maybeDump): 2531 25322010-01-21 Robert Hogan <robert@roberthogan.net> 2533 2534 Reviewed by Simon Hausmann. 2535 2536 Qt DRT: respect window.close() and window.closed() 2537 2538 Qt DRT needs to maintain a correct count of open windows 2539 for windowCount(). It also needs to delete windows that 2540 have been closed by window.close(). 2541 2542 This fixes the following tests: 2543 2544 plugins/destroy-during-npp-new.html 2545 fast/dom/Document/early-document-access.html 2546 fast/dom/Window/window-early-properties.html 2547 fast/events/open-window-from-another-frame.html 2548 fast/events/popup-blocking-click-in-iframe.html 2549 2550 https://bugs.webkit.org/show_bug.cgi?id=32953 2551 2552 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 2553 (WebCore::DumpRenderTree::DumpRenderTree): 2554 (WebCore::DumpRenderTree::createWindow): 2555 (WebCore::DumpRenderTree::windowCloseRequested): 2556 * DumpRenderTree/qt/DumpRenderTreeQt.h: 2557 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 2558 (LayoutTestController::maybeDump): 2559 25602010-01-20 Eric Seidel <eric@webkit.org> 2561 2562 No review, rolling out r53593. 2563 http://trac.webkit.org/changeset/53593 2564 https://bugs.webkit.org/show_bug.cgi?id=33496 2565 2566 Re-rollout this patch, the commit-queue should not have landed 2567 it again, but it did due to land-diff and rollout both not 2568 clearing flags. 2569 2570 * Scripts/webkitpy/commands/early_warning_system.py: 2571 * Scripts/webkitpy/commands/queues.py: 2572 * Scripts/webkitpy/queueengine.py: 2573 * Scripts/webkitpy/scm.py: 2574 * Scripts/webkitpy/scm_unittest.py: 2575 25762010-01-20 Eric Seidel <eric@webkit.org> 2577 2578 Reviewed by Adam Barth. 2579 2580 webkit-commit-queue status page is confusing 2581 https://bugs.webkit.org/show_bug.cgi?id=33496 2582 2583 This should improve the status page by removing more Fail messages. 2584 To do this, I re-factored the CommitQueue and the AbstractReviewQueues 2585 to behave more like one another. This meant moving where the failure reporting was done. 2586 Previously the AbstractReviewQueue always used the parent process to report the error, 2587 while CommitQueue used the subprocess when possible, and the parent only reported errors 2588 that we didn't know how to handle (bugs in the commit-queue itself). 2589 Now the AbstractReviewQueue follow's the commit-queue's model. This got rid of a try-block 2590 in both implementations and required teaching handle_script_error in each to post Fail messages 2591 to the status server instead of calling exit(1). 2592 2593 This will also make the style-queue share more bug posting logic with other queues: 2594 https://bugs.webkit.org/show_bug.cgi?id=33871 2595 2596 * Scripts/webkitpy/commands/early_warning_system.py: 2597 - Don't exit(1) as that will cause the calling queue to also report Fail to the status server. 2598 Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled. 2599 So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure. 2600 _update_status_for_script_error knows how to post the Fail message to the status server. 2601 - Teach _update_status_for_script_error how to post Fail messages to the status server. 2602 * Scripts/webkitpy/commands/queues.py: 2603 - Remove the try block from process_work_item since the caller already has one. 2604 - Only CC watchers on failure to cut down on commit-queue generated mail. 2605 - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item. 2606 - Abstract _format_script_error_output_for_bug to share code between all queues. 2607 - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output. 2608 - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing. 2609 - Move logging out of _can_build_and_test and make the logs explain what revision we're testing. 2610 - handle_script_error now posts Fail instead of the try block in process_work_item handling it. 2611 * Scripts/webkitpy/queueengine.py: 2612 - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing. 2613 * Scripts/webkitpy/scm.py: 2614 - Add new checkout_revision function. 2615 * Scripts/webkitpy/scm_unittest.py: 2616 - Test our new checkout_revision function. 2617 26182010-01-20 Fumitoshi Ukai <ukai@chromium.org> 2619 2620 Reviewed by Alexey Proskuryakov. 2621 2622 WebSocket: Missing Request-URI, when no tralling slash in host 2623 https://bugs.webkit.org/show_bug.cgi?id=33689 2624 2625 Update pywebsocket to 0.4.7.1, which supports alias for resource 2626 name, so that we could test for ws://127.0.0.1:8880 2627 2628 * Scripts/run-webkit-tests: 2629 * Scripts/run-webkit-websocketserver: 2630 * pywebsocket/mod_pywebsocket/dispatch.py: 2631 * pywebsocket/mod_pywebsocket/handshake.py: 2632 * pywebsocket/mod_pywebsocket/standalone.py: 2633 * pywebsocket/setup.py: 2634 * pywebsocket/test/test_dispatch.py: 2635 * pywebsocket/test/test_handshake.py: 2636 26372010-01-20 Eric Seidel <eric@webkit.org> 2638 2639 No review, rolling out r53537. 2640 http://trac.webkit.org/changeset/53537 2641 https://bugs.webkit.org/show_bug.cgi?id=33496 2642 2643 Added a failure condition to the commit-queue and looks to 2644 have broken the EWS bots 2645 2646 * Scripts/webkitpy/commands/early_warning_system.py: 2647 * Scripts/webkitpy/commands/queues.py: 2648 * Scripts/webkitpy/queueengine.py: 2649 * Scripts/webkitpy/scm.py: 2650 * Scripts/webkitpy/scm_unittest.py: 2651 26522010-01-20 Jon Honeycutt <jhoneycutt@apple.com> 2653 2654 MSAA: accSelect() is not implemented 2655 2656 https://bugs.webkit.org/show_bug.cgi?id=33918 2657 <rdar://problem/7436861> 2658 2659 Reviewed by Darin Adler. 2660 2661 * DumpRenderTree/AccessibilityUIElement.cpp: 2662 (takeFocusCallback): 2663 Call the object's takeFocus() function. 2664 (takeSelectionCallback): 2665 Call its takeSelection() function. 2666 (addSelectionCallback): 2667 Call its addSelection() function. 2668 (removeSelectionCallback): 2669 Call its removeSelection() function. 2670 (AccessibilityUIElement::getJSClass): 2671 Add new functions to the JS class definition. 2672 2673 * DumpRenderTree/AccessibilityUIElement.h: 2674 Declare new functions. 2675 2676 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 2677 (AccessibilityUIElement::takeFocus): 2678 Stubbed. 2679 (AccessibilityUIElement::takeSelection): 2680 Stubbed. 2681 (AccessibilityUIElement::addSelection): 2682 Stubbed. 2683 (AccessibilityUIElement::removeSelection): 2684 Stubbed. 2685 2686 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 2687 (AccessibilityUIElement::takeFocus): 2688 Stubbed. 2689 (AccessibilityUIElement::takeSelection): 2690 Stubbed. 2691 (AccessibilityUIElement::addSelection): 2692 Stubbed. 2693 (AccessibilityUIElement::removeSelection): 2694 Stubbed. 2695 2696 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 2697 (AccessibilityUIElement::takeFocus): 2698 Call the object's accSelect() function, passing the appropriate flag. 2699 (AccessibilityUIElement::takeSelection): 2700 Ditto. 2701 (AccessibilityUIElement::addSelection): 2702 Ditto. 2703 (AccessibilityUIElement::removeSelection): 2704 Ditto. 2705 27062010-01-20 Andras Becsi <abecsi@inf.u-szeged.hu> 2707 2708 Reviewed by Alexey Proskuryakov. 2709 2710 Extract Apache handling to httpd.pm module and use the provided functionality 2711 in scripts where Apache is needed. 2712 The module httpd.pm stores the PID of Apache in a variable and cleans up 2713 the PID directory after Apache properly shut down. Catching INT and TERM 2714 signals allows the scripts to close Apache and clean up its PID directory 2715 even if the testing was interrupted. 2716 2717 https://bugs.webkit.org/show_bug.cgi?id=33153 2718 2719 * Scripts/webkitperl/httpd.pm: Added. 2720 * Scripts/run-iexploder-tests: 2721 * Scripts/run-webkit-httpd: 2722 * Scripts/run-webkit-tests: 2723 27242010-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 2725 2726 Reviewed by Simon Hausmann. 2727 2728 [Qt] Make DumpRenderTree build on Windows 2729 2730 * DumpRenderTree/qt/DumpRenderTree.pro: 2731 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 2732 * DumpRenderTree/qt/DumpRenderTreeQt.h: 2733 * DumpRenderTree/qt/main.cpp: 2734 27352010-01-20 Steve Block <steveblock@google.com> 2736 2737 Reviewed by Eric Seidel. 2738 2739 Fix commit bot to land patches in order of the bug last modification date. 2740 https://bugs.webkit.org/show_bug.cgi?id=33395 2741 2742 * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL. 2743 27442010-01-20 Adam Barth <abarth@webkit.org> 2745 2746 Reviewed by Eric Seidel. 2747 2748 Teach check-webkit-style about WebKit/gtk/tests 2749 https://bugs.webkit.org/show_bug.cgi?id=33892 2750 2751 Removes false positives found in 2752 https://bugs.webkit.org/show_bug.cgi?id=30883 2753 2754 * Scripts/webkitpy/style/cpp_style.py: 2755 * Scripts/webkitpy/style/cpp_style_unittest.py: 2756 27572010-01-20 Adam Barth <abarth@webkit.org> 2758 2759 Reviewed by Eric Seidel. 2760 2761 Teach check-webkit-style about QGVLauncher 2762 https://bugs.webkit.org/show_bug.cgi?id=33890 2763 2764 Remove false positives found in 2765 https://bugs.webkit.org/show_bug.cgi?id=33708 2766 2767 * Scripts/webkitpy/style/cpp_style.py: 2768 * Scripts/webkitpy/style/cpp_style_unittest.py: 2769 27702010-01-20 Eric Seidel <eric@webkit.org> 2771 2772 Reviewed by Adam Barth. 2773 2774 webkit-commit-queue status page is confusing 2775 https://bugs.webkit.org/show_bug.cgi?id=33496 2776 2777 This should improve the status page by removing more Fail messages. 2778 To do this, I re-factored the CommitQueue and the AbstractReviewQueues 2779 to behave more like one another. This meant moving where the failure reporting was done. 2780 Previously the AbstractReviewQueue always used the parent process to report the error, 2781 while CommitQueue used the subprocess when possible, and the parent only reported errors 2782 that we didn't know how to handle (bugs in the commit-queue itself). 2783 Now the AbstractReviewQueue follow's the commit-queue's model. This got rid of a try-block 2784 in both implementations and required teaching handle_script_error in each to post Fail messages 2785 to the status server instead of calling exit(1). 2786 2787 This will also make the style-queue share more bug posting logic with other queues: 2788 https://bugs.webkit.org/show_bug.cgi?id=33871 2789 2790 * Scripts/webkitpy/commands/early_warning_system.py: 2791 - Don't exit(1) as that will cause the calling queue to also report Fail to the status server. 2792 Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled. 2793 So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure. 2794 _update_status_for_script_error knows how to post the Fail message to the status server. 2795 - Teach _update_status_for_script_error how to post Fail messages to the status server. 2796 * Scripts/webkitpy/commands/queues.py: 2797 - Remove the try block from process_work_item since the caller already has one. 2798 - Only CC watchers on failure to cut down on commit-queue generated mail. 2799 - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item. 2800 - Abstract _format_script_error_output_for_bug to share code between all queues. 2801 - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output. 2802 - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing. 2803 - Move logging out of _can_build_and_test and make the logs explain what revision we're testing. 2804 - handle_script_error now posts Fail instead of the try block in process_work_item handling it. 2805 * Scripts/webkitpy/queueengine.py: 2806 - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing. 2807 * Scripts/webkitpy/scm.py: 2808 - Add new checkout_revision function. 2809 * Scripts/webkitpy/scm_unittest.py: 2810 - Test our new checkout_revision function. 2811 28122010-01-20 Adam Barth <abarth@webkit.org> 2813 2814 Reviewed by Darin Adler. 2815 2816 Exempt JavaScriptCore/qt/api from style checks 2817 https://bugs.webkit.org/show_bug.cgi?id=33879 2818 2819 Apparently there is a JavaScriptCore API for Qt as well as a WebKit 2820 API. 2821 2822 * Scripts/webkitpy/style/cpp_style.py: 2823 * Scripts/webkitpy/style/cpp_style_unittest.py: 2824 28252010-01-19 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 2826 2827 Reviewed by Simon Hausmann. 2828 2829 [Qt] Don't use QSocketNotifier in the DRT for reading stdin 2830 2831 QSocketNotifier is not available on Windows. Instead we read 2832 stdin synchronously after each test using signals and slots. 2833 2834 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 2835 * DumpRenderTree/qt/DumpRenderTreeQt.h: 2836 * DumpRenderTree/qt/main.cpp: 2837 28382010-01-19 Adam Barth <abarth@webkit.org> 2839 2840 Rubber stamped by Eric Seidel. 2841 2842 Move chromium-ews back to building release only to make the EWS faster. 2843 2844 * Scripts/webkitpy/commands/early_warning_system.py: 2845 28462010-01-17 Jon Honeycutt <jhoneycutt@apple.com> 2847 2848 MSAA: The child <option> elements of a non-multiple <select> are not 2849 exposed 2850 2851 https://bugs.webkit.org/show_bug.cgi?id=33773 2852 <rdar://problem/7550556> 2853 2854 Reviewed by Alice Liu. 2855 2856 * DumpRenderTree/AccessibilityUIElement.cpp: 2857 (getIsVisibleCallback): 2858 Call the object's isVisible() function. 2859 (getIsOffScreenCallback): 2860 Ditto, for isOffScreen(). 2861 (getIsCollapsedCallback): 2862 Ditto, for isCollapsed(). 2863 (getHasPopupCallback): 2864 Ditto, for hasPopup(). 2865 (AccessibilityUIElement::getJSClass): 2866 Add isVisible and isOffScreen attributes. 2867 2868 * DumpRenderTree/AccessibilityUIElement.h: 2869 Declare new functions. 2870 2871 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 2872 (AccessibilityUIElement::isVisible): 2873 Stubbed. 2874 (AccessibilityUIElement::isOffScreen): 2875 Stubbed. 2876 (AccessibilityUIElement::isCollapsed): 2877 Stubbed. 2878 (AccessibilityUIElement::hasPopup): 2879 Stubbed. 2880 2881 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 2882 (AccessibilityUIElement::isVisible): 2883 Stubbed. 2884 (AccessibilityUIElement::isOffScreen): 2885 Stubbed. 2886 (AccessibilityUIElement::isCollapsed): 2887 Stubbed. 2888 (AccessibilityUIElement::hasPopup): 2889 Stubbed. 2890 2891 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 2892 (AccessibilityUIElement::showMenu): 2893 Call the object's accDoDefaultAction() to show its popup menu. 2894 (AccessibilityUIElement::isEnabled): 2895 Check that the object does not have the "unavailable" state. 2896 (AccessibilityUIElement::isVisible): 2897 Check that the object does not have the "invisible" state. 2898 (AccessibilityUIElement::isOffScreen): 2899 Check whether the object has the "offscreen" state. 2900 (AccessibilityUIElement::isCollapsed): 2901 Check whether the object has the "collapsed" state. 2902 (AccessibilityUIElement::hasPopup): 2903 Check whether the object has the "has popup" state. 2904 29052010-01-19 Victor Wang <victorw@chromium.org> 2906 2907 Reviewed by Eric Seidel. 2908 2909 Correct committer name. 2910 https://bugs.webkit.org/show_bug.cgi?id=33868 2911 2912 * Scripts/webkitpy/committers.py: 2913 29142010-01-19 Kent Tamura <tkent@chromium.org> 2915 2916 Reviewed by Darin Adler. 2917 2918 [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp() 2919 https://bugs.webkit.org/show_bug.cgi?id=33783 2920 2921 Some listbox tests check selection behavior by click events with 2922 "meta" or "shift" keys. Behaviors for such modifier keys are 2923 platform-dependent. The new parameter of mouseDown() and mouseUp() 2924 allows to specify not only concrete modifier keys such as 2925 "shiftKey" "metaKey", but also functional names like 2926 "addSelectionKey" "rangeSelectionKey". 2927 2928 * DumpRenderTree/mac/EventSendingController.mm: 2929 (+[EventSendingController isSelectorExcludedFromWebScript:]): 2930 (+[EventSendingController webScriptNameForSelector:]): 2931 (buildModifierFlags): 2932 (-[EventSendingController mouseDown:withModifiers:]): 2933 (-[EventSendingController mouseDown:]): 2934 (-[EventSendingController mouseUp:withModifiers:]): 2935 (-[EventSendingController mouseUp:]): 2936 (-[EventSendingController keyDown:withModifiers:withLocation:]): 2937 29382010-01-19 Adam Barth <abarth@webkit.org> 2939 2940 Reviewed by Eric Seidel. 2941 2942 Unbreak --request-commit 2943 https://bugs.webkit.org/show_bug.cgi?id=33832 2944 2945 * Scripts/webkitpy/bugzilla.py: 2946 29472010-01-19 Eric Seidel <eric@webkit.org> 2948 2949 Reviewed by Adam Barth. 2950 2951 validate-committer-lists throws exception and committers.py needs a refresh 2952 https://bugs.webkit.org/show_bug.cgi?id=33831 2953 2954 * Scripts/validate-committer-lists: use webkit_logging 2955 * Scripts/webkitpy/committers.py: Add recently minted committers. Fix Simon Hausmanns email address list to include his webkit-committers@lists address. 2956 29572010-01-18 Adam Roben <aroben@apple.com> 2958 2959 Add LayoutTestController support for calling new WebKit SPI to 2960 disallow setting document.domain 2961 2962 DRT part of fixing <http://webkit.org/b/33806> 2963 <rdar://problem/7552837> Would like API to disallow setting of 2964 document.domain for pages with certain URL schemes 2965 2966 Reviewed by Sam Weinig. 2967 2968 * DumpRenderTree/LayoutTestController.cpp: 2969 (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls 2970 through to LayoutTestController. 2971 (LayoutTestController::staticFunctions): Added 2972 setDomainRelaxationForbiddenForURLScheme. 2973 2974 * DumpRenderTree/LayoutTestController.h: Added 2975 setDomainRelaxationForbiddenForURLScheme. 2976 2977 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 2978 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 2979 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 2980 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 2981 Added. Calls through to WebKit. 2982 2983 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 2984 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 2985 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 2986 (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): 2987 Stubbed out. 2988 29892010-01-18 Adam Barth <abarth@webkit.org> 2990 2991 Reviewed by Adam Roben. 2992 2993 Rename patches-to-commit to patches-in-commit-queue 2994 https://bugs.webkit.org/show_bug.cgi?id=33789 2995 2996 The command really lists the patches in the commit-queue not all the 2997 patches that are pending-commit (as the FIXME commands). 2998 2999 * Scripts/webkitpy/commands/queries.py: 3000 * Scripts/webkitpy/commands/queries_unittest.py: 3001 30022010-01-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 3003 3004 Reviewed by Simon Hausmann. 3005 3006 [Qt] Force qmake to generate a single makefile for DerivedSources.pro 3007 3008 * Scripts/webkitdirs.pm: 3009 30102010-01-18 Adam Roben <aroben@apple.com> 3011 3012 Clean up use of /useenv when invoking Visual C++ 3013 3014 This change reverts things to their pre-r49485 state. That revision 3015 (and, subsequently, r49664 and r51788) started passing /useenv to 3016 Visual C++, even in cases where we don't want to do so (such as when 3017 invoking Visual C++ Express), in the name of making the Chromium build 3018 work. Now that Chromium isn't using buildVisualStudioProject or 3019 pdevenv, we can put things back they way they were. 3020 3021 Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express 3022 (due to /useenv flag) 3023 3024 Reviewed by Sam Weinig. 3025 3026 * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this 3027 script anymore. 3028 * Scripts/webkitdirs.pm: 3029 (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes 3030 care of this itself, and we don't want to pass /useenv when not using 3031 pdevenv (e.g., when using VC++ Express, because that will cause it to 3032 ignore the Platform SDK). 3033 30342010-01-18 Adam Barth <abarth@webkit.org> 3035 3036 Reviewed by Eric Seidel. 3037 3038 webkit-patch land-safely should obsolete old patches 3039 https://bugs.webkit.org/show_bug.cgi?id=33788 3040 3041 When posting a commit-queue+ patch with land-safely, we should 3042 obsolete the old patches on the bug. They're really confusing 3043 because the main use case is to address reviewer feedback on a 3044 previous patch. 3045 3046 * Scripts/webkitpy/commands/upload.py: 3047 * Scripts/webkitpy/commands/upload_unittest.py: 3048 30492010-01-18 Adam Barth <abarth@webkit.org> 3050 3051 Reviewed by David Levin. 3052 3053 webkit-patch should authenticate more often 3054 https://bugs.webkit.org/show_bug.cgi?id=33701 3055 3056 This makes it easier to work with security patches. 3057 3058 * Scripts/webkitpy/bugzilla.py: 3059 30602010-01-18 Adam Barth <abarth@webkit.org> 3061 3062 Reviewed by Darin Adler. 3063 3064 style checker needs to know about GObject-specific requirements 3065 inside WebCore/bindings/gobject/ 3066 https://bugs.webkit.org/show_bug.cgi?id=33606 3067 3068 Add an exception to the underscore rule for certain 3069 GObject-specific names. 3070 3071 * Scripts/webkitpy/style/cpp_style.py: 3072 * Scripts/webkitpy/style/cpp_style_unittest.py: 3073 30742010-01-18 Adam Barth <abarth@webkit.org> 3075 3076 Reviewed by Shinichiro Hamaji. 3077 3078 [check-webkit-style] does understand ResourceHandleWin.h 3079 https://bugs.webkit.org/show_bug.cgi?id=32975 3080 3081 I'm not 100% convinced this fix is correct, but without more examples, 3082 it's hard to generalize. We can always generalize the fix in the 3083 future. 3084 3085 * Scripts/webkitpy/style/cpp_style.py: 3086 * Scripts/webkitpy/style/cpp_style_unittest.py: 3087 30882010-01-18 Adam Barth <abarth@webkit.org> 3089 3090 Unreviewed "build" fix. 3091 3092 * Scripts/webkitpy/bugzilla.py: 3093 30942010-01-18 Adam Barth <abarth@webkit.org> 3095 3096 Unreviewed. Actually make land-safely mark commit-queue+ as 3097 discussed with Eric. 3098 3099 * Scripts/webkitpy/bugzilla.py: 3100 * Scripts/webkitpy/steps/postdiffforcommit.py: 3101 31022010-01-17 Adam Barth <abarth@webkit.org> 3103 3104 Reviewed by Darin Adler. 3105 3106 style-queue complains about one-line macros that include multiple statements 3107 https://bugs.webkit.org/show_bug.cgi?id=33173 3108 3109 Add an exception for multiple statements on a line that starts a macro. 3110 3111 * Scripts/webkitpy/style/cpp_style.py: 3112 * Scripts/webkitpy/style/cpp_style_unittest.py: 3113 31142010-01-17 Adam Barth <abarth@webkit.org> 3115 3116 Reviewed by Darin Adler. 3117 3118 [check-webkit-style] qt unit testing false positives 3119 https://bugs.webkit.org/show_bug.cgi?id=32833 3120 3121 Exempt the Qt API and unit tests from the style checker. 3122 3123 * Scripts/webkitpy/style/cpp_style.py: 3124 * Scripts/webkitpy/style/cpp_style_unittest.py: 3125 31262010-01-17 Adam Barth <abarth@webkit.org> 3127 3128 Reviewed by Darin Adler. 3129 3130 style-check script reports loads of errors on gtk2drawing.c 3131 https://bugs.webkit.org/show_bug.cgi?id=33771 3132 3133 Exempt WebCore/platform/gtk/gtk2drawing.c and 3134 WebCore/platform/gtk/gtk2drawing.h from style checks. 3135 3136 * Scripts/webkitpy/style/cpp_style.py: 3137 * Scripts/webkitpy/style/cpp_style_unittest.py: 3138 31392010-01-17 Chris Jerdonek <cjerdonek@webkit.org> 3140 3141 Reviewed by Shinichiro Hamaji. 3142 3143 Finished eliminating _cpp_style_state global state variable from 3144 check-webkit-style code and eliminating _CppStyleState class. 3145 3146 https://bugs.webkit.org/show_bug.cgi?id=33764 3147 3148 * Scripts/webkitpy/style/checker.py: 3149 - Minor updates caused by changes to cpp_style.py. 3150 3151 * Scripts/webkitpy/style/cpp_style.py: 3152 - Removed _CppStyleState class. 3153 - Removed verbose_level functions. 3154 - Added verbosity as a parameter to _FunctionState constructor. 3155 - Added verbosity as a parameter to process_file(). 3156 - Added verbosity as a parameter to process_file_data(). 3157 3158 * Scripts/webkitpy/style/cpp_style_unittest.py: 3159 - Added helper functions to set verbosity while running tests. 3160 31612010-01-17 Adam Barth <abarth@webkit.org> 3162 3163 Reviewed by Shinichiro Hamaji. 3164 3165 check-webkit-style underscore check should be disabled for Qt methods starting with qt_ 3166 https://bugs.webkit.org/show_bug.cgi?id=33663 3167 3168 * Scripts/webkitpy/style/cpp_style.py: 3169 * Scripts/webkitpy/style/cpp_style_unittest.py: 3170 31712010-01-17 Adam Barth <abarth@webkit.org> 3172 3173 Reviewed by Eric Seidel. 3174 3175 style-queue complains about missing #include of config.h for non-WebCore projects 3176 https://bugs.webkit.org/show_bug.cgi?id=33170 3177 3178 WebKitAPITests are consumers of the WebKit API and therefore do not 3179 need to follow the same include discipline as the rest of WebKit. This 3180 patch exempts them from the include checks. 3181 3182 * Scripts/webkitpy/style/cpp_style.py: 3183 * Scripts/webkitpy/style/cpp_style_unittest.py: 3184 31852010-01-17 Adam Barth <abarth@webkit.org> 3186 3187 Reviewed by Eric Seidel. 3188 3189 EWS (Early Warning Systems) should build both debug and release 3190 https://bugs.webkit.org/show_bug.cgi?id=33681 3191 3192 Build both debug and release for chromium-ews. 3193 3194 * Scripts/webkitpy/commands/early_warning_system.py: 3195 31962010-01-17 Adam Barth <abarth@webkit.org> 3197 3198 Reviewed by Darin Adler. 3199 3200 style-queue should include instructions for how to file bugs against check-webkit-style 3201 https://bugs.webkit.org/show_bug.cgi?id=32345 3202 3203 Added some text to the error message asking folks to file bugs against 3204 false positives. 3205 3206 * Scripts/webkitpy/commands/queues.py: 3207 32082010-01-17 Chris Jerdonek <cjerdonek@webkit.org> 3209 3210 Reviewed by Adam Barth. 3211 3212 Eliminated the error_count global variable and related 3213 check-webkit-style refactoring. 3214 3215 https://bugs.webkit.org/show_bug.cgi?id=33678 3216 3217 * Scripts/check-webkit-style: 3218 - Updated to use webkit_argument_defaults(). 3219 - Renamed styleChecker to style_checker. 3220 3221 * Scripts/webkitpy/style/checker.py: 3222 - Prefixed the three default arguments with WEBKIT_DEFAULT. 3223 - Added webkit_argument_defaults(). 3224 - Added default filter_rules parameter to CategoryFilter constructor. 3225 - Added __ne__() to CategoryFilter class. 3226 - Added __eq__() and __ne__() to ProcessorOptions class. 3227 - Added error_count and _write_error attributes to StyleChecker class. 3228 - Made StyleChecker._handle_error() increment the error count. 3229 3230 * Scripts/webkitpy/style/checker_unittest.py: 3231 - Improved CategoryFilterTest.test_eq(). 3232 - Added CategoryFilterTest.test_ne(). 3233 - Added test_eq() and test_ne() to ProcessorOptionsTest class. 3234 - Updated unit tests to use webkit_argument_defaults(). 3235 - Added StyleCheckerTest class. 3236 3237 * Scripts/webkitpy/style/cpp_style.py: 3238 - Removed references to global error_count. 3239 3240 * Scripts/webkitpy/style/cpp_style_unittest.py: 3241 - Removed CppStyleStateTest class. 3242 32432010-01-15 Jon Honeycutt <jhoneycutt@apple.com> 3244 3245 get_accParent should try to retrieve parent AccessibilityObject, before 3246 calling upon window 3247 3248 https://bugs.webkit.org/show_bug.cgi?id=22893 3249 3250 Reviewed by Darin Adler. 3251 3252 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 3253 (AccessibilityUIElement::parentElement): 3254 Get the object's parent. Query it for IAccessible, and return it. 3255 32562010-01-16 Dan Bernstein <mitz@apple.com> 3257 3258 Reviewed by Mark Rowe. 3259 3260 <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently() 3261 3262 * DumpRenderTree/mac/CheckedMalloc.cpp: 3263 (makeLargeMallocFailSilently): Temporarily allow writing to the default 3264 malloc zone structure while modifying it. 3265 32662010-01-16 David Kilzer <ddkilzer@apple.com> 3267 3268 Added back removed properties to iExploder input files 3269 3270 While the update-iexploder-cssproperties script works great to 3271 add new properties, it has the side-effect of removing old 3272 properties that once were parsed. 3273 3274 * iExploder/htdocs/cssproperties.in: Added back removed 3275 properties into their own section. 3276 * iExploder/htdocs/htmlattrs.in: Ditto. 3277 32782010-01-16 Holger Hans Peter Freyther <zecke@selfish.org> 3279 3280 Reviewed by David Kilzer. 3281 3282 Update iExploder/htdocs/*.in by running update-iexploder-cssproperties 3283 https://bugs.webkit.org/show_bug.cgi?id=33756 3284 3285 * iExploder/htdocs/cssproperties.in: New CSS attributes 3286 * iExploder/htdocs/htmlattrs.in: New HTML attributes 3287 * iExploder/htdocs/htmltags.in: New HTML tags 3288 32892010-01-15 Chris Jerdonek <chris.jerdonek@gmail.com> 3290 3291 Reviewed by David Kilzer. 3292 3293 Altered parseDiffHeader() to skip unrecognized lines and 3294 other minor clean-ups. 3295 3296 https://bugs.webkit.org/show_bug.cgi?id=33476 3297 3298 * Scripts/VCSUtils.pm: 3299 - Changed parseDiffHeader() as follows: 3300 - Skips over unrecognized lines. 3301 - Addressed FIXME to remove substitution for "diff" line. 3302 - Renamed "version" header hash key to "sourceRevision". 3303 - Eliminated "copiedFromVersion" header hash key. 3304 - Included "sourceRevision" also for copied files. 3305 - Checks that copy revision number matches "sourceRevision". 3306 - No longer returns $foundHeaderEnding. 3307 - Dies if header ending not found. 3308 - Diff header dividing line now always added. 3309 3310 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: 3311 - Made necessary changes in parseDiffHeader() unit tests. 3312 - Shortened the file paths in some test cases. 3313 33142010-01-14 Yuzo Fujishima <yuzo@google.com> 3315 3316 Reviewed by Alexey Proskuryakov. 3317 3318 Update pywebsocket to 0.4.6 3319 https://bugs.webkit.org/show_bug.cgi?id=32299 3320 The newer pywebsocket can handle more simultaneous connections. 3321 3322 * pywebsocket/mod_pywebsocket/handshake.py: 3323 * pywebsocket/mod_pywebsocket/standalone.py: 3324 * pywebsocket/setup.py: 3325 * pywebsocket/test/test_handshake.py: 3326 33272010-01-14 Eric Seidel <eric@webkit.org> 3328 3329 Reviewed by Adam Barth. 3330 3331 REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs 3332 https://bugs.webkit.org/show_bug.cgi?id=33638 3333 3334 * Scripts/webkitpy/bugzilla.py: 3335 - Add Bug.id() to match Attachment.id() 3336 - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers. 3337 - Add back a missing variable to _validate_setter_email found by the new unit tests! 3338 * Scripts/webkitpy/commands/queries.py: 3339 - Add FIXMEs about the commands being confusingly named. 3340 * Scripts/webkitpy/commands/queries_unittest.py: 3341 - Update results to reflect the newly restructured mock bug cache. 3342 * Scripts/webkitpy/commands/queues.py: 3343 - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression). 3344 - Add a FIXME about eventually sorting the patches into some order. 3345 * Scripts/webkitpy/commands/queues_unittest.py: 3346 - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer. 3347 * Scripts/webkitpy/commands/upload_unittest.py: 3348 - Update results to match the newly restructured mock bug cache. 3349 * Scripts/webkitpy/mock_bugzillatool.py: 3350 - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs. 3351 - Add a few more attachments and bug dictionaries for use by the tests. 3352 33532010-01-13 Diego Gonzalez <diego.gonzalez@openbossa.org> 3354 3355 Reviewed by Kenneth Christiansen. 3356 3357 [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController 3358 https://bugs.webkit.org/show_bug.cgi?id=33617 3359 3360 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 3361 (WebCore::WebPage::resetSettings): 3362 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 3363 (LayoutTestController::setUserStyleSheetLocation): 3364 (LayoutTestController::setUserStyleSheetEnabled): 3365 * DumpRenderTree/qt/LayoutTestControllerQt.h: 3366 33672010-01-14 Adam Roben <aroben@apple.com> 3368 3369 Add LayoutTestController API to force 3370 -webView:resource:willSendRequest:: to return null 3371 3372 Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533> 3373 window.onload never fires if page contains an <iframe> with a bad 3374 scheme or whose load is cancelled by returning null from resource load 3375 delegate's willSendRequest 3376 3377 Reviewed by Brady Eidson. 3378 3379 * DumpRenderTree/LayoutTestController.cpp: 3380 (LayoutTestController::LayoutTestController): Initialize new member. 3381 (setWillSendRequestReturnsNullCallback): Call through to 3382 LayoutTestController. 3383 (LayoutTestController::staticFunctions): Added new function. 3384 3385 * DumpRenderTree/LayoutTestController.h: Added 3386 m_willSendRequestReturnsNull. 3387 (LayoutTestController::willSendRequestReturnsNull): 3388 (LayoutTestController::setWillSendRequestReturnsNull): 3389 Added standard accessors. 3390 3391 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 3392 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): 3393 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 3394 (ResourceLoadDelegate::willSendRequest): 3395 Return null if LayoutTestController says to. 3396 33972010-01-14 Kevin Ollivier <kevino@theolliviers.com> 3398 3399 [wx] Build fix after removal of XBM support. 3400 3401 * wx/build/settings.py: 3402 34032010-01-14 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 3404 3405 Reviewed by Simon Hausmann. 3406 3407 Add support for partial building on Symbian. 3408 3409 The build happens in the source directory as out of source builds are 3410 not supported by qmake for Symbian. 3411 3412 Also the actual build isn't started but it is left to the developer 3413 to choose the architecture/configuration. 3414 3415 * Scripts/webkitdirs.pm: 3416 34172010-01-14 Simon Hausmann <simon.hausmann@nokia.com> 3418 3419 Reviewed by Kenneth Rohde Christiansen. 3420 3421 Add support for "detecting" Symbian environments by either 3422 looking for the EPOCROOT environment variable or via --symbian 3423 being passed on the commandline. 3424 3425 * Scripts/webkitdirs.pm: 3426 34272010-01-14 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 3428 3429 Unreviewed. 3430 3431 [Qt] Use a different Makefile names for sources generation and compilation. 3432 This prevents Makefile overwriting when running build-webkit twice. 3433 3434 * Scripts/webkitdirs.pm: 3435 34362010-01-14 Andreas Kling <andreas.kling@nokia.com> 3437 3438 Reviewed by Kenneth Rohde Christiansen. 3439 3440 [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets. 3441 3442 https://bugs.webkit.org/show_bug.cgi?id=33373 3443 3444 * QtLauncher/main.cpp: 3445 (WebPage::createPlugin): 3446 34472010-01-14 Eric Seidel <eric@webkit.org> 3448 3449 No review, rolling out r53249. 3450 http://trac.webkit.org/changeset/53249 3451 https://bugs.webkit.org/show_bug.cgi?id=33617 3452 3453 This caused http/tests/security/local-user-CSS-from- 3454 remote.html to fail on the Qt Release Build Bot. 3455 3456 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 3457 (WebCore::WebPage::resetSettings): 3458 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 3459 (LayoutTestController::overridePreference): 3460 * DumpRenderTree/qt/LayoutTestControllerQt.h: 3461 34622010-01-14 Chris Jerdonek <chris.jerdonek@gmail.com> 3463 3464 Reviewed by Shinichiro Hamaji. 3465 3466 Moved error() from cpp_style.py to checker.py. 3467 3468 https://bugs.webkit.org/show_bug.cgi?id=33620 3469 3470 * Scripts/check-webkit-style: 3471 - Addressed FIXME to not set global state. 3472 3473 * Scripts/webkitpy/style/checker.py: 3474 - Added argument validation to ProcessorOptions constructor. 3475 - Added should_report_error() to ProcessorOptions class. 3476 - Removed set_options(). 3477 - Added StyleChecker class. 3478 3479 * Scripts/webkitpy/style/checker_unittest.py: 3480 - Added unit test class for ProcessorOptions class. 3481 - Added unit test to check that parse() strips white space. 3482 3483 * Scripts/webkitpy/style/cpp_style.py: 3484 - Removed "filter" and "output_format" methods. 3485 - Removed should_print_error() and error() functions. 3486 - Removed default parameter value from process_file(). 3487 3488 * Scripts/webkitpy/style/cpp_style_unittest.py: 3489 - Removed call to cpp_style._should_print_error(). 3490 - Removed test_filter() and test_filter_appending(). 3491 3492 * Scripts/webkitpy/style/text_style.py: 3493 - Removed default parameter value from process_file(). 3494 34952010-01-14 Diego Gonzalez <diego.gonzalez@openbossa.org> 3496 3497 Reviewed by Kenneth Rohde Christiansen. 3498 3499 [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController 3500 https://bugs.webkit.org/show_bug.cgi?id=33617 3501 3502 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 3503 (WebCore::WebPage::resetSettings): 3504 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 3505 (LayoutTestController::setUserStyleSheetLocation): 3506 (LayoutTestController::setUserStyleSheetEnabled): 3507 * DumpRenderTree/qt/LayoutTestControllerQt.h: 3508 35092010-01-13 Adam Barth <abarth@webkit.org> 3510 3511 Reviewed by Eric Seidel. 3512 3513 Fix CloseBugForLandDiff unittest to actually run 3514 https://bugs.webkit.org/show_bug.cgi?id=33640 3515 3516 * Scripts/webkitpy/mock_bugzillatool.py: 3517 * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: 3518 35192010-01-12 Jon Honeycutt <jhoneycutt@apple.com> 3520 3521 MSAA: selected, selectable, extended selectable, and multiple 3522 selectable states are not reported 3523 3524 https://bugs.webkit.org/show_bug.cgi?id=33574 3525 <rdar://problem/7536826> 3526 3527 Reviewed by Darin Adler. 3528 3529 * DumpRenderTree/AccessibilityUIElement.cpp: 3530 (getIsSelectableCallback): 3531 Return the result of calling isSelectable(). 3532 (getIsMultiSelectableCallback): 3533 Return the result of calling isMultiSelectable(). 3534 (AccessibilityUIElement::getJSClass): 3535 Add isSelected and isMultiSelectable properties to the JSClass 3536 definition. 3537 3538 * DumpRenderTree/AccessibilityUIElement.h: 3539 Declare isSelectable() and isMultiSelectable(). 3540 3541 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 3542 (AccessibilityUIElement::isSelectable): 3543 Stubbed. 3544 (AccessibilityUIElement::isMultiSelectable): 3545 Stubbed. 3546 3547 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 3548 (AccessibilityUIElement::isSelectable): 3549 Stubbed. 3550 (AccessibilityUIElement::isMultiSelectable): 3551 Stubbed. 3552 3553 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 3554 (accessibilityState): 3555 Get the object's state, and return it. 3556 (AccessibilityUIElement::isSelected): 3557 Check the object's selected state. 3558 (AccessibilityUIElement::isSelectable): 3559 Check the object's selectable state. 3560 (AccessibilityUIElement::isMultiSelectable): 3561 Check the object's extended/multiple selectable state. 3562 35632010-01-13 Adam Barth <abarth@webkit.org> 3564 3565 Unreviewed. Repeat the below for CloseBugForLandDiff. 3566 3567 * Scripts/test-webkitpy: 3568 * Scripts/webkitpy/steps/closebugforlanddiff.py: 3569 * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added. 3570 35712010-01-13 Adam Barth <abarth@webkit.org> 3572 3573 Unreviewed. Turn the mac-ews status bubbles back on now that this bot 3574 is running again. 3575 3576 * QueueStatusServer/templates/statusbubble.html: 3577 35782010-01-13 Adam Barth <abarth@webkit.org> 3579 3580 Reviewed by Darin Adler. 3581 3582 REGRESSION(53133): webkit-patch land dies if it can't find a bug id. 3583 https://bugs.webkit.org/show_bug.cgi?id=33634 3584 3585 Deal with the case of no bug patch object in the state. 3586 3587 * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: 3588 * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: 3589 35902010-01-13 Kenneth Russell <kbr@google.com> 3591 3592 Unreviewed; added myself to the committers list. 3593 3594 * Scripts/webkitpy/committers.py: 3595 35962010-01-13 Darin Adler <darin@apple.com> 3597 3598 Ignore compiled Python in more of webkitpy. 3599 3600 * Scripts/webkitpy/commands: Added property svn:ignore. 3601 * Scripts/webkitpy/steps: Added property svn:ignore. 3602 * Scripts/webkitpy/style: Added property svn:ignore. 3603 36042010-01-13 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 3605 3606 Reviewed by Simon Hausmann. 3607 3608 [Qt] Fix build problem related to the pushd command 3609 3610 * Scripts/webkitdirs.pm: 3611 36122010-01-13 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 3613 3614 Reviewed by Simon Hausmann. 3615 3616 [Qt] Split the build process in two different .pro files. 3617 This allows qmake to be run once all source files are available. 3618 3619 * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC. 3620 36212010-01-13 Shinichiro Hamaji <hamaji@chromium.org> 3622 3623 Unreviewed tiny typo fix in docstrings. 3624 3625 * Scripts/webkitpy/style/checker_unittest.py: 3626 36272010-01-13 Chris Jerdonek <chris.jerdonek@gmail.com> 3628 3629 Reviewed by Shinichiro Hamaji. 3630 3631 Created a CategoryFilter class to encapsulate the logic of 3632 filter rules. 3633 3634 https://bugs.webkit.org/show_bug.cgi?id=33454 3635 3636 * Scripts/webkitpy/style/checker.py: 3637 - Added CategoryFilter class. 3638 3639 * Scripts/webkitpy/style/checker_unittest.py: 3640 - Added CategoryFilter unit tests. 3641 3642 * Scripts/webkitpy/style/cpp_style.py: 3643 - Updated filter methods to use CategoryFilter. 3644 3645 * Scripts/webkitpy/style/cpp_style_unittest.py: 3646 - Updated references to filters. 3647 36482010-01-12 Shinichiro Hamaji <hamaji@chromium.org> 3649 3650 Unreviewed. Now I can review :) 3651 3652 * Scripts/webkitpy/committers.py: 3653 36542010-01-12 Brent Fulgham <bfulgham@webkit.org> 3655 3656 Reviewed by Darin Adler. 3657 3658 Extend WinLauncher example with better printing features. 3659 3660 * WinLauncher/PrintWebUIDelegate.cpp: 3661 (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly 3662 larger margins. 3663 (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based 3664 on text metrics. 3665 (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based 3666 on text metrics. 3667 (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along 3668 with separating line. 3669 (PrintWebUIDelegate::drawFooterInRect): 3670 * WinLauncher/PrintWebUIDelegate.h: Remove stubs. 3671 * WinLauncher/WinLauncher.cpp: 3672 (PrintView): Correct loop used to print individual pages. 3673 Previously it started at 0, which is a wild-card to print all 3674 pages at once. 3675 36762010-01-12 Alexey Proskuryakov <ap@apple.com> 3677 3678 Reviewed by Darin Adler. 3679 3680 https://bugs.webkit.org/show_bug.cgi?id=33540 3681 Make it possible to build in debug mode with assertions disabled 3682 3683 * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]): 3684 36852010-01-11 Darin Fisher <darin@chromium.org> 3686 3687 Reviewed by Dimitri Glazkov. 3688 3689 [Chromium] "build-webkit --chromium" should run "make all" on Linux 3690 https://bugs.webkit.org/show_bug.cgi?id=33500 3691 3692 * Scripts/webkitdirs.pm: 3693 36942010-01-12 Eric Seidel <eric@webkit.org> 3695 3696 Reviewed by Adam Barth. 3697 3698 AssignToCommitter does not need to fetch bugs twice 3699 https://bugs.webkit.org/show_bug.cgi?id=33530 3700 3701 This is a no-brainer patch now that we've added Bug.reviewed_patches 3702 3703 * Scripts/webkitpy/commands/upload.py: 3704 37052010-01-12 Eric Seidel <eric@webkit.org> 3706 3707 Reviewed by Adam Barth. 3708 3709 bugzilla.py should have an Attachment object instead of passing around dictionaries 3710 https://bugs.webkit.org/show_bug.cgi?id=31594 3711 3712 * Scripts/webkitpy/bugzilla.py: 3713 - Add a new Attachment class, with accessor methods for all the necessary properties. 3714 - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url()) 3715 - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug 3716 - Move committer validation logic into its own class. 3717 - Committer rejection is only used in one place. Make the new Bug reviewed_patches and commit_queued_patches 3718 handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle 3719 the case where we want to reject patches in bugzilla. 3720 - Simplify fetch_patches_from_commit_queue now that committer validation is simpler. 3721 - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug. 3722 - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it. 3723 - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class. 3724 * Scripts/webkitpy/bugzilla_unittest.py: 3725 - Move test_flag_permission_rejection_message into a new CommitterValidationTest class. 3726 * Scripts/webkitpy/commands/download.py: 3727 - Store "bug_id" in state instead of making a fake patch object. 3728 - Update to use Attachment and Bug objects. 3729 * Scripts/webkitpy/commands/download_unittest.py: 3730 - Update expected results now that our testing framework covers more code. 3731 * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class. 3732 * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class. 3733 * Scripts/webkitpy/commands/queries_unittest.py: ditto. 3734 * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes. 3735 * Scripts/webkitpy/commands/queuestest.py: ditto. 3736 * Scripts/webkitpy/commands/upload.py: ditto. 3737 * Scripts/webkitpy/mock_bugzillatool.py: 3738 - Now that more logic has moved into Attachment and Bug, we have to actually 3739 provide real reviewer emails as well as real reviewer flags. 3740 - Update mock methods to return Attachment objects. 3741 * Scripts/webkitpy/scm.py: Update to use Attachment class. 3742 * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class. 3743 * Scripts/webkitpy/statusserver.py: ditto. 3744 * Scripts/webkitpy/steps/applypatch.py: ditto. 3745 * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto. 3746 * Scripts/webkitpy/steps/closebug.py: ditto. 3747 * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id() 3748 * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class. 3749 * Scripts/webkitpy/steps/obsoletepatches.py: ditto. 3750 * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto. 3751 37522010-01-12 Adam Barth <abarth@webkit.org> 3753 3754 Unreviewed typo fix. :( 3755 3756 * Scripts/webkitpy/commands/early_warning_system.py: 3757 * Scripts/webkitpy/commands/queues.py: 3758 37592010-01-12 Adam Barth <abarth@webkit.org> 3760 3761 Unreviewed. Add "error" to the right part of the message. 3762 3763 * Scripts/webkitpy/commands/queues.py: 3764 37652010-01-12 Adam Barth <abarth@webkit.org> 3766 3767 Reviewed by Eric Seidel. 3768 3769 EWS should show purple when svn-apply fails 3770 https://bugs.webkit.org/show_bug.cgi?id=33527 3771 3772 * Scripts/webkitpy/commands/early_warning_system.py: 3773 * Scripts/webkitpy/commands/queues.py: 3774 37752010-01-12 Adam Barth <abarth@webkit.org> 3776 3777 Reviewed by Eric Seidel. 3778 3779 Remove copy/paste code from subclasses of AbstractReviewQueue 3780 https://bugs.webkit.org/show_bug.cgi?id=33525 3781 3782 * Scripts/webkitpy/commands/early_warning_system.py: 3783 * Scripts/webkitpy/commands/queues.py: 3784 37852010-01-12 Adam Barth <abarth@webkit.org> 3786 3787 Reviewed by Eric Seidel. 3788 3789 Add Gustavo and Xan as gtk-ews watchers 3790 https://bugs.webkit.org/show_bug.cgi?id=33519 3791 3792 * Scripts/webkitpy/commands/early_warning_system.py: 3793 37942010-01-12 Adam Barth <abarth@webkit.org> 3795 3796 Reviewed by Eric Seidel. 3797 3798 webkit-patch shouldn't waste my time for with a component prompt 3799 https://bugs.webkit.org/show_bug.cgi?id=33521 3800 3801 The component field isn't very useful for bugs created with 3802 webkit-patch because they're likely to be resolved quickly. Instead of 3803 always prompting for a component, we should just default to the "New 3804 Bugs" component. If the bug stays around for more than five minutes, 3805 we can assign it a proper component. 3806 3807 * Scripts/webkitpy/bugzilla.py: 3808 38092010-01-12 Adam Barth <abarth@webkit.org> 3810 3811 Reviewed by Eric Seidel. 3812 3813 Add experimental "land-safely" command to webkit-patch 3814 https://bugs.webkit.org/show_bug.cgi?id=33518 3815 3816 * Scripts/webkitpy/commands/upload.py: 3817 * Scripts/webkitpy/commands/upload_unittest.py: 3818 * Scripts/webkitpy/steps/__init__.py: 3819 * Scripts/webkitpy/steps/postdiffforcommit.py: Added. 3820 38212010-01-11 Kevin Ollivier <kevino@theolliviers.com> 3822 3823 [wx] Build fix after introduction of JS_NO_EXPORT 3824 3825 * wx/build/settings.py: 3826 38272010-01-11 Eric Seidel <eric@webkit.org> 3828 3829 No review, rolling out r53079. 3830 http://trac.webkit.org/changeset/53079 3831 https://bugs.webkit.org/show_bug.cgi?id=33197 3832 3833 Adam doens't think this actually works, and believe it caused 3834 a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so 3835 rolling this out. 3836 3837 * Scripts/test-webkitpy: 3838 * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed. 3839 * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed. 3840 * Scripts/webkitpy/commands/download.py: 3841 * Scripts/webkitpy/commands/upload.py: 3842 * Scripts/webkitpy/mock_bugzillatool.py: 3843 38442010-01-10 Adam Barth <abarth@webkit.org> 3845 3846 Reviewed by David Kilzer. 3847 3848 bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files 3849 https://bugs.webkit.org/show_bug.cgi?id=33197 3850 3851 We should just search for bug numbers in the ChangeLogs instead of in 3852 the whole diff. 3853 3854 * Scripts/test-webkitpy: 3855 * Scripts/webkitpy/commands/abstractdiffcommand.py: Added. 3856 * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added. 3857 * Scripts/webkitpy/commands/download.py: 3858 * Scripts/webkitpy/commands/upload.py: 3859 * Scripts/webkitpy/mock_bugzillatool.py: 3860 38612010-01-11 Chris Jerdonek <chris.jerdonek@gmail.com> 3862 3863 Reviewed by David Kilzer. 3864 3865 Created a unit-tested function to parse the header block of 3866 a Git or SVN diff -- for future refactoring of svn-apply and 3867 svn-unapply. 3868 3869 https://bugs.webkit.org/show_bug.cgi?id=33447 3870 3871 * Scripts/VCSUtils.pm: 3872 - Added parseDiffHeader(). 3873 - Removed irrelevant comment from gitdiff2svndiff(). 3874 3875 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added. 3876 - Added 48 unit tests for parseDiffHeader(). 3877 38782010-01-10 Adam Barth <abarth@webkit.org> 3879 3880 Rubber stamped by David Kilzer. 3881 3882 bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files 3883 https://bugs.webkit.org/show_bug.cgi?id=33197 3884 3885 Fix a typo: Commmand -> Command. 3886 3887 * Scripts/webkitpy/commands/abstractsequencedcommand.py: 3888 * Scripts/webkitpy/commands/download.py: 3889 * Scripts/webkitpy/commands/queries.py: 3890 * Scripts/webkitpy/commands/upload.py: 3891 * Scripts/webkitpy/multicommandtool.py: 3892 38932010-01-10 Adam Barth <abarth@webkit.org> 3894 3895 Reviewed by Darin Adler. 3896 3897 Let webkit-patch work with options in $EDITOR 3898 https://bugs.webkit.org/show_bug.cgi?id=33414 3899 3900 The $EDITOR evironment variable might have command line options like 3901 bbedit -w. This patch lets us run those $EDITORs. 3902 3903 * Scripts/webkitpy/user.py: 3904 39052010-01-10 Robert Hogan <robert@roberthogan.net> 3906 3907 Reviewed by Adam Barth. 3908 3909 [Qt] Add enableXSSAuditor support to QWebSettings and DRT. 3910 3911 https://bugs.webkit.org/show_bug.cgi?id=33419 3912 3913 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 3914 (WebCore::WebPage::WebPage): 3915 (WebCore::WebPage::resetSettings): 3916 (WebCore::DumpRenderTree::createWindow): 3917 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 3918 (LayoutTestController::setXSSAuditorEnabled): 3919 * DumpRenderTree/qt/LayoutTestControllerQt.h: 3920 39212010-01-10 Adam Barth <abarth@webkit.org> 3922 3923 Unreviewed cosmetic change. Remove the status bubble for mac-ews 3924 because we don't have hardware for it at the moment. 3925 3926 * QueueStatusServer/templates/statusbubble.html: 3927 39282010-01-09 Daniel Bates <dbates@webkit.org> 3929 3930 No review, rolling out r53044. 3931 http://trac.webkit.org/changeset/53044 3932 https://bugs.webkit.org/show_bug.cgi?id=33419 3933 3934 We need to look into this some more because the Qt 3935 bot is failing the XSSAuditor tests. See bug #33419 3936 for more details. 3937 3938 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 3939 (WebCore::WebPage::WebPage): 3940 (WebCore::WebPage::resetSettings): 3941 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 3942 * DumpRenderTree/qt/LayoutTestControllerQt.h: 3943 39442010-01-09 Daniel Bates <dbates@webkit.org> 3945 3946 Reviewed by Adam Barth. 3947 3948 https://bugs.webkit.org/show_bug.cgi?id=33419 3949 3950 Adds support for the XSSAuditor to the Qt DRT. 3951 3952 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 3953 (WebCore::WebPage::WebPage): 3954 (WebCore::WebPage::resetSettings): 3955 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 3956 (LayoutTestController::setXSSAuditorEnabled): 3957 * DumpRenderTree/qt/LayoutTestControllerQt.h: 3958 39592010-01-09 Adam Barth <abarth@webkit.org> 3960 3961 Reviewed by Eric Seidel. 3962 3963 Retry writes to QueueStatusServer when we get 500 errors 3964 https://bugs.webkit.org/show_bug.cgi?id=33412 3965 3966 This prevents the queues from failing to mark a patch as "pass" or 3967 "fail" when AppEngine throws 500 errors. 3968 3969 * Scripts/test-webkitpy: 3970 * Scripts/webkitpy/networktransaction.py: Added. 3971 * Scripts/webkitpy/networktransaction_unittest.py: Added. 3972 * Scripts/webkitpy/statusserver.py: 3973 * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added. 3974 * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added. 3975 * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added. 3976 39772010-01-09 David Kilzer <ddkilzer@apple.com> 3978 3979 <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers 3980 3981 Reviewed by Eric Seidel. 3982 3983 * QueueStatusServer/templates/statusbubble.html: Added 3984 -moz-border-radius and -webkit-border-radius to provide rounded 3985 borders in older Firefox and Safari browsers. 3986 39872010-01-09 Chris Jerdonek <chris.jerdonek@gmail.com> 3988 3989 Reviewed by David Kilzer. 3990 3991 Modified VCSUtils::gitdiff2svndiff() to accept strings that 3992 end in vertical white space. 3993 3994 https://bugs.webkit.org/show_bug.cgi?id=33415 3995 3996 * Scripts/VCSUtils.pm: 3997 * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: 3998 39992010-01-08 Eric Seidel <eric@webkit.org> 4000 4001 Reviewed by Adam Barth. 4002 4003 run-javascriptcore-tests needs a --quiet flag 4004 https://bugs.webkit.org/show_bug.cgi?id=33399 4005 4006 Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch. 4007 4008 * Scripts/webkitpy/steps/runtests.py: 4009 40102010-01-08 Andras Becsi <abecsi@inf.u-szeged.hu> 4011 4012 Reviewed by Alexey Proskuryakov. 4013 4014 Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order. 4015 4016 To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize 4017 the time when Apache and WebSocketServer is locked by tests. 4018 Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing, 4019 we need to run http and websocket tests after all other tests. 4020 If one however explicitly specifies the tests to run in the argument list of run-webkit-tests 4021 we need to preserve the given order. 4022 4023 * Scripts/run-webkit-tests: 4024 40252010-01-08 Adam Barth <abarth@webkit.org> 4026 4027 Reviewed by Eric Seidel. 4028 4029 Don't post style-queue pass messages to bugs 4030 https://bugs.webkit.org/show_bug.cgi?id=33404 4031 4032 These messages aren't needed any more now that we have the status 4033 bubble reporting pass events passively. 4034 4035 * Scripts/webkitpy/commands/queues.py: 4036 40372010-01-08 Adam Barth <abarth@webkit.org> 4038 4039 Reviewed by Eric Seidel. 4040 4041 Optimize the number of CPUs used for building Qt and Gtk 4042 https://bugs.webkit.org/show_bug.cgi?id=33394 4043 4044 Instead of hardcoding the number 8, we should read the number of CPUs 4045 from the environment. 4046 4047 * Scripts/webkitpy/executive.py: 4048 * Scripts/webkitpy/webkitport.py: 4049 * Scripts/webkitpy/webkitport_unittest.py: 4050 40512010-01-08 Chris Fleizach <cfleizach@apple.com> 4052 4053 Reviewed by Eric Seidel. 4054 4055 REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot 4056 https://bugs.webkit.org/show_bug.cgi?id=33300 4057 4058 * DumpRenderTree/AccessibilityUIElement.h: 4059 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 4060 (AccessibilityUIElement::AccessibilityUIElement): 4061 (AccessibilityUIElement::~AccessibilityUIElement): 4062 (_accessibilityNotificationCallback): 4063 (AccessibilityUIElement::addNotificationListener): 4064 40652010-01-08 Eric Seidel <eric@webkit.org> 4066 4067 Reviewed by Simon Hausmann. 4068 4069 commit-queue should run run-javascriptcore-tests 4070 https://bugs.webkit.org/show_bug.cgi?id=33376 4071 4072 I also made it run the python and perl unit tests. 4073 4074 * Scripts/webkitpy/steps/runtests.py: 4075 * Scripts/webkitpy/webkitport.py: 4076 40772010-01-07 Andras Becsi <abecsi@inf.u-szeged.hu> 4078 4079 Reviewed by Darin Adler. 4080 4081 Run the http and websocket tests after all other tests. 4082 https://bugs.webkit.org/show_bug.cgi?id=33153 4083 4084 * Scripts/run-webkit-tests: 4085 40862010-01-07 Adam Barth <abarth@webkit.org> 4087 4088 Reviewed by Eric Seidel. 4089 4090 Fix some test-webkitpy expectations 4091 https://bugs.webkit.org/show_bug.cgi?id=33345 4092 4093 I forgot to change these when I added the CheckStyle step. 4094 4095 * Scripts/webkitpy/commands/upload_unittest.py: 4096 40972010-01-07 Adam Barth <abarth@webkit.org> 4098 4099 Reviewed by Eric Seidel. 4100 4101 webkit-patch edit-changelogs (or upload) will open blank files if run outside the root 4102 https://bugs.webkit.org/show_bug.cgi?id=33341 4103 4104 Fix this by moving to the root directory before editing ChangeLogs. 4105 There is a related bug with CheckStyle. 4106 4107 * Scripts/webkitpy/steps/checkstyle.py: 4108 * Scripts/webkitpy/steps/editchangelog.py: 4109 41102010-01-07 Eric Seidel <eric@webkit.org> 4111 4112 Reviewed by Nikolas Zimmermann. 4113 4114 media/unsupported-tracks.html is failing on Snow Leopard Release bot 4115 https://bugs.webkit.org/show_bug.cgi?id=32339 4116 4117 This is a speculative fix. I do not have a Snow Leopard machine to test on 4118 and I've not seen mention of someone being able to reproduce this locally. 4119 4120 Prevent watchdog timer from firing after a test completes but before 4121 the next one starts, causing the error to appear in the next test. 4122 4123 * DumpRenderTree/mac/DumpRenderTree.mm: 4124 (dump): Stop the watchdog before printing #EOF for the test content. 4125 We only need to care about the JavaScript of the test running too long 4126 or some hang in WebCore. Any other failures will be covered by the calling 4127 script's own watchdog timer. 4128 41292010-01-07 Eric Seidel <eric@webkit.org> 4130 4131 Reviewed by Adam Barth. 4132 4133 commit-queue is stuck spinning due to exception 4134 https://bugs.webkit.org/show_bug.cgi?id=33358 4135 4136 * Scripts/webkitpy/commands/queues.py: 4137 - Don't try to stringify the exception. 4138 41392010-01-07 Mark Rowe <mrowe@apple.com> 4140 4141 Reviewed by Jon Honeycutt. 4142 4143 Don't leak a JSStringRef within _accessibilityNotificationCallback. 4144 4145 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 4146 (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up 4147 when it goes out of scope. 4148 41492010-01-07 Simon Fraser <simon.fraser@apple.com> 4150 4151 Reviewed by Darin Adler. 4152 4153 Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement. 4154 4155 * Scripts/do-webcore-rename: 4156 41572010-01-07 Kim Grönholm <kim.gronholm@nomovok.com> 4158 4159 Reviewed by Antti Koivisto. 4160 4161 Wrong state and TouchLists in TouchEvents 4162 https://bugs.webkit.org/show_bug.cgi?id=32878 4163 4164 * DumpRenderTree/qt/EventSenderQt.cpp: 4165 (EventSender::touchStart): 4166 (EventSender::touchEnd): 4167 (EventSender::clearTouchPoints): 4168 * DumpRenderTree/qt/EventSenderQt.h: 4169 41702010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com> 4171 4172 Reviewed by Adam Barth. 4173 4174 Created a module that runs the style package unit tests. 4175 4176 https://bugs.webkit.org/show_bug.cgi?id=32973 4177 4178 * Scripts/test-webkitpy: 4179 * Scripts/webkitpy/style/unittests.py: Added. 4180 41812010-01-07 Adam Barth <abarth@webkit.org> 4182 4183 Reviewed by Maciej Stachowiak. 4184 4185 Don't print a redundant message when confirming a diff 4186 https://bugs.webkit.org/show_bug.cgi?id=33315 4187 4188 Instead of saying "ERROR: User declined" we should just exit because 4189 the use knows they just declined! 4190 4191 * Scripts/webkitpy/steps/confirmdiff.py: 4192 41932010-01-07 Adam Barth <abarth@webkit.org> 4194 4195 Reviewed by Maciej Stachowiak. 4196 4197 Check style before uploading a patch 4198 https://bugs.webkit.org/show_bug.cgi?id=33314 4199 4200 * Scripts/webkitpy/commands/upload.py: 4201 * Scripts/webkitpy/steps/checkstyle.py: 4202 * Scripts/webkitpy/steps/options.py: 4203 42042010-01-07 Adam Barth <abarth@webkit.org> 4205 4206 Reviewed by Maciej Stachowiak. 4207 4208 Add prepare and post to webkit-patch main help 4209 https://bugs.webkit.org/show_bug.cgi?id=33313 4210 4211 * Scripts/webkitpy/commands/upload.py: 4212 42132010-01-07 Eric Seidel <eric@webkit.org> 4214 4215 Reviewed by Adam Barth. 4216 4217 Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red) 4218 https://bugs.webkit.org/show_bug.cgi?id=33290 4219 4220 Add the Chromium builders to our list of core builders and test that our regexps work. 4221 I also updated our regexp testing to make sure we cover all known builders at build.webkit.org. 4222 4223 * Scripts/webkitpy/buildbot.py: 4224 * Scripts/webkitpy/buildbot_unittest.py: 4225 42262010-01-07 Adam Barth <abarth@webkit.org> 4227 4228 Reviewed by Eric Seidel. 4229 4230 bugzilla-tool needs a new name 4231 https://bugs.webkit.org/show_bug.cgi?id=28459 4232 4233 Rename bugzilla-tool to webkit-patch. Also, rename some commands to 4234 make more sense with the new name. 4235 4236 * Scripts/bugzilla-tool: Removed. 4237 * Scripts/webkit-patch: Added. 4238 * Scripts/webkit-tools-completion.sh: 4239 * Scripts/webkitpy/bugzilla_unittest.py: 4240 * Scripts/webkitpy/commands/download.py: 4241 * Scripts/webkitpy/commands/download_unittest.py: 4242 * Scripts/webkitpy/commands/early_warning_system.py: 4243 * Scripts/webkitpy/commands/queries.py: 4244 * Scripts/webkitpy/commands/queues.py: 4245 * Scripts/webkitpy/commands/queues_unittest.py: 4246 * Scripts/webkitpy/commands/upload.py: 4247 * Scripts/webkitpy/commands/upload_unittest.py: 4248 * Scripts/webkitpy/queueengine.py: 4249 * Scripts/webkitpy/steps/completerollout.py: 4250 42512010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com> 4252 4253 Reviewed by Eric Seidel. 4254 4255 Moved style-related modules to webkitpy.style sub-package. 4256 4257 https://bugs.webkit.org/show_bug.cgi?id=32971 4258 4259 * Scripts/check-webkit-style: 4260 - Updated import statement. 4261 4262 * Scripts/test-webkitpy: 4263 - Updated import statements. 4264 4265 * Scripts/webkitpy/cpp_style.py: Removed. 4266 - Moved to webkitpy/style. 4267 4268 * Scripts/webkitpy/cpp_style_unittest.py: Removed. 4269 - Moved to webkitpy/style. 4270 4271 * Scripts/webkitpy/style.py: Removed. 4272 - Moved to webkitpy/style/checker.py. 4273 4274 * Scripts/webkitpy/style/__init__.py: Added. 4275 - Added containing webkitpy directory to package search path. 4276 4277 * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py. 4278 * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py. 4279 - Updated import statement. 4280 4281 * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py. 4282 * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py. 4283 - Update import statement. 4284 4285 * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py. 4286 * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py. 4287 * Scripts/webkitpy/style_unittest.py: Removed. 4288 - Moved to webkitpy/style/checker_unittest.py. 4289 4290 * Scripts/webkitpy/text_style.py: Removed. 4291 - Moved to webkitpy/style. 4292 4293 * Scripts/webkitpy/text_style_unittest.py: Removed. 4294 - Moved to webkitpy/style. 4295 42962010-01-06 Kinuko Yasuda <kinuko@chromium.org> 4297 4298 Reviewed by Eric Seidel. 4299 4300 [Qt] Support the 3rd argument of EventSender.keyDown that 4301 has been recently added to report keyLocation 4302 (see also: https://bugs.webkit.org/show_bug.cgi?id=28247). 4303 https://bugs.webkit.org/show_bug.cgi?id=33250 4304 4305 Test: fast/events/keydown-numpad-keys.html 4306 4307 * DumpRenderTree/qt/EventSenderQt.cpp: 4308 (EventSender::keyDown): 4309 * DumpRenderTree/qt/EventSenderQt.h: 4310 43112010-01-06 Eric Seidel <eric@webkit.org> 4312 4313 Reviewed by Adam Barth. 4314 4315 Add long_help for all common commands. 4316 https://bugs.webkit.org/show_bug.cgi?id=33261 4317 4318 For now these long_helps are pretty basic. 4319 These were all written to just explain the steps 4320 that each command runs. This style long_help could 4321 be made easier by using: 4322 https://bugs.webkit.org/show_bug.cgi?id=33257 4323 4324 * Scripts/webkitpy/commands/download.py: 4325 * Scripts/webkitpy/commands/queries.py: 4326 43272010-01-06 Diego Gonzalez <diego.gonzalez@openbossa.org> 4328 4329 Reviewed by Kenneth Christiansen. 4330 4331 [Qt] Add page zooming support to Qt DumpRenderTree 4332 https://bugs.webkit.org/show_bug.cgi?id=32898 4333 4334 Patch by Kim Grönholm <kim.gronholm@nomovok.com>, 4335 Diego Gonzalez <diego.gonzalez@openbossa.org> and 4336 Afonso Costa <afonso.costa@openbossa.org> 4337 4338 * DumpRenderTree/qt/EventSenderQt.cpp: 4339 (EventSender::zoomPageIn): 4340 (EventSender::zoomPageOut): 4341 * DumpRenderTree/qt/EventSenderQt.h: 4342 43432010-01-06 Eric Seidel <eric@webkit.org> 4344 4345 No review, just adding Mike Belshe's new bugzilla email at his request. 4346 4347 * Scripts/webkitpy/committers.py: 4348 43492010-01-06 Eric Seidel <eric@webkit.org> 4350 4351 Unreviewed. Rolling out r52869 and r52853 due to bot 4352 and local run-webkit-test failures 4353 4354 REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot 4355 https://bugs.webkit.org/show_bug.cgi?id=33256 4356 4357 The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153 4358 4359 * Scripts/run-webkit-tests: 4360 43612010-01-06 Eric Seidel <eric@webkit.org> 4362 4363 Unreviewed "build" fix. Just adding missing include. 4364 4365 bugzilla-tool rollout --complete-rollout should make a nicer bug comment 4366 https://bugs.webkit.org/show_bug.cgi?id=29212 4367 4368 * Scripts/webkitpy/steps/completerollout.py: 4369 43702010-01-06 Eric Seidel <eric@webkit.org> 4371 4372 Reviewed by Adam Barth. 4373 4374 bugzilla-tool rollout --complete-rollout should make a nicer bug comment 4375 https://bugs.webkit.org/show_bug.cgi?id=29212 4376 4377 * Scripts/webkitpy/bugzilla.py: 4378 - Make reopen_bug robust against the bug already being open. 4379 * Scripts/webkitpy/commands/download.py: 4380 - Remove dead code from Rollout. 4381 * Scripts/webkitpy/steps/completerollout.py: 4382 - Improve the rollout comment. 4383 43842010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu> 4385 4386 Reviewed by Darin Adler. 4387 4388 Set isHttpdOpen to 0 if pidfile does not exist for some reason. 4389 Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256. 4390 4391 * Scripts/run-webkit-tests: 4392 43932010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu> 4394 4395 Reviewed by Darin Adler. 4396 4397 Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(), 4398 and remove the httpd's pidfile directory if httpd terminated. 4399 4400 * Scripts/run-webkit-tests: 4401 44022010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com> 4403 4404 Reviewed by David Levin. 4405 4406 Refactored check-webkit-style's argument parser to not rely 4407 on global state, and improved its error handling and unit 4408 test coverage. 4409 4410 https://bugs.webkit.org/show_bug.cgi?id=32966 4411 4412 * Scripts/check-webkit-style: 4413 - Adjusted to use new argument parser. 4414 4415 * Scripts/webkitpy/cpp_style.py: 4416 - Changed _CppStyleState to accept an array of filter rules 4417 instead of a comma-delimited string. 4418 - Eliminated cpp_style._DEFAULT_FILTER_RULES. 4419 - Eliminated cpp_style._USAGE. 4420 4421 * Scripts/webkitpy/cpp_style_unittest.py: 4422 - Updated test_filter() and test_default_filter(). 4423 4424 * Scripts/webkitpy/style.py: 4425 - Converted style._USAGE to create_usage(). 4426 - Corrected usage instructions by removing 0 as a valid 4427 --verbose flag value. 4428 - Removed use_webkit_styles(). 4429 - Added ProcessorOptions class. 4430 - Added ArgumentDefaults class. 4431 - Added ArgumentPrinter class. 4432 - Removed parse_arguments and added ArgumentParser class. 4433 - Moved exit_with_usage() and exit_with_categories() into 4434 ArgumentParser. 4435 - Refactored parse_arguments() as ArgumentParser.parse(). 4436 - Improved parser error handling. 4437 4438 * Scripts/webkitpy/style_unittest.py: 4439 - Added DefaultArgumentsTest class. 4440 - Addressed FIXME to check style.WEBKIT_FILTER_RULES 4441 against style.STYLE_CATEGORIES. 4442 - Added ArgumentPrinterTest class. 4443 - Added ArgumentParserTest class and rewrote parser unit tests. 4444 44452010-01-05 Adam Roben <aroben@apple.com> 4446 4447 Test that it's safe to call IWebView::close when 4448 IWebView::initWithFrame hasn't been called 4449 4450 Part of <http://webkit.org/b/32827> Crash when calling 4451 IWebView::close, then releasing the WebView, without calling 4452 DestroyWindow 4453 4454 Reviewed by Steve Falkenburg. 4455 4456 * WebKitAPITest/tests/WebViewDestruction.cpp: 4457 (WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close 4458 without ever calling IWebView::initWithFrame and tests that we don't 4459 crash or leak. 4460 44612010-01-05 Adam Roben <aroben@apple.com> 4462 4463 Add more WebViewDestruction tests 4464 4465 Fixes <http://webkit.org/b/33216>. 4466 4467 Reviewed by Eric Seidel. 4468 4469 * WebKitAPITest/tests/WebViewDestruction.cpp: 4470 (WebKitAPITest::NoInitWithFrame): 4471 (WebKitAPITest::CloseThenDestroyViewWindow): 4472 (WebKitAPITest::DestroyViewWindowThenClose): 4473 (WebKitAPITest::DestroyHostWindow): 4474 (WebKitAPITest::DestroyHostWindowThenClose): 4475 (WebKitAPITest::CloseThenDestroyHostWindow): 4476 Added these tests that exercise tearing down a WebView in various 4477 ways, all of which we eventually want to have work. Some of them 4478 currently crash or leak. 4479 44802010-01-05 Robert Hogan <robert@roberthogan.net> 4481 4482 Reviewed by Eric Seidel. 4483 4484 [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT 4485 4486 If you're working from a --minimal or --no-svg build and make changes to the 4487 DRT, then recompile, the build will fail. 4488 4489 This is because the current behavior at build time is to assume that the 4490 previous Qt build supported SVG and consequently delete libQtWebKit.so. 4491 Unfortunately, just deleting libQtWebKit.so will not cause the library to 4492 re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the 4493 linking phase, and attempt to link the DRT with libQtWebKit.so absent. This 4494 results in a link failure on the DRT. 4495 4496 Since re-linking libQtWebKit can take up to ten minutes and should be avoided 4497 in cases where not actually required, remove the assumption that 4498 the previous Qt build supported SVG, and amend the symbol detection to look for 4499 a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks 4500 for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'. 4501 4502 https://bugs.webkit.org/show_bug.cgi?id=32992 4503 4504 * Scripts/webkitdirs.pm: 4505 45062010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com> 4507 4508 Reviewed by David Kilzer. 4509 4510 Switched to generating list of Perl unit test files dynamically, 4511 instead of explicitly. 4512 4513 https://bugs.webkit.org/show_bug.cgi?id=33200 4514 4515 * Scripts/test-webkitperl: 4516 45172010-01-05 Yael Aharon <yael.aharon@nokia.com> 4518 4519 Reviewed by Kenneth Rohde Christiansen. 4520 4521 [Qt] Reimplement EventSender::leapForward 4522 https://bugs.webkit.org/show_bug.cgi?id=33114 4523 4524 Follow Windows implementation of leapForward. When leapForward is called, 4525 messages are queued and posted after the timeout. A new event loop is created to 4526 handle those messages and the additional messages that are created as a result. 4527 4528 * DumpRenderTree/qt/DumpRenderTree.pro: 4529 * DumpRenderTree/qt/EventSenderQt.cpp: 4530 (EventSender::EventSender): 4531 (EventSender::mouseDown): 4532 (EventSender::mouseUp): 4533 (EventSender::mouseMoveTo): 4534 (EventSender::leapForward): 4535 (EventSender::sendOrQueueEvent): 4536 (EventSender::replaySavedEvents): 4537 (EventSender::eventFilter): 4538 * DumpRenderTree/qt/EventSenderQt.h: 4539 45402010-01-05 Adam Barth <abarth@webkit.org> 4541 4542 Reviewed by Darin Adler. 4543 4544 Fix obscure queue crash in queueengine 4545 https://bugs.webkit.org/show_bug.cgi?id=33196 4546 4547 Sometimes we get an exception that can't be stringified. For example: 4548 4549 AttributeError: 'ParseError' object has no attribute 'msg' 4550 4551 In these cases, the whole queue dies because we're in the global 4552 exception handler. Instead of dieing here, we should just print a less 4553 informative message to the console. We're already printing the whole 4554 backtrace anyway, so there's not much point to stringifying the 4555 exception anyway. 4556 4557 * Scripts/webkitpy/queueengine.py: 4558 45592010-01-05 Dominic Mazzoni <dmazzoni@google.com> 4560 4561 Reviewed by Darin Adler. 4562 4563 https://bugs.webkit.org/show_bug.cgi?id=32571 4564 4565 For an object with an aria role of "checkbox" or "radiobutton", 4566 use the "aria-checked" attribute to determine if it's checked. 4567 These changes add an isChecked() method to AccessibilityUIElement 4568 so that we can check for this property from a layout test. 4569 4570 * DumpRenderTree/AccessibilityUIElement.cpp: 4571 (getIsCheckedCallback): 4572 (AccessibilityUIElement::getJSClass): 4573 * DumpRenderTree/AccessibilityUIElement.h: 4574 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 4575 (AccessibilityUIElement::isChecked): 4576 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 4577 (AccessibilityUIElement::isChecked): 4578 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 4579 (AccessibilityUIElement::isChecked): 4580 45812010-01-05 David Levin <levin@chromium.org> 4582 4583 Reviewed by Darin Adler. 4584 4585 Having a comment for the #endif for a header guard is not required WebKit style. 4586 https://bugs.webkit.org/show_bug.cgi?id=33214 4587 4588 * Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit 4589 early when it has all the needed information to continue. 4590 * Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests. 4591 45922010-01-05 Adam Roben <aroben@apple.com> 4593 4594 Share more code in the WebViewDestruction tests 4595 4596 Part of <http://webkit.org/b/33212> Small fixes/improvements to 4597 WebKitAPITest 4598 4599 Reviewed by Sam Weinig. 4600 4601 * WebKitAPITest/tests/WebViewDestruction.cpp: 4602 (WebKitAPITest::createAndInitializeWebView): Renamed from 4603 createWebView. Now initializes the HostWindow and returns the 4604 WebView's HWND via an out-parameter. 4605 (WebKitAPITest::finishWebViewDestructionTest): Added. Code came from 4606 the CloseWithoutDestroyWindow test. 4607 (WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from 4608 CloseWithoutDestroyWindow and changed to use the new functions. 4609 (WebKitAPITest::MainFrameAfterClose): Changed to use the new 4610 functions. 4611 (WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from 4612 NoCloseOrDestroyWindow and changed to use the new functions. 4613 46142010-01-05 Adam Roben <aroben@apple.com> 4615 4616 Don't show HostWindows by default 4617 4618 This was making WebKitAPITest very flashy as windows appeared and 4619 disappeared. 4620 4621 Part of <http://webkit.org/b/33212> Small fixes/improvements to 4622 WebKitAPITest 4623 4624 Reviewed by Sam Weinig. 4625 4626 * WebKitAPITest/HostWindow.cpp: 4627 (WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style 4628 from the window. 4629 46302010-01-05 Adam Roben <aroben@apple.com> 4631 4632 Don't hang in WebKitAPITest if no messages have been posted 4633 4634 Part of <http://webkit.org/b/33212> Small fixes/improvements to 4635 WebKitAPITest 4636 4637 Reviewed by Sam Weinig. 4638 4639 * WebKitAPITest/tests/WebViewDestruction.cpp: 4640 (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage 4641 to avoid hanging if no messages have been posted. 4642 46432010-01-05 Adam Roben <aroben@apple.com> 4644 4645 Fix WebKitCreateInstance helper 4646 4647 Part of <http://webkit.org/b/33212> Small fixes/improvements to 4648 WebKitAPITest 4649 4650 Reviewed by Sam Weinig. 4651 4652 * WebKitAPITest/tests/WebViewDestruction.cpp: 4653 (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight 4654 through, instead of taking its address. 4655 46562010-01-04 Maciej Stachowiak <mjs@apple.com> 4657 4658 Reviewed by Darin Fisher. 4659 4660 Reorganize, document and rename OS() platform macros. 4661 https://bugs.webkit.org/show_bug.cgi?id=33198 4662 4663 Adapt to name changes. 4664 4665 * DumpRenderTree/DumpRenderTree.h: 4666 * DumpRenderTree/config.h: 4667 46682010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com> 4669 4670 Reviewed by Eric Seidel. 4671 4672 Minor improvements to test-webkit-scripts, as suggested 4673 by an earlier review. 4674 4675 https://bugs.webkit.org/show_bug.cgi?id=33125 4676 4677 * Scripts/test-webkit-scripts: 4678 - Used OptionParser class instead of getopt.getopt(). 4679 - Created main() method for __main__ block. 4680 - Enclosed functions in a class. 4681 46822010-01-05 Chris Fleizach <cfleizach@apple.com> 4683 4684 No review. Fix DRT breakage on Tiger/Leopard. 4685 4686 Add ARIA "Live Region" support 4687 https://bugs.webkit.org/show_bug.cgi?id=33117 4688 4689 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 4690 46912010-01-04 Chris Fleizach <cfleizach@apple.com> 4692 4693 Reviewed by Darin Adler. 4694 4695 Add ARIA "Live Region" support 4696 https://bugs.webkit.org/show_bug.cgi?id=33117 4697 4698 * DumpRenderTree/AccessibilityUIElement.cpp: 4699 (indexOfChildCallback): 4700 (boolAttributeValueCallback): 4701 (stringAttributeValueCallback): 4702 (addNotificationListenerCallback): 4703 (AccessibilityUIElement::getJSClass): 4704 * DumpRenderTree/AccessibilityUIElement.h: 4705 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 4706 (AccessibilityUIElement::indexOfChild): 4707 (AccessibilityUIElement::stringAttributeValue): 4708 (AccessibilityUIElement::boolAttributeValue): 4709 (AccessibilityUIElement::addNotificationListener): 4710 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 4711 (AccessibilityUIElement::indexOfChild): 4712 (AccessibilityUIElement::stringAttributeValue): 4713 (AccessibilityUIElement::boolAttributeValue): 4714 (_accessibilityNotificationCallback): 4715 (AccessibilityUIElement::addNotificationListener): 4716 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 4717 (AccessibilityUIElement::indexOfChild): 4718 (AccessibilityUIElement::stringAttributeValue): 4719 (AccessibilityUIElement::boolAttributeValue): 4720 (AccessibilityUIElement::addNotificationListener): 4721 47222010-01-04 Eric Seidel <eric@webkit.org> 4723 4724 Reviewed by Adam Barth. 4725 4726 bugzilla-tool rollout should require a reason 4727 https://bugs.webkit.org/show_bug.cgi?id=30810 4728 4729 * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic. 4730 * Scripts/webkitpy/changelogs_unittest.py: Test reason support. 4731 * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument 4732 * Scripts/webkitpy/commands/download_unittest.py: pass required reason 4733 * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert 4734 47352010-01-04 Jon Honeycutt <jhoneycutt@apple.com> 4736 4737 MSAA: <select> elements should broadcast value change events 4738 4739 https://bugs.webkit.org/show_bug.cgi?id=33088 4740 4741 <rdar://problem/7332364> 4742 4743 Reviewed by Darin Adler. 4744 4745 * DumpRenderTree/AccessibilityController.cpp: 4746 (logValueChangeEventsCallback): 4747 Start logging value change events. 4748 (AccessibilityController::getJSClass): 4749 Add a "logValueChangeEvents" to the AccessibilityController's JS class 4750 definition. 4751 (AccessibilityController::resetToConsistentState): 4752 Disable logging of value change events. 4753 4754 * DumpRenderTree/AccessibilityController.h: 4755 Declare setLogValueChangeEvents(), and add a member variable for the 4756 value change event hook. 4757 4758 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 4759 (AccessibilityController::setLogValueChangeEvents): 4760 Stubbed. 4761 4762 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 4763 (AccessibilityController::setLogValueChangeEvents): 4764 Stubbed. 4765 4766 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 4767 (AccessibilityController::AccessibilityController): 4768 Initialize new member var. 4769 (AccessibilityController::~AccessibilityController): 4770 Disable logging of value change events. 4771 (logEventProc): 4772 When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object 4773 and its value. 4774 (AccessibilityController::setLogValueChangeEvents): 4775 If disabling logging, unhook the event, and clear the event hook 4776 member var. Otherwise, query for the root element to enable 4777 accessibility, and hook EVENT_OBJECT_VALUECHANGE. 4778 47792010-01-04 Adam Barth <abarth@webkit.org> 4780 4781 Reviewed by Eric Seidel. 4782 4783 long_help for submit-patch 4784 https://bugs.webkit.org/show_bug.cgi?id=33184 4785 4786 * Scripts/webkitpy/commands/upload.py: 4787 47882010-01-04 Adam Barth <abarth@webkit.org> 4789 4790 Reviewed by Eric Seidel. 4791 4792 commit-queue can wrongly reject patches if the buildbots are behind 4793 https://bugs.webkit.org/show_bug.cgi?id=30098 4794 4795 Check to make sure we can currently build and test before trying to 4796 land a patch. 4797 4798 * Scripts/webkitpy/commands/queues.py: 4799 48002010-01-04 Adam Roben <aroben@apple.com> 4801 4802 Add a test harness for the Windows WebKit API, and a few tests 4803 4804 We currently only have tests for a handful of bugs regarding WebView 4805 destruction, but more tests can easily be added later. Eventually 4806 we'll run these tests as part of run-webkit-tests. 4807 4808 Fixes <http://webkit.org/b/33167>. 4809 4810 Reviewed by Sam Weinig. 4811 4812 * WebKitAPITest/HostWindow.cpp: Added. 4813 (WebKitAPITest::HostWindow::HostWindow): Initialize m_window. 4814 (WebKitAPITest::HostWindow::~HostWindow): Destroy our window if 4815 needed. 4816 (WebKitAPITest::HostWindow::initialize): Create our window. 4817 (WebKitAPITest::HostWindow::clientRect): Return our window's client 4818 rect. 4819 (WebKitAPITest::HostWindow::registerWindowClass): Does what it says. 4820 (WebKitAPITest::HostWindow::wndProc): Just call through to 4821 DefWindowProcW. 4822 4823 * WebKitAPITest/HostWindow.h: Added. 4824 (WebKitAPITest::HostWindow::window): Simple getter. 4825 4826 * WebKitAPITest/Test.h: Added. This file defines some macros useful 4827 for writing tests. 4828 4829 * WebKitAPITest/TestsController.cpp: Added. 4830 (WebKitAPITest::TestsController::TestsController): Initialize our 4831 members. 4832 (WebKitAPITest::TestsController::shared): Return the shared instance. 4833 (WebKitAPITest::TestsController::runAllTests): Run a message pump 4834 until a WM_QUIT message is received, then return whether all tests 4835 succeeded. 4836 (WebKitAPITest::TestsController::addTest): Add the test to m_tests and 4837 start running tests soon. 4838 (WebKitAPITest::TestsController::testFailed): Record the failure and 4839 print a message about it to stdout. 4840 (WebKitAPITest::TestsController::runNextTest): If we don't have any 4841 tests to run, post a WM_QUIT message to stop the message pump. 4842 Otherwise, run the test and print whether it passed, then schedule the 4843 next test. 4844 (WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer 4845 to run the next test. 4846 (WebKitAPITest::TestsController::registerWindowClass): Does what it 4847 says. 4848 (WebKitAPITest::TestsController::wndProc): If the runNextTestTimer 4849 fired, call runNextTest(). Pass everything else through to 4850 DefWindowProcW. 4851 4852 * WebKitAPITest/TestsController.h: Added. 4853 4854 * WebKitAPITest/WebKitAPITest.vcproj: Added. 4855 4856 * WebKitAPITest/WebKitAPITestCommon.vsprops: Added. 4857 4858 * WebKitAPITest/main.cpp: Added. 4859 (main): (Mostly) just calls TestsController::runAllTests. 4860 4861 * WebKitAPITest/tests/WebViewDestruction.cpp: Added. 4862 (WebKitAPITest::WebKitCreateInstance): Helper function template to 4863 call through to the real WebKitCreateInstance. 4864 (WebKitAPITest::webViewCount): Helper function to call through to 4865 IWebKitStatistics::webViewCount. 4866 (WebKitAPITest::createWebView): Helper function to create a WebView 4867 and put it inside a HostWindow. 4868 (WebKitAPITest::runMessagePump): Helper function to run a message pump 4869 for a specified number of milliseconds, or until a WM_QUIT message is 4870 received. 4871 (WebKitAPITest::CloseWithoutDestroyWindow): Test for 4872 <http://webkit.org/b/32827>. 4873 (WebKitAPITest::MainFrameAfterClose): Test for 4874 <http://webkit.org/b/32868>. 4875 (WebKitAPITest::NoCloseOrDestroyWindow): Test for 4876 <http://webkit.org/b/33162>. 4877 48782010-01-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 4879 4880 Reviewed by David Kilzer. 4881 4882 Add support for Git's "diff.mnemonicprefix" config option to WebKitTools 4883 4884 https://bugs.webkit.org/show_bug.cgi?id=32820 4885 4886 * Scripts/VCSUtils.pm: 4887 * Scripts/svn-apply: 4888 * Scripts/svn-unapply: 4889 * Scripts/test-webkitperl: Run gitdiff2svndiff test 4890 * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added. 4891 * Scripts/webkitpy/diff_parser.py: 4892 * Scripts/webkitpy/diff_parser_unittest.py: 4893 48942010-01-04 Chris Jerdonek <chris.jerdonek@gmail.com> 4895 4896 Reviewed by David Kilzer. 4897 4898 Divided the Perl unit tests into separate files and put 4899 them in a separate directory, and renamed test-webkit-perl 4900 to test-webkitperl. 4901 4902 https://bugs.webkit.org/show_bug.cgi?id=33124 4903 4904 * Scripts/VCSUtils.pm: 4905 - Renamed generateRunPatchCommand() to generatePatchCommand(). 4906 4907 * Scripts/VCSUtils_unittest.pl: Removed. 4908 - Divided into three files in Scripts/webkitperl/VCSUtils_unittest. 4909 4910 * Scripts/test-webkit-perl: Removed. 4911 - Renamed to test-webkitperl. 4912 4913 * Scripts/test-webkit-scripts: 4914 - Updated paths to test-webkitpy and test-webkitperl. 4915 4916 * Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl. 4917 - Added paths to new test files. 4918 4919 * Scripts/webkitperl: Added. 4920 * Scripts/webkitperl/VCSUtils_unittest: Added. 4921 * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added. 4922 * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added. 4923 * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl. 4924 49252010-01-04 Eric Seidel <eric@webkit.org> 4926 4927 Reviewed by Adam Barth. 4928 4929 Make bugzilla-tool rollout include a bug link in the ChangeLog entry 4930 https://bugs.webkit.org/show_bug.cgi?id=33146 4931 4932 One more step towards better rollouts. 4933 4934 * Scripts/webkitpy/changelogs.py: 4935 * Scripts/webkitpy/changelogs_unittest.py: 4936 * Scripts/webkitpy/steps/preparechangelogforrevert.py: 4937 49382010-01-04 Adam Barth <abarth@webkit.org> 4939 4940 Reviewed by Eric Seidel. 4941 4942 Sort the step options 4943 https://bugs.webkit.org/show_bug.cgi?id=33144 4944 4945 * Scripts/webkitpy/steps/options.py: 4946 49472010-01-04 Eric Seidel <eric@webkit.org> 4948 4949 Reviewed by Adam Barth. 4950 4951 Need support for longer text in per-command help 4952 https://bugs.webkit.org/show_bug.cgi?id=33143 4953 4954 Add some minimal additional help to land-diff and 4955 pave the way for adding better help to all commands. 4956 4957 * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff 4958 * Scripts/webkitpy/multicommandtool.py: support long_help 4959 * Scripts/webkitpy/multicommandtool_unittest.py: test long_help 4960 49612010-01-04 Adam Barth <abarth@webkit.org> 4962 4963 Reviewed by Eric Seidel. 4964 4965 Add unit test for MarkBugFixed 4966 https://bugs.webkit.org/show_bug.cgi?id=33142 4967 4968 MarkBugFixed is way behind in command technology, but it still needs a 4969 unit test, as the FIXME commands. 4970 4971 Also, remove mark-bug-fixed and create-bug from main help since we have 4972 more modern commands to replace them. 4973 4974 * Scripts/webkitpy/commands/upload.py: 4975 * Scripts/webkitpy/commands/upload_unittest.py: 4976 * Scripts/webkitpy/mock_bugzillatool.py: 4977 49782010-01-04 Adam Barth <abarth@webkit.org> 4979 4980 Reviewed by Eric Seidel. 4981 4982 Add missing unit test for CommitMessageForCurrentDiff 4983 https://bugs.webkit.org/show_bug.cgi?id=33141 4984 4985 * Scripts/webkitpy/commands/upload.py: 4986 * Scripts/webkitpy/commands/upload_unittest.py: 4987 49882010-01-04 Adam Barth <abarth@webkit.org> 4989 4990 Reviewed by Eric Seidel. 4991 4992 Remove raw_input from queues in favor of user.prompt 4993 https://bugs.webkit.org/show_bug.cgi?id=33140 4994 4995 This lets up properly mock out the user interaction instead of hacking 4996 around it with the options. 4997 4998 * Scripts/webkitpy/commands/queues.py: 4999 * Scripts/webkitpy/commands/queuestest.py: 5000 50012010-01-04 Eric Seidel <eric@webkit.org> 5002 5003 Reviewed by Adam Barth. 5004 5005 bugzilla-tool should not require users to install mechanize 5006 https://bugs.webkit.org/show_bug.cgi?id=32635 5007 5008 * Scripts/webkitpy/__init__.py: Add missing declaration for ClientForm (which mechanize requires). 5009 50102010-01-04 Eric Seidel <eric@webkit.org> 5011 5012 Reviewed by Adam Barth. 5013 5014 bugzilla-tool should not require users to install mechanize 5015 https://bugs.webkit.org/show_bug.cgi?id=32635 5016 5017 Use the nifty "autoinstall" module from Daniel Krech: 5018 http://pypi.python.org/pypi/autoinstall/0.2 5019 http://code.google.com/p/pyautoinstall/ 5020 It's available under a WebKit-compatible BSD license. 5021 5022 * Scripts/webkitpy/__init__.py: 5023 - bind "mechanize" to an autoinstall importer which will 5024 auto-download mechanize if necessary. 5025 * Scripts/webkitpy/autoinstall.py: Added. 5026 * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize 5027 * Scripts/webkitpy/statusbot.py: ditto. 5028 * Scripts/webkitpy/webkit_mechanize.py: Removed. 5029 50302010-01-04 Adam Barth <abarth@webkit.org> 5031 5032 Reviewed by Eric Seidel. 5033 5034 [bzt] Move AbstractSequencedCommand to a more general location 5035 https://bugs.webkit.org/show_bug.cgi?id=33137 5036 5037 I do what the FIXME tell me to do. 5038 5039 * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added. 5040 * Scripts/webkitpy/commands/download.py: 5041 * Scripts/webkitpy/commands/upload.py: 5042 50432010-01-04 Adam Barth <abarth@webkit.org> 5044 5045 Reviewed by Eric Seidel. 5046 5047 Rename StatusBot to StatusServer 5048 https://bugs.webkit.org/show_bug.cgi?id=33139 5049 5050 It's not a bot. It's a server. 5051 5052 * Scripts/bugzilla-tool: 5053 * Scripts/webkitpy/bugzilla.py: 5054 * Scripts/webkitpy/commands/early_warning_system.py: 5055 * Scripts/webkitpy/commands/queues.py: 5056 * Scripts/webkitpy/mock_bugzillatool.py: 5057 * Scripts/webkitpy/queueengine.py: 5058 * Scripts/webkitpy/statusbot.py: Removed. 5059 50602010-01-04 Adam Barth <abarth@webkit.org> 5061 5062 Reviewed by Eric Seidel. 5063 5064 [bzt] submit-pach should have a -o/--open option to open the bug after submit 5065 https://bugs.webkit.org/show_bug.cgi?id=33136 5066 5067 Python makes this very easy. 5068 5069 * Scripts/webkitpy/mock_bugzillatool.py: 5070 * Scripts/webkitpy/steps/options.py: 5071 * Scripts/webkitpy/steps/postdiff.py: 5072 * Scripts/webkitpy/user.py: 5073 50742010-01-04 Adam Barth <abarth@webkit.org> 5075 5076 Reviewed by Eric Seidel. 5077 5078 [bzt] Move steps to a submodule 5079 https://bugs.webkit.org/show_bug.cgi?id=33135 5080 5081 For great victory. This will probably introduce some regressions 5082 because our test coverage isn't perfect, but I've tried to be careful. 5083 5084 * Scripts/test-webkitpy: 5085 * Scripts/webkitpy/buildsteps.py: Removed. 5086 * Scripts/webkitpy/buildsteps_unittest.py: Removed. 5087 * Scripts/webkitpy/commands/download.py: 5088 * Scripts/webkitpy/commands/upload.py: 5089 * Scripts/webkitpy/steps/__init__.py: Added. 5090 * Scripts/webkitpy/steps/abstractstep.py: Added. 5091 * Scripts/webkitpy/steps/applypatch.py: Added. 5092 * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added. 5093 * Scripts/webkitpy/steps/build.py: Added. 5094 * Scripts/webkitpy/steps/checkstyle.py: Added. 5095 * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added. 5096 * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added. 5097 * Scripts/webkitpy/steps/closebug.py: Added. 5098 * Scripts/webkitpy/steps/closebugforlanddiff.py: Added. 5099 * Scripts/webkitpy/steps/closepatch.py: Added. 5100 * Scripts/webkitpy/steps/commit.py: Added. 5101 * Scripts/webkitpy/steps/completerollout.py: Added. 5102 * Scripts/webkitpy/steps/confirmdiff.py: Added. 5103 * Scripts/webkitpy/steps/createbug.py: Added. 5104 * Scripts/webkitpy/steps/editchangelog.py: Added. 5105 * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added. 5106 * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added. 5107 * Scripts/webkitpy/steps/metastep.py: Added. 5108 * Scripts/webkitpy/steps/obsoletepatches.py: Added. 5109 * Scripts/webkitpy/steps/options.py: Added. 5110 * Scripts/webkitpy/steps/postdiff.py: Added. 5111 * Scripts/webkitpy/steps/preparechangelog.py: Added. 5112 * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added. 5113 * Scripts/webkitpy/steps/promptforbugortitle.py: Added. 5114 * Scripts/webkitpy/steps/revertrevision.py: Added. 5115 * Scripts/webkitpy/steps/runtests.py: Added. 5116 * Scripts/webkitpy/steps/steps_unittest.py: Added. 5117 * Scripts/webkitpy/steps/update.py: Added. 5118 * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added. 5119 * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added. 5120 * Scripts/webkitpy/stepsequence.py: 5121 51222010-01-04 Daniel Bates <dbates@webkit.org> 5123 5124 Reviewed by Eric Seidel. 5125 5126 https://bugs.webkit.org/show_bug.cgi?id=33097 5127 5128 Cleans up the File menu to better conform to the File menu in Safari 5129 both in terms of options and keyboard shortcuts. Adds a "Quit" menu 5130 options to close all open windows. Also, renames the Tools menu to 5131 Develop. 5132 5133 * QtLauncher/main.cpp: 5134 (MainWindow::setupUI): 5135 51362010-01-04 Daniel Bates <dbates@webkit.org> 5137 5138 https://bugs.webkit.org/show_bug.cgi?id=33039 5139 5140 Unreviewed fix. 5141 5142 * Scripts/webkitpy/credentials.py: 5143 * Scripts/webkitpy/credentials_unittest.py: 5144 51452010-01-04 Daniel Bates <dbates@webkit.org> 5146 5147 Reviewed by Eric Seidel. 5148 5149 https://bugs.webkit.org/show_bug.cgi?id=33039 5150 5151 [bzt] Second attempt to fix an issue where bugzilla-tool dies 5152 when the keychain lookup fails to find an entry for bugs.webkit.org. 5153 5154 * Scripts/webkitpy/credentials.py: 5155 * Scripts/webkitpy/credentials_unittest.py: 5156 51572010-01-04 Eric Seidel <eric@webkit.org> 5158 5159 Reviewed by Adam Barth. 5160 5161 Make Rollout an AbstractSequencedCommmand 5162 https://bugs.webkit.org/show_bug.cgi?id=33133 5163 5164 As suggested by Adam in: 5165 https://bugs.webkit.org/show_bug.cgi?id=33131#c2 5166 5167 * Scripts/webkitpy/commands/download.py: 5168 51692010-01-04 Eric Seidel <eric@webkit.org> 5170 5171 Reviewed by Adam Barth. 5172 5173 Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses 5174 https://bugs.webkit.org/show_bug.cgi?id=33131 5175 5176 Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command 5177 but for now we just deploy it everywhere and don't try to fix up the few valid uses 5178 of Command. 5179 5180 * Scripts/webkitpy/commands/download.py: 5181 * Scripts/webkitpy/commands/queries.py: 5182 * Scripts/webkitpy/commands/upload.py: 5183 * Scripts/webkitpy/multicommandtool.py: 5184 51852010-01-03 Adam Barth <abarth@webkit.org> 5186 5187 Unreviewed "build" fix. Need to import ScriptError. 5188 5189 * Scripts/webkitpy/buildsteps.py: 5190 51912010-01-03 Adam Barth <abarth@webkit.org> 5192 5193 Reviewed by Eric Seidel. 5194 5195 [bzt] Make it easier to run submit-patch when previous run cancelled 5196 https://bugs.webkit.org/show_bug.cgi?id=33070 5197 5198 This patch renames create-review to submit-patch (as requested by 5199 Maciej). 5200 5201 This patch makes it easier to run submit-patch after the user has 5202 already cancelled a previous run of submit-patch by detecting when we 5203 already have ChangeLogs and reading the bug number from them (and not 5204 attempting to recreate them). Aside from performance and the extra 5205 edit step, this command should not subsume post-dif. 5206 5207 Also, added a --email command line argument so that the output of 5208 prepare-ChangeLog makes sense when it can't find the user's email 5209 address. 5210 5211 * Scripts/webkitpy/bugzilla.py: 5212 * Scripts/webkitpy/buildsteps.py: 5213 * Scripts/webkitpy/commands/upload.py: 5214 * Scripts/webkitpy/commands/upload_unittest.py: 5215 * Scripts/webkitpy/mock_bugzillatool.py: 5216 * Scripts/webkitpy/user.py: 5217 52182010-01-03 Eric Seidel <eric@webkit.org> 5219 5220 Reviewed by Adam Barth. 5221 5222 Rename Scripts/modules to Scripts/webkitpy 5223 https://bugs.webkit.org/show_bug.cgi?id=33128 5224 5225 Just search-replace and svn mv commands. 5226 5227 * Scripts/bugzilla-tool: 5228 * Scripts/check-webkit-style: 5229 * Scripts/modules: Removed. 5230 * Scripts/modules/BeautifulSoup.py: Removed. 5231 * Scripts/modules/__init__.py: Removed. 5232 * Scripts/modules/bugzilla.py: Removed. 5233 * Scripts/modules/bugzilla_unittest.py: Removed. 5234 * Scripts/modules/buildbot.py: Removed. 5235 * Scripts/modules/buildbot_unittest.py: Removed. 5236 * Scripts/modules/buildsteps.py: Removed. 5237 * Scripts/modules/buildsteps_unittest.py: Removed. 5238 * Scripts/modules/changelogs.py: Removed. 5239 * Scripts/modules/changelogs_unittest.py: Removed. 5240 * Scripts/modules/commands: Removed. 5241 * Scripts/modules/commands/__init__.py: Removed. 5242 * Scripts/modules/commands/commandtest.py: Removed. 5243 * Scripts/modules/commands/download.py: Removed. 5244 * Scripts/modules/commands/download_unittest.py: Removed. 5245 * Scripts/modules/commands/early_warning_system.py: Removed. 5246 * Scripts/modules/commands/early_warning_system_unittest.py: Removed. 5247 * Scripts/modules/commands/queries.py: Removed. 5248 * Scripts/modules/commands/queries_unittest.py: Removed. 5249 * Scripts/modules/commands/queues.py: Removed. 5250 * Scripts/modules/commands/queues_unittest.py: Removed. 5251 * Scripts/modules/commands/queuestest.py: Removed. 5252 * Scripts/modules/commands/upload.py: Removed. 5253 * Scripts/modules/commands/upload_unittest.py: Removed. 5254 * Scripts/modules/comments.py: Removed. 5255 * Scripts/modules/committers.py: Removed. 5256 * Scripts/modules/committers_unittest.py: Removed. 5257 * Scripts/modules/cpp_style.py: Removed. 5258 * Scripts/modules/cpp_style_unittest.py: Removed. 5259 * Scripts/modules/credentials.py: Removed. 5260 * Scripts/modules/credentials_unittest.py: Removed. 5261 * Scripts/modules/diff_parser.py: Removed. 5262 * Scripts/modules/diff_parser_unittest.py: Removed. 5263 * Scripts/modules/executive.py: Removed. 5264 * Scripts/modules/executive_unittest.py: Removed. 5265 * Scripts/modules/grammar.py: Removed. 5266 * Scripts/modules/mock.py: Removed. 5267 * Scripts/modules/mock_bugzillatool.py: Removed. 5268 * Scripts/modules/multicommandtool.py: Removed. 5269 * Scripts/modules/multicommandtool_unittest.py: Removed. 5270 * Scripts/modules/outputcapture.py: Removed. 5271 * Scripts/modules/patchcollection.py: Removed. 5272 * Scripts/modules/queueengine.py: Removed. 5273 * Scripts/modules/queueengine_unittest.py: Removed. 5274 * Scripts/modules/scm.py: Removed. 5275 * Scripts/modules/scm_unittest.py: Removed. 5276 * Scripts/modules/statusbot.py: Removed. 5277 * Scripts/modules/stepsequence.py: Removed. 5278 * Scripts/modules/style: Removed. 5279 * Scripts/modules/style.py: Removed. 5280 * Scripts/modules/style_unittest.py: Removed. 5281 * Scripts/modules/text_style.py: Removed. 5282 * Scripts/modules/text_style_unittest.py: Removed. 5283 * Scripts/modules/user.py: Removed. 5284 * Scripts/modules/webkit_logging.py: Removed. 5285 * Scripts/modules/webkit_logging_unittest.py: Removed. 5286 * Scripts/modules/webkit_mechanize.py: Removed. 5287 * Scripts/modules/webkitport.py: Removed. 5288 * Scripts/modules/webkitport_unittest.py: Removed. 5289 * Scripts/test-webkit-python: Removed. 5290 * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python. 5291 * Scripts/validate-committer-lists: 5292 * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules. 5293 * Scripts/webkitpy/bugzilla.py: 5294 * Scripts/webkitpy/bugzilla_unittest.py: 5295 * Scripts/webkitpy/buildbot.py: 5296 * Scripts/webkitpy/buildbot_unittest.py: 5297 * Scripts/webkitpy/buildsteps.py: 5298 * Scripts/webkitpy/buildsteps_unittest.py: 5299 * Scripts/webkitpy/commands/commandtest.py: 5300 * Scripts/webkitpy/commands/download.py: 5301 * Scripts/webkitpy/commands/download_unittest.py: 5302 * Scripts/webkitpy/commands/early_warning_system.py: 5303 * Scripts/webkitpy/commands/early_warning_system_unittest.py: 5304 * Scripts/webkitpy/commands/queries.py: 5305 * Scripts/webkitpy/commands/queries_unittest.py: 5306 * Scripts/webkitpy/commands/queues.py: 5307 * Scripts/webkitpy/commands/queues_unittest.py: 5308 * Scripts/webkitpy/commands/queuestest.py: 5309 * Scripts/webkitpy/commands/upload.py: 5310 * Scripts/webkitpy/commands/upload_unittest.py: 5311 * Scripts/webkitpy/comments.py: 5312 * Scripts/webkitpy/credentials.py: 5313 * Scripts/webkitpy/credentials_unittest.py: 5314 * Scripts/webkitpy/executive.py: 5315 * Scripts/webkitpy/executive_unittest.py: 5316 * Scripts/webkitpy/mock_bugzillatool.py: 5317 * Scripts/webkitpy/multicommandtool.py: 5318 * Scripts/webkitpy/multicommandtool_unittest.py: 5319 * Scripts/webkitpy/queueengine.py: 5320 * Scripts/webkitpy/queueengine_unittest.py: 5321 * Scripts/webkitpy/scm.py: 5322 * Scripts/webkitpy/scm_unittest.py: 5323 * Scripts/webkitpy/statusbot.py: 5324 * Scripts/webkitpy/stepsequence.py: 5325 * Scripts/webkitpy/webkit_logging_unittest.py: 5326 * Scripts/webkitpy/webkitport_unittest.py: 5327 53282010-01-03 Chris Jerdonek <chris.jerdonek@gmail.com> 5329 5330 Reviewed by Eric Seidel. 5331 5332 Added script to test both Perl and Python, and renamed 5333 run-webkit-unittests to test-webkit-python. 5334 5335 https://bugs.webkit.org/show_bug.cgi?id=33045 5336 5337 * Scripts/VCSUtils_unittest.pl: 5338 - Tweaked so it can be run from outside Scripts directory. 5339 5340 * Scripts/run-webkit-unittests: Removed. 5341 - Renamed to test-webkit-python. 5342 5343 * Scripts/test-webkit-perl: 5344 - Tweaked so it can be run from outside Scripts directory. 5345 5346 * Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests. 5347 5348 * Scripts/test-webkit-scripts: Added. 5349 - Runs both test-webkit-perl and test-webkit-python. 5350 53512010-01-03 Adam Barth <abarth@webkit.org> 5352 5353 Reviewed by Eric Seidel. 5354 5355 commit-queue/bugzilla-tool should build both Debug and Release 5356 https://bugs.webkit.org/show_bug.cgi?id=28450 5357 5358 Add a --build-style command that lets the master process tell the child 5359 process to build both debug and release. Eventually we want to teach 5360 the test step to understand this option too, but that's a patch for 5361 another day. 5362 5363 * Scripts/modules/buildsteps.py: 5364 * Scripts/modules/commands/queues.py: 5365 * Scripts/modules/webkitport.py: 5366 * Scripts/modules/webkitport_unittest.py: 5367 53682010-01-03 Jakub Wieczorek <faw217@gmail.com> 5369 5370 Reviewed by Eric Seidel. 5371 5372 [Qt] EventSender: add support for Enter key events 5373 https://bugs.webkit.org/show_bug.cgi?id=33064 5374 5375 Unskip 5 tests that are fixed now. 5376 5377 * DumpRenderTree/qt/EventSenderQt.cpp: 5378 (EventSender::keyDown): 5379 53802010-01-03 Adam Barth <abarth@webkit.org> 5381 5382 Reviewed by Eric Seidel. 5383 5384 [bzt] Add test for previous typo fix 5385 https://bugs.webkit.org/show_bug.cgi?id=33083 5386 5387 A trivial test for a trivial fix, as requested by Eric. 5388 5389 * Scripts/modules/bugzilla_unittest.py: 5390 53912010-01-03 Adam Barth <abarth@webkit.org> 5392 5393 Reviewed by Eric Seidel. 5394 5395 Implement mac-ews 5396 https://bugs.webkit.org/show_bug.cgi?id=33072 5397 5398 The mac-ews is slightly different than the other early warning systems 5399 because we can't run Mac OS X inside a VM. For that reason, we only 5400 process patches that were uploaded by committers. This isn't as much 5401 coverage as the other EWS bots, but it's better than nothing. 5402 5403 * Scripts/modules/commands/early_warning_system.py: 5404 * Scripts/modules/commands/early_warning_system_unittest.py: 5405 * Scripts/modules/commands/queues.py: 5406 * Scripts/modules/commands/queuestest.py: 5407 * Scripts/modules/mock_bugzillatool.py: 5408 54092010-01-03 Chris Jerdonek <chris.jerdonek@gmail.com> 5410 5411 Reviewed by David Kilzer. 5412 5413 Refactored svn-apply and svn-unapply to use a common "patch" 5414 command method, and added unit tests for this new method. 5415 5416 https://bugs.webkit.org/show_bug.cgi?id=33098 5417 5418 * Scripts/VCSUtils.pm: 5419 - Added generateRunPatchCommand(). 5420 - Added runPatchCommand(). 5421 - Added exitStatus() from webkitdirs.pm to address FIXME. 5422 5423 * Scripts/VCSUtils_unittest.pl: 5424 - Added 10 unit tests for generateRunPatchCommand(). 5425 - Added 4 unit tests for runPatchCommand(). 5426 - Added callSilently() method. 5427 5428 * Scripts/svn-apply: 5429 - Refactored applyPatch(). 5430 - Removed $pathScriptWasRunFrom global variable. 5431 - Addressed issue where "--force" option was getting added twice. 5432 5433 * Scripts/svn-unapply: 5434 - Refactored applyPatch(). 5435 - Removed $pathScriptWasRunFrom global variable. 5436 - Added support for --force option. 5437 - Enhanced to return meaningful exit status. 5438 5439 * Scripts/webkitdirs.pm: 5440 - Moved exitStatus() implementation to VCSUtils.pm. 5441 54422009-12-31 Adam Barth <abarth@webkit.org> 5443 5444 Reviewed by Eric Seidel. 5445 5446 [bzt] Implement build-and-test 5447 https://bugs.webkit.org/show_bug.cgi?id=33073 5448 5449 Some of the early warning system bots want to use build-and-test so 5450 they can cover LayoutTests in addition to just compilation. 5451 5452 * Scripts/modules/commands/download.py: 5453 * Scripts/modules/commands/download_unittest.py: 5454 54552009-12-31 Adam Barth <abarth@webkit.org> 5456 5457 Reviewed by Eric Seidel. 5458 5459 Show mac-ews status on QueueStatusServer 5460 https://bugs.webkit.org/show_bug.cgi?id=33076 5461 5462 Also make error status purple. 5463 5464 * QueueStatusServer/model/attachment.py: 5465 * QueueStatusServer/model/queues.py: 5466 * QueueStatusServer/templates/dashboard.html: 5467 * QueueStatusServer/templates/statusbubble.html: 5468 54692009-12-31 Adam Barth <abarth@webkit.org> 5470 5471 Unreviewed. 5472 5473 [bzt] REGRESSION: Bugzila is a typo 5474 https://bugs.webkit.org/show_bug.cgi?id=33074 5475 5476 Eric should test his code before landing! :) 5477 5478 * Scripts/modules/bugzilla.py: 5479 54802009-12-31 Adam Barth <abarth@webkit.org> 5481 5482 Unreviewed. Fix the unit tests! 5483 5484 * Scripts/run-webkit-unittests: 5485 54862009-12-30 Kevin Watters <kevinwatters@gmail.com> 5487 5488 Reviewed by Kevin Ollivier. 5489 5490 [wx] Alter a couple of default settings in the test app. 5491 5492 https://bugs.webkit.org/show_bug.cgi?id=32956 5493 5494 * wx/browser/browser.cpp: 5495 (MyApp::OnInit): 5496 54972009-12-30 Eric Seidel <eric@webkit.org> 5498 5499 Reviewed by Adam Barth. 5500 5501 logging.py should be renamed to webkit_logging.py and eventually die 5502 https://bugs.webkit.org/show_bug.cgi?id=33058 5503 5504 Change all imports of "logging" to webkit_logging, 5505 except the ones which came from Google's cpp_lint.py and diff_parser.py 5506 which clearly are assuming python's logging.py. 5507 5508 * Scripts/modules/bugzilla.py: 5509 * Scripts/modules/buildbot.py: 5510 * Scripts/modules/buildsteps.py: 5511 * Scripts/modules/commands/download.py: 5512 * Scripts/modules/commands/queries.py: 5513 * Scripts/modules/commands/queues.py: 5514 * Scripts/modules/commands/upload.py: 5515 * Scripts/modules/credentials.py: 5516 * Scripts/modules/executive.py: 5517 * Scripts/modules/multicommandtool.py: 5518 * Scripts/modules/queueengine.py: 5519 * Scripts/modules/scm.py: 5520 * Scripts/modules/statusbot.py: 5521 * Scripts/modules/stepsequence.py: 5522 * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py. 5523 * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py. 5524 55252009-12-30 Jakub Wieczorek <faw217@gmail.com> 5526 5527 Reviewed by Simon Hausmann. 5528 5529 [Qt] layoutTestController.pathToLocalResource() should return a path, not an URL 5530 https://bugs.webkit.org/show_bug.cgi?id=33051 5531 5532 Moreover, its primary function is to normalize the path in regard of platform 5533 specific directory separators. Therefore, it can simply make use of the 5534 QDir::toNativeSeparators function. 5535 5536 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 5537 (LayoutTestController::pathToLocalResource): 5538 55392009-12-30 David D. Kilzer <ddkilzer@webkit.org> 5540 5541 Fix executable bits for r52646 5542 5543 * Scripts/VCSUtils_unittest.pl: Added property svn:executable. 5544 * Scripts/test-webkit-perl: Ditto. 5545 55462009-12-29 Chris Jerdonek <chris.jerdonek@gmail.com> 5547 5548 Reviewed by David Kilzer. 5549 5550 Fixed a bug in fixChangeLogPatch, made it work correctly in 5551 more circumstances, and added unit tests. 5552 5553 https://bugs.webkit.org/show_bug.cgi?id=32919 5554 5555 * Scripts/VCSUtils.pm: 5556 Rewrote fixChangeLogPatch. 5557 5558 * Scripts/VCSUtils_unittest.pl: Added. 5559 Added 7 unit tests for fixChangeLogPatch. 5560 5561 * Scripts/test-webkit-perl: Added. 5562 Added test harness for unit tests of Perl code. 5563 55642009-12-29 Eric Seidel <eric@webkit.org> 5565 5566 Reviewed by Adam Barth. 5567 5568 Split out BugzillaQueries class from Bugzilla 5569 https://bugs.webkit.org/show_bug.cgi?id=33042 5570 5571 * Scripts/modules/bugzilla.py: 5572 - Split out BugzillaQueries from Bugzilla. 5573 - Try to isolate self.bugzilla usage into helper functions whenever possible. 5574 - Add a bunch of FIXMEs. 5575 - Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list 5576 * Scripts/modules/bugzilla_unittest.py: 5577 - Create a new BugzillaQueriesTest testcase and move logic there. 5578 * Scripts/modules/buildsteps_unittest.py: 5579 - Use Bug 75 instead of 1 since bug 1 doesn't actually exist. 5580 * Scripts/modules/commands/queries.py: 5581 - Update to use bugzilla.queries 5582 * Scripts/modules/commands/queues.py: 5583 - Ditto. 5584 * Scripts/modules/commands/upload.py: 5585 - Ditto. 5586 * Scripts/modules/mock_bugzillatool.py: 5587 - Add a MockBugzillaQueries. 5588 - Make patches and bugs global privates. 5589 - Let _id_to_object_dictionary take a variable argument list instead of an array. 5590 55912009-12-29 Daniel Bates <dbates@webkit.org> 5592 5593 Reviewed by Eric Seidel. 5594 5595 https://bugs.webkit.org/show_bug.cgi?id=33041 5596 5597 Speed up the test method test_read_credentials_with_SVN by not actually 5598 creating an SVN repository to test against (by default). Instead, it is 5599 sufficient to create a temporary directory that does not contain a Git 5600 repository. 5601 5602 Also, renamed method test_read_credentials_with_SVN to 5603 test_read_credentials_without_git_repo, to better reflect what it is 5604 testing. 5605 5606 * Scripts/modules/credentials_unittest.py: 5607 56082009-12-29 Daniel Bates <dbates@webkit.org> 5609 5610 Reviewed by Adam Barth. 5611 5612 https://bugs.webkit.org/show_bug.cgi?id=33039 5613 5614 [bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup 5615 fails to find an entry for bugs.webkit.org. 5616 5617 Under Mac OS X, bugzilla-tool tries to query the keychain and Security 5618 framework (via /usr/sbin/security) for an internet-password entry for 5619 bugs.webkit.org so that it can use it to login to bugs.webkit.org. 5620 However, if no such entry exists then bugzilla-tool dies with an error. 5621 5622 * Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return 5623 [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org. 5624 * Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found. 5625 56262009-12-29 Eric Seidel <eric@webkit.org> 5627 5628 Rubber-stamped by Adam Barth. 5629 5630 Remove unused BugzillaException. 5631 5632 * Scripts/modules/bugzilla.py: 5633 56342009-12-29 Eric Seidel <eric@webkit.org> 5635 5636 Reviewed by Adam Barth. 5637 5638 Need a script to assign bugs with r+ patches to committers for landing 5639 https://bugs.webkit.org/show_bug.cgi?id=33009 5640 5641 This is just one more small tool to help in the fight against our 5642 ever-growing list of to-be-committed patches. 5643 5644 * Scripts/modules/bugzilla.py: 5645 - Rename assign_to_email to assigned_to_email (typo). 5646 - Add assigned_to_email() method on Bug. 5647 - Add reassign_bug method. 5648 - Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module. 5649 * Scripts/modules/bugzilla_unittest.py: 5650 - Update test after assigned_to_email rename. 5651 * Scripts/modules/commands/commandtest.py: 5652 - Call bind_to_tool to that self.tool works in Command testing. 5653 * Scripts/modules/commands/download.py: 5654 - Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command. 5655 * Scripts/modules/commands/queries_unittest.py: 5656 - One of the test patches is now posted by "eric@webkit.org" which is a committer. 5657 - Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not. 5658 * Scripts/modules/commands/upload.py: 5659 - Add new assign-to-committer command. 5660 * Scripts/modules/commands/upload_unittest.py: 5661 - Add basic assign-to-committer test. 5662 * Scripts/modules/committers.py: 5663 - Add bugzilla_email() accessor. 5664 * Scripts/modules/committers_unittest.py: 5665 - Test our assumption that bugzilla_email is the first email. 5666 * Scripts/modules/mock_bugzillatool.py: 5667 - Add _id_to_object_dictionary for generating bug_cache from list of bugs. 5668 - Remove unused fetch_attachments_from_bug. 5669 - Add fetch_bug support and a bug_cache. 5670 * Scripts/modules/multicommandtool.py: 5671 - Move AbstractDeclarativeCommmand here from download.py 5672 56732009-12-29 Adam Barth <abarth@webkit.org> 5674 5675 Reviewed by Eric Seidel. 5676 5677 [bzt] Don't crash if user types a number during PromptForBugOrTitleStep 5678 https://bugs.webkit.org/show_bug.cgi?id=33038 5679 5680 Simple fix with test. 5681 5682 * Scripts/modules/buildsteps.py: 5683 * Scripts/modules/buildsteps_unittest.py: 5684 56852009-12-29 Adam Barth <abarth@webkit.org> 5686 5687 Reviewed by Eric Seidel. 5688 5689 [bzt] post-diff requires reading to the end 5690 https://bugs.webkit.org/show_bug.cgi?id=33036 5691 5692 Catch the IOError caused by not reading to the end of the diff. We 5693 don't have a good way to test this currently. 5694 5695 * Scripts/modules/user.py: 5696 56972009-12-29 Chang Shu <Chang.Shu@nokia.com> 5698 5699 Reviewed by Adam Barth. 5700 5701 [Qt] Move logic that handles Qt headers before primary headers 5702 so that Qt headers won't be treated as primary headers by mistake. 5703 https://bugs.webkit.org/show_bug.cgi?id=32991 5704 5705 * Scripts/modules/cpp_style.py: 5706 * Scripts/modules/cpp_style_unittest.py: 5707 57082009-12-29 Eric Seidel <eric@webkit.org> 5709 5710 Reviewed by Adam Barth. 5711 5712 Add the start of a Bug object for bugzilla.py 5713 https://bugs.webkit.org/show_bug.cgi?id=32995 5714 5715 This allowed us to get rid of some duplicated "is_obsolete" checks. 5716 5717 * Scripts/modules/bugzilla.py: 5718 - Add a new Bug class, and move patches/unreviewed_patches filtering logic there. 5719 - Add _fetch_bug_page for possible future mocking. 5720 (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.) 5721 - Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object. 5722 - Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods. 5723 - Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue 5724 using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list. 5725 * Scripts/modules/bugzilla_unittest.py: 5726 - Remove an unneeded unicode string marker. 5727 * Scripts/modules/buildsteps.py: 5728 - define __all__ to include just the BuildSteps 5729 * Scripts/modules/commands/download.py: 5730 - import * now that we have an __all__ defined. 5731 * Scripts/modules/commands/upload.py: 5732 - Use fetch_bug_dictionary instead of fetch_bug. 5733 57342009-12-29 Daniel Bates <dbates@webkit.org> 5735 5736 Reviewed by Ariya Hidayat. 5737 5738 https://bugs.webkit.org/show_bug.cgi?id=32925 5739 5740 Adds an Open File dialog to make it convenient to open a file 5741 to view in the browser. 5742 5743 Currently a person must either specify the path to a file as a 5744 command-line argument or type a file URL. Instead, we should 5745 have a file dialog to allow a person to open a file without 5746 memorizing its path. 5747 5748 * QtLauncher/main.cpp: 5749 (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded()) 5750 to urlEdit->setText(qurl.toString()). 5751 (MainWindow::openFile): Added. 5752 (MainWindow::changeLocation): Moved code to load URL into method 5753 MainWindow::loadURL. 5754 (MainWindow::loadURL): Added. 5755 (MainWindow::setupUI): Added menu item Open File. 5756 57572009-12-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5758 5759 Reviewed by Holger Freyther. 5760 5761 [GTK] fails fast/harness/use-page-cache.html 5762 https://bugs.webkit.org/show_bug.cgi?id=33013 5763 5764 Make sure settings are forwarded to child WebViews. 5765 5766 * DumpRenderTree/gtk/DumpRenderTree.cpp: 5767 (createWebView): 5768 57692009-12-29 Daniel Bates <dbates@webkit.org> 5770 5771 Reviewed by Eric Seidel. 5772 5773 https://bugs.webkit.org/show_bug.cgi?id=32778 5774 5775 Changes $diffPercentage to be a number to resolve Perl 5776 warning about comparing a string to a number. 5777 5778 * Scripts/run-webkit-tests: 5779 57802009-12-29 Jakub Wieczorek <faw217@gmail.com> 5781 5782 Reviewed by Eric Seidel. 5783 5784 [Qt] DRT: Frame loader callbacks differ from the Mac port 5785 https://bugs.webkit.org/show_bug.cgi?id=32989 5786 5787 Remove messages from the callbacks that should not dump them to match 5788 the expected results for the http/loading tests. 5789 5790 Unskip some http/loading tests which succeed now. 5791 5792 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 5793 (WebCore::DumpRenderTree::dump): 5794 57952009-12-29 Robert Hogan <robert@roberthogan.net> 5796 5797 Reviewed by Eric Seidel. 5798 5799 [Qt] fix fast/dom/Window/window-onFocus.html 5800 5801 Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where 5802 window.onblur was getting dispatched twice from QtWebKit. 5803 5804 https://bugs.webkit.org/show_bug.cgi?id=32990 5805 5806 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 5807 (WebCore::DumpRenderTree::DumpRenderTree): 5808 (WebCore::DumpRenderTree::switchFocus): 5809 * DumpRenderTree/qt/DumpRenderTreeQt.h: 5810 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 5811 (LayoutTestController::setWindowIsKey): 5812 (LayoutTestController::setMainFrameIsFirstResponder): 5813 * DumpRenderTree/qt/LayoutTestControllerQt.h: 5814 58152009-12-28 Kinuko Yasuda <kinuko@chromium.org> 5816 5817 Reviewed by Maciej Stachowiak. 5818 5819 Extended EventSender.keyDown method to take another (3rd) argument 5820 for indicating the keyLocation to make numeric pad key events testable. 5821 Expected values for the argument is one of the KeyLocationCode 5822 specified in DOM Level 3 5823 (http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents). 5824 https://bugs.webkit.org/show_bug.cgi?id=28247 5825 5826 Test: fast/events/keydown-numpad-keys.html 5827 5828 * DumpRenderTree/mac/EventSendingController.mm: 5829 (+[EventSendingController isSelectorExcludedFromWebScript:]): 5830 (+[EventSendingController webScriptNameForSelector:]): 5831 (-[EventSendingController keyDown:withModifiers:withLocation:]): 5832 58332009-12-28 Ariya Hidayat <ariya.hidayat@gmail.com> 5834 5835 Unreviewed, update my email address. 5836 5837 * Scripts/modules/committers.py: 5838 58392009-12-28 Laszlo Gombos <laszlo.1.gombos@nokia.com> 5840 5841 Reviewed by Adam Barth. 5842 5843 [Qt] Fix build break for Qt 4.4 5844 https://bugs.webkit.org/show_bug.cgi?id=30327 5845 5846 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale 5847 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto. 5848 * QtLauncher/main.cpp: 5849 (MainWindow::MainWindow): Qt::WA_TranslucentBackground was 5850 introduced in Qt version 4.5 5851 58522009-12-28 Adam Barth <abarth@webkit.org> 5853 5854 Reviewed by Eric Seidel. 5855 5856 [bzt] Add an edit-changelog command 5857 https://bugs.webkit.org/show_bug.cgi?id=32986 5858 5859 This command makes it easier to edit ChangeLogs. It's similar to 5860 prepare-ChangeLog -o, except it works with already existing ChangeLogs. 5861 5862 * Scripts/modules/commands/upload.py: 5863 * Scripts/modules/commands/upload_unittest.py: 5864 58652009-12-28 Adam Barth <abarth@webkit.org> 5866 5867 Reviewed by Eric Seidel. 5868 5869 [bzt] Create an ASAD command for uploading a patch 5870 https://bugs.webkit.org/show_bug.cgi?id=32979 5871 5872 The create-review command goes through the whole process of preparing a 5873 code review, including creating a bug, editing the ChangeLogs, and 5874 uploading the patch. It is indeed the All Sing, All Dance upload 5875 command. 5876 5877 * Scripts/modules/buildsteps.py: 5878 * Scripts/modules/commands/upload.py: 5879 * Scripts/modules/commands/upload_unittest.py: 5880 * Scripts/modules/mock_bugzillatool.py: 5881 * Scripts/modules/user.py: 5882 58832009-12-28 Adam Barth <abarth@webkit.org> 5884 5885 Unreviewed "build" fix (with test!). 5886 5887 * Scripts/modules/bugzilla.py: 5888 * Scripts/modules/bugzilla_unittest.py: 5889 58902009-12-27 Eric Seidel <eric@webkit.org> 5891 5892 Reviewed by Adam Barth. 5893 5894 Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command 5895 https://bugs.webkit.org/show_bug.cgi?id=32980 5896 5897 * Scripts/modules/bugzilla.py: 5898 - Add a new _parse_bug_page function and use it in fetch_attachments_from_bug 5899 - Replace fetch_title_from_bug with a new fetch_bug call instead. 5900 - Use list comprehensions where possible to reduce code duplication. 5901 * Scripts/modules/bugzilla_unittest.py: 5902 - Add a minimal bug parsing test. 5903 - Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal 5904 * Scripts/modules/commands/upload.py: 5905 - Use fetch_bug(bug_id)["title"] instead of fetch_title_from_bug 5906 59072009-12-27 Adam Barth <abarth@webkit.org> 5908 5909 Reviewed by Eric Seidel. 5910 5911 Status bubble shouldn't be transparent for bots that haven't run yet 5912 https://bugs.webkit.org/show_bug.cgi?id=32977 5913 5914 * QueueStatusServer/templates/statusbubble.html: 5915 59162009-12-27 Adam Barth <abarth@webkit.org> 5917 5918 Reviewed by Eric Seidel. 5919 5920 [QueueStatusServer] Run gc cron job less often 5921 https://bugs.webkit.org/show_bug.cgi?id=32958 5922 5923 Now that we've cleaned out the backlog of idle messages, we don't need 5924 to run the gc job every half hour. We could also stop logging the idle 5925 messages, but this seems easier for the time being. 5926 5927 * QueueStatusServer/cron.yaml: 5928 59292009-12-27 Daniel Bates <dbates@webkit.org> 5930 5931 Reviewed by Adam Barth. 5932 5933 https://bugs.webkit.org/show_bug.cgi?id=32896 5934 5935 Fixes an issue where bugzilla-tool tries to read the username and password from 5936 Git regardless of whether Git is installed. In particular, if Git is not 5937 installed then bugzilla-tool dies (with a trace) when it attempts to query Git 5938 for the authentication credentials to log into bugs.webkit.org. 5939 5940 Moreover, modifies Executive.run_command to catch and pass OSError exceptions to 5941 the specified error handler. For instance, the specified error handler will now 5942 be called when the command does not exist (i.e. OSError errno 2). 5943 5944 * Scripts/modules/credentials.py: Added check for Git. 5945 * Scripts/modules/credentials_unittest.py: Added test method 5946 test_read_credentials_with_SVN. 5947 * Scripts/modules/executive.py: Modified method run_command to catch 5948 OSError exceptions (i.e [Errno 2] No such file or directory) and call 5949 the specified error handler. 5950 * Scripts/modules/executive_unittest.py: Added. 5951 * Scripts/run-webkit-unittests: Added import executive_unittest.py. 5952 59532009-12-27 Daniel Bates <dbates@webkit.org> 5954 5955 Unreviewed. Added missing file style_unittest.py that wasn't committed 5956 in change set 52541 (http://trac.webkit.org/changeset/52541) as part of 5957 the patch for bug #32592. 5958 5959 * Scripts/modules/style_unittest.py: Added. 5960 59612009-12-27 Daniel Bates <dbates@webkit.org> 5962 5963 Reviewed by Eric Seidel. 5964 5965 https://bugs.webkit.org/show_bug.cgi?id=32964 5966 5967 [bzt] Updated the unit test based on the change made in bug #32951. 5968 5969 The change made in bug #32951 added the command-line argument: 5970 --makeargs="-j8" to the build-webkit command. However, the associated 5971 unit test was not updated. 5972 5973 * Scripts/modules/webkitport_unittest.py: 5974 59752009-12-27 Yael Aharon <yael.aharon@nokia.com> 5976 5977 Reviewed by Darin Adler. 5978 5979 check-webkit-style should not mark moc files inclusion as errors 5980 https://bugs.webkit.org/show_bug.cgi?id=32669 5981 5982 Add a new header type for moc files, and skip them when checking the order of header files. 5983 5984 * Scripts/modules/cpp_style.py: 5985 59862009-12-26 Adam Barth <abarth@webkit.org> 5987 5988 Reviewed by Eric Seidel. 5989 5990 [bzt] Make the qt build go fast 5991 https://bugs.webkit.org/show_bug.cgi?id=32951 5992 5993 Make use of multiple cores, if available. 5994 5995 * Scripts/modules/webkitport.py: 5996 59972009-12-25 Daniel Bates <dbates@rim.com> 5998 5999 Reviewed by Eric Seidel. 6000 6001 https://bugs.webkit.org/show_bug.cgi?id=32682 6002 6003 Fixes an issue where checkFrameworks always dies with an error under Windows 6004 since the clause "unless (-x $path)" is always satisfied because files under 6005 Windows do not have an explict executable bit. 6006 6007 * Scripts/webkitdirs.pm: 6008 60092009-12-23 Eric Seidel <eric@webkit.org> 6010 6011 Reviewed by Adam Barth. 6012 6013 bugzilla-tool should accept global options anywhere 6014 https://bugs.webkit.org/show_bug.cgi?id=26912 6015 6016 * Scripts/bugzilla-tool: 6017 - Use the new global_options class property. 6018 - Add a handle_global_options callback to avoid needing callbacks for each global option. 6019 * Scripts/modules/multicommandtool.py: 6020 - Make the code use one combined option parser. 6021 This allows us to accept global options anywhere and 6022 individual command options before commands. 6023 - Add a handle_global_options callback to avoid needing callbacks for each global option. 6024 - Make the Command hold the option parser, but allow the tool to override it. 6025 - The default option parser is used for help printing and when Commands are run stand alone, 6026 but are otherwise not used. 6027 - Add Command.main to codify the idea that Commands should support being run stand-alone. 6028 - Change _split_args to _split_command_name_from_args now that args are unified. 6029 * Scripts/modules/multicommandtool_unittest.py: 6030 - Test that "tool" and "tool help" show the same help. 6031 - Test that args are accepted before commands 6032 60332009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com> 6034 6035 Reviewed by David Levin. 6036 6037 Moved some sections of code in preparation to refactor 6038 check-webkit-style's argument parser to avoid setting 6039 global variables. 6040 6041 https://bugs.webkit.org/show_bug.cgi?id=32592 6042 6043 * Scripts/check-webkit-style: 6044 - Moved _USAGE string to style.py. 6045 - Addressed FIXME by eliminating dependencies on cpp_style.py. 6046 6047 * Scripts/modules/cpp_style.py: 6048 - Moved default arguments and style categories to style.py. 6049 - Moved exit_with_usage(), exit_with_categories(), and 6050 parse_arguments() to style.py. 6051 - Removed references in _CppStyleState to the global 6052 variables now in style.py. 6053 6054 * Scripts/modules/cpp_style_unittest.py: 6055 - Moved parse_arguments() unit tests to style_unittest.py. 6056 6057 * Scripts/modules/style.py: 6058 - Added _USAGE string from check-webkit-style. 6059 - Added default arguments and style categories from cpp_style.py. 6060 - Added exit_with_usage(), exit_with_categories(), and 6061 parse_arguments() from cpp_sstyle.py. 6062 6063 * Scripts/modules/style_unittest.py: Added. 6064 - Added parse_arguments() unit tests from cpp_style_unittest.py. 6065 6066 * Scripts/run-webkit-unittests: 6067 - Added unit tests from style_unittest.py. 6068 60692009-12-23 Eric Seidel <eric@webkit.org> 6070 6071 Reviewed by Adam Barth. 6072 6073 commit-queue should mention bug 30084 when rejecting patches until it can be fixed 6074 https://bugs.webkit.org/show_bug.cgi?id=32911 6075 6076 * Scripts/modules/bugzilla.py: Make the message even more fancy. 6077 * Scripts/modules/bugzilla_unittest.py: Test our new fancy message. 6078 60792009-12-23 Laszlo Gombos <laszlo.1.gombos@nokia.com> 6080 6081 Not reviewed, adding myself to the reviewers list. 6082 6083 * Scripts/modules/committers.py: 6084 60852009-12-23 Adam Barth <abarth@webkit.org> 6086 6087 Reviewed by Eric Seidel. 6088 6089 [bzt] Create a prepare-diff command that creates a bug and a ChangeLog 6090 https://bugs.webkit.org/show_bug.cgi?id=32895 6091 6092 The workflow Maciej and I discussed is as follows: 6093 6094 1) Write code. 6095 2) bugzilla-tool prepare-diff 6096 3) Edit ChangeLogs 6097 4) bugzilla-tool post-diff 6098 6099 We might want to experimenting with combining 2-4 into a single 6100 command, but that might be stressful to edit the ChangeLogs modally. 6101 6102 Removed submit-patch since it has the modal ChangeLog editing but none 6103 oof the bug creating fun. 6104 6105 * Scripts/modules/bugzilla.py: 6106 * Scripts/modules/buildsteps.py: 6107 * Scripts/modules/commands/upload.py: 6108 * Scripts/modules/commands/upload_unittest.py: 6109 61102009-12-23 Gabor Loki <loki@webkit.org> 6111 6112 Unreviewed; added myself to the committers list. 6113 6114 * Scripts/modules/committers.py: 6115 61162009-12-22 Adam Barth <abarth@webkit.org> 6117 6118 Reviewed by Maciej Stachowiak. 6119 6120 [bzt] Don't call create-patch twice during post-diff 6121 https://bugs.webkit.org/show_bug.cgi?id=32893 6122 6123 If we call create-patch to get the bug number, cache the diff in the 6124 state so we don't need to call it again. 6125 6126 * Scripts/modules/buildsteps.py: 6127 * Scripts/modules/commands/upload.py: 6128 61292009-12-22 Daniel Bates <dbates@rim.com> 6130 6131 Reviewed by Eric Seidel. 6132 6133 https://bugs.webkit.org/show_bug.cgi?id=32680 6134 6135 Fixes an issue in builtDylibPathForName so that it returns the correct 6136 path to the built QtWebKit library on the Qt Windows port. Currently, 6137 it returns the path to the file named QtWebKit.dll but this file does 6138 not exist on the Qt Windows build. Instead, the file is named 6139 QtWebKit4.dll. 6140 6141 * Scripts/webkitdirs.pm: 6142 61432009-12-22 Marc-Antoine Ruel <maruel@chromium.org> 6144 6145 Reviewed by Adam Roben. 6146 6147 Remove the only dependency on perl-libwin32 in cygwin 6148 6149 * Scripts/num-cpus: 6150 61512009-12-22 Darin Adler <darin@apple.com> 6152 6153 * pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore 6154 generated ".pyc" files. 6155 61562009-12-22 Darin Adler <darin@apple.com> 6157 6158 Reviewed by Mark Rowe. 6159 6160 Turn off datagrid by default, at least for all platforms Apple ships. 6161 The datagrid implementation isn't ready for general web use yet. 6162 6163 * Scripts/build-webkit: Turn off datagrid by default. 6164 61652009-12-22 Eric Seidel <eric@webkit.org> 6166 6167 Reviewed by Darin Adler. 6168 6169 validate-committer-lists fails when run from an SVN checkout 6170 https://bugs.webkit.org/show_bug.cgi?id=31974 6171 6172 * Scripts/validate-committer-lists: 6173 - Make it print a warning message instead of throwing 6174 an exception when running from an SVN checkout. 6175 61762009-12-22 Philippe Normand <pnormand@igalia.com> 6177 6178 Reviewed by Adam Barth. 6179 6180 check-webkit-style should not warn about NULL usage in g_object_{get,set} 6181 https://bugs.webkit.org/show_bug.cgi?id=32858 6182 6183 * Scripts/modules/cpp_style.py: 6184 * Scripts/modules/cpp_style_unittest.py: 6185 61862009-12-22 Simon Hausmann <simon.hausmann@nokia.com> 6187 6188 Rubber-stamped by Holger Freyther. 6189 6190 Moved QtLauncher from WebKit/qt. 6191 6192 * QtLauncher: Copied from WebKit/qt/QtLauncher. 6193 * QtLauncher/QtLauncher.pro: 6194 61952009-12-21 Adam Barth <abarth@webkit.org> 6196 6197 Reviewed by Eric Seidel. 6198 6199 [bzt] Automate the process of calling prepare-ChangeLog 6200 https://bugs.webkit.org/show_bug.cgi?id=32816 6201 6202 This patch automates the process of creating a bug and patch and 6203 uploading it to bugzilla. The first cut just calls 6204 prepare-ChangeLog. 6205 6206 This patch required some refactoring of upload.py to the Step 6207 model, but that's worth doing anyway. 6208 6209 * Scripts/bugzilla-tool: 6210 * Scripts/modules/buildsteps.py: 6211 * Scripts/modules/commands/download.py: 6212 * Scripts/modules/commands/upload.py: 6213 * Scripts/modules/commands/upload_unittest.py: 6214 * Scripts/modules/mock_bugzillatool.py: 6215 62162009-12-21 Darin Adler <darin@apple.com> 6217 6218 * Scripts/do-webcore-rename: Did a rename, so checking in the 6219 version of the script I used. 6220 62212009-12-21 Adam Barth <abarth@webkit.org> 6222 6223 Reviewed by Eric Seidel. 6224 6225 Update status-bubble to show all the queues 6226 https://bugs.webkit.org/show_bug.cgi?id=32838 6227 6228 Also, move statusbubble over to use memcache. 6229 6230 * QueueStatusServer/handlers/statusbubble.py: 6231 * QueueStatusServer/templates/statusbubble.html: 6232 62332009-12-21 Adam Barth <abarth@webkit.org> 6234 6235 Reviewed by Eric Seidel. 6236 6237 Delete the boring "Empty queue" status messages in QueueStatusServer 6238 https://bugs.webkit.org/show_bug.cgi?id=32818 6239 6240 * QueueStatusServer/app.yaml: 6241 * QueueStatusServer/cron.yaml: 6242 * QueueStatusServer/handlers/gc.py: 6243 * QueueStatusServer/main.py: 6244 62452009-12-21 Adam Barth <abarth@webkit.org> 6246 6247 Reviewed by Eric Seidel. 6248 6249 Exception on queue status server 6250 https://bugs.webkit.org/show_bug.cgi?id=32812 6251 6252 Turns out we need to pass the id to the filter. 6253 6254 * QueueStatusServer/filters/webkit_extras.py: 6255 * QueueStatusServer/templates/patch.html: 6256 * QueueStatusServer/templates/recentstatus.html: 6257 62582009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com> 6259 6260 Reviewed by Eric Seidel. 6261 6262 Created "style" folder for code supporting check-webkit-style. 6263 6264 * Scripts/modules/style: Added. 6265 62662009-12-20 Adam Barth <abarth@webkit.org> 6267 6268 Reviewed by Eric Seidel. 6269 6270 REGRESSION: error when running commit-queue 6271 https://bugs.webkit.org/show_bug.cgi?id=32806 6272 6273 Fix typo and add test! 6274 6275 * Scripts/modules/bugzilla.py: 6276 * Scripts/modules/bugzilla_unittest.py: 6277 62782009-12-20 Adam Barth <abarth@webkit.org> 6279 6280 [bzt] Optimize status updates for new dashboard 6281 https://bugs.webkit.org/show_bug.cgi?id=32797 6282 6283 This patch makes the queues slightly more chatty with the web service. 6284 Also, this patch introduces some testing for the queues! 6285 6286 * Scripts/modules/commands/early_warning_system.py: 6287 * Scripts/modules/commands/early_warning_system_unittest.py: Added. 6288 * Scripts/modules/commands/queues.py: 6289 * Scripts/modules/commands/queues_unittest.py: 6290 * Scripts/modules/commands/queuestest.py: Added. 6291 * Scripts/modules/mock_bugzillatool.py: 6292 * Scripts/modules/patchcollection.py: 6293 * Scripts/modules/queueengine.py: 6294 * Scripts/run-webkit-unittests: 6295 62962009-12-20 Adam Barth <abarth@webkit.org> 6297 6298 Reviewed by Eric Seidel. 6299 6300 Prepare QueueStatusServer for new status messages 6301 https://bugs.webkit.org/show_bug.cgi?id=32805 6302 6303 * QueueStatusServer/handlers/recentstatus.py: 6304 * QueueStatusServer/index.html: Removed. 6305 * QueueStatusServer/model/attachment.py: 6306 * QueueStatusServer/model/queues.py: Added. 6307 * QueueStatusServer/templates/recentstatus.html: Added. 6308 63092009-12-20 Shinichiro Hamaji <hamaji@chromium.org> 6310 6311 Reviewed by Adam Barth. 6312 6313 [check-webkit-style] static_cast is not misnamed! 6314 https://bugs.webkit.org/show_bug.cgi?id=32796 6315 6316 * Scripts/modules/cpp_style.py: 6317 * Scripts/modules/cpp_style_unittest.py: 6318 63192009-12-20 Alejandro G. Castro <alex@igalia.com> 6320 6321 Reviewed by Gustavo Noronha Silva. 6322 6323 [GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html 6324 https://bugs.webkit.org/show_bug.cgi?id=32788 6325 6326 Do not increase the click count if we are using a different button. 6327 6328 * DumpRenderTree/gtk/EventSender.cpp: 6329 63302009-12-20 Adam Barth <abarth@webkit.org> 6331 6332 Reviewed by Eric Seidel. 6333 6334 [QueueStatusServer] Add a per-patch details page 6335 https://bugs.webkit.org/show_bug.cgi?id=32784 6336 6337 This is a first cut at a per-patch details page. I'm sure we'll have 6338 to iterate. 6339 6340 * QueueStatusServer/filters/webkit_extras.py: 6341 * QueueStatusServer/handlers/patch.py: Added. 6342 * QueueStatusServer/index.yaml: 6343 * QueueStatusServer/main.py: 6344 * QueueStatusServer/model/attachment.py: 6345 * QueueStatusServer/stylesheets/dashboard.css: 6346 * QueueStatusServer/templates/dashboard.html: 6347 * QueueStatusServer/templates/patch.html: Added. 6348 63492009-12-20 Adam Barth <abarth@webkit.org> 6350 6351 Reviewed by Eric Seidel. 6352 6353 Use memcache to make dashboard to fast 6354 https://bugs.webkit.org/show_bug.cgi?id=32780 6355 6356 * QueueStatusServer/app.yaml: 6357 * QueueStatusServer/handlers/dashboard.py: 6358 * QueueStatusServer/handlers/updatestatus.py: 6359 * QueueStatusServer/model/attachment.py: Added. 6360 63612009-12-19 Brent Fulgham <bfulgham@webkit.org> 6362 6363 Reviewed by Adam Roben. 6364 6365 Provide an example implementation for printing under Windows. 6366 http://bugs.webkit.org/show_bug.cgi?id=32504.` 6367 6368 * WinLauncher/PrintWebUIDelegate.cpp: Added. 6369 (PrintWebUIDelegate::QueryInterface): 6370 (PrintWebUIDelegate::AddRef): 6371 (PrintWebUIDelegate::Release): 6372 (PrintWebUIDelegate::webViewPrintingMarginRect): 6373 * WinLauncher/PrintWebUIDelegate.h: Added. 6374 (PrintWebUIDelegate::PrintWebUIDelegate): 6375 (PrintWebUIDelegate::createWebViewWithRequest): 6376 (PrintWebUIDelegate::webViewShow): 6377 (PrintWebUIDelegate::webViewClose): 6378 (PrintWebUIDelegate::webViewFocus): 6379 (PrintWebUIDelegate::webViewUnfocus): 6380 (PrintWebUIDelegate::webViewFirstResponder): 6381 (PrintWebUIDelegate::makeFirstResponder): 6382 (PrintWebUIDelegate::setStatusText): 6383 (PrintWebUIDelegate::webViewStatusText): 6384 (PrintWebUIDelegate::webViewAreToolbarsVisible): 6385 (PrintWebUIDelegate::setToolbarsVisible): 6386 (PrintWebUIDelegate::webViewIsStatusBarVisible): 6387 (PrintWebUIDelegate::setStatusBarVisible): 6388 (PrintWebUIDelegate::webViewIsResizable): 6389 (PrintWebUIDelegate::setResizable): 6390 (PrintWebUIDelegate::setFrame): 6391 (PrintWebUIDelegate::webViewFrame): 6392 (PrintWebUIDelegate::setContentRect): 6393 (PrintWebUIDelegate::webViewContentRect): 6394 (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): 6395 (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): 6396 (PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt): 6397 (PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage): 6398 (PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener): 6399 (PrintWebUIDelegate::mouseDidMoveOverElement): 6400 (PrintWebUIDelegate::contextMenuItemsForElement): 6401 (PrintWebUIDelegate::validateUserInterfaceItem): 6402 (PrintWebUIDelegate::shouldPerformAction): 6403 (PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo): 6404 (PrintWebUIDelegate::willPerformDragDestinationAction): 6405 (PrintWebUIDelegate::dragSourceActionMaskForPoint): 6406 (PrintWebUIDelegate::willPerformDragSourceAction): 6407 (PrintWebUIDelegate::contextMenuItemSelected): 6408 (PrintWebUIDelegate::hasCustomMenuImplementation): 6409 (PrintWebUIDelegate::trackCustomPopupMenu): 6410 (PrintWebUIDelegate::measureCustomMenuItem): 6411 (PrintWebUIDelegate::drawCustomMenuItem): 6412 (PrintWebUIDelegate::addCustomMenuDrawingData): 6413 (PrintWebUIDelegate::cleanUpCustomMenuDrawingData): 6414 (PrintWebUIDelegate::canTakeFocus): 6415 (PrintWebUIDelegate::takeFocus): 6416 (PrintWebUIDelegate::registerUndoWithTarget): 6417 (PrintWebUIDelegate::removeAllActionsWithTarget): 6418 (PrintWebUIDelegate::setActionTitle): 6419 (PrintWebUIDelegate::undo): 6420 (PrintWebUIDelegate::redo): 6421 (PrintWebUIDelegate::canUndo): 6422 (PrintWebUIDelegate::canRedo): 6423 (PrintWebUIDelegate::printFrame): 6424 (PrintWebUIDelegate::ftpDirectoryTemplatePath): 6425 (PrintWebUIDelegate::webViewHeaderHeight): 6426 (PrintWebUIDelegate::webViewFooterHeight): 6427 (PrintWebUIDelegate::drawHeaderInRect): 6428 (PrintWebUIDelegate::drawFooterInRect): 6429 (PrintWebUIDelegate::canRunModal): 6430 (PrintWebUIDelegate::createModalDialog): 6431 (PrintWebUIDelegate::runModal): 6432 (PrintWebUIDelegate::isMenuBarVisible): 6433 (PrintWebUIDelegate::setMenuBarVisible): 6434 (PrintWebUIDelegate::runDatabaseSizeLimitPrompt): 6435 (PrintWebUIDelegate::paintCustomScrollbar): 6436 (PrintWebUIDelegate::paintCustomScrollCorner): 6437 * WinLauncher/WinLauncher.cpp: Add new UI delegate for print support. 6438 (WinLauncherWebHost::updateAddressBar): check-webkit-style fixes. 6439 (WinLauncherWebHost::QueryInterface): check-webkit-style fixes. 6440 (WinLauncherWebHost::AddRef): check-webkit-style fixes. 6441 (WinLauncherWebHost::Release): check-webkit-style fixes. 6442 (resizeSubViews): check-webkit-style fixes. 6443 (_tWinMain): check-webkit-style fixes. 6444 (MyRegisterClass): check-webkit-style fixes. 6445 (InitInstance): check-webkit-style fixes. 6446 (AbortProc): New print support function. 6447 (getPrinterDC): New print support function. 6448 (initDocStruct): New print support function. 6449 (PrintView): New printing implementation. 6450 (WndProc): Add support for printing. 6451 (MyEditProc): check-webkit-style fixes. 6452 (About): check-webkit-style fixes. 6453 (loadURL): check-webkit-style fixes. 6454 * WinLauncher/WinLauncher.h: 6455 (WinLauncherWebHost::WinLauncherWebHost): 6456 (WinLauncherWebHost::didStartProvisionalLoadForFrame): 6457 (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): 6458 (WinLauncherWebHost::didFailProvisionalLoadWithError): 6459 (WinLauncherWebHost::didCommitLoadForFrame): 6460 (WinLauncherWebHost::didReceiveTitle): 6461 (WinLauncherWebHost::didReceiveIcon): 6462 (WinLauncherWebHost::didFinishLoadForFrame): 6463 (WinLauncherWebHost::didFailLoadWithError): 6464 (WinLauncherWebHost::didChangeLocationWithinPageForFrame): 6465 (WinLauncherWebHost::willPerformClientRedirectToURL): 6466 (WinLauncherWebHost::didCancelClientRedirectForFrame): 6467 (WinLauncherWebHost::willCloseFrame): 6468 (WinLauncherWebHost::windowScriptObjectAvailable): 6469 * WinLauncher/WinLauncher.rc: Add menu entry for printing. 6470 * WinLauncher/WinLauncher.vcproj: Add new files. 6471 * WinLauncher/resource.h: Add menu entry for printing. 6472 64732009-12-19 Adam Barth <abarth@webkit.org> 6474 6475 Unreviewed. Tweak the CSS to make the dashboard prettier. 6476 6477 * QueueStatusServer/stylesheets/dashboard.css: 6478 * QueueStatusServer/templates/dashboard.html: 6479 64802009-12-19 Adam Barth <abarth@webkit.org> 6481 6482 Reviewed by Eric Seidel. 6483 6484 QueueStatusServer needs a human readable dashboard 6485 https://bugs.webkit.org/show_bug.cgi?id=32769 6486 6487 Here is a first cut at the dashboard. There's a lot left to do. 6488 6489 * QueueStatusServer/filters/webkit_extras.py: 6490 * QueueStatusServer/handlers/dashboard.py: Added. 6491 * QueueStatusServer/handlers/patchstatus.py: 6492 * QueueStatusServer/handlers/recentstatus.py: 6493 * QueueStatusServer/handlers/showresults.py: 6494 * QueueStatusServer/handlers/statusbubble.py: 6495 * QueueStatusServer/handlers/updatestatus.py: 6496 * QueueStatusServer/main.py: 6497 * QueueStatusServer/model/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. 6498 * QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py. 6499 * QueueStatusServer/stylesheets/dashboard.css: Added. 6500 * QueueStatusServer/templates/dashboard.html: Added. 6501 * QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html. 6502 * QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html. 6503 65042009-12-19 Daniel Bates <dbates@webkit.org> 6505 6506 Reviewed by Timothy Hatcher. 6507 6508 https://bugs.webkit.org/show_bug.cgi?id=32462 6509 6510 Added --inspector-frontend flag to build-webkit to copy any changes 6511 to the inspector front-end files to the built WebCore framework. This 6512 will make inspector development more consistent with the rest of 6513 WebKit development. 6514 6515 * Scripts/build-webkit: 6516 * Scripts/webkitdirs.pm: 6517 65182009-12-19 Adam Barth <abarth@webkit.org> 6519 6520 Unreviewed fixes for me being terrible at python. 6521 6522 * Scripts/modules/bugzilla.py: 6523 * Scripts/run-webkit-unittests: 6524 65252009-12-18 Adam Barth <abarth@webkit.org> 6526 6527 Reviewed by Eric Seidel. 6528 6529 Split QueueStatus server into modules 6530 https://bugs.webkit.org/show_bug.cgi?id=32768 6531 6532 One monolithic file is no good. 6533 6534 * QueueStatusServer/app.yaml: 6535 * QueueStatusServer/handlers/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. 6536 * QueueStatusServer/handlers/patchstatus.py: Added. 6537 * QueueStatusServer/handlers/recentstatus.py: Added. 6538 * QueueStatusServer/handlers/showresults.py: Added. 6539 * QueueStatusServer/handlers/statusbubble.py: Added. 6540 * QueueStatusServer/handlers/updatestatus.py: Added. 6541 * QueueStatusServer/main.py: Added. 6542 * QueueStatusServer/model.py: Added. 6543 * QueueStatusServer/queue_status.py: Removed. 6544 65452009-12-18 Adam Barth <abarth@webkit.org> 6546 6547 Rubber stamped by Eric Seidel. 6548 6549 Renamed WorkQueue to QueueEngine. WorkQueue is not a queue. 6550 6551 * Scripts/modules/commands/queues.py: 6552 * Scripts/modules/queueengine.py: Added. 6553 * Scripts/modules/queueengine_unittest.py: Added. 6554 * Scripts/modules/stepsequence.py: 6555 * Scripts/modules/workqueue.py: Removed. 6556 * Scripts/modules/workqueue_unittest.py: Removed. 6557 65582009-12-18 Adam Barth <abarth@webkit.org> 6559 6560 Reviewed by Eric Seidel. 6561 6562 Add watches for EWS 6563 https://bugs.webkit.org/show_bug.cgi?id=32767 6564 6565 dglazkov wanted to be added. 6566 6567 * Scripts/modules/bugzilla.py: 6568 * Scripts/modules/commands/early_warning_system.py: 6569 * Scripts/modules/commands/queues.py: 6570 65712009-12-18 Eric Seidel <eric@webkit.org> 6572 6573 Reviewed by David Levin. 6574 6575 move bugzilla.py off of urllib2 6576 https://bugs.webkit.org/show_bug.cgi?id=32729 6577 6578 * Scripts/modules/bugzilla.py: use mechanize for all url fetching. 6579 65802009-12-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 6581 6582 Rubber-stamped by Xan Lopez. 6583 6584 [GTK] New events (pageshow and pagehide) tests failing 6585 https://bugs.webkit.org/show_bug.cgi?id=28823 6586 6587 Original patch by Jan Michael Alonzo. 6588 6589 Disable page cache for tests. 6590 6591 * DumpRenderTree/gtk/DumpRenderTree.cpp: 6592 (resetDefaultsToConsistentValues): 6593 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 6594 (copyWebSettingKey): 6595 (LayoutTestController::overridePreference): 6596 65972009-12-18 Fumitoshi Ukai <ukai@chromium.org> 6598 6599 Reviewed by David Levin. 6600 6601 Check one space before end of line comments. 6602 https://bugs.webkit.org/show_bug.cgi?id=32597 6603 6604 Fix to check one space before end of line comments in whitespace and build/header_guard. 6605 Also fix build/header_guard to use WebKit header guard defines. 6606 6607 * Scripts/modules/cpp_style.py: 6608 * Scripts/modules/cpp_style_unittest.py: 6609 66102009-12-17 Sam Weinig <sam@webkit.org> 6611 6612 Reviewed by Mark Rowe. 6613 6614 Add BUILDING_ON_SNOW_LEOPARD #define. 6615 6616 * DumpRenderTree/mac/DumpRenderTreeMac.h: 6617 66182009-12-17 Yuzo Fujishima <yuzo@google.com> 6619 6620 Reviewed by Alexey Proskuryakov. 6621 6622 Update pywebsocket to 0.4.5 and make handshake checking stricter 6623 https://bugs.webkit.org/show_bug.cgi?id=32249 6624 6625 * Scripts/run-webkit-tests: 6626 * pywebsocket/mod_pywebsocket/handshake.py: 6627 * pywebsocket/mod_pywebsocket/memorizingfile.py: Added. 6628 * pywebsocket/mod_pywebsocket/standalone.py: 6629 * pywebsocket/setup.py: 6630 * pywebsocket/test/test_handshake.py: 6631 * pywebsocket/test/test_memorizingfile.py: Added. 6632 66332009-12-17 Eric Seidel <eric@webkit.org> 6634 6635 Reviewed by Adam Barth. 6636 6637 Command.show_in_main_help should default to False 6638 https://bugs.webkit.org/show_bug.cgi?id=32686 6639 6640 * Scripts/modules/commands/download.py: 6641 * Scripts/modules/commands/queries.py: 6642 * Scripts/modules/commands/queues.py: 6643 * Scripts/modules/commands/upload.py: 6644 * Scripts/modules/multicommandtool.py: 6645 66462009-12-17 Alejandro G. Castro <alex@igalia.com> 6647 6648 Reviewed by Eric Seidel. 6649 6650 Added the key WebKitEnableCaretBrowsing to the 6651 layoutTestController.overridePreference in order to activate caret 6652 browsing. 6653 https://bugs.webkit.org/show_bug.cgi?id=32612 6654 6655 * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of 6656 the setting. 6657 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new 6658 key in the keytable. 6659 66602009-12-17 Chris Fleizach <cfleizach@apple.com> 6661 6662 Reviewed by David Kilzer. 6663 6664 AX: DRT needs to support URL for accessibility 6665 https://bugs.webkit.org/show_bug.cgi?id=32666 6666 6667 * DumpRenderTree/AccessibilityUIElement.cpp: 6668 (getURLCallback): 6669 (AccessibilityUIElement::getJSClass): 6670 * DumpRenderTree/AccessibilityUIElement.h: 6671 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 6672 (AccessibilityUIElement::url): 6673 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 6674 (AccessibilityUIElement::url): 6675 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 6676 (AccessibilityUIElement::url): 6677 66782009-12-17 Philippe Normand <pnormand@igalia.com> 6679 6680 Unreviewed; added myself to committers 6681 6682 * Scripts/modules/committers.py: 6683 66842009-12-17 Benjamin Otte <otte@gnome.org> 6685 6686 Unreviewed; added myself to committers 6687 6688 * Scripts/modules/committers.py: 6689 66902009-12-17 Adam Barth <abarth@webkit.org> 6691 6692 Rubber stamp by Seidel. 6693 6694 Clean up exception handling in WorkQueue. Basically, a bunch of the 6695 delegate messages can throw exceptions because of network errors. We 6696 want the queues to keep on ticking instead of erroring out. That means 6697 we want to catch generic exceptions and continue looping. 6698 6699 Also, cleaned up the exception handling in the EWS to properly log 6700 failures. 6701 6702 * Scripts/modules/commands/early_warning_system.py: 6703 * Scripts/modules/commands/queues.py: 6704 * Scripts/modules/workqueue.py: 6705 67062009-12-16 Adam Barth <abarth@webkit.org> 6707 6708 Reviewed by Eric Seidel. 6709 6710 [bzt] Make UpdateStep quiet 6711 https://bugs.webkit.org/show_bug.cgi?id=32599 6712 6713 * Scripts/modules/buildsteps.py: 6714 * Scripts/modules/buildsteps_unittest.py: 6715 67162009-12-16 Evan Martin <evan@chromium.org> 6717 6718 Reviewed by Adam Barth. 6719 6720 Add Gtk to the early warning system WebKit port list. 6721 6722 https://bugs.webkit.org/show_bug.cgi?id=32629 6723 6724 * Scripts/modules/commands/early_warning_system.py: 6725 * Scripts/modules/webkitport.py: 6726 * Scripts/modules/webkitport_unittest.py: 6727 67282009-12-16 Eric Seidel <eric@webkit.org> 6729 6730 Reviewed by Adam Barth. 6731 6732 post-diff is failing with exception under guess_reviewer_from_bug 6733 https://bugs.webkit.org/show_bug.cgi?id=32642 6734 6735 Also refactor output capturing code into 6736 OutputCapture.assert_outputs to share more code between tests. 6737 6738 * Scripts/modules/buildsteps.py: 6739 - Add the missing include. 6740 - Give guess_reviewer_from_bug a private underscore. 6741 * Scripts/modules/buildsteps_unittest.py: Added. 6742 - Test to make sure _guess_reviewer_from_bug works as expected. 6743 * Scripts/modules/commands/commandtest.py: 6744 - Custom code is now obsoleted by OutputCapture.assert_outputs 6745 * Scripts/modules/commands/queues_unittest.py: 6746 - ditto 6747 * Scripts/modules/credentials_unittest.py: 6748 - ditto 6749 * Scripts/modules/mock_bugzillatool.py: 6750 - fetch_reviewed_patches_from_bug can never return None 6751 * Scripts/modules/multicommandtool_unittest.py: 6752 - Custom code is now obsoleted by OutputCapture.assert_outputs 6753 * Scripts/modules/outputcapture.py: 6754 - Add assert_outputs to share more code between tests. 6755 * Scripts/run-webkit-unittests: 6756 - Add buildsteps_unittest.py 6757 67582009-12-16 Adam Barth <abarth@webkit.org> 6759 6760 Unreviewed. Added a default argument to _update_status so that callers 6761 don't have to explictly pass None when they don't have a patch object. 6762 6763 * Scripts/modules/commands/queues.py: 6764 67652009-12-16 Kent Tamura <tkent@chromium.org> 6766 6767 Reviewed by David Levin. 6768 6769 check-webkit-style supports for TAB check against text files. 6770 https://bugs.webkit.org/show_bug.cgi?id=32538 6771 6772 * Scripts/check-webkit-style: 6773 Move process_patch() to style.py. 6774 * Scripts/modules/cpp_style.py: 6775 Add can_handle(). 6776 * Scripts/modules/cpp_style_unittest.py: 6777 Add tests for can_handle(). 6778 * Scripts/modules/style.py: 6779 Added. This is a front-end of cpp_style and text_style. It dispatches 6780 files to an appropriate linter. 6781 * Scripts/modules/text_style.py: 6782 Added. This is a linter module for generic text files. It supports 6783 only for TAB checking at this moment. 6784 * Scripts/modules/text_style_unittest.py: 6785 Added. Tests for text_style.py. 6786 * Scripts/run-webkit-unittests: 6787 Add text_style_unittest. 6788 67892009-12-16 Eric Seidel <eric@webkit.org> 6790 6791 Reviewed by David Levin. 6792 6793 bugzilla-tool should not require users to install mechanize 6794 https://bugs.webkit.org/show_bug.cgi?id=32635 6795 6796 Centralize our import logic. 6797 6798 * Scripts/modules/bugzilla.py: use webkit_mechanize 6799 * Scripts/modules/statusbot.py: use webkit_mechanize 6800 * Scripts/modules/webkit_mechanize.py: Added. 6801 68022009-12-16 Eric Seidel <eric@webkit.org> 6803 6804 Reviewed by Adam Barth. 6805 6806 Generalize commit-queue recent status page for all queues 6807 https://bugs.webkit.org/show_bug.cgi?id=32633 6808 6809 * QueueStatusServer/index.html: 6810 - Generalize to support other queues. 6811 * QueueStatusServer/queue_status.py: 6812 - Generalize MainPage to support other queues. 6813 68142009-12-16 Evan Martin <evan@chromium.org> 6815 6816 Reviewed by Adam Barth. 6817 6818 Early warning system server should display output as UTF-8. 6819 6820 https://bugs.webkit.org/show_bug.cgi?id=32625 6821 6822 * QueueStatusServer/queue_status.py: 6823 68242009-12-16 Adam Barth <abarth@webkit.org> 6825 6826 Reviewed by Eric Seidel. 6827 6828 [bzt] Add error handling to the early warning system 6829 https://bugs.webkit.org/show_bug.cgi?id=32594 6830 6831 This should be the last step in making the EWS operational. When we 6832 have a build error, we post the log to QueueStatusServer and add a link 6833 to the bug. 6834 6835 * Scripts/modules/commands/early_warning_system.py: 6836 * Scripts/modules/commands/queues.py: 6837 * Scripts/modules/executive.py: 6838 68392009-12-16 Simon Hausmann <simon.hausmann@nokia.com> 6840 6841 Reviewed by Holger Freyther. 6842 6843 Fix crash with tests that use custom font faces. 6844 6845 https://bugs.webkit.org/show_bug.cgi?id=32600 6846 6847 In the DRT we call QApplication::removeAllApplicationFonts(), to make sure 6848 that custom font faces between tests don't influence each other. Calling this 6849 function in Qt however also invalidates all existing handles with QFontDatabase. 6850 6851 In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(), 6852 which implies a call to WebCore::FontCache::fontCache()->invalidate(). 6853 6854 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 6855 (WebCore::DumpRenderTree::open): 6856 68572009-12-16 Andreas Kling <andreas.kling@nokia.com> 6858 6859 Reviewed by Simon Hausmann. 6860 6861 [Qt] Maintain button state between mouse events. 6862 6863 This allows eventSender to generate drag events. 6864 6865 https://bugs.webkit.org/show_bug.cgi?id=32601 6866 6867 * DumpRenderTree/qt/EventSenderQt.cpp: 6868 (EventSender::mouseDown): 6869 (EventSender::mouseUp): 6870 (EventSender::mouseMoveTo): 6871 * DumpRenderTree/qt/EventSenderQt.h: 6872 68732009-12-15 Chris Jerdonek <chris.jerdonek@gmail.com> 6874 6875 Reviewed by David Levin. 6876 6877 Code clean-up in check-webkit-style as described below. 6878 The only functional changes are minor improvements to the 6879 script's help output. 6880 6881 https://bugs.webkit.org/show_bug.cgi?id=32487 6882 6883 * Scripts/check-webkit-style: 6884 - Added the module docstring from cpp_style.py. 6885 - Improved wording of the --help output and added some of the 6886 default values as substitution strings. 6887 - Called cpp_style.exit_with_usage instead of sys.stderr.write 6888 in main function. 6889 - Made changes caused by changes to cpp_style.py. 6890 6891 * Scripts/modules/cpp_style.py: 6892 - Removed module docstring, as well as redundant _USAGE string 6893 and main() function obsoleted by check-webkit-style. 6894 - Moved specification of default script values from within a 6895 function definition to global variables. 6896 - Moved the default webkit filter rules to be near the other 6897 global variables. 6898 - Renamed "FILTER" global variables to "FILTER_RULES" to 6899 establish unambiguous terminology. 6900 - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES. 6901 - Changed _STYLE_CATEGORIES from a string to a list. 6902 - Added default webkit filter rules to --filter= output. 6903 - Renamed "print_" methods to "exit_with_" since they exist 6904 and added a temporary display_help parameter. 6905 - Added a temporary display_help parameter to parse_arguments. 6906 6907 * Scripts/modules/cpp_style_unittest.py: 6908 - Made changes caused by changes to cpp_style.py. 6909 - Lower-cased ErrorCollector's ERROR_CATEGORIES instance 6910 variables since they are not global. 6911 69122009-12-15 Adam Barth <abarth@webkit.org> 6913 6914 Unreviewed fix for the style-queue. 6915 Typo: _updates_status -> _update_status 6916 6917 We need to improve our testing infrastructure for the queues. 6918 6919 * Scripts/modules/commands/queues.py: 6920 69212009-12-15 Adam Barth <abarth@webkit.org> 6922 6923 Unreviewed fix for the style-queue. I suspect this is a recent 6924 regression from Eric's change below. 6925 6926 * Scripts/modules/commands/queues.py: 6927 69282009-12-15 Yaar Schnitman <yaar@chromium.org> 6929 6930 Reviewed by Darin Fisher. 6931 6932 update-webkit-chromium to auto-install gclient 6933 6934 https://bugs.webkit.org/show_bug.cgi?id=32587 6935 6936 * Scripts/update-webkit-chromium: 6937 69382009-12-15 Eric Seidel <eric@webkit.org> 6939 6940 Reviewed by Adam Barth. 6941 6942 bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot 6943 https://bugs.webkit.org/show_bug.cgi?id=32546 6944 6945 You can see an example of this working in: 6946 https://bugs.webkit.org/show_bug.cgi?id=32585#c3 6947 6948 * QueueStatusServer/queue_status.py: 6949 - Output the id of the newly created status. 6950 * Scripts/modules/commands/queues.py: 6951 - Tweak the commit-queue logging to include a full status link. 6952 * Scripts/modules/statusbot.py: 6953 - update_status should return the newly created status id. 6954 69552009-12-15 Andras Becsi <abecsi@inf.u-szeged.hu> 6956 6957 Reviewed by Tor Arne Vestbø. 6958 6959 [Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable. 6960 6961 * DumpRenderTree/qt/DumpRenderTree.cpp: Removed. 6962 * DumpRenderTree/qt/DumpRenderTree.h: Removed. 6963 * DumpRenderTree/qt/DumpRenderTree.pro: Updated. 6964 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp. 6965 * DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h. 6966 * DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp. 6967 (GCController::GCController): 6968 * DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h. 6969 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 6970 * DumpRenderTree/qt/WorkQueueItem.h: Removed. 6971 * DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes. 6972 * DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h. 6973 * DumpRenderTree/qt/jsobjects.cpp: Removed. 6974 * DumpRenderTree/qt/jsobjects.h: Removed. 6975 * DumpRenderTree/qt/main.cpp: Updated includes. 6976 69772009-12-15 Adam Barth <abarth@webkit.org> 6978 6979 Reviewed by Eric Seidel. 6980 6981 We have two mark-fixed commands 6982 https://bugs.webkit.org/show_bug.cgi?id=32073 6983 6984 * Scripts/mark-bug-fixed: Removed. 6985 * Scripts/modules/commands/upload.py: 6986 * Scripts/modules/commands/upload_unittest.py: 6987 69882009-12-15 Eric Seidel <eric@webkit.org> 6989 6990 Reviewed by Adam Barth. 6991 6992 bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected 6993 https://bugs.webkit.org/show_bug.cgi?id=28286 6994 6995 * QueueStatusServer/index.html: 6996 - Show [results] links if a results log was uploaded. 6997 * QueueStatusServer/queue_status.py: 6998 - Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str(). 6999 * Scripts/modules/commands/queues.py: 7000 - Post to the status bot when a patch fails and include the failure log as a results file. 7001 70022009-12-15 Eric Seidel <eric@webkit.org> 7003 7004 Reviewed by Adam Barth. 7005 7006 queue sub-commands need --status-host so they can report status 7007 https://bugs.webkit.org/show_bug.cgi?id=32313 7008 7009 Make --status-bot a global option and make 7010 run_bugzilla_tool pass --status-bot to sub-commands. 7011 7012 * Scripts/bugzilla-tool: 7013 - Rename _status to status_bot and make it non-lazy. 7014 * Scripts/modules/commands/queues.py: 7015 - Move status updates out of WorkQueue and into individual queues. 7016 * Scripts/modules/commands/queues_unittest.py: 7017 - Test that --status-host is passed to bugzilla-tool when run as subcommand. 7018 * Scripts/modules/mock_bugzillatool.py: 7019 - Add a MockStatusBot 7020 * Scripts/modules/workqueue.py: 7021 - Remove status_host and work_work_logs_directory callbacks. 7022 - Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches! 7023 * Scripts/modules/workqueue_unittest.py: 7024 - Update unit tests to reflect new callbacks. 7025 70262009-12-15 Adam Barth <abarth@webkit.org> 7027 7028 Reviewed by Eric Seidel. 7029 7030 scm_unittest.py is too slow 7031 https://bugs.webkit.org/show_bug.cgi?id=31818 7032 7033 Now we don't run the SCM unit tests unless we get the --all flag on the 7034 command line. Eric and I were commenting out this test because it was 7035 too painful to run. 7036 7037 * Scripts/run-webkit-unittests: 7038 70392009-12-14 Adam Barth <abarth@webkit.org> 7040 7041 Unreviewed. Fix failing unittest. 7042 7043 * Scripts/modules/bugzilla_unittest.py: 7044 70452009-12-14 Eric Seidel <eric@webkit.org> 7046 7047 Reviewed by Adam Barth. 7048 7049 Move Credential handling out into a separate module 7050 https://bugs.webkit.org/show_bug.cgi?id=32531 7051 7052 * Scripts/modules/bugzilla.py: 7053 * Scripts/modules/credentials.py: Added. 7054 * Scripts/modules/credentials_unittest.py: Added. 7055 * Scripts/run-webkit-unittests: 7056 70572009-12-14 Adam Barth <abarth@webkit.org> 7058 7059 Reviewed by Eric Seidel. 7060 7061 Kill _create_step_sequence 7062 https://bugs.webkit.org/show_bug.cgi?id=32539 7063 7064 It's cleaner to represent not having these sequences as an empty 7065 sequence instead of None. 7066 7067 * Scripts/modules/commands/download.py: 7068 * Scripts/modules/stepsequence.py: 7069 70702009-12-14 Adam Barth <abarth@webkit.org> 7071 7072 Unreviewed. Address reviewer comments from an earlier patch. I didn't 7073 do this earlier because I was worried about conflicts in dependent 7074 patches. 7075 7076 * Scripts/modules/commands/download.py: 7077 70782009-12-14 Adam Barth <abarth@webkit.org> 7079 7080 Reviewed by Eric Seidel. 7081 7082 [bzt] Make download commands declarative 7083 https://bugs.webkit.org/show_bug.cgi?id=32469 7084 7085 This patch "properly" factors most of the download commands. These 7086 commands are now largely declarative, which is the final step of this 7087 grand refactoring. 7088 7089 * Scripts/modules/buildsteps.py: 7090 * Scripts/modules/commands/download.py: 7091 70922009-12-14 Adam Barth <abarth@webkit.org> 7093 7094 Reviewed by Eric Seidel. 7095 7096 [bzt] Add AbstractPatchSequencingCommand to remove redundant code 7097 https://bugs.webkit.org/show_bug.cgi?id=32468 7098 7099 Redundant code is bad. This patch moves us towards more declarative 7100 commands. 7101 7102 * Scripts/modules/commands/download.py: 7103 71042009-12-14 Adam Barth <abarth@webkit.org> 7105 7106 Reviewed by Eric Seidel. 7107 7108 [bzt] Kill WebKitApplyingScripts 7109 https://bugs.webkit.org/show_bug.cgi?id=32467 7110 7111 Ah! I've been wanting to do this for a long time. This patch brings 7112 the applying commands into the patch processing fold. 7113 7114 * Scripts/bugzilla-tool: 7115 * Scripts/modules/buildsteps.py: 7116 * Scripts/modules/commands/download.py: 7117 * Scripts/modules/commands/download_unittest.py: 7118 * Scripts/modules/mock_bugzillatool.py: 7119 71202009-12-14 Adam Barth <abarth@webkit.org> 7121 7122 Reviewed by Eric Seidel. 7123 7124 [bzt] Convert rollout to StepSequence 7125 https://bugs.webkit.org/show_bug.cgi?id=32406 7126 7127 * Scripts/modules/buildsteps.py: 7128 * Scripts/modules/commands/download.py: 7129 * Scripts/modules/commands/download_unittest.py: 7130 * Scripts/modules/mock_bugzillatool.py: 7131 71322009-12-14 Adam Barth <abarth@webkit.org> 7133 7134 Reviewed by Eric Seidel. 7135 7136 [bzt] Kill LandingSequence 7137 https://bugs.webkit.org/show_bug.cgi?id=32464 7138 7139 Removes LandingSequence in favor of StepSequence. This required 7140 changing the Step API slightly to carry a general notion of state 7141 instead of carrying patches specifically. 7142 7143 * Scripts/modules/buildsteps.py: 7144 * Scripts/modules/commands/download.py: 7145 * Scripts/modules/commands/queues.py: 7146 * Scripts/modules/landingsequence.py: Removed. 7147 * Scripts/modules/stepsequence.py: 7148 71492009-12-14 Robert Hogan <robert@roberthogan.net> 7150 7151 Reviewed by Eric Seidel. 7152 7153 [Qt] Fix https://bugs.webkit.org/show_bug.cgi?id=32437 7154 7155 Amend the behaviour of DRT::notifyDone to dump only when 7156 the page has finished loading. 7157 7158 This fix permits removal of the following tests from the Qt skipped list: 7159 fast/forms/textarea-linewrap-dynamic.html 7160 fast/forms/textarea-setvalue-submit.html 7161 fast/forms/textarea-hard-linewrap-empty.html 7162 fast/forms/submit-to-url-fragment.html 7163 http/tests/misc/percent-sign-in-form-field-name.html 7164 http/tests/security/escape-form-data-field-names.html 7165 7166 However it also requires the following two to be added to the skipped list: 7167 7168 http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html 7169 svg/custom/use-instanceRoot-as-event-target.xhtml 7170 7171 It appears the behaviour of notifyDone was masking problems with these two 7172 tests. 7173 7174 * DumpRenderTree/qt/DumpRenderTree.cpp: 7175 (WebCore::DumpRenderTree::DumpRenderTree): 7176 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7177 (LayoutTestController::reset): 7178 (LayoutTestController::processWork): 7179 (LayoutTestController::maybeDump): 7180 (LayoutTestController::notifyDone): 7181 (LayoutTestController::provisionalLoad): 7182 * DumpRenderTree/qt/LayoutTestControllerQt.h: 7183 (LayoutTestController::resetLoadFinished): 7184 71852009-12-14 Simon Hausmann <hausmann@webkit.org> 7186 7187 Reviewed by Holger Freyther. 7188 7189 [Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events 7190 7191 https://bugs.webkit.org/show_bug.cgi?id=32482 7192 7193 * DumpRenderTree/qt/EventSenderQt.cpp: 7194 (EventSender::setTouchModifier): 7195 (EventSender::clearTouchPoints): 7196 (EventSender::sendTouchEvent): 7197 * DumpRenderTree/qt/EventSenderQt.h: 7198 71992009-12-13 Maciej Stachowiak <mjs@apple.com> 7200 7201 Reviewed by Gavin Barraclaugh. 7202 7203 Fix minor problem in sunspider-compare-results which left it broken. 7204 7205 * Scripts/sunspider-compare-results: Declare $parseonly 7206 72072009-12-12 Maciej Stachowiak <mjs@apple.com> 7208 7209 Reviewed by Oliver Hunt. 7210 7211 Give command-line sunspider the ability to handle multiple suites and versions 7212 https://bugs.webkit.org/show_bug.cgi?id=32477 7213 7214 * Scripts/run-sunspider: Updated for changes to command-line parameters. 7215 * Scripts/sunspider-compare-results: ditto 7216 72172009-12-12 Maciej Stachowiak <mjs@apple.com> 7218 7219 Not reviewed, fixing previous comment. 7220 7221 Remove accidental change to sunspider-compare-results 7222 7223 * Scripts/sunspider-compare-results: 7224 72252009-12-11 Yael Aharon <yael.aharon@nokia.com> 7226 7227 Unreviewed build fix for Qt versions < 4.6. 7228 Guard every slot individually with #ifdef. 7229 7230 * DumpRenderTree/qt/EventSenderQt.cpp: 7231 (EventSender::addTouchPoint): 7232 (EventSender::updateTouchPoint): 7233 (EventSender::touchStart): 7234 (EventSender::touchMove): 7235 (EventSender::touchEnd): 7236 (EventSender::clearTouchPoints): 7237 (EventSender::releaseTouchPoint): 7238 (EventSender::sendTouchEvent): 7239 * DumpRenderTree/qt/EventSenderQt.h: 7240 72412009-12-11 Eric Seidel <eric@webkit.org> 7242 7243 Reviewed by Adam Barth. 7244 7245 CommandsTest.assert_execute_outputs doesn't check stderr 7246 https://bugs.webkit.org/show_bug.cgi?id=32352 7247 7248 Fix assert_execute_outputs to check stderr 7249 and then fix all the unit tests which needed to 7250 pass stderr output. 7251 7252 * Scripts/modules/commands/commandtest.py: 7253 * Scripts/modules/commands/download_unittest.py: 7254 * Scripts/modules/commands/upload_unittest.py: 7255 72562009-12-11 Adam Barth <abarth@webkit.org> 7257 7258 Reviewed by Eric Seidel. 7259 7260 [check-webkit-style] False positive for tst_QWebFrame 7261 https://bugs.webkit.org/show_bug.cgi?id=32436 7262 7263 Add an exception for function names that start with "tst_". These are 7264 used by the Qt unit testing framework. 7265 7266 * Scripts/modules/cpp_style.py: 7267 * Scripts/modules/cpp_style_unittest.py: 7268 72692009-12-11 Simon Hausmann <hausmann@webkit.org>, Kim Grönholm <kim.gronholm@nomovok.com> 7270 7271 Reviewed by Antti Koivisto. 7272 7273 Added support for creating synthetic touch events with EventSender 7274 in Qt's DumpRenderTree. 7275 7276 https://bugs.webkit.org/show_bug.cgi?id=32114 7277 7278 * DumpRenderTree/qt/EventSenderQt.cpp: 7279 (EventSender::addTouchPoint): 7280 (EventSender::updateTouchPoint): 7281 (EventSender::touchStart): 7282 (EventSender::touchMove): 7283 (EventSender::touchEnd): 7284 (EventSender::clearTouchPoints): 7285 (EventSender::releaseTouchPoint): 7286 (EventSender::sendTouchEvent): 7287 * DumpRenderTree/qt/EventSenderQt.h: 7288 72892009-12-11 Benjamin Poulain <benjamin.poulain@nokia.com> 7290 7291 Reviewed by Darin Adler. 7292 7293 The values of RuntimeArray are not enumerable 7294 https://bugs.webkit.org/show_bug.cgi?id=29005 7295 7296 * DumpRenderTree/mac/ObjCController.m: 7297 (+[ObjCController isSelectorExcludedFromWebScript:]): 7298 (+[ObjCController webScriptNameForSelector:]): 7299 (-[ObjCController arrayOfString]): 7300 73012009-12-10 Eric Seidel <eric@webkit.org> 7302 7303 No review, just updating unit tests to match recent checkins. 7304 7305 * Scripts/modules/mock_bugzillatool.py: 7306 - Add missing red_core_builders_names method causing exception. 7307 * Scripts/modules/workqueue_unittest.py: 7308 - processutils is dead, use executive.py instead. 7309 73102009-12-10 Eric Seidel <eric@webkit.org> 7311 7312 Reviewed by Adam Barth. 7313 7314 Move run_command onto Executive to make code which uses run_command testable 7315 https://bugs.webkit.org/show_bug.cgi?id=32396 7316 7317 * Scripts/modules/executive.py: 7318 - Move run_command and error handlers onto Executive. 7319 * Scripts/modules/scm.py: 7320 * Scripts/modules/scm_unittest.py: 7321 73222009-12-09 Eric Seidel <eric@webkit.org> 7323 7324 Reviewed by Adam Barth. 7325 7326 bugzilla-tool needs a command to list patches needing cq+ 7327 https://bugs.webkit.org/show_bug.cgi?id=32351 7328 7329 * Scripts/modules/bugzilla.py: 7330 - Parse attacher_email from attachment xml. 7331 * Scripts/modules/bugzilla_unittest.py: 7332 - Test new attacher_email parsing. 7333 * Scripts/modules/commands/queries.py: 7334 - Add PatchesToCommitQueue 7335 * Scripts/modules/commands/queries_unittest.py: 7336 - Tests for PatchesToCommitQueue 7337 * Scripts/modules/mock_bugzillatool.py: 7338 - Add necessary mock methods for running PatchesToCommitQueue 7339 73402009-12-10 Adam Barth <abarth@webkit.org> 7341 7342 Unreviewed. Turns out every StepSequence command needs a --quiet 7343 option. 7344 7345 * Scripts/modules/stepsequence.py: 7346 73472009-12-10 Eric Z. Ayers <zundel@google.com> 7348 7349 Reviewed by Pavel Feldman. 7350 7351 Implements displayWebView() to force an invalidation and repaint. 7352 This fixes a problem running the timeline-paint.html unit test. 7353 7354 https://bugs.webkit.org/show_bug.cgi?id=31729 7355 7356 * DumpRenderTree/gtk/DumpRenderTree.cpp: 7357 (displayWebView): 7358 73592009-12-10 Adam Barth <abarth@webkit.org> 7360 7361 Reviewed by Eric Seidel. 7362 7363 [bzt] Convert more commands to StepSequences 7364 https://bugs.webkit.org/show_bug.cgi?id=32362 7365 7366 We should eventually convert all the commands, but I'm starting with 7367 the easy ones. 7368 7369 * Scripts/modules/commands/download.py: 7370 73712009-12-10 Xan Lopez <xlopez@igalia.com> 7372 7373 Reviewed by Jan Alonzo. 7374 7375 [GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing 7376 https://bugs.webkit.org/show_bug.cgi?id=31103 7377 7378 Give focus to the webviews when we create them, since some tests expect this. 7379 7380 * DumpRenderTree/gtk/DumpRenderTree.cpp: 7381 (main): 7382 73832009-12-10 Eric Seidel <eric@webkit.org> 7384 7385 Reviewed by Adam Barth. 7386 7387 bugzilla-tool "builders are red" error should tell you which builders 7388 https://bugs.webkit.org/show_bug.cgi?id=32211 7389 7390 * Scripts/modules/buildsteps.py: 7391 73922009-12-09 Marwan Al Jubeh <marwan.aljubeh@gmail.com> 7393 7394 Reviewed by Adam Roben. 7395 7396 Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228 7397 Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically 7398 in Windows as part of running update_webkit. 7399 7400 * Scripts/update-webkit: 7401 - Run setupAppleWinEnv() on Apple's Windows port. 7402 * Scripts/webkitdirs.pm: 7403 - Added functions that return the source directory, libraries directory and default build directory on Windows. 7404 - Added isWindowsNT() which tests if the current Windows version is from the Windows NT family. 7405 - Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir 7406 and Cygwin to their desired values. 7407 74082009-12-09 Adam Barth <abarth@webkit.org> 7409 7410 Reviewed by Eric Seidel. 7411 7412 exception thrown when running apply-patches 7413 https://bugs.webkit.org/show_bug.cgi?id=32344 7414 7415 The update step now takes a port option. Once we finish the Steps 7416 refactoring, we won't have to worry about this kind of bug again. 7417 7418 * Scripts/modules/commands/download.py: 7419 74202009-12-09 Adam Barth <abarth@webkit.org> 7421 7422 Unreviewed. Fix ScriptError includes. I don't understand why these 7423 didn't throw during unit testing... 7424 7425 * Scripts/modules/commands/download.py: 7426 * Scripts/modules/logging_unittest.py: 7427 * Scripts/modules/workqueue.py: 7428 74292009-12-09 Adam Barth <abarth@webkit.org> 7430 7431 Reviewed by Eric Seidel. 7432 7433 [bzt] Remove unused PatchCollection class 7434 https://bugs.webkit.org/show_bug.cgi?id=32312 7435 7436 It's dead code. 7437 7438 * Scripts/modules/patchcollection.py: 7439 * Scripts/modules/patchcollection_unittest.py: Removed. 7440 74412009-12-09 Adam Barth <abarth@webkit.org> 7442 7443 Unreviewed "build" fix. CheckStyle needs a --no-upate option. 7444 7445 * Scripts/modules/commands/download.py: 7446 74472009-12-09 Adam Barth <abarth@webkit.org> 7448 7449 Reviewed by Eric Seidel. 7450 7451 [bzt] Convert Build to use Sequence 7452 https://bugs.webkit.org/show_bug.cgi?id=32310 7453 7454 So much prettier. 7455 7456 * Scripts/modules/buildsteps.py: 7457 * Scripts/modules/commands/download.py: 7458 * Scripts/modules/landingsequence.py: 7459 * Scripts/modules/stepsequence.py: Added. 7460 74612009-12-09 Adam Barth <abarth@webkit.org> 7462 7463 Add missing file. 7464 7465 * Scripts/modules/executive.py: Added. 7466 74672009-12-09 Adam Barth <abarth@webkit.org> 7468 7469 Unreviewed "build" fix. 7470 7471 * Scripts/modules/landingsequence.py: 7472 74732009-12-09 Adam Barth <abarth@webkit.org> 7474 7475 Reviewed by Eric Seidel. 7476 7477 [bzt] Implement abstract Steps 7478 https://bugs.webkit.org/show_bug.cgi?id=32212 7479 7480 This is a fairly disruptive change that refactors how we build 7481 commands. Instead of using a landing sequence, we can now assemble a 7482 sequence of steps directly. We still use the landing sequence in the 7483 interim, but this will be removed soon. 7484 7485 * Scripts/bugzilla-tool: 7486 * Scripts/modules/buildsteps.py: 7487 * Scripts/modules/commands/download.py: 7488 * Scripts/modules/commands/early_warning_system.py: 7489 * Scripts/modules/commands/queues.py: 7490 * Scripts/modules/commands/queues_unittest.py: 7491 * Scripts/modules/landingsequence.py: 7492 * Scripts/modules/mock_bugzillatool.py: 7493 * Scripts/modules/processutils.py: Removed. 7494 * Scripts/modules/scm.py: 7495 * Scripts/modules/scm_unittest.py: 7496 * Scripts/modules/webkitport.py: 7497 74982009-12-08 Eric Seidel <eric@webkit.org> 7499 7500 Reviewed by Adam Barth. 7501 7502 run_command and ScriptError should move into processutils.py 7503 https://bugs.webkit.org/show_bug.cgi?id=32305 7504 7505 Turns out there are a zillion callers to run_command. 7506 7507 * Scripts/modules/commands/download.py: 7508 * Scripts/modules/commands/early_warning_system.py: 7509 * Scripts/modules/commands/queues.py: 7510 * Scripts/modules/landingsequence.py: 7511 * Scripts/modules/logging_unittest.py: 7512 * Scripts/modules/processutils.py: 7513 * Scripts/modules/scm.py: 7514 * Scripts/modules/scm_unittest.py: 7515 * Scripts/modules/workqueue.py: 7516 * Scripts/modules/workqueue_unittest.py: 7517 75182009-12-08 Kevin Watters <kevinwatters@gmail.com> 7519 7520 Reviewed by Kevin Ollivier. 7521 7522 [wx] Mac plugins support. 7523 7524 https://bugs.webkit.org/show_bug.cgi?id=32236 7525 7526 * wx/browser/wscript: 7527 75282009-12-08 David Levin <levin@chromium.org> 7529 7530 Reviewed by Adam Barth. 7531 7532 [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) { 7533 https://bugs.webkit.org/show_bug.cgi?id=32193 7534 7535 * Scripts/modules/cpp_style.py: For the function { rule, if there is space 7536 at the beginning of line, ignore lines which then have a macro. 7537 * Scripts/modules/cpp_style_unittest.py: Add tests to verify the 7538 new behavior. 7539 75402009-12-08 Dmitry Titov <dimich@chromium.org> 7541 7542 Rubber-stamped by David Levin. 7543 7544 Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread." 7545 It may have caused massive increase of reported leaks on the bots. 7546 https://bugs.webkit.org/show_bug.cgi?id=31639 7547 7548 * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed. 7549 75502009-12-08 Dmitry Titov <dimich@chromium.org> 7551 7552 Reviewed by Darin Adler. 7553 7554 Add asserts to RefCounted to make sure ref/deref happens on the right thread. 7555 https://bugs.webkit.org/show_bug.cgi?id=31639 7556 7557 * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added. 7558 75592009-12-08 David Levin <levin@chromium.org> 7560 7561 Reviewed by Adam Barth. 7562 7563 [check-webkit-style] False positive for camel case of JSC op codes 7564 https://bugs.webkit.org/show_bug.cgi?id=32192 7565 7566 * Scripts/modules/cpp_style.py: Added an exception for the JSC op 7567 code functions and const_iterator as well since I noticed a false 7568 positive there when testing the fix. 7569 * Scripts/modules/cpp_style_unittest.py: Added tests for these 7570 changes. 7571 75722009-12-08 Nikolas Zimmermann <nzimmermann@rim.com> 7573 7574 Rubber-stamped by Maciej Stachowiak. 7575 7576 Turn on (SVG) Filters for Win. 7577 https://bugs.webkit.org/show_bug.cgi?id=32224 7578 7579 * Scripts/webkitdirs.pm: 7580 75812009-12-08 Nikolas Zimmermann <nzimmermann@rim.com> 7582 7583 Rubber-stamped by Maciej Stachowiak. 7584 7585 Turn on (SVG) Filters for Gtk. 7586 https://bugs.webkit.org/show_bug.cgi?id=32224 7587 7588 * Scripts/build-webkit: 7589 75902009-12-07 Shinichiro Hamaji <hamaji@chromium.org> 7591 7592 Reviewed by David Levin. 7593 7594 [check-webkit-style] S_OK is a fine identifier 7595 https://bugs.webkit.org/show_bug.cgi?id=32225 7596 7597 * Scripts/modules/cpp_style.py: 7598 * Scripts/modules/cpp_style_unittest.py: 7599 76002009-12-07 Nikolas Zimmermann <nzimmermann@rim.com> 7601 7602 Rubber-stamped by Maciej Stachowiak. 7603 7604 Turn on (SVG) Filters for Qt. 7605 https://bugs.webkit.org/show_bug.cgi?id=32224 7606 7607 * Scripts/build-webkit: 7608 76092009-12-07 Yuzo Fujishima <yuzo@google.com> 7610 7611 Reviewed by Alexey Proskuryakov. 7612 7613 Make run-webkit-websocketserver log to stderr rather than to a file. 7614 https://bugs.webkit.org/show_bug.cgi?id=32234 7615 7616 * Scripts/run-webkit-websocketserver: 7617 76182009-12-07 Dmitry Titov <dimich@chromium.org> 7619 7620 Rubber-stamped by Darin Adler. 7621 7622 Remove ENABLE_SHARED_SCRIPT flags 7623 https://bugs.webkit.org/show_bug.cgi?id=32245 7624 This patch was obtained by "git revert" command and then un-reverting of ChangeLog files. 7625 7626 * Scripts/build-webkit: 7627 76282009-12-07 Simon Fraser <simon.fraser@apple.com> 7629 7630 Reviewed by Darin Adler. 7631 7632 <rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests 7633 7634 The counter that WebView used to keep track of the number of enclosed WebHTMLViews using 7635 accelerated compositing was hard to manage, and maintained incorrectly in a number of cases. 7636 This caused one compositing test make DumpRenderTree think that all subsequent tests 7637 were compositing too. 7638 7639 Replace this counter with notifications, which are only fired if a client (DRT) requests them. The 7640 notification informs the client that a WebHTMLView entered compositing mode (or an already- 7641 compositing WebHTML was added); it does not say when a view becomes uncomposited, or all 7642 compositing subviews were removed, since this is tricky to get right. 7643 7644 DumpRenderTreeWindow listens for this notification, and uses it to turn on window 7645 autodisplay, which is necessary to kick-start Core Animation rendering and animations. 7646 We ensure that window autodisplay is turned off before every test. 7647 7648 * DumpRenderTree/mac/DumpRenderTree.mm: 7649 (createWebViewAndOffscreenWindow): 7650 (resetWebViewToConsistentStateBeforeTesting): 7651 * DumpRenderTree/mac/DumpRenderTreeWindow.h: 7652 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: 7653 (-[DumpRenderTreeWindow close]): 7654 (-[DumpRenderTreeWindow startListeningForAcceleratedCompositingChanges]): 7655 (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]): 7656 76572009-12-07 Nikolas Zimmermann <nzimmermann@rim.com> 7658 7659 Reviewed by Holger Hans Peter Freyther. 7660 7661 Turn on (SVG) Filters support, by default. 7662 https://bugs.webkit.org/show_bug.cgi?id=32224 7663 7664 For now only enable FILTERS build flag on WebKit/mac. Other platforms will follow soon. 7665 7666 * Scripts/build-webkit: 7667 76682009-12-07 Yaar Schnitman <yaar@chromium.org> 7669 7670 Reviewed by Darin Fisher. 7671 7672 Chromium buildbots are not red when they fail 7673 https://bugs.webkit.org/show_bug.cgi?id=32235 7674 7675 * Scripts/build-webkit: 7676 76772009-12-07 Yaar Schnitman <yaar@chromium.org> 7678 7679 Reviewed by Darin Fisher. 7680 7681 Typo in chromium linux builder 7682 https://bugs.webkit.org/show_bug.cgi?id=32238 7683 7684 * Scripts/webkitdirs.pm: 7685 76862009-12-07 Yaar Schnitman <yaar@chromium.org> 7687 7688 Reviewed by Darin Fisher. 7689 7690 fixes to build-webkit --chromium 7691 https://bugs.webkit.org/show_bug.cgi?id=32179 7692 7693 * Scripts/webkitdirs.pm: 7694 76952009-12-07 Eric Seidel <eric@webkit.org> 7696 7697 No review, just adding two recently approved committers. 7698 7699 * Scripts/modules/committers.py: 7700 77012009-12-07 Alexey Proskuryakov <ap@apple.com> 7702 7703 * Scripts/run-webkit-websocketserver: Added property svn:executable. 7704 77052009-12-07 Yuzo Fujishima <yuzo@google.com> 7706 7707 Reviewed by Alexey Proskuryakov. 7708 7709 Add run-webkit-websocketserver 7710 7711 https://bugs.webkit.org/show_bug.cgi?id=31390 7712 7713 * Scripts/run-webkit-websocketserver: Added. 7714 77152009-12-07 Steve Falkenburg <sfalken@apple.com> 7716 7717 Build fix. Be flexible about which version of ICU is used on Windows. 7718 7719 * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2. 7720 77212009-12-07 Dirk Schulze <krit@webkit.org> 7722 7723 Not reviewed, adding myself to the reviewers list. 7724 7725 * Scripts/modules/committers.py: 7726 77272009-12-06 Eric Seidel <eric@webkit.org> 7728 7729 Reviewed by Adam Barth. 7730 7731 Add an API for uploading results files to StatusBot 7732 https://bugs.webkit.org/show_bug.cgi?id=32210 7733 7734 Add Content-Type: plain/text which was forgotten 7735 from the previous commit when I landed with land-patches 7736 instead of land-diff. 7737 7738 * QueueStatusServer/queue_status.py: 7739 77402009-12-06 Eric Seidel <eric@webkit.org> 7741 7742 Reviewed by Adam Barth. 7743 7744 Status Server needs a way to handle uploaded results 7745 https://bugs.webkit.org/show_bug.cgi?id=32209 7746 7747 * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command 7748 * QueueStatusServer/update_status.html: Add file upload. 7749 77502009-12-06 Eric Seidel <eric@webkit.org> 7751 7752 Reviewed by Adam Barth. 7753 7754 Add an API for uploading results files to StatusBot 7755 https://bugs.webkit.org/show_bug.cgi?id=32210 7756 7757 * Scripts/modules/statusbot.py: 7758 77592009-12-06 Eric Seidel <eric@webkit.org> 7760 7761 Reviewed by Adam Barth. 7762 7763 Status Server needs a way to handle uploaded results 7764 https://bugs.webkit.org/show_bug.cgi?id=32209 7765 7766 * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command 7767 * QueueStatusServer/update_status.html: Add file upload. 7768 77692009-12-06 Adam Barth <abarth@webkit.org> 7770 7771 Reviewed by Eric Seidel. 7772 7773 [bzt] BuildAttachment should not check the builders 7774 https://bugs.webkit.org/show_bug.cgi?id=32207 7775 7776 This is code that got copied here by accident when the class was created. 7777 7778 * Scripts/modules/commands/download.py: 7779 77802009-12-06 Adam Barth <abarth@webkit.org> 7781 7782 Reviewed by Eric Seidel. 7783 7784 [bzt] Make LandingSequence.update aware of ports 7785 https://bugs.webkit.org/show_bug.cgi?id=32208 7786 7787 This is required to make build work on the Chromium port because 7788 Chromium has a custom update-webkit. 7789 7790 * Scripts/modules/landingsequence.py: 7791 77922009-12-06 Adam Barth <abarth@webkit.org> 7793 7794 Reviewed by Eric Seidel. 7795 7796 Add early warning system commands to bugzilla-tool. 7797 7798 * Scripts/bugzilla-tool: 7799 * Scripts/modules/landingsequence.py: 7800 * Scripts/modules/webkitport.py: 7801 78022009-12-06 Adam Barth <abarth@webkit.org> 7803 7804 Reviewed by Eric Seidel. 7805 7806 [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem 7807 https://bugs.webkit.org/show_bug.cgi?id=32205 7808 7809 * Scripts/modules/commands/early_warning_system.py: Added. 7810 * Scripts/modules/commands/queues.py: 7811 78122009-12-06 Dan Bernstein <mitz@apple.com> 7813 7814 Reviewed by Adele Peterson. 7815 7816 REGRESSION (r51728): update-webkit fails when the current directory is 7817 not inside a Subversion working copy 7818 https://bugs.webkit.org/show_bug.cgi?id=32204 7819 7820 * Scripts/update-webkit: Invoke isSVN() in the correct working 7821 directory. 7822 78232009-12-06 Adam Barth <abarth@webkit.org> 7824 7825 Reviewed by Eric Seidel. 7826 7827 [bzt] Rename AbstractTryQueue to AbstractReviewQueue 7828 https://bugs.webkit.org/show_bug.cgi?id=32202 7829 7830 * Scripts/modules/commands/queues.py: 7831 78322009-12-05 Adam Barth <abarth@webkit.org> 7833 7834 Reviewed by Eric Seidel. 7835 7836 [bzt] Implement ChromiumPort 7837 https://bugs.webkit.org/show_bug.cgi?id=32182 7838 7839 * Scripts/modules/webkitport.py: 7840 * Scripts/modules/webkitport_unittest.py: 7841 78422009-12-05 Adam Barth <abarth@webkit.org> 7843 7844 Reviewed by Eric Seidel. 7845 7846 Move update-webkit into BuildSteps 7847 https://bugs.webkit.org/show_bug.cgi?id=32181 7848 7849 We need to move update-webkit out of SCM.py because SCM isn't supposed to know 7850 that WebKit exists. The proper place for the knowledge of the existence of 7851 update-webkit is in WebKitPort because some ports have specialized update 7852 scripts (analogous to build-webkit). 7853 7854 * Scripts/modules/buildsteps.py: 7855 * Scripts/modules/commands/download.py: 7856 * Scripts/modules/landingsequence.py: 7857 * Scripts/modules/scm.py: 7858 * Scripts/modules/webkitport.py: 7859 78602009-12-05 Adam Barth <abarth@webkit.org> 7861 7862 Reviewed by Eric Seidel. 7863 7864 update-webkit should call git svn rebase and resolve-ChangeLogs -f 7865 https://bugs.webkit.org/show_bug.cgi?id=27162 7866 7867 Teach update-webkit about Git. I didn't add the call to 7868 resolve-ChangeLogs -f because sometimes that script goes bananas. We 7869 can iterate from here, however. 7870 7871 * Scripts/update-webkit: 7872 78732009-12-04 Yael Aharon <yael.aharon@nokia.com> 7874 7875 Unreviewed build fix. 7876 7877 [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h. 7878 7879 * DumpRenderTree/qt/DumpRenderTree.cpp: 7880 78812009-12-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 7882 7883 Reviewed by Adam Treat. 7884 7885 Add some missing methods for showing and hiding the 7886 Web Inspector. 7887 7888 * DumpRenderTree/qt/DumpRenderTree.cpp: 7889 (WebCore::WebPage::WebPage): 7890 (WebCore::WebPage::~WebPage): 7891 (WebCore::WebPage::webInspector): 7892 * DumpRenderTree/qt/DumpRenderTree.h: 7893 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7894 (LayoutTestController::showWebInspector): 7895 (LayoutTestController::hideWebInspector): 7896 * DumpRenderTree/qt/LayoutTestControllerQt.h: 7897 78982009-12-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 7899 7900 Reviewed by Adam Treat. 7901 7902 Implement the setAllowUniversalAccessFromFileURLs method 7903 for the Qt LayoutTestController. 7904 7905 * DumpRenderTree/qt/DumpRenderTree.cpp: 7906 (WebCore::WebPage::resetSettings): 7907 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7908 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 7909 * DumpRenderTree/qt/LayoutTestControllerQt.h: 7910 79112009-12-04 Chris Fleizach <cfleizach@apple.com> 7912 7913 Reviewed by Darin Adler. 7914 7915 REGRESSION: AX: buttons now extremely repetitive 7916 https://bugs.webkit.org/show_bug.cgi?id=32164 7917 7918 * DumpRenderTree/AccessibilityUIElement.cpp: 7919 (isAttributeSupportedCallback): 7920 (AccessibilityUIElement::getJSClass): 7921 * DumpRenderTree/AccessibilityUIElement.h: 7922 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 7923 (AccessibilityUIElement::isAttributeSupported): 7924 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 7925 (AccessibilityUIElement::isAttributeSupported): 7926 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 7927 (AccessibilityUIElement::isAttributeSupported): 7928 79292009-12-03 Shinichiro Hamaji <hamaji@chromium.org> 7930 7931 Reviewed by David Levin. 7932 7933 check-webkit-style should check for camelCase variable names 7934 https://bugs.webkit.org/show_bug.cgi?id=32051 7935 7936 * Scripts/modules/cpp_style.py: 7937 * Scripts/modules/cpp_style_unittest.py: 7938 79392009-12-03 Chris Fleizach <cfleizach@apple.com> 7940 7941 Reviewed by Eric Seidel. 7942 7943 AX: VO just says "term" on many web sites 7944 https://bugs.webkit.org/show_bug.cgi?id=32139 7945 7946 * DumpRenderTree/AccessibilityUIElement.cpp: 7947 (getRoleDescriptionCallback): 7948 (AccessibilityUIElement::getJSClass): 7949 * DumpRenderTree/AccessibilityUIElement.h: 7950 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 7951 (AccessibilityUIElement::roleDescription): 7952 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 7953 (AccessibilityUIElement::roleDescription): 7954 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 7955 (AccessibilityUIElement::roleDescription): 7956 79572009-12-03 Chris Fleizach <cfleizach@apple.com> 7958 7959 Reviewed by Beth Dakin. 7960 7961 Implement WAI-ARIA scrollbar role and related property aria-orientation 7962 https://bugs.webkit.org/show_bug.cgi?id=32126 7963 7964 * DumpRenderTree/AccessibilityUIElement.cpp: 7965 (getOrientationCallback): 7966 (AccessibilityUIElement::getJSClass): 7967 * DumpRenderTree/AccessibilityUIElement.h: 7968 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 7969 (AccessibilityUIElement::orientation): 7970 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 7971 (AccessibilityUIElement::orientation): 7972 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 7973 (AccessibilityUIElement::orientation): 7974 79752009-12-03 Eric Carlson <eric.carlson@apple.com> 7976 7977 Reviewed by Adam Roben. 7978 7979 Minor correction to r51663. 7980 7981 * DumpRenderTree/win/DumpRenderTree.cpp: 7982 (addQTDirToPATH): 7983 GetEnvironmentVariable -> GetEnvironmentVariableW. 7984 79852009-12-03 Eric Carlson <eric.carlson@apple.com> 7986 7987 Reviewed by Adam Roben. 7988 7989 ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3) 7990 https://bugs.webkit.org/show_bug.cgi?id=30256 7991 7992 Add the QuickTime dll directory to the PATH environment variable so 7993 inialization can succeed. 7994 7995 * DumpRenderTree/win/DumpRenderTree.cpp: 7996 (addQTDirToPATH): 7997 (initialize): 7998 79992009-12-03 Shu Chang <Chang.Shu@nokia.com> 8000 8001 Reviewed by Kenneth Rohde Christiansen. 8002 8003 [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame. 8004 8005 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 8006 (LayoutTestController::maybeDump): 8007 80082009-12-03 Yuzo Fujishima <yuzo@google.com> 8009 8010 Reviewed by Eric Seidel. 8011 8012 Update pywebsocket to 0.4.3 8013 This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests. 8014 Stack trace is logged now in INFO level. 8015 https://bugs.webkit.org/show_bug.cgi?id=32097 8016 8017 * pywebsocket/mod_pywebsocket/dispatch.py: 8018 * pywebsocket/mod_pywebsocket/msgutil.py: 8019 * pywebsocket/mod_pywebsocket/standalone.py: 8020 * pywebsocket/mod_pywebsocket/util.py: 8021 * pywebsocket/setup.py: 8022 * pywebsocket/test/test_dispatch.py: 8023 * pywebsocket/test/test_util.py: 8024 80252009-12-03 Sam Weinig <sam@webkit.org> 8026 8027 Reviewed by Gavin Barraclough. 8028 8029 Fix JSClassRef leak. 8030 8031 * DumpRenderTree/AccessibilityController.cpp: 8032 (AccessibilityController::makeWindowObject): 8033 * DumpRenderTree/GCController.cpp: 8034 (GCController::makeWindowObject): 8035 * DumpRenderTree/LayoutTestController.cpp: 8036 (LayoutTestController::makeWindowObject): 8037 80382009-12-03 Brady Eidson <beidson@apple.com> 8039 8040 Reviewed by Sam Weinig. 8041 8042 <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API 8043 8044 Keep DRT-win building... 8045 8046 * DumpRenderTree/win/FrameLoadDelegate.h: 8047 (FrameLoadDelegate::didPushStateWithinPageForFrame): 8048 (FrameLoadDelegate::didReplaceStateWithinPageForFrame): 8049 (FrameLoadDelegate::didPopStateWithinPageForFrame): 8050 80512009-12-03 Andras Becsi <abecsi@inf.u-szeged.hu> 8052 8053 Unreviewed build fix. 8054 8055 [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM. 8056 8057 * DumpRenderTree/qt/DumpRenderTree.cpp: 8058 80592009-12-03 Andras Becsi <abecsi@inf.u-szeged.hu> 8060 8061 Reviewed by Kenneth Rohde Christiansen. 8062 8063 [Qt] Refactor DRT to not crash on tests which open child windows from javascript. 8064 Prevent DRT from showing the main view if these childs get deleted. 8065 This fixes https://bugs.webkit.org/show_bug.cgi?id=31591. 8066 8067 * DumpRenderTree/qt/DumpRenderTree.cpp: 8068 (WebCore::WebPage::WebPage): 8069 (WebCore::DumpRenderTree::DumpRenderTree): 8070 (WebCore::DumpRenderTree::~DumpRenderTree): 8071 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 8072 (WebCore::DumpRenderTree::open): 8073 (WebCore::DumpRenderTree::closeRemainingWindows): 8074 (WebCore::DumpRenderTree::createWindow): 8075 (WebCore::DumpRenderTree::windowCount): 8076 * DumpRenderTree/qt/DumpRenderTree.h: 8077 80782009-12-02 Eric Seidel <eric@webkit.org> 8079 8080 Reviewed by Adam Barth. 8081 8082 REGRESSION(51595): commit-queue is throwing exceptions 8083 https://bugs.webkit.org/show_bug.cgi?id=32083 8084 8085 * Scripts/modules/commands/queues.py: 8086 - Don't use default value of [] as it ends up getting shared. 8087 - Make log_progress accept arrays of ints as well as strings. 8088 - Return an exit code from execute() 8089 * Scripts/modules/commands/queues_unittest.py: Added. 8090 - Test to make sure log_progress will accept ints. 8091 - Test to make sure run_bugzilla_tool will accept ints. 8092 * Scripts/modules/workqueue.py: 8093 - Print the stack trace on unexpected exceptions for easier debugging. 8094 * Scripts/run-webkit-unittests: 8095 - Add queues_unittest. 8096 8097 * Scripts/modules/commands/queues.py: 8098 * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py. 8099 * Scripts/modules/mock_bugzillatool.py: 8100 * Scripts/modules/workqueue.py: 8101 * Scripts/run-webkit-unittests: 8102 81032009-12-02 David Levin <levin@chromium.org> 8104 8105 Reviewed by Adam Barth. 8106 8107 check-webkit-style is too noisy about namespace indenting issues. 8108 https://bugs.webkit.org/show_bug.cgi?id=32096 8109 8110 * Scripts/modules/cpp_style.py: 8111 Added a _FileState object to be able to track file level information. In this 8112 case, it simply tracks whether the error has already been given, so that it isn't 8113 done again. 8114 * Scripts/modules/cpp_style_unittest.py: 8115 Modified test cases to pass in the _FileState object and fix a test that expected 8116 to see the namespace error twice (now it only occurs once). No new tests because 8117 existing tests cover the change in functionality. 8118 81192009-12-01 Kevin Ollivier <kevino@theolliviers.com> 8120 8121 Reviewed by Eric Seidel. 8122 8123 [wx] Get DumpRenderTree building after waf switch. 8124 8125 https://bugs.webkit.org/show_bug.cgi?id=32041 8126 8127 * DumpRenderTree/wscript: Added. 8128 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 8129 (LayoutTestController::setTimelineProfilingEnabled): 8130 (LayoutTestController::evaluateScriptInIsolatedWorld): 8131 (LayoutTestController::disableImageLoading): 8132 (LayoutTestController::whiteListAccessFromOrigin): 8133 (LayoutTestController::counterValueForElementById): 8134 * Scripts/build-webkit: 8135 81362009-12-02 Adam Barth <abarth@webkit.org> 8137 8138 Reviewed by Eric Seidel. 8139 8140 [bzt] build-attachment shouldn't check whether the builders are red 8141 https://bugs.webkit.org/show_bug.cgi?id=32062 8142 8143 build-attachment doesn't touch the remote repository, so there isn't a 8144 need to hold off when the builders are red. 8145 8146 * Scripts/modules/commands/download.py: 8147 * Scripts/modules/landingsequence.py: 8148 81492009-12-02 Eric Seidel <eric@webkit.org> 8150 8151 Reviewed by Adam Barth. 8152 8153 REGRESSION(51590): style-queue and build-queue think their empty when they are not 8154 https://bugs.webkit.org/show_bug.cgi?id=32061 8155 8156 * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings. 8157 * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints. 8158 81592009-12-02 Eric Seidel <eric@webkit.org> 8160 8161 Reviewed by Adam Barth. 8162 8163 build-queue is throwing exceptions and complaining about 8164 lack of --no-update on build-attachment. Make it stop. 8165 8166 * Scripts/modules/buildsteps.py: 8167 * Scripts/modules/commands/download.py: 8168 81692009-12-02 Adam Barth <abarth@webkit.org> 8170 8171 Unreviewed "build" fix. Forgot to declare my variables. :( 8172 8173 * QueueStatusServer/queue_status.py: 8174 81752009-12-02 Adam Barth <abarth@webkit.org> 8176 8177 Reviewed by Eric Seidel. 8178 8179 [bzt] Implement status bubble view 8180 https://bugs.webkit.org/show_bug.cgi?id=32057 8181 8182 The status bubble is a compact representation of the queue status for a 8183 given patch. This will eventually help us reduce the comment spam from 8184 the queues. 8185 8186 * QueueStatusServer/index.html: Added HTML5 doctype for sanity. 8187 * QueueStatusServer/queue_status.py: 8188 * QueueStatusServer/status_bubble.html: Added. 8189 81902009-12-02 Eric Seidel <eric@webkit.org> 8191 8192 Reviewed by Adam Barth. 8193 8194 trim commands/*.py includes now that commands are unit tested 8195 https://bugs.webkit.org/show_bug.cgi?id=32056 8196 8197 In the course of ensuring that the unit tests still 8198 passed after this change, I had to actually make them 8199 pass in the first place. 8200 8201 * Scripts/modules/bugzilla.py: 8202 - Fix _parse_attachment_ids_request_query to return ints instead of strings. 8203 * Scripts/modules/commands/download.py: Remove unneeded imports. 8204 * Scripts/modules/commands/queries.py: Ditto. 8205 * Scripts/modules/commands/queues.py: Ditto. 8206 * Scripts/modules/commands/upload.py: Ditto. 8207 * Scripts/modules/scm_unittest.py: 8208 - Fix to expect the \n after the path since echo adds an \n. 8209 82102009-12-01 Yaar Schnitman <yaar@chromium.org> 8211 8212 build-webkit: Remove flex,bison,gperf check for chromium 8213 https://bugs.webkit.org/show_bug.cgi?id=32043 8214 8215 * Scripts/webkitdirs.pm: 8216 82172009-12-01 Chris Fleizach <cfleizach@apple.com> 8218 8219 Build fixage for Windows/GTK for DumpRenderTree. 8220 8221 WAI-ARIA: implement support for ARIA drag and drop 8222 https://bugs.webkit.org/show_bug.cgi?id=32007 8223 8224 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 8225 (AccessibilityUIElement::ariaIsGrabbed): 8226 (AccessibilityUIElement::ariaDropEffects): 8227 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 8228 (AccessibilityUIElement::ariaIsGrabbed): 8229 (AccessibilityUIElement::ariaDropEffects): 8230 82312009-12-01 Chris Fleizach <cfleizach@apple.com> 8232 8233 Reviewed by Darin Adler. 8234 8235 WAI-ARIA: implement support for ARIA drag and drop 8236 https://bugs.webkit.org/show_bug.cgi?id=32007 8237 8238 * DumpRenderTree/AccessibilityUIElement.cpp: 8239 (getARIADropEffectsCallback): 8240 (getARIAIsGrabbedCallback): 8241 (AccessibilityUIElement::getJSClass): 8242 * DumpRenderTree/AccessibilityUIElement.h: 8243 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 8244 (AccessibilityUIElement::ariaIsGrabbed): 8245 (AccessibilityUIElement::ariaDropEffects): 8246 82472009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> 8248 8249 Not reviewed. GTK DRT try 2. 8250 8251 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 8252 (LayoutTestController::sampleSVGAnimationForElementAtTime): 8253 82542009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> 8255 8256 Not reviewed. Try to fix gtk DRT build. 8257 8258 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 8259 82602009-12-01 David Levin <levin@chromium.org> 8261 8262 Reviewed by Eric Seidel. 8263 8264 check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h 8265 https://bugs.webkit.org/show_bug.cgi?id=32033 8266 8267 * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find 8268 instead of startswith. 8269 * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior. 8270 82712009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> 8272 8273 Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well. 8274 8275 * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature. 8276 82772009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> 8278 8279 Reviewed by Simon Fraser. 8280 8281 Add SVG animation test framework with 'snapshot' functionality 8282 https://bugs.webkit.org/show_bug.cgi?id=31897 8283 8284 Add new 'sampleSVGAnimationForElementAtTime' DRT method, 8285 used by the new SVG animation testing framework, implemented 8286 for qt/gtk/win/mac. 8287 8288 * DumpRenderTree/LayoutTestController.cpp: 8289 (sampleSVGAnimationForElementAtTimeCallback): 8290 (LayoutTestController::staticFunctions): 8291 * DumpRenderTree/LayoutTestController.h: 8292 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 8293 (LayoutTestController::sampleSVGAnimationForElementAtTime): 8294 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 8295 (LayoutTestController::sampleSVGAnimationForElementAtTime): 8296 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 8297 (LayoutTestController::sampleSVGAnimationForElementAtTime): 8298 * DumpRenderTree/qt/LayoutTestControllerQt.h: 8299 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 8300 (LayoutTestController::sampleSVGAnimationForElementAtTime): 8301 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 8302 (LayoutTestController::sampleSVGAnimationForElementAtTime): 8303 83042009-12-01 Adam Roben <aroben@apple.com> 8305 8306 Remove user content before running each test on Windows 8307 8308 Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows 8309 8310 Reviewed by Alexey Proskuryakov. 8311 8312 * DumpRenderTree/win/DumpRenderTree.cpp: 8313 (resetWebViewToConsistentStateBeforeTesting): Remove all user content 8314 before each test, which matches Mac. 8315 83162009-12-01 Yuzo Fujishima <yuzo@google.com> 8317 8318 Reviewed by Alexey Proskuryakov. 8319 8320 Make pywebsocket log errors to a file 8321 https://bugs.webkit.org/show_bug.cgi?id=31604 8322 8323 * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory 8324 (by passing the path to the server via a recently added -l option). 8325 83262009-12-01 Adam Roben <aroben@apple.com> 8327 8328 Fix tests that use the TestNetscapePlugin in Debug_Internal builds 8329 8330 Reviewed by Ada Chan. 8331 8332 Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use 8333 TestNetscapePlugin fail in Debug_Internal builds 8334 8335 * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin 8336 directory in Debug and Debug_All builds, but not in Debug_Internal 8337 builds. 8338 83392009-12-01 Adam Roben <aroben@apple.com> 8340 8341 Re-enable DRT's watchdog timer on Windows 8342 8343 It was accidentally disabled in r50907. 8344 8345 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 8346 (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck 8347 into an if condition. 8348 83492009-12-01 Adam Barth <abarth@webkit.org> 8350 8351 Reviewed by Eric Seidel. 8352 8353 check-webkit-style complains about #imports with / in them 8354 https://bugs.webkit.org/show_bug.cgi?id=32022 8355 8356 We need to exclude #import directives in addition to #include from the 8357 binary operator whitespace checks. 8358 8359 * Scripts/modules/cpp_style.py: 8360 * Scripts/modules/cpp_style_unittest.py: 8361 83622009-11-30 Adam Barth <abarth@webkit.org> 8363 8364 Reviewed by Eric Seidel. 8365 8366 check-webkit-style is slightly too verbose 8367 https://bugs.webkit.org/show_bug.cgi?id=32010 8368 8369 check-webkit-style prints out a bunch of "done" lines that seem redundant, 8370 especially for the style-queue. 8371 8372 * Scripts/modules/cpp_style.py: 8373 83742009-11-30 Alejandro G. Castro <alex@igalia.com> 8375 8376 Reviewed by Eric Seidel. 8377 8378 [GTK] Moved the functions that are closing the result log of the 8379 tests to the last line of the runTest function, this avoids 8380 reporting crashes in the wrong test if there is a problem when 8381 reseting the state after the test. 8382 8383 * DumpRenderTree/gtk/DumpRenderTree.cpp: 8384 (dump): 8385 (runTest): 8386 83872009-11-30 Sam Weinig <sam@webkit.org> 8388 8389 Reviewed by Geoffrey Garen. 8390 8391 Fix for https://bugs.webkit.org/show_bug.cgi?id=31286 8392 fast/js/date-proto-generic-invocation breaks another test 8393 8394 Don't cache JSClassRefs, a change to the prototype chain will 8395 last between tests. 8396 8397 * DumpRenderTree/AccessibilityController.cpp: 8398 (AccessibilityController::getJSClass): 8399 * DumpRenderTree/GCController.cpp: 8400 (GCController::getJSClass): 8401 * DumpRenderTree/GCController.h: 8402 * DumpRenderTree/LayoutTestController.cpp: 8403 (LayoutTestController::getJSClass): 8404 84052009-11-30 Yuzo Fujishima <yuzo@google.com> 8406 8407 Reviewed by Alexey Proskuryakov. 8408 8409 Update pywebsocket to 0.4.2.1. 8410 This is to fix a bug that some messages are logged to stderr even when the log file is specified. 8411 https://bugs.webkit.org/show_bug.cgi?id=31976 8412 8413 * pywebsocket/mod_pywebsocket/standalone.py: 8414 * pywebsocket/setup.py: 8415 84162009-11-30 Adam Barth <abarth@webkit.org> 8417 8418 Reviewed by Eric Seidel. 8419 8420 [bzt] Generate pass messages for style-queue 8421 https://bugs.webkit.org/show_bug.cgi?id=31995 8422 8423 With this change, the style-queue posts "pass" messages to bugs as 8424 well. Also, added more information to the state store w.r.t. passing 8425 and failing. 8426 8427 * Scripts/modules/commands/queues.py: 8428 * Scripts/modules/patchcollection.py: 8429 84302009-11-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8431 8432 Reviewed by Simon Fraser. 8433 8434 Check for WEBKIT_TESTFONTS environment variable in 8435 run-webkit-tests, for GTK+, to have a more prominent error 8436 message. 8437 8438 * Scripts/run-webkit-tests: 8439 84402009-11-30 Yaar Schnitman <yaar@chromium.org> 8441 8442 Reviewed by Dimitri Glazkov. 8443 8444 update-webkit --chromium forces gclient sync 8445 8446 https://bugs.webkit.org/show_bug.cgi?id=31967 8447 8448 * Scripts/update-webkit-chromium: 8449 84502009-11-29 Eric Seidel <eric@webkit.org> 8451 8452 Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights. 8453 8454 * Scripts/modules/committers.py: 8455 84562009-11-29 Eric Seidel <eric@webkit.org> 8457 8458 No review, just adding missing svn property. 8459 8460 Set svn:executable property on new scripts. 8461 These were added by commit-queue commits, but the executable 8462 property was lost due to a bug in svn-apply: 8463 https://bugs.webkit.org/show_bug.cgi?id=27204 8464 8465 * Scripts/update-webkit-chromium: Added property svn:executable. 8466 * Scripts/validate-committer-lists: Added property svn:executable. 8467 84682009-11-29 Eric Seidel <eric@webkit.org> 8469 8470 Reviewed by Adam Barth. 8471 8472 Need a way to validate that committers.py includes all committers/reviewers 8473 https://bugs.webkit.org/show_bug.cgi?id=30970 8474 8475 Add a script which knows how to compare our public committer/reviewer 8476 lists and show discrepancies between them. 8477 8478 Validates mailing lists vs. committers.py: 8479 - committers.py committers missing from webkit-committers@lists 8480 - webkit-committers@lists members missing from committers.py 8481 - committers.py reviewers missing from webkit-reviewers@lists 8482 - webkit-reviewers@lists members missing from committers.py 8483 - webkit-reviewers@lists members missing from committers.py reviewer list 8484 8485 Validates committers.py vs. trunk/ SVN history: 8486 - committers who have not committed in over a year 8487 - SVN committers missing from committers.py 8488 - committers.py members who have no record in SVN. 8489 8490 All of these lists still show "false positives" until a few more committers.py updates are made, like: 8491 https://bugs.webkit.org/show_bug.cgi?id=31366 8492 8493 * Scripts/validate-committer-lists: Added. 8494 84952009-11-28 Adam Barth <abarth@webkit.org> 8496 8497 Reviewed by Eric Seidel. 8498 8499 [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes 8500 https://bugs.webkit.org/show_bug.cgi?id=31950 8501 8502 Now we cache the last status that we get back from QueueStatusServer. 8503 Eventually we'll have to do something more fancy if we want to support 8504 a "try again" button on QueueStatusServer, but we can cross that bridge 8505 when we come to it. 8506 8507 * Scripts/modules/patchcollection.py: 8508 85092009-11-28 Adam Barth <abarth@webkit.org> 8510 8511 Reviewed by Eric Seidel. 8512 8513 StyleQueue scans ~100 bug pages every 5 minutes 8514 https://bugs.webkit.org/show_bug.cgi?id=31947 8515 8516 Instead of getting the pending-review attachment ids by scanning each 8517 bug (which results in a network request), we should just get them all 8518 from webkit.org/pending-review in one shot. 8519 8520 * Scripts/modules/bugzilla.py: 8521 * Scripts/modules/bugzilla_unittest.py: 8522 * Scripts/modules/commands/queries.py: 8523 * Scripts/modules/commands/queries_unittest.py: 8524 * Scripts/modules/commands/queues.py: 8525 * Scripts/modules/mock_bugzillatool.py: 8526 * Scripts/modules/patchcollection.py: 8527 85282009-11-28 Adam Barth <abarth@webkit.org> 8529 8530 Reviewed by Eric Seidel. 8531 8532 [bzt] CC webkit-bot-watchers whenever the bots touch bugs 8533 https://bugs.webkit.org/show_bug.cgi?id=31952 8534 8535 The mailing list is open for anyone to subscribe. 8536 8537 * Scripts/modules/bugzilla.py: 8538 * Scripts/modules/commands/queues.py: 8539 85402009-11-28 Adam Barth <abarth@webkit.org> 8541 8542 Reviewed by Eric Seidel. 8543 8544 [bzt] style-queue should report style errors to bugzilla 8545 https://bugs.webkit.org/show_bug.cgi?id=31945 8546 8547 Currently, we're just logging the style errors locally. With this 8548 patch we'll actually log the errors to bugzilla. Note: I plan to run 8549 with the "local-only" logging during development. 8550 8551 * Scripts/modules/commands/queues.py: 8552 * Scripts/modules/scm.py: 8553 85542009-11-28 Adam Barth <abarth@webkit.org> 8555 8556 Reviewed by Eric Seidel. 8557 8558 [bzt] style-queue shouldn't reject patches from the commit-queue 8559 https://bugs.webkit.org/show_bug.cgi?id=31944 8560 8561 Currently the style-queue subprocess gets confused and thinks its the 8562 commit-queue. If the patch has an error, it rejects it from the 8563 commit-queue. Instead, we should have style-queue specific logic. 8564 This patch doesn't add that logic, but it gives us a callback we can 8565 use to add that logic. 8566 8567 * Scripts/modules/buildsteps.py: 8568 * Scripts/modules/commands/queues.py: 8569 * Scripts/modules/landingsequence.py: 8570 85712009-11-27 Adam Barth <abarth@webkit.org> 8572 8573 Rubber stamped by Eric Seidel. 8574 8575 Rename CommitQueueStatus to QueueStatusServer to allow for more queues. 8576 8577 * CommitQueueStatus: Removed. 8578 * CommitQueueStatus/app.yaml: Removed. 8579 * CommitQueueStatus/filters: Removed. 8580 * CommitQueueStatus/filters/__init__.py: Removed. 8581 * CommitQueueStatus/filters/webkit_extras.py: Removed. 8582 * CommitQueueStatus/index.html: Removed. 8583 * CommitQueueStatus/index.yaml: Removed. 8584 * CommitQueueStatus/queue_status.py: Removed. 8585 * CommitQueueStatus/stylesheets: Removed. 8586 * CommitQueueStatus/stylesheets/main.css: Removed. 8587 * CommitQueueStatus/update_status.html: Removed. 8588 * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus. 8589 85902009-11-27 Adam Barth <abarth@webkit.org> 8591 8592 Reviewed by Eric Seidel. 8593 8594 style-queue should only process each patch once 8595 https://bugs.webkit.org/show_bug.cgi?id=31939 8596 8597 Actually address reviewer comments! 8598 8599 * Scripts/bugzilla-tool: 8600 86012009-11-27 Adam Barth <abarth@webkit.org> 8602 8603 Reviewed by Eric Seidel. 8604 8605 [bzt] style-queue fails to apply a bunch of patches for no reason 8606 https://bugs.webkit.org/show_bug.cgi?id=31942 8607 8608 By passing --non-interactive to check-style, we convince check-style 8609 to pass --force to svn-apply, which lets it apply more patches. 8610 8611 * Scripts/modules/commands/queues.py: 8612 86132009-11-27 Adam Barth <abarth@webkit.org> 8614 8615 Reviewed by Eric Seidel. 8616 8617 [bzt] Support --status-host in style-queue 8618 https://bugs.webkit.org/show_bug.cgi?id=31941 8619 8620 * Scripts/modules/commands/queues.py: 8621 * Scripts/modules/statusbot.py: 8622 86232009-11-27 Adam Barth <abarth@webkit.org> 8624 8625 Reviewed by Eric Seidel. 8626 8627 style-queue should only process each patch once 8628 https://bugs.webkit.org/show_bug.cgi?id=31939 8629 8630 Before processing a patch, the try-queues now ask the web service 8631 whether they have already processed the patch. This is an initial cut 8632 of this functionality. I expect we're make it richer over time. 8633 8634 * Scripts/bugzilla-tool: 8635 * Scripts/modules/commands/queues.py: 8636 * Scripts/modules/patchcollection.py: 8637 86382009-11-27 Adam Barth <abarth@webkit.org> 8639 8640 Reviewed by Eric Seidel. 8641 8642 PatchStatus does not return status 8643 https://bugs.webkit.org/show_bug.cgi?id=31938 8644 8645 We need to parse attachment_id as an int. Otherwise, we can't find 8646 anything in the datastore. 8647 8648 * CommitQueueStatus/queue_status.py: 8649 86502009-11-27 Adam Barth <abarth@webkit.org> 8651 8652 Reviewed by Eric Seidel. 8653 8654 Make commit-queue status not throw an exception where there is not 8655 status 8656 https://bugs.webkit.org/show_bug.cgi?id=31936 8657 8658 We need to actually fetch the results of the query to see what's in the 8659 datastore. 8660 8661 * CommitQueueStatus/queue_status.py: 8662 86632009-11-27 Adam Barth <abarth@webkit.org> 8664 8665 Reviewed by Eric Seidel. 8666 8667 [bzt] unit test ApplyPatches and ApplyAttachment 8668 https://bugs.webkit.org/show_bug.cgi?id=31935 8669 8670 * Scripts/modules/commands/download.py: 8671 * Scripts/modules/commands/download_unittest.py: 8672 86732009-11-27 Adam Barth <abarth@webkit.org> 8674 8675 Reviewed by Eric Seidel. 8676 8677 [bzt] Unit test download commands 8678 https://bugs.webkit.org/show_bug.cgi?id=31923 8679 8680 Adds download_unittest and fixes a bug found while testing. 8681 8682 * Scripts/modules/commands/commandtest.py: 8683 * Scripts/modules/commands/download.py: 8684 Fixed a bug where we'd throw an error because [].append returns 8685 None. 8686 * Scripts/modules/commands/download_unittest.py: Added. 8687 * Scripts/modules/mock_bugzillatool.py: 8688 * Scripts/run-webkit-unittests: 8689 86902009-11-27 Adam Barth <abarth@webkit.org> 8691 8692 Unreviewed "build" fix found while writing unit tests. 8693 8694 * Scripts/modules/commands/download.py: 8695 86962009-11-27 Adam Barth <abarth@webkit.org> 8697 8698 Reviewed by Eric Seidel. 8699 8700 [bzt] Kill WebKitLandingScripts 8701 https://bugs.webkit.org/show_bug.cgi?id=31904 8702 8703 Step 6: Kill the rest. 8704 8705 * Scripts/modules/buildsteps.py: 8706 * Scripts/modules/commands/download.py: 8707 * Scripts/modules/commands/queries.py: 8708 * Scripts/modules/commands/upload.py: 8709 * Scripts/modules/landingsequence.py: 8710 * Scripts/modules/scm.py: 8711 * Scripts/modules/webkitlandingscripts.py: Removed. 8712 87132009-11-27 Adam Barth <abarth@webkit.org> 8714 8715 Reviewed by Eric Seidel. 8716 8717 [bzt] Unit test upload commands 8718 https://bugs.webkit.org/show_bug.cgi?id=31903 8719 8720 Adds unit tests for all but two of the upload commands. The two 8721 remaining ones are more difficult. I'll return to them later. The 8722 goal of these tests is just to run the commands. We can test more 8723 detailed behavior later. 8724 8725 * Scripts/modules/commands/commandtest.py: 8726 * Scripts/modules/commands/upload.py: 8727 * Scripts/modules/commands/upload_unittest.py: 8728 * Scripts/modules/mock.py: Added. 8729 * Scripts/modules/mock_bugzillatool.py: 8730 87312009-11-26 Adam Barth <abarth@webkit.org> 8732 8733 Reviewed by Eric Seidel. 8734 8735 [bzt] Kill WebKitLandingScripts 8736 https://bugs.webkit.org/show_bug.cgi?id=31904 8737 8738 Step 5: Kill run_and_throw_if_fail. 8739 8740 * Scripts/modules/buildsteps.py: 8741 * Scripts/modules/processutils.py: Added. 8742 * Scripts/modules/webkitlandingscripts.py: 8743 87442009-11-26 Adam Barth <abarth@webkit.org> 8745 8746 Reviewed by Eric Seidel. 8747 8748 [bzt] Kill WebKitLandingScripts 8749 https://bugs.webkit.org/show_bug.cgi?id=31904 8750 8751 Step 4: Kill run_webkit_script. 8752 8753 * Scripts/modules/buildsteps.py: 8754 * Scripts/modules/commands/download.py: 8755 * Scripts/modules/webkitlandingscripts.py: 8756 87572009-11-26 Adam Barth <abarth@webkit.org> 8758 8759 Reviewed by Eric Seidel. 8760 8761 [bzt] Kill WebKitLandingScripts 8762 https://bugs.webkit.org/show_bug.cgi?id=31904 8763 8764 Step 3: Kill build_webkit. 8765 8766 * Scripts/modules/buildsteps.py: 8767 * Scripts/modules/landingsequence.py: 8768 * Scripts/modules/webkitlandingscripts.py: 8769 87702009-11-26 Adam Barth <abarth@webkit.org> 8771 8772 Reviewed by Eric Seidel. 8773 8774 [bzt] Kill WebKitLandingScripts 8775 https://bugs.webkit.org/show_bug.cgi?id=31904 8776 8777 Step 2: Kill ensure_builders_are_green. 8778 8779 * Scripts/modules/buildsteps.py: 8780 * Scripts/modules/commands/download.py: 8781 * Scripts/modules/landingsequence.py: 8782 * Scripts/modules/webkitlandingscripts.py: 8783 87842009-11-26 Adam Barth <abarth@webkit.org> 8785 8786 Reviewed by Eric Seidel. 8787 8788 [bzt] Kill WebKitLandingScripts 8789 https://bugs.webkit.org/show_bug.cgi?id=31904 8790 8791 Step 1: Kill prepare_clean_working_directory and run_webkit_tests. 8792 8793 * Scripts/bugzilla-tool: 8794 * Scripts/modules/buildsteps.py: Added. 8795 * Scripts/modules/commands/download.py: 8796 * Scripts/modules/landingsequence.py: 8797 * Scripts/modules/webkitlandingscripts.py: 8798 87992009-11-26 Zoltan Horvath <zoltan@webkit.org> 8800 8801 Reviewed by Adam Barth. 8802 8803 Remove directory prefixes from linux commands 8804 8805 SCM unittests can cause errors on some systems if we use absolute reference to 8806 the commands, so directory prefixes have been removed. 8807 8808 * Scripts/modules/scm_unittest.py: 8809 88102009-11-21 Holger Hans Peter Freyther <zecke@selfish.org> 8811 8812 Reviewed by Kenneth Rohde Christiansen. 8813 8814 Link DumpRenderTree to the Qt Ui Tools 8815 https://bugs.webkit.org/show_bug.cgi?id=31203 8816 8817 Implement QWebPage::createPlugin using the Qt Ui Tools 8818 to be able to create classes like QProgressBar from within 8819 the <object></object> tags This is required for the 8820 new automatic test of Qt Plugins. 8821 8822 * DumpRenderTree/qt/DumpRenderTree.cpp: 8823 (WebCore::WebPage::createPlugin): 8824 * DumpRenderTree/qt/DumpRenderTree.h: 8825 * DumpRenderTree/qt/DumpRenderTree.pro: 8826 88272009-11-25 Yuzo Fujishima <yuzo@google.com> 8828 8829 Reviewed by Eric Seidel. 8830 8831 Update pywebsocket to 0.4.2 8832 8833 Update pywebsocket to 0.4.2 8834 https://bugs.webkit.org/show_bug.cgi?id=31861 8835 8836 * pywebsocket/example/echo_client.py: 8837 * pywebsocket/example/echo_wsh.py: 8838 * pywebsocket/mod_pywebsocket/__init__.py: 8839 * pywebsocket/mod_pywebsocket/dispatch.py: 8840 * pywebsocket/mod_pywebsocket/msgutil.py: 8841 * pywebsocket/mod_pywebsocket/standalone.py: 8842 * pywebsocket/setup.py: 8843 * pywebsocket/test/test_dispatch.py: 8844 * pywebsocket/test/test_msgutil.py: 8845 88462009-11-25 Adam Barth <abarth@webkit.org> 8847 8848 Reviewed by Eric Seidel. 8849 8850 Add unit test for mark-fixed 8851 https://bugs.webkit.org/show_bug.cgi?id=31896 8852 8853 * Scripts/modules/commands/commandtest.py: Added. 8854 * Scripts/modules/commands/queries_unittest.py: 8855 * Scripts/modules/commands/upload_unittest.py: Added. 8856 * Scripts/modules/mock_bugzillatool.py: 8857 * Scripts/run-webkit-unittests: 8858 88592009-11-25 Adam Barth <abarth@webkit.org> 8860 8861 Reviewed by Eric Seidel. 8862 8863 bugzilla-tool should have a mark-fixed command 8864 https://bugs.webkit.org/show_bug.cgi?id=31853 8865 8866 Pretty simple stuff. 8867 8868 * Scripts/modules/commands/upload.py: 8869 88702009-11-25 Eric Seidel <eric@webkit.org> 8871 8872 Reviewed by Adam Barth. 8873 8874 'bugzilla-tool help' should only show common commands like how 'git help' does 8875 https://bugs.webkit.org/show_bug.cgi?id=31772 8876 8877 I also took this opportunity to make 'help' a real Command. 8878 Making 'help' a real command required adding Command.tool (which we've wanted to do for a while). 8879 8880 * Scripts/bugzilla-tool: 8881 - change should_show_command_help to should_show_in_main_help 8882 * Scripts/modules/commands/download.py: 8883 - Mark commands as being shown in main help or not. 8884 - show_in_main_help = False is not required (default is false), 8885 but it seemed to make the commands more self-documenting. 8886 * Scripts/modules/commands/queries.py: ditto 8887 * Scripts/modules/commands/queues.py: ditto 8888 * Scripts/modules/commands/upload.py: ditto 8889 * Scripts/modules/multicommandtool.py: 8890 - Make Command hold a pointer to tool in self.tool. Most Command 8891 subclasses do not take advantage of this yet, but it was required 8892 for HelpCommand to be able to reach the tool from _help_epilog(). 8893 - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help 8894 - Move MultiCommandTool._help_epilog to Command._help_epilog 8895 - Move "help" logic into HelpCommand.execute() 8896 - Change should_show_command_help to should_show_in_main_help and add a default implementation. 8897 * Scripts/modules/multicommandtool_unittest.py: 8898 - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands' 8899 89002009-11-25 Brian Weinstein <bweinstein@apple.com> 8901 8902 Reviewed by Dan Bernstein. 8903 8904 Patch by Mark Rowe. 8905 8906 The buildbots are failing on Windows because when they were upgraded 8907 to 4.0.4, Apple Application Support was not in their path. Add it to 8908 the path to fix the buildots. 8909 8910 * Scripts/webkitdirs.pm: 8911 89122009-11-25 Csaba Osztrogonác <ossy@webkit.org> 8913 8914 Reviewed by David Kilzer. 8915 8916 run-webkit-tests doesn't accept directories/files with --skipped=only parameter 8917 https://bugs.webkit.org/show_bug.cgi?id=31799 8918 8919 * Scripts/run-webkit-tests: Fixed. 8920 89212009-11-25 Zoltan Horvath <zoltan@webkit.org> 8922 8923 Reviewed by Eric Seidel. 8924 8925 Change run_command to give back stderr by default 8926 https://bugs.webkit.org/show_bug.cgi?id=31734 8927 8928 Change run_command to give back stderr by default. 8929 Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches. 8930 Change the related unittest call. 8931 8932 * Scripts/modules/scm.py: 8933 * Scripts/modules/scm_unittest.py: 8934 89352009-11-25 Eric Seidel <eric@webkit.org> 8936 8937 Reviewed by Adam Barth. 8938 8939 Centralize required argument parsing in Command 8940 https://bugs.webkit.org/show_bug.cgi?id=31872 8941 8942 * Scripts/modules/commands/download.py: remove custom required arg message. 8943 * Scripts/modules/commands/upload.py: ditto. 8944 * Scripts/modules/multicommandtool.py: 8945 - Add _parse_required_arguments. 8946 - Pass program name off to OptionParser. 8947 - Add name() for access to tool name. 8948 - Add check_arguments_and_execute and make it return a return code. 8949 - Replace a couple uses of + with %. 8950 * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments 8951 89522009-11-25 Eric Seidel <eric@webkit.org> 8953 8954 Reviewed by Adam Barth. 8955 8956 Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests. 8957 https://bugs.webkit.org/show_bug.cgi?id=31870 8958 8959 * Scripts/modules/commands/queries_unittest.py: Use the new class. 8960 * Scripts/modules/multicommandtool_unittest.py: Ditto. 8961 * Scripts/modules/outputcapture.py: Added. 8962 89632009-11-24 Dmitry Titov <dimich@chromium.org> 8964 8965 Reviewed by Eric Seidel. 8966 8967 Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit 8968 https://bugs.webkit.org/show_bug.cgi?id=31444 8969 8970 * Scripts/build-webkit: 8971 89722009-11-24 Chris Marrin <cmarrin@apple.com> 8973 8974 Reviewed by Simon Fraser. 8975 8976 Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded 8977 https://bugs.webkit.org/show_bug.cgi?id=27314 8978 8979 Now the script allows the directories with these tests to be included on all 8980 platforms but Mac, where they behave the same as always. For all other platforms 8981 the tests need to be excluded using the Skipped files, which is currently done 8982 for all platforms (including win since we're not turned on yet) 8983 8984 * Scripts/webkitdirs.pm: 8985 89862009-11-24 Eric Seidel <eric@webkit.org> 8987 8988 Reviewed by Adam Barth. 8989 8990 queries_unittest.py should test command output 8991 https://bugs.webkit.org/show_bug.cgi?id=31845 8992 8993 * Scripts/modules/commands/queries_unittest.py: 8994 - Capture stdout and stderr and compare with expected strings. 8995 89962009-11-24 Simon Fraser <simon.fraser@apple.com> 8997 8998 No Review. 8999 9000 Fix spelling error ("depenedencies"). 9001 9002 * Scripts/build-webkit: 9003 90042009-11-24 Mark Rowe <mrowe@apple.com> 9005 9006 Land the configuration that includes the two debug GTK Linux builders. 9007 9008 * BuildSlaveSupport/build.webkit.org-config/config.json: 9009 90102009-11-24 David Kilzer <ddkilzer@apple.com> 9011 9012 <http://webkit.org/b/31840> bisect-builds broke after r50080 9013 9014 Reviewed by Dan Bernstein. 9015 9016 * Scripts/bisect-builds: 9017 (mountAndRunNightly): Switched back to using backticks to run 9018 the hdiutil command since exec() will terminate the existing 9019 script, which is not what we want. Store the output of 9020 File::Spec->devnull() in a variable for use in the hdiutil 9021 detach commands. 9022 90232009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com> 9024 9025 Reviewed by Kenneth Rohde Christiansen. 9026 9027 Include "config.h" to meet Coding Style Guidelines 9028 https://bugs.webkit.org/show_bug.cgi?id=31792 9029 9030 * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: 9031 * DumpRenderTree/qt/jsobjects.cpp: 9032 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: 9033 90342009-11-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9035 9036 Reviewed by Oliver Hunt. 9037 9038 Implement new required function to pass test we used to pass. This 9039 change is required since r51294. 9040 9041 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 9042 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 9043 90442009-11-23 Jakub Wieczorek <faw217@gmail.com> 9045 9046 Reviewed by Kenneth Rohde Christiansen. 9047 9048 [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs. 9049 https://bugs.webkit.org/show_bug.cgi?id=31775 9050 9051 LayoutTestController::dumpBackForwardList() should work with local URLs 9052 as well as with normal URLs (in http tests for instance). 9053 Currently it does not output the latter properly. 9054 9055 Unskip a bunch of passing http/navigation tests. 9056 9057 * DumpRenderTree/qt/DumpRenderTree.cpp: 9058 (WebCore::dumpHistoryItem): 9059 90602009-11-22 Chris Fleizach <cfleizach@apple.com> 9061 9062 Reviewed by Oliver Hunt. 9063 9064 ARIA: support aria-flowto 9065 https://bugs.webkit.org/show_bug.cgi?id=31762 9066 9067 * DumpRenderTree/AccessibilityUIElement.cpp: 9068 (ariaFlowToElementAtIndexCallback): 9069 (AccessibilityUIElement::getJSClass): 9070 * DumpRenderTree/AccessibilityUIElement.h: 9071 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 9072 (AccessibilityUIElement::ariaFlowToElementAtIndex): 9073 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 9074 (AccessibilityUIElement::ariaFlowToElementAtIndex): 9075 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 9076 (AccessibilityUIElement::ariaFlowToElementAtIndex): 9077 90782009-11-22 Antonio Gomes <tonikitoo@webkit.org> 9079 9080 Reviewed by Kenneth Christiansen. 9081 9082 [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen 9083 https://bugs.webkit.org/show_bug.cgi?id=31638 9084 9085 Unfreeze WorkQueue after each test execution. 9086 9087 * DumpRenderTree/qt/DumpRenderTree.cpp: 9088 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 9089 90902009-11-22 Jakub Wieczorek <faw217@gmail.com> 9091 9092 Reviewed by Adam Barth. 9093 9094 [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors 9095 for localhost and 127.0.0.1. 9096 https://bugs.webkit.org/show_bug.cgi?id=31783 9097 9098 Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now. 9099 9100 * DumpRenderTree/qt/DumpRenderTree.cpp: 9101 (WebCore::NetworkAccessManager::NetworkAccessManager): 9102 (WebCore::NetworkAccessManager::sslErrorsEncountered): 9103 (WebCore::WebPage::WebPage): 9104 * DumpRenderTree/qt/DumpRenderTree.h: 9105 91062009-11-22 Chris Evans <cevans@chromium.org> 9107 9108 Reviewed by Adam Barth. 9109 9110 Disable access to file:/// directory listings 9111 https://bugs.webkit.org/show_bug.cgi?id=31329 9112 9113 Implemented setAllowUniversalAccessFromFileURLs to support testing of 9114 file URL security. 9115 9116 * DumpRenderTree/LayoutTestController.cpp: 9117 (setAllowUniversalAccessFromFileURLsCallback): 9118 (LayoutTestController::staticFunctions): 9119 * DumpRenderTree/LayoutTestController.h: 9120 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 9121 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 9122 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 9123 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 9124 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 9125 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 9126 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 9127 (LayoutTestController::setAllowUniversalAccessFromFileURLs): 9128 91292009-11-22 Jakub Wieczorek <faw217@gmail.com> 9130 9131 Reviewed by Kenneth Rohde Christiansen. 9132 9133 [Qt] Fix the timeout of fast/frames/frame-navigation.html 9134 https://bugs.webkit.org/show_bug.cgi?id=31638 9135 9136 The test is timeouting, because it uses the WorkQueue to load a document in one 9137 of the child frames and once the loading is finished, the DRT does not dump the 9138 tree. This is because it waits for the QWebFrame::loadFinished() signal from 9139 the main frame, while it should connect to QWebPage::loadFinished(). 9140 9141 * DumpRenderTree/qt/DumpRenderTree.cpp: 9142 (WebCore::DumpRenderTree::DumpRenderTree): 9143 91442009-11-21 Eric Seidel <eric@webkit.org> 9145 9146 Reviewed by Adam Barth. 9147 9148 bugzilla-tool --help spews way too much text 9149 https://bugs.webkit.org/show_bug.cgi?id=31771 9150 9151 * Scripts/bugzilla-tool: 9152 - Remove self.cached_scm initialization hack. 9153 * Scripts/modules/buildbot.py: 9154 - Make default_host accessible to callers. 9155 * Scripts/modules/commands/download.py: 9156 - Phrase help for all commands consistently and remove spurious help text punctuation. 9157 * Scripts/modules/commands/queries.py: Ditto. 9158 * Scripts/modules/commands/queues.py: Ditto. 9159 * Scripts/modules/commands/upload.py: Ditto. 9160 * Scripts/modules/multicommandtool.py: 9161 - Add HelpPrintingOptionParser.format_epilog to replace 9162 NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize 9163 per-command help (thus removing the need for the cached_scm hack in BugzillaTool). 9164 - Make --help only show a list of commands like "svn help" and "git help" do -- 9165 previously --help was listing all commands and options. 9166 - Sort list of commands alphabetically. 9167 91682009-11-21 Eric Seidel <eric@webkit.org> 9169 9170 No review. Fixing a typo from the previous patch for bug 31767. 9171 9172 AbstractQueue.run_bugzilla_tool throws an exception 9173 https://bugs.webkit.org/show_bug.cgi?id=31769 9174 9175 * Scripts/modules/commands/queues.py: 9176 91772009-11-21 Eric Seidel <eric@webkit.org> 9178 9179 Reviewed by Adam Barth. 9180 9181 commit-queue fails to run with "permissions error" due to bad bugzilla-tool path 9182 https://bugs.webkit.org/show_bug.cgi?id=31767 9183 9184 What we really want to test is BugzillaTool.path() instead of TrivialTool.path(). 9185 Since we don't have a good way to test BugzillaTool pieces, I've 9186 left out a test for now. 9187 9188 * Scripts/bugzilla-tool: 9189 - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue. 9190 * Scripts/modules/commands/queues.py: 9191 - Use tool.path() instead of __file__. 9192 * Scripts/modules/multicommandtool.py: 9193 - Add a new path() method to MultiComandTool. 9194 * Scripts/modules/multicommandtool_unittest.py: 9195 - Provide a path() method. Little point in testing this mock implementation. 9196 91972009-11-21 Adam Barth <abarth@webkit.org> 9198 9199 Unreviewed "build" fix. Turns out I was testing the wrong copy of 9200 WebKitTools. 9201 9202 * Scripts/modules/commands/download.py: 9203 92042009-11-21 Adam Barth <abarth@webkit.org> 9205 9206 Reviewed by Eric Seidel. 9207 9208 Convert check-style to use LandingSequence 9209 https://bugs.webkit.org/show_bug.cgi?id=31763 9210 9211 Instead of manipulating the working copy by hand, we should use the 9212 LandingSequence in CheckStyle. This will make this code eaiser to 9213 test. 9214 9215 * Scripts/modules/commands/download.py: 9216 92172009-11-20 Adam Barth <abarth@webkit.org> 9218 9219 Reviewed by Eric Seidel. 9220 9221 Unit test query commands 9222 https://bugs.webkit.org/show_bug.cgi?id=31755 9223 9224 These tests are pretty rough, but hopefully they'll grow. 9225 9226 * Scripts/modules/commands/queries_unittest.py: Added. 9227 * Scripts/modules/mock_bugzillatool.py: Added. 9228 * Scripts/run-webkit-unittests: 9229 92302009-11-20 Eric Seidel <eric@webkit.org> 9231 9232 Reviewed by Adam Barth. 9233 9234 Fix a bunch of unit test regressions from our recent bugzilla-toll hacking 9235 https://bugs.webkit.org/show_bug.cgi?id=31758 9236 9237 * Scripts/modules/multicommandtool.py: 9238 - Allow passing of explicit commands to MultiCommandTool.__init__ 9239 * Scripts/modules/multicommandtool_unittest.py: 9240 - Use new Command.name naming system. 9241 - Test Command auto-discovery. 9242 * Scripts/modules/workqueue.py: 9243 - bug_id no longer exists, use patch['bug_id'] instead. 9244 * Scripts/modules/workqueue_unittest.py: 9245 - WorkQueues require names now. 9246 - should_proceed_with_work_item must return a patch object. 9247 92482009-11-20 Chris Fleizach <cfleizach@apple.com> 9249 9250 Reviewed by Beth Dakin. 9251 9252 WAI-ARIA: add support for aria-owns 9253 https://bugs.webkit.org/show_bug.cgi?id=31702 9254 9255 * DumpRenderTree/AccessibilityUIElement.cpp: 9256 (ariaOwnsElementAtIndexCallback): 9257 (AccessibilityUIElement::getJSClass): 9258 * DumpRenderTree/AccessibilityUIElement.h: 9259 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 9260 (AccessibilityUIElement::ariaOwnsElementAtIndex): 9261 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 9262 (AccessibilityUIElement::ariaOwnsElementAtIndex): 9263 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 9264 (AccessibilityUIElement::ariaOwnsElementAtIndex): 9265 92662009-11-20 Eric Seidel <eric@webkit.org> 9267 9268 Reviewed by Adam Barth. 9269 9270 Fix exception thrown when running the commit-queue. 9271 9272 * Scripts/modules/statusbot.py: patch is optional. 9273 * Scripts/modules/workqueue.py: WorkQUeue requires a name. 9274 92752009-11-20 Eric Seidel <eric@webkit.org> 9276 9277 Reviewed by Adam Barth. 9278 9279 Teach the StatusBot how to support more than just the commit-queue 9280 https://bugs.webkit.org/show_bug.cgi?id=31754 9281 9282 * Scripts/modules/workqueue.py: Another typo. 9283 92842009-11-20 Eric Seidel <eric@webkit.org> 9285 9286 Reviewed by Adam Barth. 9287 9288 Teach the StatusBot how to support more than just the commit-queue 9289 https://bugs.webkit.org/show_bug.cgi?id=31754 9290 9291 * Scripts/modules/commands/queues.py: Fix silly typo. 9292 92932009-11-20 Eric Seidel <eric@webkit.org> 9294 9295 Reviewed by Adam Barth. 9296 9297 Teach the StatusBot how to support more than just the commit-queue 9298 https://bugs.webkit.org/show_bug.cgi?id=31754 9299 9300 * CommitQueueStatus/index.yaml: 9301 - Add indices required for the new queries. 9302 * CommitQueueStatus/queue_status.py: 9303 - Add a patch-status page and move update_status to update-status. 9304 - Only display "commit-queue" status records for the commit-queue. 9305 - Add support for a queue_name property on status records. 9306 - Fix _int_from_request to actually work. 9307 * CommitQueueStatus/update_status.html: 9308 - Add support for a queue_name on status records. 9309 - Remove unused list of bug ids. 9310 * Scripts/modules/commands/queues.py 9311 - Make the queues pass the patch instead of the bug_id to StatusBot. 9312 * Scripts/modules/statusbot.py: 9313 - Support passing the queue_name to the status updates. 9314 - Support fetching patch status with patch_status(). 9315 * Scripts/modules/workqueue.py: 9316 - Pass the patch to the StatusBot instead of the bug_id. 9317 - Let WorkQueues have a name. 9318 93192009-11-20 Adam Barth <abarth@webkit.org> 9320 9321 Reviewed by Eric Seidel. 9322 9323 Move bugzilla-tool commands into their own file 9324 https://bugs.webkit.org/show_bug.cgi?id=31752 9325 9326 This will let us write unit tests. 9327 9328 * Scripts/bugzilla-tool: 9329 * Scripts/modules/commands/__init__.py: Added. 9330 * Scripts/modules/commands/download.py: Added. 9331 * Scripts/modules/commands/queries.py: Added. 9332 * Scripts/modules/commands/queues.py: Added. 9333 * Scripts/modules/commands/upload.py: Added. 9334 * Scripts/modules/grammar.py: Added. 9335 93362009-11-20 Adam Barth <abarth@webkit.org> 9337 9338 Reviewed by Eric Seidel. 9339 9340 BuildQueue should check if the tree is currently buildable 9341 https://bugs.webkit.org/show_bug.cgi?id=31744 9342 9343 * Scripts/bugzilla-tool: 9344 * Scripts/modules/landingsequence.py: 9345 * Scripts/modules/webkitlandingscripts.py: 9346 93472009-11-20 Adam Barth <abarth@webkit.org> 9348 9349 Reviewed by Eric Seidel. 9350 9351 Move prepare_clean_working_directory into the LandingSequence 9352 https://bugs.webkit.org/show_bug.cgi?id=31743 9353 9354 * Scripts/bugzilla-tool: 9355 * Scripts/modules/landingsequence.py: 9356 93572009-11-20 Yael Aharon <yael.aharon@nokia.com> 9358 9359 Reviewed by Kenneth Rohde Christiansen. 9360 9361 NPN_ReloadPlugins does not reload the page even if reloadPages is true. 9362 https://bugs.webkit.org/show_bug.cgi?id=30460 9363 9364 Added code for calling NPN_ReloadPlugins with reloadPages true and false. 9365 9366 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 9367 (pluginInvoke): 9368 93692009-11-20 Adam Barth <abarth@webkit.org> 9370 9371 Reviewed by Eric Seidel. 9372 9373 Pass the port information to the child process 9374 https://bugs.webkit.org/show_bug.cgi?id=31736 9375 9376 We need to do this so the child process knows what to build! 9377 9378 * Scripts/bugzilla-tool: 9379 * Scripts/modules/landingsequence.py: 9380 * Scripts/modules/webkitport.py: 9381 * Scripts/modules/webkitport_unittest.py: 9382 93832009-11-20 Adam Barth <abarth@webkit.org> 9384 9385 Reviewed by Eric Seidel. 9386 9387 Support Qt port in build-queue 9388 https://bugs.webkit.org/show_bug.cgi?id=31733 9389 9390 * Scripts/bugzilla-tool: 9391 93922009-11-20 Adam Barth <abarth@webkit.org> 9393 9394 Reviewed by Eric Seidel. 9395 9396 Implement a build-queue 9397 https://bugs.webkit.org/show_bug.cgi?id=31725 9398 9399 Currently this just builds the first 10 patches in the review queue. 9400 We'll want to do something smarter soon. 9401 9402 * Scripts/bugzilla-tool: 9403 94042009-11-20 Adam Barth <abarth@webkit.org> 9405 9406 Reviewed by Eric Seidel. 9407 9408 Make commit-queue and style-queue show up in help 9409 https://bugs.webkit.org/show_bug.cgi?id=31724 9410 9411 We need to store their names on their class to make these commands 9412 properly register themselves with MultiCommandTool. 9413 9414 * Scripts/bugzilla-tool: 9415 94162009-11-20 Adam Barth <abarth@webkit.org> 9417 9418 Reviewed by Eric Seidel. 9419 9420 Implement bugzilla-tool build-attachment 9421 https://bugs.webkit.org/show_bug.cgi?id=31722 9422 9423 This command builds an attachment from bugzilla. It leaves the built 9424 patch in the working copy. 9425 9426 * Scripts/bugzilla-tool: 9427 * Scripts/modules/landingsequence.py: 9428 * Scripts/modules/webkitlandingscripts.py: 9429 94302009-11-20 Alejandro G. Castro <alex@igalia.com> 9431 9432 Reviewed by Xan Lopez. 9433 9434 [GTK] DRT release event does not create the state correctly 9435 https://bugs.webkit.org/show_bug.cgi?id=31717 9436 9437 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 9438 94392009-11-20 Eric Seidel <eric@webkit.org> 9440 9441 Reviewed by Adam Barth. 9442 9443 MultiCommandTool should find Command objects automatically instead of with a manual list 9444 https://bugs.webkit.org/show_bug.cgi?id=31710 9445 9446 * Scripts/bugzilla-tool: 9447 * Scripts/modules/multicommandtool.py: 9448 - Use some wild python-fu to crawl all the known subclasses of Command. 9449 94502009-11-20 Adam Barth <abarth@webkit.org> 9451 9452 Unreviewed "build" fix. Added missing import. 9453 9454 * Scripts/bugzilla-tool: 9455 94562009-11-20 Adam Barth <abarth@webkit.org> 9457 9458 Unreviewed "build" fix. I failed to update LandingSequence.test 9459 properly. 9460 9461 * Scripts/modules/landingsequence.py: 9462 94632009-11-20 Adam Barth <abarth@webkit.org> 9464 9465 Reviewed by Eric Seidel. 9466 9467 Create LandingSequence as the all-sing, all-dance landing class 9468 https://bugs.webkit.org/show_bug.cgi?id=31709 9469 9470 Client can inherit from this class to carefully control exactly which 9471 steps they wish to have happen in the landing sequence. 9472 9473 * Scripts/bugzilla-tool: 9474 * Scripts/modules/landingsequence.py: Added. 9475 * Scripts/modules/webkitlandingscripts.py: Added. 9476 94772009-11-19 Adam Barth <abarth@webkit.org> 9478 9479 Reviewed by Eric Seidel. 9480 9481 Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand 9482 https://bugs.webkit.org/show_bug.cgi?id=31707 9483 9484 This is to help when we implement build-attachment. 9485 9486 * Scripts/bugzilla-tool: 9487 94882009-11-19 Adam Barth <abarth@webkit.org> 9489 9490 Reviewed by Eric Seidel. 9491 9492 Support Qt port in bugzilla-tool 9493 https://bugs.webkit.org/show_bug.cgi?id=31701 9494 9495 Now we support building with Qt! 9496 9497 * Scripts/bugzilla-tool: 9498 * Scripts/modules/webkitport.py: Added. 9499 * Scripts/modules/webkitport_unittest.py: Added. 9500 * Scripts/run-webkit-unittests: 9501 95022009-11-19 Zoltan Horvath <zoltan@webkit.org> 9503 9504 Reviewed by Adam Barth. 9505 9506 Remove inserting stderr into patch in bugzilla-tool 9507 https://bugs.webkit.org/show_bug.cgi?id=29914 9508 9509 Modify SCM python module's run_command function to avoid return of stderr 9510 by default, so stderr won't be inserted into the patches. 9511 Modify the related unit test. 9512 9513 * Scripts/modules/scm.py: 9514 * Scripts/modules/scm_unittest.py: 9515 95162009-11-19 Eric Seidel <eric@webkit.org> 9517 9518 Reviewed by Adam Barth. 9519 9520 bugzilla-tool needs per-command help 9521 https://bugs.webkit.org/show_bug.cgi?id=31697 9522 9523 Added support for "bugzilla-tool help command-name" 9524 and a unit test to make sure it works. 9525 9526 * Scripts/modules/multicommandtool.py: 9527 * Scripts/modules/multicommandtool_unittest.py: 9528 95292009-11-19 Eric Seidel <eric@webkit.org> 9530 9531 Reviewed by Adam Barth. 9532 9533 Move MultiCommandTool and Command into a separate file and add some basic unit tests 9534 https://bugs.webkit.org/show_bug.cgi?id=31695 9535 9536 * Scripts/bugzilla-tool: 9537 * Scripts/modules/multicommandtool.py: Added. 9538 * Scripts/modules/multicommandtool_unittest.py: Added. 9539 * Scripts/run-webkit-unittests: 9540 95412009-11-19 Eric Seidel <eric@webkit.org> 9542 9543 No review, just adding a FIXME. 9544 9545 Split out command parsing and help printing from BugzillaTool 9546 https://bugs.webkit.org/show_bug.cgi?id=31688 9547 9548 * Scripts/bugzilla-tool: Add an extra comment about current design failures. 9549 95502009-11-19 Eric Seidel <eric@webkit.org> 9551 9552 Reviewed by Adam Barth. 9553 9554 Split out command parsing and help printing from BugzillaTool 9555 https://bugs.webkit.org/show_bug.cgi?id=31688 9556 9557 * Scripts/bugzilla-tool: 9558 - Add new MultiCommandTool class to contain option parsing and help printing logic. 9559 - Rename private methods to use _ pattern. 9560 - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command. 9561 - 9562 95632009-11-19 Eric Seidel <eric@webkit.org> 9564 9565 Reviewed by Adam Barth. 9566 9567 Re-factor help printing to use modern python idioms 9568 https://bugs.webkit.org/show_bug.cgi?id=31685 9569 9570 * Scripts/bugzilla-tool: 9571 95722009-11-19 Eric Seidel <eric@webkit.org> 9573 9574 Reviewed by Darin Adler. 9575 9576 commit-queue empty queue logs twice 9577 https://bugs.webkit.org/show_bug.cgi?id=31679 9578 9579 * Scripts/bugzilla-tool: 9580 95812009-11-19 Eric Seidel <eric@webkit.org> 9582 9583 Reviewed by Darin Adler. 9584 9585 bugzilla-tool's reviewer/committer rejection message should be clearer 9586 https://bugs.webkit.org/show_bug.cgi?id=31126 9587 9588 Add more explanatory prose to bugzilla-tool's flag permission rejection message. 9589 9590 * Scripts/modules/bugzilla.py: 9591 95922009-11-19 Eric Z. Ayers <zundel@google.com> 9593 9594 Reviewed by Pavel Feldman. 9595 9596 Forces a WM_PAINT event on calling layoutTestController.display() 9597 in order to enable the timeline-paint.html test on Windows. 9598 ::UpdateWindow() does not force an event becaue the window is 9599 not visible. 9600 9601 https://bugs.webkit.org/show_bug.cgi?id=31402 9602 9603 * DumpRenderTree/win/DumpRenderTree.cpp: 9604 (displayWebView): 9605 96062009-11-19 Michelangelo De Simone <michelangelo@webkit.org> 9607 9608 No review needed. 9609 9610 Added myself to committers list. 9611 9612 * Scripts/modules/committers.py: 9613 96142009-11-19 Adam Barth <abarth@webkit.org> 9615 9616 Reviewed by Eric Seidel. 9617 9618 Bugzilla-tool command classes should match command names 9619 https://bugs.webkit.org/show_bug.cgi?id=31666 9620 9621 I renamed all the commands except CommitMessageForCurrentDiff because 9622 the new name would conflict with an existing class. 9623 9624 * Scripts/bugzilla-tool: 9625 96262009-11-19 Pavel Feldman <pfeldman@chromium.org> 9627 9628 Reviewed by Gustavo Noronha Silva. 9629 9630 Web Inspector: Implement "show inspector" in WebKit GTK 9631 API and enable console tests. 9632 9633 https://bugs.webkit.org/show_bug.cgi?id=31669 9634 9635 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 9636 (LayoutTestController::showWebInspector): 9637 96382009-11-19 Kenneth Rohde Christiansen <kenneth@webkit.org> 9639 9640 Reviewed by Simon Hausmann. 9641 9642 Minor refactoring + more documentation. 9643 9644 * DumpRenderTree/qt/DumpRenderTree.cpp: 9645 (WebCore::clearHistory): 9646 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 9647 96482009-11-19 Fumitoshi Ukai <ukai@chromium.org> 9649 9650 Reviewed by Eric Seidel. 9651 9652 Ignore websocket tests when --no-http is specified. 9653 https://bugs.webkit.org/show_bug.cgi?id=31662 9654 9655 * Scripts/run-webkit-tests: 9656 96572009-11-18 Adam Barth <abarth@webkit.org> 9658 9659 Reviewed by Eric Seidel. 9660 9661 Normalize ' and " in bugzilla-tool 9662 https://bugs.webkit.org/show_bug.cgi?id=31655 9663 9664 We decided " is better than ' and we should be consistent. 9665 9666 * Scripts/bugzilla-tool: 9667 96682009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com> 9669 9670 Reviewed by Kenneth Rohde Christiansen. 9671 9672 [Qt] Remove support for Qt v4.3 or older versions 9673 https://bugs.webkit.org/show_bug.cgi?id=29469 9674 9675 * DumpRenderTree/qt/DumpRenderTree.pro: 9676 * DumpRenderTree/qt/ImageDiff.pro: 9677 96782009-11-18 Shinichiro Hamaji <hamaji@chromium.org> 9679 9680 Reviewed by Eric Seidel. 9681 9682 GitTest.test_create_binary_patch fails if /tmp is symlink 9683 https://bugs.webkit.org/show_bug.cgi?id=31536 9684 9685 * Scripts/modules/scm_unittest.py: 9686 96872009-11-18 Yaar Schnitman <yaar@chromium.org> 9688 9689 Reviewed by Darin Adler. 9690 9691 Configuration for Chromium Build Slaves. 9692 9693 https://bugs.webkit.org/show_bug.cgi?id=31442 9694 9695 * BuildSlaveSupport/build.webkit.org-config/config.json: 9696 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 9697 96982009-11-18 Eric Seidel <eric@webkit.org> 9699 9700 Reviewed by Darin Adler. 9701 9702 workqueue.py results in totally broken commit-queue UI 9703 https://bugs.webkit.org/show_bug.cgi?id=31645 9704 9705 * Scripts/bugzilla-tool: 9706 - Remove unneeded use of PatchCollection. 9707 - Grab a new copy of the cq'd patches every run of the queue. 9708 97092009-11-18 Sam Weinig <sam@webkit.org> 9710 9711 Reviewed by Anders Carlsson. 9712 9713 Make the Mac Geolocation API async. 9714 9715 Update DRT to use the new async Mac Geolocation API. 9716 9717 * DumpRenderTree/mac/UIDelegate.mm: 9718 (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]): 9719 97202009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com> 9721 9722 Reviewed by Kenneth Rohde Christiansen. 9723 9724 Add and option to toggle HTML5 datalist support to build-webkit 9725 https://bugs.webkit.org/show_bug.cgi?id=31599 9726 9727 * Scripts/build-webkit: 9728 97292009-11-18 Kevin Watters <kevinwatters@gmail.com> 9730 9731 Reviewed by Kevin Ollivier. 9732 9733 Enable wx plugin support using the Windows implementation as a base. 9734 9735 https://bugs.webkit.org/show_bug.cgi?id=31636 9736 9737 * wx/build/settings.py: 9738 97392009-11-18 Kenneth Rohde Christiansen <kenneth@webkit.org> 9740 9741 Reviewed by Simon Hausmann. 9742 9743 Change the initialization order so that the controllers 9744 will be created before exporting them to the JS DOM window. 9745 9746 * DumpRenderTree/qt/DumpRenderTree.cpp: 9747 (WebCore::DumpRenderTree::DumpRenderTree): 9748 97492009-11-18 Kenneth Rohde Christiansen <kenneth@webkit.org> 9750 9751 Reviewed by Simon Hausmann. 9752 9753 Fix a code copy and paste error. m_page should be page. 9754 9755 * DumpRenderTree/qt/DumpRenderTree.cpp: 9756 (WebCore::DumpRenderTree::createWindow): 9757 97582009-11-17 Mark Rowe <mrowe@apple.com> 9759 9760 Reviewed by Alexey Proskuryakov. 9761 9762 <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X 9763 9764 * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file. 9765 This prevents symlinks from confusing the descendant check. 9766 97672009-11-17 Mark Rowe <mrowe@apple.com> 9768 9769 Reviewed by Alexey Proskuryakov. 9770 9771 <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run 9772 9773 If the WebSocket server fails to start have DRT load an error page in place of tests that require the 9774 server to be up rather than having run-webkit-tests abort immediately. 9775 9776 * Scripts/run-webkit-tests: 9777 97782009-11-17 Eric Seidel <eric@webkit.org> 9779 9780 Reviewed by Darin Adler. 9781 9782 commit-queue is failing to set reviewer in ChangeLogs 9783 https://bugs.webkit.org/show_bug.cgi?id=31592 9784 9785 * Scripts/bugzilla-tool: Clarify the "applying" log message. 9786 * Scripts/modules/bugzilla.py: 9787 - Add a new _validate_committer_and_reviewer function as a 9788 temporary solution until we can make a real Attachment object 9789 which knows how to fill in its committer/reviewer fields automatically. 9790 97912009-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org> 9792 9793 Unreviewed buildbot fix. 9794 9795 Revert part of earlier patch and add comment, as it 9796 was causing timeouts on the buildbot. 9797 9798 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9799 (LayoutTestController::notifyDone): 9800 98012009-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org> 9802 9803 Reviewed by Oliver Hunt. 9804 9805 Make the timeout 15 sec as for the other DRT's and make 9806 it print out the same output when a test timeout. 9807 9808 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9809 (LayoutTestController::waitUntilDone): 9810 (LayoutTestController::notifyDone): 9811 (LayoutTestController::timerEvent): 9812 98132009-11-17 Joseph Pecoraro <joepeck@webkit.org> 9814 9815 Reviewed by Timothy Hatcher. 9816 9817 Fixed typos in comments. 9818 9819 * Scripts/modules/committers.py: 9820 98212009-11-17 Pavel Feldman <pfeldman@chromium.org> 9822 9823 Reviewed by Timothy Hatcher. 9824 9825 Web Inspector: Make DRT show web inspector for tests in inspector/ folder. 9826 - Updated DRT to show/close inspector for all tests under /inspector 9827 - Introduced LayoutTestController::setTimelineProfilingEnabled and 9828 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled 9829 - Removed reload on each inspector test 9830 - Renamed fast/inspector to fast/inspector-support in order not to trigger 9831 inspector for those. 9832 - Reimplemented timeline tests in order to get rid of reload there. 9833 - Moved tests that don't require harness into the fast group. 9834 9835 https://bugs.webkit.org/show_bug.cgi?id=31472 9836 9837 * DumpRenderTree/LayoutTestController.cpp: 9838 (setTimelineProfilingEnabledCallback): 9839 (closeWebInspectorCallback): 9840 (LayoutTestController::staticFunctions): 9841 * DumpRenderTree/LayoutTestController.h: 9842 * DumpRenderTree/gtk/DumpRenderTree.cpp: 9843 (shouldOpenWebInspector): 9844 (runTest): 9845 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 9846 (LayoutTestController::setTimelineProfilingEnabled): 9847 * DumpRenderTree/mac/DumpRenderTree.mm: 9848 (shouldOpenWebInspector): 9849 (runTest): 9850 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 9851 (LayoutTestController::setTimelineProfilingEnabled): 9852 * DumpRenderTree/win/DumpRenderTree.cpp: 9853 (shouldOpenWebInspector): 9854 (runTest): 9855 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 9856 (LayoutTestController::setTimelineProfilingEnabled): 9857 98582009-11-17 Oliver Hunt <oliver@apple.com> 9859 9860 Reviewed by Maciej Stachowiak. 9861 9862 Incorrect use of JavaScriptCore API in DumpRenderTree 9863 https://bugs.webkit.org/show_bug.cgi?id=31577 9864 9865 Return undefined rather than a literal null. 9866 9867 * DumpRenderTree/AccessibilityUIElement.cpp: 9868 (setSelectedTextRangeCallback): 9869 (incrementCallback): 9870 (decrementCallback): 9871 (showMenuCallback): 9872 98732009-11-16 Chris Fleizach <cfleizach@apple.com> 9874 9875 Reviewed by Beth Dakin. 9876 9877 AX: aria-labelledby duplicates some of its WAI-ARIA label 9878 https://bugs.webkit.org/show_bug.cgi?id=31565 9879 9880 * DumpRenderTree/AccessibilityUIElement.cpp: 9881 (titleUIElementCallback): 9882 (getIsValidCallback): 9883 (AccessibilityUIElement::getJSClass): 9884 98852009-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org> 9886 9887 Reviewed by Simon Hausmann. 9888 9889 r50942 broke output from created windows. Make the 9890 m_enableTextOutput a member of the DRT and not the 9891 WebPage. 9892 9893 * DumpRenderTree/qt/DumpRenderTree.cpp: 9894 (WebCore::WebPage::WebPage): 9895 (WebCore::WebPage::javaScriptAlert): 9896 (WebCore::WebPage::javaScriptConsoleMessage): 9897 (WebCore::WebPage::javaScriptConfirm): 9898 (WebCore::WebPage::javaScriptPrompt): 9899 (WebCore::WebPage::acceptNavigationRequest): 9900 (WebCore::DumpRenderTree::DumpRenderTree): 9901 (WebCore::DumpRenderTree::open): 9902 (WebCore::DumpRenderTree::createWindow): 9903 * DumpRenderTree/qt/DumpRenderTree.h: 9904 (WebCore::DumpRenderTree::setTextOutputEnabled): 9905 (WebCore::DumpRenderTree::isTextOutputEnabled): 9906 (WebCore::WebPage::shouldInterruptJavaScript): 9907 (WebCore::WebPage::isTextOutputEnabled): 9908 (WebCore::WebPage::setViewGeometry): 9909 99102009-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org> 9911 9912 Reviewed by Gustavo Noronha Silva. 9913 9914 Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin 9915 as the implementation is being used by at least Qt and Gtk+. 9916 9917 Update buildsystems as well. 9918 9919 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 9920 * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: 9921 * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: 9922 * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: 9923 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: 9924 * GNUmakefile.am: 9925 99262009-11-16 Yuzo Fujishima <yuzo@google.com> 9927 9928 Reviewed by Alexey Proskuryakov. 9929 9930 Disable wss until all platforms support pyOpenSSL 9931 9932 https://bugs.webkit.org/show_bug.cgi?id=31479 9933 9934 * Scripts/run-webkit-tests: 9935 99362009-11-14 Antonio Gomes <tonikitoo@webkit.org> 9937 9938 Reviewed by Kenneth Christiansen. 9939 9940 [Qt] Implement load error pages support for Qt's DRT. 9941 https://bugs.webkit.org/show_bug.cgi?id=31509 9942 9943 For now, it will not be a default feature, and layout tests 9944 that want to make use of this have to explicitily call 9945 'handleErrorPages();' for the test source. 9946 9947 Any of the other DumpRenderTree's (mac, win and gtk) 9948 support handling error pages. Qt's will be the first. 9949 9950 * DumpRenderTree/qt/DumpRenderTree.cpp: 9951 (WebCore::WebPage::supportsExtension): 9952 (WebCore::WebPage::extension): 9953 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 9954 (LayoutTestController::reset): 9955 * DumpRenderTree/qt/LayoutTestControllerQt.h: 9956 (LayoutTestController::shouldHandleErrorPages): 9957 (LayoutTestController::handleErrorPages): 9958 99592009-11-16 Eric Seidel <eric@webkit.org> 9960 9961 Reviewed by Adam Barth. 9962 9963 Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment 9964 https://bugs.webkit.org/show_bug.cgi?id=31549 9965 9966 Renamed --commit-queue to --non-interactive in most places 9967 and remove the code in land-patches which is no longer needed. 9968 9969 * Scripts/bugzilla-tool: 9970 99712009-11-16 Eric Seidel <eric@webkit.org> 9972 9973 Reviewed by Adam Barth. 9974 9975 The commit-queue should use land-attachment 9976 https://bugs.webkit.org/show_bug.cgi?id=31548 9977 9978 * Scripts/bugzilla-tool: 9979 99802009-11-16 Adam Barth <abarth@webkit.org> 9981 9982 Reviewed by Eric Seidel. 9983 9984 Convert CommitQueue over to PatchCollection 9985 https://bugs.webkit.org/show_bug.cgi?id=31547 9986 9987 Also fixes a bug in workqueue and adds a test! 9988 9989 * Scripts/bugzilla-tool: 9990 * Scripts/modules/workqueue.py: 9991 * Scripts/modules/workqueue_unittest.py: 9992 99932009-11-16 Adam Barth <abarth@webkit.org> 9994 9995 Reviewed by Eric Seidel. 9996 9997 Move StyleQueue over to using PatchCollection 9998 https://bugs.webkit.org/show_bug.cgi?id=31544 9999 10000 That's what the class it's for. 10001 10002 * Scripts/bugzilla-tool: 10003 * Scripts/modules/patchcollection.py: 10004 * Scripts/modules/patchcollection_unittest.py: 10005 100062009-11-16 Eric Seidel <eric@webkit.org> 10007 10008 Reviewed by Adam Barth. 10009 10010 bugzilla-tool needs a land-attachment command 10011 https://bugs.webkit.org/show_bug.cgi?id=31546 10012 10013 * Scripts/bugzilla-tool: 10014 - Move all the logic into AbstractLandingCommand and 10015 add a new LandAttachment command subclass. 10016 - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land. 10017 100182009-11-16 Eric Seidel <eric@webkit.org> 10019 10020 Reviewed by Adam Barth. 10021 10022 Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment 10023 https://bugs.webkit.org/show_bug.cgi?id=31543 10024 10025 Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'. 10026 10027 * Scripts/bugzilla-tool: 10028 100292009-11-16 Eric Seidel <eric@webkit.org> 10030 10031 Reviewed by Adam Barth. 10032 10033 Disable the style queue from posting to the commit queue status page. 10034 10035 * Scripts/bugzilla-tool: 10036 100372009-11-16 Adam Barth <abarth@webkit.org> 10038 10039 Reviewed by Eric Seidel. 10040 10041 Implement PatchCollection 10042 https://bugs.webkit.org/show_bug.cgi?id=31541 10043 10044 This class holds a set of patches and lets clients iterate through 10045 them. Optionally, clients can install a filter. 10046 10047 * Scripts/modules/patchcollection.py: Added. 10048 * Scripts/modules/patchcollection_unittest.py: Added. 10049 * Scripts/run-webkit-unittests: 10050 100512009-11-16 Eric Seidel <eric@webkit.org> 10052 10053 Reviewed by Adam Barth. 10054 10055 bugzilla-tool land-patches will close bugs with patches r=? 10056 https://bugs.webkit.org/show_bug.cgi?id=28230 10057 10058 The commit-queue shouldn't close patches with outstanding reviews on them, 10059 even if many reviewers seem to be against multi-patch bugs. 10060 10061 * Scripts/bugzilla-tool: 10062 100632009-11-16 Eric Seidel <eric@webkit.org> 10064 10065 Reviewed by Adam Barth. 10066 10067 bugzilla-tool check-style should work with attachment ids instead of bug ids 10068 https://bugs.webkit.org/show_bug.cgi?id=31540 10069 10070 * Scripts/bugzilla-tool: 10071 100722009-11-16 Eric Seidel <eric@webkit.org> 10073 10074 Reviewed by Adam Barth. 10075 10076 WorkQueue is the only place that should know about special exit codes 10077 https://bugs.webkit.org/show_bug.cgi?id=31534 10078 10079 Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error 10080 and add tests for handling exit codes. 10081 I also cleaned up workqueue_unittest.py more. 10082 10083 * Scripts/bugzilla-tool: 10084 * Scripts/modules/workqueue.py: 10085 * Scripts/modules/workqueue_unittest.py: 10086 100872009-11-16 Eric Seidel <eric@webkit.org> 10088 10089 Reviewed by Adam Barth. 10090 10091 Re-factor workqueue_unittest to allow for more than one test. 10092 https://bugs.webkit.org/show_bug.cgi?id=31535 10093 10094 * Scripts/modules/workqueue_unittest.py: 10095 100962009-11-16 Eric Seidel <eric@webkit.org> 10097 10098 Reviewed by Adam Barth. 10099 10100 land-patches needs to be re-factored into smaller chunks 10101 https://bugs.webkit.org/show_bug.cgi?id=31532 10102 10103 * Scripts/bugzilla-tool: fix a couple obvious typos. 10104 101052009-11-16 Eric Seidel <eric@webkit.org> 10106 10107 Reviewed by Adam Barth. 10108 10109 land-patches needs to be re-factored into smaller chunks 10110 https://bugs.webkit.org/show_bug.cgi?id=31532 10111 10112 The next patch will move these methods into WebKitLandingScripts. 10113 10114 * Scripts/bugzilla-tool: 10115 - Split out _land_patch and _close_bug_if_no_active_patches. 10116 101172009-11-16 Adam Barth <abarth@webkit.org> 10118 10119 Reviewed by Eric Seidel. 10120 10121 Fix silly copy-and-paste code. I am a terrible coder. 10122 10123 * Scripts/modules/bugzilla.py: 10124 101252009-11-16 Adam Barth <abarth@webkit.org> 10126 10127 Reviewed by Eric Seidel. 10128 10129 Implement a StyleQueue 10130 https://bugs.webkit.org/show_bug.cgi?id=31537 10131 10132 The first iteration of the style queue only produces output locally. 10133 There is also a limit of 10 patches because it's not that useful to 10134 iterate through the entire review queue at this point. We can remove 10135 the limit later. 10136 10137 * Scripts/bugzilla-tool: 10138 * Scripts/modules/bugzilla.py: 10139 101402009-11-16 Adam Barth <abarth@webkit.org> 10141 10142 Reviewed by Eric Seidel. 10143 10144 Unit test WorkQueue 10145 https://bugs.webkit.org/show_bug.cgi?id=31531 10146 10147 Adds basic unit testing for WorkQueue. Just runs through one cycle. 10148 10149 * Scripts/bugzilla-tool: 10150 * Scripts/modules/statusbot.py: 10151 * Scripts/modules/workqueue.py: 10152 * Scripts/modules/workqueue_unittest.py: Added. 10153 * Scripts/run-webkit-unittests: 10154 101552009-11-16 Eric Seidel <eric@webkit.org> 10156 10157 Reviewed by Adam Barth. 10158 10159 bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs 10160 https://bugs.webkit.org/show_bug.cgi?id=31530 10161 10162 * Scripts/bugzilla-tool: 10163 101642009-11-16 Eric Seidel <eric@webkit.org> 10165 10166 Reviewed by Adam Barth. 10167 10168 bugzilla-tool needs apply-attachment 10169 https://bugs.webkit.org/show_bug.cgi?id=31528 10170 10171 * Scripts/bugzilla-tool: 10172 - Add ApplyAttachment command. 10173 - Abstract applying code into WebKitApplyingScripts. 10174 - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional. 10175 * Scripts/modules/bugzilla.py: 10176 - Add fetch_attachment and bug_id_for_attachment_id. 10177 * Scripts/modules/bugzilla_unittest.py: 10178 - Add test for new parsing. 10179 - Fix previous parsing test which broke with Adam's check-style patch (bug 31515). 10180 101812009-11-16 Eric Seidel <eric@webkit.org> 10182 10183 Reviewed by Adam Barth. 10184 10185 Document check-style's use of force_clean. 10186 10187 * Scripts/bugzilla-tool: 10188 * Scripts/modules/scm.py: 10189 101902009-11-16 Adam Barth <abarth@webkit.org> 10191 10192 Reviewed by Eric Seidel. 10193 10194 Move WorkQueue to its own file 10195 https://bugs.webkit.org/show_bug.cgi?id=31529 10196 10197 WorkQueue and WorkQueueDelegate are separate concerns from 10198 bugzilla-tool. Also added a missing include to logging.py. 10199 10200 * Scripts/bugzilla-tool: 10201 * Scripts/modules/logging.py: 10202 * Scripts/modules/workqueue.py: 10203 102042009-11-16 Adam Barth <abarth@webkit.org> 10205 10206 Reviewed by Eric Seidel. 10207 10208 Move OutputTee to logging.py. 10209 10210 * Scripts/bugzilla-tool: 10211 * Scripts/modules/logging.py: 10212 102132009-11-15 Adam Barth <abarth@webkit.org> 10214 10215 Reviewed by Eric Seidel. 10216 10217 Refactor bugzilla-tool to allow for multiple queues 10218 https://bugs.webkit.org/show_bug.cgi?id=31513 10219 10220 Divide the commit queue class into three class to make creating 10221 additional queues easier. 10222 10223 * Scripts/bugzilla-tool: 10224 102252009-11-15 Shinichiro Hamaji <hamaji@chromium.org> 10226 10227 Reviewed by Eric Seidel. 10228 10229 svn-apply may not handle git patches created by bugzilla-tool 10230 https://bugs.webkit.org/show_bug.cgi?id=31457 10231 10232 * Scripts/modules/scm.py: 10233 * Scripts/modules/scm_unittest.py: 10234 102352009-11-15 Shinichiro Hamaji <hamaji@chromium.org> 10236 10237 Reviewed by Eric Seidel. 10238 10239 bugzilla-tool should post git binary diff 10240 https://bugs.webkit.org/show_bug.cgi?id=31458 10241 10242 Add --binary option to Git.create_patch. 10243 10244 * Scripts/modules/scm.py: 10245 * Scripts/modules/scm_unittest.py: 10246 102472009-11-15 Adam Barth <abarth@webkit.org> 10248 10249 Reviewed by Darin Adler. 10250 10251 Add bugzilla-tool check-style 10252 https://bugs.webkit.org/show_bug.cgi?id=31515 10253 10254 * Scripts/bugzilla-tool: 10255 * Scripts/modules/bugzilla.py: 10256 102572009-11-13 Kenneth Rohde Christiansen <kenneth@webkit.org> 10258 10259 Reviewed by Simon Hausmann. 10260 10261 Make the Qt Linux only --valgrind feature, suppress errors 10262 defined in the SuppressedValgrindErrors file. 10263 10264 * Scripts/run-webkit-tests: 10265 102662009-11-13 Kenneth Rohde Christiansen <kenneth@webkit.org> 10267 10268 Reviewed by Simon Hausmann. 10269 10270 Set the locale to C and not to the current one in use on the system. 10271 10272 * DumpRenderTree/qt/DumpRenderTree.cpp: 10273 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 10274 102752009-11-13 Adam Roben <aroben@apple.com> 10276 10277 Add support for 10278 http/tests/security/isolatedWorld/didClearWindowObject.html 10279 10280 Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when 10281 window objects in isolated worlds are cleared 10282 10283 Reviewed by Dave Hyatt. 10284 10285 * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld. 10286 10287 * DumpRenderTree/mac/FrameLoadDelegate.mm: 10288 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): 10289 Added. Moved code here from -webView:didClearWindowObject:forFrame:. 10290 (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]): 10291 Added. Sets a __worldID property on the global object whose value is 10292 the ID of this world. 10293 (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]): 10294 Respond to this new delegate callback by calling through to one of the 10295 above new methods. 10296 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 10297 (worldMap): Added. Returns a HashMap containing all the worlds we've 10298 created. 10299 (worldIDForWorld): Added. Returns the ID for this world, or 0 if we 10300 haven't kept track of this world. 10301 (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap() 10302 instead of declaring our own. 10303 10304 * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld. 10305 10306 * DumpRenderTree/win/FrameLoadDelegate.cpp: 10307 (FrameLoadDelegate::didClearWindowObject): Moved code from hear to 10308 didClearWindowObjectForFrameInStandardWorld. 10309 (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld): 10310 Respond to this new delegate callback by calling through to one of the 10311 below new methods. 10312 (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld): 10313 Added. Sets a __worldID property on the gobal object whose value is 10314 the ID of this world. 10315 (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): 10316 Added. Moved code here from didClearWindowObject. 10317 10318 * DumpRenderTree/win/FrameLoadDelegate.h: Added the 10319 didClearWindowObjectForFrame* functions. 10320 10321 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 10322 (worldMap): Added. Returns a HashMap containing all the worlds we've 10323 created. 10324 (worldIDForWorld): Added. Returns the ID of this world, or 0 if we 10325 haven't kept track of this world. 10326 (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap() 10327 instead of declaring our own. 10328 103292009-11-13 Adam Roben <aroben@apple.com> 10330 10331 Finish replacing worldIDs with world objects 10332 10333 The only remaining use of worldIDs was in a method only used by DRT 10334 for the isolated worlds tests. 10335 10336 Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects 10337 10338 Reviewed by Mark Rowe. 10339 10340 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 10341 (LayoutTestController::evaluateScriptInIsolatedWorld): 10342 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 10343 (LayoutTestController::evaluateScriptInIsolatedWorld): 10344 Updated for changes to WebFrame. Now holds the map of worldID -> world 10345 at this level instead of making WebKit do it. 10346 103472009-11-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 10348 10349 Reviewed by Simon Hausmann. 10350 10351 [Qt] Ensure the DRT does not output anything until first test is run 10352 10353 * DumpRenderTree/qt/DumpRenderTree.cpp: 10354 * DumpRenderTree/qt/DumpRenderTree.h: 10355 103562009-11-13 Kenneth Rohde Christiansen <kenneth@webkit.org> 10357 10358 Reviewed by Tor Arne Vestbø. 10359 10360 Clear the undo stack in before each new test run. 10361 10362 Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes. 10363 10364 * DumpRenderTree/qt/DumpRenderTree.cpp: 10365 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 10366 103672009-11-13 Andras Becsi <becsi.andras@stud.u-szeged.hu> 10368 10369 Reviewed by Kenneth Rohde Christiansen. 10370 10371 [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController. 10372 10373 * DumpRenderTree/qt/DumpRenderTree.cpp: 10374 (WebCore::WebPage::resetSettings): 10375 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 10376 (LayoutTestController::overridePreference): 10377 103782009-11-13 Eric Seidel <eric@webkit.org> 10379 10380 Reviewed by Adam Barth. 10381 10382 Update committers.py based on svn records 10383 https://bugs.webkit.org/show_bug.cgi?id=31366 10384 10385 This list was generated using validate-committer-lists from 10386 https://bugs.webkit.org/show_bug.cgi?id=30970 10387 and makes committers.py current for committers who have 10388 committed in the last 3 years. 10389 10390 * Scripts/modules/committers.py: 10391 103922009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org> 10393 10394 Reviewed by Adam Barth. 10395 10396 The document-open.html test was flaky at times. The test invokes the layout test plugin 10397 which in its destroy stream handler opens a new document. This basically tears down the 10398 stream and the associated plugin instance. The pluginLog function in the layout test 10399 plugin attempts to retrieve the window script object on a torn down plugin instance 10400 which crashed consistently on windows in the debugger. The functions which issue 10401 these logs already have a valid window script object. We now have variants of the pluginLog 10402 function which take in a window script object with and without variable arguments. 10403 10404 https://bugs.webkit.org/show_bug.cgi?id=31067 10405 10406 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 10407 (pluginLogWithWindowObject): 10408 (pluginLogWithWindowObjectVariableArgs): 10409 (pluginLog): 10410 (notifyTestCompletion): 10411 (testDocumentOpen): 10412 (testWindowOpen): 10413 104142009-11-12 Joanmarie Diggs <joanmarie.diggs@gmail.com> 10415 10416 Reviewed by Gustavo Noronha Silva. 10417 10418 https://bugs.webkit.org/show_bug.cgi?id=30997 10419 [Gtk] Implemment AtkDocument 10420 10421 Added testing support. 10422 10423 * DumpRenderTree/AccessibilityUIElement.cpp: 10424 * DumpRenderTree/AccessibilityUIElement.h: 10425 (getDocumentEncodingCallback): 10426 (getDocumentURICallback): 10427 (AccessibilityUIElement::getJSClass): 10428 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 10429 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 10430 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 10431 (AccessibilityUIElement::documentEncoding): 10432 (AccessibilityUIElement::documentURI): 10433 104342009-11-12 Adam Roben <aroben@apple.com> 10435 10436 Replace worldIDs with world objects 10437 10438 Part of <http://webkit.org/b/31414> Implement new SPI for dealing with 10439 user scripts/stylesheets and isolated worlds 10440 10441 Reviewed by Sam Weinig. 10442 10443 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 10444 (LayoutTestController::addUserScript): 10445 (LayoutTestController::addUserStyleSheet): 10446 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 10447 (LayoutTestController::addUserScript): 10448 (LayoutTestController::addUserStyleSheet): 10449 Changed these functions to create a new WebJSWorld each time they're 10450 called and to pass that world to WebKit. 10451 104522009-11-11 Chris Fleizach <cfleizach@apple.com> 10453 10454 Reviewed by Oliver Hunt. 10455 10456 need to implement aria tree roles 10457 https://bugs.webkit.org/show_bug.cgi?id=31284 10458 10459 * DumpRenderTree/AccessibilityUIElement.cpp: 10460 (disclosedRowAtIndexCallback): 10461 (selectedRowAtIndexCallback): 10462 (isEqualCallback): 10463 (isAttributeSettableCallback): 10464 (isActionSupportedCallback): 10465 (disclosedByRowCallback): 10466 (hierarchicalLevelCallback): 10467 (AccessibilityUIElement::getJSClass): 10468 * DumpRenderTree/AccessibilityUIElement.h: 10469 (AccessibilityUIElement::isEqual): 10470 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 10471 (AccessibilityUIElement::hierarchicalLevel): 10472 (AccessibilityUIElement::disclosedRowAtIndex): 10473 (AccessibilityUIElement::selectedRowAtIndex): 10474 (AccessibilityUIElement::disclosedByRow): 10475 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 10476 (AccessibilityUIElement::getChildAtIndex): 10477 (AccessibilityUIElement::disclosedRowAtIndex): 10478 (AccessibilityUIElement::selectedRowAtIndex): 10479 (AccessibilityUIElement::titleUIElement): 10480 (AccessibilityUIElement::parentElement): 10481 (AccessibilityUIElement::disclosedByRow): 10482 (AccessibilityUIElement::hierarchicalLevel): 10483 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 10484 (AccessibilityUIElement::hierarchicalLevel): 10485 (AccessibilityUIElement::disclosedRowAtIndex): 10486 (AccessibilityUIElement::selectedRowAtIndex): 10487 (AccessibilityUIElement::disclosedByRow): 10488 104892009-11-11 Shinichiro Hamaji <hamaji@chromium.org> 10490 10491 Reviewed by Darin Adler. 10492 10493 svn-apply can not handle git binary diffs 10494 https://bugs.webkit.org/show_bug.cgi?id=26830 10495 10496 Support "literal" type git binary diffs. 10497 10498 * Scripts/VCSUtils.pm: 10499 * Scripts/modules/scm_unittest.py: 10500 * Scripts/svn-apply: 10501 105022009-11-11 Dmitry Titov <dimich@chromium.org> 10503 10504 Not reviewed, removing duplicate entry for myself in committers.py. 10505 10506 * Scripts/modules/committers.py: 10507 105082009-11-11 Alexey Proskuryakov <ap@apple.com> 10509 10510 Reviewed by Darin Adler and Mark Rowe. 10511 10512 https://bugs.webkit.org/show_bug.cgi?id=31200 10513 Tests in http/tests/security/mixedContent start to fail when new tests are added 10514 10515 * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug. 10516 105172009-11-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10518 10519 Reviewed by Jan Alonzo. 10520 10521 Create, and display a window for the inspector, for inspector 10522 tests. 10523 10524 Need to also show/hide the inspector window to avoid having 10525 problems with code assuming it is realized 10526 https://bugs.webkit.org/show_bug.cgi?id=31347 10527 10528 * DumpRenderTree/gtk/DumpRenderTree.cpp: 10529 (webInspectorShowWindow): 10530 (webInspectorCloseWindow): 10531 (webInspectorInspectWebView): 10532 (createWebView): 10533 105342009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org> 10535 10536 Unreviewed Qt buildbot fix. 10537 10538 My previous fix was wrong, so revert that change and fix it by 10539 returning when the document of the frame has no document element. 10540 Idea is borrowed from mac and win DRT. 10541 10542 * DumpRenderTree/qt/DumpRenderTree.cpp: 10543 (WebCore::DumpRenderTree::dumpFramesAsText): 10544 105452009-11-11 Eric Seidel <eric@webkit.org> 10546 10547 Reviewed byg Kenneth Rohde Christiansen. 10548 10549 Update Kenneth's committer record to include the email he 10550 uses on lists.webkit.org. 10551 10552 * Scripts/modules/committers.py: 10553 105542009-11-11 Eric Seidel <eric@webkit.org> 10555 10556 Reviewed by Gustavo Noronha Silva. 10557 10558 Several committers use separate email addresses for bugzilla and svn.webkit.org 10559 https://bugs.webkit.org/show_bug.cgi?id=31364 10560 10561 Update records for existing committers to include email addresses 10562 used in svn.webkit.org and lists.webkit.org. 10563 Most committers use the same email address in all 3 places, but some use 10564 separate addresses. committers.py needs record of each of these addresses. 10565 10566 * Scripts/modules/committers.py: 10567 105682009-11-11 Eric Seidel <eric@webkit.org> 10569 10570 No review, adding second email address for an existing committer. 10571 10572 Add Yong Li's second bugzilla account to his committer record. 10573 See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27 10574 10575 * Scripts/modules/committers.py: 10576 105772009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org> 10578 10579 Reviewed by Simon Hausmann. 10580 10581 If the frame has no innerText don't append it, and 10582 do not add a newline which breaks some cross platform 10583 results. 10584 10585 * DumpRenderTree/qt/DumpRenderTree.cpp: 10586 (WebCore::DumpRenderTree::dumpFramesAsText): 10587 105882009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org> 10589 10590 Reviewed by Simon Hausmann. 10591 10592 Implement missing functionality in the Gtk/Qt TestNetscapePlugin. 10593 10594 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 10595 (webkit_test_plugin_new_instance): 10596 (webkit_test_plugin_destroy_instance): 10597 (webkit_test_plugin_destroy_stream): 10598 105992009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org> 10600 10601 Reviewed by Mark Rowe. 10602 10603 Implement the functionality needed by plugins/window-open.html 10604 10605 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 10606 (webkit_test_plugin_new_instance): 10607 (webkit_test_plugin_set_window): 10608 106092009-11-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 10610 10611 Reviewed by Simon Hausmann. 10612 10613 [Qt] Force -graphicssystem raster and -style windows when running DRT 10614 10615 * DumpRenderTree/qt/main.cpp: 10616 * Scripts/run-webkit-tests: 10617 106182009-11-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 10619 10620 Reviewed by Simon Hausmann. 10621 10622 Compute correct library paths for Qt 10623 10624 * Scripts/webkitdirs.pm: 10625 106262009-11-10 Mark Rowe <mrowe@apple.com> 10627 10628 Reviewed by Sam Weinig. 10629 10630 <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added 10631 10632 The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error 10633 about the validity of the self-signed certificates used in the regression tests. We would then add the 10634 host to the ignore list for SSL certificate errors and retry the request. If this happened during a test 10635 that had enabled frame load delegate logging this would result in extra log messages being generated, 10636 causing the test to fail. 10637 10638 We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any 10639 tests. 10640 10641 * DumpRenderTree/mac/DumpRenderTree.mm: 10642 (dumpRenderTree): 10643 * DumpRenderTree/mac/FrameLoadDelegate.mm: 10644 (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): 10645 106462009-11-10 Andras Becsi <becsi.andras@stud.u-szeged.hu> 10647 10648 Reviewed by Kenneth Rohde Christiansen. 10649 10650 [Qt] Remove obsolete scrollbar policy settings from DRT constructor. 10651 10652 * DumpRenderTree/qt/DumpRenderTree.cpp: 10653 (WebCore::DumpRenderTree::DumpRenderTree): 10654 106552009-11-10 Philippe Normand <pnormand@igalia.com> 10656 10657 Reviewed by Jan Alonzo. 10658 10659 [GTK] Remove WebSocket configuration from WebKitWebSettings 10660 https://bugs.webkit.org/show_bug.cgi?id=31244 10661 10662 Follow-up of r50724. Don't set the enable-web-socket property 10663 anymore. 10664 10665 * DumpRenderTree/gtk/DumpRenderTree.cpp: 10666 (resetDefaultsToConsistentValues): 10667 106682009-11-10 Oliver Hunt <oliver@apple.com> 10669 10670 Reviewed by Maciej Stachowiak. 10671 10672 Rename 3D Canvas related classes to use WebGL prefix 10673 https://bugs.webkit.org/show_bug.cgi?id=29095 10674 10675 Checkin new version of do-webcore-rename used to do the WebGL type rename, 10676 and upate webkitdirs script to new method of testing for WebGL. 10677 10678 * Scripts/do-webcore-rename: 10679 * Scripts/webkitdirs.pm: 10680 106812009-11-09 Oliver Hunt <oliver@apple.com> 10682 10683 Reviewed by Geoff Garen. 10684 10685 Make do-webcore-rename work with git. 10686 10687 * Scripts/do-webcore-rename: 10688 106892009-11-09 Simon Hausmann <simon.hausmann@nokia.com> 10690 10691 Adding Kenneth to the reviewers list. 10692 10693 * Scripts/modules/committers.py: 10694 106952009-11-09 Martin Robinson <martin.james.robinson@gmail.com> 10696 10697 Reviewed by Jan Alonzo. 10698 10699 [GTK] Expose Page::tabKeyCyclesThroughElements in the API 10700 https://bugs.webkit.org/show_bug.cgi?id=30482 10701 10702 LayoutTestControllerGtk now uses the exposed 10703 Page::tabKeyCyclesThroughElements API 10704 10705 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 10706 (LayoutTestController::setTabKeyCyclesThroughElements): 10707 107082009-11-08 Shu Chang <Chang.Shu@nokia.com> 10709 10710 Reviewed by Holger Freyther. 10711 10712 [Qt] Added support for key code 8 (backspace) in EventSenderQt. 10713 This helps to pass the test case below. Also replaced hardcoded 10714 code numbers with defined constants. 10715 https://bugs.webkit.org/show_bug.cgi?id=31185 10716 10717 Test: editing/undo/undo-deleteWord.html 10718 10719 * DumpRenderTree/qt/EventSenderQt.cpp: 10720 (EventSender::keyDown): 10721 107222009-11-07 Antonio Gomes <tonikitoo@webkit.org> 10723 10724 Reviewed by Holger Freyther. 10725 10726 [Qt] [DRT] Fix wrong logic in LayoutTestController processWork 10727 https://bugs.webkit.org/show_bug.cgi?id=31164 10728 10729 Fixed wrong logic to assume WorkQueue is done in QT's DRT. 10730 10731 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 10732 (LayoutTestController::processWork): 10733 107342009-11-05 Antonio Gomes <tonikitoo@webkit.org> 10735 10736 Reviewed by Holger Freyther. 10737 10738 [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method 10739 https://bugs.webkit.org/show_bug.cgi?id=31158 10740 10741 By invoking a script queue'd by queueScript(), 'true' was beeing returned 10742 always, which from WorkQueue prospective means that a load has been started 10743 and the queue processing should stop and wait for the load to finish. 10744 Spinning it off into a loading and a non-loading variants was the solution 10745 adopted by Mac's DRT to work around this problem. The former keeps returning 10746 'true' while the later executes the script synchronously and returns 'false' 10747 making it possible to the WorkQueue to proceed right away. 10748 10749 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 10750 (LayoutTestController::processWork): 10751 (LayoutTestController::queueLoadingScript): 10752 (LayoutTestController::queueNonLoadingScript): 10753 * DumpRenderTree/qt/LayoutTestControllerQt.h: 10754 * DumpRenderTree/qt/WorkQueueItem.h: 10755 (LoadingScriptItem::LoadingScriptItem): 10756 (LoadingScriptItem::invoke): 10757 (NonLoadingScriptItem::NonLoadingScriptItem): 10758 (NonLoadingScriptItem::invoke): 10759 107602009-11-07 Mark Rowe <mrowe@apple.com> 10761 10762 Rubber-stamped by Cameron Zwarich. 10763 10764 Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH. 10765 10766 * Scripts/commit-log-editor: 10767 107682009-11-07 Mark Rowe <mrowe@apple.com> 10769 10770 Reviewed by Darin Adler. 10771 10772 Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>. 10773 commit-log-editor does not support all the email address configurations that prepare-Changelog supports 10774 10775 Move logic for determining the name and email address to use in a ChangeLog entry from 10776 prepare-ChangeLog to VCSUtils so that commit-log-editor can use it. It wants to check 10777 whether the author of the patch matches committer, and therefore needs access to the 10778 email address that would be used in a ChangeLog entry. 10779 10780 Based on a patch by Pierre d'Herbemont. 10781 10782 * Scripts/VCSUtils.pm: 10783 * Scripts/commit-log-editor: 10784 * Scripts/prepare-ChangeLog: 10785 * Scripts/webkitdirs.pm: 10786 107872009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org> 10788 10789 Reviewed by Adam Barth. 10790 10791 Added functionality to the layout test plugin to invoke document.open and 10792 window.open with default arguments. The associated webkit bug is 10793 https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically 10794 window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't 10795 work in Chromium (V8) if there is no calling javascript context. To achieve this 10796 effect we invoke these functions in the layout test plugin in the NPP_SetWindow 10797 for the window.open test case and in NPP_DestroyStream for the document.open test case. 10798 10799 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 10800 (testDocumentOpen): 10801 (testWindowOpen): 10802 (pluginAllocate): 10803 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 10804 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 10805 (NPP_New): 10806 (NPP_SetWindow): 10807 (NPP_DestroyStream): 10808 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 10809 (NPP_New): 10810 (NPP_SetWindow): 10811 (NPP_NewStream): 10812 (NPP_DestroyStream): 10813 108142009-11-06 Eric Seidel <eric@webkit.org> 10815 10816 Reviewed by Adam Barth. 10817 10818 bugzilla-tool crashed with exception 10819 https://bugs.webkit.org/show_bug.cgi?id=31092 10820 10821 * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error. 10822 108232009-11-04 Eric Seidel <eric@webkit.org> 10824 10825 No review, just add a line which got left out of the patch uploaded for commit. 10826 10827 commit-queue is crashing when trying to reject patches after unknown failures 10828 https://bugs.webkit.org/show_bug.cgi?id=31091 10829 10830 * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash. 10831 108322009-11-04 Adam Roben <aroben@apple.com> 10833 10834 Remove bogus else clause in bugzilla-tool 10835 10836 Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool 10837 create-bug raises exception after entering bug description 10838 10839 Reviewed by David Kilzer. 10840 10841 * Scripts/bugzilla-tool: 10842 (CreateBug): else clauses are only hit if no exception is raised, so 10843 it makes no sense to try to re-raise the exception in an else clause. 10844 The exception will automatically be re-raised if it doesn't match any 10845 of the except clauses, so we don't have to do anything special here at 10846 all to get the desired behavior. 10847 108482009-11-04 Eric Seidel <eric@webkit.org> 10849 10850 Reviewed by David Kilzer. 10851 10852 svn-apply's fixChangeLogPatch function seems broken 10853 https://bugs.webkit.org/show_bug.cgi?id=30683 10854 10855 Update fixChangeLogPatch to be able to handle patches which 10856 don't start at line 1. 10857 Add unit tests for svn-apply to scm_unittest.py. 10858 10859 * Scripts/VCSUtils.pm: 10860 * Scripts/modules/scm_unittest.py: 10861 108622009-11-04 Chris Fleizach <cfleizach@apple.com> 10863 10864 Reviewed by Beth Dakin. 10865 10866 Need to implement ARIA role="combobox" 10867 https://bugs.webkit.org/show_bug.cgi?id=31096 10868 10869 * DumpRenderTree/AccessibilityUIElement.cpp: 10870 (showMenuCallback): 10871 (getIsExpandedCallback): 10872 (AccessibilityUIElement::getJSClass): 10873 * DumpRenderTree/AccessibilityUIElement.h: 10874 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 10875 (AccessibilityUIElement::isExpanded): 10876 (AccessibilityUIElement::showMenu): 10877 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 10878 (AccessibilityUIElement::isExpanded): 10879 (AccessibilityUIElement::showMenu): 10880 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 10881 (AccessibilityUIElement::isSelected): 10882 (AccessibilityUIElement::isExpanded): 10883 (AccessibilityUIElement::showMenu): 10884 108852009-11-04 Eric Seidel <eric@webkit.org> 10886 10887 Reviewed by Adam Barth. 10888 10889 commit-queue is crashing when trying to reject patches after unknown failures 10890 https://bugs.webkit.org/show_bug.cgi?id=31091 10891 10892 * Scripts/bugzilla-tool: 10893 - patch['id'] was a copy/paste mistake. This code has no 'patch' variable 10894 so we have to find out what the current patch is by asking bugzilla again. 10895 - Discovered that this code was also leaking file descriptors, so fixed that. 10896 108972009-11-04 Adam Roben <aroben@apple.com> 10898 10899 Make run-webkit-tests work for the Debug_Internal Windows 10900 configuration 10901 10902 In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug 10903 suffix. 10904 10905 Fixes <http://webkit.org/b/31123>. 10906 10907 Reviewed by Sam Weinig. 10908 10909 * Scripts/run-webkit-tests: Don't add the _debug suffix in 10910 Debug_Internal, either. 10911 109122009-11-04 Eric Seidel <eric@webkit.org> 10913 10914 Reviewed by Adam Barth. 10915 10916 committers.py needs a way to store non-bugzilla email addresses 10917 https://bugs.webkit.org/show_bug.cgi?id=31037 10918 10919 Make Committer and Reviewer constructors take a single email or a list of emails. 10920 Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email. 10921 Expose reviewers(), used by validate-committer-lists on bug 30970. 10922 10923 * Scripts/modules/committers.py: 10924 * Scripts/modules/committers_unittest.py: Added tests for the new code. 10925 109262009-11-03 Yuzo Fujishima <yuzo@google.com> 10927 10928 Reviewed by David Levin. 10929 10930 Start/Stop Web Socket and Web Socket Secure servers for layout tests. 10931 https://bugs.webkit.org/show_bug.cgi?id=27491 10932 10933 The test path determination logic is changed to handle websocket and websocket/ssl cases. 10934 The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement. 10935 10936 Functions to start or stop Web Socket servers are added. 10937 10938 * Scripts/run-webkit-tests: 10939 109402009-11-03 Eric Seidel <eric@webkit.org> 10941 10942 No review, just changing wording of log message. 10943 10944 Change log string to say "failed" instead of "rejected" 10945 when a commit fails due to an out of date checkout. 10946 This makes grepping the commit-queue log for rejected patches easier. 10947 10948 * Scripts/bugzilla-tool: 10949 109502009-11-03 Eric Seidel <eric@webkit.org> 10951 10952 No review, adding commonly known committers missing from the file. 10953 10954 * Scripts/modules/committers.py: Add committers found by looking at SVN records. 10955 109562009-11-03 Eric Seidel <eric@webkit.org> 10957 10958 No review, just sort-order cleanup. 10959 10960 * Scripts/modules/committers.py: Sort committers/reviewers alphabetically. 10961 109622009-11-03 Stephen White <senorblanco@chromium.org> 10963 10964 (Unreviewed). 10965 10966 Add myself to committers.py. 10967 10968 * Scripts/modules/committers.py: 10969 109702009-11-03 Robin Dunn <robin@alldunn.com> 10971 10972 Reviewed by Kevin Ollviier. 10973 10974 Add packaging scripts for Debian-based Linux distros. 10975 10976 https://bugs.webkit.org/show_bug.cgi?id=31075 10977 10978 * wx/packaging/build-debian-installer.py: Added. 10979 * wx/packaging/debian: Added. 10980 109812009-11-03 Dan Bernstein <mitz@apple.com> 10982 10983 Reviewed by Anders Carlsson and Beth Dakin. 10984 10985 https://bugs.webkit.org/show_bug.cgi?id=31070 10986 10987 Added an 'ondestroy' parameter to the test plug-in. When the plug-in is 10988 destroyed, it executes the value of the 'ondestroy' parameter as a 10989 script. 10990 10991 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 10992 (pluginAllocate): Initialize onDestroy. 10993 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define 10994 onDestroy. 10995 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 10996 (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if 10997 specified. 10998 (NPP_Destroy): Execute the value of 'ondestroy' as a script. 10999 110002009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com> 11001 11002 Reviewed by Xan Lopez. 11003 11004 https://bugs.webkit.org/show_bug.cgi?id=31035 11005 [GTK] some accessibility tests hitting assertion in debug builds 11006 11007 Get the correct Gtk+ object before attempting to turn it into an AtkObject. 11008 11009 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 11010 (AccessibilityController::rootElement): 11011 110122009-11-02 Chris Fleizach <cfleizach@apple.com> 11013 11014 Reviewed by Beth Dakin. 11015 11016 Support ARIA "tab" roles 11017 https://bugs.webkit.org/show_bug.cgi?id=30842 11018 11019 * DumpRenderTree/AccessibilityUIElement.cpp: 11020 * DumpRenderTree/AccessibilityUIElement.h: 11021 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 11022 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 11023 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 11024 110252009-11-01 Eric Seidel <eric@webkit.org> 11026 11027 Reviewed by David Levin. 11028 11029 buildbots should use --exit-after-N-failures 11030 https://bugs.webkit.org/show_bug.cgi?id=30809 11031 11032 Make the bots exit after 20 failures to prevent never-ending 11033 test runs where every test spends a minute crashing. 11034 11035 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 11036 110372009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com> 11038 11039 Reviewed by Eric Seidel. 11040 11041 Turn on warnings for QtWebKit for gcc 11042 https://bugs.webkit.org/show_bug.cgi?id=30958 11043 11044 * DumpRenderTree/qt/main.cpp: 11045 (crashHandler): Mark function NO_RETURN 11046 110472009-11-01 Jessie Berlin <jberlin@webkit.org> 11048 11049 Adding myself to the committers list. 11050 11051 * Scripts/modules/committers.py: 11052 110532009-10-30 Jon Honeycutt <jhoneycutt@apple.com> 11054 11055 Fix an issue that Adam noticed in DRT. 11056 11057 Reviewed by Darin Adler. 11058 11059 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 11060 (AccessibilityUIElement::role): 11061 Get the length of the role text, and create a buffer dynamically. 11062 110632009-10-30 Eric Seidel <eric@webkit.org> 11064 11065 No review, rolling out r50105. 11066 http://trac.webkit.org/changeset/50105 11067 11068 This commit was causing: 11069 https://bugs.webkit.org/show_bug.cgi?id=30869 11070 We'll re-implement the feature a different way. 11071 11072 * Scripts/bugzilla-tool: 11073 110742009-10-29 Jon Honeycutt <jhoneycutt@apple.com> 11075 11076 Test for MSAA: Accessibility of headings is not correct 11077 11078 https://bugs.webkit.org/show_bug.cgi?id=30937 11079 11080 Reviewed by Adam Roben. 11081 11082 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 11083 (AccessibilityUIElement::role): 11084 Allow the role returned to be a BSTR. 11085 (AccessibilityUIElement::description): 11086 Fix a copy/paste error. 11087 110882009-10-29 Jon Honeycutt <jhoneycutt@apple.com> 11089 11090 Test for MSAA: Accessibility of links is wrong 11091 11092 https://bugs.webkit.org/show_bug.cgi?id=30928 11093 11094 Reviewed by Darin Adler. 11095 11096 * DumpRenderTree/AccessibilityUIElement.cpp: 11097 (getAccessibilityValueCallback): 11098 Return the accessibility value. 11099 (AccessibilityUIElement::getJSClass): 11100 Added "accessibilityValue" value. 11101 11102 * DumpRenderTree/AccessibilityUIElement.h: 11103 11104 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 11105 (AccessibilityUIElement::accessibilityValue): 11106 Stubbed. 11107 11108 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 11109 (AccessibilityUIElement::accessibilityValue): 11110 Stubbed. 11111 11112 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 11113 (AccessibilityUIElement::accessibilityValue): 11114 Get the object's value, and return it as a JS string. 11115 111162009-10-30 Kevin Ollivier <kevino@theolliviers.com> 11117 11118 Fix typo in command name used by wx build system. 11119 11120 * wx/build/build_utils.py: 11121 111222009-10-30 Adam Barth <abarth@webkit.org> 11123 11124 Reviewed by Darin Adler. 11125 11126 Patch v1 is a dumb default name for patches 11127 https://bugs.webkit.org/show_bug.cgi?id=30952 11128 11129 Let's use "Patch" instead. 11130 11131 * Scripts/bugzilla-tool: 11132 111332009-10-30 Andras Becsi <becsi.andras@stud.u-szeged.hu> 11134 11135 Unreviewed trivial buildfix. 11136 11137 [Qt] Buildfix for r50333. 11138 11139 * DumpRenderTree/qt/DumpRenderTree.pro: 11140 111412009-10-30 Antonio Gomes <tonikitoo@webkit.org> 11142 11143 Reviewed by Holger Freyther. 11144 11145 [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue 11146 https://bugs.webkit.org/show_bug.cgi?id=30953 11147 11148 DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the 11149 same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch 11150 makes qt DRT to share this implementation (as gtk and mac ports do). 11151 11152 * DumpRenderTree/qt/DumpRenderTree.pro: 11153 * DumpRenderTree/qt/WorkQueue.cpp: Removed. 11154 * DumpRenderTree/qt/WorkQueue.h: Removed. 11155 111562009-10-30 Kenneth Rohde Christiansen <kenneth@webkit.org> 11157 11158 Unreviewed potential buildbot fix. 11159 11160 Second try: Reset page history before running each test. 11161 11162 Apparently the QWebHistory::clear() keeps the current page 11163 in history which is not what we want, so we not additionally 11164 sets the history capacity to 0 (forces removing everything) 11165 and then sets it back to its original value. 11166 11167 * DumpRenderTree/qt/DumpRenderTree.cpp: 11168 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 11169 111702009-10-30 Kenneth Rohde Christiansen <kenneth@webkit.org> 11171 11172 Unreviewed potential buildbot fix. 11173 11174 Reset page history before running each test. 11175 11176 * DumpRenderTree/qt/DumpRenderTree.cpp: 11177 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 11178 111792009-10-30 Roland Steiner <rolandsteiner@chromium.org> 11180 11181 Reviewed by Eric Seidel. 11182 11183 Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak. 11184 11185 Bug 28420 - Implement HTML5 <ruby> rendering 11186 (https://bugs.webkit.org/show_bug.cgi?id=28420) 11187 11188 No new tests (no functional change). 11189 11190 * Scripts/build-webkit: 11191 111922009-10-29 Dan Bernstein <mitz@apple.com> 11193 11194 Reviewed by Mark Rowe. 11195 11196 Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine 11197 from the two scripts that define it but don’t use it to the script that uses it but doesn’t 11198 define it. 11199 11200 * Scripts/VCSUtils.pm: 11201 * Scripts/svn-apply: 11202 * Scripts/svn-unapply: 11203 112042009-10-29 Xan Lopez <xlopez@igalia.com> 11205 11206 Reviewed by Gustavo Noronha. 11207 11208 Use the GTK+ main loop instead of rolling our own mini-version of 11209 it. 11210 11211 * DumpRenderTree/gtk/DumpRenderTree.cpp: 11212 (dump): 11213 (runTest): 11214 (webViewLoadFinished): 11215 112162009-10-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 11217 11218 Reviewed by Oliver Hunt. 11219 11220 Implement the Qt version of DRT dumpBackForwardList(). 11221 11222 * DumpRenderTree/qt/DumpRenderTree.cpp: 11223 (WebCore::dumpHistoryItem): 11224 (WebCore::DumpRenderTree::dumpBackForwardList): 11225 112262009-10-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 11227 11228 Reviewed by Adam Roben. 11229 11230 Implement DRT functionality for Qt introduced in 11231 r28690 and r28705. 11232 11233 - Implemented pathToLocalResource which exposes the functionality of 11234 converting a given unix path to the correct location on Windows. 11235 - Implemented a way to remove machine-dependent information from paths 11236 in layout test results. 11237 11238 * DumpRenderTree/qt/DumpRenderTree.cpp: 11239 (WebCore::urlSuitableForTestResult): 11240 (WebCore::WebPage::javaScriptConsoleMessage): 11241 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 11242 (LayoutTestController::pathToLocalResource): 11243 * DumpRenderTree/qt/LayoutTestControllerQt.h: 11244 112452009-10-28 Roland Steiner <rolandsteiner@chromium.org> 11246 11247 Adding myself to the committers list. 11248 11249 * Scripts/modules/committers.py: 11250 112512009-10-28 Chris Fleizach <cfleizach@apple.com> 11252 11253 Adding myself to the committers list. 11254 11255 * Scripts/modules/committers.py: 11256 112572009-10-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11258 11259 Reviewed by Jan Alonzo. 11260 11261 [GTK] API to start inspector for a WebView 11262 https://bugs.webkit.org/show_bug.cgi?id=22551 11263 11264 Use the new inspector API to implement the LayoutTestController 11265 interfaces used to test the inspector. 11266 11267 * DumpRenderTree/gtk/DumpRenderTree.cpp: 11268 (webInspectorInspectWebView): 11269 (createWebView): 11270 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 11271 (LayoutTestController::showWebInspector): 11272 (LayoutTestController::closeWebInspector): 11273 (LayoutTestController::evaluateInWebInspector): 11274 112752009-10-28 Shinichiro Hamaji <hamaji@chromium.org> 11276 11277 Reviewed by Eric Seidel. 11278 11279 [Qt] WebFrame::counterValueForElementById must not be exposed 11280 https://bugs.webkit.org/show_bug.cgi?id=30882 11281 11282 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 11283 (LayoutTestController::counterValueForElementById): 11284 112852009-10-28 Kenneth Rohde Christiansen <kenneth@webkit.org> 11286 11287 Rubberstamped by Oliver Hunt. 11288 11289 Fix the warning: 11290 11291 "warning: ignoring return value of 'char* getcwd(char*, size_t)', 11292 declared with attribute warn_unused_result". 11293 11294 by actually checking the result. In the case it is null, an 11295 error has occoured, so treat it as the other fatal errors. 11296 11297 * DumpRenderTree/qt/DumpRenderTree.cpp: 11298 (WebCore::DumpRenderTree::initializeFonts): 11299 113002009-10-27 Shinichiro Hamaji <hamaji@chromium.org> 11301 11302 Reviewed by Darin Adler. 11303 11304 Provide a way to get counter values with layoutTestContoller 11305 https://bugs.webkit.org/show_bug.cgi?id=30555 11306 11307 Define layoutTestContoller.counterValueForElementById. 11308 11309 * DumpRenderTree/LayoutTestController.cpp: 11310 (counterValueForElementByIdCallback): 11311 (LayoutTestController::staticFunctions): 11312 * DumpRenderTree/LayoutTestController.h: 11313 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 11314 (LayoutTestController::counterValueForElementById): 11315 113162009-10-27 Kenneth Rohde Christiansen <kenneth@webkit.org> 11317 11318 Rubberstamped by Oliver Hunt. 11319 11320 Change two methods to be internal for DRT use only. 11321 11322 Part of [Qt] Review all new API in Qt 4.6 11323 https://bugs.webkit.org/show_bug.cgi?id=29843#c11 11324 11325 * DumpRenderTree/qt/DumpRenderTree.cpp: 11326 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 11327 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 11328 (LayoutTestController::whiteListAccessFromOrigin): 11329 113302009-10-27 Eric Seidel <eric@webkit.org> 11331 11332 Reviewed by Adam Barth. 11333 11334 REGRESSION: svn-apply exits(1) when applying a patch with a file add 11335 https://bugs.webkit.org/show_bug.cgi?id=30826 11336 11337 * Scripts/svn-apply: 11338 - Add () around all system() calls. 11339 - Use the correct system() == 0 or die instead of system() or die 11340 - Add descriptive messages to all die statements. 11341 113422009-10-27 Steve Block <steveblock@google.com> 11343 11344 Reviewed by NOBODY. 11345 11346 Adds steveblock@google.com to list of committers. 11347 11348 * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers. 11349 113502009-10-27 Eric Seidel <eric@webkit.org> 11351 11352 Reviewed by Adam Barth. 11353 11354 svn-apply can exit(0) even on patch failure 11355 https://bugs.webkit.org/show_bug.cgi?id=29622 11356 11357 * Scripts/svn-apply: 11358 - Add a bunch of "or die" statements, hopefully catching all 11359 possible cases where failure could still exit(0). 11360 113612009-10-27 Eric Seidel <eric@webkit.org> 11362 11363 Reviewed by Adam Barth. 11364 11365 svn-* scripts should share code through VCSUtils.pm 11366 https://bugs.webkit.org/show_bug.cgi?id=30791 11367 11368 Just moving code into a shared location. 11369 11370 * Scripts/VCSUtils.pm: 11371 * Scripts/prepare-ChangeLog: 11372 * Scripts/resolve-ChangeLogs: 11373 * Scripts/svn-apply: 11374 * Scripts/svn-create-patch: 11375 * Scripts/svn-unapply: 11376 * Scripts/update-webkit: 11377 113782009-10-27 Vadim Zeitlin <vadim@wxwidgets.org> 11379 11380 Suppress a huge number of MSVC warnings when building wxWebKit. 11381 11382 * wx/build/settings.py: 11383 113842009-10-26 Eric Seidel <eric@webkit.org> 11385 11386 No review, just adding Mike Belshe to the committers list. 11387 11388 * Scripts/modules/committers.py: 11389 113902009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com> 11391 11392 Reviewed by Darin Adler. 11393 11394 Make .rc files compile on Windows without depending on MFC headers 11395 https://bugs.webkit.org/show_bug.cgi?id=30750 11396 11397 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use 11398 windows.h instead of afxres.h because it exists even when MFC is not 11399 installed, and is all that's needed here. 11400 11401 * FindSafari/FindSafari.rc: Ditto 11402 114032009-10-24 Eric Seidel <eric@webkit.org> 11404 11405 Reviewed by Adam Barth. 11406 11407 bugzilla-tool post-diff should know how to mark commit-queue=? 11408 https://bugs.webkit.org/show_bug.cgi?id=29202 11409 11410 * Scripts/bugzilla-tool: 11411 - Add --commit-queue option to post-diff, post-commits and create-bug. 11412 * Scripts/modules/bugzilla.py: 11413 - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch. 11414 - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch. 11415 114162009-10-23 Eric Seidel <eric@webkit.org> 11417 11418 Reviewed by Adam Barth. 11419 11420 bugzilla-tool commit-queue does not notice modifications to committers.py 11421 https://bugs.webkit.org/show_bug.cgi?id=30084 11422 11423 * Scripts/bugzilla-tool: 11424 - Make commit-queue re-exec itself instead of using while(1). 11425 - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch. 11426 - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too). 11427 114282009-10-22 Eric Seidel <eric@webkit.org> 11429 11430 Reviewed by Adam Barth. 11431 11432 commit-queue will get stuck on patches if land-patches terminates unexpectedly 11433 https://bugs.webkit.org/show_bug.cgi?id=30634 11434 11435 * Scripts/bugzilla-tool: 11436 - Add a way for land-patches to exit(2) to indicate an error, but one it has handled. 11437 - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'. 11438 114392009-10-26 Yuzo Fujishima <yuzo@google.com> 11440 11441 Reviewed by Eric Seidel. 11442 11443 Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example. 11444 11445 https://bugs.webkit.org/show_bug.cgi?id=30763 11446 11447 * pywebsocket/mod_pywebsocket/__init__.py: 11448 * pywebsocket/mod_pywebsocket/dispatch.py: 11449 * pywebsocket/mod_pywebsocket/headerparserhandler.py: 11450 * pywebsocket/mod_pywebsocket/standalone.py: 11451 * pywebsocket/setup.py: 11452 * pywebsocket/test/test_dispatch.py: 11453 114542009-10-26 Carol Szabo <carol.szabo@nokia.com> 11455 11456 Reviewed by David Levin. 11457 11458 REGRESSION: 2 failures in run-webkit-unittests 11459 https://bugs.webkit.org/show_bug.cgi?id=30645 11460 11461 * Scripts/modules/cpp_style_unittest.py: 11462 Fixed a few test scenarios which apparently lost some spaces from 11463 text literals. 11464 114652009-10-26 Kevin Ollivier <kevino@theolliviers.com> 11466 11467 wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit. 11468 11469 * Scripts/webkitdirs.pm: 11470 114712009-10-26 Csaba Osztrogonác <ossy@webkit.org> 11472 11473 Reviewed by Darin Adler. 11474 11475 Unification of using null device in perl scripts. 11476 https://bugs.webkit.org/show_bug.cgi?id=30572 11477 11478 * Scripts/VCSUtils.pm: 11479 * Scripts/bisect-builds: 11480 * Scripts/resolve-ChangeLogs: 11481 * Scripts/run-iexploder-tests: 11482 * Scripts/run-jsc: 11483 * Scripts/run-mangleme-tests: 11484 * Scripts/run-webkit-tests: 11485 * Scripts/webkitdirs.pm: 11486 Using File::Spec->devnull() instead of hard coded /dev/null. 11487 114882009-10-26 Eric Seidel <eric@webkit.org> 11489 11490 Reviewed by Holger Freyther. 11491 11492 Reviewers are missing from committers.py 11493 https://bugs.webkit.org/show_bug.cgi?id=30733 11494 11495 * Scripts/modules/committers.py: 11496 114972009-10-23 Eric Seidel <eric@webkit.org> 11498 11499 No review, only adding Alice to the list of reviewers. 11500 11501 * Scripts/modules/committers.py: 11502 115032009-10-23 Eric Seidel <eric@webkit.org> 11504 11505 Reviewed by Eric Carlson. 11506 11507 fast/media/mq-transform-02.html failed on Leopard Commit Bot 11508 https://bugs.webkit.org/show_bug.cgi?id=30700 11509 11510 * DumpRenderTree/mac/DumpRenderTree.mm: 11511 (resetDefaultsToConsistentValues): Update QuickTime version check. 11512 115132009-10-23 Kevin Ollivier <kevino@theolliviers.com> 11514 11515 wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 11516 character measurement APIs that are private on Tiger. 11517 11518 * wx/build/settings.py: 11519 115202009-10-22 Gavin Barraclough <barraclough@apple.com> 11521 11522 Reviewed by NOBODY (build fix). 11523 Build fix following bug #30696. 11524 11525 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 11526 (LayoutTestController::evaluateScriptInIsolatedWorld): 11527 115282009-10-22 Gavin Barraclough <barraclough@apple.com> 11529 11530 Reviewed by Sam Weinig & Geoff Garen. 11531 11532 https://bugs.webkit.org/show_bug.cgi?id=30696 11533 Enable isolated-worlds tests on mac. 11534 11535 Add private interface for DRT to invoke execution in a given world. 11536 11537 * DumpRenderTree/LayoutTestController.cpp: 11538 (evaluateScriptInIsolatedWorldCallback): 11539 (LayoutTestController::staticFunctions): 11540 * DumpRenderTree/LayoutTestController.h: 11541 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 11542 (LayoutTestController::evaluateScriptInIsolatedWorld): 11543 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 11544 (LayoutTestController::evaluateScriptInIsolatedWorld): 11545 115462009-10-21 Eric Seidel <eric@webkit.org> 11547 11548 Reviewed by Adam Barth. 11549 11550 bugzilla-tool's "patch failed to download an apply" error should give more information 11551 https://bugs.webkit.org/show_bug.cgi?id=30632 11552 11553 * Scripts/modules/scm.py: 11554 - Use the common run_command method instead of custom POpen code. 11555 - Make run_command know how to take pipes as input. 11556 * Scripts/modules/scm_unittest.py: 11557 - Add new tests to cover change. 11558 - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times. 11559 115602009-10-21 Kent Tamura <tkent@chromium.org> 11561 11562 Unreviewed. Adding myself to the committers list. 11563 11564 * Scripts/modules/committers.py: 11565 115662009-10-21 Robin Dunn <robin@alldunn.com> 11567 11568 Reviewed by Kevin Ollivier. 11569 11570 Update the Windows installer builder to work with Vista / Win 7 and with git. 11571 11572 https://bugs.webkit.org/show_bug.cgi?id=30649 11573 11574 * wx/build/build_utils.py: 11575 * wx/packaging/build-mac-installer.py: 11576 * wx/packaging/build-win-installer.py: 11577 * wx/packaging/wxWebKitInstaller.iss.in: 11578 115792009-10-21 Alejandro G. Castro <alex@igalia.com> 11580 11581 Reviewed by Gustavo Noronha. 11582 11583 [GTK] Added conditional code to avoid using 11584 gdk_window_get_root_coords if we do not have a gtk+ release newer 11585 than 2.17.3. 11586 https://bugs.webkit.org/show_bug.cgi?id=30636 11587 11588 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 11589 115902009-10-21 Shu Chang <Chang.Shu@nokia.com> 11591 11592 Reviewed by Eric Seidel. 11593 11594 [Qt] Added dummy implementation for keepWebHistory() 11595 https://bugs.webkit.org/show_bug.cgi?id=30592 11596 11597 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 11598 (LayoutTestController::keepWebHistory): 11599 * DumpRenderTree/qt/LayoutTestControllerQt.h: 11600 116012009-10-21 Alejandro G. Castro <alex@igalia.com> 11602 11603 Reviewed by Xan Lopez. 11604 11605 [GTK] Fixed the double click condition, it is not double click if 11606 we move in just in one direction. 11607 https://bugs.webkit.org/show_bug.cgi?id=30636 11608 11609 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 11610 116112009-10-21 Alejandro G. Castro <alex@igalia.com> 11612 11613 Reviewed by Xan Lopez. 11614 11615 [GTK] Initialize the events completly before emitting them. 11616 https://bugs.webkit.org/show_bug.cgi?id=30633 11617 11618 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 11619 116202009-10-21 Kevin Ollivier <kevino@theolliviers.com> 11621 11622 wx build fix. Fix for when linking using --as-needed with gcc. 11623 11624 * wx/browser/wscript: 11625 116262009-10-21 Kevin Ollivier <kevino@theolliviers.com> 11627 11628 wxMac 10.4 build fix. Build and link against a version of libcurl new enough 11629 to support all the features used by CURL backend. 11630 11631 * wx/build/settings.py: 11632 * wx/install-unix-extras: 11633 116342009-10-20 Anton Muhin <antonm@chromium.org> 11635 11636 Reviewed by Adam Barth. 11637 11638 Add {ager,antonm,yurys}@chromium.org into committers.py 11639 https://bugs.webkit.org/show_bug.cgi?id=30560 11640 11641 * Scripts/modules/committers.py: 11642 116432009-10-20 Kenneth Rohde Christiansen <kenneth@webkit.org> 11644 11645 Reviewed by Tor Arne Vestbø. 11646 11647 Make the Netscape Test plugin available to the Qt launcher. 11648 11649 * Scripts/run-launcher: 11650 116512009-10-20 Fumitoshi Ukai <ukai@chromium.org> 11652 11653 Reviewed by David Levin. 11654 11655 Removed WebSocket runtime settings. 11656 https://bugs.webkit.org/show_bug.cgi?id=29896 11657 11658 WebSocket runtime configuration is supported by chromium/v8 only. 11659 11660 * DumpRenderTree/mac/DumpRenderTree.mm: 11661 (resetDefaultsToConsistentValues): 11662 * DumpRenderTree/win/DumpRenderTree.cpp: 11663 (resetDefaultsToConsistentValues): 11664 116652009-10-19 Nate Chapin <japhet@chromium.org> 11666 11667 Reviewed by Adam Barth. 11668 11669 Add testFail() to test plugin so we can test our handling of a 11670 plugin invoke call returning false. 11671 11672 https://bugs.webkit.org/show_bug.cgi?id=30239 11673 11674 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail(). 11675 (pluginInvoke): 11676 (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown. 11677 116782009-10-19 Zan Dobersek <zandobersek@gmail.com> 11679 11680 Reviewed by Gustavo Noronha. 11681 11682 Enable DOM pasting when running layout tests. 11683 11684 * DumpRenderTree/gtk/DumpRenderTree.cpp: 11685 (resetDefaultsToConsistentValues): 11686 116872009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org> 11688 11689 Reviewed by Simon Hausmann. 11690 11691 Use the setPreferredContentsSize method instead 11692 of setFixedContentsSize, as the method has been renamed. 11693 11694 * DumpRenderTree/qt/DumpRenderTree.cpp: 11695 (WebCore::DumpRenderTree::open): 11696 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 11697 (LayoutTestController::setFixedContentsSize): 11698 116992009-10-16 Steve Falkenburg <sfalken@apple.com> 11700 11701 Reviewed by Dan Bernstein. 11702 11703 https://bugs.webkit.org/show_bug.cgi?id=30456 11704 Fixes for new Debug_All Windows build configuration. 11705 11706 * DumpRenderTree/win/DumpRenderTree.cpp: 11707 (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming. 11708 * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX. 11709 117102009-10-16 Eric Seidel <eric@webkit.org> 11711 11712 Reviewed by Adam Barth. 11713 11714 commit-queue status bot should list which buildbot is blocking the queue 11715 https://bugs.webkit.org/show_bug.cgi?id=30452 11716 11717 Add new methods and testing. 11718 11719 * Scripts/bugzilla-tool: 11720 * Scripts/modules/buildbot.py: 11721 * Scripts/modules/buildbot_unittest.py: 11722 117232009-10-16 Eric Seidel <eric@webkit.org> 11724 11725 Reviewed by Adam Barth. 11726 11727 run-webkit-tests fails when CWD is not inside a WebKit checkout 11728 https://bugs.webkit.org/show_bug.cgi?id=30451 11729 11730 * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure. 11731 * Scripts/modules/scm_unittest.py: 11732 - Remove use of original_path (we don't need to restore the CWD). 11733 - Don't use '.' to find the webkit checkout, use __file__ instead. 11734 117352009-10-16 Steve Falkenburg <sfalken@apple.com> 11736 11737 Reviewed by Adam Roben. 11738 11739 Add a Debug_All configuration to build entire stack as debug. 11740 Change Debug_Internal to: 11741 - stop using _debug suffix for all WebKit/Safari binaries 11742 - not use _debug as a DLL naming suffix 11743 - use non-debug C runtime lib. 11744 11745 * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration. 11746 * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration. 11747 * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration. 11748 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 11749 Add missing debug.vsprops inherited property sheet. 11750 Add Debug_All configuration. 11751 * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all". 11752 * WinLauncher/WinLauncher.vcproj: 11753 Removed extraneous definitions inherited from vsprops. 11754 Add Debug_All configuration. 11755 117562009-10-16 Carol Szabo <carol.szabo@nokia.com> 11757 11758 Reviewed by David Levin. 11759 11760 check-webkit-style is wrong about indent checking in namespaces 11761 in header files and a few other things 11762 https://bugs.webkit.org/show_bug.cgi?id=30362 11763 11764 The few other things include: 11765 + check-webkit-style does not require spaces around the equal sign 11766 inside 'if' statements and around binary operators that take 11767 numeric literals. 11768 + check-webkit-style reports false errors for the / operator 11769 when part of a filename in the #include directive. 11770 11771 * Scripts/modules/cpp_style.py: 11772 Improved indentation checking and space checking around 11773 binary operators. While the checks are still not perfect, 11774 they are clearly better than before. 11775 * Scripts/modules/cpp_style_unittest.py: 11776 Added test cases for the newly supported checks and modified old 11777 test cases to match the new guidelines 11778 117792009-10-16 Kevin Ollivier <kevino@theolliviers.com> 11780 11781 wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp. 11782 11783 * wx/build/settings.py: 11784 117852009-10-15 Yuzo Fujishima <yuzo@google.com> 11786 11787 Reviewed by David Levin. 11788 11789 Add mod_pywebsocket to test Web Sockets. 11790 http://code.google.com/p/pywebsocket/ 11791 https://bugs.webkit.org/show_bug.cgi?id=27490 11792 11793 * pywebsocket/COPYING: Added. 11794 * pywebsocket/MANIFEST.in: Added. 11795 * pywebsocket/README: Added. 11796 * pywebsocket/example/echo_client.py: Added. 11797 * pywebsocket/example/echo_wsh.py: Added. 11798 * pywebsocket/mod_pywebsocket/__init__.py: Added. 11799 * pywebsocket/mod_pywebsocket/dispatch.py: Added. 11800 * pywebsocket/mod_pywebsocket/handshake.py: Added. 11801 * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added. 11802 * pywebsocket/mod_pywebsocket/msgutil.py: Added. 11803 * pywebsocket/mod_pywebsocket/standalone.py: Added. 11804 * pywebsocket/mod_pywebsocket/util.py: Added. 11805 * pywebsocket/setup.py: Added. 11806 * pywebsocket/test/config.py: Added. 11807 * pywebsocket/test/mock.py: Added. 11808 * pywebsocket/test/run_all.py: Added. 11809 * pywebsocket/test/test_dispatch.py: Added. 11810 * pywebsocket/test/test_handshake.py: Added. 11811 * pywebsocket/test/test_mock.py: Added. 11812 * pywebsocket/test/test_msgutil.py: Added. 11813 * pywebsocket/test/test_util.py: Added. 11814 * pywebsocket/test/testdata/handlers/blank_wsh.py: Added. 11815 * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added. 11816 * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added. 11817 * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added. 11818 * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added. 11819 * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added. 11820 * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added. 11821 * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added. 11822 118232009-10-15 James Robinson <jamesr@google.com> 11824 11825 Reviewed by David Levin. 11826 11827 Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file. 11828 11829 https://bugs.webkit.org/show_bug.cgi?id=30426 11830 11831 * Scripts/modules/cpp_style.py: 11832 * Scripts/modules/cpp_style_unittest.py: 11833 118342009-10-15 Brian Weinstein <bweinstein@apple.com> 11835 11836 Reviewed by Adam Roben. 11837 11838 Fixes <http://webkit.org/b/30411>. 11839 REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows. 11840 11841 Added a check for isChromium() in pdevenv, and pass /useenv if we are not 11842 building Chromium. 11843 11844 * Scripts/pdevenv: 11845 118462009-10-15 Robin Dunn <robin@alldunn.com> 11847 11848 Reviewed by Kevin Ollivier. 11849 11850 Add Mac package building scripts for wx. 11851 11852 https://bugs.webkit.org/show_bug.cgi?id=30405 11853 11854 * wx/build/build_utils.py: 11855 * wx/build/settings.py: 11856 * wx/packaging/build-mac-installer.py: Added. 11857 118582009-10-15 Zan Dobersek <zandobersek@gmail.com> 11859 11860 Reviewed by Gustavo Noronha. 11861 11862 Enable Web Sockets support when running layout tests. 11863 11864 * DumpRenderTree/gtk/DumpRenderTree.cpp: 11865 (resetDefaultsToConsistentValues): 11866 118672009-10-15 Xan Lopez <xlopez@igalia.com> 11868 11869 Reviewed by Gustavo Noronha. 11870 11871 Need to initialize event.button.button, since in most cases a 11872 button number is not passed as an argument. 11873 11874 * DumpRenderTree/gtk/EventSender.cpp: 11875 (mouseDownCallback): 11876 (mouseUpCallback): 11877 118782009-10-15 Kevin Ollivier <kevino@theolliviers.com> 11879 11880 wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to 11881 the OS if none was explicitly set. 11882 11883 * wx/build/settings.py: 11884 118852009-10-14 Pavel Feldman <pfeldman@chromium.org> 11886 11887 Reviewed by Timothy Hatcher. 11888 11889 Web Inspector: enable developers extras within inspector layout tests. 11890 11891 https://bugs.webkit.org/show_bug.cgi?id=30014 11892 11893 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 11894 (LayoutTestController::showWebInspector): 11895 (LayoutTestController::closeWebInspector): 11896 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 11897 (LayoutTestController::showWebInspector): 11898 (LayoutTestController::closeWebInspector): 11899 119002009-10-14 José Millán Soto <jmillan@igalia.com> 11901 11902 Reviewed by Jan Alonzo. 11903 11904 GtkLauncher is using a deprecated signal 11905 https://bugs.webkit.org/show_bug.cgi?id=30364 11906 11907 Modified GtkLauncher to use notify::title signal instead of 11908 deprecated title-changed signal 11909 11910 * GtkLauncher/main.c: 11911 (notify_title_cb): 11912 (create_browser): 11913 119142009-10-14 Brady Eidson <beidson@apple.com> 11915 11916 Reviewed by Sam Weinig. 11917 11918 Don't set the history delegate on new windows that are opened during a test, as the history delegate: 11919 1 - Disables WebHistory 11920 2 - Doesn't make sense in that context anyway. 11921 11922 * DumpRenderTree/win/DumpRenderTree.cpp: 11923 (createWebViewAndOffscreenWindow): 11924 119252009-10-14 Kevin Ollivier <kevino@theolliviers.com> 11926 11927 wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify 11928 the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET. 11929 11930 * wx/build/settings.py: 11931 * wx/install-unix-extras: 11932 119332009-10-14 Brady Eidson <beidson@apple.com> 11934 11935 Reviewed by Sam Weinig. 11936 11937 WebKit Win API should provide a delegate interface for global history. 11938 https://bugs.webkit.org/show_bug.cgi?id=29905 11939 11940 * DumpRenderTree/LayoutTestController.cpp: 11941 (LayoutTestController::LayoutTestController): 11942 * DumpRenderTree/LayoutTestController.h: 11943 (LayoutTestController::dumpHistoryDelegateCallbacks): 11944 (LayoutTestController::setDumpHistoryDelegateCallbacks): 11945 11946 * DumpRenderTree/win/DumpRenderTree.cpp: 11947 (shouldLogHistoryDelegates): 11948 (runTest): 11949 (createWebViewAndOffscreenWindow): 11950 (main): 11951 * DumpRenderTree/win/DumpRenderTree.vcproj: 11952 11953 Add the IWebHistoryDelegate to DRT Windows: 11954 * DumpRenderTree/win/HistoryDelegate.cpp: Added. 11955 (wstringFromBSTR): 11956 (HistoryDelegate::HistoryDelegate): 11957 (HistoryDelegate::~HistoryDelegate): 11958 (HistoryDelegate::QueryInterface): 11959 (HistoryDelegate::AddRef): 11960 (HistoryDelegate::Release): 11961 (HistoryDelegate::didNavigateWithNavigationData): 11962 (HistoryDelegate::didPerformClientRedirectFromURL): 11963 (HistoryDelegate::didPerformServerRedirectFromURL): 11964 (HistoryDelegate::updateHistoryTitle): 11965 (HistoryDelegate::populateVisitedLinksForWebView): 11966 * DumpRenderTree/win/HistoryDelegate.h: Added. 11967 11968 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 11969 (LayoutTestController::removeAllVisitedLinks): 11970 119712009-10-14 Shu Chang <Chang.Shu@nokia.com> 11972 11973 Reviewed by Simon Hausmann. 11974 11975 [Qt] Implement support for setPOSIXLocale on Qt. 11976 https://bugs.webkit.org/show_bug.cgi?id=30268 11977 11978 * DumpRenderTree/qt/DumpRenderTree.cpp: 11979 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 11980 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 11981 (LayoutTestController::setPOSIXLocale): 11982 * DumpRenderTree/qt/LayoutTestControllerQt.h: 11983 119842009-10-13 Stephanie Lewis <slewis@apple.com> 11985 11986 Unreviewed, adding myself to reviewers list. 11987 11988 * Scripts/modules/committers.py: 11989 119902009-10-13 Stephanie Lewis <slewis@apple.com> 11991 11992 Reviewed by Mark Rowe. 11993 11994 Fix null assignment so root tests work again. 11995 11996 * Scripts/webkitdirs.pm: 11997 119982009-10-13 Andras Becsi <becsi.andras@stud.u-szeged.hu> 11999 12000 Reviewed by Simon Hausmann. 12001 12002 [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes 12003 out of jsobjects into separate files to get a more structured DumpRenderTree implementation. 12004 This is done in preparation of implementing missing features in DRT. 12005 No functionality changes made yet. 12006 12007 * DumpRenderTree/qt/DumpRenderTree.cpp: 12008 * DumpRenderTree/qt/DumpRenderTree.pro: 12009 * DumpRenderTree/qt/EventSenderQt.cpp: Added. 12010 (EventSender::EventSender): 12011 (EventSender::mouseDown): 12012 (EventSender::mouseUp): 12013 (EventSender::mouseMoveTo): 12014 (EventSender::leapForward): 12015 (EventSender::keyDown): 12016 (EventSender::contextClick): 12017 (EventSender::scheduleAsynchronousClick): 12018 (EventSender::frameUnderMouse): 12019 * DumpRenderTree/qt/EventSenderQt.h: Added. 12020 (EventSender::clearKillRing): 12021 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added. 12022 (LayoutTestController::LayoutTestController): 12023 (LayoutTestController::reset): 12024 (LayoutTestController::processWork): 12025 (LayoutTestController::maybeDump): 12026 (LayoutTestController::waitUntilDone): 12027 (LayoutTestController::notifyDone): 12028 (LayoutTestController::windowCount): 12029 (LayoutTestController::clearBackForwardList): 12030 (LayoutTestController::dumpEditingCallbacks): 12031 (LayoutTestController::dumpResourceLoadCallbacks): 12032 (LayoutTestController::queueBackNavigation): 12033 (LayoutTestController::queueForwardNavigation): 12034 (LayoutTestController::queueLoad): 12035 (LayoutTestController::queueReload): 12036 (LayoutTestController::queueScript): 12037 (LayoutTestController::provisionalLoad): 12038 (LayoutTestController::timerEvent): 12039 (LayoutTestController::encodeHostName): 12040 (LayoutTestController::decodeHostName): 12041 (LayoutTestController::setJavaScriptProfilingEnabled): 12042 (LayoutTestController::setFixedContentsSize): 12043 (LayoutTestController::setPrivateBrowsingEnabled): 12044 (LayoutTestController::setPopupBlockingEnabled): 12045 (LayoutTestController::pauseAnimationAtTimeOnElementWithId): 12046 (LayoutTestController::pauseTransitionAtTimeOnElementWithId): 12047 (LayoutTestController::numberOfActiveAnimations): 12048 (LayoutTestController::disableImageLoading): 12049 (LayoutTestController::dispatchPendingLoadRequests): 12050 (LayoutTestController::setDatabaseQuota): 12051 (LayoutTestController::clearAllDatabases): 12052 (LayoutTestController::whiteListAccessFromOrigin): 12053 (LayoutTestController::waitForPolicyDelegate): 12054 (LayoutTestController::overridePreference): 12055 * DumpRenderTree/qt/LayoutTestControllerQt.h: Added. 12056 (LayoutTestController::isLoading): 12057 (LayoutTestController::setLoading): 12058 (LayoutTestController::shouldDumpAsText): 12059 (LayoutTestController::shouldDumpBackForwardList): 12060 (LayoutTestController::shouldDumpChildrenAsText): 12061 (LayoutTestController::shouldDumpDatabaseCallbacks): 12062 (LayoutTestController::shouldDumpStatusCallbacks): 12063 (LayoutTestController::shouldWaitUntilDone): 12064 (LayoutTestController::canOpenWindows): 12065 (LayoutTestController::shouldDumpTitleChanges): 12066 (LayoutTestController::waitForPolicy): 12067 (LayoutTestController::dumpAsText): 12068 (LayoutTestController::dumpChildFramesAsText): 12069 (LayoutTestController::dumpDatabaseCallbacks): 12070 (LayoutTestController::dumpStatusCallbacks): 12071 (LayoutTestController::setCanOpenWindows): 12072 (LayoutTestController::dumpBackForwardList): 12073 (LayoutTestController::setCloseRemainingWindowsWhenComplete): 12074 (LayoutTestController::display): 12075 (LayoutTestController::dumpTitleChanges): 12076 (LayoutTestController::dumpSelectionRect): 12077 * DumpRenderTree/qt/TextInputControllerQt.cpp: Added. 12078 (TextInputController::TextInputController): 12079 (TextInputController::doCommand): 12080 * DumpRenderTree/qt/TextInputControllerQt.h: Added. 12081 * DumpRenderTree/qt/WorkQueue.cpp: 12082 * DumpRenderTree/qt/WorkQueue.h: 12083 * DumpRenderTree/qt/WorkQueueItem.h: 12084 * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added. 12085 (findFrameNamed): 12086 (LoadItem::invoke): 12087 (ReloadItem::invoke): 12088 (ScriptItem::invoke): 12089 (BackForwardItem::invoke): 12090 * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files 12091 * DumpRenderTree/qt/jsobjects.h: 12092 120932009-10-13 Dmitry Titov <dimich@chromium.org> 12094 12095 Not reviewed, adding myself to the list of reviewers. 12096 12097 * Scripts/modules/committers.py: 12098 120992009-10-13 Anders Carlsson <andersca@apple.com> 12100 12101 Reviewed by Sam Weinig. 12102 12103 <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API 12104 12105 Make the private browsing mode testable by the test plug-in. 12106 12107 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 12108 (pluginGetProperty): 12109 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 12110 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 12111 (NPP_New): 12112 (NPP_SetValue): 12113 121142009-10-13 Pavel Feldman <pfeldman@chromium.org> 12115 12116 No review, just adding self to the list of reviewers. 12117 12118 * Scripts/modules/committers.py: 12119 121202009-10-12 Pavel Feldman <pfeldman@chromium.org> 12121 12122 Reviewed by Adam Roben. 12123 12124 Web Inspector: Use proper web view in inspector layout 12125 tests for windows. 12126 12127 https://bugs.webkit.org/show_bug.cgi?id=30298 12128 12129 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 12130 (LayoutTestController::showWebInspector): 12131 (LayoutTestController::closeWebInspector): 12132 (LayoutTestController::evaluateInWebInspector): 12133 121342009-10-12 Fumitoshi Ukai <ukai@chromium.org> 12135 12136 Reviewed by Sam Weinig. 12137 12138 Enable experimentalWebSocket in DumpRenderTree for LayoutTest. 12139 https://bugs.webkit.org/show_bug.cgi?id=29841 12140 12141 * DumpRenderTree/mac/DumpRenderTree.mm: 12142 (resetDefaultsToConsistentValues): 12143 * DumpRenderTree/win/DumpRenderTree.cpp: 12144 (resetDefaultsToConsistentValues): 12145 121462009-10-12 Yaar Schnitman <yaar@chromium.org> 12147 12148 Reviewed by Dimitri Glazkov. 12149 12150 Chromium Port - Windows 12151 https://bugs.webkit.org/show_bug.cgi?id=29969 12152 12153 * Scripts/pdevenv: removed msvc's /useenv for chromium builds 12154 * Scripts/webkitdirs.pm: 12155 121562009-10-12 Csaba Osztrogonac <ossy@webkit.org> 12157 12158 Reviewed by Darin Adler. 12159 12160 jsc scripts cleanup and Qt/GTK fix 12161 https://bugs.webkit.org/show_bug.cgi?id=30288 12162 12163 Duplicated jscPath() moved to webkitdirs.pm. 12164 New jscProductDir() added to webkitdirs.pm instead of duplicated codes. 12165 Configuration added (release/debug) to path for Qt-port on Windows. 12166 12167 * Scripts/run-javascriptcore-tests: 12168 * Scripts/run-jsc: 12169 * Scripts/run-sunspider: 12170 * Scripts/sunspider-compare-results: 12171 * Scripts/webkitdirs.pm: 12172 121732009-10-11 Adam Barth <abarth@webkit.org> 12174 12175 Unreviewed. Add Collin to committers.py. 12176 12177 * Scripts/modules/committers.py: 12178 121792009-10-11 Kevin Ollivier <kevino@theolliviers.com> 12180 12181 wx build fix, add bindings to source/include dirs now that there are sources there. 12182 12183 * wx/build/settings.py: 12184 121852009-10-09 Mark Rowe <mrowe@apple.com> 12186 12187 Reviewed by Brady Eidson. 12188 12189 Enable plug-in halting in DumpRenderTree. 12190 12191 We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins. 12192 This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs. 12193 12194 * DumpRenderTree/mac/DumpRenderTree.mm: 12195 (resetDefaultsToConsistentValues): 12196 * DumpRenderTree/mac/UIDelegate.mm: 12197 (-[UIDelegate webView:shouldHaltPlugin:]): 12198 121992009-10-08 Brady Eidson <beidson@apple.com> 12200 12201 Reviewed by Dan Bernstein. 12202 12203 Ask the History Delegate to populate the visited links hash. 12204 <rdar://problem/7285293> and https://webkit.org/b/29904 12205 12206 Add the ability for LayoutTestController to clear all visited links. 12207 Also lets the History Delegate dump visited links, but only if this test specifically cleared them. 12208 12209 * DumpRenderTree/LayoutTestController.cpp: 12210 (LayoutTestController::LayoutTestController): 12211 (removeAllVisitedLinksCallback): 12212 (LayoutTestController::staticFunctions): 12213 * DumpRenderTree/LayoutTestController.h: 12214 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 12215 (LayoutTestController::removeAllVisitedLinks): 12216 12217 * DumpRenderTree/mac/HistoryDelegate.mm: 12218 (-[HistoryDelegate populateVisitedLinksForWebView:]): 12219 12220 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 12221 (LayoutTestController::removeAllVisitedLinks): 12222 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 12223 (LayoutTestController::removeAllVisitedLinks): 12224 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 12225 (LayoutTestController::removeAllVisitedLinks): 12226 12227 122282009-10-08 Daniel Bates <dbates@webkit.org> 12229 12230 Reviewed by Adam Roben. 12231 12232 https://bugs.webkit.org/show_bug.cgi?id=30175 12233 12234 The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return 12235 the OLE drag-and-drop return value like the function it emulates. Currently, 12236 UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 12237 whether the drag-and-drop operation was successful or was cancelled. 12238 12239 This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 12240 return value according to whether the drop operation was successful or not. 12241 12242 * DumpRenderTree/win/EventSender.cpp: 12243 (doMouseUp): Added parameter oleDragAndDropReturnValue. 12244 (replaySavedEvents): Ditto. 12245 * DumpRenderTree/win/EventSender.h: 12246 * DumpRenderTree/win/UIDelegate.cpp: 12247 (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value. 12248 122492009-10-08 Alejandro G. Castro <alex@igalia.com> 12250 12251 Reviewed by Xan Lopez. 12252 12253 [GTK] Added support for a parameter setting the button that was 12254 pressed in the mouseDown function. 12255 https://bugs.webkit.org/show_bug.cgi?id=30220 12256 12257 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 12258 122592009-10-08 Alejandro G. Castro <alex@igalia.com> 12260 12261 Reviewed by Xan Lopez. 12262 12263 [GTK] Added a line to the bottom of the expected result to match 12264 the output of the test. 12265 https://bugs.webkit.org/show_bug.cgi?id=30220 12266 12267 * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste- 12268 expected.txt: 12269 122702009-10-08 Adam Roben <aroben@apple.com> 12271 12272 Use QueryInterface to get IWebInspectorPrivate 12273 12274 Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be 12275 accessed in a more standard way 12276 12277 Reviewed by John Sullivan and Tim Hatcher. 12278 12279 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 12280 (LayoutTestController::evaluateInWebInspector): Get the IWebInspector 12281 by calling IWebViewPrivate::inspector, then use QueryInterface to get 12282 to the IWebInspectorPrivate interface. 12283 122842009-10-07 Adam Roben <aroben@apple.com> 12285 12286 Implement DRT support for origin whitelisting 12287 12288 Fixes <http://webkit.org/b/30185>. 12289 12290 Reviewed by Eric Seidel. 12291 12292 * DumpRenderTree/win/DumpRenderTree.cpp: 12293 (resetWebViewToConsistentStateBeforeTesting): Reset any origin 12294 whitelist, to match Mac DRT. 12295 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 12296 (LayoutTestController::whiteListAccessFromOrigin): Call through to 12297 IWebViewPrivate::whiteListAccessFromOrigin. 12298 122992009-10-07 Brady Eidson <beidson@apple.com> 12300 12301 Reviewed by Darin Adler. 12302 12303 Send title changes to the global history delegate. 12304 <rdar://problem/7285293> and https://webkit.org/b/29904 12305 12306 * DumpRenderTree/mac/HistoryDelegate.mm: 12307 (-[HistoryDelegate webView:updateHistoryTitle:forURL:]): 12308 123092009-10-07 Adam Barth <abarth@webkit.org> 12310 12311 Unreviewed. Remove some folks from committers.py who were listed on 12312 the WebKit Team wiki page but who weren't actually listed as commit+. 12313 At some point, we should coorelate this list with the committers 12314 mailing list. 12315 12316 * Scripts/modules/committers.py: 12317 123182009-10-07 Adam Barth <abarth@webkit.org> 12319 12320 Unreviewed. Import a bunch of committers from the WebKit Team page on 12321 the wiki into committers.py. 12322 12323 * Scripts/modules/committers.py: 12324 123252009-10-07 Adam Barth <abarth@webkit.org> 12326 12327 Unreviewed. Added Aaron Boodman to committers.py. 12328 12329 * Scripts/modules/committers.py: 12330 123312009-10-07 Evan Martin <evan@chromium.org> 12332 12333 Reviewed by Darin Adler. 12334 12335 Add API to LayoutTestController for re/setting the system locale. 12336 https://bugs.webkit.org/show_bug.cgi?id=18994 12337 12338 * DumpRenderTree/LayoutTestController.cpp: 12339 (setLocaleCallback): 12340 (LayoutTestController::staticFunctions): 12341 (LayoutTestController::setLocale): 12342 * DumpRenderTree/LayoutTestController.h: 12343 123442009-10-06 Shinichiro Hamaji <hamaji@chromium.org> 12345 12346 Reviewed by Jan Alonzo. 12347 12348 [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts 12349 https://bugs.webkit.org/show_bug.cgi?id=29689 12350 12351 Build fix by adding -lfontconfig for DumpRenderTree. 12352 12353 * GNUmakefile.am: 12354 123552009-10-07 Csaba Osztrogonac <oszi@inf.u-szeged.hu> 12356 12357 Reviewed by Simon Hausmann. 12358 12359 Re-enable use-remote-links-to-tests for Qt. Disabled in r46416. 12360 12361 * Scripts/run-webkit-tests: 12362 123632009-10-07 Xan Lopez <xlopez@igalia.com> 12364 12365 Reviewed by Gustavo Noronha. 12366 12367 "delete" in EventSender is the backspace key, not the delete one. 12368 12369 * DumpRenderTree/gtk/EventSender.cpp: 12370 (keyDownCallback): 12371 123722009-10-07 Xan Lopez <xlopez@igalia.com> 12373 12374 Reviewed by Gustavo Noronha. 12375 12376 getChildrenWithRange expects as last parameter the end index, not 12377 the length of the range. Correct this and clarify the variable 12378 names to reflect how the code works. 12379 12380 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 12381 (AccessibilityUIElement::getChildrenWithRange): 12382 (AccessibilityUIElement::getChildAtIndex): 12383 123842009-10-06 Mark Rowe <mrowe@apple.com> 12385 12386 Reviewed by Simon Fraser. 12387 12388 <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH 12389 12390 * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the 12391 the fact we have already changed the working directory to the top of the open source tree. 12392 123932009-10-06 Julie Parent <jparent@chromium.org> 12394 12395 Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email, 12396 rather than my committer email. 12397 12398 * Scripts/modules/committers.py: 12399 124002009-10-06 Jakub Wieczorek <faw217@gmail.com> 12401 12402 Reviewed by Eric Seidel. 12403 12404 [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset(). 12405 12406 r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset 12407 it after each layout test as it should do, making the DRT dump additional output 12408 for all of the subsequent layout tests. 12409 12410 * DumpRenderTree/qt/jsobjects.cpp: 12411 (LayoutTestController::reset): 12412 124132009-10-06 Jakub Wieczorek <faw217@gmail.com> 12414 12415 Reviewed by Simon Hausmann. 12416 12417 [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the 12418 fast/dom/assign-to-window-status.html test, which is passing as a result. 12419 12420 https://bugs.webkit.org/show_bug.cgi?id=30127 12421 12422 * DumpRenderTree/qt/DumpRenderTree.cpp: 12423 (WebCore::DumpRenderTree::DumpRenderTree): 12424 (WebCore::DumpRenderTree::statusBarMessage): 12425 * DumpRenderTree/qt/DumpRenderTree.h: 12426 * DumpRenderTree/qt/jsobjects.h: 12427 (LayoutTestController::shouldDumpStatusCallbacks): 12428 (LayoutTestController::dumpStatusCallbacks): 12429 124302009-10-06 Jakub Wieczorek <faw217@gmail.com> 12431 12432 Reviewed by Simon Hausmann. 12433 12434 [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown() 12435 ignores the argument indicating which mouse button to trigger. 12436 https://bugs.webkit.org/show_bug.cgi?id=30048 12437 12438 This affects the fast/events/mouse-click-events.html layout test. 12439 12440 * DumpRenderTree/qt/jsobjects.cpp: 12441 (EventSender::mouseDown): 12442 (EventSender::mouseUp): 12443 * DumpRenderTree/qt/jsobjects.h: 12444 124452009-10-06 Jakub Wieczorek <faw217@gmail.com> 12446 12447 Reviewed by Simon Hausmann. 12448 12449 [Qt] Fix the EventSender::keyDown() implementation 12450 https://bugs.webkit.org/show_bug.cgi?id=30043 12451 12452 It should post both a key press event and a key release event, 12453 just like other ports do. 12454 12455 * DumpRenderTree/qt/jsobjects.cpp: 12456 (EventSender::keyDown): 12457 124582009-10-05 Kevin Ollivier <kevino@theolliviers.com> 12459 12460 wx build fix. Add jpeg to the list of libs to link against. 12461 12462 * wx/build/settings.py: 12463 124642009-10-05 Jakub Wieczorek <faw217@gmail.com> 12465 12466 Reviewed by Simon Hausmann. 12467 12468 [Qt] EventSender::keyDown() cannot send function-key events. 12469 https://bugs.webkit.org/show_bug.cgi?id=30044 12470 12471 This affects the fast/events/keydown-function-keys.html layout test. 12472 12473 * DumpRenderTree/qt/jsobjects.cpp: 12474 (EventSender::keyDown): 12475 124762009-10-05 Vadim Zeitlin <vadim@wxwidgets.org> 12477 12478 Added --wx-compiler-prefix waf option to allow building wxWebKit with 12479 wxWidgets built using "nmake COMPILER_PREFIX=something-non-default". 12480 12481 * wx/build/settings.py: 12482 * wx/build/wxpresets.py: 12483 124842009-10-05 Pavel Feldman <pfeldman@chromium.org> 12485 12486 Reviewed by Timothy Hatcher. 12487 12488 Web Inspector: add testing harness for Web Inspector. 12489 12490 https://bugs.webkit.org/show_bug.cgi?id=30010 12491 12492 * DumpRenderTree/LayoutTestController.cpp: 12493 (showWebInspectorCallback): 12494 (closeWebInspectorCallback): 12495 (evaluateInWebInspectorCallback): 12496 (LayoutTestController::staticFunctions): 12497 * DumpRenderTree/LayoutTestController.h: 12498 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 12499 (LayoutTestController::showWebInspector): 12500 (LayoutTestController::closeWebInspector): 12501 (LayoutTestController::evaluateInWebInspector): 12502 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 12503 (LayoutTestController::showWebInspector): 12504 (LayoutTestController::closeWebInspector): 12505 (LayoutTestController::evaluateInWebInspector): 12506 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 12507 (LayoutTestController::showWebInspector): 12508 (LayoutTestController::closeWebInspector): 12509 (LayoutTestController::evaluateInWebInspector): 12510 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 12511 (LayoutTestController::showWebInspector): 12512 (LayoutTestController::closeWebInspector): 12513 (LayoutTestController::evaluateInWebInspector): 12514 125152009-10-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 12516 12517 Reviewed by Ariyha Hidayat. 12518 12519 Pass arguments to system() as a string instead of array 12520 12521 When passed as an array entries with a space fail to translate 12522 to two arguments to the child process, so instead of manually 12523 splitting all the entries in @buildArgs we pass the whole thing 12524 as a string instead. 12525 12526 * Scripts/webkitdirs.pm: 12527 125282009-10-04 Carol Szabo <carol.szabo@nokia.com> 12529 12530 Reviewed by David Levin. 12531 12532 check-webkit-style misses whitespace errors for operators: 12533 <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||. 12534 https://bugs.webkit.org/show_bug.cgi?id=30021 12535 12536 * Scripts/modules/cpp_style.py: 12537 Added the operators mentioned above to the same list as == and !=. 12538 125392009-10-02 Julie Parent <jparent@chromium.org> 12540 12541 Unreviewed. 12542 12543 Adding myself and Ojan Vafai as committers, because we are committers. 12544 12545 * Scripts/modules/committers.py: 12546 125472009-10-02 Brian Weinstein <bweinstein@apple.com> 12548 12549 Reviewed by Adam Roben. 12550 12551 svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff, 12552 this will help the patch merging process when TryBots are used. 12553 12554 * Scripts/svn-create-patch: 12555 125562009-10-02 Jakub Wieczorek <faw217@gmail.com> 12557 12558 Reviewed by Simon Hausmann. 12559 12560 [Qt] Implement layoutTestController.overridePreference(). 12561 https://bugs.webkit.org/show_bug.cgi?id=29970 12562 12563 * DumpRenderTree/qt/DumpRenderTree.cpp: 12564 (WebCore::WebPage::WebPage): 12565 (WebCore::WebPage::resetSettings): 12566 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 12567 * DumpRenderTree/qt/jsobjects.cpp: 12568 (LayoutTestController::reset): 12569 (LayoutTestController::setPrivateBrowsingEnabled): 12570 (LayoutTestController::setPopupBlockingEnabled): 12571 (LayoutTestController::overridePreference): 12572 * DumpRenderTree/qt/jsobjects.h: 12573 125742009-10-01 Chris Marrin <cmarrin@apple.com> 12575 12576 Reviewed by Oliver Hunt. 12577 12578 Turn on ENABLE_3D_CANVAS in TOT 12579 https://bugs.webkit.org/show_bug.cgi?id=29906 12580 12581 * Scripts/build-webkit: 12582 125832009-10-01 Kenneth Rohde Christiansen <kenneth@webkit.org> 12584 12585 Rubberstamped by Simon Hausmann. 12586 12587 Enable HTTP tests for Qt 12588 12589 * Scripts/run-webkit-tests: 12590 125912009-10-01 Yaar Schnitman <yaar@chromium.org> 12592 12593 Reviewed by Dimitri Glazkov. 12594 12595 build-webkit --chromium now also works on cygwin. 12596 12597 https://bugs.webkit.org/show_bug.cgi?id=29973 12598 12599 * Scripts/webkitdirs.pm: 12600 126012009-10-01 Zoltan Horvath <zoltan@webkit.org> 12602 12603 Reviewed by Simon Hausmann. 12604 12605 [Qt] Don't use TCmalloc in DumpRenderTree 12606 https://bugs.webkit.org/show_bug.cgi?id=27029 12607 12608 Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT. 12609 12610 * DumpRenderTree/qt/DumpRenderTree.pro: 12611 126122009-10-01 Jakub Wieczorek <faw217@gmail.com> 12613 12614 Reviewed by Simon Hausmann. 12615 12616 [Qt] Implement eventSender.scheduleAsynchronousClick(). 12617 12618 https://bugs.webkit.org/show_bug.cgi?id=29931 12619 12620 * DumpRenderTree/qt/jsobjects.cpp: 12621 (EventSender::scheduleAsynchronousClick): 12622 * DumpRenderTree/qt/jsobjects.h: 12623 126242009-10-01 Jakub Wieczorek <faw217@gmail.com> 12625 12626 Reviewed by Simon Hausmann. 12627 12628 [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove 12629 fast/events/open-window-from-another-frame.html from the Skipped list. 12630 12631 https://bugs.webkit.org/show_bug.cgi?id=29930 12632 12633 * DumpRenderTree/qt/jsobjects.cpp: 12634 (LayoutTestController::setPopupBlockingEnabled): 12635 * DumpRenderTree/qt/jsobjects.h: 12636 126372009-09-30 Cameron McCormack <cam@mcc.id.au> 12638 12639 Unreviewed. 12640 12641 Added myself to the list of committers. 12642 12643 * Scripts/modules/committers.py: 12644 126452009-09-30 Eric Seidel <eric@webkit.org> 12646 12647 No review, just adding Geoff to the list of reviewers. 12648 12649 * Scripts/modules/committers.py: 12650 126512009-09-30 Dan Bernstein <mitz@apple.com> 12652 12653 Reviewed by Sam Weinig. 12654 12655 Added the WebKit Layout Tests fonts that are referenced in 12656 LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css 12657 12658 * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added. 12659 * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added. 12660 126612009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu> 12662 12663 Reviewed by David Kilzer. 12664 12665 Make sunspider scripts work on Windows platform. 12666 https://bugs.webkit.org/show_bug.cgi?id=29656 12667 12668 * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter. 12669 * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter. 12670 * Scripts/webkitdirs.pm: currentPerlPath() added. 12671 126722009-09-29 Brady Eidson <beidson@apple.com> 12673 12674 Rubberstamped by Dan Bernstein. 12675 12676 Fix license and some sorting in new files. 12677 12678 * DumpRenderTree/mac/HistoryDelegate.h: 12679 * DumpRenderTree/mac/HistoryDelegate.mm: 12680 126812009-09-29 Yaar Schnitman <yaar@chromium.org> 12682 12683 Reviewed by David Kilzer. 12684 12685 Fixed how error codes are handled. 12686 https://bugs.webkit.org/show_bug.cgi?id=29898 12687 12688 * Scripts/update-webkit: 12689 * Scripts/update-webkit-chromium: 12690 126912009-09-29 Brady Eidson <beidson@apple.com> 12692 12693 Reviewed by John Sullivan. 12694 12695 Updated way-out-of-date sorting throughout the dump methods/flags. 12696 12697 * DumpRenderTree/LayoutTestController.cpp: 12698 (LayoutTestController::LayoutTestController): 12699 (dumpAsPDFCallback): 12700 (dumpAsTextCallback): 12701 (dumpFrameLoadCallbacksCallback): 12702 (dumpResourceLoadCallbacksCallback): 12703 (LayoutTestController::staticFunctions): 12704 12705 * DumpRenderTree/LayoutTestController.h: 12706 (LayoutTestController::dumpAsText): 12707 (LayoutTestController::setDumpAsText): 12708 (LayoutTestController::dumpFrameLoadCallbacks): 12709 (LayoutTestController::setDumpFrameLoadCallbacks): 12710 (LayoutTestController::dumpSelectionRect): 12711 (LayoutTestController::setDumpSelectionRect): 12712 (LayoutTestController::dumpSourceAsWebArchive): 12713 (LayoutTestController::setDumpSourceAsWebArchive): 12714 (LayoutTestController::dumpStatusCallbacks): 12715 (LayoutTestController::setDumpStatusCallbacks): 12716 (LayoutTestController::dumpTitleChanges): 12717 (LayoutTestController::setDumpTitleChanges): 12718 (LayoutTestController::dumpWillCacheResponse): 12719 (LayoutTestController::setDumpWillCacheResponse): 12720 127212009-09-29 Brady Eidson <beidson@apple.com> 12722 12723 Reviewed by John Sullivan. 12724 12725 WebKit Mac API should provide a delegate interface for global history. 12726 <rdar://problem/7042773> and https://webkit.org/b/29904 12727 12728 Adding the dumping of global history delegate callbacks. 12729 12730 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 12731 12732 Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL: 12733 * DumpRenderTree/mac/DumpRenderTree.mm: 12734 (createWebViewAndOffscreenWindow): 12735 (allocateGlobalControllers): 12736 (shouldLogFrameLoadDelegates): 12737 (shouldLogHistoryDelegates): 12738 (runTest): 12739 12740 Dump history delegate callbacks: 12741 * DumpRenderTree/mac/HistoryDelegate.h: Added. 12742 * DumpRenderTree/mac/HistoryDelegate.mm: Added. 12743 (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]): 12744 (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]): 12745 (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]): 12746 127472009-09-29 Daniel Bates <dbates@webkit.org> 12748 12749 Reviewed by Adam Roben. 12750 12751 https://bugs.webkit.org/show_bug.cgi?id=28902 12752 12753 Fixes an issue where the drop effect returned by Window Dump Render Tree 12754 was always DROPEFFECT_NONE (since it was hard coded to do so). 12755 12756 This patch corrects this issue by determining the actual drop effect 12757 performed by the corresponding drag-and-drop operation so that we can 12758 return it. 12759 12760 * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect. 12761 (DraggingInfo::DraggingInfo): 12762 (DraggingInfo::performedDropEffect): Added method. 12763 (DraggingInfo::setPerformedDropEffect): Added method. 12764 * DumpRenderTree/win/EventSender.cpp: 12765 (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect. 12766 Moved delete draggingInfo to UIDelegate::doDragDrop. 12767 * DumpRenderTree/win/UIDelegate.cpp: 12768 (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect(). 12769 127702009-09-29 Dan Bernstein <mitz@apple.com> 12771 12772 Reviewed by Adam Roben. 12773 12774 Remove copying of unnecessary or nonexistent files from the ImageDiff 12775 post-build event. 12776 12777 * DumpRenderTree/win/ImageDiff.vcproj: 12778 127792009-09-29 Csaba Osztrogonac <oszi@inf.u-szeged.hu> 12780 12781 Reviewed by David Kilzer. 12782 12783 [Qt] Make build-webkit script work on Windows 12784 https://bugs.webkit.org/show_bug.cgi?id=29802 12785 12786 * Scripts/run-webkit-tests: 12787 * Scripts/webkitdirs.pm: 12788 - Removed unnecessary -p switch for mkdir on Windows. 12789 - Use canonical path, which uses slashes or backslashes depends on platform. 12790 - isWindows() only test for Windows and not for Cyqwin. 12791 127922009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu> 12793 12794 Reviewed by Simon Hausmann. 12795 12796 Fix time measurement in build-webkit after refactoring done in r48853. 12797 12798 * Scripts/build-webkit: 12799 128002009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu> 12801 12802 Reviewed by Tor Arne Vestbø. 12803 12804 [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard. 12805 This fixes https://bugs.webkit.org/show_bug.cgi?id=19674. 12806 12807 * DumpRenderTree/qt/DumpRenderTree.cpp: 12808 (WebCore::WebPage::WebPage): 12809 128102009-09-29 Jakub Wieczorek <faw217@gmail.com> 12811 12812 Reviewed by Simon Hausmann. 12813 12814 [Qt] Implement eventSender.contextClick(). 12815 https://bugs.webkit.org/show_bug.cgi?id=29821 12816 12817 * DumpRenderTree/qt/jsobjects.cpp: 12818 (EventSender::contextClick): 12819 * DumpRenderTree/qt/jsobjects.h: 12820 128212009-09-28 Fumitoshi Ukai <ukai@chromium.org> 12822 12823 Reviewed by Eric Seidel. 12824 12825 Add experimentalWebSocketsEnabled in WebPreferences. 12826 https://bugs.webkit.org/show_bug.cgi?id=28941 12827 12828 * DumpRenderTree/mac/DumpRenderTree.mm: 12829 (resetDefaultsToConsistentValues): 12830 * DumpRenderTree/win/DumpRenderTree.cpp: 12831 (resetDefaultsToConsistentValues): 12832 128332009-09-28 Yaar Schnitman <yaar@chromium.org> 12834 12835 Reviewed by David Kilzer. 12836 12837 Integrated chromium port building into webkit tools update-webkit and 12838 build-webkit. 12839 12840 https://bugs.webkit.org/show_bug.cgi?id=29749 12841 12842 * Scripts/build-webkit: When --chromium is specified, will build 12843 the chromium port (currently only Mac is supported). 12844 * Scripts/update-webkit: When --chromium is specified, delegates to 12845 update-webkit-chromium. 12846 * Scripts/webkitdirs.pm: Added chromium specific defs. 12847 * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch 12848 chromium port's dependencies and update its project files. 12849 128502009-09-28 Fumitoshi Ukai <ukai@chromium.org> 12851 12852 Unreviewed. 12853 12854 Add myself to list of committers. 12855 12856 * Scripts/modules/committers.py: 12857 128582009-09-27 Jakub Wieczorek <faw217@gmail.com> 12859 12860 Reviewed by Darin Adler. 12861 12862 run-webkit-tests: Do not strip the metrics when there is no expected result for a test. 12863 https://bugs.webkit.org/show_bug.cgi?id=29771 12864 12865 * Scripts/run-webkit-tests: 12866 128672009-09-27 Jakub Wieczorek <faw217@gmail.com> 12868 12869 Reviewed by Simon Hausmann. 12870 12871 [Qt] Implement layoutTestController.waitForPolicyDelegate. 12872 https://bugs.webkit.org/show_bug.cgi?id=25037 12873 12874 * DumpRenderTree/qt/DumpRenderTree.cpp: 12875 (WebCore::WebPage::acceptNavigationRequest): 12876 * DumpRenderTree/qt/DumpRenderTree.pro: 12877 * DumpRenderTree/qt/jsobjects.cpp: 12878 (LayoutTestController::reset): 12879 (LayoutTestController::notifyDone): 12880 (LayoutTestController::waitForPolicyDelegate): 12881 * DumpRenderTree/qt/jsobjects.h: 12882 (LayoutTestController::waitForPolicy): 12883 128842009-09-26 David Kilzer <ddkilzer@apple.com> 12885 12886 <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch 12887 12888 Reviewed by Eric Seidel. 12889 12890 The -o|--open switch uses the open(1) command on Mac OS X to 12891 open the bug URL in the default web browser. If there are 12892 similar mechanisms on other platforms, they may be added later. 12893 12894 * Scripts/mark-bug-fixed: 12895 (MarkBugFixed.__init__): Added -o|--open switch to list of parse 12896 options. 12897 (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging 12898 code into main() and extracted prompting code into 12899 _prompt_user_for_correctness(). 12900 (MarkBugFixed._open_bug_in_web_browser): Added. 12901 (MarkBugFixed._prompt_user_for_correctness): Added. 12902 (MarkBugFixed.main): Added logging code from 12903 _determine_bug_id_and_svn_revision(). Added code to call 12904 _open_bug_in_web_browser() if the switch is set. Added code to 12905 call _prompt_user_for_correctness() when needed. 12906 * Scripts/modules/bugzilla.py: 12907 (Bugzilla.short_bug_url_for_bug_id): Added. 12908 129092009-09-26 David Kilzer <ddkilzer@apple.com> 12910 12911 svn-unapply and svn-apply don't work when used outside multiple svn working directories 12912 12913 <http://webkit.org/b/29744> 12914 <rdar://problem/7252905> 12915 12916 Reviewed by Eric Seidel. 12917 12918 Some users have a workflow where svn-create-patch, svn-apply and 12919 svn-unapply are used outside of multiple svn working 12920 directories. Instead of aborting the scripts in these cases, 12921 print a warning and assume that Subversion is being used. 12922 12923 * Scripts/VCSUtils.pm: 12924 (determineVCSRoot): Call warn() instead of die() if both isGit() 12925 and isSVN() initially return false. Set $VCSUtils::isSVN to 1 12926 to enforce the assumption about Subversion, then return 12927 determineSVNRoot(). 12928 * Scripts/svn-apply: Switch to using isGit() and isSVN() from 12929 VCSUtils.pm. They both already cache their values and checking 12930 here is redundant since determineVCSRoot() is called later. 12931 129322009-09-26 Zan Dobersek <zandobersek@gmail.com> 12933 12934 Reviewed by Gustavo Noronha. 12935 12936 [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts 12937 https://bugs.webkit.org/show_bug.cgi?id=29689 12938 12939 Load test fonts through FontConfig before each test. 12940 This ensures a more proper rendering of the tests. 12941 12942 * DumpRenderTree/gtk/DumpRenderTree.cpp: 12943 (initializeFonts): 12944 (runTest): 12945 (main): 12946 * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf. 12947 * GNUmakefile.am: 12948 129492009-09-25 David Kilzer <ddkilzer@apple.com> 12950 12951 <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch 12952 12953 Reviewed by Eric Seidel. 12954 12955 * Scripts/mark-bug-fixed: 12956 (MarkBugFixed.__init__): Added -u|--update-only switch to list 12957 of parse options. 12958 (MarkBugFixed.main): When -u|--update-only is specified, add a 12959 comment to the bug without marking it Resolved/Fixed. 12960 129612009-09-25 Darin Adler <darin@apple.com> 12962 12963 Reviewed by Geoffrey Garen. 12964 12965 * Scripts/prepare-ChangeLog: Leave files from the script-tests directory 12966 out, just as we do for the resources directory. 12967 129682009-09-25 Adam Barth <abarth@webkit.org> 12969 12970 Unreviewed. Added Tony to committers.py because he's a 12971 committer now. 12972 12973 * Scripts/modules/committers.py: 12974 129752009-09-25 Eric Seidel <eric@webkit.org> 12976 12977 Reviewed by Simon Fraser. 12978 12979 REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots 12980 https://bugs.webkit.org/show_bug.cgi?id=28624 12981 12982 Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older. 12983 12984 * DumpRenderTree/mac/DumpRenderTree.mm: 12985 (resetDefaultsToConsistentValues): 12986 129872009-09-25 Eric Seidel <eric@webkit.org> 12988 12989 Reviewed by Adam Barth. 12990 12991 commit-queue should auto-retry patches which fail to commit due to out of date files 12992 https://bugs.webkit.org/show_bug.cgi?id=28316 12993 12994 * Scripts/bugzilla-tool: 12995 - Handle new CheckoutNeedsUpdate exception. 12996 * Scripts/modules/logging_unittest.py: 12997 - Call the ScriptError constructor correctly (this test had regressed). 12998 * Scripts/modules/scm.py: 12999 - Added the ability to define custom error handlers for run_command 13000 and added a commit_error_handler which throws CheckoutNeedsUpdate 13001 instead of ScriptError. 13002 - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible. 13003 * Scripts/modules/scm_unittest.py: 13004 - Added tests of new error handlers. 13005 130062009-09-25 Eric Seidel <eric@webkit.org> 13007 13008 Reviewed by Adam Barth. 13009 13010 commit-queue should give better feedback when failing a patch 13011 https://bugs.webkit.org/show_bug.cgi?id=29316 13012 13013 * Scripts/bugzilla-tool: 13014 - Update ScriptError uses to the new constructor format. 13015 - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output 13016 so that we can print to both stdout as well as an output buffer for error reporting. 13017 - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError. 13018 - Use e.message_with_output() when failing a patch (this is the real fix here). 13019 I also removed use of "This patch will require manual commit." as that's not always true. 13020 - Add missing word "bug" from log message. 13021 * Scripts/modules/scm.py: 13022 - Make ScriptError save a bunch more data so that error messages can be nicer. 13023 - Update ScriptError callers. 13024 130252009-09-24 John Gregg <johnnyg@google.com> 13026 13027 Reviewed by Eric Seidel. 13028 13029 Enable switch for notifications (experimental) in Page Settings 13030 https://bugs.webkit.org/show_bug.cgi?id=28930 13031 13032 Now that desktop notifications are controlled by run-time switch, 13033 set that switch to true for DumpRenderTree. 13034 13035 * DumpRenderTree/mac/DumpRenderTree.mm: 13036 (resetDefaultsToConsistentValues): 13037 * DumpRenderTree/win/DumpRenderTree.cpp: 13038 (resetDefaultsToConsistentValues): 13039 * DumpRenderTree/win/UIDelegate.cpp: 13040 (UIDelegate::QueryInterface): 13041 130422009-09-24 Kevin Ollivier <kevino@theolliviers.com> 13043 13044 wx build fix. SnowLeopard fixes for Mac dependencies. 13045 13046 * wx/build/build_utils.py: 13047 * wx/build/settings.py: 13048 * wx/install-unix-extras: 13049 130502009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 13051 13052 Reviewed by Oliver Hunt. 13053 13054 Add support for DRT to send mouse wheel events. 13055 13056 https://bugs.webkit.org/show_bug.cgi?id=29348 13057 [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally 13058 13059 * DumpRenderTree/gtk/EventSender.cpp: 13060 (mouseWheelToCallback): 13061 130622009-09-17 Eric Seidel <eric@webkit.org> 13063 13064 Reviewed by David Levin. 13065 13066 commit-queue needs web-based status reporting 13067 https://bugs.webkit.org/show_bug.cgi?id=29307 13068 13069 Add a first-pass web-based status for the commit-queue. 13070 The bot is currently reachable at: 13071 http://webkit-commit-queue.appspot.com/ 13072 13073 * CommitQueueStatus/app.yaml: Added. 13074 - Application description file required by App Engine. 13075 * CommitQueueStatus/filters/__init__.py: Added. 13076 - Required by python to treat 'filters' as a module. 13077 * CommitQueueStatus/filters/webkit_extras.py: Added. 13078 - Support for turning 'bug 123' and 'patch 123' into links. 13079 This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page). 13080 * CommitQueueStatus/index.html: Added. 13081 * CommitQueueStatus/index.yaml: Added. 13082 - Some auto-generated file from app engine. 13083 * CommitQueueStatus/queue_status.py: Added. 13084 - The core logic of this bot. We could eventually split this file out into pieces. 13085 * CommitQueueStatus/stylesheets/main.css: Added. 13086 - Some basic lame-o CSS to make the page look less awful. 13087 * CommitQueueStatus/update_status.html: Added. 13088 - The form that the commit-queue (or a human) can use to update the status. 13089 * Scripts/bugzilla-tool: 13090 - Add some very basic update_status calls. 13091 * Scripts/modules/statusbot.py: Added. 13092 - Knows how to post to the CommitQueueStatus web application. 13093 130942009-09-24 David Kilzer <ddkilzer@apple.com> 13095 13096 <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch 13097 13098 Reviewed by Adam Roben. 13099 13100 * Scripts/mark-bug-fixed: 13101 (MarkBugFixed.__init__): Added -m|--comment switch to list of 13102 parse options. 13103 (MarkBugFixed.main): When specified, prepend comment from 13104 -m|--comment command-line switch to the bug comment. 13105 131062009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 13107 13108 Reviewed by Jan Alonzo. 13109 13110 [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly 13111 https://bugs.webkit.org/show_bug.cgi?id=29693 13112 13113 Show the window, to be able to synthesize events correctly. 13114 13115 * DumpRenderTree/gtk/DumpRenderTree.cpp: 13116 (runTest): 13117 (main): 13118 131192009-09-24 Oliver Hunt <oliver@apple.com> 13120 13121 Reviewed by NOBODY(rollout) 13122 13123 Roll out r48712 as it is incorrect. 13124 13125 * DumpRenderTree/mac/ObjCController.m: 13126 (+[ObjCController isSelectorExcludedFromWebScript:]): 13127 (+[ObjCController webScriptNameForSelector:]): 13128 131292009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com> 13130 13131 Reviewed by Eric Seidel. 13132 13133 https://bugs.webkit.org/show_bug.cgi?id=29005 13134 The indices of RuntimeArray should be enumerated like for a regular array. 13135 13136 * DumpRenderTree/mac/ObjCController.m: 13137 (+[ObjCController isSelectorExcludedFromWebScript:]): 13138 (+[ObjCController webScriptNameForSelector:]): 13139 (-[ObjCController arrayOfString]): 13140 131412009-09-23 David Kilzer <ddkilzer@apple.com> 13142 13143 <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool 13144 13145 Reviewed by Darin Adler. 13146 13147 Also fixed a bug where specifying a revision on the command-line 13148 as 'r12345' would fail. See <http://webkit.org/b/29699>. 13149 13150 * Scripts/bugzilla-tool: Updated module import statements. 13151 (parse_bug_id): Removed. Moved to bugzilla.py. 13152 (bug_comment_from_svn_revision): Removed. Moved to comments.py. 13153 (bug_comment_from_commit_text): Removed. Moved to comments.py. 13154 (MarkBugFixed): Removed. Code moved to mark-bug-fixed. 13155 (BugzillaTool.__init__): Removed mark-fixed subcommand. 13156 * Scripts/mark-bug-fixed: Added. 13157 * Scripts/modules/bugzilla.py: 13158 (parse_bug_id): Added. Moved from bugzilla-tool. 13159 * Scripts/modules/comments.py: Added. 13160 (bug_comment_from_svn_revision): Added. Moved from bugzilla-tool. 13161 (bug_comment_from_commit_text): Added. Moved from bugzilla-tool. 13162 131632009-09-23 Marshall Culpepper <mculpepper@appcelerator.com> 13164 13165 Reviewed by Eric Seidel. 13166 13167 jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return 13168 "false" in non-implemented stub for setAlwaysAcceptCookies. 13169 https://bugs.webkit.org/show_bug.cgi?id=29661 13170 13171 * DumpRenderTree/win/DumpRenderTree.vcproj: 13172 * DumpRenderTree/win/DumpRenderTree.cpp: 13173 131742009-09-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 13175 13176 Reviewed by Xan Lopez. 13177 13178 [GTK] need to dump number of pending unload handlers 13179 https://bugs.webkit.org/show_bug.cgi?id=29685 13180 13181 Implement dumping of the number of pending unload handlers. 13182 13183 The following tests will pass: 13184 13185 fast/loader/unload-form-about-blank.html 13186 fast/loader/unload-form-post-about-blank.html 13187 fast/loader/unload-form-post.html 13188 fast/loader/unload-form.html 13189 fast/loader/unload-hyperlink.html 13190 fast/loader/unload-javascript-url.html 13191 fast/loader/unload-reload.html 13192 fast/loader/unload-window-location.html 13193 13194 * DumpRenderTree/gtk/DumpRenderTree.cpp: 13195 (getFrameNameSuitableForTestResult): 13196 (webViewLoadFinished): 13197 131982009-09-22 Shinichiro Hamaji <hamaji@chromium.org> 13199 13200 Reviewed by Eric Seidel. 13201 13202 js tests should move into jstests subdirectory instead of resources/ 13203 https://bugs.webkit.org/show_bug.cgi?id=25880 13204 13205 Remove support of resources directory. 13206 13207 * Scripts/make-script-test-wrappers: 13208 132092009-09-22 Eric Seidel <eric@webkit.org> 13210 13211 No review, only fixing typo (missing space character). 13212 13213 Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220 13214 13215 * Scripts/run-webkit-tests: 13216 132172009-09-22 Eric Seidel <eric@webkit.org> 13218 13219 Reviewed by Darin Adler. 13220 13221 run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC) 13222 https://bugs.webkit.org/show_bug.cgi?id=29220 13223 13224 * Scripts/run-webkit-tests: 13225 132262009-09-22 Eric Seidel <eric@webkit.org> 13227 13228 Reviewed by David Kilzer. 13229 13230 svn-apply can't handle single-line binary file additions 13231 https://bugs.webkit.org/show_bug.cgi?id=29100 13232 13233 Fixed the regexp and added a unit test. 13234 13235 * Scripts/modules/scm_unittest.py: 13236 * Scripts/svn-apply: 13237 132382009-09-11 Eric Seidel <eric@webkit.org> 13239 13240 Reviewed by David Kilzer. 13241 13242 post-diff and post-commits should be able to find bug urls in ChangeLogs. 13243 https://bugs.webkit.org/show_bug.cgi?id=29206 13244 13245 * Scripts/bugzilla-tool: 13246 - Share common options by adding a PostDiffAsPatchToBug.posting_options() method. 13247 - Rename --no-comment to --add-log-as-comment and reverse behavior. 13248 Comments tend to just be noise. I'll eventually remove this argument if no one uses it. 13249 - Split out code into helper functions to try and make execute() more legible. 13250 - Make post-diff find the bug url in the ChangeLogs if not passed as an argument. 13251 - Fallback to bug urls in commit diffs, instead of just in commit messages, 13252 meaning post-commits will now find bug urls in ChangeLogs. 13253 132542009-09-21 Csaba Osztrogonac <oszi@inf.u-szeged.hu> 13255 13256 Reviewed by Maciej Stachowiak. 13257 13258 --parse-only parameter wasn't passed to SunSpider/sunspider script. 13259 https://bugs.webkit.org/show_bug.cgi?id=29611 13260 13261 * Scripts/run-sunspider: Missing parameter passing added. 13262 132632009-09-20 David Kilzer <ddkilzer@apple.com> 13264 13265 <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module 13266 13267 Reviewed by Mark Rowe. 13268 13269 The require statement is like the use statement, except that it 13270 is run during script execution instead of during the 'BEGIN' 13271 phase. This makes it possible to change @INC before the require 13272 statement is run. See 'require' and 'use' in the perlfunc(1) 13273 manpage and 'BEGIN' in perlmod(1) manpage. 13274 13275 * Scripts/run-webkit-tests: Replace eval statement with require 13276 statement. 13277 132782009-09-18 Kevin Ollivier <kevino@theolliviers.com> 13279 13280 wx build fixes. Fix the config name under git and allow users to specify 13281 their own waf install for experimenting with new versions. 13282 13283 * Scripts/webkitdirs.pm: 13284 * wx/build/settings.py: 13285 132862009-09-18 Alex Milowski <alex@milowski.com> 13287 13288 Reviewed by Maciej Stachowiak. 13289 13290 Added checkWebCoreMathMLSupport and hasMathMLSupport to support 13291 checking for whether MathML tests should be run 13292 13293 * Scripts/run-webkit-tests: 13294 * Scripts/webkitdirs.pm: 13295 132962009-08-28 Darin Adler <darin@apple.com> 13297 13298 Reviewed by Mark Rowe. 13299 13300 Break more of run-webkit-tests into separate functions 13301 https://bugs.webkit.org/show_bug.cgi?id=29497 13302 13303 Some small steps toward improving run-webkit-tests. My goal is to 13304 refactor much more of the script into functions. Later we can add 13305 parallel test running to the tool. But better structure may help 13306 even if someone decides to translate this into another scripting 13307 language instead. 13308 13309 * Scripts/run-webkit-tests: Break more pieces of the script into 13310 seprate functions. Added readSkippedFiles, findTestsToRun, and 13311 printResults functions. Removed custom code to skip results.html 13312 and instead just put it into the ignoredFiles hash. Fixed some 13313 indentation. Sorted function declarations, global variables, 13314 and options at the top of the file alphabetically so they're not 13315 in a semi-random order. 13316 133172009-09-17 Kevin Ollivier <kevino@theolliviers.com> 13318 13319 wx build fix, add missing dependency. 13320 13321 * wx/browser/wscript: 13322 133232009-09-16 Mark Rowe <mrowe@apple.com> 13324 13325 Split the SnowLeopard build across a few machines. 13326 13327 * BuildSlaveSupport/build.webkit.org-config/config.json: 13328 133292009-09-16 Kevin Ollivier <kevino@theolliviers.com> 13330 13331 wx build fix to support monolithic builds on Windows. 13332 13333 * wx/build/wxpresets.py: 13334 133352009-09-16 Kevin Ollivier <kevino@theolliviers.com> 13336 13337 wx build fix, improve debug support and 2.9 support on MSW. 13338 13339 * wx/build/settings.py: 13340 * wx/build/wxpresets.py: 13341 133422009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 13343 13344 Blind try at fixing new test failure on Windows. 13345 13346 * DumpRenderTree/win/FrameLoadDelegate.cpp: 13347 (FrameLoadDelegate::didReceiveTitle): 13348 133492009-09-15 Alex Milowski <alex@milowski.com> 13350 13351 Reviewed by Tor Arne Vestbø. 13352 13353 Added mathml toggle 13354 13355 * Scripts/build-webkit: 13356 133572009-09-15 Kevin Ollivier <kevino@theolliviers.com> 13358 13359 wx build fix. Allow waf build to support Python < 2.6. 13360 13361 * wx/build/waf_extensions.py: 13362 133632009-09-14 Chris Marrin <cmarrin@apple.com> 13364 13365 Reviewed by Oliver Hunt. 13366 13367 Add LayoutTests infrastructure to enable and disable webgl tests. 13368 https://bugs.webkit.org/show_bug.cgi?id=29254 13369 13370 * Scripts/run-webkit-tests: 13371 * Scripts/webkitdirs.pm: 13372 133732009-09-14 Simon Fraser <simon.fraser@apple.com> 13374 13375 Reviewed by Darin Adler. 13376 13377 Add --iterations option to run-webkit-tests to repeat the tests N times 13378 https://bugs.webkit.org/show_bug.cgi?id=29263 13379 13380 When run with --iterations N, run-webkit-tests will repeat the tests N times. 13381 13382 * Scripts/run-webkit-tests: 13383 133842009-09-14 Brady Eidson <beidson@apple.com> 13385 13386 Not reviewed, maybe should've been: 13387 13388 Cleaning up more Windows-specific fallout from the fix for: 13389 <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160 13390 13391 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 13392 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Correct printf() formatter, 13393 and call the correct method to get the Sender. 13394 133952009-09-14 Jon Honeycutt <jhoneycutt@apple.com> 13396 13397 GTK build fix. 13398 13399 Unreviewed. 13400 13401 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 13402 (AccessibilityController::setLogScrollingStartEvents): 13403 134042009-09-11 Jon Honeycutt <jhoneycutt@apple.com> 13405 13406 DRT/test part of 13407 <rdar://problem/7197644> WebKit should broadcast an MSAA event when 13408 jumping to a named anchor 13409 13410 https://bugs.webkit.org/show_bug.cgi?id=28899 13411 13412 Reviewed by Adam Roben. 13413 13414 * DumpRenderTree/AccessibilityController.cpp: 13415 (logScrollingStartEventsCallback): 13416 Turn on logging of scrolling start events. 13417 (AccessibilityController::getJSClass): 13418 Add a "logScrollingStartEvents" to the AccessibilityController's JS 13419 class definition. 13420 (AccessibilityController::resetToConsistentState): 13421 Turn off logging of scrolling start events. 13422 13423 * DumpRenderTree/AccessibilityController.h: 13424 Declare setLogScrollingStartEvents(). Add a member for the scrolling 13425 start event hook. 13426 13427 * DumpRenderTree/mac/AccessibilityControllerMac.cpp: 13428 (AccessibilityController::setLogScrollingStartEvents): 13429 Stubbed. 13430 13431 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 13432 (AccessibilityController::AccessibilityController): 13433 Initialize the handle to 0. 13434 (logEventProc): 13435 Renamed from logFocusEventProc; now logs scrolling start events, too. 13436 Removed the assertion that the event is a focus event. Added a switch 13437 to print a message for focus, scrolling start, and other, unknown 13438 events. 13439 (AccessibilityController::setLogFocusEvents): 13440 Changed to use logEventProc. 13441 (AccessibilityController::setLogScrollingStartEvents): 13442 If turning logging off, unhook the scrolling start event hook, and clear 13443 the member holding the handle. If turning on, query for the root 13444 accessible, so that accessibility is enabled for the WebView, and call 13445 SetWinEventHook to setup an event hook using logEventProc as the 13446 callback function. 13447 134482009-09-14 Brady Eidson <beidson@apple.com> 13449 13450 Windows build fix. 13451 13452 * DumpRenderTree/LayoutTestController.cpp: 13453 (setAuthenticationPasswordCallback): 13454 (setAuthenticationUsernameCallback): 13455 13456 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 13457 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): 13458 134592009-09-14 Brady Eidson <beidson@apple.com> 13460 13461 Reviewed by Alexey Proskuryakov. 13462 13463 Safari 4 cannot be used to update firmware on Linksys routers. 13464 <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160 13465 13466 Add the ability for DRT to handle authentication challenges. 13467 13468 * DumpRenderTree/LayoutTestController.cpp: 13469 (setAuthenticationPasswordCallback): 13470 (setAuthenticationUsernameCallback): 13471 (setHandlesAuthenticationChallengesCallback): 13472 (LayoutTestController::staticFunctions): 13473 13474 * DumpRenderTree/LayoutTestController.h: 13475 (LayoutTestController::handlesAuthenticationChallenges): 13476 (LayoutTestController::setHandlesAuthenticationChallenges): 13477 (LayoutTestController::authenticationUsername): 13478 (LayoutTestController::setAuthenticationUsername): 13479 (LayoutTestController::authenticationPassword): 13480 (LayoutTestController::setAuthenticationPassword): 13481 13482 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 13483 (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): 13484 13485 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 13486 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): 13487 * DumpRenderTree/win/ResourceLoadDelegate.h: 13488 134892009-09-12 Mark Rowe <mrowe@apple.com> 13490 13491 Reviewed by Dan Bernstein. 13492 13493 Test for <rdar://problem/6954546> and <rdar://problem/7090444>. 13494 13495 Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New. 13496 This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>. 13497 13498 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 13499 (NPP_New): 13500 135012009-09-14 Kevin Ollivier <kevino@theolliviers.com> 13502 13503 wx build fix for non-wxPython builds and a fix for errors when updating swig.py. 13504 13505 * wx/build/build_utils.py: 13506 * wx/build/settings.py: 13507 135082009-09-14 Csaba Osztrogonac <oszi@inf.u-szeged.hu> 13509 13510 Reviewed by Tor Arne Vestbø. 13511 13512 [Qt] Build fix for windows build. 13513 13514 * Scripts/bisect-builds: Add missing paranthesis for tmpdir function. 13515 135162009-09-13 Kevin Ollivier <kevino@theolliviers.com> 13517 13518 Fix typo accidently landed in last commit. 13519 13520 * wx/build/settings.py: 13521 135222009-09-13 Kevin Ollivier <kevino@theolliviers.com> 13523 13524 wx build fix, error out if using the wrong Python. 13525 13526 * wx/build/settings.py: 13527 135282009-09-13 Xan Lopez <xlopez@igalia.com> 13529 13530 Build fix for GTK+ < 2.14. 13531 13532 Do not use gtk_widget_get_window, access the window directly 13533 through the struct. 13534 13535 * DumpRenderTree/gtk/EventSender.cpp: 13536 (contextClickCallback): 13537 (mouseDownCallback): 13538 (mouseUpCallback): 13539 (mouseMoveToCallback): 13540 (keyDownCallback): 13541 135422009-09-13 Martin Robinson <martin.james.robinson@gmail.com> 13543 13544 Reviewed by Xan Lopez and Jan Alonzo. 13545 13546 [GTK] EventSender does not set 'window' property on synthesized GDK events 13547 https://bugs.webkit.org/show_bug.cgi?id=29169 13548 13549 Set the window property on synthesized GDK events in the GTK+ EventSender. 13550 13551 * DumpRenderTree/gtk/EventSender.cpp: 13552 (contextClickCallback): 13553 (mouseDownCallback): 13554 (mouseUpCallback): 13555 (mouseMoveToCallback): 13556 (keyDownCallback): 13557 135582009-09-12 Drew Wilson <atwilson@google.com> 13559 13560 Reviewed by Mark Rowe. 13561 13562 run-webkit-tests has a timeout value that is too low 13563 https://bugs.webkit.org/show_bug.cgi?id=29223 13564 13565 * Scripts/run-webkit-tests: 13566 Changed timeout value to 20 seconds to avoid timing out too early. 13567 135682009-09-11 Kevin Ollivier <kevino@theolliviers.com> 13569 13570 wx build fix. Mark dependencies as mandatory and declare which MSVC versions and 13571 architectures are supported for building wxWebKit. 13572 13573 * wx/build/settings.py: 13574 135752009-09-11 Eric Seidel <eric@webkit.org> 13576 13577 Reviewed by David Levin. 13578 13579 bugzilla-tool rollout threw exception under svn 13580 https://bugs.webkit.org/show_bug.cgi?id=29211 13581 13582 * Scripts/modules/scm.py: add missing return, and convert number arguments to strings. 13583 * Scripts/modules/scm_unittest.py: add testing for this fix. 13584 135852009-09-11 Brian Weinstein <bweinstein@apple.com> 13586 13587 Add myself to the committers list. 13588 13589 * Scripts/modules/committers.py: 13590 135912009-09-11 Eric Seidel <eric@webkit.org> 13592 13593 Reviewed by Adam Barth. 13594 13595 bugzilla-tool land-patches should only fail-fast in --commit-queue mode 13596 https://bugs.webkit.org/show_bug.cgi?id=29201 13597 13598 * Scripts/bugzilla-tool: 13599 136002009-09-11 Adam Roben <aroben@apple.com> 13601 13602 Make commit-log-editor move common prefixes to the top of the log 13603 13604 Fies <http://webkit.org/b/29190> commit-log-editor should move common 13605 prefixes to the top of the commit log 13606 13607 Reviewed by Darin Adler. 13608 13609 * Scripts/commit-log-editor: Find and remove the longest common prefix 13610 ending in a double newline from each ChangeLog entry, then put that 13611 common prefix at the top of the commit log. 13612 (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds, 13613 removes, and returns the longest common prefix ending in a double 13614 newline from a hash of strings 13615 136162009-09-11 Eric Seidel <eric@webkit.org> 13617 13618 Fix obvious typo in previous commit, no review. 13619 13620 bugzilla-tool should automate rollouts 13621 https://bugs.webkit.org/show_bug.cgi?id=26715 13622 13623 * Scripts/bugzilla-tool: add back missing "scm" argument. 13624 136252009-09-11 Eric Seidel <eric@webkit.org> 13626 13627 Reviewed by Adam Barth. 13628 13629 bugzilla-tool should automate rollouts 13630 https://bugs.webkit.org/show_bug.cgi?id=26715 13631 13632 bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit. 13633 The --complete-rollout option will automatically land and update the bug. 13634 Eventually --complete-rollout will be default, but that will require more testing. 13635 13636 This first pass is good enough for others to try and file bugs about. 13637 13638 * Scripts/bugzilla-tool: 13639 - Move modified_changelogs into scm.py. 13640 - Move svn_revision_from_commit_text logic into scm.py. 13641 - Add RolloutCommit command. 13642 * Scripts/modules/bugzilla.py: 13643 - Add reopen_bug command used by RolloutCommit. 13644 * Scripts/modules/scm.py: 13645 - Add functions to support RolloutCommit. 13646 - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge). 13647 - Add a str() call so that svn_commit_log can take a numeric argument. 13648 - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead. 13649 - Made dry_run commits return something that svn_revision_from_commit_text can parse. 13650 * Scripts/modules/scm_unittest.py: 13651 - Add read_from_path for easy file reading. 13652 - Put test4 on a new line to make reverts work w/o conflict. 13653 - Add an "svn update" call so that the checkout revision matches the server revision. 13654 - Add tests for svn_revision_from_commit_text. 13655 - Add a simple test for apply_reverse_diff. 13656 - Add a new self.scm member and use it in the new tests (eventually other tests can use it too). 13657 - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected. 13658 136592009-09-11 Adam Roben <aroben@apple.com> 13660 13661 Get user script/stylesheet tests running on Windows 13662 13663 Fixes <http://webkit.org/b/29181> User script/stylesheet tests are 13664 skipped on Windows 13665 13666 Reviewed by John Sullivan. 13667 13668 * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations 13669 against comsuppw.lib so we can use _bstr_t. 13670 13671 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include 13672 order, added #include of comutil.h for _bstr_t. 13673 13674 (bstrT): Helper function to convert a JSStringRef to a _bstr_t. 13675 (LayoutTestController::addUserScript): 13676 (LayoutTestController::addUserStyleSheet): 13677 Implemented. Implementations were based on those in 13678 LayoutTestControllerMac.mm. 13679 136802009-09-10 David Kilzer <ddkilzer@apple.com> 13681 13682 <http://webkit.org/b/29147> run-webkit-tests: make -h show help 13683 13684 Reviewed by Mark Rowe. 13685 13686 * Scripts/run-webkit-tests: Updated to make -h switch show help. 13687 136882009-09-10 Fumitoshi Ukai <ukai@chromium.org> 13689 13690 Reviewed by Alexey Proskuryakov. 13691 13692 Add WebCore/websockets directory in wx build system. 13693 https://bugs.webkit.org/show_bug.cgi?id=28038 13694 13695 * wx/build/settings.py: 13696 136972009-09-10 Martin Robinson <martin.james.robinson@gmail.com> 13698 13699 [GTK] EventSender does not properly convert some keyDown strings 13700 https://bugs.webkit.org/show_bug.cgi?id=29119 13701 13702 Add more keyDown string to character code conversions for GTK+ EventSender. 13703 13704 * DumpRenderTree/gtk/EventSender.cpp: 13705 (keyDownCallback): 13706 137072009-09-09 Steve Block <steveblock@google.com> 13708 13709 Reviewed by Maciej Stachowiak. 13710 13711 Geolocation Coordinates::toString() prints bogus values for unspecified properties. 13712 https://bugs.webkit.org/show_bug.cgi?id=29080 13713 13714 * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list. 13715 137162009-09-09 Eric Seidel <eric@webkit.org> 13717 13718 Reviewed by Eric Carlson. 13719 13720 reviewer/committer lookups are backwards 13721 https://bugs.webkit.org/show_bug.cgi?id=29113 13722 13723 I also moved Eric Carlson from the committer list to the reviewer list now that he is one. 13724 13725 * Scripts/modules/bugzilla.py: 13726 * Scripts/modules/committers.py: 13727 137282009-09-09 Cameron McCormack <cam@mcc.id.au> 13729 13730 Reviewed by Eric Seidel. 13731 13732 svn-unapply doesn't revert directories correctly 13733 https://bugs.webkit.org/show_bug.cgi?id=29065 13734 13735 * Scripts/svn-unapply: Make svnStatus consistently return status 13736 lines including a newline. 13737 * Scripts/svn-apply: Keep svnStatus in sync with the one in 13738 svn-unapply, in lieu of moving it to a common file. 13739 137402009-09-09 Cameron McCormack <cam@mcc.id.au> 13741 13742 Reviewed by Eric Seidel. 13743 13744 svn-apply doesn't handle changes to files copied to new directories properly 13745 https://bugs.webkit.org/show_bug.cgi?id=29059 13746 13747 * Scripts/svn-apply: Don't treat "--- revision 0" patches as being 13748 additions if we know that we've just copied a file to this name. 13749 137502009-09-09 Eric Seidel <eric@webkit.org> 13751 13752 Reviewed by David Levin. 13753 13754 commit-queue hangs if a builder has never built 13755 https://bugs.webkit.org/show_bug.cgi?id=29091 13756 13757 * Scripts/modules/buildbot.py: 13758 * Scripts/modules/buildbot_unittest.py: 13759 137602009-09-09 Zan Dobersek <zandobersek@gmail.com> 13761 13762 Reviewed by Gustavo Noronha. 13763 13764 [GTK] DumpRenderTree needs eventSender object and implementation 13765 https://bugs.webkit.org/show_bug.cgi?id=25990 13766 13767 Implements most of the EventSender object's functionality for 13768 the DumpRenderTree tool. Implementation still lacks support 13769 for drag and drop tests and forward leaps. 13770 13771 Based on work by Holger Hans Peter Freyther. 13772 13773 * DumpRenderTree/gtk/DumpRenderTree.cpp: 13774 (runTest): Focus on the view before loading a new test. 13775 (webViewWindowObjectCleared): 13776 * DumpRenderTree/gtk/EventSender.cpp: Added. 13777 (getDragModeCallback): 13778 (setDragModeCallback): 13779 (leapForwardCallback): 13780 (contextClickCallback): 13781 (updateClickCount): 13782 (mouseDownCallback): 13783 (mouseUpCallback): 13784 (mouseMoveToCallback): 13785 (beginDragWithFilesCallback): 13786 (replaySavedEvents): 13787 (keyDownCallback): 13788 (textZoomInCallback): 13789 (textZoomOutCallback): 13790 (zoomPageInCallback): 13791 (zoomPageOutCallback): 13792 (getClass): 13793 (makeEventSender): 13794 * DumpRenderTree/gtk/EventSender.h: Added. 13795 * GNUmakefile.am: Add build rules for EventSender. 13796 137972009-09-09 Daniel Bates <dbates@webkit.org> 13798 13799 Reviewed by Adam Roben. 13800 13801 https://bugs.webkit.org/show_bug.cgi?id=28953 13802 13803 Added pre- and post- build events so that on build failure, the file 13804 buildfailed is written to the directory $(WebKitOutputDir). 13805 13806 * WinLauncher/WinLauncher.vcproj: 13807 138082009-09-09 Kenneth Rohde Christiansen <kenneth@webkit.org> 13809 13810 Unreviewed. 13811 13812 Add myself to list of committers. 13813 13814 * Scripts/modules/committers.py: 13815 138162009-09-08 Eric Seidel <eric@webkit.org> 13817 13818 Reviewed by David Levin. 13819 13820 commit-queue gets stuck if a non-committer sets commit-queue+ or review+ 13821 https://bugs.webkit.org/show_bug.cgi?id=28605 13822 https://bugs.webkit.org/show_bug.cgi?id=28916 13823 13824 * Scripts/bugzilla-tool: 13825 - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit" 13826 comment now that it's used for rejecting patches for invalid committers too. 13827 - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them. 13828 - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916. 13829 * Scripts/modules/bugzilla.py: 13830 - Make _parse_attachment_element not validate reviewer/committer. 13831 - Share flag parsing code in _parse_attachment_flag. 13832 - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails. 13833 - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not. 13834 - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction. 13835 * Scripts/modules/bugzilla_unittest.py: 13836 - Update this test to no longer expect committer/reviewer validation. 13837 * Scripts/modules/committers.py: 13838 - Return None on failed lookups instead of raising Exceptions. 13839 * Scripts/modules/committers_unittest.py: 13840 - Update tests to expect None returns instead of exceptions. 13841 138422009-09-09 David Kilzer <ddkilzer@apple.com> 13843 13844 <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY() 13845 13846 Reviewed by Mark Rowe. 13847 13848 No change to layout test results. 13849 13850 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 13851 (AccessibilityUIElement::clickPointY): Changed to return y value 13852 instead of x value. 13853 138542009-09-08 Dimitri Glazkov <dglazkov@chromium.org> 13855 13856 Reviewed by Mark Rowe. 13857 13858 Reduce dglazkov's boboiness by properly concatenating revision value. 13859 13860 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution 13861 rather than "+". 13862 138632009-09-08 Kevin Ollivier <kevino@theolliviers.com> 13864 13865 wxWebKit Python extension build fix - get swig.py if it doesn't exist. 13866 13867 * wx/build/build_utils.py: 13868 138692009-09-08 Mark Rowe <mrowe@apple.com> 13870 13871 Fix an incorrect variable name in UpdateChromiumSource. 13872 13873 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 13874 138752009-09-08 Mark Rowe <mrowe@apple.com> 13876 13877 Don't check for leaks on the release SnowLeopard builder. 13878 13879 * BuildSlaveSupport/build.webkit.org-config/config.json: 13880 138812009-09-08 Mark Rowe <mrowe@apple.com> 13882 13883 Add a SnowLeopard release builder. 13884 13885 * BuildSlaveSupport/build.webkit.org-config/config.json: 13886 138872009-09-08 David Levin <levin@chromium.org> 13888 13889 Reviewed by Darin Adler. 13890 13891 Remove end of line whitespace check from check-webkit-style. 13892 https://bugs.webkit.org/show_bug.cgi?id=29053 13893 13894 * Scripts/modules/cpp_style.py: 13895 138962009-09-08 Cameron McCormack <cam@mcc.id.au> 13897 13898 Reviewed by Darin Adler. 13899 13900 Fix DumpRenderTree build from clean tree on Tiger 13901 https://bugs.webkit.org/show_bug.cgi?id=28927 13902 13903 * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the 13904 DerivedSources/DumpRenderTree directory exists when 13905 building on Tiger. 13906 139072009-09-08 Kevin Ollivier <kevino@theolliviers.com> 13908 13909 wx build fix after introduction of platform/mock directory. 13910 13911 * wx/build/settings.py: 13912 139132009-09-08 Yael Aharon <yael.aharon@nokia.com> 13914 13915 Unreviewed. 13916 13917 Add myself to list of committers. 13918 13919 * Scripts/modules/committers.py: 13920 139212009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com> 13922 13923 Unreviewed. 13924 13925 Add myself to list of committers. 13926 13927 * Scripts/modules/committers.py: 13928 139292009-09-08 Cameron McCormack <cam@mcc.id.au> 13930 13931 Reviewed by Darin Adler. 13932 13933 prepare-ChangeLog too chatty on file additions 13934 https://bugs.webkit.org/show_bug.cgi?id=29019 13935 13936 * Scripts/prepare-ChangeLog: Omit description of added properties 13937 on newly added files. 13938 139392009-09-08 Steve Block <steveblock@google.com> 13940 13941 Reviewed by Adam Barth. 13942 13943 Adds a LayoutTestController method to set the permission state for Geolocation. 13944 This is required to use the mock Geolocation service for testing. 13945 https://bugs.webkit.org/show_bug.cgi?id=29027 13946 13947 * DumpRenderTree/LayoutTestController.cpp: Modified. 13948 (setDatabaseQuotaCallback): Modified. Style fix. 13949 (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state. 13950 (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController. 13951 * DumpRenderTree/LayoutTestController.h: Modified. 13952 (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state. 13953 (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set. 13954 (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state. 13955 * DumpRenderTree/mac/UIDelegate.mm: Modified. 13956 (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state. 13957 139582009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com> 13959 13960 Reviewed by Simon Hausmann. 13961 13962 [Qt] QtWebKit single API to enable persistency 13963 https://bugs.webkit.org/show_bug.cgi?id=28682 13964 13965 Use the new enablePersistentStorage API instead 13966 of enabling all persistent features one-by-one. 13967 13968 * DumpRenderTree/qt/DumpRenderTree.cpp: 13969 (WebCore::WebPage::WebPage): 13970 (WebCore::DumpRenderTree::DumpRenderTree): 13971 139722009-09-07 Andras Becsi <becsi.andras@stud.u-szeged.hu> 13973 13974 Reviewed by Tor Arne Vestbø. 13975 13976 Refactor --strict switch to --ignore-metrics and correct the 13977 implementation to make the feature usable on all platforms. 13978 https://bugs.webkit.org/show_bug.cgi?id=28907 13979 13980 run-webkit-tests --ignore-metrics strips the font related metrics from 13981 the actual and expected data before comparing them. 13982 In this way the render trees can be checked for obvious differences but 13983 a successful test implies by no means that the layout is actually correct. 13984 13985 * Scripts/run-webkit-tests: 13986 139872009-09-07 Steve Block <steveblock@google.com> 13988 13989 Reviewed by Adam Barth. 13990 13991 Adds a mock Geolocation service. This will be used to provide predictable behavior of the 13992 Geolocation API for use in LayoutTests. Later changes will integrate the the mock 13993 Geolocation service with DumpRenderTree. 13994 https://bugs.webkit.org/show_bug.cgi?id=28264 13995 13996 * DumpRenderTree/LayoutTestController.cpp: Modified. 13997 (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service. 13998 (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service. 13999 (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController. 14000 * DumpRenderTree/LayoutTestController.h: Modified. 14001 * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified. 14002 (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service. 14003 (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service. 14004 140052009-09-07 Drew Wilson <atwilson@google.com> 14006 14007 Reviewed by David Levin. 14008 14009 Enable SHARED_WORKERS by default 14010 https://bugs.webkit.org/show_bug.cgi?id=28959 14011 14012 * Scripts/build-webkit: 14013 140142009-09-07 Kevin Ollivier <kevino@theolliviers.com> 14015 14016 wx build fixes for wx SVN trunk. 14017 14018 * wx/build/settings.py: 14019 140202009-09-04 Kevin Ollivier <kevino@theolliviers.com> 14021 14022 wx build fix. Switch USE_ defines over to the compiler so that they can be 14023 checked by files not including config.h (like WebCorePrefix.h). 14024 14025 * wx/build/settings.py: 14026 140272009-09-04 Adam Barth <abarth@webkit.org> 14028 14029 Unreviewed build fix. 14030 14031 Update declaration of FrameLoadDelegate to reflect that 14032 IWebFrameLoadDelegatePrivate2 inherits from 14033 IWebFrameLoadDelegatePrivate. 14034 14035 * DumpRenderTree/win/FrameLoadDelegate.h: 14036 140372009-09-04 Adam Barth <abarth@webkit.org> 14038 14039 Reviewed by Eric Seidel. 14040 14041 https://bugs.webkit.org/show_bug.cgi?id=24696 14042 14043 Add testing instrumentation for mixed content. 14044 14045 * DumpRenderTree/mac/FrameLoadDelegate.mm: 14046 (-[FrameLoadDelegate webView:]): 14047 (-[FrameLoadDelegate webView:didRunInsecureContent:]): 14048 * DumpRenderTree/win/FrameLoadDelegate.cpp: 14049 (descriptionSuitableForTestResult): 14050 (FrameLoadDelegate::QueryInterface): 14051 (FrameLoadDelegate::didDisplayInsecureContent): 14052 (FrameLoadDelegate::didRunInsecureContent): 14053 * DumpRenderTree/win/FrameLoadDelegate.h: 14054 140552009-09-03 Kevin Watters <kevinwatters@gmail.com> 14056 14057 Reviewed by Kevin Ollivier. 14058 14059 [wx] Frames support 14060 https://bugs.webkit.org/show_bug.cgi?id=19041 14061 14062 * wx/build-wxwebkit: 14063 140642009-09-02 David Kilzer <ddkilzer@apple.com> 14065 14066 <http://webkit.org/b/28880> svn-apply --force doesn't actually work 14067 14068 Reviewed by Eric Seidel. 14069 14070 This fixes "svn-apply --force" and adds unit tests for the 14071 scm.apply_patch() method which uses this script. 14072 14073 * Scripts/svn-apply: Created $globalExitCode variable that 14074 defaults to 0. Exit with a value of $globalExitCode when the 14075 script is finished. 14076 (applyPatch): Ignore a non-zero $exitCode if $force is true, but 14077 set $globalExitCode to $exitCode so that svn-apply exits with a 14078 non-zero status if any patches did not apply cleanly. Also 14079 print out the actual patch command if $force was not true. 14080 14081 * Scripts/modules/scm.py: 14082 (scripts_directory): Added. Extracted from script_path(). 14083 (script_path): Extracted scripts_directory(). 14084 * Scripts/modules/scm_unittest.py: Import urllib. 14085 (SVNTestRepository.setup): Save the original working directory 14086 in test_object since this represents the WebKit repository from 14087 where the unit tests are run. 14088 (SCMTest): Created new super class to hold utility methods. 14089 (SCMTest._create_patch): Creates a patch file on disk and a 14090 dictionary for use with scm.svn_apply(). 14091 (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink 14092 back to WebKitTools/Scripts in the test repository so that 14093 scm.apply_patch() is able to find the svn-apply script. 14094 (SVNTest): Inherit from SCMTest instead of unittest.TestCase. 14095 (SVNTest.tearDown): Make sure to change directories back to the 14096 original_path before the next test. 14097 (SVNTest.test_apply_svn_patch): New test case for applying an 14098 svn patch with scm.apply_patch(). 14099 (SVNTest.test_apply_svn_patch_force): New test case for applying 14100 an svn patch with scm.apply_patch() that conflicts. 14101 (GitTest): Inherit from SCMTest instead of unittest.TestCase. 14102 (GitTest.tearDown): Make sure to change directories back to the 14103 original_path before the next test. 14104 (GitTest.test_apply_git_patch): New test case for applying a git 14105 patch with scm.apply_patch(). 14106 (GitTest.test_apply_git_patch_force): New test case for applying 14107 a git patch with scm.apply_patch() that conflicts. 14108 141092009-09-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 14110 14111 Reviewed by Mark Rowe. 14112 14113 [Qt] Add support for platform-spesific layout-test results 14114 14115 For the Qt port we use the qt-[mac|linux|win] directories and then fall 14116 back to the generic qt directory for both test results and skipped list. 14117 14118 * Scripts/run-webkit-tests: 14119 * Scripts/webkitdirs.pm: 14120 141212009-09-02 Laurent Cerveau <lcerveau@me.com> 14122 14123 Reviewed by David Kilzer. 14124 14125 <http://webkit.org/b/25517> build-webkit script should print build time at end 14126 14127 * Scripts/build-webkit: 14128 Added startTime and endTime variable so that the build time is computed and printed as 14129 part of the build message; display formatting has been separated in a dedicated subroutine. 14130 141312009-09-02 David Kilzer <ddkilzer@apple.com> 14132 14133 <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root 14134 14135 Reviewed by Eric Seidel. 14136 14137 * Scripts/VCSUtils.pm: 14138 (determineSvnRoot): Added back check for repository root that 14139 was removed in r46134 when this code lived in svn-create-patch. 14140 It's necessary to check both the repository root and the 14141 repository UUID in case two different working directories are 14142 checked out from the same repository. 14143 141442009-09-02 Timothy Hatcher <timothy@apple.com> 14145 14146 Use new 512x512 icons for nightly builds. 14147 14148 Rubber-stamped by Mark Rowe. 14149 14150 * WebKitLauncher/webkit.icns: 14151 141522009-09-02 Kevin Ollivier <kevino@theolliviers.com> 14153 14154 waf build fix. Remove local variable shadowing global. 14155 14156 * wx/build/settings.py: 14157 141582009-09-02 Zan Dobersek <zandobersek@gmail.com> 14159 14160 Reviewed by David Kilzer. 14161 14162 Calls exitStatus function from the main package where it is also defined. 14163 14164 * Scripts/VCSUtils.pm: 14165 141662009-09-02 Kevin Ollivier <kevino@theolliviers.com> 14167 14168 waf build fixes for Windows/MSVC and Mac/Snow Leopard. 14169 14170 * wx/browser/wscript: 14171 * wx/build/build_utils.py: 14172 * wx/build/settings.py: 14173 141742009-08-10 Kevin Ollivier <kevino@theolliviers.com> 14175 14176 Reviewed by Eric Seidel. 14177 14178 Changes needed for build-webkit to support the waf build system for the wx port. 14179 14180 https://bugs.webkit.org/show_bug.cgi?id=27619 14181 14182 * Scripts/build-webkit: 14183 * Scripts/run-launcher: 14184 * Scripts/webkitdirs.pm: 14185 141862009-09-02 David Kilzer <ddkilzer@apple.com> 14187 14188 <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts 14189 14190 Reviewed by Eric Seidel. 14191 14192 * Scripts/update-webkit: Added "--accept postpone" to 14193 @svnOptions when running with svn-1.6 or newer. 14194 141952009-09-02 David Kilzer <ddkilzer@apple.com> 14196 14197 Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer() 14198 14199 Reviewed by Eric Seidel. 14200 14201 * Scripts/VCSUtils.pm: 14202 (@EXPORT): Added &isSVNVersion16OrNewer. 14203 (svnVersion): Added. Internal method that gets the SVN version 14204 and caches it. 14205 (isSVNVersion16OrNewer): Added. Method that does the SVN 1.6 14206 version check. 14207 * Scripts/prepare-ChangeLog: Switched to use new 14208 isSVNVersion16OrNewer() method. 14209 * Scripts/resolve-ChangeLogs: Ditto. 14210 * Scripts/svn-create-patch: Ditto. 14211 142122009-09-02 David Kilzer <ddkilzer@apple.com> 14213 14214 Clean up VCSUtils.pm 14215 14216 Reviewed by Eric Seidel. 14217 14218 * Scripts/VCSUtils.pm: Added proper package statement. Fixed 14219 indentation of BEGIN block. Listed each exported method on a 14220 line by itself. Added methods to the export list after adding 14221 the package statement. Sorted module variables. Moved 14222 definiton of $gitRoot next to other module variables. 14223 142242009-09-01 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 14225 14226 Rubber-stamped by Simon Hausmann. 14227 14228 [Qt] Fix layout-test plugins/plugin-javascript-access.html 14229 14230 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 14231 142322009-09-02 Shinichiro Hamaji <hamaji@chromium.org> 14233 14234 Reviewed by Eric Seidel. 14235 14236 js tests should move into jstests subdirectory instead of resources/ 14237 https://bugs.webkit.org/show_bug.cgi?id=25880 14238 14239 make-script-wrappers supports both resources and script-tests directories. 14240 run-webkit-tests ignores files in script-tests. 14241 Move script tests of animations to check the new script is working. 14242 14243 * Scripts/make-script-test-wrappers: 14244 * Scripts/run-webkit-tests: 14245 142462009-09-02 Szabo Carol <carol.szabo@nokia.com> 14247 14248 Reviewed by David Levin. 14249 14250 check-webkit-style uses python from /usr/bin instead of the PATH 14251 https://bugs.webkit.org/show_bug.cgi?id=28225 14252 14253 * Scripts/bugzilla-tool: 14254 * Scripts/check-webkit-style: 14255 * Scripts/run-webkit-unittests: 14256 * Scripts/update-sources-list.py: 14257 Changed the first line from 14258 #!/usr/bin/python 14259 to 14260 #!/usr/bin/env python 14261 which causes python to be invoked from the path location returned 14262 by "which python" when any of these scripts are launched. 14263 these are currently all the python scripts in WebKitTools/Scripts. 14264 142652009-09-01 David Kilzer <ddkilzer@apple.com> 14266 14267 <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards 14268 14269 Reviewed by Adam Barth. 14270 14271 * Scripts/modules/scm.py: 14272 (Git.commit_ids_from_commitish_arguments): Reverse the list of 14273 commits returned from git-rev-list since we always want to post 14274 the oldest patches first to bugs.webkit.org. 14275 * Scripts/modules/scm_unittest.py: 14276 (run): Added return statement to return the output now that we 14277 want it sometimes. 14278 (SVNTestRepository._setup_test_commits): Added a fourth commit 14279 so the GitTest.test_commitish_order() test has more commits to 14280 work with. 14281 (GitTest.test_commitish_order): Added unit test for change to 14282 Git.commit_ids_from_commitish_arguments() in scm.py. 14283 142842009-09-01 David Kilzer <ddkilzer@apple.com> 14285 14286 <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed 14287 14288 Reviewed by David Levin. 14289 14290 The mark-fixed subcommand is for those times when you don't use 14291 bugzilla-tool to commit a patch, but you want to use it to close 14292 the bug with a committed-revision message. 14293 14294 * Scripts/bugzilla-tool: 14295 (bug_comment_from_svn_revision): Added. Extracted from 14296 bug_comment_from_commit_text(). 14297 (bug_comment_from_commit_text): Extracted 14298 bug_comment_from_svn_revision() from this method. 14299 (MarkBugFixed.__init__): Added. 14300 (MarkBugFixed._fetch_commit_log): Added. Retrieves the commit 14301 log from the last commit if no svn revision is specified, else 14302 the commit log for the specified svn revision. 14303 (MarkBugFixed._determine_bug_id_and_svn_revision): Added. 14304 Attempts to determine the bug id and svn revision if one or both 14305 were not defined on the command line. 14306 (MarkBugFixed.execute): Added. Adds a comment about the 14307 revision that fixed the bug and closes the bug. 14308 (BugzillaTool.__init__): Added mark-fixed subcommand. 14309 * Scripts/modules/bugzilla.py: 14310 (Bugzilla.fetch_title_from_bug): Added. Returns the title of a 14311 bug given a bug id. 14312 * Scripts/modules/scm.py: 14313 (SCM.strip_r_from_svn_revision): Added. Utility method to strip 14314 the leading 'r' from an svn revision. 14315 (SCM.svn_commit_log): Added. Subclasses must override. 14316 (SCM.last_svn_commit_log): Added. Subclasses must override. 14317 (SVN.svn_commit_log): Added. Returns svn log for a given 14318 revision. 14319 (SVN.last_svn_commit_log): Added. Uses svnversion to find the 14320 last commit in an svn working directory and then runs svn log. 14321 (Git.svn_commit_log): Added. Returns svn log for a given 14322 revision. 14323 (Git.last_svn_commit_log): Added. Runs git-svn-log with a limit 14324 of one log message. 14325 143262009-09-01 David Kilzer <ddkilzer@apple.com> 14327 14328 <http://webkit.org/b/28880> svn-apply --force doesn't actually work 14329 14330 Reviewed by Brady Eidson. 14331 14332 * Scripts/svn-apply: 14333 (applyPatch): Add "--force" to $options arrayref if $force is 14334 set. 14335 143362009-09-01 David Kilzer <ddkilzer@apple.com> 14337 14338 <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch 14339 14340 Reviewed by Adam Roben. 14341 14342 When git-filter-branch has been invoked to rewrite ChangeLog 14343 files on series of git commits, it changes directories into 14344 .git-rewrite/t before re-running resolve-ChangeLogs. This 14345 causes determineVCSRoot() in VCSUtils.pm to return 14346 ".git-rewrite/t", which causes that path to be prepended to all 14347 ChangeLog paths, which results in an error like this: 14348 14349 error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git. 14350 Died at WebKitTools/Scripts/resolve-ChangeLogs line 376. 14351 14352 The correct way to fix this is not to try to find the repository 14353 root when invoked by git-filter-branch. 14354 14355 * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true, 14356 set $relativePath to '.' instead of calling 14357 chdirReturningRelativePath(determineVCSRoot()). 14358 (isInGitFilterBranch): Added. Checks for the existence of the 14359 MAPPED_PREVIOUS_COMMIT environment variable. 14360 143612009-09-01 Xan Lopez <xlopez@igalia.com> 14362 14363 Reviewed by Gustavo Noronha. 14364 14365 Add support for Fedora distros in the http tests 14366 https://bugs.webkit.org/show_bug.cgi?id=28263 14367 14368 Add detection code for Fedora distribution, and use the proper 14369 httpd conf file when needed. 14370 14371 * Scripts/run-webkit-httpd: 14372 * Scripts/run-webkit-tests: 14373 * Scripts/webkitdirs.pm: 14374 143752009-09-01 Jan Michael Alonzo <jmalonzo@webkit.org> 14376 14377 Reviewed by Eric Seidel. 14378 14379 [Gtk] DRT needs implementation of overridePreference 14380 https://bugs.webkit.org/show_bug.cgi?id=28830 14381 14382 Implement overridePreference. 14383 14384 * DumpRenderTree/gtk/DumpRenderTree.cpp: 14385 (resetDefaultsToConsistentValues): 14386 (setDefaultsToConsistentStateValuesForTesting): 14387 (runTest): 14388 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14389 (toWebSettingKey): 14390 (LayoutTestController::overridePreference): 14391 143922009-09-01 Joseph Pecoraro <joepeck@webkit.org> 14393 14394 <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying 14395 14396 Reviewed by Eric Seidel. 14397 14398 Jump back and forth between the repository root directory (to apply) and the 14399 directory the script was run from (to find the patch). 14400 14401 * Scripts/svn-apply: 14402 * Scripts/svn-unapply: 14403 144042009-08-31 Adam Roben <aroben@apple.com> 14405 14406 Fall back to a Release version of Safari if a Debug one doesn't exist 14407 14408 <http://webkit.org/b/28849> 14409 14410 Reviewed by Sam Weinig. 14411 14412 * Scripts/webkitdirs.pm: 14413 (safariPath): If the user is working with a Debug build, but there's 14414 no Debug version of Safari present, fall back to using a Release 14415 version of Safari. 14416 144172009-08-31 Adam Roben <aroben@apple.com> 14418 14419 Make safariPath() work for Debug builds of Safari on Windows 14420 14421 <http://webkit.org/b/28849> 14422 14423 Reviewed by Sam Weinig. 14424 14425 * Scripts/webkitdirs.pm: 14426 (safariPath): If the user is working with a Debug build, add the 14427 _debug suffix to Safari.exe. 14428 144292009-08-28 Eric Seidel <eric@webkit.org> 14430 14431 Reviewed by Adam Barth. 14432 14433 commit-queue needs a master process 14434 https://bugs.webkit.org/show_bug.cgi?id=28040 14435 14436 Add a bugzilla-tool commit-queue command 14437 Keeps per-bug logs, but doesn't yet upload them anywhere. 14438 14439 * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue' 14440 * Scripts/modules/buildbot.py: remove noisy log message 14441 * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python 14442 144432009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org> 14444 14445 Reviewed by Gustavo Noronha. 14446 14447 [GTK] Geolocation needs permission API before being enabled by default 14448 14449 Build the Gtk port with geolocation enabled. This option is only 14450 enabled for the buildbot. The autotools option will be enabled by 14451 default once the permissions API is implemented. 14452 14453 * Scripts/build-webkit: 14454 144552009-08-26 Cameron McCormack <cam@mcc.id.au> 14456 14457 Reviewed by David Kilzer. 14458 14459 Make prepare-ChangeLog notice property changes 14460 https://bugs.webkit.org/show_bug.cgi?id=28675 14461 14462 Make the generated ChangeLog entry include a short description of 14463 property changes if there were such changes. Also make 14464 prepare-ChangeLog not bail if the only changes are property changes. 14465 14466 * Scripts/prepare-ChangeLog: 14467 144682009-08-26 Adam Barth <abarth@webkit.org> 14469 14470 Reviewed by Oliver Hunt. 14471 14472 Don't let local files access web URLs 14473 https://bugs.webkit.org/show_bug.cgi?id=28480 14474 14475 A bunch of our LayoutTests rely on our old behavior, so we explicitly 14476 grant local files universal access during testing. Mainly, these tests 14477 involve making XMLHttpRequests for data URLs. 14478 14479 * DumpRenderTree/mac/DumpRenderTree.mm: 14480 (resetDefaultsToConsistentValues): 14481 * DumpRenderTree/qt/DumpRenderTree.cpp: 14482 (WebCore::WebPage::WebPage): 14483 * DumpRenderTree/win/DumpRenderTree.cpp: 14484 (resetDefaultsToConsistentValues): 14485 144862009-08-26 John Gregg <johnnyg@google.com> 14487 14488 Reviewed by David Levin. 14489 14490 Minor style correction and include fix for notifications 14491 https://bugs.webkit.org/show_bug.cgi?id=28745 14492 14493 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: 14494 change to correct EnumStyle 14495 (DRTDesktopNotificationPresenter::checkNotificationPermission): 14496 144972009-08-26 David Levin <levin@chromium.org> 14498 14499 Reviewed by Alexey Proskuryakov. 14500 14501 XMLHttpRequest.withCredentials=false shouldn't save cookies. 14502 https://bugs.webkit.org/show_bug.cgi?id=28743 14503 14504 Added the support to the layout test controller on OSX and 14505 Windows (for CFNETWORK) to allow for changing the accept cookie 14506 policy. 14507 14508 * DumpRenderTree/LayoutTestController.cpp: 14509 (LayoutTestController::LayoutTestController): Added a bool 14510 to track the state of accepting cookies. 14511 (setAlwaysAcceptCookiesCallback): Standard wrapper method 14512 to go from js to a C++ method. 14513 (LayoutTestController::staticFunctions): Added the 14514 setAlwaysAcceptCookies method to the js layoutTestController. 14515 * DumpRenderTree/LayoutTestController.h: 14516 (LayoutTestController::alwaysAcceptCookies): Returns the value. 14517 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14518 (LayoutTestController::setAlwaysAcceptCookies): Stub out method. 14519 * DumpRenderTree/mac/DumpRenderTree.mm: 14520 (resetDefaultsToConsistentValues): Reset the accept cookie to 14521 its default. 14522 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 14523 (LayoutTestController::setAlwaysAcceptCookies): Does the work for 14524 OSX to change the cookie accept policy. 14525 * DumpRenderTree/win/DumpRenderTree.cpp: 14526 (setAlwaysAcceptCookies): Method to handle all the calls necessary 14527 to change the accept cookie policy on Windows. 14528 (resetDefaultsToConsistentValues): Reset the accept cookie to 14529 its default. 14530 * DumpRenderTree/win/DumpRenderTreeWin.h: 14531 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 14532 (LayoutTestController::setAlwaysAcceptCookies): Stub out method. 14533 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 14534 (LayoutTestController::setAlwaysAcceptCookies): Stub out method. 14535 145362009-08-26 Dimitri Glazkov <dglazkov@chromium.org> 14537 14538 Unreviewed. 14539 14540 Remove accidentally left in clobber option. 14541 https://bugs.webkit.org/show_bug.cgi?id=28400 14542 14543 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option. 14544 145452009-08-26 Dimitri Glazkov <dglazkov@chromium.org> 14546 14547 Reviewed by Mark Rowe. 14548 14549 Add canary-style Chromium WebKit build slave to the waterfall. 14550 https://bugs.webkit.org/show_bug.cgi?id=28400 14551 14552 * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave 14553 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands. 14554 145552009-08-25 Cameron McCormack <cam@mcc.id.au> 14556 14557 Reviewed by Darin Adler. 14558 14559 make-script-test-wrappers should be executable 14560 https://bugs.webkit.org/show_bug.cgi?id=28669 14561 14562 Make make-script-test-wrappers and update-sources-list.py both be 14563 executable. 14564 14565 * Scripts/update-sources-list.py: 14566 * Scripts/make-script-test-wrappers: 14567 145682009-08-25 Brent Fulgham <bfulgham@webkit.org> 14569 14570 Build fix 14571 14572 Revise Debug_Cairo targets to point inherit from the 14573 debug_wincairo.vsprops property sheet so that they link 14574 against the proper libraries in Debug build. 14575 14576 * DumpRenderTree/win/DumpRenderTree.vcproj: 14577 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 14578 * WinLauncher/WinLauncher.vcproj: 14579 145802009-08-25 David Levin <levin@chromium.org> 14581 14582 Reviewed by Adam Roben. 14583 14584 PLATFORM(CFNETWORK) should be USE(CFNETWORK). 14585 https://bugs.webkit.org/show_bug.cgi?id=28713 14586 14587 * DumpRenderTree/win/DumpRenderTree.cpp: 14588 (main): 14589 145902009-08-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 14591 14592 Reviewed by Ariya Hidayat. 14593 14594 [Qt/Mac] Use CONFIG+=build_all only when building libraries 14595 14596 If no configuration is specified when building WebKit we pass the 14597 debug_and_release option to QMake which results in Makefiles for 14598 both configurations being generated. 14599 14600 Previously we built both of these configurations by default, for 14601 all targets (both the QtWebKit framework/dyldlib and the various 14602 executables such as QtLauncher and tests). This makes sense for 14603 the libraries, which get the _debug suffix and can be loaded on 14604 demand by setting the DYLD_IMAGE_SUFFIX, but for executables we 14605 ended up building the same executable twice. 14606 14607 We now only build one instance of each executable, and since this 14608 is a developer build we build the debug-version. Passing either 14609 --debug or --release to build-webkit will override this, and 14610 even in the default case the release version can still be built 14611 by running 'make release' in the the build directory of each 14612 target. 14613 14614 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 14615 * Scripts/webkitdirs.pm: 14616 146172009-08-24 Hironori Bono <hbono@chromium.org> 14618 14619 Reviewed by Adam Barth. 14620 14621 Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet". 14622 <https://bugs.webkit.org/show_bug.cgi?id=27827>. 14623 14624 Because of the lack of mappings from GDK key-codes to WebKit key-codes, 14625 Chromium cannot send valid key-codes to JavaScript when a user types 14626 function keys. This change just copies the mappings from 'KeyEventGtk.cpp'. 14627 14628 To write layout tests for this issue, added mappings from function-key 14629 names to platform-specific key-codes to EventSendingController objects 14630 so that eventSender.keyDown() can send function-key events without using 14631 platform-specific key codes. (Unfortunately, this eventSender.keyDown() change 14632 is only for Mac. So this change adds this new test to Skipped tests for other 14633 platforms to prevent this change from crashing the build trees.) 14634 14635 * DumpRenderTree/mac/EventSendingController.mm: 14636 (-[EventSendingController keyDown:withModifiers:]): 14637 146382009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org> 14639 14640 Reviewed by Xan Lopez. 14641 14642 [Gtk] API for disabling local file access to web URLs 14643 https://bugs.webkit.org/show_bug.cgi?id=28663 14644 14645 Enable this setting for DRT. 14646 14647 * DumpRenderTree/gtk/DumpRenderTree.cpp: 14648 (resetWebViewToConsistentStateBeforeTesting): 14649 146502009-08-22 Adam Barth <abarth@webkit.org> 14651 14652 Revert 47684. We're going to do this later once clients have had a 14653 chance to opt into the setting they like. 14654 14655 * DumpRenderTree/mac/DumpRenderTree.mm: 14656 (resetDefaultsToConsistentValues): 14657 * DumpRenderTree/qt/DumpRenderTree.cpp: 14658 (WebCore::WebPage::WebPage): 14659 * DumpRenderTree/win/DumpRenderTree.cpp: 14660 (resetDefaultsToConsistentValues): 14661 146622009-08-22 Adam Barth <abarth@webkit.org> 14663 14664 Reviewed by Eric Seidel. 14665 14666 Don't let local files access web URLs 14667 https://bugs.webkit.org/show_bug.cgi?id=28480 14668 14669 A bunch of our LayoutTests rely on our old behavior, so we explicitly 14670 grant local files universal access during testing. Mainly, these tests 14671 involve making XMLHttpRequests for data URLs. 14672 14673 * DumpRenderTree/mac/DumpRenderTree.mm: 14674 (resetDefaultsToConsistentValues): 14675 * DumpRenderTree/qt/DumpRenderTree.cpp: 14676 (WebCore::WebPage::WebPage): 14677 * DumpRenderTree/win/DumpRenderTree.cpp: 14678 (resetDefaultsToConsistentValues): 14679 146802009-08-22 Mark Rowe <mrowe@apple.com> 14681 14682 Rubber-stamped by Anders Carlsson. 14683 14684 Bring signed updates to the Mac nightly builds. 14685 14686 * WebKitLauncher/Info.plist: 14687 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: 14688 * WebKitLauncher/WebKitNightlyEnablerSparkle.m: 14689 (initializeSparkle): 14690 * WebKitLauncher/nightly.webkit.org.public.pem: Added. 14691 146922009-08-21 Jan Michael Alonzo <jmalonzo@webkit.org> 14693 14694 Rubberstamped by Simon Fraser. 14695 14696 Remove GNOME keyring support in build-webkit. This dependency's 14697 already been removed in the Gtk port. 14698 14699 * Scripts/build-webkit: 14700 147012009-08-20 Brian Weinstein <bweinstein@apple.com> 14702 14703 Reviewed by Adam Roben. 14704 Based on original patch by Stephanie Lewis. 14705 14706 Added support of the Windows malloc history format to parse-malloc history, so we can 14707 read and parse it. 14708 14709 * Scripts/parse-malloc-history: 14710 147112009-08-20 Chris Fleizach <cfleizach@apple.com> 14712 14713 Reviewed by Darin Adler. 14714 14715 Enable various "grouping" ARIA roles 14716 https://bugs.webkit.org/show_bug.cgi?id=28486 14717 14718 Expose the ability to retrieve the subrole through accessibility for DRT. 14719 14720 * DumpRenderTree/AccessibilityUIElement.cpp: 14721 * DumpRenderTree/AccessibilityUIElement.h: 14722 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 14723 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 14724 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 14725 147262009-08-20 Joseph Pecoraro <joepeck@webkit.org> 14727 14728 Unreviewed. 14729 14730 Added myself as a committer. 14731 14732 * Scripts/modules/committers.py: 14733 147342009-08-20 Xan Lopez <xlopez@igalia.com> 14735 14736 Reviewed by Gustavo Noronha. 14737 14738 Fix memory leaks. 14739 14740 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14741 (LayoutTestController::whiteListAccessFromOrigin): 14742 (LayoutTestController::pauseAnimationAtTimeOnElementWithId): 14743 (LayoutTestController::pauseTransitionAtTimeOnElementWithId): 14744 147452009-08-20 Eric Seidel <eric@webkit.org> 14746 14747 Reviewed by Adam Barth. 14748 14749 bugzilla-tool post-diff can post partial diffs from SVN checkouts. 14750 https://bugs.webkit.org/show_bug.cgi?id=28445 14751 14752 Pass the checkout root as the cwd. Also wrote a test to ensure this. 14753 14754 * Scripts/modules/scm.py: 14755 * Scripts/modules/scm_unittest.py: 14756 147572009-08-20 Mark Rowe <mrowe@apple.com> 14758 14759 Reviewed by Adele Peterson. 14760 14761 Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue. 14762 14763 * DumpRenderTree/AccessibilityUIElement.cpp: 14764 (attributeValueCallback): 14765 147662009-08-20 Ariya Hidayat <ariya.hidayat@nokia.com> 14767 14768 Unreviewed, build fix. 14769 14770 [Qt] The template-based qMax() compares two qreals. 14771 14772 * DumpRenderTree/qt/ImageDiff.cpp: 14773 (main): 14774 147752009-08-20 David Levin <levin@chromium.org> 14776 14777 Reviewed by David Kilzer. 14778 14779 bugzilla-tool patch retrieval should handle 302 redirects. 14780 https://bugs.webkit.org/show_bug.cgi?id=28485 14781 14782 * Scripts/modules/scm.py: Pass the --location parameter to curl 14783 so that 302's are followed. 14784 147852009-08-20 Aaron Boodman <aa@chromium.org> 14786 14787 One more speculative build for gtk. 14788 14789 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14790 147912009-08-20 Aaron Boodman <aa@chromium.org> 14792 14793 Speculative build for gtk. 14794 14795 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14796 (LayoutTestController::whiteListAccessFromOrigin): 14797 147982009-08-20 Mark Rowe <mrowe@apple.com> 14799 14800 Ignore some leaks that are known to originate from ImageIO. 14801 14802 * Scripts/run-webkit-tests: 14803 148042009-08-20 Aaron Boodman <aa@chromium.org> 14805 14806 With David Levin. 14807 14808 Speculative build fix for qt. 14809 14810 * DumpRenderTree/qt/jsobjects.cpp: 14811 (LayoutTestController::whiteListAccessFromOrigin): 14812 * DumpRenderTree/qt/jsobjects.h: 14813 148142009-08-19 Mark Rowe <mrowe@apple.com> 14815 14816 Reviewed by Dan Bernstein. 14817 14818 Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot 14819 14820 Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit. 14821 14822 * Scripts/check-for-global-initializers: 14823 148242009-08-19 Aaron Boodman <aa@chromium.org> 14825 14826 Reviewed by David Levin. 14827 14828 https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to 14829 specify a more granular policy for cross-origin XHR access. 14830 14831 * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests. 14832 (whiteListAccessFromOriginCallback): Ditto. 14833 (LayoutTestController::staticFunctions): Ditto. 14834 * DumpRenderTree/LayoutTestController.h: Ditto. 14835 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto. 14836 (LayoutTestController::whiteListAccessToOrigin): Ditto. 14837 * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto. 14838 (LayoutTestController::whiteListAccessFromOrigin): Ditto. 14839 * DumpRenderTree/qt/jsobjects.cpp: Ditto. 14840 (LayoutTestController::whiteListAccessFromOrigin): Ditto. 14841 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin(). 14842 (LayoutTestController::whiteListAccessFromOrigin): Ditto. 14843 * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test. 14844 (resetWebViewToConsistentStateBeforeTesting): Ditto. 14845 * DumpRenderTree/mac/DumpRenderTree.mm: Ditto. 14846 (resetWebViewToConsistentStateBeforeTesting): Ditto. 14847 * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto. 14848 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto. 14849 148502009-08-19 Mark Rowe <mrowe@apple.com> 14851 14852 Rubber-stamped by Dan Bernstein. 14853 14854 Ignore some leaks that are known to originate from QTKit. 14855 14856 * Scripts/run-webkit-tests: 14857 148582009-08-19 Eric Seidel <eric@webkit.org> 14859 14860 Reviewed by Adam Barth. 14861 14862 commit-queue/bugzilla-tool can get wedged if git is mid-rebase 14863 https://bugs.webkit.org/show_bug.cgi?id=28436 14864 14865 Make clean_working_directory cancel rebases too (even though that's a bit of a hack). 14866 This code will only ever be run when --force-clean is passed. 14867 14868 I also added a new unit test to make sure this code actually works. :) 14869 14870 * Scripts/modules/scm.py: 14871 * Scripts/modules/scm_unittest.py: 14872 148732009-08-19 Eric Seidel <eric@webkit.org> 14874 14875 Reviewed by David Levin. 14876 14877 WebKit needs a changelogs.py to hold changelog-related code 14878 https://bugs.webkit.org/show_bug.cgi?id=28477 14879 14880 This is moving code and adding tests. There was only one functional 14881 change (which was removing a trailing newline from the last_entry() result). 14882 14883 * Scripts/bugzilla-tool: 14884 * Scripts/modules/changelogs.py: Added. 14885 * Scripts/modules/changelogs_unittest.py: Added. 14886 * Scripts/run-webkit-unittests: 14887 148882009-08-20 Eric Seidel <eric@webkit.org> 14889 14890 Reviewed by Adam Barth. 14891 14892 bugzilla-tool needs a way to ask build.webkit.org if the bots are passing 14893 https://bugs.webkit.org/show_bug.cgi?id=28222 14894 14895 Basic support for now. This has been in testing for 24 hours now and worked great! 14896 14897 * Scripts/bugzilla-tool: 14898 * Scripts/modules/buildbot.py: Added. 14899 * Scripts/modules/buildbot_unittest.py: Added. 14900 * Scripts/run-webkit-unittests: 14901 149022009-08-19 Jan Michael Alonzo <jmalonzo@webkit.org> 14903 14904 Reviewed by Gustavo Noronha. 14905 14906 [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the 14907 default timeout used by run-webkit-tests. Mac and Win ports were 14908 recently bumped in http://trac.webkit.org/changeset/r47465. 14909 14910 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 14911 (LayoutTestController::setWaitToDump): 14912 149132009-08-19 David D. Kilzer <ddkilzer@webkit.org> 14914 14915 DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger 14916 14917 Reviewed by Mark Rowe. 14918 14919 Provide pre-generated swig source files for Tiger so it may 14920 benefit from the faster run-webkit-tests. 14921 14922 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: 14923 Generated by swig. 14924 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added. 14925 Generated by swig. 14926 (swig_type_info::SWIG_TypeNameComp): 14927 (swig_type_info::SWIG_TypeEquiv): 14928 (swig_type_info::SWIG_TypeRegisterTL): 14929 (swig_type_info::SWIG_TypeCheck): 14930 (swig_type_info::SWIG_TypeCast): 14931 (swig_type_info::SWIG_TypeDynamicCast): 14932 (swig_type_info::SWIG_TypeName): 14933 (swig_type_info::SWIG_TypePrettyName): 14934 (swig_type_info::SWIG_TypeQueryTL): 14935 (swig_type_info::SWIG_TypeClientDataTL): 14936 (swig_type_info::SWIG_PackData): 14937 (swig_type_info::SWIG_UnpackData): 14938 (swig_type_info::SWIG_PropagateClientDataTL): 14939 (swig_type_info::SWIG_PackVoidPtr): 14940 (swig_type_info::SWIG_UnpackVoidPtr): 14941 (swig_type_info::SWIG_PackDataName): 14942 (swig_type_info::SWIG_UnpackDataName): 14943 * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on 14944 Tiger using pre-generated files. 14945 149462009-08-18 Shinichiro Hamaji <hamaji@chromium.org> 14947 14948 Reviewed by David Kilzer. 14949 14950 run-webkit-tests hangs when WebCore tries to log too much 14951 https://bugs.webkit.org/show_bug.cgi?id=15743 14952 14953 Read stdout and stderr in parallel. 14954 14955 * Scripts/run-webkit-tests: 14956 149572009-08-18 Mark Rowe <mrowe@apple.com> 14958 14959 Rubber-stamped by Oliver Hunt. 14960 14961 Add a new build configuration that checks for leaks during the layout tests, 14962 and hook a new machine up to it. 14963 14964 * BuildSlaveSupport/build.webkit.org-config/config.json: 14965 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 14966 149672009-08-18 Aaron Boodman <aa@chromium.org> 14968 14969 Reviewed by Maciej Stachowiak. 14970 14971 https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests. 14972 14973 No new tests: Already covered by existing tests. 14974 14975 * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest. 14976 149772009-08-18 Mark Rowe <mrowe@apple.com> 14978 14979 Rubber-stamped by Geoff Garen. 14980 14981 Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests. 14982 14983 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 14984 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 14985 149862009-08-18 Brian Weinstein <bweinstein@apple.com> 14987 14988 Rubber-stamped by Adam Roben. 14989 14990 Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them, 14991 and removed include to fix building on VC++ Express. 14992 14993 * DumpRenderTree/win/UIDelegate.cpp: 14994 (UIDelegate::exceededDatabaseQuota): 14995 149962009-08-18 Brian Weinstein <bweinstein@apple.com> 14997 14998 Reviewed by Oliver Hunt. 14999 15000 Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support 15001 LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota. 15002 15003 Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface. 15004 Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac. 15005 15006 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 15007 (LayoutTestController::setDatabaseQuota): 15008 * DumpRenderTree/win/UIDelegate.cpp: 15009 (UIDelegate::exceededDatabaseQuota): 15010 150112009-08-18 Peter Kasting <pkasting@google.com> 15012 15013 Reviewed by Eric Seidel. 15014 15015 https://bugs.webkit.org/show_bug.cgi?id=28415 15016 Set svn:eol-style CRLF on all .sln and .vcproj files that don't already 15017 have it. 15018 15019 * record-memory-win/record-memory-win.vcproj: 15020 * WinLauncher/WinLauncher.vcproj: 15021 * WebKitLauncherWin/WebKitLauncherWin.vcproj: 15022 * DumpRenderTree/win/ImageDiff.vcproj: 15023 * FindSafari/FindSafari.vcproj: 15024 150252009-08-18 Drew Wilson <atwilson@google.com> 15026 15027 Reviewed by Eric Seidel. 15028 15029 Need to extend DumpRenderTree to expose number of worker threads 15030 https://bugs.webkit.org/show_bug.cgi?id=28292 15031 15032 Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit. 15033 15034 * DumpRenderTree/LayoutTestController.cpp: 15035 (getWorkerThreadCountCallback): 15036 (LayoutTestController::staticValues): 15037 * DumpRenderTree/LayoutTestController.h: 15038 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15039 (LayoutTestController::workerThreadCount): 15040 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 15041 (LayoutTestController::workerThreadCount): 15042 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 15043 (LayoutTestController::workerThreadCount): 15044 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 15045 (LayoutTestController::workerThreadCount): 15046 150472009-08-18 Xan Lopez <xlopez@igalia.com> 15048 15049 Reviewed by Jan Alonzo. 15050 15051 Initialize x and y in the GtkAllocation structure to shut up 15052 valgrind. 15053 15054 * DumpRenderTree/gtk/DumpRenderTree.cpp: 15055 (runTest): 15056 150572009-08-17 Shinichiro Hamaji <hamaji@chromium.org> 15058 15059 Reviewed by Darin Adler. 15060 15061 Some HTMLs are modified by make-script-test-wrappers 15062 https://bugs.webkit.org/show_bug.cgi?id=28213 15063 15064 Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into 15065 the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and 15066 re-generated wml/* and Geolocation/* . 15067 15068 * Scripts/make-script-test-wrappers: 15069 150702009-08-17 Shinichiro Hamaji <hamaji@chromium.org> 15071 15072 Reviewed by Eric Seidel. 15073 15074 -webkit-box-orient:horizontal doesn't work on <button> tag 15075 https://bugs.webkit.org/show_bug.cgi?id=34445 15076 15077 Make a flexible button's anonymous child flexible and pass the 15078 parent's box-orient to the anonymous child. 15079 15080 Also, added a renderName for anonymous flexible boxes. 15081 15082 * Scripts/make-script-test-wrappers: 15083 150842009-08-17 Eric Seidel <eric@webkit.org> 15085 15086 Reviewed by Darin Adler. 15087 15088 Can no longer --reset-results of a layout test directory 15089 https://bugs.webkit.org/show_bug.cgi?id=28336 15090 15091 --reset-results and --exit-after-n-failures are incompatible. 15092 15093 * Scripts/run-webkit-tests: 15094 150952009-08-17 David Kilzer <ddkilzer@apple.com> 15096 15097 <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git 15098 15099 Reviewed by Adam Roben. 15100 15101 New commit message: 15102 Committed r12345: <http://trac.webkit.org/changeset/12345> 15103 15104 * Scripts/bugzilla-tool: 15105 (bug_comment_from_commit_text): Print out a compact, 15106 standardized commit message for both git and svn. 15107 151082009-08-17 Peter Kasting <pkasting@google.com> 15109 15110 Reviewed by Steve Falkenburg. 15111 15112 https://bugs.webkit.org/show_bug.cgi?id=27323 15113 Only add Cygwin to the path when it isn't already there. This avoids 15114 causing problems for people who purposefully have non-Cygwin versions of 15115 executables like svn in front of the Cygwin ones in their paths. 15116 15117 * DumpRenderTree/win/DumpRenderTree.vcproj: 15118 * DumpRenderTree/win/ImageDiff.vcproj: 15119 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 15120 151212009-08-17 David Kilzer <ddkilzer@apple.com> 15122 15123 <http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN() 15124 15125 Reviewed by David Levin. 15126 15127 * Scripts/modules/cpp_style.py: 15128 (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'. 15129 (check_max_min_macros): Added. Returns level 4 error when MAX() 15130 and MIN() macros are used in header files and C++ source files. 15131 (check_style): Added call to check_max_min_macros(). 15132 * Scripts/modules/cpp_style_unittest.py: Added unit tests. 15133 (test_max_macro): Added. 15134 (test_min_macro): Added. 15135 151362009-08-13 Mike Fenton <mike.fenton@torchmobile.com> 15137 15138 Reviewed by Eric Seidel. 15139 15140 Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp 15141 and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp. 15142 15143 https://bugs.webkit.org/show_bug.cgi?id=28268 15144 15145 * platform/graphics/GraphicsContext.cpp: 15146 (WebCore::GraphicsContext::adjustLineToPixelBoundaries): 15147 * platform/graphics/GraphicsContext.h: 15148 * platform/graphics/cairo/GraphicsContextCairo.cpp: 15149 * platform/graphics/qt/GraphicsContextQt.cpp: 15150 151512009-08-10 Mike Fenton <mike.fenton@torchmobile.com> 15152 15153 Reviewed by Adam Treat. 15154 15155 Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and 15156 WebKit style guide. 15157 15158 https://bugs.webkit.org/show_bug.cgi?id=28161 15159 15160 * DumpRenderTree/qt/jsobjects.cpp: 15161 (findFrameNamed): 15162 (LoadItem::invoke): 15163 (LayoutTestController::provisionalLoad): 15164 (LayoutTestController::timerEvent): 15165 (LayoutTestController::pauseAnimationAtTimeOnElementWithId): 15166 (LayoutTestController::pauseTransitionAtTimeOnElementWithId): 15167 (LayoutTestController::numberOfActiveAnimations): 15168 (EventSender::keyDown): 15169 (EventSender::frameUnderMouse): 15170 (TextInputController::doCommand): 15171 151722009-08-16 David Kilzer <ddkilzer@apple.com> 15173 15174 <http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements 15175 15176 Reviewed by David Levin. 15177 15178 In <http://webkit.org/b/28355#c1>, it was noted that new source 15179 files use 'using namespace std;' instead of individual 15180 'using std::foo;' statements. This adds a level 4 check for 15181 such statements. 15182 15183 * Scripts/modules/cpp_style.py: 15184 (_ERROR_CATEGORIES): Added 'build/using_std'. 15185 (check_using_std): Added. 15186 (check_style): Added call to check_using_std(). 15187 * Scripts/modules/cpp_style_unittest.py: 15188 (WebKitStyleTest.test_using_std): Added unit test. 15189 151902009-08-16 David Kilzer <ddkilzer@apple.com> 15191 15192 Backed out r47343 which was mistakenly committed 15193 15194 * Scripts/bugzilla-tool: 15195 * Scripts/modules/scm.py: 15196 151972009-08-16 David Kilzer <ddkilzer@apple.com> 15198 15199 <http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class 15200 15201 Reviewed by David Levin. 15202 15203 The ScriptError class doesn't exist in bugzilla.py, so any 15204 errors print error messages about ScriptError instead of the 15205 actual error: 15206 15207 NameError: global name 'ScriptError' is not defined 15208 15209 * Scripts/modules/bugzilla.py: 15210 (BugzillaError): Added class. Modeled after ScriptError class 15211 in scm.py. 15212 (Bugzilla.authenticate): Changed to use BugzillaError instead of 15213 ScriptError. 15214 (Bugzilla._check_create_bug_response): Ditto. 15215 152162009-08-14 Adam Bergkvist <adam.bergkvist@ericsson.com> 15217 15218 Reviewed by Sam Weinig. 15219 15220 Added EventSource to the build script (default on). 15221 https://bugs.webkit.org/show_bug.cgi?id=14997 15222 15223 * Scripts/build-webkit: 15224 152252009-08-15 Ryosuke Niwa <rniwa@webkit.org> 15226 15227 Unreviewed. 15228 15229 Add myself to list of committers. 15230 15231 * Scripts/modules/committers.py: 15232 152332009-08-15 Jon Honeycutt <jhoneycutt@apple.com> 15234 15235 Fix layout test failures after r47312. 15236 15237 Reviewed by Cameron Zwarich. 15238 15239 * DumpRenderTree/AccessibilityController.h: 15240 Replaced logFocusEvents() with setLogFocusEvents(), which takes a 15241 boolean argument to turn logging of focus events on or off. 15242 Added a function to reset the AccessibilityController to a consistent 15243 state. 15244 15245 * DumpRenderTree/AccessibilityController.cpp: 15246 (logFocusEventsCallback): 15247 Call setLogFocusEvents() to enable logging. 15248 (AccessibilityController::resetToConsistentState): 15249 Call setLogFocusEvents() to disable logging. 15250 15251 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 15252 (AccessibilityController::setLogFocusEvents): 15253 Update stub. 15254 15255 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 15256 (AccessibilityController::setLogFocusEvents): 15257 Update stub. 15258 15259 * DumpRenderTree/mac/DumpRenderTree.mm: 15260 (resetWebViewToConsistentStateBeforeTesting): 15261 Call the FrameLoadDelegate's resetToConsistentState method. 15262 15263 * DumpRenderTree/mac/FrameLoadDelegate.h: 15264 Declare the resetToConsistentState method. 15265 15266 * DumpRenderTree/mac/FrameLoadDelegate.mm: 15267 (-[FrameLoadDelegate resetToConsistentState]): 15268 Call the AccessibilityController's resetToConsistentState() function. 15269 15270 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 15271 (AccessibilityController::~AccessibilityController): 15272 Turn off focus event logging when the controller is destroyed. 15273 (AccessibilityController::setLogFocusEvents): 15274 If the caller passes false, unhook the focus event, and clear 15275 m_focusEventHook. 15276 15277 * DumpRenderTree/win/DumpRenderTree.cpp: 15278 (resetWebViewToConsistentStateBeforeTesting): 15279 Call the FrameLoadDelegate's resetToConsistentState function. 15280 15281 * DumpRenderTree/win/FrameLoadDelegate.h: 15282 Declare the resetToConsistentState() function. 15283 15284 * DumpRenderTree/win/FrameLoadDelegate.cpp: 15285 (FrameLoadDelegate::resetToConsistentState): 15286 Call the AccessibilityController's resetToConsistentState() function. 15287 15288 152892009-08-14 Jon Honeycutt <jhoneycutt@apple.com> 15290 15291 Add a mechanism for logging MSAA focus events. 15292 15293 Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit 15294 nightly (20866) 15295 15296 https://bugs.webkit.org/show_bug.cgi?id=20866 15297 15298 Reviewed by Oliver Hunt. 15299 15300 * DumpRenderTree/AccessibilityController.cpp: 15301 (logFocusEventsCallback): 15302 Call the AccessibilityController's logFocusEvents() function. 15303 (AccessibilityController::getJSClass): 15304 Add a "logFocusEvents" function to the AccessibilityController's JS 15305 class definition. 15306 15307 * DumpRenderTree/AccessibilityController.h: 15308 On Windows, include windows.h, and add a member variable to hold the 15309 handle to the event hook for focus events. Add a declaration for a 15310 function that enables logging of focus events. 15311 15312 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: 15313 (AccessibilityController::logFocusEvents): 15314 Stubbed. 15315 15316 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 15317 (AccessibilityController::logFocusEvents): 15318 Stubbed. 15319 15320 * DumpRenderTree/win/AccessibilityControllerWin.cpp: 15321 (AccessibilityController::AccessibilityController): 15322 (AccessibilityController::~AccessibilityController): 15323 If we hooked the focus event, unhook it. 15324 (logFocusEventProc): 15325 When we receive a focus event, get the accessible object for the event, 15326 and log its name to stdout. 15327 (AccessibilityController::logFocusEvents): 15328 Setup the focus event hook to listen for events in the current process. 15329 153302009-08-14 Eric Seidel <eric@webkit.org> 15331 15332 No review. Fix 5-space indent to be 4-spaces. 15333 15334 * Scripts/bugzilla-tool: 15335 153362009-08-14 Laszlo Gombos <laszlo.1.gombos@nokia.com> 15337 15338 Reviewed by Simon Hausmann. 15339 15340 [Qt] Public API to configure the storage path for HTML5 localStorage 15341 https://bugs.webkit.org/show_bug.cgi?id=28036 15342 15343 Turn on LocalStorage support for Qt DumpRenderTree since 15344 LocalStorage is now disabled by defult for QtWebkit. 15345 15346 * DumpRenderTree/qt/DumpRenderTree.cpp: 15347 (WebCore::WebPage::WebPage): 15348 153492009-08-14 Xan Lopez <xlopez@igalia.com> 15350 15351 Reviewed by Jan Alonzo. 15352 15353 Do not unref the main webview, it's owned by its parent 15354 container. Instead destroy the container, which should take care 15355 of everything (not terribly important since we exit right after 15356 that, but still). 15357 15358 * DumpRenderTree/gtk/DumpRenderTree.cpp: 15359 (main): 15360 153612009-08-13 Eric Seidel <eric@webkit.org> 15362 15363 No review, correcting obvious python error seen in the commit queue. 15364 15365 args can be a string or an array. Assuming args is always an array results in 15366 double-spaced text in error logs. 15367 15368 * Scripts/bugzilla-tool: 15369 153702009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 15371 15372 Unreviewed build fix. Include stdio.h for using stdout, stderr, 15373 and fprintf. 15374 15375 * DumpRenderTree/LayoutTestController.cpp: 15376 153772009-08-13 Shinichiro Hamaji <hamaji@chromium.org> 15378 15379 Reviewed by Eric Seidel. 15380 15381 rename make-js-test-wrappers to make-script-test-wrappers 15382 https://bugs.webkit.org/show_bug.cgi?id=28212 15383 15384 * Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers. 15385 153862009-08-13 Drew Wilson <atwilson@chromium.org> 15387 15388 Unreviewed. 15389 15390 Add myself to list of committers. 15391 15392 * Scripts/modules/committers.py: 15393 153942009-08-13 John Sullivan <sullivan@apple.com> 15395 15396 Unreviewed. 15397 15398 Add myself to list of committers. 15399 15400 * Scripts/modules/committers.py: 15401 154022009-08-13 Eric Seidel <eric@webkit.org> 15403 15404 Correct spelling error in file name. No review. 15405 15406 * Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py. 15407 * Scripts/run-webkit-unittests: 15408 154092009-08-13 Eric Seidel <eric@webkit.org> 15410 15411 Reviewed by Simon Fraser. 15412 15413 REGRESSION(r47175): error running run-webkit-tests 15414 https://bugs.webkit.org/show_bug.cgi?id=28261 15415 15416 Fix "Use of uninitialized value in concatenation (.) or string at 15417 WebKitTools/Scripts/run-webkit-tests line 191." by setting 15418 $testsPerDumpTool to 1000 by default. 15419 15420 * Scripts/run-webkit-tests: 15421 154222009-08-13 Nate Chapin <japhet@chromium.org> 15423 15424 Unreviewed. 15425 15426 Add myself to list of committers. 15427 15428 * Scripts/modules/committers.py: 15429 154302009-08-13 Brent Fulgham <bfulgham@webkit.org> 15431 15432 Unreviewed. 15433 15434 Add 'Brent Fulgham' to the committers list. 15435 15436 * Scripts/modules/committers.py: 15437 154382009-08-13 Adam Langley <agl@chromium.org> 15439 15440 Review not required. 15441 15442 * Scripts/modules/committers.py: 15443 Adding myself to this list because Eric told me to. 15444 154452009-08-13 Greg Bolsinga <bolsinga@apple.com> 15446 15447 Unreviewed. 15448 15449 Add 'Greg Bolsinga' to the committers list. 15450 15451 * Scripts/modules/committers.py: 15452 154532009-08-13 Adam Roben <aroben@apple.com> 15454 15455 Fix off-by-one result comparisons in media tests on Windows Debug 15456 builds 15457 15458 media/video-played.html seems always to time out in Windows Debug 15459 builds. A race condition between media/video-test.js's "hang" timer and 15460 DumpRenderTree's built-in "watchdog" timer was causing results for 15461 media/video-played.html to be printed twice, causing all future media 15462 tests to be compared to the previous test's results. 15463 15464 The fix is to make the watchdog timer got through the same code path 15465 as calling notifyDone manually, so that the results will only get 15466 printed once. A subsequent patch will remove video-test.js's hang 15467 timer entirely, since it is redundant. 15468 15469 Fixes <http://webkit.org/b/28265>. 15470 15471 Reviewed by Mark Rowe. 15472 15473 * DumpRenderTree/LayoutTestController.cpp: 15474 (LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came 15475 from Gtk/Mac/Win's watchdog timer handlers, but we now call 15476 notifyDone() instead of dump() so that a subsequent call to 15477 notifyDone() won't print the results out again. 15478 15479 * DumpRenderTree/LayoutTestController.h: Added 15480 waitToDumpWatchdogTimerFired. 15481 15482 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15483 (waitToDumpWatchdogFired): 15484 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 15485 (waitUntilDoneWatchdogFired): 15486 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 15487 (waitUntilDoneWatchdogFired): 15488 Changed to call waitToDumpWatchdogTimerFired. 15489 154902009-08-13 Eric Carlson <eric.carlson@apple.com> 15491 15492 Unreviewed. 15493 15494 Added 'Eric Carlson' to the committers list. 15495 15496 * Scripts/modules/committers.py: 15497 154982009-08-13 Dirk Schulze <krit@webkit.org> 15499 15500 Unreviewed. 15501 Added 'Dirk Schulze' to the committers list. 15502 15503 * Scripts/modules/committers.py: 15504 155052009-08-13 Adam Roben <aroben@apple.com> 15506 15507 Enable running testapi in run-javascriptcore-tests on Windows 15508 15509 Fixes <http://webkit.org/b/24856> run-javascriptcore-tests should run 15510 testapi on Windows 15511 15512 Reviewed by Mark Rowe. 15513 15514 * Scripts/run-javascriptcore-tests: Allow testapi to run if we're in 15515 the AppleWinWebKit configuration. 15516 155172009-08-13 Adam Roben <aroben@apple.com> 15518 15519 Re-enable testapi in run-javascriptcore-tests on Mac 15520 15521 This seems to have been mistakenly disabled in r47089. 15522 15523 Rubber-stamped by Mark Rowe. 15524 15525 * Scripts/run-javascriptcore-tests: Removed comment markers that were 15526 preventing running testapi. 15527 155282009-08-12 George Staikos <george.staikos@torchmobile.com> 15529 15530 Reviewed by Adam Treat. 15531 15532 Enable WCSS and XHTML-MP flags for build-webkit. 15533 15534 * Scripts/build-webkit: 15535 155362009-08-12 David Kilzer <ddkilzer@apple.com> 15537 15538 run-webkit-tests: document --nthly flag in help message 15539 15540 Reviewed by Simon Fraser. 15541 15542 * Scripts/run-webkit-tests: Added --nthly flag to $usage string. 15543 Also noted that -1|--singly implies --nthly 1. 15544 155452009-08-12 Eric Seidel <eric@webkit.org> 15546 15547 No review, just fixing mismerged ChangeLogs. 15548 155492009-08-12 Eric Seidel <eric@webkit.org> 15550 15551 Reviewed by Mark Rowe. 15552 15553 run-webkit-tests needs a --exit-after-failures=N option 15554 https://bugs.webkit.org/show_bug.cgi?id=28192 15555 15556 Added the option and deployed it to bugzilla-tool. 15557 15558 * Scripts/bugzilla-tool: 15559 * Scripts/run-webkit-tests: 15560 155612009-08-11 Eric Seidel <eric@webkit.org> 15562 15563 Reviewed by Mark Rowe. 15564 15565 bugzilla-tool : various improvements for running the commit-queue 15566 https://bugs.webkit.org/show_bug.cgi?id=28199 15567 15568 Make run_and_throw_if_fail silence STDERR as well as STDIN. 15569 I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion). 15570 Change a few "print" statements to "log" so they appear in the output. 15571 Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects). 15572 Added a little more logging so that --quiet mode is easier to understand. 15573 Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well. 15574 Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc. 15575 Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer. 15576 Made curl call (downloading patch files) quieter. 15577 15578 * Scripts/bugzilla-tool: 15579 * Scripts/modules/bugzilla.py: 15580 * Scripts/modules/scm.py: 15581 155822009-08-12 Peter Kasting <pkasting@google.com> 15583 15584 Reviewed by Darin Adler. 15585 15586 https://bugs.webkit.org/show_bug.cgi?id=27323 15587 Change pattern that strips all trailing whitespace to just remove EOL 15588 chars (\r, \n), to make it clear that varying EOL chars is the primary 15589 problem being solved. 15590 15591 * Scripts/prepare-ChangeLog: 15592 * Scripts/resolve-ChangeLogs: 15593 * Scripts/svn-create-patch: 15594 * Scripts/update-webkit: 15595 155962009-08-12 Kevin Ollivier <kevino@theolliviers.com> 15597 15598 wx waf build fix, add new directories to the build. 15599 15600 * wx/build/settings.py: 15601 156022009-08-11 Adam Roben <aroben@apple.com> 15603 15604 Update DumpRenderTree for IWebUIDelegatePrivate changes 15605 15606 Reviewed by Dave Hyatt. 15607 15608 * DumpRenderTree/win/UIDelegate.h: Updated to match 15609 IWebUIDelegatePrivate. 15610 156112009-08-12 Adam Roben <aroben@apple.com> 15612 15613 Don't try to seek to the end of stdin on Cygwin 15614 15615 Doing so seems to always cause an exception (for unknown reasons). 15616 15617 Fixes <http://webkit.org/b/28159> create-bug throws an exception in 15618 Cygwin 15619 15620 Reviewed by Dave Kilzer. 15621 15622 * Scripts/bugzilla-tool: 15623 (CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors 15624 generated by calling sys.stdin.seek, since these seem to be generated 15625 for no good reason on Cygwin. 15626 156272009-08-12 Adam Roben <aroben@apple.com> 15628 15629 Don't raise an exception when --cc is not passed to create-bug 15630 15631 Fixes <http://webkit.org/b/28158> create-bug throws an exception if 15632 --cc is not specified 15633 15634 Reviewed by Dave Kilzer. 15635 15636 * Scripts/modules/bugzilla.py: 15637 (Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC 15638 string was specified. Otherwise we'll generate an exception about the 15639 "cc" variable not being a string. 15640 156412009-08-11 Eric Seidel <eric@webkit.org> 15642 15643 Reviewed by Adam Barth. 15644 15645 bugzilla-tool : various improvements for running the commit-queue 15646 https://bugs.webkit.org/show_bug.cgi?id=28199 15647 15648 Make run_and_throw_if_fail silence STDERR as well as STDIN. 15649 I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the out 15650 Change a few "print" statements to "log" so they appear in the output. 15651 Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non 15652 Added a little more logging so that --quiet mode is easier to understand. 15653 Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well. 15654 Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc. 15655 Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer. 15656 Made curl call (downloading patch files) quieter. 15657 15658 * Scripts/bugzilla-tool: 15659 * Scripts/modules/bugzilla.py: 15660 * Scripts/modules/scm.py: 15661 156622009-08-11 Eric Seidel <eric@webkit.org> 15663 15664 No review, script regression fix only. 15665 15666 run-webkit-tests --quiet hangs 15667 https://bugs.webkit.org/show_bug.cgi?id=28202 15668 15669 Do a huge dance to get open3 to pipe to /dev/null w/o blocking. 15670 This was what I came up with after discussions in #perl. 15671 15672 * Scripts/run-webkit-tests: 15673 156742009-08-11 John Gregg <johnnyg@google.com> 15675 15676 Reviewed by Maciej Stachowiak. 15677 15678 Switch DumpRenderTree to contain a WebUIDelegate2, which extends 15679 WebUIDelegate, so that the notifications tests will still work. 15680 https://bugs.webkit.org/show_bug.cgi?id=28198 15681 15682 * DumpRenderTree/win/UIDelegate.h: 15683 156842009-08-11 Darin Adler <darin@apple.com> 15685 15686 Try to fix GTK build. 15687 15688 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 15689 (AccessibilityUIElement::stringForRange): Added. 15690 156912009-08-10 Mike Fenton <mike.fenton@torchmobile.com> 15692 15693 Reviewed by Adam Treat. 15694 15695 Add processing for string constants used by the tests to trigger 15696 common actions like up, down, left, right, etc. for the Qt 15697 implementation of DumpRenderTree. 15698 15699 Note this allows fast/forms/textarea-arrow-navigation.html to pass 15700 correctly. 15701 15702 https://bugs.webkit.org/show_bug.cgi?id=28161 15703 15704 * DumpRenderTree/qt/jsobjects.cpp: 15705 (EventSender::keyDown): 15706 157072009-08-11 Chris Fleizach <cfleizach@apple.com> 15708 15709 Reviewed by Darin Adler. 15710 15711 Bug 28200 - ListMarker should be included as part of the text value to parse 15712 https://bugs.webkit.org/show_bug.cgi?id=28200 15713 15714 Add the ability to retrieve a string given a plain NSRange. 15715 15716 * DumpRenderTree/AccessibilityUIElement.cpp: 15717 (stringForRangeCallback): 15718 (AccessibilityUIElement::getJSClass): 15719 * DumpRenderTree/AccessibilityUIElement.h: 15720 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 15721 (AccessibilityUIElement::valueDescription): 15722 (AccessibilityUIElement::stringForRange): 15723 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 15724 (AccessibilityUIElement::stringForRange): 15725 157262009-08-11 Dmitry Titov <dimich@chromium.org> 15727 15728 Reviewed by NOBODY (Speculative fix for the layout test failure). 15729 15730 Fix fast/dom/prototype-inheritance.html 15731 and fast/dom/prototype-inheritance-2.html 15732 broken on Windows by http://trac.webkit.org/changeset/47018 15733 15734 * DumpRenderTree/win/DumpRenderTree.cpp: 15735 (resetDefaultsToConsistentValues): enable app cache in Windows DRT. 15736 157372009-08-11 Eric Seidel <eric@webkit.org> 15738 15739 Reviewed by Adam Barth. 15740 15741 bugzilla-tool: Re-factor shared landing logic into helper class to share more code 15742 https://bugs.webkit.org/show_bug.cgi?id=28193 15743 15744 Added new WebKitLandingScripts class to hold this shared logic. 15745 Also added a view_source_url function to move more webkit-specific urls out of bugzilla-tool core. 15746 15747 * Scripts/bugzilla-tool: 15748 157492009-08-11 Kenneth Rohde Christiansen <kenneth@webkit.org> 15750 15751 Reviewed by Adam Treat. 15752 15753 Fix the current failures on the buildbot. 15754 15755 As Qt hooks up the maybeDump to loadFinished, we need to make 15756 sure that calling dump() will not call maybeDump on loadFinished. 15757 15758 As dump is called my emitting done() which calls dump() and then 15759 setting m_isLoading to false. So in the case m_isLoading is false, 15760 do not dump again. 15761 15762 The current code is confusing, and should be made more clear 15763 in another commit. 15764 15765 * DumpRenderTree/qt/jsobjects.cpp: 15766 (LayoutTestController::maybeDump): 15767 (LayoutTestController::notifyDone): 15768 157692009-08-11 John Gregg <johnnyg@google.com> 15770 15771 Reviewed by Maciej Stachowiak. 15772 15773 Add support for desktop notifications API to DumpRenderTree, 15774 and support for ENABLE_NOTIFICATIONS flag to build-webkit. 15775 15776 * DumpRenderTree/LayoutTestController.cpp: 15777 (grantDesktopNotificationPermissionCallback): 15778 (LayoutTestController::staticFunctions): 15779 (LayoutTestController::grantDesktopNotificationPermission): 15780 (LayoutTestController::checkDesktopNotificationPermission): 15781 * DumpRenderTree/LayoutTestController.h: 15782 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: Added. 15783 (DRTDesktopNotificationPresenter::DRTDesktopNotificationPresenter): 15784 (DRTDesktopNotificationPresenter::QueryInterface): 15785 (DRTDesktopNotificationPresenter::AddRef): 15786 (DRTDesktopNotificationPresenter::Release): 15787 (DRTDesktopNotificationPresenter::showDesktopNotification): 15788 (DRTDesktopNotificationPresenter::cancelDesktopNotification): 15789 (DRTDesktopNotificationPresenter::notificationDestroyed): 15790 (DRTDesktopNotificationPresenter::checkNotificationPermission): 15791 (DRTDesktopNotificationPresenter::requestNotificationPermission): 15792 * DumpRenderTree/win/DRTDesktopNotificationPresenter.h: Added. 15793 * DumpRenderTree/win/DumpRenderTree.vcproj: 15794 * DumpRenderTree/win/UIDelegate.cpp: 15795 (UIDelegate::UIDelegate): 15796 (UIDelegate::desktopNotificationsDelegate): 15797 * DumpRenderTree/win/UIDelegate.h: 15798 * Scripts/build-webkit: 15799 158002009-08-11 Peter Kasting <pkasting@google.com> 15801 15802 Reviewed by Darin Adler. 15803 15804 https://bugs.webkit.org/show_bug.cgi?id=27323 15805 Handle arbitrary line endings when manufacturing patches for additions 15806 with history. 15807 15808 * Scripts/svn-create-patch: 15809 158102009-08-11 Peter Kasting <pkasting@google.com> 15811 15812 Reviewed by Darin Adler. 15813 15814 https://bugs.webkit.org/show_bug.cgi?id=28183 15815 Support VS2008 as well as VS2005 in a few scripts. 15816 15817 * Scripts/pdevenv: Check both $VS80COMNTOOLS and $VS90COMNTOOLS. 15818 * Scripts/webkitdirs.pm: Use $VSINSTALLDIR if available instead of hardcoding the VS2005 dir. 15819 158202009-08-11 Eric Seidel <eric@webkit.org> 15821 15822 Reviewed by Adam Barth. 15823 15824 run-webkit-tests --quiet should not output build-dumprendertree output 15825 https://bugs.webkit.org/show_bug.cgi?id=28189 15826 15827 * Scripts/run-webkit-tests: 15828 158292009-08-11 Eric Seidel <eric@webkit.org> 15830 15831 Reviewed by Darin Adler. 15832 15833 Exception in land-patches 15834 https://bugs.webkit.org/show_bug.cgi?id=27962 15835 15836 Use ("%s" % object) instead of ("" + object). 15837 Added unit tests for logging.py. 15838 15839 * Scripts/modules/logging.py: 15840 * Scripts/modules/logging_unittest.py: Added. 15841 * Scripts/run-webkit-unittests: 15842 158432009-08-11 Dmitry Titov <dimich@chromium.org> 15844 15845 Reviewed by NOBODY (Windows layout tests fix). 15846 15847 Fix for layout tests failures. Need to initialize some preferences early 15848 because WebView on Windows uses them during create time. 15849 15850 * DumpRenderTree/win/DumpRenderTree.cpp: 15851 (main): 15852 158532009-08-11 Dmitry Titov <dimich@chromium.org> 15854 15855 Reviewed by Adam Roben. 15856 15857 Originally implemented by Glenn Wilson <gwilson@chromium.org>. 15858 15859 Added support for overriding default preferences per-test. 15860 See https://bugs.webkit.org/show_bug.cgi?id=20534 15861 15862 * DumpRenderTree/LayoutTestController.cpp: 15863 (overridePreferenceCallback): add wiring for layoutTestController.overridePreference. 15864 (LayoutTestController::staticFunctions): same. 15865 * DumpRenderTree/LayoutTestController.h: same. 15866 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 15867 (LayoutTestController::overridePreference): added empty overridePreference method. 15868 * DumpRenderTree/mac/DumpRenderTree.mm: implemented preference override. 15869 (resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test. 15870 (setDefaultsToConsistentValuesForTesting): new method, sets other details of testing environment, every time DRT starts. 15871 (resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues(). 15872 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 15873 (LayoutTestController::overridePreference): 15874 * DumpRenderTree/win/DumpRenderTree.cpp: 15875 (resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test. 15876 (resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues(). 15877 (createWebViewAndOffscreenWindow): same. 15878 (main): same. 15879 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 15880 (LayoutTestController::overridePreference): 15881 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 15882 (LayoutTestController::overridePreference): 15883 158842009-08-11 Brian Weinstein <bweinstein@apple.com> 15885 15886 Reviewed by Sam Weinig. 15887 15888 Added support for DRT to support arguments for eventSender.mouseDown and eventSender.mouseUp for Windows. 15889 https://bugs.webkit.org/show_bug.cgi?id=28166. 15890 15891 This is a step towards fixing fast/events/mouse-click-events.html on Windows. 15892 15893 * DumpRenderTree/win/EventSender.cpp: 15894 (mouseDownCallback): 15895 (mouseUpCallback): 15896 (replaySavedEvents): 15897 158982009-08-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 15899 15900 Reviewed by Simon Hausmann. 15901 15902 Build the TestNetscapePlugin on Qt/Mac 15903 15904 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 15905 159062009-08-11 Dmitry Titov <dimich@chromium.org> 15907 15908 Reviewed by NOBODY (build fix). 15909 15910 Attempt to fix the Windows test bot. Reverted r47015 caused one of the Windows 15911 bots that runs Layout Tests to save "JS disabled" and "default font 24pt" 15912 preferences permanently. Since these preferences are not initialized explicitly in DRT, 15913 almost all Layout tests are failing. Attempt to fix by explicit 15914 initialization of these into defaults (enabled, 16pt) at the beginning of the DRT. 15915 15916 * DumpRenderTree/win/DumpRenderTree.cpp: 15917 (main): see above. 15918 159192009-08-10 Steve Falkenburg <sfalken@apple.com> 15920 15921 Windows nightly fix. 15922 15923 Reviewed by Ada Chan. 15924 15925 * FindSafari/FindSafari.cpp: 15926 (_tmain): Copy Safari.dll if it exists. 15927 159282009-08-10 David Levin <levin@chromium.org> 15929 15930 Reviewed by David Kilzer. 15931 15932 check-webkit-style doesn't catch braces around single line statements when followed by else. 15933 https://bugs.webkit.org/show_bug.cgi?id=28164 15934 15935 * Scripts/modules/cpp_style.py: Added else to the regex that finds ending }'s when 15936 checking the no braces for "single lines" rule. 15937 * Scripts/modules/cpp_style_unittest.py: Added test case. 15938 159392009-08-10 David Kilzer <ddkilzer@apple.com> 15940 15941 <http://webkit.org/b/28163> bugzilla-tool: scm module should not import bugzilla module 15942 15943 Reviewed by David Levin. 15944 15945 * Scripts/bugzilla-tool: 15946 (parse_bug_id): Added. Moved from CommitMessage.parse_bug_id() 15947 in scm module. 15948 * Scripts/modules/scm.py: Removed import of bugzilla module. 15949 (CommitMessage.parse_bug_id): Deleted. 15950 159512009-08-10 Peter Kasting <pkasting@google.com> 15952 15953 Reviewed by David Kilzer. 15954 15955 https://bugs.webkit.org/show_bug.cgi?id=18599 15956 Work around apparent bug in abs2rel() with symlinked directories. 15957 15958 * Scripts/resolve-ChangeLogs: 15959 159602009-08-10 Dan Bernstein <mitz@apple.com> 15961 15962 Build fix 15963 15964 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 15965 (NPP_New): 15966 159672009-08-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 15968 15969 Reviewed by Simon Hausmann. 15970 15971 Fix a bunch of build warnings in TestNetscapePlugin 15972 15973 * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: 15974 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 15975 159762009-08-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 15977 15978 Reviewed by Adam Roben. 15979 15980 Allow TestNetscapePlugIn to fall back to the Carbon event model 15981 15982 Previously the plugin would fail, even though the Carbon event 15983 model was available. The only way to get the Carbon event model 15984 was to pass the "forcecarbon" argument in the test markup, but no 15985 tests were using this. 15986 15987 Now the plugin uses carbon either if it's forced, or if the Cocoa 15988 event model is not supported. 15989 15990 This helps us run most of the plugin tests on Qt/Mac, which still 15991 does not support the Cocoa event model. 15992 15993 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 15994 (NPP_New): 15995 159962009-08-08 Adam Barth <abarth@webkit.org> 15997 15998 Reviewed by Eric Seidel. 15999 16000 bugzilla-tool needs a --quiet option 16001 https://bugs.webkit.org/show_bug.cgi?id=28060 16002 16003 A first pass at a --quiet option. This doesn't do all the excting 16004 things we might want, but it addresses 80% of the use case. 16005 16006 * Scripts/bugzilla-tool: 16007 160082009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org> 16009 16010 Reviewed by Xan Lopez. 16011 16012 [Gtk] Enable accessibility in Gtk DRT 16013 https://bugs.webkit.org/show_bug.cgi?id=25989 16014 16015 Add Accessibility support to the GTK DRT. 16016 16017 * DumpRenderTree/AccessibilityUIElement.h: 16018 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Added. 16019 (AccessibilityController::AccessibilityController): 16020 (AccessibilityController::~AccessibilityController): 16021 (AccessibilityController::focusedElement): 16022 (AccessibilityController::rootElement): 16023 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Added. 16024 (AccessibilityUIElement::AccessibilityUIElement): 16025 (AccessibilityUIElement::~AccessibilityUIElement): 16026 (AccessibilityUIElement::getLinkedUIElements): 16027 (AccessibilityUIElement::getDocumentLinks): 16028 (AccessibilityUIElement::getChildren): 16029 (AccessibilityUIElement::getChildrenWithRange): 16030 (AccessibilityUIElement::childrenCount): 16031 (AccessibilityUIElement::elementAtPoint): 16032 (AccessibilityUIElement::getChildAtIndex): 16033 (AccessibilityUIElement::allAttributes): 16034 (AccessibilityUIElement::attributesOfLinkedUIElements): 16035 (AccessibilityUIElement::attributesOfDocumentLinks): 16036 (AccessibilityUIElement::titleUIElement): 16037 (AccessibilityUIElement::parentElement): 16038 (AccessibilityUIElement::attributesOfChildren): 16039 (AccessibilityUIElement::parameterizedAttributeNames): 16040 (AccessibilityUIElement::role): 16041 (AccessibilityUIElement::title): 16042 (AccessibilityUIElement::description): 16043 (AccessibilityUIElement::language): 16044 (AccessibilityUIElement::x): 16045 (AccessibilityUIElement::y): 16046 (AccessibilityUIElement::width): 16047 (AccessibilityUIElement::height): 16048 (AccessibilityUIElement::clickPointX): 16049 (AccessibilityUIElement::clickPointY): 16050 (AccessibilityUIElement::intValue): 16051 (AccessibilityUIElement::minValue): 16052 (AccessibilityUIElement::maxValue): 16053 (AccessibilityUIElement::valueDescription): 16054 (AccessibilityUIElement::isEnabled): 16055 (AccessibilityUIElement::insertionPointLineNumber): 16056 (AccessibilityUIElement::isActionSupported): 16057 (AccessibilityUIElement::isRequired): 16058 (AccessibilityUIElement::attributesOfColumnHeaders): 16059 (AccessibilityUIElement::attributesOfRowHeaders): 16060 (AccessibilityUIElement::attributesOfColumns): 16061 (AccessibilityUIElement::attributesOfRows): 16062 (AccessibilityUIElement::attributesOfVisibleCells): 16063 (AccessibilityUIElement::attributesOfHeader): 16064 (AccessibilityUIElement::indexInTable): 16065 (AccessibilityUIElement::rowIndexRange): 16066 (AccessibilityUIElement::columnIndexRange): 16067 (AccessibilityUIElement::lineForIndex): 16068 (AccessibilityUIElement::boundsForRange): 16069 (AccessibilityUIElement::cellForColumnAndRow): 16070 (AccessibilityUIElement::selectedTextRange): 16071 (AccessibilityUIElement::setSelectedTextRange): 16072 (AccessibilityUIElement::attributeValue): 16073 (AccessibilityUIElement::isAttributeSettable): 16074 (AccessibilityUIElement::increment): 16075 (AccessibilityUIElement::decrement): 16076 * DumpRenderTree/gtk/DumpRenderTree.cpp: 16077 (webViewWindowObjectCleared): 16078 (main): 16079 * GNUmakefile.am: 16080 160812009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org> 16082 16083 Unreviewed Gtk build fix. 16084 16085 DRT needs internal WTF symbols so we link to libJavaScriptCore.la 16086 too. Also don't force Gtk to use USE_SYSTEM_MALLOC. 16087 16088 * GNUmakefile.am: 16089 160902009-08-07 Darin Adler <darin@apple.com> 16091 16092 * Scripts/commit-log-editor: Fix unchecked access to environment 16093 variable that may not be there. 16094 160952009-08-07 Mark Rowe <mrowe@apple.com> 16096 16097 Handle the case where only a single test is missing results. 16098 16099 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 16100 161012009-08-07 George Wright <george.wright@torchmobile.com> 16102 16103 Reviewed by Adam Treat 16104 16105 Fix DumpRenderTree for the Qt port to always dump the PNG data unless 16106 the expected and actual hashes match. 16107 16108 https://bugs.webkit.org/show_bug.cgi?id=28077 16109 16110 * DumpRenderTree/qt/DumpRenderTree.cpp: 16111 (WebCore::DumpRenderTree::dump): 16112 161132009-08-07 Pierre d'Herbemont <pdherbemont@apple.com> 16114 16115 Reviewed by Eric Seidel. 16116 16117 commit-log-editor does not produce a git commit log that is git friendly. 16118 https://bugs.webkit.org/show_bug.cgi?id=27754 16119 16120 We make sure we end up with: 16121 - A first paragraph describing the bug. It is eventually prefixed by 16122 "WebKit: <line>" or "WebCore: <line>". This used to be 16123 "WebCore:\n\n<line>". 16124 - The Reviewed By line. 16125 - An eventual Patch By line if author and committer doesn't match. 16126 - The rest of the commit. 16127 16128 * Scripts/commit-log-editor: 16129 161302009-08-07 Adam Barth <abarth@webkit.org> 16131 16132 Unreviewed. (Darin Adler indicated he'd prefer if we landed these 16133 kinds of changes unreviewed, like editing the WebKit Team wiki page.) 16134 16135 Added Pierre d'Herbemont to list of committers. 16136 16137 * Scripts/modules/committers.py: 16138 161392009-08-07 Shinichiro Hamaji <hamaji@chromium.org> 16140 16141 Reviewed by Adele Peterson. 16142 16143 Cannot scroll for box-reflect:right 16144 https://bugs.webkit.org/show_bug.cgi?id=27979 16145 16146 Update m_overflowLeft an m_overflowWidth for reflection just like 16147 m_overflowTop and m_overflowHeight. 16148 16149 * Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflo 16150w-scroll.js 16151 161522009-08-06 Shinichiro Hamaji <hamaji@chromium.org> 16153 16154 Reviewed by Adam Barth. 16155 16156 box-shadow's spread is ignored with <table> 16157 https://bugs.webkit.org/show_bug.cgi?id=28017 16158 16159 Use RenderStyle::getBoxShadowExtent just like RenderBlock. 16160 16161 * Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflow-scroll.js 16162 161632009-08-06 Eric Seidel <eric@webkit.org> 16164 16165 No review, only changing make-js-test-wrappers. 16166 16167 Fix make-js-test-wrappers to ignore a few more js tests 16168 with custom templates. 16169 16170 * Scripts/make-js-test-wrappers: 16171 161722009-08-06 Chris Marrin <cmarrin@apple.com> 16173 16174 Reviewed by David Hyatt. 16175 16176 Added ENABLE_3D_CANVAS flag to build, default to off 16177 16178 * Scripts/build-webkit: 16179 161802009-08-05 Brady Eidson <beidson@apple.com> 16181 16182 Reviewed by Darin Adler. 16183 16184 Win DRT's resource load delegate is missing didReceiveResponse 16185 https://bugs.webkit.org/show_bug.cgi?id=28033 16186 16187 * DumpRenderTree/win/FrameLoadDelegate.cpp: 16188 Added: 16189 (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): 16190 (FrameLoadDelegate::willPerformClientRedirectToURL): 16191 (FrameLoadDelegate::didCancelClientRedirectForFrame): 16192 16193 Minor style cleanup: 16194 (FrameLoadDelegate::didStartProvisionalLoadForFrame): 16195 (FrameLoadDelegate::didReceiveTitle): 16196 (FrameLoadDelegate::didFinishLoadForFrame): 16197 (FrameLoadDelegate::willCloseFrame): 16198 (FrameLoadDelegate::didClearWindowObject): 16199 * DumpRenderTree/win/FrameLoadDelegate.h: 16200 162012009-08-05 Brady Eidson <beidson@apple.com> 16202 16203 Reviewed by Darin Adler. 16204 16205 Win DRT's resource load delegate is missing didReceiveResponse 16206 https://bugs.webkit.org/show_bug.cgi?id=28033 16207 16208 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 16209 (ResourceLoadDelegate::didReceiveResponse): 16210 * DumpRenderTree/win/ResourceLoadDelegate.h: 16211 162122009-08-05 Darin Fisher <darin@chromium.org> 16213 16214 Reviewed by Darin Adler. 16215 16216 Add layoutTestController.dumpWillCacheResponse 16217 https://bugs.webkit.org/show_bug.cgi?id=28010 16218 16219 willCacheResponse is only interesting for embedders of mainline WebKit on Mac. 16220 Splitting off a new dumpWillCacheResponse allows a number of existings tests 16221 to run across platforms. 16222 16223 The test that was specifically verifying willCacheResponse now calls 16224 dumpWillCacheResponse. 16225 16226 * DumpRenderTree/LayoutTestController.cpp: Add dumpWillCacheResponse 16227 (LayoutTestController::LayoutTestController): 16228 (dumpWillCacheResponseCallback): 16229 (LayoutTestController::staticFunctions): 16230 * DumpRenderTree/LayoutTestController.h: 16231 (LayoutTestController::dumpWillCacheResponse): 16232 (LayoutTestController::setDumpWillCacheResponse): 16233 * DumpRenderTree/mac/ResourceLoadDelegate.mm: Inspect dumpWillCacheResponse 16234 instead of dumpResourceLoadCallbacks. 16235 (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]): 16236 162372009-08-05 Jeremy Orlow <jorlow@chromium.org> 16238 16239 Reviewed by Adam Barth. 16240 16241 Add my name to committers.py 16242 https://bugs.webkit.org/show_bug.cgi?id=28013 16243 16244 Add my name to committers.py. 16245 16246 * Scripts/modules/committers.py: 16247 162482009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org> 16249 16250 Reviewed by Simon Hausmann. 16251 16252 A minor refactoring of the Qt DRT to be a bit more similar to 16253 the other DRTs, as well as more understandable. 16254 16255 Splitting up resetJSObjects into a LayoutTestController->reset() 16256 plus a new closeRemainingWindows() method. 16257 16258 Added a resetToConsistentStateBeforeTesting() method to keep 16259 the code in one place, making it easier to verify that we are 16260 doing things properly. 16261 16262 * DumpRenderTree/qt/DumpRenderTree.cpp: 16263 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 16264 (WebCore::DumpRenderTree::open): 16265 (WebCore::DumpRenderTree::closeRemainingWindows): 16266 * DumpRenderTree/qt/DumpRenderTree.h: 16267 162682009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org> 16269 16270 Reviewed by Simon Hausmann. 16271 16272 Make the Qt DRT WorkQueue work similarily to the cross platform 16273 one. This means that all items return true if they started 16274 loading. 16275 16276 This change paves the way for unforking the WorkQueue, if we [Qt] 16277 would like that. 16278 16279 * DumpRenderTree/qt/WorkQueue.cpp: 16280 (WorkQueue::processWork): 16281 * DumpRenderTree/qt/WorkQueue.h: 16282 * DumpRenderTree/qt/WorkQueueItem.h: 16283 * DumpRenderTree/qt/jsobjects.cpp: 16284 (LoadItem::invoke): 16285 (ReloadItem::invoke): 16286 (ScriptItem::invoke): 16287 (BackForwardItem::invoke): 16288 (LayoutTestController::processWork): 16289 (LayoutTestController::maybeDump): 16290 162912009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 16292 16293 Reviewed by Simon Hausmann. 16294 16295 If load of a test fails, don't dump as it will be dumped 16296 in the preceding test, resulting in a invalid incorrect layout. 16297 16298 * DumpRenderTree/qt/jsobjects.cpp: 16299 (LayoutTestController::maybeDump): 16300 163012009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org> 16302 16303 Reviewed by Simon Hausmann. 16304 16305 Make the Qt DumpRenderTree more similar to the mac one. 16306 16307 Changes include: 16308 1) Reset zoom factor before each test 16309 2) Only dump the backforward list when we got other dump result 16310 3) When we dump the render tree, and got zero result print out: 16311 [mainFrame renderTreeAsExternalRepresentation] 16312 and not: 16313 [frame renderTreeAsExternalRepresentation] 16314 16315 * DumpRenderTree/qt/DumpRenderTree.cpp: 16316 (WebCore::DumpRenderTree::open): 16317 (WebCore::methodNameStringForFailedTest): 16318 (WebCore::DumpRenderTree::dump): 16319 163202009-08-05 chris fleizach <cfleizach@apple.com> 16321 16322 Fix Tiger build breakage. 16323 16324 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 16325 163262009-08-04 Chris Fleizach <cfleizach@apple.com> 16327 16328 Reviewed by Darin Adler. 16329 16330 Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented 16331 https://bugs.webkit.org/show_bug.cgi?id=27994 16332 16333 Expose valueDescription for accessibility. 16334 16335 * DumpRenderTree/AccessibilityUIElement.cpp: 16336 (getValueDescriptionCallback): 16337 (AccessibilityUIElement::getJSClass): 16338 * DumpRenderTree/AccessibilityUIElement.h: 16339 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 16340 (AccessibilityUIElement::valueDescription): 16341 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 16342 (AccessibilityUIElement::valueDescription): 16343 163442009-08-04 Eric Seidel <eric@webkit.org> 16345 16346 Reviewed by Mark Rowe. 16347 16348 REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH 16349 https://bugs.webkit.org/show_bug.cgi?id=28006 16350 16351 Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig 16352 16353 * DumpRenderTree/mac/PerlSupport/Makefile: 16354 163552009-08-04 Adam Barth <abarth@webkit.org> 16356 16357 Reviewed by Darin Adler. 16358 16359 Add pkasting to bugzilla-tool as a committer 16360 https://bugs.webkit.org/show_bug.cgi?id=28002 16361 16362 * Scripts/modules/committers.py: 16363 163642009-08-04 Chris Fleizach <cfleizach@apple.com> 16365 16366 Reviewed by Darin Adler. 16367 16368 Bug 27993 - AXSliders are missing required attributes and actions 16369 https://bugs.webkit.org/show_bug.cgi?id=27993 16370 16371 Add ability to check if any arbitrary action is supported. 16372 16373 * DumpRenderTree/AccessibilityUIElement.cpp: 16374 (isActionSupportedCallback): 16375 (AccessibilityUIElement::getJSClass): 16376 * DumpRenderTree/AccessibilityUIElement.h: 16377 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 16378 (AccessibilityUIElement::isActionSupported): 16379 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 16380 (AccessibilityUIElement::isActionSupported): 16381 163822009-08-04 Adam Barth <abarth@webkit.org> 16383 16384 Reviewed by Eric Seidel. 16385 16386 bugzilla-tool unit tests need a test harness 16387 https://bugs.webkit.org/show_bug.cgi?id=27977 16388 16389 * Scripts/run-webkit-unittests: Added. 16390 163912009-08-04 Mark Rowe <mrowe@apple.com> 16392 16393 Rubber-stamped by Gavin "Gavvy" Barraclough. 16394 16395 Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions 16396 by listing the DumpRenderTree binary as a dependency. Xcode has the smarts to rebuild 16397 DumpRenderTree itself when switching OS versions so this dependency removes the need 16398 for any smarts in the Makefile. 16399 16400 * DumpRenderTree/mac/PerlSupport/Makefile: 16401 164022009-08-04 Eric Seidel <eric@webkit.org> 16403 16404 Reviewed by Adam Barth. 16405 16406 bugzilla-tool needs unit tests 16407 https://bugs.webkit.org/show_bug.cgi?id=26916 16408 16409 Add some basic unit testing for scm.py. 16410 16411 * Scripts/modules/scm.py: 16412 * Scripts/modules/scm_unittest.py: Added. 16413 164142009-08-04 Mike Fenton <mike.fenton@torchmobile.com> 16415 16416 Reviewed by Adam Treat. 16417 16418 Fix --skipped=only mode to honor flags such as --no-http and platform ignored directories by checking 16419 to make sure the Skipped entries are not in the $ignoredDirectories array. Directories commonly included 16420 are (http, media, compositing, wml, wcss). 16421 16422 https://bugs.webkit.org/show_bug.cgi?id=27893 16423 16424 * Scripts/run-webkit-tests: 16425 164262009-08-03 Chris Fleizach <cfleizach@apple.com> 16427 16428 Reviewed by Jon Honeycutt. 16429 16430 Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute. 16431 https://bugs.webkit.org/show_bug.cgi?id=27958 16432 16433 Exposed isRequired to DumpRenderTree for accessibility. 16434 16435 * DumpRenderTree/AccessibilityUIElement.cpp: 16436 (getIsRequiredCallback): 16437 (AccessibilityUIElement::getJSClass): 16438 * DumpRenderTree/AccessibilityUIElement.h: 16439 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 16440 (AccessibilityUIElement::isRequired): 16441 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 16442 (AccessibilityUIElement::isRequired): 16443 164442009-08-04 Adam Barth <abarth@webkit.org> 16445 16446 Reviewed by Eric Seidel. 16447 16448 bugzilla-tool --commit-queue should validate commit-queue setter is a committer 16449 https://bugs.webkit.org/show_bug.cgi?id=27974 16450 16451 With a test! 16452 16453 * Scripts/modules/bugzilla.py: 16454 * Scripts/modules/bugzilla_unittest.py: 16455 164562009-08-04 Eric Seidel <eric@webkit.org> 16457 16458 Reviewed by Adam Barth. 16459 16460 REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs 16461 https://bugs.webkit.org/show_bug.cgi?id=27973 16462 16463 The trailing comma (suppresses newlines) was lost in r46700. 16464 16465 * Scripts/bugzilla-tool: 16466 164672009-08-04 Adam Barth <abarth@webkit.org> 16468 16469 Reviewed by Eric Seidel. 16470 16471 bugzilla-tool has too many fatal errors 16472 https://bugs.webkit.org/show_bug.cgi?id=27969 16473 16474 Replace several fatal errors with ScriptError exceptions. 16475 16476 * Scripts/bugzilla-tool: 16477 * Scripts/modules/bugzilla.py: 16478 * Scripts/modules/scm.py: 16479 164802009-08-04 Eric Seidel <eric@webkit.org> 16481 16482 No review, ChangeLog fix only. 16483 16484 Fix a ChangeLog line-spacing disaster caused by: 16485 https://bugs.webkit.org/show_bug.cgi?id=27973 16486 16487 Still unsure what the fix for bugzilla-tool will be. 16488 164892009-08-04 Adam Barth <abarth@webkit.org> 16490 16491 Reviewed by Eric Seidel. 16492 16493 bugzilla-tool --commit-queue should only land commit-queue+ patches 16494 https://bugs.webkit.org/show_bug.cgi?id=27970 16495 16496 commit-queue mode for bugzilla-tool 16497 https://bugs.webkit.org/show_bug.cgi?id=27918 16498 16499 Make bugzilla tool smart enough to find the commit-queue+ flags and 16500 land those patches. 16501 When we call land-patches with --commit-queue, we should filter the 16502 patches we land to only those that have the commit-queue+ flag set. 16503 That way, when we call bugzilla-tool from a main commit queue process, 16504 we won't land the wrong patches. 16505 16506 * Scripts/bugzilla-tool: 16507 165082009-08-04 Eric Seidel <eric@webkit.org> 16509 16510 Reviewed by Adam Barth. 16511 16512 committer logic should be split out of bugzilla.py into its own module 16513 16514 https://bugs.webkit.org/show_bug.cgi?id=27972 16515 16516 I also added unit tests for the functionality I added. 16517 16518 * Scripts/modules/bugzilla.py: 16519 * Scripts/modules/bugzilla_unittest.py: Added. 16520 * Scripts/modules/commiters_unittest.py: Added. 16521 * Scripts/modules/committers.py: Added. 16522 165232009-08-03 Peter Kasting <pkasting@google.com> 16524 16525 Reviewed by David Kilzer. 16526 16527 https://bugs.webkit.org/show_bug.cgi?id=27323 16528 Handle any kind of line endings in svn-apply and svn-unapply, instead 16529 of assuming LF. 16530 16531 * Scripts/svn-apply: 16532 * Scripts/svn-unapply: 16533 165342009-08-03 Adam Barth <abarth@webkit.org> 16535 16536 Reviewed by Eric Seidel. 16537 16538 bugzilla-tool land-patches needs --queue mode 16539 https://bugs.webkit.org/show_bug.cgi?id=27961 16540 16541 Add a --commit-queue command line option to suppress user interaction. 16542 16543 * Scripts/bugzilla-tool: 16544 * Scripts/modules/scm.py: 16545 165462009-08-03 Mark Rowe <mrowe@apple.com> 16547 16548 Build fix. Add installsrc, installhdrs and install targets. 16549 16550 * DumpRenderTree/mac/PerlSupport/Makefile: 16551 165522009-08-03 Eric Carlson <eric.carlson@apple.com> 16553 16554 Reviewed by Eric Seidel. 16555 16556 HTMLInputElement is not controllable by assistive technologies 16557 https://bugs.webkit.org/show_bug.cgi?id=27941 16558 16559 Accessibility control of a slider required adding increment() and decrement() 16560 methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement. 16561 16562 * DumpRenderTree/AccessibilityUIElement.cpp: 16563 (incrementCallback): New, call UI element increment method. 16564 (decrementCallback): New, call UI element decrement method. 16565 (AccessibilityUIElement::getJSClass): Expose increment and decrement methods. 16566 16567 * DumpRenderTree/AccessibilityUIElement.h: 16568 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 16569 (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper. 16570 (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper. 16571 16572 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 16573 (AccessibilityUIElement::increment): New, do nothing. 16574 (AccessibilityUIElement::decrement): New, do nothing. 16575 165762009-08-02 David D. Kilzer <ddkilzer@webkit.org> 16577 16578 <http://webkit.org/b/27930> bugzilla-tool hates Tor Arne Vestbø 16579 16580 Reviewed by Tor Arne Vestbø. 16581 16582 * Scripts/bugzilla-tool: 16583 (set_reviewer_in_changelog): Made sure reviewer is properly 16584 encoded when calling replace(). 16585 165862009-08-02 Kevin Ollivier <kevino@theolliviers.com> 16587 16588 Reviewed by David Levin. 16589 16590 Script for building the wxBrowser sample app for wx. 16591 https://bugs.webkit.org/show_bug.cgi?id=27619 16592 16593 * wx/browser/wscript: Added. 16594 165952009-08-02 Kevin Ollivier <kevino@theolliviers.com> 16596 16597 Reviewed by Jan Alonzo. 16598 16599 Scripts needed for the waf build. 16600 https://bugs.webkit.org/show_bug.cgi?id=27619 16601 16602 * wx/build: Added. 16603 * wx/build/build_utils.py: Added. 16604 * wx/build/settings.py: Added. 16605 * wx/build/waf_extensions.py: Added. 16606 * wx/build/wxpresets.py: Added. 16607 166082009-08-01 Dan Bernstein <mitz@apple.com> 16609 16610 Reviewed by Darin Adler. 16611 16612 Make pixel test results more consistent across Mac OS X versions 16613 16614 * DumpRenderTree/cg/ImageDiffCG.cpp: 16615 (createDifferenceImage): Avoid color correction when rendering the 16616 images into graphics contexts, so that the actual color values are 16617 compared, regardless of how the images are tagged. 16618 * DumpRenderTree/mac/DumpRenderTree.mm: 16619 (createWebViewAndOffscreenWindow): Set the window’s color space to the 16620 main screen’s color space, even though the window is off-screen. 16621 166222009-08-01 Mark Rowe <mrowe@apple.com> 16623 16624 Try again to make the Qt build bot happy. 16625 16626 * BuildSlaveSupport/test-result-archive: Create a placeholder file inside the newly-created 16627 directory to prevent 'zip' from failing due to the directory containing no files. 16628 166292009-08-01 Mark Rowe <mrowe@apple.com> 16630 16631 Try and make the Qt build bot happy. 16632 16633 * BuildSlaveSupport/test-result-archive: Handle the case where run-webkit-tests generates 16634 no output files at all and thus does not create the layout-test-results directory. 16635 166362009-08-01 Mark Rowe <mrowe@apple.com> 16637 16638 Move the include of DumpRenderTreeSupport to after DumpRenderTree has been built. 16639 16640 * Scripts/run-webkit-tests: 16641 166422009-08-01 Mark Rowe <mrowe@apple.com> 16643 16644 Reviewed by Sam Weinig and David D. Kilzer. 16645 16646 Fix <https://bugs.webkit.org/show_bug.cgi?id=27923>. 16647 Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X 16648 16649 run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is 16650 in the process of crashing. We can do the same test more efficiently with a simple call to sysctl. 16651 I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module 16652 instead. This speeds up run-webkit-tests by around 8%. 16653 16654 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 16655 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added. 16656 (processIsCrashing): 16657 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: Added. Tiger does not have the SWIG tool 16658 that is used to generate the Perl binding to the C code, so we fall back to the old implementation on Tiger. 16659 * DumpRenderTree/mac/PerlSupport/Makefile: Added. 16660 * Scripts/run-webkit-tests: 16661 166622009-08-01 Mark Rowe <mrowe@apple.com> 16663 16664 Reviewed by David D. Kilzer. 16665 16666 Display the reminder once rather than once per ChangeLog. 16667 16668 * Scripts/prepare-ChangeLog: 16669 166702009-08-01 David Kilzer <ddkilzer@apple.com> 16671 16672 resolve-ChangeLogs: add error checking to git ls-files command on close() 16673 16674 Reviewed by Eric Seidel. 16675 16676 Item 2 of <https://bugs.webkit.org/show_bug.cgi?id=18599#c0>. 16677 16678 * Scripts/resolve-ChangeLogs: Added error checking to close() 16679 after running git ls-files. Added error checking to all 16680 system() calls by checking for a non-zero WEXITSTATUS($?). 16681 Changed "|| die;" expressions to "or die $!;". 16682 166832009-08-01 David Kilzer <ddkilzer@apple.com> 16684 16685 <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths 16686 16687 Reviewed by Eric Seidel. 16688 16689 * Scripts/resolve-ChangeLogs: Used chdirReturningRelativePath() 16690 and determineVCSRoot() to change directories to the root of the 16691 project before running the command and to provide a path for 16692 removeChangeLogArguments() to make sure any ChangeLog arguments 16693 on the command line are still found. 16694 (canonicalRelativePath): Added. Returns a canonical path (e.g., 16695 stripping 'dir/../' from the path) relative to the current 16696 directory. 16697 (removeChangeLogArguments): Added argument which contains a 16698 relative path that must be prepended to any ChangeLog arguments. 16699 Used canonicalRelativePath() and File::Spec->catfile() to 16700 construct a normalized, relative path to each file. 16701 167022009-08-01 David Kilzer <ddkilzer@apple.com> 16703 16704 Implement VCSUtils::chdirReturningRelativePath() 16705 16706 Reviewed by Eric Seidel. 16707 16708 Step 2 to fix: 16709 <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths 16710 16711 * Scripts/VCSUtils.pm: 16712 (VCSUtils::chdirReturningRelativePath): Moved here from 16713 chdirAndGetDifference() in svn-create-patch. 16714 * Scripts/svn-create-patch: Switched to use 16715 chdirReturningRelativePath() instead of chdirAndGetDifference(). 16716 (chdirAndGetDifference): Removed. 16717 167182009-08-01 David Kilzer <ddkilzer@apple.com> 16719 16720 Implement VCSUtils::determineVCSRoot() 16721 16722 Reviewed by Eric Seidel. 16723 16724 Step 1 to fix: 16725 <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths 16726 16727 * Scripts/VCSUtils.pm: Removed reference to webkitdirs module. 16728 (VCSUtils::EXPORT): Added &determineVCSRoot. Realphabetized. 16729 (VCSUtils::determineGitRoot): Added. Based on code in 16730 commit-log-editor. 16731 (VCSUtils::determineVCSRoot): Implemented using 16732 determineGitRoot() and determineSVNRoot(). 16733 * Scripts/commit-log-editor: Replaced use of 16734 topLevelSourceDirectory() with determineVCSRoot(). Resorted 16735 use statements. 16736 (topLevelSourceDirectory): Removed. 16737 167382009-07-31 Daniel Bates <dbates@intudata.com> 16739 16740 Reviewed by Eric Seidel. 16741 16742 https://bugs.webkit.org/show_bug.cgi?id=27757 16743 16744 Resolves Perl redefinition warnings about functions tmpfile and tmpnam which are 16745 defined in both File::Temp and POSIX. 16746 16747 This stops the warnings by preventing the "import" method of File::Temp from being called, 16748 which would otherwise add these functions into the primary namespace. Note, "use POSIX" 16749 will import these functions into the primary namespace anyway. We only need one instance 16750 of these functions in our namespace (or we get redefinition warnings), so lets use the 16751 one's in the POSIX package. 16752 16753 * Scripts/update-webkit-auxiliary-libs: Changed "use File::Temp" to "use File::Temp ()". 16754 * Scripts/update-webkit-support-libs: ditto 16755 167562009-07-31 Laszlo Gombos <laszlo.1.gombos@nokia.com> 16757 16758 Reviewed by Eric Seidel. 16759 16760 Add a top level build option to control datagrid support 16761 https://bugs.webkit.org/show_bug.cgi?id=27915 16762 16763 * Scripts/build-webkit: 16764 167652009-07-31 David Levin <levin@chromium.org> 16766 16767 Reviewed by Adam Treat. 16768 16769 check-webkit-style --git-commit has bugs if you select a commit in the past 16770 https://bugs.webkit.org/show_bug.cgi?id=27908 16771 16772 * Scripts/check-webkit-style: 16773 (main): Made the git-commit command only select the first commit 16774 if a range is given (and print a warning). 16775 * Scripts/modules/scm.py: 16776 (SCM::create_patch_from_local_commit): 16777 (SCM::create_patch_since_local_commit): 16778 (SCM::commit_locally_with_message): 16779 (SCM::discard_local_commits): 16780 Added an error messages in case these aren't overriden. 16781 16782 (Git::create_patch_since_local_commit): 16783 Added this command to allow doing a diff of everything after a given commit. 16784 167852009-07-31 Jan Michael Alonzo <jmalonzo@webkit.org> 16786 16787 Speculative Qt build fix. Not reviewed. 16788 16789 Add LayoutTestController::disableImageLoading() in jsobjects.h. 16790 16791 * DumpRenderTree/qt/jsobjects.h: 16792 167932009-07-31 Brady Eidson <beidson@apple.com> 16794 16795 Reviewed by John Sullivan. 16796 16797 <rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896 16798 Favicons are still loaded when automatic image loading is disabled. 16799 16800 * DumpRenderTree/LayoutTestController.cpp: 16801 (disableImageLoadingCallback): 16802 (LayoutTestController::staticFunctions): 16803 * DumpRenderTree/LayoutTestController.h: 16804 16805 * DumpRenderTree/mac/DumpRenderTree.mm: 16806 (resetWebViewToConsistentStateBeforeTesting): 16807 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 16808 (LayoutTestController::disableImageLoading): 16809 16810 * DumpRenderTree/win/DumpRenderTree.cpp: 16811 (resetWebViewToConsistentStateBeforeTesting): 16812 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 16813 (LayoutTestController::disableImageLoading): 16814 16815 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 16816 (LayoutTestController::disableImageLoading): Stubbed for now. 16817 * DumpRenderTree/qt/jsobjects.cpp: 16818 (LayoutTestController::disableImageLoading): Ditto. 16819 168202009-07-30 Eric Seidel <eric@webkit.org> 16821 16822 Reviewed by David Kilzer. 16823 16824 bugzilla-tool post-commits trunk..head errors out 16825 https://bugs.webkit.org/show_bug.cgi?id=27847 16826 16827 Rename commit_ids_from_range_arguments to commit_ids_from_commitish_arguments 16828 and make it handle the new arguments format proposed in the bug. 16829 16830 * Scripts/bugzilla-tool: 16831 * Scripts/modules/scm.py: 16832 168332009-07-30 Eric Seidel <eric@webkit.org> 16834 16835 Reviewed by David Levin. 16836 16837 clean up build-webkit to use less copy/paste code and remove unneeded SVG warning 16838 https://bugs.webkit.org/show_bug.cgi?id=27857 16839 16840 * Scripts/build-webkit: 16841 168422009-07-31 David Kilzer <ddkilzer@apple.com> 16843 16844 <http://webkit.org/b/27894> bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5 16845 16846 Reviewed by Eric Seidel. 16847 16848 * Scripts/modules/bugzilla.py: 16849 (Bugzilla.clear_attachment_review_flag): Specify which 'comment' 16850 form field to use when setting its value. 16851 168522009-07-31 Eric Seidel <eric@webkit.org> 16853 16854 Reviewed by David Kilzer. 16855 16856 bugzilla-tool post-commits obsoletes its own work :( 16857 https://bugs.webkit.org/show_bug.cgi?id=27849 16858 16859 Simple fix. Use .add() instead of .update() 16860 16861 * Scripts/bugzilla-tool: 16862 168632009-07-31 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 16864 16865 Reviewed by Anders Carlsson. 16866 16867 Improve platform-detection in run-webkit-tests 16868 16869 This prevents miss-detection of mac-* over Qt/Mac. 16870 16871 * Scripts/run-webkit-tests: 16872 168732009-07-30 Mark Rowe <mrowe@apple.com> 16874 16875 Reviewed by Cameron Zwarich. 16876 16877 Teach buildbot to detect test cases that are missing results. 16878 16879 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 16880 168812009-07-30 Mark Rowe <mrowe@apple.com> 16882 16883 Things work better when you create the correct directories. 16884 16885 * Scripts/run-webkit-tests: 16886 168872009-07-30 Mark Rowe <mrowe@apple.com> 16888 16889 Include some information about the error when we die. 16890 16891 * Scripts/run-webkit-tests: 16892 168932009-07-30 Mark Rowe <mrowe@apple.com> 16894 16895 Ensure that the path exists before writing results to it. 16896 Hopefully this will make the Windows build bot happy. 16897 16898 * Scripts/run-webkit-tests: 16899 169002009-07-30 Mark Rowe <mrowe@apple.com> 16901 16902 Reviewed by Adam Treat and Jon Honeycutt. 16903 16904 Teach run-webkit-tests to always store the actual results in the results directory for new tests. 16905 This allows us to give a working link to the results from the result summary page, even if we're 16906 not generating new results in to the tree. 16907 16908 * Scripts/run-webkit-tests: 16909 169102009-07-30 Mark Rowe <mrowe@apple.com> 16911 16912 Add a Qt Linux build bot. 16913 16914 * BuildSlaveSupport/build.webkit.org-config/config.json: 16915 169162009-07-30 Jakob Petsovits <jakob.petsovits@torchmobile.com> 16917 16918 Reviewed by Adam Roben. 16919 16920 Add --minimal option to webkit-build. 16921 https://bugs.webkit.org/show_bug.cgi?id=27852 16922 16923 This option disables all optional build features unless 16924 they are explicitly enabled. 16925 16926 * Scripts/build-webkit: 16927 169282009-07-30 Jakub Wieczorek <faw217@gmail.com> 16929 16930 [Qt] Fix build with GCC 4.4. 16931 16932 * DumpRenderTree/qt/ImageDiff.cpp: 16933 169342009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com> 16935 16936 Reviewed by Simon Hausmann. 16937 16938 https://bugs.webkit.org/show_bug.cgi?id=27813 16939 16940 [Qt] Support pixel tests in DumpRenderTree for the Qt port. 16941 16942 * DumpRenderTree/qt/DumpRenderTree.cpp: 16943 (WebCore::DumpRenderTree::DumpRenderTree): 16944 (WebCore::DumpRenderTree::open): 16945 (WebCore::DumpRenderTree::setDumpPixels): 16946 (WebCore::DumpRenderTree::dump): 16947 * DumpRenderTree/qt/DumpRenderTree.h: 16948 * DumpRenderTree/qt/main.cpp: 16949 (main): 16950 169512009-07-29 Ariya Hidayat <ariya.hidayat@nokia.com> 16952 16953 Reviewed by Simon Hausmann. 16954 16955 https://bugs.webkit.org/show_bug.cgi?id=27813 16956 16957 [Qt] Implement ImageDiff. 16958 16959 * DumpRenderTree/qt/ImageDiff.cpp: Added. 16960 * DumpRenderTree/qt/ImageDiff.pro: Added. 16961 169622009-07-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 16963 16964 Reviewed by Eric Seidel. 16965 16966 build-webkit: Reorder logic for determining the baseProductDir 16967 16968 https://bugs.webkit.org/show_bug.cgi?id=27699 16969 16970 We now do port-spesific probing for the product dir first, and then 16971 fall back to either the generic WEBKITOUTPUTDIR (which now also works 16972 on Mac), or WebKitBuild. 16973 16974 Then we add the git branch if the git branch build option is enabled. 16975 16976 Finally we massage the product dir based on the port. For example the 16977 Mac port will now always set the SYMROOT and OBJROOT configuration for 16978 XCode. 16979 16980 Note that isAppleWinWebkit() and isCygwin() is not mutually exclusive, 16981 hence the normal if and not elsif in the last two blocks. 16982 16983 * Scripts/webkitdirs.pm: 16984 169852009-07-29 David Kilzer <ddkilzer@apple.com> 16986 16987 <http://webkit.org/b/27082> bugzilla-tool: Add --no-close switch to land-patches 16988 16989 Reviewed by David Levin. 16990 16991 * Scripts/bugzilla-tool: 16992 (LandPatchesFromBugs.__init__): Added --no-close switch. 16993 (LandPatchesFromBugs.land_patches): Don't close the bug if the 16994 --no-close switch was used. Always clear the review+ flag on 16995 every landed patch using the commit_text message when cleared. 16996 This prevents patches from showing up in the commit queue if 16997 reopened and provides consistency with all landed patches. 16998 * Scripts/modules/bugzilla.py: 16999 (Bugzilla.clear_attachment_review_flag): Added. 17000 170012009-07-29 David Kilzer <ddkilzer@apple.com> 17002 17003 <http://webkit.org/b/27815> bugzilla-tool: add -m/--description to post-commits command 17004 17005 Reviewed by Eric Seidel. 17006 17007 * Scripts/bugzilla-tool: 17008 (PostDiffAsPatchToBug.execute): Changed default patch name from 17009 "patch" to "Patch v1". 17010 (PostCommitsAsPatchesToBug.__init__): Added -m/--description 17011 switch. 17012 (PostCommitsAsPatchesToBug.execute): Use description provided by 17013 -m/--description switch first, else fall back to the commit 17014 message. 17015 170162009-07-29 Kenneth Rohde Christiansen <kenneth@webkit.org> 17017 17018 Reviewed by Dave Levin. 17019 17020 Make check-webkit-style support files as arguments. 17021 https://bugs.webkit.org/show_bug.cgi?id=27549 17022 17023 * Scripts/check-webkit-style: 17024 Support files as argument. Change documentation and use basename 17025 on the binary name when used in the documentation. Also do not 17026 die when printing something containing non-ASCII characters. 17027 170282009-08-06 Mike Fenton <mike.fenton@torchmobile.com> 17029 17030 Reviewed by David Levin. 17031 17032 Add validation for pointer and reference declaration as defined by webkit style guidelines to cpp_style.py. 17033 Add unit tests for validation and update existing c style cast test to be run explicitly as c validation. 17034 17035 https://bugs.webkit.org/show_bug.cgi?id=27984 17036 17037 * Scripts/modules/cpp_style.py: 17038 * Scripts/modules/cpp_style_unittest.py: 17039 170402009-07-29 David Kilzer <ddkilzer@apple.com> 17041 17042 <http://webkit.org/b/27119> bugzilla-tool: Add create-bug command 17043 17044 Reviewed by David Levin. 17045 17046 Implement "create-bug" command for bugzilla-tool. 17047 17048 * Scripts/bugzilla-tool: Added CreateBug class. 17049 (CreateBug.__init__): Added. 17050 (CreateBug.create_bug_from_commit): Added. 17051 (CreateBug.create_bug_from_patch): Added. 17052 (CreateBug.prompt_for_bug_title_and_comment): Added. 17053 (CreateBug.execute): Added. 17054 (BugzillaTool.__init__): Added create-bug command. 17055 * Scripts/modules/bugzilla.py: 17056 (Bugzilla.prompt_for_component): Added. 17057 (Bugzilla.check_create_bug_response_returning_bug_id_on_success): Added. 17058 (Bugzilla.create_bug_with_patch): Added. 17059 170602009-07-29 Jan Michael Alonzo <jmalonzo@webkit.org> 17061 17062 Reviewed by Eric Seidel and Xan Lopez. 17063 17064 [Gtk] Enable http/tests/appcache tests 17065 https://bugs.webkit.org/show_bug.cgi?id=27674 17066 17067 Add support for testing http/tests/appcache tests. 17068 17069 * DumpRenderTree/gtk/DumpRenderTree.cpp: 17070 (resetWebViewToConsistentStateBeforeTesting): 17071 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 17072 (LayoutTestController::setAppCacheMaximumSize): 17073 170742009-07-28 Mark Rowe <mrowe@apple.com> 17075 17076 Reviewed by Oliver Hunt. 17077 17078 Prevent nightly builds of WebKit from launching against old Safari versions that we no longer work with. 17079 17080 * WebKitLauncher/main.m: 17081 (checkSafariVersion): Add a minimum required Safari version of 4.0. This matches the requirement on Windows. 17082 (main): If the minimum version requirement is not met, display an alert and bail out. 17083 170842009-07-28 David Levin <levin@chromium.org> 17085 17086 Reviewed by Adam Treat. 17087 17088 cpplint* should be named cpp_style* 17089 https://bugs.webkit.org/show_bug.cgi?id=27752 17090 17091 The files were renamed. A few renames were done: 17092 CppLint -> CppStyle 17093 cpplint -> cpp_style 17094 17095 * Scripts/check-webkit-style: 17096 * Scripts/modules/cpp_style.py: Copied from cpplint.py and 17097 did name fix ups. 17098 * Scripts/modules/cpp_style_unittest.py: Copied from cpplint_unittest.py and 17099 did name fix ups. 17100 * Scripts/modules/cpplint.py: Removed. 17101 * Scripts/modules/cpplint_unittest.py: Removed. 17102 171032009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 17104 17105 Rubber-stamped by Holger Freyther. 17106 17107 Add Steve Falkenburg to bugzilla-tools' reviewers list 17108 17109 * Scripts/modules/bugzilla.py: 17110 171112009-07-28 Zoltan Horvath <hzoltan@inf.u-szeged.hu> 17112 17113 Reviewed by Simon Hausmann. 17114 17115 Implement test result archive support for the Qt port. 17116 17117 * BuildSlaveSupport/test-result-archive: 17118 171192009-07-27 Brady Eidson <beidson@apple.com> 17120 17121 Reviewed by Sam Weinig. 17122 17123 https://bugs.webkit.org/show_bug.cgi?id=27755 17124 Layout tests that dump resource load delegate calls should dump the request method and the response status code. 17125 17126 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 17127 (-[NSURLResponse _drt_descriptionSuitableForTestResult]): 17128 (-[NSURLRequest _drt_descriptionSuitableForTestResult]): 17129 17130 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 17131 (descriptionSuitableForTestResult): 17132 171332009-07-27 Pierre d'Herbemont <pdherbemont@apple.com> 17134 17135 Reviewed by David Levin. 17136 17137 "bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load. 17138 https://bugs.webkit.org/show_bug.cgi?id=27747 17139 17140 modules.bugzilla is not found because not included. 17141 17142 * Scripts/modules/scm.py: Properly import modules.bugzilla. 17143 171442009-07-24 Pierre d'Herbemont <pdherbemont@apple.com> 17145 17146 Reviewed by David Kilzer. 17147 17148 commit-log-editor should allow git commit --amend to regenerate the commit log based on the modifed ChangeLog 17149 https://bugs.webkit.org/show_bug.cgi?id=27664 17150 17151 * Scripts/commit-log-editor: Add --regenerate-log option. 17152 The user is asked if he wants to suppress previous ChangeLog and regenerate it, 17153 if this option is enabled. 17154 171552009-07-27 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu> 17156 17157 Reviewed by Simon Hausmann. 17158 17159 Generating remote links causes a lot of unnecessary spew on Qt build bot too 17160 17161 * Scripts/run-webkit-tests: 17162 171632009-07-25 Kwang Yul Seo <skyul@company100.net> 17164 17165 Reviewed by Darin Adler. 17166 17167 Windows build break due to warning C4819 17168 https://bugs.webkit.org/show_bug.cgi?id=27416 17169 17170 Disable C4819 warning to fix build. 17171 17172 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 17173 171742009-07-24 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com> 17175 17176 Not reviewed. Add Kevin McCullough as reviewer in bugzilla.py 17177 17178 * Scripts/modules/bugzilla.py: 17179 171802009-07-24 Eli Fidler <eli.fidler@torchmobile.com> 17181 17182 Reviewed by Adam Treat. 17183 17184 Improve git workflow by populating commit messages with ChangeLog entries. 17185 https://bugs.webkit.org/show_bug.cgi?id=27605 17186 17187 If the user doesn't manually modify the ChangeLog files, use 17188 prepare-ChangeLog to populate the git commit message. This behaviour 17189 can be disabled by the 'webkitGenerateCommitMessage' git configuration option. 17190 17191 * Scripts/commit-log-editor: 17192 171932009-07-24 David Levin <levin@chromium.org> 17194 17195 Reviewed by Adam Treat. 17196 17197 cpplint crash when there is a duplicate header followed by another header. 17198 https://bugs.webkit.org/show_bug.cgi?id=27625 17199 17200 * Scripts/modules/cpplint.py: Ensure that include_state.header_types is updated even 17201 there is a duplicate header, which resulted in some code rearrangement. Also, 17202 changed some if's in this function to return early. This avoids having nearly the 17203 whole function content being indented. 17204 * Scripts/modules/cpplint_unittest.py: Added a test which would have exposed the crash. 17205 172062009-07-24 Jakob Petsovits <jakob.petsovits@torchmobile.com> 17207 17208 Reviewed by Adam Treat. 17209 17210 Filetype support changes for cpplint and check_webkit_style 17211 https://bugs.webkit.org/show_bug.cgi?id=27653 17212 17213 Introduce .c support for check_webkit_style, and remove support for 17214 .cc files in favor of .cpp. 17215 17216 * Scripts/check-webkit-style: 17217 * Scripts/modules/cpplint.py: 17218 * Scripts/modules/cpplint_unittest.py: 17219 172202009-07-24 Eli Fidler <eli.fidler@torchmobile.com> 17221 17222 Reviewed by David Levin. 17223 17224 Improve git workflow by populating commit messages with ChangeLog entries. 17225 https://bugs.webkit.org/show_bug.cgi?id=27605 17226 17227 add --[no-]write prepare-ChangeLog options to bash completion 17228 17229 * Scripts/webkit-tools-completion.sh: 17230 172312009-07-24 Andrei Popescu <andreip@google.com> 17232 17233 Reviewed by Anders Carlsson. 17234 17235 ApplicationCache should have size limit 17236 https://bugs.webkit.org/show_bug.cgi?id=22700 17237 17238 Adds a new method on the LayoutTestController that 17239 allows a JS unit test to configure the maximum size 17240 of the Application Cache. 17241 17242 * DumpRenderTree/LayoutTestController.cpp: 17243 (setAppCacheMaximumSizeCallback): 17244 (LayoutTestController::staticFunctions): 17245 * DumpRenderTree/LayoutTestController.h: 17246 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 17247 (LayoutTestController::setAppCacheMaximumSize): 17248 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 17249 (LayoutTestController::setAppCacheMaximumSize): 17250 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 17251 (LayoutTestController::setAppCacheMaximumSize): 17252 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 17253 (LayoutTestController::setAppCacheMaximumSize): 17254 172552009-07-24 Adam Barth <abarth@webkit.org> 17256 17257 Rubber stamped by Eric Seidel. 17258 17259 Added andersca to list of reviewers. 17260 17261 * Scripts/modules/bugzilla.py: 17262 172632009-07-24 Mark Rowe <mrowe@apple.com> 17264 17265 Reviewed by Xan Lopez. 17266 17267 Fix dozens of "Deallocation of a pointer not malloced" messages seen while running 17268 layout tests on the build bot. 17269 17270 Memory allocated via FastMalloc was being deleted via the system memory allocator 17271 due to an inconsistent including of FastMalloc.h. We address this by including it 17272 from config.h and including config.h from every implementation file, as in our other 17273 projects. 17274 17275 * DumpRenderTree/ForwardingHeaders/wtf/FastMalloc.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h. 17276 * DumpRenderTree/config.h: 17277 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 17278 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 17279 * DumpRenderTree/mac/AppleScriptController.m: 17280 * DumpRenderTree/mac/CheckedMalloc.cpp: 17281 * DumpRenderTree/mac/DumpRenderTree.mm: 17282 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: 17283 * DumpRenderTree/mac/DumpRenderTreePasteboard.m: 17284 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: 17285 * DumpRenderTree/mac/EditingDelegate.mm: 17286 * DumpRenderTree/mac/EventSendingController.mm: 17287 * DumpRenderTree/mac/FrameLoadDelegate.mm: 17288 * DumpRenderTree/mac/GCControllerMac.mm: 17289 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 17290 * DumpRenderTree/mac/NavigationController.m: 17291 * DumpRenderTree/mac/ObjCController.m: 17292 * DumpRenderTree/mac/ObjCPlugin.m: 17293 * DumpRenderTree/mac/ObjCPluginFunction.m: 17294 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 17295 * DumpRenderTree/mac/PlainTextController.mm: 17296 * DumpRenderTree/mac/PolicyDelegate.mm: 17297 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 17298 * DumpRenderTree/mac/TextInputController.m: 17299 * DumpRenderTree/mac/UIDelegate.mm: 17300 * DumpRenderTree/mac/WorkQueueItemMac.mm: 17301 173022009-07-24 Mark Rowe <mrowe@apple.com> 17303 17304 Reviewed by Simon Hausmann. 17305 17306 Add a command line option to run-javascriptcore-tests to explicitly opt out of attempting to rebuild JavaScriptCore. 17307 This is primarily useful to speed up the build bots where one machine builds JavaScriptCore and a second runs the tests, 17308 leading to situations where the build system unnecessarily feels that the need to recompile. 17309 17310 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 17311 * Scripts/run-javascriptcore-tests: 17312 173132009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org> 17314 17315 Reviewed by Eric Seidel. 17316 17317 [Gtk] Add implementation of GCController for DRT 17318 https://bugs.webkit.org/show_bug.cgi?id=27636 17319 17320 * DumpRenderTree/gtk/DumpRenderTree.cpp: 17321 (webViewWindowObjectCleared): 17322 (main): 17323 * DumpRenderTree/gtk/GCControllerGtk.cpp: 17324 (GCController::collect): 17325 (GCController::collectOnAlternateThread): 17326 (GCController::getJSObjectCount): 17327 173282009-07-23 Mark Rowe <mrowe@apple.com> 17329 17330 Update build.webkit.org config for new machine. 17331 17332 * BuildSlaveSupport/build.webkit.org-config/config.json: 17333 173342009-07-23 Brady Eidson <beidson@apple.com> 17335 17336 Remove accidentally checked in code. 17337 17338 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 17339 (waitUntilDoneWatchdogFired): 17340 (LayoutTestController::setWaitToDump): 17341 173422009-07-23 Brady Eidson <beidson@apple.com> 17343 17344 Reviewed by Geoff Garen. 17345 17346 WebCore has a few places that don't gracefully handle a null request returned from willSendRequest. 17347 https://bugs.webkit.org/show_bug.cgi?id=27595 17348 17349 Add the ability to tell the LayoutTestController to return a null request for willSendRequest 17350 redirect callbacks. 17351 17352 * DumpRenderTree/LayoutTestController.cpp: 17353 (LayoutTestController::LayoutTestController): 17354 (setWillSendRequestReturnsNullOnRedirectCallback): 17355 (LayoutTestController::staticFunctions): 17356 * DumpRenderTree/LayoutTestController.h: 17357 (LayoutTestController::willSendRequestReturnsNullOnRedirect): 17358 (LayoutTestController::setWillSendRequestReturnsNullOnRedirect): 17359 17360 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 17361 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): 17362 * DumpRenderTree/win/ResourceLoadDelegate.cpp: 17363 (ResourceLoadDelegate::willSendRequest): 17364 173652009-07-23 Mark Rowe <mrowe@apple.com> 17366 17367 Reviewed Oliver Hunt. 17368 17369 Fix DumpRenderTree to not fail an assertion on launch on a new machine. 17370 17371 * DumpRenderTree/mac/DumpRenderTree.mm: 17372 (setDefaultsToConsistentValuesForTesting): Disable the XSS auditor. It being enabled 17373 breaks all of the JavaScript tests within testStringByEvaluatingJavaScriptFromString, 17374 which causes us to exit due to an assertion failure. It's not clear why the XSS auditor 17375 decides to interfere with these tests. 17376 173772009-07-23 Mark Rowe <mrowe@apple.com> 17378 17379 Reviewed by Oliver Hunt. 17380 17381 Update default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows 17382 in hopes of fixing some layout test failures seen on the build bot. 17383 17384 * DumpRenderTree/gtk/DumpRenderTree.cpp: 17385 (resetWebViewToConsistentStateBeforeTesting): 17386 173872009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> 17388 17389 Reviewed by Adam Treat. 17390 17391 Fix false positives for switch statement indentation check in cpplint. 17392 https://bugs.webkit.org/show_bug.cgi?id=27615 17393 17394 Makes one-line case statements (e.g. "case foo: bar();") work. 17395 Also a few general improvements to the robustness and readability of 17396 the check, and more test cases. 17397 17398 * Scripts/modules/cpplint.py: 17399 * Scripts/modules/cpplint_unittest.py: 17400 174012009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> 17402 17403 Reviewed by Adam Treat. 17404 17405 Add check for line-breaking rule #3 to cpplint. 17406 https://bugs.webkit.org/show_bug.cgi?id=27610 17407 17408 "An else if statement should be written as an if statement when 17409 the prior if concludes with a return statement." 17410 17411 Implemented by a multi-line (kind of back-tracking) algorithm. 17412 Comes with loads of unit tests. Fixes the check for label indentation 17413 to be not so overzealous, as it didn't allow for completely unindented 17414 goto labels (at the very start of a line). 17415 17416 * Scripts/modules/cpplint.py: 17417 * Scripts/modules/cpplint_unittest.py: 17418 174192009-07-23 Eli Fidler <eli.fidler@torchmobile.com> 17420 17421 Reviewed by Adam Treat. 17422 17423 Improve git workflow by populating commit messages with ChangeLog entries. 17424 https://bugs.webkit.org/show_bug.cgi?id=27605 17425 17426 add --[no-]write option to optionally output new ChangeLog entries to 17427 stdout instead of modifying ChangeLog files 17428 17429 fix Torch Mobile copyright 17430 17431 * Scripts/prepare-ChangeLog: 17432 174332009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com> 17434 17435 Reviewed by Adam Treat. 17436 17437 Enable cpplint for .c files. 17438 https://bugs.webkit.org/show_bug.cgi?id=27604 17439 17440 Also make sure that the check for NULL does not apply to .c files. 17441 17442 * Scripts/modules/cpplint.py: 17443 * Scripts/modules/cpplint_unittest.py: 17444 174452009-07-22 Steve Falkenburg <sfalken@apple.com> 17446 17447 Checkpoint new Windows nightly launcher. 17448 17449 Reviewed by Mark Rowe. 17450 17451 * WebKitLauncherWin: Added. 17452 * WebKitLauncherWin/Resource.h: Added. 17453 * WebKitLauncherWin/WebKitLauncherWin.cpp: Added. 17454 (getStringValue): Retrieve a string registry value. 17455 (applePathFromRegistry): Get an Apple-related path out of the registry. 17456 (copyEnvironmentVariable): Copy an environment variable. 17457 (safariInstallDir): Helper function to get the install directory for Safari. 17458 (safariBrowserExe): Helper function to get the full path of the Safari executable. 17459 (_tWinMain): Locate Safari and launch it after setting up an environment variable. 17460 * WebKitLauncherWin/WebKitLauncherWin.h: Added. 17461 * WebKitLauncherWin/WebKitLauncherWin.rc: Added. 17462 * WebKitLauncherWin/WebKitLauncherWin.vcproj: Added. 17463 * WebKitLauncherWin/webkit.ico: Added. 17464 174652009-07-22 David Levin <levin@chromium.org> 17466 17467 Reviewed by Adam Treat. 17468 17469 run-webkit-lint should be named check-webkit-style 17470 https://bugs.webkit.org/show_bug.cgi?id=27568 17471 17472 This name better reflects the fact that it is about checking the style of files. 17473 17474 * Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint. 17475 174762009-07-22 Takeshi Yoshino <tyoshino@google.com> 17477 17478 Reviewed by Darin Adler. 17479 17480 VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp 17481 https://bugs.webkit.org/show_bug.cgi?id=26375 17482 17483 Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now, 17484 the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals 17485 in the macros before writing out them into the file to update. 17486 17487 By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian 17488 strings in the Localizable.strings file. 17489 17490 Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide 17491 users to update-webkit-localizable-strings. 17492 17493 * Scripts/extract-localizable-strings: 17494 174952009-07-22 Shinichiro Hamaji <hamaji@google.com> 17496 17497 Reviewed by David Levin. 17498 17499 Tiny typo fixes for cpplint.py 17500 https://bugs.webkit.org/show_bug.cgi?id=27530 17501 17502 * Scripts/modules/cpplint.py: 17503 175042009-07-22 Shinichiro Hamaji <hamaji@chromium.org> 17505 17506 Reviewed by David Levin. 17507 17508 run-webkit-lint checks code which are not changed 17509 https://bugs.webkit.org/show_bug.cgi?id=27529 17510 17511 Add check if the line is newly added. 17512 17513 * Scripts/run-webkit-lint: 17514 175152009-07-22 Shinichiro Hamaji <hamaji@chromium.org> 17516 17517 Reviewed by David Levin. 17518 17519 run-webkit-lint should have --git-commit option 17520 https://bugs.webkit.org/show_bug.cgi?id=27528 17521 17522 * Scripts/modules/cpplint.py: 17523 * Scripts/run-webkit-lint: 17524 175252009-07-22 Peter Kasting <pkasting@google.com> 17526 17527 Reviewed by David Kilzer. 17528 17529 https://bugs.webkit.org/show_bug.cgi?id=27323 17530 Factor svn-create-patch's "determineSvnRoot()" into a function in 17531 VCSUtils.pm so commit-log-editor can use it too. 17532 17533 * Scripts/VCSUtils.pm: Add determineSVNRoot(). 17534 * Scripts/commit-log-editor: Use determineSVNRoot() instead of old 17535 code (which didn't work as well). 17536 * Scripts/svn-create-patch: Remove determineSvnRoot() (moved). 17537 175382009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com> 17539 17540 Reviewed by Adam Treat. 17541 17542 Fix false positives in namespace indentation checks. 17543 https://bugs.webkit.org/show_bug.cgi?id=27567 17544 17545 The regular expression detecting goto labels (in order 17546 to skip those) was too permissive, which caused other 17547 code like "Foo::Bar()" to be treated as a label too, 17548 thereby not stopping the processing loop as expected. 17549 17550 Now comes with a stricter regexp, and more demanding 17551 test cases to check for these issues. 17552 17553 * Scripts/modules/cpplint.py: 17554 * Scripts/modules/cpplint_unittest.py: 17555 175562009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com> 17557 17558 Reviewed by Adam Treat. 17559 17560 Fix cpplint generating false positives for 17561 "primary" includes in headers. 17562 https://bugs.webkit.org/show_bug.cgi?id=27553 17563 17564 Doing so by only flagging includes in header files 17565 as primary when the include filename exactly matches 17566 the header filename. 17567 17568 * Scripts/modules/cpplint.py: 17569 * Scripts/modules/cpplint_unittest.py: 17570 175712009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com> 17572 17573 Reviewed by Adam Treat. 17574 17575 cpplint generates false positives for primary includes 17576 https://bugs.webkit.org/show_bug.cgi?id=27544 17577 17578 Fix false positives for instances when cpplint would 17579 normally classify multiple includes as primary: After 17580 the first primary include, classify subsequent ones as 17581 "other" includes even if they look like primary ones. 17582 17583 * Scripts/modules/cpplint.py: 17584 * Scripts/modules/cpplint_unittest.py: 17585 175862009-07-22 Gabor Rapcsanyi <rapcsanyi.gabor@stud.u-szeged.hu> 17587 17588 Reviewed by Simon Hausmann. 17589 17590 Pass XAUTHORITY environment variable to $dumpTool as well. 17591 17592 * Scripts/run-webkit-tests: 17593 175942009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com> 17595 17596 Reviewed by Adam Treat. 17597 17598 Add check for correct wtf includes to cpplint. 17599 https://bugs.webkit.org/show_bug.cgi?id=27524 17600 17601 * Scripts/modules/cpplint.py: 17602 * Scripts/modules/cpplint_unittest.py: 17603 176042009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com> 17605 17606 Reviewed by David Levin. 17607 17608 Add checks for multi-line boolean operator placement. 17609 https://bugs.webkit.org/show_bug.cgi?id=27496 17610 17611 * Scripts/modules/cpplint.py: 17612 * Scripts/modules/cpplint_unittest.py: 17613 176142009-07-21 Adam Treat <adam.treat@torchmobile.com> 17615 17616 Reviewed by David Levin. 17617 17618 We can't match implementation file and primary header exactly 17619 since we have so many files in WebKit where the port suffix 17620 is appended to the filename. 17621 17622 Example: FooQt.cpp and the primary header is Foo.h. 17623 17624 * Scripts/modules/cpplint.py: 17625 176262009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com> 17627 17628 Reviewed by David Levin. 17629 17630 Add checks for switch statement indentation to cpplint. 17631 https://bugs.webkit.org/show_bug.cgi?id=27508 17632 17633 * Scripts/modules/cpplint.py: 17634 * Scripts/modules/cpplint_unittest.py: 17635 176362009-07-21 Kenneth Rohde Christiansen <kenneth@webkit.org> 17637 17638 Reviewed by Adam Treat. 17639 17640 Feature request: cpplint should check for braces - rule 2 17641 https://bugs.webkit.org/show_bug.cgi?id=27497 17642 17643 Add the requested feature: Make sure { is on the same line 17644 as the foreach "keyword". 17645 17646 * Scripts/modules/cpplint.py: 17647 * Scripts/modules/cpplint_unittest.py: 17648 176492009-07-20 Jakob Petsovits <jakob.petsovits@torchmobile.com> 17650 17651 Reviewed by David Levin. 17652 17653 Add checks for namespace indentation to cpplint. 17654 https://bugs.webkit.org/show_bug.cgi?id=27461 17655 17656 * Scripts/modules/cpplint.py: 17657 * Scripts/modules/cpplint_unittest.py: 17658 176592009-07-20 Adam Treat <adam.treat@torchmobile.com> 17660 17661 Reviewed by David Levin. 17662 17663 Add cpplint check for proper include order 17664 https://bugs.webkit.org/show_bug.cgi?id=27462 17665 17666 Add a new check to cpplint to flag cases where the include section of a file 17667 does not match the mandated include order and style of the Webkit coding style 17668 guidelines. 17669 17670 Add associated tests. 17671 17672 * Scripts/modules/cpplint.py: 17673 * Scripts/modules/cpplint_unittest.py: 17674 176752009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 17676 17677 Reviewed by David Levin. 17678 17679 Support lint for patches 17680 https://bugs.webkit.org/show_bug.cgi?id=27291 17681 17682 Add run-webkit-lint script, which lints recent changes in local 17683 repository. Also, modified cpplint.py so that we don't need to 17684 specify verbose level for process_file(). 17685 17686 * Scripts/modules/cpplint.py: 17687 * Scripts/run-webkit-lint: Added. 17688 176892009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 17690 17691 Reviewed by David Levin. 17692 17693 diff_parser should accept lines without trailing \n 17694 https://bugs.webkit.org/show_bug.cgi?id=27483 17695 17696 Normalize the input lines by removing a trailing newline. 17697 Also, add a case for unittest for newly added files. 17698 17699 * Scripts/modules/diff_parser.py: 17700 * Scripts/modules/diff_parser_unittest.py: 17701 177022009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 17703 17704 Reviewed by David Levin. 17705 17706 cpplint.py's process_file() should accept customized error function 17707 https://bugs.webkit.org/show_bug.cgi?id=27487 17708 17709 * Scripts/modules/cpplint.py: 17710 177112009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 17712 17713 Reviewed by David Levin. 17714 17715 cpplint.py should have an interface to get global error count 17716 https://bugs.webkit.org/show_bug.cgi?id=27486 17717 17718 * Scripts/modules/cpplint.py: 17719 * Scripts/modules/cpplint_unittest.py: 17720 177212009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 17722 17723 Reviewed by David Levin. 17724 17725 cpplint's parse_argument should not exit even if no files are specified 17726 https://bugs.webkit.org/show_bug.cgi?id=27489 17727 17728 * Scripts/modules/cpplint.py: 17729 * Scripts/modules/cpplint_unittest.py: 17730 177312009-07-21 Shinichiro Hamaji <hamaji@chromium.org> 17732 17733 Reviewed by David Levin. 17734 17735 diff_parser: s/add_deleted_line/add_old_line/g 17736 https://bugs.webkit.org/show_bug.cgi?id=27484 17737 17738 * Scripts/modules/diff_parser.py: 17739 177402009-07-21 Roland Steiner <rolandsteiner@google.com> 17741 17742 Reviewed by David Levin. 17743 17744 Add ENABLE_RUBY to list of build options 17745 https://bugs.webkit.org/show_bug.cgi?id=27324 17746 17747 * Scripts/build-webkit: Added flag ENABLE_RUBY. 17748 177492009-07-20 Mark Rowe <mrowe@apple.com> 17750 17751 Reviewed by David D. Kilzer. 17752 17753 Fix <https://bugs.webkit.org/show_bug.cgi?id=27482>. 17754 Bug 27482: svn-apply cannot apply patch generated by Windows SVN 17755 17756 A regexp in svn-apply was treating everything prior to a \n as part of the 17757 file name. The native Windows SVN client uses \r\n for line endings which 17758 meant that the \r was being included in the file name. This defeated the 17759 special-case logic for ChangeLogs to apply them with an increased fuzz factor, 17760 meaning that the ChangeLog portions of such patches would fail to apply. 17761 17762 Also updated two other regexps that look like they would hit similar problems 17763 with line-endings so that they will correctly handle patches from Windows SVN. 17764 17765 * Scripts/svn-apply: 17766 177672009-07-20 Peter Kasting <pkasting@google.com> 17768 17769 Reviewed by Mark Rowe. 17770 17771 https://bugs.webkit.org/show_bug.cgi?id=27468 17772 Back out r46060, which caused problems for some Apple developers. 17773 17774 * DumpRenderTree/win/DumpRenderTree.vcproj: 17775 * DumpRenderTree/win/ImageDiff.vcproj: 17776 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 17777 177782009-07-20 Peter Kasting <pkasting@google.com> 17779 17780 Reviewed by Darin Adler. 17781 17782 https://bugs.webkit.org/show_bug.cgi?id=27323 17783 Use shorter, more correct code for determining the current directory, 17784 which works better with symbolic links on some systems. Also switch 17785 from checking repository root to checking UUID, to match scm.py. 17786 17787 * Scripts/svn-create-patch: 17788 177892009-07-20 Mark Rowe <mrowe@apple.com> 17790 17791 Rubber-stamped by Dan Bernstein. 17792 17793 Work around <rdar://problem/7075373> by ensuring that the URL is absolute before handing it off to CoreText. 17794 17795 * DumpRenderTree/mac/DumpRenderTree.mm: 17796 (activateFonts): 17797 177982009-07-20 David Levin <levin@chromium.org> 17799 17800 Reviewed by Adam Treat. 17801 17802 Enable filename completion for run-webkit-test (added "-o default"). 17803 17804 * Scripts/webkit-tools-completion.sh: 17805 178062009-07-20 Simon Hausmann <simon.hausmann@nokia.com> 17807 17808 No review, just adding Gavin Barraclough as reviewer. 17809 17810 * Scripts/modules/bugzilla.py: 17811 178122009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org> 17813 17814 Reviewed by David Levin. 17815 17816 Add support for Qt's foreach to cpplint 17817 https://bugs.webkit.org/show_bug.cgi?id=27386 17818 17819 * Scripts/modules/cpplint.py: 17820 * Scripts/modules/cpplint_unittest.py: 17821 178222009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org> 17823 17824 https://bugs.webkit.org/show_bug.cgi?id=27145 17825 [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615 17826 17827 Reviewed by Gustavo Noronha. 17828 17829 Normalize file URLs. 17830 17831 * DumpRenderTree/gtk/DumpRenderTree.cpp: 17832 (dumpHistoryItem): 17833 178342009-07-17 Peter Kasting <pkasting@google.com> 17835 17836 Reviewed by David Kilzer. 17837 17838 https://bugs.webkit.org/show_bug.cgi?id=27323 17839 Further improve non-Cygwin SVN support. 17840 17841 * Scripts/prepare-ChangeLog: Harmless change to be consistent with other 17842 places that consume whitespace at the end of svn output. 17843 * Scripts/resolve-ChangeLogs: Add support for SVN 1.6. Slightly 17844 optimize svn info parsing based on technique in svn-create-patch. 17845 Normalize paths and consume whitespace in the same way as 17846 prepare-ChangeLog, for Windows systems with a non-Cygwin SVN. Force 17847 diff and patch to run in binary mode so that they won't 17848 "intelligently" screw up line endings. 17849 178502009-07-18 Simon Fraser <simon.fraser@apple.com> 17851 17852 Fix Tiger DRT build. 17853 17854 * DumpRenderTree/mac/DumpRenderTree.mm: 17855 (createWebViewAndOffscreenWindow): 17856 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 17857 178582009-07-17 Simon Fraser <simon.fraser@apple.com> 17859 17860 Reviewed by Dan Bernstein. 17861 17862 DRT doesn't reliably snapshot composited layers 17863 https://bugs.webkit.org/show_bug.cgi?id=27399 17864 17865 If we're doing an "onscreen" pixel capture, it means that we're snapshotting a view 17866 with composited content. In that case we need to force the view to display so that 17867 the composited layers are rendered to the screen. 17868 17869 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 17870 (createBitmapContextFromWebView): 17871 178722009-07-17 Adam Barth <abarth@webkit.org> 17873 17874 Reviewed by David Levin. 17875 17876 bugzilla-tool does not understand nested SVN repos 17877 https://bugs.webkit.org/show_bug.cgi?id=27404 17878 17879 Determine the root of the working copy by looking at SVN's UUIDs. 17880 17881 * Scripts/modules/scm.py: 17882 178832009-07-17 David Levin <levin@chromium.org> 17884 17885 Reviewed by Mark Rowe. 17886 17887 webkit-tools-completion.sh has two typos and sorting issues. 17888 https://bugs.webkit.org/show_bug.cgi?id=27401 17889 17890 * Scripts/webkit-tools-completion.sh: Fix two typos "--dif" and "-clean". 17891 Also, sort all lists including items in the case statement and flags for 17892 the commands. 17893 178942009-07-17 Peter Kasting <pkasting@google.com> 17895 17896 Reviewed by David Kilzer. 17897 17898 https://bugs.webkit.org/show_bug.cgi?id=27323 17899 Tweak some regexes for correctness. 17900 17901 * Scripts/prepare-ChangeLog: Allow 1-character filenames (my previous 17902 change here didn't quite get things right). 17903 * Scripts/update-webkit: Detect conflicting ChangeLogs correctly by not 17904 including any trailing whitespace in the name "ChangeLog", and by 17905 normalizing paths before calling basename() to avoid confusing it. 17906 (normalizePath() copied from prepare-ChangeLog.) 17907 179082009-07-17 Peter Kasting <pkasting@google.com> 17909 17910 Reviewed by Steve Falkenburg. 17911 17912 https://bugs.webkit.org/show_bug.cgi?id=27323 17913 Only add Cygwin to the path when it isn't already there. This avoids 17914 causing problems for people who purposefully have non-Cygwin versions of 17915 executables like svn in front of the Cygwin ones in their paths. 17916 17917 * DumpRenderTree/win/DumpRenderTree.vcproj: 17918 * DumpRenderTree/win/ImageDiff.vcproj: 17919 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: 17920 179212009-07-17 David Levin <levin@chromium.org> 17922 17923 Reviewed by Adam Treat. 17924 17925 WebKit should have a bash completion script to aid with common commands. 17926 https://bugs.webkit.org/show_bug.cgi?id=27374 17927 17928 * Scripts/webkit-tools-completion.sh: The script which enables option completion 17929 for several WebKit command line scripts. 17930 179312009-07-17 Peter Kasting <pkasting@google.com> 17932 17933 Reviewed by David Kilzer. 17934 17935 https://bugs.webkit.org/show_bug.cgi?id=27323 17936 Avoid error spew on Macs, and fix a few other tiny details. 17937 17938 * Scripts/svn-create-patch: 17939 179402009-07-17 Adam Treat <adam.treat@torchmobile.com> 17941 17942 Reviewed by Dave Levin. 17943 17944 https://bugs.webkit.org/show_bug.cgi?id=27377 17945 This makes cpplint complain about this for instance: 17946 17947 if (true) 17948 { 17949 int foo; 17950 } 17951 17952 Add the appropriate unit tests. 17953 17954 * Scripts/modules/cpplint.py: 17955 * Scripts/modules/cpplint_unittest.py: 17956 179572009-07-17 Adam Treat <adam.treat@torchmobile.com> 17958 17959 Reviewed by Dave Levin. 17960 17961 https://bugs.webkit.org/show_bug.cgi?id=27377 17962 Don't filter whitespace at the end of the line. This is not 17963 explicitly a rule of webkit coding style, but there is no reason 17964 not to warn of this common style problem. 17965 17966 Don't filter whitespace newline. Now, cpplint will complain 17967 about the following situation: 17968 17969 if (true) { 17970 doSomething(); 17971 doSomethingAgain(); 17972 } 17973 else 17974 doSomething(); 17975 17976 Which is a webkit coding style rule violation. 17977 17978 * Scripts/modules/cpplint.py: 17979 179802009-07-17 Adam Treat <adam.treat@torchmobile.com> 17981 17982 Reviewed by Dave Levin. 17983 17984 https://bugs.webkit.org/show_bug.cgi?id=27377 17985 Move this comment to where it belongs. 17986 17987 * Scripts/modules/cpplint_unittest.py: 17988 179892009-07-17 Brent Fulgham <bfulgham@webkit.org> 17990 17991 Reviewed by Adam Roben. 17992 17993 Correct crash in WinLauncher due to improper mixing of BSTR 17994 and TCHAR types. 17995 https://bugs.webkit.org/show_bug.cgi?id=27381 17996 17997 * WinLauncher/WinLauncher.cpp: 17998 (loadURL): Perform SysReAllocString to update the BSTR with 17999 the contents of the TCHAR string. 18000 180012009-07-17 David Levin <levin@chromium.org> 18002 18003 Reviewed by Adam Treat. 18004 18005 cpplint should flag usages of NULL. 18006 https://bugs.webkit.org/show_bug.cgi?id=27341 18007 18008 * Scripts/modules/cpplint.py: Add the check for NULL test and call it. 18009 Make the collapse_strings method public. 18010 * Scripts/modules/cpplint_unittest.py: Add several tests to verify 18011 the check for NULL behavior. Adjust existing tests due to the 18012 new NULL check: 18013 1. Several had NULL removed (or were just removed completely). 18014 2. Two tests now do an assert that allows the caller to check 18015 that a particular error is one of several that was returned. 18016 180172009-07-17 Shinichiro Hamaji <hamaji@chromium.org> 18018 18019 Reviewed by David Levin. 18020 18021 Add a parser of patches for linter. 18022 https://bugs.webkit.org/show_bug.cgi?id=27363 18023 18024 Adds a simple parser for unified diff format. 18025 18026 * Scripts/modules/diff_parser.py: Added. 18027 * Scripts/modules/diff_parser_unittest.py: Added. 18028 180292009-06-30 Holger Hans Peter Freyther <zecke@selfish.org> 18030 18031 Reviewed by Simon Hausmann. 18032 18033 [GTK+] Remove check to be loadable in firefox 18034 https://bugs.webkit.org/show_bug.cgi?id=27345 18035 18036 if (aMozillaVTable->size < sizeof (NPNetscapeFuncs)) 18037 fails in firefox but no other example in the mozilla tree is 18038 doing that check. Remove and be happy. 18039 18040 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 18041 (NP_Initialize): 18042 180432009-07-17 Adam Treat <adam.treat@torchmobile.com> 18044 18045 Reviewed by Simon Hausmann. 18046 18047 Something about having a single TAB in a style checking tool like this 18048 is equivalent to nails on a chalk board to me... 18049 18050 * Scripts/modules/cpplint.py: 18051 180522009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org> 18053 18054 Reviewed by Simon Hausmann. 18055 18056 Overwrite the plugin directories for the DRT. 18057 Part of https://bugs.webkit.org/show_bug.cgi?id=27215 18058 18059 * DumpRenderTree/qt/DumpRenderTree.cpp: 18060 (WebCore::DumpRenderTree::DumpRenderTree): 18061 180622009-07-16 Fumitoshi Ukai <ukai@chromium.org> 18063 18064 Reviewed by David Levin. 18065 18066 Add --web-sockets flag and ENABLE_WEB_SOCKETS define. 18067 https://bugs.webkit.org/show_bug.cgi?id=27206 18068 18069 Add --web-sockets flag. 18070 18071 * Scripts/build-webkit: add --web-sockets flag. 18072 180732009-07-16 Adam Treat <adam.treat@torchmobile.com> 18074 18075 Reviewed by Dave Levin. 18076 18077 cpplint should check for one line control clauses that are surrounded 18078 by braces 18079 https://bugs.webkit.org/show_bug.cgi?id=27354 18080 18081 * Scripts/modules/cpplint.py: Added the new lint check. 18082 * Scripts/modules/cpplint_unittest.py: Add tests for the new lint check 18083 and fix the other tests as they were not passing this new lint check. 18084 180852009-07-16 Peter Kasting <pkasting@google.com> 18086 18087 Reviewed by David Kilzer. 18088 18089 https://bugs.webkit.org/show_bug.cgi?id=27323 18090 Improve support for WebKit checkouts hosted inside other checkouts 18091 (possible for some ports, e.g. Chromium). 18092 18093 * Scripts/svn-create-patch: Determine SVN root by looking for Repository 18094 Root string and aborting when it's missing or different than what 18095 we've already seen. 18096 180972009-07-16 Peter Kasting <pkasting@google.com> 18098 18099 Reviewed by Adam Roben. 18100 18101 https://bugs.webkit.org/show_bug.cgi?id=27323 18102 Improve support for non-Cygwin SVNs on Windows. 18103 18104 * Scripts/commit-log-editor: Modify regex so that trailing whitespace 18105 (e.g. \r) isn't included in filenames. 18106 * Scripts/prepare-ChangeLog: Fix a case of adding "\n" to the ChangeLog 18107 without normalizing. Normalize file paths early instead of late so 18108 all stages of the script work. Modify regexes so that trailing 18109 whitespace (e.g. \r) isn't included in filenames. 18110 * Scripts/svn-create-patch: Use a regex instead of chomp so we cut off 18111 line endings even if they don't match Perl's. 18112 181132009-07-16 Joseph Pecoraro <joepeck02@gmail.com> 18114 18115 Reviewed by Darin Adler. 18116 18117 WebKitTools/Scripts/svn-create-patch is broken 18118 https://bugs.webkit.org/show_bug.cgi?id=27328 18119 18120 * Scripts/svn-create-patch: one line fix for unusual perl behavior 18121 181222009-07-16 David Levin <levin@chromium.org> 18123 18124 Reviewed by David Kilzer. 18125 18126 cpplint should check for equality comparisons to 0/true/false 18127 https://bugs.webkit.org/show_bug.cgi?id=27333 18128 18129 * Scripts/modules/cpplint.py: Added the new lint check. 18130 * Scripts/modules/cpplint_unittest.py: Add tests for the new lint check 18131 and fix a regex that in another unit test that caused it to fail when 18132 you have a directory with a number in it (like WebKit-2) 18133 181342009-07-16 David D. Kilzer <ddkilzer@webkit.org> 18135 18136 <http://webkit.org/b/27241> bugzilla-tool post-commits silently fails with bad args 18137 18138 Reviewed by Eric Seidel. 18139 18140 * Scripts/bugzilla-tool: 18141 (PostCommitsAsPatchesToBug.execute): Added more error checking 18142 when consuming arguments. 18143 181442009-07-16 David D. Kilzer <ddkilzer@webkit.org> 18145 18146 TOOL FIX: scm.py: CommitMessage.message is ambiguous 18147 18148 Fixes this error when running bugzilla-tool apply-patches 18149 --local-commit: 18150 18151 File "bugzilla-tool", line 188, in apply_patches 18152 scm.commit_locally_with_message(commit_message.message() or patch['name']) 18153 TypeError: 'list' object is not callable 18154 18155 * Scripts/modules/scm.py: After r45940 (and r45971), rename 18156 CommitMessage.message attribute to CommitMessage.message_lines. 18157 (CommitMessage.__init__): 18158 (CommitMessage.body): 18159 (CommitMessage.description): 18160 (CommitMessage.message): 18161 (CommitMessage.parse_bug_id): 18162 181632009-07-16 David D. Kilzer <ddkilzer@webkit.org> 18164 18165 TOOL FIX: bugzilla-tool: import CommitMessage class 18166 18167 * Scripts/bugzilla-tool: After r45940, the CommitMessage class 18168 needs to be imported for commit_message_for_this_commit(). 18169 181702009-07-16 David Levin <levin@chromium.org> 18171 18172 Reviewed by Maciej Stachowiak. 18173 18174 prepare-ChangeLog should display the --bug option in its help text. 18175 https://bugs.webkit.org/show_bug.cgi?id=27334 18176 18177 * Scripts/prepare-ChangeLog: Added the help text. 18178 181792009-07-15 Darin Adler <darin@apple.com> 18180 18181 * Scripts/do-webcore-rename: Check in the version used to 18182 rename parseURL to deprecatedParseURL. 18183 181842009-07-10 David Kilzer <ddkilzer@apple.com> 18185 18186 bugzilla-tool: create CommitMessage class 18187 18188 Reviewed by Eric Seidel. 18189 18190 Create a CommitMessage class to encapsulate related code. 18191 18192 * Scripts/bugzilla-tool: 18193 (bug_id_from_commit_message): Moved to 18194 CommitMessage.parse_bug_id(). 18195 (commit_message_for_this_commit): Return a CommitMessage. 18196 (ApplyPatchesFromBug.apply_patches): Use CommitMessage.message(). 18197 (LandPatchesFromBugs.build_and_commit): Ditto. 18198 (CommitMessageForCurrentDiff.execute): Ditto. 18199 (PostCommitsAsPatchesToBug.execute): Switched from 18200 Git.commit_message_for_commit() to 18201 Git.commit_message_for_local_commit(). Switched from 18202 bug_id_from_commit_message() to CommitMessage.parse_bug_id(). 18203 18204 * Scripts/modules/scm.py: 18205 (first_non_empty_line_after_index): Added. 18206 (CommitMessage.__init__): Added. 18207 (CommitMessage.body): Added. 18208 (CommitMessage.description): Added. 18209 (CommitMessage.message): Added. 18210 (CommitMessage.parse_bug_id): Added. Moved from 18211 bug_id_from_commit_message() in bugzilla-tool. 18212 (Git.commit_message_for_local_commit): Renamed from 18213 commit_message_for_commit(). Return a CommitMessage. 18214 182152009-07-15 Joseph Pecoraro <joepeck02@gmail.com> 18216 18217 Reviewed by David Kilzer. 18218 18219 bugzilla-tool/svn-apply can't handle patches made from a non-root directory 18220 https://bugs.webkit.org/show_bug.cgi?id=26999 18221 18222 * Scripts/svn-create-patch: 18223 182242009-07-15 Shinichiro Hamaji <hamaji@chromium.org> 18225 18226 Reviewed by David Levin. 18227 18228 Move cpplint.py to module directory 18229 https://bugs.webkit.org/show_bug.cgi?id=27302 18230 18231 * Scripts/modules/cpplint.py: Renamed from WebKitTools/Scripts/cpplint.py. 18232 * Scripts/modules/cpplint_unittest.py: Renamed from WebKitTools/Scripts/cpplint_unittest.py. 18233 182342009-07-15 Simon Hausmann <simon.hausmann@nokia.com> 18235 18236 Reviewed by Adam Treat. 18237 18238 https://bugs.webkit.org/show_bug.cgi?id=27295 18239 18240 Re-implement QWebPage::shouldInterruptJavaScript to disable 18241 js interruption and avoid showing a messagebox during Qt DRT 18242 runs when script execution takes a bit longer. 18243 18244 * DumpRenderTree/qt/DumpRenderTree.cpp: 18245 (WebCore::WebPage::shouldInterruptJavaScript): Return false 18246 in re-implemented slot. 18247 182482009-07-15 Zoltan Horvath <hzoltan@inf.u-szeged.hu> 18249 18250 Reviewed by Jan Alonzo. 18251 18252 Fix the DumpRenderTree GTK+ build 18253 https://bugs.webkit.org/show_bug.cgi?id=27290 18254 18255 Set USE_SYSTEM_MALLOC macro for the DumpRenderTree build to 18256 disable using TCmalloc in DumpRenderTree. 18257 18258 * GNUmakefile.am: 18259 182602009-07-14 Steve Falkenburg <sfalken@apple.com> 18261 18262 Reorganize JavaScriptCore headers into: 18263 API: include/JavaScriptCore/ 18264 Private: include/private/JavaScriptCore/ 18265 18266 Reviewed by Darin Adler. 18267 18268 * DumpRenderTree/win/DumpRenderTree.vcproj: 18269 * DumpRenderTree/win/ImageDiff.vcproj: 18270 182712009-07-14 Shinichiro Hamaji <hamaji@chromium.org> 18272 18273 Reviewed by David Levin. 18274 18275 WebKit needs a style linting tool 18276 https://bugs.webkit.org/show_bug.cgi?id=25884 18277 18278 Modifies cpplint (http://google-styleguide.googlecode.com/svn/trunk/cpplint/) 18279 based on WebKit's style guide. 18280 18281 * Scripts/cpplint.py: Added. 18282 * Scripts/cpplint_unittest.py: Added. 18283 182842009-07-14 Laszlo Gombos <laszlo.1.gombos@nokia.com> 18285 18286 Reviewed by Simon Hausmann. 18287 18288 [Qt] DumpRenderTree no longer builds with Qt4.4 18289 https://bugs.webkit.org/show_bug.cgi?id=27257 18290 18291 Flag Qt 4.5 dependency to allow building with Qt 4.4. 18292 18293 * DumpRenderTree/qt/main.cpp: 18294 (main): 18295 182962009-07-13 Brent Fulgham <bfulgham@webkit.org> 18297 18298 Reviewed by Adam Roben. 18299 18300 Add new configuration flag for redistributable Windows build. 18301 https://bugs.webkit.org/show_bug.cgi=27087 18302 18303 * DumpRenderTree/config.h: Check for presence of WIN_CAIRO and 18304 select appropriate configuration. Defaults to standard Apple build. 18305 * DumpRenderTree/win/DumpRenderTree.vcproj: Add new WinCairo.vsprops 18306 to Debug_Cairo and Release_Cairo targets. 18307 183082009-07-13 Simon Hausmann <simon.hausmann@nokia.com> 18309 18310 Reviewed by Ariya Hidayat. 18311 18312 Always run the Qt DRT with the raster graphicssystem on X11, for 18313 increased stability in the image based tests, in particular canvas. 18314 18315 * DumpRenderTree/qt/main.cpp: 18316 (main): 18317 183182009-07-13 Simon Hausmann <simon.hausmann@nokia.com> 18319 18320 Reviewed by Ariya Hidayat. 18321 18322 Fix test netscape plugin usage with the Qt DRT. 18323 18324 * DumpRenderTree/qt/DumpRenderTree.cpp: 18325 (WebCore::WebPage::WebPage): Enable plugins in the settings. 18326 * Scripts/run-webkit-tests: Set the QT_WEBKIT_PLUGIN path to the correct build 18327 directory to make Qt DRT find the test netscape plugin. 18328 183292009-07-13 Simon Hausmann <hausmann@webkit.org> 18330 18331 Reviewed by Ariya Hidayat. 18332 18333 Make sure to disable the fixed contents size when resetting the page/view 18334 state between test runs, to avoid side-effects. 18335 18336 * DumpRenderTree/qt/DumpRenderTree.cpp: 18337 (WebCore::DumpRenderTree::open): Call setFixedContentsSize() with an invalid 18338 QSize to disable the fixed layout. 18339 183402009-07-13 Simon Hausmann <hausmann@webkit.org> 18341 18342 Reviewed by Ariya Hidayat. 18343 18344 When creating new windows, don't forget to connect the new 18345 page's main frame. This ensures that for example the layoutTestController 18346 is also available there. 18347 18348 * DumpRenderTree/qt/DumpRenderTree.cpp: 18349 (WebCore::DumpRenderTree::createWindow): 18350 183512009-07-13 Simon Hausmann <hausmann@webkit.org> 18352 18353 Reviewed by Ariya Hidayat. 18354 18355 Added support for LayoutTestController.setPrivateBrowsingEnabled. 18356 18357 * DumpRenderTree/qt/jsobjects.cpp: 18358 (LayoutTestController::reset): 18359 (LayoutTestController::setPrivateBrowsingEnabled): 18360 * DumpRenderTree/qt/jsobjects.h: 18361 183622009-07-13 Simon Hausmann <hausmann@webkit.org> 18363 18364 Reviewed by Ariya Hidayat. 18365 18366 Added support for database callbacks, storage quota setting, 18367 and clearing of all databases. 18368 18369 * DumpRenderTree/qt/DumpRenderTree.cpp: 18370 (WebCore::DumpRenderTree::DumpRenderTree): 18371 (WebCore::DumpRenderTree::dumpDatabaseQuota): 18372 * DumpRenderTree/qt/DumpRenderTree.h: 18373 * DumpRenderTree/qt/jsobjects.cpp: 18374 (LayoutTestController::reset): 18375 (LayoutTestController::setDatabaseQuota): 18376 (LayoutTestController::clearAllDatabases): 18377 * DumpRenderTree/qt/jsobjects.h: 18378 (LayoutTestController::shouldDumpDatabaseCallbacks): 18379 (LayoutTestController::dumpDatabaseCallbacks): 18380 * DumpRenderTree/qt/main.cpp: 18381 (main): 18382 183832009-07-13 Simon Hausmann <hausmann@webkit.org> 18384 18385 Reviewed by Ariya Hidayat. 18386 18387 Setup the path in the Qt DRT for HTML 5 Databases, to enable some of 18388 the storage layout tests. 18389 18390 * DumpRenderTree/qt/main.cpp: 18391 (main): 18392 183932009-07-13 Simon Hausmann <hausmann@webkit.org> 18394 18395 Reviewed by Ariya Hidayat. 18396 18397 Make the test output more robust by dumping only when the main 18398 frame finishes loading, instead of when _any_ frame finishes. 18399 18400 * DumpRenderTree/qt/DumpRenderTree.cpp: 18401 (WebCore::DumpRenderTree::DumpRenderTree): Connect to the 18402 main frame's loadFinished() signal instead of the page's one. 18403 184042009-07-13 Simon Hausmann <hausmann@webkit.org> 18405 18406 Reviewed by Ariya Hidayat. 18407 18408 Implement the GCController DRT interface. 18409 18410 * DumpRenderTree/qt/DumpRenderTree.cpp: 18411 (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController. 18412 (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine. 18413 * DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController. 18414 * DumpRenderTree/qt/jsobjects.cpp: Implement GCController. 18415 (GCController::GCController): 18416 (GCController::collect): 18417 (GCController::collectOnAlternateThread): 18418 (GCController::getJSObjectCount): 18419 * DumpRenderTree/qt/jsobjects.h: Declare GCController. 18420 184212009-07-13 Simon Hausmann <hausmann@webkit.org> 18422 18423 Reviewed by Ariya Hidayat. 18424 18425 Implement the GCController DRT interface in the Qt DRT. 18426 18427 * DumpRenderTree/qt/DumpRenderTree.cpp: 18428 (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController. 18429 (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine. 18430 * DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController. 18431 * DumpRenderTree/qt/jsobjects.cpp: Implement GCController. 18432 (GCController::GCController): 18433 (GCController::collect): 18434 (GCController::collectOnAlternateThread): 18435 (GCController::getJSObjectCount): 18436 * DumpRenderTree/qt/jsobjects.h: Declare GCController. 18437 184382009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org> 18439 18440 https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT 18441 18442 Reviewed by Gustavo Noronha and Xan Lopez. 18443 18444 Support running of tests that open and close JS windows automatically. 18445 18446 * DumpRenderTree/gtk/DumpRenderTree.cpp: 18447 (dumpFramesAsText): 18448 (dumpBackForwardListForAllWebViews): 18449 (resetWebViewToConsistentStateBeforeTesting): 18450 (dump): 18451 (runTest): 18452 (webViewClose): 18453 (createWebView): 18454 (webViewCreate): 18455 (main): 18456 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: 18457 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 18458 (LayoutTestController::windowCount): 18459 (LayoutTestController::setPopupBlockingEnabled): 18460 184612009-07-13 Shinichiro Hamaji <hamaji@chromium.org> 18462 18463 Reviewed by Maciej Stachowiak. 18464 18465 prepare-ChangeLog should decode HTML entities in short description 18466 https://bugs.webkit.org/show_bug.cgi?id=27122 18467 18468 Decode the short description by adding a function which decodes HTML 18469 entities. It can decode &, <, >, ", and ' . They may be sufficient 18470 as the description seems to be encoded by xml_quote in 18471 http://mxr.mozilla.org/bugzilla/source/Bugzilla/Util.pm 18472 18473 * Scripts/prepare-ChangeLog: 18474 184752009-07-13 Drew Wilson <atwilson@google.com> 18476 18477 Reviewed by David Levin. 18478 18479 Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs 18480 https://bugs.webkit.org/show_bug.cgi?id=26932 18481 18482 Added support for --shared-workers (turned off by default) 18483 18484 * Scripts/build-webkit: 18485 184862009-07-12 Dan Bernstein <mitz@apple.com> 18487 18488 Reviewed by Maciej Stachowiak. 18489 18490 https://bugs.webkit.org/show_bug.cgi?id=27196 18491 Update check-for-global-initializers for the renaming for bidi.cpp to 18492 RenderBlockLineLayout.cpp 18493 18494 * Scripts/check-for-global-initializers: 18495 184962009-07-11 Simon Fraser <simon.fraser@apple.com> 18497 18498 Enable support for accelerated compositing and 3d transforms on Leopard. 18499 <https://bugs.webkit.org/show_bug.cgi?id=20166> 18500 <rdar://problem/6120614> 18501 18502 Reviewed by Oliver Hunt. 18503 18504 * Configurations/FeatureDefines.xcconfig: 18505 * wtf/Platform.h: 18506 185072009-07-10 David Kilzer <ddkilzer@apple.com> 18508 18509 <http://webkit.org/b/27173> svn-apply: Fix typo in git command used to find deleted files 18510 18511 Reviewed by Eric Seidel. 18512 18513 * Scripts/svn-apply: 18514 (scmWillDeleteFile): Changed 'head' to 'HEAD'. 18515 185162009-07-10 David Kilzer <ddkilzer@apple.com> 18517 18518 <http://webkit.org/b/27167> bugzilla-tool: hide help for unsupported commands 18519 18520 Reviewed by Eric Seidel. 18521 18522 When bugzilla-tool -h|--help is invoked in an svn working 18523 directory, don't print help for commands that are only supported 18524 on git working directories. 18525 18526 * Scripts/bugzilla-tool: 18527 (Command.__init__): Added requires_local_commits argument with a 18528 default of False. Set self.requires_local_commits attribute. 18529 (PostCommitsAsPatchesToBug.execute): Removed 18530 SCM.supports_local_commits() check since this is now handled by 18531 BugzillaTool.main(). 18532 (PostCommitsAsPatchesToBug.__init__): Added 18533 requires_local_commits=True argument to Command.__init__(). 18534 (BugzillaTool.commands_usage): Don't print help for commands if 18535 they require local commits and the current SCM doesn't support 18536 them. 18537 (BugzillaTool.main): If command_object requires local commits 18538 and the current SCM doesn't, exit with an error message. 18539 185402009-07-10 David Kilzer <ddkilzer@apple.com> 18541 18542 <http://webkit.org/b/27117> bugzilla-tool: use Mac OS X keychain for authentication 18543 18544 Reviewed by Eric Seidel. 18545 18546 Try reading credentials from git config first, then keychain if 18547 running on Mac OS X, else prompt at the command-line. 18548 18549 * Scripts/modules/bugzilla.py: Added "import platform". 18550 (credentials_from_git): Added. 18551 (credentials_from_keychain): Added. 18552 (is_mac_os_x): Added. 18553 (read_credentials): Added. 18554 (Bugzilla.__init__): Moved instance attribute bug_server to a 18555 static attribute named bug-server_url. 18556 (Bugzilla.bug_server_host): Added. Extracted host name from 18557 bug_server_url. 18558 (Bugzilla.bug_server_regex): Updated to be created using 18559 bug_server_host. 18560 (Bugzilla.bug_server_url): Renamed from bug_server. 18561 (Bugzilla.bug_url_for_bug_id): Updated for renaming of 18562 bug_server to bug_server_url. 18563 (Bugzilla.attachment_url_for_id): Ditto. 18564 (Bugzilla.fetch_bug_ids_from_commit_queue): Ditto. 18565 (Bugzilla.authenticate): Ditto. Updated to use 18566 read_credentials(). 18567 (Bugzilla.add_patch_to_bug): Ditto. 18568 185692009-07-10 David Kilzer <ddkilzer@apple.com> 18570 18571 <http://webkit.org/b/27115> bugzilla-tool: extract duplicate logging methods into a module 18572 18573 Reviewed by Adam Roben. 18574 18575 * Scripts/bugzilla-tool: Removed error() and log() methods and 18576 added import of new logging module. 18577 * Scripts/modules/bugzilla.py: Ditto. Removed "import sys". 18578 * Scripts/modules/scm.py: Ditto. 18579 18580 * Scripts/modules/logging.py: Added. 18581 (log): Added. 18582 (error): Added. Prefix error messages with "ERROR: ". 18583 185842009-07-10 Adam Roben <aroben@apple.com> 18585 18586 Sort all our Xcode projects 18587 18588 Accomplished using sort-Xcode-project-file. 18589 18590 Requested by Dave Kilzer. 18591 18592 * DrawTest/DrawTest.xcodeproj/project.pbxproj: 18593 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 18594 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: 18595 185962009-07-10 Adam Roben <aroben@apple.com> 18597 18598 Print prepare-ChangeLog's reminders to STDERR so they don't end up in 18599 the diff output 18600 18601 Fixes REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines 18602 into the diff 18603 <https://bugs.webkit.org/show_bug.cgi?id=27150> 18604 18605 Reviewed by Maciej Stachowiak. 18606 18607 * Scripts/prepare-ChangeLog: 18608 186092009-07-08 Adam Roben <aroben@apple.com> 18610 18611 Use case-insensitive comparisons when sorting Xcode project files 18612 18613 This matches the sorting used in Xcode's files list. 18614 18615 Fixes Bug 27079: sort-Xcode-project-file should sort 18616 case-insensitively, to match Xcode's files list 18617 <https://bugs.webkit.org/show_bug.cgi?id=27079> 18618 18619 Reviewed by Dave Kilzer. 18620 18621 * Scripts/sort-Xcode-project-file: 18622 (sortChildrenByFileName): 18623 (sortFilesByFileName): 18624 Lowercase the strings before comparing them so that the comparison 18625 will be case-insensitive. 18626 186272009-07-08 Simon Hausmann <hausmann@webkit.org> 18628 18629 Reviewed by Holger Freyther. 18630 18631 https://bugs.webkit.org/show_bug.cgi?id=27109 18632 18633 Fix side-effects in the Qt DRT with tests using application fonts. 18634 18635 Detect if a test used application fonts and re-initialize the fontconfig 18636 application fontset accordingly. 18637 18638 * DumpRenderTree/qt/DumpRenderTree.cpp: 18639 (WebCore::DumpRenderTree::open): call initializeFonts and remove all application fonts 18640 after running a testcase. 18641 (WebCore::DumpRenderTree::initializeFonts): Moved fontconfig initialization code 18642 here from main. 18643 * DumpRenderTree/qt/DumpRenderTree.h: Declare initializeFonts. 18644 * DumpRenderTree/qt/main.cpp: 18645 (main): Moved fontconfig initialization code to DRT::initializeFonts. 18646 186472009-07-10 Antonio Gomes <antonio.gomes@openbossa.org> 18648 18649 Reviewed by Simon Hausmann. 18650 18651 [QT] [ARM] Add pkg-config entry for FontConfig on DRT.pro 18652 https://bugs.webkit.org/show_bug.cgi?id=26990 18653 18654 Missing pkg-config entry for FontConfig in DRT.pro causes some compilers to 18655 not link fine against FontConfig bits. 18656 18657 * DumpRenderTree/qt/DumpRenderTree.pro: 18658 186592009-07-09 Drew Wilson <atwilson@google.com> 18660 18661 Reviewed by Alexey Proskuryakov. 18662 18663 https://bugs.webkit.org/show_bug.cgi?id=26903 18664 18665 Turned on CHANNEL_MESSAGING by default because the MessageChannel API 18666 can now be implemented for Web Workers and is reasonably stable. 18667 18668 * Scripts/build-webkit: 18669 186702009-07-09 David Kilzer <ddkilzer@apple.com> 18671 18672 <http://webkit.org/b/27114> bugzilla-tool: Parse short bug URL from commit log messages 18673 18674 Reviewed by Adam Roben. 18675 18676 * Scripts/bugzilla-tool: 18677 (bug_id_from_commit_message): Check for the short bug URL before 18678 checking for the longer bugs.webkit.org URL. 18679 186802009-07-08 David Kilzer <ddkilzer@apple.com> 18681 18682 Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and actually work 18683 18684 <https://bugs.webkit.org/show_bug.cgi?id=27062> 18685 18686 Reviewed by Eric Seidel. 18687 18688 Removed the required BUGID argument from the "post-commits" 18689 command and replaced it with a -b|--bug-id switch or parsing the 18690 commit log message for the bug URL. Fixed a bug in the 18691 "post-commits" that would ignore the COMMITISH used and post a 18692 patch of local changes against HEAD. Added --no-commit switch 18693 to disable using the bulk of the ChangeLog entry as the comment 18694 for the new patch. 18695 18696 * Scripts/bugzilla-tool: 18697 (bug_id_from_commit_message): Added. Returns a bug id from the 18698 commit log message, thus enforcing the need for a bug URL in the 18699 message. 18700 (PostCommitsAsPatchesToBug.__init__): Updated help description 18701 to match new behavior of pulling bug ids from commit log 18702 messages instead of from the command line. Added -b|--bug-id 18703 switch and --no-comment switch. 18704 (PostCommitsAsPatchesToBug.execute): Updated to use 18705 bug_id_from_commit_message() to pull bug ids from commit log 18706 messages. Also switched from SCM.create_patch() to use 18707 SCM.create_patch_from_local_commit() to fix a bug where local 18708 repository changes were posted as a patch instead of the 18709 specific COMMITISH. Fall back to -b|--bug-id if no URL is found 18710 in the commit log message. Don't specify a comment for the 18711 patch if --no-comment is used. Set cherry_pick argument to True 18712 for Git.commit_ids_from_range_arguments() since we don't want 18713 implicit commit range behavior for this command. 18714 18715 * Scripts/modules/bugzilla.py: Import datetime module. 18716 (timestamp): Added. Returns a timestamp in the form of 18717 "YYYYMMDDhhmmss". 18718 (Bugzilla.bug_server_regex): Added static attribute. 18719 (Bugzilla.add_patch_to_bug): Construct a more meaningful patch 18720 file name using the bug_id and timestamp(). 18721 18722 * Scripts/modules/scm.py: 18723 (SCM.create_patch_from_local_commit): Added. 18724 (Git.create_patch_from_local_commit): Added. Runs "git diff" to 18725 return a patch for the given commit_id. 18726 187272009-07-08 Maciej Stachowiak <mjs@apple.com> 18728 18729 Reviewed by Mark Rowe. 18730 18731 Make prepare-ChangeLog less shouty 18732 https://bugs.webkit.org/show_bug.cgi?id=27098 18733 18734 * Scripts/prepare-ChangeLog: 18735 187362009-07-08 David Kilzer <ddkilzer@apple.com> 18737 18738 Bug 27083: bugzilla.py: Clean up bug_server use 18739 18740 <https://bugs.webkit.org/show_bug.cgi?id=27083> 18741 18742 Reviewed by Darin Adler. 18743 18744 * Scripts/modules/bugzilla.py: 18745 (Bugzilla.fetch_bug_ids_from_commit_queue): Use bug_server 18746 instead of hard-coding the URL. 18747 (Bugzilla.authenticate): Remove extra '/' before URL path. 18748 (Bugzilla.add_patch_to_bug): Ditto. 18749 187502009-07-08 Brent Fulgham <bfulgham@webkit.org> 18751 18752 Build fix for Windows Cairo. 18753 18754 Cairo build was incorrectly #including the PixelDumpSupportCG.h 18755 instead of PixelDumpSupportCairo.h 18756 18757 * DumpRenderTree/win/PixelDumpSupportWin.cpp: Correct #include 18758 187592009-07-08 David Faure <faure@kde.org> 18760 18761 Reviewed by Ariya Hidayat. 18762 18763 Small documentation improvement for build-webkit --help 18764 18765 * Scripts/build-webkit: mention --debug option 18766 187672009-07-07 Brady Eidson <beidson@apple.com> 18768 18769 Tiger build fix, work around missing NSString API. 18770 18771 * DumpRenderTree/mac/DumpRenderTree.mm: 18772 (dumpHistoryItem): 18773 187742009-07-07 Brady Eidson <beidson@apple.com> 18775 18776 Reviewed by Mark Rowe. 18777 18778 https://bugs.webkit.org/show_bug.cgi?id=27049 - In dumpBackForwardList() mode, DRT should normalize file urls. 18779 18780 Make the dump of a history item agnostic to the layout of filesystem on the testing machine. 18781 18782 * DumpRenderTree/mac/DumpRenderTree.mm: 18783 (dumpHistoryItem): 18784 * DumpRenderTree/win/DumpRenderTree.cpp: 18785 (dumpHistoryItem): 18786 187872009-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 18788 18789 Rubber-stamped by Simon Hausmann. 18790 18791 Correct git url of the Qt test-fonts. 18792 18793 * DumpRenderTree/qt/main.cpp: 18794 (main): 18795 187962009-07-07 Simon Hausmann <hausmann@webkit.org> 18797 18798 Reviewed by Holger Freyther. 18799 18800 Clear the main frame's name between loading pages, like in r36652. This 18801 reduces the side-effects between test cases. 18802 18803 * DumpRenderTree/qt/DumpRenderTree.cpp: 18804 (WebCore::DumpRenderTree::open): 18805 188062009-07-06 Simon Hausmann <hausmann@webkit.org> 18807 18808 Reviewed by Holger Freyther. 18809 18810 Fix various layout tests with Qt's DRT. 18811 18812 Remember to set the focus on the web page before 18813 loading. 18814 18815 * DumpRenderTree/qt/DumpRenderTree.cpp: 18816 (WebCore::DumpRenderTree::open): 18817 188182009-07-07 Simon Hausmann <hausmann@webkit.org> 18819 18820 Reviewed by Tor Arne Vestbø and Holger Freyther. 18821 18822 Fix timeout timer handling in Qt DRT. 18823 18824 Use QBasicTimer instead of startTimer/killTimer, to fix the 18825 problem that starting the timeout timer did not stop a 18826 previously started timer, causing multiple emissions of timeout. 18827 The timerEvent() implementation now also checks the timer id, to 18828 protect against double timeouts. 18829 18830 * DumpRenderTree/qt/jsobjects.cpp: 18831 (LayoutTestController::LayoutTestController): 18832 (LayoutTestController::reset): 18833 (LayoutTestController::waitUntilDone): 18834 (LayoutTestController::notifyDone): 18835 (LayoutTestController::timerEvent): 18836 * DumpRenderTree/qt/jsobjects.h: 18837 188382009-07-06 Eric Seidel <eric@webkit.org> 18839 18840 Reviewed by Maciej Stachowiak. 18841 18842 bugzilla-tool fails to close bugs with bugzilla 3.0 18843 https://bugs.webkit.org/show_bug.cgi?id=27008 18844 18845 Update bugzilla.py to match changes in the bug page "changeform" 18846 Update scm.py to add bug_ids to attachments to make error reporting nicer. 18847 18848 * Scripts/modules/bugzilla.py: 18849 * Scripts/modules/scm.py: 18850 188512009-07-03 Maciej Stachowiak <mjs@apple.com> 18852 18853 Reviewed by Eric Seidel. 18854 18855 bugzilla-tool forgot how to obsolete patches 18856 https://bugs.webkit.org/show_bug.cgi?id=26951 18857 18858 * Scripts/modules/bugzilla.py: 18859 188602009-07-02 Brent Fulgham <bfulgham@webkit.org> 18861 18862 Unreviewed build fix (Cairo this time) for DumpRenderTree. 18863 Put Cairo code back in, but use original include order 18864 for the CG stuff to avoid compile issues. 18865 18866 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 18867 (createBitmapContextFromWebView): 18868 188692009-07-02 Eric Seidel <eric@webkit.org> 18870 18871 Correct blatant typo (missing []), no review. 18872 18873 * Scripts/modules/scm.py: 18874 188752009-07-02 Brent Fulgham <bfulgham@webkit.org> 18876 18877 Windows build fix, no review. 18878 18879 18880 Reverting PixelDumpSupportWin.cpp change to avoid strange 18881 error on the build-bot. 18882 18883 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 18884 (createBitmapContextFromWebView): 18885 188862009-07-02 Brent Fulgham <bfulgham@webkit.org> 18887 18888 Build fix, no review. 18889 18890 * DumpRenderTree/config.h: 18891 188922009-07-02 Eric Seidel <eric@webkit.org> 18893 18894 Reviewed by David Levin. 18895 18896 bugzilla-tool needs to handle login failure 18897 https://bugs.webkit.org/show_bug.cgi?id=26913 18898 18899 We now exit(1) on login failure. 18900 18901 * Scripts/modules/bugzilla.py: 18902 189032009-06-30 Brent Fulgham <bfulgham@webkit.org> 18904 18905 Reviewed by Adam Roben. 18906 18907 Add build support for a Windows Cairo version of 18908 DumpRenderTree. Share as much logic between the 18909 CG and Cairo builds as possible. 18910 https://bugs.webkit.org/show_bug.cgi?id=26457 18911 18912 * DumpRenderTree/PixelDumpSupport.cpp: Added. 18913 (dumpWebViewAsPixelsAndCompareWithExpected): Moved common logic 18914 from CG-specific file. 18915 (printPNG): Moved common logic from CG-specific file. 18916 * DumpRenderTree/PixelDumpSupport.h: Add declaration for new 18917 common printPNG function. 18918 * DumpRenderTree/cairo: Added. 18919 * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Added. 18920 Implement cairo-specific logic for dealing with Cairo surfaces. 18921 (writeFunction): 18922 (printPNG): Cairo-specific PNG handling logic. 18923 (computeMD5HashStringForBitmapContext): New Cairo routine using 18924 the generic BitmapContext signature. 18925 (dumpBitmap): New function containing Cairo-specific portions of 18926 the dumping routine. 18927 * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Added. 18928 Provide Cairo version of the BitmapContext structure so that 18929 dumping routines can work on an abstract type. 18930 (BitmapContext::createByAdoptingBitmapAndContext): 18931 (BitmapContext::~BitmapContext): 18932 (BitmapContext::cairoContext): 18933 (BitmapContext::BitmapContext): 18934 * DumpRenderTree/cg/PixelDumpSupportCG.cpp: 18935 (printPNG): CG-specific PNG handling logic. 18936 (computeMD5HashStringForBitmapContext): Revised to use generic 18937 BitmapContext signature. 18938 (dumpBitmap): New function containing CG-specific portions of 18939 the dumping routine. 18940 * DumpRenderTree/cg/PixelDumpSupportCG.h: Add new signatures. 18941 * DumpRenderTree/win/DumpRenderTree.cpp: Disable CFNetwork logic 18942 when building the non-CFNetwork version. 18943 (main): 18944 * DumpRenderTree/win/DumpRenderTree.vcproj: 18945 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 18946 (createBitmapContextFromWebView): Provide parallel Cairo implementation 18947 of CG bitmap/context setup. 18948 189492009-07-02 Eric Seidel <eric@webkit.org> 18950 18951 No review, just adding Antti as a reviewer. 18952 18953 * Scripts/modules/bugzilla.py: 18954 189552009-07-02 Antonio Gomes <antonio.gomes@openbossa.org> 18956 18957 Reviewed by Simon Hausmann. 18958 18959 https://bugs.webkit.org/show_bug.cgi?id=26896 18960 18961 [Qt] Set DRT's default fontsize to 13. 18962 18963 * DumpRenderTree/qt/DumpRenderTree.cpp: 18964 (WebCore::WebPage::WebPage): 18965 189662009-07-01 Eric Seidel <eric@webkit.org> 18967 18968 Reviewed by Adam Barth. 18969 18970 bugzilla-tool fails for SVN users 18971 https://bugs.webkit.org/show_bug.cgi?id=26914 18972 18973 To fix this I moved svn from -F - to using -m 18974 In order for -m to work I had to move us off of shell=True 18975 To move off of shell=True all call sites for run_command 18976 which take args, need to pass their args as an list instead of a string. 18977 18978 In order for the final bug update to work correctly, I had to 18979 abstract the way that we parse out revision numbers from the commit text. 18980 18981 * Scripts/bugzilla-tool: 18982 * Scripts/modules/scm.py: 18983 189842009-07-01 Eric Seidel <eric@webkit.org> 18985 18986 Reviewed by Maciej Stachowiak. 18987 18988 prepare-ChangeLog should have a --bug= argument and use it for url autofill 18989 https://bugs.webkit.org/show_bug.cgi?id=26383 18990 18991 prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org 18992 I also added a bit more template text in an effort to get better ChangeLogs 18993 from casual contributers. 18994 18995 * Scripts/prepare-ChangeLog: 18996 189972009-07-01 Eric Seidel <eric@webkit.org> 18998 18999 Reviewed by Adam Roben. 19000 19001 prepare-ChangeLog should fail when EMAIL_ADDRESS or REAL_NAME are missing: 19002 https://bugs.webkit.org/show_bug.cgi?id=26692 19003 19004 I also made prepare-ChangeLog sanity-check names and email addresses a little. 19005 Names must contain a space, and email addresses must contain '@' 19006 19007 Also "fixed" $email_address to $emailAddress. This script uses mixed variable name styles. 19008 19009 * Scripts/prepare-ChangeLog: 19010 190112009-07-01 Chris Fleizach <cfleizach@apple.com> 19012 19013 Reviewed by Beth Dakin. 19014 19015 Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions 19016 https://bugs.webkit.org/show_bug.cgi?id=26900 19017 19018 Expose the ability to get the click point of an element through accessibility. 19019 19020 * DumpRenderTree/AccessibilityUIElement.cpp: 19021 (getClickPointXCallback): 19022 (getClickPointYCallback): 19023 (AccessibilityUIElement::getJSClass): 19024 * DumpRenderTree/AccessibilityUIElement.h: 19025 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 19026 (AccessibilityUIElement::clickPointX): 19027 (AccessibilityUIElement::clickPointY): 19028 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 19029 (AccessibilityUIElement::clickPointX): 19030 (AccessibilityUIElement::clickPointY): 19031 190322009-07-01 Mark Rowe <mrowe@apple.com> 19033 19034 Reviewed by Simon Fraser. 19035 19036 Change how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices. 19037 This makes WebKit.app behave as expected when set as the default web browser on a wider 19038 range of OS versions. 19039 19040 * WebKitLauncher/WebKitNightlyEnabler.m: 19041 (poseAsWebKitApp): 19042 (enableWebKitNightlyBehaviour): 19043 190442009-07-01 Mark Rowe <mrowe@apple.com> 19045 19046 Reviewed by Simon Fraser. 19047 19048 Shuffle some code around in preparation for a change to how poseAsWebKitApp works. 19049 19050 * WebKitLauncher/WebKitNightlyEnabler.m: 19051 (systemVersion): 19052 (webKitLauncherBundle): 19053 (insideSafari4OnTigerTrampoline): 19054 190552009-06-30 Xan Lopez <xlopez@igalia.com> 19056 19057 Reviewed by Jan Alonzo. 19058 19059 https://bugs.webkit.org/show_bug.cgi?id=26877 19060 [GTK] DRT fixes to pass new plugin test 19061 19062 Silence compiler warnings. 19063 19064 Newer GCC don't like using or returning a static string where a 19065 'char*' is expected. Ideally we'd change the function signatures 19066 to return or take 'const char*' I suppose, but since we can't do 19067 that just cast the strings to 'char*'. 19068 19069 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 19070 (webkit_test_plugin_get_value): 19071 190722009-06-30 Xan Lopez <xlopez@igalia.com> 19073 19074 Reviewed by Jan Alonzo. 19075 19076 https://bugs.webkit.org/show_bug.cgi?id=26877 19077 [GTK] DRT fixes to pass new plugin test 19078 19079 Use the common pluginLog function instead of a local copy. 19080 19081 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 19082 (webkit_test_plugin_new_instance): 19083 (webkit_test_plugin_destroy_instance): 19084 (webkit_test_plugin_set_window): 19085 (webkit_test_plugin_handle_event): 19086 190872009-06-30 Xan Lopez <xlopez@igalia.com> 19088 19089 Reviewed by Jan Alonzo. 19090 19091 https://bugs.webkit.org/show_bug.cgi?id=26877 19092 [GTK] DRT fixes to pass new plugin test 19093 19094 Modify our DRT as done in bug #15457 to log logSrc as src in order 19095 to pass test plugins/netscape-plugin-map-data-to-src.html. 19096 19097 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: 19098 (webkit_test_plugin_new_instance): 19099 191002009-06-30 Adrien Nader <camaradetux@gmail.com> 19101 19102 Reviewed by Jan Alonzo. 19103 19104 [GTK] GtkLauncher depends on gtk+2-2.15 because of gtk_orientable_set_orientation() 19105 https://bugs.webkit.org/show_bug.cgi?id=26835 19106 19107 * GtkLauncher/main.c: 19108 (create_toolbar): 19109 191102009-06-30 Eric Seidel <eric@webkit.org> 19111 19112 Typo fix only, no review. 19113 19114 Fix typo causing failure during land-diff 19115 19116 * Scripts/bugzilla-tool: 19117 191182009-06-30 Simon Fraser <simon.fraser@apple.com> 19119 19120 Reviewed by Dan Bernstein. 19121 19122 Fix drawing of view background in pixel snapshots when using compositing. 19123 We still need to call -displayIfNeeded to ensure that the NSView drawing 19124 has happened. 19125 19126 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 19127 (createBitmapContextFromWebView): 19128 191292009-06-30 Simon Fraser <simon.fraser@apple.com> 19130 19131 Reviewed by Mark Rowe. 19132 19133 createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD, 19134 and thus failed on SnowLeopard. 19135 19136 * DumpRenderTree/mac/PixelDumpSupportMac.mm: 19137 (createBitmapContextFromWebView): 19138 191392009-06-30 Eric Seidel <eric@webkit.org> 19140 19141 Reviewed by Nikolas Zimmermann. 19142 19143 Make bugzilla tool print a message explaining how to get help on failure: 19144 https://bugs.webkit.org/show_bug.cgi?id=26861 19145 19146 % bugzilla-tool 19147 Usage: bugzilla-tool [options] command [command-options] [command-arguments] 19148 19149 bugzilla-tool: error: No command specified 19150 19151 Type 'bugzilla-tool --help' to see usage. 19152 19153 * Scripts/bugzilla-tool: 19154 191552009-06-30 Eric Seidel <eric@webkit.org> 19156 19157 Reviewed by Maciej Stachowiak. 19158 19159 Include a built copy of BeautifulSoup 3.1.0.1 so that 19160 bugzilla-tool users do not need to install it manually. 19161 https://bugs.webkit.org/show_bug.cgi?id=26833 19162 19163 BeautifulSoup is BSD-licensed (thus WebKit compatible) and available from: 19164 http://www.crummy.com/software/BeautifulSoup 19165 19166 * Scripts/bugzilla-tool: fixed a typo in a log message. 19167 * Scripts/modules/BeautifulSoup.py: Added. 19168 * Scripts/modules/bugzilla.py: 19169 191702009-06-30 Eric Seidel <eric@webkit.org> 19171 19172 Reviewed by Simon Hausmann. 19173 19174 Fix our create_patch handling to not 19175 hang when creating large patches. 19176 https://bugs.webkit.org/show_bug.cgi?id=26834 19177 19178 We're now using StringIO to make an in-memory buffer for the patch 19179 instead of piping from the patch command directly to the upload. 19180 The previous hang was caused by calling wait() when the process had already 19181 filed the stdout buffer. 19182 19183 * Scripts/modules/scm.py: 19184 191852009-06-29 Sam Weinig <sam@webkit.org> 19186 19187 Reviewed by Mark Rowe. 19188 19189 Remove more unused scons support. 19190 19191 * Scripts/build-jsc: 19192 * Scripts/build-webkit: 19193 * Scripts/webkitdirs.pm: 19194 191952009-06-26 Eric Seidel <eric@webkit.org> 19196 19197 Reviewed by David Levin. 19198 19199 Rename land-and-update to land-diff and make it awesome. 19200 https://bugs.webkit.org/show_bug.cgi?id=26734 19201 19202 Renamed land-and-update to land-diff 19203 Made the BUGID argument optional. 19204 Added optional support for building and testing before landing. 19205 19206 land-diff [options] [BUGID] Lands the current working directory diff and updates the bug if provided. 19207 Options: 19208 -r REVIEWER, --reviewer=REVIEWER 19209 Update ChangeLogs to say Reviewed by REVIEWER. 19210 --no-close Leave bug open after landing. 19211 --no-build Commit without building first, implies --no-test. 19212 --no-test Commit without running run-webkit-tests. 19213 19214 * Scripts/bugzilla-tool: 19215 192162009-06-28 Jan Michael Alonzo <jmalonzo@webkit.org> 19217 19218 Gtk build fix - include stdarg.h for va_start/va_end. 19219 19220 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 19221 192222009-06-28 John Abd-El-Malek <jam@chromium.org> 19223 19224 https://bugs.webkit.org/show_bug.cgi?id=15457 19225 19226 Modify NPAPI test plugin to verify that "src" paramater is added when 19227 it's missing but "data" is present. 19228 19229 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: 19230 (pluginLog): 19231 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: 19232 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: 19233 (NPP_New): 19234 (NPP_Destroy): 19235 (NPP_SetWindow): 19236 (handleEventCarbon): 19237 (handleEventCocoa): 19238 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: 19239 (NPP_New): 19240 192412009-06-27 Emilio Pozuelo Monfort <pochu27@gmail.com> 19242 19243 Reviewed by Jan Alonzo. 19244 19245 [GTK] Don't use deprecated GTK+ symbols. 19246 https://bugs.webkit.org/show_bug.cgi?id=26583 19247 19248 * GtkLauncher/main.c: 19249 (create_toolbar): 19250 192512009-06-26 Adam Barth <abarth@webkit.org> 19252 19253 Reviewed by Eric Seidel. 19254 19255 Make SVN work (again?). 19256 19257 * Scripts/modules/scm.py: 19258 192592009-06-26 Chris Fleizach <cfleizach@apple.com> 19260 19261 Reviewed by Oliver Hunt. 19262 19263 Add ability to query isEnabled 19264 19265 * DumpRenderTree/AccessibilityUIElement.cpp: 19266 (getIsEnabledCallback): 19267 (AccessibilityUIElement::getJSClass): 19268 * DumpRenderTree/AccessibilityUIElement.h: 19269 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 19270 (AccessibilityUIElement::isEnabled): 19271 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 19272 (AccessibilityUIElement::isEnabled): 19273 192742009-06-26 Brady Eidson <beidson@apple.com> 19275 19276 Reviewed by Sam Weinig 19277 19278 <rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails 19279 19280 Add a dumpResourceResponseMIMETypes() mode so the ResourceLoadDelegate will dump the mime type from 19281 the NSURLResponse. Needed for the test for this bug fix. 19282 19283 * DumpRenderTree/LayoutTestController.cpp: 19284 (LayoutTestController::LayoutTestController): 19285 (dumpResourceResponseMIMETypesCallback): 19286 (LayoutTestController::staticFunctions): 19287 * DumpRenderTree/LayoutTestController.h: 19288 (LayoutTestController::dumpResourceResponseMIMETypes): 19289 (LayoutTestController::setDumpResourceResponseMIMETypes): 19290 19291 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 19292 (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): 19293 192942009-06-26 David Kilzer <ddkilzer@apple.com> 19295 19296 Update build-dumprendertree to use buildXCodeProject() 19297 19298 Reviewed by Adam Roben. 19299 19300 * Scripts/build-dumprendertree: Updated to use 19301 buildXCodeProject() when building for isAppleMacWebKit(). This 19302 provides additional command-line switch parsing for free. Also 19303 added --clean and --help switches. Updated copyright. 19304 193052009-06-26 Eric Seidel <eric@webkit.org> 19306 19307 Reviewed by Tor Arne Vestbø. 19308 19309 Remove non-sense --update option to land-patches 19310 and make land-patches update before every patch application. 19311 This makes it slightly less likely that multi-patch landings will fail. 19312 19313 Also updated git diff command to include staged modifications. 19314 19315 * Scripts/bugzilla-tool: 19316 * Scripts/modules/scm.py: 19317 193182009-06-25 Eric Seidel <eric@webkit.org> 19319 19320 Reviewed by Jan Alonzo. 19321 19322 Fix obsolete_attachment to work when passed a comment. 19323 https://bugs.webkit.org/show_bug.cgi?id=26745 19324 19325 * Scripts/modules/bugzilla.py: 19326 193272009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org> 19328 19329 Reviewed by Mark Rowe. 19330 19331 bugzilla-tool apply-patch throws exception in Linux 19332 https://bugs.webkit.org/show_bug.cgi?id=26738 19333 19334 HEAD is case-sensitive in Linux. Convert uses of head to HEAD in 19335 the scm module. 19336 19337 * Scripts/modules/scm.py: 19338 193392009-06-25 Eric Seidel <eric@webkit.org> 19340 19341 Reviewed by Jan Alonzo. 19342 19343 bugzilla-tool post-diff needs to obsolete old patches before posting 19344 https://bugs.webkit.org/show_bug.cgi?id=26740 19345 19346 I've also added a --no-obsolete to disable this behavior. 19347 19348 I also finally updated the bug page parsing to use XML. So much less code! 19349 19350 * Scripts/bugzilla-tool: 19351 * Scripts/modules/bugzilla.py: 19352 193532009-06-25 Eric Seidel <eric@webkit.org> 19354 19355 Reviewed by Mark Rowe. 19356 19357 Call WebKitTools/Scripts scripts by their absolute paths 19358 https://bugs.webkit.org/show_bug.cgi?id=26704 19359 19360 bugzilla-tool used to use whatever build-webkit was in your path. 19361 That could end up building the wrong copy of WebKit. 19362 19363 * Scripts/bugzilla-tool: 19364 * Scripts/modules/scm.py: 19365 193662009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 19367 19368 Reviewed by Dave Levin. 19369 19370 Use unicode() instead of str when reading from bugzilla. 19371 Also add Simon Fraser as a reviewer. 19372 https://bugs.webkit.org/show_bug.cgi?id=26719 19373 19374 * Scripts/modules/bugzilla.py: 19375 193762009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 19377 19378 Reviewed by Simon Hausmann. 19379 19380 Use Q_ASSERT in Qt's DumpRenderTree instead of JSC's ASSERT 19381 19382 The WTFReportAssertionFailure function in JSC is not exported when 19383 building QtWebKit in both debug and release on Mac, so DRT fails to 19384 link. 19385 19386 We can revert this patch once the Qt port builds JSC as a separate 19387 library, and we add the proper export macros to Assertions.cpp 19388 19389 * DumpRenderTree/qt/WorkQueue.cpp: 19390 (WorkQueue::queue): 19391 (WorkQueue::dequeue): 19392 193932009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 19394 19395 Reviewed by Jan Alonzo. 19396 19397 bugzilla-tool: Add Simon Hausmann as reviewer 19398 19399 * Scripts/modules/bugzilla.py: 19400 194012009-06-24 Eric Seidel <eric@webkit.org> 19402 19403 Reviewed by Dave Levin. 19404 19405 Support local commits during apply-patches 19406 and let land-patches take multiple bug ids. 19407 https://bugs.webkit.org/show_bug.cgi?id=26703 19408 19409 I also restructured parts of land-patches into 19410 class methods and static methods in preparation 19411 for future code sharing with other commands. 19412 19413 * Scripts/bugzilla-tool: 19414 * Scripts/modules/bugzilla.py: 19415 * Scripts/modules/scm.py: 19416 194172009-06-25 Eric Seidel <eric@webkit.org> 19418 19419 Reviewed by Tor Arne Vestbø. 19420 19421 Make svn-apply work with Git too 19422 https://bugs.webkit.org/show_bug.cgi?id=26299 19423 19424 Add an --force option to svn-apply and otherwise make svn-apply 19425 exit non-zero when patch application fails. 19426 https://bugs.webkit.org/show_bug.cgi?id=26300 19427 19428 I did not update svn-unapply, because it makes no sense in a Git world. 19429 You don't roll in and out patch files. You make commits and deal with those. 19430 Git users can just git reset --hard to get the same functionality. 19431 19432 * Scripts/svn-apply: 19433 194342009-06-25 Eric Seidel <eric@webkit.org> 19435 19436 Reviewed by Tor Arne Vestbø. 19437 19438 Remove use of os.system to fix reviewers with unicode chars in their names 19439 https://bugs.webkit.org/show_bug.cgi?id=26713 19440 19441 Also change to latin1 encoding of ø to make python happy. 19442 19443 * Scripts/modules/bugzilla.py: 19444 * Scripts/modules/scm.py: 19445 194462009-06-25 Eric Seidel <eric@webkit.org> 19447 19448 Reviewed by Tor Arne Vestbø. 19449 19450 Add Adam Roben and Tor Arne Vestbø to the reviewers list. 19451 19452 * Scripts/modules/bugzilla.py: 19453 194542009-06-24 Chris Fleizach <cfleizach@apple.com> 19455 19456 Windows build fix. 19457 19458 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 19459 (AccessibilityUIElement::language): 19460 194612009-06-24 Chris Fleizach <cfleizach@apple.com> 19462 19463 Reviewed by Oliver Hunt. 19464 19465 Bug 26668: AX: need a way to retrieve the language for an element 19466 Support ability to retrieve AXLanguage for testing 19467 19468 * DumpRenderTree/AccessibilityUIElement.cpp: 19469 (getLanguageCallback): 19470 (AccessibilityUIElement::getJSClass): 19471 * DumpRenderTree/AccessibilityUIElement.h: 19472 * DumpRenderTree/mac/AccessibilityUIElementMac.mm: 19473 (AccessibilityUIElement::language): 19474 194752009-06-24 Eric Seidel <eric@webkit.org> 19476 19477 Reviewed by Maciej Stachowiak. 19478 19479 Spell Maciej's name right and add Brady Eidson. 19480 19481 * Scripts/modules/bugzilla.py: 19482 194832009-06-23 Eric Seidel <eric@webkit.org> 19484 19485 Reviewed by Dave Levin. 19486 19487 Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run 19488 https://bugs.webkit.org/show_bug.cgi?id=26669 19489 19490 * Scripts/bugzilla-tool: 19491 * Scripts/modules/scm.py: 19492 194932009-06-23 Takeshi Yoshino <tyoshino@google.com> 19494 19495 Reviewed by Mark Rowe. 19496 19497 Bug 26537: Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists 19498 https://bugs.webkit.org/show_bug.cgi?id=26537 19499 19500 Let determineBaseProductDir subroutine remove 19501 ~/Library/Preferences/xcodebuild.plist. It can prevent xcodebuild from 19502 respecting global settings such as a custom build products directory 19503 (<rdar://problem/5585899>). 19504 19505 * Scripts/webkitdirs.pm: 19506 195072009-06-23 Eric Seidel <eric@webkit.org> 19508 19509 Reviewed by Dave Levin. 19510 19511 Make SCM.run_command smarter, and make all previous 19512 os.system and subprocess.popen use SCM.run_command instead. 19513 https://bugs.webkit.org/show_bug.cgi?id=26666 19514 19515 This makes it easier to handle errors in a standard way throughout all the code. 19516 Since this new code raises by default when the exit_code != 0, 19517 we should prevent future problems of bugzilla-tool continuing after 19518 a git or svn command failed. 19519 19520 * Scripts/modules/scm.py: 19521 195222009-06-23 Joe Mason <joe.mason@torchmobile.com> 19523 19524 Reviewed by Adam Treat. 19525 19526 https://bugs.webkit.org/show_bug.cgi?id=26664 19527 * Scripts/prepare-ChangeLog: Added --git-index mode to list only the 19528 changes which are already staged in the index. Useful to create an 19529 entry for what you're about to commit while ignoring unstaged changes. 19530 195312009-06-23 Anders Carlsson <andersca@apple.com> 19532 19533 Reviewed by Darin Adler. 19534 19535 Update for WebKit changes. 19536 19537 * DumpRenderTree/win/UIDelegate.h: 19538 (UIDelegate::willPerformDragSourceAction): 19539 195402009-06-23 Eric Seidel <eric@webkit.org> 19541 19542 Reviewed by Mark Rowe. 19543 19544 * Scripts/modules/scm.py: Fix commit_with_message to return the commit output. 19545 195462009-06-23 Eric Seidel <eric@webkit.org> 19547 19548 Reviewed by Mark Rowe. 19549 19550 * Scripts/modules/scm.py: Fix error seen when commiting r44979. 19551 195522009-06-18 Eric Seidel <eric@webkit.org> 19553 19554 Reviewed by Dave Levin. 19555 19556 WebKit needs a script to interact with bugzilla and automate 19557 parts of the patch posting and commit processes. 19558 https://bugs.webkit.org/show_bug.cgi?id=26283 19559 19560 This is really a first-draft tool. 19561 It's to the point where it's useful to more people than just me now though. 19562 Git support works. SVN support is written, but mostly untested. 19563 19564 This tool requires BeautifulSoup and mechanize python modules to run: 19565 sudo easy_install BeautifulSoup 19566 sudo easy_install mechanize 19567 19568 More important than the tool itself are the Bugzilla, Git and SVN class abstractions 19569 which I hope will allow easy writing of future tools. 19570 19571 The tool currently implements 10 commands, described below. 19572 19573 Helpers for scripting dealing with the commit queue: 19574 bugs-to-commit Bugs in the commit queue 19575 patches-to-commit Patches attached to bugs in the commit queue 19576 19577 Dealing with bugzilla: 19578 reviewed-patches BUGID r+'d patches on a bug 19579 apply-patches BUGID Applies all patches on a bug to the local working directory without committing. 19580 land-and-update BUGID Lands the current working directory diff and updates the bug. 19581 land-patches [options] BUGID Lands all patches on a bug optionally testing them first 19582 obsolete-attachments BUGID Marks all attachments on a bug as obsolete. 19583 commit-message Prints a commit message suitable for the uncommitted changes. 19584 19585 These effectively replace git-send-bugzilla: 19586 post-diff BUGID Attaches the current working directory diff to a bug as a patch file. 19587 post-commits BUGID COMMITISH Attaches a range of local commits to a bug as patch files. 19588 19589 post-diff works for SVN and Git, post-commits only works for SCMs with local-commit support (like Git) 19590 19591 land-* commands in a Git environment only work with simple patches due to svn-apply bugs: 19592 https://bugs.webkit.org/show_bug.cgi?id=26299 19593 https://bugs.webkit.org/show_bug.cgi?id=26300 19594 19595 This script follows python style (similar to how for Obj-C we follow AppKit style) 19596 http://www.python.org/doc/essays/styleguide.html 19597 The Python community has a strong style culture and the WebKit style guide is silent re: Python. 19598 19599 I've filed a bug to update the WebKit style guide to mention python: 19600 https://bugs.webkit.org/show_bug.cgi?id=26524 19601 19602 * Scripts/bugzilla-tool: Added. 19603 196042009-06-22 Steve Falkenburg <sfalken@apple.com> 19605 19606 Remove errant line of code mistakenly checked in. 19607 19608 * DumpRenderTree/win/DumpRenderTree.cpp: 19609 (main): 19610 196112009-06-22 Steve Falkenburg <sfalken@apple.com> 19612 19613 Pass correct value to setShouldPaintNativeControls. 19614 19615 Rubber stamped by Mark Rowe. 19616 19617 * DumpRenderTree/win/DumpRenderTree.cpp: 19618 (main): 19619 196202009-06-22 Steve Falkenburg <sfalken@apple.com> 19621 19622 Fix last DumpRenderTree change to correctly set preferences flag without crashing. 19623 19624 Reviewed by Mark Rowe. 19625 19626 * DumpRenderTree/win/DumpRenderTree.cpp: 19627 (main): 19628 196292009-06-21 Steve Falkenburg <sfalken@apple.com> 19630 19631 Set up global native controls flag before creating the first WebView. 19632 19633 Reviewed by Darin Adler. 19634 19635 * DumpRenderTree/win/DumpRenderTree.cpp: 19636 (main): 19637 196382009-06-21 Mark Rowe <mrowe@apple.com> 19639 19640 Reviewed by Sam Weinig. 19641 19642 Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates). 19643 19644 * WebKitLauncher/WebKitNightlyEnablerSparkle.m: 19645 (userAgentStringForSparkle): 19646 (initializeSparkle): 19647 196482009-06-21 Mark Rowe <mrowe@apple.com> 19649 19650 Reviewed by Sam Weinig. 19651 19652 Add a hook to the WebKit launcher application to allow a link on the nightly build start page to 19653 trigger an update via the built-in software update mechanism. 19654 19655 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: 19656 * WebKitLauncher/WebKitLauncherURLProtocol.h: Added. 19657 * WebKitLauncher/WebKitLauncherURLProtocol.m: Added. 19658 (+[WebKitLauncherURLProtocol load]): 19659 (+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains. 19660 (+[WebKitLauncherURLProtocol canonicalRequestForRequest:]): 19661 (-[WebKitLauncherURLProtocol startLoading]): 19662 (-[WebKitLauncherURLProtocol stopLoading]): 19663 (-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically 19664 determine whether the x-webkit-launcher is available and working. 19665 (-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread. 19666 (-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error. 19667 196682009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org> 19669 19670 Reviewed by Gustavo Noronha and Xan Lopez. 19671 19672 [Gtk] Implement DRT XSS auditor support 19673 https://bugs.webkit.org/show_bug.cgi?id=26571 19674 19675 * DumpRenderTree/gtk/DumpRenderTree.cpp: 19676 (resetWebViewToConsistentStateBeforeTesting): 19677 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 19678 (LayoutTestController::setXSSAuditorEnabled): 19679 196802009-06-19 Darin Adler <darin@apple.com> 19681 19682 * Scripts/do-webcore-rename: More renaming ideas. 19683 196842009-06-15 Andre Pedralho <andre.pedralho@openbossa.org> 19685 19686 Reviewed by Tor Arne Vestbø. 19687 19688 Only pass --makeargs along if an argument is given. 19689 19690 * Scripts/build-webkit: 19691 196922009-06-19 Adam Barth <abarth@webkit.org> 19693 19694 Unreviewed attempt to fix Windows build. 19695 19696 * DumpRenderTree/win/DumpRenderTree.cpp: 19697 (resetWebViewToConsistentStateBeforeTesting): 19698 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 19699 (LayoutTestController::setXSSAuditorEnabled): 19700 197012009-06-18 Adam Barth <abarth@webkit.org> 19702 19703 Reviewed by Sam Weinig. 19704 19705 https://bugs.webkit.org/show_bug.cgi?id=26199 19706 19707 Add support for testing the XSSAuditor. 19708 19709 * DumpRenderTree/LayoutTestController.cpp: 19710 (setXSSAuditorEnabledCallback): 19711 (LayoutTestController::staticFunctions): 19712 * DumpRenderTree/LayoutTestController.h: 19713 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 19714 (LayoutTestController::setXSSAuditorEnabled): 19715 * DumpRenderTree/mac/DumpRenderTree.mm: 19716 (resetWebViewToConsistentStateBeforeTesting): 19717 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 19718 (LayoutTestController::setXSSAuditorEnabled): 19719 * DumpRenderTree/win/DumpRenderTree.cpp: 19720 (resetWebViewToConsistentStateBeforeTesting): 19721 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 19722 (LayoutTestController::setXSSAuditorEnabled): 19723 (LayoutTestController::setPopupBlockingEnabled): 19724 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 19725 (LayoutTestController::setXSSAuditorEnabled): 19726 197272009-06-18 Darin Adler <darin@apple.com> 19728 19729 Rubber stamped by Mark Rowe. 19730 19731 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: 19732 (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression 19733 tests. The close method can be called on a window that's already closed 19734 so we can't assert here. 19735 197362009-06-17 Steve Falkenburg <sfalken@apple.com> 19737 19738 Updated for consolidated WebKit COM interfaces. 19739 19740 Reviewed by Adam Roben. 19741 19742 * DumpRenderTree/win/FrameLoadDelegate.cpp: 19743 * DumpRenderTree/win/FrameLoadDelegate.h: 19744 * DumpRenderTree/win/UIDelegate.cpp: 19745 * DumpRenderTree/win/UIDelegate.h: 19746 * WinLauncher/WinLauncher.h: 19747 197482009-06-16 Adam Barth <abarth@webkit.org> 19749 19750 Reviewed by Darin Adler. 19751 19752 https://bugs.webkit.org/show_bug.cgi?id=26437 19753 19754 Make the commit-log-editor match the ambient line endings in commit 19755 messages. 19756 19757 * Scripts/commit-log-editor: 19758 197592009-06-16 Xan Lopez <xlopez@igalia.com> 19760 19761 Reviewed by Gustavo Noronha. 19762 19763 Update GtkLauncher to recent API changes in the progress property, 19764 which now goes from 0.0 to 1.0. 19765 19766 * GtkLauncher/main.c: 19767 197682009-06-16 Adam Barth <abarth@webkit.org> 19769 19770 Reviewed by Darin Adler. 19771 19772 https://bugs.webkit.org/show_bug.cgi?id=26000 19773 19774 Teach prepare-ChangeLog to match the line ends that are already present 19775 in ChangeLog files. This helps folks whose use cygwin perl with CR LF 19776 line endings on Windows. 19777 19778 Also, teach prepare-ChangeLog to normalize backslashes in paths. This 19779 helps folks who use Windows SVN prepare correct ChangeLogs. 19780 19781 * Scripts/prepare-ChangeLog: 19782 19783== Rolled over to ChangeLog-2009-06-16 == 19784