12011-04-19 Igor Oliveira <igor.oliveira@openbossa.org> 2 3 Reviewed by Andreas Kling. 4 5 [Qt] X11: Text selection is causing oncopy event to be called 6 https://bugs.webkit.org/show_bug.cgi?id=58656 7 8 Always when text is selected the oncopy event is fired, this behavior does 9 not exist in Firefox or Chrome. Now, when selecting a text, QtWebKit 10 is making multi part-copies (with rich text metadata), the multi-part 11 data can be obtained by data transfer items interface when supported by QtWebKit. 12 Also, copies to the clipboard of a selected image, is not supported by Chrome and 13 Firefox and was removed from QtWebKit. 14 15 16 * Api/qwebpage.cpp: 17 (QWebPagePrivate::handleClipboard): 18 192011-04-18 Csaba Osztrogonác <ossy@webkit.org> 20 21 [Qt][WK2] Unreviewed buildfix after r84174. 22 23 * QtWebKit.pro: Missing includepath added. 24 252011-04-18 Yi Shen <yi.4.shen@nokia.com> 26 27 Reviewed by Laszlo Gombos. 28 29 [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::inputFieldFocus 30 https://bugs.webkit.org/show_bug.cgi?id=57546 31 32 Disable the fullscreen VKB when testing inputFieldFocus(). 33 34 * tests/qwebframe/tst_qwebframe.cpp: 35 362011-04-18 Andreas Kling <kling@webkit.org> 37 38 [Qt] DRT: Unreviewed test fix after r84168. 39 40 Dump the original request KURL for blocked access attempts. 41 Turns out converting it to a QUrl lower-cases the hostname. 42 43 * WebCoreSupport/FrameLoaderClientQt.cpp: 44 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): 45 462011-04-18 Yi Shen <yi.4.shen@nokia.com> 47 48 Reviewed by Laszlo Gombos. 49 50 [Qt] Fix Api tests for QWebPage on Symbian 51 https://bugs.webkit.org/show_bug.cgi?id=56924 52 53 Ignores the style attribute that selectedHtml() returns. 54 55 * tests/qwebpage/tst_qwebpage.cpp: 56 (tst_QWebPage::cursorMovements): 57 (tst_QWebPage::textSelection): 58 (tst_QWebPage::findText): 59 602011-04-18 Andreas Kling <kling@webkit.org> 61 62 Reviewed by Adam Barth. 63 64 REGRESSION (r84010): [Qt] DRT: Unbreak redirection of http:/ URLs. 65 https://bugs.webkit.org/show_bug.cgi?id=58779 66 67 KURL::host() doesn't return the host part of [broken] http:/ URLs, so use 68 QUrl instead to match the behavior of other ports. 69 70 * WebCoreSupport/FrameLoaderClientQt.cpp: 71 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): 72 732011-04-18 Dominic Cooney <dominicc@chromium.org> 74 75 Reviewed by Andreas Kling. 76 77 Add layoutTestController.shadowRoot to Qt DRT. 78 https://bugs.webkit.org/show_bug.cgi?id=58759 79 80 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 81 (DumpRenderTreeSupportQt::shadowRoot): Added. 82 * WebCoreSupport/DumpRenderTreeSupportQt.h: 83 842011-04-16 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> 85 86 Reviewed by Andreas Kling. 87 88 [Qt] Autotest got missed in the handover of the QML WebView element 89 https://bugs.webkit.org/show_bug.cgi?id=41449 90 91 Importing WebView QML element test cases from Qt repository. I did some 92 style modifications and simplifications in the original code but hopefully 93 without changing the behavior. 94 95 Tests that do not pass are marked with QEXPECT_FAIL or QSKIP. The two major 96 issues currently are: 97 98 - pixelCache() test checked the usage of pixel cache by using a subclass of 99 QDeclarativeWebView. We can't do that right now because this class is not 100 exported. We may need a Q_AUTOTEST_EXPORT thing for QtWebKit if we want 101 this kind of test. 102 - elementAtArea() test uses a function that is not exported. But in this case 103 I think we should test it's user, the public method "heuristicZoom". 104 105 * tests/qdeclarativewebview/resources/basic.html: Added. 106 * tests/qdeclarativewebview/resources/basic.png: Added. 107 * tests/qdeclarativewebview/resources/basic.qml: Added. 108 * tests/qdeclarativewebview/resources/elements.html: Added. 109 * tests/qdeclarativewebview/resources/elements.qml: Added. 110 * tests/qdeclarativewebview/resources/forward.html: Added. 111 * tests/qdeclarativewebview/resources/forward.png: Added. 112 * tests/qdeclarativewebview/resources/javaScript.html: Added. 113 * tests/qdeclarativewebview/resources/javaScript.qml: Added. 114 * tests/qdeclarativewebview/resources/loadError.qml: Added. 115 * tests/qdeclarativewebview/resources/newwindows.html: Added. 116 * tests/qdeclarativewebview/resources/newwindows.qml: Added. 117 * tests/qdeclarativewebview/resources/propertychanges.qml: Added. 118 * tests/qdeclarativewebview/resources/sethtml.qml: Added. 119 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: 120 (tst_QDeclarativeWebView::tmpDir): 121 (strippedHtml): 122 (fileContents): 123 (removeRecursive): 124 (tst_QDeclarativeWebView::cleanupTestCase): 125 (tst_QDeclarativeWebView::basicProperties): 126 (tst_QDeclarativeWebView::elementAreaAt): 127 (tst_QDeclarativeWebView::historyNav): 128 (callEvaluateJavaScript): 129 (tst_QDeclarativeWebView::javaScript): 130 (tst_QDeclarativeWebView::loadError): 131 (tst_QDeclarativeWebView::multipleWindows): 132 (tst_QDeclarativeWebView::newWindowComponent): 133 (tst_QDeclarativeWebView::newWindowParent): 134 (tst_QDeclarativeWebView::pressGrabTime): 135 (tst_QDeclarativeWebView::renderingEnabled): 136 (tst_QDeclarativeWebView::setHtml): 137 (tst_QDeclarativeWebView::settings): 138 (tst_QDeclarativeWebView::checkNoErrors): 139 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc: 140 1412011-04-08 Luiz Agostini <luiz.agostini@openbossa.org> 142 143 Reviewed by Kenneth Rohde Christiansen. 144 145 [Qt] QWebPage MIME type handling inconsistency with other web browsers 146 https://bugs.webkit.org/show_bug.cgi?id=46968 147 148 Implementing mime type sniffing based on 149 http://tools.ietf.org/html/draft-abarth-mime-sniff-06. 150 151 * WebCoreSupport/FrameLoaderClientQt.cpp: 152 (WebCore::FrameLoaderClientQt::createNetworkingContext): 153 * WebCoreSupport/FrameNetworkingContextQt.cpp: 154 (WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt): 155 (WebCore::FrameNetworkingContextQt::create): 156 (WebCore::FrameNetworkingContextQt::MIMESniffingEnabled): 157 * WebCoreSupport/FrameNetworkingContextQt.h: 158 * tests/MIMESniffing/MIMESniffing.pro: Added. 159 * tests/MIMESniffing/TestData.h: Added. 160 * tests/MIMESniffing/resources.qrc: Added. 161 * tests/MIMESniffing/resources/application_atom+xml: Added. 162 * tests/MIMESniffing/resources/application_ogg: Added. 163 * tests/MIMESniffing/resources/application_pdf: Added. 164 * tests/MIMESniffing/resources/application_postscript: Added. 165 * tests/MIMESniffing/resources/application_rdf+xml: Added. 166 * tests/MIMESniffing/resources/application_rss+xml: Added. 167 * tests/MIMESniffing/resources/application_x-gzip: Added. 168 * tests/MIMESniffing/resources/application_x-rar-compressed: Added. 169 * tests/MIMESniffing/resources/application_zip: Added. 170 * tests/MIMESniffing/resources/audio_x-wave: Added. 171 * tests/MIMESniffing/resources/image_bmp: Added. 172 * tests/MIMESniffing/resources/image_gif: Added. 173 * tests/MIMESniffing/resources/image_jpeg: Added. 174 * tests/MIMESniffing/resources/image_png: Added. 175 * tests/MIMESniffing/resources/image_vnd.microsoft.icon: Added. 176 * tests/MIMESniffing/resources/image_webp: Added. 177 * tests/MIMESniffing/resources/text_html: Added. 178 * tests/MIMESniffing/resources/text_xml: Added. 179 * tests/MIMESniffing/resources/video_webm: Added. 180 * tests/MIMESniffing/tst_MIMESniffing.cpp: Added. 181 (tst_MIMESniffing::tst_MIMESniffing): 182 (errorText): 183 (tst_MIMESniffing::testCase1): 184 * tests/tests.pro: 185 1862011-04-15 Andreas Kling <kling@webkit.org> 187 188 Reviewed by Antonio Gomes. 189 190 [Qt] DRT: Block access to external URLs. 191 192 Implement the "Blocked access to external URL" behavior for Qt's DRT, 193 based on what other ports are doing. 194 195 Fixes <http://webkit.org/b/57306> and <http://webkit.org/b/58523>. 196 197 * WebCoreSupport/FrameLoaderClientQt.cpp: 198 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): 199 2002011-01-26 Ragner Magalhaes <ragner.magalhaes@openbossa.org> 201 202 Reviewed by Antonio Gomes. 203 204 [Qt] Web Inspector does not highlight elements 205 https://bugs.webkit.org/show_bug.cgi?id=35125 206 207 Adjust Web inspector to highlight elements on the page when the mouse 208 hovers the element on DOM inspector. 209 210 * Api/qwebframe.cpp: 211 (QWebFramePrivate::renderRelativeCoords): 212 * WebCoreSupport/InspectorClientQt.cpp: 213 (WebCore::InspectorClientQt::highlight): 214 (WebCore::InspectorClientQt::hideHighlight): 215 2162011-04-12 George Guo <George.Guo@nokia.com> 217 218 Reviewed by Laszlo Gombos. 219 220 [Qt] On Symbian got "Update Error" when installing QtWebkit.sis 221 http://bugs.webkit.org/show_bug.cgi?id=58141 222 223 If QtWebKit is already in Symbian ROM, we need package to be 224 both SA and RU type 225 226 * QtWebKit.pro: 227 2282011-04-12 Alexis Menard <alexis.menard@openbossa.org> 229 230 Reviewed by Andreas Kling. 231 232 [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file. 233 https://bugs.webkit.org/show_bug.cgi?id=58251 234 235 Fix an issue with slot names after http://trac.webkit.org/changeset/83512. 236 237 * Api/qwebframe.cpp: 238 (QWebFrame::QWebFrame): 239 2402011-04-11 Alexis Menard <alexis.menard@openbossa.org> 241 242 Reviewed by Benjamin Poulain. 243 244 [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file. 245 https://bugs.webkit.org/show_bug.cgi?id=58251 246 247 Qt coding conventions states that private slots should be located in private implementation of 248 the class. This allows us to rename/delete the slots in the future without breaking anything. 249 250 No new tests added, just a simple refactoring. 251 252 * Api/qwebframe.cpp: 253 (QWebFramePrivate::_q_orientationChanged): 254 * Api/qwebframe.h: 255 * Api/qwebframe_p.h: 256 2572011-04-11 Alexis Menard <alexis.menard@openbossa.org> 258 259 Reviewed by Kenneth Rohde Christiansen. 260 261 [Qt] Sub-Frame content is not updated when scrolling in certain circumstances 262 https://bugs.webkit.org/show_bug.cgi?id=50373 263 264 Make sure that we invalidate the backing store when using TILED_BACKING_STORE 265 and the page contains sub frames. This bug appears only when frame flattening is 266 disabled and scrollable subframes. 267 268 Original patch from Thomas Thrainer. 269 270 * WebCoreSupport/ChromeClientQt.cpp: 271 (WebCore::ChromeClientQt::invalidateWindow): 272 2732011-04-11 Benjamin Poulain <benjamin.poulain@nokia.com> 274 275 Reviewed by Andreas Kling. 276 277 [Qt] HTML5 Drag and Drop demos not working 278 https://bugs.webkit.org/show_bug.cgi?id=56486 279 280 Handling the drop with JavaScript was not working with Qt because if the action is ignored 281 in response to DragEnter, no further events are sent to the view. 282 283 Drag and drop is defined and used differently by webpages. The drag move events are determining 284 what action should take place. To adopt this behavior for Qt, we always accept drag enter events 285 on the widget. 286 287 * Api/qwebpage.cpp: 288 (QWebPagePrivate::dragEnterEvent): 289 2902011-04-11 Andras Becsi <abecsi@webkit.org> 291 292 Reviewed by Andreas Kling. 293 294 [Qt] REGRESSION(83122): tst_QWebElement::style() fails 295 https://bugs.webkit.org/show_bug.cgi?id=58032 296 297 According to the documentation of QWebElement the styleProperty method should 298 not respect style inheritance and other CSS rules for the InlineStyle enum. 299 300 r83122 fixed this behaviour. 301 302 * tests/qwebelement/tst_qwebelement.cpp: 303 (tst_QWebElement::style): Fix the expected color for QWebElement::InlineStyle. 304 3052011-04-11 Andreas Kling <andreas.kling@nokia.com> 306 307 Build fix after r83436. 308 309 * WebCoreSupport/FrameLoaderClientQt.cpp: 310 (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): 311 3122011-04-11 Andreas Kling <andreas.kling@nokia.com> 313 314 Reviewed by Benjamin Poulain. 315 316 [Qt] dumpResourceResponseMIMETypes shouldn't strip URL query string. 317 318 * WebCoreSupport/FrameLoaderClientQt.cpp: 319 (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): Use KURL::lastPathComponent() 320 for the dumpResourceResponseMIMETypes display string instead of QFileInfo::fileName(). 321 This is in line with the Mac port. 322 3232011-04-08 Sheriff Bot <webkit.review.bot@gmail.com> 324 325 Unreviewed, rolling out r83295. 326 http://trac.webkit.org/changeset/83295 327 https://bugs.webkit.org/show_bug.cgi?id=58144 328 329 Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit). 330 331 * WebCoreSupport/EditorClientQt.cpp: 332 (WebCore::EditorClientQt::handleInputMethodKeydown): 333 3342011-04-08 Yi Shen <yi.4.shen@nokia.com> 335 336 Reviewed by Antonio Gomes. 337 338 [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails 339 https://bugs.webkit.org/show_bug.cgi?id=57472 340 341 Avoid to insert new line for both keydown event & keypress event. 342 343 * WebCoreSupport/EditorClientQt.cpp: 344 (WebCore::EditorClientQt::handleInputMethodKeydown): 345 3462011-04-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> 347 348 Reviewed by Benjamin Poulain. 349 350 [Qt] QWebFrame::setUrl works only from second time if url fragment is present 351 https://bugs.webkit.org/show_bug.cgi?id=32723 352 353 When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(), 354 use an invalid URL (the begin() without arguments). Clearing the document 355 with the same URL was causing problems when we had a fragment because it assume that 356 only scrolling was enough and did not loaded the document again. 357 358 When setUrl() is called but fails, url() is expected to return the requested value. The 359 begin(url) guaranteed that before. This patch adds a member to track the URL, which is 360 updated when the URL changes and also when setUrl() is called. 361 362 KURL was used for the member so that when setUrl() is called, and then url() is checked 363 before the page gets loaded, we perform the same conversion that will be performed by a 364 successful load, e.g. add trailing '/' to an address. This behavior is checked by 365 tst_QWebFrame::requestedUrl() test. 366 367 For the record: the second QWebPage::setUrl() worked because the load was considered a 368 FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was 369 needed. See FrameLoader::shouldScrollToAnchor() for details on this classification. 370 371 * Api/qwebframe.cpp: 372 (QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal. 373 (clearCoreFrame): 374 (isCoreFrameClear): 375 (QWebFrame::setUrl): 376 (QWebFrame::url): 377 (QWebFrame::baseUrl): look in the document for the baseURL since its contents can change 378 the baseURL, e.g. by using the <base> tag. 379 * Api/qwebframe_p.h: 380 381 * WebCoreSupport/FrameLoaderClientQt.cpp: 382 (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage): 383 (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad): 384 385 * tests/qwebframe/tst_qwebframe.cpp: 386 (tst_QWebFrame::setUrlWithFragment): unskip test. 387 3882011-04-07 Alexis Menard <alexis.menard@openbossa.org> 389 390 Reviewed by Kenneth Rohde Christiansen. 391 392 Build fix when using Phonon as a backend for the multimedia support. 393 394 * WebCoreSupport/ChromeClientQt.cpp: 395 (WebCore::ChromeClientQt::ChromeClientQt): 396 (WebCore::ChromeClientQt::~ChromeClientQt): 397 * WebCoreSupport/ChromeClientQt.h: 398 3992011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com> 400 401 Reviewed by Kenneth Rohde Christiansen. 402 403 [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests 404 https://bugs.webkit.org/show_bug.cgi?id=56086 405 406 Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests() 407 from the LayoutTestController. 408 409 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 410 (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests): 411 * WebCoreSupport/DumpRenderTreeSupportQt.h: 412 4132011-04-06 Anders Bakken <agbakken@gmail.com> 414 415 Reviewed by Kenneth Rohde Christiansen. 416 417 [Qt] FrameLoaderClientQt.cpp has coding-style errors 418 https://bugs.webkit.org/show_bug.cgi?id=40254 419 420 * WebCoreSupport/FrameLoaderClientQt.cpp: 421 (drtDescriptionSuitableForTestResult): 422 (WebCore::FrameLoaderClientQt::hasWebView): 423 (WebCore::FrameLoaderClientQt::setCopiesOnScroll): 424 (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents): 425 (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): 426 (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons): 427 (WebCore::FrameLoaderClientQt::cancelPolicyCheck): 428 (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): 429 (WebCore::FrameLoaderClientQt::postProgressStartedNotification): 430 (WebCore::FrameLoaderClientQt::postProgressFinishedNotification): 431 (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady): 432 (WebCore::FrameLoaderClientQt::willChangeTitle): 433 (WebCore::FrameLoaderClientQt::didChangeTitle): 434 (WebCore::FrameLoaderClientQt::finishedLoading): 435 (WebCore::FrameLoaderClientQt::frameLoadCompleted): 436 (WebCore::FrameLoaderClientQt::provisionalLoadStarted): 437 (WebCore::FrameLoaderClientQt::didFinishLoad): 438 (WebCore::FrameLoaderClientQt::setTitle): 439 (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon): 440 (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld): 441 (WebCore::FrameLoaderClientQt::updateGlobalHistory): 442 (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem): 443 (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): 444 (WebCore::FrameLoaderClientQt::committedLoad): 445 (WebCore::FrameLoaderClientQt::download): 446 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): 447 (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage): 448 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse): 449 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): 450 (WebCore::FrameLoaderClientQt::createFrame): 451 (WebCore::FrameLoaderClientQt::objectContentType): 452 (WebCore::FrameLoaderClientQt::createPlugin): 453 4542011-04-06 Alexis Menard <alexis.menard@openbossa.org> 455 456 Reviewed by Andreas Kling. 457 458 [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA). 459 https://bugs.webkit.org/show_bug.cgi?id=57974 460 461 We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA). 462 463 No new tests needed, just a config flag rename. 464 465 * Api/qwebkitplatformplugin.h: 466 * WebCoreSupport/ChromeClientQt.cpp: 467 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 468 (DumpRenderTreeSupportQt::mediaContentUrlByElementId): 469 * WebCoreSupport/FullScreenVideoQt.cpp: 470 (WebCore::FullScreenVideoQt::FullScreenVideoQt): 471 (WebCore::FullScreenVideoQt::~FullScreenVideoQt): 472 (WebCore::FullScreenVideoQt::enterFullScreenForNode): 473 (WebCore::FullScreenVideoQt::exitFullScreenForNode): 474 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback): 475 (WebCore::FullScreenVideoQt::isValid): 476 * WebCoreSupport/FullScreenVideoQt.h: 477 * WebCoreSupport/QtPlatformPlugin.cpp: 478 * WebCoreSupport/QtPlatformPlugin.h: 479 * examples/platformplugin/WebPlugin.cpp: 480 (WebPlugin::supportsExtension): 481 (WebPlugin::createExtension): 482 * examples/platformplugin/WebPlugin.h: 483 * examples/platformplugin/platformplugin.pro: 484 * examples/platformplugin/qwebkitplatformplugin.h: 485 * tests/qwebpage/tst_qwebpage.cpp: 486 (tst_QWebPage::loadHtml5Video): 487 * tests/tests.pri: 488 4892011-04-06 Alexis Menard <alexis.menard@openbossa.org> 490 491 Reviewed by Andreas Kling. 492 493 [Qt] Implement fullscreen playback for the GStreamer backend. 494 https://bugs.webkit.org/show_bug.cgi?id=56826 495 496 Implement support for fullscreen playback when building the 497 Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1). 498 The implementation is done in FullScreenVideoQt alongside with 499 the Qt Multimedia support. 500 501 No new tests because layout tests cover it. They are not yet activated 502 but will be any time soon. 503 504 * QtWebKit.pro: 505 * WebCoreSupport/ChromeClientQt.cpp: 506 (WebCore::ChromeClientQt::ChromeClientQt): 507 (WebCore::ChromeClientQt::~ChromeClientQt): 508 (WebCore::ChromeClientQt::enterFullscreenForNode): 509 (WebCore::ChromeClientQt::exitFullscreenForNode): 510 * WebCoreSupport/ChromeClientQt.h: 511 * WebCoreSupport/FullScreenVideoQt.cpp: 512 (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler): 513 (WebCore::GStreamerFullScreenVideoHandler::setVideoElement): 514 (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen): 515 (WebCore::GStreamerFullScreenVideoHandler::windowClosed): 516 (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen): 517 (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler): 518 (WebCore::FullScreenVideoQt::FullScreenVideoQt): 519 (WebCore::FullScreenVideoQt::~FullScreenVideoQt): 520 (WebCore::FullScreenVideoQt::enterFullScreenForNode): 521 (WebCore::FullScreenVideoQt::exitFullScreenForNode): 522 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback): 523 (WebCore::FullScreenVideoQt::isValid): 524 * WebCoreSupport/FullScreenVideoQt.h: 525 (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler): 526 5272011-04-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> 528 529 Reviewed by Kenneth Rohde Christiansen. 530 531 [Qt] Improve tests for QWebFrame::url() and related methods 532 https://bugs.webkit.org/show_bug.cgi?id=57865 533 534 * tests/qwebframe/tst_qwebframe.cpp: 535 (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test. 536 (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl() 537 that fails and a load() that fails (for a different URL). 538 539 (tst_QWebFrame::setUrlWithFragment_data): 540 (tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing 541 the URL in the frame before the test starts. 542 543 (tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with 544 the same URL as argument. 545 546 (extractBaseUrl): 547 (tst_QWebFrame::setUrlThenLoads_data): 548 (tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a 549 sequence of set and loads. Those tests are interesting because the properties 550 react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl() 551 is used or after the load() is committed and baseUrl() is similar to url() but also depends 552 on the contents of the page when it loads. 553 5542011-04-04 MORITA Hajime <morrita@google.com> 555 556 Reviewed by Ryosuke Niwa. 557 558 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult 559 https://bugs.webkit.org/show_bug.cgi?id=56085 560 561 * WebCoreSupport/EditorClientQt.h: 562 (WebCore::EditorClientQt::requestCheckingOfString): 563 5642011-04-04 Chang Shu <cshu@webkit.org> 565 566 Reviewed by Ryosuke Niwa. 567 568 setContentEditable with true/false/inherit string is not working properly 569 https://bugs.webkit.org/show_bug.cgi?id=52058 570 571 Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable 572 as rendererIsEditable is for WebCore internal use. 573 574 * WebCoreSupport/EditorClientQt.cpp: 575 (WebCore::EditorClientQt::handleKeyboardEvent): 576 5772011-04-01 Carol Szabo <carol.szabo@nokia.com> 578 579 Reviewed by Benjamin Poulain. 580 581 Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into 582 Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords. 583 584 Tiled painting still causes synchronous layout when 585 accelerated compositing and texture mapper are enabled 586 https://bugs.webkit.org/show_bug.cgi?id=56929 587 588 * Api/qwebframe.cpp: 589 (QWebFramePrivate::renderFromTiledBackingStore): 590 (QWebFramePrivate::renderRelativeCoords): 591 (QWebFramePrivate::renderFrameWidgets): 592 * Api/qwebframe_p.h: 593 5942011-04-01 Nancy Piedra <nancy.piedra@nokia.com> 595 596 Reviewed by Benjamin Poulain. 597 598 [Qt] DragClientQt.h has coding-style errors 599 https://bugs.webkit.org/show_bug.cgi?id=40425 600 601 * WebCoreSupport/DragClientQt.h: 602 6032011-03-31 Marius Storm-Olsen <marius.storm-olsen@nokia.com> 604 605 Reviewed by Kenneth Rohde Christiansen. 606 607 [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call 608 https://bugs.webkit.org/show_bug.cgi?id=57017 609 610 Build fix. No new tests. 611 612 * QtWebKit.pro: 613 6142011-03-31 Evan Martin <evan@chromium.org> 615 616 Another build fix. 617 618 * WebCoreSupport/FrameLoaderClientQt.cpp: 619 (WebCore::FrameLoaderClientQt::updateGlobalHistory): 620 6212011-03-31 Nancy Piedra <nancy.piedra@nokia.com> 622 623 Reviewed by Benjamin Poulain. 624 625 [Qt] ChromeClientQt.h has coding-style errors 626 https://bugs.webkit.org/show_bug.cgi?id=40239 627 628 * WebCoreSupport/ChromeClientQt.h: 629 (WebCore::ChromeClientQt::scrollbarsModeDidChange): 630 (WebCore::ChromeClientQt::needTouchEvents): 631 (WebCore::ChromeClientQt::formStateDidChange): 632 (WebCore::ChromeClientQt::scrollRectIntoView): 633 (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame): 634 (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame): 635 6362011-03-31 Evan Martin <evan@chromium.org> 637 638 Build fix from previous change. 639 640 * Api/qwebframe.cpp: 641 (QWebFrame::title): 642 6432011-03-31 Evan Martin <evan@chromium.org> 644 645 Reviewed by Eric Seidel. 646 647 <title> should support dir attribute 648 https://bugs.webkit.org/show_bug.cgi?id=50961 649 650 Update to new FrameLoaderClient interface. 651 652 * WebCoreSupport/FrameLoaderClientQt.cpp: 653 (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): 654 (WebCore::FrameLoaderClientQt::setTitle): 655 * WebCoreSupport/FrameLoaderClientQt.h: 656 6572011-03-30 Yi Shen <yi.4.shen@nokia.com> 658 659 Reviewed by Kenneth Rohde Christiansen. 660 661 [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes 662 https://bugs.webkit.org/show_bug.cgi?id=57020 663 664 Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints(). 665 666 * tests/qwebview/tst_qwebview.cpp: 667 (tst_QWebView::focusInputTypes): 668 6692011-03-30 Robert Hogan <robert@webkit.org> 670 671 Reviewed by Antonio Gomes. 672 673 [Qt] Fix LoadHTMLStringItem::invoke() after r75966 674 675 Add DRT support for loading an alternate HTML string 676 for error pages. This allows Qt to unskip 677 http/tests/navigation/go-back-to-error-page.html. 678 679 https://bugs.webkit.org/show_bug.cgi?id=52614 680 681 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 682 (DumpRenderTreeSupportQt::setAlternateHtml): 683 * WebCoreSupport/DumpRenderTreeSupportQt.h: 684 6852011-03-29 Alexis Menard <alexis.menard@openbossa.org> 686 687 Unreviewed build fix for build-webkit -minimal. 688 689 Breakage introduced by http://trac.webkit.org/changeset/82238. 690 The minimal option has no support for shortcuts. 691 692 * WebCoreSupport/EditorClientQt.cpp: 693 (WebCore::EditorClientQt::handleInputMethodKeydown): 694 6952011-03-29 Janne Koskinen <janne.p.koskinen@digia.com> 696 697 Reviewed by Kenneth Rohde Christiansen. 698 699 [Qt] Enterkey to go to Newline does not work in the text area(in HTML form) 700 https://bugs.webkit.org/show_bug.cgi?id=33179 701 702 Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods. 703 704 * WebCoreSupport/EditorClientQt.cpp: 705 (WebCore::EditorClientQt::handleInputMethodKeydown): 706 * tests/qwebpage/tst_qwebpage.cpp: 707 (tst_QWebPage::inputMethods): 708 7092011-03-29 Andreas Kling <kling@webkit.org> 710 711 Reviewed by Simon Hausmann. 712 713 [Qt] Fix documentation for QWebPage::repaintRequested() 714 715 This signal is always emitted when the page is dirtied, so remove 716 reference to old behavior where we would only emit the signal for 717 headless QWebPages. 718 719 * Api/qwebpage.cpp: 720 7212011-03-28 Andreas Kling <kling@webkit.org> 722 723 Reviewed by Benjamin Poulain. 724 725 [Qt] Pass QString() instead of String() when emitting titleChanged() for new loads. 726 727 * WebCoreSupport/FrameLoaderClientQt.cpp: 728 (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad): 729 7302011-03-28 Andreas Kling <kling@webkit.org> 731 732 Reviewed by Benjamin Poulain. 733 734 [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested() 735 https://bugs.webkit.org/show_bug.cgi?id=52629 736 737 * WebCoreSupport/ChromeClientQt.cpp: 738 (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of 739 QWebPage::repaintRequested() use a Qt::QueuedConnection. 740 741 * tests/qwebpage/tst_qwebpage.cpp: 742 (RepaintRequestedRenderer::RepaintRequestedRenderer): 743 (RepaintRequestedRenderer::onRepaintRequested): 744 (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling 745 QWebFrame::render() in a slot connected to to QWebPage::repaintRequested() 746 doesn't cause recursive signal emissions. 747 7482011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com> 749 750 Reviewed by Andreas Kling. 751 752 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled 753 https://bugs.webkit.org/show_bug.cgi?id=57087 754 755 * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS 756 * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests 757 since they are applications, not libraries. 758 7592011-03-28 Andras Becsi <abecsi@webkit.org> 760 761 Reviewed by Csaba Osztrogonác. 762 763 [Qt] QtWebKit does not link with --3d-canvas using MinGW 764 https://bugs.webkit.org/show_bug.cgi?id=57225 765 766 * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols. 767 7682011-03-28 Csaba Osztrogonác <ossy@webkit.org> 769 770 Reviewed by Andreas Kling. 771 772 REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile. 773 https://bugs.webkit.org/show_bug.cgi?id=57183 774 775 Windows buildfix after r82065. 776 777 * Api/DerivedSources.pro: Readding escaping on Windows platforms. 778 7792011-03-27 Andreas Kling <kling@webkit.org> 780 781 Fix build warning about IconDatabaseClient.h (wrong path.) 782 783 * QtWebKit.pro: 784 7852011-03-27 Andreas Kling <kling@webkit.org> 786 787 Reviewed by Kenneth Rohde Christiansen. 788 789 [Qt] Support for CSS color and background-color properties on select element's dropdown list 790 https://bugs.webkit.org/show_bug.cgi?id=51627 791 792 Extend the QWebSelectData interface with background and foreground colors 793 for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle 794 getters in RenderMenuList. 795 796 * Api/qwebkitplatformplugin.h: 797 * WebCoreSupport/PopupMenuQt.cpp: 798 (SelectData::backgroundColor): 799 (SelectData::foregroundColor): 800 (SelectData::itemBackgroundColor): 801 (SelectData::itemForegroundColor): 802 * WebCoreSupport/QtFallbackWebPopup.cpp: 803 (WebCore::QtFallbackWebPopup::show): 804 (WebCore::QtFallbackWebPopup::populate): 805 8062011-03-27 Yi Shen <yi.4.shen@nokia.com> 807 808 Reviewed by Andreas Kling. 809 810 [Qt][Symbian] Fix Api test failure -- microFocusCoordinates 811 https://bugs.webkit.org/show_bug.cgi?id=57108 812 813 Since the canvas is not self-closing tag, we need to add '</canvas>'. 814 815 * tests/qgraphicswebview/tst_qgraphicswebview.cpp: 816 (tst_QGraphicsWebView::microFocusCoordinates): 817 * tests/qwebview/tst_qwebview.cpp: 818 (tst_QWebView::microFocusCoordinates): 819 8202011-03-27 Kwang Yul Seo <skyul@company100.net> 821 822 Reviewed by Eric Seidel. 823 824 [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap. 825 https://bugs.webkit.org/show_bug.cgi?id=57143 826 827 Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and 828 define WTF_USE_TEXTURE_MAPPER=1. 829 830 * QtWebKit.pro: 831 8322011-03-27 Andreas Kling <kling@webkit.org> 833 834 Reviewed by Benjamin Poulain. 835 836 REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile. 837 https://bugs.webkit.org/show_bug.cgi?id=57183 838 839 The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\> 840 which was due to the outputting code previously being wrapped in eval(). 841 842 * Api/DerivedSources.pro: 843 8442011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com> 845 846 Reviewed by Andreas Kling. 847 848 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled 849 https://bugs.webkit.org/show_bug.cgi?id=57087 850 851 Use explicit conversion for string to avoid depending on the default codec 852 installed by the user code. 853 854 * Api/qwebkitversion.cpp: 855 (qWebKitVersion): 856 * Api/qwebpage.cpp: 857 (QWebPagePrivate::dynamicPropertyChangeEvent): 858 (QWebPage::javaScriptConsoleMessage): 859 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 860 (convertToPropertyName): 861 (DumpRenderTreeSupportQt::setEditingBehavior): 862 (DumpRenderTreeSupportQt::plainText): 863 * WebCoreSupport/EditorClientQt.cpp: 864 (dumpRange): 865 * WebCoreSupport/FrameLoaderClientQt.cpp: 866 (drtDescriptionSuitableForTestResult): 867 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): 868 * WebCoreSupport/InspectorClientQt.cpp: 869 (WebCore::InspectorClientQt::openInspectorFrontend): 870 * WebCoreSupport/InspectorServerQt.cpp: 871 (WebCore::parseWebSocketChallengeNumber): 872 (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead): 873 8742011-03-26 Andreas Kling <kling@webkit.org> 875 876 Reviewed by Kenneth Rohde Christiansen. 877 878 [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded 879 https://bugs.webkit.org/show_bug.cgi?id=57157 880 881 Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged() 882 is always emitted when appropriate. 883 884 * QtWebKit.pro: Add new files. 885 886 * WebCoreSupport/IconDatabaseClientQt.h: Added. 887 * WebCoreSupport/IconDatabaseClientQt.cpp: Added. 888 (WebCore::IconDatabaseClientQt::instance): 889 (WebCore::IconDatabaseClientQt::IconDatabaseClientQt): 890 (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt): 891 (WebCore::IconDatabaseClientQt::performImport): 892 (WebCore::IconDatabaseClientQt::didRemoveAllIcons): 893 (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL): 894 (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL): 895 (WebCore::IconDatabaseClientQt::didChangeIconForPageURL): 896 (WebCore::IconDatabaseClientQt::didFinishURLImport): 897 898 * WebCoreSupport/FrameLoaderClientQt.h: 899 * WebCoreSupport/FrameLoaderClientQt.cpp: 900 (WebCore::FrameLoaderClientQt::registerForIconNotification): 901 (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected 902 to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the 903 QWebFrame::iconChanged() signal when the IconDatabases finishes loading 904 a cached favicon for the frame's URL. 905 906 * Api/qwebsettings.cpp: 907 (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is 908 instantiated. An IconDatabaseClient has to be registered before the IconDatabase 909 spawns its reader thread. 910 9112011-03-25 Andy Estes <aestes@apple.com> 912 913 Reviewed by Adele Peterson. 914 915 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js 916 https://bugs.webkit.org/show_bug.cgi?id=49016 917 918 Update objectContentType() implementation to handle the 919 shouldPreferPlugInsForImages flag. 920 921 * WebCoreSupport/FrameLoaderClientQt.cpp: 922 (WebCore::FrameLoaderClientQt::objectContentType): 923 * WebCoreSupport/FrameLoaderClientQt.h: 924 9252011-03-25 Chang Shu <cshu@webkit.org> 926 927 Reviewed by Ryosuke Niwa. 928 929 rename Node::isContentEditable and all call sites to rendererIsEditable 930 https://bugs.webkit.org/show_bug.cgi?id=54290 931 932 This is part of the effort to separate JS API HTMLElement isContentEditable from 933 internal Node::rendererIsEditable. 934 935 * WebCoreSupport/EditorClientQt.cpp: 936 (WebCore::EditorClientQt::handleKeyboardEvent): 937 9382011-03-25 Alexis Menard <alexis.menard@openbossa.org> 939 940 Reviewed by Andreas Kling. 941 942 [Qt] The keyboard shortcuts during fullscreen playback do not work. 943 https://bugs.webkit.org/show_bug.cgi?id=57095 944 945 We need to explicitely set the focus on the widget in order to receive the keyboard events. 946 947 * WebCoreSupport/FullScreenVideoWidget.cpp: 948 (WebCore::FullScreenVideoWidget::show): 949 9502011-03-24 Sheriff Bot <webkit.review.bot@gmail.com> 951 952 Unreviewed, rolling out r81916 and r81917. 953 http://trac.webkit.org/changeset/81916 954 http://trac.webkit.org/changeset/81917 955 https://bugs.webkit.org/show_bug.cgi?id=57071 956 957 broke a test on platforms that do not have QuickTime installed 958 (Requested by estes on #webkit). 959 960 * WebCoreSupport/FrameLoaderClientQt.cpp: 961 (WebCore::FrameLoaderClientQt::objectContentType): 962 * WebCoreSupport/FrameLoaderClientQt.h: 963 9642011-03-24 Andy Estes <aestes@apple.com> 965 966 Reviewed by Darin Adler. 967 968 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js 969 https://bugs.webkit.org/show_bug.cgi?id=49016 970 971 Update objectContentType() implementation to handle the 972 shouldPreferPlugInsForImages flag. 973 974 * WebCoreSupport/FrameLoaderClientQt.cpp: 975 (WebCore::FrameLoaderClientQt::objectContentType): 976 * WebCoreSupport/FrameLoaderClientQt.h: 977 9782011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com> 979 980 Reviewed by Kenneth Rohde Christiansen. 981 982 [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles 983 https://bugs.webkit.org/show_bug.cgi?id=40884 984 985 Add tests and benchmarks for the software fallback of WebGL. 986 987 * tests/benchmarks/webgl/10000_triangles.html: Added. 988 * tests/benchmarks/webgl/tst_webgl.cpp: Added. 989 (GraphicsView::GraphicsView): 990 (GraphicsView::resizeEvent): 991 (tst_WebGlPerformance::init): 992 (tst_WebGlPerformance::cleanup): 993 (tst_WebGlPerformance::benchSoftwareFallbackRgb16): 994 (tst_WebGlPerformance::benchSoftwareFallbackRgb32): 995 (tst_WebGlPerformance::benchSoftwareFallbackArgb32): 996 (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied): 997 (tst_WebGlPerformance::benchmarkFrameRenderingOnImage): 998 * tests/benchmarks/webgl/tst_webgl.qrc: Added. 999 * tests/benchmarks/webgl/webgl.pro: Added. 1000 * tests/qgraphicswebview/qgraphicswebview.pro: 1001 * tests/qgraphicswebview/resources/pointing_right.html: Added. 1002 * tests/qgraphicswebview/resources/pointing_up.html: Added. 1003 * tests/qgraphicswebview/tst_qgraphicswebview.cpp: 1004 (compareImagesFuzzyPixelCount): 1005 (GraphicsView::GraphicsView): 1006 (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation): 1007 (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation): 1008 (tst_QGraphicsWebView::compareCanvasToImage): 1009 * tests/qgraphicswebview/tst_qgraphicswebview.qrc: 1010 * tests/tests.pro: 1011 10122011-03-24 Kristian Amlie <kristian.amlie@nokia.com> 1013 1014 Reviewed by Benjamin Poulain. 1015 1016 Avoided ASCII-cast warnings for WebKit. 1017 1018 Normally they won't be enabled anyway, but if you build webkit from 1019 within the Qt mother repository it will pick up Qt's default build 1020 settings, which do enable it. We need to disable them because 1021 warnings are treated as errors and there are way too many of them in 1022 the WebKit code. 1023 1024 [Qt] Avoid ASCII-cast warnings for WebKit. 1025 https://bugs.webkit.org/show_bug.cgi?id=57016 1026 1027 * QtWebKit.pro: 1028 10292011-03-24 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> 1030 1031 Reviewed by Benjamin Poulain. 1032 1033 [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL 1034 https://bugs.webkit.org/show_bug.cgi?id=29595 1035 1036 Qt Designer resets the URL by setting it to QUrl(). The bug was caused by 1037 ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and 1038 prepending the current directory. 1039 1040 By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which 1041 will end up loading "about:blank", but keeping it as a requested URL. 1042 1043 This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl 1044 is filled for the loaded URLs as well, we can use it in every case. 1045 1046 Three new autotests were added, to better cover the expected behavior of setting 1047 the QUrl() in a QWebFrame. 1048 1049 * Api/qwebframe.cpp: 1050 (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative. 1051 (QWebFrame::requestedUrl): always use m_lastRequestedUrl. 1052 1053 * WebCoreSupport/FrameLoaderClientQt.cpp: 1054 (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl 1055 anymore, since we always rely on it even for loaded frames. 1056 1057 * tests/qwebframe/tst_qwebframe.cpp: 1058 (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes 1059 the reduction of the bug report. 1060 (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs. 1061 (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history. 1062 10632011-03-23 Brady Eidson <beidson@apple.com> 1064 1065 Reviewed by Sam Weinig. 1066 1067 Change IconDatabase opening to allow for arbitrary filenames 1068 https://bugs.webkit.org/show_bug.cgi?id=56977 1069 1070 * Api/qwebsettings.cpp: 1071 (QWebSettings::setIconDatabasePath): 1072 10732011-03-23 Aparna Nandyal <aparna.nand@wipro.com> 1074 1075 Reviewed by Andreas Kling. 1076 1077 [Qt] QtWebKit rendering problem when maximizing and doing a back 1078 https://bugs.webkit.org/show_bug.cgi?id=56669 1079 1080 Added an auto test. 1081 Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21 1082 1083 * tests/qwebview/tst_qwebview.cpp: 1084 (tst_QWebView::rendering): 1085 10862011-03-23 Yury Semikhatsky <yurys@chromium.org> 1087 1088 Reviewed by Pavel Feldman. 1089 1090 [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h 1091 https://bugs.webkit.org/show_bug.cgi?id=56843 1092 1093 * WebCoreSupport/InspectorClientQt.cpp: 1094 (WebCore::InspectorClientQt::openInspectorFrontend): 1095 10962011-03-22 Andrew Wason <rectalogic@rectalogic.com> 1097 1098 Reviewed by Benjamin Poulain. 1099 1100 [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent 1101 https://bugs.webkit.org/show_bug.cgi?id=54138 1102 1103 * tests/qwebpage/tst_qwebpage.cpp: 1104 (webGLScreenshotWithoutView): 1105 (tst_QWebPage::acceleratedWebGLScreenshotWithoutView): 1106 (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView): 1107 Render a QWebPage (with and without accelerated compositing) 1108 with a WebGL context that has no owning view. Shouldn't crash. 1109 11102011-03-21 Chang Shu <cshu@webkit.org> 1111 1112 Reviewed by Alexey Proskuryakov. 1113 1114 REGRESSION (r79953): Can't type in MS Outlook 2011 1115 https://bugs.webkit.org/show_bug.cgi?id=56665 1116 1117 r79953 removed the WebView level editablity which is persistent no matter whether 1118 underlying document itself is changed and editability gets lost. The resolution is to 1119 set this WebView editable value to WebCore. This avoids the callback from WebCore to 1120 WebKit which was the main goal in r79953 to improve performance. 1121 1122 * Api/qwebpage.cpp: 1123 (QWebPage::setContentEditable): 1124 (QWebPage::isContentEditable): 1125 11262011-03-19 Andreas Kling <kling@webkit.org> 1127 1128 Reviewed by Benjamin Poulain. 1129 1130 [Qt] Remove support for Qt 4.6 1131 https://bugs.webkit.org/show_bug.cgi?id=56712 1132 1133 * Api/qwebframe.cpp: 1134 (QWebFrame::load): 1135 * Api/qwebpage.cpp: 1136 (QWebPagePrivate::QWebPagePrivate): 1137 * Api/qwebsettings.cpp: 1138 (QWebSettings::QWebSettings): 1139 * WebCoreSupport/GeolocationClientQt.cpp: 1140 (WebCore::GeolocationClientQt::positionUpdated): 1141 11422011-03-19 Andreas Kling <kling@webkit.org> 1143 1144 Reviewed by Antonio Gomes. 1145 1146 [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply 1147 https://bugs.webkit.org/show_bug.cgi?id=56711 1148 1149 Document the fact that when unsupportedContent(QNetworkReply*) is emitted, 1150 ownership of the reply is transferred to the receiving slot. 1151 1152 * Api/qwebpage.cpp: 1153 11542011-03-17 Brady Eidson <beidson@apple.com> 1155 1156 Reviewed by Sam Weinig. 1157 1158 https://bugs.webkit.org/show_bug.cgi?id=56425 1159 More groundwork for WebKit2 IconDatabase 1160 1161 Update already-used function names: 1162 * Api/qwebhistory.cpp: 1163 (QWebHistoryItem::icon): 1164 * Api/qwebsettings.cpp: 1165 (QWebSettings::iconForUrl): 1166 11672011-03-18 Alexis Menard <alexis.menard@openbossa.org> 1168 1169 Reviewed by Benjamin Poulain. 1170 1171 [Qt] console.log not being exposed to QmlViewer 1172 https://bugs.webkit.org/show_bug.cgi?id=56536 1173 1174 The documentation is bogus the feature does not exist. 1175 1176 * declarative/qdeclarativewebview.cpp: 1177 11782011-03-17 Andreas Kling <kling@webkit.org> 1179 1180 Reviewed by Kenneth Rohde Christiansen. 1181 1182 [Qt] QML WebView emits iconChanged() when the page title changes 1183 https://bugs.webkit.org/show_bug.cgi?id=56570 1184 1185 * declarative/qdeclarativewebview.cpp: 1186 (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged 1187 signal to the view's iconChanged signal. 1188 11892011-03-17 Alexis Menard <alexis.menard@openbossa.org> 1190 1191 Reviewed by Benjamin Poulain. 1192 1193 [Qt] Videos look ugly when using QGraphicsWebView. 1194 https://bugs.webkit.org/show_bug.cgi?id=56580 1195 1196 We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video. 1197 QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it 1198 by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView 1199 QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch 1200 ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing 1201 in addition of what could be set on the painter. In order to not break the rendering of all the items in the 1202 scene we set back the painter to its original state when QGraphicsWebView is rendered. 1203 1204 * Api/qgraphicswebview.cpp: 1205 (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): 1206 (QGraphicsWebView::paint): 1207 (QGraphicsWebView::renderHints): 1208 (QGraphicsWebView::setRenderHints): 1209 (QGraphicsWebView::setRenderHint): 1210 * Api/qgraphicswebview.h: 1211 * tests/qgraphicswebview/tst_qgraphicswebview.cpp: 1212 (tst_QGraphicsWebView::renderHints): 1213 12142011-03-16 Joseph Pecoraro <joepeck@webkit.org> 1215 1216 Reviewed by Kenneth Rohde Christiansen. 1217 1218 Viewport no longer allows an auto value for "user-scalable" 1219 https://bugs.webkit.org/show_bug.cgi?id=55416 1220 1221 Make the default value for userScalable be true. 1222 1223 * Api/qwebpage.cpp: 1224 (QWebPage::viewportAttributesForSize): 1225 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 1226 (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable. 1227 12282011-03-15 Kevin Ollivier <kevino@theolliviers.com> 1229 1230 Reviewed by Darin Adler. 1231 1232 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export 1233 info into the headers rather than in export symbol definition files, but disable it on 1234 all platforms initially so we can deal with port build issues one port at a time. 1235 1236 https://bugs.webkit.org/show_bug.cgi?id=27551 1237 1238 * WebCoreSupport/GeolocationClientQt.cpp: 1239 * WebCoreSupport/PopupMenuQt.cpp: 1240 12412011-03-14 Brady Eidson <beidson@apple.com> 1242 1243 Reviewed by Anders Carlsson. 1244 1245 https://bugs.webkit.org/show_bug.cgi?id=56320 1246 Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()" 1247 1248 * Api/qwebhistory.cpp: 1249 (QWebHistoryItem::icon): Use IconDatabase directly. 1250 12512011-03-11 Brady Eidson <beidson@apple.com> 1252 1253 Reviewed by attempt at build fix! 1254 1255 https://bugs.webkit.org/show_bug.cgi?id=56216 1256 Fix the Qt build following the same pattern of the patch. 1257 1258 * Api/qwebsettings.cpp: 1259 (QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase() 1260 12612011-03-11 Alexis Menard <alexis.menard@openbossa.org> 1262 1263 Reviewed by Ariya Hidayat. 1264 1265 [Qt] Entering fullscreen and leaving it may hide the cursor of the application. 1266 https://bugs.webkit.org/show_bug.cgi?id=56181 1267 1268 We need to stop the auto hide cursor timer when closing the widget otherwise the timer 1269 might get fired and therefore hide the cursor even when the fullscreen widget is closed. 1270 1271 * WebCoreSupport/FullScreenVideoWidget.cpp: 1272 (WebCore::FullScreenVideoWidget::closeEvent): 1273 12742011-03-10 David Boddie <david.boddie@nokia.com> 1275 1276 Reviewed by Andreas Kling. 1277 1278 Fixed a qdoc warning and terminology (WebKit instead of Webkit). 1279 https://bugs.webkit.org/show_bug.cgi?id=55756 1280 1281 * Api/qwebhistoryinterface.cpp: 1282 12832011-03-10 Andreas Kling <kling@webkit.org> 1284 1285 Unreviewed build fix after r80774. 1286 1287 QML property versioning is introduced in Qt 4.7.3, not 4.7.2. 1288 See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451 1289 1290 * declarative/plugin.cpp: 1291 (WebKitQmlPlugin::registerTypes): 1292 * declarative/qdeclarativewebview.cpp: 1293 * declarative/qdeclarativewebview_p.h: 1294 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: 1295 12962011-03-10 Alexis Menard <alexis.menard@openbossa.org> 1297 1298 Reviewed by Andreas Kling. 1299 1300 [Qt] QtDeclarative Webview element has a fixed white background 1301 https://bugs.webkit.org/show_bug.cgi?id=40918 1302 1303 Implement a way to change the background color of the WebView QML element. 1304 This feature is activated for QtWebKit 1.1 version of the plugin. 1305 1306 * declarative/plugin.cpp: 1307 (WebKitQmlPlugin::registerTypes): 1308 * declarative/qdeclarativewebview.cpp: 1309 (QDeclarativeWebView::backgroundColor): 1310 (QDeclarativeWebView::setBackgroundColor): 1311 * declarative/qdeclarativewebview_p.h: 1312 * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added. 1313 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: 1314 (tst_QDeclarativeWebView::backgroundColor): 1315 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc: 1316 13172011-03-10 Stanislav Paltis <Stanislav.Paltis@nokia.com> 1318 1319 Reviewed by Laszlo Gombos. 1320 1321 [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage 1322 https://bugs.webkit.org/show_bug.cgi?id=55945 1323 1324 Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to 1325 set interval used to trigger when decoded data in dead list of object cache will 1326 be purged from object cache. 1327 1328 * Api/qwebpage.cpp: 1329 (QWebPagePrivate::dynamicPropertyChangeEvent): 1330 13312011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> 1332 1333 Reviewed by Antonio Gomes. 1334 1335 Simplify how QWebFrame::requestedUrl() is obtained 1336 https://bugs.webkit.org/show_bug.cgi?id=55842 1337 1338 When a load starts, store the requested URL until we know that it'll be 1339 available for us in the document loader -- after load finished. 1340 1341 The existing auto tests cover the three different code paths in 1342 requestedUrl() and the new code passes the autotests. In each of those 1343 cases, we looked for the information in a different place, but in all 1344 of them, dispatchDidStartProvisionalLoad was called. 1345 1346 This simplification will be useful to fix bug 32723. The way requestedUrl() 1347 is implementent, we can't use it as a fallback for url() when the setUrl() 1348 was called with an invalid URL. 1349 1350 * Api/qwebframe.cpp: 1351 (QWebFrame::requestedUrl): 1352 * WebCoreSupport/FrameLoaderClientQt.cpp: 1353 (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): 1354 (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): 1355 * WebCoreSupport/FrameLoaderClientQt.h: 1356 (WebCore::FrameLoaderClientQt::lastRequestedUrl): 1357 13582011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 1359 1360 Reviewed by Kenneth Rohde Christiansen. 1361 1362 Tiled backing store's delegated scroll request uses incorrect convention 1363 https://bugs.webkit.org/show_bug.cgi?id=56011 1364 1365 Adapt internal API to match the change from delta to point on the 1366 WebCore side, and convert the point to a delta for the public API. 1367 1368 * WebCoreSupport/ChromeClientQt.cpp: 1369 (WebCore::ChromeClientQt::delegatedScrollRequested): 1370 * WebCoreSupport/ChromeClientQt.h: 1371 13722011-03-09 Peter Kasting <pkasting@google.com> 1373 1374 Reviewed by Mihai Parparita. 1375 1376 Unify Windows version checks. 1377 https://bugs.webkit.org/show_bug.cgi?id=55979 1378 1379 * Api/qwebpage.cpp: 1380 (QWebPage::userAgentForUrl): 1381 13822011-03-07 Sam Weinig <sam@webkit.org> 1383 1384 Reviewed by Anders Carlsson. 1385 1386 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse 1387 https://bugs.webkit.org/show_bug.cgi?id=55827 1388 1389 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse 1390 and pass the entire response, instead of just the MIMEType. 1391 1392 * WebCoreSupport/FrameLoaderClientQt.cpp: 1393 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse): 1394 * WebCoreSupport/FrameLoaderClientQt.h: 1395 13962011-03-05 Qi Zhang <qi.2.zhang@nokia.com> 1397 1398 Reviewed by Laszlo Gombos. 1399 1400 [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String 1401 https://bugs.webkit.org/show_bug.cgi?id=48636 1402 1403 Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo. 1404 1405 * Api/qwebpage.cpp: 1406 (QWebPage::userAgentForUrl): 1407 14082011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> 1409 1410 Reviewed by Kenneth Rohde Christiansen. 1411 1412 [QT] Implement mock client-based geolocation for layout testing 1413 https://bugs.webkit.org/show_bug.cgi?id=54334 1414 1415 Implement layout testing for Client-Based geolocation. If drt_run is set 1416 then create mock geolocationClient and update the same with controller. 1417 1418 * Api/qwebpage.cpp: 1419 (QWebPagePrivate::QWebPagePrivate): 1420 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 1421 (DumpRenderTreeSupportQt::mockGeolocationReset): 1422 (DumpRenderTreeSupportQt::setMockGeolocationPermission): 1423 (DumpRenderTreeSupportQt::setMockGeolocationPosition): 1424 (DumpRenderTreeSupportQt::setMockGeolocationError): 1425 * WebCoreSupport/DumpRenderTreeSupportQt.h: 1426 * WebCoreSupport/GeolocationClientQt.cpp: 1427 (WebCore::GeolocationClientQt::GeolocationClientQt): 1428 * WebCoreSupport/GeolocationClientQt.h: 1429 14302011-03-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> 1431 1432 Reviewed by Kenneth Rohde Christiansen. 1433 1434 [Qt] QWebFrame::setUrl works only from second time if url fragment is present 1435 https://bugs.webkit.org/show_bug.cgi?id=32723 1436 1437 Create an auto-test for Qt based on the bug description. 1438 1439 * tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test. 1440 14412011-03-03 Brady Eidson <beidson@apple.com> 1442 1443 Reviewed by Darin Adler. 1444 1445 https://bugs.webkit.org/show_bug.cgi?id=55721 1446 Global IconDatabase should be returned by reference, not as a pointer 1447 1448 * Api/qwebsettings.cpp: 1449 (QWebSettings::setIconDatabasePath): 1450 (QWebSettings::iconDatabasePath): 1451 (QWebSettings::clearIconDatabase): 1452 (QWebSettings::iconForUrl): 1453 14542011-03-03 Alexey Proskuryakov <ap@apple.com> 1455 1456 Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included 1457 via ChromeClient.h 1458 1459 * WebCoreSupport/ChromeClientQt.h: 1460 14612011-03-02 Alexey Proskuryakov <ap@apple.com> 1462 1463 Reviewed by Darin Adler. 1464 1465 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access 1466 https://bugs.webkit.org/show_bug.cgi?id=55633 1467 <rdar://problem/8963023> 1468 1469 * WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode): 1470 * WebCoreSupport/ChromeClientQt.h: 1471 Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since 1472 this platform doesn't observe or have full keyboard access state. 1473 14742011-03-03 Alexis Menard <alexis.menard@openbossa.org> 1475 1476 Reviewed by Andreas Kling. 1477 1478 [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem 1479 https://bugs.webkit.org/show_bug.cgi?id=55568 1480 1481 We should use updateMicroFocus() from QGraphicsItem rather than the implementation 1482 in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature. 1483 In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done 1484 in QGraphicsItem. 1485 1486 * Api/qgraphicswebview.cpp: 1487 (QGraphicsWebView::setPage): 1488 * Api/qgraphicswebview.h: 1489 14902011-03-03 Peter Kasting <pkasting@google.com> 1491 1492 Reviewed by James Robinson. 1493 1494 Drop redundant "Windows; " from the Windows-specific User Agent string. 1495 https://bugs.webkit.org/show_bug.cgi?id=54567 1496 1497 * Api/qwebpage.cpp: 1498 (QWebPage::userAgentForUrl): 1499 15002011-03-01 Brian Weinstein <bweinstein@apple.com> 1501 1502 Reviewed by Adam Roben. 1503 1504 Part of WebKit2: Need a way to send notifications to client when cookies change 1505 https://bugs.webkit.org/show_bug.cgi?id=55427 1506 <rdar://problem/9056027> 1507 1508 Add stubs for CookiesStrategy on Qt WebKit1. 1509 1510 * WebCoreSupport/WebPlatformStrategies.cpp: 1511 (WebPlatformStrategies::createCookiesStrategy): 1512 (WebPlatformStrategies::notifyCookiesChanged): 1513 * WebCoreSupport/WebPlatformStrategies.h: 1514 15152011-03-01 Joseph Pecoraro <joepeck@webkit.org> 1516 1517 Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port. 1518 1519 * Api/qwebpage.cpp: 1520 (QWebPage::viewportAttributesForSize): 1521 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 1522 (DumpRenderTreeSupportQt::viewportAsText): 1523 15242011-03-01 Joseph Pecoraro <joepeck@webkit.org> 1525 1526 Reviewed by Kenneth Rohde Christiansen. 1527 1528 Viewport Warning/Error Messages Are Now Inaccurate 1529 https://bugs.webkit.org/show_bug.cgi?id=53707 1530 1531 * Api/qwebpage.cpp: 1532 (QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to. 1533 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 1534 (DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to. 1535 15362011-03-01 Andras Becsi <abecsi@webkit.org> 1537 1538 Reviewed by Csaba Osztrogonác. 1539 1540 [Qt] Clean up the project files and move common options to WebKit.pri. 1541 1542 * QtWebKit.pro: Move common options to WebKit.pri. 1543 15442011-03-01 Aparna Nandyal <aparna.nand@wipro.com> 1545 1546 Reviewed by Simon Hausmann. 1547 1548 [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection 1549 https://bugs.webkit.org/show_bug.cgi?id=55319 1550 1551 The test case required internet connection to be able to connect to 1552 google.com. Added new html file which refers to local html file. 1553 1554 * tests/qwebpage/resources/content.html: Added. 1555 * tests/qwebpage/resources/frame_c.html: Added. 1556 * tests/qwebpage/resources/framedindex.html: Added. 1557 * tests/qwebpage/tst_qwebpage.cpp: 1558 (tst_QWebPage::backActionUpdate): 1559 * tests/qwebpage/tst_qwebpage.qrc: 1560 15612011-02-25 Steve Block <steveblock@google.com> 1562 1563 Reviewed by Jeremy Orlow. 1564 1565 Bridge.h should not include BridgeJSC.h 1566 https://bugs.webkit.org/show_bug.cgi?id=55212 1567 1568 Include BridgeJSC.h directly instead. 1569 1570 * Api/qwebframe.cpp: 1571 15722011-02-28 Chang Shu <cshu@webkit.org> 1573 1574 Reviewed by Ryosuke Niwa. 1575 1576 Remove the support of Frame::isContentEditable and its dependencies. 1577 https://bugs.webkit.org/show_bug.cgi?id=54292 1578 1579 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode. 1580 1581 * Api/qwebpage.cpp: 1582 (QWebPagePrivate::QWebPagePrivate): 1583 (QWebPage::setContentEditable): 1584 (QWebPage::isContentEditable): 1585 * Api/qwebpage_p.h: 1586 * WebCoreSupport/EditorClientQt.cpp: 1587 * WebCoreSupport/EditorClientQt.h: 1588 15892011-02-28 Alexis Menard <alexis.menard@openbossa.org> 1590 1591 Reviewed by Oliver Hunt. 1592 1593 Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904. 1594 1595 * Api/qwebelement.cpp: 1596 (QWebElement::evaluateJavaScript): 1597 15982011-02-28 Alexis Menard <alexis.menard@openbossa.org> 1599 1600 Reviewed by Andreas Kling. 1601 1602 [Qt]tst_QDeclarativeWebView - 8 test cases fail 1603 https://bugs.webkit.org/show_bug.cgi?id=55214 1604 1605 Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView 1606 if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672). 1607 I also refactored the tests so we don't use the network but instead a local html file. 1608 QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards. 1609 1610 * tests/qdeclarativewebview/resources/sample.html: Added. 1611 * tests/qdeclarativewebview/resources/webviewtest.qml: 1612 * tests/qdeclarativewebview/resources/webviewtestdefault.qml: 1613 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: 1614 (tst_QDeclarativeWebView::preferredWidthTest): 1615 (tst_QDeclarativeWebView::preferredHeightTest): 1616 (tst_QDeclarativeWebView::preferredWidthDefaultTest): 1617 (tst_QDeclarativeWebView::preferredHeightDefaultTest): 1618 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc: 1619 16202011-02-28 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> 1621 1622 Reviewed by Andreas Kling. 1623 1624 [Qt] Add clipped version of QWebElement::render method. 1625 Allows faster rendering of web element part. 1626 https://bugs.webkit.org/show_bug.cgi?id=50311 1627 1628 * Api/qwebelement.cpp: 1629 (QWebElement::render): 1630 * Api/qwebelement.h: 1631 * tests/qwebelement/tst_qwebelement.cpp: 1632 (tst_QWebElement::render): 1633 16342011-02-28 Kristian Amlie <kristian.amlie@nokia.com> 1635 1636 Reviewed by Andreas Kling. 1637 1638 Added full webkit module profile and a syncqt profile. 1639 1640 This is for modularized Qt. 1641 1642 [Qt] WebKit patches required to work with a modularized version of Qt 1643 https://bugs.webkit.org/show_bug.cgi?id=53916 1644 1645 * qt_webkit_version.pri: 1646 16472011-02-27 Aparna Nandyal <aparna.nand@wipro.com> 1648 1649 Reviewed by Antonio Gomes. 1650 1651 [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward 1652 https://bugs.webkit.org/show_bug.cgi?id=53917 1653 1654 Adding test case to check the scenario to avoid regressions in the 1655 future. 1656 1657 * tests/qwebframe/tst_qwebframe.cpp: 1658 16592011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com> 1660 1661 Reviewed by Andreas Kling. 1662 1663 [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject() 1664 https://bugs.webkit.org/show_bug.cgi?id=55322 1665 1666 Documentation update, add a reference to the QtWebKit bridge page. 1667 1668 * Api/qwebframe.cpp: 1669 16702011-02-26 Vsevolod Vlasov <vsevik@chromium.org> 1671 1672 Reviewed by Pavel Feldman. 1673 1674 DumpRenderTree should reset frame opener between tests. 1675 https://bugs.webkit.org/show_bug.cgi?id=54874 1676 1677 Added clearOpener method to DumpRenderTreeSupportQT. 1678 1679 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 1680 (DumpRenderTreeSupportQt::clearOpener): 1681 * WebCoreSupport/DumpRenderTreeSupportQt.h: 1682 16832011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org> 1684 1685 Reviewed by Andreas Kling. 1686 1687 Make it possible to test the targetdensity-dpi support 1688 https://bugs.webkit.org/show_bug.cgi?id=55142 1689 1690 Test the viewport meta tag feature targetdensity-dpi by 1691 adding extra arguments to dumpConfigurationForViewport 1692 1693 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 1694 (DumpRenderTreeSupportQt::viewportAsText): 1695 * WebCoreSupport/DumpRenderTreeSupportQt.h: 1696 16972011-02-26 Sheriff Bot <webkit.review.bot@gmail.com> 1698 1699 Unreviewed, rolling out r79764. 1700 http://trac.webkit.org/changeset/79764 1701 https://bugs.webkit.org/show_bug.cgi?id=55295 1702 1703 "broke Chromium builds" (Requested by rniwa on #webkit). 1704 1705 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 1706 * WebCoreSupport/DumpRenderTreeSupportQt.h: 1707 17082011-02-26 Vsevolod Vlasov <vsevik@chromium.org> 1709 1710 Reviewed by Pavel Feldman. 1711 1712 DumpRenderTree should reset frame opener between tests. 1713 https://bugs.webkit.org/show_bug.cgi?id=54874 1714 1715 Added clearOpener method to DumpRenderTreeSupportQT. 1716 1717 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 1718 (DumpRenderTreeSupportQt::clearOpener): 1719 * WebCoreSupport/DumpRenderTreeSupportQt.h: 1720 17212011-02-25 Andras Becsi <abecsi@webkit.org> 1722 1723 Reviewed by Csaba Osztrogonác. 1724 1725 [Qt] Make the WebKit2 build system less confusing for non-Qt developers 1726 https://bugs.webkit.org/show_bug.cgi?id=55213 1727 1728 * QtWebKit.pro: Move the WebKit2 API into a project include file 1729 in the WebKit2 directory and include the pri file here. 1730 17312011-02-25 Alexis Menard <alexis.menard@openbossa.org> 1732 1733 Unreviewed build fix for Intel ICC and MSVC. 1734 1735 * tests/qgraphicswebview/tst_qgraphicswebview.cpp: 1736 (tst_QGraphicsWebView::setPalette): 1737 * tests/qwebview/tst_qwebview.cpp: 1738 (tst_QWebView::setPalette): 1739 17402011-02-25 Alexis Menard <alexis.menard@openbossa.org> 1741 1742 Reviewed by Kenneth Rohde Christiansen. 1743 1744 [Qt] Properly propagate the palette to QWebPage from QGraphicsWebView 1745 https://bugs.webkit.org/show_bug.cgi?id=31742 1746 1747 Discovered while looking at 31742. When we set a palette on the 1748 QGraphicsWebView we need to propagate it to the page like QWebView. 1749 I have added the same tests as QWebView to be sure to catch potential 1750 regressions as well as two extras QVERIFY to check the palette propagation. 1751 1752 * Api/qgraphicswebview.cpp: 1753 (QGraphicsWebView::event): 1754 * tests/qgraphicswebview/tst_qgraphicswebview.cpp: 1755 (tst_QGraphicsWebView::setPalette_data): 1756 (tst_QGraphicsWebView::setPalette): 1757 17582011-02-25 Csaba Osztrogonác <ossy@webkit.org> 1759 1760 Unreviewed buildfix after r79672. 1761 1762 [Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative. 1763 1764 * tests/tests.pri: 1765 * tests/tests.pro: 1766 17672011-02-25 Gopal Raghavan <gopal.1.raghavan@nokia.com> 1768 1769 Reviewed by Kenneth Rohde Christiansen. 1770 1771 [Qt] QML WebView inside a Flickable shows checkers pattern at startup 1772 https://bugs.webkit.org/show_bug.cgi?id=50222. 1773 1774 This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set. 1775 1776 * declarative/qdeclarativewebview.cpp: 1777 (QDeclarativeWebView::init): 1778 * tests/qdeclarativewebview: Added. 1779 * tests/qdeclarativewebview/qdeclarativewebview.pro: Added. 1780 * tests/qdeclarativewebview/resources: Added. 1781 * tests/qdeclarativewebview/resources/webviewtest.qml: Added. 1782 * tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added. 1783 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added. 1784 (tst_QDeclarativeWebView::initTestCase): 1785 (tst_QDeclarativeWebView::cleanupTestCase): 1786 (tst_QDeclarativeWebView::init): 1787 (tst_QDeclarativeWebView::cleanup): 1788 (tst_QDeclarativeWebView::preferredWidthTest): 1789 (tst_QDeclarativeWebView::preferredHeightTest): 1790 (tst_QDeclarativeWebView::preferredWidthDefaultTest): 1791 (tst_QDeclarativeWebView::preferredHeightDefaultTest): 1792 (tst_QDeclarativeWebView::checkNoErrors): 1793 * tests/tests.pri: 1794 * tests/tests.pro: 1795 17962011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 1797 1798 Reviewed by Andreas Kling. 1799 1800 [Qt] Revert the support for QNAM affined to a different thread. 1801 https://bugs.webkit.org/show_bug.cgi?id=55149 1802 1803 Qt 4.8 will have QNAM use its own thread internally by default, 1804 no need to keep this complexity in WebKit. 1805 1806 This mainly reverts: 1807 http://trac.webkit.org/changeset/73710 1808 http://trac.webkit.org/changeset/73712 1809 1810 * WebCoreSupport/FrameLoaderClientQt.cpp: 1811 (WebCore::FrameLoaderClientQt::download): 1812 * tests/qwebpage/tst_qwebpage.cpp: 1813 18142011-02-24 Sam Weinig <sam@webkit.org> 1815 1816 Try to fix the Qt build. 1817 1818 * QtWebKit.pro: 1819 18202011-02-24 Peter Kasting <pkasting@google.com> 1821 1822 Reviewed by Eric Seidel. 1823 1824 Drop the "U; " encryption level from the User Agent string. 1825 https://bugs.webkit.org/show_bug.cgi?id=54566 1826 1827 * Api/qwebpage.cpp: 1828 (QWebPage::userAgentForUrl): 1829 18302011-02-24 Andrew Wilson <atwilson@chromium.org> 1831 1832 Unreviewed, rolling out r79570. 1833 http://trac.webkit.org/changeset/79570 1834 https://bugs.webkit.org/show_bug.cgi?id=54874 1835 1836 Breaks chromium build because glue/mocks/mock_web_frame.h/cc 1837 was not updated 1838 1839 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 1840 * WebCoreSupport/DumpRenderTreeSupportQt.h: 1841 18422011-02-24 Vsevolod Vlasov <vsevik@chromium.org> 1843 1844 Reviewed by Alexey Proskuryakov. 1845 1846 DumpRenderTree should reset frame opener between tests. 1847 https://bugs.webkit.org/show_bug.cgi?id=54874 1848 1849 Added clearOpener method to DumpRenderTreeSupportQT. 1850 1851 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 1852 (DumpRenderTreeSupportQt::clearOpener): 1853 * WebCoreSupport/DumpRenderTreeSupportQt.h: 1854 18552011-02-24 Alexis Menard <alexis.menard@openbossa.org> 1856 1857 Reviewed by Andreas Kling. 1858 1859 [Qt] tst_QWebView::setPalette(activeFG) fails 1860 https://bugs.webkit.org/show_bug.cgi?id=55029 1861 1862 This time it should be the proper fix. The window needs to be shown before we 1863 call activateWindow() otherwise there is no active windows for the application. 1864 1865 * tests/qwebview/tst_qwebview.cpp: 1866 (tst_QWebView::setPalette): 1867 18682011-02-24 Andras Becsi <abecsi@webkit.org> 1869 1870 Reviewed by Laszlo Gombos. 1871 1872 [Qt] MinGW build fails to link 1873 https://bugs.webkit.org/show_bug.cgi?id=55050 1874 1875 Prepend the libraries of subcomponents instead of appending them 1876 to fix the library order according to the dependency of the libraries 1877 1878 * QtWebKit.pro: prepend libraries in the correct order 1879 18802011-02-23 Alexis Menard <alexis.menard@openbossa.org> 1881 1882 Reviewed by Ariya Hidayat. 1883 1884 [Qt] tst_QWebView::setPalette(activeFG) fails 1885 https://bugs.webkit.org/show_bug.cgi?id=55029 1886 1887 Attempt to make the test more robust. By investigating with the bot virtual machine 1888 I discovered that the activation can take some time. In this patch we make sure that 1889 the active window we want to have is the same as the QApplication. 1890 1891 * tests/qwebview/tst_qwebview.cpp: 1892 (tst_QWebView::setPalette): 1893 18942011-02-23 Alexis Menard <alexis.menard@openbossa.org> 1895 1896 Reviewed by Dan Bernstein. 1897 1898 [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases 1899 http://trac.webkit.org/changeset/79167 refactored the way the bound size of 1900 the frame is handled. A new API setBoundsSize was added, we need to call it 1901 in addition to setFrameRect. I could call setBoundSize after setFrameRect but 1902 I thought It would be more elegant to use the resize method. 1903 1904 * Api/qwebpage.cpp: 1905 (QWebPage::setViewportSize): 1906 19072011-02-22 Fabrizio Machado <fabrizio.machado@nokia.com> 1908 1909 Reviewed by Laszlo Gombos. 1910 1911 [Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool 1912 https://bugs.webkit.org/show_bug.cgi?id=54976 1913 1914 Test not needed. 1915 1916 * WebCoreSupport/InspectorClientQt.cpp: 1917 19182011-02-22 Alexis Menard <alexis.menard@openbossa.org> 1919 1920 Reviewed by Andreas Kling. 1921 1922 [Qt] QWebView ignores a palette set with QWebView::setPalette() 1923 https://bugs.webkit.org/show_bug.cgi?id=31742 1924 1925 Test case to check that the palette sets on the QWebView is taken 1926 into account. 1927 1928 * tests/qwebview/tst_qwebview.cpp: 1929 (tst_QWebView::setPalette_data): 1930 (tst_QWebView::setPalette): 1931 19322011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com> 1933 1934 Reviewed by Alexey Proskuryakov. 1935 1936 Drop the language tag part from the User Agent string 1937 https://bugs.webkit.org/show_bug.cgi?id=54560 1938 1939 * Api/qwebpage.cpp: 1940 (QWebPage::userAgentForUrl): 1941 1942 * tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange 1943 test. 1944 19452011-02-22 Chang Shu <cshu@webkit.org> 1946 1947 Reviewed by Csaba Osztrogonác. 1948 1949 [Qt] editing/deleting/5408255.html fails 1950 https://bugs.webkit.org/show_bug.cgi?id=54964 1951 1952 Move WebCore resource file to QtWebKit since they are referred in WebKit. 1953 1954 * QtWebKit.pro: 1955 19562011-02-22 Andras Becsi <abecsi@webkit.org> 1957 1958 Reviewed by Csaba Osztrogonác. 1959 1960 [Qt] Redesign the build system 1961 https://bugs.webkit.org/show_bug.cgi?id=51339 1962 1963 Move inspector's resource files into the final build step to fix the layout test regression. 1964 1965 * QtWebKit.pro: Add inspector's reaource files. 1966 19672011-02-22 Andras Becsi <abecsi@webkit.org> 1968 1969 Reviewed by Laszlo Gombos. 1970 Rubber-stamped by Csaba Osztrogonác. 1971 1972 [Qt] Redesign the build system 1973 https://bugs.webkit.org/show_bug.cgi?id=51339 1974 1975 The patch landed in r79320 didn't contain the cleanup 1976 which was already addressed in the last attachment. 1977 1978 * QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri. 1979 19802011-02-22 Andras Becsi <abecsi@webkit.org> 1981 1982 Reviewed by Laszlo Gombos. 1983 1984 [Qt] Redesign the build system 1985 https://bugs.webkit.org/show_bug.cgi?id=51339 1986 1987 Part 2. 1988 1989 Build WebCore as a static library, compile the WebKit API and WebKit2 API 1990 in a final step and link to WebKit2, WebCore and JSC libraries to fix 1991 linking issues resulting from stripped away symbols. 1992 1993 * QtWebKit.pro: Added. 1994 Project file for the final build step. 1995 19962011-02-17 Ryosuke Niwa <rniwa@webkit.org> 1997 1998 Reviewed by Kent Tamura. 1999 2000 Rename Position::node() to Position::deprecatedNode() 2001 https://bugs.webkit.org/show_bug.cgi?id=54622 2002 2003 Replaced the call to node() by a call to containerNode() because the returned node is 2004 used to determine whether or not the selected contents are editable and such a check 2005 must be done against the container node. 2006 2007 * WebCoreSupport/EditorClientQt.cpp: 2008 (WebCore::EditorClientQt::handleKeyboardEvent): 2009 20102011-02-19 Charlie Reis <creis@chromium.org> 2011 2012 Reviewed by Mihai Parparita. 2013 2014 Ensure loading has stopped in HistoryController::goToItem 2015 https://bugs.webkit.org/show_bug.cgi?id=54517 2016 2017 Add a FrameLoaderClient callback for whether to stop loading before goToItem. 2018 2019 Test: http/tests/navigation/forward-to-fragment-fires-onload.html 2020 2021 * WebCoreSupport/FrameLoaderClientQt.cpp: 2022 (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added. 2023 * WebCoreSupport/FrameLoaderClientQt.h: 2024 20252011-02-18 Fabrizio Machado <fabrizio.machado@nokia.com> 2026 2027 Reviewed by Eric Seidel. 2028 2029 Remove reduntant checks. 2030 https://bugs.webkit.org/show_bug.cgi?id=54764 2031 2032 2033 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 2034 (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): 2035 * WebCoreSupport/NotificationPresenterClientQt.cpp: 2036 (WebCore::NotificationPresenterClientQt::toPage): 2037 20382011-02-18 Csaba Osztrogonác <ossy@webkit.org> 2039 2040 Unreviewed. 2041 2042 [Qt] Buildfix for platforms with geolocation disabled. 2043 2044 * Api/qwebpage.cpp: Add the missing guard. 2045 20462011-02-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> 2047 2048 Reviewed by Kenneth Rohde Christiansen. 2049 2050 [Qt] Implement client based geolocation for qtport 2051 https://bugs.webkit.org/show_bug.cgi?id=42629 2052 2053 Implements client based geolocation for qtwebkit. 2054 New client based geolocation contains permission API's as well, 2055 so removed the implementation from ChromeClientQt.cpp. 2056 2057 * Api/qwebpage.cpp: 2058 (QWebPagePrivate::QWebPagePrivate): 2059 * WebCoreSupport/ChromeClientQt.cpp: 2060 * WebCoreSupport/ChromeClientQt.h: 2061 (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame): 2062 (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame): 2063 * WebCoreSupport/GeolocationClientQt.cpp: Added. 2064 (WebCore::GeolocationClientQt::GeolocationClientQt): 2065 (WebCore::GeolocationClientQt::~GeolocationClientQt): 2066 (WebCore::GeolocationClientQt::geolocationDestroyed): 2067 (WebCore::GeolocationClientQt::positionUpdated): 2068 (WebCore::GeolocationClientQt::startUpdating): 2069 (WebCore::GeolocationClientQt::stopUpdating): 2070 (WebCore::GeolocationClientQt::setEnableHighAccuracy): 2071 (WebCore::GeolocationClientQt::requestPermission): 2072 (WebCore::GeolocationClientQt::cancelPermissionRequest): 2073 * WebCoreSupport/GeolocationClientQt.h: Added. 2074 (WebCore::GeolocationClientQt::lastPosition): 2075 20762011-02-10 Luiz Agostini <luiz.agostini@openbossa.org> 2077 2078 Reviewed by Adam Roben. 2079 2080 HTML5 <details> and <summary>: localized text 2081 https://bugs.webkit.org/show_bug.cgi?id=54260 2082 2083 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to 2084 provide the default label to be used by a <details> tag that has no <summary> child. 2085 2086 * WebCoreSupport/WebPlatformStrategies.cpp: 2087 (WebPlatformStrategies::defaultDetailsSummaryText): 2088 * WebCoreSupport/WebPlatformStrategies.h: 2089 20902011-02-17 Hui Huang <hui.2.huang@nokia.com> 2091 2092 Reviewed by Laszlo Gombos. 2093 2094 The URL of HTML5 Video Element is percent encoded at websites such as youtube. 2095 It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes 2096 the HTTP GET request for the video to be rejected by the service provider. 2097 https://bugs.webkit.org/show_bug.cgi?id=53973. 2098 2099 The bug is fixed by constructing QUrl from the encoded URL in 2100 MediaPlayerPrivateQt::commitLoad. 2101 2102 New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with 2103 HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId 2104 is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt. 2105 A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test 2106 is skipped if Qt Multimedia is not available. 2107 2108 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: 2109 (DumpRenderTreeSupportQt::mediaContentUrlByElementId): 2110 * WebCoreSupport/DumpRenderTreeSupportQt.h: 2111 * tests/qwebpage/tst_qwebpage.cpp: 2112 (tst_QWebPage::loadHtml5Video): 2113 * tests/tests.pri: 2114 21152011-02-17 Andreas Kling <kling@webkit.org> 2116 2117 Reviewed by Antti Koivisto. 2118 2119 [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests 2120 https://bugs.webkit.org/show_bug.cgi?id=49216 2121 2122 * tests/qwebframe/tst_qwebframe.cpp: 2123 2124== Rolled over to ChangeLog-2011-02-16 == 2125
