• Home
  • Line#
  • Scopes#
  • Navigate#
  • Raw
  • Download
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 
5 #include "chrome/browser/command_updater.h"
6 
7 #include "base/compiler_specific.h"
8 #include "chrome/browser/command_observer.h"
9 #include "chrome/browser/command_updater_delegate.h"
10 #include "testing/gtest/include/gtest/gtest.h"
11 
12 class FakeCommandUpdaterDelegate : public CommandUpdaterDelegate {
13  public:
ExecuteCommandWithDisposition(int id,WindowOpenDisposition)14   virtual void ExecuteCommandWithDisposition(int id,
15                                              WindowOpenDisposition) OVERRIDE {
16     EXPECT_EQ(1, id);
17   }
18 };
19 
20 class FakeCommandObserver : public CommandObserver {
21  public:
FakeCommandObserver()22   FakeCommandObserver() : enabled_(true) {}
23 
EnabledStateChangedForCommand(int id,bool enabled)24   virtual void EnabledStateChangedForCommand(int id, bool enabled) OVERRIDE {
25     enabled_ = enabled;
26   }
27 
enabled() const28   bool enabled() const { return enabled_; }
29 
30  private:
31   bool enabled_;
32 };
33 
TEST(CommandUpdaterTest,TestBasicAPI)34 TEST(CommandUpdaterTest, TestBasicAPI) {
35   FakeCommandUpdaterDelegate delegate;
36   CommandUpdater command_updater(&delegate);
37 
38   // Unsupported command
39   EXPECT_FALSE(command_updater.SupportsCommand(0));
40   EXPECT_FALSE(command_updater.IsCommandEnabled(0));
41   // FakeCommandUpdaterDelegate::ExecuteCommand should not be called, since
42   // the command is not supported.
43   command_updater.ExecuteCommand(0);
44 
45   // Supported, enabled command
46   command_updater.UpdateCommandEnabled(1, true);
47   EXPECT_TRUE(command_updater.SupportsCommand(1));
48   EXPECT_TRUE(command_updater.IsCommandEnabled(1));
49   command_updater.ExecuteCommand(1);
50 
51   // Supported, disabled command
52   command_updater.UpdateCommandEnabled(2, false);
53   EXPECT_TRUE(command_updater.SupportsCommand(2));
54   EXPECT_FALSE(command_updater.IsCommandEnabled(2));
55   // FakeCommandUpdaterDelegate::ExecuteCommmand should not be called, since
56   // the command_updater is disabled
57   command_updater.ExecuteCommand(2);
58 }
59 
TEST(CommandUpdaterTest,TestObservers)60 TEST(CommandUpdaterTest, TestObservers) {
61   FakeCommandUpdaterDelegate delegate;
62   CommandUpdater command_updater(&delegate);
63 
64   // Create an observer for the command 2 and add it to the controller, then
65   // update the command.
66   FakeCommandObserver observer;
67   command_updater.AddCommandObserver(2, &observer);
68   command_updater.UpdateCommandEnabled(2, true);
69   EXPECT_TRUE(observer.enabled());
70   command_updater.UpdateCommandEnabled(2, false);
71   EXPECT_FALSE(observer.enabled());
72 
73   // Remove the observer and update the command.
74   command_updater.RemoveCommandObserver(2, &observer);
75   command_updater.UpdateCommandEnabled(2, true);
76   EXPECT_FALSE(observer.enabled());
77 }
78 
TEST(CommandUpdaterTest,TestObserverRemovingAllCommands)79 TEST(CommandUpdaterTest, TestObserverRemovingAllCommands) {
80   FakeCommandUpdaterDelegate delegate;
81   CommandUpdater command_updater(&delegate);
82 
83   // Create two observers for the commands 1-3 as true, remove one using the
84   // single remove command, then set the command to false. Ensure that the
85   // removed observer still thinks all commands are true and the one left
86   // observing picked up the change.
87 
88   FakeCommandObserver observer_remove, observer_keep;
89   command_updater.AddCommandObserver(1, &observer_remove);
90   command_updater.AddCommandObserver(2, &observer_remove);
91   command_updater.AddCommandObserver(3, &observer_remove);
92   command_updater.AddCommandObserver(1, &observer_keep);
93   command_updater.AddCommandObserver(2, &observer_keep);
94   command_updater.AddCommandObserver(3, &observer_keep);
95   command_updater.UpdateCommandEnabled(1, true);
96   command_updater.UpdateCommandEnabled(2, true);
97   command_updater.UpdateCommandEnabled(3, true);
98   EXPECT_TRUE(observer_remove.enabled());
99 
100   // Remove one observer and update the command. Check the states, which
101   // should be different.
102   command_updater.RemoveCommandObserver(&observer_remove);
103   command_updater.UpdateCommandEnabled(1, false);
104   command_updater.UpdateCommandEnabled(2, false);
105   command_updater.UpdateCommandEnabled(3, false);
106   EXPECT_TRUE(observer_remove.enabled());
107   EXPECT_FALSE(observer_keep.enabled());
108 }
109