11. A single AtomISP driver needs to be implemented to support both BYT and 2 CHT platforms. The current driver is a mechanical and hand combined merge 3 of the two using an ifdef ISP2401 to select the CHT version, which at the 4 moment is not enabled. Eventually this should become a runtime if check, 5 but there are some quite tricky things that need sorting out before that 6 will be possible. 7 82. The file structure needs to get tidied up to resemble a normal Linux 9 driver. 10 113. Lots of the midlayer glue. unused code and abstraction needs removing. 12 133. The sensor drivers read MIPI settings from EFI variables or default to the 14 settings hard-coded in the platform data file for different platforms. 15 This isn't ideal but may be hard to improve as this is how existing 16 platforms work. 17 184. The sensor drivers use the regulator framework API. In the ideal world it 19 would be using ACPI but that's not how the existing devices work. 20 215. The AtomISP driver includes some special IOCTLS (ATOMISP_IOC_XXXX_XXXX) 22 that may need some cleaning up. 23 246. Correct Coding Style. Please don't send coding style patches for this 25 driver until the other work is done. 26 277. The ISP code depends on the exact FW version. The version defined in 28 BYT: 29 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c 30 static const char *release_version = STR(irci_stable_candrpv_0415_20150521_0458); 31 CHT: 32 drivers/staging/media/atomisp/pci/atomisp2/css/sh_css_firmware.c 33 static const char *release_version = STR(irci_ecr-master_20150911_0724); 34 35 At some point we may need to round up a few driver versions and see if 36 there are any specific things that can be done to fold in support for 37 multiple firmware versions. 38 39 40Limitations: 41 421. Currently the patch only support some camera sensors 43 gc2235/gc0310/0v2680/ov2722/ov5693/mt9m114... 44 452. To test the patches, you also need the ISP firmware 46 47 for BYT:/lib/firmware/shisp_2400b0_v21.bin 48 for CHT:/lib/firmware/shisp_2401a0_v21.bin 49 50 The firmware files will usually be found in /etc/firmware on an Android 51 device but can also be extracted from the upgrade kit if you've managed 52 to lose them somehow. 53 543. Without a 3A libary the capture behaviour is not very good. To take a good 55 picture, you need tune ISP parameters by IOCTL functions or use a 3A libary 56 such as libxcam. 57 584. The driver is intended to drive the PCI exposed versions of the device. 59 It will not detect those devices enumerated via ACPI as a field of the 60 i915 GPU driver. 61 625. The driver supports only v2 of the IPU/Camera. It will not work with the 63 versions of the hardware in other SoCs. 64 65